labofsahil/github-event-dataset-2012 huggingface dataset:
@goodok I get what you're saying and that's exactly being done in this line. 
On the other hand, in the above lines (12 to 15), I'm trying to describe to the user what's happening in this line and what exactly it is that 'e' represents. 
It's like:
  >>> print "Adding two numbers: "
  # Below, we want to print 2 & 3 as characters, and not as the numbers themselves, else the output will be 5, which is not what we want ( that's what   lines 12 through 15 do.)
  >>> print " 2 + 3 "     
  #Below we do the actual addition ( analogous to line no. 17 in our code)
  >>> print 2 + 3                #with 5 as output
The in-code comment doesn't give any constructive explanation, so let's just remove it. Your explanation here is fine and since this is a different issue altogether, we don't need to address it in this PR.
The original Wester test is that N(1,7) = 0.142857_repeated. Do we have a way to represent a repeating decimal number other than some fancy infinite sum? If not, it should raise a non-implemented error.
I guess you only need 4 tests: 1 with no free symbols, 1 with free symbols (none non-commutative), and 1 with free symbols that contain a non-commutative and 1 with a non-commutative object and no non-commutative symbols. Regarding the last suggested test: if the sum contains a non-commutative object then the approach you have taken will fail since you only look at the symbols. It is perhaps better to use _mask_nc and then inspect the replacements and non-commutative symbols. (The improved _mask_nc is part of #1204 .)
On Mon, Apr 30, 2012 at 8:55 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>> @@ -207,6 +215,9 @@ class sign(Function):
>>
>>      nargs = 1
>>
>> +    def doit(self):
>> +        return self.args[0] / Abs(self.args[0])

This is one of those instances where, since you are trying to evaluate
it rather than returning sign(arg), you should probably use equals to
check for equivalence to zero or else don't return a/abs(a) for
sign(a) if a.is_positive is None.
This should not stay here, I guess ;)
I guess this change was rejected so no need to worry about it.

@lubosdz can you exclude it?
Classes that implement ILogFilter will be attached to → You can attach classes that implement ILogFilter to
The formhandler is always using %Y-%m-%d. So we have to transform the after submit value to have it in the ifFormat.
Thinking about it now, it may make sense to leave these constants public. This way external clients of the AppBlade library would be able to interpret the NSError objects that get generated with these values.
Yeah same comment here. It's actually creating a tab delimited file.
The serialized form probably doesn't contain these overheads right? Map/lists are serialized using the serde to cache.
it's configuration... after all... dev uses | that's what i used for dev/test
What does `It should not get services` mean?
mongos or mongod
`newquery` already false?
It seems that doing this here would hide a bug where the plugin doesn't properly create the Mash itself.
This code will work with only one timezone selector per page. A better solution might be to take the element(s) as parameters.
fixed :(
Put var here.
`SUCESS`?
fclose($temp) per http://us.php.net/tmpfile.
So that would only be if it were to get an ack for it's ack.
From https://npmjs.org/doc/json.html#X-Version-Ranges I don't think that ">= 0.6.x" is a valid way to specify a version. It should either be "0.6.x" or ">= 0.6.0". From my experiments with Heroku and Nodejitsu I have seen that "0.6.x" always works but ">= 0.6.0" caused problems, so I would recommend using "0.6.x".
Thanks for the feedback. In retrospect, line185-193 should probably be removed completely. Agreed ?
Yes, I thought that's what it's for. But why would we want to see diff of binary files? It will be mostly garbage. Maybe sometimes not in case of PDF, but surely DOCX, which is a ZIP file.

And I'm also asking because I didn't find it in the documentation, so I assume it's an "external diff driver", but we don't have it defined.
http://www.kernel.org/pub/software/scm/git/docs/gitattributes.html
Please remove console logs before commiting this code.
I think we should look at how many places use these functions in "analysis/cartography" - they aren't doing any analysis/cartography, more like utility functions for working with a cube. If it is the case that they are limited to plotting, then I think we should look at moving them there and making them private (or inline).
Wherever this functionality ends up, it should probably by public, not private.
Use kwargs here rather than typing out the whole shebang each time.
second param should be the default mime type you want to return if one is not found
This seems like premature optimization, but would it be better just to allocate the right size array and copy the ids into it? There's a fair bit of collection magic here and below on 413.
one blank
I think this should have been:

+        if ( ++ eventLoop->events_offset >= eventLoop->setsize )
```javascript
var hasFilterer = window.brunch && window.brunch.test && window.brunch.test.filterer;
var valid = hasFilterer ? window.brunch.test.filterer(path) : true;
if (valid) window.require('#{path}');
```
should we cache the test files array? and if, where?
'|' within an XPath predicate means 'AND'. In the predicate, '|' separates the individual nodes and attributes that we are wanting to extract and then build within our XML document. So this is the logical place to remove the head from the predicate after extracting an attribute or a node.
Please don't separate if body and else body with whitespace
Good to know that this is how to add error messages to the google test output
this refers to content below "To display multiple fields on the same line...."
title2 not title3 :)
<pre>In facts, we are going to change the main data source (from kvs to db) and you saw that this implied very big changes and big effort. Thus, to separate those concerns is not a bad idea.</pre>

I don't understand your point. We're not going to change the primary source of data from the KVS to the DB; we've already done this in the nhlib-integration branch (we now only use Redis for progress counters and some other lightweight data). And it's not going to change any time soon. Would you like me to explain the history of why we introduced a RDBMS into our project for persistent storage (instead of using Redis for caching and XML for persistent storage)? Can you please tell me, in your imagination, what do you think would replace a relational database as storage for this information? And more importantly, in what timeframe do you imagine that these changes would happen?

And also: Regarding switch to using the DB instead of a KVS, this was not the bulk of the changes that we've written. So while this was _one_ of the changes we made in the new calculator architecture, this is rather minor compared to everything else (changes to inputs, a BRAND NEW hazard library, changes in output formats, changes in the approach to distributing calculations, etc.), so your concern doesn't really carry any weight. Changing the data access was quite simple. If you consider the history of the project, the changes in data storage/access merely finished up the transition away from using Redis in this strange way. We didn't introduce the database until almost a year after the development of oq-engine began. It's important to understand this history.
ordered aggregate failed in 8.4 and 4.0.
We (@avital and I) weren't sure how this  and the next line help. If you are required to run as port 80, then why do you need to do anything else... isn't just running with -p 80 enough?

Also, if the issue is that port 80 and localhost do not work, then instead of having these instructions be step 6 of a long list, the template should check to see if the URL is an URL that QQ would accept. If it is, no special instructions are needing. If it isn't, it should give ONLY the instructions to run as a better URL and tell you to try to configure again once you've fixed it.  ie, it should never both tell you "reconfigure your port" and "here's how to sign up on QQ".
Could this be made into a big red warning box or something like that?
I was thinking about adding pre- and post-filters just like a HTTP stack, and use a post-filter to unwrap the future, but figured that I didn't want to spend time to write tests for a filter feature that didn't help me with anything else.
This could use a docstring explaining what it's for and why we need a custom one instead of the standard one.
ok i've removed this everywhere... ;)
Why not extend the hack above as in 

```
if (oc_debug !== true || typeof console === 'undefined' || typeof console.log === 'undefined') {
```
Docstring should indicate this sets the object timeout period
This will dog performance pretty badly. i'll merge and then tweak this
No, the problem with qtconsole is that the terminal size isn't reflective of the window size so I'm skipping that check here and set it to some default.
I don't know of an easy way for the ipython shell to query the window for geometry.
Maybe want to revert the default font.size at the end of the function?
I don't even remember why i was doing this, but noted.
Done on 172fb79
I totaly didn't notice description. 

I think all links should open in new window, so we should remove 'window'  field in model.
With this we can change if self.window ugliness.
Done. I also restructured a bunch of the code splitting it into separate functions. I think it's easier to follow now.
i'd rather have `job max attempts`, the random underscore is a little weird
I think this is fine as it is. This is definitely a better solution than changing `load`'s behaviour.
I'll probably switch it to something contained (with a count method and a get-by-index method).
Should the command be added to the working set menu? It should work there.
Good catch! I was adding this for AttrHints which currently is invoked by a space character.
Re the menus: move line up/down feels more related to Duplicate.  In fact, now that this menu section is getting longer it feels weird to have Comment/Uncomment grouped in with more generic editing commands.  How about reordering it so the menu looks like this?

...
Duplicate
Move Line(s) Up
Move Line(s) Down
---divider---
Comment/Uncomment Lines
---divider---
Use Tab Characters
Linebreaks between ordered list items would make this info easier to read, especially since we hope to someday use JSDoc (or something similar) to generate documentation from these comments.
This is a bit edge-casey, but I would try the explicit .git subfolder first, and then try it as a submodule of brackets-app after. The reason is that for non-committers, we're actually suggesting that they not get brackets as a submodule of brackets-app, but rather manually git clone their own fork of brackets. I can imagine that there will be some cases where someone might first get brackets as a submodule, then later delete it and git clone their fork once they decide they want to do some work on it. In that case, there will be both a (stale) modules/brackets folder inside the brackets-app .git folder, and a (correct) .git folder inside brackets. So I think we should look in the latter first.
I'm not sure. That code went through several iterations as I recall, but right now it seems like the difference of the two offset() calls should always be 0 at this point. I filed another bug on cleaning up some issues with MRIE...we could add this to the list.

Sent from tiny phone

On Nov 27, 2012, at 12:45 AM, "Peter Flynn" <notifications@github.com<mailto:notifications@github.com>> wrote:


In src/extensions/default/InlineColorEditor/InlineColorEditor.js:

> @@ -162,6 +166,13 @@ define(function (require, exports, module) {
>              this._color = colorString;
>          }
>      };
> +
> +    /**
> +     * Update the width of the inline editor based on the host editor's width.
> +     */
> +    InlineColorEditor.prototype._handleHostResize = function () {
> +        this.$htmlContent.css("min-width", this.hostEditor.getScrollerElement().scrollWidth + "px");


I'm a little confused why MultiRangeInlineEditor uses a more complex formula than this. It looks like they should both yield the same value to me: the width of the gutter plus the full width of the text. Is MultiRangeInlineEditor's code just overcomplicated?

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/2222/files#r2232256>.
This logic doesn't look right...  If matches[3] is not .htm/.html, fileName is set to "index.html" above, so this replace here will do nothing. I think you want to replace matches[2] with fileName (or "index.html") instead.
I think in general we use the present form of the verb instead of the past for event names--e.g. "change" instead of "changed". Not sure if we're consistent everywhere though.
good point. Fixed
This is the part where the new behavior might actually be wrong. If the document is dirty (in the original sense--i.e., there are unsaved changes), we should set `useCache` to false even if the disk timestamps match (because the user has modified the document in memory even though the file hasn't changed on disk). I think this might be the same thing Peter was pointing out, but I'm not totally sure.

We probably need a new unit test to make sure that changes are picked up from the in-memory version the second time you try it (the existing one only checks the first time you have unsaved changes, which wouldn't catch the bug here, if I'm understanding the problem correctly, because nothing will have been cached in that case).
new externalized string ``JSLint disabled or not working for the current file``
Shouldn't InlineImageViewier.onAdded() call up to the super method so that it gets proper width resizing?
Is this the cleanest way to temporarily disable the beautify plugin? How about a `this.enabled` field and check?
Ah, standards. I suspect that both notations needs to be supported. How did you try to import the data?
Something tells me you are using tabs for indentation?
Well that is an option too, you should mention it in our next class, I think it would be excepted quite good.
it would be also nice to inform the user about the available options rather than tell her to run `jekyll --help`.
There's nothing wrong with just including Tooltip here, unless you've changed something that prevents it from working properly. I'd rather keep it how it was than use `window.Butter`.
What does `map = map = ...` mean?  Should be `map = buildMap( ... )`
Why not let the browser cache this file?  With icons we load as separate files, why not here?
IMO there's no reason to involve javascript here, your'e just adding lines. Have the default for`. off` = `visibility:none` with no transition.

In fact, isn't it already like that?
same here, does this need to be created inline?
Well, classList is obviously much much easier to use. The only problem browser for what we are supporting is IE9 and we have a ticket about dealing with this. Part of it is that it needs to be in our shims, the other is that it needs to be included on export as well.

https://webmademovies.lighthouseapp.com/projects/65733-popcorn-maker/tickets/1860-ie9-shims-need-to-exist-on-exported-projects-not-just-in-butter#ticket-1860-2
Stack shall be evaluated only for the amount of the arguments for the hsbw. Also, evaluation will drop the precision of the number, e.g. 240 1024 'div' will be evaluated to 0. Calculated width and lsb are only used in font metrics, not sure if hmoveto will need more precision (e.g. for accent chars)
Yeah, sorry about this. I merged my search branch changes back into master, and there were a couple of conflicts that I had to address in the list templates. I followed the normal resolution process (e.g. http://git-scm.com/book/en/Git-Branching-Basic-Branching-and-Merging#Basic-Merge-Conflicts) but it ended up creating a commit with ALL those changes inside.

ryanpitts/source@c117af642317a079bf00d9b72795ff7d25370729

Not sure if I should have done something differently to avoid this.
For future reference, please prefer $( ) syntax to backticks (it allows nesting and I think reads better, so I use it everywhere.)
should be `didNotAnswer`, same below.
Perhaps we should, in parallel to working around the bug, file a bug on the GHC Trac?
This should change too I assume?
"Probíhá prohledávání souborů %s..." - v tomhle konkrétním případě vynechat "probíhá", není to sice chyba, ale před podstatným jménem slovesným je považované za nadbytečné
shadow back e products_list beshe
That's in fact intentional trick for adding documentation :D
Avoid using Single. Use something more defensive like FirstOrDefault and check for null.
hom**o**genous
I think `val.flatten` does everything this does (with the exception of converting ints to floats), in addition to supported n-dimensional arrays.
One problem with `wraps()` is that it does *not* copy the argument signature of the wrapped function. Unfortunately there's no good way around that.  There are a few hacks that enable it but I don't think they're very reliable.  So I'm not saying you should change this. It's just important that any wrapped function have good documentation :/
Update comment: `ModIdx` to `ModSrcTgt`
@diapolo, I do think it's important that you understand: let's say you have the  following code:

    if (a) {
        if(b) {
           doActionAB();
        }
    } else if (c) {
        doActionC();
    }

If you make a truth table for that, you get:

    a b c
    0 0 0    N/A
    0 0 1    doActionC
    0 1 0    N/A
    0 1 1    doActionC
    1 0 0    N/A
    1 0 1    N/A
    1 1 0    doActionAB
    1 1 1    doActionAB

Let's say you "optimize" it to 

    if (a && b) {
       doActionAB();
    } else if (c) {
        doActionC();
    }

Then the truth table becomes:

    a b c
    0 0 0    N/A
    0 0 1    DoActionC
    0 1 0    N/A
    0 1 1    doActionC
    1 0 0    N/A
    1 0 1    doActionC
    1 1 0    doActionAB
    1 1 1    doActionAB

So, now, for a,!b,c you're *also* triggering doActionC. 

In the case of this code, it would mean that a PushGetBlocks could be called when, during import, a node sends us a "inv" with a block that we already have. I'm not sure whether this is desired behavior or not, but I don't think so as Sipa's patch seems like a "ignore the inv request mechanism while importing".
Ok, yes, that makes sense.
From what I remember mark  does not like this. I'm fine with it though
Oh, right, nevermind - I was looking at the parsed output, and thinking that was the data we were getting for some reason.
That makes a lot of sense, doing this now.
Wrm die check? Kan het voorvallen dat profiles niet installed is en ze toch hier in deze actie komen?
Good catch, I'm glad I'd put that note in... I'd forgotten about it.

Let me work on it a bit, we'll see how bad it is.  I'd say that since this PR is blocking everything else, if I don't finish it very quickly, let's move without.  It can always be added later.

But I'll give it a try.
While you are at it, do you want to reduce this indent to 4?  8 has always seemed like too much to me.
@takluyver I also write a file here as well.
please remove the dependency; we are not adding a 250k+ dep for Base64.  If there's a problem with Base64, enunciate it specifically, raise an issue and fix it, or make an impl that fixes it
what's the license model of vim25?  can we distribute it?  check cloudstack-devl mailing list archives
I remember that too. I must have rebased it in when I wasn't paying attention. Anyway, it's fixed now. I :purple_heart: deleting code!
I don't know why, but this seems backwards to me; I'd expect attachment to happen at the parent `parent.append(child)`. Probably because that's how lists work.
Small change in wording: 'on the' (right?)
That's the style I use when chaining jQuery calls, looks much better.
Actually, I don't think you actually have to add that. There *should* be tests that make sure products are getting added right elsewhere.
@AdrianGaudebert where is it done already? 

@twobraids I shall extend the `XXX` comment with some more reasoning instead of just venting.
I'd guess even more preferably the XML file could be removed altogether and "--run jsmodules/startup/InterestManagerDialog.js" would be used.
Just noting that the Tundra code convention uses method names that start with an uppercase variable (but don't bother going on a seach-replace spree to change these now, it's not worth the developer time).
Comme dit ci-dessus, en faisant la modif sur `Environment.directory` ca ne fait rien, la css est toujours générée dans `c2cstats/static/gen` et `_cache/assets` est vide.

En utilisant `assets.directory = os.path.join(CACHE_DIR, 'assets')` ca plante avec ce message: (les sources doivent aussi être dans `_cache/assets`)
```
BuildError: [Errno 2] Aucun fichier ou dossier de ce type: '/home/simon/Dev/c2c/c2cstats/_cache/assets/css/bootstrap.min.css'
```

La prochaine version de webasssets aura un paramètre supplémentaire pour dire où sont les sources, ca devrait résoudre le problème:
https://webassets.readthedocs.org/en/latest/environment.html#webassets.env.Environment.load_path
Is similar to a constructor? If so, I'd say we use `__construct` instead.
You didnt fix the real issue. With ur current implementation, the hostname pattern is still only set on some routes!
need a trailing dot.
You didn't make $name optional. Don' you think it might be handy?
Furthermore you still don't handle inexistent offsets. This can create inconsistencies and unexpected outcomes as a user can create non-sequential `elements` indexes. But in `replace` you assume they are sequential.
Travis in PHP 5.3.3 only says "Fatal error: Can't inherit abstract function Symfony\Component\Routing\Matcher\UrlMatcherInterface::match() (previously declared abstract in Symfony\Component\Routing\Matcher\RequestMatcherInterface)"
So its not possible to declare the method again in php 5.3.3? Then I would simply need to remove the declaration it.
this array is not used
The following three lines can be removed if the `$placeholderValue` closure is adapted.
This appears to duplicate `Form::getTypes()`. Is there any reason you're not just calling that?
In demo mode workflowId could be <small|large> and we get rid of localdata=small. I don't think we need none|anonymous for anything. Also we don't want to have spaces in qs values.
That is fine, please comment that after you pull. It would be difficult to
comment that section on my fork as we build that artifact.

On another note, I've seen a few posts where people are interested to
contribute to Finagle but are confused about sbt and eclipse. I checked in
non intrusive support to eclipsify finagle-core with "sbt eclipse". I think
it would be beneficial to pull and include a note on the main Finagle
Readme. I believe the easier for someone to get the project open in an IDE
the more likely they will become interested in contributing.



On Mon, Apr 23, 2012 at 5:12 PM, marius a. eriksen <
reply@reply.github.com
> wrote:

> >    val protobufProject = project(
> >      "finagle-protobuf", "finagle-protobuf",
> >      new ProtobufProject(_), coreProject)
> > -*/
>
> let's keep this commented out for the time being— i do'nt want to publish
> artifacts just yet.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/twitter/finagle/pull/81/files#r723757
>
In terms of naming, this is not really correct. Type BIT represents a bitmap of 1 or more bits. It's really an integer type of varying length, and only in the minimal case of BIT/BIT(1) is it potentially a boolean.
Here is my understanding of your design of the logging facility: use getEnvironment().fatal for fatal and use a per-class logger for everything else. It that correct? If so, maybe we should leave a comment here to make the rule explicit.
use `intValue` for `int` and `integerValue` for `NSInteger`
we decided this was another job.
heh, why not:  
post.originalPostID ? REPLY_LABEL_WIDTH : UPDATE_LABEL_WIDTH;
We should probably use /etc/gemrc
Interestingly enough, since it's not a view I wonder if the helper will be available to it?
Not sure going through `guest` factory is necessary here. Maybe reduce to `'guest1@example.com, guest2@example.com`?
Hrm. Doesn't ohai give us a way to query installed packages on a system? I
suspect we could do this in a very chef way.

Sounds good =)

Thanks
-Miah


On Sat, Apr 21, 2012 at 9:18 AM, Sean Porter <
reply@reply.github.com
> wrote:

> > @@ -34,6 +34,9 @@
> >  default['redis']['config']['pidfile'] = "/var/run/redis.pid"
> >  default['redis']['config']['rdbcompression'] = "yes"
> >  default['redis']['config']['timeout'] = "300"
> > +default['redis']['config']['slowlog'] = false
>
> Would need to hit the pkg manager of choice to determine the version
> installed. I can test this cookbook on a variety of Ubuntu releases to see
> if there are any other configuration issues. We can then collect these
> attributes at the bottom of the default attributes file w/ a little
> documentation.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CXInc/chef-redis/pull/8/files#r717362
>
It's up to you. I set up git on a new system and I noticed that the
recommended method is now the https one.

2012/6/15 David Coeurjolly <
reply@reply.github.com
>

> > @@ -65,13 +70,13 @@ Once you have fork the initial DGtal repository,
> >  you can clone your fork to have a local copy of your own (remote) copy
> of DGtal:
> >
> >  @code
> > -git clone git@github.com:yourlogin/DGtal.git
> > +git clone https://github.com/yourlogin/DGtal.git
>
> Not sure if it is a good idea to promote https compared to SSH (for
> read/write access): https asks you your login/passwd when pushing whereas
> github provides a secure way to skip this point with SSH-key publishing in
> your account.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/DGtal-team/DGtal/pull/378/files#r993333
>
Please add spaces betwen arguments everywhere. 

http://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements
Maybe use constants for 'g', 'c', etc?
Ha ha, yes, of course 'union' is a reserved word. Forgot that.

How about roi_union() and roi_intersection()?
You are correct (assuming you mean there will be an overlap of 1 message). I felt the simpler implementation outweighed the tiny advantage of skipping one more message, but happy if you want to change it.
this change seems suspcious, im not sure why its there.
If a service removes other services it creates, then it needs to asynchronously stop, and use a task to wait on the removal before completing the stop of the service. Otherwise restarting the service will race and potentially fail. The executor to do tasks like this can be obtained using Services.addServerExecutorDependency during build.

Take a look at JMSTopicService's stop method  for an example
I think access to this set needs to be syncronized, as I think this can be called by multiple threads at once.
Well spotted - Thanks.
Done
Missing property value
This requires a new schema version. The attribute in the 1_0 version was "domain".
Still not sure about contents validation, since as a single function it turns out to be quite ugly :|
That `onHide` thingy allows to clear inputs if we display the dialog multiple times.
Got it! In fact this was just a "template" implementation by @borjasalguero I have this under control in my upcoming PR once this is closed ;-)
typo: building *blocks*
I am not familiar with the OpenWnn IME you guys ported from, but a 
little bit of playing through I would say it's different to the iPhone 
Japanese IME, so it requires states.

How about `function km_showPendingSymbols(symbols, highlightStart, 
highlightEnd, highlightState)` and have `keyboard.css` to assign the 
color of each state? State can be a number or string, depend on your 
preference (don't be language-specific though). In this way we can keep 
the IME logic and the visual separate ...... that's all I ask for.
The bug is tracked here https://bugzilla.mozilla.org/show_bug.cgi?id=805780 . I am adding the right comment
Let's pick a different name ;)
I would like to understand why exactly?
OK, it seems `setDate` handle that for you according to MDC.
Do we need to get the headings each time we enter this function?

Couldn't we just ask for them once? Or are we protecting if a heading becomes visible cause of the adding of a contact or something like that?
this already happens with XmlSettings.  What attack angle are you thinking of?
Sure, I can change the names, but the code will stick out from the rest of the source file like a sore thumb.  It definitely confused me too, the first time I read the code.  I'll make the change and ping you when I'm done.

You are correct though -- obj_ext is the "externally provided" object, while obj is the "internally cleansed" equivalent, should swiz validate the input.
É bem verificar no FF do Mac se todos esses `font-weight: lighter` estão deixando as fontes muito finas a ponto do texto se tornar inlegível. No Chrome do Mac a fonte fica legível, isso só acontece no FF. Esse problema foi percebido ontem na landing do Redu em produção. Se o problema for verificado, a solução é usar o valor `300` ao invés de `lighter` (equivale a `100`).
@filipewl, removed. b59cf431d2
The `#to_s` method is called on anything interpolated within `#{...}` so you can probably remove it here.
These two lines should probably be:

log.exception('%s exists' % (self.target,))
Can you comment on the explicit different between this and ```Monoid[Seq[T]]```?
maybe rewrite this as:

```js
return (options.variable || 'templates') 
  + '["' + name + '"] = new Hogan.Template(' 
  + hogan.compile(openedFile, { asString: 1 }) 
  + ');';
```
The AppServer expects a void proto in response. Requires investigation but has to do with what the integer represents (I think a index number?). I added some clarification.
Don't override the old variable - just call the new one something like `json_config`.
Wait, nevermind it does work on that context.
https://developer.mozilla.org/en/DOM/XMLHttpRequest#send()

```
void send();
void send(ArrayBuffer data);
void send(Blob data);
void send(Document data);
void send(DOMString? data);
void send(FormData data);
```

all these data types are forms? you're just making shit up now
You can use ( ... ) with a single item (not a tuple) to deal with the line length issue. Also, please do not editorialize in comments.
So this is an example of the semi-"heavy wrapper" in @Afforess post. We need to implement start level in Bridge if Vanilla shouldn't implement it
When I throw an object like this, the debugger says "Uncaught #", which is a lot more cryptic than say "Uncaught XML Parsing Exception". Maybe also log an error message to console here for any cases where it is not loading from file?
Same thing here, it would be nice if test modules could override some/all post-processing.
dev machines probably shouldn't be updating the production stack :)
country codes are 2 characters right? So why not make this 3? 2+NUL
Hello newer, sexier readme.
Let's change the name of the file karenpittsMac.yes to something that does not identify me. Perhaps development.yes
NEVERMIND I SUCK AT READING. Hi.
Is the order relevant? Otherwise you could simple have:

    principals = EXPANDED_PRINCIPALS.concat(window);

And I assume it's better pass `window` rather than `[window]` when there are no additional principals for platform optimization reason, otherwise you could have:

    let principals = EXPANDED_PRINCIPALS.concat(window);
nit: Cu.imports -> Cu.import
I think we should develop the policy that we don't rev the version in feature branches. Right before we publish a new version, we can rev and publish. That way, we don't have to worry about whether a branch should rev or not. Also, the version number of this should probably be 1.0.0rc2. Unless we just want to skip to official release, then 1.0.0 (which we haven't released yet).
As I said, I'm not sure if it's used elsewhere. It works like that, and the refactoring is not over (there will be more due to ModelCriterion). This code is just copied from the old class.
I'd like to change this to [multi_json](https://github.com/intridea/multi_json/) and fall back to 'json' if multi_json isn't available.
Doing this kind of reset counter is ugly to my eyes. I couldn't read it on the first pass. However, the only response I have is something like a modulo counter:

```javascript
var countdown = 10;
var time_alive = 0;

this.update = function() {
  if (time_alive % countdown === 0) {
    // shoot
  }
};
```
It seems to me this could be called Append. No? Because it can take an HTML String, jQuery object, or a DOM element.
I think that's the only framework we use, and it's the only example I can think of for something that should be locked to an exact version.
Does the issue come from the use of program.parse another time, or from the need to augment argv before parsing in itself?
Can you use .bind(this) instead?
For all this cases you can cast the return to integer

```
return (int) ($this->evaluateAstPart($ast['arguments'][0], $number)
                    > $this->evaluateAstPart($ast['arguments'][1], $number));
```
incorrect spacing: ( "" )...
But, yes, that sounds like a good idea. When implementing this bit I had that thought as well.
Again, indentation is incorrect here.
Is this required for the change to work? Will it still work on older API Levels?
Style nit: space after if.
Missing space after the `if`.  Also you need to add `{` around the statement as defined in PSR-1/2
then it simply mean that your phpunit.xml file is outdated compared to the dist file
Is there a reason this should not be fancylogger's raiseException?
libpthread-stubs is provided by xcb, doesn't have a dedicated homepage.
I've fixed this
Fix spacing issue before the word function.
spacing inside .replace brackets
Wraps the `find_events_extended` in a wrapper which evaluates the result to see if it is what we want.
You should never be using a `gevent.sleep` try to make it either asynchronous using gevent events or use a polling mechanism.
Yes, it caused a failure when using postgres as the test database.  
On the role.rb model, there is a length contraint:   validates_length_of :name, :maximum => 30
The name in the fixture was 37 characters, so I just shortened it.
I assume other databases just truncated the name with no problem.
Ждём еще один pull-request ;)
The functions in the ProRemote class checks if the running Nexus is indeed Nexus Pro. I have a Scenario that checks for this by invoking the nexus status command. I can change this to be Background instead which would call it before every Scenario but would that be redundant?
Rename test, must be related to config file lists.
That isn't 1.0.0! xD

Haven't seen a 1.0.0 install for a while, though. It's all black and *horrific*.
** interceptor** (割り込み処理)
For better readability this could have been written like:

```php
    /**
    * Clears cache-block cache by name property and optionally node id
    *
    * USAGE:
    * eZTemplateCacheBlock::expireCacheByName( $name, $nodeID);
    *
    * @param string $name
    * @param int|bool $nodeID
    */
    static function expireCacheByName( $name, $nodeID = false )
    {
        if ( !$name )
        {
            return;
        }

        $cachePath = eZTemplateCacheBlock::cachePath( eZTemplateCacheBlock::keyString( $keys ), $nodeID, $name );
        $phpPath = eZTemplateCacheBlock::templateBlockCacheDir() . '/';
        if ( is_numeric( $nodeID ) )
        {
            $phpPath .= eZTemplateCacheBlock::subtreeCacheSubDirForNode( $nodeID, $name );
        }
        else
        {
            $phpPath .= $name;
        }

        $phpPath = $phpPath . '/' . $filename;
        $fileHandler = eZClusterFileHandler::instance( $phpPath );
        $fileHandler->fileDelete( $phpPath, '' );
    }
```
I think the same issue will occur with &, or < or > in the name. And, perhaps, htmlspecialchars or htmlentities are better suited than the str_replace.
This is here for setting the image's `src` the first time without waiting for the `options.delay` to pass. Rather than calling the "global" `updateBreakpoint()` to inefficiently force an update for every image being registered in this query, this waits for the resolution of a `$.Deferred` to tell it that `updateBreakpoint()` has run at least once and that the breakpoint is now valid.
Yes, a few lines down we assign it to whatever the found resource's title was.
You are correct, I actually discovered later in the day on Wednesday that this wasn't doing what I wanted and this code has already been changed pretty significantly.  Will push up another commit in a bit.

When I originally wrote this code, it looked in the debugger as though the result-set object might just have a property on it that was pre-populated with the size, and that's what I was trying to grab.  `count` is clearly not the way to do that, though.
On Mon, Jul 30, 2012 at 03:17:05PM -0700, Chris Price <reply@reply.github.com> wrote:
> > @@ -0,0 +1,101 @@
> > +;; ## internal (private-ish) helper functions for com.puppetlabs.jdbc.  External
> 
> Cool, haven't run `lein docs`, will give that a whirl.  And the
> italics sounds reasonable.  Was there anything else you meant here
> by "The comment lines aren't correct markdown"?

Nope, that was it...I think by having the "." and new sentence start
on the same line as the "##", you'll end up generating an HTML heading
that contains the beginning of the next sentence. :(
Same here, gotta lose the `:else`.
I think this code will only check one run prefix... It needs to check every run prefix that's returned for validity.
It looks like an undefined visibility will pass validation and end up doing an invalid query.  It would be better to add
`sectionVisibility = sectionVisibility || default` at the top.
I'm not sure I understand what this is doing. Do we need it ?
It is validating that you can't specify a group (e.g., g:oae:oae-team) as a resource when interacting directly with the RolesAPI. I'm not quite sure how else to phrase it.
Ah right, fixed in the latest commit.
I know it's long, but this comes very close to AuthzAPI. Can we change this to AuthenticationAPI?
I'm still not super sure what the usecase is, but this (as well as the hardcoded array above) seems solely profile related? could move this information back to the controller and just have empty/stub methods here? dunno :) Can also be done later, obviously.

Otherwise ... all good! Merge it!
why? that is good to have there. :)

On 20/03/2012, at 11:49 PM, Sven Fuchs wrote:

>> @@ -35,6 +35,7 @@ def configure
>> 
>>   RSpec.configure do |c|
>>     c.filter_run_excluding :js => true if ENV['CI']
>> +    c.backtrace_clean_patterns.clear
> 
> accidentally committed. should i remove this?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/travis-ci/travis-ci/pull/466/files#r582978
Because it implements the StorageEngine interface...
I'm reasonably happy with a python script here too, for the same reasons of dependency -- Python'll be "always there" on our dev machines and there's no extra deps needed.
Not sure I like this, since it is theoretically possible that all prime endpoints could have different values i.e. versions etc. I will probably come back to this later to examine further.
That was already there, I just moved that line. Baby steps :P

Sent from my Windows Phone
________________________________
From: Brendan Forster
Sent: 7/05/2012 7:56 AM
To: Jake Ginnivan
Subject: Re: [DownmarkerWPF] Pulled out another control, and moved heaps of the zoom logic around (#256)

>              ApplyFont();
> -            ApplyZoom();
> +            markdownEditor.Editor.TextArea.TextView.Redraw();

!!! so many dots !!!

---
Reply to this email directly or view it on GitHub:
https://github.com/Code52/DownmarkerWPF/pull/256/files#r779464
Don't remove these.
componentsJoinedByString возвращает объект NSString, так что можно сделать просто return [_DNA componentsJoinedByString:@" "];
@vratushnyi да, это понятно, что если переменная используется только один раз, то не зачем ее обьявлять, но здесь (да и в других местах программы) я заводил такие переменные для того, чтобы в дебагере отслеживать значения потому, что Xcode не показывает значения выражений, значения одного обьекта из массива и т.д.
shouldn't that path need to be at the beginning?
This can be combined with the next line without issue.
I think we can remove the check !isNativeLzoLoaded(getConf() in both
createInputStream() functions since both will call createDecompressor()
eventually and createDecompressor() checks !isNativeLzoLoaded.

On Tue, Apr 24, 2012 at 10:22 AM, Yu Xu <yu@twitter.com> wrote:

> that's to be consistent with the other function createInputStream(in).
>
> On Tue, Apr 24, 2012 at 10:20 AM, Raghu Angadi <
> reply@reply.github.com
> > wrote:
>
>> > @@ -86,7 +87,16 @@ public CompressionInputStream
>> createInputStream(InputStream in,
>> >
>> >    @Override
>> >    public CompressionInputStream
>> src/java/com/twitter/elephantbird/mapreduce/input/LzoBinaryBlockRecordReader.java(InputStream
>> in) throws IOException {
>>
>> > -    return createInputStream(in, createDecompressor());
>> > +    // Ensure native-lzo library is loaded & initialized
>> > +    if (!isNativeLzoLoaded(getConf())) {
>>
>> do you need this?
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/kevinweil/hadoop-lzo/pull/1/files#r727564
>>
>
>
Ah sorry, I misread the code: I guess "arcname" is actually the name in the archive, so "metadata.xml" is ok. Sorry.
Yeah thats a good idea, but I think I should just do the caching in the ZincGetApplicationDocumentsDirectory helper function.
I think it makes sense to combine these into a single vector...?
should we mention making master a tracking branch of upstream/master?
My vote is for refactoring the below into functions. I don't see any new dependencies (e.g., no mavavi or anything). Perhaps two functions would do it:

1) One that generates an order of labels based on their positions in source space. This function could just take a list of labels, and a subject name, I think, and return an order array. Basically it could clump the right hemi labels on the right side and left on left, so that if 1/3 of the labels were RH labels, these would span -pi/3 to pi/3 on the circle, and the LH labels would take up the rest. Does that make sense? I think that would work for the one-hemisphere case as well as the whole-brain case in a nice way. This would go in label.py.

2) One that takes a list of labels and optionally, an order (so users don't have to reorder the list themselves) and does the actually plotting. This would probably go in viz.py.

How do you think on it?
pep8 2 lines between functions

you should really activate a pep8/pyflakes plugin in your editor.
I don't think this is used now, right?
How will / should this affect other package types?
Nice note to pressed_key
Same here, don't remove this file from the repository).
Other issues aside, this should be 

```ruby
# config.backend_route = <%= Refinery::Core.backend_route.inspect %>
```
missing ``=`` signs in the line
Are you sure that ```autoHeight: true``` and ```autoScroll: true``` play well together? My understanding is that if ```autoHeight``` is true, the container's height will adjust to the height of its content, and then scrollbars don't make any sense.
over 80 characters
Окей.
Лучше перенести в initializer list. Тем более, что едва ли ты будешь менять
этот идентификатор, и его можно сделать константным.
I meant that the default is for it to look for a messages.locale.yml file
in the bundle that the menu is rendered in.

For example, I am using the menu in a template in MyAppBundle, and by
default the knp_menu template outlined in the doc example is pulling the
translation from MyApp/Bundle/Resources/translations/messages.en.yml,
without me setting a translation domain.



On Sat, Jun 16, 2012 at 5:38 AM, Christophe Coevoet <
reply@reply.github.com
> wrote:

> > @@ -52,14 +52,15 @@ $menu->addChild('Home', array('route' =>
> 'homepage'));
> >  $menu->addChild('Login', array('route' => 'login'));
> >  ```
> >
> > -To translate them you need to add translation_domain parameter using
> addExtras:
> > +To specify a translation file you can optionally add the
> translation_domain parameter using setExtra.
> > +Otherwise, default is
> {BundleMenuIsRenderedIn}/Resources/translations/message.{locale}.yml
>
> the translation string are not tied to a bundle. The same translation
> domain can be used in several bundles. And there is no default here as
> there is no built-in translations in KnpMenuBundle. The default domain
> depends of what you do in your own theme
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/KnpLabs/KnpMenuBundle/pull/119/files#r997477
>
Can you explain what this block does?  I'm having a hard time figuring it out.
Here the export directory is shown instead of the import directory.
It's 10 (defined in cgData on line 80), so it's ok, we have no colission.
Adding Title to Graph If it is required.
horray fixin fakemode :)
Should this name be a bit more distinct? Like maybe even "reddwarf" since its really just the async side of RDL.
Will there ever be a case where someone would intentionally pass this None instead of a dictionary? Seems like if they have a None they'll have to handle it after they get the return value of utils.exclude anyway so this won't help them out there. It may be easier to raise a TypeError so they find out sooner.
This has the potential to throw a wrench in the works the moment we've got an arg with an `=` sign in it, or anything with a comma in it.
Depending on where all we end up using this, it may not be a huge problem, but I figured I'd voice my concern anyway.
It will flick unlock_handle  from its centre point until (0 ,-100) over duration of 800ms.
Something missing in `(self.testsetup, )` ?
Since string concatenation takes an operator (.), it should adopt the same formatting as regular operators.

    $myvalue = 4 + 7 + 3;
    $mystring = 'Hello' . ' ' . 'World!';
This is now the implementation for this, is already fixed.

On Wed, Sep 5, 2012 at 8:43 PM, Richard Rodger <notifications@github.com>wrote:

> In lib/parambulator.js:
>
> > @@ -63,10 +63,30 @@ var quantrule = function( foundok, rulename ) {
> >    }
> >  }
> >
> > +var lenrule = function( islenok ) {
> > +  return function(ctxt,cb) {
> > +    var conditionallength = ctxt.rule.spec
> > +    var value = ctxt.point
> > +
> > +    if( !_.isUndefined(value) ) {
> > +      if ( _.isNumber(conditionallength) ){
> > +        var valuelen = _.isObject(value) ? Object.keys(value).length : value.length
> > +        if ( !_.isUndefined( valuelen ) ){
> > +          if ( !islenok( valuelen, conditionallength ) ) {
> > +            return ctxt.util.fail(ctxt,cb)
> > +          }
> > +        }
>
> generally a positive statement is easier to understand than a double
> negative
> so islenok should return true if the len is >= the min
> however, the name of the function should be "pass" - this is consistent
> with childrule
> (and quantrule foundok should be renamed to pass as well )
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/9/files#r1535925>.
>
>



-- 

*malex*
@apex13 Can we use single quotes?
@bp323 to the homePath or the display name?
Indentation in both .h and .cpp should be fixed now.
一応"Callback URL"という記載をしておきました。Callback URLが何かについてはアプリ登録のときに入力すると思うのでそこで説明すると良いとおもいます
I named it that to be analogous to the existing ```ab_add_conversion``` (which calls the ```increment_conversion``` helper just as this calls the ```increment_ab_count``` helper).
Did you think about aborting the transaction internally, that is, returning WT_DEADLOCK aborts the transaction before the return?

It makes application error handling easier, I think, and given our model, I don't see why it wouldn't work.   (In fact, we could abort on any error, not just deadlock?  That was the Berkeley DB rule, and I'm assuming we have the same rule, it's hard to imagine EINVAL not leading to abort, and ENOMEM should definitely lead to abort.)
Mucho copy pasta was removed all around the tests.
Since this is not a published dependency, so could we have some documentation in the README about how this dependency came to be?