labofsahil/github-event-dataset-2012 huggingface dataset:
You have a point that the [ReadTheDocs](http://readthedocs.org/docs/mytardis/en/latest/) documentation really should be preferred over viewing the reStructuredText in GitHub. Perhaps a link in the README to ReadTheDocs would be appropriate? At the moment [mytardis.org](http://mytardis.org) is a synonym for [mytardis.its.monash.edu.au](http://mytardis.its.monash.edu.au/), but once it's an official site I imagine another prominent link there to the documentation will remove any remaining confusion.

As for the contributors file, I went through the commit list looking for major contributors, rather than simply relying on the previous list. I may have missed a few people though.
Looks good, will probably just change this manually in github and close your pull request.  Will test today.
Robin, thank you for the important fix!
My only worry is that in its current form we can't merge this commit into master as is. Could you please clean it up a bit?
Especially I'm worrying whether we break USP2 and N2x0 builds with this. We must maintain them in good order.
We don't currently have a view count field for the videos. Should we just use a stub for now? (Partially why I gave the example of 100 views)
Can you give me an example of how this crashes? I'd ideally like to make a test case for this, but I'm also curious since this hasn't crashed here for me in a while...
And a few opcodes:

enum Opcodes
{
    CMSG_CALENDAR_GET_EVENT              = 0xDCE2,
    CMSG_CALENDAR_GET_ARENA_TEAM         = 0x88D7,
    CMSG_CALENDAR_GUILD_FILTER           = 0x0A57,
    CMSG_MESSAGECHAT_BATTLEGROUND_LEADER = 0x20C9,
    CMSG_MESSAGECHAT_PARTY_LEADER        = 0x24C9,
    CMSG_MESSAGECHAT_RAID_LEADER         = 0x60D1,
    CMSG_WORLD_TELEPORT                  = 0x4898
    {
        float PosX,
        float PosY,
        float PosZ,
        float Orientation,
        uint32 MapId;
        
        Mask: 4, 3, 7, 5, 0, 1, 6, 2;
        Bytes: 3, 1, 7, 0, 2, 5, 6, 4;
    },
    
    SMSG_ALL_ACHIEVEMENT_DATA = 0xE6EC,
}
I make two new routes for this, instead of putting the score into here.

So, you'd have 2 more POST routes, like /comments/vote_up or something. 

Something like this: http://stackoverflow.com/questions/2920855/how-to-add-a-new-custom-resource-to-routes-rails-3
Shouldn't minTxViewId be volatile?
OK, cool. Thanks. I can read all of your comment in the email notification, at least. :)
I will raise an issue to cover the remaining locales.
oic ._.
Ya, but why do we need a for loop? there will _always_ be just one rid < session.rid (which is the node.attrs.rid) -- since we get rid of such requests immediately.
Attachment's were getting messed up because of the string concatenation. Switched to a Buffer which is a much better way to handle binary data.
I send a pull request. As well. Ciao
Terima Kasih untuk script yang sangat bermanfaat, harapan kami agar visitor yang belum (non-member) mendaftar juga bisa dihitung sebagai visitor. Terima Kasih.
Right, using `sendQuery` and `getResult` will do at least some processing as results are received, however (as I mentioned in the commit) I don't think there is any kind of throttling involved.   If this is indeed the case,  if results will come in faster than the code can handle them,  they will accumulate in memory. 

`getTypename` is still in your codepath,  as it is used to fill in the `typename` in the `Field` record,  but this shouldn't be an issue because your code appears to explicitly that all type oids are builtins,  thus `getTypename` shouldn't ever touch the `connectionObjects` cache.
It’s not _needed_, just a bit cleaner as it makes the indentation more consistent and simplifies the GA snippet. Feel free to cherrypick / close this pull request!
Properties? Yes, so this is an acceptable error. Parameters: definitely not. I used to write adapters that ignored some parameters by naming them all `_`. It's frowned upon, so I don't do that any more, but I don't think it is either bad *or* likely to be an error.
hm, I will need to check this, for now use previous commit
at my testing db map.php reduced to 303.4KB from 358.3KB before using jsmin
@josevalim thanks for the explanation, @rafaelfranca thanks for pointing the example, its cleaner to me now. 

I understood your reasons, though I think inherited_resources is perfect for some cases...
same for the bundle namespace
Peter,
Just to confirm - is that repetition  of %{_builddir} correct?
Adam
My reason for this is that there is no difference between '0 hours done' and 'blank hours done' - both mean that no work has been done for this ticket/work type. There *is* imo a difference between an estimation of 0 (you won't need any work of this kind) and 'blank' (no estimation was made), and between a todo of 0 (no more work left) and 'blank' (let the system calculate the todo). 
Also, it is possible to 'clear' both the estimations and the todo - it isn't possible to 'clear' done.
I'm a little torn with tracking swizzled classes in an ivar, since swizzled-ness is a global property. Presumably one would never use more than one `MAKVONotificationCenter`, but it's not actually a singleton, so it would be good to cover that case, even if it should never really happen. I'd suggest moving it to a global variable. Access to it should also be synchronized for thread safety.
Added the button for linking to the site to the main page
In this line too:
                      '.$search['publi'].$row['charac'].', on '.$row['date'].'
another dot
This will actually be v0.4.2. I neglected to update the Changelog the last time.
I just changed the file format so I'm adding this song back in now...
Looks good. Is this the "standard back button" that you speak of?  What makes it standard?  The "backlink" class?
It's true.  I suppose we could just make the provided fields a
reasonable default that can be overridden by specified fields, but
this is certainly sufficing for now.  If you'd prefer to make it look
more like the work in #55, feel free.

On Sun, Jan 8, 2012 at 8:59 PM, John O'Connor
<reply@reply.github.com>
wrote:
> `fields` is unused.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/TireSwingSoftware/openassign-server/commit/d3ce39e40283a989c293e06894ecf49e27dab4e6#commitcomment-848385
tak to je ve 2.2 i setAnnotationNamespaceAlias ...
doesn't support PFM though right?
and VVVV can't export EXR's right now
I'm writing a FreeImage .NET importer for VVVV though to go the other way (generally from Cinema 4D)
working on a '3d scanning system' inside Cinema 4D which means i can volumetrically define animations out of the scene.
Magic numbers. Do you need my explanation of what is it?
Is it intended that all hosts are found if you type only "@" or "user@"?

In this case the variable "host" is empty and the match returns an empty array or '' (not sure about that) instead of null and so the if statement is true and all host are added to the searchResult
lol - yeah, that lots of old & intermediate stuff

no, unfortunately I haven't so far compiled a kernel for the fascinate yet :/

take your pick:
https://github.com/MotoXoomKernelFlavors/tiamat-kernel-mod/commit/54e12e66e24c7a2594411bec539c0511a05936e5
https://github.com/MotoXoomKernelFlavors/tiamat-kernel-mod/commit/11fefe42377881f9423f9e16be34556c964fc28b
(that's on my xoom-kernel)

https://github.com/mathkid95/linux_samsung_ics_real/commit/6934eea95bbeb8fac8b90caaef7d9666e913582a
<-- 
use that one, since that where it came from
Dim's and GoTo's -- i love it
gpios used for i2c2 (bord_smba1002_i2c,c) is currently used by PTA which is assigned to hdmi. We need it muxed to use it.



________________________________
 From: treznorx <reply@reply.github.com>
To: clemsyn <clemsyn@yahoo.com> 
Sent: Saturday, February 25, 2012 7:26 AM
Subject: Re: [android-tegra-nv-2.6.39-rel-14r7] i2c2 proper gpio porting (a54d0b2)
 
In the .32 kernel this bus is not muxed for smb-a1002.

It is muxed for smb-a1006 and smb-a1009.

The .32 kernel could be wrong, is there something broken without this mux?

http://bit.ly/w3QGWg This is where I'm seeing that our bus is not muxed.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/clemsyn/android-tegra-nv-2.6.39-rel-14r7/commit/a54d0b265180cc5ce29574c923a9eb7609abc1c9#commitcomment-1010779
And fixed, again.  b57c6fb1c13f2c2d1e7f884aba2bf07436b1b06e
This function has been deprecated.  An bool attribute 'view' has been added to the control_group function.
Should this method be here and/or should it be empty?
Do NOT use for...in to iterate array, should use: for(var i = 0; i < a.length; i++)
Does this have an advantage over passing in the offset pointer to `lmadata` to begin with?
`=== false` as above.
shouldn't we just fix the reactor import in mcp?
clearFailed
thanks, I have removed the fixme and added your comment
Use named parameter when using boolean constants in parameter lists?
Ah, I didn't know this.

I added dilation to the throttler rates and tested it by (locally and temporarily) setting `timefactor =  5.0` in `akka/akka-testkit/src/main/resources/reference.conf`. With this, the tests still pass.

See https://github.com/hbf/akka/commit/aeb4e471415b2f757d4065cc5baed8a940e78cc4
why local methods?
Great work Patrik!
could use case callback :: more
instead of c.tail
This is possibly due to my limited understanding, but why "terminationHooks foreach { _ ! TerminationHook }" is missing here? We do not notify hook registrants when one of them is the terminated one?
What happens with messages in the mailbox between the ChannelShutdown message and the Start message being processed?
Whoa, this section needs some comments-love.
I'm not sure that this is as efficient as clazz.newInstance
see java.lang.Class newInstance0 (some caching going on)
you might want to do this as fallback, if clazz.newInstance fails
same problem in case of an intervening restart
Don't add an onFailure and an onSuccess (2 callbacks) when only a single onComplete is needed.
@rossjones 

Thanks I'll look at fixing this issue
Are you advocating against using positional arguments for calls in general, or is there something unique about this case that I'm not seeing?
I started using them in the areas that I expect to generate API docs for, such as in the extensions code. I hate the inconsistency, but it probably makes sense for us all to start using them and then eventually do a big ass change over. Maybe I'll see if I can get Mike to do it as part of his git refactoring process, just a big grep.
drop the `return item` (this method should return `None`)

while returning the inserted item may be useful in some cases for method chaining, the norm for method chaining is actually to return `self`, which in this case would be the parent object, not the child. aside from that, the even more prevalent norm (in python at least) is for `insert()` methods to return `None` or `void()`... better to maintain consistency above all else.
Not sure I like this change. Maybe the public API should expose two methods and use this method with a bool as a parameter internally to avoid problems.
mutable Map as a parameter? I don't see it being modified either.
A c&p error. Thanks for spotting it.
The last part is identical to the check for m_pBufferRef above..

````
#if(buffsink)
  result = m_dllAvFilter.av_buffersink_get_buffer_ref(m_pFilterOut, &m_pBufferRef, 0);
#else
  if ((result = m_dllAvFilter.avfilter_request_frame(link)) < 0)
  { ...... }
  m_pBufferRef = link->cur_buf;
#endif
  if(!m_pBufferRef)
  { ...}
````
аа, тут имелось ввиду видимо, что тип ваще задан, а не пуст. Тогда да. можно и так.
This is a little hard to understand :(
closes over this
The caller is responsible of checking if the variable is an array (or ArrayAccess) and if the key exists

If think this will make the following fail:

``` php
<?php
class Foo extends ArrayObject {
    public $bar = "property";
}

$foo = new Foo(array('bar' => "dimension"));
```

``` jinja
{{ foo['bar'] }}
```

This should display `$foo['bar']`, but it will actually display `$foo->bar`.
.... that's.... excuse me as I go open a debate issue for this.
Move this inside DisplayExceptionLine.
Do these relative URLs work now?


On Mon, Jun 11, 2012 at 1:55 PM, Robert Martone
<reply@reply.github.com>
wrote:
>>   */
>> -var Container = require( '/scripts/lu-controls/Container' ),
>> +var Abstract = require( '/scripts/lu-controls/Abstract' ),
>
> Please use ```lu/Container``` and ```lu/Abstract```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/Lu/pull/153/files#r962793



-- 
jimg at yojimg dot net
You can just say synchronized instead of this.synchronized; it will match the style of the existing code more that way.
Spaces around operators and after ','.
There isn't tests for `lang=None` but I guess this case will break because `markdown_page()` will try to open the slug instead of a filename -> `IOError` even if the file exists.
я наверно хотел спать - обычно стараюсь так делать)
поправлю
I agree with you. and I updated it.
> If I call `@@compiled_delegators.include?(method)` while another thread is in the process of adding an element to the set (remember, this is the only mutation that will happen), could the call ever return false, when it should actually return true?

What you are describing is a **data race** (2 concurrent threads accessing the same memory, while at least 1 of them is doing a write). For example a C++ program with a data race has an **undefined behaviour**, in other words anything is allowed happen. It depends on the underlying implementation, but sure ... it can return `false` (unlikely), it can also go into infinite loop or crash the VM (probable).

I should really finish up mine [concurrent cache/hash implementation](https://github.com/thedarkone/thread_safe/blob/cache/lib/thread_safe/cache.rb) that allows concurrent modification/reads/deletes/inserts/whatever while being completely lock-free for reads.
The word „full“ has the same meaning as in it's twin method - full_messages. It means that returning array contains sentences which include the attribute name itself. Like „Password can't be blank“ instead of „can't be blank“.
Ahhh. Yeah.
I was logging more, and I reduced it to where it is; I forget what I found out, but I remember it wasn't being useful.
not sure, but it only considers method type parameters this way
it seems class type params should be stripped as well, indeed
does the spec specify?
Hmm. Could you explain the difference between `findDecl` and `findMember`?
I must have gone blind. Sorry.
Please remove this reference. If you write it as ``is a `numpy.mgrid` object``, then numpy.mgrid will be converted to a link, so it's clear where to find more info.
How about using the new Cython array syntax: `array_data_type[:]` instead of `np.ndarray[array_data_type, ndim=1]`?
From discussions on the Cython ML, it seems the `np.ndarray` syntax will be eventually deprecated.
This formulation sounds a little bit awkward to me.  How about "The mission of the ImmutableMatrix class is to bridge this tension between performance/mutability and safety/immutability."

(I'm not a native English speaker, so feel free to disregard this comment in the favour of something more authoritative.)
So if there's an assumption for identity, then identity <-> unit_trangular & diagonal.
I guess this was already here, but there's no need to do `locals or {}` and check if `locals` is `None` in `parse_expr`.  Probably the latter way is preferred, since `parse_expr` might be called directly.

Also, since these are keyword arguments, it's better to call them as `parse_expr(a, locals=locals, globals=globals, transformations=transformations)`.
``print`` is unnecessary here.
It's now in my expr_from_dict-opt branch.
For out-of-range breaks used in coord with expansion.
I will note this.
"If you want not to perform..." => "If you don't want to perform..."
But, as I can see, it's not applied recursively in this case:

```php
CFileHelper::mkdir('/var/www/mydir', 0777, true);
```
please make this a read only property. Not sure we need it though; what's wrong with just calling  [[UIDevice currentDevice] name] ?
So if the end time stamp was taken here, regardless of whether there is a StartTime or not that solves the problem you bring up in the review comments, no?
I think this might be better as:

```js
m.push('(?:[ \\t]*\\/\\/.*\\r?\\n)+');
```
Woops, forgot to send movements to other players.
Will do... Sometime up to the end of the weekend.
As in decorate the existing resolver?

``` php

class ControllerAsAServiceDecorator implements ControllerResolverInterface
{
    protected $resolver;
    protected $app;

    public function __construct(ControllerResolverInterface $resolver, Application $app)
    {
        $this->resolver = $resolver;
        $this->app = $app;
    }

    public function getController(Request $request)
    {
        // check for service:method syntax
        // pass to existing otherwise
        return $this->resolver->getController($request);
    }

    public function getArguments(Request $request, $controller)
    {
        return $this->resolver->getArguments($requet, $controller);
    }
}
```

Ideally it would have to duplicate a couple of sanity checks, checking for the _controller attribute and then the method_exists, but other than that I can't see it being a problem.

What do we reckon?
from now on please provide a big doc block with a link url or a usage example snippet
This extra `/` causes the URL to be `//repos` which returns a 404.
Use uv__epoll_wait().
Should this line be commented out?
This should be in the verification code, not in production code.
Do limits get applied as part of the XML POST?
We shouldn't overload the term "namespace" which refers to the concatenation of the database name and collection name, typically. The fact that you can put a dot in collection names and get something that *looks* like hierarchical namespaces, is a hack (a decent one, but still a hack,) and it gives the wrong impression about how collections works.

Better to say, "Collection names *can* have a dot, and you may use this to simulate a hierarchical namespace; however, the collection namespace for each database is itself flat." and leave it at that.

Perhaps you can contrive this into an FAQ and use the example in the answer.
@groovecoder it's already allowed for headings per the line just above the one I changed, so I'm not sure why it shouldn't be allowed everywhere. I don't know how vital is it, though, but I do know that deki allows it.
Haha, so I actually misunderstood exactly this :) That's a really strange thing to do though, why would you pass a bool?
The tests are not actually the same.
Both fixed. Will appear in the next push.
We only have provision for apache and IIS by default (see web.config changes at the end of the diff). I will comment this out and explain to uncomment it if you want to remove /app.php/ from URLs. I am not, however, sure how to "turn something off" in the web.config file.
You should not be doing these changes.
Yeah, if it is that easy, just do it like that and mark it as deprecated. We can then still remove it later on.
That was simple a misnamed param documentation. I'll change it.
Newline at the end needs to go.
Escape both keys and values.
agent.load_average so it is clear?
nit, escaping/quotes
Change settings here to suite custom domains.
Agree, its odd. I will check this.
В идеале хотелось бы сделать AMD
Sure. Ik heb ze niet in mn IDE zitten dus ik heb maar wat gedaan :p 
Ik zal voortaan deze standaard hanteren.
This line gives error in Visual Studio "ambiguous call to overloaded function". Replace log(2) with log(2.0f)
Wouldn't const int fix it?

On Mon, Dec 3, 2012 at 10:49 AM, joshdoe <notifications@github.com> wrote:

> In samples/cpp/connected_components.cpp:
>
> > -
> > -    Mat dst = Mat::zeros(img.size(), CV_8UC3);
> > -
> > -    if( !contours.empty() && !hierarchy.empty() )
> > -    {
> > -        // iterate through all the top-level contours,
> > -        // draw each connected component with its own random color
> > -        int idx = 0;
> > -        for( ; idx >= 0; idx = hierarchy[idx][0] )
> > -        {
> > -            Scalar color( (rand()&255), (rand()&255), (rand()&255) );
> > -            drawContours( dst, contours, idx, color, CV_FILLED, 8, hierarchy );
> > -        }
> > +    Mat labelImage(img.size(), CV_32S);
> > +    int nLabels = connectedComponents(bw, labelImage, 8);
> > +    Vec3b colors[nLabels];
>
> This is an error with MSVC9 (VS2008) since nLabels is not a constant; use
> new and delete instead.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Itseez/opencv/pull/135/files#r2296401>.
>
>
Type and members missing XML-comments
we agreed on no 'src' in the path, right... so is this necessary?
Should be RaxaEmr.Pharmacy
Thanks @bblay. If I understand correctly, the real problem is that ```cube.data``` is modified by the call to ```iris.analysis.interpolate.linear```, a supposed out-of-place operation. I believe we should be testing this i.e. that cube is not changed by the call to ```linear``` (and that the resulting array and its mask are the expected size). By the way, I do not think that the data copying and mask unsharing is needed to reproduce this bug and confuses the issue a little. See below:
```python
import iris
import iris.tests.stock as stock

cube = stock.realistic_4d_w_missing_data()
cube = cube[0, 2, 18::-1]
cube.coord('grid_longitude').circular = True

orig_cube = cube.copy()

assert(orig_cube == cube)
sample = [('grid_longitude',0), ('grid_latitude',0)]
inter = iris.analysis.interpolate.linear(cube, sample)
assert(orig_cube == cube)
```
This dependency isn't listed in the INSTALL file.
All those Py_XDECREF apply to the NULL array declared on line 2793, not on the one declared on line 2805, that has gone out of scope.
Some message is in order.
Done (2dd1096)
isReader function actually checks for read*
either the above comment is incorrect of the function is incorrect.
These lines are building quite a complex command that is gonna look awkward in the log for most cases where the sparse checkout is not in use. Perhaps it'd be better to use the simpler command unless an rtp parameter is used in the bundle.
I believe tap is not defined in Ruby < 1.9, so we probably want to avoid using it.
Should either be a temporary table or go into the specified output schema.
Agreed.  Additionally "integer" is misspelled.
Even after some search, I am still not exactly sure how bernoulli_distribution.operator(...) works. I assume it simply returns something like 
"generator.operator() < generator.max() * this->p ? true : false".
(http://en.cppreference.com/w/cpp/numeric/random/bernoulli_distribution/operator()
http://www.boost.org/doc/libs/1_35_0/libs/math/doc/sf_and_dist/html/math_toolkit/dist/dist_ref/dists/bernoulli_dist.html
http://www.cplusplus.com/reference/std/random/bernoulli_distribution/operator()/ )
`man clang` and `man gcc` mention the `CPATH` environment variable to pick up the includes.  Nothing about -L libs though.
Needs use the new options syntax (look at other formulae for examples), and use `build.include?` rather than inspecting ARGV directly.
Good work. I'd vote to just make the `ghostscript-fonts` a depends_on without an option and then we don't need this caveat at all.
Can you add a comment on why this is needed?
Just in case there weren't enough cooks yet:

* The closure should definitely be added as `faye_client`, `others_editing` and `ping_interval` are effectively global variables at the moment;

* The larger question of whether this should be extracted to a separate file or not is more interesting. Of course, compression might not make a huge saving and maybe you have are fluent with `ack` for finding JavaScript but the assumption I would challenge is *why is this so specific to this one page?*

  Surely, this functionality is actually quite useful: being notified of other users on the same page simultaneously is something that could be used in myriad ways.

  Perhaps the fact that we are so inherently coupled to the variables passed from Mustache is actually a smell. What if, instead, you included some some sort of reusable plugin and then did something like:

```javascript
(function ($) {
  $(document).ready(function () {
    $.GollumEditor();
    NotifyPresence({
      client_id: '{{faye_client_id}}',
      token: '{{faye_auth_token}}',
      user: '{{current_user_name}}',
      email: '{{current_user_email}}',
      page: '{{escaped_name}}'
  });
}(jQuery));
```

(Warning: fatuous example above -- particularly as it doesn't let you customise the message -- but you get the gist.)
--trace is what commander uses.  --debug was also used by rhc_common.
Will fix.  Older help used the sentence style.
Code de debugage que tu peux enlever je pense
I'm glad this amuses you. For the next time you make a code review and notice this obvious statements I suggest you add an useful comment something like this: ``You should remove this comment because the code is clear here.``
Spelling on "mehods".
the default should be removed from the code then
Works for me. Thanks for trying it out.
We should probably check this at the beginning of the method and bail out early if `cordovaRef` is undefined.
This could be an object literal instead: {}
I think this is one people will want to be able to toggle frequently--could we have a three-finger shortcut instead (maybe Ctrl-Alt-H)?
typo: "stae"
I think we can just get rid of this comment.
True, not the cleanest way. I will check for `enabled` in the `beautify` method.
This is a weird way of doing things but ok.
The diff isn't showing the actual method, but the before_pause method is still an attr_writer, it should be `before_pause=` and do a register_hook
All the code in this test is commented out?
I do not understand this line. Now the scenario_risk never computes insured losses, how can this replace a previous test related to insured losses?
What about the comment

# same, but with an insured calculator

?
I think you can do `helper.toString!indexOf \livescript`, looks more ... "coco"/"livescript" way to me
Why is something in account and something in frontend? This smells wrong. :-) Probably we could move all this to account, no?
Good idea to use this app.
These lines were copy paste from the original class but I'll change it I guess.
Just to clarify, url is the remotely-addressable url, and filename is the key that's used by the local file store and S3?
Gotcha.  Done.
Change this to 1305px and add margin: 25px auto 0 auto, so the container will center on big screens :)
Why do we need to do the setTimeout 0, is there a way around this?
might want to ensure callback is a function here.
not necessary to include vendor prefixes for border-radius
'Invalid or corrupted PDF file.' instead of `exception.message` (or omit this parameter)
Actually, the `rect[]` values are in real coordinates, so if I make it 10, it will have a negative size.
The usePrivateBrowsing attribute has been supported for quite a while, and it's currently supported in Firefox 17 (release), Aurora, Beta and Nightly (it was introduced in Firefox 13).  In builds without per-window private browsing support (anything less than Firefox 20) this value is kept in sync with nsIPrivateBrowsingService.privateBrowsingEnabled, which means that you can just drop this whole if block and everything will work correctly in both types of builds.
Renderers listen directly to the image's `load` and `error` events, they don't listen to the tile.
SDK 暴露的所有函数都在 Qiniu::RS 名字空间下，实际上 Qiniu::RS 表示 QiniuRS 含义，作为一个完整的存储产品理解就好了，不要理解成独立的 RS service模块
Yeah, I think that is fine as long as things still seem to be safe when it fails (on systems without CAP_SYS_TIME on the fs, etc
Minion. The Salt port installs a *rc* script which should be used to manage your.

***an*** is used to preface singular nouns which start with a vowel or nouns starting with a silent ```h``` such as *hour*
Please specify the latest `:commit` and ask the author for a version tag with [this template](https://github.com/CocoaPods/Specs/wiki/%22Please-add-semantic-version-tags%22-issue-template).
:+1: For not making a typo!
Windows has been unsupported since 3.0, so don't worry about that :) Global setting to enable/disable dyndns would be nice to have.
Can you remove inmobi specific path from here as well?
So this rules method worked:
```ruby
def rules
  {:about => lambda { true } }
end
```
So I can do that but the `skip_before_filter :authorize` line seems to be cleaner and we're still calling `before_filter :require_user` so either way works.
Nice, and is it possible to remove maruku completely from the initializer and only require it for build phase? I mean, we do not need it for development, do we?
please remove the TODO before squashing as there is nothing to do in this method
`MethodDescriptor` I like. Make it so!
It was created by Inkscape, so we can use it, right?
Make it "changeCurrentFrame": the name "switchToFrame" is already used for a slot, and API that is exposed to the JS side.
And I think this could also made private: I doubt it should be used from the outside.
Pedantic: I think these should be uppercase.
"routines"-> "classes and functions".  Also, perhaps "other quantites"->"other cosmology-related calculations" or something like that.
Yes. Starting vnodes has always been a synchronous action for vnode manager (formerly master). We can reduce the default value to 1 if we'd like. No idea how long people expect to wait for hinted handoff to kick in after a reboot. Alternatively, I can start multiple vnodes in parallel -- but unclear about disk contention issues. Or, could just sends messages in this management tick; which trigger the actual vnode starts. In all cases, the actual starting of an individual vnode would remain synchronous though, just not the entire block.

We already have issue #150 filed to look into starting vnode asynchronously. I currently worry that we have some assumptions built-in about synchronous vnode starting with respect to handoff, vnode proxies, etc. So, would be a change we would need to reason about and test heavily.
realised this is a stupid question, since it is the riak_core_sup that will restart the riak_core_metric_sup, args and all :blush:
On second thought, maybe putting the blog on a subdomain is better. This makes me cringe.
I'm not sure Sign/Verify need their own tabs. How about just a single "Messaging" tab?
I agree the gui settings shouldnt be permanently set by cli flags, but if you set a setting by a cli flag, the gui should show that setting, and if you change it in the gui thereafter, it should change and be set.  Id say thats by far the least surprising behavior.
has all this code really changed, or is this diff a bit of a mess?
It seems to me, that if someone wants to improve the priority of a transaction, they do actually want to mine that transaction. What's the point of setting a priority of a transaction that you're not going to mine regardless?
But if it were ProcessBlock, it would be unclear and searching to code for where the printf was called would be harder (which is the point of prefixing the print with the function that called it)
thx, that does it
This will go back to destroy.
Is the pipe the appropriate thing to use to encode data? Why encode things here? If it needs to be send across the wire, the implementor of that application can just encode the entire message.
Do you want just a bare print here?  We've been moving towards more structured logging in general, so I was a bit surprised to see just a simple print for this failure...
Ok, will remove the complete block. Is it ok to add a new commit or should I amend?
@snapshot = etherpad.tryDeserializeSnapshot @snapshot
Copied that from `NISwitchFormElementCell`/ `NISliderFormElementCell` ... but I can fix it there as well :-)
When listing large number values, its best to list the factors; for example  "60 * 30"  for  30 minutes, this just makes it more readable and easy to switch to say 25 min later if that is a change request.
that is correct put it in the common EmbedPlayer.css
Added to verify infinite year loop bug. This test is not really exhaustive though...

I want to take the examples from http://tools.ietf.org/html/rfc5545 and use some of those in these tests soon.
What's with all the casts? This is C, we don't cast the return of `malloc`.
Now I did:

```diff
diff --git a/src/errors.c b/src/errors.c
index 6621651..12adb42 100644
--- a/src/errors.c
+++ b/src/errors.c
@@ -100,8 +100,8 @@ void giterr_set(int error_class, const char *string, ...)
                        git_buf_puts(&buf, lpMsgBuf);
                        LocalFree(lpMsgBuf);
                }
-#endif
        }
+#endif
 
        if (!git_buf_oom(&buf))
                set_error(error_class, git_buf_detach(&buf));
```
A good point. That's something that we can improve

2012/10/4 Terence Yim <notifications@github.com>

> In
> sensei-core/src/test/java/com/senseidb/search/req/mapred/FacetCountsMapReduce.java:
>
> >      TermValueList termValueList = accessor.getTermValueList(column);
> > -    HashMap<String, IntContainer> ret = new HashMap<String, IntContainer>(countDistribution.length);
> > -    for (int i = 0; i < countDistribution.length; i++) {
> > -      ret.put(termValueList.get(i), new IntContainer(countDistribution[i]));
> > +    HashMap<String, IntContainer> ret = new HashMap<String, IntContainer>(countDistribution.size());
>
> It seems like a bad good design for public interface to extends from
> Serializable. We should rather have a Serializer interface that can
> serialize SenseiMapReduce, which also allow us using different
> serialization strategy.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/linkedin/sensei/pull/57/files#r1764511>.
>
>
I think the user doesn't matter here, so we can have the post modelmaker create it.
I think I'd ditch this test, too. It's just duplicating the code used for calculation.
There was a talk in pull #88, to update `utils.js:saveScreenshot()`'s description.

I would like to propose (in a follow up bug) to rename `saveScreenshot` to `saveDataURL`  or `saveDataURLToFile`.
Fortunately `saveScreenshot()` [is used only][1] in `controller.js:MozMillController.prototype.screenshot()`.


Note that there are `saveFile()` and `saveAsFile()` methods already in `utils.js`!



[1]: https://github.com/mozilla/mozmill/commit/eefed2195e "Bug 761423 - screenshot() method should save JPEG images and offer testsdetails about the taken image. r=jhammel"
Yeah, that was the lazy way. I'll see what UPSERT can do (Josh told me about a MERGE command that he desperately wants to see in Postgres), or just make an other sql call inside the post. Or tweak the get.
Perhaps it's a bit late but after having talked to Lars about this, he agrees that it's better to use the logger directly. I.e.:

```python
logger.error("Failed to foo and bar", exc_info=True)
```

That does the exact same thing and uses "pure standard lib".
Also the code in line 51-54 can NOT be in the except block because those lines don't do anything with the db.
I'm guessing that just didn't occur at the time. We caught it with Jake's clirr plugin. And Julian now has a task for 1.9. I think that's the long and the short of it.
chef_db has a fetch_requestor function, can it be used instead?
So this is a learning moment.  :)  There is a file called config_custom.js where you override values in config.js.  I think you just need to move these changes into that file instead.  Also - you can push more changes to this branch and the PR will get updated automatically.  Thanks, L
It is a query used as a filter, I'm not sure if it is the same that a filter, or if it has more sense. The documentation says: "The filter can be defined using Query DSL" so, I think that we must build the filter in the same way that we build a query. Honestly, I'm not sure...
Is this dead code as well?
I agree but don't have any better ideas.
ну нє. для генерації урла є роутер якому передаєш назву роута + параметри + вказівку генерувати абсолютний урл
I don't see any route pattern that could cause this. Why is it needed?
I know it was present in the old code. But if you rewrite it, we don't need carry something that serves no purpose.
If it isn't countable, will return null. I also think that your code is more generic, and is almost what I propose, but @bschussek likes this way.
Ah, I already rebase this PR, that's why you don't see the other commits. :)
`return is_file($file) ? @unlink($file) : false;`
As the loop is only used to remove private services, the check could even wrap the loop.
this is not consistent. Above, you replaced the threshold parameter with ``1`` when calling the macro and here you removed it entirely
``` php
<?php
$parentView = $view->getParent();

if (null === $parentView) {
// ...
} else {
// use $parentView rather than $view->getParent() * 2
}
these should all have ()s since they modify state (offset)
int postIndex = self.posts.count
`map` is for single line, use a full `each` block for the multi-line.
你的意思是不需要这几个参数的介绍？
- 论文中不应该有强调，强调更不应该用黑体
- 如果一定想用，那是他自己的问题，不是我们写的模板应该解决的问题
- 我们写这个模板的意义到底是什么？不是传授LaTeX基本语法，更不是教用户怎样自定义，而是让用户体验用LaTeX写作的优势，可以几乎脱离格式，只关注内容本身，所以我们要做的就是让用户感觉到，用尽可能少的东西就能写出一篇符合要求的毕业设计论文，而不是考虑那么多可能的需求。
A bit nitpicky, but the name checksd just comes from the fact that we're autoloading a directory, not from the thing itself. Can we call this Check or AgentCheck? It's something our users will extend so the name should make perfect sense. The D suffix usually implies directory or daemon and this is neither.
arg my comment disappeared in the code where i asked if I have to throw an exception.

I wanted to remove that get, but i didn't now if it was better to throw an exception or if another beavior was better.

Initially i let it with a comment to discuss about it with you there
I actually prefer the other approach, but I'm happy enough for it to change...
adding an empty phpdoc is useless
~ gitignore в помощь
Right. The basic impact is it ensures that the OperationContext understands that it's executing a "write" operation and therefore obtains an exclusive lock, ensuring that 2 write operations are not concurrently executing.

Admittedly, it's a bit of an indirect way of doing that, one that people can easily misunderstand. Any of the APIs that result in model modification will also result in the exclusive lock being taken, in those cases without requiring any special parameter. There's also the OperationContext.acquireControllerLock() method that makes things explicit. (Note I'm not advocating changing this code to use acquireControllerLock(), just an FYI.)
clean up the file from json references, we will not support it
looks great to drop node-get if @tmcw approves. My only thoughts: also remove from package.json and consider re-throwing errors if request does not already do so. For example, node-get parsed failed responses and attached the http code, like 404, which was useful. We should try to maintain reasonably nice error messages for users since TileMill users will get the modal and error message here directly from request if the request fails.
> That's true. But setDisplayedApp has been exposed only for TrustedDialog :)

hehe I don't remember to do that :P It was already there https://github.com/ferjm/gaia/commit/61e23eb59cec54107b5ea83c22971ce1c900a294 :)

I'll do what you said and get the `setDisplayedApp(null)` back getting rid of the `showHomescreen()` function.

Thanks Vivien!
agreed and solved.
I would like to keep all the hacks in one place: webapi.js
https://github.com/lightsofapollo/b2g-scripts its bundled via npm like test-agent and others.
nit: never used.
Is this something that should be use by the battery as well? (Just asking, no reasons to do that here).
the first time I see this kind of comment in HTML probably works
Done, and <code>cropImage</code> is a function defined in my <code>utils.js</code>.
That function is for cropping the onloaded IMG.
If a DIV(parent) contains a IMG(child), the IMG will be cropped and fitted to vertical or horizontal center.
`alarm.id` check should only affect L363-364, L365-386 should be unaffected (so we could refresh the UI with default value).
Why are you putting ```downloading``` and ```cancelled``` on the descriptor? These properties will now get serialized into IndexedDB. Is that intended? Also, when do we remove or change them again to indicate that they're no longer downloading or that the installation wasn't cancelled. These seem like transient states and should probably not be on the descriptor. In either case, though, they should be updated.
Nit: replace the three dots `...` by an ellipsis character `…`.
Nice catch, regex I ended up not using.
Chris wanted some comments on the lines above explaining units.  And I think also symbolic constants and comments for the 1200 and 60 numbers. That could be a different followup, I suppose.
vingtetun wrote:
> Can you leave this code. It is needed for some demo purpose:)

I think I've fixed it and submitted a new PR. I'm pretty new to git so I 
hope I didn't make things worse! I forgot to refresh my code before 
pushing my PR. :)

-- 
Eric
Just as style points, I prefer to omit `()` and `{}` where not necessary. 

```ruby
options.merge! :octokit => { :media_type => :raw } 
```
Typo in optimizationLevel
please split this spec into two (for true/false cases) -> also correct the name "should return TRUE if the highscore is better"
Actually not ... I´ll change that :wink:
Does this mean the plugin is opinionated about using handlebars?
global? `var inline = options.line == "true";`
Consider choosing a native internal colorspace choice to avoid translating these a bunch.
This method doesn't do anything - get rid of it.
Should be `Exception of class #{e.class} with message #{e.message}` so that we can get the actually useful information.
Alright I will finish this tomorrow or so, so please don't close this.
And thanks for giving me a hand.
Does the message/input become visible anywhere? I'm fine if it's cryptic in the debugger as long as it 
A) fails
B) gives me the message/input SOMEWHERE.
You bind to a port. We are talking about a TCP client here, not a server
Looks like you're doing browser sniffing to determine the features of various browsers. Can you find a way to do feature detection instead?
Changing code from deferedGenerator to inlineCallback should just involve changing

```python
wfd = defer.waitForDeferred(d)
yield wfd
res = wfd.getResult()
```

to

```
res = yield d
```

There is a gotcha that the `yield` expression can't occur everywhere.
I think this should be `open(tmp_path, 'wb')`, or things might break on Windows.
This feature could also be needed for the css generated with command line tool. I think this should a parser environment setting that could be set both from lessc and browser.js. See my pull request for the reference https://github.com/cloudhead/less.js/pull/880
Why should change int to intptr_t here? It is not a pointer.
Why we should add '-fpermissive' parameter? It's for template inheritance. But cocos2dx haven't used it.
Great, it works! I'll update documentation. Should I also rename Serenade.isIE7 to Sereande._isIE7? Or replicate it on each source requiring the IE7 detection?
Not sure all of this gist processing is necessary. Didnt want to muck around too much since I knew the Save/Fork buttons worked well.
I would use a 415, which isolates this type of error from a "not found" error.
why the change in language?
Think how much typing you'll save...
`param` is not imported at this point and - should `topo.version` be populated before it is imported and the message displayed after the import?
The admin wants to see the users directory after destroying a user. But then the user who just canceld their account should be redirected to login page - or maybe root. The session is canceled automagically.
I added a comment, maybe we could export the code to a function in the future, if we see that we're going to reuse that approach more than once. I will appreciate if you could take a look to the comment, I believe we could probably express it in a better and short way. :)
When is "upgrade_to_primary_user" shown and when is "verify_primary_user" shown?
there are two browser declarations
Just trying to understand the difference here for my own benefit: so it used to get the default connection and use that as the prefix for the cache key, but now we don't need to because it's always called "datazilla-datasources".  Is that just because we had wanted to be more dynamic before, but ends up we don't need to be?  or is this specifically related to this new caching?
Use ``{# comment #}`` rather than an HTML comment that gets sent to the user.
Cool. TIL!

Matthew Riley MacPherson | http://lonelyvegan.com


On Friday, 18 May, 2012 at 4:12 PM, Brian J Brennan wrote:

> > @@ -3,6 +3,8 @@ var express = require('express');
> > var configurations = module.exports;
> > var app = express.createServer();
> > var settings;
> > +var redis = require("redis");
> > +var client = redis.createClient();
> > 
> 
> 
> +1 @ednapiranha, camelCase for localVars. Underscores are generally used ONLY_IN_CONSTANTS and for _privateThings.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/newnewtab/pull/12/files#r845201
> 
>
This happens at module load time... That's kind of icky. It's better to have this in an init method or something that gets called at startup.
Add `build` which forces to build a new object, even if registered as a singleton. If an instance is requested, return a shallow clone of the registered instance.
Need space on either side of the `=`
The name of this method should be something like `is_ruby_dsl_filename?`, since it is a very public API, and the name is very generic - it isn't clear what this actually applies to.  (eg: I initially ran across it and wasn't sure if it inspected string content, or some custom type, rather than a filename.)
@daniel-pittman That should be `get_group`
I would recommend some line-breaks #readability #getawesome
A = new C();

Assign to A the return of C

Even if you leave in blank the line, phpDocumentor by default treat the return as `@return self`
I think that Logger should only throw exceptions when is strictly needed. IMHO this case is not enough critical to cut the flow with an exception.
`modifica` -> `ricarica`
`la strada "hello/world"` -> `il percorso "hello/world" all'indirizzo della pagina`
Added date information in the comment
Just move the // CraftBukkit end, don't make a new line comment.
Seems these alias names should be defined in the AliasManager setup not via startup setAlias calls, otherwise I can't rely on 'DPWebAPI' existing unless this component is enabled?
missing space after echo, added = after echo (from <?=)
In m opinion, we can consider that the versions given are integer, as these are major versions. Hence this line
Interface Vererbung bei älteren PHP Versionen (ab 5.3.10 ist der Bug behoben) über zwei oder mehr schmeist einen Fatal error.
Fatal error: Can't inherit abstract function Symfony\Component\Security\Core\User\AdvancedUserInterface::isAccountNonExpired() (previously declared abstract in ...

Siehe auch:
https://bugs.php.net/bug.php?id=43200
I sorted it out using toScalarValueArray method...
https://github.com/kapitchi/KapitchiBase/blob/master/src/KapitchiBase/Mapper/DbAdapterMapper.php#L40

Usage: https://github.com/kapitchi/KapitchiIdentity/blob/master/src/KapitchiIdentity/Model/Mapper/IdentityDbAdapter.php#L31
Why an extra line?
This check would be useful only in case when there is more than GitHub resource owner registered, because this resource owner by default extends `AdvancedUserResponse`.
Can we add either a maximumRetries or a maximumWait here, I think maximumWait is likely easiest to understand, and have it exposed via the api

    var maximumWait = opts.maximumWait || 30000;

or such and cancel the replication / call opts.complete with an appropriate error
SQLAlchemy's `ordering_list` doesn't have any helper methods for this. http://www.sqlalchemy.org/trac/browser/lib/sqlalchemy/ext/orderinglist.py

Let's keep the current code for now. Just make the two fixes I've pointed out above.
in-cache ?
Maybe tagging services here ? i.e.: `hwi_oauth.resource_parent.oauth1` & `hwi_oauth.resource_parent.oauth2`.

And later just do in compiler pass: `$container->findTaggedServiceIds('hwi_oauth.resource_parent.oauth1')`