labofsahil/github-event-dataset-2012 huggingface dataset:
This is a really bad reference to point people to, as it's targeted at JBoss AS developers. We need to find a better one.
Let's hold off on that for now; I think it'll be pretty obvious to users that they shouldn't call function with keyword args. I don't think it'll be a big problem, and I don't want to add too much to the generated code at once for performance sake. After you are doing I'm going to do some benchmarking to make sure it's still fast. It should be, but we don't need to introduce another check on every single call.
`ApiKey` expects a user so it would not make sense (or be possible) to assign the `UserProfile`.
Nice catch. If it works without the password I say go for it.
This fix is because time is an object which contains duration, percentage, and seconds. I'm assuming we didn't notice this before because timeUpdate was firing so often that it update anyways.
Looks like a bug! Did you mean to define "vot"?
I think the `assert` added to the tests should be here as well, not?
Maybe "Level" is too generic, and may be confused with logging levels. How about "Scope", "Domain", "Realm", "Orbit", "Rank", "Echelon", "Degree", "Grade", "Stage", "Rung", "Stratum".
why is DEGREES off by 1?
Again, don't use toFixed here, put it in later. Also, this will prevent you from doing `"1.0" * 0.5` i.e. a string times a number.
I haven't used this a lot, but apparently you're supposed to put this function right after calling graphie.init up on line 42.
this is ugly, pleaes just parse the values like in the upload helper and format them back in the database format if needed.
Change for a generic url
All the methods on this class can go to the appropriate classes in the model.
I browsed thorough the site and  from what I've seen, 'feedback' is the only button name there is for pagination on the mobile version of Input.
This locator is too 'loose' and counts a warning message as a valid message.
Yes you can, if it's private for the class.
`@selected_plugin_names` is used in the [form partial](https://github.com/resolve/refinerycms/blob/master/authentication/app/views/refinery/admin/users/_form.html.erb#L39) and it'll throw an exception if you  remove `refinery_users` node and try to save the form.
Can you change the Type to Group? A couple of lines higher there is still a groupId mentioned
Please document all of these functions
I thought it finds Java unit tests... I guess I could rename it to JavaJUnit4TestFinder to be consistent
I don't really understand this. We could revisit it later, but what methods do you think need thread-safety guarantees? There are no mutators, only getters.
Can't we use here only unique number specifier? Since it is unique it should be usable quite well.
copy-pasted from the other templates, so they all need cleanup :D
Aren't we using <a> everywhere else? Also msg attribute
There should be check for TLS connection and client's desire to use PLAIN authentification without TLS.
geeft een naam aan de entity. (name)player is beter dan de de EntityMainCharacter als je hem moet oproepen in een andere entity.
You can use directly the `config_item()` function and you won't need to get the whole CI superobject.
Метод не будет работать при массиве DNA отличающемся от 100
Неправильная реализация метода mutate. Заменяться должны не первые N символов, а N случайных символов. То есть, мутировать может и 99-й символ, если ему повезёт.
Также в одном из комментариев в обсуждении проекта Рахим отметил, что мутировавший символ должен обязательно замениться на другой. В текущей реализации символ A может замениться опять на А.
I prefer the 1.9 style hash syntax.  Up to you:

validates :name, presence: true
semantically, `hr` is kind of a weird choice here. Why not just use `div`?
Comparison with `undefined` should be done via the `typeof` operator:
```javascript
if (typeof(error) === "undefined" || error === null) {
   // ...
}
```
to nit pick, as is now it will never be None. Will remove it and say: if fit, ...
Yeah I'm always in the habit of doing JSON::XS.  I've seen projects use JSON::Any (and YAML::Any) but it looks like that's deprecated in lieu of JSON proper.  Heh, compiling yuk.  I always prefer XS modules over PP.  I'm going to remove DBIx::MyParsePP I think from the dependencies.  Seems not necessary since the mysql server can just report the errors directly and we can start up faster.
is this enough to just ignore subsequent lines to fix this issue ?`maybe check the second line is well the error "The process has leaked file descriptors" error, or that first one contain the expected SHA1. I'd like we avoid letting other error pass without a base check
Could you please reduce the line width by vertically aligning the parameters? It makes the code a bit easier to read ;-)
Change this number if you want to specify a different minimum width for the images
Yes, thanks:)
"trackstart" => "trackend"
Have you tried Mockito.eq("Person") instead of Mockito.argThat(TestUtil.equalsMatcher("Person"))?
It doesn't look like we have a need to call `chef_object:normalize/2` in a generic context where we are passed data and it's type. So I'm thinking it might be cleaner to define type specific functions or even move the definitions into the type-specific helper modules? Thoughts?
Then we don't need to say "Default is to refinery" because it will be shown :-)
OK, I will remove it~
Extra parenthesis here. Should be `Math.floor(Math.sqrt(r)*logn)`
It's probably wise to just enable the most popular ones, and be done with it: svn, git, and hg.
The space between `...Extension` and `</...` should be removed
Because you use different formats you can't use a specific extension in your text. Use something like '... add the confguration to your configuration file.' And add file comments in all code blocks below:

    yaml file
    # app/config/config.yml

    xml file
    <!-- app/config/config.xml -->

    php file
    // app/config/config.php
Yep, not sure what happened there, I have removed it
:+1: for letting marek teach us things for the form newbies
如果<literal>proxy_pass</literal>没有使用URI，传送到后端服务器的请求URI跟客户端发起的原始URI是一样的。如果nginx改变了请求URI，则传送的URI是nginx改变以后完整的规范化URI：
address用来描述计算指定的variable所依赖的客户端IP地址。
定义客户端的IP地址从指定的变量获取。
Soon Prerequisites will be ActorSystem. Full circle.
Тут лучше угловые скобки юзать.
все ньюлайны у меня не просто так.
А если я два файла подряд расшарю? Почему ты завязываешься на то, что урл
обязательно копируется в буфер (который один)?

Блин, добавь сюда идентификатор того, что расшарилось/получено, это же
просто элементарно хороший тон.
В том, что формат даты будет браться из локали.
Ну и стоит отметить, что `std::swap` может быть быстрее ручной реализации, особенно для implicitly shared классов, за счет прямого обмена указателями на реализацию вместо тупого копирования и инкремента-декремента ссылок.
`type( nil )` returns `nil` and thus this method will error when attempting to register a global listener.
Sir, are you just bored or what? lol

Will fix!
CREATE TABLE IF NOT EXISTS `lang_strings` (
  `id_string` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `string_language` smallint(4) unsigned NOT NULL,
  `string_package` smallint(4) unsigned NOT NULL,
  `string_key` varchar(255) CHARACTER SET ascii NOT NULL DEFAULT '',
  `string_value` text NOT NULL,
  PRIMARY KEY (`id_string`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
I am fine with the first remark but unsure if removing it is a good idea, as the mapController is used frequently when tracking my position current position.
I guess that can be simplified as:

    fetchOptions.getFetchMode() == FetchOptions.FetchMode.EAGER
Shouldn't the UUID be transmitted as a part of the command, and re-instated on the remote end?  The way you have done this, the remote instance of the command will have a *different* UUID from the local instance (prior to transmitting) and you'll never find it again!!
Here's a comment on a line...
Ah, I see.  I missed the fact that hist doesn't take a base as argument.   hist is a bit of an anomaly -- it takes a 'log' argument, whereas most other things (except bar*) work by requiring a subsequent call to `set_xscale` or `set_yscale`, which of course take an optional "base".  Making this also work that way would be a little bit of work, because this minimum adjustment stuff you've added here would have to be moved to the draw phase.  Ideally, that's where I'd like to see this go, but I don't know if that's worth abandoning this fix, and we've have to maintain backward compatiblity anyway -- this "log" kwarg goes back at least 5 years, as far as I can tell.

We could either add an additional keyword "log_base", or extend "log" so it can be "True" (meaning base 10 as it does now), or a number, meaning a base.  I would also recommend updating `bar*` to be in line with that.

However, I'm aware that none of this is premised on any real world use case -- just my own desire for consistency across uses of log scale, so I could be persuaded to leave this as-is by further discussion.
Is `x` always a nonzero integer? If so then, at present, this calculation rounds down on division by two. Since I am not sure what `color(x)` does, this concerns me a little. The line above, however, `np.abs((3 * x - 1) / 2)` is fine, since `3x -1` is always even.
This seems weird. Isn't that just the same as `return makeRunner`?
Is it worth adding a TODO next to the xpath locators to work with webdev introduce ids or css to make selection more specific?
Согласен.
Готво :-)
Я имел ввиду то, что описал @AlexeyDsov  ;)
Ну нет, так нет, это не так и принципиально.
So this looks perfect:

```clojure
> (mk-array-value (IntArray. [1 2 3 4]))
#<ArrayValue <ArrayValue ints:IntArray(ints:[1 2 3 4])>>
```

But here we're able to create an `IntArray` of floats:

```clojure
> (mk-array-value (IntArray. [1.5 2.5 3.5 4.5]))
#<ArrayValue <ArrayValue ints:IntArray(ints:[1.5 2.5 3.5 4.5])>>
```

Wondering if we need something like this instead for all these multimethods:

```clojure
(defmethod mk-array-value
  IntArray
  [x]
  (ArrayValue/ints (vec (apply vector-of (cons :int x)))))
```
Is the space in this vector needed for the test?
Lazy loading will pass it through
In our use, yes, as we expect the deserializer to overwrite the properties in the fetched entity.
you can use alpha.display_vector("Alpha Vector"). Thats much shorter :)
Good point, that's better. Changed it.
Thanks!
Isn't this check done within get_node_text() too?
In your app (where you use the vanity gem), when you make experiments you call ab_test "Test Name" { block } which is ```#ab_test(name, &block)``` in ab_test.rb, which calls ```base#define``` via inheritance.

/runonsentence
nice!! let me do the switch, thanks.
Identifier is injected by the queues when message is dequeued. Outgoing messages don't necessarily have one.
as for dropForeignKey
Please revert to as it was before. According to our coding guidelines we don't indent has values.
Are you sure ``'Zend\\Uri\\Http'`` has the correct type as ``string`` is not a sub-type of ``string``?
Are you sure ``$filtered`` has the correct type as ``*`` is not a sub-type of ``string``?
I was originally going to add a bunch of native code that would only work with that API version, but I may not. This works for now, since we've compiled it for nearly the same device you have for the Android store. I guess this is fine.
Find instances of ajax == NodeAjax, replace with isNode check.
Are you missing a second line in this one? What do you expect the parser to do?
I agree with @nilshoerrmann .. This should be in class `General`
Add all arguments to the callback.

Space after `()`.
I don't like hex encoding. It has low entropy (only 16 characters are used) in comparison with the whole alphanumeric range. So if you would use whole alphanumeric range, you should encode the same random number much shorter. Thus have much shorter channel_id and URLs, but same randomness. Use `django.utils.crypto.get_random_string`.

But it is good to have a separate function for this, so that later on you can just change this function if the way we want to generate those IDs should be different.
I am deleting it. As far I understand it just tells you that this was automatically derived from some similar translation. And that you should check it. But you can check what Internet says about this.
no, its difficult for parsing from web :)
Now I just simply loop over panels ;) appendTo just moves the panel. Fixed.
I dont know what do you think about this..
So why is here `'1'` and not `1`?
Not really correct check. Much better check would be to check if user is authenticated.

And also add comma to the end.

```
'locations_form' : forms.LocationsForm() if getattr(request, 'user', None) and request.user.is_authenticated() and request.user.is_staff else None,
```
+?> - Символ плюс значит, что все, что идет после него является новым кодом, а вопр.знак и знак больше является закрывающим тегом php.
\ No newline at end of file - Какая то хрень, которую добавляет geany. Мне надо быть внимательнее и не допускать ее.

Но вообще тебе бы прибить эту ветку..
I meant like, as a comment
Why did these need to change? the fact that it didn't break any tests means we have some untested and unverified cases here as well.
Instead of return?
Is it more appropriate to create hashes for the URI rather than putting the textual arm_group_type into the URI?
I see. I still would like to keep the comment about the code reuse from Voldemort here, so will use private comments for them  instead of javadoc.

> On the voldemort code reuse.. if it really is a copy&paste work, do you think (after they are both integrated) we would be able to move common routines in the hibernate-ogm-core module as a general utility library?

Yes, I think that way. There is a couple of places where I have added a comment like `Reused from VoldemortDatastoreProvider.`
1. `RequiredProp` enum
2. Helper classes

About the first one, this would be able to be moved to a general utility library because it checks the required properties to start up datastore providers and all the datastore providers should check them when they get started. I believe that currently there is no check for the properties on Hibernate OGM.

About the second one,  I've checked Voldemort,Redis and Riak with Hibernate OGM and they share one thing about how they store data which is use JSON. In this case, I think that routines related to JSON processing, serialization and deserialization, would be able to be put as a general utility class.
installer.pl do it
if 0 means false, use $FALSE, otherwise define a constant in pf::radius::constants
This seems counter intuitive that the toBackup() method doesn't return the input to the restoreFromBackup method.
Да, понимаю, но то всё PyCHarm  нагенерил, подправлю, спасибо за комммент
`all_items.extend(items);`?
Err, few lines further down. `if(this.data)`, possibly more than just this one.
That would be good, no reason not to supply both.
Totally agree on that: it depends on the project. I can easily imagine people that won't be very happy if some untranslated text will get unnoticed into production because of some mistake or typo that was silently skipped by the formatter.
I think for this special case we can do `File.join('custom', path)` and don't change `resource_file_path` at all.
The value in the exception message should be received, not len(data).  Another spot I missed when I converted to an array of chunks. 

I see -- the recv() call still worked because it was always asking for more than remained.
Add here one empty line before, group imports based on Python package (Djagno is one, lazysignup another).
Why not just
for (SlotType1 slot : request.getAdhocQuery().getSlot()) {
?
Hi, not much more than a ditto here!
This was Barney's call, but I think I agree with him.  Real images normally have a sky level in them, so as an astronomer, I would be confused if my config file specified a sky level and yet the final image didn't have it.  (Just poisson noise consistent with that level of sky.)  So I think it is clearer to require postsubtract be explicitly specified to get that behavior.

My nitpicky comment is that I think postsubtract should be post_subtract.
Is it?  I guess I've completely misunderstood your suggestion about that then.  Sorry!  I thought you were planning to do some post-processing to remove the artifact by copying some values at the end, rather than just expanding the image to an odd side length at the start.
Do we need these to return by pointer (rather than by value) at all?  Does the implementation make it hard to guarantee that return-value optimization will work?  Or is it just more useful for clients to have shared_ptrs to these things?
s/ROOT/BROOKLYN_HOME/g ?
Same for this: it's dangerous because it doesn't coerce.
Also, I think we should be stronger typed rather than just taking any types in the map and doing our best. Doing `""+k` is probably going to hide more errors that outweigh the benefits it gives some folk.
I vote for deleting it and adding it only if it's needed (it's currently unused).
you're right, except where catalog consists of instruction to scan some 
local jars, then pull in declared catalogs (which are not allowed to be 
scanned)

--a


On 26/11/2012 12:28, Aled Sage wrote:
>
> In core/src/main/java/brooklyn/catalog/internal/CatalogDo.java:
>
> > +    CompositeClassLoader childrenClassLoader = new CompositeClassLoader();
> > +    ClassLoader recursiveClassLoader;
> > +
> > +    public CatalogDo(CatalogDto dto) {
> > +        this.dto = dto;
> > +    }
> > +
> > +    boolean isLoaded() {
> > +        return isLoaded;
> > +    }
> > +
> > +    /** causes all URL-based catalogs to have their manifests loaded,
> > +     * and all scanning-based classpaths to scan the classpaths
> > +     * (but does not load all JARs)
> > +     */
> > +    public synchronized CatalogDo load(ManagementContext mgmt, CatalogDo parent) {
>
> I think I'm still missing something fundamental about who invokes the 
> scanning and when.
>
> I'd have thought "normal" usage would be to connect to some 
> catalog-server that gives back XML-serialized DTOs. The caller then 
> constructs a bunch of CatalogDo instances (is that "domain object"?) 
> for these, which know all the meta-data they require so no need for 
> the caller to do any scanning on this CatalogDo.
>
> If a specific template is chosen to be instantiated, then some 
> classpath setup will be required (e.g. downloading jars that were 
> referenced in the DTO), but that wouldn't require any classpath 
> scanning either.
>
> The use-case for classpath scanning is to build up ones own DTOs (and 
> then CatalogDo instances) to reflect what is on the local classpath. 
> And scanning would also be used if you want to implement a server so 
> you can auto-generate relevant DTOs.
>
> Is that how it works? Or is load/scan being called in other situations 
> as well?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/brooklyncentral/brooklyn/pull/396/files#r2221102>.
>
A quick Google search tells me Model mixins are used in Django for model inheritance.  Are you planning on doing something similar here?
Needs to have an `if block_given?` because if you use system keys you don't need a block.

Is there a reason it's not using `instance_eval` any more? I thought it was prettier before.
a.button.reset-button  has right margin of 20px. And new layout this leads to button not being properly aligned to the right border
I would probably move all log logic into separate method (to keep code clean and readable)
Based on the asynchronous nature of JS I can not be guaranteed that the local variable is the very same instance and had not been overridden by another spec. I learned this the hard way as I was receiving test failures from one spec caused by spies from another spec.
Maybe we can do a dumb helper for that?
6 --> 7
So one of the things in our coding guidelines now are no commented code (with very few exception) so just delete these lines.
Get to a library, too.
`= null` should be added to the implementation. Does it make sense on the interface? I would remove it here.
Just checked out the recent commits, I think those are much better!  Looks like it'll fail now if the thing we're testing is not executed.
У меня же в readFrom идет закрытие. Или это касается строк выше?
Это лишнее - у String есть метод chatAt
Куда оно денется?
Происходит так:
$ dfdsfsdf
command-not-found
Process finished with exit code 1
I noticed our liberal use of p & puts while in Eggshell. For MVP, we should probably get back in the habit of logger.(warn | info | debug | error) to prevent production related verbosity. There's some logging tips here: http://mikenaberezny.com/2007/02/24/rails-logging-tips/ which might be beneficial to help fork development/test logging to the console
we want it to be configurable instead of hard coded so that customers can try all kinds of things. You might want to talk with Ted about it.
Should be comma separated
It could happen if you open a tool, then select it again while it's loading.
Thanks again, sorry it took so long to land on master.
pep8: no space around `=` in key word arguments.
I'm pretty sure what you do is equivalent to ``exp(score)/\sum exp(score)`` but it looks more complicated.
Can logistic be used with anything other than sLDA?
What is `flat`, `fields`, `attrs`, `commit`? Docstring please.
Added new validation item
As a side note even if this isn't going to me merged, please never ever just comment out an assertion without an accompanying comment – it's even worse than just deleting it. About the only possible way to make sense of this piece of code is to look at the SCM history…
Erroneous edit?
The argtype implementation needs to worry about that - this is the wrong place to fix it.
I know.
But might have a non-spillable case, where you're happy for it to fire a OOM exception.

Currently it's defaulted to earlyAlloc, i.e. alloc at same time where stable used.
It does look a bit odd, I think it _could_ be 0, but harmless as 1.
Isn't the `jbarnette/johnson@refspec` convention pretty well established?
Also, change the `pass` to `continue`. Then it feels like it's doing something useful. Also good if we some day add more junk after it in the same for loop block.
Not all RDBMS supports DbType.DateTime2
`ActiveRecord::Base.table_name_prefix` is only Rails v 3.0.9 - 3.1.0... Their docs mention 2.3.x and 3.x.  Might have trouble getting this in without it working in 2.3.x
We should neither use direct or fallback here. I will remove the type of update completely.
CS guidelines allow the use of double quotes for avoid scape single quotes
That's now part of pull 68.
Give <another example where an INI file is included in a deeper part of the tree. e.g.:

database.@include = 'database.ini'
The event should be "dispatch.error". The RouteNotFoundStrategy in Zend\Mvc\View now does a reasonable job of creating a ViewModel with all the information you need to determine that a routing error occurred.
I find this variable name confusing, because it is actually *not* a UUID, but a "special string" passed along by Rudder (that contains several UUIDs, but also other things). How about "identifier" instead?
Did you mean for this to have package-level visibility?
Will spit out rspec results in xml form, which bamboo can then make use of. will require modifying .rspec but only do so on the bamboo server else users are going to have a not so useful rspec output console.
Since one goal of Tasks is to be able to view completed items as well, Date.today will probably change in the near future. But this is cool!
Feels funny to implement such generic patterns as this & new_or_update on this ActiveModel instance but not others, but that doesn't block the merge. I'd like to get an agreed upon app-wide pattern soon, though.
perhaps I should detail some usecases instead of trying to walk you through the implementation...

contact "Robin Harold Burchell"
"R B" should match
"Rob B" should also
"obin Burchell" should not (doesn't start with R)
"Robin" should match
"R" should match
"Harold" should match
"Burchell" should match
"chell" should not

..get the idea?

i'd suggest splitting both the search pattern and the display label on word boundaries (" " in English, in the real world when we do i18n this will be a lot more complicated) and iterating through each filter word through each display label word
this list is not synchronised with the actual event handlers, so if we add a new event handler, someone needs to remember to update this string, too. Can we change this to a handlers array? a la:

```
eventHandlers = ['onLoad', 'onSetup', ...];
// bind noop by default for these
for(each eventHandler string) { 
  if(aOptions and aOptions.eventHandler and it's a function) {
    curSketch = aOptions.eventHandler
  }
  else { curSketch.eventHandler = noop; }
}
```
This will not work as expected when Metasploit is running on Windows.
Done. Hope this is sufficient?
please split this up to ~80-120 chars per line
Why don't we have this block of code look like this: 

```python

limit = forms.PAGINATION_LIMIT
if form.is_valid():
    limit = form.cleaned_data['limit']

page = request.GET.get('page', 1)
```
I am not sure this does what you want if field is a base field.
```javascript
ZU.fieldIsValidForType("publicationTitle", "bookSection"); // == false
ZU.fieldIsValidForType("bookTitle", "bookSection"); // == true
newItem.publicationTitle = "Title"; // sets bookTitle on a bookSection, because bookTitle is mapped to publicationTitle
```
use defaultValue for these arguments.
Did we mean to delete this line?
I just spotted it when I copied the code from here down to below.  It's probably not a bug, either, but it's better this way.
Any reason why you want to use this switch case instead of passing the handler as I did before?
Missing space and braces here.
Initialize i = 0 at declaration time.
Hard to read, much easier to notice.
Very minor... but I'd make this static final and name it LOG... (PMD/CheckStyle would likely bark about it).
Sounds ok. You should take a look at the UploadManager I added yesterday (it's in master, too).

How about wrapping up with Facebook and opening a refactoring PR to see how it goes?
это я знаю (я проверил :)), но не забудь про panel.append вокруг
Yes. but str_replace("'", "'", $string) does not change anything ;).

Thanks for your work, I spent time searching updated version of phamlp ! "sadly" you're not using haml too but that's definitely a really great job.
I wanted to use that, but `source` and `target` (the terms `VariantException` uses) seem too confusing for this usage.
It shouldn't be necessary to reallocate/recompute this on every iteration. Just put it into a static (module-level?) immutable?
Pah, Java! Alright, let's move on with our lives. 

Might need a @SuppressWarnings to avoid some checkstyle etc. warnings re static.
Porque tirou os parênteses?
You're probably right, I just didn't have enough time to wade through routes hell to fix it. I'll fix if I have time before the deadline...
ok .. i see the issue now.

RestRouteLoader does not extend from ``Symfony\Component\Config\Loader\FileLoader`` so the locator isn't used to locate the file:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Config/Loader/FileLoader.php#L66

i don't know the routing well enough to say how to best resolve the issue.
i will open an new ticket to add support for this syntax, but for now indeed we should update the docs as per your PR
is this even still needed when using composer?
Do we really need to suppress it?
So what do we do then?
Uneeded NL
I think it will be good to have also in case just active model available. I think doesn't really need rails here. maybe you can provide some fallback when rails isn't availble?
How can this be controlled ?
if this keep hapening I cannot trigger a build on the same node more than once [whilst im dependent on its snapshot]
Ну и хрен с ним тогда.
На больших каналах не зафлудится?
inherit from `object`
No need for space padding inside the `$()`
oops - you are right; we are in a loop; I saw this code

		if (this.payloadExpression != null) {
			messageOrPayload = this.payloadExpression.getValue(methodInvocationEvaluationContext);
		}

and forgot we could have set it in the loop.
It was confusing for a bit, but now I see what you are doing. Basically preserving the old behavior while giving access to the folder.
So, looks good and simple, however after talking to you yesterday we kind of both agreed that caching the folder instance was not a good thing (even though that was the original code), since the same folder instance is now accessible by both the adapter and the client which means that the client can close the folder referenced by the adapter. As you said we can probably take care of it in 3.0, but may be updating documentation stating that no lifecycle operations should be performed on the folder?. wdyt?
One last try before I create the JIRA; you suggested they can override doPoll() to provide a custom query; but that would require them to replicate other code.

Would you consider this...

````java

diff --git a/spring-integration-jdbc/src/main/java/org/springframework/integration/jdbc/JdbcMessageStore.java b/spring-integration-jdbc/src/
index 60c503f..4e0123d 100644
--- a/spring-integration-jdbc/src/main/java/org/springframework/integration/jdbc/JdbcMessageStore.java
+++ b/spring-integration-jdbc/src/main/java/org/springframework/integration/jdbc/JdbcMessageStore.java
@@ -516,7 +516,7 @@ public class JdbcMessageStore extends AbstractMessageGroupStore implements Messa
        public Message<?> pollMessageFromGroup(final Object groupId) {
                String key = getKey(groupId);
                
-               List<Message<?>> messages = jdbcTemplate.query(getQuery(POLL_FROM_GROUP), new Object[] { key, region }, mapper);
+               List<Message<?>> messages = jdbcTemplate.query(getQuery(getPollFromGroupQuery()), new Object[] { key, region }, mapper);
                Assert.isTrue(messages.size() == 0 || messages.size() == 1);
                if (CollectionUtils.isEmpty(messages)){
                        return null;
@@ -528,6 +528,10 @@ public class JdbcMessageStore extends AbstractMessageGroupStore implements Messa
                        return message;
                }
        }
+
+       protected String getPollFromGroupQuery() {
+               return POLL_FROM_GROUP;
+       }
        
        public Iterator<MessageGroup> iterator() {
````
Shouldn't we be using this.copy() ??? So we lock???

Also, maybe using Runnable as a callback there is an abuse since it's always run on the same thread. Maybe FileCopyCallback.doWhileLocked(...) ??
I agree that such specific comments on implementation details are fragile, but we also get dinged for not including the values for defaults and making them hard to find. We recently found and fixed issues in some of the Tables documents that quoted a value of 5000 that were actually supposed to be 1000, for instance. The value appears to be correct in this case, and if the implementation changes, we'll have to scour the documentation to correct it in several places anyway, so this is not adding a lot to the marginal workload.
Should retain endpoint name
Prefer that existing white-space not be modified at sites where there are no other changes, especially if the original was acceptable (it was).
style nit: + goes on previous line, not next line.
This doesn't look good. Is this steer torque calc a linear calculation? Please use the non-linear version if so, because speed does vary over a run, ever so slightly, but it does.

If you want linear equations for these forces and torques, you should have the word ``linear`` in the function names so that people know what they are getting.
I checked and this default seems to be used more. RHEL(-based) since version 6, debian(-based), gentoo. It seems RHEL(-based) < 6 is the exception here. Now if only the distros could agree on the lease file location ... ;)
rst allows you to wrap lines in a table cell. I recommend doing so in the above to make this more readable when editing.
I probably would try to right this like:

```
def to_s
  return "XX" unless flipped?
  super
end
```

Nice use of super here!
Yeah, go ahead and add it.  It was just an oversight that it's missing.
I should probably add measures to ShapePart if we want them to be useful. Right now it's very difficult to index into the measures array to find the values for a specific part.
if failsafes are true, then use simpler constructor
Since enabled is already == to FAKE_MODE do we need it in the if clause?
This line is unnecessary?
```
You must also `connect mongoengine`_ to the database::

.. _connect mongoengine: http://readthedocs.org/docs/mongoengine-odm/en/latest/django.html
```
Again, should be a property imo.
It's a bit easier for translators if characters like "\n" don't appear in the text, so in this case, you could split it into 2 messages, that are concatenated with a "\n" in between.

Also please note the typo: meesages

Using format() is kind of recommended in UH, and with it, you buy readability by being more verbose, in which case a line break to shorten the line length would be great (PEP8 proposes a limit iirc)
A while ago I had started with this (see https://github.com/gunnarmorling/beanvalidation-spec/commit/4bc10919cbf007b02ff447abd93ed424e68296c2) and copied the corresponding section from the CDI spec (and @pmuir deleted it over there, see [CDI-262](https://issues.jboss.org/browse/CDI-262)). The wording there was:

> In order to adhere to the rules defined above and to provide integration with Context and Dependency Injection (CDI), a Java EE or embeddable EJB container must provide the following services and artifacts:
>
> * A built-in bean with bean type `javax.validation.ValidatorFactory` and a built-in bean with bean type `javax.validation.Validator`, allowing injection of the default `ValidatorFactory` and a `Validator` for the default `ValidatorFactory` respectively. Both built-in beans must have the qualifier
`@Default`. These beans are passivation capable dependencies, as defined in section 6.6.2 of the CDI specification, “Passivation capable dependencies”.

This seems a bit more specific.
Ah, ok.  Thanks for reminding me.  Let's just leave 'de' off, as we're not guaranteed a German locale, and we're covering the dynamic portions in test_locale, as you've also mentioned.

Thanks!
Can't accept that! :)
Not entirely pep-8, but I code with half a screen on a MacBook Air.
Typo: "and perform and action they please."
This line is not so useful.
`Initializes the proxy with the specified transform matrix`
das Ding sollte anschließend im egg
sein. Deswegen hab ichs ins ressource gepackt

Von meinem iPhone gesendet

Am 27.08.2012 um 21:38 schrieb Bernd Rössl <notifications@github.com>:

> In buildout.cfg:
> 
> > @@ -13,6 +14,18 @@ eggs = robotframework-ioslibrary
> >  [versions]
> >  robotframework = 2.7.3
> >  
> > +[waxsim]
> > +recipe = hexagonit.recipe.download
> > +url = https://github.com/jonathanpenn/WaxSim/tarball/master
> > +strip-top-level-dir = true
> > +
> > +[waxsim-build]
> > +recipe = iw.recipe.cmd
> > +on_install=true
> > +cmds = cd ${waxsim:location}
> > +    xcodebuild
> > +    mv build/Release/waxsim ${buildout:directory}/src/IOSLibrary/resources
> ich würde das nicht moven sondern symlinken. falls das erzeugte binary auch als command verwendet werden kann würde ich es sogar nach bin/irgendwas linken und von dort aus verwenden. wenn es aber sowieso nur als resource verwendet wird ist der pfad ok.
> 
> —
> Reply to this email directly or view it on GitHub.
>
add a parameter for the location, and if it is null you can default to `locationService.getDefaultLocation()`.
@elnur 2.* is a bad idea as you cannot ensure it works with 2.9. However, it should be ``>=2.0,<2.2`` to allow both 2.0.* and 2.1.*
Any test for the fancy show-matching-part? :)
Fix indention here as well please.
do not use a default namepace, use scope operator to refer to a specific namespace
@nukulb I prefer this code here. It's a wrapper that allows me to re-use some of the existing network code written by the browser and makes most sense here. I can rewrite this file so that the wrapper isn't necessary, but i wanted to minimize code changes to the existing browser code as much as possible, so that we are more closely aligned with them.
If the code for standard and custom is identical except for the exec call should we combine it into one function?
I was looking into a unit test, but wasn't sure how to mock out the config object.  Is there a way to?
use DB uniqueness constraint
"... *variable* ..."
This should really be a `__getattr__` here.  @dmclain had mentioned some reasoning for doing a `__getitem__`, but I don't remember what it was.  Unless there's a really good reason, I'm -1 on making this use list-like syntax.