labofsahil/github-event-dataset-2012 huggingface dataset:
Ok, how about replacing "Otherwise, default is {BundleMenuIsRenderedIn}/Resources/translations/message.{locale}.yml"

with

"Otherwise, the default translation domain will be ```messages```."
Style point: please don't indent the `when` in a case statement:

```ruby
case foo
when :bar
  ...
else
  ...
end
```

is better than

```ruby
case foo
  when :bar
    ...
  else
    ...
end
```

Since it keeps the indentation consistent with the `end`
Good idea.
We can parse all options and cache it for future usage.
After our discussion you can easily bind callback on custom buttons and you can chain twig filters to properly escape translated strings.

```js
var buttons = {};

buttons["Ok"] = function() {
     console.log("Ok click");
};

var confirmBox = p4.Dialog.Create({
          size : 'Alert',
          closeOnEscape : true,
          closeButton:true,
          cancelButton: true,
          buttons: buttons
});

confirmBox.setContent("{{ 'prod::thesaurusTab:dlg:Acceptation en cours.' | trans | e('js') }}");

```
May I suggest that instead of `filter` we will receive `options.filter` so we can have it optional (the options object is distinguishable from the callback function so it is easy to make it optional):

```js
function(options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = {};
  }

  options = options || {};
  options.filter = options.filter || function() { return true; };
```
Those items were actually standing out to me as well. Is it possible for me
to make these changes or will @*btandresen need to?*

On Tue, May 22, 2012 at 10:35 PM, aparajita <
reply@reply.github.com
> wrote:

> > @@ -95,6 +95,23 @@ function CGContextAddCurveToPoint(aContext, cp1x,
> cp1y, cp2x, cp2y, x, y)
> >      _CGContextAddCurveToPointCanvas(aContext, cp1x, cp1y, cp2x, cp2y,
> x, y);
> >  }
> >
> > +function CGContextAddLines(aContext, points, count)
> > +{
> > +    // implementation mirrors that of CGPathAddLines()
> > +    var i = 1;
> > +
> > +    if (count === NULL)
> > +        var count = points.length;
> > +
> > +    if (count < 1)
> > +        return;
> > +
> > +    _CGContextMoveToPointCanvas(aContext, points[0].x, points[0].y);
> > +
> > +    for (; i < count; ++i)
>
> ```javascript
> for (var i = 1; i < count; ++i)
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cappuccino/cappuccino/pull/1403/files#r865636
>
Yes, I was going to comment on this pull but you beat me to it!
but /var/lib/libvirt/qemu might not exist, might have messed up permissions
(777, root owns), etc.

On Wed, Sep 12, 2012 at 11:05 AM, Andres Lagar-Cavilla <
notifications@github.com> wrote:

> In packagers/deb/nova-compute-gridcentric/DEBIAN/postinst:
>
> > +        chown(os.path.join(mount.path, 'vms'), uid, gid)
> > +        if mode != None:
> > +            chmod(os.path.join(mount.path, 'vms'), mode & 0666)
> > +        chown(mount.path, uid, gid)
> > +        if mode != None:
> > +            chmod(mount.path, mode)
> > +    except OSError, e:
> > +        # If the mountpoint doesn't exist or it isn't mounted, that's okay.
> > +        # We don't want the package installation to fail because somebody
> > +        # has bad /etc/fstab entries.
> > +        if e.errno != errno.ENOENT:
> > +            raise
> > +
> > +def main():
> > +    try:
> > +        passwd = pwd.getpwnam('libvirt-qemu')
>
> I'd say screw qemu.conf. /var/lib/libvirt/qemu is practice, qemu.conf is
> theory.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gridcentric/openstack/pull/144/files#r1587944>.
>
>
Wuh oh, is that three spaces between classes? :police_car:
I don't think these store calls to c2 are necessary. You've defined a dummy cache store with the same name for both nodes' cache configurations, so you're clearly going for the shared cache store configuration (make it more explicit in the configuration by marking shared(true)), so you should only need to store the data in one of the stores, since they both point to the same place.

By the way, you might wanna add a test to see how it all works in shared=false cache store situations, where each node has its own cache store, and each has a portion of the data. You could try to see if the data from each of the nodes, and their cache store, is used correctly to do map/reduce.
You need to invoke the LegacyConfigurationAdaptor.adapt() method here so that the common properties are set on the configuration object (e.g purgeSynchronously, purgerThreads, etc)
same here, this line should not be changed in this commit as it's not related to your fix.
Maybe we should remove the `[firstname][lastname].org` stuff.
what is this ? The filter does not have any constructor argument. Did you try to run the test ?
IMO, it is better than more than 80 char lines :)

There's probably a best way to write this code;so I think
My vote: 

```Fixed > Broken```

:-) i.e. I don't really mind which goes. They are both readable enough in my eyes, and I don't expect performance to make any difference in choosing in this case (compared to other operations, microseconds aren't worth counting).
Good point, but you need to update the y-axis also; it is presently 1-4.
Could you wrap this (and other lines in this function) to a maximum of 80 characters, please? As per PEP8.
Hold fire until we get some other feedback then. If anyone else agrees with me then do it, if not, then its just me being picky ;-)
neither will this one show up as a link
Shouldn't this be a docstring? I.e, using `"""`
I had to re-add this property because the logging handler was failing without that property set. I now correctly unset it after all tests have been run.

Pushed:
https://github.com/mozautomation/mozmill/commit/a23fa832e1652de4d0fae39229caf30613d9f55f
I doubt anybody really cares about changing the double click interval.
что не правильно в том что было?
I have to write a complete chapter about this part in the .Net Bridge. I need some time for it. I will add it when I finished that part in the master theses document
I do not think we need this. 
But in case we do, why not have ``matches`` return a tuple (boolean, int) so you could:

```python
matches, score = rule.matches(request)
```
@arnodeclercq Can you remove all the style changes in the files?
This is a big thing for causing possible merge conflicts with other pull requests.
As part of cleaning up our code and making it follow our style guide we reformat CSS areas we touch in our commits.
Can you do this for the line above and the one you edited below?
Makes sense. No idea what that class would be at the moment, as that info is in a different branch...
you have right
This should be F_ISSET, not F_SET.
No, but will do... :-)
or use a path.join?
Thanks for the explanations. Seems to be not important here, but I'm going to change it anyways. It's always a good idea to conform to language principles. Just my Scala experience is not older than two days ;)
Are you sure that ``$classArray`` (of type ``*``) is traversable?
any suggestion then?
ah no big deal, fix it when I'll step on it
Пишу по памяти:
Так как ширина view, на котором отображается шильдик на iPhone меньше 60, а на iPad, соответственно - больше.
Почему именно константа - более наглядно, к тому же ширина самого view сомневаюсь, что будет меняться. 
Честно говоря, внутри исходников не искал констант с размерами окон. Так же само смею задать вопрос, почему width во фрейме была константа "9"? Понятно, что 9 - ширина исходного изображения шильдика "wp_banner_shild.png".
Das vllt. auch ins RatingModel verlegen. Oder vllt. auch ins BeerModel.
Also you should put one in Scala IDE, because it is also copy pasted from Scala IDE
I would love to see this using `JApplicationWeb`  and it's response management instead of `JResponse`, or perhaps optionally using `JResponse`.
Is there something breaking by having the keys quoted?
That's certainly true.  Actually a lot of times the trouble is a missing noun but often in those cases we have imperatives which technically ARE sentences, and those have been bugging me because we really should be using stops and aren't. Of course just as easy to write a sniff highlighting the presence of periods in labels and titles e.g. on the same line as @param and the first line of a method.

A long time ago I proposed to Louis and Andrew that they think of the docblocks as somewhat like a bibliographic reference (because we have title, date,  copyright), but they really didn't like it. Now in many systems of rendering bibliographic listings there are full stops used after a title as well as after date, author etc, basically each element.   Also we are not running all of the elements together, we are putting them on separate lines. It's many many periods to add though and I wonder if it is worth all those extra characters.  Either way it needs to be consistent in the tests and libraries trees. Looking through the codebase a bit it is highly inconsistent.
btw, you should typehint the array
I suggest having a fixed list of locations where convert could be located, and using a filter so plugins could override the list.  For example:

```
self::$convert_bin = apply_filter('find_imagemagic_convert', array('/usr/bin/convert', '/usr/local/bin/convert'));
```
What kind of test you think we can add here? try running `./manage.py test` first and see if this example test is working. Then maybe you can make a test that checks if the poll is being displayed to the user or something. I will be adding more to the README on tests tomorrow.
Move this to `authorization.py` file.
You can create a parsing function. How you will implement this ... maybe there is something already on the Internet? Maybe Django has something. Or Python. Check internationalization and parsing of dates.
Combine it with [this](https://docs.djangoproject.com/en/dev/topics/testing/#overriding-settings) and you will know what to do. :-)
In fact I have noticed, that it will not be anymore. I have to fix it.
Don't hardcode `/user/`. You can store output of `url` into a variable and then check if current request path_info starts with that, if it does, you add CSS class.
> Why is `gettext` so stupid :)

Because we do not know how to solve halting problem. :-)

> Is this a hint, because your suggestion with associative array looks very convenient.

I would suggest you look into `django-missing` package. ;-)
Мб отдельный файл?
Most of the time, what you will receive will be a plain, simple integer. So this won't work. We could maybe do that instead :

if (is_object($valueOrObject)) {
    $valueOrObject = $this->metadata->getIdentifierValues($valueOrObject);
}

return $this->find($target, $valueOrObject);

But not sure this is clearer...
My thinking was like below.

`setTupRedis` method instantiates `JedisPool` and get `Jedis`  from the created `JedisPool` based on the required properties. as below.	

    pool = new JedisPool( createJedisConfig(), requiredProperties.get( RequiredProp.PROVIDER_URL.getName() ) );
    jedis = pool.getResource();

` requiredProperties` is an unmodifiable `Map`, so it's read only and thread safe. However, multiple `RedisDatastoreProvider` instances are about to call `setUpRedis` about the same time without `synchronized` keyword,  I thought that there would be a chance for them to modify the Jedis properties values somehow while other `RedisDatastoreProvider` instances are about to read them. If exists, it would be better to make the method `synchronized` to maintain the consistent state.
On the repo there is the libnet-appliance-session-perl version 2.111080-1 that work with packetfence
Requires a documentation string describing the behavior, inputs, and outputs of this function.
Maybe you can help me here, i couldn't make it :(
s/curcus/Circus/
I have no problem cribbing those (assuming they are licensed well) to be noit_v?asprintf.
That would be fine with me. I just had it as a section heading page, we have similar ones for '4. General Foreman' and '3. Installing Foreman' so I had this one to keep with the pattern.
we should do this only if method is for cvxopt, to avoid unnecessary import
Hmm. It appears I'm going to have to think about this a little more to get my head around it. 

I was thinking we should leave the `dist` attribute as-is, but then add:
`setattr(self, self.dist.name, self.dist)`
so that in the default case, there would be `self.dist` and `self.norm`.

But from the comments above, it seems that 
`self.ppf = self.dist.ppf` is what we're really after. Is that correct?
%kernel_dir%
Environment Setup
----------------
Same question for these other changes in the Adapter framework.
bug?  if you are expecting the exception then I think the assertNotNull doesn't do anything.
i just statically imported them - they are being used from the util class.
 funnily enough i *think* we both made that change in parallel.


On Thu, Nov 15, 2012 at 11:47 AM, msweaver <notifications@github.com> wrote:

> In
> Product/Production/Services/DirectCore/src/test/java/gov/hhs/fha/nhinc/direct/DirectMailClientSpringTest.java:
>
> >      /**
> >       * Tear down keystore created in setup.
> >       */
> >      @AfterClass
> >      public static void tearDownClass() {
> > -        DirectUnitTestUtil.removeSmtpAgentConfig();
>
> shouldn't this use the one from the util?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CONNECT-Solution/CONNECT/pull/174/files#r2141037>.
>
>



-- 
Michael Landis
Software Engineer
www.5amsolutions.com | Software for Life(TM)
phone: 866.526.6042 x774
email: mlandis@5amsolutions.com
skype: mlandis5am
Ugh, use ' or ", not both. -1 for consistency fail.
а для них импликация работает? надо проверить..
The additions to this paragraph are wrong.  The old version was correct.  There are no intermediate Fourier images for drawShoot.
> I can add your diminished disquietude to the docs if you like. :)
> 
> 
Haha, no need, I just wanted to apologize for my silence and say I'm glad this was the resolution!
You need a way to check if the work needs to be done or not. You do this by overloading `load_current_resource` and then, inside each action, you compare that state to the desired new state if the action install were to be run.

If no work is to be performed then nothing gets done. This is how we do idempotent LWRPs.
The problem here is that this attribute needs to be manually toggled and it can be placed in an inaccurate state. Is there no good way to identify if the Nexus has had a license installed?
I'm not sure, we remove the placeholder in order to start editing an empty editable. Current selection is within the placeholder, so you're right i'm creating a new one to not loose a selection which in most cases is withing the toberemoved placeholder.
It's difficult for me to immagine a use case where user, in the 1/10s, will click to another editable and then change the selection.
ezurl() :)
add this new test first, as it is probably the most explanatory:

    @Test(groups = "Integration")
    public void testUrlMappingServerNameAndPath() {
        DynamicCluster c0 = new DynamicCluster(app, initialSize:1, factory: new JBoss7ServerFactory(httpPort:"8100+"));
        DynamicCluster c1 = new DynamicCluster(app, initialSize:1, factory: new JBoss7ServerFactory(httpPort:"8100+"));
        
        nginx = new NginxController([
                "owner" : app,
                "port" : 8000
            ])
        
        UrlMapping u0 = new UrlMapping(nginx, domain: "localhost1", path: '~ /atC0(\$|/.*)', target: c0);
        UrlMapping u1 = new UrlMapping(nginx, domain: "localhost2", path: '~ /atC1(\$|/.*)', target: c1);
        
        app.start([ new LocalhostMachineProvisioningLocation() ])
        
        for (Entity child : c0.getOwnedChildren()) {
            ((JBoss7Server)child).deploy(war.toString(), "atC0.war")
        }
        for (Entity child : c1.getOwnedChildren()) {
            ((JBoss7Server)child).deploy(war.toString(), "atC1.war")
        }

        // Confirm routes requests to the correct cluster
        // Do more than one request for each in-case just lucky with round-robin...
        // FIXME Make JBoss7Server.deploy wait for the web-app to actually be deployed
        executeUntilSucceeds {
            for (int i = 0; i < 2; i++) {
                assertUrlHasText("http://localhost1:8000/atC0", "Hello");
            }
            for (int i = 0; i < 2; i++) {
                assertUrlHasText("http://localhost2:8000/atC1", "Hello");
            }
        }
        assertFails {
            //this should *not* be available
            assertUrlHasText("http://localhost1:8000/atC1", "Hello");
        }
    }
Another nice thing to do is to detect if the MBean goes away entirely (e.g. connection failed), to set SERVICE_UP as false.
See for example `TomcatServer.connectSensors()`, where it calls:

            requestProcessorObjectNameAdapter.reachable().poll(new Function<Boolean,Void>() {
                @Override public Void apply(Boolean input) {
                    if (input != null && Boolean.FALSE.equals(input) && Boolean.TRUE.equals(getAttribute(SERVICE_UP))) {
                        log.debug("Entity "+this+" is not reachable on JMX");
                        setAttribute(SERVICE_UP, false);
                    }
                    return null;
                }});
IMHO - A log message that says trying out private Address, since no public addresses available - might be helpful here.
Okay. I was not aware of the v3 branch to be honest. :) Do you need anything else from me, or will you pick up these changes and merge them into v3 yourself? (I don't really know the timeframe for v3. What's up in NuGet is still the master branch, isn't it?)
Thats an excellent question I never managed to understand properly.
This is however the way even zend_std_read_property() does it :)

These read_property()s are just temporary properties, not a real reference to anything, so even assignment by ref and then modifying it will not change anything within the object.

There is also an explicit check in the engine to see if the return value was used, and if not - and refcount == 0 - it is destroyed, otherwise the refcount is increased (in this case to 1 - as we don't have in reality another reference to it).
Hmh. I forgot about the mongos case.. we'd want to mention that explicitly somehow.
The replicaset name isn't stored on the connection so getting that information isn't trivial, but I think it is worth including it
esta linha poderia ser reduzida para: `` if self.cleaned_data["init_year"]: ``
`isExpired` has a setter you can use that is synchronous.

I.e, if the following works (and has no other side effects):
```
updateExpiry: function(message) {
      var updatedAt = message && message.updatedAt;
      if(!updatedAt) return;
      if(this.stale(updatedAt)) {
        this.set('updatedAt', updatedAt);
        if(this.get('remoteExpiryAutoFetch')) {
          this.set('isExpired', true);
          this.fetch();
        } else {
          this.expire();
        }
      }
    },
```

I would use that.
(a string is a type of object ;))
On Tue, Feb 28, 2012 at 8:17 AM, vingtetun <
reply@reply.github.com
> wrote:

> >
> > -    <div id="video-controls">
> > -      <span class="button" onclick="Camera.toggleCamera()">switch</span>
> > -      <span class="button">capture</span>
> > -    </div>
> > +    <video id="viewfinder" autoplay> </video>
>
> 'video' was a bad name, 'viewfinder' sounds a bad name too. What about
> 'display'?
>

Seems like an OK name to me http://en.wikipedia.org/wiki/Viewfinder

"display" is very generic

-- 
Ben Francis
http://tola.me.uk
The example code had POST but I guess GET is all the search is using at this point.
maybe something like:
```
c = Skin.class;
Field[] fields = c.getDeclaredFields();
for (Field f : fields) {
  f.set(this, f.get(c));
}
```
Yep, removed , thanks
The place where changing 5.3.2 into 5.3.3 was really needed is not here (even if it can make sense) but in the travis config (there is no 5.3.2 version on travis anymore).
s/returns/return
Would it work to have:

content => "$nullmailer::remoterelay $nullmailer::remoteproto $nullmailer::remoterelayopts"

With remoteproto defaulting to 'smtp' and the remoterelayopts defaulted to an empty string.

(It appears newer versions can also handle 'smtps' too)

Then you could do:
 class {'nullmailer':
  remoterelayopts => '--port=2525 --auth-login --user=superman --pass=alwayswins',
}
Lost data-bypass attribute here and in a few other places.
Over-zealous line wrapping?
lines можно возвращать из метода
Фигурные скобки.
Должен быть публичным.
I think it's ok to not throw an exception.
Doesn't it support hints? I can see it's not enabled by default, if it doesn't, `hint_class` should not be required I believe.
Not used. Same for sc.
I was going to put that in the narrative docs, but I didn't write those yet.
Also rather than testing numerical values (which make it difficult to know if the test is correct or not), I would apply `Normalizer` on `X` and `Y` and use `linear_kernel`. Then the output should be the same as `cosine_kernel` on the non-normalized data.
Right. Fixed
G < U
Please use BlackBerry in all places above where not.
Nice. I'll put a comment in ignore.c to warn about changing the first string in ignore_pattern_files.
Bugger, forget this one. This should not have been commited. I remove it.
I do need thorprocess name to create the path of the log file. For example, /var/log/HPCCSystems/mythor.
But this cannot appear after the line below, because (as you can see above) it's returning the file from the directory (which is not there yet).

FileServices get away with it because it doesn't use the pointer directly, but add subfiles by name, which then gets inside transaction, where the file exists.
When analysing a core dump ?
It shouldn't, mptags are allocated and ensured are flushed at creator and receiver each time they are requested, see  allocateMPTag and deserializeMpTag
no necessary.
LDFLAGS should always be included, I'd say.
It may be usefull to display an `aside` note that provide a link to content script page?
We can move this repo to Mozilla. and then setup travis ci against the org. I did it for [browserid](http://travis-ci.org/#!/mozilla/browserid)
ok done
pretty sure yes... see http://httpd.apache.org/docs/2.0/mod/mod_userdir.html
will add check.
Here's the not so pretty module to hook into Settings after it's been initialized. The way that the railties hook inside rails_config was written made it a little difficult to hook in settings after the default rails_config hooks for rails.
This was actually never referenced - `cc-widget-walktime #walktime_map_container`
@shacker It should, I'll change this
Yes. There is a way to do it unauthenticated. But not tested in anger via SOP. On RFC need to construct specific connection etc.
Not a lot of information is needed in Name, but this is a vague name I think.
If you "reraise" exception on force_auth you don't need to keep checking result return code
OK, I added a range check with the option to disable it. @tonysyu Thanks for all the great comments!
Both good comments, changed.
Perhaps a better name might be `resizeWidgetOnWindowResize` but I wanted to avoid using `resize` twice in the same boolean variable name.  If you turn this off for a full-screen widget, yes, the canvas will stretch and the Earth will be the wrong aspect ratio, so you could think of it as refreshing the aspect ratio and other settings.  There are times you need to turn this off, for example if you embed this widget in a Dojo layout with a `ContentPane`, you need to let Dojo handle the window resize first, and Dojo will automatically call this wiget's resize handler.
Yeah, this was just me being lazy.
As @mramato suggests, go with explicit `typeof xxx === 'undefined'` checks.  I like the elegance of `||` and - to a lesser extent - `defaultValue`, but we shouldn't use either here or in similar cases.
I thought about it, but was unsure if it would useful anywhere else.  If a similar function pops up elsewhere, we can refactor then.
Could use some flushed out doc.
The code change invalidates this comment. Could you please update the comment with an explanation of what the new intent is?
The marriage chain now does convert to lower case after the contents of the input.

**For example:**
```sh
If looking for "search" does not match with "Search"
```
I wonder if we should even print this warning in production mode. I guess for the most part no one will see it. But I might suggest that this be clarified so that devs don't think ther app databases are being corrupted:

"[ERROR] Analytics: database error on shutdown: %@"
`Node` should probably be `Element` here
Эта переменная, как я понял, не содержит по-jQuery-энный  объект, не стоит ее называть с $, чтобы не путать других.
Because the Spec reviewer argued that we should use JAR names as asigned by the build:
https://bugzilla.redhat.com/show_bug.cgi?id=800756#c1

More info:
http://fedoraproject.org/wiki/Packaging:Java#Filenames
Post is looking good! Screenshots ;)
Alguna razón para este cambio? Evitar las `<br />`?
This probably applies to all of the problem types. Any time you're dividing, you should probably wrap the division in `roundTo()`

Something like `<var>roundTo( 10, SALES_TAX / 200 )</var>` would work since sometimes floating point division loses a little precision:


![Imgur](http://i.imgur.com/cfVXQ.png)
Please do not reuse variables like this in tests. I think that it's bad practice and begging for bugs. Create a new variable or scope the unit tests so that it each section is in its own scope (allowing you to reuse the variable name but still have different variables). e.g.

    {
        ubyte[] buffer = [...];
        //tests...
    }

    {
        ubyte[] bufer = [...];
        //different tests
    }
Not a fan of the fact that we have @safe and @trusted but isSafe is a disjunction of them (instead of isSafe meaning safe and isTrusted meaning trusted). Could we change things such that we have isSafe, isTrusted, and isSafelyCallable? The latter would implement the functionality of the currently proposed isSafe.
Let's use `isRandomAccessRange!S && is(ElementType!S : char)` here because supporting ranges of `ubyte` is an important case.
do we want to leave this print here?
or do we have a TODO that this should use logging library?
Some more spaces might be nice here.
faire un use mageekguy\atoum alors que le phar n'est pas charger, ça marche ca ?
This fragment can be rewritten to not require these checks.
Right. Either in build.xml or in components/antlib/resources/global.xml
because this "resource: "@AcmeHelloBundle\Controller\UsersController"" didn't work for me. Have you tried to use such syntax?
Fixed (github is slow right now, takes some time to recognize new commits).
you never use the loader in the closure
The dot must not be escaped here. This would match ```.``` and ```,``` as well as ```\```.
In this case, we've added additional fl-layout-xx statements. We used to have, fl-layout-50, fl-layout-100, fl-layout-150, etc. We've added some additional ones like fl-layout-75, etc. to have some more flexibility.

However, we have made other changes to this file in the past, not as part of the contentauthoring work.
Also, `click` should become `on`
Пустая строка не нужна.
Just realized, I think the module could just be `cc.model.library.importer`. It imports both suites and cases, and that's everything the `library` module is concerned with anyway, so it's really an importer that applies to the whole `library` module.

Similarly, I think the class itself could just be `Importer` rather than `CaseImporter`; the latter is perhaps even misleading, since it imports both suites and cases.
I'm a little confused as to why TrimPath is even trying to execute that statement -- it shouldn't ever enter into it. What is the result of `data && data[field_index]` in this case? I assume that `data` is `undefined`, and then `data[field_index]` wouldn't even be evaluated.
~~JPA Parameter~~ parameter. With the parameter text within emphasis tags
I agree, so long as you simplify the methods for each type.
If we do templates for postgres.conf, then I like the idea of having a separate template for postgres 8 vs postgres 9.
You missed the @ before return. This probably caused the last two errors.
I guess we might as well remove the migration topics from the code base now.
Moved imports as "from __future__ import" has to be in the beginning.
yes thats right... my solution would struggle into problems in version code 2.x.. found another spelling bug....
Yes, this is ok, because it's embedded field.
Trust me, it works ;-)

 
On 9. apr. 2012, at 13:57, Mitar wrote:

>> +        # Try to hydrate the data provided.
>> +        value = dict_strip_unicode_keys(value)
>> +        self.fk_bundle = Bundle(data=value)
>> +            
>> +        return self.fk_resource.full_hydrate(self.fk_bundle)
>> +
>> +class EmbeddedListField(fields.ToManyField):
>> +    """
>> +    Represents a list of embedded objects. It must be used in conjunction
>> +    with EmbeddedDocumentField.
>> +    Does not allow for manipulation (reordering) of List elements. Use
>> +    EmbeddedSortedList instead.
>> +    """
>> +    
>> +    is_related = False
>> +    is_m2m = False
> 
> You are using `m2m` methods bellow, but here you are setting `is_m2m` to `False`. Is this OK?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mitar/django-tastypie-mongoengine/pull/1/files#r659753
Also try to use single quotes ' instead of double quotes "
some reference to the kinds of types needs to be given here
The function would have to change to account for the files not existing.
Also, its only ever called after we create a backups dir and this whole plugin is mega fail if that dir doesn't exist.

So I do agree, but for now I'll leave it with the defensive programming, and adjust to handle failure tomorrow.
ah I guess you're right; django.conf probably needs a full-blown django instance in the background, while your import just needs django to exist. Should be fine then.
return is not declarable
Or maybe empty closures should printf as `0` ?
Group Warning problem
I wonder if all those String constants could be refactored into enum classes - e.g. one enum class per category: AccountManagement, Authentication etc. Right now there are 1000+ lines of constant definitions and String constants are just not very type-safe. 

Not necessary to fix prior to merging this PR but maybe something to consider.
Does StyledWriter have an advantage over FastWriter?
This causes a continuous loop, a mutex would be better to use here if you are trying to block
remind me again why you need special handling for XHR?
handled by destructor now
My understanding is that the blurb is necessary for new samples.
I think it would be nicer to use `null === $class` here to meet the [Symfony2 standards](http://symfony.com/doc/2.0/contributing/code/standards.html) (and PSR-2)
Well, whitespace isn't actually a word...