labofsahil/github-event-dataset-2012 huggingface dataset:
ehh Pete? You asked me if it works in production - and the answer is no :(


    [rails 3] RAILS_ENV=production rake  db:reset
    rake aborted!
    undefined method `less' for #<Rails::Application::Configuration:0x007fa172ee1d60>

    (See full trace by running task with --trace)

Can you confirm that this is the "expected result" <:)

(I did a deploy of my project and to my great disappointment, got the above error - then I tried on my own mac to rake the exact same task that crumples on the server - and the result is the same. Then I tried with this project and it is the same. 

Did you successfully rake anything in production? And if you did, how did you manage to?

- sorry to not testing any raking in production :(
cheers,
Walther
it happened  while using uuid helper in quite standard way - for some reason model.primary_key was not defined. I am sorry I won't have time to investigate further, so if you feel it's not good, just ignore it. Thanks for understanding (life is too fast) :-) Jakub
I agree with the corrections by scott
Gah... thank you.  Fixing and retagging...
it should have been strlen(temp)
Do we print to console.error when an error occurs here?  We seem to be spying on it but not checking for values
Right, that makes sense

On Feb 28, 2012 10:59 PM, "Hector Castro" <
reply@reply.github.com>
wrote:

> I didn't test this. Figuring it might be in the context of a Rails
> example, but if Sinatra has a render call, we should replace it with that.
>
> --
> Hector
>
> On Feb 28, 2012, at 10:48 PM, Jamie Ly<reply@reply.github.com> wrote:
>
> > I'm wondering about why you created this helper versus using
> >
> >    = render :partial => "about"
> >
> > in the haml. The example is from the bottom of [the HAML Tutorial](
> http://haml-lang.com/tutorial.html).
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/CfABrigadePhiladelphia/the-other-philadelphia/commit/d94cf63a41e47b10cde9086083f4b29d6f4f56ba#commitcomment-1024224
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/CfABrigadePhiladelphia/the-other-philadelphia/commit/d94cf63a41e47b10cde9086083f4b29d6f4f56ba#commitcomment-1024249
>
maybe use `_delete` instead of `_del`?
We'd better use rib.confirm in msg-box.js for better UI.
No need for refresh the deviceSelect always . Maybe we can use  'add' and 'remove' functions  to improve performance
Until now the annotation_id column of the river table held the id of the comment. Now we can't place it there anymore.

I wonder if the annotation_id column is used by anything else but annotation comments and group discussion replies.

Maybe the discussion replies should also be converted to objects. Then the annotation_id column could be altered to hold an object guid instead of an annotation id.
Everything is perfect except the ~ have to completely underline the title, otherwise it won't be included in the documentation.  Also, I've been dropping the SRL_ from everything.  We could drop it here as well and just have the constants OUTLINE_BLACK or COLOR_OUTLINE_BLACK.  Doesn't matter that much, really.
a standard deviation
removed and added to migration docs
There is a huge comment right above this loop, and it explains it. Hence I refute your claim.
Removed it instead.
actually it is more like `!isTerminated`, which should be made more clear here (otherwise it could be interpreted as “this node is UP”).
why not j.u.c.TimeoutException?
What is the coding convention for strings? When to use interpolation,  
formatters or plain concatenation?
Why is start called here?
yes, good points, will add the doc comment.
same here: what’s the unit?
Not quite sure why these LB cookie methods are included in this PR.  Are they related?  The changes will break existing code but if there is a good reason, it may still be the right thing to do.  Just need a bit more background.
does this stuff have any connection to moving packs?
Updated chunk create parameters.  card and renderer are now stored in a hash to simplify the API.  I think we probably should get rid of card_params if we can, and pass those objects only when rendering (inclusion processing) is happening.
need spaces after the ':', so that the docs render properly by sphinx
I don't think we can. Here is an example 
A = np.random.rand(10, 3)
np.linalg.norm(A)
2.9526140321096026
not a array.
Or better... where do you see it being re-implemented?
Re-reading mock docs to see if I can find something.
I was missing this from the drugis-common pull request but I see that a commit just appeared.
It comes from: https://github.com/ajaxorg/ace/blob/master/tool/tmlanguage.js#L263-276

Sometimes tmlanguage files have their own node for specific repository rules: https://github.com/miksago/jade-tmbundle/blob/master/Syntaxes/Jade.tmLanguage#L343

In the Ace sense, they're still valid states and ought to be incorporated into the highlight rules. I'm not sure what your tmlanguage file looks like in this case, I've only ever seen it empty or properly stringified.
Without actually looking into the presence of profiles and comments in an image, it's possible to simply check the file size before and after stripping. The beach.jpg from assets is a good example, containing Exif data and color profile. Like this:

```
@tests.test
def strip():
    """Strips the image of all profiles and comments."""
    with Image(filename=asset('beach.jpg')) as img:
        strio = StringIO.StringIO()
        img.save(file=strio)
        len_unstripped = strio.tell()
        strio.truncate(0)
        img.strip()
        img.save(file=strio)
        len_stripped = strio.tell()
        assert len_unstripped > len_stripped
```
What does "starts over" mean in this context?
It might be more readable for the Regexp to use the `%r` literal syntax here.
Ok.  So maybe we should just put the common functions in some common location at some point.
But wasn't blocked drawing a part of the original TwUI goal? It stated so clearly in the `README`. Either way, you're not obligated to use the blocks if you don't want to, so I'd guess it's fine to leave it in.
eeeeeewww. in Objective-C land, we like `YES` and `NO`, so please use those! :)
This is probably a paranoia case that the following script causes a event loop starvation while one does not in node-v0.8.x. 
````
var domain = require('domain');
var d  = domain.create();
d.on('error', function(e) {
  console.log(e.message);
  f();
});
function f() {
  process.nextTick(function() {
    d.run(function() {
      throw(new Error('d'));
    });
  });
}
f();
process.on('SIGINT', function() {
  console.log('SIGINT');
  process.exit();
});
````
with the version of inject I committed on Friday - they should 'work' - fingers crossed.
find_by depracated
I think you mean `"inplace_increment"` here?
I just realized that this will only work if `railties` is loaded in your application. As `railties` is not a `actionpack` dependency this can fail with a `LoadError`
How about merging this into master first, then deprecating in 3-2-stable, and then removing the old method from master?
I think you could probably only set `@errors` to `nil`, and let the [method do its job](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/validations.rb#L169).
`render partial: 'route'` should work.
OK. That makes sense. Should we do the same for ``content_tag(wrapper_tag, nil, html_options)`` in ``simple format``?
In my defense, he changed my outdented `protected` to an indented `private`. :) I'll restore it to what it was before the commit I am reverting here.
2.10.1?
Ok, then I'll try to make this method abstract.
@jsuereth Could you please run the community build _after_ this change instead of now?
Fully agreed. Tests should rely as little on std lib as possible. This way they are more localized and easier to debug.
Is this intentional or just an oversight?
`np.fromfile(DATAFILE1)`?
why are there anonymous morphisms but no anonymous objects?
For example, using `isinstance`.
On line 24 you say that the second argument should contain a list of applied functions, not a list of functions.
I think one should compare with `is` instead of `==` here.
why use `;` instead of `.` ?
In PHP if you have no return, function actually returns `null`.
I would make it optional. Again, maybe the client wants to launch a permanent gatewayserver that will survive this python process and be shut down with the shutdown command.
No, insert_new is 'cos you can't increment a non existing counter. But insert would zero the counter for the current moment if it already existed, insert_new means "only create this key if it doesn't exist already" and then update it.
you haven't set it up what? do you mean by change you have not created the issue?
No, 0 and up. So uint should do fine.

I got some strange errors from message sender, the buttons were never clickable. So it's not tested end-to-end. 

17 apr 2012 kl. 21:52 skrev Henrik Feldt<reply@reply.github.com>:

>> @@ -18,6 +18,7 @@ public RKAE()
>> 
>>        public string Cause { get; set; }
>>        public string Comment { get; set; }
>> +        public int NumberOfPeoplePresent { get; set; }
> 
> Can this number be negative? uint perhaps?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/haf/Agressiv/pull/3/files#r697007
the FreeBSD version does not have the long arguments, therefore shortened arguments need to be used for cut throughout
What is this default?  Is this the number of tasks it will accept?  If we are going to provide a default, we should do it based on the number of cores in the system instead.

public int getCapacity()
{
  return Runtime.getRuntime().availableProcessors() - 1;
}
needs something between the word "array" and `[5]`...
it's still in the document. this line has been moved up in the document to line 427.
no to the include.  It looked horrifyingly ugly. 


On Nov 16, 2012, at 6:39 PM, Sam Kleinman wrote:

> In source/reference/simple-aggregation.txt:
> 
> > @@ -0,0 +1,41 @@
> > +=======================================
> > +Simple Aggregation Methods and Commands
> > +=======================================
> open question: should we have included content here or not?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Hardcoded URLs are bad. [Use the Sites framework to get absolute URLs](https://docs.djangoproject.com/en/dev/ref/contrib/sites/#getting-the-current-domain-for-full-urls)
wrong key was used to check for why run mode
Would making it an option that defaults to off be viable?
If you add more tests here consider taking the file apart into separate files for index, viewtopic and viewforum.
```{LA_ADD_FILE}'}``` => ```{LA_ADD_FILE}'}```
Excluded part here <code>(?<!\?>)</code> was responsible for the character(s) matching (. - any characters including newline, since 'm' modifier is used) not to be preceded by the PHP closing tag <code>?> </code>. Thus regex should match text within PHP tags only, if I understand it properly. After the patch, the regex matches text outside PHP tags as well. I don't know if such behavior is correct during template compile.
fixed in 1a15d7f
fixed in f8147bd
we can put the cert into constants.lua or a new file...
> CMake (CPack, CTest) produces a pretty big bunch of files.

Autotools does that as well, IDEs can store their projects' files in src root dir.

> Polluting project root is dangerous (as long as we can override original files with build-time installs)

Its safe, we have all our sources in src include dirs.

> Polluted project root looks awful.

ls -la /home/elvenfighter ;)

> git -f clean in not a panacea as long as it can remove other (non CMake cache files)

You can have local .gitignore file to protect important files if you are really intended to use git -f clean.
The `callback` param is to a function that's internal to commands/compile.js, and it always passes the callback.  Guard still needed?
Same here for the `AssemblyInfo -> SharedAssemblyInfo` files
Suggest putting these into a namespace (like RaxaEmr.Pharmacy.Vars, or something simpler) to reduce the number of variables in the Global namespace.
Recommend that you name constants with underscores for readability. ```PURCHASE_ORDER_MODEL``` vs ```PURCHASEORDERMODEL```
use of positional arguments is confusing (especially given that they are miss-used later on).
Clarify the two sentences into on simple one.
More details:
g_cost is used to compute the gradient with respect to cost. If you put cost in wrt, your pull request gives the wrong answer for it.

If cost is an integer, then the ops that backprop through it are only allowed to return zero, disconnected, or undefined. This is already enforced, grep for "only_connected_to_int".

Basically you were trying to solve a problem that does not exist, and adding many problems in the process.
Ah! I figured this out! It's a very timely error actually. 

The function in rank 0 has two independent (from its perspective) input branches, a recv of z and some computation with x. It's choosing which one to do first arbitrarily. The standard order in toposort chooses the receive first so both functions are waiting to receive from the other. 

If only there were some way to say to cleanly affect the ordering of toposort....
This should also be changed to use maxColSize.
m_tuples seems like unwanted costly overhead in the UNION ALL case. 

Hiding the m_tuples.insert inside the custom needToInsert would allow UNION ALL's m_tuples to be initialized but otherwise unused in the UNION ALL case -- its type could be just about anything -- something trivial like "int" if kept as the template parameter.

OR you could just hard-code m_tuples' type as the unordered_set and ignore this member (leave it empty) in the UNION ALL case.
Then, you could parameterize the template more directly on the specific UNION_TYPE/scalar/int constant -- which I think would make the intent/scope of the templating clearer. I think that parameterizing by the "typename SetType" implementation detail impairs clarity.

OR On second thought, I'm thinking that any template here is overkill -- if all that's needed is a cheap boolean member check like:

        if (m_isAll || needToInsert()) {

It would not be that horrible even to pull the m_isAll test out of the inner loop and have two copies of the inner loop in an if/else -- one calling needToInsert, the other not.
or fix #12422 ?
This needs `versionchanged` directive. You can find the examples elsewhere in this file.
> I assume I should change the behaviour of my patch to respect the prior behaviour of `cabal build` and ignore the behaviour of `./Setup build` entirely?

Yes please.
Where this rewriting happens? Here https://github.com/jckarter/clay/blob/master/compiler/lambdas.cpp#L591?
I'd like to rewrite a body from `return x + a + b` to `return x + a^ + b^. This would make nested capture-by-smart-ptr possible.
I agree that it's clearer as-is, your variable name changes in general made things easier for me  to understand so I wouldn't give that up for 2 bytes. 

Just to note, this is one of the areas where CCAO changes things to eliminate the quoted method names, but since we're planning on keeping CCAO caged in a branch for 1.8 it's not an immediate concern what we do here for master.

https://github.com/dmethvin/jquery/blob/ccao/src/deferred.js#L34
Numero uno: https://github.com/gruntjs/grunt-contrib-jshint/issues/1
It is very difficult for us to find a good strategy in a tight time frame. After talking with Gavin, we can add this in next release.

I have filed a jira of MADLIB-487. What do you think?
Why is this emote moved to another nonzero id?
Looks like you may have an extra closing brace there.
Mainly because it is currently a stub, and I thought to group all the stubs together at the bottom.
This seems a lot like the previous css.  I think we should create a "comments.css", and include it in the places we want to style comments.
This is not a stable download; formula must define a stable, versioned download (with a checksum!) in order to be considered for inclusion in core.
This needs to be broken up a bit, don't shove everything into one shell invocation.
Thanks, removed it from the pull request. Note, this line exists in mysql and mariadb formulas, so probably it should be removed in those too.
should be ---------- not =======
This is something that is a) shared and b) a responsibility of the options object, not a responsibility of this method.  Should be refactored out if we ever use this code anywhere else.
```
if '/var/www/dir' . '/alias/index.php' != '/var/www/dir/index.php'
then $alias = substr('/alias/index.php', 0, strlen('/var/www/dir') - strlen('/dir') - strlen('/var/www/dir/index.php'))
> $alias = substr('/alias/index.php', 0, strlen('/var/www/dir') - strlen('/var/www/dir/index.php'))
> $alias = substr('/alias/index.php', 0, 0 - strlen('/index.php'))
```

``$alias == '/alias'``
i find it important to also add a ``@throws`` tag for the filesystem exceptions that might be thrown by this function (coming from ``wrench`` or the ``fs`` modules)
man koennte ueberlegen die konstanten in die excp. klasse zu verlagern...
I am going to make changes to how lu is bootstrapped in 0.4.x. I'll update this accordingly.
this test coming in another pull?
@dredhorse @simplyianm is saying you should use ```boolean``` rather than ```Boolean```
Not currently. My preference is to require that Execute.InBatches or Execute.Atomically be specified explicitly for readability reasons.
Right, but that is definitely possible: KeyBindingManager has addBinding() and removeBinding() methods that appear to be public.  If we're assuming the key map is immutable for now (which might be reasonable), then we should make addBinding() internal-use-only (only allowed to be called by Menus.js) and comment out removeBinding().
Underscore added to this method and parseStyleSize() above.
@peterflynn I can't figure out how to return the results when using `Async.doSequentially`. It seems that it just discards the results of the individual Deferreds. Is there any way to resolve the Deferred using the list of opened documents with `Async.doSequentially`? It does simplify the code nicely though.

@redmunds (regarding point 2) So are you saying that files that are opened from the open file dialog should always be added to the working set even if they are in the project? Is this the right function to do the opening multiple files in or what existing code path are you meaning?
i wanted to remove setframe from debugger
its' name is misleading: it only notifies ide that frame is changed
and there is no way to actually set frame on debugged process

it should go with [onChangeRunning](https://github.com/ajaxorg/cloud9/blob/b1c7d6d761cc389bd65541d1097ea41bf07f5e02/plugins-client/ext.dbg-node/dbg-node.js#L96-130) not into public interface
Not that I can tell in most cases. The most common way to setup hooks is `Resque.before_first_fork { ... }`, so `...` is turned into a `Proc` and does not really care if it's passed additional parameters.

I suppose that `Resque.before_first_fork = lambda { ... }` would blow up, but I would be surprised if anyone did such a thing.
I'm still getting used to Resque's code base, but will this break existing hooks?
@biyeun did this get fixed?
Are you using the env argument?
Yes, the commit states that we need to change the way we create objects. The metaprogramming is saving us a bunch of lines but does not allow this custom constructors each one with its documentation.
No. I can register with extended User document and having DATABASES setting. But I can also open the webpage if I remove the DATABASES setting. But registration does not yet work with removed DATABASES setting. This is something you have to fix. (Check the traceroute of the exception and you will see who wants to access the database.)
Upper case the first letter of the TODO comment.
do you clean up all of these listeners anywhere? I imagine this might get troublesome.
This name is not great, can you do better?  I'm still confused by it even after all your explanations.  It shouldn't be named in a way that relates to UI, but to a Project and the logic of a Project.
Truthfully, I'm not sure. I'd say I left that in as a safeguard.
I don't think this actually works.  Try doing:
if ( `[ '"absolute", "relative" ].indexOf( getComputedStyle( element ).getPropertyValue( "position" ) ) == -1 )`
ah haha yea sorry about that, will update
Don't use magic numbers, define variables so it's obvious what these are.
I don't think this is necessary. It should just run before other things down here https://github.com/mozilla/butter/pull/924/files#L3R611, right?
Probably don't need `TEMPLATES` at all anymore, right?
I've chosen `text=[]` such that `text.join('')` is simply to call. I don't know yet how the additional attributes for lines etc. are stored best. I don't have strong opinions right now if we should combine (use a object) or leave it this way (two arrays).

What's your choice?
Hopefully fixed in bver/aji-ie branch script_injection.
P.

On Mon, Jul 9, 2012 at 2:23 PM, IUnknown68 <
reply@reply.github.com
> wrote:

> > @@ -273,3 +273,14 @@ bool
> CSalsitaContentApi::GetActivatedWindowPopupId(HWND activatedWindow, INT &po
> >
> >    return false;
> >  }
> > +
> > +STDMETHODIMP CSalsitaContentApi::executeScript(BSTR script)
> > +{
> > +  CComQIPtr<IHTMLWindow2> htmlWindow =
> CComUtil::IWebBrowserToIHTMLWindow(m_WebBrowser);
> > +  if (htmlWindow)
> > +  {
> > +    VARIANT varRet;
>
> This might leak depending on the type returned (e.g. BSTR). Please use a
> CComVariant here (works like a safepointer and releases resources in its
> destructor)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/salsita/aji-ie/pull/4/files#r1121812
>
Again, this code exists merely to illustrate a difference between version 2 and version 3 of the gem. I'm not sure this needs to change.
FreeeBSD -> FreeBSD
Should use `com.twitter.zipkin.common.AnnotationType.String` rather than converting the generated thrift struct.
If a function is supplied as the last argument, we assume it's a callback function so we just pass everything straight through.
I've now implemented your extremely good idea.  ;)
You mean line 16? - yep ok I can remove it.
Yes I do, but not without scrolling right :)
Ok, found the problem.  It was because I was using quotes: $("document").bind() and $("document").trigger().  For some reason this worked when using "body".  Not sure why.  I'll resubmit.
`Glue::Foreman::Environment` should use `Foreman::Environment < Resources::ForemanModel` instead of using  `ForemanApi::Resources::Environment` directly. This line is an example of this. See foreman_architectures how its done for other already implemented foreman resources.
Since the routes are added as array, I added the parameters as array (assoc), too and used the route name as key to assign them to the route. Another way would be to extend the 'routes' key in the 'extras' array but this would break compatibility with the voters, thats why i used a separate field in 'extras'
I think it's a good idea but it'd be a lot of work in the short term
Perhaps use jsdoc for these?

/**
 * Event emission encoding handler.
 */
this.decoder = new Codec();
The inputs are pretty tiny on the phone, we should make them bigger.
name was not initialized earlier. the module failed because of that. fixed that too
Should we add the public keys of anyone who's done a public release to the release docs?
It probably doesn't matter to most users, but I do find it confusing that an object created with the `Coordinates` class is not an instance of `Coordinates`.  I'm not sure if that's a very good practice.  One example describing the "factory class" pattern [1] matches my expectation that you call a method in the factory class to generate a new object of variable class.  Instead in the Coordinates implementation you use `__new__` to return an object  that doesn't inherit from the parent class.

I see that there is a big warning in the docs...  but is there a way to make `Coordinates` be a base class of the returned object?

[1] http://www.linuxtopia.org/online_books/programming_books/python_programming/python_ch23.html#objects.creation.factory
Similarly, maybe ``decimal.Decimal(2400000.5))`` should be defined at the top?
`find_by_followed_id` will return a Realtionship or nil. 

Definitive source for modeling production Rails apps? No. Good introduction to the basics of the framework? Yes.
This should work, or?

``style = style ^ CClientUIInterface::MODAL;``
check the documentation comment above this function.
LookupArgs_state_UNKNOWN since it is a value of the state field within LookupArgs struct
you don't allow one line ifs? man.
Okay, verified now.
> if WorkingCopyHasUnstagedOrUncommitedChanges is called inside of a WithTemporaryIndex

I don't think that is the case. 

If I am not mistaken, `Rcheckin` is the only user of this method, and we want it to use the actual index since we shell out to a `git rebase`
Well, the first google research for "m language" actually leads you here

http://en.wikipedia.org/wiki/M_(programming_language)
It makes perfect sense. I came to the same conclusion this morning and did already implement it (and went off, the weather was just too good). In retrospect it does make sense. Doing some more testing and will push it to github.

It all gets messed up if you have text in vi that is soft-wrapped (which happens easily in vertical split), but that's the same with Terminal.app.
Yup, fixing now (to actually read 'on its PyPI page', with link, since that seems to be the authoritative site).
I know one too, I just can't fathom it...
Yep. I'm not sure why this didn't show up in my manual testing, but it is fixed now. I think that should make Leeroy happy.
Docstring should clarify that these are tests for case filtering specifically.
It'd be a lot more efficient here to do a single db query for suites and iterate over that: `for i, suite in enumerate(model.Suite.objects.filter(pk__in=self.cleaned_data["suites"])):`
Cool. We'll revisit this thought when we experiment with refactoring it out into its own web framework thing.
That's why I added some test cases.

I manually computed the area & cg by hand and used those values in the 
asserts.  Since both trapezoid and free form use the same algorithm, I 
cheated and used trapezoid to help verify the computation.  (I don't 
know if elliptical uses this algorithm or not, haven't checked).

The last freeform test case is a square adjacent to a rectangle. The 
rectangle portion is constructed so the "trailing edge" has y0 = -y1.  
When this test case is executed with the old code it fails since cg = 
NaN.  However, with the corrected if condition, it passes and matches my 
hand computations.

Kevin

On 10/6/2012 11:00 AM, plaa wrote:
>
> In core/src/net/sf/openrocket/rocketcomponent/FinSet.java:
>
> > @@ -440,7 +440,7 @@ private void calculateAreaCG() {
> >  			
> >  			double da = (y0 + y1) * (x1 - x0) / 2;
> >  			finArea += da;
> > -			if (Math.abs(y0 - y1) < 0.00001) {
> > +			if (Math.abs(y0 + y1) < 0.00001) {
>
> There's definitely a bug in that code - the question is whether the 
> if-clause is wrong of the equation...
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/plaa/openrocket/pull/4/files#r1779577>.
>
So what do you think about the proposed alternative `TryParseAndVerify` as a public method on `ResourceLinkVerifier`?
I don't want this.
This change makes the above comment obsolete.
The "*" placement for pointers is wrong here.
BTW, I originally used `Date.iso8601(value)` but that doesn't work on 1.8.7.
However, I'll change this to just break as well, so we can do your suggested change.
typo: Gets
please use the methods available in the interface instead of the public properties. And does this code works for all Doctrine projects ?
Are the `start` and `end` query parameters sometimes empty? If the user isn't specifying them, the storage class logic is going to fill in `0` for `$start` and `time()` for `end`, which means a range query on the `time` field takes place regardless. This can be inefficient, especially if the `time` field isn't indexed in the database backend.

Do you mind if I fix this in the PR I'm going to submit on your branch for the MongoDB changes? I can try to address it universally for all of the storage adapters.
All summary lines must end with a dot.
Ah, I know why. Ill make a PR too improve this.
Why changing this comment? I think the previous one was better.
``true if none of the files exists, false otherwise``
Ho :) Thanks! I think the declaration disappeared during some rebase
So I guess ideally the config file should override these values if given, and command line options should override both.
convention is to name it just `completion:`
```completionBlock``` is widely used in this project as well as in third party plugins
thx.  dry'ed up nicely.
kill this since it isn't called when we're pulling the VC from storyboard
enghadr khandidam ino didam ke chi
gozashtam shoma ham bebinidesh
shahkare yeki az doostane :D
This could do with a different `target_path_template`, so you can really tell where the result path came from.
node test/test.js
while an edge-case, an alias for _SimpleLanguageChanger should be preserved for now, with a warning raised if used if possible.
to me this looks like covering up the real issue. which is that request.current_page apparently leaked in some test to another test. Shouldn't that be fixed instead?
Am I mistaken, or can the gender be different for the first name and last name with your code? Something like "Gaspar Jakubova" isn't correct, so I think you'd rather have a 'nameMale' and a 'nameFemale' method, each calling firstName() and lastName() with the same gender.
Derp, you're right — a few changes I've got sitting in a branch that aren't ready to go yet. I'll fix the docs for now.
`containerDiv`
Using `<h1>` outside of a `<section>` will break the title hierarchy. Accessibility blocker.
This is wrong, font-family should stay Open Sans and specify font-weight to 600.

Unless that's not working and you are looking for workaround.
I don't think this will ever happen, will it?  If not, you can remove this code.
please review this doc, thanks Jose
Remove deadcode (also there is no reasons to write BUTTONS instead of Buttons
red is dead!
there is an existing class in the contacts app already defined for not visible elements, it is called 'hide', thus the notDisplayed class seems to be duplicate
maybe just do:
```javascript
var link = links[k];
var delimiter = var delimiter = x.indexOf('?') == -1 && '?' || '&';
link.href += delimiter + parameters;
```

No need for the elaborate if statement with comments.
A little more straight-forward would be `f.get_name() == 'OutputForm'` (no need to create another `Symbol`).
I have the '&' so that any following lines are no blocked should someone add something. Essentially we are not using or caring about the curl response so we wire it to continue on.
这个函数有两个问题：
1. 此函数和 rs 服务一点关系都没有。
2. 此函数功能来说，不是 thumbnail，还是叫 imageMogr 或者 imageMogrify 会比较好一点。
Nice catch of my shitty logic. What I meant to write was

````
! = highlighting[klass] if klass in highlighting
```

as  a way to reuse the `highlight` with `".new.#klass"` without adding the property to `highlighting`. Well, that explains why it doesn't work. 

Gotta rewrite this feature eventually.
I'll change `Element` -> `Node` later, don't pollute your diffs.
"rake run" should work on Windows now too as of PR 104; I also fixed Travis CI. Knock wood. :-)
No use for count outside of testing
Oh, of course! I was looking above, not below.
I rewritten the code in this commit:-

https://github.com/skyluc/scalatest/commit/a7b82ab39a21f81cfd7f4f1c965c484aabdd8c22
Why not just *always* get the local addr? The `appLocalAddr` would then be `SockAddr, and there would be no need for `needLocalAddr`.
Yeah I wanted to ask you about this. Gateway relation has private reader for relation hence the send.
I didn't mean a completely separate helper that could be reused by other classes but simply a separate method with a speaking name that can be tested independently. I like it when methods do only one specialized thing or they are aggregations of logic they delegate to these small "helper" methods.
Could you reorder the options to be the variable size - and clean up the white space after the colons
```js
'namespace': String, 
'outputdir': path, 
'wrapper': String, 
'variable': String, 
'version': true,
'help': true
```
Sounds fine to me, whichever you think is more idiomatic
I didn't mean that. I meant that at first we should fix the obvious problems that make this benchmark... hm... inaccurate at all. And only then chose what time resolution we actually need. If your benchmark can show 1.9 sec instead of  1.009 sec, it's exactly the [0] resolution you mentioned :)
probaby more than 79 cols?
It might be worth adding a way to store all the blocks.

Also, you could add an input for a (Hash)Set that contains blocks that the ray can pass through.
Definitely agree that each function should have a full docstring. I'm waiting to do it until we're sure we don't want to edit the docstring for `aperture_photometry` too much more (because it is mostly a copy-paste, as you said).
A longer term fix would be to migrate to lager, then bump the level there, then put it back down on exit.  error_logger should be able to do this, but seemingly it can't.
This is only ever called if `self.shallow` is true.
So could you modify it too?
I think it is more suitable to modify it in this commit.
``$output`` is undefined here
Why not ``$auth .= ':' . $pass`` ?
IIRC openssl uses a scramble algorithm, (ie can it find any path to valid), and the order of the certs is almost irrelevant. See Moxie's TACK proposal for how they add a second chain to a TLS connection for a good practical example of this.... I'd have to source out where that algorithm is in code, but yes, I think this might be exploitable.
No, these gem should not be in assets group. It for precompiling js/css files actually. It not for ui libs.
Quote from http://guides.rubyonrails.org/asset_pipeline.html
"If you are precompiling your assets locally, you can use bundle install --without assets on the server to avoid installing the assets gems (the gems in the assets group in the Gemfile)."
So, placing them here will broke meaning of assets group.

As for exact gem versions: I believe it always better specify version than no to.
Actually why not?
What does this do?  (and why's it related to citations?)
just an observation not related to this actual pull request, but "didnt send USER/NICK/HOST" seems kinda fucko here.
Yep, I'll check into it.  I most likely won't get to it until midnight tonight (I'm -5 GMT).
I'd revert this guy too. See comment above
300 | ERROR   | Whitespace found at end of line
Just a note: 'send' is a ruby special method, Object#send, which lets you call methods by name. Not super awesome overriding it, though in this case maybe it's fine.
How about adding links to Companies, Investors and Deals here?
localization "I18n.translate"
Ohh good catch!! I was most likely broken with multiple addons being installed.
You're still mixing two naming conventions in the single JSON, please stick to either camel case or dash delimited naming convention. The later one seems to be more popular in JSON so I'd prefer that one.
Not sure what do you suggest instead.
This is explicitly set and *cannot* be overridden by the RP.
These new sub-states need tests.
The PR is for node v0.8.12, but this is saying v0.8.11 is OK.
Mind sending over a JSON blob so it's clear what we are checking here? data.active is way better traceable as data only.
As given by Bill we can use max_pause for incremental GC but not for non-incremental GC. So we should differentiate between max_pause and total_time. Also we want to have the type and reason for GC according to the settings in config.js.

Something I will follow-up with is that we should pass-through the whole json blob to main.js and check for values we need for the widget there. That way we can pass all data to the log file or later graphing solutions. It's nothing you will have to take care in this pull request.

Beside that please update the timestamp code to retrieve it via the json blob, now that bug 736643 has been fixed.
Any observer we register we have to remove.
well, let this `todo` for the moment, and open an issue :p
This comment no longer matches the implementation.
Putting a link in the README is fine for now.
this shouldn't exists even IMO

The outputstream above will be replaced too.
Damn I can't get this work all the time either. Not a big deal we can just use ```,``` as the leader that is fine with me.
What about `~> 1.2.0.rc.2` instead?
yes, because shaply use (minx, miny, maxx, maxy) bbox, and TileCloud: (Bounds(minx, maxx), Bounds(miny, maxy)) !
Hmm, `config.php` was already present in `.gitignore` since #1. Are sure you fetched the upstream changes before starting to work?
mocha.js is built by a make target, all modifications are in lib/*
Looks like my IDE doesn't recognize parent namespace. Will fix
I'm wondering if you could use Zend_Uri for extract the Path part.

Also may this is more simple `preg_match('#[^/]/(.*)#')`
Don't commit this. Put in a comment. You don't need dead code in a file.
I agree with your for this point: +1 to switch to an exception for consistency.
with your code change, this : 
    
     $this->assertEquals($client->call('testFunc2', array('World')), 'Hello World!');

the result is alwas "Equals" , but skipped.

please try :  
      
      $this->assertEquals($client->call('testFunc2', array('WorldSSSS')), 'Hello World!');

and the result still valid :(
Same comment as previous.
Tab characters on lines 78 and 79.
This should be // CraftBukkit start - just use built-in teleport
If everyone else uses 64k then it's fine to leave at 64k. It just seems excessive to me, particularly given the practical experience we have here.
@divad12 pretty sure all people who seriously work on exercises have a separate clone of it.
Is "estimatedSize" better than "nodeSize" ? For the map I suggest "estimatedGainForLeftSafeLiteral".
I agree that they are useful, the thing is that some people will not understand what they are made for, and it will not be useful in some cases (for instance if pelican is installed system wide, by the package manager for instance).
Why not make apply_filters an instance method on the Search class?
ahh, stupid me just copy&pasting from the line above. Will fix.
other idem
Should be on a single docstring line. Also, extraneous "
You could change this to:
if mods or changed or unset:
    self.log.debug("\n".join(mods, text, unset_text))
so it's all in one debug statement?
I'm still having a small issue. The fullname (your real name on Flickr) is not always filled in so in my app the displayname is empty. Maybe we could set the displayname to username if the fullname is empty?
Well it is the `FOSUBRegistrationFormHandler` ... :P But probaby better safe than sorry.
I am wondering about this. I think it would be better to save `$element` in `$this->response` and in `getName()` return `$this->getNodeValue('./foaf:name', $this->response)`. That way you can extend this response class to add additional values to your response. Right now the original response is 'lost' after this method.

What do you think? :)
th tags?
again we show different icons, depending on platform so using present is the best here.
Instead of doing this, why don't you just put `test_search_with_space` and all the others as a top level method of the file?
`<ul><li><h2>` makes me suspect this might be better as a `<dl>`. But it's a little complex because you have these labels below, too, so `<dt>` can't just be the username. How about we file a follow-up bug to make this HTML more semantic and take it as-is for right now?
It's not required or anything. It should work just as well outside the label tag.
Ignore this. I'll file a follow-up to refactor this whole test case.
Could this be done with super()?
Addresses for positions are contiguous and (now) in the right order. Could be read in one go.
Not to nitpick, but mods have to contact Wranglers (via Support) to get non-canonicals added, so the text might need some rejiggering? "unless the moderator requests them to be added:" ?
Little clueless when it comes to windows.  Is it just a matter of replacing both forward and back slashes?  That's what you are referring to ya?
`bundle exec` is not needed for this, as `rails` will use `script/rails`.
Probably not needed when switch is it's own config.
instead of match just use:

if (connection.isDefined) {…} else {…}
Oh so you do! Any reasons to have History hidden in the menu and not as a tab on the home screen?
I think you'd want to declare `artifact` inside the block, so that it begins nil for each iteration.
Fix the indent to this function
Past tense would be better here
we could replace both these streams with concats and simple fs.writeFile()'s, should clean things up a bit there's no reason for them to be streams really, also hasCss wont account for dependencies that have css, we have to check the `Builder#build()` object
すべての配列の共通集合となる値のリストを算出します。結果となる値はそれぞれの配列内に存在することになります。
To later use this attribute, I think you should add the set for this attribute under the 81st line : $this->FollowMaster = $followMaster; ?
The PHPDoc property for $FollowMaster attribute mismatch with the one declared in PHP
1. You can interpolate in translations using a special syntax.
2. Pluralize takes an argument that determines if it should be pluralized or not. 

With both of those in mind, you could change this to something like:

```
::I18n.t("refinery.admin.images.form.error_count", :default => "There was %{error_count} %{error_plural).", :error_count => @errors.length, :error_plural => 'error'.pluralize(@errors.length))
```

Still not perfect because of the was/were discrepancy, but you get the idea.
What happens if you have a tree of comments and you delete the middle one?
I though we we're going with lazy deletion and just show a message: 'This comment has been deleted' in the UI?

All that would have to happen for this is that you have a `deleted` column that has a flag whether or not the comment has been removed.
This should have a lot more permutations for deleting threaded stuff

e.g.

- Delete top level comment, no reply
- Delete top level comment with reply
- Delete reply, no reply
- Delete reply with reply

+ Should also verify validation and permissions
This seems like an exact copy of twitter (almost). Any code we can re-use?
private row?
data parameter is not handled anymore.
I'm thinking this would be nicer as:

    git up
    git up upstream

`up` being short for "update" and taking an optional remote option, which defaults to `origin`.

Seeking feedback on that idea. Also not sure how to implement the `$1 || 'origin'`.
What about Checks#fetch? Similar to hash syntax, I guess.
Shouldn't this be `$buckets = array();`?
Waarom weer terug naar de main map? We hebben net de big map gepushed.
Do you not think it's a little cleaner? It also reduces LOC by ~25% whilst doing so. Obviously your call, but I'll add a test to this and leave it with you.

Anthony.
Очень неэффективный алгоритм. Итераций будет на несколько порядков больше, чем x. В худшем случае цикл действительно будет бесконечным.
Если еще не смотрели лекцию 3 - лучше посмотрите. Два ваших метода makeString и print можно заменить одним методом description.
Этот массив лучше вынести в класс, так как создавать его каждый раз при вызове ф-ии — лишняя работа
@vitalaw вот до кодировки CP1252 я так и не дошёл, да. Спасибо, добавлю-ка в закладки. =)
Почему  лучше инициализацию производить с указанием размера?
Есть вероятность того, что заново сгенерированный нуклеотид будет таким же, что и первоначальный, что за мутацию не засчитывается.
Why did you undo this test?
Also, please don't use the style attribute unless you have to. Use a CSS class and add appropriate styles to main.css Thanks!
called *the* push attribute list.
Removing the else clause here causes the scan for parent blocks to recursively scan inside of 'block' nodes as well as other nodes. This was the only change required to fix the nested block definitions in inheritance bug (#60).
(If there's an awesome dojo-y way for doing this, I would love to replace that nasty awkward chain of doom.)

On Monday, October 15, 2012 at 2:08 PM, Evan Hensleigh wrote:

> It is—I want to call Google Map's postCreate, but NOT ChildNodes', and AFAIK this is the only way to do it.
>  
> On Monday, October 15, 2012 at 2:05 PM, Chris Barrett wrote:
>  
> > In app/toura/components/ChildNodesMap.js:
> > > templateString : dojo.cache('toura.components', 'ChildNodesMap/ChildNodesMap.haml'), > handleClicks : false, > > - prepareData : function() { > - this.node.populateChildren(); > + postCreate : function() { > + // this.inherited(arguments); > + toura.components.GoogleMap.prototype.postCreate.apply(this, arguments);  
> > Was this still necessary?
> >  
> > —
> > Reply to this email directly or view it on GitHub (https://github.com/futuraprime/mulberry/pull/3/files#r1845063).  
> >  
> >  
> >  
> >  
>  
>
I guess it's meant to be less bookkeeping for when you want to schedule a block on a background thread without specifying anything else, but the performance improvement over creating a new `+backgroundScheduler`, scheduling the block, and throwing away the scheduler is probably negligible.
Missing command docs and description (mistakenly?) removed.
Notes like this should be up in the top documentation section, under 'Notes'
@codyhoag This leading paragraph needs to remind the reader how OAuth is being used.
>There are a couple of tests that "Checkout" a bare repository outside of the specific BranchFixture tests.

@jamill What would you think about moving all of them in a separate `CheckoutFixture` file?
Hey! You stole my questions :smile:

> Should the target of the note taken into account as well?
The problem is that there is currently no way in libgit2 that I'm awere of which can give us the target of the note (nothing comparable to `git_tag_target_oid` if you prefer).

> Should the same textual content created at a different moment pointing at a different object be considered the same Note or not?
Despite feeling that you asked the question in a rethorical way, I would say yes. A note as it is defined currently in libgit2 looks a lot like a blob (same granularity). So the content, or the blob id would do the trick I feel (at least for the moment).
Is `TestHiddenWidget` used, or is it a leftover of the development phase which can be deleted?
```
if 'command_line' in info:
   ....
```
we could think of a way to take care this SSVEP case by passing a list of frequencies rather than an interval used with the FFT.
wait. To me having to check verbose here defeats the purpose of the logger instance. If the logger is an instance that has a state and it should know how verbose it should be. If the verbosity level is 0 or False then logger.info() should basically ignore the call to info.

makes sense?
Isn't UN_TOKENIZED the default?
this should be also 16?
Can we please name the configuration `confirm_within` ? It will be similar to `reset_password_within`.
This is not only shorter, this is also faster because key is computed once for each item while compare function is computed for every compare.

Anyway, 'cmp' argument was removed in python3 so we have to use 'key' argument. There is functools.cmp_to_key function but it is not available in python 2.6.
Good catch, I will fix it
can we instantiate Instrumenter only once ? (this create an instance per processed file)
this will be addressed by a separate PR by @swederik.
Mhh... wasn't there consensus on the mailing list to leave Duration out for now?
Ошибаешься. У меня максимальное значение выдается в 1.5, емнип
I see two cons to that.
First, github truncate long label on the "show issue" page (ex: https://github.com/gquemener/dotfiles/issues/1), but given the color code, maybe this is not such a big problem.
Secundo, it will be longer to type (and a bit stranger too): `bin/behat --tags="@behat:failed"`, it makes the word 'behat' repeated twice.

However, this should be configurable!
`omit` en lugar de `ommit`.
Another use of `final`, `fis` also needs to be disposed properly.