labofsahil/github-event-dataset-2012 huggingface dataset:
`dir` argument needs to be `folder`. I would use `outdir` instead. Both argument parser and `kwargs` needs to be updated.
Yep, will do. Thanks!
в списке инициализации отступ 2 таба
Can we please create a public API in `attr` to comport this? We shouldn't be calling `instance_variable_set`. Also this line is too long.
Instead of "Column names" we can say "keys".
AV dependency?
`Hash#delete` accepts a block with the default value

```ruby
length = options.delete(:length) { 30 }
```
Can clarify this with `Hash#fetch`:

```
seconds_to_advance = options.fetch(:seconds, 0) + 60*options.fetch(:minutes, 0) + 3600*options.fetch(:hours, 0)
```
Don't use public. if you need the methods after the private being public just move the private method to below all the public
please don't use class names in Spanish, also don't use text in Portuguese
I agree, but then let's rename HIDDEN and isHidden! We just introduced it a couple weeks ago, it's not like it has some huge installed base of users.  Two names for something is a last resort, not a first.
Let's ask @magarciaEPFL. Miguel, could you, please, comment?

But in the meanwhile, could we, please, have this in trunk? I routinely use locker because of its minimalism, so that'd be a significant convenience for me.
This is ok for package objects?
Better to save this for the Pull Request description, IMO. Otherwise the notifications are sent as soon as you push the commit your a WIP branch.
Sorry to be unclear: I meant it would be better to import and call `scipy.linalg.matfuncs.expm` here.  It is largely the same code, correct?
Why did you move this method out of being a private method? Why should it be a public method?
Why do you test repr instead of str?
are negatives supported?

Is it necessary to provide the sum? Perhaps it could be computed if not given (i.e. `len(args) == 1 and type(args[0]) is list`)
sign simplification makes this `-(-p1*p2)`
Why do you argue? This piece of code is not required to provide the method.

>you can assume that this algorithm used once, and forget to look for copy of it

Enough already to justify a bad refactoring, covering everything forever oblivious programmers. It is a myth.
Otherwise ifFormat will not used.
lol. I just copied from an email from @jusuff :wink: 

btw - if your other message you metioned jusuff's impending merge this weekend. You should note that this is a PR for the 1.3 branch, not 1.4. It is just a way to use ajax in 1.3
Can you add some more description about this?
minor thing - missing CALL ENTERS
Removed `return $hookArg;` so now the method no longer returns anything.
So I read up more on ABCs in Python and, while I personally disagree with it's preference of "inspection over invocation," ABC is the preferred/more Pythonic way to go so this is good.
+1. Sometimes I receive errors what `records` object is null.
It's just a command line argument of test application. Something like time to live.
If something goes wrong while testing/debugging don't want to run application in background forever.

test_app usage:
#usage: $0 number_of_iterations [daemon_name_if_daemonized]

Don't think need to use our params here, it's just a toy.
The basic overview should contain something about not being able to make any changes that alter the size of the documents.
Oups... J'ai pas répondu à la question. Désolé. Je ne tiens pas à row-fluid, mais plutôt à avoir tout uniforme pour la raison évoqué précédemment.
Prefix all columns with the table name (in this case alias). I.e. `p.` oder `a.`
Or rather, rename find to index and then it'll be consistent. This is js code, not php.
1. done
2. Huh? (I didn't understand)
3. Fixed.
@nickvergessen this line and line above it retreives some part of $split_keywords and store in $this->split_words. thats what i meant by saying the code block below is unnecessary sine under no circumstance $this>split_words will have quotes. I hope i am not missing something?
should be files
Hmm, can not use `/* */` in the docblock itself. Any concrete text suggestions?
fă stringul de la error translatabil: _("You have...").
Why is this check here?

It seems to me that action_msg isn't set.
Your new version is correct and faster; it is still faster without the
other quick exit,
for instance the following example is 17% faster on my computer without the
code for that special case

```
from time import time
from sympy.combinatorics.named_groups import RubikGroup

def bench1():
    G = RubikGroup(3)
    it = G.generate()
    a = [it.next() for i in range(10000)]
    t0 = time()
    for x in a:
        fc = G.coset_factor(x)
    t1 = time()
    print '%.3f' %(t1-t0)
bench1()
```


On Mon, Sep 17, 2012 at 5:09 PM, Christopher Smith <notifications@github.com
> wrote:

> In sympy/combinatorics/perm_groups.py:
>
> > @@ -1259,13 +1258,10 @@ def coset_factor(self, g):
> >          I = range(self.degree)
> >          if g == I:
> >              return [I]*(len(u))
> > -        # look for another quick exit
> > -        if any(p == g for ui in u for p in ui):
> > -            return [I]*(len(u) - 1) + [g]
>
> I understand now...please see the slightly modified version of your edits
> that I committed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/smichr/sympy/pull/17/files#r1619373>.
>
>
Access to local members should be prefixes with `this`
The init method should take another argument called ``tracker_name`` and the settings you're setting below should be taken from ``settings.ISSUETRACKERS[tracker_name]`` and not necessarily from ``default``.

This argument may have a default value of ``'default'``.

Also, check if the ``ENGINE`` for the chosen tracker is set to ``Jira``. If not, raise a ``ValueError``.
Check whether the downloaded ethernet is the same you added in setUp()
```coffeescript
br = globals.window.brunch ?= {}
settings = br.test ?= {}
settings.filterer = (fullName) ->
  testName = fullName.replace(stripTestDirRegex, '')
  filterRegex.test testName
```
CID 751861 (#1 of 1): Logically dead code (DEADCODE)
Execution cannot reach this statement
you don't think this is worth a test?
Actually, the system is convenient in that if you just make another commit and push it, that commit gets added to this pull request.
Just FYI, this build target works if you need something to start with when working on the PEAR generation stuff.
why this is showing as difference
can you please fix the formatting ...
Actually, this does need to be one of them because reduce here uses the first element as the accumulator and the test accumulates into it.
this is clever.
```// FIXME: MADLIB-513: Pending Boost bug 6934 ...```
The update operation is very expensive, especially for large dataset. I think we can use the following SQL statement to create the target table so that we can avoid the updating. And we can remove the tree_id column from the sample_result_temp.  Although we need to calculate the tid and nid twice, i think it can do better than updating.
```
CREATE TEMP TABLE target_tale(id, tid, nid, weight) AS
SELECT record_id, (sample_id-1)%num_of_tree + 1 as tid, (sample_id-1)%num_of_tree + 1 as nid,  count(*) as weight
FROM sample_result_temp t, src_table k
WHERE  t.record_id=k.id
GROUP BY record_id, tid, nid;
```
Ok. Added the MADLIB_PG_TRY.
I'm assuming you meant to use this variable in the following two logger lines to prevent casting in both lines?
Do we need to care about names in this API or could this be made to be the MPD frontend codes problem as this could be considered an MPD-ism?
Same sanity checking goes for deletes.
Dear jacknagel, 
   the proposed approach did not work as the man page is created during the "make install" execution. And the make install execution will fail if the work-around is not put in place. I worked out with a solution that takes in account your suggestion but stil uses some workaround.
o.O ... thank you!!
Need to update the checksum as well!
Do you need to create the list here using `++`? If this will end up getting handled by a `list_to_binary` (which AFAICT is the same as `iolist_to_binary` and handles iolists, then you can just reutrn the list as:

```
[<<"(">>, join(...), <<")">>]
```
`box-shadow` can be safely used without vendor prefixes.

http://caniuse.com/#feat=css-boxshadow
Do we really need a separate test here? Isn't all event routing the same?
Looks OK but later it would be good to unify with Confirm::MustBeRoot() function.
I think this is either an indicator that 'waitForHTML' is the wrong name for this property, or you should just be checking the presence of 'html' itself:

```coffeescript
if (html = @get('html'))?
  $setInnerHTML @get('node'), html
```
Is this really a worthy abstraction? Just put it inline.
This is a fancy way of saying `factor / 2`
dur, No you're not. But `supportsMulberry` is global.
Whether or not autoRemove is enabled, we should always remove the popUp from ``_popUps``. This block should be:

```
if (autoRemove) {
  $popUp.remove();
}
_popUps.splice(index, 1);
```
ok, I'll remove the unneeded undefined checks.
@GarthDB What do you think?
new counting bloom filter id is inclusive, right? so need a +1 there?
Toying with the Idea of loading as much js in the footer to improve page-load times.
Stylistic stuff: I think this `if` should have curly braces and there should be spaces after commas. It would also be helpful to have a comment explaining how this works.

In case you're wondering why all the ggplot2 code isn't like this, it's because some of it is old code, written in a different style.
I think that's right - you should instead do `geom_point(data=df0, x = 10, y = 10, colour = "red")` - if there's no data, there's nothing to plot.
Shouldn't this be `app_data` instead of `app_signed_request_data`?

http://developers.facebook.com/docs/authentication/signed_request/
I am not sure if this works/is needed?
I want some kind of shared class here so I can use all the good label, textarea, input classes in whatever we need. Should I make it something more general-sounding and change that in the editors too?
Should we attempt to do any sanitization or cleaning of this?
6 is the length of the <head> tag bracket.
You can probably use the form `LangUtils.domFragment( SUPER_SCROLLBAR_LAYOUT, "#butter-super-scrollbar-outer-container" )`
Instead of involving `CrashReporter` here, you can eliminate the dependency by using `dialog.send( message, data );` and listening for it on the other side (in `crashreporter.js`).
Yeah, I need to rip out the current mongodb session store we use for another one that can gracefully handle the existence of no MongoDB.
Yes, but we need it here now. It was inserted in a different ticket, so I don't actually know why it's all green unless it went through an indentation change.
Damn, this whole section is a repeat.
This will provide visual feedback for droppable areas as well
Mostly just the wrong impression of where ems are better.
Add braces for if statements or replace with `url = url.get('Type').name === 'Filespec' ? url.get('F') : '';` (you may need to split into two lines)
```if (setting.id == xx && ShowAndGetInput)```
no { } needed. saves a couple of lines :)
I think the best behaviour would be to silently ignore non critical arguments like server_name but fail if security critical arguments get added later.
这段代码挺容易出错的，如果能把cookie的解析过程，改成状态机，代码将会更加漂亮
暂停新的worker，有点危险啊
I'll create an issue for finding a style and updating the docs to list it.
This test doesn't actually verify that it falls back to showing the speakers starting from the lowest possible character. It's an interesting thing to test, but I could go either way whether it actually gets tested. However, if you decide not to assert that specific thing, I'd tweak the docstring so it doesn't allude to this being tested.
Does using just `**/*.{h,m}` not work?
Ok I am merging exit_with and exit_with_error into one function, does not make sense to have two.
Might wanna return
```ruby
Support.array_with_total
```
instead of empty array
Not really.  A lot of times with form inputs its easier to just do one big form submit event instead of a click event and a form event (captures hitting enter as well).  I think it was just an artifact of that even though this doesn't have any form elements.  I would be for getting rid of it, but the buttons don't need to be of type submit, and no preventDefault() needed.
doh yes.
Lose setCount
Well if we have a regression (and we have) maybe it's okay to have some tests failing :)
On 06/04/2012 06:33, Fabien Cazenave [:kazé] wrote:
>> @@ -1134,8 +1134,10 @@
>>           currentLang = match[1];
>>           skipLang = (currentLang != lang) && (currentLang != '*');
>>           continue;
>> -      } else if (skipLang)
>> +      }
>> +      else if (skipLang) {
> I heard the exact opposite. :-(

That's a lie! :)
I don't think requiring a `get_w` function is a good idea, for the following reasons:

- for a constant w cosmology (LambdaCDM, wCDM), it makes sense for this to be an attribute and not a function, since it isn't a function of redshift.
- There is already a precedent with `H(z)` that the name of the function doesn't start with a get_,. i.e. why do we calculate the Hubble parameter with `H(z)`, but the w value with `get_w(z)`

So I don't think `get_w` or  `_w_integral` should be defined in `FLRWCosmology`, they should be implemented differently by the individual cosmologies.  Also, the function to find `w(z)` should be called `w(z)` and not `get_w(z)` for those cosmologies with varying w.

This also means this base class shouldn't define a generalised `_efunc` and `_inv_efunc`. I also think this is a good think, given that you pointed out the code is inefficient (integral of an integral), and it's not clear whether anyone will need this.
Huh, yes. Erm, I have no idea why the code in your patch wasn't part of the code already…thank you.
Why remove this line? I found this necessary to avoid a warning with VC2010.
please remove the "static", we dont use that hint
why are you removing some of them ?
Can you comment on the purpose of this change?
You probably don't want to keep the Unix-specific code here.
@cgjones - It would be nice to what exactly for all processes?
Why not `eq_`?
Oh yeah, you're right. I was thinking more in the case of inactive redirecting to active, but I put the comment in the wrong place.
It should be `(r'^privacy', include('privacy.urls')),`
This change pulls in a version that has an S that lets you override how it calculates the doctype to use for searching.
this is specifically for webkit. to implement native momentum scrolling on iOS I have to use `-webkit-overflow-scrolling: touch` this ensures that all elements render correctly when using momentum scrolling.
Perhaps we should change SHAPE_CIRCLE/SHAPE_OCTAGON to 'circle' and 'octagon'
noted. it makes sense. Although I don't know anything about AppResources, it looks like it's a WP thing only.
The last sentence is no longer accurate, right?  Instead it's something like

```
The `_utc` variant assumes that *ts* represents a UTC time, while the
`_local` variant assumes that *ts* represents a time in the local time
zone.
```
Well, dreamweb is using 8 bit graphics, so this should never happen. I can change this to use pitch instead though
The missing k prefix here is an omission on my part. I'll look at adding a commit to rename these to comply more closely with coding conventions.

The enum is a little trickier. AFAIK an enum type is always internally a uint16 (short int) or uint32 (int) type, which will double or quadruple the const memory usage in the compiled binary compared to the uint8 (byte) type, though I wasn't sure whether the effect of alignment / masking on access would actually prevent any saving in real-world usage.

The issue I was trying to avoid was increasing the ROM (code segment) usage in the ScummVM teenagent engine as a side-effect of doing the refactoring and adding readable symbols. If I had used defines, then any symbol used multiple times would probably still be multiple values in the const segment, so doing this as a const variable should "deduplicate" and thus save ROM. enums would be better, but their size is the issue.

I should explain that saving an extra byte here and there is not normally a critical aim, except that the Teenagent engine open bugs are mainly reported from PSP and other memory-limited platforms and a secondary aim of the refactoring was to close memory leaks and reduce RAM usage, but without significant increase in ROM usage.

I'm also not sure if I tried making this int/enum and I found it required casts on usage to prevent "precision loss" type compiler wanrings...

Does fuzzie or anyone familar with detail of compiler internals know if an enum type is dynamically sized to save memory , if it can be type selected or if it is fixed at uint32 (int)?

P.S. I may be "overthinking" this and the actual saving is neglible, but I made this choice a while back and I can't quite remember the rationale at the time.
правильно. дякую
You need to set it to `false` by default (like done [here](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L33) for the `trustProxy` property in `Request`)
you should use ``assertCount(2, $collection)``
needs to be mentioned in phpdoc
Ok, should I rebase the PR on 2.1 then and include the rest of the work and open a new one for the upgrade file?
which are used
Yeah, sounds good. I used runtimeName since I thought we later might want to add runtimeVersion and such.
What does the alert do?
Extra space before `==`.

Also, flippin' sweet.
should cleaning up.
This empty line is redundant
I like that `r is land_downloader` is true. Similarly, it'd be nice to have `r is generic_ne_downloader` for the `ocean_spec` case. This comes back to the caching-of-Downloaders/copying issue discussed on the previous PR. I'm inclined to leave out complexity that doesn't have a use.
This is only true if ``params == null``, and these logs should probably be at debug.
{Promise} ?
i think it would be helpful for code organization to move these list/set helper functions to a separate .c/.h file... thoughts?
Oh... yeah, in retrospect, the code that looks for suggestions seems like it should be in its own method. This seems good to me. I'll try to get it pulled tomorrow.
There are a few placeres with whitespace before `)`. Could you remove that? It doesn't follow the coding guidelines.
Is there any particular reason why you prefer to output the spinner as part of the template instead of i[nserting it using Javascript](https://github.com/aakb/ting/commit/6af0e80ec7de8bb944ba3b35c13624cffa441fbe#L0L7)? For clients which does not support Javascript hiding the element entirely seems like the right way to go.

Also this may result in multiple elements with the same ID. Perhaps that is the final argument for changing this to avoid the soft dependency to `ting_search`.
ok that the kind of function that i have forget they exist, thank's to point me on, i will try ...
I've removed this commented line and added documentation in the next commits that I've added to the PR.
I've tweaked this value so that it's long enough to not close the menu accidentally, and short enough that it's still possible to quickly select an item with one click in the SelectButtonView.
Oh duh.  I wasn't paying close attention to the context - brain wasn't on this morning.

Ok, it seems like this should be a utility function in lib/gallery.common.js but I'm ok with leaving it the way it is for now and we can refactor it out later if we have multiple implementations of this type of aspect ratio calculations in JS.
and btw, the example runs on http://harvesthq.github.com/chosen/
This is easy to do as we are using some template engine, if not it will be a mess :D
This is very ugly :) Could we know our height and when the keyboard is displayed (then our viewport should be reduced) calculate the diff we could know this information.. It is only an idea and I don't know if it work fine or not
#5305 changed this to"Enter a search term or web address to start browsing."

As @benfrancis pointed out on iRC, it seems to be a repetition of what the URL bar already says, and the important piece of information (top sites - you don't have top site yet) is missing.

cc @jcarpenter
The latest icons I receive are 64x64 icons and we need some additional space for the drop shadow. @patrykdesign Any opinion on that?
ok, I will correct it
no need to bind(this) since the function does not use this. And you don't do it for the onsuccess function above.
timer will be canceled at Line 97 when the screen is being turn back on.
This needs to stay off the whitelist.
move this to 
`var formattedBalance = '--';`
@vingtetun Not too hard I would think, I always forget myself, just need someone /w the python skills to add a module to gjslint.
Janurary -> January
This should probably be parsed as an integer like above.
I'd prefer this wasn't a public method.  I want to keep VCR's public API as small as possible; that helps me maintain it easier.  You can certainly make this a private helper method, though.  There's no need for a test for it, either; it'll be implicitly tested by the tests for `assert_finished!` (or whatever we call it).
We shouldn't default to `1` here, otherwise branches without PRs will have build statuses posted to PR #1.

We should just not comment if no PR is found for the branch.
The note below eliminates this function
Throw or silently drop? Meh?
These are intentionally out of the gemspec, if you try to install it as a gem you shouldn't be force to pull dependencies for plugins you may not want.
Kinda break your abstraction here. It would be a little cleaner to have this check in JSONMaker class, instead of checking the dictionary by hand out here.  Perhaps in the JSONMaker constructor?
For tags split across multiple lines, you'll want to indent the second line so that it's obvious that there's a continuation.
Question: Won't this cause the thread to spin and wait for this? Is there a better solution?
yeah, logical error
This `session` variant seems no use?
I'm saying forget the case statement and just do `{ok, Schema} = ...`  If that call fails something really stupid happened (well actually, the ETS table for the cache may not be around if these calls are somehow coming in before Search starts but that should be a change to get_schema, not here).
That makes sense. Could you record that reasoning somewhere?

In any case, is there a reason for having an id column on that table, rather than just having `schedulerid` be the primary key?
The reason should perhaps be updated to not refer to the web page (or changed so that that is specified from the web code.
Is the usage of   float   intended here?
```FALSE``` should be lowercase.
@till it is not the lock from master. It is an older lock from master.
We can certainly move it. Just to be clear, this file will be moved to guvnor/src/main/zanata.
if you pass in an edition string as the third param ("UK", "US"), the time will be region specific, e.g. show EST if viewing in america
Let me rephrase that...it won't raise from the pyapns server.
this should probably be %{@source_path} not %{source_path}, right?
I think the overall approach is good, but I'm not sure why you changed from plugin_page() to manually building the url.

Otherwise I'm going to merge this to be available for 1.2.11
this should be in the if statement to match byran's diff, but I'm not sure this is the best way to go yet anyhow.
There already is a pref controlling it, it was just never documented before so I've added a note about that.
It's little confusing to have comment of `joinPath` on top of this function. I would move it below this function and maybe add comment saying that it's internal utility used by `joinPath`.
This is confusing, you just created options on line 30, which did not had any `window`, also super should not be adding things here.
So either make `options` be an argument to `initialize` or just get rid off it entirely.
@benadida - after reading through the spec, `public-key` is the old field name whereas `publicKey` is the new, is there any danger of a cert containing both fields?  If so, would that be an error?  If not an error, should 'public-key' take precedence over 'publicKey' even though the latter is the newly specified field?
Agreed!  Nice tests, and nice style of tests.
Maybe you may use a ternary operator here
This is a manual change I did :)
It might be worth creating this lazily, on demand, since most Ruby DSL files will not use it.
This is a pretty odd use of "tap", since the "return the instance" behaviour is unused.  It would be better written without that.
This won't work, it means I can only see either my posts logged in or everyone else's not logged in but not both.
Since the heartbeat beat interval is able to be specified in the config and could be several seconds, leaving just the heartbeat channel to do the killing of kernels will leave the kernels of one-of computations alive for up to several seconds after execution has finished. I guess it may not matter, but I figured why not kill them immediately?
Please add a doc for this.
Unnecessary type?
This docblock must go before `class`
Use a dataProvider instead; less verbose, and makes the tests easier to read.
I think this should not be a test-dependency but a normal one.
author and since
`radius` is a variable based on whether or not the creeper is powered, and is defined on [L162](https://github.com/Bukkit/CraftBukkit/pull/806/files#L1R62)
wait you are right, i am fixing this
But you don't need to move your eyes between sides of your monitor
you forgot to use arglen here
I don't see how using `this` is anymore readable. `@` is used in the rest of the code, and I want to be consistent.
WTF is this!?
@samiluukkonen What?
\` \`
Spaces, spaces, ....
Hi Pete,

I do not know why,  Yes you're right does not make sense. I will modify that.

Cheers
I delete this lines and test compiled project in chorme & firfox. It is works perfect. So i remove this lines permanently.
This is unnecessarily strict. `typeof` always produces a string.
/me refrains from trying to write all this in one line using a generator expression ;)
That's acceptable. It's not a page, so shouldn't be a child class of Page. In fact, the __init__ method wouldn't need to be identical as you're only using the selenium object in this class.
@teodosia Glenn is unwatching the page on line 34, however if a step between watching and unwatching was to fail then the page may remain in the watch list.

@glennhoward Another option would be to remove all pages from the watchlist after logging in.
I used to have some debug statements there, no longer needed & will fix :)
The indenting is a little off again starting here.

We could use some more classes throughout this, not just in case we want to style it, but also to help us apply javascript without all of those child combinators down there. The h3 in line 16 could use class="heading", the ol in 17 could use class="faq index group", the ol in 19 could use class="category", the a in 20 could use class="title".
Can you make the confirmation message a translation string?
Me too, but Eclipse did not, and I am pragmatic.
This is rootDir in EnvJasmime, not projectDir.
I gotcha. Can you push those changes up to master soon? That'll give @jlee42 something to base his changes off of.
That was actually a pretty stupid thing to do. It should have been obvious when I wrote this that `getTranslatorObject` will be asynchronous and I'll need to handle this differently.

I'll look this up in the source, but perhaps you can answer this quickly. With `Zotero.wait` now a no-op, how does the calling function know to wait for Zotero.done()? Does it do it if there is no return?
There is some mixing here between Response.Status (server side concept), and ClientResponse.Status (client side concept)
#23478
This is the new method on ChildReferences that is used by LazyCachedNode to know when the ChildReferences should be used to find the ChildReference given a child's node key.
Use the function isRTL in this if statement
You properly shouldn't use the fixer as-is for JavaScript as it was meanly developed for php.
oops.  but this is where you would overide default route
It is not related- myapp is a dummy test project. The schema.rb file was generated when I ran the migration for the test project. See: http://www.quora.com/Ruby-on-Rails/What-is-schema-rb-in-rails-project
Please remove personal reminders prior to pull request. Also whitespace.
If that simulates a download I think that's ok.

On 6-dec.-2012, at 10:51, Simon Gaeremynck <notifications@github.com> wrote:

> In node_modules/oae-principals/tests/test-cropping.js:
> 
> > +
> > +        it('verify bad mimetype', function(callback) {
> > +            createUser(function(ctx) {
> > +                RestAPI.User.uploadPicture(ctx, ctx.userObj.id, getTextStream, null, function(err) {
> > +                    assert.equal(err.code, 400);
> > +                    callback();
> > +                });
> > +            });
> > +        });
> > +
> > +        it('verify cropping', function(callback) {
> > +            createUser(function(ctx) {
> > +                RestAPI.User.uploadPicture(ctx, ctx.userObj.id, getPictureStream, null, function(err) {
> > +                    assert.ok(!err);
> > +                    var selectedArea = createSelectedArea(10, 10, 200, 200);
> > +                    RestAPI.Crop.cropPicture(ctx, ctx.userObj.id, selectedArea, function(err) {
> That's because we don't have a way to "download" a file in the unit tests yet.
> That said, I think I can get the root dir from the config API, append the uri and open the file directly, rather than downloading it. WDYT?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Expiring is spelled wrong here
Is this a custom validator? Should we design it to be used like this instead:

`validator.check(ctx, {'code': 401, 'msg': 'You have to be logged in to be able to create a conten item'}).isLoggedInUser();`

Which seems to be more consistent with the other validator methods.
Because then criticalHitLevel() will be incorrect.The engine would still work of course, but if for some reason we ever rely on criticalHitLevel() somewhere else, we might easily introduce a bug.
``EmptyIndex``
Same comment as in https://github.com/scala-ide/scala-ide/pull/261/files#r2419172, if you think it's valid.
This seems to be the wrong function. Did you maybe wanted to use addIndexKey() instead?
this name is funny what about:
fetch_check or get_check

we know they are registered since its the checks container
Usually we use `Array#push`, as in:

```javascript
entryData.push({
  name: ...,
  hours: ...
});
```
this is wrong. It will only work for the GoutteDriver and will throw a Fatal Error for others
Отсутствует проверка x на допустимый диапазон [0;100].
Это можно сократить до
if (self = [super init])
100 скорее всего должно быть константой.. т.к если условие изменится, Вам прийдется лазить по всему коду и изменять величину
Вот здесь подвисает выполнение с выводом в консоль следующего:
---------------------------------------------------------------------
self	Cell *	0x0000000100114370
cell	Cell *	0x00000001001147f0
diffOfDNA	int	78
n	int	100
_DNA	__NSArrayM *	0x00000001001150c0
---------------------------------------------------------------------
2012-11-05 23:18:06.338 Human DNA[1995:403] *** Terminating app due to uncaught exception 'NSRangeException', reason: '*** -[__NSArrayM objectAtIndex:]: index 100 beyond bounds [0 .. 99]'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff9551cf56 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff8cde3dee objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff954aa392 -[__NSArrayM objectAtIndex:] + 274
	3   Human DNA                           0x00000001000017ec -[Cell hammingDistance:] + 108
	4   Human DNA                           0x0000000100001459 main + 153
	5   Human DNA                           0x00000001000010e4 start + 52
)
terminate called throwing an exception(lldb)
Так мы говорим о том, что вы сами сделали себе дополнительную проверку, а значит, подразумеваете, что может возникнуть ситуация, когда длины будут разные. Но проверка бессмысленная, так как не будет отражать действительности.
не уверен в правильности &&
Более детальный взгляд на алгоритм показал, что не выполняется гораздо более важный нюанс: randomLetter может содержать индекс элемента, совпадающего с тем, который мы заменяем в массиве DNA. Такая замена является некорректной, и проверка должна присутствовать (хоть явно и не указано в задании, но активно обсуждалось в комментариях). Думаю, что как раз в этом причина несовпадения результата выполнения метода mutate, о котором я написал в Discussion.
This is not how to iterate over a list. Use this instead:

    for node in parent:
      if node["name"] == name:
        return node
Please follow the same column aligning style that I was using in the previous revision of this file. ie:

      emitter.emit('progress', {
          percent : result[1]
        , speed   : result[3]
        , eta     : result[4]
      });
Seems to be [a pretty common question](https://www.google.com/search?q=nsarray+remove+duplicates) for `NSArray`, at least.
Is there a reason this isn't implemented as a map + flatten?
Sure - will split this test.
I would just call it "projs"
I thought about simple truncation (like you suggest) as a method for equalizing epochs. I think it could make sense to give users the option of which of these two methods to use.

I'm not sure I'd call this method a "trick" exactly -- I think it makes some sense as a way to balancing the number of epochs. If one is going to underpower analysis to deal with trial-count induced bias, they have to choose how to underpower their analysis. This method works based on the idea that if there happened to be some time-varying (like on the scale of minutes) noise characteristics during a recording, they could be compensated for (to some extent) in the equalization process. This method thus seeks to reduce any of those effects by minimizing the differences in the times of the events in the two sets of epochs. For example, if one had event times [1, 2, 3, 4, 120, 121] and the other one had [3.5, 4.5, 120.5, 121.5], it would make the most sense to me to remove events at times [1, 2] in the first epochs and not [20, 21]:

```
>>> t1 = np.array([1, 2, 3, 4, 120, 121])
>>> t2 = np.array([3.5, 4.5, 120.5, 121.5])
>>> t1[mne.epochs._minimize_time_diff(t2, t1)]
array([ 3,  4, 120, 121])
```

In terms of dealing with it statistically instead of underpowering the analysis (like this will do), I also tried computing a scalar debiasing factor, as well as averaging over multiple random undersamplings (underpowering the analysis in multiple ways). I could never get rid the resulting t distributions to look as reasonable as simply underpowering the analysis (not to mention the additional complexity involved in describing these methods to reviewers who may already struggle with statistics), so I decided this was a sensible way to go. I'm fine with removing it, though, if people think it's not the best way for public consumption...
only keep the needed routes. The jobs feed doesn't need user and index.
Is that on purpose? Or should we guard based on exists of webui_priv.pem?
This is not helpful with more than one advice.
I'd say remove them. Would be nice to not have to maintain anymore.
The name of this class makes absolutely no sense - there are no *ITCH4 files*! I assume you're referring to the SoupBinTCP format here but it's best to keep that out of this pull request.
You shouldn't access this, its not a public API and may change with future releases. You should use the `QUnit.log` callback instead, which has a documented public API and provides html-free messages: http://api.qunitjs.com/QUnit.log/
These 2 methods in the await object can be refactored to a different signature if needed.

I'm not sure if the Awaitable trait should live in the Await object, but if you insist, it can also be done.
Done; I also used this method in some functions when lp.ngens > 1, since in some benchmark it turns out to be faster.
Та же хрень здесь.
We need to introduce a new term the way the "todos" project does it.  Hints in the text edit boxes.
Technically works, though I was looking more for separate conditionals.  Still counts for full credit :)
camelCase meta struc (same below)
Jumps to last? or after last?
Do you need a hard dependency on Hibernate?  Couldn't you make do with one on the JPA interfaces from JavaEE?
Nit: let's rename the function to `_format_value()` 'cause "formatter" looks more suitable as a name for a class.
Can you remove these whitespace only changes in non-relevant files from the commit.  (Should be possible with commit amending in git).  They make browsing the history more cumbersome.
I'm glad my factoring has made it so easy to add a button. I can't remember if there were any backends which do not currently use this list. Probably worth checking.
is `select category` supposed to be a string? if so can you add quotes
this is not a non destructive test
Yeah, this code is broken. We need to create an `InvitationStats` object for any users that don't already have one. I'll fix this and push an update in a bit.
Please use the streamparser class for this. Should make life much easier.
Lint: `$k` is unused
I'm not a big fan of exists, as whether an item exists or is valid are really two separate questions. The "get" function may be able to return a value that exists, but is past it's ttl and therefore no longer valid, at which point the developers using the library needs to make a decision about what they'd like to do. In most cases they'll treat validity and existence as the same, but that won't always be the case.
I don't think I can merge this in since `/home/christian/src/vagrant` doesn't exist on my machine ;)
`canView = false;` --> `return false;` to avoid having to use a variable
Missing spaces on this line and below
Thanks! I have fixed this.
why no longer -1?
Cleaned this up.
Yeah, its a specialized format for Markdown Plus, described here: http://doc.silverstripe.org/framework/en/trunk/misc/ss-markdown
yes. I first missed the fact you did it in case of an id is not provided
is there a way to remove the duplication?
well, the thing is that `assert.deepEqual` throws an error when the assertion fails:

    > assert.deepEqual({lorem:1,ipsum:2}, {lorem:1});

    AssertionError: {"lorem":1,"ipsum":2} deepEqual {"lorem":1}
        at [object Context]:1:8

and I just wanted a function to return true or false, I could use try/catch though, what do you think is better?
or at the same level as `this.includesObject` and `~this.obj`?
Quoting JP Slavinsky  
<reply@reply.github.com>:

>> @@ -3,6 +3,6 @@
>>
>>  $("#question_list").html("<%= escape_javascript(
>>    render :partial => 'list', :locals => {:entries => @questions,
>> -                     :checkbox_options => params[:use_checkboxes]  
>> ? {} : nil}) %>")
>> +                     :checkbox_options =>  
>> @question_form_action.nil? ? {} : nil}) %>")
>
> @question_form_action is only defined in this one place -- are you  
> expecting it to be set somewhere?  If not, why is it here?
>

I'll check again

> Are searches still happening through JS?  If not, shouldn't we ditch  
> this file and the "format.js" in QuestionsController::search?
>

We do JS searches in the Projects tab I think and maybe somewhere else.

> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lml/quadbase/pull/58/files#r497091
>
>
Why are you setting the color twice? Once here, and then immediately overriding it 2 lines later.
I forgot to uncomment this line before submitting the pull request.
my jslint complained about having no return value here. crockford knows!
如果是buffer，那么先toString后再返回，而不是返回字节码。
So for instance if we only build the ica token, list ica there.  If we build tpm and soft, list those.
you should return ``1`` instead of ``-1`` IMO. I don't think that negative status code are used in Unix-style command lines
"For real-time searches" -> "Only applies to real-time searches"?
You might be able to upload the app the same way that splunkweb does with tar.gz files.
Let's just call this `add_element`
In function calls we do not have spaces around `=`.
In fact. You could move this form to external file and include it here. And in that external file you could use sekizai to add JavaScript files. So anywhere somebody would include that files, libraries would automatically be added to the output.
No need for this then.
What are those new lines?
why isn't this marked as being windows platform?
Is there any special reason for excluding non-ASCII characters and =/~?
Should examples be cleaned up on `brew rm`? If so, should be `(prefix+'etc/logrotate/examples')`.
That link should be "/password/change/"?
It looks like you are removing just a single value. Rather than iterating through all invitees, you can use something like the following:
```python
try {
  invitee = house.invitees.all().get(email=uninvite_email)
  invitee.delete()
} except (InviteProfile.DoesNotExist e) {
  # not a member, carry on
  pass
}
```
I think this one is missing `action='store_true`.
Check if the fileinfo extensions is loaded. This will not always be installed on the webserver
Can we use the same layout as the other buttons?
```c++
Creature *creature -> Creature* creature
```
Correctness, but it's something that we're fucking up all over the place, so I'll merge this and fix it everywhere later.
I think ```--hierarchical_fields``` is a little confusing. I suggest renaming it to something like ```--sc_separated``` (like we have in convert_biom.py), or adding an optional option to specify the character(s) to split on, with semicolon being the default.
Sure. Will do. 

Just curious, does this statement throw any error ```ActiveRecord::Base.connection.schema_search_path = "unknown_schema"``` when run from rails console?
Align with `_runtimes` above
Well, it shouldn't, that's why it throws here :) . About what is possible and what not, I'm just careful with asynchronous code.
Indentation is two spaces.
svn checkout "http://modpagespeed.googlecode.com/svn/branches/latest-beta/src/net/instaweb/automatic" "/where/you/built/mod_pagespeed/src/net/instaweb/automatic"
It should be from multiplying/dividing together a bunch of constants. The scale height is the height where a quantity changes by a factor of e^-1. 

The equation should be [this one]( http://upload.wikimedia.org/wikipedia/en/math/5/b/5/5b5cdd7bddb7a752110211845dfe3cf9.png).

So the scale height is just 1 over all the variables in the exponent bit except h. Scale height = R*T0/((g=G*Mass body/r^2)*M).
Could you please try to rewrite this hook without the runtime hook (rthook)?

zmq/__init__.py  depends on __file__ attribute. But this attribute should work for frozen app as usual.

Could you please try the following?
- drop  runtime hook pyi_rth_zmq.py
- for 'name'  do:      name = os.path.join('zmq', os.path.join.basename(bundled[0]))
- with this name pyinstaller should create file like  MEIPASS/zmq/libzmq.dll
- and with this file  the module zmq/__init__.py should be able to just find it without any rthook
Right now I don't think we have a reason to pass anything to super that's not an array. All non-array keyword arguments are handled by the subclasses.
я хотел как можно меньше менять чтобы быстрее выкатить
I'd be tempted not to have the separate classes for each of these commands, just a container class with constants:

```java
public class ReadEventsCommands {
  private static final ReadEventsCommand<Failure> READ_FAILURES= new ReadEventsCommand<Failure>("failure") {
    public List<Failure> getEventsFromEventCollector(EventCollector eventCollector) {
      return eventCollector.getFailures();
    }
  } 

  // ...
```
it seems we do this relative path thing to app a lot, so we should think about ways to dry this up
+1 on adding the possible PERMs to this documentation.  Wouldn't be too hard to support a comma separated list.
That might be worth doing in the config/process.py file, but it's a bit too obfuscated for the tutorial.  I'd feel obliged to write a comment explaining that this is equivalent to the lines that we would be replacing.  

Furthermore, even I knew how to do a list comprehension line that would be one line for each of ix and iy
```
ix = [ k / ntiles for k in range(ntiles**2) ]
iy = [ k % ntiles for k in range(ntiles**2) ]
```
which is easier to follow than the meshgrid version and possibly even more efficient, but I rejected it because even that was too obfuscated.  The explicit appends seemed clearest, and thus the most appropriate here.
Good to see that it has been adressed in https://github.com/Graylog2/graylog2-server/commit/6218ec9a
@pmn4 Will you yank this out of Eastwood.
"TICACTOE" is misspelled; it should be "TICTACTOE".
Added check . Will push to fork ASAP .
Test method something like this:

```
public void testLaunchCommand() {
    Cli<?> cli = getCli(); // TODO
    BrooklynCommand command = cli.parse("launch", "--app", "my.App");
    assertTrue(command instanceof LaunchCommand);
    String details = command.toString();
    assertTrue(details.contains("application=my.App");
}
```
I also like the expression of `(a b).c`. Have you run into trouble with more complex statements? I'm having trouble coming up with a good example here that's not overly contrived, so maybe it's just not an issue, but I feel like it could be.
Sorry, I may haven't understood the problem.
We should replace declaration of `OS.class_NSTableView` to `objc.Class`?
@pan-os άφηνε και κενά γύρω από το / όπως εδώ στο s / 2
sinatra に合わせて public/js とか public/css においたんだけど、ダメ？
(assets/stylesheets とかに置くとなると Sprockets の Environment 弄ると思うけど)
Do we really need it, as well as SSL enabled by default?
I thought in English but I wrote it in Spanish. It's changed this now. Let me a couple of minutes to find out the problem with raw.
Should you do the same for the subdir_matcher section? I already look up the corresponding article so you could check its published flag.
We do. It's just not in the documentation. I'll add a Jira on it.
It might be clearer to write `self.service.splunk_version < (5,)`?
the query would then query for nt:file i think
your personal zone hub looks correct
What is socket used for?
My previous comment didn't come through correctly because of markdown. The addresses collection passed as the first argument to Iterables.filter() is a Map&lt;Address.Type, Address&gt; and the Predicate IsPrivateIPAddress seems to expect a String.  Thus, the filter doesn't work.
:metal: Love getting rid of the duplication
I tried .clone(), but since this is its own class, I'm having some trouble doing that. Any ideas?
Let's add the possible values in the docs: `nocache`, `private`, `private_no_expire`, or `public`. Defaults to `nocache`.
fyi - `check_cs` doesn't pick it up.  Time for some real codesniffer :)
А чем лучше цикл, когда есть одна хорошая функция?
А если текстовым редактором посмотреть? Может там пробел и табуляция?
The ordering is:

- homepage
- url
- md5
- version (optional)
This could all be moved out into a (generated) CSV file.
Or you can define the method inside a `no_tasks` block.
Hi Johannes,

On Sun, Nov 25, 2012 at 10:04 PM, Johannes Schönberger <
notifications@github.com> wrote:

> Yes, that was my intention. But we could also add another wrapper function
> around peak_local_max called corner_peaks which applies the
> center-of-mass approach. Because corner detection makes IMO no sense if
> multiple corners are returned in the same "neighborhood".
>

I see.  Absolutely.  I think that for some applications, you want to use
the function peak_local_max as it is now, so it would be good to keep it
this simple.  To be relevant to other applications (such as corner
detection), I am in favour of adding a wrapper function as you suggest. :)

 PS: How do you markup a function name so that 'peak_local_max' displays
> like in your post? Thanks.
>
> Could you rephrase this sentence, please? I'm not sure what you would like
> to express here.
>

Just a question about style, trying and getting more familiar with GitHub.
 I was trying to type peak_local_max instead of plain peak_local_max, as a
function name. I didn't find the answer on the GitHub Flavored
Markdown<http://github.github.com/github-flavored-markdown/>
 page.
lol sorry ^^