[DomCrawler] Added test for supported encodings by mbstring
[Process][Tests] Prove process fail
[Process][Tests] Prove process fail (Add more test case)
[Process] Fixed bug introduced by 7bafc69f38a3512eb15aad506959a4e7be162e52.
merged branch lyrixx/process (PR #5592)

Commits
-------

27b2df9 [Process] Fixed bug introduced by 7bafc69f38a3512eb15aad506959a4e7be162e52.
7a955c0 [Process][Tests] Prove process fail (Add more test case)
598dcf3 [Process][Tests] Prove process fail

Discussion
----------

[Process][Tests] Prove process fail with chained commands

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: no
Fixes the following tickets: -
Todo: Fix that
License of the code: MIT

This PR is against 2.1 branch. Previous PR was #5575

This PR try to hiligh a regression in Process component.

``` php
$process = new Process("echo -n 1 && echo -n 1");
// or $process = new Process("echo -n 1 ; echo -n 1");
$process->run();
var_dump('11' == $process->getOutput()); // false,
var_dump($process->getOutput()); // '1',
```

This test failed because of PR #5543 ; see https://github.com/symfony/symfony/commit/7bafc69f38a3512eb15aad506959a4e7be162e52#L0R233

---------------------------------------------------------------------------

by romainneutron at 2012-09-25T13:05:45Z

You've to revert the change that causes the fail (ie: remove https://github.com/symfony/symfony/blob/2.1/src/Symfony/Component/Process/Process.php#L233)

---------------------------------------------------------------------------

by romainneutron at 2012-09-25T13:06:56Z

BTW, removing this line re-open #5030

---------------------------------------------------------------------------

by stof at 2012-09-25T13:11:15Z

@lyrixx please add a commit reverting the addition of ``exec`` in the case of sigchild not being used (only this addition, not the full commit you linked) as it should fix your test.

---------------------------------------------------------------------------

by stof at 2012-09-25T13:12:21Z

@fabpot btw, this regression is quite important. As I said in the previous PR, it impacts composer in a bunch of places.

---------------------------------------------------------------------------

by romainneutron at 2012-09-25T13:30:07Z

You reverted too much things, you just had to remove line 233

---------------------------------------------------------------------------

by stof at 2012-09-25T13:42:49Z

@lyrixx I explicitly asked you to revert only the ``exec`` addition for the case without sigchild.

---------------------------------------------------------------------------

by lyrixx at 2012-09-25T13:55:57Z

@stof Sorry, i fixed that.

---------------------------------------------------------------------------

by romainneutron at 2012-09-25T13:56:26Z

@lyrixx just remove the two last commit, edit Process.php and remove line 233

---------------------------------------------------------------------------

by lyrixx at 2012-09-25T13:59:59Z

@romainneutron I think it's ok now.

---------------------------------------------------------------------------

by romainneutron at 2012-09-25T14:11:28Z

yep it's good :)
refactor src/Symfony/Component/Translation/Loader/MoFileLoader.php
merged branch h4ck3rm1k3/RefactorExtract (PR #5623)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #5623).

Commits
-------

4a17053 refactor src/Symfony/Component/Translation/Loader/MoFileLoader.php

Discussion
----------

Refactor extract

proposed patch for what looked falsly as usage of undefined variables (#5620)

---------------------------------------------------------------------------

by stof at 2012-09-27T18:05:22Z

could you squash your commits ?

---------------------------------------------------------------------------

by pborreli at 2012-09-27T18:12:56Z

check http://symfony.com/doc/current/contributing/code/patches.html#step-3-submit-your-patch

---------------------------------------------------------------------------

by h4ck3rm1k3 at 2012-09-27T18:18:53Z

Wow, that is nice, thanks for taking the time to teach me these tricks.
Fix duplicated code and a field name
merged branch Nanocom/fix_console_tests (PR #5602)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #5602).

Commits
-------

a7d8a74 [Console] Fix duplicated code and a field name

Discussion
----------

[Console] Fix duplicated code and a field name

* Renamed a field name in CommandTesterTest
* Deleted duplicated code in testRenderException

---------------------------------------------------------------------------

by fabpot at 2012-09-27T12:16:40Z

Can you submit this PR on the 2.1 branch as this is where it should be fixed? Thanks.
merged branch hason/crawler_mb (PR #5590)

This PR was merged into the 2.1 branch.

Commits
-------

d7623ae [DomCrawler] Added test for supported encodings by mbstring

Discussion
----------

[2.1][DomCrawler] Added test for supported encodings by mbstring

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT

---------------------------------------------------------------------------

by fabpot at 2012-09-25T09:35:18Z

As this is a bug fix, it should be done on the 2.0 branch. Thanks.

---------------------------------------------------------------------------

by stof at 2012-09-25T09:41:59Z

@fabpot 2.0 does not contain the code trying to convert the encoding.
Added Base64 encoding, decoding to MongoDBProfilerStorage
merged branch krmcbride/mongo-profiler (PR #5556)

This PR was merged into the 2.1 branch.

Commits
-------

c120c4d Added Base64 encoding, decoding to MongoDBProfilerStorage

Discussion
----------

[HttpKernel] Added UTF8 encoding, decoding to MongoDBProfilerStorage

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes

It didn't take long for us to hit a non-utf8 error using the new `MongoDBProfilerStorage`.  I'm pretty sure the culprit was the Switfmailer DataCollector serializing a message with a PDF attachment.

I thought this would be a good failsafe, although one could ask whether mail message attachments should be serialized at all...

---------------------------------------------------------------------------

by krmcbride at 2012-09-28T17:28:02Z

Switched encoding/decoding to base64
[HttpFoundation] fixed the path to the SensioHandlerInterface class in composer.json