labofsahil/github-event-dataset-2012 huggingface dataset:
Also I think we need to pick a better name.  The `operate_on` name suggests that the density operator is operating on the argument of the method, which is not what it does.  Maybe `apply_op` would be better?
Ah, no.  It does indent, but it doesn't render as Python unless I put `::` after `form`.  I've fixed it.
No need for comment.
by yii standards variables prefixed with an underscore are private.
But why do you want to have <?php ... ?> on every line?
It's unclear and not good code.


On 27-09-2012 16:21, Nobuo Kihara wrote:
>
> In docs/guide/topics.gii.txt:
>
> > @@ -127,9 +127,9 @@ It is time for us to do the real customization work. Open the file `protected/gi
> >  public function attributeLabels()
> >  {
> >  	return array(
> > -<?php foreach($labels as $name=>$label): ?>
> > -			<?php echo "'$name' => Yii::t('application', '$label'),\n"; ?>
> > -<?php endforeach; ?>
> > +		foreach($labels as $name=>$label):
> > +				echo "'$name' => Yii::t('application', '$label'),\n";
> > +	endforeach;
>
> They are not typos and should not be changed.
>
> ---
> Reply to this email directly or view it on GitHub 
> <https://github.com/yiisoft/yii/pull/1488/files#r1707283>.
>
We also don't use `affected_loans` anymore. This can go.
At this point of the documentation,  ```?_switch_user=fabien``` can be confusing. I think you could replace with a classic ```/admin```
After a rebase, this file is not needed anymore
No, it's potentially dangerous... I've found myself replacing the same calls in tcp/udp without realizing that tcp/udp handles ain't streams.
This is just style preference I guess. When using the uv_interface_addresses function, I would first check the uv_err_t return code before I went to checking the count. If I got an ENOMEM error, I would handle that very differently than an error indicating there were no interfaces. From my reading of the code, having 0 interfaces will result in ENOMEM - maybe I'm misunderstanding that though.

Not a big deal either way - thanks for the great project and taking the time to review.
Please revert this spacing change to the copyright info (want to leave them all exactly the same in case we one day need to do a global search and replace).
CS: no space between method name and brace
``20`` is not an example, it means the actual number 20.
in geoNear what?
- ingestion.
- "this command" should be `moveChunk`
this isn't the right command format 

    db.runCommand( { logRotate: 1 } )
Two variables given the same value can be defined on one line:
`$avatar_drivers = $avatar_data = null;`
javascript lang should be ```{LA_....}```?
The idea is that we create a _second_ connection to the primary dc to download the update. We don't try and use the same socket connection.
De ce două slash-uri? Nu sunt backslash.
Roland added the filtering to the Akka build recently.
they could be CSS since YUI uses yui modules meta for css as well.
Could we add a mocking constructor to the test framework to do this?
или это когда с свежей нодой ковырялся... верну короче
Instead, use Util.getBasicAuthHeaders here
Can remove bmi_rounded > 60.00 || part here. Although it is unlikely, people with BMI over 60 do exist.
@piyush92 please add your patient ID from the store here
I think this be a call to ```iris.io.run_callback()``` instead?
This warning should really be an error. And it'd be even better if the check used `os.path.isdir()`.
Is it still a work in progress?
You could do things like this

`sA1, sA2, sA3 = ['sA%d'%i if i+1 < nd_in else '0' for i in range(3)]`

The other ones are admittedly harder. Might be worth a try.
Это не по заданию, просто ддумаю, так красивее

next  unless one_record.send(model == Issue ? :description : :notes) =~ header_regexp
in_date, text = DateTime.strptime($1, date_format), $2.strip
one_record.send(model == Issue ? :description= : :notes, text)
Does `voltdb replica ...` work without requiring `create`?  The test case was removed at: https://github.com/VoltDB/voltdb/pull/296/files#L8L148 ?
Модули сохраняются в переменные `UPPERCASE`, классы в `CamelCase`, функции в `camelCase` и т.д.
no, it checks the normalized_ boolean, not the total mass. There are some associated tests in the compmap class.
Done in ae6ffd2e7ef69180560eaeae9a00f76cd3721691.
Should be $_uiDefClass or $_fieldSetClass depending on how we name it. :)
The point is to have an overridable hook, not to silently fail if ajax is not here.
Almost perfect ;)
Just because it's not the source, doesn't mean it shouldn't follow the style guide LN12-21
Have you already got the code structure with this properly placed in mind?
If you get a change I'd curious how you'd weigh in on this? I'll try to better explain my thinking in case I missed the mark perviously...

My grand scheme is to be able to consume oauth1 and 2 apis outside of any accounts package... to the extent that I even want to get the popup code out of accounts packages. An example scenario would be an app with srp authentication that allows the user to auth twitter or facebook for the purpose making signed requests to the respective API .

Otherwise there's no reason for this to be a separate package. Perhaps it's a premature optimization, guess it depends if you agree with the above.

-Mike
Yes it is. but i want to leave this in for future testings.
As far as I know, it's only an issue with IE 8/9. MS added WebSocket support in IE10, so we don't support anything less out of the box. Though, I don't know how `console` works in IE10, and using flash fallback etc, as we've seen working with our WebSocket already, using IE 8/9 may actually work as well.

I'll add a polyfill for `window.console`, which makes it an empty function if it doesn't already exist.
Does yaws look for the Cellar locations specifically, or does it look for them in the broader /usr/local prefix? (e.g. `/usr/local/lib/yaws/examples/ebin` vs `/usr/local/Cellar/yaws/1.94/lib/yaws/examples/ebin`
@daniel-uzunu: use a bulleted list to describe these parameters since a big wall of text isn't really easy on the eyes
Ja ist richtig. Was soll mit files auf "root ebene" passieren?
Aaahhh.
What you're saying is VERY SCARY! I think you can get exactly what you want, though you might need two counters instead of one.
  int nextSingleton = 100;
  int nextInstance = 200;
  assertEquals(set(100, 200), ...);
  assertEquals(set(100, 201), ...);
Yeah I have two profiles, 'Square' and 'AOSP', that I switch between. You just have to remember to set the right one if you don't already have a project set up. Occasionally there are quirks but it works well enough.
For reference comments is just something we're adhering to with the code52 blog, rather than a specific jekyll value.

That being said, I don't see why it isn't, as I can't see any use case when you'd not want it - simply don't template it if you're never going to use. We can take this up as a debate if somebody objects down the track - for now I'm happy for it to be there.
The reason is a different scenario against the old impl. Here all factory methods are used except for the old #classes() and #methods().

For instance, in our scenario the user provides a pool via e.g. #classesAndMethods(poolClasses, poolMethods) etc.

Thus the methods are 'fetched' to that poolMethods from the particular classes in some order and time. So the methods may run in parallel across parallel classes if used #classesAndMethods(poolClasses, poolMethods).

So, we have to wait until all the methods of certain class finished and the runner then can do the rest like AfterClass.
This is much better memory management than waiting until all classes finished and then AfterClass-es are fired at last.

In principle, this scenario cannot call pool.shutdown() and awaitTermination() instead of futures.
The reason is that once the pool is shut down, it cannot take a new task/method from other parallel class. This is especially imporant for parallel classes.

Did i answer your question?
I think being conservative is probably the way to go. It's sad we have to do this much code, but at least it's localized.
Is this just random for testing?
Should be able to remove this check in favor of IDynamicMetaObjectProvider. This also could have bad unintended consquences.
_checkRequirements runs before _doLookups. I've mirrored the pattern this system had before—I'm not sure why it originally fetched the components twice.

I guess originally it didn't, as capabilities once leaned on the now-removed _loadInvolvedComponents, which fetched the required components from the page definition. That ran before _checkRequirements.

There's really no reason for _checkRequirements to exist at all—this same functionality could be handled in _doLookups. I'll refit it that way.
It's confusing to set the false case here and the true case in the _getUrlList() function. It should be removed from here and both cases set in 1 place (in _getUrlList() ).
Also, can remove the `return` here too
This should be `expect($projectFileItems.find("a.jstree-clicked").eq(0).siblings("input").eq(0).val()).toBe(fileName)`.
Just curious, why do we need an extra pair of single quotes for each key?
Typo: "tests"
According to the spec you're not allowed to mix percentages and integers, and Chrome at least seems to ignore it if you do... so it doesn't seem like the normalizing _needs_ to support it.  (And in fact we'll still catch it as invalid later since tinycolor isn't happy with mixing either).
I think we should change the var to match the new module name... I think we've always kept them in sync for all our other modules
Indent is incorrect. Did you run JSLint? I think it would have caught that.
would you change the == matching here to ===
and a better check for future extensions would be:
`["forEach", "map", "filter", "every", "some"].indexOf(b.p.value) !== -1`
I assume you're trying to force an exception to be raised here. The more idiomatic way to do so would be `self.assertRaises`.
Please use full / proper sentence for comments.

I don't see how the windows path is converted to segments.
Can you please check again this comment?

I don't think that this comment is requried, but the above comment would benefit from an expansion:

Instead of:

# Make sure that we have a temporary folder on Windows.

We can have

# Make sure that we have a temporary folder on Windows.
# When the temporary folder is missing, we try to create it.
You could just add a comment next to the ``if`` saying that a logged-in user wants to edit a staff user and that's not allowed.
i guess it's fine, but any reason why you're changing these? just to be consistent with the new function names?
Given that this is only used here, I'm not sure having an extra indirection through the `CachedResponse` class is needed. Why not just perform the code check directly here and act accordingly? Something like:

```scala
result match {
  case Full(response) if response.code >= 500 && response.code < 600 =>
    // The request failed...
    liftSession.with...
  case other =>
    future.satisfy(other)
}
```
This double data_version jump is actually normal when updating the version column, so nothing to worry about here.
This worries me: 

> Each time you call createObjectURL(), a new object URL is created, even if you've already created one for the same file. Each of these must be
> released by calling window.URL.revokeObjectURL() when you no longer need them. Browsers will release these automatically when the document is > unloaded; however, for optimal performance and memory usage, if there are safe times when you can explicitly unload them, you should do so.
Needs to be a tad wider.
I've been trying to keep the newlines consistent in the function signature with the newlines in the array above it so that you can easily see which objects belong to which source files. Mind cutting this line the way you did the one on top of it?
We use 'callback' vs. 'CB' everywhere else in our tree, do it here too.
Does the array ever change lengths? If not can we store length?
Just remove the line then :)
cstddef is already included.
why not use StringBuilder?
pitäisi olla long?
I was not sure of the name. We already have very generic resources so at the time I thought that what is special about LDP is that all resources that are created are local ( hence the relative URIs everywhere... ). What should I call them? Perhaps Resource is enough... Seems like a good idea.
no not use double negation. simply
```c++
if (sit == end)
```
Personally I'd just have it as an attribute on the instance, with a default value if none is specified, and can be set using an options hash in the initializer. Like we do with `InitializeWithOptions` elsewhere.
AngularJS算是框架，移动到框架那里吧
why this? chunks are always `Uint64` => `chunk_bits` is always going to be 64.
This works the same as it did in v1.  The agent submits all of the specified units (read: packages) to yum so they can be installed in a single transaction.  The thinking being that since the user specified them in the same request, they don't want a partial install.  Though, we probably should support an option for this so the user can specify the expected behavior.
What if we moved this to auth_support.rb? and did it in a test/support directory.  Prevent cluttering of the test/ directory and use of 'helper' might get confusing given Rails helpers.
Is the change to the converge-ui hash intentional?
I believe this is a leftover from the previous code, or at least not usual to put require at the end of flie
We are constrained by the specification of the Node Stream interface here. There are four events that a stream is allowed to emit: `data` with a data payload, `error` with an error payload, and no-payload `end` and `close`.
Alphabetize the Disposes....  Unacceptable.
I have to admit that I cloned this code without given it even a first
thought (not to mention the second one :) ). Not to mention an obvious bug
that child copy must be added to the union node.

Removed the whole method.

On Wed, Sep 26, 2012 at 3:37 AM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/plannodes/UnionPlanNode.java:
>
> > -        // This node doesn't actually exist
> > -        assert(false);
> > +        // Should be at least two selects in a join
> > +        assert(m_children.size() > 1);
> > +        for (AbstractPlanNode child : m_children)
> > +        {
> > +            child.resolveColumnIndexes();
> > +        }
> > +    }
> > +
> > +    public ParsedUnionStmt.UnionType getUnionType() {
> > +        return m_unionType;
> > +    }
> > +
> > +    /**
> > +     * Create a DistinctPlanNode that clones the configuration information but
>
> I don't see how this could be correct or useful. The analogous code on
> DistinctNode is only (or not actually) called specifically on a
> DistinctNode by a method of a PushdownReceiveDominators class which is
> never instantiated. It takes the distinct node and either copies or moves
> it to below the receive node regardless of any nodes in between -- which
> are possibly very significant -- there could be an Agg in there!
> It assumes that an exact clone of the distinct can be patched in below the
> send -- something I generally doubt.
> What does any of this have to do with UNION? Are you planning on enabling
> this code and expanding it so that a UNION is going to be patched in below
> a send node? How is the send's requirement for one child node going to be
> reconciled with the UNION's requirement for multiple child nodes? Your code
> gives a nod to this by aggressively cloning child instances -- though as
> far as I can tell the clones are unattached to anything and instantly
> unreachable and ready for garbage collection. But even if you tried to
> retain them as children of the copied UNION (?), where/how does the SEND
> node's original child fit in to make a plan that retains its correctness?
> I'm not seeing a win, here, just lots of open questions and issues.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1692644>.
>
>
Use new style classes (inherit from `object`).
@astrofrog @demitri : I've updated this by putting imports the *first* time something appears in the docs, but not all the imports at the top of every single example. It seems excessive/information-overloading to include all imports all along the way.  But if you disagree I can update it to include all of them.
Since there are no side-effects to accessing the different formats with attributes (i.e. the content of ``Time`` is not changed), I'm fine with not having getters/setters. After all, ``There should be one-- and preferably only one --obvious way to do it``...
Especially as it could be up to 16 at a time.
Couln't this be a single if with an ``&&``?
Git is so intelligent than there isn't any conflict that he don't solve automatically :-)
YESS! :))
So, you want the same information for each event, right? Like group name, title text, etc. In general, to take advantage of the Event's polymorphism, you need to ask the for that directly. Eg `title_text = notification.title_text`. Now, I'm not sure of the relationship between notification and event, but perhaps notification passes that request on to event and event is polymorphic and knows that if it's a comment liked event, that it should return `comment_vote.discussion_title` when asked for title text.  

The only gotcha is, you don't want an event to return urls. Typically that's something the model layer doesn't know about. The same goes for other presentation logic, such as html formatting of something. You need to use decorators/presenters for that. Ideally you want to avoid having polymorphic event decorators, since that'd be a parallel inheritance hierarchy, so perhaps the event can return a piece of data that can be presented without needing to know exactly what the at a is. Ie, instead of calling notification.href, you call notification.subject_model or something, which returns an active record model which you decorator can find a path to based on it's type.  

--  
Craig Ambrose


On Wednesday, 8 August 2012 at 11:31 AM, jonlemmon wrote:

> In app/views/notifications/_notification.html.haml:
> > + - action_text = "added you to the group" > + - title_text = membership.group_full_name > + - group_name = membership.group_full_name > + - href = group_path(membership.group) > + > + - elsif notification.event_kind == "comment_liked" > + - comment_vote = notification.comment_vote > + - person = comment_vote.user_name > + - action_text = "liked your comment in the discussion" > + - title_text = comment_vote.discussion_title > + - group_name = comment_vote.group_full_name > + - href = discussion_path(comment_vote.discussion) > + > + - date = time_ago_in_words(notification.created_at) > + - class_name = notification.viewed_at.nil? ? " unread" : "" > +  
> The event is polymorphic. How would you suggest I take advantage of that to move all this code out of the template?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/enspiral/loomio/pull/246/files#r1327763).  
>  
>  
>
It was on the client side that it needed special handling.  Have handled it in a way I am OK with.

Didn't know about the interning of compiled regexes, though... that's neat and possibly makes it worth ignoring the entire compiled regex thing in this case.
i changed this now to have a factorymethod createChild that does the new. this way if you have your own implementation, you can overwrite the driver to create your object. i think this is better than naming the classes in a configuration file (redundantly for every property and every collection). if one needs specific classes for specific properties, one can now implement an arbitrary complex createChild method.
Was looking into that when I had to go home. : ) That would indeed be better.
I disagree, if you want the content of the file, you can do `%load <drag>`, run it : `%run <drag>`, see it `%pycat <drag>`
It is much more powerfull to get the path.
This block belongs in the docstring above, where it was
Actually, I see now that it was used in `assert_match`.  Regardless, it'd be a lot easier just to chdir into the temporary directory.

```python
save = os.getcwdu()
with TemporaryDirectory() as td:
    os.chdir(td)

    # Create empty files.
    for fname in filenames:
        open(fname, 'w').close()

    assert ...

os.chdir(save)
```
Yes, but even on a giant docstring it's only going to be a few microseconds.  So it's probably not worth the optimization.  The "fastest" approach would probably be something like:
```py
line = re.split(r'[\r\n]', doc, 1)[0]
```
Nope, just a typo and already fixed.
It's imported from core.magic and reused from there...
oauth's and bouncycastle's base64 alphabets aren't url safe either.
I agree that adding a huge dep just for base64 is not ideal. Should I simply copy commons-codec Base64 class (and the required hierarchy) into oauth? later we can remove it when we migrate to guava 14 (I can be in charge of that).
very sensible :)
Set = "" here
おいやります！
"that the a task.." -> "that a task.."
Better: ``self.fields['publisher'].queryset = Publisher.objects.for_user(request.user)``
If we are stale, return true?
So, I do two spaces before a new section. Makes it easier to discern new sections when skimming.

Regardless, the rest of the manual uses two spaces before a new section, so it's better to keep with that.
If we don't have a model maker for helpfulvote class, we should probably create one. It'd work just like the revision model maker here.
rats, I forgot.  you've already suggested this.  I'll try to keep this in mind from now on. fixed
Sorry, that should be `xrange(10)` but the iterator isn't about whether we use `range` or `xrange`. Python will recognize that an iterator is being returned with the function having to contain a `yield` statement.
I agree with @schmittjoh that `SecureRandom` would be a more fitting name. `Prng` does not imply that the random values generated by it are cryptographically secure, which is a very important distinction to typical PRNGs.
this is mysterious to the reader: comment on this behavior. also you probably did mean:  `buffer.readableBytes`?
delete all these dead comments
Yup, thanks! 3fd39c8
Minor style nit: This seems unnecessarily verbose.  How about the following three liner:

```C++
return ROI(spec.x, spec.x + spec.width,
           spec.y, spec.y + spec.height,
           spec.z, spec.z + spec.depth);
```

ditto for the other functions below.
The idea is that an aspect ratio of 1.05 should not force two samples.  But the exact value is purely intuitive/visual from my observation.  I looked at those ellipse pictures with a few different values here, and this one seemed to strike a good balance of adding an extra sample only when the ellipse becomes eccentric enough to really need it.
Well, there were some setController's in the constructor and some in the init method, so I moved them all to the init for consistency. I'll move them to the constructor, now.
spacing and check the error message
This should also take into consideration the other view-modes. So also render the list_image here.
Actually, I'm not sure we should be monkeying around with the editor's context menus at all. Here's an alternative: in the top right corner, create a menu-button or small toolbar with the splitting and collapsing actions. You can use ``setCornerWidget`` for this.

http://doc.qt.digia.com/4.7-snapshot/qtabwidget.html#setCornerWidget

Gmail does something similar to this:

http://www.skipser.com/i/2/images/general/gmail_previewpane3.jpg

We'll need to dig up some icons, but I think we can manage that. What do you think?
i dont think this was necessary to duplicate the modals for editing user preferences, we could have just used the contenteditable=true attribute, and then used the Save button to extract the text.
As it was just testing DescriptionProviders which we do not need anymore...
You can actually require less than this (a stream of things you can get to from String), but this is better than it was before.
I've tried doing it with the getFilename approach, but it always seems to crash Firefox (before I can get to the Error Console to view the logs that I'm outputting!). It seems that it basically gets into an infinite loop with renaming the file and then renaming it again etc - but I can't see why. I've changed the if in this code to:

    var newname = Zotero.ZotFile.getFilename(parentItem, file.leafName);
                                Application.console.log("Current name: " + file.leafName + "New name: " + newname);
                                if (file.leafName == newname) {
                                    Application.console.log("Skipping as filename already what it should be");
                                    continue;
                                }

and I've checked that both getFilename and file.leafName return the name *with* the extension, and they do, so they should be comparable.

Do you have any ideas what may be going wrong here? This really should work, as far as I can see, yet it doesn't. Alternatively, is there a way to get access to the Error Console once Firefox has crashed?

If not, what was your alternative idea?
we do when the phone is locked. the statusbar is hidden otherwise.
embrace this block like this,
``` 
if () {
} else if () {
}
```
Since you are inside a SIMManager no need to add PIN/Pin in your methods names. Let's call them showScreen, hideScreen (that will also fix the naming issue ;))
`previousSettings`
Nit: strange alignment
This is included in another pull req right?
Do you really want this color, or you accidentally add it for tests?

I think with the color it will block the background ....
If you really think it's too silly I can change it. Figured our codebase was open so some fun is in order on occasion, especially since it never makes it to the interface. I'm cool either way.
Would there be any problems with defaulting to 0 if no PR is found for the branch and not commenting if the PR number is 0?
Does this throw an exception if the file doesn't exist?
I see. Definitely, we should only have one version through the solution.
That last idea works for me.
grundsätzlich nicht falsch, aber ich finde `em` und `%`sollten wir nicht wirklich benutzen wenn wir alles andere auch pixel basiert machen. Muss jetzt nich ausgebessert werden. Aber ich werfs trotzdem mal so rein.
hier bitte mit der $() funktion von Ember.View arbeiten

        @$('#clock-seconds .first')

dann wird nur innerhalb des views gesucht
I guess it's because of Devise, but still asking:

You specify json in the `url` and as `dataType` are both needed?
`:Tab /=`
I'd prefer to use Vector here, and then use updated to quickly (log-base 32 complexity) create a new table.

So, something like: case class CMSCountsTable(counts : Vector[Vector[Long]])

then make a new CMSCountsTable after each addition.  You could also have a val of total count and update that after each step.
TypedTsv[(Int,Int,Double)](input).toMatrix should work.
This is not a useful explanation.
please fix the whitespace here
fPhysical? that's not a class member...
This probably isn't needed. You can do the same thing with either of the following:

```jul
cbind(df, dfs...)
# or:
hcat(df, dfs...)
```
Also, whenever we define a method for `hcat`, we should define one for `cbind` and vice versa.
Don't you mean `HTMLFormElement`? I don't think you can construct a form out of any random elments.
The default value of vcpu_thread_pattern is "thread_id=(\d+)" in code,
this block can help user know where/how to setup this parameter.
Do we need to describe this kind of parameters in document (effective scope, example, etc)

Or we suppose user would read the code when they touch some problem, then update parameters the config file.
OK, I've rebased this branch on top of e3440e0edac449f3a6ed6e829be510a41b238a9a
Yup that's fine. I don't use an IDE which reads those docblock hints, so I typically don't realize those discrepancies. Feel free to fix it.
should be ``elseif`` without a space
Container injected only for those two calls?
But it will make calls like: normalize("something") impossible. Why not just create a wrapper function in that case?
I'll test myself, but my first though is that single quotes aren't valid JSON.
no, this new test was required to keep the tests passing after I made the fix.

The issue is related to requests running in parallel, specifically `complete_user_creation` and `user_creation_status`.  

When we make a proper, 100% correct fix for this class of race conditions on dev we should introduce some tests that do these things in parallel some number of times and ensure that results are always consistent.
Node's [path.basename](http://nodejs.org/api/path.html#path_path_basename_p_ext) might be useful here.
true, we don't really care, although unit tests are likely to fail if the timestamp resolution can't distinguish between two calls in rapid succession, so milliseconds are easier. (if we get full second resolution, the test will probably need an artificial 2s stall to avoid false negatives).
s/heirarchy/hierarchy
I would make `--view_batches` raise an error if either `--project` or `--cron_batch` is given, again on the principle that when the user explicitly gives conflicting input it's better to fail fast than to make assumptions about which should take priority.
Hm, we removed two entries which had GC==1 and GC==2. So the oldest should be GC==3. Why is that 4 here?
You should use Bug.is_closed() here. this will see "verified" bugs as open. I think this should work:

```python
blockers = [blocker for blocker in bug.depends_on
                  if (blocker in id_to_bug and not id_to_bug[blocker].is_closed())]
```
Backends call the router directly using the [Messaging API](http://rapidsms.readthedocs.org/en/feature-new-routing/topics/router/messaging.html), not via HTTP.
That's a fair point, and thanks for the feedback. I'll look into making an example for Kannel.
Use mochijson2.
Maybe "ensure each created or updated view is correct before merging"? Using `view` in 2 different ways is confusing.
Can you remove the unnecesary import? `use Zend\Authentication\Storage as AuthenticationStorage`
This is the wrong place to wire it. Since it has to do with dispatch logic, it should not be in the ViewManager.

I'd recommend creating a Logger service factory. Users could then call on that to attach additional writers, or to simply get the logger instance. We could then by default add a ZendMonitor log writer, and have filters attached to it that only log in certain situations. This could then be attached to specific events.
Why isn't the ZendMonitor log writer being used here?
This is an older version of the code. I fixed this in the amended commit. feildmaster addressed his concerns via #bukkitdev.
Why remove this? Do you feel your code is most optimized?
> Does that make sense?

Yes, thanks for clarifying.
This should be just `Travis`.
dunno I'll give it a try.
Drop these commented out lines?
@phoolish  I'm thinking the deprecation notice should go to STDERR instead, just so it's more noticeable to users.  (That way it would go to the cron mail or show up in front of the user if they're invoking `maid clean` directly.  People probably won't notice it as easily in the log.)

I'm pretty sure that `warn` does that...

```ruby
warn '[DEPRECATION] last_accessed has been replaced by accessed_at.'
```
So, since it does not allow to navigate the tree, is the only other solution then to allow extra keys everywhere ?

Would be sad if that were the only solution.
huh, yeah. we should throw an error during validation
We should probably clean up this environment variable on `test/test_helper.exs` than changing every test in it.
PHPDoc in this file needs updating for @return values :)
missing 2 empty lines below this
I'm not sure if we want to use the `username` (= Flickr screen name). People can change it as much as they want. It's safer to use `user_nsid`.
この辺の文、ヘルパにまとめたいですね。
It should also be noted that mixing `==` and `===` is just as annoying as mixing `'` and `"`. It's a style thing
These lines are used to initialize "arr" which is an array containing the operation "signature" - It is used in the "invoke"  call.
Nope, with an empty query it just returns an empty dictionary. Some of the tests have asserts that handle this case.
Nitpick: These should be moved to `test_special_banner_redirect` since it is the only test that needs these two patches.
Some of these variables are relics of old code. width, height, originalStyle, styleWidth, styleHeight
delete this declaration?
Add this after the Arrays import.
```java
import java.util.Comparator;
```
If we are switching this to a solid color, which removes the slight gradient that Katello is currently using upstream, then we should remove this mixin and the bottom-color variable above all together and instead just do background: $login_background-color.
newline zu viel
Can you configure your IDE to not use wildcard imports? We avoid them wherever possible. They prove difficult when there are classes in multiple packages that are similarly named, which is something we run into quite a bit.
Then do we need the extra copy in the SessionNode.Changes object? Can they just be an immutable view?
Get rid of all of the horizontal rules, please
might do away completely with this check:
- maybe user symlinked "convert" to something else, or built it by hand
- putenv should be harmless for other handlers anyway
You need to finish it :)
bcrypt is not in the stdlib
большими буквами не называют
,LOOKUP?
ended up changing it to the first of those in my local copy :)
Kunnen we dit niet mooier `groups` en `group_names` noemen? Het `cached_` deel geeft alleen aan dat het binnen deze request gecached is.
It's a conversion between X keycodes and Linux kernel keycodes. The relationship between them seems to be roughly as such - I don't know why. :)
Actually, it originally was a subclass of VideoLoader; I switched it to a mixin to make it easier to combine with other mixins (specifically, the path mixins used by a couple of suites.)
Why not just inline this?
Yes that seem to work. I will make a new commit with the change.
I assume millis since the epoch. Can you clarify?
`joinable` isn't in here
I think you can just pass `callback` in directly.
can we check that replyTo is a valid resource id if it's been provided.
If you agree that it would look better, you could just use:

`data.mediumPicture = user.mediumPicture || undefined;`
I still think this endpoint and the one for replying should be merged into one with an optional replyTo parameter. Overall, the rule of thumb is that the URL gives the unique path to the resource you're modifying. I think what you're doing isn't wrong per se, but the comment isn't technically going to live underneath the previous comment, it'll be its own top level comment. When removing the comment you're replying to, this comment will still be there. 

I think it also makes the REST API easier to use and script for.
Can you clarify 'not an acceptible input'?
not sure why this necessary, but I'd prefer to move this into the createFile function as well.
I have a feeling this test will be fragile across Scala versions. Maybe the following would be better:

```scala
class RelevanceCompletions {
  object Test {
    val stringLikeClass = "some text"
  }

  def meth1() {
    Test.str/*!*/
  }
}
```
What do you think?
Why always put the self-type? I understand that the extracted trait may need access to some member of the original class, but that's not always the case. Wouldn't it be possible to be smarter about this? (If you think this is a valid thing to do, you don't have to fix it now, but maybe file an enhancement ticket on the scala-refactoring issue tracker)
Using and example URL makes sense, but instead of introducing another fictitious site, please use Nose-ster ... e.g., www.nosester.com/nose-article
I added a comment about it and made the auth plugins actually call the parent constructor
це навіщо?
Actually, it's a good use case here. It avoids to repeat a lot of null parameters. And we have clean outputs for all providers.
Shouldn't we use `array_merge` in other providers as well ?
can't you just put raise here without the ex?
Kan deze file nu niet weg?
Okay, but in order to achieve that you need to pass `\/` as the second parameter to `rtrim()` and not to concatenate it to the trimmed string.
These *should* have the same length as the title itself.
Идея правильная, однако в реализации ошибка.
Если изначальные ДНК одинаковые и мы выполняем мутацию по одной на 100%, то результат различия не будет равен 100%. Хотя в алгоритме реализуется однозначное не соответствие заменяемого символа начальному символу.
Последовательный алгоритм - это не сумма отдельных строк и от перестановки местами результат изменяется. То есть если сейчас здесь переставить несколько строк выше, то все будет работать верно.
Только на одно хочу указать: вы должны понимать, чем отличается ваш вариант, от варианта с округлением.

А ещё, вы не проверяете передаваемое значение. Что ж это, можно передать и отрицательное, и больше 100?
Не до конца понял с какой целью создали дополнительный метод. Так или иначе [super init] вызван.
Понятно что имеется ввиду, но на всякий случай внесу две правки для корректности (согласно коду текущего проекта):
  NSString * arr[] = {@"A", @"T", @"G", @"C"};
  int index = random() % 4;
  index = [[DNA objectAtIndex: indexToMutate] isEqualTo: arr[index]] ? (index + 1) % 4 : index;
Но замечу, что такой код приводит к изменению случайного распределения - теряется равновероятность выбора. В задании закон распределения не указывался явно, говорится "в случайном порядке", но обычно, если не известно больше, подразумевают равномерность распределения.
internally
the GROUP_NAME macro, if defined, already has a backslash at the end of it (see config.h for edge code). In that case, you'll either need to omit the backslash when copying from pGroup, or omit it here before appending pApp.
Would it be helpful to write error codes to the console log?
please keep exception message consistent across drivers
Number of objects accepted by the cache.
I just copied Felix's code. He might did that for some reason.
Call me nit-picker for this but would it be possible to stay consistent with the other formatters and not pass anything (yet) to the constructor?

I/O handling is something we must improve in the near future, on a more general level.
We can't manually run a GCD queue, so we can't guarantee when the enqueued blocks are executed.
Just heuristic... Also with the 0.8
I'm curious if a published gadget is limited to being site-wide, portal-wide, or both. Depending on the answer, this bullet and possibly some of the other text regarding published gadgets may need to be updated.
I imagine int would be enough. I was reflecting the types that these values are as in libgit2. I will change the `uint`s to be `int`s, and the `ulong` to be a `long` .
Copy and paste error: this comment makes no sense for this function.
if baseline is None:
maybe just : load_bad_channels as load really suggests that something is loaded from a file on disk.
So "consistency" isn't really a statement about usefulness.

Let's go through the options:

* get back all the fields: the thing I don't like about this is that the order wasn't specified, so you have no idea what order it's in.
* get back all the fields and return a list of tuples of (key, val) pairs: I don't like this because the shape is completely different than when you specify fields.
* get back a list of ids: This is what ElasticUtils has done up until now.

I'm not sure I want to force values_list and values_dict to work the same because they're not the same. I really do want values_dict to return all the fields if you specify no fields--that's really handy.

I think given all that, I'm inclined to keep it the way I changed it. None of these are perfect answers, but I think this is the best behavior given the use cases.
How about this as found in chef_wm_depsolver.erl:


    -spec remove_dups([cookbook_with_version()]) -> [cookbook_with_version()].
    remove_dups(L) ->
        WithIdx = lists:zip(L, lists:seq(1, length(L))),
        [ Elt || {Elt, _} <- lists:ukeysort(2, lists:ukeysort(1, WithIdx)) ].
Because it's not about that one spec, adding sequential only makes that one spec run sequentially, but the issue is that you can't have two specs running an application at the same time due to Play's global state, and there is another spec in this project that runs an application, so unless we combine all the specs that run an application into one massive spec (and in future, as we increase Plays test coverage, there will be many, many more specs that run an application), sequential is of no use here.
This should end with a comma
Why not use the `#.` syntax (or `1.` syntax) here?
Definitely :)

    :doc:`/reference/forms/types/form.rst1`

And if you want to control the label of the link:

    :doc:`Form field type</reference/forms/types/form.rst1>`
最短边？
最长边？
已加
please use `===` and on the line above
I was hoping to use ```*print-all-readably*``` here. Otherwise we change print behavior for the whole system, i would rather do it just for functions that want it.

We should probably do that method-get hack, the hack i used of copying the old imp is even worse.

I can do this if you want.
Фикси явный копипаст хотя бы :3
Проставь тут везде const у локальных переменных, где нужно, чтобы сразу было видно, чо потом будет меняться, а чо — не будет.
И ошибки логические так легче отлавливать.
А потом добавить забудешь.
The variable points spot in memory, that could have a chunk of data (object) in it. The type of the object in that spot does not matter.
CPThreePartImage (and Nine) can't call `initByReferencingFile: size:` because it extends CPObject, not CPImage.
It is done by ternary operator on line 175.
Hi Mayank! Sorry for the delay in responding to your pull request. Thanks so much for this.

First off, I'd suggest creating a model object for your delayLine, and storing all of its internal state in it. The general idiom for objects in Flocking is to have transparent model state that is available for anyone to read and write from. So lines 1719-1723 would look roughly like this:

var that = {
    model: {
        delayLength: 0,
        readPos: 0
        ...
    }
}
I suggest a NETWORK_MESSAGE here.
should this be `service[mongodb]`?
Can you please update these to a better column length. We shouldn't have to wrap to view the docs.
Unecessary 'pass'?
If you do that, ActivationAndPassivationInterceptorMBeanTest.testActivationOnRemove fails on `assertActivationCount(1);` assert. 

If you look at the current ActivationInterceptor, it there's a remove() called, it removes from the store and updates the activation counter.

To avoid duplication of code, this was now done in via `evictionListener.onEntryActivated(key);` because it's at this point that I can safely do the cache store removal, and given the fact that the cache removal location had changed, I also changed the location in which the activation counter was updated.
Yes, we did. I fully agree, but then when I was to implement this I did not know how to fullfil contract ALL, SAME_MACHINE, SAME_RACK and SAME_SITE. Isn't this something that clients would have to do through interface we provide here?
Good point, I always assumed that it was going to be sync, either DIST or REPL. Maybe we should restrict it so?
can you add one more constructor why set encoding to UTF-8 by default?

Thanks for pull :)
I believe you mispelled it: `Dependent`.
Phrasing here is pretty important. Is the tree the left or right side?
I had to because I was getting confused myself!
because i don't know how to do setup() and teardown() methods that apply to just one out of many of the test cases in the class, and each of the test cases has a slightly different fixture set. if someone can suggest how, i'm happy to learn it. the same thing had been bothering me.
pixel values higher than 4095
Break it down. I just checked, this will not cause any issues with gettext.
Actually, this will cause the unread count to be requested on all pages except the /me page. The sakai.api.Communication.getUnreadMessagesCountOverview call should be removed and we should just use the number that's part of the me feed.
I changed this to viewer
В ```config/initializers/``` лучше бы смотрелось. Всё-таки директория для конфигов
thread? really? :-)
We don't use ``@return void``. Pleasde don't add it
Just in case you don't already know, I believe that jQuery works on XML elements too, so you aren't constrained by the standard DOM API here... For instance, this line could be rewritten as `results = $("photo", xml)`, I think.
I'd say leave it alone for now, for two reasons -- first, I don't want the session layer calling into the block manager (although we could simply drill a new "is compaction useful" hole); second, this layer doesn't know what files we're going to compact, since "table:xxx" translates into any number of file compaction calls, so we're going to have to check a bunch of files and then aggregate the results to figure out if the compaction will be entirely skipped or not, that feels like real work.
I'm not sure if we really need to stash this and restore it, but I figured better safe than sorry.
It felt odd to pass an explicit btree handle into the __wt_btree_get_memsize call.
I don't understand this change
WSF_FILTER_HANDLER inherits from WSF_HANDLER

so it is enough to put WSF_HANDLER

The advantage is that you can end the filter chain with a pure handler
but still you can have a chain of many filter objects
Are you sure ``'Zend\\EventManager\\SharedEventManagerInterface'`` has the correct type as ``string`` is not a sub-type of ``string``?
This is a bit confusing comment. Can you make it simpler and shorter?
probably want to make this method "public" to match the Dart version
I meant to use elink_eve here to resolve numeric alliance/corp/person names to actual names and tickers. I'll fix that up. Unfortunately, resolving moon ids and system id's requires a static database dump :/
Actually this isn't the firing of a request, but a replacement of the method on the nested changeApplier by a wrapped version... this *is* the method which is operated on line 647. We need to make sure that all routes by which changes may be fired by the user are protected by the "source wrapping" which makes a notation on the way out of the new source.

Now I look at this pathway again, I think it's possible that in some complex cases the counting of sources may not be correct. We add +1 for a source on the way up the "stack" and -1 on the way down. This at least guarantees that we get back to 0 once the user returns to the point where they fired the "first" change, but really we want the sources to be ONLY accumulative until "this point" - "this point" being the point when "the original change" has finished being processed. In a complex case, you could imagine something like this:

change with source 1 fired --->
    change with source 2 fired --->
    <-- change with source returns
   change with source 3 fired -->
       in HERE we want to still see source 2, even though it has returned!
   <-- change with source 3 returns
<-- change with source 1 returns

This should be possible with a slightly different implementation of sourceWrapModelChanged, but it might be just to JIRA this for now and move on.
please don't hardcode this. you should use a ``liip_imagine.transformer`` tag on the service and a compiler pass to add them in the loader
I will have to correct those details.
if [[ "$OSTYPE" == darwin* ]]; then
  # stuff
fi
Should you say "information"?
Why is the cast necessary? Also, we should cast to the genericized type.
I dont think that would work, assuming one proxy can handle multiple subnets
Hm, no. We will use HTML5 geolocation to send this information to the server, which will then based on that find closest node and then other parts of the portal will work as expected. So this should be done only on `/outside/` view.
You will have to order those objects by date and get only `first()`, if we will store also past horoscopes.
Use please with here. To not ditty context more then necessary:

```
{% with form_submit=_("Login") %}
    {% url login as form_action %}
    {% include "form/form.html" %}
{% endwith %}
```