labofsahil/github-event-dataset-2012 huggingface dataset:
This is not yet a 5.0-dev branch.
If you wanna make a 5.0-dev branch, I'd gladly commit to that...
There's heaps of code that will be eliminated with 5.0 that would be nice to clean up.
I was under the impression that "\n" is not recognized by Windows, so I chose to use `os.linesep`. Is that not the case anymore?
`get_equivalent_units` returns a list of equivalent units, and its output is much more useful for programmatic use (this should probably be referenced by a "see also").  Why return something that then has to be reparsed?
Okay currently I use np.iterable but that should be a quick search and replace later. 

I also think that in these cases we want to give back to the numpy community and give them the code, as your code seems clearly better than what's there. 

Then we can in the future use our implementation from numpy.
I go back and forth on `sqrt` vs. ``**0.5``.  It turns out that which one is faster seems to be a complicated function of array size and platform.  For example, on one computer I have, small arrays (<10000) seem to be better with sqrt but ``**0.5`` performs better for larger arrays.  But then on my macbook pro, it seems that ``**0.5`` is *faster* for small arrays, but the sqrt wins for medium size arrays (roughlt 1000 < n < 100000), but then **0.5** wins again for the largest arrays.

Another issue with `sqrt` is that `math.sqrt` is an order of magnitude faster than `numpy.sqrt` for *scalar* inputs.  So if you may have either numpy arrays or scalars, you have to check if its a scalar or else run a factor of at least 10x slower for scalar inputs.  And it some cases it seems that ``**0.5`` is faster than doing the if/else statement, even though `np.sqrt` of `math.sqrt` might be faster on their own. 

Fortunately, we don't have to worry too much because it's currently all scalars.  But @taldcroft and @iguananaut, we should revisit this when we add the array support!
the `parent_nddata` is set by the `NDData` object when you add an `NDError` object to it, right?  If so, this should probably be removed (and the initializer argument), because it duplicates the setting (and creates the possibility where the parent is set, but `NDData.error` is *not*).  

Also, the subclassing doc page should mention that initializers should not do this (assuming we want to remove it here).
needs a `Returns` section (or is this not public API?  still wouldn't hurt, though)
不过这事比较大，属于另外一个事情(Request)，我先合吧。
We should probably have a doc notation for files. But since we don't, perhaps backtick are in order? `/etc/sysctl.conf`
Uh.  I'd worry that callers wouldn't be aware of that subtle detail and would have applications which missed small transactions.

If the API worked in a way that it could simply be rate limited to not notify more than X times per second then that would be a preferable option, but the 1:1 behavior doesn't seem to work for that.
state->allocator->calloc(AddressMapper_MAX_ENTRIES, sizeof(uint64_t), state->allocator)
will not return null (it will abort() instead) and you don't have to worry about freeing it as long as you free the allocator.
gettype()
lol woops I copied and pasted it without even realising
Merge markers need to be removed here
I think this might be a copy n paste error here. At least it doesn't match the signature
We can add an alias.

Or we can fix this whole issue by making all mappings in Linguist case-insensitive (like in Pygments::Lexer).
```
else : 
   print 'No extra Arguments' 
```
?
 So that we are reminded that it is the slow one ?
Shouldn't the default be \r\n ? See 5545:

"Content lines are delimited by a line break, which is a CRLF sequence (CR character followed by LF character)"
You totally don't need the error or the goto. Just return if the internal prettify fails.
I was thinking for a malformed transport that might continue to call `git_indexer_stream_add` after an error occurred, in which case this code would "think" a stream already existed but actually doesn't. However, that might be "too much safety".
thanks for making this change, it was such a bad practice to reference parser variables in the grammar.

You are awesome!
This has been fixed in jubianchi/atoum@82589ef (https://github.com/jubianchi/atoum/commit/82589ef#L2R16)
Adding in as an include in an additional pull request...
I assume you don't know yet exactly, but once you know if this will be the same content as the other sidebar, then you should do something not to repeat code.
Yes, please use `url('privacy.index')`
add a newline so it doesnt complain :-)
This looks weird, I am not sure what happened. I am guessing you need to add a semi-colon to the first line and fix indentation in the second line?
ideally, it would be swapped out by Ops for the proper path to the loaded files, but good call on using the ROOT_PACKAGE. Fixing.
And you kept me thinking you hated <?..
I don't think this will work on Windows
btw, as the main use cases are the ChoiceType (and its children) and the CollectionType, I think my previous suggestion about using the same condition would be a valid case:

```php
$this->modelData instanceof \Traversable &&
$this->modelData instanceof \ArrayAccess &&
iterator_count($this->modelData) === 0
```
Shouldn’t it be `/^(.)\^?(.*)\$?\1$/` ? Pattern won’t always be delimited.
> Of course this can happen. setParent and setPrefix are public, so sure this case can be brought about.

I'm sure I could break any code by messing with its state, too ;) Attempts to avoid that would make the code less flexible and more complicated.
Quite interesting that needs special treatment:
> A path segment that contains a colon character (e.g., "this:that")
   cannot be used as the first segment of a relative-path reference, as
   it would be mistaken for a scheme name.  Such a segment must be
   preceded by a dot-segment (e.g., "./this:that") to make a relative-
   path reference.
`0 === strpos('- ', $this->currentLine)`
I'd like to avoid having timeouts like this in the test. It is not very reliable. (The rest of specs in this file have pretty bad style wrt this, too). Perhaps you can test receive ordering explicitly?

```scala
val of = Offer.choose(clientRes.messages map(Some(_)), clientRes.errors map { _ => None })
of.syncWait() must beSome("1".getBytes)
of.syncWait() must beSome("2".getBytes)
of.syncWait() must beNone
```
That was your idea, yes. We could solve that other problem another way that doesn't break the inheritance.
age yejayi lazem bood mishe meghdar ham dad
masalan
```css
  fixed : top 10 left 20
```
px ham fekr konam nemikhad ;)
这个还有待完善。
What to you think of having a parent concept "LocalDifferentialEstimator" (or something like that, with init() and eval())  with not connection with "SegmentComputer" ?
This one would be a refinement focusing CSegment.

For example, on can derive tangent estimator without using any model of CSegmentComputer.

By the way,   CSegmentComputerFunctor is too generic (any functor on SegmentComputer is not necessarily an estimator)
s/THe/The
Actually probably would.
It's on my todo list for when I get back.
This is not a real example... I think it might be worth turning this into a tutorial (in your next PR). Consider removing completely for now.
Not sure about deleting this one. I will have to look into this (I think I have some work in progress documentation which uses this).
some javascript optimization talk that Senos and Diaz went to last year, I'll ping them
I suppose we have to assume that no message that goes through these queuereaders has a "data" key in the root dict already; we control the inputs so I guess that's a safe assumption.
Are ok mate sorry about that :/  Cheers for check over things :)
Why do you need this kind of class names?
Super - I'll update it. Thanks for checking.
When this runs in an HC, the first element in the path will be profile=somename
We are currently in 2012 ;-)
Discussed this with the others, so please add in the original config side by side
How about simplifying this further and moving the indent_style to this wildcard block as well?
you're welcome
sorry again, I have just installed gjslint and I will use it in future
Be careful, Contacts is not always displayed as a child iframe from Communications, so as Francisco I'm not convinced about that change
Do you really want to reset the PIN here?
It's fine to leave it commented out for now, but yes, that's the right way to call undo.  The unit tests are frequently a good place to see how the back-end gets used; you can see most of the tests involving undo right here: https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/test/unit/test_imap_mutation.js

I have some resiliency fixes in a pull request; I may need to push an extra commit to that to avoid the permanent breakage when we get an op in the queue that is not supported, although it may be covered.

Yeah, ActiveSync needs a few more no-op's added.  IMAP may need some too for the ops that aren't fully implemented yet.
I remembered that we are not going to move `mozL10n` to platform but rather have it work as a shared library for Gaia?
Недействительная ссылка
I think this modification is not useful. Tube creation should still work without having to explicitly pass an aliquot list.
same as:

`GetService(srv.Snapshot, name)`
I prefer the real HTML entity for an ellipsis `&hellip;` instead of using three dots.
I think it is exactly that general.  The point is, there are 4 (5 here, but I got smarter later and will make another pull request) fundamental operations on KeyedList.  These could be implemented in scala collections or whatever, but we are doing it for distributed computation in scalding.
Use `Djinn.log_debug`.
I'd also add a check for `existingUrl` here so that it's not required (and it uses `'?'` if not provided). Otherwise looks good!
For now this is ok, but we may want another kind of change in the future, e.g., a "moves", for `reverse`, `sort`, and similar.
the submenu?
This feels a little weird to override the existing repair method in JMXNodeTool.  I'd rather see the "forceTableRepair" method renamed, made publicly visible and then used directly here with some mutex wrappering around it.  I know this statement isn't very clear ... let's talk verbally about design of this part.
If you are inheriting from VC10, you should be using that here.
It occurred to me that this could be an external template. It seems like a large enough chunk of text to consider warranting it.
I think it'd be easy enough to implement all of these limitations, but for the moment they're not required.  We're unlikely to ever need params-as-list, since our methods should all take keyword arguments.
I'll remove them as we don't have the bin yet
It's actually 300 / 5min now.
version ? it should be the name
Looks like a merge conflict with this commit https://github.com/diaspora/diaspora/commit/efa79a4ad785942d7056a6747d03ed7df9bff7cf
Why product has type 'installed_content'? What's a purpose of this?
I did not understand some of this behavior. Why do we continue to execute the chain, when calling the $filter->deny()?
should be `else`
It actually removes them - they were previously being tracked, so he had to `git rm` them.
Of course this import is no longer necessary too... :)
Updated to match
just want to make sure that the the other listener had a chance to hear the change. I'll make a comment.
Could you write some other (real) example this one is very confusing.
win, add, email, and auth_url are never used outside of the templates and should be removed.
didn't we agree to round timestamp down to 5 minute granularity to make log correlation intractable, even for ourselves?  is this the work of a subsequent bug?  

We should do this in browserid before blobs leave for the piggy bank.
put this up around lines 6-16 at the top of the file
So you mean some extended version of `dprime()` or `dprime_from_samp()`, right?  That is definitely a possible extension, and I'm gonna code up that too.

Meanwhile, `dprime_from_confusion_ova()` is meant to be used when there's no access to internal representation / decision making (like human data).  This function computes n OVA d's from the given n-by-n confusion matrix --- but I admit that there's no clear connection between d' computed from a n-way confusion matrix and a 2-way binary classifier.
Ah, this caught my eye. HASH_OF() is defined as:

    #define HASH_OF(p) (Z_TYPE_P(p)==IS_ARRAY ? Z_ARRVAL_P(p) : ((Z_TYPE_P(p)==IS_OBJECT ? Z_OBJ_HT_P(p)->get_properties((p) TSRMLS_CC) : NULL)))

As you checked before, that `Z_TYPE` is `IS_ARRAY`, you could just use `Z_ARRVAL_PP()` instead of `HASH_OF()`
Similar to the discussion on #130, we could have the `GNU/kFreeBSD` kernel as well, and we should test for that kernel as well.
One reason is because you can't use "const_get" inside of a face for some reason (I filed a ticket for that a while back but haven't gotten to it yet)... so we have to use an "eval" here instead.

The other reason is because I want to clearly and unambiguously isolate the code that makes up the hack so that it can be removed easily.  I think that if I refactored this logic into a utility class then there would end up being 3 places that needed to be touched to remove the hack, instead of just 2, so that's why I left it like this.  Minimizing that number seems the most important thing to me.  But maybe there is a way I can move *all* of the logic into a utility method somewhere, and get the count down to 1.  I'll take a look tomorrow and see if that's the case--I'd just assumed that it wasn't since the previous implementations were duplicating this logic... thanks for the suggestion, though, I'll look into it.
@vrthra nevermind about that
It's the workaround i found for a Json pretty generate bug.
This code should also cross compile, so windows.h should be lowercase and I don't think WindowsX.h exists on gcc/mingw.
typo: doesn -> does. I think 'nor' would be better than 'or'
Why do these rules need to be marked `!important`? They seem to work without it.
I wouldn't call the option or the variable 'littlechef', because well, we everything in there is for littlechef. That path is for the repository files, which in LittleChef speak is the "kitchen". So either name would be fine.
This could use some comments, as now ant is being relied upon to insert code
In this particular case, strict object approach would fix the problem (I mean do not use global variables, use getter/setter instead). So, continue in refactoring. Especially focusing on handling global variables out of module where defined.

Generic approach would be to create e.g. a server with generic use cases with well defined checks (sort of integration tests). New package should be tested even against those configurations. Example for this case: have predefined set of autoyast profiles and its results.
$match is an array, no?
Typo in the name (you wrote autheTNication). Moreover, as you added the use statement, you can simply use "AuthenticationService" as well in each docblock.
Isn't it a duplicate of testExcludeWithString then?
Made no difference to tests - made the change for all escape functions to boot ;)
done with my last commit
/docs/ will be added to .gitignore
Goutte is :)
This prevents overwriting unspecified cells with specific "empty" ones.  This could have also been fixed in PHPExcel/Writer/Excel5/Worksheet.php :: _writeBlank() if it did not write empty cells with no format specified.
You *should* be able to hack around it using the hook aceGetFilterStack actually. Check out the populateDomLine function to see how...
I benchmarked this and the difference is unmeasurable. So I think this change should be merged as is.
I think we can drop this migration completely now, I meant to do that after I ran the migration a while back.
This should probably be:

    if (Pouch.DEBUG)
      console.error(err);
    return call(callback, err);
Will implement error handling
habit.
would this make the build fail in case of a CS violation ? I'm not sure it is the best idea.
Instead of an an `if !` you should use an `unless` or you should keep the `if` and not have the `!` and flip the blocks inside.
Nice catch, I'll see if I can take that into account nicely.
mention why parallel=1 is required (if it's not, drop it)
MessageType.parse() is a good way to find how to parse a type.
Also RedelmParser is not a specific enough name. What about TypeParser as it parses types. If it parses only Message types it should be MessageTypeParser.
`legend` should be used within a `fieldset`

https://developer.mozilla.org/en/HTML/Element/legend
This needs more explanation.
Wow, nevermind. This one is on github. My apologies... the diff made it appear as though I was looking in the definition of `Popcorn.removeTrackEvent`. Sorry about that
@Sakshiarora I think what @AlinT is getting at is that because the property returns a Boolean it's convention (at least in this our code base) to start a def with <code>is_</code>.
You can leave it, this class isn't really used right now.
db/schema.rb よかったらignoreしてください
ah! why pop 'username' and 'password' when it's not in `Meta.fields`?
Err.... You can always do this:

    view.destroy({children: false})

We should document and test whatever we land on here as a best practice / behavior. In Phoenix land where are we caching / re-using child views?
What is all of this?
@cwhelchel Thanks a lot. Reducing the code of the `Trade` class is important at this size.

@94m3k1n9 If that would be the case, the `TradeManager` could be easily rewritten to manage multiple trades.
See the website in the previous comment.  The original was correct as "will be canceled" since this is true as a one-time future event.
I'd suggest wrapping all of these methods with "if (logger.isErrorEnabled() )" blocks (or the equivalently-named method for the log level) so that we don't create a new I18n instance when the logging is not enabled.
Fixed in next
I think it's "tray" that didn't properly get decoded. I didn't even notice that, thanks!
funny indents
I'd write this as:

```coffeescript
if /^\d+$/.test command
```
This is a hack, and I'm tired of cleaning this kind of thing up. Please find an appropriate solution.
I haven't tested this, but does this mean the BCryptHMAC password hasher without an HMAC key is the same as if you just used bcrypt?
I've made some test and it seems that 10k is enougth !
By disabling the wait you're not allowing for the chance that the browserid login is not *yet* available. If this is irrelevant in the context of the page then you can ignore this comment, however I suspect a wait with a suitable timeout is needed.
Should be marked with native as it uses a native event.
`inflateInit()` will set `total_in` and `total_out` to 0, so these assignments are misleading.
Indentation seems to be all mangled in here.
did you intend to leave this in?
Why doesn't /api/content/:contentId/download/:revisionId work here?
http://www.devthought.com/2012/02/17/npm-tricks/ > Local binaries seems to have a trick as to how we can avoid the global mocha install issue.
I think I just didn't clean this up before I made the PR, I'll have a look.
Can you please use brackets here to help dummies like me parse the precedence :)
both done.
Then I'm gonna mention KISS ;)
The problem is that I need to keep a reference on the `IDebugEventListener` which is created, to be able to unregister it. But I still can improve it a bit.
Nested matches are a bit harder to read. Couldn't you pattern match inside `Right(...)`?
Are you 100% sure that the source string won't ever contain a comma?

Is there any specific reason for not using Python's CSV library?
the ClosedChannelException needs to be caught and logged. Carlos, I am thinking closing the selector manager itself is bit extreme? I will make that change and merge it in, if its okay with you
Please fix this in other places in your codebase, too.
I couldn't find clue that modalDelegate is retained in https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSAlert_Class/Reference/Reference.html#//apple_ref/occ/instm/NSAlert/beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:

This may make pre-released delegate object.
check if timeOut is 0, then set to 0.1 from 1.
If `$method` is always guaranteed to have a length of 1+ characters, `$method[0] !== '_'` might be better than `strncmp()`.
Не вывалится, while(length<percent) не выполнится ибо length=1 уже будет больше чем percent.
Правда в этом случае один элемент таки будет заменён. Поздравляю - вы нашли проблему.
Изучите ещё метод `@throw` и `NSCAssert`, возможно, вам больше понравится.
Не понял зачем это. Ваша переменная NSMutableArray *DNA и так "спрятана", для нее не существует сеттера. Зачем его определять?
@OutPunk  это почему, интересно?
цикл будет работать до тех пор, пока не получит nil в результате (count--), и на деле так оно и есть
проверить очень просто
В настройках сервера не понял, зачем указывается IP. Понимаю, что интерфейсов может быть много, но тогда логично было бы выбирать, а не указывать.
This should be where this test ends.  This one step should cover the remaining two.
it seems as if you're messing with the indentation here.
basically, you should not use "value" and you should use "from"
This probably belongs in your local user's gitignore, not the project's file.
Yeah I tend to use a lot of ES5 methods as of late, given that most mobile browsers have very good support for most of them (especially the WebKit based ones, which Sencha specifically targets). I know this method is supported on Android 1.5+ (so fine for all) and iOS 4+ (maybe not acceptable?).

In any case, I still think just checking for length isn't good enough, for the reasons above. I say we use underscores method here:

```
_.isArray = nativeIsArray || function(obj) {
    return toString.call(obj) == '[object Array]';
};
```
Because we want subscription to happen as quickly as possible. If we're already on a scheduler, we don't need/want to defer to later.
I've made the necessary change.
I think the namespace pollution point is a good one.

Sent from my iPhone

On Nov 27, 2012, at 9:44 AM, Justin Campbell <notifications@github.com> wrote:

> In spec/lib/easystats_spec.rb:
> 
> > @@ -5,6 +5,8 @@
> >  
> >    it { should respond_to :average }
> >  
> > +  it { should respond_to :wma }
> I'm just pointing it out in the spec, but the specs are irrelevant. I'm saying I'm against having #wma be an alias to #weighted_moving_average.
> 
> —
> Reply to this email directly or view it on GitHub.
>
I just use the existing working function :)
+ 1 I think picks would be nice for .average()


On Wed, Dec 5, 2012 at 1:48 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In mne/viz.py:
>
> > @@ -1031,6 +1037,13 @@ def plot_image_epochs(epochs, picks, sigma=0.3, vmin=None,
> >          (data.shape[1] == len(times))
> >      show : bool
> >          Show or not the figure at the end
> > +    scalings : dict
> > +        The scalings of the channel types to be applied for plotting.
> > +    titles : dict
> > +        The titles associated with the channels.
> > +    keep_only_data_channels: bool
> > +            If False, all channels with be kept. Otherwise
> > +            only MEG and EEG channels are kept.
>
> I'll open a PR asap
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2319909>.
>
>
Basically it depends on how the time series are "clustered" inside the label. So maybe we shouldn't add the scaling.
don't you want to do something like that:

```
tfr_ch = tfr[ch_idx, :, times[::decim] < 0].copy()
tfr_ch /= np.mean(tfr_ch,  axis=1)[:, None]
```

and then tfr_ch is plot_data (so no need of plot data)
why is this notEqual?
remove global declaration
It's more configurable this way. You may want to declare different locations for different indexes and use this variable in any of them e.g.
hibernate.search.default.indexBase=%APPLICATION_DATA_DIRECTORY%/lucene/default
hibernate.search.Concept.indexBase=%APPLICATION_DATA_DIRECTORY%/lucene/concept_search
oh,  man. Is it ever!
Yes. We can add it in as a story. There also needs to be stuff for if it fails.
tbh I have no idea.

Should I remove it?
这个也是咨询过永攀，她说这个说法比较贴切
Thinking about this some more -- the developer on a project using this could just create their own `signed_in_admin` if they needed that functionality
@mike-burns and which version of paperclip are you typically using in client projects...?    :trollface:
Epic fail , need to change this to : 

if(!DungeonMaze.allowSurface) {
this is very suboptimal
`if (!profile) ... return;`
А ничего, что у тебя иначе объект утекает?
Тут лучше не отбивать табом.
Ah, me confundí, parece que es por fecha, estaba confundido con lo anterior.
should check user rights
Oups I forgot to do this.
We discussed this. ids and uuids are more or less interchangeable in _instance_update. As a separate change, we're going to make sure they all use uuid for consistency.
Why do you need a treeset here? To order/sort the names? If so, could you have used Collections.sort() op?
+1. I imagine in most situations the list would only be read (e.g. during all the reads and writes from the cluster) so IMO we should optimise for this situation.
this doesn't get used -- were you going to zip and then didnt?
Shouldn't this be handled by the `path` module?
Hmmm. @mdboom has just updated the coding_guide page to explain this in a little more detail. 

Do you feel that having this extra ```README``` for added help outweighs the cost of having to maintain this information in 2 places? 
Personally, I'm not sure - hence would like to get your more fresh eyes on this.
Why can't the Node always store the full URI? The prefix is purely a concern of the markup, it can be applied when reading and writing N3 only?
Use triple equals, not double equals
self.testsetup ???
true, "Copier la partie" would be better
Some of those parts will still feel better in a subclass
Seems worth to me.
lol. the only reason I pitched in is because you submitted a pull request and I'm watching this repo... no worries.

looks like python 3.3 is what's causing it to fail... right rob? I'm not sure if there's proper travis support for 3.3 yet--maybe just disable it so you can have a nice green image, until it magically starts working.
Thinking about this, this is a little weird. The templates should only be available via getTemplates and not through the global variable that might or might not be there. No widgets should rely on or use the global variable.
I actually do think this logic will stay specific to querying-content, but I guess we'll find out as the refactoring completes post-1.4. Either way, since all of the relevant code will need to be revisited anyway, my comment was kind of pointless. :)
It disappeared every second refresh. Fixed this morning, but the bug will still be in this version. ;)
Presumably you wanted to write assertNotEquals here?
Mno jo, copy and paste... :)
I've added a cache pool lock as well as keeping the __wt_connection lock. That makes the lock semantics when managing the cache pool more complex, but.. I thought it was worthwhile because I didn't want new connections (that aren't necessarily part of the cache pool) to have to wait on a lock being held for cache pool operations.
Remove outer parenthesis.
Hm, `0` in this line shouldn't really be here?
Are you sure ``$resource`` has the correct type as ``null|resource`` is not a sub-type of ``resource``? I found this a couple of more times on lines: 1178, 1220, 1279, 1307, 1309, 1311, 1313, 1410.
缩进有问题。node代码中，通常都是两个缩进。
Fuera esos paréntesis xD

Y usa `data.SongName?`. El operador existencial es **muy** importante en Coffee, porque JS apesta.
You finally keep these here? :)
I know

And I am here to remind you ;)
Like @jashkenas says above, it's probably best to avoid them when possible to stay away the bugs that come along with them.  That said, the actual fix was to move the extension of `child` with `parent` and `staticProps` before the inheritance set up.
I don't think this test goes far enough to ensure that the options
object isn't mutated.  It will fail if a key in `options` is removed,
but not if a value is modified.  I recommend this instead:

```javascript

it("should not mutate the user-provided option object", function() {
    var onSuccess = function(result) {};
    var onError = function(result) {};
    var options = {
        values: {"ntoll/rating": 7,
                 "ntoll/description": "I like it!"},
        about: "foo",
        onSuccess: onSuccess,
        onError: onError,
    };
    this.fi.tag(options);

    expect(options.length).toEqual(4);
    expect(options.values).toEqual({"ntoll/rating": 7,
                                    "ntoll/description": "I like it!"});
    expect(options.about).toEqual("foo");
    expect(options.onSuccess).toEqual(onSuccess);
    expect(options.onError).toEqual(onError);
});
```
it is set to default value. After code review changes, this becomes obvious
For now, would it be ok to just change this to:

```php
$options[CURLOPT_FOLLOWLOCATION] = (bool) $this->options->get('curl.followLocation', true);
```

If we can support it in the other transports it won't be hard to support it with a generic option.  It would be good to document the options that are available, probably in the this class constructor Docblock.

Does that get you out of trouble?
This change is unrelated to the pull request.  Please keep it on topic.
This field type could also make use of the placeholder attribute.
Did you mean

    $input->set('option', $option);

?
Actually I think you are right. But in this case, I'd suggest to move the PdfTransformer somewhere else.
I still think that something like an example folder would be better.
boring CS issue .. ``switch (`` :)
Does `_enqueue_removal` get called if a video changes status from APPROVED to something else?
Yes, it is a problem. File `nasty-infinite-warnings.cpp` is able to generate 6MB of warnings before compiler runs out of memory. Then django, while serving user this output, crashes whole server.
I moved it up. See above :)
Constant string - `'` around.
You have really programmed in some other language in between, haven't you?
Why is this needed and `object` is not good enough?
In this case it is probably enough:

```
if not value:
    return
```
But still, store all of this into the database. Like we are doing in other backends. For example, expires could be helpful some day.
No need for space around `{}`.
$fieldsParam = $e->getRequest()->getQuery()->get('_fields');
$fields = Fields::createFromString($fieldsParam);
The user actively clicks the button. We should ask the user if he wants to continue and warn him that this action should only be used if no other TGit application is running.
For deletion of files on startup: Files are only deleted if those are older than one day - if we cannot delete a file (or another tool just deleted a file), ignore it.
sorry, i mean if you delete these lines, the logical chain is not broken?
Auf den MultithreadedProgressDialog ändern.
I'm not 100% sure what `sharedACL` is for. My best guess is that it's an incomplete ACL that exists on objects that are not owned by the current user. Is that correct?
So you suggest calling it "ObjectManager" ? As it contains an ObjectRepository, it may be a little confusing.
No shit? :revolving_hearts: :sparkling_heart: . that's amazing. I may use that going forward.
here you have some spaces instead of tabs.. I'm having my IDE showing whitespace characters.
The same as others, nothing :)  I guess it's there to avoid hard-coding the eq 'close' part.
OK, now that you learned this, you can also learn (see bellow) that you can simply raise `exceptions.PermissionDenied` and the same will happen.
I think you should split this part into:

- a method that calls a command on a specific node
- then a check on the command: if you want to send it to multiple nodes, call the first method multiple times, otherwise just one time.
bidpom actually uses the more generic 'bidpom_' (see [here](https://github.com/mozilla/bidpom/blob/master/mocks/user.py#L13)). I think it may make sense to allow for project specific overrides. It should be impossible for two projects to get the same uuid, but we're testers right, we know the impossible happens! :P I would perhaps suggest an optional 'prefix' argument in bidpom when constructing a user.
There is a considerable difference: `fulfillment` does not return an actual promise, but something that only looks like a promise (and cannot be chained). By opposition, `resolve` returns an actual promise.

I told you that that code was harder to understand than it looked :)
Some whitespace missing, should be `function(msg) { return /^handle/.test(msg); }`.

Same on following lines.
There are two kinds of context we need: per-request, and per-server.  Right now I believe I'm doing per-request context properly, with ngx_http_set_ctx, and ngx_http_get_module_ctx.  Everything in the ngx_http_pagespeed_request_ctx_t has the lifetime of a request. [1]  For the per-server context I need to hold on to a ServerContext and a RewriteDriverFactory (via the needs-to-be-renamed ngx_http_pagespeed_module_ctx_t) and have them available across all requests.  If I understand Ben properly, they should go into the configuration at the server-block level.

[1] Not quite true.  The RewriteDriver may continue working on background rewrites after we're done with the request.  For example, if it's partway through a large image compression when we call FinishParse it will give us HTML with a link to the original resource but keep on compressing the image so that future requests can have the rewritten image.  It puts itself back in the rewrite driver pool when it's done, though, so we don't need to keep a pointer to it after the request completes.
Bad check? Both types are unsigned, underflow will wrap.
Yes, but it also happens to be the documented way to interact with libpng. That said, this code needs to be wrapped up in a sane class anyway.
Btw. is `canFade` really a good name for this? Shouldn't it be `isDocked` or something?
You should really use compsys since compctl is deprecated and has not been updated in years. It's only there for backwards compatibility and may be removed at some point.
Yeah I completely understand what you mean.  Really, it's not that much more unreadable.  I think we can keep your changes.
This obviously is not the good way to do it. You should not be committing this to the repository. Check how we are doing it in [nodewatcher](http://dev.wlan-si.net/browser/nodewatcher).
Class will be deleted.
Same as addButton |^|
bad style uses braces {}
ordering change here affects layout and i wanted email before name
Can you leave it with my fix of `getOwner()` rather than `owner` please?
Both should work. Using the method is arguably "less groovy" but will hopefully avoid any similar confusion in the future...
not convinced --   Application.isAssignableFrom(getEntityClass(xx)) is easy -- but fine for now
You are correct. I return to indexOf.
We discussed that a better approach would be to instantly fail rather than assert False here, and it looks like we can use `pytest.fail(message)` for this.

See: http://pytest.org/latest/builtin.html#pytest.fail
Hannes Magnusson <notifications@github.com> wrote:

> > +		safe_op = !default_fire_and_forget;
> > +	}
> > +	/* Then we check the options array that could overwrite the
> default */
> > +	if (options && Z_TYPE_P(options) == IS_ARRAY) {
> > +		/* Check for "safe" in options array */
> > +		if (zend_hash_find(HASH_P(options), "safe", strlen("safe")+1,
> (void**)&safe_pp) == SUCCESS) {
> > +			/* Check for bool/int value >= 1 */
> > +			if ((Z_TYPE_PP(safe_pp) == IS_LONG || Z_TYPE_PP(safe_pp) ==
> IS_BOOL)) {
> > +				safe_op = (Z_LVAL_PP(safe_pp) >= 1);
> > +				goto ok;
> > +			}
> > +			/* Check for string value ("majority", or a tag) */
> > +			if (Z_TYPE_PP(safe_pp) == IS_STRING) {
> > +				safe_op = 1;
> > +				goto ok;
> > +			}
> 
> Any reason for not supporting specifying safe and fsync? (the fsync
> check is done 2lines below but is skipped when safe_pp is string)

That sounds like a bug then. Will check and fix
@miketaylr @luzc if the image is not modified we are alright, BUT as a courtesy we could just put a comment on Flickr for the owner to ask if s/he is ok with it. Sometimes people have chosen a license without realizing the consequences.
> My gut reaction is that we should check #to_ary and use Array.new(actual) instead of actual.dup later. Array.new will take in a thing that responds to #to_ary.

That sounds fine, although we should think through the cases where the provided object is not actually an array.  For example, if it is a `Set` would it work properly?
As configurações de MEMCACHED devem ser mantidas como Dummy, no arquivo settings.py. Estas configs devem ser realizadas no settings_local.include
Because Ace insists on them. They are big, breaking changes.
if there are more than one updaters, this'll only check the first and ignore the rest. I assume you want to return true if any are collaborative, and false if all are not?
Unsure, I guess it could work even without escaping, @laserlemon is author of this regexp, I just moved it to travis-support, maybe he will be able to tell if there is any reason to do that.
all these should use ``{@inheritdoc}`` instead of duplicating the phpdoc. Much easier to maintain the phpdoc
I think you may have replaced the space indentation with tabs here.
Need to change Recipient: ${item.author.username} to Recipient: ${item.recipient.username}.
Yes, I think that's something we should add. I created a new feature for this on the spreadsheet.
Have you measured how much impact it has to convert nodes to jQuery objects? Maybe at least assigning the object to a variable and reusing it might be good (instead of using the DOM API directly).
E mai rapid switch plus ca e si mai usor de citit atunci cand sunt multe conditii.
raymond was talking of a possible vuln. where you send a backspace in the request so it logs and then deletes logs, this is an attempt to inject something nasty, not sure i should let them do it.
Если вернётся null - что будет с открытыми подключениями?
Так , я вас понял :) Т.е. тут исправляем не по code conventions, но просто из других соображений? Просто я хотел исправить на нечто вроде while () {} или
while {
}, но не знал как верно.
Итого мне занести инкремент в цикл или просто поставить {}? Если второе - то как? - по code conventions я ответа судя по всему не найду :)
it is because currently, in the response, there are some tags that are similar between these two requests. However, these two requests are not the only two requests that share similar response structure. If we want to consolidate these common logic together, it might make sense to take a step back to look at the bigger picture, making a proposal encompassing broader considerations.
I'm confused about this. I would have thought that search tests are shared?
Any objection to making this response.kind_of? Net::HTTPSuccess rather than just a check for 201 status?
I copied the behaviour of `peak_local_max`.

Imho the best design would be to only provide a `threshold` parameter. If someone wants to use a relative threshold, he/she can simply pass `threshold_rel * np.max(hspace)`. What do you think?
Could you be more specific on what "the results are best" means?
I guess it should be that the cross-validation error correlates best with the test error.
Btw, you don't plot the test-error, do you?
Will change it as the draws are independent any way...
you're right. there seems to be a method that is called before ``fit``. I'll investigate.
Maybe on one of the larger random matrices from the beginning of the test.
is this the same as ``atleast2d``?
Well, it makes sense in clustering (where I came across it) and it would also make sense to get the in-sample error...
Huh, the diff I was looking at seemed to suggest it should go away, will re-add. Oddly removing this did not break any unit tests.
Console should be able to set the time of a world.
This should be `from . import settings` to avoid accidentally importing a root level `settings` module.
OK. Updated.
Added Conversion Helper file, for the utility function to convert from V8 to Native and vice versa.
Added V8ToNative namespace where we can add functions which are converting data from V8 to Native.
for the Native to V8 conversion NativeToV8 namespace is added
This should not be an instance function and doesn't even belong in this class. We need a Native-V8 conversion util/helper file to put this in, if one doesn't already exist.
Do no perform errors show in this way. Better do <%= @user.errors[:attribute].join(',') %>, next to each text field.
This will move all later items, causing false positives if out of order.
Is there something still missing here?
This pattern of a local transaction, possibly creating one, and then calling autoCommit occurs quite a few times in this file.  A separate commit might consider commoning them all up into a local object.

e.g.,
CLocalTransaction localTransaction(transaction, user);
This raises a notice: 

``Notice: Undefined index: include_fields in /var/www/mediawiki/extensions/Bugzilla/BugzillaQuery.class.php on line 212``
hmmm, did I change anything?
this doesn't look, did you mean `if (-1 == path.indexOf(` ?
why using both a property and a local variable ?

And properties should be declared in the class
Oh, good point. I'll change this back.
Thanks - I was going off what navigator.geolocation was doing -- which I suppose should go in clobbers as well (it's not there currently)?
Bad path!
Ah, didn't know underscore was loaded.
See http://isotope.metafizzy.co/docs/help.html#images
I was actually re-registering because the ZK docs say that a watch is only fired once. If you want to keep getting watch events, you need to re-register your watch after reading. Maybe the ZK gem does this for us behind the scenes, though. I also just made a change to explicitly check the event type.
Shouldn't there be some rights check in place? Normal users shouldn't be able to access such a page.
Do we have static `clone` functions for this?
Honestly, I was just playing Devil's Advocate.  If you guys want to just remove it for now and add it back if we need it later, that's fine with me.
There is a typo here, `concatenatedSources` does not exist.  It looks like the only thing using this function is `ComplexConicSensorVolume` which is broken because of this error.
After investigation it turned out that there must be a complete worker role scaffolding.
Don't need the "you can test for a cloud service, storage service name,..." sentence at the end, it's redundant.
OK, how about this as a solution?
```
RSpec.constants.map! { |g| g.to_sym }.include?(:Mocks)
```
I tested the change here in irb on both ruby 1.8 and 1.9, and it works.
The driver will live inside titanium_mobile which a developer will need to pull down anyways to build the SDK.  In short, test will no longer be served up via the hub.
This statement can be moved inside the else. For the pass condition this is not required since childHeight is horizontalRowHeight
Docs need to state that this is supported on IOS version 5.0 or greater
extra spaces here too
There's two extra spaces at the beginning of this line, I think--should line up with previous line. Suggest changing it to:

    If the network activity indicator is currently visible, it is hidden immediately.
Ok, I'll talk to Eric Bidelman about it, but I don't want to block this commit.
название не удачное
brace on its own line
Honestly I'd rather see how everything actually works ;)
Filter looks much more clearly useful. Since you're good with git, may I impose on you to make this a separate pull request so we can pull this in while still debating Lambda? Thanks!
I think this should not be valid: the minItems:2 constraint is violated
FYI, I don't think this check will work. Lists don't usually implement the `==` operator and .keys returns a new collection each time.
What we probably need is for watchers to have Map support:
https://github.com/dart-lang/dart-web-components/issues/146
Oh, you're doing this for testing. In that case, make `getCommandProcessor` a wrapper around `CommandProcessor.getProcessor` — don't cache at all.
missing the line for setting target to be 2D for ES
settings.textureTarget = GL_TEXTURE_2D;
Esse controlador não precisava ser feito.
No Controlador, foi criado uma action para tratar a imagem, como ela é feita a busca!

def imagemProfessor ={


if (params.id){


Professor professor = Professor.findById(params.id)


if(professor){


response.outputStream << professor.imagem


}   


}







No View , tive que inserir a apresentação da imagem, pois ele vem por default a impressão do valor do campo imagem de professor

<td>     
<img alt="" class="imgDoubleBorderLightGray" width="100" height="100"    src="/AlocadorHorarios/professor/imagemProfessor/${professorInstance.id}">
</td>



--  
Paulo Lira
Graduando em Sistemas de Informação - UFPB
------------------------------------------------
E-mail - paulo.liraa[at]gmail.com  
Msn - p4ulocesar[at]msn.com      
Skype - paulo.liran
Cel - (83)9638-3330   
------------------------------------------------



On Thursday, 5 de April de 2012 at 02:08, rodrigovilar wrote:

> > @@ -10,20 +10,14 @@ class ProfessorController {
> > redirect(action: "list", params: params)
> > }
> >  
> > - def imagem = {
> >  
>  
>  
> Na prática, você apenas tirou a action imagem, não é?
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/rodrigovilar/AlocadorHorarios/pull/12/files#r648942
>  
>
The identiation of Licensed seems to be off...
Refactored here: bcabe6612dc8cc49f05f1ed912a5995bc11ed1f2
you should probably just remove ``(recommended)``, and maybe drop the number for the titles.

This title could also be improved a bit IMO. what about ``Install the bundle with Composer``
Is the \ required?
I think this needs to be:
```ruby
    get '/posts/new' => 'PostsController::New'
```
you right! thanks ;)
Spaces here and throughout the rest of the widget.
`->` остается на предыдущей строке.
И в этом цикле обрамляющие скобочки не нужны.
I forwarded this to Andrei, to see if there is some reason for the @@@BUG@@@ 
ugliness that we are not aware of.
Ok, i'll change that and will add additional 'key' attribute.
Nit: line is too long, it'd be good if line is around 120 chrs so no need to scroll deep to the right
Sorry the poor english, $right means $sure, to the user access /delete_user/ID/1 (to really confirm if they want this, good for two-steps delete)
what's up with $this->iondb ?
the password should be defined inside https://github.com/symfony-cmf/symfony-cmf-website/blob/master/app/config/parameters.yml
however that file should be renamed to parameters.yml.dist, so that we can change the password on the production server.
imho we can merge this, but:

@lsmith77 what do you think about this one? we could also have handled this like an "external" link but that sounds stupid and would be hardcoding information. eventually we should probably do something on the cmf MenuBundle to allow rendering the root of the menu as home link.

should we create a ticket on MenuBundle so we don't forget?
@robertbasic : updated, cmiiw ;)
no, its optional. we don't need to map it. its just a convenience - the information is in the Id as well. (nodename is simple the part of the path after the last "/")
This is written as command line interface in the title and Command Line Interface in the 'see also' box. If we are going to use cli, I suggest we use Command Line Interface and CLI - lowercase abbreviations are confusing.
you should not require symfony/symfony, to let users use the individual repos if they want. And jms/translation-bundle is not a required dependency.
actually once this class extends LzoBaseLoad func, this method can be removed.
ça doit être une étape intermédiaire qui fait sa merde, surement au pull du local vers le dépôt, vu que la trace serveur du commit sur ma branche a remplacé les fonction d'origine en réécrivant les write()
Peut être tester avec smartgit prochainement.

Mais ce qui me gonfle surtout c'est d'avoir dû passer mes encodage de windows vers unix dans eclipse, et maintenant je vais devoir changer mes clients git de mes pc ou leur gestion des fichiers de "dos?" vers unix. En espérant que ce soit ça.
J'espère que j'aurai pas un énième changement à faire ultérieurement. :-/
Is the ip going to be just {'ip': ''} or {'addresses': [{'ip': ''}, {'ip': ''}]}