labofsahil/github-event-dataset-2012 huggingface dataset:
This method shares a lot with AddItem, can we reduce the duplication?
It'd probably be better to do that in a separate request. So, you added all the sizes, but you're only using one? I don't think we should commit anything unless it's actually used, even if we "plan" to use it eventually. If they get used by the new mixin, that'd be the time to add them. Also, the naming convention for images is to use hyphens, not underscores.
Yep. It's not exactly the clearest code in the world. I looked at the docs and didn't see another way to resolve the full URL.
Typo ``ndeve``?
It feels like this and all the other similar items could be refactored into a single function that takes the URL as an argument and returns a closure which you then pass to `CommandManager.register()`. Something like this:

```javascript
function _makeLinkMenuHandler(url) {
    return function () {
        if (!url) {
            return;
        }
        NativeApp.openURLInDefaultBrowser(url);
    };
}

// ...

CommandManager.register(Strings.CMD_HOW_TO_USE_BRACKETS, 
    Commands.HELP_HOW_TO_USE_BRACKETS, 
    _makeLinkMenuHandler(brackets.config.how_to_use_url);
```

(assuming that `brackets.config` is available by the time the `HelpCommandHandlers` module is loaded, which I'm assuming is the case).
Earlier in this file we still have the `<span class="settings">` -- should we remove it?
Appears to be unused... remove?
This is ignore is not needed since 7133270
Are these couchdb `_id`s?
First time I've seen somebody use footnote-style links in markdown. :clap:
Done in a537185.
I think it needs 2 divs but I wasn't the one who made it so I'm not sure.
No, but how can it access a variable defined in some other template?
Well parts of the portal will be definitely w/o authorization, how much of the user profile will depend on user settings.
We don't need this prefix do we?
wasn't this fixed in another ticket?
why keep track of a counter? You could just pass the getComponents function to forEach:

```js
components.forEach(getComponent);
```

It will be passed the component and index.
s/paul@paul.annesley.cc/paul@annesley.cc/
My aliases

    co    = checkout
    st    = status
    subup = submodule update --recursive --init
    pull  = pull --ff-only
    hub   = !hub
    flow  = !git-flow
It's a relative import.
You actually tried running salt with this relative import right?  ;)

--
Pedro Algarvio

----- Reply message -----
De: "David Boucha" <notifications@github.com>
Para: "saltstack/salt" <salt@noreply.github.com>
Assunto: [salt] Add runtime check for systemd (#2819)
Data: qui, Dez 6, 2012 16:17
In salt/modules/debian_service.py: 
> @@ -8,13 +8,14 @@ 
>   
>  # Import Python libs 
>  import salt.utils 
> +from .systemd import _sd_booted 

Is the dot before systemd there intentionally? 


&mdash;

Reply to this email directly or view it on GitHub.
I wanted to be able to stop waiting and then run other commands. Without this I think subsequent commands would see messages intended for the waiter (as they're both multiplexed on the same socket). Now I think harder, this solution is a little racey, but it should be fixable.
Remove this block and add apache2 header
Should be a var
do you mean sending the manifest in the second parameter? for my is ok!
Per http://www.w3.org/TR/sparql11-query/#sparqlSolutions , I'm tempted to call them Solution and Solutions.
If there’s no email address of the author available, then you can use this form:

```ruby
s.author = 'Shaun Harrison'
```
We should not be adding the results to TreeSet here, because the order of commitPaths will change. We should just traverse the commitPaths and check the paths are in oder
It's amazing how much can be done with multiple dispatch. The promotion system being an obvious, prominent example. So much time has been spend studying single dispatch oo patterns, so little has been spend on multiple dispatch. It feels like such a wide open area!
@jlsherrill yes, I can make that change. I'm wondering if I should go ahead and do that for content view def as well.
I typically start phrase descriptions lower-cased. Is that unusual?
yes, I would prefer that. But I'm not sure that can be easily achieved within individual views in an app. Any ideas?
@adrn @wkerzendorf @kbarbary @andycasey - since you reviewed this before, do you have any thoughts on @eteq's suggestion to use ``minus`` instead of ``subtract``?
ah, good point!
Yeah I'll take em out

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Thu, Nov 29, 2012 at 6:33 PM, zsherman <notifications@github.com> wrote:

> In app/helpers/videos_helper.rb:
>
> > @@ -1,2 +1,9 @@
> >  module VideosHelper
> > +  def bookmark_listing
> > +    return current_user.bookmark_listings.find_by_video_id(@video.id)
> > +  end
> > +
> > +  def bookmarked?
> > +    return bookmark_listing
> > +  end
>
> Also, do you think it's cleaner with ruby to just leave out the return?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/22/files#r2273350>.
>
>
Right, I've tested it. This works right for the proxy address, but not for the "proxy use" checkbox. OptionsModel::data confirms this; ProxyIP/ProxyPort query the actual state of the core with GetProxy, whereas ProxyUse and ProxySocksVersion return data from the settings (which may be "behind" the command line setting). This is indeed a bug.
Sure, it's never mandatory, but makes sense... all the other options are well-defined in themselves but a range is not.
"showing how to add"
Aha, I missed this.  You're suppressing the `EncShards` here, so your old code was actually correct.  I'd rather keep parity with the `ok` case and report them to the client.
意义不明，为什么要存在entryinfo这里面？
Please use `e3.base.Worker._handle_action_quit(self)`
This line could be a little clearer. How about:

```ruby
group.root? && (group.has_subgroups? || group.users_include?(current_user))
```

To achieve that, it'd need a couple of new methods on group, and users_include? would need to do the nil check.
kill_id
Can we not shove character attribute points together with roles/certificates? create a separate dict for those.
If we need this, then I think it's a sign that we still need to override `system.file`
I think we should briefly consider terminology here. For example, nose has the notion of a case and a suite (group of cases).  Naively I expected a test run to be one run of `iptest` with one version of Python.

I'm okay with calling this TestRun, but I expect in the future that we might want to try specific pull requests with a specific version of python.  (Or, more likely, run the different Python tests in parallel.)
Not sure I follow. I chose test.aws-ec2.endpoint because that exactly matches the structure of properties used in BaseContextLiveTest. Do you really want it to be different from that?

Also, where do you envisage this live test ending up? Will it be moved to BaseComputeServiceLiveTest once `overthere` is moved out of labs? Or will it stay in the `overthere` module, which thus requires an explicit test dependency in its pom on one or more providers?

I'm guessing the test will move to BaseComputeServiceLiveTest so I think we should leave the properties names as they are.

Thoughts?
Also fixed the `jake test:init` command.
you are right. i had to restructure it and then moved on once I got a passing test without adding back all the checks.
Total nit, but can't you just do `20px 30px;` here and `10px 0;` above?
I think you want to merge in Sidekiq::Worker::DEFAULT_OPTIONS if a class is not given.
Param on next line
rm this line
guzzle/http requires guzzle/parser; should we be requiring it as well?
# bing a ling
onKernelRequest to set a response header ? this is wrong. It has to be done on kernel.response to be able to access the response.
You duplicated this line.
@arnaud-lb Thsi is not equivalent. If you want an equivalent, ``addRoute`` should not support receiving a collection but only a route
why is it needed? this PR is not even against master :)
The pattern for the Min constraint should be added here as well (with LOW_CONFIDENCE).
You have this working now right?
Indent seems broken here, please check that you only use spaces and no tabs.
@lgritz, @fpsunflower sure guys you can use the swirl image if you please.  I made that texture and swirl warping especially for testing this kind of thing, so I'm super happy for it to be reused.  That's if you still need it of course... (I only saw this month old comment by accident when sifting through old email.  Note that you can get people's attention on github by "@mentioning" them via username).
Obviously that simplifies:

```srs = getattr(factory, 'crs', self.projection)```

This does concern me a little, but I think that is because all of the other things which expose this interface have a fixed crs, whereas a WMS does not.
You should remove the unused parameters.
I'm aware that fields that may be added later on will not be rendered, but since we are working in a custom tpl file and changes the way things are render in relation to the choices made in the UI it don't think it's an issue.
default for width: 100%... 400px height is a reasonable default as well.
If you can't open this file for write (like if the directory doesn't exist) the error message won't include the filename (thanks, stdlib!).
this will be run for every single request, and thus needs to be very fast. Did you check the speed of getmtime compared to `os.stat('file').st_mtime` for example?

Also, it will be more efficient not to ask for permission: just check the time and catch any file error instead of the `if`
There's no reason to set this on a read operation.
for consistency sake, shouldn't all these completeStep() with the no-op handler be replaced by stepCompleted()?
This looks a little heavy handed for a 2 buttons nav :)
Tottaly right, this was just a cheap way of knowing if we were in download mode, but can do better for sure. Lazyness was on me, will be solved ASAP
You may want to generate this dynamically instead of hardcoding it to app://settings.gaiamobile.org. There is no hardcoded protocol nor domain in Gaia.
same substantive comments here ... shorter names will be helpful as well
How are you suppose to access this page once you are already inside the contacts application?
Here is the link of the new AudioChannels API
https://wiki.mozilla.org/WebAPI/AudioChannels

And it says: "If two apps try to use the "content" channel at the same time, the foreground app wins. If both of the apps are background apps, then the last app to try to use the channel wins."

So I think the mechanism of AudioChannels should handle the condition you said correctly, or that should be a bug.
I tried using defer, but it unfortunately caused my code to miss the 'localized' event.  I'm not really clear on how that's possible, as it seems webapi.js only initiates the load on the DOMContentLoaded event, so there should be a strict ordering so this breakage should not be happening.  At least, if DOMContentLoaded is still fired after the deferred scripts are run...

I'm going to punt on this for now for that critical reason that it broke the code, especially because I suspect that much of any upside to using defer is probably mooted by the idiom we are using that invokes document.write to insert the webapi.js script tag.
If left and right are 7.5 each, shouldn't this be 15 rems here?
It's okay, that's why we need to review each other XD
no need for () around upwards
This is because how STK apps. should be answered, in some cases we need to inform asap while on other cases is when the user accepts confirmation or timeouts...
Generally one liner at the end of an else are weird. An early return sounds good in this case.

if (settings !== null) {
  callback(settings);
  return;
}

settings = deepCopy(DEFAULT_SETTINGS);
Do you want to use the |hidden| attribute instead?
Totally agree! Merge issue... My fault!
Note that I have simplify this into one `_loadingEventCount`. I don't think you need to track start and end separately (if they came in in correct order)
Yes, this is the defined purpose by UX, all DISPLAY_TEXT commands from the STK shall be showed as an alert
On 01/06/2012 04:29, Timothy Guan-tin Chien wrote:
>> @@ -0,0 +1,114 @@
>> +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- /
>> +/* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */
>> +
>> +'use strict';
>> +
>> +var ScreenManager = {
>> +  /*
>> +  * return the current screen status
>> +  * Must not multate directly - use toggleScreen/turnScreenOff/turnScreenOn.
> I would avoid Mozilla-specific getter.

Make sense.

> Besides, given the fact we impose peer review in Gaia and System app, the chance of being mess up is little.

That's not a good reason, reviewers can't remember everything and this 
is something that is unclear. Let's create a isScreenEnabled() method in 
this case and then you will make sure nobody will touch it directly.
No need for bind in the 3 callbacks.

Also you may want to do a |var feedback = UIManager.simImportFeedback;| and use feedback.innerHTML = .... in your callbacks.
I have added 1.4rem for the birthday as suggested by @basiclines . I hope this can be landed now.
coding style:
```css
#secondhand {
  stroke-width: 0.08rem;
  stroke: #00abcd;
}
```
Why not release in a finally like before?
I like "(default: 10)".
Yep.  I felt like a bare false doesn't communicate much. 

Do you have a better idea?
Oh, good point. Will do that... and actually, we should probably rename this class to something more descriptive than `ModalUnloadBlocker`, since that's not at all what it's doing anymore. Maybe something like `BeforeUnloadManager` or something.
please add a comment as to why crossWithTiny doesn't work.
You can do `input(checked)`, you just can't do `+inputMixin(checked)` because it will think `checked` is a variable.  You would need to do `+inputMixin()(checked)`.
Add an Args section.
No because it is how we get the table abstraction from cassandra. I'll make that point in the description.
Yes, replace `a = hcat(df, dfs)` with `a = hcat(df, dfs...)` in line 527 below. (I prefer using the name `cbind`, but it doesn't matter because they do the same thing.)
Perhaps clarify that this intended for usage from node.  Might be worth a subtitle.  I'd also recommend including the child_process invocation as part of the example.
Oh, I see what you mean. Since it's only relevant during the API call, I'll just add it there.
Yes this will leak, unless its explicitly freed before props goes out of scope.
Maybe you realized this, given that it's commented, but this is already included from the global Astropy doc configuration file.
`describe` is supposed to return a list of words, so you don't need/want a space at the end here.
```irc
2012-05-07 19:08:06 <glyph> Twisted actually has a few in-memory versions of things, in twisted.test.proto_helpers (the _one_ public module in our test suite, although it really shouldn't be in the test suite at all)
```
But, if `MemoryReactor` doesn't implement enough, that that doesn't matter. Mostly this is my knee-jerk reaction to seeing mocks.
misplaced bactick. ``by`` should be outside it
Missing empty line before `return` statement.
This is not clear IMO. The package array contain this fields, but the return array is an array of package arrays
hmm. that is a little bit weird
I don't remember ever having to do anything like this.  Have you looked at how this was handled before the newlib->glibc transition?
モデル、あるいはモデルのリストをセットに追加する。**silent**を指定すれば
Было бы лучше подключить через https://github.com/rweng/underscore-rails/blob/master/vendor/assets/javascripts/underscore.js но он давно не обновлялся...
this method already exists in application_controller. Am I right?
Is it possible that cert == NULL?
Note that the argument is simply ```output_dest```, not ```--output-dest``` (i.e. it is an positional argument, not a command line switch). This is what may have caused the confusion.

My intention was to implement ```output_dest``` as an optional positional argument so that you could just say something like:

```
nbconvert.py INFILE OUTFILE
```

I find this slightly easier and more concise than having to write the clumsier:

```
nbconvert.py --output_dest=OUTFILE INFILE
```

Would you prefer me to convert the ```output_dest``` argument to ```--output-dest```? Or did I misunderstand your comment?
True, its not really needed in either case. It ends up being personally preference and I'm happy to use whichever idiom the codebase/authors prefer.
I think we need utility `getSelectedTab(rawWindow)`
I'm actually not worried about the privacy leak (although it's a good point to bring up), I'm worried about the security implications of exposing internal identifiers. That can bite you at some point. However, if we're only exposing the user_id to that specific user, it's not nearly the same risk, so I'm good to go.
This is a good suggestion to help keep the code maintainable.  Making this change.
why does this not jibe with the return values in client_methods?
could use 'else if'
spaces around /
You must care about the references for this field along the code of the class
Always returns FieldSet
then  `else` rather than `if`
This import is not needed. Can you fix this kind of thing in each occurrence on your PRs?
Re-added the `if (!$instance)` statement.
Let's just make this a Write-Host warning.  There will be times when we want to test changes that have been made that aren't yet committed.  For instance, making changes to the Package.ps1 script itself.
Why the extra line break here?
I've benched it, and this is actually faster: `key.toString().match(/^[0-9]+$/)`
tiny stylistic issue: no space after "function"
So from my first comment, the issue is that the _URL item for paginated parts could be done a number of ways. The master shows that even if you have `TAG_URL='foo/{slug}bar'` that based on the pagination.html template, you have to add the `bar` at the end in your template.

So this takes the same thing. Basically everything after `{slug}` is removed from the link, then the template is required to add back the `bar`.  So the behavior is the same as the master branch, it just also takes into account a non-default setting for TAG/CATEGORY/AUTHOR_URL settings.

So what I'm doing is finding the `{slug}` and removing everything after that.

TAG_URL Default for the tag `foo` gives me:
```
<a href=".././tag/foo2.html">&raquo;</a>
```
This because the template has:
```
<a href="{{ SITEURL }}/{{ page_name }}{{ articles_page.next_page_number() }}.html">&raquo;</a>
```

Now if I change my TAG_URL settings to `TAG_URL='allmytags/{slug}supercalifragilisticexpialidocious'`, this line finds the `{slug}` and returns:
```
.././allmytags/{slug}
```
So I would have to change my template to:
```
<a href="{{ SITEURL }}/{{ page_name }}{{ articles_page.next_page_number() }}supercalifragilisticexpialidocious">&raquo;</a>
```

Basically, it finds `{slug}` and removes everything after it. The reason I chose to do it this way is because it maintains compatibility with the current `simple` template's pagination approach. Hope I didn't over explain...
So begins the auto import of subs.
@lolautruche Why does it need to do a function call 2 times btw?
Ok, overlooked that it was from interface, ignore :)
One last remark for possible optimization:

Since a new location never has any children, we can maybe skip calling `getLocationChildCount` here?
$_SERVER['HTTPS'] wird nicht immer gesetzt. Siehe: http://stackoverflow.com/questions/1175096/how-to-find-out-if-you-are-using-https-without-serverhttps
These are implementation details, no need to expose these imho.
This function doesn't seem to be used. Let `configure()` handle this like it does now?
Assuming you mean " whats the different between `org.jboss.spec:jboss-javaee-6.0` and `org.jboss.bom:jboss-javaee-6.0-with-tools`", then the latter includes Arquillian, whilst the former is just Java EE.
It is not necessary to define basic reader methods if you've declared a `lazy_attr_reader`. This is precisely what `lazy_attr_reader` provides.
IIRC that trick just makes MySQL happy because it only uses 1 byte to store the length of the varchar, but I've never tested that.
nice catch, thnx! :)
Don't need the inner grouping parens.
This is good and it does the job. Have you considered just using the tuple as passed in (i.e., not converting it to a list and then reversing it), by appending the items to an empty string and then appending the base 'Mozilla Support' to the end?
Correction: CoverageAPI
I got used recently to a cool paradigm for extending standard library:

module List = struct
include List

let may_map =...
end

and then you can use List.may_map in your code :) If you use those functions, you certainly want to start by

open Stdlib

whereas I don't think that you want the (very Liq specific) functions of Utils to be at toplevel...
I was having a problem running db:migrate on travis based on the version in the schema, but I think it I can add it back and will do so.
django_compressor is really clever and rewrites the URL in the compressed CSS.  check out the current icons in the menu on air-dev (I've made you a superuser)
Or even just kill `project_tasks` and `sales_tasks` altogether and move them down here. when they're actually used.
Oh nice, forgot about this.
Yes, so that in the validate function, it can easily check if nothing was clicked and return the empty string.
Lol'd.
Ah, I see, you removed the `except: [:show]` part as you needed a `current_user` in `Conversation#show`. All good, but we can't rely on `current_user` being available as this might be publicly viewed.
Not sure about the wording here but we can work on that later.
As the eZURLAliasML uses the translation text as key, multiple languages may exist in the same DB record 
(lang_mask is used to identify them).
The main issue is is that setting a language always available flag to false CAN overwrite a previously set flag.
As far as I can tell, the simplest way around this is to save the (only) always available language in the end.
@clemherreman IMO it is not enough. What string prefix do you get when you use this method?
check close()
Corrected. Also added in the award_date default here.
could this possibly click a link, depending upon the screen resolution?
It is in scope, and I'm not sure you've understood my point. I'm not prepared to argue it though, and this will likely be unreliable once Browser ID is reintroduced but that can be fixed as and when. In my opinion we should not have superfluous code. If Browser ID is not being used, remove all code for it.
Wrong import, the correct one would be:
from pages.desktop.sorter import Sorter
Ok. I understand the intention...
But still doing this here will result in spectacular failures ;-)
Should be called only in a mode where the RC is actually used and valid (e.g. on receiving a new RC frame in manual mode)
If you're building a string literal, you probably want to either use implicit concatenation or `.join()`.
```python
foo = ('This is a string '
       'that spans multiple lines')
bar = ''.join([
        'And here is ',
        'another one.'])
```
Is this the same as the <@ operator?
I like that better, will submit new PR.
I think comments should always be an array if there was no error. Therefore, the comments check can probably go.
Should document the arguments of the callback function
Did you mean `image/bmp`?
Missing space between if and curly bracket
Ooops !
It means force_create_dir, Yes, see the v.to_file in it.
As an aside, I've made a change here based on my testing.

If i just put a plain string `file` as the image source, the url received is: `local://base_request.html/file`.

So this code will be more robust for checking for that problem path:

```
if (e.Request.Url.StartsWith("local://base_request.html/"))
    return null;
```
Um ... I guess you've made a habit out of using regular expressions for everything. :)

    $this->assertEquals(strpos($word_wrapped, "\n"), 73);
Такое свойство чревато тем, что вы в своём классе не сможете контролировать состояние массива. По умолчанию любое объявленное свойство - readwrite, то есть, для него создаётся и сеттер, и геттер. 

Если хочется, можно сделать приватную переменную, а свойство сделать readonly. Или же переписать сеттер таким образом, чтобы он ни коим образом не повлиял на выполняемые в классе методы, то есть, обратить всё себе на руку.
Надо сделать исправления
После я ещё раз все проверю и выставлю оценки. Снижать оценку нет смысла так как идея реализована верно.
Спасибо за ревью. Пофиксил.
В цикле неплохо было бы написать for (int i = 0; i < _DNA.count; ++i) {, это бы предало большей универсальности в использовании.
По условию задачи, нужно чтобы элемент обязательно мутировал.  Т.е @"A" не может мутировать в @"А".
Тут забавная штука на самом деле :)
В вашем варианте работать будет(не факт, что во всех случаях), а вот моем не работало, из-за того что делил, а потом умножал.
Код для примера выдаст разные результаты:
    int numberIndexesToReplace = (float)DNA_LEN / 100 * mutatePercent;
    int numberIndexesToReplace1 = DNA_LEN / 100 * mutatePercent;
    NSLog(@"%d", numberIndexesToReplace);
    NSLog(@"%d", numberIndexesToReplace1);

если деление и умножение поменять местами, то результат будет одинаков :)
Это питоновская привычка, при делении переводить числитель в float:
>>> 271 / 100 * 70
140
>>> 271 * 70 / 100
189
>>> 271.0 / 100 * 70
189.7
We're Unix people.  These are all LF, not CRLF.
Lb.next
They do work in character sets, but of course escaping them might be good practice.
Oh. Very yes.
> hmm.. while I like the idea, a problem with a sparse matrix is that it wouldn't be clear in what order the connections are in the output (unless we return idx, which makes having a matrix in the input pointless)

you're right. idx seems to be way to go. However maybe “pairs" or
"indices" is a more obvious name. Just thinking out loud ...
the final code seem too complicated to me for an example. I think there is 2 options:

- add functions to mne so this code becomes simple (function that transforms a cluster as stc, add methods to Label)
- make the minimum to save the clusters in one stc file.

for visualization you can add a few lines of mayavi to plot over the fsaverage low resolution mesh (ico 5) as in:

http://martinos.org/mne/auto_examples/plot_read_forward.html#example-plot-read-forward-py
Also, @rkmaddox suggested something that might make the plot clearer, too -- a 'gap_percentage' argument. This would default to 0% (or 10% or whatever looked best), and set the percentage of a label's plotting arc that wouldn't be filled in with color. In other words, if there were 36 labels to plot, each one would currently fill 10 degrees of arc. A `gap_percentage=0.2` would mean that one degree at each end of that arc would not be filled in with color, creating gaps between the plotted labels. Make sense?
pep8 :) line too long
please remove all unused files, and files that has nothing to do with the jobs feed.
I don't see how it is used... I only see it being set in StartModuleExcecutionListener.
Don't use special chars here like "/". It's not nicely converted to a method name. Say "...non blank description"
also add @should fail if there is no description

and test that it fails even if there are no descriptions at all
Same question?
I think there is too much distance between this line and the call sites of `parsing`. It’s not clear that the `error` parameter of the `parsing` method *must* contain two `%s` which will be replaced with the key and the error message, respectively.
In other words, there is an undesirable hidden coupling between the `.format()` call on this line and the `error` parameter content.

Maybe the third parameter of the `parsing` method should have type `(String, Exception) => String` instead of just `String` so the content of the `Left` could be computed locally?
schema is incomplete.
I tested it and it's fine
It's more legible to put this on multiple lines:

    passthru(sprintf(
                          'php "%s" cache:clear --env=%s --no-warmup',
                          __DIR__.'/console',
                          $_ENV['BOOTSTRAP_CLEAR_CACHE_ENV']
    ));
Standards.rst states that classes need a PHP doc block comment.
I had to roll my own logger, since Django uses a different logging module than scrapy. This interface allows us to use "getLogger" from anywhere (in scrapy or django), and it will log to both spiders and django.
Nope, it's just the number of fibers that touch two regions
actually it is lp.ring, not lp.K; fixed it.
i think @nateabele is referring to `require("foobar.php");` vs `require "foobar.php";` i think `require "foo" . (true ? "1" : "2") . ".php";` should be valid.
Why the nested with-unique calls?  Isn't this equivalent (and cleaner):

(with-unique [test-system "test-system" copied-test-system "copied-test-system"]
  ... )
I dont know exactly what `set upstream '@{upstream}'` does but this does not seem to work here.
`$upstream` needs to be something like `origin/master` here. 

I'm willing to fix this but I've no idea about what `set upstream '@{upstream}'` is meant to be...
temp_target is a file, not a dir, because it's returned by mkstemp. images.fetch writes to a single file, so temp_target will still be a file.
In this case u are right. The map translates our exceptions to webob exceptions so we don't have to inherit from them in all our exceptions. We can remove that inheritance in our exception and it'll still translate.

Sent from my digital shackles. 

On Mar 29, 2012, at 8:47 AM, Tim Simpson<reply@reply.github.com> wrote:

>> @@ -34,6 +34,7 @@ class BaseController(wsgi.Controller):
>>     exclude_attr = []
>>     exception_map = {
>>         webob.exc.HTTPUnprocessableEntity: [
>> +            exception.UnprocessableEntity,
> 
> I'm confused what this solved. If UnprocessableEntity is-a exc.HTTPUnprocessableEntity according to inheritance then why wouldn't this already work? The integration tests looking for the correct UnprocessableEntity status code are passing.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/48/files#r621055
You should still swap them. If getattr raises an exception, then the task will already be storing the current thread. Even though it will be garbage collected since its a WeakkeyDict it feels safer and cleaner to simply avoid storing the context until you get into the try block.
My fingers tripped over themselves a lot with this one. :)
Sorry, a map won't work, there can be many hash ids for the same server address.
True, forgot I did both of those, and put a try except around secrets import.  I say we put it in secrets.py just to be consistent, they are secret after all :)
I have used None as an alternative to 'default', 'neither' is used in the
'extend' argument which already existed and is nothing to do with my
code. Also, None is not surrounded by asterisks in any of the other
docstrings in colorbar.py, I thought it best to be consistent? Do I need to
change anything here?



On 14 March 2012 21:29, Benjamin Root <
reply@reply.github.com
> wrote:

> >      *extend*      [ 'neither' | 'both' | 'min' | 'max' ]
> >                    If not 'neither', make pointed end(s) for out-of-
> >                    range values.  These are set for a given colormap
> >                    using the colormap set_under and set_over methods.
> > +    *extendfrac*  [ 'default' | None | 'auto' | length | lengths ]
>
> In mpl, we use None as synonymous with default (typically from an
> rcparam).  I would get rid of the use of 'neither' and stick with None.
>  Also, in documentation, surround None with asterisks.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/matplotlib/matplotlib/pull/766/files#r560111
>
Scrap that. They are kwargs.
I was considering using that, but I wouldn't know if it's trustworthy or not.
`i`, `d`, and `dParts` have already been defined, since for loops do not start a new scope. You should put their declarations at the top of the containing function.
I really try to be patient with this class but I always get count of the base dev rules violated by it...

a) first of all, pls always use {} for if, each, ... it's ways to simply to make an error here otherwise
b) you define many references on the class but only sporadically use them within the methods (remember, high Cohesion, low coupling, ...)
c) can you try to separate the concerns in this class? it feels as if you mix various actions together
d) extract an interface; ETMTCP already indicates that there could also be other implementations; in addition mocking such a class (although there are no tests) is pretty hard ---> avoid it; 

pls completely rebuild this class; also give the jdoc a shot; "responses" as a jdoc is not really useful; better try to make the method names speaking; whom to you response to? Nail down the domain!
yeah, can you guys please, please please stop doing this and just fix your setups? Seems to work great for @eightysteele and myself.
Uncomment plugins. :)
You are correct, I added it for simmetry with element_end (which does do
stuff) in case there's ever common code we can "push up". I can remove it
with no harm if you prefer it.
El 03/05/2012 23:15, "Robert Bruce Park" <
reply@reply.github.com>
va escriure:

> >
> >      def element_start(self, name, attributes):
> > -        """Expat StartElementHandler.
> > +        """If the element is the start of a new track segment, create a
> new
> > +        polygon to keep its points. If it's a track point, start
> accumulating
> > +        its data."""
> > +        TrackFile.element_start(self, name, attributes)
>
> If I'm understanding this line correctly, you're calling the element_start
> method from the superclass, which is a nop that always returns False. This
> seems like it would hinder performance for no reason. Or am I missing
> something?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/robru/gottengeography/pull/48/files#r770933
>
Added a few success and fail messages.
I *think* the redirectTo403 is a bit misleading and that we should have a redirectTo401 page.
I can't think of a single endpoint that will output a 403.
Please be careful of the Sakai code style. Brackets should be on the line where the def is and method parameters shouldn't align but wrap with proper indentation.
one problem:
what value do i need to assign to CT_NEWTONSVM in machine.h . For now i have assigned it a random no.
same here - just use Poly
... and change the text to "Open original image", or "Show original image" or "Display original image", up to you... you are the English speaker ;-)
Blame eap. This was a copypasta job.
There is no need to spin to figure out the data size you need. From msdn:

```
If the buffer specified by lpData parameter is not large enough to hold the data, the function returns ERROR_MORE_DATA and stores the required buffer size in the variable pointed to by lpcbData. In this case, the contents of the lpData buffer are undefined.

If lpData is NULL, and lpcbData is non-NULL, the function returns ERROR_SUCCESS and stores the size of the data, in bytes, in the variable pointed to by lpcbData. This enables an application to determine the best way to allocate a buffer for the value's data.
```
By default, the way Travis executes phpunit means you don't get any useful info if/when it errors. See one of my earlier build attempts @ http://travis-ci.org/#!/swestcott/MinkSelenium2Driver/builds/1774421 for example
Behandeln wir das in einem eigenen Branch wenn das hier gemerged ist.
Sounds good. I guess the functionality is all tested above.
``` ruby
string :subdomain, :username, :branch 
password :password
```

This seems like it should work no?
When we set `--isolate` option we slightly change the behaviour of `--single` option. With isolation we do not care about how isolated tests will be split in the groups. It's only important that all tests matched in appropriate pattern should run in a single dedicated group.

Thereby all matched tests will be selected by `Grouper.isolated` method and there is no need to try search for matched tests one more time.

When `--isolate` option was not given, but `--single` was we able to mess matched tests with others and this code will do that.
Grouper.isolated will not be called in that case(because of [if statement](https://github.com/grosser/parallel_tests/pull/170/files#L6R35)). So, tests will not be filtered till this code will be launched.
Are you really using all 7 REST methods? if not, why not limit the routing options to just the ones that are actually being used by placing this instead:

    resources :movies, only: [:index]
I'm pretty certain this should be "file's" not "files/"
ok, I'll merge :D
Is this `if` really necessary? Is not this the same:

```
$.each(panels_with_dependencies[panel] || [], function (index, dependency) {
```
Please describe the regex above. For me to see that you understand it.
No, `li` should not be in this template. We can use the same tag in multiple places. Only `img` should be there.
`<br />` should be unnecessary. Style it with CSS. Use block content? Use `<ul>`/`<li>`?
Wouldn't it be better to use blur event here? Not click?
Space after `#`. Add it a bit higher, where other authentication URLs are.
>  But as some stations would be updated a few times in some period, and others never, we can't just take first 32 stations.

I don't understand this. Every time you will fetch data for a station you will update this field. Even if it has the same value as before. The idea of this field is to tell that data there is not stale, not obsolete. So if there is no change in the station, if everything is still as it was, and you check this, this is new information, now you know that even now the state of station is like that, so you update the field.

Anyway, you probably don't need to order by this field, you just limit by it (for example, query only documents from last 2 minutes) and order by distance. Then in Python you check if you have any duplicates and use only the newer one. And of course, you can do that also on the server side, what would be better but you probably don't have time for that.

One further improvement would be to fetch for last 10 minutes, and then check what is the most recent there, and if is older then 1 minute you display warning about stale data.

And one more improvement would be that if if there is data older than 10 minutes, you don't display status of the station, but just that there is a station.
Is `value="` really needed?
variable is not needed
1st argument `$providerKey` missing
what's the difference between blobs and records? why use 2 terms?
don't use the is operator to compare two strings, because 'is' compares objects not their values. 

To understand the rational, read http://stackoverflow.com/questions/1504717/python-vs-is-comparing-strings-is-fails-sometimes-why

Note that "server is not None" works because None is a *unique* immutable object, so if server would be None that would work
change "can" with "must"
if => elseif
Would be nice to have that available globally. Network just puts both gradients for example, would be good to do it similar.
Just like our other examples. Something to kind of explain what's going on and show how (and why) you'd use it. Doesn't have to be anything crazy. Something like the cancer example in Owen (1991) would work.
here neqs would be better
Yes it is needed for pre py2.3, see commit comment on https://github.com/clach04/python-markdown2/commit/0290a1e98c7d94623d37511e617efe3e070d3813
Does language selection of Google interface (as I understand) really influence also the search results. Is there a way to configure the results based on the location? Then we could configure user to configure this in her user profile? So language and Google results.
I'd rather add a version of applyShear in C++ that takes a Shear object and have that be the one we expose to python.  Then this could become simply:
```
self.SBProfile.applyShear(args[0])
```
Likewise, the next one would be just
```
self.SBProfile.applyShear(shear)
```
Aside from being slightly cleaner, it is also more efficient, since the C++ constructor that takes (g1,g2) actually does a calculation to convert to e1,e2 internally.  Likewise, the getters which are non-obviously being called here with `.g1`, `.g2` do a calculation to convert back from e1,e2.
I've not pushed an edit for this point, as it's somewhat more debatable I think (for one thing, it demonstrates using the Poisson noise model).

However, the code I'd advocate as a replacement would be something like:
```
# We then add Poisson noise to the image.  This means that there is a small excess due to the Poisson noise in the 
# original photon-shot image, however we limited this to have a variance <= sky_level_pix / 100 using the noise= keyword.
phot_image += sky_level_pixel
phot_image.addNoise(galsim.CCDNoise(rng))
phot_image -= sky_level_pixel
```
even better, use `curl -LO` then we don't need to repeat the name (we should use that pattern everywhere i think, to simplify)
i Dont think the performance is a deal breaker here.

but the point of this test is to demonstrate that we can run same code on 3 frameworks. 
if we do if(platform == 'browser') technically we are writing different sets of codes
This should be a case statement instead if, elseif, elseif..
I think you should just leave this const and use a local variable for indentation down below.
Pode cre, foi mal rs
Yes, do we explicitly want it though, or is it a case of "it was there before, why isn't it now"?
a generic function to do response.writeHead and response,end will be clear most of the code below
Yes please do. If we wanted it we could put it back.
This one goes through all changed java files using HG manifest and creates
.patch files for each of them. Can we use diff on folders and subfolders ?
On 29 Jun 2012 09:48, "Richard Warburton" <
reply@reply.github.com>
wrote:

> > @@ -1,5 +1,29 @@
> >  #!/bin/bash
> >
> > +#
> > +# createPatches.sh - generates one or more .patch files from the
> changed .java files in the local mercurial repository.
>
> isn't this what the diff command does?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AdoptOpenJDK/BuildHelpers/pull/9/files#r1074575
>
``->addDefaultsIfNotSet()`` should be indented at the same level as ``children`` as it is on the array node, not on a sibling
This one test is broken right now-- I wasn't sure if it was safe to assume if there was going to be a configured conductor instance running or not for cuke tests or not.  Is it?
it doesn't, i was just testing.  will change it to hash
We've got crossed wires somewhere - sorry.

The google specific stuff is in authorize().

We could create an  function called authorize_params() that returns an array of additional params that override $params.
I'm not too keen on this, but it is *a* solution.

```
$params = array(....);

$params += $this->authorize_params();

 $url = $this->url_authorize().'?'.http_build_query($params);
```

in google.php:
```
public function authorize_params()
{
return array('access_type' => 'offline', 'approval_prompt'=>'force');
}
```
Not sure we need a jboss-web.xml at all.
Another question :-)
- would it be more prudent to break this into two methods; <code>def address_field_one(self, address)</code> and <code>address_field_two(self, address)</code>?
- a legitimate test would be to test the boundary conditions of these fields. Test cases should be allowed to attempt to enter > 255 characters.
I would change this to read:

    # We have to first login to paypal developer to access the paypall sandbox.
    # This is done to mimic a realistic workflow.
But certainly you have made a lot of changes to this file that are wrong
Don't worry about it ;)
I was a little afraid it was me being dense *g*
Could this be more specific? Despite my knowing vaguely what an RBM is and what it would be useful for, I've never encountered this term so I wouldn't know where to start setting it. Unless I go read the reference first.
Using numpy array might be  better instead of a list as in the gradient tree boosting module.
Benchmarking is surely needed before making this change.

@pprett In the module ``sklearn.gradient_tree_boosting`, why have you used   for instance   `self.estimators_ = np.empty((0, 0), dtype=np.object)` instead of a list?
Should this have a capital letter "M"?
This function makes my fudge-sense tingle.  You either need to do searches in the correct scope, or don't do them at all.  They should work for one-letter identifiers, there should be no possibility of matching the wrong symbol.
This should use `deprecation` instead of `error`.
This will be addressed in a later patch.
removed checking of container against nullness, since it should exist
the jira says to use --device_password
I'm sure this worked. I have since realised that this regex doesn't work in `parseAccessToken` and was about to apply a fix for that. I can't imagine why this wouldn't work for a URL though.

I'll test this later tonight as facebook is blocked in my office.
Maybe you're right, since I installed it manually due to the error that said "no redcarpet to require". 
Probably if I required rubygems from the beginning, I could have skipped that step.
I'd love to use this in the unittests... Can this be somewhere more common?
I take it we'll always use inotify on Linux. Makes sense if all our supported platforms have the module compiled in the kernel (all post-2005 releases should be fine).
Surely this must always be true.  Should this be an assert instead?
Looks like it does not, need to dig into that and fix
``master-dev`` is not a version that could be returned by the VersionParser so the example is a bad one
replacing "rules" in-place like this is a little bit confusing. You might consider having the first loop populate an `algorithms` table instead of `rules`, then have the second loop read from `algorithms` and assign to `rules`.
Using "set -e" to do this instead.
Remove this. This is provided by the basePage
Make it generic if possible
Magic Number!
@christianv Oops, done.
OTOH, no external dependencies. I suppose this is less of a big deal when using Maven, though.
`.forEach(function(`
Would this be better as `Set` operations?
With conserved_memory set we only store one image's worth of data, so we can't just copy a slice.  We can when conserved_memory is False.
Indentation (or GitHub, again)
message should be human readable and translated, right?
不过还是『用coffee用coffee用coffee』
Why does this function need to exist?  It just seems like an extra layer for no real reason.  If someone already has an eventSource instance, they should just call `addEventListner` themselves.
Does this check need to account for `_borderWidthInPixels`?
少了个空格
Use FirstOrDefault instead of try/catch.
Not sure I understand what you mean, could you explain a little more what you have in mind?
should this be using `getManualMode()` ?
These methods are tied to the ViewControllers `view(Will/Did)(Appear/Disappear)` calls. They are always initiated from the TiUIWindow class.
not needed given that it's followed by release
I just looked at the wikipedia page, and it is at least 5 densely packed typewritten pages of information loosely related to endianness, including history, etymology, systems supporting thus or such endianness, a how-to section on addressing registers, almost none of which relates to this doc.

I'll try and write up a few words instead.
Please also modify Kitchen-Nook if applicable. I believe KS-Nook has camera tests as well.
This not HTML! ">" must be written as "&gt;".

Also, here and some other places, the operator formatting isn't PEP8. We need spaces between binops.
thanks very much for the explanation.
Yes the line number is in the node attributes array. I meant to put that in the commit message, i.e. "including comments and line number", but missed it.
Couldn't you just wrap it all in one check to see if console is undefined?
странно у тебя, что-то в $, что-то нет
я бы вообще ничего в $ не клал, это ж может быть чужой жекуерь