labofsahil/github-event-dataset-2012 huggingface dataset:
ohai. Why are you extending `$!` as opposed to just `e`. That would absolve the thread-safety issues.

Also, `Errno::EPIPE` is a `StandardError`, so you don't need to rescue both. You don't even need to specify an exception class, `StandardError` is assumed if you don't.

``` ruby
rescue => e
  if e.class == OpenSSL::SSL::SSLError && e.message =~ /certificate expired/i
    e.extend(CertificateExpiredError)
    raise
  end
```
easter egg? ;)
Okay, what this ````#exists?```` normally does it will try to locate an element with specified locators by increasing index. If that element is not found, then it will break out of the loop since that means there's no more matching controls.

Can't you do something similar? Instead of doing ````data_item_exists_by_index````, can't you do something like ````match_all_locators? data_items[locators[:index]]````?
```steel_slist_node_t *elem``` should be ```steel_slist_node_t *node```
at least, this is nothing what should block this pull request.
Is "packages/mr" (extra "s") and "package/q" intentional?
wont this do the trick ?

```js
XPCNativeWrapper.unwrap(obj).toString.bind(obj.valueOf(UNWRAP_ACCESS_KEY))
```
It would be cool to add a comment about that feature/behavior in Loader construstor comment.
Or at least, keep it in mind for loader documentation file!
@ozten - I totally agree with you here.  The 620 and 505 are "magic" numbers that make the main site header look reasonable.  When the window reaches ~620 width, the right hand menu starts to drop below the left hand Persona icon.  Unless the menu is centered when the drop happens, it looks terrible.  505 is about the width where the centered menu becomes too wide and fills two lines, at this point I shrink the text, shrink the logo, and try to make things look appropriate again. - this comment would make good documentation in the CSS.
I would say 'removes the entry from the first write'
@joshcooper I checked these in my solaris box, these are the results:

    1.$ puppet resource zone
    => self[:ensure] == :running, provider.get(:ensure) == :running/:configured
   ... (repeats for all zones)
    2.$ puppet resource zone existingzone
    => self[:ensure] == :running, provider.get(:ensure) == :running/:configured
    ... (repeats for all zones)
    3.$ puppet resource zone nonexistingzone
     ... (self[:ensure] == :running, provider.get(:ensure) == :running/:configured etc) for all zones present
    => self[:name] == nonexistingzone, self[:ensure] == nil, provider.get(:ensure) == :absent

    4.$ puppet apply <noensure>.cfg (with existing zone)
    => self[:name] == existingzone, self[:ensure] == :running, provider.get(:ensure) == :absent
    5.$ puppet apply <noensure>.cfg (with non existing zone)
    => self[:name] == nonexistingzone, self[:ensure] == :running, provider.get(:ensure) == :absent

    6.$ puppet apply <ensure="absent">.cfg
    => self[:name] == myzone, self[:ensure] == "absent", provider.get(:ensure) == :absent
    7.$ puppet apply <ensure="present">.cfg
    => self[:name] == myzone, self[:ensure] == "present", provider.get(:ensure) == :absent
I lost the original comment from andy while amending. He commented that 

"If this `'-'` is just the sentinel value to communicate the missing parameter between these two methods, then this should be pulled out as a constant named something like `PARAMETER_NOT_AVAILABLE`.
If it means something else, then something named to communicate that other purpose would help a lot."

The original was just '-' in its place.
Gotcha...was trying to match existing style.

One other question, would you like an update to the 1.9 spec as well? Currently it passes under 2.0 because when `obj.to_str` is called it returns `nil`, so `String#<=>` jumps to the next option which is `obj.<=>("abc")`. If we change `obj.stub!(:to_str)` to `obj.should_receive(:to_str).and_return("aaa")`, then it would pass under 1.9 and fail under 2.0.
Why was this if statement removed?
comment should read 'Panpot', same with LSB line below
i'm ok with this as a general idea, but we need to make sure that none of the implementations assume that this is immutable without a concrete backing implementation. i'd suggesting highlighting this in the trait doc, and adding an example mutable implementation to test the code with.
I moved these to the development group so that the production server would not need them.  Asset compilation is now done on the deployment server, not the production server.
Please more documentation what this method should do. It is not much clear and name doesn't explain it.
No, it's php_soap extension constant (http://php.net/manual/en/soap.constants.php)
coding standards - put the else on the same line as the closing brackets and check indentations of all your lines please
`@param bool $allowAdd`
Make a comment that $adapterOptions will only be used on putting $adapter
I like this, it's a simple workaround but it makes things a lot better.
Please remove test-unit and use RSpec instead
note: it makes more sense to register the connector on instantiation -- that way, start() and stop() are logically simpler (it seems too tricky to unregister the connector on stop)
@anti yhtiö joiniin
Mielestäni uusi muutos olis parempi.
y u no comma separate?
nvm, forget it. I got confused by the variable naming. You should probably rename the ``$exception`` variable which does not contain an exception byt a boolean. What do you think about ``$catchException`` ?
What do you mean? The bag converter creates the Bag object and adds tuples to it. What else would you expect there?
Headers will be a useful channel for passing info, some of which will be relayed from the user through Kuma. Content could possibly change based on things expressed in headers such as:

* whether the user is logged in, and their name (eg. x-kumascript-var-username: lorchard);
* other kumascript vars passed from kuma via x-kumascript-var-* headers, but I can't think of any;
* whether or not error reporting is turned on (if we ever made it switchable, x-firelogger: 1.2);
You've got totally the right logic. Try this though

```python
with open(os.path.join(os.path.dirname(__file__), 'profile-photo.jpg') as f:
    r = self.mozillian_client.post(reverse('profile.edit'),
                                                 dict(last_name='Needsa', photo=f))
```

This ensures that the file gets closed no matter what. (I'm guessing you copied this from somewhere else in our code - i think it was done wrong there as well)
I think we should clean-up so we don't risk repeated events firing and running our code more than once.

popcorn.on( "play", function playHandler( event ) {
  this.off( "play", playHandler );
  playCounter++
  this.pause();
} );
Why does it need to inherit from anything?
I doublechecked it and it seems like no scaling needed. Lines where removed from the code. I'll push the changes later today when i looked into getting a better top-vector (forgot to do that before the pull request :-( ).
I just want to verify that we definitely want User.find, not User.find_by_slug
This should be moved above last released version ```## 0.1.34 / 2012-12-06```
is this the same sorting as in the controller? or does it being ignored?
hmm.. shouldnt this be @trend = ?
Rather than using the module callback in inserting this should be done in the resource callback. Take a look at the package-config plugin for a simplified version of this impl.
So exactly why couldn't you call get here first and then uninstall the result?
You should probably also check the `file_references` list before creating a new `PBXFileReference`. E.g.:

```ruby
file = (files + file_references).find { |file| file.path == path.to_s } || @project.files.new('path' => path.to_s)
```

Btw, can we rename `file_references` to `new_files`?
The value of `do_transfer_artifact` will be the value of the block in that call, which in cases of success of `push_artifact`, will be true. This line is redundant.
Dear Jordi,

as you may already imagine, my intention was to say "removes all queued actions of the queue". Thanks for your contribution :)
You don't need this anymore. The parent pom already contains it.
Ah, sorry for not responding sooner! I don't know how I missed your comment. Anyway, you are right--as far as I can tell, this has no effect. The cached property will be evaluated whenever it is accessed (I'm not sure where `supports_transactions` comes into play, but in the case of 1.5, the check no longer seems to be necessary.) I'll edit my patch tomorrow.
Leaking a global here; there's no need for this variable anyway.
Doesn't really matter, as long as it stays nice and clean.
How about defaulting to today for `to`?

    to  = req.query["to-date"] or now
Might be handy to mention here that it's okay to only test for `virtual?` because in this context, "virtual" == "exported but not collected". At least, I'd forgotten about that point when I saw the condition and was genuinely puzzled about what's going on. I could just be slow. :/
This code is just moved from the old location and I'm trying to minimize churn since it's been working so far.
So, I was trying to mimic postgres's directory permissions.  For the log dir they appeared to have a sticky bit set:

    root@pe-ubuntu-lucid:~# ls -ld /var/log/postgresql/
    drwxrwxr-t 2 root postgres 4096 2012-07-22 06:42 /var/log/postgresql/

I couldn't think of what the sticky bit would be for in this case so I decided not to set it--but I suppose 775 would make more sense than 774.  Thoughts?
typo: RESThub based applications
typo: to choose
A link also stores its link property in this CF, and now just does an additional SELECT to get it. Might be worth thinking about this as well.
Yea, futureproofing. It's not in the core code-base, but as a framework, it is still entirely possible for someone to want to index a content item, and want to offload fetching of the content to the index slave.
visibility should also default to a default value if not provided. This can then be a configuration value later on.
Can these 2 queries be batched up into 1?
callback is optional, this should be indicated. callback.err should be marked as optional as well then.
I see, it is needed indeed. The new jsdoc PR explains better, so this is fine by me.
From your comment, it looks like the actor needs to be stopped too.
Need to reformat this. Missing spaces at the end of the strings.
I accept this is not optimal and it would be better to decide if the scan can be stopped immediately, but the reason for the 20s is to ensure the background scanner still gets its 20s scanning (though admittedly its often unnecessary).

I did consider timestamping the start of the mux scan so I can stop straight away if possible, however for no this needs to remain. Can you revert for the PR.
haha! Was trying to stick to existing JS code formatting, I knew you'd notice the tab's, etc, you gonna reformat all the other existing JS code ;-)
But the template isn't parsed until Execute is called.
По-моему вариант проще:
- берем массив, длиной равной нашему массиву с буквами
- заполняем от 0 до длины-1
- берем случайный индекс в нем, мутируем этот элемент
- удаляем этот индекс

По сути то же, но выглядит проще. Но это уже так, просто идея
когда этот цикл завершится?
при 0 должна падать, при 100 не должна, этот поправил у себя
Это не улучшило положение :)
Not sure. Can check the documentation tomorrow.

On Thu, Nov 15, 2012 at 6:34 PM, Jeff McGee <notifications@github.com>wrote:

> In crawl.py:
>
> >
> >          cpid = os.fork()
> >          if cpid == 0:
> >              # child
> >              print "starting on %s"%filename
> > -            with open(filename,'w',1) as f:
> > -                store_tweets(config,f)
> > +
> > +            if compress:
> > +                with gzip.open(filename,'wb') as f:
>
> The uncompressed version uses line buffering so that when the SIGTERM
> happens, you don't lose a bunch of data. Does this lose tweets when SIGTERM
> kills the child process? Will you end up with a broken JSON file?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/JeffAMcGee/twitwatch/pull/1/files#r2147327>.
>
>
Chyba trochę popłynąłeś z opisem border-images. Dzięki CSS3 możemy w samym background-image dodać kilka o url(), czyli tzw. multiple background dzięki czemu jeden kontener może mieć kilka obrazków jako tło (link: http://www.css3.info/preview/multiple-backgrounds/).
Jeżeli chodzi border-images to trafniej było by gdybyś opisał to jako sposób ustawiania obrazków jako element obramowania, przykładem może być np ramka na zdjęcie. Link do info (http://www.css3.info/preview/border-image/)/
Should this explicitly _clear_ the current scheduler?

Either way, it seems like we could be clearer on this point (whether the current scheduler is inherited or not).
First nested block (^RACTuple *(void)).
This can use array subscripting syntax: `values[0]`
All functions should now look like this.
function(params) {
}
Guess I let myself get misled by the class_exists('redisent') call on top; that change fixed it so I errantly assumed it was correct.  In that case, there's some other issues with that file in general.

* There's no checking to ensure that Redis class actually exists before extending it, causing a confusing error in cases when it is not yet installed.
* That error also makes the class_exists() call on line 143 pointless, as it should always return true.
* Which also means that dynamic fallback to Redisent when PHPRedis isn't available is broken.

Since it's from upstream, it really shouldn't be edited in the first place, so not sure how to go about addressing this then.
Move your fork over top of where my repository would normally be so that the paths line up.
Let's drop this overload.
why not just use self.sources and self.mixing for both Raw and epochs? This would allow you to remove the sources parameter for sort_sources(), which I find a bit confusing.
hsp -= origin_head / 1e3  # convert to milimeters
switch the ordering here too even if dict are not ordered. it's for consistency
Add the following annotation:

<code>@Handler(supports = { ConceptMapType.class }, order = 50)</code>

This will enable looking up of this validator by core to be able to invoke it whenever a relation type is getting saved
It should say Test(expected=APIException.class)
result = results
This should be `// ...` (as you can read in the [documentation standards](http://symfony.com/doc/master/contributing/documentation/overview.html#standards))
This should be:

    $this->assertTrue(
        $client->getResponse()->headers->contains(
            'Content-Type',
            'application/json'
        )
    );
about .gitattributes believe me, i have been instructed by @Seldaek himself
其执行结果是
=>
最后，它
Actually, I'm confused about thoughtbot's current parentheses guidelines. The LevelUp one seemed more easily applicable codebase-wide, and it would say this is correct but 20 and 22 should drop parentheses.
@qiangxue named it renderItem() now, but had some problems with finding a name for the first parameter then which was `$rowAttributes`.
Since what I relay render here is an attribute, not an item I now renamed it to something neutral: `$options`. also not sure about parameter documentation with item/attribute since it is a part of the attribute array.
Think this one is now with the less possible amount of confusion, let me know what you think about it.
Пробел со звездочкой.
I think you mean to do something like this
(defn edit-system-environment [name environment]
  {:pre [(not (blank? environment))]}
  (navigate :named-systems-page {:system-name name})
  (browser click :system-environment)
  (browser check (locators/system-environment-checkbox environment))
  (browser click :save-inplace-edit))
```
or
```
(assert (not (blank? environment))) 
```

instead of the not-commonly-used :pre condition.
I think, that in this case it will not be possible. The problem is that we need to compare objects, not just Strings, if I use StringUtils.equals(this.getGeocode(),(QueueItem)obj.getGeocode()) I can cause some nullpointer exception or classcast exceptions. Is there any better approach, how to solve this ?
If you don't want TestNG to run this class as a test, you should remove the `@Test` annotation.
Just wondering, wouldn't it be more type safe to return SuccessfulResponse?
used to...? :-)
I found a few solutions, but none seemed to work with Google Chrome 23.  My understanding is that Chrome no longer lets Javascript do this for understandable security reasons.
signature is not used
this is still in there?
Can this be a precondition instead?
@bp323 Can you add an extra line on each of the files where we get the following git error:

`\ No newline at end of file`
We check btree->checkpoint in the underlying wt_checkpoint() function, and relying on the test being in the worker function means that __wt_conn_btree_apply acts the same as __wt_meta_btree_apply, that is, it operates on anything that's not the meta-data file.
There are a bunch of WT_VERBOSE_VOID calls that should handle error returns.
Why is identifier not required for the message?
Noted, the next push should address this.
Quoting JP Slavinsky  
<reply@reply.github.com>:

>> @@ -424,7 +424,8 @@ def self.search(type, where, text, user)
>>        wscope = Question
>>      end
>>
>> -    wscope.where(:content.matches % query & :question_type.matches  
>> % tquery)
>> +    wtscope = wscope.where(:question_type.matches % tquery)
>> +    wtscope.where(:content.matches % query) |  
>> wscope.tagged_with(query, :any => true, :wild => true)
>
> How does this pipe operator work?  The first clause returns a  
> relation, the second an array.  What's the ruby reason that those  
> get combined?

It's hard to see from the email, but it seems to be just the or/set  
union operator.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lml/quadbase/pull/58/files#r497214
>
>
Why do you do this? What's wrong with defaulting to /tmp?
Are you sure you want to override the parameter ``$database``? This often makes code less readable.
Oh, I've already done that (and other things) earlier. It's better to revert wrong commits than to hold up the good ones :-)
As noted in the comment above it DirectoryIterator::getExtension was only introduced in PHP 5.3.6. Since some LTS server distributions ship with an older version of PHP 5.3 I didn't feel comfortable just changing that in a random pull request. All the other places we also use the substr() workaround.

Personally I'd be fine with raising the limit further, but we should be aware of the impact.
It was mostly to make it more robust to edge cases (and avoid having ghost highlighted pixels when you mouseout of the canvas).
I will try to fix them.

+1 for the previously
This could probably go another step, something like:

```
def _thumbnail_upload_path(instance, name):
    now = datetime.datetime.now()
    opts = instance._meta
    return '{app_label}/thumbs/{model_name}/{year}/{month}/{day}/{name}'.format(app_label=opts.app_label, model_name=opts.module_name, year=now.year, month=now.month, day=now.day, name=name)
```

and be used on all the models with thumbnails.
You won't actually get an exception if there's no evaluation with the given name, right? You'll just get nil in return.
Space before `(`.

Have you run this code? Because it is not `lenght` but `length`.

In general it is better:

```
if ($('#map-layers').length) {
```

Or even:

```
if ($('#map-layers')) {
```
And on how many Slovenian sites do they have list of currently online users in real-time?
We use alery only to inform the user about Ajax error. And you have it for "comment posted" feedback (which could be also `window.console.log`).
*limited to* -> *limited by*
Make it less transparent. Space before the value.
Double spaces. Space around `*`.
Hm, . somefile works for me

> echo 'echo "test ."' > test_source

> . ./test_source                   
test .

> zsh --version
zsh 4.3.15 (x86_64-apple-darwin11.2.0)
not using the configuration of DoctrineBundle would mean that you have to reimplement all services provided by DoctrineBundle when using this config.
But this is the main feature of this PR ;) You see real name of default connection or manager.
Should be filterBy (camelCase for PHP properties, underscore_separated for options in array).
there could be situation which could not be resolved only in the code (requires user interaction).
for exampple we have our registration logic and openId. one user can create an account with email `superuser@example.com`

and the other user can try to login via openId with that same email. I am think of displaying a form where user can prove\validate\change his credentials.

The other case: We can situatuin when to create a user we have to set several fields (email, first\last names and so on). Some of them can be provided by openid provider (but not all can do that) so we have to display form again with preset values from openid provider.

I dont find a good solution to solve such situations
How do we feel about using the namespace "wikipedia" instead of "dbpedia"?
found it. Just realized i should have only look at the above line. Such typos are hard to find even after X reads ;)
I suspect you mean the opposite: "Forward a result to all registered observers".
sry, I said it wrong... what I meant was: do you want to provide a quite general eventHandler or should there be some specific events via this mix-in
Maybe something like cls.ResourceManagerData
Lots of single letter variable names here, I have no idea what they mean.
Missing addConsoleMessage() like in the else case to indicate in the log window which port we are listening on.
scipy just got an improvement in a similar case, where the bounds are automatically shifted if they don't have different signs
Sure, I'm not proposing moving everything/anything to OLS results really, but I don't think ELLinReg should do any estimation - the way I thought it was set up was that it is an estimator - ie., EL with a simple mean . We already have a streamlined framework for fitting OLS models, with general data and argument handling. Right now, a lot of this just re-implements that. 

Even if you just want to have ELLinReg subclass OLS then return a separate Results instance that would be cleaner I think. This mixes up estimation and inference, where so far we have a pretty strong wall between the two in that they're two objects, subclassing from Model and Results
а не. их не объединить см https://github.com/uploadcare/pyuploadcare/blob/ecaaa8486cf4569fc6c5a27f9c7859c25bc36ca6/pyuploadcare/dj/conf.py
It has been done in Common 2.3 (Selectable cannot be done in an ORM release as it is not part of the ORM)
不编译rewrite模块。该模块允许HTTP服务器重定向请求，改变请求的URI地址。
Here is one of the possible solutions (if anyone has time to implement it): http://stackoverflow.com/questions/4664724/distributing-django-projects-with-unique-secret-keys
Isn't here missing `url` call?
I think a chkconfig change shouldn't occur in a restart function.
Mix of tabs and spaces
I don't think I do that. I have lines that go ``getAttribute(SENSOR)`` and that's it. Will check and try again. What if I just duplicate the static final definition of the attribute/config but with a default value?
not called much so went with simpler code.  i think compilers might use string builder anyway ?
Indeed, right now I'm assuming that the APP argument provided by the user is the fully qualified classname. Any thoughts about changing that somehow?
Looks right, but just wanted to check that `createLink` is the right thing to use rather than `resource` (as suggested by the deprecation warning for `createLinkTo`).
So this is about HTML as well? Not only about css?
UI 요소 들에 대해 영어로 표기하셨는데 `팝업`, `토스트`, `버튼`, `다이얼로그`, `액션 버튼`, `슬라이더`, `텍스트 필드`, `체크 박스`, `라디오 버튼`, `타이틀`로 충분할 것 같습니다. :)
Yeah go ahead an merge it.. no problem
I think we should.  getElementsByTagName is efficient, so there is really no need to make these lookups lazy; the should just be done onload.

Also: this pattern (anti-pattern?) fails catastrophically if the getter is invoked before the element has been defined.
Sounds like the next best thing until we get method overloading in C.
What is this line? Have you tested your code?
window.addEventListener('load', function prepareMsgApplication() {
        Conversation.init();
        ConversationView.init();
      });

Basically I like to avoid bind as much as I can since it messed up the stack when you are debugging. So if I have to use it i use it but if I can do without it I don't use it.
Can you change this back to 4?  That saves ram on CC.
geez, that's awful

so what about this then?

```java
private static final String TAG = TheClassIMinto.class.getSimpleName();

// then on logger calls
Log.e(TAG, "hello error");
```

This is refactor-friendly
And then you'll get a hilarious unbound method error.
Do you know what the series of action that ActiveResource did when we weren't  eager loading subscriptions for the user?  Because it was unsubscribing correctly previously.
Надо проверять корректность тайм-зоны (что она существует).
Зачем здесь Assert, если ожидается, что тест выбросит исключение?
100% загрузка CPU в этом месте.
По этому исключению нельзя понять, что не так.
А зачем этот файл?
Извините, если дело в том, что вместе 4 пробелов стоит 2, то я думаю это проблема github-а, потому что в eclips-е это отображается как одна табуляция или 4 пробела...я не знаю как это исправить....
I was flabbergasted myself. But I just remember typhoeus' memoization and
that I should have disabled it. Rookie mistake, will update the code.
On Apr 19, 2012 7:10 PM, "Ilya Grigorik" <
reply@reply.github.com>
wrote:

> > -# | em-http-request              | 0.041866 |
> > -# +------------------------------+----------+
> > -# | Net::HTTP (persistent)       | 0.098379 |
> > -# +------------------------------+----------+
> > -# | Net::HTTP                    | 0.103786 |
> > -# +------------------------------+----------+
> > -# | RestClient                   | 0.111841 |
> > -# +------------------------------+----------+
> > -# | HTTParty                     | 0.118632 |
> > -# +------------------------------+----------+
> > -# | open-uri                     | 0.170172 |
> > -# +------------------------------+----------+
> > +#+------------------------------+-----------+
> > +#| tach                         | total     |
> > +#+------------------------------+-----------+
> > +#| Typhoeus                     | 0.005322  |
>
> That seems fishy. A little *too* fast? :)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/igrigorik/em-http-request/pull/188/files#r707898
>
Small nit, add a space after the <code>#</code>:
Example <code># We have to first login to paypal developer to access the paypal sandbox</code
Good point. I'll change it back to the author nomenclature.
This should already be contiguous, see line 62.
Minor things: not quite consistent with the code. (Actually it cannot be exact `0` and could be `1` if Y has duplicate lines)
Will hit the sack soon, too. (I don't like ScorerDecorator either ;).
I think we can get somewhere here :)

The ``AsScorer(fbeta_score, args=dict(beta=3))`` is a bit to verbose for me still. Maybe ``**kwargs``?

Good night!
Ok, I will remove `LabelEncoder`.
Two dead links. I guess you haven't given them labels?
``bias`` is the usual term in the community. before joining sklearn, I never heard the word ``intercept``.
Consistency with community or within sklearn is the question I guess ;)
Just a tiny style nit pick. I'd store this count in a plain old ``active_apids`` variable and wait until the end to construct the final apids dict  to use in json.dump.

This just makes the main code in a function a little more straight forward to read (no having to mentally remember what the ``apids`` dict looks like) and keeps all of the output-related functionality at the end in one place.
Yes, it exposes another bug.  I think 7581, and [this commit](https://github.com/yebblies/dmd/commit/ad068983d5976cb5dd2af83a6ed60a3f7d4b51ca)

IIRC it doesn't move the imaginary part correctly, because the non-complex path is taken.  Hence it's zero (sometimes).  The addition/subtraction problems may also be related.
Don't use rtti, use the methods in Object (something like `isExpression`/`isType`) to get an Expression, then check `e->op == TOKdotid` before doing a c-style cast.
created TIMOB-9656 jira task
code was removed
This line doesn't do anything because Signature#state is not accessible for mass assignment. It should be replaced with

```
@signature.state = "cancelled"
@signature.save
```
do we really need version numbers in there? doesn't look like very maintainable :(
This seems to be the main client for `GridHelper.getGridCellsIds`, and all it does on the Map is iterate in i. to do get operations on it.
Each get(i) is hiding an auto-box operation on each i > Integer, a hash code calculation and extraction from the Map.

This would be ok if we had to deal with a Map<Integer,V>, but it turns out the GridHelper.getGridCellsIds method is iterating as well on an incrementing `i` , autoboxing them all and doing a sequence of put operations.

It seems to me you actually should use an Array of strings?
could we change "goals :" to "goals:"
I guess since it's soapcall-related (even if not directly related to the timeout change) it's ok to keep it in here
Well, I should follow at least the indentation on the local area. That was copy&paste error.
How does that behave when ```IROWSTREAM_DEFINED``` is not defined?
This has been inlined into ```loadSubFiles()```
Why not replace `Windows%20NT` with `{{ os_name | urlencode }}` here?
I believe extracting the additional logic to this method into separate methods would greatly improve overall readability.

Here is an example of how this might be accomplished:

```python
class SkipEntryException(exception)
    pass

def _get_dataset_description(entry):
    if entry.title:
        return entry.title
    else:
        if IngestOptions.ALLOW_UNNAMED_DATASETS:
            return IngestOptions.DEFAULT_UNNAMED_DATASET_TITLE
        else:
            raise SkipEntryException(
                "Skipping dataset. ALLOW_UNNAMED_DATASETS disabled, so ignoring unnamed dataset ({0}) for user {1}" % 
                (entry.id, user))


def process(entry):
    ...
    try:
        ...
        dataset_description = self._get_dataset_description(entry)
        ...
    except SkipEntryException, e:
        logging.getLogger(__name__).info(e.message)

```
`finish()` has to be called in `run()` not here. Reason is that other testruns will call `run_tests()` more than once. If we call finish here all the remaining results will not be added.
Actually I used this route only to manage the switch of language. I was not thinking to a general solution. The idea to use the lang as first parameter is correct, of course. I will refactor my PR to manage that. Thanks for the suggestion.
FYI, to properly use double-checked locking in Java5 the privileges variable should be volatile (ditto for the roles and users variables).

See http://jeremymanson.blogspot.com/2008/11/what-volatile-means-in-java.html for details.
no it is not right. It should be ``Composer\Test\Repository`` according to the place you put your class (PSR-0 FTW)
The original codebase relies on Beaker's PBKDF2 implementation.
The simple hashing that you are proposing makes the salted passwords vulnerable to brute-force reversing in case they were exposed.
I used new api parameter to exclude all replies, that's why did that.
I agree with @lsmith77 I think there's no need in this case since you are not dealing with user input anywhere there.
Please order and group imports to increase readability.
This change is not the recommended style. Stand-alone variables should not be included in quotes
Remove, please.
SAP*, DDIC are in all clients, rest is client dependant. Clients 000,001 and 066 always exist.

Default password usually found to be in new clients. In practice people usually reset for default clients (SAP*) anyway. Others not so much. Full list on website if you follow labs link.
I'm normally against large methods but if the reddwarf_auth_url was not changed and restored these five methods and two classes could become one method.
Can you use an underscore for the filename, e.g. "extension_interface.js".
isn't this supposed to read:

```python
if not url:
    redirect reverse(.....)
```
Also shouldn't it be the first thing after show
"if" instead of "is."
I'm suggesting that we not temporarily change the camera's frustum to a frustum that the actual camera does not represent because later code wants to use the camera's frustum for culling; instead, we introduce a separate frustum for culling that is, perhaps, most often a reference to the camera's frustum, but might be an off-center frustum for picking.

To answer your question, as I see it now, `pick` will go through a separate `update`/`render` iteration.  I suppose if the user knows they want to do a pick when they render the scene, we could forgo the extra `update`.  Each pass will have a different frustum (or volume in general) to cull against.  This is true for cube maps and shadow maps as well.  I'm suggesting that we start to set this up now.
Almost everywhere we were constructing an `Ellipsoid` we were creating a new `Cartersian3` just to pass and throw away, so I figured why not just have the constructor take the components directly.  Constructing is so rare that I don't really care, so I can just put back one constructor taking a Cartesian3 if you want; let me know.
Also, you are wrong about the argument list:

> -> % titanium create --platform=iphone --id=foo.bar --name=foo --type=module
Traceback (most recent call last):
File "/Users/stiv/Library/Application Support/Titanium/mobilesdk/osx/2.0.0/module/module.py", line 329, in <module>
main(sys.argv)
File "/Users/stiv/Library/Application Support/Titanium/mobilesdk/osx/2.0.0/module/module.py", line 326, in main
module = ModuleProject(config['platform'],project_dir,config)
File "/Users/stiv/Library/Application Support/Titanium/mobilesdk/osx/2.0.0/module/module.py", line 68, in __init__
self.copy_template_files(all_templates_dir)
File "/Users/stiv/Library/Application Support/Titanium/mobilesdk/osx/2.0.0/module/module.py", line 108, in copy_template_files
to_ = self.replace_tokens(to_)
File "/Users/stiv/Library/Application Support/Titanium/mobilesdk/osx/2.0.0/module/module.py", line 86, in replace_tokens
string = string.replace('__SDK_ROOT__',string.replace(os.path.split(sdk_dir)[0],os.path.expanduser('~'),'~',1))
TypeError: replace() takes at most 3 arguments (4 given)
Aborting
we should still check for more values than null though,  if the user does view.fireEvent('someEvent'), then data will be undefined
No need for this.

Also, indentation is screwed
I'd need to remove this duplication ;)
Why not just call `grunt lint qunit` here? No need for a separate task for the verbose flag, right?
what if already unliked?
Seems like it is a bad idea to use ``v`` in the definition of any of these equations. The rear wheel rate is the state variable, but ``v`` is an arbitrarily defined speed. Why do you use ``v``?
Similar to the `incr` comment, this should probably go before the var declarations.
I'm confused. Why not just change the signature of the prior method to just accept any class, instead of an OpenmrsObject subclass?

(Haven't read further down yet.)
"Dislike" is not the word. The problem is `asFlatStaticArray` is a self-serving abstraction: it helps this one function (thus helping the argument "it's practical") without being otherwise useful, and this function uses it (thus closing the circle).

I won't pull in a design I don't agree with just to be nice at the cost of creating more work down the road for everybody else. Showing that you are wrong is not the purpose of anyone working on this.
I agree that it's more direct. My main problem is that it will mean a performance hit in some use cases when that performance hit can be avoided by simply checking the predicate like is being done here. And while it may be a hackish way to check the predicate, I don't know of any way to check predicates for equality other than checking string predicates like this (except perhaps if functors are used). Certainly, you can't do it with lambdas.
missing a space after the brace
Just inline `toStore`, and you can discard the cast.
indent, again; is there some tab issue?
Some misplaced bracket at the end of this line, and a missing one after `unset` on the next line. Same goes for 92-93.
Why is this line changed anyway? There's nothing to rename on it.
Needs another tab here.
It seems odd to hard-code the namespace but not the issuer.
There were indeed a few recent-enough commits that likely did not make it into firefox-release yet that might changed the behavior as a consequence.
http://hg.mozilla.org/mozilla-central/filelog/22288130fea2/netwerk/mime/nsMIMEHeaderParamImpl.cpp

Indeed the official mozilla aurora build has the test passing.
I'd recommend to drop the test. I can live with this particular instance having different results on different platforms, and the other tests seem to cover other instances of corrupt hashes pretty well.
In what cases does `get_attribute` print an error? I thought it just returned 0 if the object or attribute was not found.
А здесь можно использовать
```ruby
if children_counter_cache_column
```
Can we break this up into multiple functions, so we don't exceed our 10 lines per function rule?
Айтем незакрытый.
Just to add my 2c - I think using a LiteralExpression internally (when configuring a value, or 'key' in this case) is very different from requiring a SpEL expression that returns a literal ("'foo'").

LiteralExpression is a very thin wrapper around a String. An expression that returns a literal is actually only a little more complex but, I agree that separate attributes is 'nicer'.

That said, the parsers are beginning to be littered with code like...

````java

		if (hasViewName) {
			RootBeanDefinition expressionDef = new RootBeanDefinition(LiteralExpression.class);
			expressionDef.getConstructorArgumentValues().addGenericArgumentValue(viewName);
			builder.addPropertyValue("viewExpression", expressionDef);
		}
		else if (hasViewExpression) {
			RootBeanDefinition expressionDef = new RootBeanDefinition(ExpressionFactoryBean.class);
			expressionDef.getConstructorArgumentValues().addGenericArgumentValue(viewExpression);
			builder.addPropertyValue("viewExpression", expressionDef);
		}
````

We should probably create a utility method and begin factoring these out.
So rather than having ```false``` as the default have: 
```
'default_db' => null,
'proxy_dir' => 'data/DoctrineMongoODMModule/Proxy'
``` 

That would require some logic in the module.config wouldn't it?

I'm not sure about the namespace.
But it would fix the problem for most people. If one looks further, adding the quotes here seems really bad, why is it "pre quoted" in this way?
reduce method complexity, e.g. extract while body / for loop body to methods.
actually the links were there but I'd not put brackets around the paragraph text!
comma (something tells me, we've been lacking consistency here all along ;))
After the fact, but this method doesn't return void.

http://php.net/manual/en/function.include.php

See example #5
What is the purpose of a scenario? We need a sentence to state the purpose of the code (to see if the integration works at the end of the Hackergarten)
Tämä ei nyt ollu tarkoituksena. Ei pisteitä.
A diff shows that almost everything in the original file is being overwritten, I've included the original file in the stylesheets folder but would like to keep the edited one as the one being loaded.
Used getMockBuilder to get it work.
see above on eventName
pull synapse client call (for preview) out of this widget
All mojos are designed to throw a MojoExecutionException or MojoFailureException (in their execute() method) on failures.
However what we do is to throw a RuntimeException (IllegalStateException) which is not caught and expect that it will be caught somewhere outside. Even though it works I don't think it is good design... From my perspective we should catch an IOException or whatever and throw a MojoFailureException in the mojos.

Anyway, if you still disagree I would also be fine with the current state... :)

Kind regards,
Alex
I would get the instance only in the ``guess`` method to make it lazily:

```php
<?php

public function guess($filePath)
{
    return MimeTypeGuesser::getInstance()->guess($filePath);
}
```
The image is resized here to fit into 220? Does Fife work on that? Otherwise I would suggest we roll our own implementation of an Image that does resizing for us, so we can specify the width in the XML file.
assert 11 < 13
instead of a print here, raise a ``ValueError`` as follows:

```
except ValueError, "Command failed ..."
```
On line 102  $rel is set: `$rel = $this->hlp->getPluginRelations($id);`  and next on line 115 _showMetaInfo() is called.  Because in _showMetaInfo() $rel['conflict']  is only read and added to $data['conflicts'], it makes imho sense that it reuse the $rel from _showData(), so i added the $rel argument. (i guess in a code refactoring $rel is lost.)
Ti/_/dom is never used. It can be removed.
You can replace the whole block by `if ( ![self.proxy _hasListeners:@"pinchangedragstate"])`. This will automatically check if parent proxies have the listener
You could go one step further and have:
var logToConsole = cordova.require("salesforce/util/logger").logToConsole;

Then just do logToConsole below.
feel free to describe your thoughts  :-)
MPL on all these files.
I'll also to a trim() in the previous line.
You must use `ugettext_lazy` on models.py.

Models are loaded **before** Django configures the i18n system with the language defined on settings.py. So if you don't use the lazy version your models will always be in english (Django's global default).
I believe those are either "integration" tests (if not, "system"). :-)

https://en.wikipedia.org/wiki/Integration_testing
The hash it's pointing to right now is the hash for the matching Framework pull req. When the Framework pull req gets merged, we can update the hash here.
If you want to use fsext, you should get rid of line 17. fsext is a replacement of fs
since you are not using JsonCpp - it doesn't need to be a part of cmake script
@abledaccess href="/" re-directs the click to the root directory rather than the fluid studios home directory, the same issue that was with "Login" and "Back" link. You would like to replace it with

href="<?php echo esc_url(get_home_url()); ?>"