labofsahil/github-event-dataset-2012 huggingface dataset:
It's not a big deal, I just feel like parenthesis would make it easier to understand at a glance.
Space after if please. Same below.
URL to where this is done the way you describe?

A quick grep of the tree suggests that $l_* variables store language text or language keys, which makes sense. You are using the variable to store a boolean and it therefore should have no l_ prefix.
The only autoloaders I see are in bootstrap.php. They cover mock classes, which points to the tests/mock/ directory, extension classes, which points to the phpBB/ext/ directory, and core phpBB classes with points to the phpBB/includes/ directory. However, the classes I am attempting to load are in tests/controller/ext/, which is not covered by the above cases.
How did we gain this space?
Then I don't understand why I am being argued with?
This is a new sentence and should be capitalized.
There is a PR to make db classes autoloadable that might affect this line.
Quite a few of these keys are optional, so you should check if the even exist.
Not sure what is wrong with using `.focus()` on a button click. As long as you're not using it on page load, it shouldn't be too annoying / disorientating.
I think you could juse move the string from ucp to common.
else if on new line. same below
url to where that was claimed as the fix?
probably "% reported PM" like you did with posts and topics would be better for consistency.
Where is the wiki page for events?

There definitely should be an event here to add new information blocks.
leading indent is off
These instructions are fine for now but we will probably need to do something specific for each platform.
Don't use CamelCase, it's not our code style. Replace with `set_dibs`
call it dash, because that's the route right now
Долой style
Still needs fixing.
"Cutom Camera" alert! =)
Let’s rename to ID\Caching\CacheFactory
Style: Prefer that you name this "Observations" (or whatever the exact openMrs name is). Avoid acronyms -- It's more clear and easily understandable to new coders trying to get up to speed on the code.
Need a JIRA ticket which tracks these todos. You can use an existing ticket, create a new sub-task in an existing ticket, or create a new ticket altogether (depending on size of the work)... 
In the Code, write TODO and copy a link to the ticket which corresponds to this work
每个图都继承了事件类。具备`on`、`fire`等方法，用于组件对外传递数据。如果只是设置对象，并未侦听，用set代替这里的on吧。
The reason I check for the string "Ordered" rather than using isinstance is that we need to accept either python25.OrderedDict or collections.OrderedDict
Whenever possible, use ``models.ForeignKey(ConcreteClass)`` instead of ``models.ForeignKey("ClassNameAsString")``. The former forces a more natural order of classes, the latter is meant as a workaround for import cycles.
This is not necessary. Simply merge #228.
this is overindentation (3 spaces)
Well, that is a good question :) Maybe something along these lines:

deprecation reason: the permalink is deprecated, use get_absolute_url with reverse instead.

In early versions of Django there wasn't an easy way to use URLs defined in URLconf file inside get_absolute_url(). That meant you would need to define the URL both in URLConf and get_absolute_url(). Permalink was added to overcome this DRY principle violation. There is no reason to use permalink any more.

the actual docs for permalink here...

We should still have docs for the decorator until it is deprecated. The docs are a little verbose, but I don't see anything which must be reworded there...
I don't think brackets are needed here for the `class` directive.
Quote is misaligned by one character.
Can you please split these tests into separate cases for the things we're actually checking? The one sentence describing this block doesn't cover our tests here.
It's better to call `uenum_next` until it returns `nil`. [`uenum_count`](http://icu-project.org/apiref/icu4c/uenum_8h.html) "can be very expensive. ... Use with caution and only when necessary."
I see I've forgotten `static` keyword here. Do you mean moving from c-style singleton modules to classes? I think if to do it, it should be done for every module. In other way, I didn't have any troubles with it except this https://github.com/jckarter/clay/blob/master/compiler/codegen.cpp#L7209 global-ctors hack after your explanation
You could try changing `X` to `c` to check if the GZIP algo will better optimize the `c<d` part of the string - which is used several times throughout the minified jQuery 1.7.2 source.

</bikeshed>
Oh, I get it now, we should probably change how `Globals.register` and `Globals.cleanup` behave then.
If they are supposed to, Sizzle has a bug in handling positional selectors. :)
Links should be wrapped with brackets:

    <http://kohanframework.org/documentation>
I don't understand that comment. Could you rephrase that?
Ok. I will use ```OPERATOR(madlib.+)```. Thanks.
What about NULLIF()?
Also would it make sense to make a small local utility function for this try except? I see you use at least one other place in these changes.
I merged it now :-)
I'm less excited about querystrings key/value pairs because they can show up anywhere in the url and thus I think it's slightly harder to do metrics.

However, we don't have to make a whole bunch of entries in urls.py, though. We can just do a variable:

```
    url(r'feedback/(?P<formname>[\w-]*)/', 'feedback_router', name='feedback_router'),
```

Then have the formname override what we'd infer from the ua. I think that's the easy way to do this, but there are probably other ways, too.

This makes it easier for us to do development and also makes it possible for us to have in-product links that don't change ever and point exactly to what they should point at.
@jacknagel yes, for a lack of a better test, I define the CLT to be installed iff there is a `cc` and `make` in `/usr/bin`. So, strictly speaking this is semantically more like
- **"yes the standard unix tools are there at /usr/bin"**

and *not* like 
- **"The user has actually installed the 'Command Line Tools for Xcode'-package provided by Apple"**. 

The comment of @mxcl in the source code was "# probably a safe enough assumption", so I just took this stance, too.

I have changed the function name as you suggested. (commit comes later)
Hmm. Aren't we using the git tag so that we get the submodules, as the comment above suggests? AFAIK submodules aren't included in github-generated tarballs.
I think static went missing during some merging, it should still be in there :)
Si c'est unused, pourquoi ne pas simplement les supprimer?
Ok. will change
This construct is not intuitive. I suggest something like ``delete this._components[component]``.
Can you please tweak the indentation here to be consistent?
Thank you guys for these comments! I just bumped into the turkish i problem ( https://groups.google.com/d/topic/androidannotations/PeSJ2yPN0GE/discussion ), and if I hadn't read the article mentioned by @swankjesse I would have had no clue about what the hell was going on...
The `--verbose` parameter doesn't seem very useful currently. It just tells you what command you just ran, which you already know.

You can already make bash print each command it runs in a script, by using [the set builtin](http://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html): `set -x`.
True. I'll take another look when I'm back at the computer.
Style fix: Spaces before braces everywhere, please
That... is a very good question. It's gone.
You should be able to use `_getHTMLMenuItem()` instead of the logic here.
This could be slower since it does a string replacement every time if a change was made or not, but I went ahead and made this change because the code is a bit cleaner :)
Also, is there a task to implement this method later this sprint?  If not, should we remove it for now?
Why this be overridden? Maybe this is worth adding as a comment.
Would it be better to just call _showUpdateNotificationDialog(allUpdates) here so the user doesn't have to wait on another network request if they've left Brackets open (with icon showing) for > 24 hours?

Downside of course is if they leave it open a _really_ long time and another update comes out, the dialog will only show info on the original update(s).
Why do you have 2 event handlers. Just have one.
Vinay is not expected
synchronously or asynchronously ?
Can you please add annotations like @Immutable or @ThreadSafe or @NotThreadSafe  to your classes? I think these are going to be used in multi-threaded environments and these annotations can be useful guidance to clients.
@include OpenLayers/Control.js 
can be removed now that "me.controls instanceof OpenLayers.Control" has been removed
`= link_to "儲存", "#", :class => 'btn btn-primary'`
Are we indenting with four or two spaces? Please spell out whole names, be verbose!
The directory needs the `_` at the start of the directory name, so I think there is going to be a map here anyway, I think.
In the header, the buttons are no longer buttons really anymore (ie they dont have backgrounds or borders to deal with)
needs a comma between Verdana and sans-serif
Can you just reduce the padding here so they aren't spilling out of the box?
Why not just make is uloadDialog instead of UnloadDialog.init?

unloadDialog was my first choice, actually.
For here, probably. These tests aren't work atm though.
space after <code>while</code> and before opening brace
Make this a const please.
We shouldn't pollute the global scope here
logic here is missing `fontCharsToUnicode` call or additional manipulations with `chunk` and `text`
Not complete/useful comment. Please add your issue description text here: "Sometimes the pdf has finished downloading before the web worker-test has finished. In that case the rendering of the final pdf would cause errors." (without capitalization and exclamation points); then "We have to wait for the WorkerTransport to finalize worker-support detection."
As I understand it, this would make tuque a stand-alone module in Drupal. The Islandora module would then just list it as a dependency.

:+1:

Fabulous idea.
Btw pulp-server is also a collection of services (httpd, qpid and mongodb). Maybe we want to split it up. And add postgres as well (since we already restart mongo in this case).
+1 to jsomara's name
You accidentally downgraded version.
A good point.. but in this case no.. as the pusher class automatically
converts arrays to json.


On Fri, Nov 30, 2012 at 11:41 AM, Christophe Coevoet <
notifications@github.com> wrote:

> In src/Monolog/Handler/PusherHandler.php:
>
> > +    public function __construct($pusher_key, $pusher_secret, $pusher_app_id, $channel, $event='info_log', $level = Logger::INFO, $bubble = true)
> > +    {
> > +        $this->channel = $channel;
> > +        $this->event = $event;
> > +        //$this->pusher = new Pusher($pusher_key, $pusher_secret, $pusher_app_id, true);// DEBUG
> > +        $this->pusher = new Pusher($pusher_key, $pusher_secret, $pusher_app_id);
> > +
> > +        parent::__construct($level, $bubble);
> > +    }
> > +
> > +    /**
> > +     * {@inheritDoc}
> > +     */
> > +    protected function write(array $record)
> > +    {
> > +        $this->pusher->trigger($this->channel, $this->event, $record);
>
> Shouldn't you use $record['formatted'] here instead of $record ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Seldaek/monolog/pull/132/files#r2276736>.
>
>
change the name of the variable 'sz'
Missing label.

For the sake of accessibility, please keep the messages label and use CSS technique to hide it.
You should wrap this entire block in an if($_POST){} statement.
The class names in the generated class inheritance diagram are too small.
It's very hard to read them, even on my retina display. :-)
Wouldn't it make sense to keep a utils directory rather than having a bunch of .rst files at the top level?  Just a personal preference, I guess.
Maybe you can get rid of the ``array = ...`` and  ``ndd1`` lines, and just re-use the ``ndd`` object created just above? Just a thought.
I think this function is better named `load_modules_on_node`

just my 2¢
This is not a very safe method.
Why don't you just use ``else if``, this looks weird ... same for all other occurrences!
Hmm, that does not look right to me, it is either required or not required. The only differences hound be that the rule will not be processed if it is not required
You don't need "A" capital now that you added "The" before it.
There are two spaces before "gettype" instead of one.
Screws with a lot of IDEs. I'd prefer not doing that.
This can be deleted after the other changes have been made.
I tend to prefer putting helper methods after the main method they call, just because it makes the code read nicer (to me).
Please either log or use `bot.Reply()` to whine in the channel, instead of just printing errors to STDOUT.
Replace `_shouldRebase = (v.ToLower() == "rebase")` with `_shouldRebase = v != null` (like in https://github.com/git-tfs/git-tfs/blob/master/GitTfs/Commands/Fetch.cs#L42-L47). Add some line breaks, too.
During the classification phase, if we find tokens **not** in the language then we have to score them as zero. It is during the training phase that we build up the probabilities that a token belongs to the language. As new languages come in, we have to train the classifier to recognize them. It is the process of building up the token probabilities.

There are algorithms for continuous training bayesian classifiers. Should definitely check one of those out.
please use real tabs instead of spaces.
Is there any reason we shouldn't be passing the whole env:

```python
env = os.environ.copy()
env['IPYTHONDIR'] = IPYTHONDIR
```

?
This line is unnecessary, given the line below.
I don't like this, seems redundant and in the wrong place. We already have `git_odb_read_header` which does exactly this.
Can you move this above the set just to keep the imports together?
We are trying to get rid of fixtures. Please use `user(save=True)` and login with that user if you need to test the view as an auth'd user.
the settings have ROOT_PACKAGE, so maybe we can use os.path.join(ROOT_PACKAGE, 'media', 'geoip')
empty method. If it is intention in this state of implementation, then there should be at least raising something like NotImplemented exception
Hey, it looks like your line endings are messing up the diff, can you please try and follow the guidelines?
I was originally thinking we could define these property descriptor defaults in a helper function somewhere so we can DRY this up a bit.
Maybe something like:

```
moto.createProperty = function (val, options) {
  var defaults = {
    enumerable: true,
    configurable: false,
    writable: false
  }
  return _.extend({value: val}, _.defaults(options, defaults));
}
```

Then the calling code could look like:

```
Object.create(Foo.prototype, {
  myProperty: moto.createProperty(
    function (arg1) {
      ...
    }
  )
});

Thoughts?
I see now that this is in the CreateModule. Is that not useable here? Circular reference I suppose?
BTW : It's possible to check if a user exists in the ldap. But the LDAP will not return the password (plain text or not)...
Then, the query to find the user is very difficult to find.
wouldn't you loose the next chars here ?
@bschussek it is not fixed: https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L67

It seems like @fabpot was faster to merge :)
the translation domain should be changed to ``security`` instead of ``exceptions`` IMO
Should be `0 === $b`.
You can still set the a different hostname for a single route by hand. But in this function it should be consistent with the rest of its workings.
中身が空で使わないならコミットしなくても良いかなと思いました
No need for !!.

Please cache the results of calling `u()`.
the escape stuff is fine but we really don't need named capture groups, it would be nicer just to use what everyone in js-land is familiar with
not that I think it's wrong, just curios what the difference is?
I don't know how this passed. Needs to be fixed.
pow is ambiguous on macos X with clang++ (because of implicit cast to float or double). 
You may either write it by simple shifts:
1 << ( dimension - m);

or use static template pow:
http://www.boost.org/doc/libs/1_41_0/libs/math/doc/sf_and_dist/html/math_toolkit/special/powers/ct_pow.html

pow<dimension -m>( 2 );
This includes the typo from my original commit, which I have fixed in 04191f30ee59c3535ae1a7c1b0ef7fb1c111227c

I'm guessing you should fix the typo here too. (intial-scale -> initial-scale)
Doesn't this do same thing <code>normalize_connect_uri(uri)</code>? Maybe not, I can't remember :D
Using #ting-search-spinner creates soft dependency for ting_search. Not a huge issue but it would be nice to avoid if possible.
white space after the block
Are these APIs intended to be private?
The $album->is_album() check is to guard against a user changing the album ID in the URL to something other than an album (such as an id) causing the search to yield no results. Alternatively, rather than a user changing the URL, this could be a copy/pasted URL for a search that is stale and the MPTT tree has been updated causing the album ID to now point to an image.

My thought was if the album id isn't an album, rather than no results, just skip straight to searching the whole gallery. The access::can check is there to avoid exposing an album with that id exists, and just treat it as the same case as an invalid/not found ID.
This changes the load code from asyncoronus/at the same time (which pouch didnt like, because it was getting too many concurrent requests) to seqential, the corpus first, if it succeeds, then the session, then the data list. 

What does this mean for debugging? It means if the data list doesnt load, it could be due to the session not loading, not due to any problem with the datalist etc
This bothered me also, later i found that it could be simplified as type attribute could be used for Load metric and class attribute for Custom Load metric. both of this identifiers uniquely represent the attribute. will fix it in that way.
Though in this case, just inline the variable, as its used just once.
@ukanga what API registration do we need to have this point at formhub.org?
this is this here too :)
I don't know this will generate warning, why?
I think that SVG is a abbreviation.
It's a better way to keep the name for readability.
Yes, I like it a lot, I'm going to replace that.
Deal with Etienne. It is here because in future relase of Gecko all CSS Reset will be as part of B2G core.
@etiennesegonzac, the problem with that is in the homescreen right now we are getting the app based on origin, both will have the same origin. So you don't know which entry point you clicked.
`settings.createLock()`
good to see that the changes from the old code are minimal as this was based on the primitive BBs!
I think I just fixed this yesterday.
I think this should be var doc = (parent.location === window.location) ? document : parent.document
There can always be an error in the file, it shouldn't stop the app I think. But swallowing per line should indeed be better.
I don't think this way to call the callable works on PHP 5.3. IIRC, it only works for closures.
You've got some trailing whitespace here. And on the next line as well.

Use:

    :let ruby_space_errors = 1

In your .vimrc to pick up this kind of stuff in advance.
Sure this is going to work with `<body class="home-page"` attr changes?
ならんだ

→

    並んだ
No sorry, it's just that github review is kinda weird. :)
I will split it out to a separate module.
``
if (empty($this->flaggings)) {
  return;
}
``
Oops. Translation for COM_KUNENA_A_EBAYLANGUAGECODE is wrong and COM_KUNENA_A_DISPLAY_NAME missing.
"guideli" looks like a typo, unless its some vagary of the English language with which I was heretofore unfamiliar. :-)
It looks like Marijn removed the notion of "targetDocument" throughout the code and just used ordinary "document" instead, so I made that change in our own code in various places as well.
A bunch of other DB methods use "the current time".  Of course, testing
requires passing a reactor in, through the data API in one case.  But that
will be equally ugly if the data API has to pass along a _current_time
argument.

This has worked fine so far, and has basically become idomiatic, so I'm of
a mind to leave it as-is.
This new command should also be covered in `cmdline.rst`.
Why is this safer? If a master is just starting up as this is running, and the timing is *just* right, it seems like this could override the master setting itself as active.
お、ちゃんとエスケープできるんですね！
Maybe we should add the dependency as you said and assume an installed version from bundler as a backport. I can't see a better solution. 
@rsampaio, ideas?
This pseudo-maintainer is kinda confusing.
Well, I think the best we can do to support multiple debian releases is to add a Recommend line on this control file so via apt-get it will recommend the libbundle-ruby during the install, we use a backported libbundle-ruby1.9.1 internaly here so forcing this package as a dep will work but definitively we should not force a dependency when it does not exist in that release.
Let me know what you think.
why is this needed? It's only set in one place, never checked it seems
flag may be better than "tag"
That can be added. In this case I just added javadocs, I dont wanted to change code semantic/behavior. Perhaps the whole class should get investigated and CheckForNull be added where appropriate. Is this really needed for this patch?
273 | ERROR   | Whitespace found at end of line
Will this work in a non-executable part of the script? Is it needed as it is already in bootstrap.pl?
same comment here about structured logs vs plain text, something like `@logger.info("Connected successfully to AWS SQS queue", :queue => @queue)`
Ah, excellent.  I didn't realize this could be done.  I'll fix and update.
Are you sure ? It does not seems to be here.
I will add comments explaining why these aliases are there.
TODO: Find out if there is utility function for getting `selectedTab`.
Agreed, as called out in the PR summary.

I considered refactoring to

    primary.checkSupport(primary.domainFrom(email), ...)

or 

    primary.checkSupport(emailutils.domainFrom(email), ...)
This catch all case actually belongs with the above removed code around line 77 - it is the else statement that goes with the "if(cookiesEnabled)"
added the wrapping in the println method.
Yes. it already become independent folder with the index file.
Same concern as above; these fact values will never be refreshed since `devicemodel` is not a local variable relative to the block passed to setcode.
How about `/20\d{2}\s+/` to force 20xx
One suggestion -- this doesn't really communicate much about a real situation where `#method` would be overriden.  Instead, you might consider doing something like:

``` ruby
let(:http_request_class) { Struct.new(:method, :uri) }
```

This communicates better (I think an HTTP request object is the main time you'd see `method` overriden since it's a proper term in that domain), is less code, and is a bit less "meta" (e.g. no `class_eval`).
I think ArrayObject could be a type-hint ?
To be honest, i don't know why ... php-cs-fixer add this ? I just fix the "call" method ... i will be unfix that.
I don't know the answer to this.  Is apr_strnatcasecmp an Apache function to be preferred in place of a C library version for portability reasons?  If so, I'm all for it. :)
rides = st.rides()
if rides:
    ...
Following convention, the parameter name should actually be `$config`, since it is an array, and it makes a persistent change to the class' state.
I see. 
You decided to go with closing tags eof  (cause of symmetry), so I would have expected that here as well.
I am not sure authing for the client needs to have its own thread?  It's not like the client will be doing anything at the time. 

Anyway, if you are doing it this way, setting the data map isn't enough.  You need to ping the main login thread for it to wake up.
Why are you returning a callback?
This will make changes to the file system even if `noop` is set.  (You'll notice that's an issue in `git_piston` as well, but that's being deprecated per #18.)

If `sync` is a feature that we intend to keep around, it should respect `@file_options[:noop]` and not actually run the command in that case.  It might make sense to take care of that check in `cmd`, actually.  Up to you.
@vesak Eiks tää eka vaihtoehto tarkoita sitä, että seurataan yhtiön parametriä? Pitäiskö muuttaa tekstiä, niin että se käy jotenkin ilmi?
Then this might be a good reason to keep it as is, with `kernel.root_dir` separate (easier to override for tests I think).
yes, otherwise you'll just get the existing configuration from ezpublish_<dev>.yml because it's injected in the legacy kernel.
can you remove this and just move the next lines to the left?
I don't think you're planning on importing this file somewhere?
Why is there a docstring here? Did not see in the other .py files.
Actually you can use manifest file for JAR to specify list of dependencies.
Do we need to include e.getMessage() if you're already wrapping the exception?
a bit more precisely: which is either a vlue of type `Some[T]` or the value `None`
@milkypostman I renamed `:cvs-module` to `:module` in 9592064.
Should this be `&& typeof resp.locals !== "function"`
This can be a property as it's passive/only returns text.
We've never had it before, and while we've seen one or two books come through, I'm not sure it's needed - by and large most tickets are under 5k characters as is. (one less piece of javascript to hang...)
Oh, I see, in that case it should be indeed lowercased. The initialisation could also be removed from here and on L564, instead of logging the absence of `ServerConfigurationService`, manually set `default_list_page_size=50`
Is there no way to fix the underlying error in IE8/9 without try/catch? Seems like a brute force solution.
Also why not use quasiquotes to assemble these trees?
Should be "Flushes..."
On 16 April 2012 16:02, Henrik Skupin <
reply@reply.github.com
> wrote:

> > @@ -53,3 +53,13 @@ Now click the `Launch` button and the node should
> automatically connect to the m
> >  Using the Jenkins master as executor
> >  ------------------------------------
> >  If you want that the master node also executes jobs you will have to
> update its labels and add/modify the appropriate platforms, e.g. 'master
> mac 10.7 64bit' for MacOS X 10.7.
> > +
> > +Running on-demand tests
> > +-------------------------------
> > +1. Navigate to your Jenkins instance: http://IP:8080
> > +2. Open the +admin tab and look for the 'trigger-ondeman' row
> > +3. Click the green arrow button, 'Schedule a Build'
> > +4. Upload your ondemand.cfg file (see examples in ./config/ondemand/)
> > +5. Click 'Back to Dashboard' link and open the @ondemand tab
> > +
> > +If you see an ondemand_* testrun in the middle is blinking and the
> nodes on the left are not 'idle', your testrun is executing. Once complete,
> the results should be published automatically to
> https://mozmill-ondemand.blargon7.com/
>
> Please don't name the dashboard instance here. Just make it a general
> documentation.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/whimboo/mozmill-ci/pull/50/files#r690909
>

So the brasstacks instance is unique to our servers? How does this sound
then:

If you see an ondemand_* testrun in the middle is blinking and the nodes on
the left are not 'idle', your testrun is executing. When the testrun is
complete the nodes will go idle (assuming no other builds are queued) and
the ondemand_* testrun will stop blinking. If it renders a green circle the
testrun has passed. If it renders a red circle the testrun has experience
one or more failures. Check your dashboard for the results.

-- 
Anthony Hughes
Thinking maybe we should rename this to be getModuleName. Most of the drupal docs refer to the name used in the .module file as the module name.
Whats up with the duplication here?
Even though it should never make a difference, I would use `while` here to always make sure the list is the right size just in case we get into some weird state.
nit: extra empty line?
Renamed filename to be more descriptive and match page title.
It's also terribly Apache-specific. I want to run this on my nginx/php5-fpm install, help?
I think we may be talking past each other because of an internal vs. external distinction.  I definitely see your point that it may be wise to use `Quantity` or `NDData` *internally* in `Angle`.  I just don't want to do it right now because it would further delay the coordinate work (which works as-is right now).

From the users' perspective, though, we don't want *unit* on `Angle` because angle has `radian` `degree` and `hour` properties that each give different units.  So `Angle` having `unit`/`value` attributes would be confusing (two ways to do the same thing).  Furthermore, we would have to change the public API so that `Coordinate` is either a scalar or array (because the public API for `NDData` and `Quantity` will include that requirement), which we don't want to do for `Coordinate` for a variety of reasons.

I do see your point that this classes do conceptually overlap - I'm just saying we should continue with `coordinates` until we have the originally laid-out API ready, and then consider how it should connect with `Quantity` and `NDData`.

(Maybe we should move further discussion on this to astropy-dev? it's in an outdated diff here, so probably no one else will see it...)
This is not the Block Type name this is used by methods such as Block::getByName($name). making this translatable will break this functionality any where it is used. (you can see where this is used by clicking on a block then selecting custom template.)
Support sorting on complex properties.
What does CS mean ? :)
Also same for the other test methods
Line-break after the "or".
consider table,merge
What else raises? If you really need this, it'd be nice to print something about the error.
We always use """triple double quotes""" around docstrings, according to Python Docstring Conventions http://www.python.org/dev/peps/pep-0257/
Also, triple quotes are used even though the string fits on one line.

This applies to every docsting for each test and we should keep it as it is.
OK.  The old code was weird, and I preserved the weirdness as I moved things around.  I'll follow your suggestion.
I am not sure that referencing a non public system for details is very useful, what about putting detail as a comment in the source code, or in a file ?
You are checking if it is defined, but in the header file you define it to zero if not already defined... so this will always be true..
Also maybe nicer to name it more explicitly:
#if UART1_HW_FLOW_CONTROL
this should be configurable via airframe file...
either require this to be defined in the airframe file, or provide defaults via makefile variables and enable configuration via configure
If `log-statements` is really meant to be a boolean, I'd just call it `log-statements?` and leave out the precondition altogether. The precondition is a little too narrow, I think, in any case...passing in a `nil` won't work, for example. For boolean conditions where all you care about is truthiness, I don't think you need a precondition at all; either it's false or nil, or it isn't.
`<my_view>` gets swallowed by github's markdown.
Chuck Norris won't be happy for that ;)
Should be User|Group
This is nitpicking, but can we move Comments above CommentsByContent.
Unfortunately we don't.
Whoops, I'll add them all.
I'll add in permission checking once we have authentication support.
I can do the setting of roles though.
Same comment as in https://github.com/scala-ide/scala-ide/pull/220/files#r1994601
I'm not following. If we are using 1.7.0.RC1, then why should we be concerned about 1.6.12? Why would it be bad to set this property to the version we use?
Good, done!
This method seems overly complex in comparison to `fill_in_row` and `fill_in_table` is there a usage for this API? I think tabular forms are already complex it makes sense to work with them in multiple steps instead of passing everything in one go.

If there is no current usage I would drop `process` and `fill_in_with`. The outside can still use `fill_in_row` or `fill_in_table` and of course `submit`

What do you think?
Yes I did. I have updated. Thanks for the comments.
Discussed this with dbu in IRC. This is a simple change. +1. He'll do.
So, how about: 
typeof instance !== 'object' || instance instanceof Date || instance instanceof Array

This allows for objects which inherit from the Object prototype.
いいいいいい
There are two strategies, one for over_tblock and one for over_thread.
This is a OS project, but I still expect quality code somehow. These nested ```if``` seems a code smell to me. Could you refactor this. Basically I think you need another class that is responsible for explain what ```config.formatter``` mean. Something like this:

```ruby
from_config = FormatterFromConfig.formatter
form_congit.nil? ? PivotalToPdf::Formatters::Default : from_config
```

Again, thanks for your effort
Было бы хорошо вынести категорию в отдельный файл
Вы сделали несколько Pull Request, и получилось, что вы внесли изменения дубликатом к себе, а не сюда. Pull Request делается один раз - это гарант того, что ваш запрос окажется в списке этого форка. Все последующие коммиты к этому Pull Request будут автоматически здесь отображаться. Я в вашем аккаунте увидел, что вы сделали 3 пулл-реквеста, тем самым, у вас теперь три ветки на гитхабе.
`id && this.clients[id]` would be preferred here
You must not change the library name :)
we don't ever seem to use this since it is tied to jake anyways.
ThreadLocal是class，reify搞不了
don't compare strings with "is"

what happens if len(pick) > 1 ?
Added the version you proposed plus fixed a missing assignment-statement.
The epochs tests seem to run smoothly.


On Thu, Dec 6, 2012 at 5:41 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> Yes sounds reasonable. More than having a private ._copy with index arg...
> Or what do you / the others think?
>
>
> On Thu, Dec 6, 2012 at 5:40 PM, Christian Brodbeck <
> notifications@github.com> wrote:
>
>> In mne/epochs.py:
>>
>> > @@ -463,19 +493,30 @@ def __repr__(self):
>> >      def __getitem__(self, key):
>> >          """Return an Epochs object with a subset of epochs
>> >          """
>> > -        if not self._bad_dropped:
>> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
>> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
>> > -
>> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
>> > -        epochs.events = np.atleast_2d(self.events[key])
>> > +        epochs = self.copy()
>>
>> Maybe temporarily remove self._data in *getitem* before calling
>> self.copy()?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337336>.
>>
>>
>
>
shouldn't you remove this line?
the test suite will tell ;)

if tests agree that you can remove a line +1
Same idea here.
you can remove the XXX here now
Really? Removing the dataset was enough to fix the test?
Unrelated to this change, but removing the space after the : will make the version manifest easier to parse
My bad. I have an old local.py. I'll fix it, rebase, and push a new commit.
In CS you can shortcut `this.` with `@` so you can do `@pushObject`
please revert this change. Putting custom types in the ``Form\Type`` subnamespace is the naming convention (data transformers going in ``Form\DataTransformer``, listeners in ``Form\EventListener`` and form-specific models in ``Form\Model``)
允许限制某些IP地址的客户端访问。
Because I'm stupid. Fixed.
util бы пораньше включать :3
Personally, the beforeunload event should not be used by the library, because window.onbeforeunload ask users whether they want to remain on the current document or not. If the user selects to remain, the connection also should be maintained.
Missing docblock @param for this new argument
Prefiero que el formulario directamente no esté si no corresponde, pero si, se podría hacer al revés
- I don't like this introduction (not the introduction in the agent guide) The introduction should say "This guide will show you how to create a Service Check. A service check is ... ."
- Move the required version into setup.
- make it blue instead of yellow (this is inconsistent across the site)
Are we getting rid of composer?
Validation should be moved to the model, not using a separate validation
You're still returning a big text blob (a single large string).  You need to return a list of strings.  Then your logic later on will work to check if the string is in the list.
So sad the function is not in the `PhraseanetWebTestCaseAbstract`
you mean just `toFunction`? Problem is the semantics should be a little different, specifically you almost certainly don't want to invoke `stringToFunction` for String values.
elaborated.
@kevinprince so you could write this as 

```ruby
self.send verb, action, params
```
This is actually used as a nicety to turning request params into a dictionary. If you view wsgi.py line 71, throwing a type error would be bad here. It just returns none for the params list, since there are none.
Well thats what the config is for, right? These defaults are sane defaults for a local, easy configuration. More complex == use conf file
K I can do that. Maybe just addresses w a list?

Sent from my digital shackles. 

On Apr 4, 2012, at 10:31 PM, Nirmal Ranganathan<reply@reply.github.com> wrote:

>> @@ -16,18 +16,29 @@
>> #    under the License.
>> 
>> 
>> +def get_ip_address(addresses):
> 
> Hmmm... I think if we are returning ips we should return all the ips not just the one private. And go with either {'ips': []} or {'addresses': [{'ip': ''}]}
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/59/files#r648785
oh thats nice.
Why suppress deprecation warnings?
This is to align with the productization effort: there the PooledConnectionFactory class is removed, and therefore the tests need to be adjusted for this. Since the tests don't actually need pooling, I think it's a good idea to use the SimpleConnectionFactory unless needed(which incidentally is all code we can control). And when needed we should be really testing against a ManagedConnectionFactory
Added a new commit to fix this, thanks!
remove the constructor if you don't have anything to put in it
Since we now support python 2.6 and above, we can use ternary expressions.  This might be a good candidate for that.
This might have actually been a recurring issue.  There might be some mailing list threads about it.
I thought same-line comments only had an extra space after a colon?
@nelleV Sorry, I was unclear, I meant "down to but not including" the comment.  Sort of like Python indexing.  I would suggest leaving in the "### Labelling" comment because it is a separator, signaling that label-related methods follow.  Putting in a few such comments was part of my long-ago reorganization.  I think they are still helpful.
Note that this will show the pattern and not the function name. It might be smart to reword this to be clear about what the developer is seeing (i.e.: "A JavaScript function matched the pattern '%s', which has...")
+1 the test should ideally fail at this point if the setting was unable to be modified.
Add a `size` on all the boxes.
@bp323 You're totally right - thanks for that site btw, too bad it didn't load on my phone.
Este template deveria fazer parte dos arquivos excluídos
Analogous to updateFromEditForm() - but changed it to the more explicity updateNodesFromServer()
"else" should be in this line.
`return (testelement.dataset && testelement.dataset.testThisThing === 'test');`
agreed, I'll update it.
we might want to just have a CSS file called `preview-pane-fixes.css` and either inject its content or link to it via a `<link>` tag, to decouple the CSS from the JS here. Will also make it easier to inject other fixes in the future, if necessary.
@nickvergessen Change, yes.  Break, no.  Lazy, probably.  I don't have a strong opinion on this, but if it were my decision I would merge as it is.
Another important thing here is: Use "val" instead of "var", wherever possible. "val" means immutable, whereas "var" is a mutable variable. Scala tries to make as much as possible immutable, because this avoids side effects, is less error prone and allows more beautiful functional constructs.
- Are you sure the method ``expects`` can be called on ``$this->context`` (of type "object<PHPUnit_Framework_MockObject_MockObject>|null")?
- Are you sure ``$this->never()`` has the correct type as "object<PHPUnit_Framework_MockObject_Matcher_InvokedCount>" is not a sub-type of "object<PHPUnit_Framework_MockObject_Matcher_Invocation>"?
Actually, now that I look at your diff again is there any reason you use `Boolean` instead of `booelan`? I would think that the spoiler field could only be `true` or `false` and never `null`.
> We're also not doing this. Can you give an example where a word would be
> preceded by TeX markup?
>
The behavior of \textit{Homo Sapiens} in the wild
But that's not a problem here (or maybe not at all anymore) because the
markup conversion follows after this. Also, same as above - since our
mechanism for setting {} is more refined than before, this is probably less
of an issue, if an issue at all.

>  —
> Reply to this email directly or view it on GitHub<https://github.com/adam3smith/translators/pull/3/files#r2424620>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
Oh, right. Then I guess this is one of those rare cases where a comment is actually warranted. Also, I guess we could simplify slightly?

    var Obj = function () {};
    Obj.prototype = { hasOwnProperty: undefined };
    var object = new Obj();
Thanks. I understand it better now.
Also this whole class method is missing specs.
Why is the path altered here with `/../`?
I can't find a one-line version of this I'd like.

```python
return self.video.title if self.video is not None else 'Video Title'
return 'Video Title' if self.video is None else self.video.title
```

Neither of those look as comprehensible as the nested version IMO
yeah it gets pretty confusing, it could definitely use with a nice refactor, anything in there that isn't declarative
the style I go with is:

```js
return Array.isArray(header)
  ? header.map(Cookie.parse)
  : [Cookie.parse(header)];
```
Yes, but you have currently hardcoded width in there. Probably not all boxes will have the same width?

Anyway, OK, use *box* then. Or *panel*?
Selecting an item should submit parent form. Is this the right way to do it?
Please respect our [code style](https://github.com/wlanslovenija/PiplMesh/pull/199#commitcomment-1707793). It might be that also previous code was not in this style, as it seems. Feel free to fix it.
This of course is not correct, you do know that, do you? Because we have multilingual site. So just sticking strings together like that ... :-)

You should use Django-provided functions for doing translations in JavaScript. Yes, Django [supports that](https://docs.djangoproject.com/en/dev/topics/i18n/translation/#internationalization-in-javascript-code).
Name the section, similar to how it is done for Facebook.
This is not good. Attachment does not have `is_published` flag.
Add comment with unit.
So you mean like /profile/user/"profilename" .
Hm, is click the best one? Or should be maybe instead change? Or both? Maybe both?
`Forcast` -> `Forecast`.
Isn't there a finite risk that the `result` is exactly the same set as `initial`? If that happens, wouldn't `intersection.Count()` be equal to `initial.Count()`?
you can move it to spell_valkyr_essences_AuraScript::Absorb
Missing docs :P
why did you need to change this file at all? from what i gather you didn't add new features to the core, but made the keystone correction accessible from a different gui?
script list should be extracted in a constant and potentially (later) put behind configuration
It should be documented as such and the NEWS entry should mention it too. I would probably do it in a ipset dedicated section. Not really sure where to put it though..
This note is a distraction; it's not needed here.
This is fun but not really the right tone, it's also the only usage of the first person in this article, so it ought to go.
I'd have to update the bidpom to expose the locator or element and that's a bit of a hassle.
I think we can remove this comment, we don't see something like this in Drupal core.
to to
I could imagine this could be used for resizing based on resize events, so that when they are too frequent it would auto-throttle. The last arguments you tried to pass would need to win, but yeah, makes it a bit more complex there. Not needed while it's not needed :)
I guess it's confusing if it's in test-scripts but isn't really a test.
This seems (almost) the same as `if (event.wheelDeltaX)`?
Space before the comment.
This and Frustum::UnProjectPoint do not appear to be used. They should be removed.
I don't think "use_system_library" is clear enough, the term is vague. I prefer "bundle_libpython", it's much more clear.
Minor nit, but I don't think `oauth-put`, `insert-rows`, or `delete-all` functions should be part of the API. These are kind of application specific things. Like, I think they should belong in the forma-clj project since they are needed to make it easier to throw forma data into CartoDB. That was this cartodb-clj API will stay super lean, exposing only the `query` function. Maybe?
Not 100% sure this section has a point. Usage should demo how to use it in a different extension.
I think not, the product is just over the multivariate dimension not observations
The API doc is wrong here, since the constructor only accepts an URL string now.
How I can add additional parameters? As a tuple? Comma-separated string?
yeah, for now i think there's only one instance where it doesn't behave correct and i think in this case save could probably adopt backbone's style of passing a second `{silent: true}` in order to suppress the update.
Not quite sure how this is being used but could bootstrap's indefinite progress bar work instead?
This raises a good point in general.  I think we currently silently ignore all parameters that we aren't expecting.  It would be good to have some way of tagging which parameters we deal with at each layer, and if there are any left, we raise an exception about something being unrecognized.
Sorry that I didn't weigh in on this discussion.  I like this resolution to the problem, as the sequential seeding had vaguely worried me.
Another alternative might be a straight iterative updating of `F(<r) = 1 - (1 + r) * exp(-r)`.  This can be very simply rearragned as
```
r = ln( (1 + r) / (1 - F(<r)) )
```
I *think* starting off with a guess for r and simply updating the rhs to get a new rhs would converge for any r > 0, and might possibly be quicker than the Newton-Raphson (but then again, might easily not be)...
You may have noticed this change in font size didn't have any impact.  The send button wasn't actually 16pt in the first place.  Whoever at Google did this sample application seems to have goofed.  The font-size in here gives way to the one in clean.css.
Je gebruikt  overal css IDs voor. (`#`), dat is niet helemaal juist.
And everything else is in cents because Stripe works in cents, and we might need to handle fraction - of - dollar donations.
Hi Alex, I processed the review comments.

I tried manually to install without the so.1, but I get the message that no package is available. I also tried it only with .so, but also no package available.
Can we delete impl, to instead delegate to new method?
Could we just pass `self.extensions_paths` to `create_firefox_profile`?
wouldn't be usefull to unsubscribe from scheduler?
I thinkg empty rules should be removed. This css file already looks like peace of crap, please dont' pollute it without a reason
it's one assertion at a time.
I think we should add the argument name to `ctx.sudo` (as in `php.install` and `ruby.ensure`) too.
That would make the whole example as expressive as possible.
oh, right! that was me trying to use sublime text 2. I'll fix this, thanks for the notice.
the path param is just temporary until I can get my changes merged into alchemist