labofsahil/github-event-dataset-2012 huggingface dataset:
can you change this `1` to `5` or `10` or something higher? i found this too chatty when a client had numerous connections. (and same comment on line 228)
I don't think all the params are getting though here because the group count isn't set right for this class.

Note that it doesn't break any tests, but most tests don't use the ObjectContent path where it would break.
Oh, and most :user in the forms and such has also been renamed.  If you don't want that I can revert parts of that fairly easily, so let me know what the final form should be.
I guessed that this was needed at one time, but I thought that is likely long past.
could we add  a comment that mentions the error so we know what this is about?
I see the idea of database stuff falling under the integration category, but I've never agreed with it. IMO, so much of what we do is database driven that the distinction doesn't make sense. We'd have the slightly faster running unit tests but no confidence that they actually verify anything, in which case we'd always have to run the integration tests, making the separation needless.

I believe that it works. But, without trying to be aggressive, "very carefully hand-verified that the mongo syntax is valid" is the sort of thing that gets us into trouble. In this case it's likely that the code will never change and thus having that verification in a unit test to prevent regressions may not be as important, but I don't like making that sort of statement. I feel like once you have a judgement call like that, it can lead to this decision being made in other places where it may not apply. 

We have so many tests that do hit the database that I'd rather address the idea of an integration dir as its own entity. Trying to do it now amidst all the other 2.0 stuff, updating jenkins to run those tests, educating developers that they exist... it's too much right now. I like the idea of consistency until it's address as a whole instead of a slow trickle of differences. This is a bit bias since I disagree with the idea of separating tests out into unit v. integration and would rather have the discussion before we start down that road, and given time constraints I don't think we can have that talk now.
dislike sending root params (as we've long done, I know).  limits possibilities (layout, view, etc).  we should send params[:user] or :account or something. (maybe not this branch?)
Ah, yea that seem to make sense.
See: ```'action.edit'``` (Line 5)
Yes, if a ServiceMemberTaskAcceptor is used.
I can use the queryset.count() function available from Django ORM.
I think we need an `if ('win32' == process.platform)` check here...
This image is never used.
Signed/unsigned comparison. Happens in another place as well due to off_t being signed.
Generated files should be generated at build time. I really don't like this change.
Well, they'd always be errors like that you can't .end() a stream that's already closed or something.  Ie, useless and extraneous.  Until we have a consistent way to shut things down, and to tell if they've been shut down, I think this is about the best we can do.
Link to file not in the node docs.  This will cause a broken hyperlink on the nodejs.org site.
Nah this is just for devs who try to do some wanky stuff.
You mean just call super and and then return this and so "safe" the cast ? What would be the advance ?
For some reason I had the idea that I should demonstrate that argument order does not matter -- there was an issue where something like this worked but in a non-intuitive way.  This is of course pointless as written.  I will remove (though it suggests that maybe ``vpolyval([1,2,3], x=[0,1])`` should perhaps work...
It's a simplification, this function existed before but was called from compute_datetime_metadata_greatest_common_divisor_capsule which I could now eliminate. Before, access to the metadata was going through more indirection.

With the python metadata dict, each metadata access requires:
 - construct a python string object from the C key string
 - look up that string in the dict object, to get the pycapsule object which contains the metadata.

With the c_metadata, it just requires accessing a C pointer from the dtype structure.
this should probably be split out into its own method
оно тут еще надо?
Is `raise_routing_error` ever called without a message? Does the `message` argument need to be optional?
After think better about this, I saw that is fine that it returns `true` but I think that now the value would be `123` and not `nil` as it was before the change.
Ok, after further review, I can't change the own hash inside an each block (it throws an exception). I could copy the hash and do the conversions, then change self to reference the new hash or just keep iterating over keys and values separately. What do you think?
this shouldn't be `if 'state' in place`?
The ros constructor takes a bridge object that communicates with the server over whatever protocol. I named the backing variable `bridge`. If that's too confusing with rosbridge.js, we can name it something else.
It's past 2am, I don't want to cry myself to sleep...
Unless the type literally cannot be written down, methods in public API should always have explicit return type.
Yeah, that's still fine. I'll add that to the test case.
See line 93 --- it was built with MKL, but only contained the `empty_module` symbol. It's maybe better design to not build the module when the library is not available and catch the ImportError, rather than to substitute it with a dummy module.
none of our code depends on pandas yet, does it?
I think it's better to use something immutable like `None` for the default value of the optional argument. The trouble with this is that if `packages` is modified in the body of the function, the changed value will be supplied to `preview` on its next run. I recently had issues with this and found the following useful: http://stackoverflow.com/questions/2899643/python-constructor-does-weird-things-with-optional-parameters (see the top answer)
Just because it's shorter :). I can change it to alternating/symmetric if people find it more appropriate.
Oops! and thanks!
This is now `_mat` due to the rebase onto master updated by @smichr 's work.
No. This should be the result that the default implementation of `free_symbols` would return if it knew how to work with non-Basic args.
or

```
...this means that any recursion done when deep is True should only apply _eval_expand_hint -- not expand -- to the arguments of the object.
```
I think that it is the question of assumption system.

If it decided that  x.is_integer is False, then it is. And if it is incorrect then the code must be injected there.
yeah.. I will change that. I had done that before I put lines 27 and 28.
Good point. So how about

```
n = len(text)
text = text.rstrip('\n')
n -= len(text)
if n != 1:
    text += '\n'
    sys.stdout.write('Fixed newline issues with %s\n' % filepath)
```

This has the benefit of not truncating a file with no line ending to a single newline character. :-)  You might have another way to assure that.
Good point. I don't use mingw, but I'll keep it in mind.
Capitalize sentences. Move this above the if since it describes the behavior of the entire block.
Sinces `ArgsPattern` is used both by `expect/3` and `expect/4` I think it should be a type specification at the top of the module with it's own documentation. Specifically, it should be documented that it is a list whose length will also be the arity of the expect function.
This is more "historical apwlib" code that, for now, should be chopped out or at least completely re-evaluated to use the new `time` package.
Right, missed the call to dup(). Still needs a comment though.
Agree, better fail with the correct note.
Don't need value => true and it probably doesn't do anything.
Let's go with the excess check and add a separate ticket to indicate that the behavior is restrictive and if down the line a client doesn't like this, we could add a config option to make the relax the check.
this log line is swallowing the exception.  Makes it very difficult to debug :).
another problem here is that the link is on different lines.
Oops! My mistake. Will correct it now
Fixed with true
There should probably not be any reference returns in this diff at all. I'm going to stop commenting on them now.
request_var doesn't handle $_FILES afaik. I have a separate ticket for that.
Space after `if` please
well do you think it should be backwards compatible?
Could be something like

´old_function()
{
    $return = new_function();
    return $return['tz_select'];
}´
Oleg wanted to change this line again.
Yeah this will need to be replaced with stable before it gets merged (zend framework 2 should be released by then), this is also why 2.0.x-dev was installed for the event dispatcher.
shouldn't it be just:
db_migrator
?
I asked the same, and im still in favor of doing it (add it to action)
sscanf is slightly unsafe, but I don't think it's a blocker
Added configurable SRV records.
Eventually we will support POST too. Please don't use this heuristic.
每个人配置不同
这个可以拿掉吗
:question:
We do not need man. Will remove
It is, line 128:

     * @param {string|object} id Unique identifier of the mark, usually
     *      the requestId or a command object.
Document the constructor and parameters in the form of "Initializes a new instance of the xxxx class, with the provided message"
Auto-property instead?
in the timeout test, I discussed with Saptarshi and John,
we are unable to find a proper test which can test the message 'connection
error'.
so as per our discussion I did this for right now.

and I also face the problems while adding my code, I just added 2-3 lines
but it shows whole code changed, i just dont know why its happening...
... and what the boolean argument means/does.
Den här raden är onödig
That's what `data` was originally for, but, don't think we will use it. At least not now.
Good point - I've changed the FK names to use create_index_name so this is all solved in one place.
jslint is notoriously whiny. I agree with Peter on this.
1. I like the style.
2. Don't change the signature of `jQuery.fx.timer`... doing so would break the `elem`/`queue`/`anim` symmetry between `Animation` and `.stop `, and hide the fact that those values are actually placed right on the tick functions.
 * ...unless you have an idea for using the values *without* `extend`ing the provided tick function, in which case I like explicit parameters better.
In the beginning of each line, we use a tab currently. 

So we should only use tab in the beginning of each line. Is that right? Or, should I change all of the tabs in existing files to 4 spaces?
It looks like indentation is inconsistent.
Hmm, madlib--{version}.sql is a generated file. So I do not see any more why the .control file should be changed.
That should be http://support.mozilla.org/ .
Why do you need the extra "blank=True" here?
Yeah, openjpeg is installing as standard. Perhaps the include paths were unversioned in the past, and they're written for that rather than 1.4 or 1.5? (Not sure how 1.4 handled include paths, but it wasn't mentioned in the 1.5 whatsnew, so...)
Yep, feel free to change both, cheers.
I'm guessing you didn't mean to leave this print statement in.
First of all, I would rename this class to ``FlowNotes`` or something like that to separate it from the base ``Notes`` class.
Ok, I was halfway rambling above yesterday.. sorry about that.

So the delete is only there avoid diving into the applications block after the recursive call below (we're not interested in looking any further inside an applications block).. So for the exact same reasons as it's there in line 34
And reference the same property here instead of doing this function call and whatnot.
Yeah, I think it makes sense to recommend dot for everyone.  That's the standard for reverse-domain-name identifiers anyway.
Should the string ids (but not the translations) be up-to-date in the 3 language files? If so, GENERIC_ERROR needs to be added to de-DE.
Is the difference in the third box-shadow parameter (2px before vs 1px after) intentional? Doesn't seem like that would animate cleanly.
Chrome is opened with a 404 page with this text:

"Not Found

The requested URL /path/does/not/exist/citrus-cafe.php was not found on this server."

So, that seems pretty clear to me.

@njx Do you think we need a modal error dialog?
If someone goes and deletes stuff out of bracket's program folder, then they deserve an error or two. Are there any other reasons the welcome project wouldn't be readable?
I did a test run with [jsperf](http://jsperf.com/regex-test-vs) and it seems that regexp.test() is around 30% faster.
I think I prefer the previous version of this comment. Much clearer.
http://www.python.org/dev/peps/pep-0008/#other-recommendations
Oops, forgot to change this ;)
In the interest of full disclosure, I was going to rewrite the functionality in `merge_base` in C. I just didn't want to be exceedingly nitpicky to @spraints on his first Rugged PR. :)
OK, please improve the translations. They are really not good.
move onto line above `} else {`
it seems that way now. I was touching actual content in these files in an earlier version of this patch, but didn't end up using it. If it's a big deal, I can remove all of these.
don't need to declare update options
remove this and change it to
<pre>
hidden: true
</pre>

The plugin itself doesn't use a target, and having this here would confuse the user when a target list is appearing in the editor.
9 times out of ten they fail to load, and you're left with a gray map div.
A draggable is aware of the droppable it is being dragged over.

This makes the drop function much easier with so many events.

https://github.com/mozilla/butter/pull/292/files#L3R470 is where we do the drop. I actually see a bug here though, should look like this:


      if( !_droppable && _revert ){
        element.style.left = _originalPosition[ 0 ] + "px";
        element.style.top = _originalPosition[ 1 ] + "px";
      } else if ( _droppable ){
        _droppable.drop( _draggable );
      }

If there is no droppable, and we're revert, we revert, otherwise we try to drop. I am actually having a hard time seeing the use of revert, so I may be using it wrong.
Sounds good to me, filed https://webmademovies.lighthouseapp.com/projects/65733/tickets/595-messages-when-starting-cornfield-are-deceiving#ticket-595-1 for that issue.
Right here, the `1` should be replaced with the page number the annotation is on (as well as the `1` a few lines up).
I'm looking into EVAL now, and I'll probably go with that option (saves several network roundtrips).  It looks like redis 2.6 is getting close to release, so it seems reasonable to start depending on this.

Thanks,

Russ
I see 4 {} but only 3 params.
NexusEmailer is an iface. Maybe to some util class in same package?
This one should be closed too
So, I could be missing something here, but why do you have the `func_1arg_float` macro defined twice?
Identation level looks off here.
use:
:name => 'some_shorter_name'
No, this option is there only for adding classes, those two (grid_n and la/ra) will be there always.
Good catch; will fix.
There are some incompatible changes in apipie and foreman_api gem.
Feel free to ignore.
rawResponse
Why do I need to cancel the sleep menu timeout when the screen is not enabled?
Do you know if the gzip and bz2 readers will fail lazily?  In other words just try to read the file as gzip or bz2 and catch exceptions.  That would be fine if they both fail as soon as they know the file doesn't conform to the gzip or bz2 format, without reading the whole file.
I like "pretty strongly inconclusive" :)
Lol I guess you could move this to a signal handler for proxyIpValid now, instead of here (though I think this is fine).
So more like -maxdebuglogsize, which can be set to 0 (not limited) or or to a certain value that sets the limit, when reached, debug.log gets shrunken. I like this idea, if you would keep a default value.
I would follow our own style and have combined getter and setters like mark suggested
indeed a good idea. doing it i noticed i had at least in one position missed to do so.
Are you trying to measure how long it took to authenticate - or are you just noting when it happened? Because the message looks like you'd want to just time stamp when it happened, not measure how long it took.
Also, if self() gives unicode, then `str(self())` will fail unless we have casting.
Or perhaps I should say - in this specific blacklist manner, rather than whitelist, which is easy.  This does 'compare everything *except* stuff not preserved', whereas more common is probably 'compare the keys I care about'.
The test run appears to confirm my suspicion.
As above, I think it should fail if the input variable doesn't exist.
Are you hiding the entire output_area for that cell?  If so, won't the javascript be unable to append things to the output area and have them show up on the screen?
I guess I am +1 on Fernando's comment about disabled->enabled.

On Fri, Aug 10, 2012 at 12:59 PM, Fernando Perez
<notifications@github.com>wrote:

> In IPython/core/history.py:
>
> > @@ -81,12 +83,32 @@ class HistoryAccessor(Configurable):
> >              ipython --HistoryManager.hist_file=/tmp/ipython_hist.sqlite
> >
> >          """)
> > +
> > +    disabled = Bool(False, config=True,
>
> Just one issue that I see: I tend to prefer config variables that are
> positive, to avoid having to write code with effectively double-negatives. if
> not disabled is harder to parse mentally than if enabled, and for the
> other case, if not enabled is just about the same mental load as if
> disabled. So I would vote for changing this one to have the config
> variable be enabled.
>
> I know it will require flipping all the logic in the PR around, but it's
> easy work. Happy to discuss if you disagree, but let's go over it before
> merging...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipython/ipython/pull/2278/files#r1354995>.
>
>



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
If this script depends on being in a kpython environment, I take back saying it should be in monitorlib. If it's krux-specific, let's not put it in our open-source stuff. Conversely, if it's not krux-specific, let's not encode kruxisms.
This should be `web.png`.
doesn't need to be escaped.
Not sure yet what those short names are for, but I'd rather go with ``psql`` for postgresql and maybe ``es`` for elasticsearch, those are the most commonly used short names.
Actually, I just realized that this is strictly equivalent to: 
``$top_crasher->{'startup_crash'} = (round($top_crasher->startup_percent) > 50);``

Simple is better, right? :)
The useful comment is being replaced by `None`. @AdrianGaudebert ?
We luck out here because `\.` isn't an escape sequence, but consider making the outer string a raw one to avoid future surprises.
Please do, retry should be in there.
I'm pretty sure we'll want to only call this for non OSC flavor. Or we could add switching in chef_db.
Will do, first time really adding those..
Make sure this does not break if this Config object has no filename.
That's the easy way. I prefer a "is_a($value, 'Elastica_Query_XXX)" but I don't know how to ask about all the Elastica_Query classes.
By the way, it seems to work :)
Yes, typo. I probably incompletely removed a previous annotation that used "override" instead of "implementation". I will remove that word.
чому прибрав і де в такому разі файл міграції?
'' should probably be treated as null. And then you dont need to iterate.
This would be a BC break in 2.0 and doesn't comply with the `MatcherDumperInterface`
this extra docComment should be removed
I agree too :) I will fix it tonight
``for (elem = 0; elem < elements.length; elem++) {`` would be a better way to iterate over the JS array
This is totally broken. There is no ``generateUrl`` function
Removed in amended commit
@croaky and I discussed this in person. We both agree the instinct to use a predict method out in the if block is a good thought, but the name would need to end with a question mark and be made more specific. After expanding the name out to invitation_owner_same_as_sender? the line is basically the same and the value of extracting the method begins to diminish.
vay khodaye man !!!
in code haro az joloye chesham doooooooor kon
ina ro ki neveshte
I thought it was easier to display then when i have to diplay archived/archiving/archived.

I think it may have done better using 3 strings in a tuple, ("Archive", "Archiving", "Archived")  instead and using them when needed
Hmm, the const_cast makes me nervous here but I suppose valid_file is still conceptually const.
Empty line needed after multiline comment.
I'm good w/ using that as a standard
``console.log`` should probably not be in the final version we merge.
should be: `enter:`
The parse phase makes services available on the deployment unit that are needed by the OSGi install DUP. Only when parsing is complete, we know whether the OSGi subsystem needs to get activated or not. Only when activation is complete, we can install bundles to the Framework. 

There is also a long outstanding issue (https://issues.jboss.org/browse/AS7-3585) that is concerned with aligning the phases in general. So REGISTER should really be called INSTALL and INSTALL should be called ACTIVATE (or similar) This however needs to cook a little more and for the time being I thought REGISTER would do as a name.
You could use the one from Constants here
Este fue el nuevo nombre que quedo en el comentario aunque el archivo se llama altas?
spelling: PONTOON_WRAPPER_TAR -> PONTOON_WRAPPER_TAG
You should explicitly cast the returned value here to `int`, to avoid warnings when compiling with clang and `-Wshorten-64-to-32`.
Any reasons for keeping this file?
Origin based is good! Thanks for the info.
You may be able to do one call to .concat
_I'd really like this comment to be addressed._

I'm hearing that we **need** facebook to be part of the contact app because we don't have inter-application communication.

But since the facebook contacts are **not** persisted in the mozContact database they won't be accessible from any other applications reading the mozContact database.
So the **only** way to access them will be through a PICK-contact WebActivity.

Why can't we have a FacebookContacts app handling this type of WebActivity, then when I need to pick a contact I'll be able to choose between my classic contacts or my facebook contacts.
result == true means we confirm the resend and app will try to send message once again.  if result == false, we will cancel the resend and do nothing.
six (data-state="new")
FTR, this is the main fix in this PR…
On 05/06/2012 17:02, Timothy Guan-tin Chien wrote:
>> @@ -36,6 +38,11 @@ function AppScreen(apps) {
>>       // Ignore the homescreen application itself
>>       if (app.origin.replace(lastSlash, '') == currentHost)
>>         return;
>> +
>> +    // XXX: Ignore System Apps
>> +    if (app.manifest.hackHiddenFromHomescreen)
> That would result *UI Tests* being ignored :( But Adding an icon to the UI tests app will fix this.
>
> I would say ignoring apps w/o icon is still a hack though.

I agree that it is still a hack but I think that's less dirty than: 
hackHiddenFromManifest.

There is a need for a different way of listing/showing apps. Sometimes I 
think that it can be solved by having a main activity on the app and 
using that to fill up the homescreen. If the app does not have a main 
activity (because this is a keyboard, or because this is an homescreen 
or a system app) it will not be show on the homescreen. Also if the 
manifest contains more than one main activities it means that there will 
be multiples icons on the homescreen for the app (for an app that does 
multiples things for example, like the dialer/contacts) app.

What do you think?
Should just create the scheduler once instead of recreating it each time you want to call schedule. This lets scheduler implementations keep state if they wish (I implemented this here on top of your pull request: https://github.com/nathanmarz/storm/commit/fce57833e3bb6e311878f160b283008808a607ed )
OK, I`ll take a look at that BatchCreator. I don`t inisit on this at all.
urls.FirstOrDefault() instead of Count check.
I thought about it, it certainly felt odd to do this sort of thing in Python. But I started to type it out and it got really clunky to read, IMO at least. The perform a bit better part is intriguing to me though. Do comprehensions have a considerable performance benefit over something like this?
Right. So full-fledged docstring would be:

```python
"""Short line description

Long description goes here.

Args:
    argument_name: type argument description (preceded by 4 spaces)
        which can be very long...
    second_argument: type ...

Raises:
    MyError: description when the exception is raised

Returns: description
"""
```

More expressive examples here: http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Comments
あなたの権限で見れるジョブの一覧が表示されます。

→

    あなたの権限で見られるジョブの一覧が表示されます。
before
    
    "--"

after

    "\--"
Lines 5-7 could be one single line: `(namespace 'Slotcars.tracks.views').PageView = ...`. Remember the uppercase 'S' of the 'Slotcars' namespace (as long there is no final decision about namespacing).
Don't change the version when submitting a pull request. Let the library's manager choose which version goes with changes.
yes it should be. i will change.

On Fri, Dec 21, 2012 at 2:18 PM, P. Oscar Boykin
<notifications@github.com>wrote:

> In src/main/scala/com/twitter/scalding/Operations.scala:
>
> > @@ -73,6 +73,23 @@ import CascadingUtils.kryoFor
> >    }
> >
> >    /*
> > +   * BaseOperation with support for context
> > +   */
> > +  class SideEffectBaseOperation[C] (
>
> Should this not be abstract?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/scalding/pull/257/files#r2491855>.
>
>
I'm no regex expert and find it detracts from readability.
Username and password are only needed if the user has disabled the API Key, if this information is saved and the user has APIKey enabled, we're needlessly sending their credentials with every request, not sure if we should do that.
missing backtick after ``update``
The 'edit'? I'm not sure I understand, but I'll figure it out.
Sotty, to fix this, I think that all that is necessary is to add an alternative for the  "~=" operator. At the moment, this grammar does not support it.
The PackageBuilder has become really messy, it might be a good idea to extract the bean generation part and rewrite/optimize it in a dedicated class
We need to do some device testing to see if we have lost any users because of this... @commuterjoy 
I will liase with Kay.
This file is now deleted. Now there is only one flag file.
exatamente
remove this route also
No particular reason, just used to type `==` ;)
intentional console.log() ?
My bad. Doing `__import__('filethatdoesntexist')` will raise an `ImportError` too. My worry was that the import might have worked initially but within the imported file there are subsequent `ImportErrors`. 

Fine. Let's leave it but can we add some sort of logging?
Added the try/except around verify_request and set the status to 403 on oauth.Error.
Can you please get a reference to this service once and store it globally. When will those values be deleted from the session store file?
Thinking about this some more, Numeric is a poor test, because it would allow decimal values. A better test is that it responds to `#times`.
Thanks.  I swear I did that at least once already.
This is wrong, don't use `File.read`, use `Gem.read_binary`, see other places where reading of binary contents is performed.
Can you move this logic to ``_on_zmq_reply()``?  There's still the possibility of an error occurring when it serializes the message.
helpers.ycp is missing from the pull request. But IMHO having both routines and helpers is overkill; simply put the functions to this file.
@necromant2005 this is also in the compiler definition.

Also, what's exactly the use case of this? Not sure what it fixes (should have a test)
We should go with `callable` for forward compat purposes.
As noted previously, this inhibits understanding of the code; having elements on the following line, while technically correct, groups them in a way that makes understanding the hierarchy harder.
`un`,
Non saprei invece cosa mettere al posto di strato...
Ok, will check it out (sounds like a problem with double-encoding, which makes sense) - looks like you fixed this on the govsearch side by having the caller urldecode() before passing the url to the twitter dataservice, which probably means http_build_query is right here, and I'm ok expecting callers to pass encodable-params.
if you need a kernel and its container, why not extending from the WebTestCase instead of hardcoding the path to the kernel here
Pass it via the model.
username = username.Substring(ldapDomain + 2) would be safer. In the event that token recurs elsewhere in the username
omg, eval!!
or could u just check all changes this time... and merge it all? I will make sure we won't have same problem again next time..
Ref the review, remove this list item.
Can we keep the indentation please?
By default should be empty.
Should probably have `@var`
intersting, this code is never executed if you can just change it this way.
Maybe even merge the previous with this test?
use self.log instead of self.logger (most of the other VSC-tools code does too)
This should throw an exception just like the OAuth1 ResourceOwner

    if (null === $code = $request->query->has('code')) {
            throw new \RuntimeException('No code provided in the request.');
    }
On 19 November 2012 14:03, Austin King <notifications@github.com> wrote:
>
> In lib/i18n.js:
>
> > @@ -68,7 +68,7 @@ exports.abide = function (options) {
> >          default_locale = localeFrom(options.default_lang);
> >
> >      mo_cache[l] = {
> > -      mo_exists: path.existsSync(mo_file_path(l)),
> > +      mo_exists: fs.existsSync(mo_file_path(l)),
>
> Does this change the minimum version of Node which we would support?

actually, it does, it breaks 0.6.x
you have another patch in your issues (from a node bot) you should
ignore this one.

> Would be good to check if fs.existsSync exists.

yep, actually, it just kills a warning message, exists(Sync) has just
been moved from path to fs.

--
Niv Sardi
Move the declaration to the top of the function, you can still assign it here
please add this test to `./test.js` in the same style as the other tests in that file.

Thanks!
D
I'm neither good to write meaningful description nor mother tongue, so please improve :)
@ohadlevy, you don't need to include this.
think I had both in there at one point and picked false for reasons that I can't remember. It should be nil then?
You are right. This is manually formated. I'll use auto-format from now on.
For simple string searches like this, you can avoid using regular expressions and do `title.indexOf('Viewpoint:') != -1`
Use StringBuilder, not StringBuffer.
1) changed to fine though I disagree. This just an example resource, people are expected to make their own and to log their own stuff at the suitable prio. This is info so that when you start it, you will actually see the log (default=info), which is good when learning cloudname.

2) I know nearly nothing about base counters and I am not sure every app needs them. Unless you have a concrete proposal, I'll just add a comment suggesting it.
This is not an actionable comment. What do you want me to do? Delete the line, rename the test, ...? Please tell.
Small corrections in the English translation
sounds good. I'll have it default to git protocol, but let you specify if you want a different one.
Unless you chose to use a class instance variable for a specific purpose, could you switch this to a regular instance variable? We avoid class instance variables in our codebases.
I'm not sure that this line is entirely accurate - I mean, at least as far as this function is concerned, you are only passing in one centroid to compute variance against, not dynamically picking the closest centroid to each point. I think that there should actually be centroids for all the clusters passed into this function, but I can't really be sure since it's not being called anywhere (at least as far as I can tell).

Now, looking over this led me to go back to @afoglia's notes, and it seems as though he is assuming that mu(i) and mu_n are always equal for x_i in D_n (this is in step 3, from the email sent on july 14th). I'm not saying this is wrong (I don't feel like I have a good enough grip on the context to say that), I just wanted to bring it to everyone's attention and make sure we're ok with it.
I'm not sure if you should handle all options in this way or if you should handle options case by case...
No, in fact I did a bit of hallway usability testing on this and that was uniformly *less* comprehensible. Three different people said it should be a refresh button, so perhaps instead we should use:

<I class="icon-refresh"></i>

As its label, (that's typed from memory; I'll double-check when I'm not on my phone.)

--------------------
http://anildash.com +1 646 833 8659

On Jul 17, 2012, at 7:27 PM, Gina Trapani <reply@reply.github.com> wrote:

>> -ThinkUp is capturing your social data. The log below lists the technical details of what's going on.
>> -This could take a while. Leave this page open until it's complete.
>> -     </p>
>> - </div> 
>> -<br />
>> -<iframe width="850" height="500" src="run.php{if $log == 'full'}?log=full{/if}" style="border:solid black 1px">
>> -</iframe>
>> -<br /><br />
>> -    {include file="_usermessage.tpl"}    </div>
>> +<div class="row">
>> +
>> +    <div class="span3">
>> +          <div class="sidebar-nav">
>> +            <ul class="nav nav-list">
>> +              <li class="">
>> +                Update ThinkUp Data
> 
> Change this to Capture Data?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ginatrapani/ThinkUp/pull/1361/files#r1184257
убежала память...
General comment: much of this code seems to be aggregating or joining with ,GROUPID as an element. Would it be possible to distribute all of the data by group_id and then run things in ,LOCAL ??? (or better - use GROUP on group_id)
browser id is disabled on AMO  and these tests just need to login. 
It would be better to  have command line that will dictate the login method
In my opinion LF should be forced for all files across all OSes for consistency. I.e. if I zip the repository on Linux and zip the repository on Windows, the content of the zip should basically be the same. This statement does not seem to ensure that.
Done, I only found one place where this was necessary to get the `recaptcha` values.
I think this API should be responsible for URLEncoding the dynamic URL elements. This is a general statement for all URLs assembled by the REST API.
This has been fixed by the introduction of `server.js`
Do we need these tests?
I'm assuming that the admin UI's will be hosted by nginx at some point which makes these tests obsolete?
A 204 is not appropriate here I think. Should be a 200.
We should probably validate the displayName as well here.
It's enough to build the project just once. It's the same in all debugger tests. Since building takes 8 seconds on my iMac, I think it saves a lot of time.
Fix Packs are a different thing. We used to refer to maintenance release with the term "Service Pack" but I think we are no longer doing that, so I would remove it too from this paragraph.
use addClass( 'error' ) instead
Do you mean that we should not use @requires in Geocoder ?
yes, I think it will work, although I still think it is better to not pretend it is a Filepath and do something like head . reverse . T.splitOn '/'
This is very dangerous. Now any user can update any attribute of another user. Since we haven't studied mass assignment yet, we haven't reduced the points. Otherwise, good job!
Always use `elseif` (no space).
Might as well change the comparison operator to `===`.
Для тестирования, видимо
А, ок, понял. А "count < percent" будет работать только если количество элементов = 100?
Если вспомните, то дедлайн изначально был к третьей лекции, в которой, кстати, разбираются некоторые моменты в проекте. Ваше дело, когда смотреть лекции, но лучше смотреть их на момент выхода, ИМХО. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
@slebedev ну вообще я согласен
Метод init определен в .h файле NSObject, повтор не нужен...
насчет адаптивного кода согласен, конечно же на все 100...
I did actually… but it doesn't work properly, so I have to make this workaround… :(


On Oct 23, 2012, at 6:08 PM, Chuck LeDuc Díaz <notifications@github.com> wrote:

> In README.md:
> 
> > @@ -13,6 +13,7 @@ It never changes your source files (unless they don't yet exist, in which case t
> >  
> >  Add this line to your application's Gemfile:
> >  
> > +    gem 'ya2yaml'
> can't you just add this to the .gemspec dependencies?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
nodeDir should probably get set somewhere in `getTargetVersion()` IMO
How about `+isOnMainThread`?
@tigran123 After I remove this line reflow mode still can be restored when reopening the document. But I found that in EMULATOR mode kpdfview cannot remember last reading position. Is it a bug?
还是不一样的，加减乘除需要返回无符号数，而比较是返回布尔值。
If I'm not mistaken this produces a deepcopy of all the data even before indexing, which would not be very efficient. Also, should users modify the Epochs' ._data? If not, why not let numpy decide when to create deep copies of the data (and internally only deepcopy before actually modifying the data)?
split-apply-combine combine?
we can delete this line as active_set is overwritten in line 244
why do rejection for meg channesl?
please keep the explicit parameter naming otherwise it's impossible to know what 0.6 is even if you have to do filter_method=filter_method
You are absolutely right. This should be reverted. My bad.
I don't think this currently  refers to anything, but I can easily address this post-merge
Actually, scratch that. You're right: this is something to clean up once we have a Vector type. Dotproduct shouldn't really exist as a `Matrix` method.
This should be:

    method is called by implementing :class:`Symfony\\Component\\DependencyInjection\\Compiler\\PrependExtensionInterface`
@smoya it should be:

    * @param FormView      $view
    * @param FormInterface $form
    * @param array         $options

how it is now:

    * @param FormView $view
    * @param FormInterface $form
    * @param array $options
Oops, corrected.
What about system.registerOnTerminantion(...) ? Is this TS.
If so combined with above, this is good enough guarantee.
Yes. What I did.
Предложи лучший вариант. Я не придумал. Посмотрел в блогило - у них также.
sizes can define here
Is this because the key is just the url rather than a key for the exact item?
We shouldn't be referring in functions from other tests' namespaces, generally.  I know i've done this *once* but let's not make a habit out of it.

Why not?

Because when content-search has a compile problem, we don't want systems to have a compile problem too.

setup-org should go somewhere else, maybe in katello.fake-content.
```->``` is used to thread multiple forms, but you only have one.  So ```->``` does nothing here, you should just remove it:

```clojure
(let [mykey (slurp "http://inecas.fedorapeople.org/fakerepos/zoo/RPM-GPG-KEY-dummy-packages-generator")] 
 ...)
```
I've added a `fight` array where I save all the moves of the fighter for the match. Then I can acces to this array with fight method.
remove this and ensure LDAP connection
revert brackets
Ooh, this is the part where I'd like to have Aperture and PSF sub-classes with dimensions specified in arcseconds.
Usege 的写法不对吧？

[] 是可选，应该是?

Usage: php SearchBuilderJob.php { rebuild_all | build | build_since } type_name [since_time]
Looks like you keft this one out.
Why set it back to false?

Also, you're not reverting the skip locking flag?
On 2012/08/20 3:35 AM, Michael Droettboom wrote:
> I don't know if this ever made it into the code guidelines, but we've
> tried not to have unicode-encoded files like this, but instead use |\u|
> escape sequences for unicode characters. I know it's not as obvious --
> but some developers are still using editors that don't handle unicode
> encodings correctly -- I'm not one of them ;)

Thank you.  I *am* one of them, maybe the only one.

This may help: http://www.utf8-chartable.de

One incredibly verbose but effective mechanism for including unicode 
looks like this:

u'D\N{LATIN SMALL LETTER E WITH ACUTE}velopp\N{LATIN SMALL LETTER E WITH 
ACUTE}s'

String substitution with %s can be used to make it shorter.

Or one can use this:
u'D\xe9velopp\xe9s'

again with the option of string substitution to make it a bit clearer.

Eric
Just a formatting fix
Simple yet sweet.
Minor nit - you could probably pull out this for loop launching logic into a separate function
ooh good catch I totally missed that one, I added \*request\* to middleware originally and than forgot to change this
I don't know how strict we want to be on this, but my understanding is that we wanted to move away from <#define>s and instead use <static const>s i.e.:

<static const int BOX = 5;>
В этом методе нет аргументов. Внутренние переменные вполне прилично называются. Про Form не понял.
it would be REALLY helpful if you could specify the expected result of classes by using unit tests
By doing that and aliasing the sub-selects appropriately, you can just return `PSU::db('cts')->GetRow( $sql );`
It was introduced in Facter 1.6.2 ([ticket here](https://projects.puppetlabs.com/issues/6792)) so I think that's fine as far as a dependency goes, but adding a note couldn't hurt
Also, should this be doing a parseInt ?
@jsloane has a point, although it's rather unlikely that the locale will produce an invalid language I've tried it out and this renders widgets relying on the translations to fail (e.g. text widget). I've attached some screenshots of errors I see in the JIRA ticket associated to this issue. We should default to English if the language is not found.
Careful here!
If feat==m_features and it has only one refcount, it is deleted and you get an error.
always first SG_REF
Technically yes, although I think it'll still work because PHP methods are case-insensitive. I'll adjust the documentation anyway, so we don't give people bad habits. ;-)
is built, instead of is build
s/future/feature/
Reusing `session_cnt` here looks dangerous to me: if I try to think through all of the cases of sessions being closed and reopened between the top of the loop and here, it would be weird if this test didn't work, but it isn't at all obvious that it is correct, either.

I think the count should be stashed in a local variable with a `WT_ORDERED_READ` whenever we walk the list to avoid confusion, if not actual bugs.
This is fine to remove this trait and the reason for it has gone away - for completeness' sake, it might be more consistent to inline the body of the old applyReferenceData/1 implementation.
I have no strong opinion on this matter, but at least, it should be documented.
as he thought*
Here too, and the one below
Good point. I actually have tried the "vnode kill" method with the memory backend, but somehow it didn't reliably clear the data. Note that `ets:delete_all_objects/1` is guaranteed to be atomic and isolated; so assuming the test is doing nothing at the moment and no requests are in-flight (a reasonable but not fool-proof on a testing setup), the `ets:delete_all_objects/1` should leave nothing behind.
I think the raw option is useful, thats why I made the code changes to make the option work. My changes also make it possible to pass `{json: true}` which is also helpful.
The catalog is analogous to a DB in a DB System. The JDBC driver will always report one catalog, which is the target "HPCC System"
@iain is there a way to get around this ugly bit of code?
Should be `$(document)`, not `$('body')`. Same below.
this is now in the same namespace too
Please use some other class for this text. It looks really ugly with red background. Probably reuse the class which is used for marking invalid forms after Django validates.
Maybe ```id``` ?
You probably want here `request.session.get(MOCKING_SESSION_KEY, False)`.
I thought that panel will display a list (similar to user list) of all venues around the location, and its open hours. And when you would click on the map, you would get the element in the list scrolled into the view, enhanced somehow to be visible. So panel should be a list of venues, in the order of proximity to the location (order which is given by OpenHours).

Also a search/filter box could be useful.
Here I though of space after `:`.

BTW, for only one key to set, it is probably simpler to use `css('min-height', 50)`.
Find DIV element with id "horoscope-sign-right" and inside this DIV element search for another DIV with class "view-contetn".
First XPath display SPAN tag, second display STRONG tag.
Why do you create a dict here? Why it cannot be simply a string? So that the result is a list of list of strings?
Hi David,

I have the function that checks for datasets as a recursive function. I
did this so that it would be possible to handle hdf files with datasets
hanging from groups and subgroups instead of just directly under file.

For example, 'field/temperature' or field/measurements/pressure'.

In general, we would need that.

For such recursive methods it is easiest to define them so that they dont
return any values, and so I do not have return value for that method. It
just updates a dictionary that is global. I thought that was easiest for
me to understand myself.

Thanks,
Swarbhanu.




On 3/5/12 10:05 AM, "David Stuebe"
<reply+p-518206-36c35db9931799d3a3d47bfaa20e8613a1822c4a-1181645@reply.gith
ub.com> wrote:

>>              if isinstance(node, h5py._hl.dataset.Dataset):
>> -                list_of_h5py_datasets.append(node)
>> +
>> +               
>>#------------------------------------------------------------------------
>>-------------------------------
>> +                # if the name of the dataset (without grp/subgrp name)
>>is one of the supplied variable names of interest,
>> +                # update the dictionary for relevant datasets
>> +               
>>#------------------------------------------------------------------------
>>-------------------------------
>> +
>> +                dataset_name = node.name.rsplit('/', 1)[1]
>> +                dataset = node
>> +
>> +                if dataset_name in var_names:
>> +                    dict_of_h5py_datasets[dataset_name] = dataset
>
>This is a neat trick using a local variable that is not yet defined, but
>it is confusing. Is there a reason this could not be a return value from
>this method? What do you think would make the code easiest to read?
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/ooici-dm/pyon/pull/29/files#r518206
See below. better to use django's default 500 handler view, which takes no context; if a 500 error occurs we already threw an exception - better not to compound it by attempting more logic.
i failed while testing with gm mode on xD
i'll update this pr
IMO you shouldn't implement them, let the script user handle it.
Why not just have one button that shows you the current revision as plain text?
Same as https://github.com/doctrine/DoctrineModule/pull/17/files#r800204