RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=92202

Reviewed by Beth Dakin.

Source/WebCore: 

Test: fast/writing-mode/positionForPoint.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPoint): Fixed two issues, each of which are covered by
one of the sub-tests in the new regression test: (1) changed to compare children’s logical
bounds against pointInLogicalContents, i.e. compare childern’s horizontal bounds to the
point’s horizontal component; and (2) changed to use logicalTopForChild and
logicalHeightForChild, which account for this block’s writing mode, instead of logicalTop
and logicalBottom, which are based on the child’s writing mode.

LayoutTests: 

* fast/writing-mode/positionForPoint-expected.txt: Added.
* fast/writing-mode/positionForPoint.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Avoid moving child objects multiple times when vertical scrollbar are shown at the left side.
https://bugs.webkit.org/show_bug.cgi?id=91756

Reviewed by Tony Chang.

Source/WebCore:

My r123067 moves the top-left origin of an RTL element right when its vertical
scrollbar is shown at its left side. (That is, r123067 moves all child objects
in the RTL element right.) This change also increases RenderBox::clientLeft()
at the same time, i.e. it also moves child objects right. Furthermore, my r109512
moves positioned objects in an RTL element right at the same time. This makes
WebKit move objects in an RTL element up to three times by the scrollbar width.
(Moving an absolute object right increases the scrollWidth value and it causes
this bug.) This change removes unnecessary code that moves objects right in my
r109512 and RenderBox::clientLeft().

Test: scrollbars/rtl/div-absolute.html
      fast/block/float/026.html
      fast/block/float/028.html
      fast/overflow/unreachable-overflow-rtl-bug.html

* dom/Element.cpp:
(WebCore::Element::clientLeft): Increase clientLeft value by the width of a vertical scrollbar as written in the CSSOM specification.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects): Removed unnecessary code.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): Removed unnecessary code.
* rendering/RenderBox.h:
(WebCore::RenderBox::clientLeft): Removed unnecessary code.

LayoutTests:

This change adds a test that compares CSSOM properties of an RTL element which
includes positioned objects with the CSSOM properties of an LTR one. This change
also uses clientLeft properties in offsetX-offsetY.html to remove a hard-coded
value in the test and adds rebaselined results for Windows.

* fast/events/offsetX-offsetY.html: Replaced a hard-coded value 'borderLeft' with clientLeft.
* platform/chromium-linux/fast/block/float/026-expected.png:
* platform/chromium-linux/fast/block/float/028-expected.png:
* platform/chromium-win/fast/block/float/026-expected.png:
* platform/chromium-win/fast/block/float/028-expected.png:
* platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
* platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
* scrollbars/rtl/div-absolute-expected.txt: Added.
* scrollbars/rtl/div-absolute.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Tests] Remove duplicated fast/forms/number/number-spinbutton-events.html
https://bugs.webkit.org/show_bug.cgi?id=92205

Reviewed by Kent Tamura.

This patch removes fast/forms/number/number-spinbutton-events.html
because fast/forms/number/number-events.html covers and checked more.

r108955 is an evidence of coverage.

* fast/forms/number/number-spinbutton-events-expected.txt: Removed.
* fast/forms/number/number-spinbutton-events.html: Removed.
* platform/efl/Skipped:
* platform/qt-arm/TestExpectations:
* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Move renderingStats from WebView to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=92184

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

We are going to add some rendering stats that work in non-composited mode, so the renderingStats() method should be moved from WebView to WebWidget.

* public/WebView.h:
(WebKit):
(WebView):
* public/WebWidget.h:
(WebKit):
(WebWidget):
(WebKit::WebWidget::renderingStats):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Tests] Rename fast/number/number-events.html to number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92208

Reviewed by Kent Tamura.

This patch renames fast/forms/number/number-events.html to number-spinbutton-change-and-input-events.html
to make file name explains what test will be done.

* fast/forms/number/number-events-expected.txt: Removed.
* fast/forms/number/number-events.html: Removed.
* fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Copied from LayoutTests/fast/forms/number/number-events-expected.txt.
* fast/forms/number/number-spinbutton-change-and-input-events.html: Copied from LayoutTests/fast/forms/number/number-events.html.
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123576 268f45cc-cd09-0410-ab3c-d52691b4dbfc