labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, I basically followed the pattern of `NSTextView+RBLAntialiasingAdditions`. So should I change it to `imp_implementationWithBlock`?
Fix this and merge by yourself.
Every theory exercises every data point.
Agreed, this got pulled through automatically in the forward-port merge from the implementation in 1.5.5.  Moving.
ack, if the result is a pure message and should be re-usable, feel free to move to the XmppMessageBuilder
this should probably be (i.e. `1`), the above refers to the preceding example, not the value of the int.
this output...
I would drop the options section, to avoid redundancy with the documentation of createCollection section.
ah, much nicer. I felt dirty when I did `+ '/' +` but I thought we'd only do it in one or two places. /me should know better
How about `if` here?
You'd need to migrate the users or all our existing users (and their stats) would be rendered unusable, right?
Just following what has already been done in the rest of the file.  If that's not necessary then I'll remove them.
Typehinting `array $options = array()`
Well, I would keep `we are afraid` instead of `then`, it seems to be more polite IMO... Or it is the lack of accuracy the reason it has been changed?
Another bad `<br />` here
This sort of code should not be in our test suite.
Since you are using this variable elsewhere it needs to have phpbb prefix.
ah. the luvit json generator needs a key to generate a table instead of a JSON array.
indentation problem? ^^
I wouldn’t replace regular loops in hot spots if they don’t consist of a single function call, but rather contain inline code. Stuff will be running every frame, so reducing overhead is a good thing in those spots, even if not as elegant.
Hm, I’d just test whether the `append()` method of the fake node has been called with the root node of the movie. E.g. like this:

```js
var targetNode = createFakeDomNode();
spyOn(targetNode, 'appendChild');
spyOn(document, 'getElementById').andReturn(targetNode);
var renderer = new SvgRenderer('thing', 1, 1);

expect(document.getElementById).toHaveBeenCalledWith('thing');
expect(targetNode.appendChild.).toHaveBeenCalledWith(renderer.svg.rootContainer);
```

That should do the trick
Again, whitespace
I commited this one change separately. I added a comment line which now prevents automatic merge of this pull request. Please, make another commit to your dspace-with-dynamic-configs branch that removes the change to this file - that should fix the automatic merge.
@Raynos it's still sortable, but shorter, I know some users are interested in byte optimizations! (like @owenb :)
I think that is a bit easier to read
there are a couple of hard-coded version string in this file that are repeated several times. Perhaps refactor the values into constants so it's easier to change version and not risk missing to change it in one of this locations.
code style: "Do not mention your author name directly unless required by the convention (liquibase-only)."
https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Coding+Standards
See note above regarding using an enum or values object for the page names.
if true, it loadDB bypasses the cache, reads from DB, and write to cache.
这个地方需要被重构。一般不需要主动去调用，尤其是内部组件的方法。而是通过函数注入的方式完成。
Why this is needed? I think this function is inherited from _operators.
I don't get what this question means.
What is supposed to happen for the gradient through a graph like the following?

```
x = scalar()
z = x + x * cast(x, 'int'))
```
This documents the new standardized philosophy on how to handle integers in gradients. *Pay attention to this section as it is the main point of the pull request*. The rest of the pull request is just to implement this section correctly.
Not sure why 1 magic number is better than another, here, since it's being used in the same way, as a "not yet initilaized" flag. -- it does NOT represent the initial size USED by calculateSerializedSize -- that's a completely independent and equally mysterious "2".

Note: flattenBuffer is still error-checking for -1 -- which seems like it will never happen, now? Should the code be changed, there, too?

Wants to be a CONSTANT that gets defined, documented, and USED in calculateSerializedSize.

BTW, calculateSerializedSize would be cleaner if it just set m_serializedSize and returned void rather than leaving that to its 2 callers.
Did you mean to check this in like this?
Should be `batch_count` here.
rather than repeat this a lot, I'll just say that return values and parameters should have their units described in the documentation where applicable. (atom percent, mass percent, kg, g, etc.)
Why is this gone? This is important to avoid trying to load shared objects multiple times.
remove views. prefix
This whole new block has to go one line down since
```
.. versionadded:: 1.3
The ``receiver`` decorator was added in Django 1.3.
```
belong together.
'other-built-in-views' links to the original topics/auth.txt
same for this one
database should be `rapns_test` for all adapters. Also leave username blank in here as it is set explicitly in the spec_helper. This should fix the CI failure.
This works in all supported browsers, and probably all browsers period. Testing against `"\xA0\uFEFF"` would be more correct technically, but would cost 4 bytes gzipped.

*Cue someone showing an implementation recognizing BOM but not NBSP...*
Did you lint this before you committed? http://danheberden.com/share/144fc4c.png 

Also, the indentation is all goofed up.
This may be unnecessary.
Using column name or expression makes more stable.
I roll back this change. id 0 is now valid for emotes as requested by Bjorn.
Yep thats correct I will edit this
Other option would be ``type=object`` but I have no idea how that maps with ``gst-launch`` syntax. Ideally this should be a gobject enum we create with on, off and default, and then pass to the property. However, I have no idea how to define gobject types in python.
These are indented 4 spaces, but should be 2.
Because you did this work in setUp() it'll create and destroy the indexes for every test. You probably just want to do it once, so you should do it in ``setUpClass``.
This two-line loop appears to do nothing?
>just setting it to 4.3 seems a bit icky.

It's not like that is a hardcoded value, though; it falls through to using the compiler build numbers to make a "best guess" as to what the corresponding Xcode version would be, and a lot of things depends on that being the case.
If you're really interested in the Mac situation, take a look at the mailing list.

At the moment, this patch is the best situation possible.
OK, got it !
It's better to define regex as a constant, say _RELATIVE_PATH_REGEX.
Some comments on this line of code
Use `%.2f` and `mag_aca_err / 100.0` please.
Can we add some tests for this?  Thanks.
It could but I would like to that refactor when there is a concrete reason to do so.
This probably isn't necessary since it's also included below.
I think we don't do this in unit tests?
For consistency with other existing code, can you replace .forEach calls with $.map? 
ie. unfiltered = $.map(entries, function(entry) { ... return entryStr; });
Is it a typo? thought?
jslint - 'perfTimerDOM' was used before it was defined.
The way that comes to mind is to create some custom events (e.g. panelResizeStart, panelResize, panelResizeEnd) that the modules could listen for.
Also... it sounds like you basically have this figured out already, but just in case it would be helpful to have a little more background here:

The Smart Autocomplete code isn't robust against the case where multiple keystrokes kick off multiple calls to this function -- it doesn't stop listening to the Promises it got back from earlier incarnations of the query string.  So it allows bugs where the Promises it got back resolve in a different order than they were kicked off in -- the last one to resolve "wins," updating the UI based on a stale query string.

In practice that doesn't happen with the Promises we happen to return here, because they all resolve at the same time, in order.  But it could happen if the user switched to a synchronous search mode (e.g. "@") before the Promise(s) resolved.  It also seems a little inefficient to run the full searchFileList() on a bunch of stale query strings before getting to the final "winning" one.

Ideally, Smart Autocomplete would have some way of ignoring stale Promises and only caring about the most recently received one, but it doesn't.  If it did, that would still leave the inefficiency concern (which seems trickier to fix since jQuery doesn't offer a way to "cancel" a pending Promise that's become obsolete).

Down the road it'd be nice if we wrapped this up in an API so that other Quick Open modes could return async results without duplicating this convoluted bit of boilerplate code.  Feel free to file a bug on that if you'd like.
What is this return value? Is it the Menu that the item was added to (so that you can chain calls to `createMenuItem()` as in your examples below)? If so, we should be really clear about that, as I would be more likely to expect `createMenuItem()` to return the created item.
For clarity I would move the added statement as an if inside this if.
It's probably best to throw an exception here; someone has called process with a programmeId, and expects that programmeId to be processed. If that doesn't happen because of an error, then let the caller know and they can decide on how to deal with it. If you log and do nothing, they can't make that decision.
The "contract" for what this function does is kind of odd. It kind of does a few different things, which I feel like should be separated out. First, it's responsible for generating the case export payload. I think this should be it's own function, like `generate_case_export_payload` that this task calls. Then it's responsible for packaging it up either as a `CachedDownload` (which is persisted) or an `HttpResponse` (which is returned). I think these should be also be refactored into their own functions.
User objects are actually pretty big (they include permissions and stuff) so it might be better to send over just the parts they're going to need, like `{'username': user.username, 'full_name': user.full_name}`
Before entering this method you acquired a lock on responseMap. So why is it required again? Also, line 150-156 seems to be repeated?
Need to handle args here I guess
I suppose so. I was just following the pattern you set in https://github.com/hadley/ggplot2/commit/755ddba725c97f0a88a856568a5250bbf34ead2d#L8R60
oh nvm, i see what's going on i think
content for 都可以擺在最上面 (因為他不會直接輸出)
Basically seems like the same remarks apply as above in this file :)
well actually my info wasn't entirely correct, only links for bug is removed, and date of course order of some lines change, but the case stays the same.
I wonder at the value of separating things out like this, given that we don't do this anywhere else.  What's your thinking?
This indentation still looks wrong. Is it a tab inward?
Note: the majority of this file's changes is the result of an indentation reduction.
Alright, probably a good idea
Ahh, okay. Yeah, I'd just do `if (data.data['description']) { … }`  as your conditional test.
Maybe correct this to TH{1,2,3}/!normalize/<float value>/ ?
split `->query` to new line
Guter Einwand, hab ich nicht drauf geachtet.. @utf8 läufts zumindest rund so weit.
All of these branches are unnecessary with the call to ```platform.linux_distribution()``` using the extended set of distros to check. It does the same thing, but in a loop.
Right. I will change the code to not have the null check
...a v OS X "Zobrazení". Se "standardem" ve Windows to nebude tak žhavé, horko těžko jsem našel aplikaci s takovým menu, takže v tom nevidím takový problém. Naopak v OS X toto menu mají prakticky všechny aplikace, takže použiji překlad pro OS X, byť je asi nevhodný ve Windows (i když považuji "Zobrazit" za celkově nevhodné pro *menu*, ale ano, konzistence je důležitá). Tedy do té doby, než budu mít nějak lépe vyřešené používání jiných řetězců pro různé platformy.
Potřebuje předělat na plurál a jako předešlé přerovnat aby to v češtině neznělo divně.
Oh, whoops! Thanks for catching this!
Controversial! I would suggest that something which is not uncommon is *not* necessarily common, so I would choose to replace the phrase with something along the lines of '...because drives are sometimes known to misreport...'.

In any case, I'd consider the existing wording a [litote](http://en.wikipedia.org/wiki/Litotes) and thus correct usage :)
Should be 
              is isa(B, Vector); X = reshape(X, (n,)); end
Why are you calling WriteByte? _stream.Write(data.Array, data.Offset, data.Count);
I did, they're wrapped in ERB comments.

They're useful when testing.
Right. I kept the data from the `webapps` array in webapi.js, but that’s incorrect.
This can be reduced to jQuery(function($){}
I don't know if this matters, so I'm going to poll others: (@eteq, @astrofrog).  We've typically put this sort of really long documentation in `rst` files in the `doc` tree rather than as a module docstring.  Should we do that here also?  (In terms of how it ultimately gets built in to the docs, I think this is fine, however).
Since the `TimeFormat` class can represent arrays, it might as well have a `__len__` method too.  Then the `__len__` for `Time` can just be `return len(self._time)`.
So are you suggesting to move it to ``to_xml`` in ``tree.py``? Should the default be ``overwrite=True``?
It'd be easier to read if you inverted this conditional. 

```ruby
if bookmarked?
  ...
else
  ...
end
```

Or if you really like it this way, use `unless`.
Eventually it makes no sense in C++ anyway, as there are so many types and classes.
This enables it for MAC_OSX too, is that intended? 
I remember boost interprocess had another problem on mac:  it took 100% CPU time.
The fallback WAS in before I edited the file, but it would have failed for Vista and higher. If you are fine with the rest of the changes I can remove this, sure.
i like "_requirePresence" (noun after a verb), but thats just a minor knicknack.
Yup, will move that out.
Do we need this here, we should also see the error without this annotation, no?
@"ok" message is not good enough for failure reports.
Please fix here and in other places.
`SqliteCache`
I think there is something I Don't understand in you comment  :-(
The trace message is display only when the authentication is made and not
everytime because there is a if/return just before which exit when the
remote is already authenticated.
How sure are you about all these parameters?  A quick search gave me a different idea of what parameters this func should have.

-[Unknown]
This should be `url_file`, not `url_or_file`
`sys.executable` should do for the path of the currently running Python.
Because you can give it keyword arguments to pass to the next function in the chain, and it's possible, if unlikely, that you might use `msg` as a keyword argument. So it deliberately looks special because it's handled differently to other keyword arguments.
In the unit tests, there are also things like `refs/heads/dummy-marker.txt`, which are empty files. In the general case, if you try to get the OID pointed to by such a malformed ref, this function should tell you what's wrong. `ENOTFOUND` doesn't seem like exactly the right signal to send, but it's the closest one we have.
Missing semicolons on lines 190, 191, 204, 208, 212, 213.
I'm not sure whether the connection creation should be inside the try block or not. If it raises an exception, we want the application to fail badly instead of just logging an error and returning an empty result.
I would change this to:
```
nosetests socorro/unittests
```
having to go into sub directories is silly :)
what's the AttributeError we're trying to hide here?
If it is all the methods in a test class, then I vote you just put the `create_switch` in the test class' `setUp()` and just delete the other lines. In the spirit of leaving things better than you found them.
This comment should probably be moved to line 839 (updateVerticalScroll() does more than just position the mover div)
The returns value of `delete_object` here is feeling increasingly leaky. I wonder if there is some smaller piece of delete_object to factor out for reuse? More on this later. Also, as-is I'm confused because it looks like delete_object isn't going to handle the 3-element return properly.
nit: not typesafe, as above.
I thought we didn't need the `.js` at the end of these, no?
Ah ok, thought there was more to it.
the name should be prefixed by ``propel_`` to avoid clashes
'string, scalar or object with __toString()'
this should be moved at the top of the class like done in other similar situations.
the keys here dont matter, it's purely internal.
It would give a null error - defaultProfilePhotoID would not actually be initialized.
If you don't mind, just collapse this ERB block with the one above.
`undefined method`
bingo, I agree with you.
Won't hold up merging but could reduce this to one line.
отступи по пробелу справа и слева от равно
BTW mate... Although this fix suppresses the email this doesn't fix it as the ?showinfo parameter is parsed and used when the module name  is clicked a new screen then displays information about the module of which name is passed in the showinfo parameter so I'll deal with this and the fix just requires an isset() wrapper to check if the user has clicked... I'll fix this now and commit the fix for this module. What happens with your current fix for this is that whatever module name is clicked the 'Module information' screen always shows information of the Module Admin module and not the individual module :)
It's not a work restart during initialisation ...
Where does this.id come from?
unless love
Commit 78c7547 which I added to this pull request should address this.
Scott, first of all: I'm not a JPA expert - so I might need a little help from you here.

I suggest we wait until this PR makes it upstream and then create a few more test cases together to find out what is really there and what is missing. Then we can talk about much smaller change sets and isolated functionality.
Let me look into that and add a commit for this...
I have removed the lines are only useful for debugging purposes.
Me neither, but we add an address that is an object that already contains a type. So is not empty.
The coding style is to emit the `{}` here.
BTW this issue is interesting, thank you for investigation on this.
Is it possible to have 2 dialogs at the same time?
I don't think so since all dialogs come form user actions and the user needs to dismiss the dialog before moving to something else.

If this is true I'd like the markup to be in the html file from the get go, `ConfirmDialog` would just have the responsibility to handle the iframe support, update the content and use a simple css toggle to show/hide the dialog.
Do we really want this here in the repo?
expand the rule
at == access token?
Same from above.
last minor issue

If we can through here then we need to handle that in the display and feed it back to the user, Ill be happy whichever way you decide to do that, but it needs done, otherwise people could just be pressing = all the time with no feedback
one id should be enough?
PNG and RGB should be default values for the utility method.
not quite seeing where this is mocked so that it returns an empty list?
One other thing...`NullList` needs to maintain the same interface as a full `HTTPInteractionList`, so whatever public methods wind up being added here need to be added there (typically as a no-op).
JObject.Load(reader)?
Why not trace and swallow the exception here?
python-support is needed here for whatever reason our build farm needs it
Deprecated as of OS X 10.6.
It'd be nice to flesh this out with a bit more detail.  If a user gets this and doesn't understand what these files are, it would be confusing.  Maybe something like:

```
Both ~/.rspec and ~/.rspecrc exist. RSpec supports either file for global options, but does not both at the same time.  Please delete one.
```
**... не позволяЮт ...**
I removed the em / % and replaced them with pixels!
So I assume we will also need a TupleConverter[U] parameter?
Can you name this function more in line with what its doing? The current name is confusing.
nice spacing
Hmmm, arguably what you are doing here would be better supported using a bit of JavaScript to change the form based on the drop-down box.
Setting the `editedTemplate` to be a copy of the current template ensures that the `isDirty()` routine properly fails.
Thanks, yes it's a good/valid suggestion and I agree, virt_utils is a very crowded module.  One idea may be we split up the whole thing into a bunch of subject-specific util modules.  i.e. virt_utils.storage, virt_utils.network, virt_utils.cpu ,etc.  I'll keep this in mind.
Replaced the EPL code with a call to commons.io.FileUtils/deleteQuietly.  2a48851
variable link is not defined here.
Agreed @mattandrews and @commuterjoy. Dunno why we need `core-navigation` in the url at all. Unless there's any objections, I'll remove it (and updated references to it accordingly)
Yes, like it - I'll do that. I rewrote that on the train home as well, so will check in some improvements soon - plus the tests.
It does not only set `globalHash` but inderectly set `bestMatchingLocale`.
I can just remove this method and put all this code in top level?
(but this method is meant to be exported, be asynchronous and be called by addon runner)
(See https://github.com/mozilla/addon-sdk/pull/387#r718567 for more info)
ahh I get this now.
search_results.py:17:5: E303 too many blank lines (2)
There shouldn't be either the comma or the newline. Obviously, this would break in IE. And it's just lousy JS.
Sorry. Yes this is a mistake on my side. Using dataChanged fixes a bug in the datagraph where variable values would not update themself.
It doesn't look like the '--db' argument is used anywhere. Should this be removed?
What exactly does this fix? Why would we want to continue processing if the trimmed string is empty?
I must recognize that the constants are more self-explanatory. Could you replace `true` with `Hma::OUTPUT_BINARY`?
I agree with @lukaszr here -- if the only bit that you're interested in are nodes with a specific attribute, skip them. Yes, it can potentially lead to hard-to-locate errors, but if you're mixing information in the file, you have to expect that.
I'd prefer to use Gtk.Stock.MissingImage here instead of hard-coding the string.
please use 0x200 instead. i'd like to keep the types grouped, and like to give 0x101 to the next version of the Pi.

also, as @malard said, please be specific about the NXP chip you support, as it doesn't add support for all their chips.
The problem with that is that the default minecraft implementation isn't particularly logical. If the portals face North / South then it doesn't create the new one, but if it's East / West then it creates the new one, unless it's being created between 2 existent portals, at which case it destroys the west most one and fails to build the proposed one. I opted to only commit the North / South implementation because it makes the most sense, but I'll start working on the East / West compatibility.
`checked="<%= !data.stats.left %>"` -> `<%= !data.stats.left ? 'checked' : '' %>"`
Tony: What does this one mean? What does dynamic binding support for properties like text mean?
Should rather use `resolve_from_host_name` to support matching on ip too?
The placeholders INTEGER and EXPRESSION need to be replaced with actual values for this language.
same for all other relations
not sure what else you need .. there is ``$this->fieldMappings`` which contains the list of fields ..
008d1d1 で表示されなくなっていたっぽい :dogeza:
Use EAPI="4" here. Or have you any reasons for the 3-rd EAPI?
Good point. Because I totally forgot about it :-D
is this libpthread-stubs or xcb? (same for ictce version)
Swap empty line
`except AttributeError`, fixed
These should also accept &lt:dest> child elements. Can't tell if the xslt already supports it in this context, so would be good to add that here.
http://localhost:8000/en-US/api/v1/users/?format=html or possible without
`format=html` depending on your browser

On Tue, Jun 5, 2012 at 2:18 PM, James Socol <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,52 @@
>
> Let me rephrase: where on the site can I see this?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/241/files#r932126
>
Instead of taking a blacklist approach, could we take a whitelist approach here? Just incase we add another property to the Popcorn.plugin skeleton
bebe, what is your opinion of this pull request? https://github.com/mozilla/sumo-tests/pull/68
because the go_to_X_page() methods will disappear from the page classes no matter which solution (mine or davehunt's) is implemented.
@kellyredding - I believe you added an issue for this, and I agree, it'd be nice if we could do something here.
Was there an empty line on the end of this file before? I don't recall
removing it...

On Thu, Nov 8, 2012 at 2:58 PM, brunoais <notifications@github.com> wrote:

> In jquery.sceditor.js:
>
> > @@ -3458,4 +3469,4 @@
> >  			(new $.sceditor(this, options));
> >  		});
> >  	};
> > -})(jQuery, window, document);
> > +})(jQuery, window, document);
> > \ No newline at end of file
>
> I think you should make this new empty Line at the end of the file...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/samclarke/SCEditor/pull/34/files#r2069464>.
>
>
`if (0 == buf.length)` no jquery parens :D
This is a backward compatibility thing, the old object details page used the getFormattedDC function which returned the QDC instead if that was available.  I don't know if removing this special case will cause any problems so I tried to preserve it.
Since you're iterating through the map only to call `debug`, this should be wrapped within an if-block that checks the debug status via `if ( logger.isDebugEnabled() ) `
Explain what Node.js is
Well, I'd make 2 counterpoints here:

1. I think that the query will still run much faster on the DB side *with* the LIMIT clause than it would with a setFetchSize.  I can set up an explicit benchmark for this if you like but I've used this technique quite a bit in the past :)
2. The only reason that I didn't put it directly in the spot where we were assembling the query (which in this case would be in resource.clj) was because it still seemed like there would be a valid use case for the non-LIMIT version of the query, and I wanted to avoid copy-and-pasting the whole body of that method.

I would agree that this is not a function that should be used haphazardly, and I'm open to conversation about moving it elsewhere or other options for handling it... it does seem like this is something that could come up elsewhere though.  The fact that we have a generic `query-to-vec` function that blindly slurps an entire result set into memory seems at least as fragile as this extension to it, IMO :)
It's starting to make more sense now.  Definitely a lot of my previous comment was driven by lack of familiarity with some clojure structures.
Given you include the thread ID in the message, this is either racy, or unnecessary:

If you can have multiple threads with the same ID, in Ruby-land, you also have multiple threads with the same `current` thread value - they defined ID equality as a valid test, at least at runtime.

If not, you face one of two situations:

1. You can have the same thread passing through this code twice *at the same time*, in which case this is full of races.
2. You can only have one thread with the same ID walking through this code at any time, in which case the thread ID is sufficient to be unique inside this process.
most likely yes, I just wanted to get something up and running before the demo/performance test.
This shouldn't go into this PR.
The coverage.html file gets generated in the target/ directory, so I rather keep it.
Typo still here.
This function doesn't take a user
Good call, removed in 804c425
cache variable?
Right, but this option shouldn't exist at all.  You should use mkdir_p to make the directories.  Otherwise, every time a user programatically adds a subconf, they will have to set that flag.  That's a bit annoying.
You don't need this either. This is to import external crypto functions, but you are not using them.
Good clean up :D
Would you be willing to spin up an Amazon RDS instance for some quick testing? I can do it for you and provide connection settings at some point but I'm about to get on a plane.
No spaces around `is_array()`, also `{` should go on the next line.
The brace in this case was deliberate, but whatever ([PSR-2](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md): "When the ending list (whether or arguments or variables) is split across multiple lines, the closing parenthesis and opening brace MUST be placed together on their own line with one space between them."). The CodeIgniter style guide doesn't address this.
В задании сказано: "метод mutate принимает значение x типа int"
В более ранних версиях XCode мне б не удалось и массив создать @ литералом, да и создание NSNumber через @() не сработало бы
Повторов не будет, массив intArr состоит из уникальных чисел
@mvmn это не оптимизация, это костыль. Это заплатка, которую вы делаете, заточив свой проект под конкретную задачу, не задумываясь о том, что через неделю, через год к вам придёт клиент и попросит сделать программу для последовательности из 1000 символов, добавить туда ещё что-нибудь, и так далее. Понятное дело, что мы учимся, но мы учимся не чтобы делать костыли, а чтобы грамотно разрабатывать свои продукты, чтобы другим программистам не пришлось ломать голову и вспоминать любыми нехорошими словами человека, который написал ЭТО. Любой программный продукт разрабатывается с видом на будущее.

Я всегда говорил, что программист - ленив, и это по умолчанию. Бывают такие ленивые программисты, которые затачивают всё под определённую задачу, ибо лень; а бывают такие ленивые программисты, которые делают программу с возможностью быстрого и лёгкого расширения функционала.
Тут точно не может быть проблемы? Может лучше использовать метод isEqual?
Если вы уже успели просмотреть сегодняшнюю лекцию, то узнаете о методе

-(NSString *) description

Если уж не добавите его сейчас, то обязательно изучите потом, полезная штука.
maybe split this up to a multiple lines? :)
I think it's fine. We could even raise it a bit more if we could find a way so that the developer could easily cache bust. Maybe something like `basket.revision(1);` and whenever he/she needs to refresh the cache, they just bump it to `basket.revision(2);` and basket.js would clear all old stuff and store it using rev 2 instead. That way, we could probably have an expiration that would virtually never expire and leave it up to the developer completely.

But that's a whole other discussion I guess ;)
We use camel case
One MUST is enough.
@lcdhoffman Like 'language', we've just added and released a further mandatory field for resource/archival object -- namely 'level' on both records.  I noticed this new validation stops the import for the ferris.xml test file.
This is a very dangerous definition, because the actual values rely on the type `enum LVDocViewMode` defined in `kpvcrlib/crengine/crengine/include/lvdocview.h`. I am not saying we shouldn't do this --- I did exactly the same thing for djvu render mode in djvureader.lua, but I described this danger in the comment, so perhaps we should add a comment explaining why these specific numeric values of 0 and 1 must be chosen (and cannot be changed), referring to the lvdocview.h header file.
That makes sense. I will make that change.
Can you update this so it doesn't unnecessarily rely on ActiveSupport with `present?`?
确实没什么作用，其实一般用的时候不会去指定名字的，如果用户真的创建了两个eventbus的话，这个名字可以在调试的使用用来区分吧。不需要去重，因为eventbus对象之间是独立的。
I searched for an element that was global and didn't have content. Having found nothing else, I decided to use a `docinfo` element, which doesn't have any impact in the generated document and allows to be used later to find the latest defined value.
additional copy_raw attribute then for this case?


On Thu, Dec 6, 2012 at 3:46 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -610,7 +663,7 @@ def crop(self, tmin=None, tmax=None, copy=False):
> >          tmask = (self.times >= tmin) & (self.times <= tmax)
> >          tidx = np.where(tmask)[0]
>
> why not copy_raw argument but it will be unaccessible but the user in the
> getitem
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2335515>.
>
>
this will only work if you don't do any dimensionality reduction with n_components < n_channels

otherwise you loose data on purpose which can be good eg. maxfilter keeps only 64 PCA like components on purpose
I'd rather an explicit name : radius?
could be moved up a few lines, but it doesn't really matter ;-)
I am not into onclick javascript events in the mark-up.
These few lines can be remove. unwanted links.
To make page 1 the default page
This should be:

    /**
     * @var SecurityContextInterface
     */

As well as the other examples
Yea, this seems odd - what if `$number` has a description? Then it wouldn't line up with the description of the `@throws` or the `Issue` (if it had one).

I can't really argue with the phpcs, but this one almost feels wrong :/
Might want to update this fanout_error, I removed the srvsock variable...
That's very brittle: what if we want to work with objects that happen to be iterable?
To avoid all the extra backslashes for every quote, you can declare the docstring as "raw".. it should work fine. (just use r"""blablabla""")
Уже есть `info` же.
I moved this out of the class-level so that it is possible to subclass `Vimrunner::Server` and provide your own per-server `vimrc`.
esto puede ser un helper
OK, I'll change this as soon as I have access to my main laptop again (which should be this weekend)
the kernel needs the class loader component in debug mode, wich is not in require-dev
Interesting,   looks ok on my end
We should have a limit for the cache. The most simplest approach is to throw the whole cache away when it exceed a certain size. But an unlimited in-memory cache could cause us problems at some point.
that was a joke :-)
Having only the last member of that method marked as final doesn't look good. final is not in our coding style btw
As above, regarding word order.
Really picky nit - simplify this into one line by doing the following:

return self.marionette.execute_async_script("GaiaLockScreen.unlock()")
Don't globally override this element.  If you need certain select boxes to be auto, set them via classes or ids (probably on the `<form>` tag).
My reasoning behind this is so that it is hierarchical and you can evaluate it with < and > so that the admin has all, cts general has 3,2 and 1, etc..

Basically I wanted a value assigned to it so that I can evaluate it as such instead of copying code for each one
Hey, are we using shorts just to get the storage down? We're going to have to be careful with the casting, as Clojure defaults everything to longs.
generally a positive statement is easier to understand than a double negative
so islenok should return true if the len is >= the min
however, the name of the function should be "pass" - this is consistent with childrule
(and quantrule foundok should be renamed to pass as well )
We can't put this in the main `require` statement, since we don't have access to the `sakai` variable there.

The `fillShareData` function also needs access to the `addthis` global variable but that function only executes when the popup gets shown.
This should still be passing in the group profile.
I could add [1] into the CSS.

#entity_download.s3d-dialog-container h1.s3d-dialog-header {
    margin-bottom: 5px;
}
I tend to do this as a means of future proofing. Using '''authorizable instanceof User''' means that if User is ever subclassed this will be a hidden little gotcha - it will return false for any subclass.

What do you think? I'll go with your preference.
I messed this up. I changed some things around so now it returns false correctly when
the parameter is not found.
same here, please add a test for new methods at some point
I think all this stuff can be taken out and put into a separate pull request. Will get onto it soon
Is this intentionally left blank?
yeah, `artifact_id`. fixed.
Брех, че розаво
OK, I will remove that error checking.
Yeah, I haven't yet encountered an scenario where pack('m') spits out a "\r". That's exactly how basic_auth is implemented in net/http, so I don't see any problems leaving it in.
Yup. In my opinion the indentation rules are purely for ease of code maintenance and readability. Therefore we don't care as much about the rendered product as we do about the source files. Our standard practice is that all code inside of beginning and ending template tags should be indented.

http://mozweb.readthedocs.org/en/latest/coding.html#django
The functional implementation is a bit shorter ;)
cloud9 上node版本 v0.6.21
From the template. Removed.
ooohhh.. actually. i re-read the README and youre totally right. i wouldnt even be using this..  thanks. :)
You could just give `pred` as a parameter to `filter`. Also, `count` is costly, better to use `(not (empty? ...))`.
The return is an instance of ModelCriteria?
I was on the fence here too.  I made it a value class for copy-pasters.
Better to have "best practice" in the docs.
You're right. It was done correctly and I "broke" it :)
(This is useful for future developers to know what is available.)
No *EmbeddedListField*?
I would rather see that you pass Python object to the template and then in the template use filter which escapes into JSON.
No, you should, ready event is cool. You can do something like:

```
$(document).ready(function () {
    // other stuff ...

    $(window).bind('mapready', function () {
        ...
    });
});
```

But this does not really work if event is triggered before callback is binded. This should still be researched.
Just set `user.backend` to `"%s.%s" % (piplmesh.backends.MongoEngineBackend.__module__, piplmesh.backends.MongoEngineBackend.__class__.__name__)` before you call `auth.login`. :-)
And where do you use it?
Panel might be better :). Should I un-hardcode width than?
This is just test code for creating comments so i can test notification.
Hi David,

Yep, and I will make concatenate_block_size and var_names required
variables.

Thanks,
Swarbhanu.





On 3/5/12 10:21 AM, "David Stuebe"
<reply+p-518280-a2c1639f0e59299110b946d84ae531250a2ab837-1181645@reply.gith
ub.com> wrote:

>>  
>> -                        if concatenate_block_size:
>> +            else: # no concatenate_block_size is provided
>
>Remove this case...
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/ooici-dm/pyon/pull/29/files#r518280
No, I don't want to muddy the waters between tickets and patches. 

From where I'm standing `div` is re-assigned in the while loop, so whatever `div` ends up being is what gets removed. 

You could also argue that this still allows any elements that are being put in `safeFragment` for clonable reuse - but that's desired.
Do not use a namespace here, but prefix it to the corresponding class.
should not need to require this here afaik
and here:

DoCastVictim(SPELL_EARTH_SHOCK);
use pls for spells magic number
look some lines above, that's an old leftover from bad wg merge
you may want to change out `@tokyorails` , other than that looks good.
Nochmal Grammatiknazi ;) (you asked for it)
We should not log an error if we're throwing an exception as well; throwing the exception is the better option in this case I think.
not required I think. Hard failure is fine for now. did you test this patch with your script?
I don't know how things work to output colors on the terminal, what does this `\033[0m\` thing? Do you mind adding a comment?
Third slap.
Extra space. And in general there is lots of camelCasing in here.
Could `text-overflow: ellipsis;` be used instead?
Normally we use our event delegation design, but i guess an exception for this view is OK.
beta -> params.
What I do is usually is to broadcast the boolean
```
x[idx[:,None] * idx]
```
Notation: I prefer ``mask`` in the name if it's boolean, and ``idx`` for integer indexing. It makes it easier to remember which one I used.
The header should be called "Examples", otherwise it won't parse.

``import numpy as np`` below is not necessary.
Is the code that's on github the most recent? I still see these and just made a similar comment.
Nothing, the convention is that $foo denotes a jquery object, but in the language itself it doesnt mean anything.
Streaming the resource is clever, nicely done!  However, the `table` argument is a little misleading - it's not really the table you're passing in, it's a file handle.
I'd suggest including "Alpha" in the option name -- when I first saw this being used, I guessed that it was the animation duration (in seconds).

highlightSeriesBackgroundAlpha?
In fact I would extend `plain.html` and have both header and footer. (And fill in the search box of the header the same query as it is passed to the view.)
Please make sure postscript name is "no longer than 63 characters; and restricted to the printable ASCII subset, codes 33 through 126, except for the 10 characters: '[', ']', '(', ')', '{', '}', '<', '>', '/', '%'." (from http://www.microsoft.com/typography/otspec/name.htm)

The OpenType sanitizer on Firefox and Chrome browsers will reject the font: http://code.google.com/p/ots/source/browse/trunk/src/name.cc?r=77#139 if postscript name is invalid
I am talking about the FFT in optics.py, not in SBProfile.
学习了。。。
Let's give this a new classname, away from the default SimpleTest
If you're referring to amounts checking, that's fixed now.
Oh no, some tabs got it. I recreated my eclipse workspace and somehow it hadn't picked up the formatter choice of spaces.
should the first -X be ms not mx ?
I am very against using octal numbers for modes, it is error prone even at the best of times.
Nope. Automatically coercing an array to a string happens to have the right output here, but explicit is way better than implicit here.
If you use opts[:keep_zero] here, it will output a zero for every unit, which is likely not what you want (you want the last unit only). See my patch in #13.
I supone it's the same in line 78, isn't?
`@author == author` will suffice as the condition.
Yes. Can't set it on tcp/cooked.
That if there's an app but no user, then it's /servicesNS/nobody/<app>, and such. You're right that the logic probably isn't really right. I feel like there should be a complete rewrite of namespace handling with a single data type. Probably we should hammer out exactly what the type and logic should be and document it somewhere so we can get all the SDKs onto the same system.
No need to keep old code (use git)
Agreed. I'll make that change.
I'm a pedant for this kind of stuff.  Can you include a space after that ``{%`` when using template tags?
Using update-in here makes sense to me, it improves the readability and expressiveness of the code; I infer that it's more idiomatic Clojure. But just to be clear — this isn't a performance optimization, right? It's solely a readability improvement? I mean, if anything I'd think it'd be a little slower — but probably worth it.
Save profile if there is no one already there.
Remove To Do from here. Keep the TODOs in a separate file.
If src is a healthanalyzer, it might be a better idea to do if(mode ==1), not a for loop.
Revert everything but this line.  I adjusted the others as it had broken the science and medbay doors.
Should this be `"O"`?
You should use braces around the value: `${dovecot::params::version}`
Better to save the result of `key.match(blah)`, rather than run `key.match` again in the next line.
Very minor style opinion, if (!isElementNode) { do a few things; return; } might be nicer than a big long if statement here.
do not use K_NULL because typeof(K_NULL) is Object.
please use KNULL(Json).
Ok. Just to confirm. I was not in my computer and didn't look at the code. Thanks to explain.
non relative imports
Maybe we could rename `y` to `class_labels` to be more explicit?
Please delete those commented out lines if you don't need them.
On Sat, Nov 10, 2012 at 04:40:16AM -0800, Andreas Mueller wrote:
> Isn't this line the implementation of assert_all_finite ?

No, it's more clever than this.
This will need to be updated to:

https://secure.travis-ci.org/scikit-learn/scikit-learn.png

at least I guess.
I think you can just return from here and remove the label.
This, and most of latter `property` call, are same as above.
Don't loose this back to a deprecation.  It should remain an unconditional error.
You removed the files but not these lines in the .xml file.
The ctor shouldn't have the object factory as a param now that it doesn't use it anymore.  It should get set directly in the createPicker function using setNativeObjectFactory
I did not take into account the fact that this commit would break backwards
compatibility... Changing the if-test to account for 1/0 values would fix
that. I'll try to have a fix ready tomorrow (tuesday evening in european
time ;)).

Browser compatibility is another issue. Using the string value will
probably not work in some older versions of chrome etc, but using the
integer values throws warnings and will stop working in the future... Have
you got any idea on how to fix this issue?
On Oct 30, 2012 2:15 AM, "Parashuram N" <notifications@github.com> wrote:

> In jquery.indexeddb.js:
>
> > @@ -478,7 +484,7 @@
> >  									dfd.rejectWith(trans, [e, e]);
> >  								}
> >  							}
> > -							me.transaction(storeName, typeof mode === "number" ? mode : IDBTransaction.READ_WRITE).then(function(){
> > +							me.transaction(storeName, (mode === "readwrite" || mode === "readonly") ? mode : "readwrite").then(function(){
>
> How about checking if this is a number (0,1) or one of the strings
> ("read", "readwrite") ? I think I will abstract out that logic.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/axemclion/jquery-indexeddb/pull/17/files#r1974272>.
>
>
This method is useless and should be removed. We should also rename the methods to be coherent with AnnotationHelper (*Value instead of *Parameter)
I'll leave for now, there are some other changes I plan to make to these array classes, for use in by hash dedup/agg.
May change then.
Any reason not to set these here? they were in the !win32 branch below.
You don't need the thorprocess name for the log, you need the date + the leading path.
As mentioned above, it's possible that the log path doesn't contain the target process, so you shouldn't rely on it.
where is the test being run if we return here?
Would this prevent specifying Firefox.app/Contents/MacOS/firefox?
+1 and may be highlight this paragraph with some bold or yellow or anything that would ensure developers reading this part :)
See previous suggest of 'default' instead of 'user'
Shouldn't this be RecursiveArrayMerge now?
`_position`. Cf  ma PR #15
The `href` value is quoted with double quotes here, but in the source single quotes are used. Probably change the single quotes to double quotes.
"Creates a <code>ServiceTimeoutException</code> with specified message and cause. "
This does not work for Windows systems and Linux systems.  The scroll bar takes width on these platforms compared to OS X and will cause overflow in the div
Not sure how this is used. Can I have multiple instances running at the same time?
This fails jsglobals.js in `make check`; I also think this is wrong; doesn't this mean that the sketch will get focus on load?
weak (non-existent) ruby skills
Why not the shiny new ```prepend_migrate?``` method?
Maybe you should have a look at figure 1 in http://web.mit.edu/persci/people/adelson/pub_pdfs/pyramid83.pdf.

The smoothing window should cover `window_size = 2 * factor + 1` of the parent image. Sigma must be `(window_size - 1) / 6.0`, so that the window covers >99% of the distribution. Now substitute `window_size` in equation 2 with equation 1. This is how I came up with the computation of sigma - maybe you could do it differently.