labofsahil/github-event-dataset-2012 huggingface dataset:
just mentioning that you can write this as `n in (1, 2)`. It is not "better", however I personally prefer it.
This is not needed : `/usr/bin/git` is in current `PATH`.
It looks like this is assuming it will only ever terminate one instance at a time.  I think we need the system to be able to terminate multiple instances at once.
needs comma
glossary terms are singular except in cases where the term is a collective noun (i.e. `BSON types`)
right. sorry.
maybe a simple list-table here.
equality matches documents
You will need to make an local optimizer that will replace GpuFromHost by GpuFromHostStart + GpuFromHostWait
Also, prosilver/subsilver inheritance is there for a reason and should be restored.
Why? The other way around. Method names should contain verbs.
Single quotes here, please
This does not work on freebsd:

ps: illegal option -- -
usage: ps [-aCcdefHhjlmrSTuvwXxZ] [-O fmt | -o fmt] [-G gid[,gid...]]
          [-M core] [-N system]
          [-p pid[,pid...]] [-t tty[,tty...]] [-U user[,user...]]
       ps [-L]
If you look in 3.0 in the memory cache backend, these functions exist there as well. If you know the reason why they were used there but are no longer needed I'll remove these, but I would not like to remove them without knowing why they existed in the memory backend in the first place.
Is isset correct for the first use of a static variable?
I agree that too much is going on in this branch.
we usually use local exports = {} so it's more extensible later.
Cred că ai folosit taburi în partea asta, că nu apar ok liniile. Înlocuiește toate taburile cu (4) spații, te rog.
Is there a chance that this->projection won't be nullptr but deleted?
Any version of IE? :)
tssk-tssk *slap on wrist*
This is still to be completed.
I don't see the correlation between the purpose of this branch and these changes (i.e. I suggest they may have been better in separate branches). @bblay may know more. Nonetheless, they are here now, and I don't have any desire to have them lifted out, only to be put into another branch...
You are right. self.UPLO should be in props.
Also test Diagonal(1,1,2) and Diagonal(1,2,0). you only test the 2nd parameter with the default value of 0. The swap could cause problem
I'll try to rewrite it here:

When an optimization is rejected, we can't use DebugMode as it check those rejected optimization. The rejected inplace optimization will cause wrong results, so DebutMode will trigger an useless error. To allow using DebugMode more often, we can pre-check that our optimization will get rejected in many cases (not the cycle reason) and don't try it in those case. For this you can use the ``theano.gof.destroyhandler.fast_inplace_check()`` function that will tell you which Op can be performed inplace.

Is that clear? I think there was an explanation missing that I added at the start of the paragraph.
inherits, gets
Should this be changed to a version number before this is merged?
Drop the "is_", it should simply be named: network_exists
`--inspector-port`, соответственно
Please make sure that CFEngine still compiles without libxml2 enabled. files_editxml.c is not conditionally compiled.
Interestingly (or not), this test is not causing infinite recursion before the patch. It simply gives untranslated string, without placeholder ("My name is ."). After the patch, it raises TemplateSyntaxError, indeed. Is this intended? Can you just have a look at this behaviour?
Link to the reverse_lazy docs here?
tox does support pypy but whenever I've tried it on my Mac (OS X 10.6.8), the Django test suite hangs -- if we can figure out why and solve that, then I think it makes sense to add it back.
Thanks, I missed to add the import.
Please use comments (`#`) instead of docstrings in tests. If you use docstrings, the nosetests -v output is hard to read (it displays the docstring instead of the test module, class, and method name).
At the beginning I wrote these qa tests, but I didn't have the input needed to finish them (related to the insured losses feature). The sample based issue is postponed for now. I'll add a TODO.
All common packing code is in lambdaPack. `lambdaRepack` is a user-overloadable part. It gets a tuple with references to captured values and returns tuple with packed values. `trace` returns references thenselves, but prints what has been captured. `move` returns moved dereferenced values. In `lambdaUnpack`  it is transformed back to references..
you're completely right, I assumed it was the content box
Why is it no longer necessary that tokenize respect leading and trailing whitespace when checking the cache?
Fixed. Added a new function utils::almostEqual().
These functions are all calculation functions. I think there are only two exception. One is domain_error, according to the original code, this kind of error should be caught and return NaN. The another is overflow exception, but for distribution functions, there is no reason to overflow, we should process these conditions.
Not necessary to be retroactive yet.  At some point before the 3.0 release
we will be doing a full pass over the source to fix these things.  4-space
tabs (the VS C# default) is our chosen indent for the project and in future
we will be getting stricter on submissions meeting those requirements.
This is now rewritten in a much simpler form, so no "exported object" is built, and no objects passed to the wrapper is altered.
In the interests of inciting Jack to review something other than the small stuff, we will continue to support HOMEBREW_MAKE_JOBS.
Maybe use the ruby URI module for extracting this?!?
Can be `current_pos`?
The outuput for this example is missing
Perhaps the profile name should be pulled out into a constant so it's not duplicated?

Nitpick: reddit's not capitalized :)
Can you possibly use classes or less generic id names for these page-specific content sections?
Since this is OS specific, and python has a default anyway, I'd say it should be left empty in example.ini (maybe recommend /dev/shm for Ubuntu in the comments)
These tests were already passing, but they were the other outstanding issue that I was mentioned in https://github.com/square/okhttp/pull/53
One more comment: This code should be broken into a separate it() { ... } block so it shows up as a new test (not just adding on to the existing one).
I think NJ's caution was that we can't assume just because the UI event handler got called that the UI is enabled (because the click/keypress might have been already sitting in the event queue when the UI was set to disabled).  But ```_enabled``` should still be up to date (assuming push).
Should be result.reject()
I think that problem is more widespread. Shouldn't need to special case it here.
Minor nit. Change to ``forceTriangle = (newWidth > 10)``
Changed name to setSelectedIndex()
Probably better to use the `|JSON` filter (load hq_shared_tags), so you don't ever have to think about escaping issues. Looks like `locations` in the line above is serialized json? I like to preserve the original object and pass it through the `JSON` filter for the sake of being explicit.
what if there are many geometry fields in the table ?
這一整塊可以用一個 partial
用 partial 的時機 => 可能很多地方都會用到時
Those two lines are not necessary.
Of course? You should trust into yourself! :-) The only limit to you is yourself.

If something is not clear about `default_error_messages`, check the code. How it is copied to `self.error_messages`.
This is really a const, right? Should probably be `var TIME_ACCURACY = 5;`
Your quotes are inconsistent here and https://github.com/mozilla/butter/pull/1027/files#L0R321
Looks like a typo in your comment here.
Perhaps httpbin.org instead?
这个可以设置发送标志，并添加写超时事件，需要放在里面的。
why is '10'?
the indenting is wrong :)
It looks like all of this is nested inside `_init` but it's at a lower indentation level.
This needs to be rethought a bit. `title` is a required entry field, so the message config parameter will never be used in this instance. It's probably safe to just use the message config directly.
Plus `List` still has to subtype `ListNode` so that the `ListItem`s at the head and tail can refer to it--see the comment by @aviks. You can't use a `Union` for that because one type won't exist when the other is declared.
I agree it's sort of hackish, but it actually mimics the environment that would be present if those elements were not present which is what the Katello model expects.  Given that the glue layers are enhancements to the base Katello model.

You can see the function that sets things up here - https://github.com/Katello/katello/blob/pulpv2/src/test/minitest_helper.rb

And then an example of how it's being used here - https://github.com/Katello/katello/blob/pulpv2/src/test/models/repository_base.rb

Where, before each test suite the call to disable the glue layers is being made.  A test suite being represented by a class that inherits Minitest::Rails::ActiveSupport::TestCase.

I have noticed no performance issues with the tests, even when I was doing the re-loading in the setup calls (i.e. before each individual test).

I agree with you somewhat on the glue layer acting more like an event-based/observer pattern due to my JS background, but as you say, another discussion entirely.
I saw some discussion in early comments about the use of org = "nil".  One alternative might be to simply omit the attribute of org in the JS.  Then on server side use the existence of org to mean it has a value and non-existence to mean it's nil.
I can, but I dont like it.
Could you check here that the user has 'read' access to that activation key.   Keys are no-tag resources, so you can just check with  ActivationKey.readable?(org)
Love this impl. Nice job dude.
The sleep is kinda lame, ideally the test-agent server should just have a queue and unload it when the client connects.

In my tests 4s was fine since its just localhost -> localhost. If we moved things to different servers there would likely be a problem.
I should have the time to create the queue logic before we want to split things up.
stricts -> strict
This is wrong.  A page, like a person, should only have one head.
lager:info("http://www.youtube.com/watch?v=QhW7rpFhr2k"),
shouldn't the example be between backtics as other code?
Importing is not read-only. Only reindexing is.
Please make this a parameter to ipcInit instead of a global
Alright I'm fine with this patch then, but now I'm interested in which lines give you that signed/unsigned warning, as we are always interested in finding and fixing these :).
In principe it would be better, I thought about it too, but the problem is that the entire UI is held up during import, so it would probably only be confusing right now.
Not only that, but also the Recorder in gatling-highcharts that imports com.excilys.ebi.gatling.recorder.ui.GatlingHttpProxyUI
this is a default file pulling in by automake when a COPYING file exists. can you send me the license you want?
Any particular reason to hardcode 10 here?  Just curious, I'm always a bit reluctant to have hardcoded constants in the middle of execution code...
I have a feeling we should have MapValidator here more than spam of validations. But its ok.
Feels a bit longy.

Also if we do validation on :team_id etc. we should have relation back to main model ```belongs_to```
Nit: Order.
I just tested it, and you do. Git ignores the gitignore file if you don't exclude it specifically.
Why don't you want to keep the `exc_info`?
Migration might be done by now right?
Tu peux mettre ça sur la même ligne pour le moment (tant qu'il y en a qu'un seul)
Are tests run in parallel (isolation). It could explain such a pb.

----- Reply message -----
De : "Bilal Amarni" <notifications@github.com>
Pour : "symfony/symfony" <symfony@noreply.github.com>
Cc : "Victor Berchet" <victor@suumit.com>
Objet : [symfony] [FrameworkBundle] used the new method for trusted proxies (#6154)
Date : mer., déc. 5, 2012 21:22
In src/Symfony/Bundle/FrameworkBundle/Tests/Functional/RequestTest.php:
> +        );
> +
> +        $client->request('GET', '/request_showip');
> +
> +        $ip = $client->getResponse()->getContent();
> +        $expectedIp = $shouldBeTrusted ? $forwardedFor : $realIp;
> +
> +        $this->assertEquals($ip, $expectedIp);
> +    }
> +
> +    public function getConfigs()
> +    {
> +        return array(
> +            array('default.yml', '88.777.66.55', false),
> +            array('trusted_proxies.yml', '127.0.0.1', true),
> +            array('trust_proxy_headers.yml', '88.777.66.55', true),

I'm stucked in here... all those providers are correct but tests passes only if I keep one of them each time, I don't exactly know why it fails but it looks like a caching issue, even though a few lines below the cache dir is deleted, apparently they use the same kernel class, and as it's within the same process only the first one is used by PHP, is there a solution for this? thx


&mdash;

Reply to this email directly or view it on GitHub.
Changing the exception used is a BC break for people catching it (and is not a phpdoc change, so your PR description is incomplete)
circular dependencies are forbidden by the container.
Actually not having a persistent way to authenticate is a very big pain. Now that tokens are not available either you have to store your password (easy but not secure) or set up OAuth (complicated).

We can leave this as it is for the moment, however there should be definitely an issue filed against it.
2. basically branching a code based on test of object's class is considered as a bad design. I know class test is used relatively a lot, but it should be always replaced by method call.

It's ok to test if method exists and then call it, because any class can implement this method and the test code remains unchanged for any number of classes.

On other hand  when you use class test and you want to test for multiple classes you have to modify the if statement. Now also class where that class test if statement is present is directly dependent on those other classes and you end up with with spaghetti dependancy.

When you use protocol with method call the testing class only knows that there are some classes that could implement this protocol. And no spaghetti design is used.

Other good reason to use method call is that code will have it's name (method name) and it will provide some documentation why you want to test it in if statement. It also introduces good Decompose Conditional refactoring pattern: http://www.refactoring.com/catalog/decomposeConditional.html

----

You can merge it as it is now, it doesn't matter that much. I just think that we should aim for a good design all the time.
Style:

```ruby
RestClient.post(
  messages_endpoint,
  message.merge(access_token: @sender.access_token),
)
```
Single quotes in the ruby
呃，我都已经认为这些是最基本的了，难道这一节“字体字号设置”就直接不要了？
Lets convert this paragraph into a shorter one that just explains what this does, instead of the reasoning behind it. It will give for clearer documentation.
De ce este nevoie, avem resurse doar.
Now in pulp 0.0.332 it looks like we can get away with details=#{details}.. I am going to remove the other adds..
Note: This will be removed soon (for 0.5). It is only there becasue Iris is currently using it.
Not consistent with 180, 181. I'd put ```coord)),``` up a line and align the string literal.
Ah, excellent. Thanks. @hand_contents[current_name] I think is what I want.
yeah, that's something we need to actually think about. this doesn't address post-filtering for mobile clients, javascript clients, etc
Yes, I'm using 2.0.12
I didn't, but I would welcome it if it was added.  Does modernizr detect webkit notifications being supported?
Also maybe change ```related name``` to ```related_name```, then there's no ambiguity.
I have almost always used `each` so I can't tell the behavior of it when using `collection`. But in my example the `view` and `context` are different.
I would suggest to remove URL from input, since we will probably change code if URL changes
Why this restriction? Could DeploymentOverlayIndexService.java not use a regexp?
Nice catch, a logging profile should override a configuration file. I'll make the changes necessary.
First I just wanted an attribute  for when you are browsing the management tree.  You need to see the available choices to pick a default impl.  

Jikiran convinced me that we needed an operation because that is how it is done with installed database drivers.  So if you are writing some kind of client and you want to present choices as a list you would use the operation.  

For browsing, you aren't likely to see or know about the operation.  So I just kept the read-only attribute.  

Still kind of lame and redundant, I know.  Both seemed useful so I kept both.
I would rather define this function different depending on whether `canGetComputedStyle` is true or not (to avoid check at run time)
you can use - and plack handler automatically converts to _. i.e. `starman --min-spare-servers 2 ...`
I want to sub the first string of hour.
Such as: 08:30 ---> 8:30 respect to 12-hour display(sync style with spec.).
Please also set r+ in bugzilla.
I set it r? to let you confirm again.
Thank you.
I've already talked with UX people this morning and as i've commented (https://github.com/mozilla-b2g/gaia/pull/6424#issuecomment-10507216) this is the expected behavior
I guess this can be figured out outside of this bug. Thanks.
Hello timdream.

Thanks for your review.

I have added the lines before "wpsInProgress" variable. Because it and gWpsInfoBlock should not be changed when gWifiManager.wps does not exist.
How do we know that |frequencies| is the same as what we're already playing?  Can't this logic cause us to lose start() calls for new tones?  What should we do if the new frequencies are different than the current ones?  Is it illegal to call start() with new frequencies before calling stop() for the old ones?

This needs either a more explanatory comment about the "stomp" logic, or an assertion that the frequencies are the same.
maybe fb.importer can work ... what do you think?
OOP should be also disabled in `background_service.js` in this case.
If there is no chromeEventId you can return before entering the switch since you use e.detail.id in the open-payment-flow-dialog too. (that could be rename chromeEventId)
Don't need the `kb` prefix since we're already in the `KeypadManager` :)
I have hooked-up the changing password functionality to the save button, and do a little check on empty password.
heh, as far as I know text indent is still the standard for image replacement?
:)

we are going to do a follow up, adding the l10n functions, we already add the string to the properties file in the en-US locale with the id: deleteConfirmMsg for the string freeze :P

We will be good boys and add complete the l10n functionality soon.
The first characters of every word are encoded into trie (prefix). Three words starting with that prefix are stored as a linear list in the leaf node of the trie (suffix). I am not completely sure if this answers your question, but i try: e.g. the prefix is 'abo', we have to make sure that there is a way from the root to the node 'abo' adding maybe nodes for 'a', 'b' if they not already exist to finally end up at the node 'abo' where we then store three words (e.g.) 'above, 'about', 'abort'. If we wouldn't prune after 3 words, we would have as many words as there are in the XML file starting with 'abo' which we can prune because they are not going to affect the final results, since we are only going to show 3 suggestions anyway.
I already did a comment last time about this switch. Please address it. If a timezone list will come later then you will add names later.
And you should confirm the strings with UX ... "Anonymous" is geeky :P
Not sure. I coppied the use from another form on the site. Perhaps it's no longer necessary since I updated vendor. I'll check it out.
Here's where the leak occurred.
Do we really need to blow it up to that many possibilities? Does octokit actually use anything besides `application/vnd.github.v3+json`, it's the four markdown flavor variations and `application/vnd.github.v3.raw`? Maybe rather than constructing all the possible variations this could support the most common N and allow the caller to override the entire media type.

Regardless, i don't think this is a very important issue. Certainly not important enough to slow down shipping this.
notice the , in front of the or. That prevents the expression from evaluating so it gets passed as a literal s-expression to the rspec-from-direcory. This means the directory finding happens immediately before body-form is executed
IMO, i think it is better scope the catch.   

string id;
try { id = _rep.CurrentId; } catch { return null; }
return CreateEtag(id);
Dead code like this shouldn't make it into a pull request.
should not remove the tips.
can you test Iterable too on an List[Int] or something?
Why is ReduceOperations sortable? This seems wrong.
You should remove calls to `$this->getZipFile()` and use `$this->_zipFile` (after renaming it should be: `$this->zipFile`)
`return false unless value`
Indeed, I was displeased to not be using maybeDeferred. To support SKIP I would use the example I gave above (with a maybeDeferred), but this would mean that self.finished() could be called before the self.start() chain of deferred is fully called. I worry about other similar "weirdness" it might lead to.

If thats all OK I will send an updated pull.
I guess that the problem is in the content of the pickle. The comment says that the pickle is created by:
    # >>> bs = BuildStatus(BuilderStatus('test'), 1)
    # >>> bss = BuildStepStatus(bs)
    # >>> pkl = pickle.dumps(dict(buildstatus=bs, buildstepstatus=bss))
Althought the test pickle was created with persistent version 3 of buildstatus it does not contain a source attribute as the attribute is not assigned in the constructor. The test starts as version 3 and only upgradeToVersion4 is called. Looks like a new test has to be created including .source attribuut.
No debugging prints in committed code :)
`and`
agreed, indexJSON was more for symmetry reasons.
I don't think that's right, we already notify the installed one, so no need to notify the alias IMO.
do a docblock here
the first line does not need the sudo nor the --install-dir stuff, you can just do this reads shorter:

    $ curl -s http://getcomposer.org/installer | php
    $ sudo mv composer.phar /usr/local/bin/composer
As the options are an associative array, you should use ``array_replace_recursive`` to avoid weird behaviors:

```php
array_merge_recursive(
    array('http' => array('header' => 'foo')),
    array('http' => array('header' => 'bar'))
)
===
array('http' => array('header' => array('foo', 'bar')));
```
introduced factory...
I don't really know why I've got in the habit of that style. I think in this case it was to do with their being a true default. The code has the fonts as false by default, but then the switch can override it.

Happy to change to your version if you think it's clearer though.
I am doing a multi-character replace, I am interpreting the literal \002 from the MOTD file as the ascii \002 char (hence the double slash), I also made it so it could have future expansion in case someone likes %C instead of using \003.
The function it's self can be cleaned up and I'll work on that when I get home but ultimately I copied this from anope (Though I use this same function in many of my other projects)
Is there a reason for a separate flag? It seems like we could accomplish this with a custom singleton object of some sort. `None` can continue to stand for "same output directory, same basename", while `Stdout()` (or, even the number 0, or something).

I suspect the right way to go about this is to accept either strings or file-like objects. I think this more flexible approach is what will be required for leveraging this with nbviewer (@Carreau?).
For now, let's just modify the sidebar block. I'd like to do a redesign of the default layout in the near future anyway.
I'm thinking about getting rid of the tutorial and replacing it with a series of increasingly sophisticated examples with a few comments at the top to explain what the user should take away from each.
Why is this a TextOrButton as opposed to a (for example) RadioOrCheck? What does the "link" value here actually do?
Can the internal* functions be grouped together to increase mental cohesion of the blocks?
this introduces a DB write on every cert_key, which will likely change the performance profile of our app, since that used to be read-only. Is there an easy way to determine those rare cases when that update is needed? Stashing something in the req data structure from when that user row was read?
These styles were for the old style error messages.  The old style messages have been replaced with the newer unified error message style.
Ok changed; see further below.
I don't think this code should be reaching in and using `DataSource` directly like this, hardcoding things like the contenttype "perftest" and details of the model. Everything that's needed here (and above with `get_projects_by_cron_batch`) should be exposed as methods on `PerformanceTestModel` with the details abstracted away. Actual Django ORM queries on `DataSource` should probably never happen outside `datazilla.model.sql.models` - that's just an implementation detail of `SQLDataSource`, which is an implementation detail of `PerformanceTestModel`.
Yeah, just pass the value as number. Also as mentioned above please update the timestamp code here too.
this is to auto connect to the form. next time we need to change to exp http://nexvend.com/forgot_password
`ClassName` everywhere.
The downside of this syntax is that the default value must be always supplied (nil is the default for no value, because that parameter would be set to nil when no default value is specified), but the upside is that all create_{node,hostclass,definition} methods have similar syntax.
So, to make a face available on the command line you need to write an application.  That means that we have been pushing people to define these things, and we have an unknown but large enough pool of people who might get broken by the simple change.

We need to search for the new, correct name, but fall back to the older name if it isn't found.  I think that this should be done silently this release, deprecation warning next major release, and removed in Waldorf + 1.
Perhaps can we remove this `REFACTOR` legend now that the modification is in a separate file? /cc @drbrain @evanphx
I'll admit that I took as my design template these existing lines:

  it "are nil unless a match group occurs" do
    def test(arg)
...

committed 5636072
just the default Capfile :)
mapping to null and then filtering nulls out is one way. A better way might be to use flatMap { fileName => if (...) Some(fileName) else None }
That's fine. I've already updated konacha to use window.Mocha.
changelogs must be strictly incremental once they arrive in the Build Service. August out, September back in, please.
Fixed, and implemented in coming commit.
Questo segmento e' outdated. La `ZendSkeletonApplication` ora si installa tramite composer. Quindi qui purtroppo non è sufficiente il lavoro di traduzione...
DocBlock definition don't match with the interface definition. Types mismatch
Third argument cannot be optional if the interface defines it as non-optional.
The intention is for `_vendorPrefix` to slip through so it can be asserted that it's set correctly, not skip it like the other underscore-prefixed ones.
This is probably right, but I don't have this - what is this?
It's no longer the case in recent PHP versions.
What happens if val is not an array? ;)
I'm not sure this makes sense... `Popcorn.options` looks like a "static" property on the `Popcorn` constructor object
Maybe it should return the non option argument along side with the dict?
Rename LocationTest to RestLocationTest and also TrashItemTest to RestTrashItemTest?
because it's unreachable
Prefer using `use` statements to allow static analysis
I have to pass the connection to be able to call custom typeCast as this=Connection.
either you could do that or replace 6 by len('{slug}') which would make 
it more readable.

In any case, you should add a python comment so that people are able to 
understant what you're doing :)
"will submit" => "Submits"
break description into shorter lines
part 3 - for update-single record 
line 136-146
Ah ah, cache bypassing for tests should not be committed :)
Again too many indents.
next 2 lines over indented.
OK got the error! Thanks for reporting ;)
all these `sendMessage` calls need whitespace
@CristinaRO That works better? (I'm still not 100% what can be a generated link in Ruby, so...)
"when scheme is not Basic" or something would read better
figured i'd stick to convention.
You can use the same lock object after it has been released. I'll add it to javadoc.
Well, it's only used there because none of the other connectors use the _DocumentChanges_ yet. Also, there's a corresponding _setChildren_ in the _DocumentWriter_.

The reason why I added them is that any children changes are expressed only via _Name_ and/or _String_ (id) while the methods that allow children manipulation used only a _List(Document)_. Without these methods, imo it's very likely that each connector interested in computing children changes will perform the same set of operations to always get the Name and/or children ids.
shouldn't we keep the entry-utility class? we still have the entry-meta in entry-header. Or should we have two entry-metas?
here you should use the file helper.
деструктор...... ты от него наследуешься
а это не дефолтное поведение?
if it's possible that taskConfig.invocation is null add the check, please.
The next few diffs are just whitespace fixes (some of the indentation in master was wonky).
Note that these have to happen before the logic below, otherwise the calculation of lineSpaceX() will be wrong.
:( Forgot to run the test before commit.
getPrincipalFromRow can now just do a return, which would allow us to vastly simplify this function.
This is no longer necessary, V8 optimizes this for you.
To be nice to developers that want to write Scala IDE plugins in Java. I know, very unlikely, but I feel this is the right reflex.
Is `signature` a method reference? Meaning not a Java5 signature, but a VM-like signature, without generics.
I like it (except the part where we depend on internals of `Enumeration`). Now what would be a better name for `def is`?
The following point is all good, but I think it should not be under recommendations.
Right!

Will update and repost, I guess I need to redo the pull.

Shiv

On Feb 23, 2012, at 5:50 PM, Steve Johnson wrote:

>> @@ -88,6 +91,7 @@
>> 
>> log = logging.getLogger('mrjob.emr')
>> 
>> +S3_URI_RE = re.compile(r'^s3://([A-Za-z0-9-\.]+)/(.*)$')
> 
> Looks like you're behind on merging from master. Please update so we don't have things like this sneaking in.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Yelp/mrjob/pull/378/files#r483505
An "ordinary" number doesn't mean the same thing.
вероятно, опечатка
если i = 1, а count (то есть %) 20, то цикл проработает только 19 раз вместо 20
должен быть 0
или в условии цикла i<=count
В данном случае у вас получается изменение f ячеек, а должно менять f% массива. При размерности массива в 100 это эквивалентно  но если размерность массива поменять то будет уже не то. Переделайте чтоб меняло f% , т.к. данное решение не соответствует условиям задачи.
Oh because this is a WIP, the validation is actually in the next pull request. This pull request is only for the db schema.
No, it is fine. 

If you are in code and can fix it, do it!
Sent on the TELUS Mobility network with BlackBerry
Missing a space between `if` and the open parenthesis, but we can just do `return (boolean) count($this->enabledFilters)`.
Open curly braces `{` should be on a new line.
wat? Why not just call it directly?
Dette har jeg fikset.
Sure, although in principle I don't know why it would /need/ to be really circular and thus just angles. Maybe polar coordinates angles and radii (between zero and one) would be the easiest way to go, since 99% of the time people will just want to do angles, but for some reason someone might want to do arbitrary locations...
please save the file as javascript file not text.
Would it? :-)
Hmm...I see what you're saying. Maybe we could create another `dotprouct` method, which wouldn't be exposed outside this file, that just takes two arrays. Then `Matrix.prototype.dotproduct` would just forward calls to it?
AFAIK, there is no "problems" when the console does not support colors. Colors are just disabled.
I like file comments, maybe add one here?

    // src/Acme/WhateverBundle/FormType/FriendMessageFormType.php

PS: I is better to use the `AcmeDemoBundle` here, because you used it on the bottom too.
Replace with user32.dll for consistency
This line has the same problem as line 33.
This is the part that is a little **hacky**. As when the configuration is created the target attr_accessor is set for both the `project` and `target`. So asking if we are a Target is to prevent recursion.
this line is redundant. It is repeated above.
this might as well be wrapped into an else so it is only conditionally done.
Плохо, base64 может содержать слеши. Заменяй в получившейся строке слеши на `_`.
Умница, как раз то, что я имел ввиду.
я это оставлю тут. У меня что-то хреново работало, когда оно было в инит, и пусть лучше тут.
This shouldn't pass

~~~
Language constructs such as include and require should never use parentheses
~~~
[Source](https://github.com/UnionOfRAD/li3_quality/issues/11)
¿Es necesario esto?
! done ! as method 'sleep'
please remove closing tag
doesn't seem like these would need to be quoted.
Once you move your state to a model object, you can initialize it there and avoid the need for the init() function.
No, the exception needs to be added to the list of parser exceptions. Will fix in next refresh
Ok, that part won't be possible.

You'll have to embed the files (`canton.{shp, dbf, shx, prj}`) in the test resources, extract them to some temporary location and then register it.

1. Place the files in `src/test/resources/org/orbisgis/server/wms`.
2. Extract them in the tests with:

 ```java
File fshp = File.createTempFile("gdms", ".shp");
fshp.delete();
FileUtils.copy(WMSTest.class.getResourceAsStream("canton.shp"), fshp);
// do the same for canton.{shx, dbf, prj}
```
3. You can register it with `sm.register("toto", fshp);
4. When you're done, delete the 4 files.
Updated with latest commit.
But, yes, because of the other mplot3d imports there, removing that line still works, but I would rather keep everything consistent with the documentation.
Just noting that this is not a PEP 8 related change.
Essas mudanças estão erradas, vou corrigir.
Ссылка "здесь" не объяснила мне сложности.

Оно конечно понятно что выпиливать из уже созданного реквеста это время и т.д., куда проще одним реквестом нафигачить кучу изменений, а чуваки которые будут смотреть и проверять что сделали пусть паряться и думают как понять что там такого написали и сломается у них на продакшене что-нить после мега апдейта или нет.
JavaScript execution cycle. Otherwise no other listeners to the tileloaded event would be executed. But I think we should use OpenLayers.Console instead. Will change that.
False $do_it used in libraries/plugins/export/ExportSql.class.php , it needs for mysql export without backquoting I guess.
Even if I found in google what is "|=", I can not figure out what a bitwise operator can do on strings.
Don't do `take 5`; do

```clojure
(fact
  (make-clean 23 #{0 1} #{2 3 255} ndvi reli) => (has-prefix [7753 7955 7635 8360 7888]))
```

That way you're testing the actual function call, not some wrapper around it.
probably just delete commented out stuff
@nicolaasmatthijs space between `)` and `{`
@pluskid oh yeah just that it's written here as well if you haven't checked the irc logs. i've tested yesterday night your patch with using cross-validation on MulticlassLibSVM and it works smoothly! thanks a lot for the patch. let's see if you'll need to remove the STL dependency...
Yeah, I didn't visually compare the color values (my hex literacy isn't that great) - thanks for following up with Paul!
No that's true
ano, ano.. všude má být před závorkou mezera - kromě definice makra :) mi to tady asi jen ujelo..
hi, please update your pull request, this line is in there twice now...
Thanks callum.
I split the note and exercise.  I suggest .art-connections for the feature and .art-exercise for the exercise ( pi and eoc). I liked exercise because it clearly distinguishes the separation of the previous design.

Sent from my iPad

On Nov 19, 2012, at 5:26 PM, Philip Schatz <notifications@github.com> wrote:

> In css/ccap-biology.less:
> 
> > @@ -219,28 +218,33 @@ div.section .titlepage .abstract {
> >  .scientific { .x-feature(black, @cream, CNX_BioMaj_Scienctific); }
> >  .everyday { .x-feature(black, @cream, CNX_BioMaj_Everyday); }
> >  .career { .x-feature(black, @cream, CNX_BioMaj_Career); }
> > +.art { .x-feature(black, @cream, CNX_BioMaj_Art); }
> Hmm, I don't know
> 
> I don't like very short class names but...
> "exercise" doesn't convey any new information since it's in an exercise...
> —
> Reply to this email directly or view it on GitHub.
>
I don't really understand : what do you mean by the attached diff ?
Are you sure the class "Zend\ModuleManager\Feature\BootstrapListenerInterface" actually exists, or did you maybe forget to add a USE statement?
- Are you sure the variable ``$entry`` exists, or did you maybe forget to declare it?
- Are you sure the variable ``$mode`` exists, or did you maybe forget to declare it?
s/projects/organizations :)
If you check it well, you will notice I am not introducing whitespace but removing it. I have delete-trailing-whitespace in my before-save-hook. If you prefer to keep the whitespace I can revert the commit and commit only the interesting hunks.
you would need to supply { id: 1, properties: {} }. but yeah, that would work. it's a bit hacky though.
Can we add the `level` description in a `:param level:` role at the end of the docstring. Also a `:return:` would be nice. I try to follow that so I can later on auto-generate some docs with sphinx. You can see `Frame.locate_frame` for guidance.
had to check for existence because otherwise IE throw some nasty error. (Object doesn't support this action)
you can also use u.size as the divisor -- would make the code a little easier to read IMO
Maybe I'm just not used to it yet, but I actually find the details helpful, so I'm not in favor of the auto-collapse. (and since there's nothing else on the page, the details aren't cluttering anything up) 
Agree/disagree?
`r'^account/confirmation/token/(?:(?P<confirmation_token>\w+)/)?$'` will do it for you. ;-)
*Base class for horoscope providers.*
This is exactly how you *don't* do things in jQuery. This is why jQuery code can be so nice. This can be written simply as:

```
return $('.post').is(function (index) {
    return $(this).data('id) == self.id;
});
```

(See why we are using `self` and not `this`? :-) )

(Code not tested.)
Too complex. Split this into multiple views. One for changing password, one for account.
Start with lower case. Always initialize variable.
I know what you have. But as I said, also those default choices should be based on backends. So that if somebody adds a new backend, they are automatically extended. Not that you have to search around the code where all you have also to change stuff.
Find a better name for this.
We are only supporting 2.6+ so if we are going to change this import it does not need to be conditional. We can always assume `import json` will work.
Please revert this. Putting these comments in the phpdoc of the method does not make sense. There are describing this piece of code, not the purpose of the method.
Well, in your application, you are also using ``null`` to access the default manager from the registry.
the ``onclick`` event seems wrong
Reuse our storage factory?
Rather than having `if userAgent` in the `setUserAgent` method, I think there should be an `if headers['User-Agent']` here.
This function returns a promise that is already resolved yes? Then I'd probably go with `resolvedPromise` or just `resolved` if you particularly want brevity (at the cost of a little less clarity of meaning)
Is the comment above this line still needed or is it obsolete?
This also does boundary checks.
Perhaps you meant Seth Chisamore? (schisamo@opscode.com).
This doesn't strike me like a good idea. Retry on EINTR, complain in the log otherwise.

You don't have to special-case `rc == 0` -  writes < PIPE_BUF (at least 512) are atomic, they either succeed or fail with EAGAIN.
It certainly should. I remember briefly wondering if this function existed and decided it didn't. Fun times :/
This is something I've wondered about previously. Given that our translation tokens are usually the complete, valid English version of the string to be translated, why do we not simply make the translate function return the token itself it a translation wasn't found? It could emit a console message in the process. At least then there wouldn't be a crash, and when I write Lua code I can include translatable strings from the start without having to set up a Languages.lua immediately.
needs maxiter to avoid possible endless loops

Do we need a newton maximizer here, or can we reuse some other ones? Would be more economical to invest into it only once.
For example LikelihoodModel newton has problems when the step size is too large.
I think the second option is the right choice. And I'd rather leave things that way until then, so we don't forget about these annoying conversions.
Slighty better to use `c("x", "group")` so R CMD check doesn't warn spuriously.
What's the reason for the changes below? Just moving code around?
@sefk We don't want to send _our_ csrf token to piazza =)
discussion 2
please avoid such reformatting, it just makes diffs harder to read
No. Here i think Web git diff has BIG bug with tabs. Look in the code.
Without context this message will be really  confusing
And I forgot to make a commit for each correction too  x(
No, this happens before discovery all together. If during discovery we find that the replicaset on the *servers* struct does not match what we encounter through ismaster, it still bails out.
So even Python 3.3's `json` module doesn't support `use_decimal`:

```
$ python3.3
Python 3.3.0 (v3.3.0:bd8afb90ebf2, Sep 29 2012, 01:25:11) 
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import json
>>> from decimal import Decimal
>>> json.dumps(4.561)
'4.561'
>>> json.dumps(Decimal(4.561))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/json/__init__.py", line 226, in dumps
    return _default_encoder.encode(obj)
  File "/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/json/encoder.py", line 187, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/json/encoder.py", line 245, in iterencode
    return _iterencode(o, 0)
  File "/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/json/encoder.py", line 169, in default
    raise TypeError(repr(o) + " is not JSON serializable")
TypeError: Decimal('4.56099999999999994315658113919198513031005859375') is not JSON serializable
>>> json.dumps(Decimal(4.561), use_decimal=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/json/__init__.py", line 233, in dumps
    **kw).encode(obj)
TypeError: __init__() got an unexpected keyword argument 'use_decimal'
```

I don't know if a response would typically have a `Decimal`. Perhaps this is not common?
We should! :)
What version of jQuery are you using? In newer versions it's `on('click', [...]`.
The idea is to be able to declare multiple netatalk::server resources, right? If so, you'll need a newline character at the end of your content parameters value. 

content => "${server_name} ${options_string}\n",
Not an issue, but could not decipher out from the code what's the base path you are using
peek is  good!
Hmm, yes it would. Still, the proxy port doesn't seem to get saved to the file?
Просо без всего. Эти теги в любом случае не имеют представления на странице.
ну нужно избавиться было от _, решил добавить префикс ctor - от constructor
Зачем здесь synchronized?
А где проверка типов геттера и сеттера?
The README should explicitly say that :-)
Done está esta clase ?
Is a ```CommonsLogStopWatch``` necessary, or can we use a ```Log4JStopWatch``` as with the other timings in this class?
Scifio licensing should also be included here?
We are using the `Faraday::Response::RaiseError` middleware, so we'll get an exception if things don't work.
Same here: `valid_engine?`
Again, it needs to distinguish itself from the next line.
The comment is there to remind me and potential maintainers that, indeed, Liblinear doesn't do MLR :)
insert empty line here pep 257
I think I would name this "settle_bills", and not "settle_bill"
No reason (just didn't think of that at the time), I'll make that change.
On failure, kilnhg will return an error object.  I've seen this pattern before (the perforce python API worked the same way).  I just print out the whole error object now, though it may be that it's better to just extract a certain part of it.  I guess we can see what folks find useful.

I don't know if it's possible for _make_review to ever return None.  Probably not.  I'm changing it to an assert, we'll see what happens.

I do have a remaining question though: what to do if _get_repo_to_push_to returns None?  Should I just die in that case?  I can't imagine anything good happening if ixRepo is invalid.
Hmm, I didn't noticed it. Will fix.
this check is independant of the whole for loop and should likely be done before entering the loop at all.  That would also seem like a nice place to use that TiObjectScope class.
Can't you just use obj instead of casting *value everytime?
I don't see why stdout would be appropriate since these aren't outputs resulting from running the app, they're just logs. I don't think it makes a difference though because I see the logs in QDE and the logs/log file on the device. In other words, stdout and stderr both seem to go to the same places.
Hm, I'd hope so, I suspect there are other problems if you managed to rename a different platform file..
I'll re-look though.
memsize_t cast
The first lines of the function are

    //This doesn't really work because the input dataset could contain duplicates, which would generate duplicate
    //values for the keyed join, but not for the index read.
    //I could spot a dedup(ds, all) and then allow it, but it's a bit messy.
    return NULL;

I think probably the correct fix is to delete the whole function.
Then you return NULL from this, have a function that checks if it is non-null and converts that to "unknown", and test no nulls in the self test.

This is a generally useful function, so it should make sure that it is always implemented.
This had no detectable side-effects on 3.8.x code, other than leaking memory...
unlikely to not match, but shouldn't be an assert since legal ecl could trigger it.
In my opinion `rows="20"` and `class += 'foo'` are nice and ``attr:"title:Hello,world"`` is unnecessary. 

And it seems that `attr:...` is in fact unsupported or doesn't work the intuitive way based on examples :) Wouldn't it add 'attr' attribute with 'autofocus' value?

`+= ` example would be nice to see in readme.
Definitely agree, and gave this some thought before going ahead w this (and briefly discussed with @rhelmer). The biggest issue had to do with backwards compatibility with old bookmarked URLs -- thoughts?
@bodepd 
ok will do
Do you think it would be worth having "password" and "roles" field names be constants somewhere, rather than hard-coded strings?
That setter was used internally only getter was exported:

https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/private-browsing.js#L59-61
J'ai supprimé cette partie, car il est n'est pas possible qu'un Etudiant soit administrateur.
Pour l'instant seul un Utilisateur du Service Pédagogique ou un Professeur peut l'être.