labofsahil/github-event-dataset-2012 huggingface dataset:
You absolutely should use the `ARGV.map!` method here, if you *really* want to convert these strings into the symbols.
GWT is used by:

Google AdWords 
Google AdSense 
Google Flights 
Google Hotel Finder 
Google Offers 
Google Wallet 
Google Blogger 
Google Chrome Webstore 
Google Product Search 
Google Public Data 
Google Groups 
Orkut
Google Takeout 
Google Pagespeed 
Google WebFonts 
Google Tables

... don't think these services are all going away :P
I bet you didn't want die() :P
I wonder if it's worth elaborating on the bad things (can rst do footnotes? Hmmmm.)
JS does unsigned bith math (>>>) on 32 bit integers plus sign bit. The high bits of the 5th byte on't matter if they are beyond 32 bit.
Don't worry about manifest warnings, look at that http://code.google.com/intl/es-ES/mobile/ads/docs/android/fundamentals.html#requirements
Yeah I'm about to refactor this code now, just thought I'd commit while I'm in the green.
I appreciate that you took the time to implement this, but I'm reluctant to diverging away further from the (outdated) Narcissus version we currently embed. A quick look at https://github.com/mozilla/narcissus/blob/master/lib/lexer.js seems to indicate that they have \r\n support there now. Also, David Herman has merged a number of fixes from other Narcissus users in the past months. Those will benefit us too.

We really want to get rebased as soon as possible. It's not easy given that our version of Narcissus is modified to produce a better (for Shaper's need) AST. If you're interested in participating with this, let me know. Otherwise I'll try to plan for an evening of rebasing fun.
Since eZ Publish 4.5, we have an event system [1], it allows to do exactly the same thing with less code, wouldn't it be interesting to use it?

[1] https://github.com/ezsystems/ezpublish/blob/master/doc/features/4.5/event.txt
форматирование кода неверное. нужны пробелы и перенос строки. Ещё кажется нверный отступ, пробелы вместо табуляции
http://pastebin.com/aysba980
The patch is available here:

http://www.mediafire.com/?o652vhh66blk52z
This way any of the classes can be easily swapped out for another. You could even run two instances of Swiftlet together if you wanted to. The first three paragraphs under "The factory pattern" in this article explain it nicely:

http://www.ibm.com/developerworks/library/os-php-designptrns/

Less global state should also make unit-testing more easy. I admit I did like the look and simplicity of `App::getModel()` though.
Thanks for you Info !
I am a German and my english write have a little rust.
I hope at is good enough for you ?!  

I think it is better when the User make a little wire on the original SD Ramps Card and it all works, only must change the SDCARDDETECT Pin and change from INVERTED to NOT INVERTED, thats all.
The most people have not an selfmade SD-Card Adapter, the most have buy the Adapter in an Reprap Shop.
I think better is when  make a Software in the code and the user have a config-switch and can easy switch between ?! 

I have little change the code for me and i  put the Card in and the LCD show Card insert, and i put out an the LCD show not inserted.
And i have when not a Card insert and i make the Raprap ON show my Username of the lower Line on the LCD ( i have another change in the Text "Reprap reddy"  in the Code to my Username and i have a personal Printer

Infos over me

PS i work in professional Electronic and design it, i make electronic, programming and  PCB in my work and my hobby, and i am 50 years old/young ;)
At the moment i work on a better Extruder in my hobby, i have in my House a lathe an a selfmade CNC machine  

Thanks for you work.
I hope you are not angry over me ?!

Hardwarekiller
argh damnit, in der langen version war es noch richtig, wird sofort gefixt
ya begitulah....
(Going through and marking all the places that should be model makers.)

This should be a model maker.
Thanks for your collaboration! =)
these two rules are already covered [below](https://github.com/vaidikkp/zamboni/blob/56b914/media/css/legacy/main-mozilla.css#L1351)
I was so going to take credit for this in a future commit
Personally I don't care much if some rules are generated even I'm not using them, because the most important thing is that all works as expected. anyway in bootstrap there are many rules that I don't use, eg. some basic components and some base css.

@fat I proposed my solution without knowing at all about `guards` of `less`. I like very much your branch and I'll keep watching it. I think it is the right way to follow: having some more complexity in the less files but generating as little code as possible in the css
shouldn't that be exactly the other way around?
Would it be possible to use `[ci skip]` in commit messages when only CSS or docs were updated? [Diaspora takes 3.5-5 hours of travis-ci.org workers time per push](http://travis-ci.org/#!/diaspora/diaspora/builds). That can be 20-30 times more than average.
It was but I added `no-results` since I am a big fan of consistency and DRY should help us with RTL resolutions and such in the future
yeah, whoever I stole this from had it indented, and I haven't taken the 3 keystrokes it would take to remove it. oh well
What does this need to be updated after the renaming?
Зачем нужен пустой else блок?
Ok, I think it's much better like this:

```c++
struct AttributeInfo {
    AttributeInfo():
        minimum(std::numeric_limits<double>::min()),
        maximum(std::numeric_limits<double>::max()),
        modifiable(false)
{}

    /** The minimum and maximum permitted attribute values. */
    double minimum;
    double maximum;
    /** Tells whether the base attribute is modifiable by the player */
    bool modifiable;
    /** The attributeInfoType (stackable and effect types). */
    std::vector<struct AttributeInfoType> attributeInfoTypes;
};
```

I've seen nowhere in the code where the attributeInfoType should be separated from the attributeInfo. I will have to make some tests to be sure, of course.
@PheonixKotori: I think this is fine for now, but if security is our goal (and must be, with such a high-profile big budget project such as this) we should use something a little more resistant to brute force.  A true 128-bit GUID is probably overkill and uses too many bytes, as you mentioned above, but 5 numerals is easily crackable.

Compare "time to enumerate" of:

* [5 numerals](http://bit.ly/yC3Z6r) and
* [5 alphanumeric characters](http://bit.ly/w12ywx)

This would also cut down on the chance of duplicates drastically, and although duplicates aren't likely even with this current setup (especially given that we are of course not anticipating thousands of concurrent Cinch players), I think it's always good to optimize. Capping the loop to `MAX_GUID` iterations is good too, and of course necessary any time random numbers are generated that must be unique.

(Related to issue #14)
@Rodgerwilco CodeForFame mentioned before that XStream isn't compatible with Java 7, I don't know what if any other reasons there were for moving away from it.

Maybe we could use something like this?
http://java.sun.com/xml/tutorial_intro.html

I'm really not familiar with any of them, suggestions?
I don't understand why the following two methods are overridden here.  cloudstack is already in rest.properties...  can you look at IpClientExpectTest for an example?
David fixed the release issue, here you can find it https://github.com/arranger1044/iSoul/downloads
Try this.

```ruby
BigNum.class_eval do
  alias_method :old_mul, :"*"
end
```
Will do. I'll wait until we finally change the template_3.0 directory name.
I'd suggest splitting the image / js / html changes into separate requests.  It's very unlikely we will now accept pull requests changing the default button colors, you will want to supply them as a separate file.  Perhaps considering putting together a "blue theme"?

Your code is close to meeting the guidelines, afaik there are some in the wiki but basically they are "keep commits concise and focused" IE one commit may be "new pad editor images" or " change function closures to match best practices"..  

If this document does not exist (The guidelines) it would be interested to read a draft from you on what you think would be good guidelines?

Thanks


J
Not needed, since an exception was just raised.
Fixed up some unnecessary whitespace changes I made.
Can you not do `for (var k in localStorage)`? (Haven't tried it, just wondering.)
I liked the wording before can you please remove "Note:" the fact that its styled the way it is already calls it out as a note of some type. Thanks. Sorry to be so picky :)
You can use builtin method [to_s(:db)](http://api.rubyonrails.org/classes/DateTime.html#method-i-to_formatted_s).
comment is before tag-stuff. no bueno.
@huacnlee 那加个 `unless Section.count > 0` 之类的 block 包起来吧，用注释不太好的感觉
Register olurken daha önce girilmiş bir mail adresi tekrarlandığında duplicate hatası alıyorduk.Bu yüzden emaili check ettirdim.Buraya kadar bir sıkıntı yok.Eğer o mail daha önce girilmişse else çalıştırması lazım ve 'No' hata mesajını verdikten sonra redirect yapması lazım.İşin garip yanı redirect yapıyor.Ama ondan önce gelen setFlash ı çalıştırmıyor.
YEEHAA!
Hm, after restarting it's ok'ey. Value is permanently 2. But after another changing it alternates again.
So, I can't use this option in such dynamic cases? Because I'm need to be able to change option as many times as I want without server's restarting.

PS: but really, do you know what is the reason of such behavior?
Good point. I haven't found a way to get a github raw url to a specific commit or tag. Suggestions?
https://github.com/ChaosEMU/ChaosCore use this core and db. My repo is for tests
Not sure it must be a && instead of a ||.
There are really few spells having all three requirements (44 to be precise): http://tinypic.com/r/25ftuna/5
Is it safe to call WebSocket.start() from another thread? It would be safer and more in line with the model we used elsewhere if the user could pass in an j.l.c.Executor which work will be guaranteed to run on.
Wait, 60 seconds?? The only reason there's a delay at all is to prevent this from activating on quick switches to the address bar and such.
The intention was that focusing on other applications would result in unread message notifications, the same as focusing on other channel tabs within the app.
You probably just need to put xwiki-commons-logging-logback as test dependency. Nobody directly depends on it except XE.
Function names like this are not very informative.
Add ``:only => :steam_login`` or something.
I didn't try that config because I wasn't sure what it meant by its name.
We can use template parameters in here. 

color: var(styleForumLinkcolorText);

And put the variable into template.xml
There is a sys/types.h in Linux, so yes, having a header named types.h is a very bad idea. We had tons of trouble with a similar case in FCEU where sys/types.h would suddenly pull in the custom types.h instead.
why not void*
В нашем случае надо использовать гем formtastic, потому что на наших проектах мы используем его, поэтому данным гемом надо строить формы
yes, we should handle this in the DI container, yes. something like lukas did here, i guess: https://github.com/symfony-cmf/ChainRoutingBundle/commit/cc576d6c0c03aae08a81cb300852fc8de28eac28#L1L76
Trying to make an inane comment from a not-Mac!
I was talking about running Doxygen itself (i.e. generating the .tex file).  Sounds like we've got both of the necessary parts.
Why not a BioclipseException? Can you explain that in a blog post, please?
Node.js 0.5 is no longer provided (it was development series of 0.6.0). An up-to-date list can always be found in our [CI environment page](http://about.travis-ci.org/docs/user/ci-environment/).
I think this might have to do with what version of gcc is being used...I use gcc-4.4 on Ubuntu 11.10 still and I never have this problem.
check comments above.
Maybe use `templates['mytemplate']` here instead of `JST` because you've specified a custom `JavaScriptVariableName` in the previous configuration example.
novalis, do these elevation changes fix #563, or will that be a separate task?
/music all down to 221 ms.  I...guess that is ok...
The version published on nhforge states "3.2" - is this information duplicated in the file?
I just upgraded my instance to 1.3.7 and my jobs can no longer create views.  I use base clearcase.  I see that this commit was made to change the way the view storage works but I can't figure out how to get this to work again.  Previously the view storage was kept in the workspace of the job and it did that automatically.  How do I get it to do that again?  From the wiki page, I can't tell what I should do.
Das hier benötigt noch einige überprüfungen um crashes vorzubeugen!
Bin jetzt aber erst mal Dragonball schauen :D
Is this correct? Since replacing a rollingFileLogMsgHandler?
Where is `self._redirect_nextprev` defined?
Have you seen which objects cause conflicts?
If this is not roxie (lowercase) then the environment.xml is invalid. I don't think the regression suite should be second-guessing that. The xml schema and configmgr should be enforcing such things.
En nog eentje in backend/modules/progiles/widgets/registered_today.php, lijn 90: die empty lijn moet weg
Yeah, this would be better
I believe this should be "Symfony\\Bundle\FixturesBundle"
感謝提醒，已修正此問題
Every object with a table has a unique attribute called id. You'll likely
want to use it instead of student number.
On Jan 18, 2012 6:56 PM, "Gizmmo" <
reply@reply.github.com>
wrote:

> hm nvm I see what you did its so that user has a means of connecting with
> the two other databases.  But anyway more importantly, what is the
> professors primary key?  Student has student_number, what is the
> professors?  Right no Im using username to call it individually, it seems
> to me that professor will need a  unique key so we can call it
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/GarrettSmith/UW-CA-Testing-System/commit/de12d78880008217368edfe20656c5ee605b0ea0#commitcomment-880373
>
I would also mention non-final
ref #157
Hrm, well, apparently ruby 1.8 doesn't have lookbehind. Boo.
j'ai fait une modification dans un fichier
by removing opengl renderer, the ui will lag or not?
works for me on 1.5.1
thanks.
Andrew, roll this back right now.
Error trying to restore snapshot
I'd like to see a test for this.
Good point. Moved.
How is this better than just using Long.parseLong and having it throw the parsing exception?
https://github.com/akka/akka/pull/407
`postRestart` will then subscribe again, is this intended? If yes, a comment would be in order.
The last commit implements what we discussed today.

Unfortunately, now that I finished it, I remembered I had tried this once before and in testing performance suffered.  Specifically, it doesn't buffer nearly as much as one would expect.  What happens is that the client protocol loop(s) spin faster than the single channel loop pushing messages onto the go channel.  In the protocol loop, you end up hitting the `default:` case (and flush) because there aren't messages sitting on the go channel the loop consumes from (it isn't buffered).

I can do some more testing and see if buffering the channel helps, but I now remember why I ended up going with the `channel.depth()` check approach... specifically because it is a clearer indication that messages are immediately coming (even though they may not yet have been pushed onto the channel).
The only inline comment I see is an added one about the fallback to key for codename.  That's my comment in the updated code, right?  Or are you referring to something else?
You are right on the point that this is another mapping to maintain; however this can be easily solved (actually originally I did get the list by importing all the submodules in the packages with an os.listdir() but changed the design to explicit import for simplicity).
The advantage of the module level constant AVAILABLE_GSIM is that that would appear in the documentation tools.
This is something valuable, more than just a function checking if the class exists or not. In particular help(nhlib.gsim) would show the user all the availables classes. I also think this is something that should go in nhlib, non in the engine, because it is documentation of the nhlib.
Ok for a seperate request.
It is easier/cleaner to just write

`{% set except_names = except_names or {} %}`
Bad indentation of this whole block
Done. Requires cleaned up and Dr.Racket formatting used.
Break the line.
Since this attribute does not represent the host anymore but the "base" we should change its name too.
this exact same piece of code warrants to be put inside a method
with xdebug disabled ?
but it's the "if we're really really really screwed" assumption now, instead of "if we're screwed".
This size should be in a constant.
eeeeeeewwwwwwwww! it's a `retain` guys! ostracize it! But no, seriously, you want `strong`, not `retain`. Cuz, you know, it's buff and doesn't retain math books in its head like that.
I won't be able to use `-setNeedsDisplay` to refresh the cursor otherwise.
Hmm, isn't it possible to just call close() on the reader at a later point? I guess this works but it's a little hacky.
I think that test broke because of the changes I made, and I decided to make it more readable as I fixed it
This one was already fixed at c46208c2aa64414f0e1298ed494e864884f13a32
Split it into a do / end block.
:+1:  I'll be more careful henceforth. Thanks.
What extra spaces? The indent between 'options' and '= @options'?
This seems too eager. It causes spurious warnings like this one:

    case ex @ ShutdownReq =>
         ^
    src/compiler/scala/tools/nsc/interactive/PresentationCompilerThread.scala:39: warning: This catches all Throwables. If this is really intended, use `case    ex : Throwable` to clear this warning.

Note that `ShutdownReq` is an object.
same argumentation as for `isDefaultParam` vs `hasDefault`
are there any limitations created by extending the Runnable? I'm not sure honestly what differences if any there are between extending a trait and self-typing a trait. With a class I guess there are cases when you can self-type but extending would not be allowed. But maybe self-typing a trait/interface is always wrong.
These shouldn't be here, I think.
Good catch.  Fixed in most recent post.
On Wed, Dec 12, 2012 at 3:35 AM, Julien Rioux <notifications@github.com>wrote:

> In sympy/matrices/expressions/matmul.py:
>
> >
> >      def _eval_transpose(self):
> > -        from transpose import Transpose
> > -        return MatMul(*[Transpose(arg) for arg in self.args[::-1]])
> > +        return MatMul(*[transpose(arg) for arg in self.args[::-1]])
>
> This is the line that causes the behavior
>
> >>> transpose(2*X)
> X'*2
>
> something better could be done, maybe using as_coeff_matrices.
>

hmmm...it's traversing in reversed order. So if you separate off non-matrix
args first, that should do it, something like

```
h, t = self.as_independent(Matrix, as_Add=False)
return h*MatMul(*[transpose(a) for a in Mul.make_args(t)])
```
I've raised a few points on this PR. Should I expect them be be handled on this PR or on a different one? I'll look through it again in 24 hours. 

I suppose this is the reason not to have multiple PRs open.
This is for ``SpinState`` rather than ``SpinOpBase``.
could you add PEP8 spaces here, too? (i.e. space after the comma)
The docstring I had written was a little contorted so I decided to leave it blank. I have added a docstring now though. Just waiting for the decision on the '*'/PEP 8 comments to push again.
When you do that, keys will be order-sensitive:

```
>>> (1+x).sort_key()==(1+x).sort_key('rev-lex')
False
```
Let's talk about how we can do this better - we should not have to change this for individual environments.
Changed in b349e50
It should not be called `Coordinates` if it really represents spherical angular coordinates. I think `SphericalCoordinates` would be fine. I don't think adding an extra import level solves the naming problem...what's the issue with naming it what it is? I want to be able to subclass and make my own 3D cartesian coordinate class, naively I would subclass `Coordinate`, but under this scheme that would be wrong.
it shouls be ``</providers/twig>`` (see the example in the code you removed)
Move var XMLHttpRequest and prototype override to test initialization code
Why changing from live to on?
Even if it does work, that's not what you are supposed to do. Change the <%= common_id_class %> back to #{common_id_class} and it should work as well, except without one tag inside another.
Doesn't defaulting these here mean that if the system limit is changed (to something lower), every pair will be considered in breach unless it has its value changed?

Could we not introduce some kind of value here that means "use default" - such as perhaps making this a java.lang.Integer, and therefore optional?
Sounds reasonable - I might just create a different exception class though, e.g. MissingMandatoryFieldException
is simmilar
do you need this in here for production?
Needs an exception message explaining the problem.
The rest of phpbb does not use 401, are you sure this is what you want?
How is word length an array?
These casts look highly suspicious.
There are varying opinions on what should happen with all. My version is "all" means "all", not "default".
https://gist.github.com/547b56c56712a5b6752e
Or, Allow "Remember me" logins
This should be renamed append or prepend should be renamed to before.
"mus" => "must"
You shouldn't need to `parseInt` this, as it casts it to string for the key anyway.
Maybe cast to `(int)` here. Just to make sure.
That's how it was in the original pr but I changed it after a developer reviewed it and suggested it be changed.

----- Reply message -----
From: "Jakub Senko" <reply@reply.github.com>
To: "David Colón" <david@davidiq.com>
Subject: [phpbb3] 10786 - Javascript toggle member search panel in memberlist.php (#768)
Date: Tue, Jul 24, 2012 8:27 AM


> @@ -1439,7 +1439,7 @@
>  				'S_IP_SEARCH_ALLOWED'	=> ($auth->acl_getf_global('m_info')) ? true : false,
>  				'S_EMAIL_SEARCH_ALLOWED'=> ($auth->acl_get('a_user')) ? true : false,
>  				'S_IN_SEARCH_POPUP'		=> ($form && $field) ? true : false,
> -				'S_SEARCH_USER'			=> true,
> +				'S_SEARCH_USER'			=> ($mode == 'searchuser' || ($mode == '' && $submit)),

Don't know if it is required or not, but I have always seen adding full ternary condition in phpBB, even if results are boolean values:

`($mode == 'searchuser' || ($mode == '' && $submit)) ? true : false,`

---
Reply to this email directly or view it on GitHub:
https://github.com/phpbb/phpbb3/pull/768/files#r1224204
oops, I see you do that in subproccheck
It is not going to be pointer to a temp string because compiler would complain. It it going to be reference I think now compiler allows it? So it is safe.
we need to put this back in the case that content != ''
Could these variations be handled via parameters rather than duplicate code?
Hello Andrea!
So if the collection is null, I have added to return null, and, in this case the DSIndexer has nothing to index
Do you think I should query the workspace and workflow tables to discover the right collection? Does DSpace in any case indexes also workflow or  workspace items?
Many thanks!
Rania
Docblocks? Waarom public?
Use piyush92's new person uuid here instead of hardcoding
is this still needed. Do we automatically pick the appropriate projection now?
No, but I found limiting the extent in a general, robust way was non trivial.
I don't understand what these two lines are for.
My stupid blank option check logic error, fix it.
Brace style seems inconsistent.
I do not realize the efficiency problem, but it's good to keep the code as clean as possible. Thanks.
A byproduct of a weird refactoring. Will fix.
Perhaps use the form tag from bob?
Any one is fine.
Avoid hardcoded scripts, they cannot be cached.
Nitpicky...why not use proplists for the options to make the intention more clear.
Should be `$plugin . '.Event'`
There exists a couple of EPS* macros used in a number of places (CompMap, ResourceBuff, IsoVectorTests, MaterialTests, etc.). Those macros are defined in places like CompMap.h, Material.h, and ResourceBuff.h. 

I think this CycLimits class is a good thing. I'd like to suggest that in this pull request the EPS* macros be replaced by eps() instances in this class. It's confusing to have both limit macros and a CycLimits class.  So, let's get rid of the macros?
This was a nested function, and the same or very similar code appeared in a couple places, so it has been refactored out into a method on the base class. It converts each chunk of content to a bytestring with the appropriate encoding.
Ah yeah, that's better. Thanks!
Consider adding a new line to all your files
Yes, that's where the rewriting happens. I don't think any rewriting is necessary to support smart pointer capture. `lambdaUnpack` can return `a^` and `b^` by reference. If you can avoid deep rewriting, then I think that will improve the currently poor lambda compilation performance, because the body AST would not need to be deeply cloned anymore.
I still think this should be an undocumented, private, method in manipulation.js. `_domManipScript` or something. It serves strictly no purpose outside of `domManip`. Other ajax implementations can just override it if and when needed.
And no, the state table is not necessarily just one row. If self.truncAfterIteration == False, then all states will be kept.
Good catch. This is comment is a left-over from copied code, and it is clearly confusing and inappropriate. The comment should read sth. like: "Did not find this group value. Since the underlying state is immutable, we will raise a runtime error. Obviously, this error should never occur."
These for-loops has been replaced with matrix operations.
It seems this could be done by generate_series() and random().
This won't work; `brew test` doesn't have access to the source.
I delegated the fingerprint functionality to RHC::Rest::Key#fingerprint. See 9901b12
Is this a debug output?
wrong variable name - should be $host_name
^Return the comment's score.

I'm not quite sure if you call the score of a comment, or the score of a submission karma. I know in the context of users, their aggregate comment score is called the comment karma, likewise their aggregate link-post score is their reddit karma.
would call it "number_of_repeats' or 'num_repeats'
macht das sinn?
This should be uncommented or deleted
On Tue, Oct 23, 2012 at 3:20 PM, Christian Edward Gruber <
notifications@github.com> wrote:

> In README.md:
>
> > @@ -163,7 +163,7 @@ class CoffeeMaker {
> >
> >  ### Lazy injections
> >
> > -Sometimes you need to make a dependency lazily created.  For any binding `T`, you can create a `Lazy<T>` which defers instantiation until the first call to `Lazy<T>`'s `get()` method. If `T` is a singleton, then `Lazy<T>` will be the same instance for all injections within the ObjectGraph.  Otherwise, each injection site will get its own `Lazy<T>` instance.  Regardless, subsequent calls to any given instance of `Lazy<T>` will return the same underlying instance of `T`.
> > +Sometimes you need to create a dependency lazily.  For any binding `T`, you can create a `Lazy<T>` which defers instantiation until the first call to `Lazy<T>`'s `get()` method. If `T` is a singleton, then `Lazy<T>` will be the same instance for all injections within the `ObjectGraph`.  Otherwise, each injection site will get its own `Lazy<T>` instance.  Regardless, subsequent calls to any given instance of `Lazy<T>` will return the same underlying instance of `T`.
>
> Maybe:
>
> "Sometimes you need an object to be instantiated lazily. You can achieve
> this by depending on a Lazy rather than on T directly." etc.
>
> This avoids the lazy-dependency-creation terminology a bit.
>

I went with "Sometimes you need an object to be instantiated lazily".

>
We're standardizing JUnit on 4-space indentation.  Can you fix?  Thanks.
This looks like an injection point -- should `ins` come through in the binds?
shorter:

```
dojo[this.item.link ? 'removeClass' : 'addClass'](this.externalLink, 'hidden');
```
This is 3rd party code though, right? Is it worth auditing their style?
Yes, we should coordinate with PM since this is our first breaking change. I'll let Adam know.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Wednesday, June 13, 2012 7:55 AM
To: Ty Voliter
Subject: Re: [brackets] Context Menu API, partial implementation (#1012)

>       *      AFTER or BEFORE, ignored when position is FIRST or LAST
>       *
>       * @return {MenuItem} the newly created MenuItem
>       */
> -    Menu.prototype.addMenuItem = function (id, command, keyBindings, position, relativeID) {
> -        var $menuItem,
> +    Menu.prototype.addMenuItem = function (command, keyBindings, position, relativeID) {
> +        var id,

REMINDER: Removing id parameter will break existing extensions, so we need to announce this to the community.


---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1012/files#r976650
Is this background color necessary? (It's opacity 0 anyway.) Does it not get mouse events if it doesn't have a background color?
Nice suggestion! I didn't think through that we no longer need this parameter.
I fixed this by selecting all the text by a click handler on the field.

Ty

-----Original Message-----
From: Jason San Jose [mailto:reply@reply.github.com] 
Sent: Thursday, May 10, 2012 11:14 AM
To: Ty Voliter
Subject: Re: [brackets] File Open Performance Tests (#841)

> @@ -62,7 +62,8 @@ define(function (require, exports, module) {
>      function _handleShowPerfData() {
>          var $perfHeader = $("<div class='modal-header' />")
>              .append("<a href='#' class='close'>&times;</a>")
> -            .append("<h1 class='dialog-title'>Performance Data</h1>");
> +            .append("<h1 class='dialog-title'>Performance Data</h1>")
> +            .append("<div align=right>Raw data (copy paste out): <textarea rows=1 style='width:30px; height:8px; overflow: hidden; resize: none' id='brackets-perf-raw-data'>" + PerfUtils.getDelimitedPerfData() + "</textarea></div>");

Um, so I just tried the feature and I can't do CMD+A to select all. I have to drag a selection and CMD+C to copy out of the textarea. Is there anything better we can do?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/841/files#r803784
I think you mean `editor.lineCount()` but let me know if I'm missing something!
Nothing, just an invalid tag info. Not even the tag name as we don't want to show or keep any code hints until a space is entered.
These vars that aren't modules shouldn't be merged into the same 'var' stack.  Ideally, we'd have each of these be separate with a JSDoc `@type` annotation above it.
Do you think there should be tests for an invalid regexp? We could make sure the `.alert-message` div is present and that the code doesn't choke.
ok. one underscore should be enough though
What does this function do exactly? It seems like it does a mixture of parsing our information and packing it into url query strings. Seems like these two steps could be broken out and simplified. If cleaning it up isn't an option, at least note in a comment what the function does and why it has to be that way.
Space here please.
So I'd just remove the extra wrapper around the `version` object.
Hmm i haven't used it. But I can put it back and use it.
"local and s3" should come after a full-colon, not a comma.
I wanted to avoid getting mixed up between new and old. How about a classname that sets everything new?
and below as well ( sorry for commented so much on the same issue, didn't look down before commenting )
IMHO ja, diesen Case jedoch würde ich ignorieren. Es würde jedoch schon ungemein helfen, einfach an der selben Stelle wieder anzukommen. Dieses Fass wollte ich jetzt nicht auf machen, und noch die POSTs nachschicken.

Zum Thema URI-Tags: Dadurch säubere ich halt $_GET. Sonst wäre ja nen XSS möglich. Evtl sollte ich htmlspecialchars() machen?
it seems like with the update to #load_parameter_groups this shouldn't ever be nil and you don't need the fallback `|| []`, though I don't know the whole code path here and I may be wrong.
I think we should do the following:

1. make the `factory_girl_class` method on the adapter a class method
1. change the spec_helper to use that class methods to load the factory_defnitions

@danielfrey what do you think?
I wrote to Parse to see if they are OK with this binary redistribution.
Doesn't this belong in the catalog backend?  If our catalog abstraction layer doesn't even provide a consistent interface (requiring hasattr) I would argue that it's too low-level.  Let's shoot for this method to look more like:

```#!python
def search_result_detail(request):
    uuid = request.GET.get("uuid")
    catalogue = get_catalogue()
    record = catalogue.get_by_uuid(uuid)
    return render_to_response('maps/search_result_snippet.html', RequestContext(request, { rec : rec }))
```

The idea here is that all the matching up of Layer to metadata and massaging into a template-ready format is done by the catalog backend.
True, but the point still stands that retrieving the content from a Datastream object (an API-A call) involves initializing the entire array of properties -- which is an API-M call. That assumes the fedoraUser has access to both interfaces, and IMHO that is not a reasonable assumption to make.

It would be much better to have a lazy initialization of the API-M properties (via getDatastream()) only if access to those properties is necessary.
It's used only if install_foreman == true, but we can remove if you don't like it. No issues for me.
Why not `call_git`?
Probably don't want to keep that...
@andycasey - you are not the only one concerned about memory. Actually, I think that what @taldcroft is suggesting:

    c.b

should *not* work. It should be:

    g = c.galactic  # the computation is done here
    g.b
    g.l

which means that caching is no longer really needed.

But I have to say, I think that this is a point where @eteq and @demitri's API is nicer:

    gal = c.convert_to(GalacticCoordinate)

it allows one to specify any valid coordinate class, whereas the API here requires an attribute which does some computation (and we did say in the coding guidelines that attributes that would be computationally expensive - which this will be for 10^7-10^8 sources - were discouraged). It makes it obvious a computation is being performed. And it doesn't require any caching.
for calculat**ing**
这个更像NE操作符，是不是叫NotEqualQuery更好？ 修改了NotQuery的含义对于从老代码迁移过来的人不够友好。
I'm rather sure this was removed, because of the bitcoingui.cpp cleanup I did some time ago. That string was a tooltip as far as I remember. And it is still used and in the translation files for the sign/verify message dialog.
Incorrect indentation and missing braces.
It's requires by cgxp.plugins.Profile.Control 
you split them by class than dispatch it also :-)
here you're throwing an exception and catching it, if you want to "do nothing" just put pass
char_id
Please end the file with a newline, if possible.
Does this need another Javadoc @param?
Not every host has a new enough python to have simplejson available. Do this:
```python
try:
    import simplejson as json
except ImportError:
    import json
```
It seems like we need to decide 3 things:

1. Should the iteration stop on any non-zero value from the callback or just values less than 0?
2. Should we return 0, -1, the callback value, or a special EUSER code when the callback stops the loop?
3. Should we call `giterr_set` when the callback errors or not?

I think the answer to 1 is that any non-zero value should stop the loop, and I think the answer to 3 is that we should not call `giterr_set`. If the foreach function is being used internal to the library and the callback wants `giterr_set` to be called, then it should be done inside the callback.

I no longer am clear on the right answer to 2. There seem to be good arguments for each of the possible cases. I'd love to hear more from some of the binding authors / users...
:+1: Much nicer.
That was based on the value in our settings for `DOTLANG_CACHE` being 60. I think we should consider increasing that as well to at least the length of time between the cron runs.
at least call it `debug_log`, `D` is very 1965 FORTRAN.
strangely, yes it was.  I'm suspicious that it may be different in different versions of the 'web' library.
I guess I'm the one guilty for this for not making it more obvious but you're missing `app_version` here.
in case of exceptions that is not available.
Is "use strict" required? Maybe explain why it's here and what it does.
And a reply
Any reason why this isn't in GLOBALS?
Please move this to the strategy implementation, this class should not be changed.
I had several possible names like: `SubRequestRenderingStrategy`, `HttpKernelRenderingStrategy`, `FallbackRenderingStrategy`, and `DefaultRenderingStrategy`. In the end, I chose `DefaultRenderingStrategy`.
I *think* the pull request now contains a revert for the checkstyle
thing. It also contains other commits that are already in your repo,
not sure why.

On Tue, Apr 3, 2012 at 2:26 AM, John Sirois
<reply@reply.github.com>
wrote:
>> @@ -120,18 +121,39 @@ def execute(self, targets):
>>        of (conf, jar path).
>>      """
>>
>> +    def dirname_for_requested_targets(targets):
>
> you could use self.context.id
> see context.identify: https://github.com/twitter/commons/blob/master/src/python/twitter/pants/goal/context.py#L32
> If you wan't to change that to use sha1 instead of md5 - sgtm
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/twitter/commons/pull/22/files#r638015
You are correct - my bad. I know we did this without braces elsewhere, but now of course I can't find it. Carry on.
This should be `#error`.
This template uses `@event.name` and `event_url(@event)`, the presence of which are not tested in this spec.
тем более что тесты по любому надо делать. unit
I'll be sure to play around w/ ohai later today, would be awesome if it could do the heavy lifting.
If the pool_size is one, we shouldn't create a thread pool.
Actually we do need two functions for later if we want
to support other types than float.
If it has to be a generator, perhaps ```iter(self_geoms)```, but I'm not sure it does have to be?
Agreed it's poor.

It's even more awkward now I've removed owslib because the above suggestion is no longer applicable.
We are now mocking *urllib* and it's *urlopen* function.

One option is to do the image comparison in the test, rather than via the decorator.
That way we can restore the mock before exiting the test.
That's why I was thinking:
```js
{Promise.<string>}
```

and for this case it'd just be `{Promise}` or `{Promise.<void>}`, but probably doens't matter much.
== is actually the recommended way here
I'm not seeing the GC/finalize dependency from looking at the Executors.newCachedThreadPool() javadoc or the ThreadPoolExecutor source (perhaps I missed something).  The Javadoc description is:
"
public static ExecutorService newCachedThreadPool()

Creates a thread pool that creates new threads as needed, but will reuse previously constructed threads when they are available. These pools will typically improve the performance of programs that execute many short-lived asynchronous tasks. Calls to execute will reuse previously constructed threads if available. If no existing thread is available, a new thread will be created and added to the pool. Threads that have not been used for sixty seconds are terminated and removed from the cache. Thus, a pool that remains idle for long enough will not consume any resources. Note that pools with similar properties but different details (for example, timeout parameters) may be created using ThreadPoolExecutor constructors. 
"

I did make the ThreadFactory non-daemon so that the AS wouldn't stop while persistence units are stopping.  I'll test some more to see if it takes 60 seconds to shutdown the server after deploying a JPA application.

For implementing the better solution, that sounds like a different jira is needed for that (and probably some discussion with David to see why we don't have general short/long term thread pools which I thought we did earlier).
This will be the first place that we set document or application role in jQuery UI. Can you explain why this is needed and whether it affects all AT or just specific ones?
If you can remove that I think that's fine to land.
Instead of adding more and more indentation do something like:
if (ThreadUI.delNumList.length + ThreadUI.pendingDelList.length <= 0) {
    window.history.back();
    return;
}

// Rest of the code without indentation
nit: `time.dataset.timestamp = timestamp;`
(if you’re a Vim user, just do a `:retab` please ^^)
It's *really* tempting to click this button when it appears, instead of the "next" button in the header...
I don't understand this name, why does it represent?
What's the output of

    adb shell "echo $PATH"

?
wow I can't believe I did that!
Do you really need this getter/setter here?
The WebActivities might come handy :)
@gtorodelvalle It's already fixed ;)
minor comment: can you remove those trailing ' characters, please?
Treba to na radce 15 tak vypadlo z konvertoru. Jablicko rika, ze se to tak deje i dal. Asi tri zavorky jsem tam z nejistoty pridal sam.
@filipewl, removed. f00a30b538
Rather than hardcoding this to `37`, maybe this should use the configured default color?
Should help with defaults
I´m aware that this is not obvious.
This line applies the Appendable mixin on an object and assumes an error when 'view' property is not set.
`Ember.required()` just works when the mixin is applied after creation which is not surprising because before creation it can´t be detected if a property is set.

Maybe I should just remove this test? The only thing it really tests is that the value of `view` is `Ember.required()` and not just `null`.
Yeah ok, on first read I thought that you are dropping all the fields in the right side. Can you add a couple more tests maybe? At least one where you have say ('x, 'y) on the left and then ('x, 'z) on the right and you end up with ('x, 'y, 'z)?
Should probably centralize all the type checking at some point...
Add a `:` after `ValueError`.
also please don't break the current code conventions like placing the opening brace on the same line as condition.
I'm not quite whether I should push this to another array or not to avoid calling it twice.
There's no reason, other than lazyness. Test was implemented much like a mock class, just to fill out the void of the autotest test class, that does a lot more stuff...
Well, there's no need to check this here, since we're only getting information about the install server configuration. Before actually using the xmlrpc server proxy, there's check for:

```
if install_server is not None:
```

and `install_server` only get's set if it's configured.

Basically, what I tried to do here, and I guess could/should be expanded elsewhere, is to check if not only we have a install server configured but, check ifs type is 'cobbler'. I guess it complements `install_server_is_configured`, and maybe that check could even be moved into that exact function, such as:

```
def install_server_is_configured(check_type=None):
   ...
   if check_type is not None:
      return previous_url_check() and type_check()
```
if this is the new way to specify the backup snapshot time, we should remove the hour parameter and all references to it in favor of this new parameter.  This parameter should also have docs/comments on it's format.
The source and destination can be renderables, so I don't know how or when to add them to the description.

The only build step I can find which tries to add parameters to the description is ```ShellCommand```.

It doesn't work:

```
Error describing step
        Traceback (most recent call last):
          File "buildbot/master/buildbot/process/build.py", line 393, in startNextStep
            d = defer.maybeDeferred(s.startStep, self.remote)
          File "buildbot-0.8.6p1/lib/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
            result = f(*args, **kw)
          File "buildbot/master/buildbot/process/buildstep.py", line 532, in startStep
            self.step_status.setText(self.describe(False))
          File "buildbot/master/buildbot/steps/shell.py", line 155, in describe
            desc = self._describe(done)
        --- <exception caught here> ---
          File "buildbot/master/buildbot/steps/shell.py", line 204, in _describe
            self._flattenList(tmp, x)
          File "buildbot/master/buildbot/steps/shell.py", line 148, in _flattenList
            for x in commands:
        exceptions.TypeError: iteration over non-sequence
```
@ChrisLundquist, That makes it impossible to detect missing values, which is required for the stateless network protocol and various other places that assume this kind of behavior.
This is just an example in case someone is using jQuery. This is used to demonstrate the issues and how to get around it, but people should be able to implement this the way they prefer. They don't need to use jQuery and they don't need to support IE7 always either.

But if you prefer, I can include this in the Serenade.useJQuery method if you want. But I still find it important to document what should be done so that other developers not using jQuery know how to handle those issues in their preferred framework.
does it make sense?
If it's static it's inline by default afaik.  And I'd rather specify it explicitly.
Should be made localizable: `${%anonymous user}`
Should have been removed from the repository
Stray `'` in these docs; perhaps it should be after `issue`.
You should mitigate this.
You can already gain chrome priviledges by listening to various events:
https://developer.mozilla.org/en/Observer_Notifications#Documents
Like: "chrome-document-global-created".
`system/events` module, like many modules should be considered as unsafe as `require(chrome)`!!
Why `delete` ?
So, I can't actually implemented the warning about "deprecated" in  [bug 725409](https://bugzilla.mozilla.org/show_bug.cgi?id=725409). The problem is, it will log an error for all usage of any deprecated module, not just the one used in the add-on but also the one used in the SDK module: we still use a lot of deprecated module in our modules.
Definitely we don't want to bother the user, neither the AMO reviewer, with this list. However, all deprecated modules should be under deprecated folder, so it should be quite easy spot their usage both for developers and AMO reviewer.

We probably implement that on cfx side soon or later, but as far as I know, there is not plan to do so at the moment. So I will suggest to remove this note from the docs, and maybe add that all deprecated modules are under homonyms folder.
Use the standard ajaxError instead of xhrError.
If the labels are already in the DOM, why not just show the new label instead of replace the contents?
The title will be shown on mouseover, so either remove or wrap in _().
Still not clear.  :)

Are You talking about L#44, `LAST_SESSION_GROUP_NAME_IDENTIFIER: "nightlytt-last-session-group-name",` ?
I wouldn't like to collide `TabView`'s property if we are before Bug 682996. In that case I plan simply use `TabView`'s stuff, and do not save / restore ours.
So, the return value of this should almost never change. Only when new products/components are added to bugzilla. So I wanted to cache as much as possible. I believe this should make any calls to this method in the process return the global if it's been set. Is this true? I guess I want for it to be non-thread-safe if that's what that means. But it is tricky.

Also I may end up removing this. I wrote it for completeness and because I was going to use this to do the autocomplete. But the fileit project already had it setup to autocomplete from the rest api directly on the client, so I didn't mess with it. So it's unused for now.
Why would you want to give 2 arrays if they are merged anyway?
hmm wondering if it makes sense to extract this to a json file outside of user.js and then it just gets loaded in here?
Why did you rename the signal?
this can be DRYer, like doing a before_filter for @page on this methods
The @ is for...?
Like previous notes -- no need to re-flow here.