Decorate folder as dirty if subtree contains untracked files

The new decorator implementation did not decorate folders as dirty if
untracked files existed in the subtree.

Bug: 345099
Change-Id: Ibee5d0dad240e64ad366ab4ed33a008fb1d22c50
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Disable Secure Storage in UI clone tests

Recently UI clone tests was failing because of secure storage modal
dialog asking for secure storage password. This patch disables secure
storage for all UI clone tests

Change-Id: If81f4487b05b46447c5e9a64b1626ea883a9ba65
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Remember previously chosen location in 'Create Patch' wizard

Bug 372217
Change-Id: Ic294d8235f9ce0d97aaab4f752ae44b5776b16a8
Signed-off-by: Dani Megert <Daniel_Megert@ch.ibm.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Fix compilation issues on Galileo platform

Change-Id: I7b72cea6d289b9339ae9f6154d43d9ae390c64d7
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Export all packages from org.eclipse.egit.ui

Change-Id: I4310e467be8f150a6f2c56b38ca3dc8d6d5b46b5
Signed-off-by: Kevin Sawicki <kevin@github.com>
[historyView] Add 'Committed Date' column

Also renames 'Date' column to 'Authored Date'

Bug: 369043
Change-Id: I9c00957a54149e63b3fb7510f62a1ed8c4469c1b
Wait for remote branches to be fetch in UI test

UI Tests on hudson are failing because of blocked UI with
ListRemoteOperation. This patch adds additional timeouts for
fetch remote branches operation now even when fetch operation fails rest
of test cases should pass because UI would be unlocked.

Change-Id: Ib4aa6f92d588c251f8fc7ccd0d44aa1264d788ec
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Add "Revert" action to Commit Editor

Bug: 370436
Change-Id: I3d2c0db48b4119a0dfb45d1a68460e52c4d0ec2e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Add Commit... and Reset... buttons to conflict dialog

  * Move path options to dropdown menu at right of table
  * Removes repository text box
  * Minor wording changes to messages

Change-Id: Ia3e5e4c09b92219102e15b9578780c1095663c03
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Use consistent wording & spacing when prompting for confirmation

Updates several property values to include two newlines between
message and prompt text and standardizes around how the continue
question is presented.

Change-Id: I14d94175bed816f3886711e88d1eb8136e2406ae
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Don't show actions that don't apply when read-only

Quick assist, redo, undo, cut, and paste were being shown
in the context menu even though they are not applicable when
the message are is not editable.

This would cause handler conflicts to be logged when multiple
commit editors were opened.

Bug: 372111
Change-Id: I7d0d2514d13b1b65dd34190de3dbb255e9d03525
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
[repoView] Use UIUtils.isUsable when checking tree from job

Bug: 372435
Change-Id: I397ab21aa63617a28b925d7438e55ec894cd284c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Fix patch creation to file system and workspace

Bug: 372371
Change-Id: Iba21e7431fe12fdff525818902a9ca60f6c4a38c
Signed-off-by: Dani Megert <Daniel_Megert@ch.ibm.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Support Replace With > File in Git Index on repository projects

Use the setAllPaths option on CheckoutCommand when repository
is found in the selection but no valid paths exist.

Bug: 371864
JGit-Dependency: I3e2dd563700999bc063effdd3640499c8ed08136
Change-Id: I71e490d41e95bc0e54708609c0b0e8b16b183fed
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Return an empty selection if the page is null

Calls to getSelection are usually passed the value of getPage
which can be null so guard against this case by return an
empty selection when the given page is null.

Bug: 365756
Change-Id: I41d7f1645769f44f88bf58c4bcf33a3604154548
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Add UI tests for File and Workspace options in Create Patch wizard

Change-Id: I50eeab93de3b4fc44df65e3e8387b6ba44aee33d
Support editing configuration values directly in tree

This following changes were made to the configuration
editor used in the preference pages:

  * Buttons on right side of tree view
  * Configuration values editable directly in tree
  * Single remove button for sections, subsections, and entries
  * Allow adding duplicate key name values in 'New Entry...' dialog

Change-Id: Ia061ceb95e5d68a016200405f019e0fb0c892777
Store pluginId in static field when started

Bug: 370305
Change-Id: Ib81b67720b016843cd533d42d80a2ea944f489de
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Fix the behavior of the Share|Git... dialog when a repo is a symlink

The RepositoryFinder.register(IContainer, File) method is capable of
registering a repository with a path that is not relative to the
containing project, because of the nature of File.getCanonicalFile(). 
For instance, if you are working in /dev/workspace/project and that path
contains a .git symlink which points to /dev/repo/project.git, then the
registered path for that repository will be the latter.  However, code
in RepositoringMapping.getGitDirAbsolutePath() and
ExistingOrNewPage.fillTreeItemWithGitDirectory()
make assumptions about it being relative to the containing project.

This only occurs on Posix platforms because File.getCanonicalFile() does
not have the same behavior on Windows.  Specifically it doesn't
recognize junctions (the Windows equivalent to symbolic links) and
therefore does not try to resolve them.

This patch addresses the problem by removing the use of
File.getCanonicalFile() and replacing it with File.getAbsoluteFile()
which is already there as a fallback if File.getCanonicalFile() throws
an exception.  This will make the behavior of sharing a project the same
on both Windows and Posix platforms.

Bug: 338989
Change-Id: I6901f386b00e8cd5208f22aa93298bca4d750dd3
Signed-off-by: Bradley Austin Davis <bradd@amazon.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
ContextMenuHelper: add method contextMenuItemExists

contextMenuItemExists is introduced to check the existence of a context
menu item. In the past a failing call to clickContextMenu was performed
to do this check. GitRepositoriesViewBranchHandlingTest was adapted to
use the new method.

Change-Id: I639173a347cbc9fd79b7ec1769745d9fc513b81d
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>