labofsahil/github-event-dataset-2012 huggingface dataset:
I've coded most of these modules by modifying existing modules. So explain to me the difference between OptString.new and OptEnum and why you would prefer me to use OptEnum. Also it would be useful if you could point me to the documentation resource that details this for future reference. As a lot of the other modules make use of OptString.new:

atreides:auxiliary nmonkee$ grep OptString.new * -R | wc -l
     766

Can you make it clear why and how I have done this wrong? It would be useful for me to understand this.

On 4 Oct 2012, at 21:44, jlee-r7 <notifications@github.com> wrote:

> In modules/auxiliary/scanner/sap/sap_soap_rfc_dbmcli_sxpg_call_system_command_exec.rb:
> 
> > +			'Description' => %q{
> > +				This module makes use of the SXPG_CALL_SYSTEM Remote Function Call
> > +				(via SOAP) to execute OS commands via DBMCLI command as configured in SM69.
> > +				},
> > +				'References' => [[ 'URL', 'http://labs.mwrinfosecurity.com' ]],
> > +				'Author'	=> [ 'nmonkee' ],
> > +				'License'	=> BSD_LICENSE
> > +			)
> > +		register_options(
> > +			[
> > +				OptString.new('RHOSTS', [true, 'SAP ICM server address', nil]),
> > +				OptString.new('RPORT', [true, 'SAP ICM server port number', nil]),
> > +				OptString.new('CLIENT', [true, 'Client', nil]),
> > +				OptString.new('USER', [true, 'Username', nil]),
> > +				OptString.new('PASS', [true, 'Password', nil]),
> > +				OptString.new('OS', [true, 'Windows/Linux', "Linux"]),
> 
> OptEnum is probably more approrpriate
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

email:    dave@northern-monkee.co.uk
skype:   n-monkee
ichat:     nmonkee.mac.com
web:      www.northern-monkee.co.uk
bus:       www.linkedin.com/in/nmonkee
twitter:   www.twitter.com/nmonkee
we can.
Should SYNCFILE be HTTP_HEADERFILE here?
should we remove old debug lines?
use ```expand_path``` from the Post::File mixin instead.
OK, so maybe you could integrate this function to thresholding.py instead?
Don't know if the empty for loop will slow down general usage when people just use NoCache. If this is not the concern, then I can just let the delete do the no-op.
@mramato?
Good call, this way if we ever add properties to color the code won't need to be udpated.
Probably rename this to `clearDepthStencil`.
Mixed tabs and spaces here?
Keep in mind that `self` is just a hash. This is how we often defined hashes:
```JavaScript
var self = {target: opts.targets, x: some_value, y: some_other_value};
```
Yes, you underestimated the problem. If you look at how `enable` method is defined, you will find the delegation approach doesn't work, unless we copy and paste the `enable` method here, or you find a better way to implement `enable` method.

Why don't you just pull these changes to a local branch on your computer, and experiment you solutions, making it work before presenting to me? You have the "write access" to the code too, not just the "read access". You will learn much more in that way than reading my awkward, sometimes confusing, comments.
鼠标控制也是一种输入控制
Do we have plans to allow configurations/suites/tests or even full harness apps being able to be pulled from the hub? It seems like the spec had something allowing for that in it.
Please explain the difference in scope in the following two use cases which are before and after to the line in question:

Currently:
```
dbConnection.query(query, function(error, rows, fields) {
     if (error) {
        throw error;
      }

      var runId = null;
}
```

versus

What you are suggesting:
```
dbConnection.query(query, function(error, rows, fields) {
     var runId = null;

     if (error) {
        throw error;
      }
}
```

I may indeed be mistaken, but I do not believe there is any difference in the scoping behavior for runId in either use case.
Similarly, for vertical layout, should we be ensuring that all the children in a row have the same maximum height?
this is needed due to a problem with port forwarding with adb.  in short, if you run a pass for android and then try with iOS it will fail  unless adb is stopped.  there may be a way to refactor this in a more generic way though - investigating
I'll be honest, I took a double look at this. I don't know which I would prefer - saying "on/off" in a config, or interpreting true/false statements. It _does_ mean that if there's a setting I want to prevent from the config altogether, I could set it to `nil`, right?
@briancavalier I can't keep track of numbers anymore given all the churn; what are 2.2.2 and 2.2.3?
Should this read "which *moves* logfile to an alternate location..."?
I'm not sure I follow what's happening here.. a) I'm not familiar with an "admin_token" setting. (That doesn't mean it doesn't exist, thought) b) If you're not using Keystone for authentication (i.e. auth_type is not keystone), what's the token for?
Let me give this a shot with `Async.whilst`
то есть ты считаешь что менеджер с кастомным интерфейсом на который ссылается все на свете лучше чем функция с генерик-интерфейсом?
As soon as one sees "enum Not =" it becomes mightily clear it's a value. Case closed.
yes please - same for `if`, `switch` and the like
empty constructor is not needed
k, will adjust under 80 for now
should this be ubuntu-12.04
this looks like an incomplete extraction. don't you just want to call `detect_sbt` since that does the `echo "Play 2.0" && exit 0` and `echo "Scala" && exit 0` internally? It might be better to just have `detect_sbt` return a string with no side effects and then have that echoed out here by the main script.
This is in the master-eap6 branch of the https://github.com/jboss-eap/quickstart repository. Should it be removed?

Is this only for community?
You might want to expose this using a producer to avoid putting this into the class. WDYT?
Met une majuscule à Utilisation
constantize DEFAULT_WAIT_TIME ?
if an empty array for monitoring is ok, you dont need an of this
Same here, findBranchingPoint -> find_branching_point() ?
A tiny issue on this line. Please remove the space before the colon for consistency with the rest of the file.
Still need to put that space - `if ( ! empty($name) ...`
Also, it should be: new SimpleResult(result, this, patientCalculationContext)
Gets a collection of HTTP response headers.
Missing this assert in the new asserts
`Assert.ThrowsException<ArgumentNullException>(() => new WrapAuthenticationHandler(null, "namespace", "user", "password"));`
It is actually not effective, so I removed it. but let me add it back, maybe we should do that in MQ.
Can you put `nil` in backticks?
quick someone register Massachusetts_Insitute_of_Technology
* myTableViewという目的の読めない変数名は避けましょう
Wouldn't it be nicer to have handlerOptions here, like for other controls?
Blank line between the summary line and any additional lines/paragraphs, and another blank line before the final `"""`
Should be connected with "string": `<xsd:union memberTypes="writeResultChecking xsd:string"/>`
The reason here: https://github.com/SpringSource/spring-integration/pull/411/files#r803150
I generally like the ternary operator, but I don't think it adds much value here, and probably a little less readable.
We do have cases where "you can't specify attribute X if you have Y"; are you saying we don't have cases like "you can't specify X if Y = Z" ???

I would think that, if we detect nonsense configuration, it should be fatal.

But, I can live with a WARN, I suppose.
100% agree, but totally forgot about it.
Just put it back and pushed the code.
Is there a reason to hard code the values of KeyStore type and TrustManager algorithm. Is that intentional?
Without this commit, I was able to reproduce the problem by putting a breakpoint in the test case and wait 2 seconds :-)
error check?
`each route` and `by itself`? (not sure)
you should use a `<span>` element here, the `<i>` does not make really any sense... does it ?
the second strlower must be done in the SonataMediaExtension, this is avoid computation at runtime. Can you add unit test too ?

Thanks
I'm cleaning up the comments and removing those that I felt were unnecessary, although some of the ones inside the methods seemed informative enough to keep around.
There are two expected states for the property: The property is defined. Then the value is returned. And it is not defined. Then null is returned. Additionally there is an unexpected state: The property file is not available, even it should be. This state should not happen. If it happens then the build must fail. In such a scenario it makes no sense to bother all method layers arround the core properties with such an checked exception, because it cannot be handled at all. Instead it should be catched at the top level to provide a useful error message. Besides this, the fact that IO is used is an implementation detail that should not be exposed to the callers. What happend is that an illegal state has been detected, for the property access API. This exception then is noted down as reason for the illeal state exception.
Actually I've just realised this list should omit 'X', and 'Y'  as vcf_beagle can't handle haploid areas of the genome yet.
In pdf this overflows the code box. You probably need to put each parameter and its constraints on a new line.

We also should be consistent whether we use _//..._ or just ... to indicate gaps
With Puppet 3, this isn't needed. It's only needed for the other two parameters for fallback behavior.
Heh, sorry, neither are necessary... ;)
Удалил. Не нужно вообще
I wanted to steer away from defining any console routes to give (*false*) sense of security.

On the other hand, there are http routes pre-defined in the skeleton, so I wanted to make it as easy as possible here. 

Any ideas how I could make it less confusing then?
Ergh. I hate to mention this, but we should say iOS 4 and later, since iOS 5 has the same behavior. Leaving it up to author if this nit needs picking.
Switch.when* is trying to be a fold in two parts and is weak for it. I know I said extractors are usually overkill, but Switch.On and Switch.Off are the matchers we want. Reimplement whenOn/whenOff in terms of these if they are truly missed.
I'll make sure to read those comments for the H5BP discussion you mentioned. I'm sure your technique is bad ass so no argument there :)
I would love to deliver those icon assets. Just need to figure out what this icon will look like? Any ideas? 

Would love to hear from others about that.

Thanks P-Man
There is a link for web color, but it's unclear if it relates to hex format. Anyway, at least change it to "hex triplet" as it referenced in wiki link.
Consider what to do if this throws… which it might, Because Android®.
it should be cleaner to have a single template setter. What do you think ? Client code would be more simple.
This can be done on one line :)
compile the Regex earlier (ie. outside the loop), and use the compiled version here. Otherwise, the benefit of the regex compilation is lost, no?
I'd vote to leave it like this, no need to have the added spaces.
consider making constructor private
getUsageInRangeForUser??
Not sure if this needs its own section.  Could be a side note in the Dietary Restrictions section, no?
If you have a function this long, i think it is not doing one thing anymore, and you should split it up into a few smaller functions
My understanding is that this transaction can only collide with itself, and it's doing only 1 operation (1 put), so it will cause ndb to retry only when that put is failing? Am I missing something?
I borrowed this from somebody else and am not sure how to make the conversion from base64 to gif. Save image as I suppose could work (this may also be a "best practice" performance wise to load from base64).