labofsahil/github-event-dataset-2012 huggingface dataset:
Da haste natürlich recht.. bezügl. wichtig: spontan schwer einzuschätzen.. html5 is natürlich inzwischen prinzipiell schon ein Thema. Weiß aber grad nicht ob das z.b. für HTML Validierung bei ner HTML5 page eine Rolle spielen würde, wenn das Textile doctype auf `xhtml` steht.
Denke dein Vorschlag mit seperaten Instanzen wär das sauberste..
May be it's helpful to tell, that the broadcast address 254 is also supported.
You're right. So perhaps it should read:

Minimal implementation: `hashWithSalt`

Alternatively, if your data types is an instance of `Generic`, you can do:

    instance Hashable => Hashable MyType

and an instance will be automatically generated for you.
This may be a bit high for the general use case as well.   Possibly us overriding it to be 100 is the right thing, but maybe 20 is more reasonable in general?  Not sure.  Maybe just leave a comment about it.
again, i think we can get away with `url\(` as the exp
Yes. I doubted that I can override blocks in macros, otherwise I would have introduced an `additional_body` block and put this stuff in there.
Let's use logging.getLogger(__name__)
The only current usage is in slavecommunicator.cc:
```C++
    if(rfc1982LessThan(theirserial, ourserial)) {
      L<<Logger::Error<<"Domain "<<di.zone<<" more recent than master, our serial " << ourserial << " > their serial "<< theirserial << endl;
```

If there are other places we should be using it, please let me know :)
Same again. This must be for debugging. Can you this in debug logger?
Kudos to @nolta for actually reading the manpage. :P
Is the !g.environments.empty? necessary?
Was this intentional?  Do the org pages still work?
Groups[0] will match </script
Move this into another method. And add some comments.
isnot(icon, "Can not found an icon to launch " + url);
Is there a method to reload the configuration options from a file?
sorts here and before returning from make_plans. Does it matter?
I didn't, look at line 112.
Hmm I responded to this earlier today but my comment seems to have disappeared. Pretty sure it was successfully submitted. Anyway here it is again (sorry if you guys are getting notification mail again for the same):

I am with @markstory on this one, `_requirePresent` is the same tense as `_allowEmpty` so my vote goes to `_requirePresent`.  So the vote tally is 2 against 2 right now but @markstory is a native speaker so unless someone else has an opinion I say the scale is tipped in `_requirePresent` 's favor :smile:
That's because `__set` isn't active right now. I'm still thinking about it
Should this be `self.widget().SetValue(int_value)`?
And it's 'messages'. >_<
Its not necessary to cast the output from a method. The method will (or should) return a string.
Not exactly sure what you're getting at, but the original code has `parsed$expr[[i]][[1]]`, i.e., the first language object of the i'th row in the parse result.
Yes, but it will make forcing .py files for %loadpy a little more complicated.
Could/should we make `find_user_code` send also meta information about where it fetched the code ? 
Drop forcing .py files for %loadpy ?
i.e.,  `if not anchor`.
See above comment, importing the existing `IPython.lib.inputhook` solved this.
I tried implementing an nsIObserver and triggering it from _refreshKPDBCallback. I don't think that it is going to work. It seems that the commonDialog blocks the thread that KF.js is running in. I don't get any notifications while the dialog box is open, but if I leave it open a while, I get a bunch of notifications piled up when I close it. Any ideas?
Why this over `function show_all() {` ?
That's my code editor's shortcut comment. I'll just remove those two lines...
You should use `u` on the concatenated strings as well.
if you don't care about `locales`, then either remove it, or fix this.
` $path` and `); ?>` should both go to separate lines
Embedded newlines and/or single quotes in stdout or stderr could make the repr of that exception hard to read.

Speaking of which, are you sure you don't want to implement __str__? __repr__ probably isn't what you want for an exception.
There is well room for compressing here. This form sends 224 bits. At minimum, the w component of the quat should not be sent, but reconstructed at receiving end instead, optimizing to 192 bits. That can be compressed even further, and the preferred way to send orientation is shown in SyncManager::ReplicateRigidBodyChanges, which sends a camera orientation in only 17 bits, and the position in 57 bits, for a total of 74 bits.

The total expected added bandwidth before is (224+3*32)*20=6.4KiBits/second, an optimized form would be (74+3*32)*20=3.4KiBits/second.
A service's background thread, technically.  Remember that all standard service methods are called on the main thread.
Right, optimistically assume it gets merged for the next release and add `@since` accordingly.
According to the doc http://www.phpunit.de/manual/3.6/en/test-doubles.html#test-doubles.stubs.examples.StubTest7.php:
`$this->onConsecutiveCalls(2, 3, 5, 7)` it does not support passing an array to return values from it on each new call. It should be changed to `->will(call_user_func_array(array($this, 'onConsecutiveCalls'), $exists));`.
well, the client class available in HttpKernel is right about its typehint. It only expects an HttpKernelInterface (and Silex can use it for instance).

And no. ``Container::set('profiler', null)`` does not remove the service from the container. It removes the *instance* if it was already created, meaning requesting the service will have to create a new instance.
hmm, indeed, buildForm does not know about the root as it is not added in the parent yet. Only buildView can apply stuff only on the root.
you should add some keywords IMO (I know other components don't have them either but we should add them to allow a better filtering on Packagist)
Work for me :-)
why are you not using the user provider to retrieve the user ?
should be `Gets`. And there is a missing dot at the end.
buttons = plural so let's call this areActionButtonsVisible
yadet in php beshe behtare
vali alan bikhiyal
i really like this line!
I dont want this to be set, I want it to be editable in the config.
Also, for loop is more readable than while.
It is standard practice to have an <instrument>_HELLO_ for instrument-specific tasks such as
data validation.

[Restoring the one comment I forgot to repeat on Nov. 20   when I didn't realise the "Close form" 
equals quit.]
What is this folder for?
{Registry} should be fine
can we default valgrind to being on?
hard code!
Is the "dummy" not used anymore?
Could you please add function header doc also for this new parameter ?
The idea was to allow a root deployment, not the individual JAR's. That said, I do think it would be nice if the EAR and any subdeployments of that EAR could get their own LogContext/profile. Nice catch BTW. I'll get this fixed.
Good catch, I'll also remove the default-providerModule as per discussion on dev mailing list (don't want to show module names in console.)
I'm not entirely sure what the goal of this change is, they seem to have the same effect?

You could rewrite it as this as well, but what's gained:

```reject { @rpmtags[:os] } == "\x01"```
Making button optional here means we need to add more CSS and make a bunch of JS code conditional as well. Requiring button means we could drop a few lines from both dialog JS and CSS files.

Even just replacing `<a>` with `<button>` requires some CSS changes.
Are you sure? I think in both contact_details and contact_form we take whatever comes from the Contacts API. May be I'm missing something. Could you point me to where we localize please? Thanks a lot!
If we change checking for the class to flag, do we need additional function just for returning it?
You're calling 2 times isFbContact maybe you want to store it into an intermediate variable?
Does this work when transitioning between views? (IE we should not animate when switching between views).
We need to check currentContact.tel or currentContact.tel.length will result on a error
What about an early return?
Ugh, my bad, I thought this line would allow to keep the red color, precisely — but you’re right, for CostControl this is defined in the local `bb/style` directory, not in the `shared/style` one.
`reqWifi` -> `wifiReq`
To avoid touble when tracking errors using the debugger it would be good to name the function as the variable, this is:
var updateOrderingUI = function updateOrderingUI() {
For example, you can check 

`(options.filterValue in this.contactData)` // we have data in cache
if we remove the "recommend" option, I think it becomes gray instead of blue.  We could also maybe add some verbiage.  For example:  "Click on the next button in the header to try automatic configuration, or:"

@caseyyee?
nit: same as above
No, this call waits 100ms and then vibrates for 100ms.  (At least that what the docs say it does).  The idea is that it vibrates once when the screenshot command is received and then again when the screenshot has been saved.  The pause is to make sure that the two vibrations are distinguishable.  So if you've successfully captured a screenshot, you'll feel two short vibrations.
This is week l10n... if `timeFormat` doesn't contain `AM` or `PM` this will make `textContent` display string `null`.

Please do `(time.match(/AM|PM/i) || []).join('')` so we will get empty string if there is no matching substring.

(Something may apply to homescreen -- you can fix that in this bug or another bug)
Make 1k lower boundary (since to low value will not work if header does not fit).
I would just take the request or the HttpContext.  The body may not be url encoded form data for some parser.
s/するのに/するために/
s/考える始める/考える/
I´ll insert spaces, but add brackets to show that those to factors belong together!
`minimumAngle` please :-)
Add test for optional hostHeader config
A String message that will be displayed as the reason why we couldn't start their application.
I'd say that the DB has to be flavour independent. Instead of asking the DB to shutdown an image (which is occi specific), export as a public function getImageNameFromInstance( vmId ) and then stop it outside the DB. That way we minimize the dependencies in the DB. What do you say?
Looks like it's fixed, you can remove that.

Can you post a thread at all? I keep getting mysql error.
I moved all the javascript for the buttons out of the body and into the head in #23.
Should also be tests for the map and set
Right, this is the failure case that I think will be rarest, since the master must not have checked in for several times its usual period for this to occur.  And even in this case, the master will re-activate itself at its next interval.   In fact, the result here will look a lot like the case where the master comes back *after* it is marked inactive: "flapping" of a master's status, indicating that it is massively overloaded.

There's no perfect way to solve this - you have two processes updating the same value via a delayed process that may not even detect collisions.  So I think failing this way is best
so pretty! but not python-2.4
Should this be above the ref to 'Configuring-Schedulers'
> +    re_change = re.compile(".* refs/changes/\d\d/(\d+)/(\d+) -> FETCH_HEAD$")

> Nitpick: Probably should make this a raw string .. turns out '\d' doesnt
have a meaning so it works, but still might be a good idea.
Sorry Jared, I dont get your point.

Pierre
prob should update this line of text too
Oh no that is something I started doing and then went another direction. Will add proper test and fix this. Good catch.
I don't understand why you're saying this is the description of composer update.
This needs a bit of "error handling": what if ".file" doesn't actually contain what we need?

Also, please try to group variable declarations in 1 var statement.
Unfortunately this is the only way that we've found not to duplicate the contents of zanata.xml. We can move the zanata.xml file but the use of ${session.executionRootDirectory} is necessary so that when invoked from the root directory, all modules know where to find the single configuration file.
This also has to do with the fact that the project is configured as a single project in zanata, which means the push/pull commands should be ran from the top level. Individual modules can still be pushed/pulled, but it needs to happen from the root module and using the -pl option.
I didn't find where it was used. Let's remove it
It was specific to this test, the other tests wanted to work as they were. Drove me crazy for hours.
please don't send PR unless you properly tested it in live application.
Why the `<br>` here? That seems odd and unnecessary.
Once you create your `README.md` file, this answer to the question "What is Ribcage?" should be there as well.
Wanna subbmit a follow-up bug for this and put a link here, to make sure we do that at some point ?
>After being able to understand the whole defer function, and understand the main usage of these two methods, I think resolvedPromise and rejectedPromise would make more sense.
You are clearly returning promises in both cases, but it sounds really weird to use promise for such special case (immediatly resolved promises) so your initial proposal make sense, but it becomes clear when you:
>
>    use promise word for both functions,
    add a second term to distinguish them,
    use past participle that makes it clear what they really are.
>
>Current names are okish, but they are hard to understand in defer.

Sorry I don't understand this comment do you imply that `resolvedPromise` & `rejectedPromise` would be a better names than `rejection`, `resolution` ? If so I don't agree as those functions do not return promises they return promise like (non-standard) compliant promises mainly for express `resolution` or `rejection` of the promise they were created for.
Is that trailing `,` after `window` necessary ?
Would be nice if we could stick to same convention either "xpi-path" or "installXpi". Also I think it could be just `path` here as `install-xpi` makes it quite obvious.
@jedp - wahahaha!  I appreciate the thought here.
IE and Chrome suffer from an odd behavior where if you .get() to the same URL that you are currently visiting, the browsers do not refresh the page as expected. A .refresh() instead of a .get() fixes the behavior.
thank you for using newlines.  I like newlines.
I can certainly try that later today (no access to the App Engine + Cloud SQL setup at the moment).
@vrthra just so I don't forget, we do want to validate the path, but only if `ensure != :absent`
Sorry, I forgot that the response wasn't a single class that you could easily just subclass. In that case the delegation makes sense.

I like your idea of adding callback hooks to the Connection class. I'm not sure what that would look like at the moment, but it smacks me as a good direction to take this.
Uncommon constructor comment, remove.
Please revert the changes to the method positions -- unnecessary, and cluttering the true change, which is the readability of the post codes.
I don't touch this :/
I haven't worked out exactly why, but I feel a little uneasy about the fact that we don't have something that will roll back the changes in the case of an unhandled exception.
Sorry I think you've misunderstood my comment. The change looks fantastic. I was merely commenting that you've making a call to obtain the auth adapter before a block where the function may return (and the auth adapter is not required within the block) which means you've made a call to obtain a resource that is not required. I agree that the majority of the change you've made is a relevant fix. Just a very slight optimisation to remove a potentially unneeded call.
calling this class TodoElement when it is not an element seems confusing.
Consider a name like
TodoView
Can you add a link to the issue? https://github.com/kriskowal/es5-shim/issues/122
new todomvc.model.proxy.TodoProxy()
Currently I do not have a way to navigate to the inventory page from the main page.  So i can not currently test this.
lol sorry yeh
En kyllä ymmärrä miks tässä on tälleen tehty.
They're called in `ORM\Configuration`
Missing empty line before this `if`
@lstrojny exactly, because there is no way to hook into the access to a public property. If you want to use ``$entity->foo`` in your code because you like property access, you can still do it by implementing ``__get`` and ``__set``, which don't break it as these method can be overwritten to load the proxy.

@guilhermeblanco it is mainly to avoid people reading the tests and thinking they can use public in their own code too (and then complaining about the broken stuff). I know the doc explicitly warns against public properties, but I also know that many devs don't read the doc.
Duly complaining! Hmmm, at this point I could just go and add a secondary commit before merging on this branch. Want to play with that, or?
I disagree here since these can be very handy :)
It's just a small feature that is broken with the new easyblock class (to be named easyconfig). It actually works in develop.
I tried both "subsilver2" and "phpbb/subsilver2" but neither would let me install the style in the ACP. Leaving this as an empty string did work.

Also, in michael's implementation, there was a template_bitfield key, which was commented out. JSON does not allow comments of any sort (not only did I see that on StackOverflow, but also quite simply I got an error when there was a comment and did not get an error when there was not a comment). We will need to add the bit about template_bitfield to the documentation.
Too much ws
Yeh it will be randomly generated i'll remove it from the passed in params just now
This is OK for now taking into account the small size of this project but in the long term the view source is in the header so would be best put in a header class (region).

Also this method is inconsistent with the rest of the project in that it returns the page object that the link goes to. Other links (eg L20) don't do this.
We can't depend on unreleased code.
I reworded the message to be more meaningful (I hope).
I agree with your notion of ugly. I have come to expect that from Java code.
Oh. I see what you mean now. I'll look at moving that function and users can call it on returned ``Trade`` objects if needed.
Yep, I was able to login to my installation with it lowercase.

This is a really nice addition to Wordpress I must say!
Can we change this back to just any instance-store image as it was before?
Can't the logic of:
```
$mainEntry = false;
foreach ( $nameList as $nameEntry )
{
    $text     = $nameEntry['text'];
    $language = $nameEntry['language'];
    if ( $language->attribute( 'id' ) == $languageID )
    {
        $mainEntry = $nameEntry;
    }
    else
    {
        $result = eZURLAliasML::storePath(
            $text, 'eznode:' . $nodeID, $language, false,
            false, $parentElementID, $cleanup
        );
        if ( $result['status'] === true )
            $changeCount++;
    }
}
if ( $mainEntry !== false )
{
    $result = eZURLAliasML::storePath(
        $mainEntry['text'], 'eznode:' . $nodeID, $mainEntry['language'],
        false, true, $parentElementID, $cleanup
    );
    if ( $result['status'] === true )
        $changeCount++;
}
```
be simplified to:
```
foreach ( $nameList as $nameEntry )
{
    $language = $nameEntry['language'];
    $result = eZURLAliasML::storePath(
        $nameEntry['text'], 'eznode:' . $nodeID, $language, false,
        $language->attribute( 'id' ) == $languageID, $parentElementID, $cleanup
    );
    if ( $result['status'] === true )
        $changeCount++;
}
```
хакер
Aren't the name and date optional?  Should these be f.get('name', None)?
When I read this file, it leaves me wondering if trying to protect a function that still has a REQUEST parameter will now break.  That is probably not the case.  Maybe add a comment like this:

Earlier versions required a ```REQUEST``` parameter, but since version 2.1 this is not the case anymore. Of course a method that has such a parameter can still be protected just like any other method.  This parameter is simply not used by the protector.
If possible, we should avoid making the ContentAPI expose a raw storage proxy. There are no permission controls or anything, which is not something you should would expect from a high-level API. If we need a re-usable file-storage API, I'd recommend unbinding it directly from the ContentAPI so we don't mix "unsafe" methods with safe ones.
What should the Type of the callback.err be if I use `null` to indicate there was no error?
`null|Object`, `Object`, ... ?
Having changed the merging of different configs this function is no longer needed and I removed it.
Please list the accepted values in this JSDoc.
Order is wrong
This was Iulian who fixed it this way. I admit it's the first time I see this code :)
Instead of the raw string type name, could you use  ``classOf[com.sun.jdi.SocketAttach].getName`` ?
CH is comprised of three parts. The bukkit plugin code, the central core code, and the Minecraft functionality. We've tried to abstract these parts so that if we wanted to use this with a different server implementation (Tekkit, etc), it'd be easier to move the code across. Same goes for using CH's language on another platform that isn't tied to Minecraft. But if you are directly importing from bukkit's API, that means more work if we change/add server implimentations. Thus, the abstraction.
This class isn't as necessary to abstract, as WorldEdit and WorldGuard are bukkit only, in terms of server plugins, but the idea should still hold true.
I moved the footer license line further down and removed a few classes before IDs but not all of them. Those that are left are either necessary or are planned to be removed with the frontend improvements anyway.
OK about the nit.
Yes I do use spaces instead of tabs.
Hmm... not really liking either way.
Как я уже неоднократно говорил - я учу Objective C с нуля и у меня есть только те знания, которые я узнал из лекций на этом сайте и из того, что я нагуглил. Про существовании метода MIN я не знал. 
Спасибо, на будущее буду знать.
согласен с @MarinaKaterinich, это у вас уже не рандом
если честно, то я просто нихрена не понял =) вот как я это вижу:
создается массив из 4 значений
потом очищается
потом опять добавляются 4 значения
затем удаляется значение из интервала от 1 до 100 (если DNA 100) при том, что массив всего из 4 элементов
и наконец элемент массива DNA заменяется с рандомным символом из малого массива
опять же arc4random() %3 
но главное, что условия задачи не выполнены: старый символ и новый могут совпасть и мутации не произойдет
хм... Сам первый раз заметил, наверно [Dolphin] - Диспетчер файлов лина
Ok, If it's not desired to change this for students, but only for admins I suggest to use conditionals in the controller using find() params. Moreover it would be highly desired to assert this in  a functional test. I.e. assignments sorted by x for admins, and sorted by y for students. You may find the assigns hash available in functional tests useful for this.
erm... what?
The platform is in english
Sorry, I don't quite understand what you mean.
`alias_method :color?, :colour?` would be better IMO (cf. http://blog.bigbinary.com/2012/01/08/alias-vs-alias-method.html)
- git read-only protocol (`git://github.com/libgit2/TestGitRepository.git`) *should* work. You might be willing to give it a try :wink2:
 - ssh (`git@github.com:libgit2/TestGitRepository`) is indeed not implemented yet
... feel the conflict ;-)

On 26.12.2012, at 13:36, Christian Brodbeck <notifications@github.com> wrote:

> In doc/source/python_reference.rst:
> 
> > @@ -198,11 +150,20 @@ Functions reference
> >  
> >     compute_proj_ecg
> >     compute_proj_eog
> > -   find_eog_events
> > +
> > +Detect Artifacts and ICA:
> Hm, this intermediate heading might make it ambiguous what module the following functions are from
> 
> —
> Reply to this email directly or view it on GitHub.
>
Good idea, I've fixed this.
So this produces a PKCS1 format public key. Our code supports this, but our erchef code generates public keys in SPKI format. The SPKI format is the same that is produced by default by the openssl command line tool:

    openssl genrsa -out mykey.pem 2048
    openssl rsa -in mykey.pem -pubout

    -----BEGIN PUBLIC KEY-----
    MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAzPzQ6dQMmw[snip]

Maybe we should just shell out to `openssl`?
Isn’t it possible to pull the `tupled` method into `Variant[M[_]]`?
Why are you creating a closure here?
Shouldn't we keep this for clarity? Not everyone will take the time to read PSR-2...
These are probably not needed
the note need to be indented. Otherwise, you will have an empty note and a new paragraph after it
This should be

    // ... perform some action, such as saving the data to the database
嗯，是这个意思。:-)
I think you should expand on this and say something like "Run the following migration *before* switching password strategies, or it'll break".
Why do you need this? The parameters are not used anywhere after the method returns.
И здесь не по ссылке? И дальше, нутыпонел.
Pero si las notas pueden ser de entrevistas, y las notas se pueden modificar, ¿no califica como hecho?
Un pequeño espacio de sobra.
I've made these changes: it's not much help. Running `countlines(filename)` typically takes less than 1/1000 of the total time to do a file read.
Could we use this?
http://commons.apache.org/io/api-1.2/org/apache/commons/io/IOUtils.html#closeQuietly(java.io.InputStream)
Agreed, it's perpetually confusing.
0 task has signal method

use CONST task_abstract::SIGNAL_SCHEDULER_DIED instead of string 'SIGNAL_SCHEDULER_DIED'
If you escape `manifest_path`, then the single quotes are actually incorrect. Let's escape things as they are being interpolated to avoid confusion.
> One note: I had copied the format and conventions exactly from CGPathAddLines, in the hopes that it would be up to the project's standard.

I know, no harm. In every other respect the code was perfectly formatted. It is common practice in Cappuccino to declare i outside of the for loop, but **only** if it is part of a var block with several variables.
functionally it works :) tested it first. I had some doubts with these disconnected waypoints, but could not find issues right now. Nevertheless should the code reflect the boundary conditions (even if it did not do that before :) )
As we discussed earlier, if zoom is presented, fit_every should not affect anything.
Make it so, Number Paul
Again using an AtomicBoolean here would make the test more safe when executed in such a highly concurrent env as our test suite is( in which one cannot rely on Thread.sleep...
Sorry, I must have added it to the commit by mistake when I added all these tests. It's not used, it was just the config of a user who was complaining about HotRod performance a long time ago...
Galder, Manik, I don't think `usingAsyncStore` can change at runtime. If it did, it wouldn't be safe to cache its value at all.
I tried to do that but git won't detect it. It won't stage the file for commit.
JsMinFilter is correct, JSMinFilter.php is incorrect, should be: JsMinFilter.php.
How do I force that change?
the link to google code in the source code asks me to go to https://github.com/rgrove/jsmin-php/ instead but the code seems to be a bit different
Still need dot syntax here for `spec.UTF8String`.
Objective-C objects should never be qualified `const`. Objects are made read-only through their interfaces, not the compiler.
Just checked np.histogram2d doc it does the right thing and divide by bin area.
I think the equation should probably be on one line. Would you mind also wrapping it such that ```... the form of ``lowerBound < upperBound`` ``` so that it would get rendered as a code snippet.
I don't follow - based on the comment above, false implies that the emulator is not required to run this test. Why would that imply disabling of the test on the emulator?
This is out of date... My pull request has the better fix (because this breaks)
I think these were actually right before...
Should change this name too.
this is a general advice. Make sure about your names and that you know what
you're doing

On Tue, Aug 7, 2012 at 4:34 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/TCP/TCPProtocol.cs:
>
> > +        }
> > +        public byte[] getMessage() {
> > +            return message;
> > +        }
> > +        public bool Compaire(Object protocol)
> > +        {
> > +            if (protocol is TCPProtocol)
> > +            {
> > +                TCPProtocol tcp = (TCPProtocol)protocol;
> > +                return compaireObject(tcp.getMessage(), message);
> > +            }
> > +            return false;
> > +        }
> > +        private Boolean compaireObject(Byte[] array1, Byte[] array2)
> > +        {
> > +            if (array1 == null || array2 == null)
>
> It comaires two byte array if they are equal. The name should be diffrent.
> I will rewrite this method
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1321836>.
>
>
Good point. The way things are now, it makes sense to check that. I was envisioning that this would also work e.g. for UTFGrid layers, but then we would need a better Tile API for intercepting and replacing requests. I'm going to add a check for ```Tile.Image```
Any chance of decorating this <img> node with an anchor with onclick so it becomes keyboard selectable/accessible? eg.

```
<a href="#featureId" class="markerLink" id="featureId" onclick="click(featureId)">
      <img id=featureId style="..." src="..." ...>
</a>
```

or maybe use an anchor or button with a background image
I was unsure about the spacing of the next concatenation. So it should look like this:
<code>
$create_query = implode(
    $crlf,
    array_slice($sql_lines, 0, $i)
)
. $crlf
. implode (
    $crlf,
    array_slice($sql_lines, $j, $sql_count - 1)
)    
</code>
Added issue #104 for this todo.
addapter for the French translation
Security hole
That loop will run forever if for some (valid or erroreous) reason, the user action returned a different HTML structure without the element to focus. Needs to be solved differently (see above).
Hmm not future proof, what do you think if we use this.parents(class) instead?
I agree with you about the second checkpoint not needing a force, but it won't hurt anything, so I'm going to leave it alone.
Why is the server doing cert validation? Confused.
This operation is likely not understood atm resulting in the system asking for a  ``@return`` annotation.
Should the type for parameter ``$item`` not be "string" instead of "type"?
@jnunemaker haha good point :+1:
Would you add the `u` modifier to the regex so that it becomes UTF-8 safe (just in case) and I'll merge this.
Actually ...
If you look at the test at line 364 of the test changes you will see that in truncateComplex if there is only html, such as an image tag, we will return that even with a length of 1 whereas in truncate normal you should get either nothing in the mode that does not allow html which should then be turned to ...  or ... in the mode that does allow html because the $length doesn't give you room to close the tag (you really must have at least 5 characters to do something with valid html and that's pushing it since I don't know that there is a one letter self closing tag  <? /> ).  So what was happening was when truncate was given this scenario it was doing the truncation (at line 55/60) and then seeing there was no > in the truncated string so it was returning the < as a character. I'm proposing here that we make the assumption the < in the first position of a 1 character string is an opening tag and handle it as such.

I was really not intending to do a rewrite of truncate itself but I found there are some issues with short lengths. Also we're going to have to look at its assumptions again in light of some of the new tags from html5.
Store has quite a few ``return false`` statements so I'm not sure we can chain it.
should these lines be removed?
Resolved with df2cbc9.
You use the word "evaluaciones" in most other entries that refer to ratings.
Yes, both :)
Actually, now recalling, maybe I was attempting to include the line number in case surrounding context made the original annotation moot because mitigations were put in around it!  I think that actually makes more sense (sorry, it's been a while!)

Either way, if it's added in `#to_hash` maybe we should just call it instead of `#clean_annotation`?
Usar aspas simples e definir como string unicode, exemplo: 

    error_message = u'Erro, verifique junto a sua operadora de cartão'
easy fix ;) if you do that, then you also need to remove that relevant code.

note that it was a needed for windows, so if we remove that bit, we need an alternative way for the proxy to ping on windows (i'm guessing executing ping would work, just need to figure out the arg list).
You should add that if it is not created, then you should update the timestamp!
As I said I had really bad experiences with model forms, so I did everything from scratch. Will try to fix it.
Here is a slight question if `column_ordering[panel]` really exists. :-) You can add one if sentence around, to just skip the panel if `panel is not in column_ordering`.
I couldn't found any similar problem on web :O, I really need help.
Have tried 

models.State(
        model_name="test"
    ).save()
Hm, so you are saying that `google_profile_data` is a dict and not an object? OK. Then we have to fix this all around. ;-)
Not really true, only from where *django-pushserver passthrough callbacks* are accessible.

Also this setting configures other things, so comment should reflect that. Like *This list also configures IPs from which django-pushserver passthrough callbacks are allowed.*
Just `post`, not `post_object`.
You mean math/mathcore/src/TMath.cxx? There is a link at the top of the source file if you want to see it. I currently don't know if this is the wrong way to embed an excerpt of LGPL'd code. Do you?
Can this explicitly say MDP_STATUS_RAN since we're defining it?
Any reason for removing the print function?
Can we change this to "Oops! The page you requested cannot be found."?
we need x out of the cycle.
It looks like, down in the old RtpSocket-land, this used to be notifyCallDisconnected().  Now it's notifyClientFailure().  Was that an intentional change?
Well, we're making these up here, so you can name them however you want. I would probably call them something like LEXICAL_VARIANTS, DEPENDENCY_PARSES, SEMANTIC_ROLES.
Please remove the curly braces around the cases.
You are missing `foreach` and `switch`.
you're right, I messed up with the commit, it's late I should have gone to bed instead ;-)
don't feel strongly.
Spelling fix: should be rowTimeSeries (english is weird).
Не используется нигде. 
/dev/null — файл, ведущий в никуда. Например, чтобы перенаправить в него вывод.
What other actions are available? Perhaps a docstring here?
Same issue with hard coded values and duplication.
Put this line at the end of initialization code.
Line up with the string above.
Would also drop parens here.
I'm working on a major refactor of the config, but for now we already have `cfg->cache_dir`.
What's the point of adding this when the js file is going to be cached anyways? Also, you can get context url via the base tag($('base').attr('href')) and the actual url via window.location.
``` erb
Hello <%= a.call %>!
```

?
`Struct.new` returns a new class so why not to treat it like a class and name it smth like `UnicodeDataAttrs` or `CodePoint`, as @camertron suggested? It's better to avoid class variable in Ruby as they have some ugly side effects when it comes to inheritance and here you have all rights to define a full-fledged constant. Then you can use it in the spec below instead of `Struct`.

And maybe it'd be nice to wrap this line. We're not sitting at 80 characters terminals any longer, but smth close to 300 characters is still hard to grasp in one line.
it's is a convenience method that lets you perform scoped jquery calls within the context of the view's element.

so you get `this.$(blerg) == $(blerg ,this.el)`
I wonder if the concept of datastore property should really be server-side only?  There is a very high chance things like `name_` will never actually be exposed to the client-side, they are really just query "shims."  In the case of name, for example, we would probably always query against `name_` but always expose `name` to the client.
Exact same issue with failure to do "ls -l" and see that it was a symbolic link rather than a copy of a file.  Sigh.

On a more minor note, I think that it belongs in devutils/ not devutils/doxygen_tutorial -- i.e., the doxygen guide goes in devutils and if someone wants a specific example they look at the tutorial subdirectory.
I can't think of an., and am happy to move this function to being just that - a bare function.  Are there any objections to this? (specifically thinking @rmandelb , @TallJimbo )
In such cases I just checkout master, copy the original to somewhere else (e.g. ~/Desktop/)and then copy it back in!  Probably terribly poor git practice some way or another, but it's quick and works!
Should we also have a check that they aren't all None?  Or are we comfortable with having a default size for everything?  It seems to me that it makes more sense to require the user to input some kind of size.  Leaving it out is much more likely to be an error than an intentional invocation of the default, it seems to me.
possibly write some function comment here saying its purpose.  I'm guilty of omission on that too probably.
Hello Rene,
I don't think the specified property is available on every browser. Which means this code will not work on a browser where setAttributeNS and specified aren't available. Better to check for typeof element.attributes[i].specified != "undefined" && element.attributes[i].specified.
It's an accessor class. Allows me to access protected methods without making them internal.
We have a race condition here. This search for a display name is not inside of a transaction. A transaction is later started (in _applyWhoAmI), but that allows two users to be assigned the same display name.

I think the determination of whether to generate a new display name may need to move into _applyWhoAmI, and call this function from there. Please take a look at how to best accomplish this.
Fixed.

NoVersion.equals(getVersion()) is null safe.
Ouais, c'est pour ca que j'ai rajoute "otherwise excellent" ! Mais vraiment, c'est mal.
Ok now i understand what is const function in c++. It is a pragma for the compiler.
This was only changed for one release then reverted back to 1.396...  should it be 1.396?
이 커밋은 반영하지 않을께요.
Gah, I missed this one - I did it at all the other ones though, I think - please check! I will fix this one too.
On Thu, 28 Jun 2012, Hannes Magnusson wrote:

> > +  object(MongoId)#%d (1) {
> > +    ["$id"]=>
> > +    string(24) "%s"
> > +  }
> > +  [0]=>
> > +  string(3) "foo"
> > +  [1]=>
> > +  string(3) "bar"
> > +  [2]=>
> > +  string(3) "baz"
> > +}
> > +array(2) {
> > +  ["_id"]=>
> > +  object(MongoId)#%d (1) {
> > +    ["$id"]=>
> > +    string(24) "%s"
> 
> That doesn't make a whole lot of sense.. a fixed length string, but not defined text?

It makes sense for a generated object ID, it's just that it's always 24 
chars long, but always different.

cheers,
Derick
`user.id.present?` would probably be better in this case
1. see previous comment about test/unit
2. haven't you already done this in test/helper.rb?
This was changed in WP´-71 which was also in pulled state.
four spaces indent
coding standards fixed
We could use 2 css classes for this (like .prerender and .oncall).

But do you think it will be more readable?
When using it, you name the variable TemplateManager. Why naming the class Template ? It does not represent a template.
Revert this section.  I rewrote it to work better >:(
I tried writing this TDD style but it was tough and I gave up and did it the old way.  That being said I spent 4 hours or so trying to figure out why it was the worst player ever and had no idea how to track down the bug.  It was a minus sign that should have been a plus. 

 I think I'm getting more comfortable with tests now though.  I'm actually doing what looks to me like real TDD in the blackjack plugin and the LPMC Casino api plugin.  However I'm still not sure how to test this.  By it's nature it's so open ended I don't really know what to test and how.  Do I test that it chooses the right move?  I don't even know what the right move is.  I can test that the board scoring is working but there are thousands of possible boards and I don't really know what boards to test that would provide enough coverage. (those aren't really specific questions I'm asking. They're just illustrative examples of the kind of issues I'm having with the concept of testing)

At the very least we can provide tests for some of the smaller helper methods though.
Im not a fan of too many parentheses but in case of `x && y || z` an added pair of parens makes sense.
Well, when you cast vanish you should gain BOTH stealth AND vanish buffs, there is no "reaplly stealth aura on vanish expiration"
I think the signature for this method would be clearer and more rubyesque if instead of an array of arrays, you took a hash, followed by the providers list. This would change the call in this example to:

```
print_table( {:name =>"Name",
                     :provider_type => "Provider Type",
                     :deltacloud_provider => "Deltacloud Provider",
                     :url => "Deltacloud url"},
                     providers )
```
а что у тебя в этом месте?
Если в finally всё закрывается - зачем это делать в catch?
interesting, this is following the Java Service Bus implementation. I think it is a good question, if we shouldn't do logging, we might want to remove that from service bus as well.
Hmm, not sure but other JDG quickstarts use java.util.logging as well so I would personally stick with that.
this should be in the header section  in the base file
blank line contains whitespace, please remove it
oups I will add it  :D
I think this should be moved to the sparse RP class rather than left in the base class. The fit method of the sparse RP class could call the `_check_denstiy` method and then call `fit` on super.
Right. Didn't check coverage yet. Will do!
I would lose the ``[]``, I guess. Personal taste, though.
Though the description is not so clear to me. The explanation should say what the algorithm does, provided it gets this option, not what the option should look like imho. So this should say something like "use the specified function to compute the affinity matrix".
Some blank lines here, is that normal?
'l2' instead of 'l1'. I will rephrase.
Why do you need a `np.int32` instead of the default?
Could you include the comment here that you deleted above?  Even I get confused sometimes as to what I'm computing =P.
If no context is set, then we'll end up with "arg1 arg2 arg - " (note the trailing ` - `). I'd prefer to not append these 3 characters in the first place, or trim them off after invoking `sprintf()`.
WDYT about an 

else { 
    ServerLogger.AS_ROOT_LOGGER.logNoManagementConsole();
}

Also, AIUI the request is for the admin-console URL, not the HTTP interface. We redirect to root URL so it's ok skipping the context path, but we probably shouldn't log the URL if the console is configured as disabled.
I put it there just because I thought it would be confusing to write it like this:
    persistance:
        listener:
            insert: true
            update: true
            delete: true
            is_indexable_callback: "isPublic"
Add TODO here, for the bind strings
Delete all commented lines!
And this one too!
how about [^a-zA-Z_] infront so i does not match xxx__(
Not so sure about the name of this struct/member.  I would have gone for something like MsgHeader/hdr.  It's Richard's domain though.
now ignoring the next match, instead of changing all other cases.
In fact, which should never == slaves, since that was tested above.
This is actually including the some source files from the Language Reference
Ah yes forgot that one, I'll change.
It's not that simple unfortunately - there's no OS selected, and if you read the text above it's supposed to automatically pick the crashiest OS, so this part should be fixed (I need to look at how the PHP app does it)
Why not just `currentversions = []` ? What am I not seeing?!
We are changing the contents of the data dictionary if it contains the key "image" or the key "filmstrip_image". We should probably do this to a copy or it could get messy on the client side.
So then it has to be a variable node because "arguments" are arrays with multiple dimensions.
No it won't - good catch!

On Mon, Mar 26, 2012 at 11:13 AM, Patrick Hayes <
reply@reply.github.com
> wrote:

> > +                     final String text = jo.getString("text");
> > +
> > +                     final Intent intent = new
> Intent(android.content.Intent.ACTION_SEND);
> > +                     intent.setType("text/plain");
> > +
> intent.putExtra(android.content.Intent.EXTRA_SUBJECT, subject);
> > +                     intent.putExtra(android.content.Intent.EXTRA_TEXT,
> text);
> > +
> > +                     this.ctx.runOnUiThread(new Runnable()
> > +                     {
> > +                             public void run()
> > +                             {
> > +                                     final ResolveInfo[]
> eligibleActivities = getEligibleActivities(intent);
> > +                                     final CharSequence[] names =
> getEligibleNames(eligibleActivities);
> > +
> > +                                     AlertDialog.Builder builder = new
> AlertDialog.Builder(ctx);
> > +                                     builder.setTitle("Share page
> using:");
>
> Will this be localizable?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wikimedia/WiktionaryMobile/pull/20/files#r604685
>
I don't have preference on chrome we can add things as necessary. What's use case for data ? It feels bit strange to readURI that is data uri.
btw, does this test pass ? there is a ``mkdir($this->vendorDir);`` in ``setUp``
I want the focus to be on the released version, not the git version (I should investigate what's needed to get `pip install easy_thumbnails==dev ` to use the github source). Not even sure this needs to be in the readme.

In fact, I'd prefer to keep readme as a very short usage summary with references to the full docs where needed
No, you don't have to revert it. I wonder what is the best practice for maintaining different coding styles in one project. In company I work, almost every one formats code(delphi) in different way: 
foo( string s ); vs foo(string s);
string s:= 'aaa'; vs string s := 'aaa'; //space befor colon
if condition then
  one_line_statement;
vs
if condition then
begin
  one_line_statment;
end;
We don't change code style each other. But we have convention for naming variables and class members which everyone has to use.
I prefer to avoid refactorings that don't increase code quality especially if refactored code wasn't written by me.
> IGitModule vs GitModule

IGitModule is supposed to be used in plugins, but there is no contraindications to use it in other places.
Myös `(map :title books)` tekisi saman
I think it would be even better to move those files in `lib` folder,
and add fake require statement in order to ensure them being shipped:
```
/*
require("subprocess_worker_win.js");
require("subprocess_worker_unix.js");
*/
const URL_PREFIX = module.uri.replace(/subprocess\.js/, "");
```

But I can do it in a followup if you don't have time.