labofsahil/github-event-dataset-2012 huggingface dataset:
`req` has its own line, let's give him his own `var` :)
I usually like early return but you're duplicating those 6 lines of code between here and the end of the function. Doing a if/else in this case will prevent that.
is commented, are we planning to use this?
Can you save the value of document.getElemenbtById in one place in order to have one place to change only if the id of one of the component is changed at some point?
Yes, it does regress it... I've updated the code in order to use `hidden` html attribute instead of `visible` class and CSS.
why don't we rename to clearList()
nit: store this.target in a target variable above and use that for all occurences of it and remove |self|.
If this is something that needs to be preffed on by default in b2g, http://mxr.mozilla.org/mozilla-central/source/b2g/app/b2g.js is probably a better place for it :)
I’ve talked about this with @gregorwagner, I think we should rather use the `name` property as the default `givenName` value when importing SIM contacts, instead of a default *displayed* value.
Don't speak loud.
If you intended for the MNotificationManagerProxy to be deleted automatically, QPointer won't do it. It's only relevant if something else may delete the instance, and this needs needs clearing.
What if no repository exists?
It has to be done in this way due to how content is read and/or written. We only know that the content has completely been sent when the stream is closed.
Did you mean to leave the reference to `Flay.load_plugins` here?
crazy... just checked out directly from your master into tmp and all tests still pass over here... when you get a chance can you log out what the multipart buffer looks like:

```javascript
RepSocket.prototype.onmessage = function(sock){
  var self = this;
  return function (msg, multipart){
    if (!multipart) return debug('rep expects multipart');
    var envelopes = [];

    console.log('raw msg:', msg);

    for (var i = 0; i < msg.length; ++i) {
      if ('\u0000' === String(msg[i])) {
        envelopes = msg.splice(0, ++i);
      }
    }

    console.log('app msg:', msg);

    self.emit.apply(self, ['message'].concat(msg, reply));

    function reply(){
      var args = [].slice.call(arguments);
      sock.write(self.pack(envelopes.concat(args)));
    }
  };
};
```

I correctly get:

```shell
raw msg: [ '\u0000', { cmd: 'hello' } ]
app msg: [ { cmd: 'hello' } ]
```
Callback style seemed to fit in pretty well, especially since we have the orignal socket in scope. Strays from how zmq does req/rep in a blocking mannor, but that doesn't really make sense in node...
This type of comment is not helpful. What is this the maximum waiting time for? Connecting to RabbitMQ? Sending messages? Everything? Are there implications to setting this value too low or too high? These are the types of questions that should be answered by a helpful docstring.
When you have several assignments bunched together, please align their equals signs.
Well Minecraft doesn't have any enchantments other than those starting at 1, so it doesn't need to be implemented until Vanilla needs to implement it.
Could we just return true/false here? Feels more ruby-ish to do that instead of return an int that represents the same. What do you think?
Should this be handled as a default?
meh, I despise chaining APIs usually, they are super inconsistent etc.
Actually the symlink nonsense was unnecessary. Update forthcoming.
Good point. I did not like doing that. 

Would you like the logic back in MergeRequest and have the doc-ready click handler call it.
All of this `CAP_FREE` nonsense can go away now.   It used to be required to track which capabilities in the global array were used, and which weren't.  Now we know that < ncaps are used and >= ncaps are unused.  Easy.
these are probably unused when unix sock is not enabled? Thus giving compiler warnings?
there should be no stlb, please just use stl

additionally there should be a difference between visual and collision stl. visual: nice to look at, collision: simple geometries, but accurate dimensions and no overlap between neighbour parts
There's been enough requests for 'default' values of things.

How about:

```config :value, :validate => :string, :default => "%{CW_Value or 1}"```

or something like that.

I'm not sold on the exact syntax for "This field value otherwise this default" but willing to experiment.
It can be displayed as a toggle button or a link with a check box next to it. I'll add to the docs.
I think this should be in `"tab/utils"` instead.
heh.  this is where the usefulness of github diffs breaks down a little.  Quite an extravagant wash of green and red for one small change!
I thought it was decided in the mailing list to set this at 1 week.
Are we still actually using this?  The code_version check on the front end was disabled in favor of using ETAGs and SHAs in the URL.
What do you think about removing the `Base` suffix from these two class names?
Can't be done as aData is log.directory and the property is log_directory.
you can probably just remove it completely since newnewtab doesn't require auth? :)
_search_field_locator & _search_button_locator point to the same element, when instead _search_button_locator should point to the search button, an example of this locator would be:
_search_button_locator = (By.CSS_SELECTOR, '#search button')
why IE 10? Shouldn't it be IE 9?
If `destroy!` returns false, this line seems unnecessary. Just return the value of `destroy!` or `!!destroy!`.
And here I use a dumb strategy to reload stylesheets.

Setting a little timeout to avoid 'flash of un-styled content'.
I'm not quite sure which tuple you are referring to, could you be more specific?
Please correct formatting :).
I rewrote the ErrorHandler using the same structure of Zend\Log\Formatter\Simple using a format properties that contains the formatter string. The format can be passed as option in constructor.
self == true || self =~ (/\A(true|t|yes|y|1)\Z/i) returns Boolean value and there is no need to use return and return false
Yeah, we require it now, but on the old gallery you could push a package without it, and there are packages in the database with null descriptions. :(
Is this missing a closing div?
`(function($, $$) {` -> `(function( $, $$ ) {`

Applies in multiple places.
Je me suis emmêlé  


Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Friday, October 19, 2012 at 6:51 PM, Sébastien Saunier wrote:

> In lib/passbook/pkpass.rb:
> > @@ -23,14 +23,20 @@ def json= json > @json = json > end > > - def create > + def create(options={}) > + options[:as_file] ||= false  
> true doit etre l'option par défaut pour ne pas changer le comportement précédent
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/applidget/passbook/pull/1/files#r1892115).  
>  
>  
>
I understand this, and realized that this might happen in certain situations. Only in the case of a 1.0 / 0.25 / 0.25 RGB or less would this happen, but I am pretty certain you understand this as well. I used this for the current version, and am continuing to improve the logic to remove these boundary cases.

I am still running into a problem however with the CONST FLOAT, as this CONST treatment I don't yet fully understand what can and cannot be done with it. My current code to fix things gives me a "variable undefined' execution error when I try:

//	Code changed to improve the contrast of the map.
	float rf = RandDouble();
	float gf = RandDouble();
	float bf = RandDouble();
	if ((rf + gf + bf) < 1.5) // Color is too dark. Adjust to a color that will provide enough contrast for a black background
	{
		if (rf < 0.66) {
			const float r = rf + 0.33;	// <-- Increase the amount of Red
		}
		if (gf < 0.66) {
			const float g = gf + 0.33;	// <-- Increase the amount of Green
		}
		if (bf < 0.66) {
			const float b = bf + 0.33;	// <-- Increase the amount of Blue
		}
   	}
	else { // Color is OK. Just load values into RGB constants.
		const float r = rf;
		const float g = gf;
		const float b = bf;
	}

Apparently CONST FLOAT cannot be in a statement where variables are being used (?)
and not give the events when cascade all was set? this feels a bit shaky. and it would be different for children then it is for references. i think we should keep it as is and document it well. (the implicit cascade of children delete and the memory impact)
why d owe have newlines here?
This is interesting. You probably have more experience with this lately - I haven't been on IRC in ages - but I added the #github channel at the time simply because there were more people willing to help newbies there than the #git channel.  It may be that this has changed.
... buts its done!
move this out of the try block?
It's not about sending =) But I agree this should be checked.

It's about value for `scope` i.e. GH uses: `user, public_repo, repo, delete_repo`, while Sensio: `SCOPE_EMAIL SCOPE_PUBLIC` etc. do see my point ? =)
The parent POM version always matches the version of application server you are using.
Needs 4 space indent.
Aha. No foreign key necessary, it seems.
I am worried about this. Modifying the prototype of typed arrays could cause JS engines to deoptimize code. Let's avoid this.
why do we need /b ?
Nit: should be two spaces for indentation; not four.
all these methods that return something should be properties
In general:
```js
if (condition) {
    statement;
} else {
    other-statement;
}
```
interesting, net is located at /lib/net.rb :)


On Mon, Dec 10, 2012 at 10:29 AM, Corey Osman <notifications@github.com>wrote:

> In lib/proxy_api.rb:
>
> > @@ -1,18 +1,21 @@
> >  require "rest_client"
> >  require "json"
> >  require "uri"
> > -require 'net'
>
> The compiler complained without it. Said it couldn't find net but found
> net/http. Corey
> … <#13b83eef74c407e3_>
> On Dec 9, 2012 11:41 PM, "Ohad Levy" <notifications@github.com> wrote: In
> lib/proxy_api.rb: > @@ -1,18 +1,21 @@ > require "rest_client" > require
> "json" > require "uri" > -require 'net' hmm.. why? — Reply to this email
> directly or view it on GitHub<
> https://github.com/theforeman/foreman/pull/292/files#r2360984>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/foreman/pull/292/files#r2361276>.
>
>
fixed, I don't think this was even restarting the channel as advertised.  Removed notification of sender.  They can create their own return handler if they want notification, set the channel to None, and then send a failure message to re-establish a channel.
close in finally {}

finally is _always_ called. Even when return, throw etc.
I would recommend to increase the screen size to 1280x1024 because we have some pages that are wider than 1024 pixels. I experienced some problems with selenium on my local machine when a test tries to click a button that is not visible (because it has not been rendered within the 1024 pixels). Therefore we increased the browser width on startup to 1280 pixels.
need to add `db.close()`
How were "projection changes" handled in 2.x ?
This comment is out of date. It says the reverse of what actually happens. More specific symbols override less specific symbols (as per the block comment at the start of assetMap ).

However, having struggled with GIT I can't work out how to get back in and change this, so leave it with this note for when it is accepted or rejected.
You could use destructuring assignment here also:

```coffeescript
{name, page} = req.params
```
Firstly I think it's not so critical, because anything in the tests that fails to execute will be quickly noticed. Some class that is missing tests and goes to production with a typo can fail suddenly if it's executed only sometimes.

And then the main issue is that you don't want to exclude all those files from *every* fixer, just this one. That said, I'll move that check in supports instead of having it here.
I like to have two blank lines between toplevel functions to improve readability of the source code. Without it, the code kind of runs together a bit more. This makes it easier to scan vertically.
Maybe warn? It'd be nice to go to stderr.
I agree @fwenzel asked for this - do you think this is necessary?
without the "strip", I was ending up with an empty string as the first element in the array.
I think we can just send the configuration file, otherwise we'll end up with individual end points for all config possibilities. The config feed will be cached anyway.
Could this be pushed down into `_updateLibraries` ?
Do we want to send out this event if an error occurred?
You shouldn't need to set these slugs explicitly, as friendly_id generates them when the user is created.  In fact I think it's better not to.
This comment doesn't match the implementation (it was wrong before already).
While changing the other stuff - ` ! empty($field['flags'])` will be much faster.
This really doesn't say anything at all. Could you change it to something like this:

 - set_realpath() can now also handle file paths as opposed to just directories.
@slebedev можно конкретную цитату ? А то моя не внимательность, не позволяет ее найти :(
Это ведь не возможно
Совершенно неправильная инициализация! Вам нужно в самом начале получить объект, под который выделена память, то есть этот метод нужно начинать с [super init], или же вызывать initWithArray именно здесь!
бесспорно, но если 0 - можно сразу выходить из метода, не создавая массив. разумеется, это не критично   

best regards,
Evgeny Trefilov


On Tuesday, 6 November 2012 г. at 0:42, Alexander wrote:

> In osx-project-1/osx-project-1/Cell+muttator.m:
> > @@ -0,0 +1,52 @@ > +// > +// Cell+muttator.m > +// osx-project-1 > +// > +// Created by Alexander Kazanskiy on 04.11.12. > +// Copyright (c) 2012 haxlet. All rights reserved. > +// > + > +#import "Cell+muttator.h" > + > +@implementation Cell (muttator) > + > +-(void) mutate:(int)num{ > + > + if ((num < 0) || (num > 100))  
>  
> здесь проверка на недопустимое значение, а 0 допустим. Если поставить <1 будет не корректно.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Hexlet/osx-project-1/pull/55/files#r2034885).
Какое именно?
You left the trackable columns in though we're not using them.  Also, instead of having all the generated stuff that you're not using commented out, just delete it, it makes reading it easier.
I'm doing that because of the issue Jason had in the past. Promiscuous started being a dick at some point, and because of the lack of output on stderr, he wasted an hour.

Furthermore it can help us setting up deployment as seeing that message would tell us that it's all good, as we wouldn't need to tail the log.

If you see 0 publishers, while you are supposed to have some, you see it right away.

So it's not needed, yes, but that's an extra layer of safety if you will
This is kinda ridiculously hard to understand and doesn't seem to replace the functionality of `+deferredScheduler`.
Second nested block (^(NSString *keyPath)).
This can be obtained from the invocation's `methodSignature`. It seems silly to pass it in here.
Why is this `__block` qualified?
Seems there are quite a lot of blank descriptions or the description is in the command. Perhaps a separate pull request once the formatting is at least in place would be warranted instead of pointing them all out here.
It certainly is possible -- that's a great way to override the base definitions.
Fixed ;) I removed the second constructor and turned `options` into an optional parameter which default value is `null`.
http://en.wiktionary.org/wiki/highlit
You should not need EOF, ending the enumerator simply should be enough. If it is not then there is a bug somewhere else.
you should keep the existing link here, as it is the link to the place where the SE uses the composer autoloader
you should add a warning about keeping the cache folder different for each environment, otherwise some unexpected behavior can happen (as different envs means different configs and so the cached data may need to be different)
设置在缓存中的描述符最大数值
1. 没有动词，所以“在”无意义，请去掉
2. 最大数值，最大数量
Totally open to options here. If you think grabbing both vars is a good compromise until the next release I'm cool with that. The only thing that will be weird here is the button will not have the correct text for anyone who wants to use the locales -- so the integration tests won't pass.
Fixed and pushed... thanks!
fine i will add it
This is too much, the MIME isn't very specific to each document, so the value should be kept small, let's say 0.5f;
Lots of blocking avoided, though currently when we create a producer or consumer, there is no guarantee that the underlying channel has been started.  We return the actor, and it is up to the caller to verify that the channel is up by using a channel callback to monitor the state.  So, in the examples and tests, we potentially block before sending  a message from the producer.  I'm open to other alternatives, but the only one that comes to mind is blocking within the AMQP extension when we make the request for a new consumer/producer.  I don't think that's a great idea since these things are supposed to be fault tolerant, and it seems reasonable to get one that will eventually start when an underlying fault has been resolved.
Por si no se nota, este cambio es el agregado de `CommonJobs.Domain.Test` a la carpeta de proyectos de Tests.
No se recalcula en este momento.
Shouldn't these be switched i.e., if x add height and if y add width?
Can we put this on one line?
Parentheses seem to have spaces the wrong side of them i.e. "blah (blah blah blah) blah" not "blah( blah blah blah )blah"
I only had 3.3 to test, that's why I didn't add the others. It probably works though.
whitespace -> different commit
Right, finally we're getting somewhere :).

I agree with you, the way we have specified activation to work is a bit vague. In fact I asked myself similar  questions you are asking. I started a thread in the dev list to discuss changes to the way we're doing activation:

http://lists.jboss.org/pipermail/infinispan-dev/2012-November/011628.html

And support (Dennis) was against changes here:

http://lists.jboss.org/pipermail/infinispan-dev/2012-November/011629.html

The thing about removal is the fact that it can optionally return the previous value, and that's why according to support guys it should be considered an activation, but really, these values are not stored in memory any longer.

Happy to go with your view though.
Why have a wrapping modules element?
Agreed. TO shouldn't  be thrown at all by method but only gather the TO information in the 'errors' Map as, base on the configured BackupFaliurePolicy we might not even cancel the operation. I've made the change and also added some logic correctly wait for timeouts as currently the time elapsed waiting for a request is not deduced from the timeout of subsequent requests.
As far as I remember checking for existence of a substring doesn't make `.replace()` any faster, it has to look for the substring first anyway. So you could skip this check and then get rid of `escape_comment` altogether calling `.replace()` right from the `comment()`.
I prefer to add two lines spaces between methods, imho it's more readable. Plus I tried to maintain this code style in all Jadler source files so that's why I added these lines here.
Why so seri... static?
Not according to `diff.h`:

`interhunk_lines: min lines between diff hunks to merge them`
what happens if i forget to mention one of the guessers in this config? for the chain router, we took the approach of specifying a priority attribute in the tag to decide which one comes first. on the plus side, here its fully up to the user which order he wants.
Cheers @pelson and @WeatherGod. I was clearly in noob-mode when I wrote that. Thanks for the feedback. Did you both try out a build with this new change? If so, how did it go?
Just occurred to me that we should use numpy.percentile now (assuming it's available in minimum version of numy that MPL supports.
I have the sneaking suspicion that this file is automagically generated. @mdboom Do you know where the github stats come from? Presumably you didn't type them all out by hand...

If it's auto-generated then I wonder if these changes will be overwritten in the next release, when we re-generate the github stats.
as i said in the other translation, i have to agree on that, in french tech language and even if indentation is not a "valid" french word, it fits better
Oops, sorry, I thought weight was a parameter to the function. Actually though, do we need to throw an exception here? Like, if weight is greater than or equal to zero, are all bets off?
please use the SG_ADD macro with MS_NOT_AVAILABLE
Extra `nil`.
see my next comment :)
You get an empty element, only if you exclude the categories option. In cases where you selected the option, but no categories exist on the deployment, it makes sense for the user to get to know that there are no categories, as opposed to receiving an XML File without the element you expected. Make sense?
BSD/Allman bracketing for this `if` block. RE: https://wiki.ushahidi.com/display/WIKI/Coding+Style+Guide#CodingStyleGuide-Brackets
There are cases where a hidden product will end up in the cart, for example, when bundled with another product.
In these cases, it is not a good idea to have a hyperlink to the product page, esp not in the cart.

Note:
$_product->is_visible() will always return true when dealing with variations. However, when a variable product is marked as hidden, we want to disable the hyperlink, no matter which variation is added to the cart. That's why we're checking the 'visibility' post meta, which always refers to the parent product.

Note: The get_post_meta should probably be filtered for consistency with is_visible(), like so:

... apply_filters('woocommerce_product_is_visible', get_post_meta( $_product->id, '_visibility', true ), $_product->id) == 'hidden' ...
Should .gitignore be empty then -- are there any project specific files to ignore ?
I don't take out the cache because I realised that's a bad idea. when using local repo, it bypasses cache and does straight copy from local repo only. In remote repo, cache is a good idea for doing local copy rather than querying the odata feed.
Avoid committing commented lines if possible
"you would end up with `IS_IPHONE` *and* `IS_IPAD`"
Yes, it makes sense. I will add it to the suggest section.
I think these arguments are incorrect for `change:attr` events.  The arguments would be `model`, `value`, `options`.
I've edited the previous patch with some of the proposed changes and
some others.
Placed both under one  if (originalDefaultEngine) {} as I still prefer
to keep it.
Fixed by 8fe0c8c826da95dad856968cc95495f0556cba31
Where does this option get used?
just a note here, the last check (`/^#.+/`) is there because if you only set 2 components of a border (say, `borderLeftWidth` and `borderLeftColor`) IE would actually return the styles in the correct order. It's only after you set the 3 components that you get the color as the first component.
Uh, that's a valid point. I was to busy complaining about the state of OAuth that I overlooked that one. Are there also other tokenTypes possible?
Oh, you want me to override get_succes_url ??
Why didnt you say that before !
Why assigning to `temp_upper_limit` twice? Before `if` and in `else`?
Use `self.get_all_panels()` here.
if-else exists in Django templates. ;-)
I think we are everywhere writing `e-mail` and not `email`. But please check.
`self.exposed_name` instead of `self.exposed` ?
But yeah, i think we could remove everything bout "easier to setup and to use" as right now, they're mostly the same in those terms (1 jar).
@Vincent-Michael no

@joschiwald dunno
Please use a private method instead of a recursive closure
Yep, this doesn't work nicely with array configs. Can live with it for now though, but makes the factory totally useless..
You can remove some duplicated code in your tests regarding input files by using a setUp and a tearDown.
Prefer the following to merge both system vars together:

```xml
        <plugin>
          <artifactId>maven-surefire-plugin</artifactId>
          <version>2.12</version>
          <dependencies>
            <dependency>
              <groupId>org.apache.maven.surefire</groupId>
              <artifactId>surefire-junit47</artifactId>
              <version>2.12</version>
            </dependency>
          </dependencies>
          <configuration>
            <redirectTestOutputToFile>true</redirectTestOutputToFile>
            <argLine>
              -Djava.library.path=${test.library.path}
              -Dtest.build.data=${basedir}/target/surefire/data
            </argLine>
          </configuration>
        </plugin>
```
how about "Updates the deployment status"?
I would try to find a way to not repeat that if block.
Should also scroll the newly selected into view. May be easier to find the next/prev on the DOM instead, see `network-view.js:300`.
This should still use the old notation in case we don't get an extension name, e.g. the code should support older versions too. Also for consistency use double quotes.
Yeah, just now coming around to the fact that float(x) ultimately becomes a C-style cast. I'll need to consider further whether removing them wholesale is worth the readability cost. For now, use `float(foo)` for primitive types since that's something we do everywhere.
Yes, for the gaussian kernel the scaling factor c is always 1.06
It might be nice to tell everyone what the replacement is for `Currencies#countries`.
у нас есть какой-то DSL для команд в серверном коде для этого, может тебе стоит доступ дать?
Translatable strings all around.
I'm not opposed to this. There is, in fact, not a huge amount that remains using `get/set/scaleFlux` (gleaned using grep).  Mike, would you be opposed to removing it entirely?
"Return without submitting" might be confusing wording for a student who is taking the exam for the first time.  Maybe something like "See previous submissions (without submitting)" would be better?

Also, the students do lose their current work if they leave the page--might we want to warn them about that?
Did you mean to add the result of e.invoke to the `stops` list?
I guess I did that somehow, but is it really an issue big enough not to merge the pull request?
T'as un exemple pour ça ?
This comment isn't so clear to me. Maybe "if the named property is a function, invoke it; otherwise, return its value"?
this config should be set in a not tracked file
I like this idea, but I think the environment variables should be more like OAEBLDR_COUNT and OAEBLDR_OFFSET so they don't end up clashing with something else in the user's environment.
Is webinos logging not working for this module?
See https://developer.mozilla.org/En/HTML/Element/Script
there is already a check for $data['left'] || $data['right'] so another one for $data would be pointless
Same as other file, think the _support require can be dropped
Look at here:

https://github.com/demandchain/homerun/blob/develop/lib/workers/feed_generator.rb#L55

This is how google code split it.

Not saying this is absolutely correct because this is not completely correct either.

Also take a look at: http://jira/browse/OP-877

I am ok with you merging this, just want to be aware of it
И на все исправления надо тесты писать.
И еще тут же вопрос, как получить сообщения вида 
at ru.fizteh.fivt.examples.Main.clear(Main.java:35)
 из исключения? Я нашел что-то похожее в getStackTrace, но там куча сообщений еще другого вида, да и вообще там очень много сообщений, поэтому я подозреваю, что это что-то не то.
У итератора есть методы hasNext() и next().
А если format - null?
This try/catch was the only way I could get the regex iteration to work correctly. Is there a better way to solve this, or is that acceptable?
oups, sorry.
ids never expire until explicitly unregistered
I'm not mad on all of these test steps being wrapped up inside one single method. Each step in this submit app flow should be abstracted out into individual steps because in the future there will probably be tests that test different workflow paths.
do these regions have enough in common that you could create a base class for them? if nothing else, they all do click_save_changes() and have the _save_changes_locator.
nice catch 
Updated
Sorry, I am a bit slow today. What is ``n_outputs_``? It is not documented btw ;)
I don't understand this test (maybe it is to late). This calls the constructor, right? Where does the constructor do input validation?
It shouldn't, that should be done in fit. But I don't see where it happens at all.
```python
res = safe_sparse_dot(X, Y.T, dense_output=True)
if out is None:
    out = res
else:
    out *= 0
    out += res
```

A bit hacky but at least it honors the `out` argument.
> Also, I think structured array is a new feature from numpy1.7, so I can't use them anyways.

No, they've been there for ever.
`sklearn.Kmeans`
This seems wasteful as geoLookup makes an ajax call and does no caching.
If I click 'switch to list view' it fires off exactly the same ajax request it has just done in the map view
Actually one other idea I got is to provide a custom QueryBuilder when calling the ```find()``` method, since the same index could be called in different contexts.

Then the ```find()``` method would take two additional arguments: ```QueryBuilder``` instance and an alias (string) name. Both optional. E.g.

    $entity_repository = $em->getRepository('AcmeBundle\Entity');
    $finder = $this->get('foq_elastica.finder.site.entity');
    $query = (....)
    $results = $finder->find($query, 10, $entity_repository->getFinderQueryBuilder(), 'e');
use `!= NULL` instead
Keep ordered
The use of "test" and [] are inconsistent. Why not use [] for both, .i.e. if [ "$allownonascii" != "true" ] && [ $(git diff --cached --name-only --diff-filter=A -z $against | LC_ALL=C tr -d '[ -~]\0' | wc -c) != 0 ]
is `action` and `node` used?
Liste le contenu de la quarantaine
> 0 (whitespace)
>Possibly for efficient random access / ease of use with XPath ?

getProp("SubFile[<n>]" would be optimal

matching @num="<n>", will involve a scan, if the elements have same name.
If dfuserver STOP=1 does not work, that's a separate issue from the new feature that has been requested here.

What has been requested (and has taken far too much time and energy than it is worth) was the ability for operations to pause the dfuserver queue just as they can pause the other queues. They do the others in eclwatch, they should do this one in eclwatch, and it should be about 3 lines of code and 15 minutes work (and should probably have been assigned to Kevin).
Ты это сознательно на новую строчку перенесла?? ( ._. )
When deleting the "newModel" key is just and empty Data instance.....
Can't we use `bind` as 2 previous lines?
The date should get internationalized.
sure. i should probably add response to provided args then since its expected right?
Have you tested whether changing the keys from symbols -> keys works here? Since `watch_file_array` is built as a simple hash, will this still support the indifferent key access? The other key changes appear fine.
This rescue is not doing what you think it's doing.

Undecorated rescues complicate troubleshooting, there should at least be a `print_error e.message` or something.

At any rate, if there is no domain, you get this:

````
msf  post(gpp) > exploit

[-] Post failed: NoMethodError undefined method `sub!' for nil:NilClass
[-] Call stack:
[-]   /home/todb/git/rapid7/metasploit-framework/modules/post/windows/gather/credentials/gpp.rb:289:in `get_domain_controller'
[-]   /home/todb/git/rapid7/metasploit-framework/modules/post/windows/gather/credentials/gpp.rb:88:in `run'
[*] Post module execution completed
````

So you will need to switch on the presence or absence of domain, and rethink this execption handling strategy.
No disconnect when no exception? is it ok?
This is almost as bad as ```::Exception```.  Please be more precise.
Limited numerical precision leads to the effect that `tform.inv(fwd(src))` does not result in the `src` coordinates. But it is probably better to remove this step as all coordinates are "distorted" by limited numerical precision not only 0s. Your opinion?

This was more of a cosmetic addition.
Good catch, I made that change, and changed it to a label instead of a span.
This is necessary since otherwise we never know whether a strategy was set by the developer or not. This was actually different from YAML and XML mapping. Internally we still default to assigned.
My issue now is the `BillboardCollectionSpec`. I could reformulate the tests to work with non 1x1 textures, but there are so many tests that rely on that property it would take a long time to fix. Is there some elegant way to allow `scalingFactor` to be changed?
It does change the camera's look direction, to straight down at the map. I changed the code above to set the view direction to negative z because it will no longer get locked to a constrained axis.
Right, If the difference between the right plane distance and the left plane distance is less than or equal to zero. What distance would be as far as possible? In 2D, the amount you can zoom is limited by the properties of the orthographic projection, but, in 3D, there isn't any limit to how far you can zoom. The camera just moves along the direction vector.
Okay. I will use Array.forEach.
headerName can be final here.
Can't we just check for falsy values here? Like:

if (!data.cancelBubble)


FYI: the following will resolve to 'false': 

false
null
undefined
The empty string ''
The number 0
The number NaN
I may have to talk to you about this.
Since you removed the comma after "version number" you should remove the comma at the end of this line too :)
You either define a funciton `mpi_type()` in `tools/toolchain/mpi.py` or just access it directly with `self.toolchain.MPI_TYPE`. 

You do want the constants publicly available, so you can do something like `if self.toolchain.MPI_TYPE == MPI_TYPE_OPENMPI: type = "OPENMPI"`. 

You shouldn't define the constant with the value you want, you pick the value based on the constant.
So, we could use it as componentsFetch.done(fn) or componentsFetch.fail(fn) right? Good point, much better.
can't this just be done as a `chmod +x ...` (or, if you're really paranoid, a `chmod +rx ...`)?
Thanks for the tip!  I do like simplicity.
I frequently use the pdfs for reference but i guess that part hasn't sunk in yet :-)
I considered this, that would make us repeat the console === "undefined" condition in each line.
Ну так мы же в свой кладём. `$` везде берётся локально.

Вообще, эту тоже можно туда положить, судя по виду.
To many l's in "below."
If T is nested struct, `T result;` occurs an error.
In addition, if T has `@disable this();`, we can bypass it.
hmm, the new exception syntax prevents 2.5 compatibility anyway.
still unneeded empty lines (11 lines)
But that would mean that I have to put the SimpleModel and EOModel at ekb api level. I mean with this move we can get rid of the ModelUtils and use the SimpleModel as a "wrapper" object. But maybe this would then be again an own issue, since this influence very very very many classes : )
yup - I just did that. but unearthing some more potential bugs. 
this is like a gift that keeps on giving ;)
This is called in calllog_toggle, but that doesn't appear to be called anywhere.
We spent more than 2 days looking at this between both you and I ... I am not intending on changing it to a REPLACE, while it would be a bit cleaner, I don't feel it is worth the effort to delve into this at this time. We agreed at the time - I would rewrite the code such that it worked properly 

----- Original Message -----

From: "nrporter" <notifications@github.com> 
To: "plymouthstate/plymouth-webapp" <plymouth-webapp@noreply.github.com> 
Cc: "bscoleman-psu" <bscoleman@plymouth.edu> 
Sent: Wednesday, October 3, 2012 10:59:37 AM 
Subject: Re: [plymouth-webapp] changes for adding new BM Report App (#425) 


In legacy/hub/HUBSQL.class.php: > +		$data['lastname'] = $filer->formatName('l');
> +		$data['firstname'] = $filer->formatName('f');
> +    $data['bmr_date'] = date('Y-m-d', strtotime($data['idate']));
> +
> +		// get previously saved version of the report...
> +		$bmr = $this->getBMReportByPidm($filer->pidm);
> +
> +		$data['modified'] = $now;
> +
> +		// if created is set - already saved one "round" get prev. saved information...
> +		if (isset($bmr['created']))
> +		{
> +			$data['created'] = $bmr['created'];
> +
> +			// Since using MySQL, can use a single REPLACE instead of check for existence
> +			// and then having to use INSERT or UPDATE 
Can we do some more experimenting to find if we CAN resolve the error? If we want to be able to use REPLACE functionality going forward, then we should see if we can get it working now instead of dealing with it later. Did we look down the database collation angle at all? 
— 
Reply to this email directly or view it on GitHub .
This shouldn't be moved to be below the END.
Why not use the latest version, and peg it to tiny instead of the minor version: `~> 0.5.0`
Yep great news :)

On Feb 21, 2012, at 9:51 AM, Simon Murtha-Smith<reply@reply.github.com> wrote:

>>     config = {registry:regBase, cache:path.join(home, '.npm')};
>>     config.locker_me = path.join(lconfig.lockerDir, lconfig.me);
>>     config.locker_base = lconfig.lockerBase;
>> +    config.prefix = config.locker_me;
>> +    var home = path.join(lconfig.lockerDir, lconfig.me);
>> +//    process.chdir(home); // for npm
> 
> Does npm no longer require the chdir?!?! This is great news!!!
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/LockerProject/Locker/pull/849/files#r471995
Duplicated code smell? Please factor out common logic frmo `index` and `show`
Well it allows reading from both GET or POST if you just use @Param. That's why I left it "active".
this function now uses existing logic and doesn't need the modifications to the various Contexts
why do this instead of using the Rails ActiveRecord version that should do the same thing?
i might be totally wrong here, but don't we only send the prepare if we need write skew check? If so then this information can be determined based on the configuration.
This should probably be `sendCommitteeWTS` to avoid conflicts.
@croby @bp323 @nicolaasmatthijs FYI: http://css-discuss.incutio.com/wiki/Internet_Explorer_Win_Bugs#.22Empty.22_div
I believe this is part of SAKIII-4927
Nice, that's thorough. Pushed fix.
Needs a semi-colon
Объяви ее в условии цикла строкой ниже.
Can you move this method down to where all privates are?
ouch!. I'll fix when you done with the rest. Definitely a leftover
like the description says, it helps with `grep -v`ing the logs. 

currently this shows up in the logs: 

`D, [2012-10-04T22:01:40.204925 #28750] DEBUG -- :    (0.8ms)  select 1`

with this change, this shows up in the logs: 

`D, [2012-10-04T22:01:40.204925 #28750] DEBUG -- :    (0.8ms)  select "app_status"`

this change means that `grep -v app_status` will filter out the latter.
make multiple lines @ 79 characters
Apparently @tombentley added this particular test. I think we should not test for that since we can't reliably test it on Windows and OSX. (the non-existence one that fails), rather than do our tests case-insensitive.
Ok will remove.
There seems to be an error whenever the user saves the compressed version due to this line. Something in the compressor is causing it. So, rather than trying to figure that out, just make the code a little more tolerant.
how the object is populated is out of the scope here
Fixed number of times to play the page
Hi Ed,

I assume that you're posing this question to the DB Team and not to me
specifically. Is that correct, Ed?

Thanks,

Mike



On 7/3/12 3:12 PM, "Ed Cranford"
<reply+p-1096064-083f8c550de1e840972fbe1b32ce59c3016289d2-1015169@reply.git
hub.com> wrote:

>> @@ -0,0 +1,18 @@
>> +POST /v2.0/tokens HTTP/1.1
>> +User-Agent: curl/7.21.0 (x86_64-pc-linux-gnu) libcurl/7.21.0
>>OpenSSL/0.9.8o zlib/1.2.3.4 libidn/1.15 libssh2/1.2.6
>> +Host: identity.api.rackspacecloud.com
>> +Accept: application/json
>> +Content-Type: application/json
>> +Content-Length: 54
>> +
>> +{
>> +   "auth":
>> +   {
>> +      "RAX-KSKEY:apiKeyCredentials":
>> +      {
>> +         "username": "hub_cap",
>
>Sample or not, should this be dummied, or is it already?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/hub-cap/reddwarf_lite-integration/pull/103/files#r10960
>64
Don't know how to format ```depends_on_groups=["dbaas.listing"])``` to be in line with ```groups``` on the above comment.
I don't understand this? Why are those two lines needed?
Yeah, I like what you have there better.
La premiere solution me semble bien
Let's add a link to http://nodejs.org/#download
Done in 668c6fd3f40340496e3456eb0fb8a4ce3ed34ffb
Should this be called TFIDFVectorizer instead? Vectorizer is a very generic name, and this class has a very specific purpose.
If this changes the contents of `text` due to the `#strip!` call, then this method should have an exclamation mark on the end, too.  If that's not intended, then just make a temp var to store the stripped version.
I don't see why ::URI.to_uri is friendlier than ::URI.to_s? In fact, I think this actually makes it more confusing.
and again :D
Is this still a FIXME?
Should possibly pass rec rather than item if there is no xml tag for this element.  I have no idea what the code generator does for that situation though.
This is fairly complex (and that complexity is mostly our fault). Could you rewrite it as something like:


```ruby
def expected_flash_invocation
  now = ""
  key = ""

  if @now
   now = ".now"
  end

  if @key
    key = "[:#{@key}"
  end

  "flash#{now}#{key}"
end
```
hello dies würde ich nicht so machen !!
otherwise the last option in the option list will not be displayed.
This still needs a better summary on what the behavior is. Will this cause the size of the view to fill the size of the superview? Or does it only fill its size to the size where the subviews fill it? Could we could use better words that are proper antonyms such as 'expand' and 'contract', or 'stretch' and 'shrink'?
Duplicated. Please change it to something more meaningful. @should reject package version if not subsequent incremental version
Should we lose this line?
This is true for the clone stage, but after that i'm not sure that a user would want to have their settings.rb file look like this - as they'd want to pull down from sakaiproject. What do you think
Maybe put this line in a test file instead?
I couldn't tell you. Inherited this. We can remove it, but my hunch is it is fixing something.
Could we actually make this into toHaveBeCalledWith('toast.show'... for these. I know it's picky but just incase the hard coded event changes etc etc
remove until needed
underscore is still used for this method.
does it make sense to do this in twig and not as a controller callback and write this logic in php?