[chromium] rename webkit_resources
https://bugs.webkit.org/show_bug.cgi?id=95874

Reviewed by James Robinson.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

Suppress image failures for gradient-with-scaled-ancestor.html due to
scrollbar diffs.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
OS X port should compile with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=96434

Source/JavaScriptCore: 

m_identIsVarDecl is unused - remove it.

Reviewed by Anders Carlsson.

* parser/NodeConstructors.h:
(JSC::ForInNode::ForInNode):
* parser/Nodes.h:
(ForInNode):

Source/WebCore: 

Reviewed by Anders Carlsson.

Guard m_hasTouchEventHandler behind ENABLE(TOUCH_EVENTS).
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
* html/HTMLInputElement.h:
(HTMLInputElement):

Fix uninitialized variable.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::createLinearSRGBColorSpace):

Source/WebKit/mac: 

m_isTerminated is unused in the Hosted flavor of NetscapePluginStream.

Reviewed by Anders Carlsson.

* Plugins/Hosted/HostedNetscapePluginStream.h:
(HostedNetscapePluginStream):
* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r128075
https://bugs.webkit.org/show_bug.cgi?id=96435

Source/WebCore:

Broke chromium content_browsertests and included flaky layout tests


* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::playbackStarted):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::playbackStopped):
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):

LayoutTests:


* platform/chromium-mac/platform/chromium/media/controls-video-sizes-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/media/controls-audio-sizes-expected.txt: Removed.
* platform/chromium/media/controls-audio-sizes.html: Removed.
* platform/chromium/media/controls-video-sizes-expected.txt: Removed.
* platform/chromium/media/controls-video-sizes-padding-expected.txt: Removed.
* platform/chromium/media/controls-video-sizes-padding.html: Removed.
* platform/chromium/media/controls-video-sizes.html: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Get rid of the PluginProcessShim for 64-bit plug-ins
<rdar://problem/12068560> and https://bugs.webkit.org/show_bug.cgi?id=96415

Reviewed by Anders Carlsson.

* PluginProcess/PluginProcess.h:
(PluginProcess):

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::getCurrentEventButtonState):
(WebKit):
(WebKit::beginModal): Moved from the shim, to be shared with shimmed processes.
(WebKit::endModal): Ditto.
(WebKit::replacedRunModalForWindow): Only used by Cocoa overrides.
(WebKit::PluginProcess::initializeShim):
(WebKit::PluginProcess::initializeCocoaOverrides):

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain): Only call initializeShim for 32-bit processes, always call initializeCocoaOverrides

* PluginProcess/mac/PluginProcessShim.h:
(PluginProcessShimCallbacks):
* PluginProcess/mac/PluginProcessShim.mm:
(WebKit):
(WebKit::shimModalDialog): Call beginModal/endModal from the shim callbacks.
(WebKit::shimAlert): Ditto.
(WebKit::WebKitPluginProcessShimInitialize): Don't do the Cocoa overrides as they are now handled outside the shim.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
IndexedDB: Optimize key decode and comparison operations
https://bugs.webkit.org/show_bug.cgi?id=96037

Reviewed by Tony Chang.

Eliminate memory allocations in code identified as CPU bottlenecks in IDB profiling.

No new tests - just performance work.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Avoid incremental allocations.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Rename confusing variables p and q.
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare): Rename from decodeAndCompare, and add specializations
for frequently encountered types (e.g. object/index data) that can be compared without a
full decode.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Pass the logical height and logical top into RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=96432

Reviewed by Ojan Vafai.

This allows us to call RenderBox::computeLogicalHeight without first having to call
setLogicalHeight() and setLogicalTop().  Previously, computeLogicalHeight would depend
on these values.

No new tests, this is just a refactor.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateLogicalHeight): Pass logicalHeight and logicalTop as params.
(WebCore::RenderBox::computeLogicalHeight): Use passed in values instead of calling logicalHeight/logicalTop.
(WebCore::RenderBox::computePositionedLogicalHeight): Pass the logicalHeight into computePositionedLogicalHeightUsing.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Pass in the logicalHeight as a parameter.
* rendering/RenderBox.h:
(RenderBox): Update computePositionedLogicalHeightUsing and computeLogicalHeight.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ElementAttributeData: Use subclasses to manage varying object layouts.
<http://webkit.org/b/94465>

Reviewed by Antti Koivisto.

Add two ElementAttributeData subclasses:

    - MutableElementAttributeData
    - ImmutableElementAttributeData

The ElementAttributeData::m_isMutable bit determines which subclass to cast to when accessing
the attribute storage. Added mutableAttributeVector() and immutableAttributeArray() helpers
to ElementAttributeData (with appropriate assertions.)

This patch removes one step of indirection in the mutable case, since the Vector<Attribute> is no
longer heap-allocated, but part of MutableElementAttributeData.

Added a WTF::deleteOwnedPtr(ElementAttributeData*) specialization so that the appropriate subclass
destructor is called for these objects.

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::createMutableAttributeData):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::create):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::ImmutableElementAttributeData::~ImmutableElementAttributeData):
(WebCore::ElementAttributeData::makeMutableCopy):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
* dom/ElementAttributeData.h:
(ElementAttributeData):
(WebCore::ElementAttributeData::isMutable):
(ImmutableElementAttributeData):
(MutableElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::immutableAttributeArray):
(WebCore::ElementAttributeData::mutableAttributeVector):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::attributeItem):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skip spatial-navigation tests on mac-wk2 because they are all failing.
https://bugs.webkit.org/show_bug.cgi?id=96438.

Unreviewed.

* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128240 268f45cc-cd09-0410-ab3c-d52691b4dbfc