labofsahil/github-event-dataset-2012 huggingface dataset:
Do you think it is nice API which require programmer to manually add ID of the panel to the context? And if she forgets this, everything collapses?

So how would you make that ID is automatically in the context? Not that you had to change all panel code?
You mean we should attach stations to DOM elements displaying stations? Like we are attaching posts in the wall to DOM elements displaying posts?

But this is implementation detail. You don't put this into TODO (but you can open a ticket, with summary what all has yet to be done after this pull request).

In the TODO we should just write that we should update displayed data from pushed updates.
Space after `()`. Use `'` for constant strings.
Order imports. Django is first, then MongoEngine, empty line in-between.
'EmbeddedListField' does not exist in fileds...  This is error I get if i try to run it.
Add a template comment with TODO that this file should be made in a way which extends default `form.html` template.

So, this, that you copy-pasted the whole file and just changed a bit, this is not a good idea in general. There are solutions to it, but we will not go into this now.
I really don't like this tuple thing. Can you at least return dict?
`crypto` too?
Yes, you need both. So have both here.

(I don't find such comment. But it does not matter.)
Don't override `brew`.

The best way to sniff for installed formula is to do `Formula.factory("mysql").installed?`, and it should be done in `install`.
Why the rest of the tests in the class have been commented out?
Im `someimprovements` Branch habe ich das Verhindern des Nachladens bei schnellem Wiederöffenen drin. Wie dus bei der Timeline gemacht hast...  das sollte das Problem zusätzlich entschärfen...
Hast du eine idee wie man es lösen könnte? So falsch ist es alledings gar nicht wenn beim Öffnen geladen wird muss auch hochgezählt werden...
`#tables_to_truncate` comes from truncation so it needs to be there.
Maybe make the text lighter with a white background? I think the idea here is to show the hours from the previous month for reference, but not emphasize them.
nitpick: missing semicolon ; )
how about changing this TODO tag to:

add any user/app/situational data to the custom_data Hash below
What comes after the check in setDefaultTempPath() is much more expensive than an assignment so I think the check makes sense there.
Can we just have None and 'L1'? I tend to prefer capital L's unless someone is strongly against it. Lowercase l's can be hard to read depending on the font.
replacing this with df_model and super aic, is more difficult to read, not now
Sorry. Added #488.
Now that you clean this up, I don't like the name ``NBin`` anymore. There are two many abbreviations, where I never remember how it is appreviated

np.random.negative_binomial
(or at least scipy's NBinom, although I don't like it)

(Assuming users have code completion, writing minimalistic names is not necessary.)
Can we pull this out to an actual class?
@camertron, can you, please, explain, why do we need to go over the whole resources hash and expand all 'redirects` here?
Yeah, that's one of the reasons why I previously suggested extracting it. I felt like I've already seen smth similar and today I found almost the same [method](https://github.com/twitter/twitter-cldr-rb/blob/master/lib/twitter_cldr/tokenizers/base.rb#L78-87) inside `Tokenizers::Base` class. It's not critical, but at some point I'll extract it from all these places into `TwitterCldr::Utils` module.
would this ever realistically *not* be the default?
do not use this package
Outdated comment?  I think you and Gary agreed that the latter is NOT necessary for whitening since you can set up corresponding calculations with the PS?
I see from the code later on that this is arcsec.  But I think it's worth clarifying here, no?
You are right... `draw` fails very ungracefully.

I think there are two options... Either the one you suggest, or simply prevent initialization with zero objects.  The latter would not prevent any of the `config` stuff from working, I think.
I see this gets passed to videotest.js as a global variable...  But would be nice if it was functionalized.
damn it, I knew I needed to take that out... luckily it's to the staging server and I can revoke it :)

Thanks! :)
Do we really need to wait 600 seconds? The start() method won't return until the MBean existed (and the VM had been created obviously). So I'd have thought this would be pretty quick.
How about keeping "*:" before the port number here?
I saw it in railscats
Otherwise `AssetDispatcher` would throw a 404. Check the description of the PR.
Nei, providecommand überschribt nid, sondern tuat nur drzua wenn no nid definiart. Han extra das gnah, damit wenn aswer book brucht dia Befehl so tüand wia erwartet und nid so wia vo miar igstellt.
Bi miar hend dia headings immer so tua wiani han wella, allerdings hani nüt fancy gmacht (pun intended)
Fixed. All three should raise.
Numbered variables are a bad practice.  You can always choose a more meaningful variable able (eg ``self.out_of_stock_product``).
the idea of modularization is to remove the modules out of webinos as
separate modules and during build we download all relevant modules in
node_modules. So your module is already for npm but should be renamed in my
opinion

On Wed, Oct 10, 2012 at 3:30 PM, Dieter Blomme <notifications@github.com>wrote:

> In node_modules/webinos/README.md:
>
> > @@ -1 +1 @@
> > -webinos module
>
> Won't that be part of the "modularization of the code"?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/webinos/Webinos-Platform/pull/197/files#r1807204>.
>
>
These two look fairly straightforward, but do need at least a couple of simple tests.
I believe this is redundant as gon is included in the application layout.
If you want to preserve the old behavior, I don't think that job.toString gives you the json representation of the job. You'll need to pass that through the codec.
it isn't a question of how you get it from the html to the java, it how you store it in the database.  You take your strings/ints in the html and POST them to a controller, which bundles them into an object, which is what get's stored in the database.  I don't know if you want to use a date object or calender or what, but raw strings in the database are error prone and redundant.
@cbandy I have not seen anything about whether it still is necessary but I can't imagine that it hurts to leave it there just in case.
Ah, so the problem was?  I didn't know that ```[].present?``` would return false.  I assumed it'd be true.
Этот код не имеет смысла, т.к. вызывается метод Integer.valueOf.
I think you changed this to `"pseudoclass"`?
<code>s/tow/two/</code>
Does this pass?  The spacing isn't right - there should be a space after "Developers" and before the pipe char.
awesome .. lgtm
Why did this change??
Yep, here is how I plan to change this:

```scala
if (contentType.equals(TemplatePartitions.TEMPLATE_SCALA)) {	  	
  val cu = TemplateCompilationUnit.fromEditor(templateEditor)
  new TemplateHover(cu)
} 
else new DefaultTextHover(sv)
}
```
I could also do that...
I think it would be worth explaining why the `break` with an inline comment here as even @agramfort was confused.
```
if (np.min(np.sum(D, axis=1)) == 0.
    and self.corr != correlation.pure_nugget):
```?
That would be really great! Thanks :)
а ты можешь назвать первый параметр просто $path ?

тогда в константах в теории может этот $path храниться, а на практике, по-моему, проще его вручную указывать

чем имеено

    $api->request(API_TYPE_ACCOUNT, $request_type, $params); 

лучше чем

    $api->request('/account/', $request_type, $params);

?
The actual properties should be indented by 2 spaces in the output - until the last line closes with "}"
I can't think of one.  Done.  (Though I abort instead of warning, because nothing good can happen after this I think.)
If msgExpr is always going to be non-null, you should remove this check.
I didn't have to when they were in the original order. Will fix.
This seems like more of a local variable and not needed in self. If the result from Deltafy() can be reused then please put it in `__init__`
I will add a comment to explain that we are only targeting ubuntu / debian systems.
I used the math notation : http://en.wikipedia.org/wiki/Interval_(mathematics)#Excluding_the_endpoints
It does not exist on our build and test mac's here either.
getInternalOperatorText() maybe better.
Good point. 

In the past I couldn't assume a transactional model for everything (like creating and removing files), and now I have to work with a dual model (some actions in transactions, others not), so some assumptions look very confusing.

However, this one is not one of them, not any more, at least.
Glad you said that. But I think you can see the use in doing this refactoring.
I *think* it's okay for us to access URL until we emit `requestCreated`. Once we do that, I think ownership of the request transfers to Qt's HTTP layer and it will delete the request whenever it feels like it.
I certainly understand your opposition. On the other hand, I'm not sure if we can properly limit the results with respect to the sorting, without pushing the limiting down to sql, or getting all records. As it is, we don't obey any limit greater than 25 here. 

I guess we could perhaps document that the limiting was always by changeid, which would probably do the right thing in most cases.
I say we get rid of it, and you use a context specific piece of PHP code where you need it that replicates its behavior, or does something specific with your particular needs.

In most cases, if you're dealing with configuration data, I don't generally care what the array is as a whole, only that if I am presented with a string for any given value's key, that I probably have to do something different with that specific key/value set.  Also, I have to go down the route of "is this array a map or an array", reset($array); if (is_string(key($array)) is generally good enough for me.

If you have to ensure all keys are int or string, then why not just check at iteration time, and if an invalid value is found, throw an exception?
Why did you delete this case?   The ```EnumName``` is necessary.  Add it back!
Going with this approach will allows us to only have a need to specify it on public pages (see `dashboard` route)
Hmm, I don't know about having an expression constructor specifically for this – I've generally been reserving them for anything that has a unique generated form (like array and dictionary literals, which use the special syntax).

It might make more sense to just always go through a function, like `extNilExpr`, which simply returns an expression for `[EXTNil null]`.
spec syntax :tada:
I'm still a bit wary of this, but it'll do until we come up with a better singleton implementation. Take a look at http://stackoverflow.com/questions/6760685/creating-a-singleton-in-python
@Seldaek because it looks ugly if cycle this classes. like html markup leak.
Creds may not necessarily be valid against this particular host, but no better way to store this at present.
Good point! I normally don't write code this way, not sure what I was thinking. I've fixed this to be more explicit.
Some members, including `_useBins ` only need the lifetime of one frame, but have the lifetime of the Scene to pass data around when rendering.  Unless the data needs to be a member for performance, e.g., `_renderList`, we should remove it, and, in this case, just pass it to `renderPrimitives`.

In general, the data flow is non-obvious when looking at `Scene.prototype.render`.
You mean BindableSpec? Because **you commented this dependency out on 8/17/12 at 10:19am**. That told me this file was not longer needed. Therefore, it needed to be deleted.
This needs some styles. Also, you should specify placeholders in config/locales/en.yml. See the simple_form config for how to do this (you can also specify hints, labels and other things there, it's really cool and keeps your view really light)
w00t

On Tue, Oct 23, 2012 at 5:20 PM, André Rodrigues
<notifications@github.com>wrote:

> In
> WindowsAzurePowershell/src/Management.WebSites/Cmdlets/RestartAzureWebsite.cs:
>
> > @@ -0,0 +1,83 @@
> > +using System;
> > +using System.Collections.Generic;
>
> R# uses inside. VS uses outside… it's debatable at a minimum :) But yeah…
> maybe we should follow VS as it's more MSFTish. From: Chris Tavares <
> notifications@github.com<mailto:notifications@github.com>> Reply-To:
> WindowsAzure/azure-sdk-tools <reply@reply.github.com<mailto:
> reply@reply.github.com>> Date: Wednesday, October 24, 2012 1:05 AM To:
> WindowsAzure/azure-sdk-tools <azure-sdk-tools@noreply.github.com<mailto:
> azure-sdk-tools@noreply.github.com>> Cc: Andre <andrerod@microsoft.com
> <mailto:andrerod@microsoft.com>> Subject: Re: [azure-sdk-tools] Adding
> Restart-AzureWebsite command (#497<https://github.com/WindowsAzure/azure-sdk-tools/issues/497>)
> In
> WindowsAzurePowershell/src/Management.WebSites/Cmdlets/RestartAzureWebsite.cs:
>  @@ -0,0 +1,83 @@ +using System; +using System.Collections.Generic;
> Ok, will change. But I think we should revisit the convention - we're
> fighting our tools. Either that or we need to get the VS "Add Class" item
> template to put the usings inside the namespace. — Reply to this email
> directly or view it on GitHub<
> https://github.com/WindowsAzure/azure-sdk-tools/pull/497/files#r1923347>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WindowsAzure/azure-sdk-tools/pull/497/files#r1923446>.
>
>
It would be faster if the function returned [window isKeyWindow]. This also removes the need of an argument.
This will be problematic for paths such as `~foo/bar`. `os.path.expanduser` behaves in the way expected (only replacing the first `~` if it points to the user dir).
This class can't be removed, it will break modules, and ti-verify.
Rule 7 violation.. :) I won't keep doing this to you, I know it's annoying.   But you should check all your blocks (if / for etc) for Rule 7 of our Java Coding Standards.
Not critical, but the returned array is already autoreleased, so no retain/release is required for doomedVcs
This app is one single library, so the underscores are overkill.
So if it does not exist relative to where we're executing?
why does it create one here when the method says it is just getting ?
Yes, this makes sense, fixing now.
Here catching the exception is useless, pc._signaling will be always available and closing a yet closed websocket just do nothing.
This won't work. At this context, "self" is a reference for the RTCPeerConnection object (where the _signaling attribute is declared), but "this", because is being called inside the "onmessage" function, is a reference to the "channel._udt" object, it's said, the real websocket, so it would raise an error.
this won't actually work anyway, best to do this sorta thing inside a pages initializer like where it injects `Refinery::Pages::InstanceMethods` into the ApplicationController :-)
`applyVisitor`?
Did you benchmark this to make sure it's faster than the existing baseline?
I would like to figure out a readable syntax that allows specifying
multiple values on the same line in a cascade.
Not sure either of those options is readable enough.  The second is verbose
and the first is ambiguous.

On Tue, Aug 21, 2012 at 2:51 PM, John Messerly <notifications@github.com>wrote:

> In components_polyfill_boostrap.dart:
>
> > +  print("Test that the library compiles. ignore.");
> > +}
> > +"""
> > +        ..type = "application/dart");
> > +
> > +  }
> > +  sb.add("""
> > +$sbMain
> > +  polyfill.initializeComponents();
> > +}
> > +""");
> > +
> > +  // Inject the output dart script on the page and the dart.js bootstrap script.
> > +  document.head.nodes
> > +   ..add(
> > +     new ScriptElement()
>
> would it be too weird to write:
>
> new ScriptElement()..text = "$sb"..type = "application/dart"
>
> or perhaps:
>
> new ScriptElement()..(text = "$sb")..(type = "application/dart")
>
> I think it looks great as is, just doing a thought experiment here about
> cascade style
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-web-components/pull/16/files#r1430042>.
>
>
Add a smile to this line too, please :)
Similarly, can this be removed?
I think this can be reduced to

     :handle-ok ::file
Why is this wrapped in grouping parens?
this method is **totally** useless as the parent class already defines it
This is becoming design discussion now. We need to consider the use cases and scenarios before diving into details. Here is a list of the scenarios. We should encode the right logic at the right layer of the SDK. 
a. the sender sends a basic type such as integer, and the receive can unambiguously receive and decode it. 
b. the sender sends a basic PHP type, the receiver cannot always correctly decode it without some additional information, such as boolean,  or double. 
c. the sender sends an extended PHP type such as DateTime, the receiver cannot always correctly decode it correctly without additional information. 
d. the sender sends some custom data such as Money, etc, it is impossible to decode it correctly without prior knowledge of the data.
this is a syntax error. email cannot be set after the class declaration.
This is the only piece that I changed that breaks backward compatibility.  It was necessary for us to deprecate the parameter.
Fixed up in e9faff7f
Why not put "all << {:value => v[1], :label => v[0]}" here?
Пиздец.
I often like the extra named variable before a return so when I encounter problems down the road I can %debug and get in there and explore more efficiently.
I don't exactly get what the spec should be about.
Whitespace/EOL change?
would be nice to have this merged in sooner rather than later so we can use mocks for all tests this way
The same as the previous NPE comment
ok; good
the log path under ... ?
This line screws up the looks. The website looks fine if you comment it out.
Please remove the space after the opening (. Also please move the && operator to the next line.
Probably ZendService should have his own index or something
it was printing an extra nil at the end of the line b/c the line numbers related to the sections were not being recalculated. which resulted in an extra newline. I was not sure if there was something that I should have been calling to recalculate the line numbers.
I've set it on the `_commonInit` method https://github.com/moneytree/Long-Weekend-Dev-Tools/pull/12/files#L2R409
no need for additional test class, unless you want to do something special
for me, yes. Let's see what @rande prefers
This will only show the last character (`3` instead of `43`). Update it to `"^.+\t([\d]+)\%"`
One empty line here in between.
This doesn't actually change the settlement level. THis only notifiesthe player about a level upgrade. Also some other classes will think the level was updated. I think you need to update the settler.level variable and use the appropriate functions here to level up.
1 possible solution is taking the orientation  of statusbar
Shame on me! I'm alredy sharpening my knife for harakiri.
@mandrews makes sense.
це в основний репо livestreet. зробити можливість в тесті задавати тривалість затримки. тобто ```I wait 5000``` чи щось таке
we are not really sure why we are raising the error here
remove this alert
Уже работает в Digital October
For ios6 local backups we also want to restore from Backups dir -- but we don't need to do that here, since the plugin will do that itself.
The `jsonOptions` instance variable hasn't been declared anywhere
Spaces around `=>` are missing.
this change should be removed, I think...
Well that would be interesting since both APE and JTA are running fine on GF Embedded with RemoteExtension mechanism.
Do we actually need all this stuff? A lot should already be implied since we have browser set to true.
Sorry, my mistake you do have the show there...what is daniel craig for then?
wiec priceList ma by list elementw skadajcych si z produktu i ceny?

W dniu 11 marca 2012 14:21 uytkownik Przemysaw Lewandowski <
reply@reply.github.com
> napisa:

> >          }
> > +
> > +        public decimal CashEquivalent
> > +        {
> > +            get { return _cashEquivalent; }
> > +            set { _cashEquivalent = value; }
> > +        }
> > +        public string Name
> > +        {
> > +            get { return _name; }
> > +        }
> > +
> > +        private decimal _cashEquivalent;
>
> Czemu towar ma cen? Chyba, e w kadym miecie cena jest taka sama.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/PrzemyslawLewandowski/Merkantyliusz-barterowy/pull/19/files#r543375
>
Debug regel voor je deviaton die uninitialized was. Moet dit nog blijven?
I don't like how you get a WebView (instantiated) object back. In my opinion,. `createWebview` should return (something like) an ID. With that ID, you use the module's API to manipulate webviews. This is simpler, more functional, and more succinct because the public API of the WebView class and the this module are in the same place.
Should not be a good idea to make camelize function know the "-" and consider like "_" ?