labofsahil/github-event-dataset-2012 huggingface dataset:
Is the patch necessary? Why did upstream reject it?

Frankly, if upstream is interested in distributing their software on OS X, so much so that the developer is also the originator of the formula,  then I would think they would be interested in patches to make it work better.

IOW, it's not our job to maintain things like this.
I don't see how this will fly. Wasn't your point that you wanted an application executor?
What do you suggest doing here? Is the NaT value fixed at INT64_MIN? This doesn't work right in NumPy 1.6.1
Hmm ist diese darstellung noch uebersichtlich bei mehrdimensionalen arrays?
ok :) i though about what exception to be used too
Just a naming nit: `js` sounds like "JavaScript". Maybe `json` or `data`?
_on_
Comment below suggests the type is not actually string.  (Ditto for the other two search plugins).
Should have seen this sooner, but do we need a completely separate module anymore? htmlContentLoad.js won't be reused anywhere else. It seems like we could inline the ``Mustache.render()`` call inside ``_onReady()`` in brackets.js.
Would it be possible to set the cursor back to the position it was in _before_ the find dialog was opened? As implemented here, the cursor is placed after the last successful match, which could be a different scroll position from when the dialog was opened.

Here is an example: I'm in FileSyncManager.js, in the findExternalChanges() function. I want to see if getFocusedEditor() is called anywhere in the file, so I do Cmd-F, type "getFo" and see that nothing is selected. After dismissing the Find dialog, the cursor is positioned in getFileString() and the editor has been scrolled away from its original position.
@tvoliter: I was going to suggest using `getMenuItem()` here, but it seems to still require the caller to do this concatenation.  It's a public API, though, so I'm wondering if maybe it should change so that callers don't need to know about the parent Menu's internal id?
Good catch--this case is actually broken.
But ditto with these tests -- they probably shouldn't share the same context menu.
Editor.getSelection() doesn't take any arguments -- the "false" has no effect here
I'm not sure how I feel about this automatic option. It seems that if you want to sort MRU, you would always expect the next opened document to be first in the working set. Can you give an example of when you wouldn't want automatic enabled?

Also, if automatic is not available (e.g. for type and name sorts), we should also disabled the automatic menu item.
That would indeed be a much cleaner solution.
It should just remove those lines regarding saving the old dispatch table. Since it's stored in ETS now, and not the application_controller, it will be cleared automatically when riak_api shuts down.
why not [`String#chomp`](http://www.ruby-doc.org/core-1.9.3/String.html#method-i-chomp)?
I have just added a comment.
Let's make the calling syntax `init_for('dev')`. This makes it clear it's different from `init_app` elsewhere.
What you want is compare with hours and minutes if the `value` is type of `datetime.datetime` and compare days, months, etc, if the `value`is type of `datetime.date`?
See examples for default attribute, of course. The one with lambda function. Do you know lambda function?
Good, but you have to throw relation database configuration out. Only then we will be sure that we are not using it somewhere.
Sorry for derail :). My mistake.
Remove this request processing. So argument and this line. Just return `settings.LANGUAGE_CODE`.
Were these migrators forgotten?
For 0.5.x there isn't, no.  For 0.6 we probably want to see what Bobby does with editors, since there are tickets to allow editors to work with Butter objects, methods, etc.
We need to file a bug to ensure that we sanitize user input. (By we, I mean you :P)
Identation for these two lines are off.
Well, strictly speaking, we could just write it all out in javascript, but I'd rather not. This is really an example of how to use this system for building more complex editors that do require an html layout to be loaded.
Well, I would have to restructure it to add another div so that it could be outside the primary input wrapper
nit: change 'reader' to 'viewer'
I think keeping it where it is is fine (without throwing in lint target). Also @arturadib might have some thoughts.
It feels like we're potentially triggering a lot of repaints with this code - can we make it less repainty? Hide the list, do the show/hides then show it after everything is done?
Sounds good, I just committed a change that does this exactly. Have a look.
can we change this to a more general purpose name: `render_body`
I think this will do it. A pragmatic solution :-)
这句注释修正下语法错误和拼写错误。
isActived
Is 'path' just the url part or does it include the server? If server, then a server named sam_i_am could not run katello?
Should 'headpin' be in this if/else somewhere too?
Then change all `action.Parameters.Count()` to action.Parameters.Count
Again, my goal was to try to determine the state of the phone just by inspecting the DOM, and not relying on the JS implementation details.  Of course, I'm still relying on the document structure details, element ids, and even CSS styles, but it seems less brittle this way than relying on the JS details.
Sorry for not responding earlier Vivian,
We could just include the output of the fallback json file in git and remove the makefile target?
When we make changes to the manifests we could just run the script in tools to regenerate it.
This is admittedly a little confusing.  As I understand it this is not hiding the fixture function; instead there is some pytest magic which notices that the method argument has the same name as a fixture function and then replaces the `Column` ref in the test method with the iterated output of the `Column` fixture function.

I was trying to minimize the diffs with the original test modules by not changing `Column` to `ColumnClass` everywhere.  Do you think that is worth doing?
是可以，只是觉得稍微有点怪。毕竟还是两个层。
Curious...since you are already using ETS for local supported does it make sense to also put this there?
`failurest`? Is this a typo for `failure set`?
Ok, makes sense. I don't really like the idea of introducing dead code in
the core though just in case it is useful later (especially as it is just a
wrapper around the ui interface). We should try to at least use it
somewhere. Shouldn't be hard if there is a clear use case. I can't think of
one right now. Issues that arise during initialization are either:
- fatal: modal dialog and exit
- important warning that requires immediate attention: modal dialog and
proceed
- warning affecting usage of the program, ie upgrade alerts: persistent
warning in status bar

Transient notifications are most useful for events that are signaled to the
user but do not require immediate attention. I don't see any of those
arising in init (but maybe you do?).
True, this is done because CaughtUp is used extensively in other branches/pull requests and doing this at this stage i think helps things to merge easier.

Sent from my Nokia phone
-----Original Message-----
From: Philip Kaufmann
Sent:  17/05/2012 16:29:07
Subject:  Re: [bitcoin] Parallel block download (#1326)

> @@ -925,6 +927,12 @@ int GetNumBlocksOfPeers()
>      return std::max(cPeerBlockCounts.median(), Checkpoints::GetTotalBlocksEstimate());
>  }
>  
> +bool CaughtUp()

You could use just: <pre>return (nBestHeight >= GetNumBlocksOfPeers());</pre> or even just use <pre>(nBestHeight >= GetNumBlocksOfPeers())</pre> directly, as you currently use <pre>CaughtUp()</pre> only once.

---
Reply to this email directly or view it on GitHub:
https://github.com/bitcoin/bitcoin/pull/1326/files#r839013
Woops, force of habit :) , i'll fix that
……用异步。不要用wait。
简单的办法包括setEnable false之类的。
no need for ``@static``. The code already tell us it is static
Since we could receive data from `stderr` more than once, this should be appending to an error string, we should only be calling `fn` in the `exit` event.

See the `exit` and `stderr` events for `encrypt()`: https://github.com/joshuairl/node-gpg/blob/247fad1906dbacf0fb303145605ac6c22f5b5762/lib/gpg.js#L128
Should we add the 'name' attribute here, as a convenience? Might take a second run to populate it, but I expect that if we don't put it here, it will almost always end up being called in our calling code. Perhaps add it as an optional flag?
yes, very copy+paste, sorry. fixed.
Was this intentional? Or it was a mistake while replacing `test` with `conform`?
My flots aren't being updated when I run the actual rt run. I'm not even seeing the ajax calls in the terminal like I see for the other plots. What is $(placeholder) ? And why does placeholder get a $ but active_url and reference_url don't? They are all outputs of getFlotInfo right?
TfsLabel is just a data transfer object, so drop ITfsLabel.
Extra newline not needed here
逻辑错误，这样会切换greenlet三次。和 poll 一样，select 是在监视的事件中有任何一个发生就会返回
>Is this on purpose?

I was trying to mimic the way `git branch` works. From what I've seen symrefs are not returned. Am I wrong?
What do you mean running threaded? Building the library with threading on>
result = Compiler.Report.ShowMesage ... AndAlso result
Please remove the content of the `alt` attribute, it is redondant with the title. (remark 1)
@pmclanahan I had it like that  before but was told that if it is not going to be l10n'd for version 1, then I should leave it off, so I removed it.
Why `Sign up`? AFAICT, this is just sending an email, not signing you up to a mailing list.

`Submit` might not be the best action term, but `Sign up` is misleading. So either
I'd probably break this out into a separate test. Create a regular user, create some questions, see if it's counted, then change the user to inactive and see if it's no longer counted. That sort of thing.
What do I have to do to be able to see this?
Since the test is never supposed to call this callback, you don't need to set and check `pingback_timeout`; just call `test.fail()` instead of `test.pass()` at this point.
function后应该有一个空格的。
Fixed with #128
@pborreli Whys is these lines removed?
You need to bump the Twig requirement to 1.9.1 as this class was buggy before (wrong parent class when copy-pasting the Twig_Filter_Node)
Hm, I'd rather leave it like that, in case someone tries to access the type in "widget_attributes".
I am not saying it is a PSR or coding style. But i guess if you ack on integer instead of int, you find a lot more entries on it.
you should not typehint the class IMO as it means it is broken when someone replaces the router by composition (BeSimpleI18nRoutingBundle does it)
Thus, it makes it impossible to use this listener in Silex (which has a matcher and a generator but no router)
As said in the PSR, there is no hard limite for the line length, so the previous version was compliant.
There is an issue here. What if I call the `setHint()` method more than once? You should keep the original message. And when you call it with `null`, you need to revert to the original message.
but it isn't an internal server error, which is what a 500 response indicates to my knowledge. Whenever I've seen an 500 error, it typically indicates some kind of server fault.

Is there a precedent for this, or a reason I should change it? I could send a 500, but would the interpretation of it in the javascript code be any less arbitrary than receiving a 1 or a 0? I've looked through a few of the controllers and I don't see error being used much -- if at all.
checkInToVenue:(CPVenue*)venue 
see comment below
quote ha chera yadet rafte ?
This line should be left.
cleanup please.
We need to keep that LANG=POSIX set in the environment, otherwise it'll break in some non-US locales (e.g. Norway).
this bit really shows how cool markdown is
This exception's message should include the message from the original exception and the original exception's class name, otherwise there's no good way to debug any issues.
Confirmed that it works even "When Charlie's hand contains Gold x5 / And Charlie's deck contains Silver x5". 

Hm, maybe it's like this. At Play Actions, I store the cards in /hand/. After "stops buying cards", we proceed straight to "and the game checks actions", which means the cards in hand have made their way into the discard pile - some of them (Estates) straight there, others (Copper) via being played and then cleaned up. Which is where `#{current_name} should have discarded #{player_hand}` expects them to be.

If anything the assertion should come after "stops playing actions / and the game checks actions", because that's when the treasures are moved.
It is more efficient to iterate over the items() than to iterate over just the keys and then fetch each item separately. 

for name, value in payload.items():
   ...
This leaves us with a trailing comma. Though the package.json is not a big deal, we should fix this.
`toArray` will create an instance of Array, which may not be what the original was.
Missing space here
If this LDAP server fails to shut down will it have an impact on any other tests that also make use of it?  If there is any risk of subsequent impact I think the exception should be thrown and allow the test to fail instead of this catch log and drop.

The reason I say this is that I have been caught out by this style of tearDown in the security tests before - a test was failing in it's clean up a subsequent test was failing it's initialization but in both places the failure was logged and dropped - this means that when you do see a test failure the failure is not reported in the location actually experiencing a problem.
We very rarely check `!== undefined`, can't this just be `!= null`?
See above code, use `this`, not `that`; also spacing
понял, переделаю.
The pending symbols list is complicated here, as we have to highlight part of its symbols with 4 different color indicating 4 input states.  Which will be better to change the interface from `function km_showPendingSymbols(symbols) ` to `function km_showPendingSymbols(symbols, highlightStart, highlightEnd, foreColor, bgColor)`, or allow displaying HTML content for compatibility with jspinyin and jszhuyin?
goPrevious and same as above.
The `mozContacts.find` is doing way more magic than that...
This is not a solution.

Ping @gregorwagner , we need to know on which number the find request did match. How can we do that?
If not, what kind of sanitization we should do in order to be sure to find it here?
nit: miss a space
then DEBUG mode should be configurable in an external JSON file for the app. We can have a JSON config file as in other apps.
Plz change timer_id to camel case.
hardcoded values? what are they based on? what happens if size is changed?
I was afraid that when the metadata parser failed to load the image which embedded in audio files, thumbnail maybe undefined because of a broken image, but this might happen very rare.
So combine these two will be a good idea since, if thumbnail is undefined, visually we will still see the default cover.
I have a doubt but I don't want to block on that. Let's fix the small nits I said and we will land it.
+1. Fixed!
Is this function really called in any place?
`// Turn on airplane mode`
Noted the hack (I agree its ugly and confusing) I will upstream a fix to caldav.js. For now I noted that it will be removed soon. (Hopefully thats ok?)
Would .Any() work here?
> Is there a reason why QColorDialog::DontUseNativeDialog is removed when there is a note to saying it should be used?

Where? AFAICS it wasn't removed.
This bit was interesting. Could use some test cases to make sure this is the desired behavior.
we should conditional provide the name of the module for when people output multiple definitions to a single file
I think that you are missing ```":" + CLASSPATH``` at the end of this line.
we may want to switch to logging earlier than late... but happy if we add a task to our checklist for release 1
Please set errno before returning -1.
Was this deprecation message lost in the move to `parse_security_group_options`?
(1) It's the UserAppServer, not the 'users/app server', and (2) it's an IP where a UserAppServer can be found, as there can be more than one.
Why is this different from the __ version? Why not just merge them?
Remind the caller what a Kind is.
Looks like an unused import. Did you plan on logging anything, or was this for personal debugging?
file provider.
Well, is there a sensible default for `branch`? If there isn't, perhaps defaultBranch needs to be mandatory, if baseURL is used. In any case, we can perhaps just use `branch`, instead of updating `self.branch`, since the only use is in this method, anyway.
My python is weak. Does that work when
      initializing the variable for the first time?
      On 2012-09-27 13:40, Tom Prince wrote:
    
      In master/buildbot/steps/vstudio.py:
      > @@ -357,3 +360,33 @@ class VC10(VC9):
>      default_installdir = 'C:\\Program Files\\Microsoft Visual Studio 10.0'
>  
>  VS2010 = VC10
> +
> +class MsBuild(VC10):
> +    def setupEnvironment(self, cmd):
> +        VisualStudio.setupEnvironment(self, cmd)
> +        cmd.args['env']['VCENV_BAT'] = "\"${VS110COMNTOOLS}..\\..\\VC\\vcvarsall.bat\""
> +
> +    def describe(self, done=False):
> +        s = "building "
> +        if done:
> +            s = "built "

      This would make more sense as
      
        if done:
    s = "built "
else:
   s = "building "

      
      
        —
        Reply to this email directly or view
          it on GitHub.
Because they are used in static method convertPackage(). Why is this method static? Don't know :) It was more clear for me to have such util method as static with cached dumper and loader.
rollback responsive to old version
Team module is a singular role. In our case its easier to make a method in Group model like `add_users_to_projects`
yep will do that.
pos most definitely is used.
Why is `noodp` the default?

Settings is already imported here, something like
```python
response['x-robots-tag'] = getattr(settings, 'X_ROBOTS_DEFAULT', 'noodp')
```
would be better, but we still need, at least in the docstring, more of a justification for why it's `noodp` and not something more common like `noindex`.

(Yes, you can make an argument that `FrameOptionsHeader` should do the same thing, but in that case I think `DENY` is a much clearer default--though adding a setting wouldn't be the end of the world if you wanted to file a new issue for that.)

Also, note how `FrameOptionsHeader` allows a decorator to exempt a particular view by checking for `request.no_frame_options` (which should probably be `_no_frame_options` but whatever). That's a model we should follow here.
some kind of moseba sodah :)
use 
video = current_user.videos.find
video.survey_sections.create
I can specify that in comments if you think that helps.
ok, third times the charm, then I shut up.  Being a crypto idiot, this coule be the exponent of the payload, it could be an expiration date.  Now I'm done harping on this.
This is a great point. Is there an existing qunit or vows test, where we can test this?

Also [BigTent Issue #34](https://github.com/mozilla/browserid-bigtent/issues/34) was declared a blocker yesterday and relates to this addresses.
Gist: BigTent will chain it's certs with a BrowserID signed cert. Without this, bigtent would bleed into the protocol during verification.
Did you consider looking for the email address in storage? If they do "own" it, then it would be present, right?

The root cause is vouching for addresses which we don't yet control.
Wait, do you want to compute d' with sample values (`pos` and `neg`) or with `y_pred` and `y_true`?

I think the primary use of `dprime()` would be for classifier outputs: as `y_pred` and `y_true` would be already available from the classification result.

And I think the primary use of `dprime_samp()` would be computing d' with raw neural outputs or human subject magnitude data.  (e.g., computing d' for one neuron, based on its firing rate when a face is presented vs blank is presented.)


Well, now it seems to me that we need both for usability.
I added a support for confusion matrices in `accuracy()` as in `dprime()`.   There are some changes/rearrangements, so might be good to take a look at the whole code.
mmh I think this constructor is useless.. regarding the previous lines
missing phpDoc
This chunk is bad; we should exec rather than use system here.
I'm curious why you decided to extract "X-Riak-Meta" entries from the MD, and then further extract "X-Riak-Meta-yz-tags" in a second pass, rather than just have get_user_meta pull "X-Riak-Meta-yz-tags"?
I think we should remove all grunt reference from the Generator system. We don't need it and it has only caused us problems. I'd rather see us just a the arg parser directly. What do you think?
Question: What would be the suggested approach? lowercase? UPPERCASE? (reading below, `utf-8` is lower)
Why not use typehinting in the constructor argument?
If these won't be used, remove them.
So, in discussing this with @pmjones, the line should likely look like this to be PSR-2 correct:

    if (false === (include $zfLibraryPath . '/Zend/Loader/StandardAutoloader.php')) {
yes, mismatched parameter, fixed
I mean, a separate pull request.
These 2 loops is the first time I see you not care about hasOwnProperty. Any reason for this?
Should be all set -- connector registration happens in start() now
Yoda conditions?
Improving the ORM exceptions is in the roadmap. Currently, they all extend from the ORMException class, which should probably be changed to an interface instead to be able to extend from other exceptions too
this method was previously unused
sorry, and now i also understand why this line is a bit different. again fine to keep setting `true` here
great idea, slightly adjusted to keep them small:
```ruby
link.gsub(/\Ahttps?:\/\/(www.)?/, '').gsub(/\/.*/, '')
```
you can probably chain the lookup on context['articles'] and context['pages'] and then iterate only once.
I could revert this, but I was not sure, if this would be "normal" (Sf2 one) this would finish with fatal error...
"...the >>>are<<< added to..."
I don't think you need a colon here - that's a formatting decision that should be left to the renderer of the Rd file.
arr = new
Please take a  look at the base.py file  where both functions are defined.
Why this change? It's a no-op. Try to avoid leaving unrelated changes in pull requests. If you want to clean up style related to the code you changed, leaving a second "style fixes" commit is best.
why did we add this comment?
s/wrap's/wraps/
Yes indeed, is a typo. Thanks @pitr-ch
Okay, I do this in lib/fog_extensions/openstack then.
Since ```"Spotlight"``` isn't a regexp, this should be ```mediaType.indexOf("Spotlight") !== -1```.
I suppose they could be, and the link still works for me as well. I suppose we can just let this be and not worry about the fact it appears to be proxied.
Ah, I didn't realize that.  I updated the minVersion in the new commit to 2.1.9.
I see now!
Oohhhh. This looks really nice.
Because of the `KhanUtil.randRangeExclude(min, max, [target])` which basically says "give me a number between 5 and 5 that isn't 5"
New Function written which accepts (typeof,...) so that the sort param doesn't have to be checked for. Function will only return files or dirs based upon typeof. Much smaller footprint aswell, aswell as local vars.
Taken into account in 7965ebbf681204ccb12300277840b217b6419c0c
Бывает. state спрятано внутри класса, поэтому connect вызывается последовательно ото всех вершин.
are we not allowed to use the OO principal of overwriting a method in the parent class if it doesn't work for us?
This is the only comment in this header that told me anything. I personally dislike comments that just paraphrase code.
I will use Assert.contains
It's just me cleaning up after myself, but they don't strictly need to be removed. I'll remove this logic.
What about:

```
if (ctx.user() && ctx.user().isAdmin(tenantAlias)) {
    return callback(null, cachedConfig[tenantAlias]);
}

callback(null, cachedConfigSuppressed[tenantAlias]);
```

as it eliminates the need for an extra variable.
Is doing `log().` necessary? In the documentation, they just do 

```
log.info('hi');
```
Comments should be on 1 line.
Or maybe not, I'm not covinced... let's see what you guys think, I have mixed feelings :-)
Ch. 6 vii
Don't see the point of this, unless you're going to check count is valid (i.e. not -1 = error). It equates to the same code.
whitespace needed after .desc }
please remove the old code instead of commenting it (and it is indeed not needed)
Yes, I switched my app back to the posgre driver to discover I couldn't
connect. I got an error about something like "localhostusername=user", so I
looked at the documentation, which says "user", not username, and corrected
the space.

- Timothy J. Warren
http://timshomepage.net
tim@timshomepage.net


On Tue, Apr 3, 2012 at 1:36 PM, Andrey Andreev <
reply@reply.github.com
> wrote:

> > @@ -89,7 +89,7 @@ public function __construct($params)
> >
> >               if ($this->username !== '')
> >               {
> > -                     $this->dsn .= 'username='.$this->username.' ';
> > +                     $this->dsn .= ' user='.$this->username.' ';
>
> They are indeed, and I've tried appending instead of prepending them while
> building the connection string.
> Now that I look at it - there's a number of other issues, which leads me
> to this question - have you actually tested it? Cause I'm sure I've read
> about all the valid parameters in order to do that whole thing.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/EllisLab/CodeIgniter/pull/1240/files#r640533
>
Два замечания: в принципе, геттеры принято называть по названию переменной, которую они должны возвращать. В вашем случае - геттер стоило бы назвать не getDNA, а просто DNA. Так же обратите внимание, что вы возвращаете ссылку на изменяемый объект. То есть, несмотря на то, что это геттер, полученное значение я смогу изменить, и оно изменится в классе,

Чтобы этого избежать, нужно возвращать (NSArray *) - это неизменяемый массив, и он родитель класса NSMutableArray.
если их длина различно то на мой взгляд разницу тоже стоит занести в переменную "count"
Зачем? Если на выходе у нас один конкретный класс, который будет иметь только то состояние, которое ему задано: у него есть возможные варианты значений в ячейке, он имеет определённую длину, умеет считать Хэммингово число и изменять себя по заданному проценту. Это вполне себе самостоятельный и полноценный класс. Для учебных целей, разумеется. В данном случае даже при применении "бизнес смысла" плодить сущности не имеет смысла.
Честно говоря, я и записался на этот курс, чтобы разобраться с такими неочивидными для меня вещами, как модификаторы доступа и различными из вариациями, так как после java и других языков, Objective-C-шные немного для меня непривычны. 
Собственно, правильнее тогда, как вы и сказали убрать определение из @interface, а вреализации класса поменять модификатор с "-" на "+" и обращаться к методу через имя класса.
Дада, я понял косяк с выводом, чтобы проверить. Мне стыдно :)
Понимаю, что может выпасть один и тот же индекс, что уменьшает количество замененных элементов. Решил, что надо сделать метод, который будет всегда возвращать только новый индекс элемента на замену. Столкнулся с тем, что в категории нельзя добавить к классу новых свойств. Пробовал категорию без имени

@interface Cell ()
@property NSMutableArray *idx;
@end

(в файле cell+mutate.h)

Компилятор это хавает, появляется свойство self.idx - хорошо, но как мне его наполнить значениями, чтобы использовать в качестве индексов? Этот массив хочет принимать только (id) ..

Я хочу так сделать, только потому, что есть метод [NSMutableArray containsObject:(id)] чтобы проверять существует ли уже такой индекс в массиве.
I kind of think this is a github issue
Michael Ing

Sent from a small keyboard device

-----Original Message-----
From: kiramccoan <notifications@github.com>
Date: Tue, 16 Oct 2012 15:37:02 
To: MarkUsProject/Markus<Markus@noreply.github.com>
Reply-To: MarkUsProject/Markus <reply@reply.github.com>
Cc: Michael Ing<mikeing2001@hotmail.com>
Subject: Re: [Markus] Issue883: warning should show up if grader or group is
 not selected on global action (#884)

> @@ -50,7 +50,7 @@ see http://www.markusproject.org/download/
>          - mod_rewrite
>          - mod_dav_svn (required if you want to allow SVN repository access)
>          - mod_authz_svn (required if you want to allow SVN repository access)
> -    * ImageMagick (known to work with >=6.5.7, older versions should be ok too)
> +    * Ghostscript (known to work with >=9.05, older versions should be ok too)

Hmm.. this is very weird. My local one did not have all these changes. I may will probably delete this branch and create a new pull request since I dont know how to fix this

---
Reply to this email directly or view it on GitHub:
https://github.com/MarkUsProject/Markus/pull/884/files#r1861045
This has been removed from my repo.

I followed the instructions at http://stackoverflow.com/questions/448919/how-can-i-remove-a-commit-on-github

`git rebase` is a glorious thing
Me neither, currently we do not have a model that fits the /:channel endpoint. The idea is use this until we do a refactoring to create an util class that would make those types of calls for us.
Do we need to do this each frame?
But then Response#url may not return a String which sucks. What about:

```Ruby

    def url
      @response['_links']['self']['href']
    end
    def has_url?
      !!(@response && @response['_links'] && @response['_links']['self'] && url)
    end

```
this might be a lot simpler as ``demo.orientation = ...``
There's probably a better way to document this. Also, we should probably stick to one style of comment within functions.
Can you put a README in this directory saying that they're really insecure, throwaway certs and not to re-use them?
Sorry, I thought it would be for me by Jorg, it will be put in again
@marc1s You’re right, nice catch! The lists I used were not human readable. A (hopefully) better fix will follow in a few minutes.
in-place only if copy=False right?
or not, doctest is failing for a different reason there, still investigating
how about spectral_connectivity? just throwing ideas...
i was checking how to know the attributes of a JavaScript object , i forgot to delete it
i will make this clear
Shouldn't the operator be  &&  instead of ||
Meh... putting on the todo list...
Inconsistent indent, also in a few more places
Why the uppercase?
Can we put book titles in quotes? Just need to scape like so

```json
"title": "Read 37 Signal's \"Getting Real\"."
```
We can't name it `delete` because delete is a reserved word in JavaScript. This breaks in some browsers.

https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Reserved_Words
This println should probably go away
Can you perhaps add some comments explaining how this logic works?
OK, it becomes

```
prec = int_tested(prec)
if not p.has(var):
        return p
```
Because it needs to be safe, but will change this in refactor of register unregister activation for both producers and consumers.
page_cache_lifetime variable isn't anywhere in pressflow code.
Actually, the whole routine can be replaced if you use Mul.make_args:

```python
d=sift(Mul.make_args(eq), lambda w: \
    w.is_Pow and w.base == x and w.exp.is_integer and w.exp.is_negative)
rest = Mul(*d[False])
pw = Add(*[p.exp for p in d[True]])
```
ок

2012/5/7 Georg Rudoy <
reply@reply.github.com
>

> > +     ${MOC_SRCS}
> > +     ${FORMS_HEADERS}
> > +     ${RCCS}
> > +     )
> > +
> > +TARGET_LINK_LIBRARIES (leechcraft_blogique
> > +     ${QT_LIBRARIES}
> > +     ${LEECHCRAFT_LIBRARIES}
> > +     )
> > +
> > +INSTALL (TARGETS leechcraft_blogique DESTINATION ${LC_PLUGINS_DEST})
> > +INSTALL (FILES blogiquesettings.xml DESTINATION ${LC_SETTINGS_DEST})
> > +
> > +SET (BLOGIQUE_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
> > +
> > +OPTION (ENABLE_BLOGIQUE_METIDA "Build Metida, LiveJournal blogging
> platform support for Blogique" OFF)
>
> Вот весь плагин и офф, а сабплагины вполне можно включать.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/0xd34df00d/leechcraft/pull/113/files#r780373
>
Я не буду убирать lang="en". Я к ним привык и они у меня везде. Стиль, еба.
В смысле, там может быть мусорка?
Could be moved lower down.
```
-  if (sym->Sdt && DECL_INITIAL (t) == NULL_TREE)
-    DECL_INITIAL (t) = dt2tree (sym->Sdt);
+  if (sym->Sdt)
+    {
+      if (!COMPLETE_TYPE_P (TREE_TYPE (t)))
+        {
+          size_t fsize = dt_size (sym->Sdt);
+          TYPE_SIZE (TREE_TYPE (t)) = bitsize_int (fsize * BITS_PER_UNIT);
+          TYPE_SIZE_UNIT (TREE_TYPE (t)) = size_int (fsize);
+        }
+
+      if (DECL_INITIAL (t) == NULL_TREE)
+        DECL_INITIAL (t) = dt2tree (sym->Sdt);
+    }
```
relayout_decl takes care of DECL_SIZE, so you don't have to worry about that here.
you did not understood what I wrote. I told you there's no need to localize exception message.

You can refactor this 10 lines in 4 lines
can stay on one line
come get a preview of what __it__ looks like
I see. So you're trying to make readers wait on writers if there are any. That sounds reasonable.

However, why not just use a shared_ptr and copy that around instead? That way you don't have to lock when you're changing the shared_ptr as .reset() is guaranteed to be race-free.
I could, but isn't the code a bit more readable with them there?  Before, it was one huge block without any whitespace, while the rest of the file (and most other files) had a blank line before each logical grouping of functionality.

If you really want them gone, I'll do it though.  Just re-confirm.  :)
thats probably a better idea overall.
Since we don't use the Future returned by submit(), I think there's no point in re-throwing the exception. We do need a cancelling mechanism instead, perhaps just broadcasting a new CH update with the old topology, but a TODO should suffice for now.
Why "activate" here?  A CacheStore.remove() may be cheaper.
why are you involving the Doctrine DataFixtures library here ? It has nothing to do with Assetic
We should make this a property, and could we rename this to `is_wifi_connected` with an optional ssid argument? Then if the SSID is provided (by the test) it will ensure that the correct network is connected.
Вот это лишнее, да.
the exception is not thrown anymore
I think @sersut was able to do this using WMI. Any reason to prefer powershell?
Yeah, was trying to keep storage down. Do longs actually take up more space when serialized with thrift?


On May 8, 2012, at 7:45 PM, Sam Ritchie <reply@reply.github.com> wrote:

>> @@ -30,18 +30,26 @@ struct NeighborValue {
>> 
>> # Collection Wrappers
>> 
>> -struct DoubleArray {
>> -  1: list<double> doubles
>> +struct ShortArray {
>> +  1: list<i16> shorts
> 
> Hey, are we using shorts just to get the storage down? We're going to have to be careful with the casting, as Clojure defaults everything to longs.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/17/files#r793062
Can you fix the capitalization here?
To leave some work to do for you when merging ;-)
Yes, I'll fix.
This seems kind of arbitrary -- if there is 30% free space, why not try to compact regardless of the size?
Why are you using so many aliases?
Each alias cause a very small performance hit. When you hit about 40 aliases you start noticing singificant performance hit. Why? Because you are using twice the memory for each data and you also have the performance hit to allocate memory and the performance hit to copy the variable.

Why do you use aliases, anyway?
Are you sure ``1`` has the correct type as "integer" is not a sub-type of "string"?
``$model->addChild($result);`` seems not to be reachable. Are you sure this is correct?
Also, for next time: implemented, not implemeneted
what is this for?  it's certainly deserving of a comment.  I don't think is does what you intend it to.
what if the file does not exist ?
```js
src: [
	'<banner>',
	'css/_normalize.css',
	'css/_base.css',
	'css/_helpers.css',
	'css/_media.css'
],
```
?
I don't like this sub feature
This should actually look at the `:awards` of the book:
~~~clojure
(contains? (:awards book) award)
~~~
Just pure javascript, it so easy :)
Use JLogLogger (JLogger is deprecated)
haha I guess I was thinking there was going to be corrections :)
quick check whether this was correctly removed @matschaffer?
``` js
if (... /^#/.test(result)){
```

Not the lack of need for `.+` and removal of extra space after `) {`
Also I don't like wrapping an action and an assert inside one function. In this example it should be two steps inside the test itself (regardless of duplication). This is a test not software so the test should be kept clear and readable.
I'll defer that until we have at least 2 uses.
Please fix the coding standards:

- a space is missing after ``if``
- there is an extra brace after ``!``
- you should use curly braces
I also think it should remain restricted to the standard folders.
Forgot to remove it. :( I have added a new setting value "dns_tsig_realm"
Don't version the cache, logs, and stuff that may change from a computer to another.
OK. So TODO should be: Push new comments to all clients and display them automatically.

This is big enough that you could create also a new ticket for it.

We can decide later on how exactly to do it. I would probably do it in the same way as we are pushing posts.
Forget it. It is OK like this. We can define notifications as part of the API. Also expose notifications through RESTful API.
Div inside of span? This is not XHTML valid.
Good. Just make it the way you believe it is the best. Also decide for yourself about reset CSS. I have never used it myself. But maybe it is really a good practice.
I noticed now, PyCharm did the indetation, I changed only the 'footer_nav', added translation tags and moved them each to new line(I am just used to it, beacause it is easier to read, and as far as I know it does no harm). I will of course put it back and never do it again
You added some unnecessary space at the end of this line.
You should pass reference to the function, not function result. ;-)
OK, so this is strange. Splitting result from fetch into two parts would be interesting approach if it would make you not need to access elements manually here. It would be interesting because it would allow split of logic between fetch_data and this task definition. That this task definition would not need to know about which fields are there.

But how you defined it, this is not done so. So, you can do two things.

Simplify everything and access filed directly for query:

```
models.BicikeljStation.objects.get_or_create(station_id=station['station_id'], timestamp=station['timestamp], default=station)
```

Or live data split, but then do something like (untested):

```
models.BicikeljStation.objects.get_or_create(default=station[1], **station[0])
```
Space after `,`. Spaces around `+`. Add TODO that URL to author should not be hard-coded like this!
One empty line too much. :-)
Name function arguments the same as they are in jQuery documentation.
That's a good idea for fixing SourceDialogs.ycp as well :)
That's how I originally had it,  but then all comparisons in the chain 
are evaluated.

On 21/02/12 18:34, Joe Groff wrote:
>> @@ -247,6 +248,10 @@ inline overload greater?(a, b) = lesser?(b, a);
>>
>>   inline overload greaterEquals?(a, b) = not lesser?(a, b);
>>
>> +inline overload compare?(expr1, fn, expr2, ..args) : Bool
>> +    = if(not compare?(expr1, fn, expr2)) false else compare?(expr2, ..args);
> This could be simplified a bit to `fn(expr1, expr2) and compare?(expr2, ..args)`.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/227/files#r472392
The provided tests also passed with the .NET 3.5 version of NSubstitute 1.4.3.0.
Wouldn't [Convert.ChangeType](http://msdn.microsoft.com/en-us/library/ttf5d382.aspx) be a bit easier?
`homepage` should go above `url`. (We used to be inconsistent about that.)
This is seriously awesome work, and I think it would be great to have that in core vagrant.
These two imports should happen before our custom overrides. So please put them after converge-ui shell import.
Add `count: 2` to make sure there's only a single value.
b1eaabe
Where is the 'options'?
Why do some fields have comments and others dont ?
Yup Sounds good
No, just keep it like you have it here. `client.js` is old code and don't follow the style guide. We could clean it up in one go some time.
I guess this should have `+ GetDescender()` on the end?
Or a cop, or a defender, or a... ;)
in general we avoid this, if a attribute is used often, or if it's a basic attributes like exog, endog, then we usually assign a local shortcut.

Much of this part is missing pep-8 spaces afte comma
My guess is that we need to have a way to turn this off, a keyword argument?  (use_formula=True).

I don't know what dmatrix can do, but from my reading of SAS and Stata we need a possibility to feed a user defined exog for least-squares means or predictive margins even if a formula is used. (Assuming formulas cannot handle every case.)
[Updated](https://github.com/KL-7/twitter-cldr-rb/commit/7cc2f73977577f50ec0d5ffd15914c8ae40454de). Any reasons why you prefer `File.open`? I usually use `Kernel#open` because it's shorter and looks consistent with [opening remote resources](https://github.com/KL-7/twitter-cldr-rb/blob/master/spec/normalization/normalization_spec.rb#L101) through `open-uri`. One thing I don't like about it is that if you need to stub/mock it you have to stub/mock it on the current object, like it was [here](https://github.com/KL-7/twitter-cldr-rb/commit/7cc2f73977577f50ec0d5ffd15914c8ae40454de#L5L196) before. Using `File.open` definitely makes things clearer in that case.
выноси
Authentication is also a part of frontend, no?
Verbose names should be translatable strings!
This is basically a sanity check to make sure the smtp and imap settings we use can talk to a real mail server. If you want to run it you have to remove the ignore and put your real connection creds in the class.  it shouldn't run as part of the suite, however I think it's valuable to leave in the codebase. I can add a comment to this effect, what do you think?
Recommend this be final, and all constructors require it to be passed in.
Thanks for adding all that whitespace.  I can't read any code that isn't at least 7 lines apart.
I'm not sure what you mean here.  

Are you suggesting that the `type` names for `noise` should include "Deviate" as part of their name?  Or that BD3 should not use `noise.type = CCDNoise`?  Or that the comment would be made clearer using the "Deviate" terms?  (BD1 had `noise.type = Gaussian`.  BD2 had `noise.type = Poisson`.  So for those going through this as a tutorial, those are the names they know by this point.)
Done.  I just added the citation, not links.  Do you think that is sufficient?
I think I missed changing all of these.  Can do.
This is just an idea, but maybe combine the two versions of this method. And do they need to be public? It seems like they are internal helper methods.
Please jslint your changes.
Weird.

It works fine on http://demo.sparkdrupal.com/node/1 (login instructions at http://demo.sparkdrupal.com/): enable edit mode, click the body field, click the image, left align it, the "Save" button on the field will become blue because you've made a change. This is leveraging the `smartContentChanged` event of type `block-change`.

I'll try with latest `dev`, late today, else tomorrow.
These commented out calls to appendSslConfig: are they suggestions of future code improvements or things that have previously been tried and rejected? Suggest instead deleting commented out code and just having a TODO about possible improvement(s).
Not sure how easy to re-enable. The FIXME about quotes in object names explains the problem. It seems that our test MBServer connection behaves differently from that in the tomcat server for quotes. I'll need to re-run and code from before all these changes to figure out how that worked. I couldn't see anything I'd done differently. And I was testing the new stuff at the level of direct calls to the MBeanSerer with different ObjectName formats.

I'll look again, but don't want to hold up this pull request.
semantics of A.remove(X) is usually to remove X from A.  i've seen the past tense used with immutable pattern so followed it, it seems the most concise that i can find.
Can you add a comment that (like some of the other fields) it is up to the user of the item annotated SetFromFlag to consume this default value?
Yes. I was told that this is because of "grails magic" :)
Probably because I wasn't careful enough... Thanks for pointing that out :-)
Corrected in d039363d.
Here's a tweaked version which does away with `j` and `l`:

```javascript
_.chunk = function(array, n) {
  if (!_.isNumber(n) || n < 1 || !_.isArray(array)) return array;
  var i = Math.ceil(array.length / n), r = [];
  while (i--) r[i] = array.slice(i*n, n*(i+1));
  return r;
};
```
Same as [line 23](#L0R23).
@thecarlhall Indeed, it actually also fixes a bug. Even when the server was running, it said that the `pid` was no longer valid.
I update the PR
we could change `this.options` to `this._options` (or whatever) and use that instead of `.parsedOptions`
I think this is another case where we could just use `get` instead of `escape` (on the ID) since it's just a number.
@vicb: at the moment we need to support both keys the prefixed and unprefixed one. and just mark the unprefixed ones in the docs as deprecated.
Spacing is off with brackets on the `while` `if` and `if`
Yes, it has been dropped.
This would be better as:

> can be set set up manually, or you can use "provisioning" software such as "Puppet" or "Chef" to do this for you. Provisioning the base box is a great way to ensure that multiple boxes are set up in an identical fashion, and removes the need for you to maintain complicated "set up" command lists, or bablabla

Something like that. Puppet and Chef need to be explained a little, they also need to sound optional - but explain why they SHOULD be used.

Thanks for this, its a good section!
I think this used to create a deferred inside here. I took it out since I think it could only add variables to the test.
change this because the is_element_present disables explicit wait
The following section should be a table?
I don't know if there's a way to do that, you'd have to take a look in `Thor`. @rafaelfranca do you?
Зачем два одинаковых публичных метода?
I think we can simplify the logic here quite a bit, something like:

```
    args = [None, ntiles_x, ntiles_y, clip_limit * nbins, nbins]

    # handle color images - CLAHE accepts scalar images only
    if image.ndim > 2:
        lab_img = skimage.img_as_float(color.rgb2lab(image))
        args[0] = rescale_intensity(lab_img[..., 0],
                                    out_range=(0, NR_OF_GREY - 1))

        new_l = _clahe(*args)
        new_l = rescale_intensity(new_l, out_range=(0, 100))
        lab_img[:new_l.shape[0], :new_l.shape[1], 0] = new_l
        image = color.lab2rgb(lab_img)
    else:
        args[0] = rescale_intensity(image, out_range=(0, NR_OF_GREY - 1))
        out = _clahe(*args)
        image[:out.shape[0], :out.shape[1]] = out

    return image
```

I didn't test the example above or make sure that it handles all image types correctly, but something along those lines should work.
this should also go into modules/classes.rst
This is not tested either.
Sorry, I wasn't refereing to the ``abs`` but to the ``0``.
np.dot
Texans at Lions is at 12:30
would be nice to document that it actually returns the map of aliases
I suspect this would be much nicer as a switch.
Fixed the places above also.
Maybe, it was more a reference to the v8 ThrowException function, but this will change as I'll be moving to a files containing all message strings
Il y a surement moyen de factoriser ce code:
```
<a href="@doc.getRouteGénérationDocument())">Générer</a> |	
<a href="#test_modal" onClick="uploadFichier('@doc.getNomDocument()', @doc.get().numeroDoc)" data-toggle="modal">Uploader</a>
 @if(doc.get().cheminFichier != null && !doc.get().cheminFichier.equals("")) {
    <a href="@routes.Documents.telechargerDocEtude(doc.get().numeroDoc)">Télécharger</a>
}
```