labofsahil/github-event-dataset-2012 huggingface dataset:
Ну смотри - тебе нужно хранить инфу за каждый день. Деактивацией баннера будет заниматься крон. По большомй счету общее количество просмотров только крону и важно. Ну может быть ещё циферку в интерфейсе написать. Да, наверно стоит чтобы крон куда-то писал общее количество показов, типо кеша. Но нода не должна иметь к этому отношения
text is wrong: not a drug purchase order. this is a billing item
There is no need for that relationship to be captured in the ```self._hints``` explicitly.

The diff changes on <i>_merge.py, lines 1267 to 1280</i> impose a three way sort on the scalar coordinates.
 + first by hint, if applicable,
 + then by axis,
 + then by coordinate definition.

The fact that ```level_height``` is a vertical coordinate i.e. it has an axis of ```Z``` as derived by ```iris.util.guess_coord_axis()``` due to it having ```attributes['positive']``` and ```sigma``` is <b>not</b> a vertical coordinate automatically deals with this <i>level_height</i> over <i>sigma</i> relationship implicitly.
Trying to mimic the theano language used in terms like "broadcast pattern".
To get this PR merged the faster, I think we could postbone those change to another PR. There could be other speed optimization to change and I would prefer to don't wait on them. So reverting warranty we won't break them.
Well, if constant-folding is disabled, I think the optimization won't work.
Anyway, it is not complete yet (still work in progress), as I would like to support the case where labels.shape[0] is known to be constant, even if it is not 1. I'll update the comments accordingly at that point.
I'm thinking of replacing the code and comment with an assert that the EC is set up as expected (implying that we are on the thread that Ryan claims we should always be).
This test case should work (same as the replica + create comment above).
This is no longer needed if there's a `unique` on OperatingSystem.device.
a data zamowienia u dostawcy?
Я выше предложил, как сделать неупячечно
GOOD JOB !!!!
I bet the reason for this problem is that you are leaking tables into the test DB. You will need to drop the tables in teardown, and this problem should go away.
Why? This is only the tests, and we don't want any tables from the schema app in there when we're done.
Isn't that exactly what I did?
Why would we want our users to modify code? That's doesn't make any sense.

Additionally, this is not something that a user should be concerned with, in my opinion. I doubt I'm alone in this regard. At most, this could be a setting in the `openquake.cfg` (which is intended for sysadmins and such, not the end user).

How is the user supposed to choose whether they use the SimpleTaskHandler class or the CeleryTaskHandler class? Can you please point me to the place in the code which allows the user to select the task handler implementation? I haven't seen anything that exposes this functionality to the user; perhaps I missed something.
Missing semicolon, no big deal.
Thanks for the test case showing why we can't ignore spaces in the filter. I think this is ready after it's cleaned up a bit:
* The class doesn't need to be dynamic, you can use a `t12685`/`opacityTest`/etc.
* Provide descriptive messages for all assertions
* Replace `ok` with `equal` since we have expected values
* Take out the `.remove`s since QUnit cleans up the fixture at the end of each test
* Simplify by combining DOM manipulation

example:
```js
var fixture = jQuery("#qunit-fixture"),
    style = jQuery("<style>.opacityWithSpaces { opacity: 0.1; filter: alpha(opacity = 10); } .opacityNoSpaces { opacity: 0.2; filter: alpha(opacity=20); }</style>").appendTo( fixture ),
    el = jQuery("<div class='opacityWithSpaces'></div>").appendTo( fixture );

equal( Math.round( el.css("opacity") * 100 ), 10, "opacity from style sheet (filter:alpha with spaces)" );
el.addClass("opacityNoSpaces");
equal( Math.round( el.css("opacity") * 100 ), 20, "opacity from style sheet (filter:alpha without spaces)" );
el.css( "opacity", 0.3 );
equal( Math.round( el.css("opacity") * 100 ), 30, "override opacity" );
el.css( "opacity", "" );
equal( Math.round( el.css("opacity") * 100 ), 20, "remove opacity override" );
```
Cool. BTW, any reference that I can look up for these conventions?
This one line does bother me...  not sure if that is the correct thing to do here.
Maybe...  if the Shader is Dispose()d it is dead... so no one should be trying to use it.
Big +1 for this test!
Would we perhaps want to use `http_request_full` instead here so we can at least see if a request returned something other than something in the 200 range?
[docs](http://docs.cython.org/src/tutorial/strings.html) you're right.
but if date_cols[0] unicode with non-ascii codepoints then str() will blow up, 
so something needs to change.

if you work with bytes. you are inevitably assuming an encoding, utf-8 most likely.
calling c should probably be considered an "I/O point" where encoding/decoding 
takes place. of course that might hurt the performance benefits of using cython 
to begin with. but unless it's unconscionably terrible, I think that's the way to go.

another (not "correct") option is storing everything internally as utf-8, which can 
be made consistent. but then you would get things like #1292 happening again,
and I would guess Py3 support would become (even more) hellish.

is the c_parser branch stable enough to look at from a unicode perspective?
I am planning to use this config file for other tests too, so I will have something like this:

token-generation:
   admin_user: ..
   .
   .

sis:
  .
  .
  .
The BufferingTracer tests actually test more than the mixin tests.  They for example they actual assert that the arguments sub tracer is called with.  Which seemed to drastically complicate the mixin and provide little value.

Even though they do share a bit of code, I think the extra code to support asserting the specific arguments to the record function would greatly over complicate the standard tests and provide little value.

There are tests that BufferingTracer calls it's wrapped tracer with the proper traces when expected.
There are also tests for each of the Raw tracers that test that the scribe client and agent are used correctly.
The standard test mixin strictly that the most basic behavior expected by the composition chain is there.
imports should be organized per pep8: http://www.python.org/dev/peps/pep-0008/#imports

In order, separated by one blank line:
1. standard library imports
2. related third party imports
3. local application/library specific imports
I assigned get level to private explicitly because we don't know what code may follow from our controller_helper.rb - which has been included in application controller. Or can we rely on our Module scope and ActionController::Base.send :include, Ariane::ControllerHelper to keep our code separate?
Never change vibra to True during development. QML errors don't show if vibra is on
err yes, that's what I meant, sorry.. only had 4 hours of sleep last night
Ahh, I see. Thank you very much.
I think we should keep the function signature the same, ie `handler` instead of `originalHandler`. Looking at the API, you shouldn't have to mentally differentiate why they take different types of handlers, even though they don't. Let's just call the inner handler `handlerWrapper` or something like that.
This is a really slow way of iterating a map. You can do this instead:

```return new ArrayList<Player>(onlinePlayers.values());```
You're creating a bunch of global variables here.
This is an existing rule that I moved from brackets.less, unchanged.  I have no idea why `!important` is being used here but I'd rather not mess with it :-)  Fwiw, `!important` seems to be used a lot in the jsTree CSS styles :-(
Good point. I'll move this to KeyBindingManager.
p.s. Doing what I suggest would probably mean only the top half's code would be easily shareable with Replace, but that might not actually be a bad thing.  As it stands, it seems a teeny bit risky (or at least confusing) that we're now calling findNext() at the beginning of a Replace operation when we used to not call into any Find-related code from there at all.
Add ``brackets.app.language``, see prior comment about ``navigator.language``
Wouldn't this trigger the "panelResizeEnd" event if user only toggled panel display to ON? I would only expect this event after a drag/resize.
I think you could also just do `String(keycode - KeyEvent.DOM_VK_0)`
I did a little survey of other Windows editors, and they seem pretty darn inconsistent:
	Sublime:  Save ALL = (none);  Save AS = Ctrl+Shift+S
	Eclipse/Aptana:  Save ALL = Ctrl+Shift+S;  Save AS = (none)
	Visual Stdio: Save ALL = Ctrl+Shift+S;  Save AS = (none)
	Notepad:  Save ALL = (n/a);  Save AS = (none)
	NotePad++:  Save ALL = Ctrl+Shift+S;  Save AS = Ctrl+Alt+S
	Dreamweaver:  Save ALL = (none);  Save AS = Ctrl+Shift+S
	Photoshop: Save ALL = (n/a);  Save AS = Ctrl+Shift+S

So of the ones I looked at, Ctrl+Shift+S means "save all" in 3 tools, and it means "save as" in 3 other tools.  No other shortcut seems to be used to "save all" though -- all the apps that use Ctrl+Shift+S for "save as" don't have any shortcut for "save all."

Are there any other major data points to add?  Popular editors I've missed?

Ultimately the right solution for situations like this is to have user-configurable keyboard shortcuts.  We still have to pick a default though.  It seems like "save all" is a more common operation in web dev than "save as," so I think it "deserves" a shortcut slightly more... but it probably depends a lot on your workflow.
Could add another API to fetch the raw list, but then of course we'd miss any bugs that arise at an earlier stage (e.g. failing to load/parse the right list).  Also, for the filtered cases we'd either have to keep hardcoding it or write a second copy of the filtering logic in the unit test module...  Is it worth it?
@peterflynn No, the old $hintMenu will get removed the next time a code hint is shown, because hintList will be non-null at that point and `showHint()` will call its `close()` method.
I'd love to improve this.  Not sure how to make this logic more OO.  If we had multiple strategies for wrapping/initializing redis that would make sense.  Did you imagine multiple strategies and a config to toggle them?  ie: regular Redis.new, Redis::Namespace, and Redis::Retry?

Feel free to hit me up on GChat at winfield.peterson@gmail.com if it's easier to clarify.
Why is this called `location_`?
`{}` here please.
You mean default implementation does that?
Form? This is not userfriendly. Too generic.
Hate to be nit picky, but shouldn't we also be changing the height of these track events? It's definitely hard to see but it's causing the trackevent to be a little bit out of bounds of the track itself.

Probably should reduce the height by 2px, since padding: 1px will add be like padding-top: 1px and padding-bottom: 1px
No, since I don't use jquery internally.
I like `request` over `req`, mostly because I don't see the point in shorter variable names that make me think harder. But if this is generally how things are written I can deal.
agree, but it's also nice to see make.js pretty :) let's create Makefile later that will just map make.js targets to execute `make whatever` as `node make whatever`.
why is this one needed? the db should be open when the container has been opened
How about making the connection implement `PromisorInterface`, so it can return a promise that resolves as soon as the conn is established?
not necessary, `self.YOUTUBE_URL` or better `self.URL` should be sufficient.
TODO: Add the native python renderer. It seems omitted from this line.
Comment here describing what the expiresAt is seconds would be nice
Isn't this calling itself?
This form inherits the fields from the normal upload form, so ``xml_file`` is redundant here.
I love your thoroughness, you put my own code to shame :)
There's [an equivalent implementation](http://msdn.microsoft.com/en-us/library/18x8h1bh(v=vs.80).aspx) on Windows.  There's an insecure version as well, but Microsoft doesn't like you to use those.
Minor suggestion -> can ya do 
```ruby
ids = tasks.select(:id).collect{|row| row[:id]}
```
Tasks table has a lot of columns we are only interested in one column i.e. id.
According to the mockups, it should be "Content View Definitions", but that's too long with the current limitations.  Even "Definitions" is too long due to current limitations.  This is only temporary so that all navs show up.  The name will be extended after the nav rework is completed, which I've heard is planned for this sprint.
why /devn/null? I would like to see the output. At least in log file.
All those options are commented out.  I basically just ported in the newest
server.conf from the beta with the changes we need.  That includes
commented out lines.


On Wed, Nov 14, 2012 at 11:26 AM, Brad Buckingham
<notifications@github.com>wrote:

> In katello-configure/modules/pulp/templates/etc/pulp/server.conf.erb:
>
> >  # filter: () directive to set more restrictive LDAP filter to limit the LDAP
> >  #            users who can authenticate to Pulp
> >
> >  #[ldap]
> > +#enabled: true
>
> Should ldap be enabled by default? If so, what does represent? (e.g. Will
> the installer create a default role?)
>
> (Just curious how this will work)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/1064/files#r2126099>.
>
>
Should we mention that deleting a unit will delete all the nurses/vacations for nurses in that unit?
Your fix is not the right one. You are now duplicated part of the logic of the parent write method, and you are doing some formatting logic in the handler, which is wrong.
As I said previously, you should write a dedicated formatter to fromat the record in the appropriate way
Don't initialize this until the connection is started.
What about this.
The only use of this variable is to increment it. Using Date.now() at the right place will probably be enough and will let you remove it.
nit: add a name to your anonymous function here and for the others
There's a few of these of this type: Python 2.6 doesn't handle `{}` in format strings -- they have to be explicitly numbered.  So this should be `{0}/{1}`.
Please don't use the ugly nXXX variable names here, thank you :-)
Should we log the `msg` that failed to publish, too?  Seems like that could be useful to have captured somewhere.
Just to understand why set the timezone to UTC rather than say server's default timezone? If you pass a string for the time then its inferred as server's time not utc time.
why the * if you are going to ignore everything in that folder?
Generally we don't want to add handlers at the module level; this is usually reserved for the things invoking libraries (or the top level of the library).
I think this commit was already merged. No idea why it shows up in the diff
Meuh, zijn 2 queries, terwijl dat hier perfect kan met een outer join
2to3 was a bit over-eager here.
Incorrect wikipedia link
The only change to this file was replacing all its text with the v3.1.1 text.
ok. Then I think it should be removed. Adding a role="presentation" does not hide it from AT it just negates the implicit role. The content is not affected. http://www.w3.org/TR/wai-aria/roles#presentation
Scratch that--the second overrides the first. I think you should change this to:

    topics_field.choices = Topic.objects.values_list('id', 'title')
I didn't tweak this because I figured bram would be styling all the modals soon.
Does that single '0' cause problems with `timedelta_to_seconds_coverter`
What if `failureOk = 'update_adu_nightly'` and the funcname is `update_adu` ;)
This whole section is duplication. I think that it should be moved to separate method, so it is easier in future to modify it at one place.
Agreed, I wasn't sure this was no longer necessary.
Done (apply to all the above).
carry over from previously when there was a need, have removed and fixed style
This should be changed to `5.3.3` as all other components min PHP version has been changed recently to this version.
This is wrong, you need to add `use Symfony\Component\Filesystem\Exception\IOException;` and use only class name here and all way below.
@beberlei ping
0 doesn't need unit (same for line 7 and 9)
if you are able to do this, you have an issue. It means that you stored the plain text password in the session
say the unserialized value is an object that was stored by someone directly, in that case you'll at least be able to use the other methods before performing operations on the stored value.
> Does it really flatten a tree to a single collection? 

Yes, it returns a DumperCollection with only routes in it (no sub-collections)
these can't both be evaluated so make this an else-if
Single quotes preferred unless interpolating
Need to call "Done_Face" here?
I saw that; this is my slightly-modified version of the output. I've removed the other top-level sequence objects and let the whole block run together.

It eliminates the problem of the top-level keys being in an arbitrary order, and it also means that the interpreter doesn't have to try to reassemble the blocks if it could determine the proper order. I think this could become difficult if the indention levels were different before and after a sequence mark, since it doesn't look like that information is preserved in the parsed output.
InterfaceManager provides the plumbing for parsing of ifconfig outputs (as
part of the drivers code Mark wrote). I don't think it is expensive
to instantiate each time nor does it need state, since this API is not
going to the see the load in contrast to the User facing API (Quantum
extension).

I ported practices from the Twisted implementation that may not apply here.
I am going to instantiate each time for the next commit, unless someone
objects :-)

On Mon, Aug 13, 2012 at 2:51 PM, Doug Hellmann <notifications@github.com>wrote:

> In akanda/routerapi/v1.py:
>
> >
> > -@blueprint.route('/get_interfaces')
> > +
> > +## APIs for working with OpenBSD System.
> > +
> > +if_mgr = ifconfig.InterfaceManager()
>
> Well, I don't know what the InterfaceManager is. Would it be expensive to
> instantiate one each time? Does it need to preserve state across requests?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dreamhost/akanda/pull/17/files#r1365229>.
>
>
Could you capitalize this class name?
@everbird 嗯，后一个pr已经改为存 NSDictionary 了，就是从api获得的一个 book 字典。感觉好了很多 :smiley:
I'm not really sure this is a great idea, wrapping whole blocks in a try/catch and silently ignoring the exception is usually a code smell. I also can't see what part of this can actually fail?
Ok, but, the Group is not created if empty visibly
Put this path as parameter in Pimple: ``changelog.json_cache``
This would wait forever if we dont get the event
If nothing is done with the return value, use

context.completeStep(OperationContext.RollbackHandler.NO_OP_ROLLBACK_HANDLER);

That makes the operation handling non-recursive. Not so critical in ops that aren't run during boot, but a good habit to have.
Can we just put this online and not have it linked like this? I think it should look like the others, no?
this date will be updated if user buy a product.
Can you add a comment describing what this is for and why you created it?  It'd be helpful for future developers.
How about starting by creating a Raffle::Position class?
Unnecessary white space?
return seems useless here
Do you mean ScreenManager.turnScreenOff(false)? If you means that, then 
we should remove the ScreenManager related call in attention_screen, and 
change it to wakelock implementation, right?

於 2012/10/31 下午 04:57, Timothy Guan-tin Chien 提到:
>
> In apps/system/js/screen_manager.js:
>
> > @@ -210,6 +219,17 @@ var ScreenManager = {
> >        return true;
> >      }
> >
> > +    if (!this._idled) {
> > +      // We are going to do brightness transition but not due to user idle.
>
> Add a |console.warn()| here -- no script should attempt 
> |LockScreen.turnScreenOff(false)| except the idle timer & wake lock 
> release handling.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/mozilla-b2g/gaia/pull/6102/files#r1989491>.
>
nit: a -> activity
`display: none`?
I think I need another coffee :)
good point. now fixed
Sure! I suggest that whatever that lands first should be immediately followed by the other one!
I don't think you need the Object.create here unless you are doing something horrible where you are mutating the intermediate prototype you are creating.  And that would probably do sucky things to your shape, and doom your soul for all time, so don't be doing that.
this isn’t required either
If you want to avoid the warning in the console caused by this line, you can do this:

  previewPlayer.deleteAttribute('src');
  previewPlayer.load()
But I still don't understand sorry. why is there still a 1~2 sec
differences if we take the last planned scheduling time? It should
only add 300s to the last time, for the planned time.

Then the question is : which are we giving to graphite : the planned
time, or the real time (so with the 1s latency). If we give the 2nd
(what we do currently) a latency change can make an error of 1~2s
indeed (but such tools can't manage this so?). Of course we can give
the tool the planned time, but if the latency is high, like 10s, the
data will be just false (10s is not what we can call precision...).

A solution can be to still

self.next_chk = int(self.next_chk + time_add)

but also reduce with the current latency (we can put a limit, like 10s
max latency to reduce). With it, I think we can have a more precise
timing, with no strange thing as managing the "last 10s" of a minute
(in fact graphite and rrd are managing in term of full minute instead
of linerar time? that's sounds stupid for me)

We can give a try to this version to see what is the result, but I
think that should be ok "statistically" :)


Jean


On Sun, Oct 7, 2012 at 4:06 PM, xkilian <notifications@github.com> wrote:
>
> In shinken/objects/schedulingitem.py:
>
> >                  else:
> > -                    self.next_chk = int(now + time_add)
> > +                    self.next_chk = int(self.next_chk + time_add)
> > +                # If check interval is a multiple of 60 (seconds), the check must be scheduler
> > +                # between 0 et 49 absolute seconds.
> > +                # Else re-schedule if the check is scheduled between 50 et 60 inclusively in absolute seconds.
> > +                # We assume here that checks do not take more than 10 seconds to execute.
>
> What happens when the assumption fails: It MAy cause a gap in time-series databases:
>
> Example with 1 minute check_interval results:
>
> 10 h 0 m 59s
> 10 h 2 m 01s
> 10 h 2 m 59s
> 10 h 3 m 59s
> 10 h 4 m 59s
>
> Notice that there is a gap, so graphite and RRDtool which use absolute time, will not display a point.
>
> —
> Reply to this email directly or view it on GitHub.
I think it would be better if these were just constructed as Python dicts rather than loaded from JSON strings in the code?
Isn't the file still named pulp_puppet.conf? That's what it's been named, and I think it should probably stay that way. In the apache config context, seeing "puppet.conf" doesn't make it obvious that it came from pulp. It's quite valuable there to have the "pulp_" prefix, whereas within /etc/pulp/, it is reasonable to have a file named "puppet.conf".
Tested it yesterday; as you might recall that's exactly what the checkins after he first checkin di (and they are handled properly)

Sent from my iPad

On Jun 15, 2012, at 8:56 AM, Nicholas Weaver<reply@reply.github.com> wrote:

>>           end
>>         end
>> -        @hw_id, @last_state = *@command_array unless @hw_id || @last_state
>> +        @hw_id, @last_state, @first_checkin = *@command_array unless @hw_id || @last_state || @first_checkin
> 
> Does not break previous versions as long as first_checkin is handled well if null
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/Razor/pull/71/files#r993653
Yeap, easily done.
Why are we moving version into a static value inside?
No, coco ADI gets triggered here. I left `pop!` because it removes the last element
One is for foldLeft one is for BufferOp (which is used for scanLeft).
The convention is to see if expected == actual, not the reverse. Could you change that throughout?
`return $this->save();` ?
A comment with a succinct version of this explanation would definitely be useful.
класс :)))) "video unsuccessfully deleted"

не надо проверять здесь, ну или если хочешь проверять - тогда должно быть понятно зачем и что юзер может с этим сделать
changed to isWhiteListed
this is wrong... you can chat in several channels at the same time... think global chat and irc chat... or a chat logger etc..
Can you please write defines in all uppercase? Also, I think 102400 is a bit too large for your average user. I think 1024 could be a good middle ground, but we could do some exponential increment as well. I.e.:

```c
#define SIZE_INCREMENT 1024
```

… or do something like:

```c
size_t increment = 16;
buffer = realloc (size + increment);
if (increment < (1 << 16)) /* max 2^16 =~ 65k elements at once */
  increment *= 2;
```
Yeah, although # isn't valid in package names anyway. But I'll fix that.
no separate files for other sensors even in the current HEAD revision of ethersex... does it make sense to move it to an external file?!?
shouldn't this say "... branch *does* not exist"?
Agreed, it make sense
Thx. See comment below.  If we stick with $text as the "optional text shown instead of title" you're probably going to need to explain why optional text is needed in the platform pull request.  Might be easier with $tip_prefix but still needs explaining, in the platform pull if not code comments.
it would be overkill to include jqueryui just for this two regex. Except if you do not thinking about replacing search box and results with jqueryui combobox?
Just set a default in the config:

config :prefix, :validate => string, :default =. ""
How about PageSelector?
localization AND the next line
It shipped in Firefox 13, if that isn't good enough then we can't use Map either.
Nice, that should keep the cookie from being sent for static resources.  ++
I have moved this to be the very first script of the set, before any libraries. This is so I can get the exact time before any other scripts are parsed. Upon completion of script parsing, start.js is run. I can take the diff between parse end and parse begin to find the total parse time. If we start shaving script bytes and realize gains in parsing, I would like to be able to quantify how much time we are saving just in parsing.
de-dent this one level.
Those two elements have to be paragraphs because span is not allowed as used here.
I didn't use blankslate gem. I implemented that class myself (list of methods is based on BasicObject.instance_methods). It also has nothing to do with the implementation of blankslate gem (please look at the source code of the gem).

Cheers!
mlen

On 30 sie 2012, at 20:39, Daniel Pittman <notifications@github.com> wrote:

> In lib/puppet/dsl/blank_slate.rb:
> 
> > @@ -0,0 +1,54 @@
> > +module Puppet
> > +  module DSL
> > +
> > +    ##
> > +    # BlankSlate is a class intended for use with +method_missing+.
> BlankSlate appears to be the BlankSlate gem, which is under an MIT license, copyright retained by the original author. Under the terms of the license we need to, at the very least, reproduce the license along with this inclusion. It seems like the rest of the use we are making of it meets the terms, though.
> 
> Details of the license from the original are:
> 
> Copyright 2011 Jim Weirich (jim@weirichhouse.org)
> 
> Permission is hereby granted, free of charge, to any person obtaining
> a copy of this software and associated documentation files (the
> "Software"), to deal in the Software without restriction, including
> without limitation the rights to use, copy, modify, merge, publish,
> distribute, sublicense, and/or sell copies of the Software, and to
> permit persons to whom the Software is furnished to do so, subject to
> the following conditions:
> 
> The above copyright notice and this permission notice shall be
> included in all copies or substantial portions of the Software.
> 
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
> LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
> OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
> WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> —
> Reply to this email directly or view it on GitHub.
> 
>
FYI: https://github.com/alindeman/rspec-mocks/blob/8dee2ec872107b9780531145590194124dfdea85/lib/rspec/mocks/method_double.rb#L51
Please don't assert that it should not throw exceptions. This spec would pass if for example it throws a different type of exception. Try to find something that actually asserts how it behaves. In this case probably something like:

```
ModuleSpecs::P::P1.should == :p1
```
This can be a single line.
I wouldn't define a default here (`/tmp/chef-solo`), because we would be setting the default in two different places. That belongs to `settings.py`
OK, so problem is probably that github use tab as two spaces, so it looks broken here.
Ok, will rename it.

Îòïðàâëåíî ñ iPad

26.08.2012, â 20:15, Mike Yumatov <notifications@github.com> íàïèñàë(à):

> In project/lint/ghclone.py:
> 
> > @@ -32,9 +32,9 @@ def tempdir(root=None):
> >  
> >  
> >  @contextmanager
> > -def clone(url):
> > +def clone(url, head=None):
> Sorry, not a ref, but a hash :)
> 
> —
> Reply to this email directly or view it on GitHub.
>
I fixed this when merging.
Remove `--recursive`
The same thing here.
Yes, looks good!
Yeah, but skipping EventManager, following happens (unsure if example is correct, but that is what I'm thinking of):

```php
class A
{
    public function setFoo(Foo $foo)
    {
    }
}

class B extends A {}

$di->get('A'); // $di->get('Foo') is called 2 times!
```
Use `start - Reset`, not `start: Reset`.
Remember we have `bin/prepare-test(dev)-env.sh` ;-)
You have renamed this method.
missing . for relative header
What happened here? o.O
Kommentoitu.
Shouldn't this be moved at line 3074?
You should define a `suite()` method that returns a testsuite, so these tests can be incorperated into a bigger suite, and work automatically in other tools that use unittest (like eclipse's unittest gui)
This also allows you to then run the testsuite from the commandline with
`python -m unittest test.missing`

I suggest
`def suite():
    """ return all the tests"""
    return TestLoader().loadTestsFromTestCase(TestNub)
` 
(with the apropriate imports from unittest)

see http://docs.python.org/2/library/unittest.html#basic-example (the bottom part)
it's the easiest way to have it picked up by optparse. but indeed, it makes no sense to store such property in environment variable (the variable is not set by default in most shells)
use function for this
all these functions do the same. make a new function and call that one.
and the point is?
Seems a bit short to me? Or is this curl default?
Can we keep this `username` and rename the `username` in your PR to `displayname` again? Having a `getUsername()` method which returns the `uuid` path and a `getDisplayName()` which returns the `username` path is even more confusing imo.
use update_attributes!
This should be JavaDoc
Any reason the `<img>` tag itself can't have the `thumbnail` class? Less divitis is good.
How is it populated?
This is a trillion times better.
should be `function() {` <-- notice the space changes
setTimeout should be multi-lined
I can see the case for both ways too. I think I might prefer it in the page object as it seems most pertinent to the page (especially for maintenance purposes) where as a provider should just provide :)
Now that you're assigning this to a variable `found` we don't need to use `or` but simply we can break out onto another line.

```ruby
found = where(@klass.friendly_id_config.query_field => id).first
found = includes(:translations).
        where(translation_class.arel_table[:locale].eq(I18n.locale)).
        where(translation_class.arel_table[@klass.friendly_id_config.query_field].eq(id)).first if found.nil?
found = includes(:translations).
        where(translation_class.arel_table[:locale].eq(I18n.default_locale)).
        where(translation_class.arel_table[@klass.friendly_id_config.query_field].eq(id)).first if found.nil?
```

Which then highlights how this is happening in the first place. The only difference between the second and third attempt to find is the locale variable, Maybe we can find by both initially or optimise this in some way:

```ruby
found = where(@klass.friendly_id_config.query_field => id).first
found = includes(:translations).
        where(translation_class.arel_table[:locale].eq([I18n.locale, I18n.default_locale])).
        where(translation_class.arel_table[@klass.friendly_id_config.query_field].eq(id)).first if found.nil?
```

This would find the `I18n.locale` version first and then the `I18n.default_locale` version second and then access the `.first` at the end of the statement, ensuring that we get one of these with preference to `I18n.locale`

What do you think?
Just to confirm: by translation string you mean the ts("I'm a translation string!") sort of thing? Apologies if that's a really stupid question.
<3 so much better
`(this.pin, [0x00]);` => `( this.pin, [ 0x00 ] );`
It can actually fail : when you unplug your camera you get an End_of_stream.
We want bindToRoute to fail early as the loading indicator is linked to it. If it does not fail early then the user is stuck in a state where the loading indicator is displayed for something that we know will be hidden will it not?
Why call this?
"Genereate"?
Good return value. Says a lot about the error.
scumbag composer :|
Could you do this with just 1 for loop?
This is something I have thought about a bit (see https://github.com/astrofrog/astropy-api/pull/1 - but no need to comment there at this stage!). You  could have

```
high_d_data.plot(slice=[1, 'x', 4', 'y'])
```

which means pick the second slice in pixel space in the first dimension, plot the second dimension on the x axis, slice 5 from the third dimension, and the fourth dimension on the y axis. This is all necessary because the WCS could depend on the position of the slices for any of the coordinates not directly shown.
Could we expand this comment a bit. This is quite confusing stuff and looking at this comment here and on the field I don't think engineers are going to see how this is supposed to be used.

Specifically we should document that noAuth means the method does not "require" credentials, although if you provide them, we will create a principal. This can be used in situations where the API method itself needs to do the authentication.

Anon on the other hand is for methods which we know we can safely ignore any credentials given and just let the request pass without creating a principal object.
Ah, right, only one parent pool.
the %s is still not filled in from this change, should have a ", filename" at the end
Which is the reason for not putting in on the capability then?
I though OPENNAAS-233 was going to be part of this funcionality.
you're right. the java source code says

***
   /**
     * Creates a new query by specifying the query <code>statement</code> itself
     * and the <code>language</code> in which the query is stated. The
     * <code>language</code> must be a string from among those returned by
     * QueryManager.getSupportedQueryLanguages().
     *
     * @param statement a <code>String</code>
     * @param language  a <code>String</code>
     * @return a <code>Query</code> object
     * @throws InvalidQueryException if the query statement is syntactically
     *                               invalid or the specified language is not supported.
     * @throws RepositoryException   if another error occurs.
     */
    public Query createQuery(String statement, String language) throws InvalidQueryException, RepositoryException;

***

So we have to throw the exception here

Can we nevertheless merge it and I make a new PR to add that?
I think these migrations should be split up into 3 individual migrations. 

Also, I'm wondering if we should perform each migration in its own transaction, as opposed to having a big transaction around all the migrations. That would prevent errors during any of these 3 migrations from forcing redoing all the work for all of them.
Should be replyTo
In Ecmascript 5 null is of the Object type. They're planning on fixing that in the next version.
This is not important and nitpicking but can this comment be on one line since the code gets wider below anyway.
This JSDoc is incorrect. It says: specifying the tenant information that was persisted. However, only false or error is returned.
I moved this out of here into oae-authentication, because it is supposed to short-circuit the request chain when there is an unexpected error with authentication.
Is this block also supposed to have an `isViewer` check?
descriptor['environment'] is defined by :env => 'production' above, so we don't have to worry about it not being defined.
As i said, i think this is not really useful.
I would prefer to remove this in all providers, because it's not a best practice for php newbies.
add the `curl ...` line please.
Тут тоже нужны одинарные кавычки
`handle*` is niet echt een goeie naam. Dat gebeurt eerder met `events`. Beter idee: `updateHealthBar`. Waarschijnlijk ook slimmer om dit in de `receiveDamage` call te doen aangezien het dan alleen update als de health echt verandert (ipv tijdens elke tick).

http://impactjs.com/documentation/class-reference/entity#receivedamage
О, вот оно как, теперь буду знать о таком поведении.
"обращать внимание на эту тонкость"
Одно дело - обращать внимания на тонкости. Другое - мусолить одну и ту же "тонкость" в дискашнах, в коментах и т.д. это никакое не обучение а банальные придирки, так что можно пафос отбросить.

В данном кокнретном случае отсутствие пересчёта это оптимизация, я уже написал почему. Могу повторить - затачивание под конкретную реализацию это и есть оптимизация.
Спасибо за комент
Так и не понял почему не добавились последние фиксы комиттил вроде с таким кодом
if ( percent > 0 && percent<=100 )
    {
        int replaceNumber=percent*maxLenght/100;
...

PS первый раз с гитхаб работаю - не до конца все ясно)
Но на будущее буду стараться всегда по возможности рассматривать проверку на корректность данных )
согласен, но словарь по условиям задачи был уже задан.
So it's been a stub for months and nobody has noticed? Great...
Let's leave it x'd out and open a techdebt to determine what the behaviour actually is on the device. Once we know that, we can emulate it properly.
Can you remove this file from commit?
In ORM the clean/dirty states are used for cacheing the generated SQL. Becasue there is no DQL/SQL generation here, they are not needed.
Then we should probably change this associated object to be atomic and immutable, so we can at least retrieve it safely.
Hmm, so I'm not sure what this is testing. The `it` description talks about immediacy but that's not actually tested. Seems to really just test that `+currentScheduler` is right.
@tigran123 Agreed. I'm not very familiar with kindlepdfviewer. Actually I just came to know this project in last weekends. So I will try the advanced features you mentioned above.
you can probably turn this into [an application start phase](http://erlang.org/doc/apps/kernel/application.html#Module:start_phase-3)
same here, use "is" instead of ==
Fix indentation (H&E)
Coding stds indicate NO tabs chars anywhere except in Makefile's. See https://github.com/nvmecompliance/tnvme/wiki/Coding-Standards, that is why the code alignment is incorrect.
new ArrayList< String >() instead of Vector
I was just replacing code that was there that was exactly duplicating `ej:get/3`.  I think it was probably defensive, but doing some repo archaeology indicates that it was there from back before we centralized the `ejson_for_indexing` function in this module.  I'd have to do some more research before I could say if they were actually necessary or not (or used to be necessary, but not anymore)
I see, I remember we discussed this at some point. I suppose it's OK then. We can always change it back if it turns out to be too expensive (but as you said it looks like it should not be that bad)
Shouldn't you only be modifying one or two stanzas anyway? Also, you should just prefetch the specific content you need, and then use that, rather than relying on having the entire file to access.
@stof corrected, should i update the other links to use `docs.doctrine-project.org` also?
这个参数必须写在值映射列表的最前面。
Libcurl accepts 0, 1, 2: http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTSSLVERIFYHOST.
I know this is a bit strange, I would love to fix it and am open for suggestions.
Thanks, how about 区域？
Fixed. Pushed.
he said to demote the summation documentation to calculus after sub section(series expansion).
le paramètre $protectPK devrait être utilisé ici pour ne pas que les valeurs lues écrases les valeurs existantes des pks.

actuellement, si on récupère un record existant dans le but de le mettre à jour (donc avec une clé existante), soit les pks sont écrasées par les valeurs données, soient elles sont mises à null. dans les deux cas donc, on perd les valeurs des pks. l'utilisation de ce paramètre $protectPK n'est pas logique.
On Fri, Feb 17, 2012 at 1:43 AM, Stefan Krastanov
<reply@reply.github.com>
wrote:
>> +    __main__:3: SymPyDeprecationWarning: The feature such and such is
>> +    deprecated.  Use this other feature instead.  Contact the developers
>> +    for further information.
>> +
>> +    If, however, the argument value does not hold a string, a string
>> +    representation of the object will be appended to the message:
>> +
>> +    >>> warnings.warn(SymPyDeprecationWarning(feature = \"such and such\",
>> +    ...     useinstead = \"this other feature\",
>> +    ...     value = [1,2,3]))
>> +    __main__:3: SymPyDeprecationWarning: The feature such and such is
>> +    deprecated.  Use this other feature instead.  ([1, 2, 3])
>> +    """
>> +
>> +    def __init__(self, value = "", feature = "", expected_removal_version = "",
>> +                 useinstead = ""):
>
> `None` seems like a better magic value (compared to "").

Checking for "" would also take care of the situation when the user
provides an empty string; do you think it's worth switching to None?

Sergiu
Looks nice, so we do not need `getDeleteParams()` and `getPutParams()` anymore.
Así lo puse en el texto de ayuda, me parece que va a ser lo más
práctico y es barato

2012/7/14 Alpha
<reply@reply.github.com>:
>>
>> -            if (!string.IsNullOrWhiteSpace(Parameters.Term))
>> -            {
>> -                Expression<Func<Attachments_QuickSearch.Projection, bool>> predicate = x =>
>> -                    x.FileNameWithoutSpaces.StartsWith(Parameters.Term.Replace(" ", string.Empty));
>> -                //Soporta comodines, pero no estoy seguro de que en futuras versiones lo haga
>> -                //El Equals no soporta comodines
>> +            var nameTerm = term.TrimEnd(new[] { '*', '?' }) + '*';
>
> ¿Esto determinaría que una búsqueda "Hola*" y "Hola?" con wildcards devolverían los mismos resultados? Entiendo que es así porque parecería que la búsqueda es siempre la primera parte de la palabra. ¿Queremos que así sea?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/127/files#r1164085
Making the listener table weak could cause it to lose callbacks that were created as anonymous functions and thus don't have any other references.
yeah, I just narrowed it down to XP in my virtual machine kingdom, are you running XP I hope? In this case it's probably something about API's and I have to look into it...
You can use ruby trickery here.... 

```
attribute_hash.each do |key, value|
  self.send("#{key}=", value) if respond_to? "#{key}="
end
```

That's a bit advanced, but is a way you don't have to specify each and every attribute you want to mass-assign.
This will sort the entries in memory -- take a look at using [scopes](http://guides.rubyonrails.org/active_record_querying.html#scopes) in the controller to do the sorting in SQL instead.
this method does not return anything ?
This PR is intended to fix a bug by using url generators instead of manually generate string.
There are a lot of use that should be refactored, but this is not the topic of this PR
Please use utils.Log.e(...) here.
The original reason we remove the ib_logfiles is cos if we change the log size in the conf, it doesn't get reflected automatically and fails if it's the wrong size... hence we delete it on initial startup and will have to do it on resizes too.
I'm was fairly sure there were annotations but Googling reveals mostly annotations for this people wrote themselves. Tempest has such an exception but it comes from unittest2.

To me a Skip is a Skip, so I don't mind this much.
Further more this would require the validation to happen outside of the model and i think the model should handle the validation for the body.
As tip, you can probably write this more elegantly by using `iterator.map()` and passing a function as parameter that writes the not done byte and ranged bytes, i.e.

    iterator.map { entry =>
      buf.writeByte(1)
      writeRangedBytes(entry.getKey.getData, buf)
    }
actually for this to be at top efficiency you could execute
`cache.withFlags(Flag.SKIP_REMOTE_LOOKUP, Flag.SKIP_CACHE_LOAD)`
at Proxy initialization and store the return value in a final field for reause. I'm doing that with most Flag uses in the Lucene directory.
@mmarkus I've asked the same thing in another commit section and @danberindei gives his view... I still think (same as you) that cancellation should be implemented using interruptions, that's what they're made for :)
But my stupid IDE can't read comments :-)
The other option is to do a hanging indent.
You could condense this CSS significantly by making it also apply to the selector below.
components reusability, they have the property defined, but if you want you can overwrite it when you create it (in other projects).

the one in main.qml is supposed to be the reliable value which devs should rely on regarding the gallery
no, it totally makes sense I didn't really like it the old way, this is much nicer
If these are not used, can you remove them?
@gsilver Can you convert this file to use single quotes on the lines you've changed?
is this really needed or could you just use shogun's parallel->get_num_threads()?
newline here please
minor thing: print "asdasdads" (without () ) does the job
Right. I was thinking the value itself would be the data, but it is a hash and would never be `0`. :+1:
Probably best you check this as well, instead of having a todo lying around.
Add standard Newscoop header, look for it in any other file.
Class and methods are not documented.