labofsahil/github-event-dataset-2012 huggingface dataset:
MogileFS Configurable Class

1st Pull Request ever!

Replaced hard-coded 'avatar' class with a config one
Please review before merge

Here some cleanup that could be interesting to be merged
Fixes

Pretty straightforward.
Fix sqlite issue

Hello!

I've fixed sqlite issue. Wrong owner (root) is preventing write access to sqlite database.

Feel free to discuss.

Many thanks!
Update js/languagestrings.js

Remplacement d'une phrase pour la finition de la traduction française
Update to Parse.framework v1.1.24.

Adds CoreLocation.framework.
Update site/sr-YU.com_hwdmediashare.ini
Adding comment to README

So as to be more concise heiheihei.
Fix missing "Email" prefix in README
OAEWDGT-3 - Submit the widget rating

Jira: https://jira.sakaiproject.org/browse/OAEWDGT-3
Fix for #9

Changed flag to FLAG_ACTIVITY_RESET_TASK_IF_NEEDED and now clicking on the notification opens the app properly.
handle different subject encodings

I was experiencing some strange and unreadable subject titles, due to different encodings from different mail sources. For now, I just took the imap_mime_header_decode function. Altough this makes the library dependant on the php imap functions, it seemed to be the cleanest solution.

Feedback is appreciated.
Fix POD after module rename

The POD was still refering to [CheckChangesTests] instead of the new name. This patch fixes that.
Authority::cannot does not work properly

`cannot()` function in the helper works as expected but it should use `Authority::cannot() ` instead of negating `can()` function. However, `Authority::cannot()` itself returns the same value as `Authority::can()`, so this commit fixes it.
Changing URL for Facebook SDK to the new location

From the [old Facebook SDK Github page](https://github.com/facebook/php-sdk):

> Please update anything you have pointing at this repostory to this location before April 1, 2012.
merge down from release 1.5 branch.  add username back into UserProfile ...

...object. should never be populated
safe_value patch

Hi, 

Here is a patch which prevents widget crashing when the input value is None. Even though this should not happen, it happens under certain circumstances with DataGridField.
Usar padrão de url comum para auth_url

Usar *url* comum para ``auth_url`` tanto no desenvolvimento, quanto na produção.

Esse esquema ainda facilita mudar a *querystring* da *url*, caso seja implementando configuração personalizada para as permissões necessárias para o ``app``.
booleantehtävät (2.)
[Review] Implement attribute node
error page

Changes :
- add 404 error page
- drop w00tw00t request
- drop cookies for more static file
the walking dead

yop
> Therefore to provide a fallback, the RGBA value must come first, followed by an IE-specific override.

Confused.  Isn't that what is going on here?

First everything will read (though might not apply)

```
 color: rgba(0,0,0, 0.80);
```
Then IE6/7 will read

```
*color: #444;
```
This one shouldn't be here either.
Ok I will take a look at it.
CFile Open does that plug an addition check.

    if ( (flags & READ_NO_CACHE) == 0 && URIUtils::IsInternetStream(url, true) && !CUtil::IsPicture(strFileName) )
      m_flags |= READ_CACHED;
looks right to me
Thanks. Make sens
Jirko vydrž, je to jen "nadhozený" kommit, který se musí obhájit. Mediáci zatím hlásají vodu, ale pijí víno.
Might be helpful to have "private_a" "private_b" to keep all the privates in order.
Did you mean to leave these commented out tests here?
Ah, so that is a bug. SagHTTPAdapter should be defaulting that to `0`. Pushing fix for that now.
我是在说你..
In case of boolean, consider using "ternary" variant of if-else:
```
if (isSelected) ColorEdgeSelect else ColorEdge
```
Oops, typo...
I don't think the last strip is actually needed but it's safe I guess, might remove it.
hey guys, nice to see my work is used ;-). but theres a little crash in Halion script if you kill him in server crashes randomly, currently im sitting on a fix for that. just a question, if you are interested i could stop working on my stuff und join your Team. if you are interested yust write me a massage on github.

and btw nice work on this project
Why you remove const?
const is good for compiler
https://github.com/mangosR2/mangos/commit/31cfffe67ddf39657acba9c6023b29c78e8afad6
This is great. I was wondering why 0.4.2 didn't like my absolute urls when running multiple tests. Should I bump up to a later release or just cherry pick this update?
Yes we do.  Those will work, but they are technically not correct.  With integral types, and only integral types, you are allowed to declare and define the constant in a header file.  However, you still need to also declare it in a source file.  Why?  Because the compiler needs to know what translation unit the constant is defined in.  If you called &joysmooth::HOLDBACK (legal, though I don't know why you would do it), the linker would not know where the space was allocated (in what translation unit) for joysmooth::HOLDBACK, so it would give a linker error.  By providing this definition we allocate the physical memory to hold the constants if they are needed.  Modern compilers will also optimize this memory out if it is unneeded with link time optimization (llvm is great at this).
flag | = mIs24HourView? DateUtils.FORMAT_24HOUR : DateUtils.FORMAT_12HOUR;
Ok, thanks. I'll push.
Your test worked.
... till this point.
Need to translate and html escape this. Since these will outputted as normal text (and not as html attributes), use the xlt() function (rather than the xla() function) from the library/htmlspecialchars.inc.php file:
```<title><?php echo xlt("Send a Reminder"); ?></title>```

See here for security model:
http://www.open-emr.org/wiki/index.php/Codebase_Security#Plan
We won't have to remove the dependency for jQuery in the KDPMapping, because we will have a separate kWidget method that simply adds mapping for the iframe calls to directly call the iframe versions of thous functions. This eliminates the entire iframe proxy setup and the client / server code.
for what is this sql query rsa?

I have problems with uncontrolable pets. I'll make a issue with more information
Awesome job :)  I love seeing old code be updated to a fraction of what it was :)
文件末尾要保留空行，不能删除。
yo uso la db 2.5 , y el emulador y tengo un problema con las rutas de vuelo alguna solucion ?
This breaks {command/control/middle}-click browsing. We should never explicitly set `document.location` in this way.
ah...sry

hat sich geklärt, ich hatte nur jedes mal ne exception bekommen, dass das repo scho existiert.
Hatte den sinn der Funktion aber auch ne richtig verstanden...jetze isses klar:) Hatte noch nen .emp-Ordner in nem darüberliegenden Pfad...
int is correct here, HaveKeys should return the number of items in pubkeys that are in the keystore.
Is /backend/cache/config/config.php (and frontend)  still required now?
ok

2012/2/23 Maxime Chramy <
reply@reply.github.com
>

> Exact, on devrait mme avoir un warning je pense. Bon il suffit d'ajouter
> les arguments pour les fonctions. Je te laisse faire un ticket ?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/TacOS-team/tacos/commit/7fa1021d45ae92f9a5195d193fce2b22c38acf8c#commitcomment-1000251
>



-- 
Nicolas Floquet
Ooh, yeah, my bad, I forgot to add the .cpp/.hpp files. I ended up making a new fork/branch once I figured out how to properly work with them in git, and then rushed to push a commit. I'll push a new one in a minute.

I saw the wiki page on file naming conventions, but since WindowManager is in window_manager.cpp, I thought the wiki was outdated and the underscores were fine. So no underscores?

As for the get functions, I'll get rid of them.
@bnoordhuis Done.

@isaacs Looks like it will throw on null, but since it's inside the `try/catch` and there's no autocompletion necessary for `null`, I'm not sure that it really matters. Also if we do your suggestion then it would throw in the `else` branch, trying to access `.constructor` of null.
you're logging in as an editor, but the test says `_as_admin`
Please use 4 space indentation. Otherwise this will crash on some OSes/python versions.
Hey thanks for contributing! Looks like a good solution to me. Let me run some tests just to be sure. I did notice that you missed the semi-colon at the very beginning of jquery.revolver.min.js though. Also, any reason why it's spread out into 9 lines instead of just 1? Maybe some performance benefit I'm not aware of?
Thanks, fixed in adaba7790b676fb6d75dad027c012928d8946cf4
I think @cvan got this one :)
I like "Copyrights and Acknowledgments". Then we can put all contributors (testers, documenters, spiritual guiders, etc.) on that page, which would be nice.
I did try with 1.2.2, same problem.

Ok, moved my answer to the related issue:
* https://github.com/cloudhead/less.js/issues/592#issuecomment-4124890
I am not sure. The comments said that plugin "isn't functional", so I assumed it shouldn't be enabled.
NSFW on profiles? ;D
I think I'll just use a special case value for Violations that aren't associated with a Rule: `:unspecified`. I think that will cover this case—better than nil, certainly, and prevents the need for a null object. Also, it could be parameterized down the road (if need be).
No need for an empty spaces, please follow existing conventions:
- each new attribute start on a new line with the same indention as the previous
- end tag /> should be near the last attribute
- no empty lines between attributes
Here you forgot to verify if separator is not null (since get_separator() returns a "string?", not a "string").
limite-vector -> limited-vector
since this is executing in a loop, this is a good candidate for prepared statements, something you ought to be using anyways.
Checkout out emacs vim-mode or evil for vim emulation in emacs. I tried
vim-mode a while back, but it looks like evil might be newer?

http://www.emacswiki.org/emacs/Evil
http://www.emacswiki.org/emacs/VimMode

On Sat, Jan 14, 2012 at 5:19 PM, Dave Ray <
reply@reply.github.com
> wrote:

> As a gesture of good will, I'm actually checking out emacs a bit this
> weekend. Chances of me switching over are low at this point. Muscle memory
> :)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/overtone/overtone/commit/29e79188ff1b0e369ed506734f12ebeda62d5f28#commitcomment-867894
>
Sure, updated the grep command in my latest commit.
It allows you to, in essence, control how frequently animals (cows, sheep, pigs etc.) and monsters (zombies, skeletons etc.) spawn independently.
Hi Amir,

Sure. Are you at work on Wednesday or Thursday?

Regards,
Nelli
Am 02.02.2012 09:07 schrieb "Amir Aryani" <
reply@reply.github.com
>:

> Hi Nelli,
>
> I am a bit confused here? As far as I can see this is not the code that
> you added to GitHub? So how did you get the message from Tim?
>
> If you are in Melbourne and have time, we can catch up. I will be glad to
> have chat with you about possible improvements of the InPython code, and
> related research work.
>
> Regards,
> Amir
>
> -- sent from an iPad
>
> On 01/02/2012, at 22:39, Nelli<reply@reply.github.com> wrote:
>
> > No. I don't know why, but I haven't even thought about that. But I am in
> > Melbourne next week and if I still have access to the computer I worked
> on,
> > I will try to improve the code with it.
> >
> > Thank you!
> >
> >
> > 2012/2/1 Amir Aryani <
> > reply@reply.github.com
> >>
> >
> >> No idea!
> >>
> >> On Wed, Feb 1, 2012 at 11:48 AM, Tim Dettrick <
> >> reply@reply.github.com
> >>> wrote:
> >>
> >>> Any particular reason why you didn't use the [tempfile](
> >>> http://docs.python.org/library/tempfile.html) library?
> >>>
> >>> ---
> >>> Reply to this email directly or view it on GitHub:
> >>>
> >>>
> >>
> https://github.com/aaryani/CoreTardis/commit/2efeced5d7caac1332df9eaf16d058d7d750c337#commitcomment-920852
> >>>
> >>
> >> ---
> >> Reply to this email directly or view it on GitHub:
> >>
> >>
> https://github.com/aaryani/CoreTardis/commit/2efeced5d7caac1332df9eaf16d058d7d750c337#commitcomment-921133
> >>
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/aaryani/CoreTardis/commit/2efeced5d7caac1332df9eaf16d058d7d750c337#commitcomment-922212
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/aaryani/CoreTardis/commit/2efeced5d7caac1332df9eaf16d058d7d750c337#commitcomment-924246
>
if($restricted_m){ // remove error when record not found
also doesnt this just tell you that improved hamstring shares diminishing returns with roots?
hrm...okay, I'll keep my commit messages a bit shorter in the future ;-)
Should note somewhere that the caller is assumed to hold the modification lock for the OVm instance.
Maybe we could use `.Platform$file.sep` in the following line instead?
Bien! Now you're just waiting for [pygments.rb](https://github.com/tmm1/pygments.rb) to get updated like the rest of us. :smiley:
Can i troll about PR? :trollface:
Ideally it would be better to make sure all values always where non-null, but I see that this is not possible without changing the implementation of equals() too.
Без объяснения про indentation и alignment бессмысленное и глупое требования. См. цикл статей на хабре.
Same goes for ERDirectToRest - IMHO, just delete it. If someone wants these they can checkout our older version to get them. Alternatively, the safest practice might have been to deprecate all the dependencies of these classes and delete them all together in one commit in a month or two. Since this is integration, you could still do that it you wanted.
I'm curious whether the process that writes the pid files also skips numbering those that were skipped by this continue statement?

i.e. will whatever causes the address to be empty also cause you to get out of sync with the numbering scheme?

If that is the case you could move, processNumber++ above.  

But if the pid files will follow the same logic you are probably ok.
see recent push

On Thu, Jan 12, 2012 at 4:39 PM, Strife Onizuka
<reply@reply.github.com>
wrote:
> Additions are correct. The rest look like articles that just need to be purged (the cache is stale).
>
> ATTACH_(LEFT|RIGHT)_PEC should not be 40.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/BlindWanderer/lslint/commit/06977c8cefa28b76ef8ae7d9d16a6c0d30f1f01a#commitcomment-863107
yo, don't mess with this guy
There is already a .box-sizing(@boxmodel) in mixins.less
Yes, the logic for date editing and validation need to integrate the order's state. TODO
Two problems here.

1. This is not thread safe
2. Statics should be avoided with services if possible since you needlessly prevent the distant future possibility of two containers in the same VM
Cara, pelo que vi no cdigo do brCobrana ele t gerando como diz l no
manual da caixa:
http://downloads.caixa.gov.br/_arquivos/cobranca_caixa_sigcb/manuais/CODIGO_BARRAS_SIGCB.PDF

Posio 20 a 44 so para o campo livre e comeam com o Cdigo do Cedente
(20 a 25).

Ou eu no entendi bem a sua pergunta?

Abraos

2012/2/28 Breno Perucchi <
reply@reply.github.com
>

> Ralft,
>
> Voc est certo, eu vi a nota agora. Me tira uma dvida, por favor.
>
> Nessa montagem de usando SIGCB e emitindo pelo www.ecobranca.caixa.gov.brambos colocam o codigo do cedente na posio 05-15 (no tenho certeza aonde
> encerra) porm no Manual (CODIGO_BARRAS_SIGCB.PDF) na pagina 7 e no indice
> 4.1.8 mostra que a posio 05-05  DV Geral e 06-09 fator vencimento e
> 10-19 valor documento.
>
> O que est acontecendo ? Ja visse algo assim ? Estava pensando em
> reformatar para o padro fornecido, mas depois que eu comparei o Ecobranca
> fiquei despreocupado, porm o mesmo no conseguiu gerar o exato mesmo
> boleto. Ficou parecido.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mrbongiolo/brcobranca/commit/0644450dbbd558253336e82879d03aa006c3cc35#commitcomment-1023963
>
Не стоит, больше мороки, чем практической пользы.
Can you also push this to the _dev  branch, please?
@Brettflan To stop it damaging mobs and players add this after event.setCancelled()

exploitExplosion.setIsIncendiary(false);
exploitExplosion.setYield(0);

That should hopefully fix it.
I understand, however the semantic of template is already provided with the annotation.
If once need more meaning, I would change the method to `allTokens()`
What do you think ?
Redis is connected to once for each instance of RedisClient. A redis connection is stateful, so we have to do it this way; otherwise if someone subscribed to a channel, then no one would be able to call get, set or almost anything else.
Nice to know that it's fixed now.
Note to self: Super Mario Kart with MSVC build still works here.
Maybe log it? Even if we don't, this should be `except StandardError:`
Hahaha! Ok, that was a "max" as in enum-max, not something meaningful in ECL.

I'll change that and separate the max from the rest (with a comment) to make it clearer.
Another candidate for properties. ;)
So you force a read before an update right? Is that always a remote read? Or is there a cache in MongoDB's driver?

Can't you cache the `DBObject` in `MongoDBTupleSnapshot` and retrieve it from there? That would avoid this unnecessary read.
There are a few problems with conversion between Table dates and Java dates:

1. The long pattern ("SSSSSSS") does not correctly serialize/deserialize milliseconds in Java. The problem is the SSSSSSS (which is also used in the link below): Java uses those for milliseconds, so there really should be exactly 3.  This ib because SSSSSSS will parse "0.0000001" (100 nanoseconds) as 1 millisecond (with 6 leading zeros)
2. Even SSS will write out 0.002 seconds (2 milliseconds) as "2" (without leading zeros). 
3. The also highlights an issue with lossiness: Java only supports millisecond accuraccy in Date, so the extra precission stored in the table is inaccessable to Java clients.

Someone else encountered a similar problem with formatting 10 years ago: http://www.velocityreviews.com/forums/t141682-simple-date-format-milliseconds-with-more-precision.html. Sadly this is a "feature" of the Java spec.
Asfoooooooo, ¬¬ no comentes que ya lo reparé ¬¬
Hmmmmmm.... ;)
Hi, the keepers (Thorim, Hodir, Freya and Mimiron) do not go, and the immortal npc either, could you tell me how to fix this? thanks :)

Sorry for my bad english.
cuando termines de hacer cambios me dices y lo meto
I agree with @millermedeiros: the problem can be fixed by also exporting the global in addition to the define() call. To be clear, this code change was not for supporting a particular script loader, but a class of script loaders that support modular code. It is difficult upgrading the web, and while ideally underscore would not need to export the global if AMD support is on a page, there is a bootstrap period where it helps.

I hope this code change is reconsidered, feel free to ping me if there is a way I can help.
Looks like you did it: eda7755f3b450f447b054e91654121de9976f3ec and then undid it: 48216cc412acdd774a57374ac010c47e26f15898
when should the updated binary be ready for testing? couple of users noticed there have been changes and can't enable auto-block anymore
Oh ok, sounds good
code is duplicated here. why not using already existing function SetLabelArray ?
Вобщем, проверь на своей опере 9, что быстрее. Всё равно в остальных браузерах есть нативная поддержка trim.
I don't see any reason to have this variable...
+1 to this not reporting 28 failures on success!
There are lost of "Undeclared identifier" in VS 2010. Such as "error C2065: SMSG_GUILD_CRITERIA_DATA ......".
musst einfach im texteditor option die  tabspaces durch 4 mal leerspace ersetzten ;)
It's a trick for decoding http encoded strings.

For example: Hopstock%20Gjestenett becomes Hopstock Gjestenett 

And we get to support essids with spaces in their names. http://webconverger.org/wireless/
Oracle only supports the INSERT INTO tablename(field1,field2,...,fieldn) format
@dumptruckman Make sure you have IntelliJ set to highlight deprecations in an obnoxious color. I also wrote a "deprecation report" (report you can run that shows all deprecated methods you're using) if you'd like. I find it helps a ton.
add this for better performance, graphic and audio
BOARD_AVOID_DRAW_TEXTURE_EXTENSION := true
TARGET_OVERLAY_ALWAYS_DETERMINES_FORMAT := true
TARGET_USE_SOFTWARE_AUDIO_AAC := true
BOARD_FORCE_STATIC_A2DP := true

since cyanogenmod has merger ICS trantition and rotation, we need this :)
It will also break if the user does not have permission to view the 'task' attribute. I'm not a huge fan of silently omitting fields but if that is the plan this will need to check if the field exists and return early if not. I can make the change as part of #52.
Estoy haciendo algunos cambios y mejoras en esta parte. Así que aprovecharé y arreglaré esto en un próximo Pull Request ;)
why still need fsoption2?
This looks good to me, but shouldn't the detection/possible validation be done by openstack and let fog be a dumb client and assume that OpenStack is giving back the correct values?

Or at least there is a limit to what must be checked and ensured.
Consider proposing upstream. Or maybe this is just a local hack.
this should have a more descriptive name - perhaps `egg_basename`
It's `Parallel` with success, failure and progress :)
The attribute should be applied to <input>, not <div>, so it must be specified in template.
The OAuth server support is tiedly linked to the CAS protocol (OAuth code = CAS ST / OAuth access token = CAS TGT) and therefore needs to access to the ticket registry.

Why don't you want that these controllers access directly the ticket registry ?
make absolute and move to top of file
Well, of course, it just doesn't give any nice error message on what is asserted.
Should be documented that it creates a new instance every call.
Always good idea – and indeed: found a bug. Two more tests are in now.
Ties into this: http://www.assembla.com/spaces/akka/tickets/2205
Sounds … strange (given that we do support other traits). How would you word it?
Immutable. Good.
This is where WikiContent does the initial parse, masking the chunks.
We don't use this for ObjectContent.
This can be converted into:
```
return isset(static::$_primary_key) ? (array) static::$_primary_key : array('id');
```

The check above can be removed.
what do you not like about this? the name tmp?
improper use of gettext. Needs to be called on the string itself, not a named variable.
find_superclass_method below should also set this and become lazy.
looks wrong,  mixing i's and id's.
Default to 1
This also brings up the idea that since some of these functions dont NEED to be in a class (because they dont use member variables) they can be factored out into module-level helpers. (not part of the class)
You mean, `sum(1 for _ in values)`?
вместо `local(...) this.apply()` уже давно можно писать просто `apply(... тут присваивания из local ...)`
Space after 'url':.
Oh, how do I go about changing this? The inspector panel?
fixed. Thanks for reviewing, Ben.
The spacing is all wonky here. They should probably be aligned.
Since this rejection function and the other rejection function are now identical, does it make sense to refactor it such that it's just passing (say) a direct reference to a suitably-modified `_rejected`?
BUG: output_spec = AFNIPrefixOutputSpec
The PyArray_DATA raised an error after the change to returning ``void*``, so I changed it to use ``PyArray_BYTES``
What is the purpose of this?  Synchronicity of the queue should depend on the queue.
I think is better to remove `:phone_number` from the `store_accessor`
Some people really really really hate unless/else, but it doesn't bother me.
This one was already in the original source :P
I think here should be:

```ruby
if (attr != rounded_time) || (!attr && original_time)
```
Maybe a code comment would be good, because the next guy looking at the source code will wonder the same (and will refactor it).
I guess this should be empty?
Style: please add spacing on default arg.  `dirs = ...`
I can change the EXCLUDED_DIRS to something more generic and add the .gitkeep on that. Is it ok for you?
Gotcha.  We'll have to do an intercept refactor later.
On Thu, Jul 26, 2012 at 8:07 PM, Paul Phillips
<reply@reply.github.com>
wrote:
>> @@ -112,11 +112,23 @@ abstract class SymbolLoaders {
>>      enterClassAndModule(root, name, new SourcefileLoader(src))
>>    }
>>
>> +  /** The package objects of scala and scala.reflect should always
>> +   *  be loaded in binary if classfiles are available, even if sourcefiles
>> +   *  are newer. Late-compiling these objects from source leads to compilation
>> +   *  order issues.
>> +   *  Note: We do a name-base comparison here because the method is called before we even
>> +   *  have ReflectPackage defined.
>> +   */
>> +  def binaryOnly(owner: Symbol, name: String): Boolean =
>> +    name == "package" &&
>> +    (owner.fullName == "scala" || owner.fullName == "scala.reflect")
>> +
>
> I'm thinking of the guy who is trying to debug why scala.reflect has different behavior from scala.frotz.  It's not like it's going to be obvious that scala.reflect is hardcoded to behave differently.  With a config file at least one can say "things which are treated differently in arbitrary-seeming ways are enumerated in this file" and one isn't left tracing through 100K lines of compiler source.
>

It's a trade-off. But I think it is pretty plausible that the
core-of-core packages scala and scala.reflect get different treatment.
They are not the same as your run-of-the mill package. So think the
best we can do is being loud and clear at the point where packages are
loaded. Putting things in configuration files makes them look more
general than they are and introduces another possible point of
breakage. Concentrate information in one point, is my motto here.

Cheers

 - Martin


> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scala/scala/pull/998/files#r1246620



-- 
Martin Odersky
Prof., EPFL and Chairman, Typesafe
PSED, 1015 Lausanne, Switzerland
Tel. EPFL: +41 21 693 6863
Tel. Typesafe: +41 21 691 4967
"having its name set to nme.ANON_FUN_NAME"

I'd delete this part, because we no longer expose ANON_FUN_NAME in the API.
How about adding a different setting? I assume 2.10.0 will be out with the old semantics for this command line option, thus it would be reasonable to have a deprecation cycle. WDYT?
so why not reuse the same symbol while we're at it?
For example:  if skew = [-0.1, 0, 0.1], the rv_continuous._argcheck was returning [False, False, True] which would mean the the return from pearson3.pdf(1, [-0.1, 0, 0.1]) would be [nan, nan,  0.23413173]).  The pearson3._pdf wasn't even called with the 'bad' skew arguments.  Basically I want any skew to be accepted.  So I need pearson3._argcheck to return an array of True values equal in length to the length of skew.
I moved this up to Sparse and got rid of ImmutableSparse's `__new__` method.
Well, they are the only ones that had to be changed.
just for me...
Fxied nl(s)
Sounds good.  I'll switch it to void.
Alright, but we will need documentation that ACS only redirects to HTTPS:// which means that they must set the return URL to something encrypted
Should probably be `null` instead.
`{` on new line?
Probably need to add an interface to define the "abstract" methods.
Upper case AND
Avatar, being an image, does not have a template file. Avatar drivers may have template files.
Missing comma .. 'ACP_LANGUAGE',
Conversions?


On 1 May 2012, at 13:35, Andreas Fischer
<reply@reply.github.com>
wrote:

>> +            {
>> +                $unapproved_topics_array[] = (int) $row['topic_first_post_id'];
>> +                $unapproved_topics_count++;
>> +            }
>> +            $db->sql_freeresult($result);
>> +
>> +            if(sizeof($unapproved_topics_array))
>> +            {
>> +                $sql_where .= ' AND ' . $db->sql_in_set('post_id', $unapproved_topics_array, true);
>> +            }
>> +        }
>> +
>> +        // Reported Posts and Approved Posts
>> +        $sql = 'SELECT post_reported, post_approved
>> +                    FROM ' . POSTS_TABLE .
>> +                $sql_where . ' OR (forum_id = 0 and post_reported = 1)';
>
> Can `forum_id = 0` on develop?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/780/files#r755535
This should not be done.
Needs a phpbb prefix.
I think your pull requests can become more focused. They ought to represent solutions to specific problems, and thus be easy to evaluate. Good practice is especially important since the cache is a new design that you want reviewers to think clearly about.

For example, put file and variable rename stuff like this, especially if it fixes bugs, onto its own branch and get that into master before conflicts happen for others.
Do we need a second code path for an endpoint list that is specified without a SRV record for testing?
lasă {% url logout_view %}
La fel, Edit Spell
This can throw IllegalFormatException, you should mark as throwing, or something like that. Especially as you commented that it's to verify that they didn't mess it up. Also, may want to link to String.format in the javadoc, to make the formatting method clear.

I take it that setting to null is when you don't want a message to be sent, right?
Make a ticket. How can we abstract `hasMany``` with OpenMRS's REST api to work better across the system?
Sure. I did a simple test using 32-bit floats:

    import numpy as np
    lat = np.arange(-90, 90, 73, dtype=np.float32)
    wgt = np.sqrt(np.cos(np.deg2rad(lat)))

and the first and last elements are `nan`. How would you test for something other than numerical precision, I guess use a threshold?
For my own education, could you explain why this clipping is necessary. If latitude is well formed and therefore has values in the range [-pi/2, pi/2] I'd have thought ```numpy.cos()``` would return values in the range [0,1]. If it is not, I'd like to know about it rather than the error being hidden.
Wont cover the case when xlim is None, but ylim is not.
let's use standard terminology...

\Sky\Memcache::begin();
\Sky\Memcache::set($key, $value); // what about mulit-key support?
\Sky\Memcache::commit();

\Sky\Memcache::begin();
\Sky\Memcache::set($key, $value); // TODO mulit-key support
\Sky\Memcache::rollback();

TODO nested memcache transactions
a变量这个变量名不好。
There could be more then 1 op in the graph... But yes, when there is only one, we could do that. I keep that for later when I work on it again (or someone else)
Will wildcards like doc/tutorials/*/*.jar be too wide for these?
Why move the includes? I normally prefer sys includes at the top so local includes weirdness can't mess up their defines. Other thoughts?
The operator goes on the previous line.
is it necessary here?
pandas won't be third faction, they will choose which side to join, just FYI
ignore wheel scrolling when the scrollable area is smaller than the wrapper (I seem to recall)
Should "Web" really be capitalized? Same thing two lines below.
i totally agree with you. i'm just wondering why you typehint \Closure in EntityManager and Connection? Is there a good reason why a concrete class should be more specific than an interface?
My thought was we should just revert the sample to the state it was in before I introduced the reorderable/swipeable behavior. I still don't know the easiest way to do this with git.


On Dec 18, 2012, at 9:14 PM, "Ben Combee" <notifications@github.com<mailto:notifications@github.com>> wrote:


In list/samples/ListContactsSample.js:

>                               {name: "divider", classes: "list-sample-contacts-divider"},
>                               {name: "item", kind: "ContactItem", classes: "list-sample-contacts-item enyo-border-box", onRemove: "removeTap"},
> -                     ], reorderComponents: [
> +                     ]/*, reorderComponents: [


Can you just delete these lines instead of commenting them out?

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/layout/pull/115/files#r2459583>.
Boo, I was right. To reproduce:

* Fab task hitting some remote server running e.g. `run("sleep 15")`
* While that is running, pull your Ethernet/disable your wifi
* Wait
* Keep waiting
* Put your laptop down for 10 minutes
* Come back, it's still waiting
* Make a sandwich
* OK, it must have noticed by now!
* Nope, still waiting.
* :sweat:

----

So I guess I'd like you to clarify exactly what the explicit short timeout + ignored `socket.timeout` stuff is for.

If there's nothing coming down the pipe, us attempting to force a short timeout, ignore it, then try reading again -- doesn't seem like it would help any vs: normal length timeout, which will naturally show up if we get nothing within X time, implying something is wrong.
I agree that this mechanism could be abused to give a project with low coverage a false sense of security. However, I think there are at least two main concrete benefits:

1) Any measure of code coverage less than 100% is imprecise. In a 10K line project with a coverage target of 90% you will meet this target with both 9010 or 9000 lines of coverage - any unexpected changes to coverage won't necessarily cause you to violate a coverage target. However, there may be certain line within a project that are crucial to get coverage of.

If you have 100% code coverage (using source directives) then even a single line of missed source will cause you to miss your target.

2) Using source directives makes it clear during code review which lines of code do/don't have code coverage.

Finally, I could add an option to the report task to enable/disable source directives with the default being disabled. This would mean developers would explicitly have to opt into using source directives and they could even generate a second report with source directives disabled to allow the true coverage to be tracked.
Ha, it works without URL encoding.
I don't have a problem with dot syntax, but it doesn't work on id pointers, necessitating this change.
As a side note, pep-257 recommends a blank line between the end of the docstring text and the end triple-quote. It makes fill-paragraph in Emacs work correctly.

I don't think it's that important to be strict about doing it one way or the other and I wouldn't adjust your pull request. However, that's why I keep adding them.
Since `Xformer` is only used in the `{ok, Results}` branch, we could move this there. I think that helps readability and is nice to avoid throw-away work.
Shouldn't this be a random generated string
yub, thx
`OldTest::test15` is duplicate of https://github.com/pornel/PHPTAL/commit/ee26c7165cd4e9002b2088632a4b75f441f7be86#L2R69 .
And that old test  is now incomplete, it should be replaced by newer, I think.
Don't commit commented out code. If it's unnecessary, remove it
The errors thrown by this method should be documented.
Inhaltlich hatte ich mir rex-url als Aufsatz auf rex-path gedacht, also quasi eine speziellere Art der Pfadausgabe (und es war so recht praktisch ;)).
Aber du hast Recht, rex-url hat jetzt eigentlich zu viele Methoden, es machen ja nur die öffentlich zugänglichen Pfade Sinn. Es müsste also wenn eher umgekehrt vererbt werden (die rex-path-methoden sind eine obermenge der rex-url-methoden), passt aber inhaltlich noch weniger würde ich sagen ;)
Was schlägst du vor? Man könnte eine gemeinsame Oberklasse machen (bloß mit welchem Namen?), oder halt die Methoden einfach in rex-url kopieren.
how do i create a new revision here, as if validating the previous edit? i sent the added text to the conflict controller, but not the actual submitted edit form, from which we create the revision in actionEdit.
Do we need both `cabbage-vendor-dir` and `cabbage-vendor-dirs`? I think we should settle on `cabbage-vendor-dirs` only.
Right - saves a cycle.
I believe that using --owner could always be done (root or $dstuser)

I think we can even setup dstuser=root, if dstuser is not given
Uh oh. Okay, I think I'm confused by this point. I thought I wrote a unit test that shows preferences like this do indeed succeed. Can you verify the test document I created in TransformerTests.js at lines 91-116? Is that the kind of situation you're worried about. And if it passes, is it passing falsely?
the license will be removed
@dsaff 
see my latest update
You do not need this field; `fListeners` is final, and `SafeNotifier` is an inner class.

If you are doing this for performance reasons, then I suggest declaring this as a final local variable just inside of `run()`
Won't this cause an exception to be thrown the next time through the loop, now?
Couldn't you just annotate `FixMethodOrder` with `@Inherited`?
Yes, that's actually what I meant with my comment. Reading "x is five" is perfectly clear.
We've settled on `'` over `"`, it's not cleaned up everywhere, but 99% of new code getting created uses `'`
Is there any reason to use the `Boolean` wrapper class here? :squirrel:
That makes sense. I think you could handle it like this to avoid the race condition:
```
public GenericTableEntity GetEntity( string rowKey )
{
   try
   {
      return _entities[rowKey];
   }
   catch( KeyNotFoundException )
   {
      throw new EntityDoesNotExistException();
   }
}
```

I think it's fine if you still want to use the lock though.
I'm not sure why these are getting a gradient background—they should have the same background and basic styling as other child nodes. There's a mixin for this in a separate pull request of mine that's being held up—I'll try to separate it out and merge it into master.
This is the same logic that is used for an initial connection.
Minor naming nit: these two vars are not types, and should not be capitalized.
Aha, so that's the rationale. But other identifiers have them, right? So what happens if you try to complete say `className431color`? Does that work correctly?
We should do a partial for this part, but we can do this later.
As the URL here can contain not only host/subdomain but also directory name - so it is fully qualified URL.

Why we want to strip protocol here if the default one in CLI env / satis is not obvious?
mock.call is a feature of the mock module version 1.0 however the version shipping with Ubuntu 12.04 is 0.7.1 (just tried apt-get install python-mock). What's the policy in such cases?
Can you change this to `<span class="username">` and then use `font-weight: bold`?
This is not wrapped in best way. If you want, you can wrap (and indent) arguments to SelectDateWidget again. But not like this.

Also do not forget comma at the end.
Fixed and made translatable.
Indentation! Still!
Just `image`?
I agree with @zacc here, this looks like a maintenance burden. I would say we should use the visibility of elements within tests.
"We found a backup for {title} from {time} ago."
for this src attribute and all others, only include the .woff and .ttf versions of files.
The indentation is wrong here too, I think. I can only tell because there is a large difference between the beginning this line and that of the one below it.
Looks like you neglected to rename the custom renderer, having changed the name of the widget. You might want to bring it more in line with the widget.
It's a wrong place to bind events. The load functions can be called multiple time (e.g. when opening file using "open file" button on demo page), which  will cause to bind the click event more than one time.
Perhaps a better rule of thumb is that 'and' and 'or' are mainly for conditional execution of one statement depending on the return value of another statement, relying on the expression short-circuiting behaviour of these operators that many programmers have gotten used to.  It's not terribly explicit, though - I'm not a big fan.
`exports.api = require('./borschik').api;`
>neodpovídá aktuální funkčnosti,

>>???
Tlačítko přidává soubory, ne adresáře

>>navíc jde o popis tlačítka.

>???
Tady mám na mysli originál, má tam být "Adds..."
Good point. I generally do not use this kind of indentation, but looking at things more closely, that is being used here.
Have consistent names for the variables. Len or Length
I ran some tests with the modifications.  Overall, it behaved well; however, I noticed if a user attempts to install multiple packages (e.g. xterm, unknownpkg) and one of those packages is invalid (e.g. unknownpkg), the request will fail with an indication of "No package(s) available to install".  I would have expected the valid pkg (xterm) to still be installed.
I had to look up #& because I've not seen it used before. Very neat though.
This variable can just be tacked onto the previous variable list for minification instead of using a new var declaration.
Are these console.log statements something you intended to check in?
Lets map the escaped word so that we don't end up creating so many strings.
Can you move this code inside the ScreenManager.toggleScreen method?
TEST_AGENT_SERVER is actually an env to specify the web socket server IE:

ws://127.0.0.1:8789
Would be nice to document this behavior in the docstring.
impl**e**mented
Can you rename this class `FLRWCosmology` or something like that?  As I mentioned earlier, I think `Cosmology` should be reserved for a (future) base class that might be generalizable to other types of cosmologies (like fractal, or modified gravity cosmologies and the like)
This one could be generated from the #defines in version.h, but as I can't include that without breaking the windres compiler, this is a no-go :-/.
As we Shutdown here this is clearly not a warning ;).
It's in the email copy not on 123done.
i think you can just do `@motions_closed.exists?` instead of `@motions_closed.size > 0`
No it wont, just do it the way I originally had it, with a cached property that holds the compiled regex... Or, don't even care about it because Python interns compiled regex objects for some N number of strings.
I would recommend using a globals.php file (like we do now) and a globals_<environment>.php file. The globals_<environment>.php should override the globals.php file.

Something like this: https://github.com/symfony/symfony-standard/tree/master/app/config

I'd store the database information - and everything else that shouldn't be versioned - in another file. (Symfony Standard uses parameter.yml, maybe we could implement this as well)
we could indeed affect the retVal variable but in practice the return code will always be 0 (or GitTfsExitCodes.OK). In other case, there will be a GitTfsException() thrown...
But I will add it (for the futur and because it's more logical).
See our developer docs for [guidelines on docstrings](http://ipython.org/ipython-doc/stable/development/doc_guide.html#docstring-format)
Windows doesn't have signal.SIGKILL (TERM is equivalent to KILL on Windows).

Perhaps reorganizing a bit so that you are calling the p.terminate() / p.kill() methods on the Popen object itself, which hide the platform differences.
(and I know, I've used `None < everything` myself a bunch, and I really hate the change, but we have to live with it)
Note that with action append, it's possible to just call this multiple times.  Users can pass `-i x -i y -i z` as well.  I think you should either handle that case, or switch to a simple str type instead of an append type.
Does this need a @Test annotation?
Changing this properly involves changing the super-type ParamsType, and thus its 13 sub-types. That includes code already in master, so I'd prefer to do those refactors in a separate pull request that cleans up all (?) the builders in one go. Is that ok with you, to take this code into master and then fix it subsequently?
this `if` is unnecessary.
Bro what the fuck
It seems like a bad good design for public interface to extends from Serializable. We should rather have a Serializer interface that can serialize SenseiMapReduce, which also allow us using different serialization strategy.
ACK

On Thu, Nov 22, 2012 at 01:52:24AM -0800, Ivan Necas wrote:
> > @@ -125,7 +129,7 @@ if [ -z "$SOURCE_NAME" -o -z "$TARGET_NAME" ]; then
> >    exit 1
> >  fi
> >  
> > -SOURCE_IMG=$BASE_IMAGE_DIR/$SOURCE_NAME.img
> > +SOURCE_IMG=$(ls -v1 $BASE_IMAGE_DIR/${SOURCE_NAME}*.img | tail -n1)
> 
> I haven't included the dash there, because in that case `rhel63-base.img` would not be found.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lzap/snap-guest/pull/7/files#r2203936

-- 
Later,

 Lukas "lzap" Zapletal
 #katello #systemengine
This is another case where we need an ORM and I'm strong arming some thing together. What this allows is inside an template we can do `messages.channel` vs `messages.first.channel`. What we really need though is a messages class that respond to `#each`.
Is this correct? It looks like you specify the time zone is UTC then assert the value is local.
Does changing the poster add an extra http request though?
I wonder if this page might work a bit better of the right column were a span(3) rather than a span(2) now that we have a 12 column grid. The 2-column sidebar is a bit tight.
Oh, cool. That's less disruptive then. Whew!
I think I've got a solution without changing configman.  Each time configman applies a converter function that returns a class, we've got the opportunity to introduce new options, aggregates and namespaces.  The `classes_in_namespaces_converter` demonstrates that we can dynamically create a new class that will give configman the opportunity to pull in the requirements of a list of classes.  In that converter, we fall back on the default behavior to have configman pull in the requirements for the list of classes.  We could have the converter pull in the requirements of the subordinate classes instead.  That gives us the opportunity to vet the requirements: throw some away or create new ones.  See this converter: http://hastebin.com/toxiwimaji.py

here's a demo program that uses it:  http://hastebin.com/hakudopeje.py

run the demo with the --help

notice that the converted figured out that the option `x` was present in the class `A` and therefore didn't put it into the namespaces for `B` or `C`.   When `B` and `C` are eventually instantiated and try to look at the value of `x`, they'll find it in `config` by acquisition.
that turns out to not be true.  those var names are not original to web.application, but my own additions and should have been candidates for PEP8ing.  re-examination of this class hierarchy is now underway.
Hey Ryan - what's this do? Is it part of the tabs feature?

Adam
This is a bit ugly but it needs to be here so the data is valid during the time we use data* that is set to point to the crn uncompress buffer if conversion is done.
The main reason for this is, that I'm lazy quite often and run the tests from any directory (not only the test directory ...). For example the following code does not work without this inclusion:

phpunit test/lib/Elastica/ClientTest.php
You might want to also fix this old typo here: "from methods from methods"
можливо стара логіка. колись створювалася нова оплата щоразу як ти натискав оплатити і для одного квитка могло бути кілька пейментів. потім я це здається переробляв
You missed `_sf2_metadata`
an upgrade instruction starting with ``Added`` looks weird to me.
@stloyd is right
The is_callable calls are needed to be able to tell if those magic "methods" were actually implemented or not on that class. You should see the latest commit, it's probably a bit clearer in that :).
@hason please change it to return 1 in both cases as returning 2 is wrong according to its meaning
what about introducing constants here ?
yeah, i think it would be better to thread a Node through where the exceptions are thrown, so that it's obvious that every place that throws one of these exceptions will attach position info at the time. it's less clear when it's being handled only at apply(FieldType).
Could it just be exercise?
toggle is good name if there is no argument, but when there is `hidden` argument it's not that obvious what this means: `[self togglePlaceholder:YES]`.
Previous method name gives more meaning, or `setPlaceholderHidden:` (`[UIVies setHidden:]`) could be better too.
doesn't receive vendor prefixes
I suppose I was curious as to whether the change was needed for some reason and was hiding something non-obvious! If not, then I'm happy with it now having the default value.
I think you spelled it wrong...
why not return a promise? :)
Move this into `_drawButton`.