Structure check hoisting should abstain if the OSR entry's must-handle value for the respective variable has a different structure
https://bugs.webkit.org/show_bug.cgi?id=95141
<rdar://problem/12170401>

Reviewed by Mark Hahnenberg.

* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] V8DOMWindowShell::setContext has no callers
https://bugs.webkit.org/show_bug.cgi?id=95147

Reviewed by Kentaro Hara.

Dead code is dead.

* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix CSSParserValue::createCSSValue() for viewport based units.
https://bugs.webkit.org/show_bug.cgi?id=94772

Reviewed by Tony Chang.

Source/WebCore:

Viewport units were not added to CSSParserValue::createCSSValue(). This patch handles that case.
Patch also converts from list of if clauses to a switch statement to catch future errors.

Test: fast/css/variables/calc-vw-crash.html

* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):

LayoutTests:

Add test that uses variables, calc and viewport units together.

* fast/css/variables/calc-vw-crash-expected.txt: Added.
* fast/css/variables/calc-vw-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] V8DOMWindowShell::installDOMWindow is subtle and should explain itself more
https://bugs.webkit.org/show_bug.cgi?id=95151

Reviewed by Kentaro Hara.

This patch adds some text to V8DOMWindowShell::installDOMWindow that
explaining what this code is doing. I've also renamed some variables
and created a helper function in an attempt to make it clearer what's
going on.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::toInnerGlobalObject):
(WebCore):
(WebCore::V8DOMWindowShell::installDOMWindow):
(WebCore::V8DOMWindowShell::updateDocumentProperty):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Add some #includes that were implicitly picked up to CCScrollbarGeometry*
https://bugs.webkit.org/show_bug.cgi?id=95158

Reviewed by Adrienne Walker.

These includes are picked up implicitly, better to #include them explicitly to be more robust to refactors.

* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp:
* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:
* platform/graphics/chromium/cc/CCScrollbarGeometryStub.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add new file to xcode project -- Update to Bug 95107
https://bugs.webkit.org/show_bug.cgi?id=95155

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-27
Reviewed by Tim Horton.

Add LayoutTypesInlineMethods.h to xcode project file.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Even more unreviewed rebaselining after r126683.

* platform/chromium/TestExpectations:
Rebaselined 30 tests (see the new common baselines below).

* animations/cross-fade-border-image-source-expected.txt: Renamed from LayoutTests/platform/efl/animations/cross-fade-border-image-source-expected.txt.
* css1/box_properties/border_bottom-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_bottom-expected.txt.
* css1/box_properties/border_bottom_inline-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_bottom_inline-expected.txt.
* css1/box_properties/border_left-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_left-expected.txt.
* css1/box_properties/border_left_inline-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_left_inline-expected.txt.
* css1/box_properties/border_right-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_right-expected.txt.
* css1/box_properties/border_right_inline-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_right_inline-expected.txt.
* css1/units/length_units-expected.txt: Renamed from LayoutTests/platform/efl/css1/units/length_units-expected.txt.
* css2.1/20110323/absolute-replaced-height-036-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.txt.
* css2.1/20110323/block-non-replaced-height-007-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-007-expected.txt.
* css2.1/20110323/block-non-replaced-height-008-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-008-expected.txt.
* css2.1/20110323/block-non-replaced-height-009-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-009-expected.txt.
* css2.1/20110323/block-non-replaced-height-010-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-010-expected.txt.
* css2.1/20110323/block-non-replaced-width-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-001-expected.txt.
* css2.1/20110323/block-non-replaced-width-002-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-002-expected.txt.
* css2.1/20110323/block-non-replaced-width-003-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-003-expected.txt.
* css2.1/20110323/block-non-replaced-width-004-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-004-expected.txt.
* css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-008-expected.txt.
* css2.1/20110323/margin-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/margin-applies-to-008-expected.txt.
* css2.1/20110323/width-non-replaced-inline-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/width-non-replaced-inline-001-expected.txt.
* css2.1/t040302-c61-phys-len-00-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t040302-c61-phys-len-00-b-expected.txt.
* css2.1/t0804-c5507-padn-r-02-f-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0804-c5507-padn-r-02-f-expected.txt.
* css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt.
* css2.1/t0804-c5509-padn-l-02-f-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0804-c5509-padn-l-02-f-expected.txt.
* css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5519-brdr-r-02-e-expected.txt.
* css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt.
* css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5520-brdr-b-00-a-expected.txt.
* css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt.
* css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5521-brdr-l-02-e-expected.txt.
Common baselines for the tests.

* platform/gtk/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/gtk/css1/box_properties/border_bottom-expected.txt: Removed.
* platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Removed.
* platform/gtk/css1/box_properties/border_left-expected.txt: Removed.
* platform/gtk/css1/box_properties/border_left_inline-expected.txt: Removed.
* platform/gtk/css1/box_properties/border_right-expected.txt: Removed.
* platform/gtk/css1/box_properties/border_right_inline-expected.txt: Removed.
* platform/gtk/css1/units/length_units-expected.txt: Removed.
* platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt: Removed.
* platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt: Removed.
* platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Removed.
* platform/gtk/css2.1/t040302-c61-phys-len-00-b-expected.txt: Removed.
* platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Removed.
* platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Removed.
* platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Removed.
* platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Removed.
* platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Removed.
* platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Removed.
* platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Removed.
* platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Removed.
* platform/mac-lion/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/mac-lion/css1/box_properties/border_bottom-expected.txt: Removed.
* platform/mac-lion/css1/box_properties/border_bottom_inline-expected.txt: Removed.
* platform/mac-lion/css1/box_properties/border_left-expected.txt: Removed.
* platform/mac-lion/css1/box_properties/border_left_inline-expected.txt: Removed.
* platform/mac-lion/css1/box_properties/border_right-expected.txt: Removed.
* platform/mac-lion/css1/box_properties/border_right_inline-expected.txt: Removed.
* platform/mac-lion/css1/units/length_units-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/absolute-replaced-height-036-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-height-007-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-height-008-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-height-009-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-height-010-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-width-001-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-width-002-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-width-003-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-width-004-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/block-non-replaced-width-008-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/margin-applies-to-008-expected.txt: Removed.
* platform/mac-lion/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Removed.
* platform/mac-lion/css2.1/t040302-c61-phys-len-00-b-expected.txt: Removed.
* platform/mac-lion/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Removed.
* platform/mac-lion/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Removed.
* platform/mac-lion/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Removed.
* platform/mac-lion/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Removed.
* platform/mac-lion/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Removed.
* platform/mac-lion/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Removed.
* platform/mac-lion/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Removed.
* platform/mac-lion/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Removed.
Removed those baselines as they are properly covered by the fallbacks.

* platform/chromium-linux-x86/fast/css/line-height-determined-by-primary-font-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt.
* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/chromium-win-xp/fast/css/line-height-determined-by-primary-font-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt.
* platform/chromium-win/animations/cross-fade-border-image-source-expected.txt:
* platform/chromium-win/css1/box_properties/border_bottom-expected.txt:
* platform/chromium-win/css1/box_properties/border_bottom_inline-expected.txt:
* platform/chromium-win/css1/box_properties/border_left-expected.txt:
* platform/chromium-win/css1/box_properties/border_left_inline-expected.txt:
* platform/chromium-win/css1/box_properties/border_right-expected.txt:
* platform/chromium-win/css1/box_properties/border_right_inline-expected.txt:
* platform/chromium-win/css1/units/length_units-expected.txt:
* platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.txt:
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt:
* platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
* platform/chromium-win/css2.1/t040302-c61-phys-len-00-b-expected.txt:
* platform/chromium-win/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
* platform/chromium-win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
* platform/chromium-win/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
* platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
* platform/chromium-win/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
* platform/chromium-win/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
* platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt:
Updated Chromium baselines as after r126683 the top border is always dumped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Crash in RenderTable::removeCaption
https://bugs.webkit.org/show_bug.cgi?id=95090

Reviewed by Abhishek Arya.

Source/WebCore:

The issue came from the caption addition logic not being called when
we move the caption due to being hooked on RenderTable::addChild
and not RenderTableCaption::insertedIntoTree. This change implemented
the previous hook and simplified our caption handling.

Test: fast/table/table-caption-moved-crash.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
Removed the add-a-caption code as it is now executed from RenderTableCaption::insertedIntoTree.

(WebCore::RenderTable::addCaption):
Added this helper method.

(WebCore::RenderTable::removeCaption):
Changed this function to be more bullet-proof. The old code was checking |index| as it wasn't
bullet proof so let's keep it.

(WebCore::RenderTable::recalcSections):
Removed the caption handling code as we should properly handle them now.

* rendering/RenderTable.h:
Added addCaption.

* rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::insertedIntoTree):
* rendering/RenderTableCaption.h:
Added insertedIntoTree.

LayoutTests:

* fast/table/table-caption-moved-crash-expected.txt: Added.
* fast/table/table-caption-moved-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126833 268f45cc-cd09-0410-ab3c-d52691b4dbfc