labofsahil/github-event-dataset-2012 huggingface dataset:
I noticed that you there is a variable called $SUBSONIC_USER renamed to $Subsonic_USER... however most other variables are renamed in this commit. Is this intentional?
Well, as you selected only 3 folders which are common in shinken install I though you had a special reason for making a "small" backup :)
Of course you can replace the 3 lines by "cp -Rfp $TARGET/* $BACKUPDIR/bck-shinken.$DATE/ " :)
One more small remark about the grid.custom.js module, but not about the current changes. It seems to me that the usage of `$.jgrid.jqID` in [the line](https://github.com/tonytomov/jqGrid/blob/master/js/grid.custom.js#L730)

    $(btbl).width(1).attr("id",$.jgrid.jqID($t.p.id)+"_frozen");

is incorrect. I suppose that one should just use `$t.p.id` directly.
Ok. Wasn't sure if I needed to do anything.
I question this commit in its entirety. What was wrong with the ascii clown?
prior to this change validateItem check happened in send method only, implemented on almost all sharers individually. If validate item was not OK, function returned and all sharing process stopped silently. As sharer retained self, there was a memory leak. To avoid a memory leak for this path in code, I decided to add validateItem check to share method too, prior to [self retain].

Now we do not retain self, and this check can be safely removed from the share method.

Just realized, that these two particular sharers have overriden validateItem method, which does not allow a picture without title (or status). So the problem you mentioned can have only those sharers with overriden validateItem method.
compromise noted and committed.
it is, thanks
Yes, we have, but I seem to have mixed things up a bit. `users_have_read` should be related to `Message`, not `MessageVersion` according to the agreed version of the specification. I will modify accordingly.
Isn't better leave that and only change The RemoveAura();
This PersistenceTest is failing with "No runnable methods"

https://hudson.qa.jboss.com/hudson/view/Drools%20jBPM/job/drools/lastCompletedBuild/testReport/org.jboss.qa.brms.persistence/PersistenceTest/initializationError/
do it, champ :D

-- 
More Cowbell


On Sunday, February 12, 2012 at 10:15 PM, Alexandre Fiori wrote:

> What about this https://gist.github.com/1811995
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/gleicon/freegeoip/commit/14c043f7d7cd0b178163cc4d73ae500d57136be7#commitcomment-958564
> 
>
This idea could also be patched directly in the ffi-rzmq gem. Change #setsockopt to call #to_i or #to_s (as appropriate) on the different option types to force them to the correct type.

The downside is that the method could now raise an exception if the call to #to_i/#to_s fails.
Oh , that is because before the code was changed, there was an "each" loop at the beginning. Now since it's gone, just change the break to this code:

if relationship_version.nil?
    activity[:what]='? <data untraceable>'
else
    cause_version=Version.find(:all, :conditions=>['item_type=? AND item_id=?', 'Issue', relationship_version.get_object.cause_id]).first
    issue_version=Version.find(:all, :conditions=>['item_type=? AND item_id=?', 'Issue', relationship_version.get_object.issue_id]).first
    if cause_version.nil? || issue_version.nil?
        activity[:what]='? <data untraceable>'
    else
        activity[:what]=cause_version.get_object.title + ' &#x27a1; ' + issue_version.get_object.title
    end
end
Haha, nice one
It worked! ;)
Why would you put there a for loop?
![jferris](http://g.images.memegenerator.net/instances/500x/14390422.jpg)
I'm not sure if other code uses e. There might be a good reason for different methods, but currently it does look WTF, considering method a (which, by the parameters, seems to be related to damaging a body part) calls the no-damage override
Ya, I think we posted at the same time. Tried your changes. much better now.

Thanks!


Steve Brueggeman


________________________________
 From: rypervenche <reply@reply.github.com>
To: xioborg <xioborg@yahoo.com> 
Sent: Monday, February 13, 2012 6:55 PM
Subject: Re: [solarus] Translation Update: Fixed boomerang (fad127a)
 
Just fyi, I did make a new commit with the fixes to that.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/christopho/solarus/commit/fad127a38282280937e8c949880045e5fb1277ce#commitcomment-962780
np, lol I figured that's what happened, I hope the current url is the correct place to post to
if (summon && (properties->Id == 65 || properties->Id == 428)) // Eye of Acherus, Raise Ally, Dream Vision, etc.
Fixed in https://github.com/ezsystems/ezp-next/commit/4a6e341eebfb18f0920e322fbc6dd03a87e04140
Hi saz,

I worked today on making a more generic framework in puppet's ruby dsl for my simpler services. That work is now here:
http://github.com/fprimex/fprimex-easysvc

Since I've completed an initial version of this module/define I unfortunately won't be testing or using your ntp module. If you would like, I will still submit a pull request and you can test my changes (or just go ahead and merge them).

Comments on my new module would be appreciated, if you are curious, since I am new to puppet. Thanks for putting your work on here. It helped me get started.
Sebenarnya ditambahkan, karena yang sebelumnya tidak ada marginTop yang menentukan jarak dengan bagian atasnya
Well, it's not particularly backward-compatible, although it would be easy for users to make that change.  But I'm not too worried about that particular kind of compatibility, so this should be fine.
Always one up-in' me huh - ya punk :)
FYI this code is incorrect and failed on some databases (MS SQL Server). You cannot compare a string an an integer.
This has been fixed in cad6f59804ed9c7850e26ad3df1fece634b4b355
Hi,

what happens if I before had an Option[List[Company]] => maybe(Company.simple * )

This doesn't work

((Company.simple ?) *)
But does it have its place in a consistency guide?
/shout just give me the default help thing and this commit breaks all of the prefixes.
This is good, but what about not running precompile task, if it is not needed? Example in this blogpost - http://www.bencurtis.com/2011/12/skipping-asset-compilation-with-capistrano/
Verbose or remove
I am inclined to agree - but current style is that MAX_ENCOUNTER and similar MAX_ values are always placed at the top.

Let me put it this way: a patch for all current has very high chances to be accepted fastly, but I am not motivated to do the actual cleaning :)
But no source for RC3, or a link to where it is stored?
This is wrong. There is an extra $attachments inclusion before $headers. This breaks HTML emails.
Jap, habs gesehen und schon übernommen.
Danke dafür.
```css
@media only screen and (min-device-width: 1024px) {
    html {
        padding: 70px 10px 10px 10px;
    }
}
```
The handler is never cleared when assigning a None property. Really, this check should exist inside wcmSandityCheckProperty.
The problem is that i needs it on cli, this change broke jUpgradeCli for migrations on the command line. The management of the params is the same using JRegistry?
yes, but i think it looks better with brackets :P
it should be
$comments = serendipity_fetchComments(null, $limit, '', true, 'NORMAL', $where);
instead of
$comments = serendipity_fetchComments(null, null, '', true, 'NORMAL', $where);
Oddy enough - Alien 3 also works on PS3 with the libsnes port in SSNES PS3 - it just doesn't work with the standalone PS3 emu port. I think it should be something that is set up wrong in emu-ps3.c - perhaps you can help narrow that one  down for m.e
oh haha nah I just noticed that code and was like wth why did I do that, it would only affect stuff like `?0` but I dont think we have to worry about that
In general, we prefer real use case object names. This helps people to understand the test and is sort of a doc.
I never understood why manually setting the serialVersionUID was a good idea in general. We don't in the project. It makes class compatibility change safer.
Please put your Chinese String into string.xml instead of java code directly.
Not clear for users? It's basically an internal workaround for not having javascript interface to outside code functionality. True, there could be a "not-implemented-yet" for else. This called gotoURL, which causes problems while page is loading.
That's really puzzling. I wonder why it's not sending anything
TODO: this charge drop can be handled by proc system, proc on explicit target of a cast, note is here, because the idea came to me just before falling asleep :)
same for all this
yeah, this was a quick and dirty solution. I think that Level really ought to do the drawing.
Ok. And what is mencoder command line with and without commit applied?
I'm trying to figure the difference.
Hmmm....., this whole section looks more like PHP-style. PHP has no symbols. Consider using symbols instead of string as hash keys. It would definitely be more like a Ruby-style (I think).
À enlever des fonctions admin_
Whoops, don't know why I typed 1463, I meant this fixes #1513!
One more non ob
Thanks.
But, actually it's about the version of SDK DLL that I use. I've manage to download the 2.6 version, and I can start the LiveView correctly. THanks
Interesting. Can we use the libs from the HTC Flyer Honeycomb firmware? It's Qualcomm based, but Adreno205. Not sure what's different between the Adreno200 and the Adreno205. The files in the Flyer ROM I found does end with _adreno200.so so I suppose the libs are for both 200 and 205?
I don't really understand the error:

    unittest
    Error: 'unittest' not found

But you do need the DLLs in the curl binary download to be somewhere in the path.  I've opted to place them in the bin directory along with dmd as that is going to most likely be in the path for windows users but you can place them wherever you feel most appropriate (Windows\System32 would work, for instance).
I completely agree with the intention of this patch, but am uncertain if this fixes it correctly.

The first change adds a second selector to firstTdChildrenSelector, but it seems the same selector. Did you mean to write 
    + ',tbody tr **th**:not(:nth-child(n+' + (settings.fixedColumns + 1) + '))'
instead of
    + ',tbody tr **td**:not(:nth-child(n+' + (settings.fixedColumns + 1) + '))'

As for the td+th: isn't that an [adjacent sibling selector](http://www.w3.org/TR/CSS2/selector.html#adjacent-selectors), thus matching a th which is preceded by a td, rather than what is probably indented (match either a td or th)?

My suggestion is to simply match all direct children of tr using the child selector:
    tbody tr:first-child > *

I've taken the liberty to apply patch b2a37e0 with child selectors in pull request #42
Don't you want to see it twice?
You must assume that GlobalSession is going to call you back at some point in the future. Your assertions will not necessarily run after all the work done in start() completes, unless you write your mocks such that that is the case. You haven't overridden start() anywhere in the inheritance chain of MockBackoffGlobalSession, so think what would happen if this were true:

<pre>
  public class GlobalSession {
    public void start() {
      new Thread(new Runnable() {
        Thread.sleep(1000);
        // Do actual work.
      }).start();
    }
  }
</pre>

Your assertions need to live in your callback, not here. This is one reason why I suggest parameterization of your mocks.
Again, if you see items that need immediate fixing, please indicate them as such, or better yet, address the issue at hand.
We can differ in opinion about the urgency of individual issues, I called the issues as I saw them and I don't think I removed any documented research. Feel free to evaluate things differently.

At the same time it is good to realize that Jenkins orders the comments as FIXME > TODO > XXX, where Eclipse sees them all as the same.
We could use that knowledge to our advantage to help us prioritize all open issues and get the most out of our servant.
It's probably wise to extend sorting to support sorting by any column in the data. This might be best exposed using a select drop-down box which has it's own value keys. You can then do model.get(the value) to easily sort by that column (field).
Yeah, hopefully this will make it more robust for future updates of Mac OS X.
There's not much there yet, I need to do some more work on it (I wrote it on a long Bart ride).  But the pfsd calculator is able to extract accurate times from rides, so it is something.
in here:
arch/arm/mach-msm/pm.c
WHY?
- */
and 
+ */

is that tupo???

Thanks.
@johnbintz I tried this out and it's working well. We'll give it a spin for the next couple of days and let you know how it goes. Thanks!
> but I'd prefer to not bring confusion in the first place.

How would you express that? I wanted to give the formal specification ("arg&lt;PARAMETER_INDEX&gt;") followed by an example ("arg0, arg1"). We might use "$PARAMETER_INDEX" as placeholder in the specification.
I agree.  I will implement full `#` support in the code and make test cases for `#`, `;`, and escaping for both.
Actually I didn't find out how. ActiveRecord::Base.connection looks pretty complex and I didn't have the time to take a look yet. You could however hard-code UTF-8 to have a quick fix.
this appears to break _attachments unless data is included as `new Buffer(js).toString("base64")` instead of `js.toString()`. does this code work as is for you?
var j, k, i = 300000;
	i = i/3;
	while(i--) { j = i*3; k = k + j; };
	Log('while(i--) { j = i*3 };')
	i = 300000;
	while((i -= 3) >= 0) { k = k + i; };
	Log('while((i -= 3) >= 0) {};')

while(i--) { j = i*3 };: 35ms
while((i -= 3) >= 0) {};: 37ms
Oh, could be. I don't know actually. But could we not include that in galaxyr.mk instead?
Just so you all know, we keep all images and assets on static.getnightingale.com - it is setup to force headers to cache everything for a long time unless it changes...

So...perhaps you could restructure this repo with your css and images all on the static subdomain...
It must mean author of plugin, not committer.
Am 01.01.2012 14:18, schrieb zachariasmaladroit:
> deep idle ist schon an, nur wird von den nstools ausgelesen, dass deep idle aus ist,
>
> "Deep Idle" Status "Off"
>
> wenn man auf "Idle Stats" geht, zeigt er aber eindeutig "Deep Idle (Top=ON)" 22342210 (ms)
>
> an,
>
> naja, wobei wir wieder beim Problem wären, dass es bei manchen Geräten zu funktionieren scheint, bei anderen jedoch nicht :/
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zachariasmaladroit/android_kernel_samsung_aries/commit/04f33dfc725d8ab999d0569c0428a97f71920cc4#commitcomment-830253
>    
das ist ja genau das, was ich meine. eigentlich ist deep idle nicht an, 
sondern das tel befindet sich im normalen deep sleep. weil wir aber die 
varibale bei 1 beginnen lassen, statt bei 0, wird der status verschoben. 
aus deep sleep wird so in der statistik deep idle bei top on.

hast du es mal zusätzlich aktiviert? bleibt dein display dann nicht schwarz?
Awesome. Will do.
Can you please motivate this api change? The only reason I can think of is to make it possible for high performance java implementation of a router to return a real `immutable.Seq` instance, which is rather inconvenient an unlikely to happen, so there will be a conversion anyway, and then I don't understand why we don't do `Util.immutableSeq` for them.
Remoting is experimental?
doesn't extend ConnectorEvent, on purpose?
I'd avoid the for comprehension here and instead do the check in the guard of the match.
> We never use relative imports, they are confusing and order-dependent

This is "IDEA magic", I have to turn this thing off... Thanks for noticing!
No need for the extra braces
Definitely - thanks!

I also need to make them config options, will need to dig a little deeper in that to see the best way so that the durable queue subclasses are kept dry.
In that case it is wrong here also: http://doc.akka.io/docs/akka/snapshot/intro/getting-started.html#using-akka-with-sbt

Do you know @bantonsson?
do we need catch around `!`
in that case it should perhaps be `case NonFatal(e)`
the three below are the ones I don't like.
I meant the reset=  .  I think it's a good practice on uninformative args (like "true") to use this technique to make the code readable.  otherwise it's really hard to remember what the heck that does.
I would suggest the following revision to this expression, for the sake of clarity:

`if isinstance(imt, SA) and imt.period in (0.2, 0.4):`

The use of the bitwise or `|` could be confused with `or`, which has a lower order of precedence. (http://docs.python.org/2/reference/expressions.html#summary)
=> {
I wonder if this whole section would be simpler and clearer if we boil it down to this:

* flags are used to indicate behavior of the immediate command
  - example
* boolean values are specified when the value gets saved
  - example
is this file using tabs for indentation?  if so, keep consistent for this pull (use whatever is there now) and if you will, submit another converting to 4 spaces
I've added a test for removing *all+*default, and I think it is passing now
Not sure about this one, sorry.
Or `MRTestingJob`. That's not a bad option either. :)
I think it's more canonical YAML for the `-`s to line up with the `include`:

```yaml
include:
- ...
- ...
```
This is the meat of the code that used to be in save_with_card and that ugly transaction.  Not AR just does it's usual transaction for nesting saves. I bit more went to validations.  It really is more Railsey this way, and will lead to more goodness.
don't add these extra **************
Ah, good catch! However, to be completely correct, the above two lines should be swapped so that `mLastMouseScenePos` takes into account the latest wheel event.
Can you maybe add a reference for the function?
what for? to get dead letters, I suppose?
what about failures? maybe just convert into an `onComplete`
Shouldn't the light track also be used for the default style?
I'd prefer not to have to cast 5 different pointers to TUIPopoverBackgroundView to access their properties.  I say the iVar stays to avoid that.
Why was this added again? What build errors were you encountering?
No, it's just that `Handle<Value>` is a lot more chars than `void`, and it looks funny all pushed to the right.
bon y va falloir avoir la discussion de quoi qu'on veux supporter! Selon moi on devrais utiliser notre code avec la meilleur techno et creer des adapteurs en fonction des version de ?&%$/)"  qu'on veux supporter. on peux tjs dire au utilisatur de IE de  downloader google chrome frame
You could do "not isinstance(outputs, str)", I guess.  Or just explicitly test for list + tuple as "isinstance(outputs, (list, tuple))".
The ``os.mkdir`` should be replaced with ``create_dir`` from ``qiime.util``, e.g.:

```
from qiime.util import create_dir
...
create_dir(opts.dir_path)
```

We try to use qiime.util.create_dir whenever creating directories in QIIME so it's done in a consistent way (e.g., error messages if the directory can't be created, etc) but there are still some places in the code that don't do this.
doxygen-комментарии должны начинаться с трех слешей
На обсуждение сейчас выставлено - сейчас и комментарии.
запятую на следующую строчку
Итерировать по константным ссылкам.
I'm not sure how accurate this is, since you can change the `:path` option using the routes, and `:action` would not match the request path anymore.
Was tempted to put a comment on this line. `route` prepends two spaces onto the front of the string that is passed, so we need to strip those spaces off. We could edit the initial loop to do this, but I couldn't think of a non-messy way to do it. Maybe `route` shouldn't prepend the spaces?
@kennyj are you able to investigate why it is being set to an empty string? that seems unexpected to me - it should be `nil` or an actual value.
are you fine with this small snippet of HTML outside a template?
I think you can comment about both `deep_symbolize_keys` and `deep_stringify_keys` :)
I agree about `options.is_a? Hash`, but I disagree about the check for `blank?`. I don't think we need to be so defensive.
What's numeric-string mean?
I agree that changeSymbolOwnerIfCorrect is not the ideal name but I also don't think that the two you propose are good because the method doesn't have anything to do with Return. It was just my way of avoiding code duplication for conditonal owner change. I am getting more inclined now to rename it to simply 'change' in the spirit of 'subst' from TreeSymSubstituter.
I would actually have not created this alias if I were to do it again—I'd encourage removing it. Initially we thought of it as a more natural way to express sequencing (this and then that) but everybody got quickly used to `flatMap` and what it actually meant — to the point that seeing `andThen` in any code is quite jarring.
@xeno-by I am not really sure a ToolBoxError is appropriate here. AFAIU ToolBoxError happens during eval(uating) at runtime, right?
Here we don't have any evals and all the erros mentioned by @paulp happen at compile time. More specifically: z2, z5, z8, z11 fail with ```error: exception during macro expansion: scala.MatchError: (x: _*)```, so there is an issue with their varargs handling. The cases that don't  have varargs but they do have type parameter, i.e. z4, z6, z10, z12, fail with ```scala.reflect.macros.TypecheckException: missing arguments for method zx; follow this method with `_' if you want to treat it as a partially applied function```. So, firstly, i ll try to look if i can fix the TypecheckException. If you have any ideas/proposals pls lmk.
Not to worry. I figure it's my job to play the critic in these situations as your standing and reputation could easily intimidate some folks. Now I'm waiting for Mark to instruct me in the finer points...
Should we have the set/frozenset type names in the printed latex? Personally I would prefer just ```{1, 2, 3, 4}``` for latex printing. 

Another option would be to create and use the FiniteSet latex printing
if I'm not mistaken, a raw call to as_real_imag will generate an error e.g. `(x*y).as_real_imag()` because no hints were provided, so (if I am right) then this line should be `if hints.get('ignore', None) == m:` which will provide the default value of None when 'ignore' is not in `hints`.
Does this have any unintended consequences?
the def of dual_matrix has been deleted at the end of the file, leaving a blank line as last line.
By the way, some of your reversed `==` comparisons look a little awkward (like `0 == n%2`).  It's a minor code quality issue, though.
actually it is sine, but in ray traicing terminology optical-direction cosine used.
I think I understand your spirit pretty well :-) If others don't object, I'm OK with it (I'm actually slightly supportive of it ;-) )
Can you add a comment where this comes from?
But good luck getting to the result given below. Simplifying these expressions with logarithms in them is a very tricky problem indeed.
Don't forget about indentation. :hand:
Just redirect to `System::getCurrentUrl();`

Can you email me please I need to talk to you about something off the ticket.
This is bad English and passing a judgement over this in this way is not exactly inspiring for downstream devs...
Why are you using a table here?
I index into that array with the condition type though, eg: `DOF_COUNTS(BOUNDARY_CONDITION_IMPERMEABLE_WALL)`, so I'd have to renumber all the conditions. Some people have said it's a bad idea to change the values of constants, and I think allocating and communicating one extra integer isn't a big problem.
Yes, otherwise there is a load of front matter code to add to folsom_metrics, folsom_ets etc. We only ever use a 1 minute window…theoretically others may need configurable windows, but I didn't see _now_ as the time to add a maybe feature.
I think it should do deep equality for everything then:

`if( (typeof value != ='undefined' && value !== null && value !== '')`
I don't know if adding the splice requirement is desirable here.
Superfluous cast. Also, I prefer to split declarations and assignments when there's a block of them.
Is the ````if```` check at the end really necessary?  Doesn't ````default_for_user!```` essentially do the same check when it runs?
Sorry, I see now. 

I think asserting: 

1. That this document addresses one topic. 

2. MongoDB automates these tasks. 

Is rhetorically confusing. The original isn't perfect by any means, but let's revert unless there's another good solution given that this is orthogonal for the project of getting the page redirected.
omg sensible key code variables?! this can't be javascript!
Are you (@int3) suggesting changing *all* existing invocations of `RegexpCache.get`?

That could be done.  But, with the greatest of respect, it may not be a great approach.  It would be a trap for existing developers who are familiar with the current interface.

I guess it's a matter of taste, but the proposed change:
  - retains the current interface to `RegexpGet.get` (so no traps)
  - generalizes that interface in a way that is useful for at least two on-going developments, and
  - does that in a natural way (to me, at least).
1. Already fixed (I think pushed also)

2. Same. That was how I was thinking too.
And it's some kind of a map. Maybe classMap. Or readClassMap/unreadClassMap, whichever one makes more sense.
Looks like you didn't change it everywhere or you botched your database at some point.
Is there a requirement for name to be namespaced? If yes where does it come from? What does this name mean, precisely? Style names are (supposed to be) defined by the directory they are in, which makes this specification redundant.
`composer update` with `--dev`. Fixing.
nit: the idiom is return luaL_error usually I think: http://pgl.yoyo.org/luai/i/luaL_error
this is a place holder for windows... I'm not sure where the file should live on windows.
style nit comma
> Is there a particular reason you recommend targeting 1.9+?


Ruby 1.9 has been the current standard for a couple of years now.  [Ruby 1.8.7 support will end soon](http://www.ruby-lang.org/en/news/2011/10/06/plans-for-1-8-7/).  The only ruby 1.8 usage I know of is for old legacy projects.  No one is building new projects for 1.8 anymore.

If you need qless to be usable by a particular ruby 1.8 application, that's a valid, good reason to support 1.8.7.  Otherwise there's no reason for it.  1.9 has lots of niceties (and additions to the stdlib) that you either can't use or have to backport if you're going to support 1.8.

From what I've heard, the ruby community's transition from ruby 1.8 to 1.9 has been much smoother than the python community's transition to python 3.

And yeah, there are idioms like that in ruby, but I'd advise just targeting 1.9 :).
That would pass `{ :hello => "howdy" }` as the first hash argument, and use whatever the default arg value is for the second hash argument.
you're not gonna quit with these `class`es are you? :)
Please add a PVP-compliant constraint such as

```
                   , stringsearch              >= 0.3      && < 0.4
```
Needs to be changed!
not without a lot of hassle
"so the" ... what?
again, please don't preoccupy yourself with style/appearance at this point. it's likely to change a lot so don't want you to invest time on it.
Can you create an enum or provide better documentation to explain what getFields() 4,5,6, etc mean? Right now, this if block is cryptic
Instead of chopping it down to (2, 8, 50, 50), why not leave the displayed dimensions intact and the chop the others? e.g. (2, 70, 2, 100). That would look as good as the original but be even smaller than your current file.

Or you could go even further, and pre-trim the vertical data as well (ditching the comment about emphasising the terrain) -> (2, 15, 2, 100).
```
this.source = conf.typeNames.map(function (typeName, index) {
  var line = {};
  line[dimenT[0]] = index;
  line[dimenT[1]] = typeName;
   return {dimenT[]};
});
```

也可以这样写。
idem python25.OrderedDict
Why not check for the other outputs?
Why create a new try block? You could just add an ``except MemoryError`` below the TypeError except.
Should the two lines above be synchronized on the m_channel object? It's synchronized in isAlive().
I don't think so, but it speaks to the fact that we don't use these kinds of indexes many places in our test code. I think we should add an expression (string) index to at least the deletes workload.
I don't know, I feel like these two are actually kindof helpful.
What are the possible return values of get_root_node()?
Following up: I'm +1 on the docs containing a rough outline of operation in bullet-point form now, and improving things to add some graphical representation later. This is already a monster pull request, no need to hold it up for Just One More Addition.
Please remove this. We have some files which still have it, but it is a left-over from the SVN area
Can it also be an empty list? If it is not None but it's an empty list, what happens?
The changes to webvtt_strerror are good, and have my blessing
On 02/04/12 16:20, Joe Groff wrote:
>>
>> -private define noPrecBinaryOp;
>> -[OP]
>> -inline overload noPrecBinaryOp(forward a, #OP,forward ..args)
>> -    = forward a,OP,..noPrecBinaryOp(..args);
>> -[OP,T,U when BinaryOpDefined?(OP,T,U)]
>> -inline overload noPrecBinaryOp(forward a:T, #OP,forward b:U, forward ..args)
>> -    = forward ..noPrecBinaryOp(OP(a,b), ..args);
>> -[OP,T,U when integerEquals?(countValues(..CallOutputTypes(OP,T,U)),0)]
>> -inline overload noPrecBinaryOp(forward a:T,#OP,forward b:U, forward ..args)
>> -    {OP(a,b);}
>> -[OP,T,U when BinaryOpDefined?(OP,T,U)]
>> -inline overload noPrecBinaryOp(forward a:T,#OP,forward b:U)
>> -    = forward OP(a,b);
>> +overload binaryOp(..args) = ..args;
> On Mon, Apr 2, 2012 at 6:57 AM, agemogolk
> <reply@reply.github.com>
> wrote:
>> I think the best solution is to find a way of making Operator? possible.
> How about passing the operators and operator positions out-of-line as
> symbol parameters, so that `x * (y,z) + w` becomes
> `infixOperator[(*),1,(+),3](x,y,z,w)`? That allows prefix and infix
> operators to be passed together in a recoverable way, and I think the
> code to decompose that form would be simpler and thus faster as well.
>
> -Joe

I've been looking at the out-of-line with direct recursion (rather than 
forcing it through the overload system) possibility on the side, but 
hadn't yet considered passing positions - looks like it could work. 
Would still be nice to have Operator? though.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/251/files#r633641
Unfortunately, anything that requires the rank of values also requires a sort. The only alternative would be online approximation algorithms. Though I am doubtful that that would be easy to parallelize. Research on anything like "online multi-stream Kolmogorov-Smirnov test approximation algorithms" is probably limited or non-existent...
I don't see why we need two of with_ordered and no_ordered versions.  You can define only one and encapsulate the ordered/non-ordered switching logic inside the function.
Can we use [the placeholder attribute](https://developer.mozilla.org/en/HTML/Forms_in_HTML#The_placeholder_attribute) for this instead?
Dunno what this `@linked` is about, but I would say just remove these caveats altogether.
Is the "def test" mandatory in Formula ? 
Can I just remove it (dgtal is mainly a lib) ?
Hmmm, I just downloaded it on my desktop and sha1sum says your checksum.  But https://github.com/rapid7/metasploit-framework/wiki/Downloads-by-Version shows the b9d6dbe54b23448da9a939cf3e1f95cb7dc0e363.  Though the download link for *that* file is http://downloads.metasploit.com/data/releases/archive/framework-4.3.0.tar.bz2.
is this the url to the binary? Not the source code? Please double check.

I think this is the devel version:
`http://download.linuxaudio.org/lilypond/sources/v2.17/lilypond-2.17.9.tar.gz`
Does the SMSSync app do anything about normalization? We might need to pull it through `vumi.utils.normalize_msisdn`
As per the previous comment, I think we should just drop the `the reddits` part.
sure I'll change that
This could and should be called `server`, `mserver` is extremely non-descriptive
Unless we move `level` into `data`, it should be written "sets its level based on third argument of the initializer" here.
Use `//`-style comment. Change exception variable to be named `ignored`.
single button in cetter of window with text looking ugly =)
pairs: TraversableOnce

you only use foreach, might as well use the most base trait (which includes Iterators and Iterables).  :)
Yes; for obscure reasons it's where our `dojo.forIn` lives.
However, the whole sneaky hidden argument thing feels a little icky.  Could we just explicitly declare a 2nd arg named unitTestOverrides or something?

It probably wouldn't be giving it away much more, since anyone who can see the args list can also see the "secret second parameter" comment 1 line below it :-)
Oops fixed. I had to use sublime while i was fixing the async issues. :)
I see this code that you refactored but did not write, but I was wondering if there is a reason to immediately call .addClass on a tag that was just added? Seems like adding it to the text string would be simpler:

  <div id='recent-folder-delete' class='trash-icon'></div>
Good catch! Not sure how I miss typing a 't' there.
I think we usually avoid using then().  You could use pipe() here, but it would also work to keep doing it the way this code used to work -- instead of creating your own wrapper Deferred, you can attach your done() callback to the result of doOpen() and still return that _same_ result object.  jQuery guarantees that the callback we added will run before callbacks added later.
Would benefit from a comment to explain why the Eterm gymnastics is being used (erring on the side of caution)
This should be `flash`.
hum, why a label text like this?
€ ?
And capture the value from parent's `clean`.

```
tmp_value = super(FormLimitedDateTimeField, self).clean(value)
```

Not `birthdate`! We are having general form field here!
You should include ID for localhost (127.0.0.1:8000) so that it can be tested locally.
well i didn't commit that code, because it wasn't working as it should. ;) it vas changing from slovenian to english and back every second or so. I very often overcomplicate things... :)
Changed to classes instead of ids :).
I was using it to help catch issues easily in my work. it can be pulled out.
Yeah, I have no idea what was happening. Problem doesn't seem to be there anymore. Herp derp computers.
There's a few unused CSS classes in here
Vice-versa. Will fix.
Or, since we don't need microsecond resolution here:

elapsed.seconds + (elapsed.days * 24 * 3600) > update_timer
@ginko are we still unsure whether this is needed?  If so let's ask @restebanez!
In py3k the `map` will be a iterator, then it will not work.
这里的日志级别改成NGX_LOG_WARN，nginx还是能继续运行的，没必要用EMERG
your first plan may be just fine.  no need for formality here.  Linux kernel got by with emailed patches, and I hear that stuff is pretty stable. ;)
You think?  Talked about this with Jamie, and we thought it would be horrid for the whole of the server to crash because some fool forgot a counter name.  You think it should crash?
na img esho pak kardam to css ha hamon tag a khodesh ke display : block dare khube :D
John Myles White has such a page on his blog.
Is there any reason why you set this variable to `null`?
I admit this is a confusing mix of two meanings of the word "Error", but shouldn't this be `IncompatibleErrorsError`?  Or maybe `IncompatibleErrorsException` if you don't like the double-error?
Maybe throw in a sentence at the end here that says something like "you can also put ``use-system-expat=1`` in ``setup.cfg`` to make this the default behavior." Or not, if you think that makes it too confusing.
这要看我们准备怎么设计整个系统：

一种是：隔离请求的参数和controller，不管是http的请求，还是cli的执行，还是什么其它的，都在request层把各种请求封装好，然后下面就是各种参数了，不再需要去调用原来url里的post或者get。把请求对象（Request）统一传给controller就好。

还有一种是：把所有的请求都变成http格式的请求，不过即使这样我也觉得不应该让下层的地方直接获取原始的get，然后作为参数，这样就会很乱，比如如果在一个Logic方法里直接取了get，这样也很难测试了。
I consider ~p to be the shotgun of io:format. You don't really need to aim it, and you're most likely to hit what you need to ;)
Updated this string and the tooltip below, which doesn't need an additional Transifex translation that way :).
Nit:
createrawtransaction help uses 'address' and double-quotes:
   createrawtransaction [{\"txid\":txid,\"vout\":n},...] {address:amount,...}

listunspent help should follow:
   "listunspent [minconf=1] [maxconf=9999999] [\"address\",...]\n"
Shouldn't this default to null?  Won't array() unbind all the associations?
qmap单纯这么引用会导致多一个为null的项吧，
应该先用 contains check一下
Not the selectors, the case statement strings.
thanks @guilhermeblanco


On Wed, Nov 21, 2012 at 9:03 PM, Guilherme Blanco
<notifications@github.com>wrote:

> In lib/Doctrine/Common/Proxy/ProxyGenerator.php:
>
> > +                || ! $method->isPublic()
> > +            ) {
> > +                continue;
> > +            }
> > +
> > +            $methodNames[$name] = true;
> > +            $methods .= "\n    /**\n"
> > +                . "     * {@inheritDoc}\n"
> > +                . "     */\n"
> > +                . '    public function ';
> > +
> > +            if ($method->returnsReference()) {
> > +                $methods .= '&';
> > +            }
> > +
> > +            $methods .= $name . '(';
>
> Align = signs
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/doctrine/common/pull/168/files#r2201646>.
>
>
Add a javadoc
Why would you include one specific module several times?
ah, yes.  I have `import os,sys,time` in my startup files, so I always forget to import them.
@takluyver, thanks!  We actually looked at the py3compat utilities, but since we don't know them too well, we didn't quite pick the right approach.  Why don't you just go ahead and apply this fix straight up into master?  Things like that are OK in my mind to do post-review without needing the overhead of a full-blown PR, they're just minor polish that would have happened during review with a bit more time.
I would expose `depth` without the underscore and document it publicly, it can come in handy for external users.  And since this is an official method anyway, might as well.
Why TODO?
Not really local path, is it? :)
You're right, let's change this.
What is oedipus?
I read through it and they definitely use it for this purpose, but the more I read, the less sure i am that I understand it enough to deal with the edge cases. So I think I'm going to defer that for now.
Decorator instead? You can save 3 kittens that way. (kittens == levels of indentation)
This does my head in a bit. 

So, we're basically making all potential reasons to stop all go through the KeyboardInterrupt exception.
can you change this to message asking them to login; I only accept a valid username password combination when writing the config.ini
Will move it to a template.
imo this also needs to consider isSilent().
ref: #3645
should probably default to '' (same as prefix)
This will indeed be a problem. Is there any way to know if we are handling a sub-request at this point?
old code should not be commented but removed
I've just found an issue about it (symfony/symfony#4655), it will be discussed for the 2.2 release apparently.
correct my mistake ;(
2 to be more specific :)
I'm definitely -1 on all those changes. There is not valid reason to create a temporary variable and I don't why it would be better.
I think the default instantiation didn't make much sense anyway because the default values (like localhost) will not be useful in 99% of the cases.
This class seems unused
@1syo なんの意味がないのか、もう少しコメントしてあげるとよさそうな気もしました。
（口頭で言ってたらすみません。。。。あと、これで @tiwakawa が理解できてたらすみません。。。
Lauren, can you use 
http://www.playframework.org/documentation/api/1.2/play/libs/Codec.html
The last time I did a code review it added an additional fee.  So, this time I removed the fee setting to 0.  When it goes to completed, will I get CR 10%?  If not, then I should add a fee now.
rasty too stylus ba nib injoori benevis
```css
  image : 'images/picefct.png'
```
bazam quotation mikhaaaaaad
Chris aside question, is it ok to send commits for small changes like this? Should I wait a day or two and gather more changes and then commit? I need to ask this since I feel uncomfortable flooding the pull request with commits.
die load-Methode uebernimmt die ganze magic. in der yml kann jetzt mit platzhaltern gearbeitet werden, siehe unten
Strange. Why not:

```ruby
content[cloud.to_s]["servers"].any? {|_, settings| settings.has_key?(option)}
```
very swish! :smiley:
Do we really need the complexity of caching this? It's just half a dozen dictionary lookups in a bad case.
Pretty sure all sorting \ searching will be done in the 'notebook' class.
tiny nitpick, we should use `0 == arguments.length` here since the user's intention may be to pass a name, but maybe their var is null
these 2 dependencies are not needed anymore
Do we want to be notified of these or are they expected errors?
I would eventually like to see the logic for generating random subnet ranges separated from the logic for trying to create the networks until we succeed. That doesn't have to happen in this changeset, but it will be easier to produce tests of the two operations are separated.
`it  { should == [nakanohito_feed] }` でいいんじゃないですか
I wanted to search with in the album and all its descendants, including sub-albums. This seems to be the way to do it from looking at [ORM_MPTT::decendants](https://github.com/gallery/gallery3/blob/master/modules/gallery/libraries/ORM_MPTT.php#L205)
No problem!

I hope I did not come off sounding argumentative, though! :)  I just wanted to make the improvement.  (It may be a very tiny one, but every CPU cycle saved helps make PyVows even faster!)
OK, there's no good reason for not throwing an OFE in these methods, so I'll change them. Part of the whole point of this exercise was to scan a ton of handlers and make small improvements like this. :)
It looks like these calculations are supposed to use offsets, but props will contain position.
This pluralization is wrong. You have to switch between "are" and "is" as well. We also need better wording for the navigation because you cannot navigate between one item.
The login system seems to have serious issues. I've needed to reset my password (again) and login ended up in a redirect loop. 

Finally:  http://bugs.jqueryui.com/ticket/8929
Unexpected semi-colon.
I believe I specifically added this line relatively recently. Is there a reason for its removal?
why is this long here and int above?
I was thinking about using some python C parser since it would be a testing only dep. But yeah, given the low number of enums it's probably not worth it.
I'd recommend to put away the inline code, but I'm making a PR later to fix all of them in sms, so we can keep this here for now
It seems that most of the use case are with a simple integer. what do you think of goToPage(index, options) instead?
`if (evt.detail.unblock)`
Needs to be l0n strings.
Ah, yes.  Silly me!

However, I think I would prefer it if we could refactor this so the resizeHandler is defined inside the newsletter mode if-branch and then we just surface that.  The non-newsletter case can initialize it to an empty function.  Once we make the transition to using 'let' versus 'var', I think it would make sense to keep things like photoState contained in the newsletter branch block.
You will also need to call the function again when the locale is changed, i.e. the `locale` event.
nit: I prefer most of the createElements / initialisation grouped together, then then attriibute / value setting, then building the dom tree, I think thats a fairly common idiom for dom building code
Even after I define the attribute as "data-optionIndex=1", it still need to be accessed as:
   `element.dataset.optionindex`

So, I'll just keep it as is if there are no other alternatives.
Add a `console.warn()` here -- no script should attempt `LockScreen.turnScreenOff(false)` except the idle timer & wake lock release handling.
I'd prefer seeing the `ro.moz.ril.iccmbdn`setting name and the new ones that are coming in the near future under a new type (e.g. `operatorvariant`) but I'm also fine seeing them under the type `default`.
Remove these??
ahhh.  thank you.
I like to put blocks even when empty, I think it's easier to read. But I can remove it to follow your conventions
Oh, you're right, I hand't realized that it was a system call. Good call on the option then.
can you explain why this is correct or reference the paper/page etc... where this is shown? It looks credible, but I can't see immediately why this would be correct without rolling up my sleeves and starting to work it a proof.
I find this paragraph confusing. A simple example of what can go wrong here would be helpful.
"Below are the options directory is set to an object"
From what I understand Qt only lets you translate things that are instanced. Which means we need to declare it inside the init() function.

If you declare it as a class variable Qt translator won't see it... unless I'm wrong.
That line's not needed anymore.
center? All I get is `MySQL database error`.

You can try `err = $ '#errmsg, center', doc`
As I said in the previous comment, the list of parameters was there generated for a usability reason.
Yes, this looks better. Pull request is updated.
I think it's best to include them for now.  If we come to a point where we remove or redo the try functionality, we can deprecate them at that time.
Commented out shouldn't be left in tree.
to check - we already pass filename for imported files.. if we also pass it for the initial file does this change the current behaviour around re-writing url's etc? I can't see that it would, but wondered if you'd considered it because we don't have any unit tests around it.
Fixed, will be deleted at CCFileUtils::purgeFileUtils together with s_pFileUtils.
This line I used a short string concatenation is the project name and a link to edit the user rights in the project. 
Result is the text and html tag links that do not select a secure html will render with a tag. There is an option to not use html_safe and break this conclusion on two lines with the work of HAML, or leave in a single line. if you remember the fact that the title of the project is validated by us and nothing dangerous in it does not slip - we can safely use html_safe.
Renaissance IDS start here ;)
Maybe this should be developmentserver.txt also?
move styling to css files
Remove "be set to" so it will read as: "The `attachTo` option must always contain at least `top` or `frame` value"
> I don't think there will be many optional settings

`label` isn't actually optional, is it? It's mandatory for the `control` type, I think. So "Optional Common Attritbutes" is the wrong table for it anyway.

There aren't many settings-specific attributes. If it's confusing to document setting-specific attributes along with the settings themselves, then this PR should do something like:

- rename "Mandatory Common Attributes" to "Mandatory Attributes", change its description accordingly, add `label` as well as `boolint`'s `on` and `off` attributes, and explain when they're used and what they mean
- for consistency, rename "Optional Common Attributes" to "Optional Attributes" and change its description accordingly.

Or, you also merge "Mandatory Common Attributes" and "Optional Common Attributes", and describe for each attribute which types is applies to, and whether it's mandatory or optional.
if you want to use the single quote, be sure that you don't have double quotes in the same file (I see a couple of them). As code style guide says, we should avoid to mix them.