spec: write specs for g/14373/

Change-Id: I74c0f838a8cedbef03b6de8c3e60b0099a6e075c
Reviewed-on: https://gerrit.instructure.com/14383
Reviewed-by: Sterling Cobb <sterling@instructure.com>
Tested-by: Sterling Cobb <sterling@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Shawn Meredith <shawn@instructure.com>
spec: discussions intermittent failure

Change-Id: I5ef84a9792223c0f5f230edcb946af84d5fd3459
Reviewed-on: https://gerrit.instructure.com/14402
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Tested-by: Bryan Madsen <bryan@instructure.com>
ensure primary buttons are on the far right, refs #10236

regardless of button source order, ensure that primary buttons are the
right-most ones when using the fixDialogButtons util

test plan:
1. check some dialogs that have multiple buttons and that use
   fixDialogButtons (or if g/13904 isn't merged, create some)
2. the primary button(s) should be on the right

Change-Id: I69c16306f2018fbe256fa1fbf4122c1d33830e88
Reviewed-on: https://gerrit.instructure.com/14274
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
fix link on facebook page

test-plan:
 - go to /facebook with facebook added to your external services but
   unconfigured
 - the link for "configure your notification preferences" should go to
   not have "#{Facebook.app_url}" in it

Change-Id: If6f9bf98f9cb4ed58b820dd48c60268f6552873e
Reviewed-on: https://gerrit.instructure.com/14305
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
api: fix current user groups endpoint's pagination links

fixes #11267

test plan:
- hit the /api/v1/users/self/groups api endpoint
- make sure then pagination links match that same url format

Change-Id: I80cf7285d3b5f8d5735c97a4859f267272bde931
Reviewed-on: https://gerrit.instructure.com/14414
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes numerical answers in quiz_statistics_csv

fixes #11160

test plan
 * create a quiz with a numerical question type.
 * have two users take the quiz Have one get the correct answer and one get it wrong
 * go to the quiz statistics page and download the csv
 * both answers should show up in the csv

Change-Id: Iad630629458abe578ffb9d5a985d172d7171c4a2
Reviewed-on: https://gerrit.instructure.com/14346
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
updated parallelized_gem version

Change-Id: Ib705d270c85e85607f66e6347494fdd0fc483709
Reviewed-on: https://gerrit.instructure.com/14421
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
Tested-by: Jake Sorce <jake@instructure.com>
mark Alerts as being a beta feature

test plan:
 * view account settings as a site admin
 * should say "Alerts (beta)"

Change-Id: I00b74382f6d9be7757dad96a436924337d8f2bb4
Reviewed-on: https://gerrit.instructure.com/14415
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
memoize and improve specs for User#assignments_needing_grading

refs #11187

I removed memoize before, since the thing being returned is an
array rather than a named scope once we restrict by section,
and thus would not return updated results on a single User
instance - but I noticed the _total_count functions are all
memoized and can't be expected to update either; also, we
probably don't expect these counts to change within a single
request.

also, move tests for User#assignments_needing_grading into
their own specs that actually test summing over multiple
assignments

test plan:
 * no visible behavior change (other than possible speedup)
 * specs should pass

Change-Id: I76c9d91b75ebcdf4dd48b356171f1bd13b011520
Reviewed-on: https://gerrit.instructure.com/14345
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Refactor "score out of points possible" for quizzes and curb unrestrained high precision quiz scores.

E.g. There's no need for "5.2333333333333 out of 10".
- Now uses render_score in Activity stream, as well as quiz question partial.
- Fixed that recent_feedback and quiz history did not use render_score.
- Refactored readable_grade into helper method; now uses I18n
- Recent Feedback stream now uses render_score via readable_grade

Test Plan:
* Take a quiz that allows for fractional scores
* Answer the quiz in such a way that you get a fraction for a score e.g. 1/3 out of 1
* Check that the quiz total score has reasonable precision (2 decimals): 6.33 out of 10
* Check that individual questions with fractional scores have reasonable precision

Fixes #11159

Change-Id: Icea14042bf8d33d7f6f91fe9086c232216ef0838
Reviewed-on: https://gerrit.instructure.com/14250
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Bryan Madsen <bryan@instructure.com>
add data validation to learning outcome title

fixes #11057

test plan:
  1. login as a teacher and go to a course
  2. click 'Outcomes' in the left nav
  3. click 'Add Outcome Group' on the right
  4. try to type a string longer than 255 characters
  5. validate that the textbox stops you and it saves
     correctly

Change-Id: I9fb323fe6360d173c44b00206583e391dda0c0cc
Reviewed-on: https://gerrit.instructure.com/14430
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>