labofsahil/github-event-dataset-2012 huggingface dataset:
I have made this change:

https://github.com/worldofchris/cucumber-js/commit/e37a4cce605aa79a2bcb01bc8942129214ec8821

There is no longer a need for the CUCUMBER_JS_HOME env var.

Instead I have sanitised the two attribute values where it appeared, "uri" and "error_message" to replace the location specific strings with something generic.

In the case of "error_message" this also addresses the problem that whenever the JSON formatter code changed there was a chance of a side effect of the line numbers in the error message changing, so taking the actual error message text out removes this problem.

Given the content of the error message is not the primary concern of the formatter, i.e. it just prints what it is given, I don't think this is a big loss.

Let me know what you think.
I think it still does make sense, though perhaps it would be clearer with deferred signals (e.g., delivering each value on `mainThreadScheduler` one at a time).
For fremtiden: `.should be_inferred` :)
Hmm. I if had the exact string that is put out, I could do something like
if [ "${DEPS}" != "the exact string" ] ; then
as an example its only the required array, but we have to use the
I prefer info = dict() it's more explicit for new python progamers.
The default tmin and tmax may be a bit large, I have been using -0.08, +0.08, this is what Sheraz is using as well.
I would write trans_band_width in full words.
It's nearly as DRY as it can get. No matter what, there's going to need to be a `response = <something>`. I think whether that's `self._publish_and_verify(SIMPLE_HTML)` or `self._simple_response()` is probably inconsequential (especially given that this is a test).
The validator has also isUserNameAsEmailValid so we can't just call isUserNameValid. We want to call validate on the actual user object, thus the code from processFormSubmission needs to be moved (or removed if already there) to onSubmit.
Thanks a lot for doing this :)
This should be:

    $exceptionListener = new ExceptionListener(...);
D'OH! ;-)
PEP8: two blank lines between module-level definitions.
This can be simplified also:

    In [9]: a = arange(5, maskna=1)

    In [10]: a[1] = NA

    In [11]: isfinite(a).all(skipna=1)
Out[11]: True
How could I miss csv.DictReader?!? Neat.
这里是不是有个Bug

我连续调用lock同一个key两次

第二次虽然失败了，

但是我第一个file 的 resource 已经丢了……
Isn't there a JIRA for this?
This is going to scale much better if the "compute" step is as fast as possible, as I guess it's executed in the scope of a lock on the _key_.
I don't think it's a good idea to run an unguarded trace statement + _getLog()_.

You might want to create a proper extension of BiFun ? so you can make avoid the anonymous class creation and statically initialize _isTraceEnabled_
That's gonna break old clients, isn't it? Didn't @maniksurtani ask you about compatibility changes on Monday?
if possible, please use the second form of stubbing:

when(reader.read(any(char[].class))).thenThrow(IOException.class);
This breaks on ruby 1.8
``s`` isn't a very explicit variable name. I'm not sure what the matplotlib's coding convention are regarding to this, but I think the code would gain in readibility with a longer variable name such as ``sketch``.
No -- many of the backends don't require it to be hashable.  This change is really an implementation detail of the PDF and SVG backends.
another place to use math.hypot()
It works for me, it's all I use.
it looks like you've replaced a wait for element then click with a find element then click.
a WebDriverWait might be in order.
Тут так и должно быть закомментировано? Или забыли удалить?
Can we lose the div style here since we're switching to buttons?
@dooremont Can you translate `My Library` to French as well?
I'm afraid this won't work. Forward class declaration only tells the compiler there is a class named this, so that you can use some limited things like the pointer type (CMath *). But you cannot do things that depends on the content of the class definition. For example, calling CMath's method isn't allowed here because the compiler doesn't know what method CMath has now (by merely seeing a statement "class CMath").
@clarkepaul are we leaving this here or moving it out?
There must be one USE keyword per declaration
yep, `:vacuum` the interval used for running the aggregation thing. `:regular` is for aggregating logs where we've received a final message (where it's rather safe to assume we can aggregate soonish). `:force` is for aggregating logs where we haven't received the final message, i.e. things have gone wrong, since we don't want to have these stick around in the parts table for too long.

i have no idea if these timeouts work in practice though.
Here Option[T].map does also make sense instead of matching it.
what is unsafe here? might not always be an parsable integer?
用'string' === (typeof data)来判断吧？
Hmm. What does 'enforce' mean here? Does it mean to enforce people to use encapsulation? I wanted to mean if people use encapsulation, it won't be broken. If they don't, it's fine too.
There is only one line in my repo, not sure what is going on here.
Claro que sim, não ligues xD. Já não estava a pensar muito bem na altura.
You can remove the `{}` and 1-line.

Also, I just noticed a style guide problem. You'll need to check your diff and find `) {` and replace with `){` :D
This is good, but use also other template variables you are passing to the template.

```
<div class="error">
    <p>{% trans "You don't have permission to access the page you requested." %}</p>
    {% if no_referer %}
        ... (translatable!)
    {% else %}
        <p>{% trans "For accessing this site and using all features cookies in your browser must be enabled." %}</p>
    {% endif %}
</div>

{% if DEBUG and reason %}<p>Reason: {{ reason }}</p>{% endif %}
```
Use `:` and not `;`.

Good TODO to ask.
Don't use hard-coded html. Construct elements through jQuery.
Harcoded or on __init__ dat they inserted to dict?
Dot missing at the end.
And then you can have a dict here, mapping from those constant strings to translated strings.

This can go to a top-level module constant (named with ALL_CAPS).
Great, but if you take away the Settings.SetWindowInFront part you can't - which is what I was referring to from the previous comment...

The dispatcher checks for null was only because when I was closing using the "x" on the ShellView (closing the app) it would randomly throw a null reference exception, so I thought it was better checking than not checking.
Also probably this one: http://stackoverflow.com/a/6651656/467754 The problem though is that the [Enumerable.Range](http://msdn.microsoft.com/en-us/library/system.linq.enumerable.range.aspx) method which is used in the unit tests also accepts only `int`.. So the tests will be full of casts...
Ah okay, that's true. I'll get the changes pushed shortly
@Null45 deceleration increases total movement time
This method is already implemented with a different name, "arrayKeyExistsIgnoreCase":

    @@ -370,6 +380,8 @@ public static function arrayKeyExistsIgnoreCase($key, array $search)

Should remove one of them.
True. A `getter`, like in the URI class, could work too. What do you think ?
Should go to prev line.
Usually on the same line as the bracket, line 78 too.
Seems `getDeclaration` doesn't cache, maybe should just get it once? Maybe I just don't get it, why does it depend on another declaration that you already have?
$ svn checkout "http://modpagespeed.googlecode.com/svn/trunk/src" "/where/you/built/mod_pagespeed/src/net/instaweb/automatic"
If we proceed like this, I think libassert_lib does not need to be linked in release builds.
`NULL` is technically not valid C++.
This check is unnecessary, the ``_get_shape_and_transform`` call guarantees ``K >= 1``. Removing it.
Only ignore the edges if the touch is accidental.
This prevents the touch from being ignored when the trackpad is actually being used.
I believe the file:// prefix is required for spring to see it since it's an external file.  When I left it out, it seems to only looking for it in the ear as a resource.  I will try using ${nhinc.properties.dir} again.  It didn't work for me the first time, but maybe there was something else that was causing it to not get resolved.

I decided on adding it to gateway.properties because in total there will only be one optional property per service.  If that property is not set, then standard is used by default.  But I can add that in if it is better to do so.
ooops while I was forced to work offline part of today I went and edited these!  Hopefully it won't cause too many conflicts if other branches merge from this as soon as it's on master.
Well... I'm a little torn, but here's my thinking:
If someone who is an expert in python copies bits from our demo scripts that use "import numpy", but they set up their script to use "import numpy as np" then the fact that their code can't run will have an immediately obvious reason.  They might grumble at us for non-standardly using numpy but can search/replace easily enough.

If someone who is new to python is trying to run a hacked up script that cut/pastes some of our script, and we've used "import numpy" then they will find out immediately what library they are missing.  If we've used "import numpy as np" then they might have no idea what is this np thing that they are apparently missing.

On May 13, 2012, at 5:31 PM, Barnaby Rowe wrote:

>> @@ -0,0 +1,441 @@
>> +#!/usr/bin/env python
>> +"""
>> +Some example scripts to make multi-object images using the GalSim library.
>> +"""
>> +
>> +import sys
>> +import os
>> +import subprocess
>> +import math
>> +import numpy
> 
> I would agree with you Mike, except that `import numpy as np` is *so* ubiquitous a re-labeling (i.e. suggested and used in many textbooks / references for scientific use of python) that I don't think keeping `numpy` has the effect you desire here.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/146/files#r813802


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
thanks, and apologies. fixed
No point in specifying tab_width, let the user decide for them selves what width to use.

Related: https://github.com/sindresorhus/screenfull.js/issues/4
Should be parseInt(jQuery.browser.version, 10)
I made it non-abstract in case anyone overrides onEvent, rather than onUpdated. But perhaps abstract would be simpler for the vast majority of use-cases.
what is the ${ROOT}/app/ directory of root all about?  maybe leave it off, and leave off "." also ?
("target/classes" might be more useful but user can set his BROOKLYN_CLASSPATH)
Perhaps add links to Coffeescript?
The call to toString is still implicit. I'm fine with that for primitives because there is only one way they could reasonably be output, but for anything more complex I like to explicitly show how it's being converted to a string
This one, with an array of 300000 and chunks of 13 took 28ms.
On Wed, 31 Oct 2012, Hannes Magnusson wrote:

> > @@ -98,6 +98,15 @@ void php_mongo_connection_force_primary(mongo_cursor *cursor, mongo_link *link T
> >    zval_add_ref(&db->link);
> >  
> >    PHP_MONGO_GET_LINK(zlink);
> > +
> > +	if (link->servers->default_w != -1) {
> > +		zend_update_property_long(mongo_ce_DB, getThis(), "w", strlen("w"), link->servers->default_w TSRMLS_CC);
> > +	} else if (link->servers->default_wstring != NULL) {
> > +		zend_update_property_string(mongo_ce_DB, getThis(), "w", strlen("w"), link->servers->default_wstring TSRMLS_CC);
> 
> Have you gone through all the cases were we read the property back to make sure we truly support it as string?

Yes - I have checked it everywhere and we do.

-- 
{
  website: [ "http://mongodb.org", "http://derickrethans.nl" ],
  twitter: [ "@derickr", "@mongodb" ]
}
Named to match the underlying field from Splunk. Renamed to is_ready and isDone to is_done.
from the hallo source code i see it still has this widget. can we not fix it in the sandbox to make it work again?
The timestamp attribute does not have any time zone information (tzinfo is None). This is because the timestamp of the _id field in the mongodb does not have timezone info, it is agreed to be UTC. So should the client be self-aware that times are UTC or should we somehow tell him that?

On 03. 10. 12, at 10:01, Mitar <notifications@github.com> wrote:

> In datastream/api.py:
> 
> > @@ -234,7 +279,7 @@ def find_metrics(self, query_tags=None):
> >  
> >          return self.backend.find_metrics(query_tags)
> >  
> > -    def insert(self, metric_id, value):
> > +    def insert(self, metric_id, value, timestamp=None):
> What is this? You changed API?
> 
> I am not sure we want to allow this officially! We have unofficial _time_offset for tests and dummy data.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Uncuddle please :)
It would be nice if this optionally took a path/file passed in by the user, though maybe that could be a later addition
This is just a style comment, but you can also write the above like this:
```
  module AeolusCli
    class Error < StandardError
      attr_reader :message

      def initialize(message)
        @message  = message
      end
    end

    class ConfigError < Error; end
  end
```

Personally, I find this a more readable form
Yes, and the default for the second argument is false.
So #national? and not #is_national?.  I know the method name could be a problem.
I'm confident this one does nothing because I was just working on it.
У тебя два метода, которые делают одно и то же - один пишет в System.out, а другой в файл. Можно сделать так, чтобы код был один.
Закрываешь System.out
Ты сам проверял работоспособность после этого изменения?
ah, it probably would. Though I'm guessing we might be able to just write something to walk down a tree and concat to a file, then cache. For now this seems fine.
I mean, why do you write it twice, once as "ubher"?
Run the `framework` tests! This causes an error and a test caught the failure.
Note that I had added APPLE here. That one is a little special because it's currently only a platform vendor, not a device vendor. Maybe it should go somewhere else.
@klrmn @stephendonner made a comment as to making this search generic, so that the search term might be changed at only one place so inside the tests i also changed to "app_details_page"
a non-empty string is considered true, so Assert.true() will always pass.
also, if get_text_from_location() returned "Element not found at location for text retrival",
then it will hit the 'else' statement, which will mean that it failed...but we won't know if it failed because the date is from three days ago, or because the .text call failed.
I don't really see the point in having two separate tests for expanding and collapsing the app description, so I would suggest to merge this two tests into one single test, as in this draft: http://pastebin.mozilla.org/1741177
I think it's probably work spelling out "yesterday", here; team, thoughts?
Makes sense - Findbugs oddly didn't flag SwappableMetadata, but it should be sorted now.
this line has been removed for each core
Should be `y_true` and `y_score`.
`default = -1` is not explained. 
Mention to `N` seems unnecessary.
Good call, I'll fix this.
Oh you mean to do it inline via `if (ad == ts->sym)`?
could you fix the indentation here (even if it is not part of the changes done by you) ?
Please use BlackBerry in all places above
We don't need \n here.
Please a new line at the end of file
why is the indentation off here?
Ah this wasn't supposed to be in this pull request.. however may still be handy. Not sure why there's a wild Google analytics tracker in this plugin
why debug only?
You can debug release code, and would be even more useful then
v. unlikely perhaps, but could e.g. throw a mem alloc error.
Or if something unexpected in uri object that it's setting up strings based on, there could be issues.

Anyway, minor point, but I'd have prob. wrapped to ensure 'free' call was made.
startRelease() causes the thread to release itself.
Leaks, should be owned..
I see... If you're fixing this bug already, I think it'd make more sense to wait until you get it than publish half the fix now and half later.

Not that the change is wrong, but commits may need to be reverted and can be used as documentation in the future (howto) and splitting it breaks both cases.
diffIter needs to be freed as monitorDirectory returns a 'new' object.
yes, that's OK for now, it looks fine
Going to have to expand on this in another branch. Not quite sure what I want the library binary to actually do.
We should allow all events if the set is empty.  Maybe make a predicate method: ```if (acceptedEventType(type))```
Étant donné que les utilisateurs de IE6 se raréfient (0.6%), et 2% pour ie7 je suis pour l'utilisation de l'espace insécable ou bien de laisser comme en anglais, car il faut aussi penser que le retour à la ligne va potentiellement se produire dans l'édition PDF de la doc.
NULL indicates the "default" branch, o how I hates it.  Not "default" in the hg sense, but "default" in the sense that the change source and source step should both agree on what it means.
Would You like to mind to address that commenting nit near `getWindowTitleForMessenger` before landing, or should I do that, or will it be ignored?
Does it make sense to get a write lock here or is it worth upgrading to a write lock after the second null check?  If we assume that these are time consuming operations (we know this is true on OSSRH with the size of security.xml), then threads will back up waiting to acquire the write lock all having detected the initial null.  Once the expensive operation completes, the blocked threads will only be released sequentially as they continue to content for exclusive access to the lock.  This will obviously happen quickly since they will immediately unlock when the second null check returns false, so perhaps this is unnecessary here and keeps the implementation simpler.
This looks good. @mathjazz is always good to get a code review from early on for tricky strings.
We need to test if the config.yml exist , and copy the default config.yml
"Implement of" should simply be "Implements"
no, you don't want to use exceptions for control flow. Just take this out of the begin; rescue; end block

```ruby
if previous_release_path.nil? || ::File.exists?(::File.join(previous_release_path, "manifest.yaml"))
  Chef::Log.warn "whatever message here"
  return false
end

Chef::Log.info "Loading manifest.yaml file from directory: #{previous_release_path}"
original_manifest = YAML.load_file(::File.join(previous_release_path, "manifest.yaml"))
return true
```
is it intended to change behavior of the example to use emulator? I don't know the risk but if there are users who are depending on this they have to know that this is emulated and doesn't work on actual azure. Further more, i know that Node users use Mac more that windows so how they are supposed to run this sample then on emulator?
I can not run them on prod from home because can not access admin.demandforce.com from home
New "destroy" method:

We remove the widget, the data form the element and the listeners (just the ones in "timepicker" namespace) from the element and the ".add-on".
please do not omit the curly brackets
Is mailing us really the best idea; it's pretty easy to ignore those e-mails.  I thought we were going to start using Freshdesk?
Maybe isn't necessary but a reference about how to use the search window of redmine could be useful, even a link to the official redmine wiki: http://www.redmine.org/projects/redmine/wiki/RedmineSearch
HD wrote this code.
Ah, I found that yesterday when I copied my changes over to a clean repo in vim some typos appeared. I guess I missed some. I'll update the two you commented on.
I'm fine with that, just wanted to throw in an opinion!
Got this in other places as well, and its ugly. Can we use single quotes to avoid escaping? At least remove the quotes around the keys, don't need those.
Ultimately, I don't don't care, but my normal preference is to group by function.  While having good/clean unit tests is important, I'm not sure order is something we should ever really worry about.  (As I say that I'll mention that I prefer constructor testing to be at the top ;)
This function does not "parse the provided URL as JSON".  

You may want to copy and adapt the doc from loadArrayBuffer in the imagery_layers branch.
(1) these are externally scriptable, so I don't see any value right now.  I also don't predict the ARB changing `mat2` in our lifetime.  That is an exaggeration, of course.
> TL;DR: it's complicated, and this is the best solution I could find.

Fair enough.  Bigger fish to fry...
While your refactoring the camera, do you want to make `_getPickRayPerspective`, `_getPickRayOrthographic`, etc. file-scoped functions?
Hi Daniel, about this dummy implementation, it won't be temporary.

The scenario here is: we have an application that don't want aerogear security as a dependency. CDI injection will fail looking for some implementation, that's the reason why it was included.
My concern is that this suppresses the crash log because it does exit(0) instead of what it would have done. This means customer issues would no longer have a useful console or crash log, both of which are vital for bug fixing.
I did some code clean up to make the logic more clear.  I renamed two methods to calculateHeightFromPins() and calculateWidthFromPins() inside onLayout() which takes care of the calculation.  We essentially do the calculation for fill/size in constrainChild() and then we determine if we want to use those calculations in calculateHeightFromPins().  If we can't calculate from the pins, then we use the default size/fill behavior (passed in as measuredHeight).
Summarizing an offline discussion: behavior is the same in both cases. The point of my example, which was not well explained, is that variable declarations are processed before code is evaluated in a process called variable lifting, meaning there is no performance gain by delaying the declaration.
I would drop any mention of support on Natty or Oneric
please change this to _categories_list_locator to indicate that it's for the whole list.
@nazriel You should _not_ need to do any specific checks for `enum`.
> The only two functions which may be an issue are minRunLength and ensureCapacity.

Thanks for clarifying that.


Then this should the description of minRunLength:

> Instead we pick a minrun in range(32, 65) such that N/minrun is exactly a
power of 2, or if that isn't possible, is close to, but strictly less than,
a power of 2.  This is easier to do than it may sound:  take the first 6
bits of N, and add 1 if any of the remaining bits are set.  In fact, that
rule covers every case in this section, including small N and exact powers
of 2; merge_compute_minrun() is a deceptively simple function.

It's not quite the same as it isn't tied to minimal merge length. Which is good if we are to rewrite it.
This is strictly a bandaid.  We have a ticket for making prefs make sense, and I don't want to move on it yet.  Right now there are three global prefs, none of which are *actually* global:

 private static final String  PREFS_EARLIEST_NEXT_SYNC = "earliestnextsync";
 private static final String  PREFS_INVALIDATE_AUTH_TOKEN = "invalidateauthtoken";
 private static final String  PREFS_CLUSTER_URL_IS_STALE = "clusterurlisstale";

For this to work, we need to kill "earliestnextsync".  The others can be killed whenever; they're transient and definitely not valid between account creations.  I can do more work and make these prefs account specific, then wipe them with the rest, but I want to get this ticket done *now* and worry about sorting this out later, when I understand what multiple Fennecs and profiles actually means.
Hold on sunshine. I'm not sure you ever want to do this.

What global preferences do you think should be cleared when an account is created?

If there are any, should they not instead be local/per-account prefs?

If not, don't we need to have two classes of global prefs?
Jean-Marie, could you explain (in the javadocs) the difference between handleException and handleConnectionException? Their javadocs are the same. Also, in general, I don't quite understand when the boolean should be checked and when not. I understand that if handleConnectionException returns true that means that the gateway couldn't reconnect and therefore there's still an error. What does true mean from handleException?
Space before the parenthesis.
do you need the above `end_time` line?
Did you try to run the whole testsuite ? AFAICS, the annotations are not registered anymore, which is likely to cause some failure
ah obviously without the STDERR.puts there - maybe do Log.error(".....") instead to log to the mco log
2.0 already have a RegistryInterface in the doctrine bridge (for the ORM only) so if your code is ORM-only, it could use this interface (some methods in it are deprecated in 2.1 as the Doctrine Common names are a bit different but they are still there for BC)
Can we also add a URL in here where we got the file?
stole the code from elsewhere...  fixed.
It wouldn't be correct. They can be zeroed out by arbitrary memory management routines (the GC, clear(), etc).
ок, исправил
Hmmm... :coffee: + :beer: = :bangbang:

Lol think its NFSW?
this should point to the master
Probably travis failed couse this :\
this is not necessary, is it?  remove it and the related imports.
This can only happen if `positions` is empty, right?  Why not make that explicit?
Gosh you guys are so strict... works on my box. :(
Can we use `url = serializers.HyperlinkedIdentityField(view_name='blogpostcomment-detail')`, and the behavior previously mentioned please.
This means you'll only support django 1.4.3 and 1.5
> Your sentence is different that the previous one

That's how I understood it. I guess maybe because it was long and tried to deal with all cases in one sentence.
I think the standard for MPL is ``import matplotlib.pyplot as plt`` by the way, I used that in a few places.
I'm a little nervous about this.  If other people decide to take use our namespace, this could mess them up in ways that would be hard to determine, yes?  Or maybe not, since it's ultimately just fronting the `salesforce/plugin/sdkinfo` plugin.  Generally speaking, I think we just need to be careful with the veracity of this information, when we're using it.
I'm missing a class called 'holiday' at least it is not showcased.
Use Log.e for any exceptions that need to be fixed. also, you can give ine as the third parameter to Log.e, which will provide the complete stack trace in the logs as well.
Can you get rid of the commented lines?
Please don't ignore the .gitignore.
Good idea -- though, I'm not exactly sure what the best practice is on this, or how well routes support something like prepending a locale to the route stack... @DASPRiD may have more feedback on how he intended to handle this.
Again, don't mention fixnum, just use the term integer.
thats what I mean; typically they've rather states like: (a) nice to
have (b) required (c) ...

Kind regards,
Andreas

On Tue, Jul 24, 2012 at 8:43 AM, Peter Grman
<reply@reply.github.com>
wrote:
>> + * ownership. The AASTI licenses this file to you under the Apache License,
>> + * Version 2.0 (the "License"); you may not use this file except in compliance
>> + * with the License. You may obtain a copy of the License at
>> + *
>> + *     http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +
>> +package org.openengsb.domain.requirement;
>> +
>> +public enum Priority {
>
> I'd say yes - already when you define the requirement you should know what is the priority of the user for it.
>
> Example how I understand it from my work:
> Requirement to implement the new taxes in a banking software which you need have from next year on - very urgent
> Requirement to exchange a current feature with something which is easier to use or enables more configuration possibilities can be somewhere between normal to nice to have.
>
> I'd say that most of the ideas for improvments which take some days to be implemented are requirements by the client - or am I wrong?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-domain-requirement/pull/1/files#r1222521
the last sentence sounds strange
Ok, so, is this sub sitemap referenced in the root sitemap automatically by django? Or do you need to precise it?
- missing space after ``foreach``
- extra space inside the parenthesis
- missing curly braces
- wrong indentation for the next line
На медленных машинах всяко может быть. Смотрите сами.
I could remove that. The webplatform function doesn't return anything.
can you put some whitespace around these two for loops, it looks better for readability when you enter a conditional block/loop, other than that I am good with this code
@jkeshavarzi - if you need this flag for completely different reasons than this pull request, it should come in as a separate commit. Don't pollute your commits with unrelated changes.
At a later point if pull this change out of the release, you will wonder where this flag went
Please separate this flag change out a separate change
jake test is failing on CI machine
Convert this to be a private static variable (no lazy init).
Should we add a license here?