List results grouped in  MUST, SHOULD and EXTRA test (#68)

Avoid the repeated MUST, SHOULD prefixes which decreases readability.
Removing extra Note: from CheckDefattr (#95)
Use ASCII instead of ascii in user message (#102)
Exit status of run-tests.py is number of errors and failures

This means we can now check for exit status to verify all tests ran
succesfully. Will be useful for running in %check and make_release
testing
Don't filter blank lines in spec file sections (#83)

Old code remove blank lines in spec_file.get_section(). Now fixed,
blank lines are now returned as other lines.
Merge branch 'devel' of ssh://git.fedorahosted.org/git/FedoraReview into devel
Update README with "How to run from git" instructions (#94).
Run all tests before making a release

we removed make_release test because we'd end up with recursive
releasing
Remove bugzilla options assign, login, comment (#67)

These functions doesn't really fit in fedora-review's overall mission
to create a review template. Furthermore, the dependency python-bugzilla
nowadays contains the 'bugzilla' tool which can make a plethora of
actions to create and modify bugzilla bugs. Removing functions in order
to clean-up the CLI interface and keep the application as small as
possible. Adding a SEE ALSO bugzilla reference in the manpage.
Add a message if user uses old options --login or --assign

Prints a message if any olf the old options is used. Blocks using
old (short) options for other purposes. Temporary, transition fix.
Merge branch 'devel' of ssh://git.fedorahosted.org/git/FedoraReview into devel
Bugfixes
Change defattr check from MUST to SHOULD

This change better reflects current guidelines. It can be there, but
why bother if EPEL5 support is not planned
The gem exclusion for RubyGems is not a must, but a should.
Set a timeout for downloading sources to 30 seconds

Originally we didn't have any timeout so we could freeze here forever
Copy srpm sources if unable to unpack

Since we are using rpmdev-extract a failure to extract most likely means
we are dealing with non-archive. So instead of unpacking we just copy it
the same way source.py is doing

This fixes following exception:
Traceback (most recent call last):
File "/home/w0rm/work/projects/fedora-review/src/FedoraReview/review_helper.py", line 130, in run
self.__do_report()
File "/home/w0rm/work/projects/fedora-review/src/FedoraReview/review_helper.py", line 81, in __do_report
self.__run_checks(self.bug.spec_file, self.bug.srpm_file)
File "/home/w0rm/work/projects/fedora-review/src/FedoraReview/review_helper.py", line 102, in __run_checks
writedown=not Settings.no_report)
File "/home/w0rm/work/projects/fedora-review/src/FedoraReview/checks_class.py", line 182, in run_checks
test.run()
File "/home/w0rm/work/projects/fedora-review/src/FedoraReview/checks/generic.py", line 348, in run
f.write(diff)
TypeError: expected a character buffer object
Handle case where make_diff returns (False, None)

This possible return value was not handled properly, possibly resulting
in backtraces when trying to use None as character buffer
Do not try to split %config lines

We assumed there was a space between config and place but this is not
neccesarily true. For example git.spec has:

%config(noreplace)%{_sysconfdir}/xinetd.d/git

So instead search the whole line for occurences. We should probably
work with expanded macros here, or do some other magic as
well...searching for datadir is probably not enough.
Lowercase spec file line before comparison

changelog macro is not necessarily lowecase so we fix this
Test if path is existing file not just the existence

If any source was %{name} this caused problems during review using '-n'
switch because we assumed a directory %{name} created by us was the
actual source.

For example see ht2html specfile