labofsahil/github-event-dataset-2012 huggingface dataset:
This commit breaks the action pack tests, specifically:

> ruby -I lib:test test/dispatch/routing_test.rb -n test_resources_are_not_pluralized

/cc @fxn
If ever there were a place for a comment...  :-)
So... Debian/Ubuntu went with libav because a libav dev said it was better, than ffmpeg. How rich. :) On that basis alone we should do the same too ?
Sure, I just copied this code without refactoring it. Sorry.
删了吧。
@pixeltrix We were chatting on I believe the same issue on another post (my mistake that I didn't look in this post before). I have the same identical error, and the error is not fixed avoiding to pass nil parameters to the url (the url is correctly generated, but when you hit it, then the no routes error come out - I ran rake routes, and my routes are right).

In my case this happen on models for which I didn't use the before_create method in the model (then empty models).
null **location**, not world
Jejejeje, si mucha inspiración :)
Нельзя strlen на utf8_strlen заменять - там специально измеряется в байтах, а не символах. 
Это для ограничения максимального размера объема данных вставляемых в базу данных.
Yeah, but otherwise I couldn't get a decent formatting. Table sticks with last item in a list, which sucks. Any ideas?
no, not intentional. I end up making that change every time I clone (I prefer not to have to setup a vhost per site I'm working on...)
https://github.com/sgraham/ninja/blob/deplist/src/disk_interface.cc#L30
and
https://github.com/sgraham/ninja/blob/deplist/src/disk_interface_test.cc#L87

Thanks :)
@wicz upon further thought perhaps this just needs to be a private method in `plugins/default.rb` since that's the only module that directly uses it.
Good catch ... I should have tested on windows too :B
Thanks for this.. some of it is accurate, and some isn't.. So, the loaded event is in fact fired as stated in the current documentation.. some of it is out of date, but what is described does work -- if it's put into the page that's being loaded.  If it's inside the mercury config, it has to be different, which should be added.. but look at the code here:


      Mercury.trigger('ready')
      jQuery(iframeWindow).trigger('mercury:ready')
      iframeWindow.Event.fire(iframeWindow, 'mercury:ready') if iframeWindow.Event && iframeWindow.Event.fire
      iframeWindow.onMercuryReady() if iframeWindow.onMercuryReady

You can see there that the events do happen, but they happen within the page that's being edited.. This is important, and I think we need to call that out more, but the changes to some of the readme isn't accurate.
also above would I with agree re: bump.
Don't do that :)
Hmm, that does actually work...

Definitely need to test more, but it may just do the trick!

Thanks!
 :3
Eh, that was a comment in the commit on the code for the timestamp method. Where Time.at 0 it should return Rake::EARLY. 
The way it appeared as a comment on the pull request was confusing.
I kept going back and forth on how/when to check the `use-gm?` but I think you're right that extending `stringify` to handle `ImageCommand` and checking `use-gm?` at that time would work.  But, to clarify, are you suggesting that we do **NOT** execute the subprocess with `ImageCommand.run`?
included a fix now as well
I'm not tied to anything... I think I picked this up when the religious war about having multiple "var' statements became a no-no.  I'm fine with putting them at the end as long as there is some kind of formatting to keep things lined up like:

```javascript
var shortVarName        = 'someVal',
    aLongerVariableName = 3,
    somethingMedium     = new TestClass();
```

The automatic comma insertion does not adversely affect the other syntax, but I'm definitely game for a switch.
Unfortunately, this change broke a lot of tests.  The asString()
command is used to generate the output that is used in many of the
examples.

Your motivation for this change remains unclear, and hence I am
struggling to suggest an alternative.  Why do we need to make these
characters visible?  When?

--Bill

On Sat, Mar 3, 2012 at 7:17 PM, Allan Odgaard
<reply@reply.github.com>
wrote:
> The `\t`, `\r`, and `\n` characters are all “ invisible” so if e.g. testing a function to harmonize line endings or indentation, the test output without using the escaped form will not be helpful.
>
> By doing this, escaping backslash naturally follows to keep it from being ambiguous.
>
> Escaping of the double-quote was added for aesthetic reasons (now that escapes were introduced). The entire string is double-quoted in the error output so it seemed wrong to have non-escaped double-quotes inside the string.
>
> As for breaking tests, I assume it is breaking tests about how `asString` should format a string? I.e. the patch should have updated the test as well for the new output.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CxxTest/cxxtest/commit/f50d7d67a41ba76c6c2db2e41e1619e0b99beae6#commitcomment-1039589
Ugh, bash fail FTW
This is roughly the code generated just for "%f":

```
  x = arg1::Real
  if(isfinite(x),
  tuple(neg,digits,pt) = _jl_fix10(x,6)
  if(length(digits)<=pt,
  x = *(rpad(digits,pt,"0"),".","000000")
,if(pt<=0,
  x = *("0.",^("0",-(pt)),digits,^("0",+(-(6,length(digits)),pt)))
  x = *(ref(digits,:(1,pt)),".",rpad(ref(digits,:(+(pt,1),:)),6,"0"))
  x = *(if(neg,"-",""),x)
  if(isnan(x),
  x = NaN
,if(x<0,
  x = -Inf
  x = Inf
  x
```

That seems like an awful lot to crank through for every format specifier.
I rewrote it like this:

```
if (Token::simpleMatch(tempToken, "; else")) {
    if (tempToken->strAt(2) != "if")
        innerIf = false;
} else
```

should be better than actual and old one...
Have you run tests?

There is a test that fails after this change: `test_regex_extractor (test_extractors.ExtractorTest)`

To run tests just type `nosetests` in the root of the repo, as the README says.
It looks like these two imports are not used, please remove them.
jupp, überbleibsel von als ich noch kein confirmation eingebaut hatte...
könnt man mal optimieren :D
to master!!!
I think we should at first delete all creatures and gameobjects on map (strand of the acients) and then calculate the new entry.
With this if i rerun this sql-file i have more and more npc and gameobjects in world
ah lol - now I know why these comments didn't show up on my github main page :)
Shouldn't be necessary to filter in this case. StatesView is a singleton class (i.e., there is one global StatesView, not one per document) that listens for changes in editors, and only shows content for the current editor. As a result, it should only get "context/loaded" and "context/statesLoaded" events for the current editor. I verified by putting a breakpoint in the callbacks when multiple editors were open and the callback was only invoked once when either a new document was created or an existing document opened.
Ah yes, good catch. :)
@philsturgeon May I ask, should those indexes be add for creation on the initial stage of table creation too?

*bonus question because I rock:* How would one check if those indexes exist already (so that they don't get created) through the Codeigniter database or AR classes?
of course, this was intentionally rel-410 as that is what the customer needed.  i;ll commit it for devtip
有了，谢谢。原来是拒绝了。
刷了一天了，在订票时老提示：

系统忙！
请点击我的订单确认客票的状态后再尝试后续操作。谢谢！

RP不好啊。
Use git status or git diff
Otherwise it clashes with the current user that is logged in.

-- Amin



On Thu, Feb 23, 2012 at 2:13 PM, William Cook <
reply@reply.github.com
> wrote:

> Why change the name from "user" to "renderingUser"???
> This will break everyone else's code for no reason.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/amshali/OpenBook/commit/64befabcabb6b2e1b66ec1bcd2e146f8e90d8f06#commitcomment-1004199
>
Patches to support Postgres are welcome. I use MySQL exclusively.
mistake here, it's supposed to be `25%`
It seems to be missing- the download link on this page- http://logix4u.net/component/content/article/14-parallel-port/16-inpout32dll-for-windows-982000ntxp takes me to the site's homepage. Do you have a copy?
You should replace ereg with preg_match because it is deprecated.
I just had problems with some scripts where I had overwriten the error_reporting (I don't know why) witch brokens on some ereg_replace in the Convert-Class :p.
- else if (s == GO_READY)
+ else if (state == GO_READY)
pitäiskö tää päivittää toimivaksi?
yep, probably a good idea
I totally forgot to uncomment those lines! Sorry.

On Mon, Feb 20, 2012 at 4:45 PM, Zuzel Vera <
reply@reply.github.com
> wrote:

> You forgot to uncomment these css (this bit should be used on the tasks
> list at a challenge home page but not on the page of an individual task), I
> will uncomment it while doing the merge.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/rsoares/lernanta/commit/ed14918e435f8d64eeed5b941361e141c7b293a0#commitcomment-986340
>



-- 
Cumprimentos,
Ricardo Soares
> I really don't want to tackle the idea of "adding actions to the global keymap" as I cannot come up with a good way to do this. Inheritance is supposed to be achieved through transparency anyway. There's nothing fundamentally wrong about having 2 or more global keymaps in the stack.

Frankly I would've thought it's just a simple matter of adding the actions to the Keymap instance, but I guess it's more complicated than that.
Fixed, removed ' / ' now it is only /search
I would avoid using the class name ".body" because it's easy to confuse it with the body tag. Something like "main" might be better.
Steve, I'm sorry, but I don't like this merge.

1. You show up as the author for all of it (which sucks for locating the original author of the code).
2. You've merged together all the commits. Most of my commits changed individual things, so that a subsequent `git-revert` could reverse one change without reversing everything in the pull request. In some cases where I found bugs later, I used `git-rebase` to "fixup" the relevant commits rather than jumble things together.
3. You've pretty much omitted all my javascript tests (and any of the JS cleanup I did).

I'm happy to wait a week or two if necessary, but can we please go back and merge this properly. If you don't like the JS work currently, just pull in Celery for now and I'll rebase the rest for your review later.
Well, I was inspired by davidsarah's suggestion of "% (prefix,)" (below). But, now that I think about it, .startswith() will give a reasonable complaint if either of those types are wrong, so nevermind.
The result is quite beautiful, I loved it.
Trying my discovery about bits field... I doubt I am going to keep it ...
El idioma con 'efe' causo sensacion :)
Instead of using almond, this kind of use of define() could just use a simple 

    function def(factory) { factory(R); }

stub, where R is the raphael object created in core. If you use r.js 1.0.6, you can have an onBuildWrite function that rewrites the define() calls to the def() call that just passes the factory function. Here is a reference for that:

https://github.com/jrburke/mvclib-template/blob/master/tools/build.js

It is a bit more complex and you can ignore the onBuildRead thing -- that example project was dealing with node-native source files and had to adapt them to use define() for the build. But the onBuildWrite stuff is useful, in addition to the use of the wrap arg to include a wrap.start that has the simple def() definition.

It also might be useful to keep the make file, and have it just call r.js, passing include= for anything that is additional in the other files it builds.
If you implement my suggestion with the template here, application developers could choose "OpenLayers.Protocol.Script.registry.${id}" or "OpenLayers.Protocol.Script.registry['${id}']" (which are just two different notations for the same), depending on what their server supports.
Looks good.

This fixes anodejs/node-spinner#1
From the [RSpec 2.8 release notes](http://blog.davidchelimsky.net/2012/01/04/rspec-28-is-released/): 

> When you use --order random, RSpec prints out the random number it used to seed the randomizer. When you think you’ve found an order-dependency bug, you can pass the seed along and the order will remain consistent:

>     --order rand:3455

So specs can be made deterministic for any particular seed.

Over time, we should catch all of the order-dependency bugs in the specs.
mkorpela: Yes, sounds like it's related to that
Thanks for explaining, you're right, I only trade the #!/bin/bash by #!/bin/zsh =p
whatever you want, doesnt matter. pick a high guid (like 500000)
My rewrite effort is sort of 3/4 done. I still need to update the visuals in the playing view, which currently just shows a boring data dump of the currently playing song's various metadata. I'm not sure what to place in there, though. I'd also like to write a quick mod playback time estimator (rather than load the file into UADE and ask the plugin to estimate it), so that I could show playback times for all major formats people are likely to see: SID, MOD, XM, S3M and IT. Other formats don't really matter, I think...
How does it know the module name if we do it like this? The module's code won't get evaluated prior to it being required.
Update to new property access syntax.
Oops did not update the folder structure in README. I'm using app/ rather than vendor/ as that's more appropriate. Feel free to update. Thanks!

```
app_root/
  app/
    themes/
      [theme_name]/
        views/
          layouts/
          ...
        assets/
          images/
          javascripts/
          stylesheets/
```
Lioncash kirjoitti 9.2.2012 kello 6.01:

> I realize that every format in this library will practically have to resample to 44100Hz. As the library itself does not do this, and considering the fact that my knowledge in upsampling and downsampling is practically zero, I have no idea on how I'd implement this. Any thoughts?

Let android do it. It will use high-quality sinc resampled internally to do the work. Here's how:

1) Add a method in plugin that returns the sample rate of the audio stream.

2) Make async package player query the plugin's frequency, and then passes that. It's currently just a static constant.

3) VisualizationView also needs it (it has the frequency halved somewhere, 22050). It can just get that from OverlappingFFT.Data which is the container class used to pass FFT data. The variable frameRate already exists there, so you can just add that.

-- 
Antti
Yeah, that's what I suggested above. Just committed the fix.
Nice, what do you think about getenv() usage to avoid isset usage? This can look like that:

    $debug = $conf->debug or 'development' == getenv('APPLICATION_ENV');

    defined('DEBUG') or define('DEBUG', $debug, true);
commit should read:

add uart3
I just removed @sample lines leftover now, while going through build
problems. Now at least packaging produce no warnings. Will re-check a
bit later.
Fixes a crashing bug that could take place if a tag was defined, but the description was empty. i.e. '@param foo '
Thank you! We were pretty close then I guess. scrollSupressionThreshold seems a bit weird still (we're using a number of 100 on that for an app that navigates between long scrolling pages via swipe where most people in our user testing want to be scrolling down the page not swiping on any given movement).
good job Maik and Mario !!! Thanks so much !
On 20/01/2012 16:08, Drew Fisher wrote:
> Is this liable to cause issues on systems where libusb-0.1 is
> installed?  The usual pattern I see for having both installed is that
> libusb-0.1 is called "libusb.so", whereas libusb-1.0 is called
> "libusb-1.0.so"; will this line wind up finding and using libusb-0.1
> if libusb-1.0 is not installed?  What about when both are present?

It cannot cause issues on systems where libusb-0.1 is installed because
it will search first for library called libusb-1.0.so. If libusb-0.1 is
present and libusb-1.0 is not, there is still no problem because in this
case, libusb.h will not be found. I have verified this on my linux laptop.

> (Is libusb-1.0 called libusb.so on Debian kfreebsd?)

Actually, kfreebsd does not use libusb-1.0 per se, but a library that
provides a compatible API. The same library provides also the libusb-0.1
API which is the reason, I believe, why they use the common name libusb.so

> We might also have to figure something out for the Windows side,
> where we do ugly things to emulate libusb-1's API using libusb-win32
> (which is a fork of libusb-0.1).

Sure, but it is just a matter of one include_path to check. (I don't
have easily access to a win32 development environment to test it).
Does searchByCoords() work without captcha for basic members ? Is the captcha only needed for the coords ? Hm....
With a zoomlevel of 14 or bigger we have to do more than one requests. It's nevertheless possible but i want to keep the number of requests low.
I encountered some flash files where a SymbolClass tag referenced an ID 
defined in a DefineBinaryData tag that occurred _after_ the symbolclass tag.

This was an obfuscated SWF, and I know that such errors should not occur 
in the SWF, but it did happen, and somehow the flash player handled it 
correctly.

Alessandro has also mentioned that it resulted in problems, which I 
didn't see when testing the commit, so I hope we can find a compromise 
that works for all files.

Cheers,
Timon

On 02/27/2012 02:54 AM, mgehre wrote:
> Why is this necessary?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lightspark/lightspark/commit/bf7c215b9b9c84de4904f1589c9a02b7b6eadf31#commitcomment-1013369
Now that the cart is in the sidebar, we need to make sure that any controller action that is called knows how to render the cart.
This is a great implementation. That is all.
Seb, the dev branch is already closed. 1.92 has moved to 'master'  - please do not commit here anymore.
What path is this in reference to?
Also, could you point out which bits of code are pre-defined helpers? (abs_path)?
nice! this pumps me up :)
Looks like this broke some regression tests: https://ci.mozilla.org/job/amo-validator-functional/125/ I haven't looked into why yet...
gotcha.. I guess I can live with that ;)
Please don't use arrays for `script:`. It works almost by accident and will be removed in the future. Do this instead:

``` yaml
script: python runtests.py
```

Also, `language:` key will be mandatory in the future, please specify it even if you are trying to hack the system to build Python projects.
You can certainly rely on it in conforming server side environments and in any app that doesn't support IE<9 (which will become increasingly common as time goes on).  Why wait for a regression and a bug report when we can test for it now?
You can just pass the addresses as an array (or comma-separated list), the library will take care of this.
Fuk, i missed that lol
Changes already in my version Beta prep 2/22/2012
yes, and marginally yes.
Theoretically, no - there could be more than one unique property. In practice, I think one is enough. However, we'd need to put in some code to throw an exception saying that more than one unique property isn't supported.
Try replacing these with 

    Player[] list = sender.getServer().getOnlinePlayers();
    boolean playerFound = false;
    String matchedNames = "";
    Player checkNames = null;
    int amt = 0;

And remove the declarations for these from the top of the function.
Here how labels have to be implemented http://stackoverflow.com/questions/3516478/rails-i18n-and-yml-structure-for-form-labels
Hi,

have to redo that, as it's first diff introduces a tautology: if a feature is present, you must not load it...
Will come back with a changed patch.

Andreas
Bien lo de Mustache. Lo único, tené en cuenta hacerlo despues que termina la carga del documento (ver document.ready, como en ejercicios anteriores).
(though it makes no difference if the header size is aligned on same power. But if you upped aligment to 8 but header size was 4 it might be significant).
ok, but will it be the same thread (itself) ?
Otherwise we still need to ensure writes are safely published; maybe not necessarily synchronization as we could reuse some of the other barriers.
welcomeページの処理のときだけ、header.inc.phpを読む前にいったんphp内でバッファリングを有効にしておくという方法がありかもですね。

ob_start();
include_once "header.inc.php";
include_once "actions/welcome.static.php";
ob_end_flush();
include_once "footer.inc.php";

思いつきで書いちゃいましたが、こんな感じでしょうか。
でもプラグイン周りで変な動きがありそうな気がします…大丈夫かな。
Please check if .infoLabel is used at any other location in the code besides the search box.
So, the thought was, maintaining isolation between each gem, to be sure core wasn't pulling in any dependencies from renee itself. I was doing this before by maintain separate gem files. But, I see your point. It IS a pain to have them separate. I'll put it back together, and hopefully nothing too bad will blow up. Perhaps we can even find a nicer solution for gem isolation when you have multiple gemspecs per project.
mhh nooo this stupid revert shit -.-
7) hcitool dev && hcitool scan
I like @GaelVaroquaux suggestion too.
It can be placed in the project build scripts:


//////// 

MobileSafari_PID=$(ps x | grep "MobileSafari" | grep -v grep | awk '{ print $1 }')

if [ "$MobileSafari_PID" == "" ]; then
  echo "Mobile Safari.app must be running in the Simulator to enable the remote inspector."
else
  
  cat <<EOM | gdb -quiet > /dev/null
  attach $MobileSafari_PID
  p (void *)[WebView _enableRemoteInspector]
  detach
EOM

fi

////////

The script above may be repurposed to fit within the phonegap/cordova project environment and may give a hint on how to add it to the project template (Build Phases > run Script) and not directly to the AppDelegate.m
Could you add yourself to the changelog?
Pobeg iz labirinta je igrica, ki jo delamo na programerskem krožku na Gimnaziji Vič.
Good point. On a related subject, do you know what would be the best way to install this gem? The only way I can think of for a standalone gem that's not on rubygems is to clone the project and run gem build and gem install.
Please also rename simd in runnable/testxmm.d as well.
Oj! Gjord efter förebild?
Do you mind using collective.eggproxy repository from my organisation rather than this one?
https://github.com/camptocamp/collective.eggproxy
We plan to add a collective.eggproxy team and add you to that team.
Actually, I meant 'middle clicking' on a video thumbnail, not 'right clicking'!
She gave back the rough draft and said to talk more about the company and
product, that last part before wasn't needed, and to end on a positive
note. But yeah sorry I went a bit overboard. Just looked at a blank
document day before it was due and wanted to fill it in.
On Feb 14, 2012 1:20 AM, "Jon Wallace" <
reply@reply.github.com>
wrote:

> The preface reads too much like a brochure, it should introduce the policy
> manual, not the company and it's direction. Also, I notice you pretty much
> re-wrote my section. We should talk about the style of the document because
> clearly we have some disagreements and I'm sure you don't want to have to
> re-write everything I do. especially when we get to the proposal.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ngokevin/technical_writing/commit/a267c7c1c51f443378e6c4093ca308643cf52f9e#commitcomment-963768
>
There's a typo at the end of line 68. Switch the "i" and "o" in "location." Full text here: 

"...press OK to visit your LOCATION settings."
We probably don't need to re-assign the $ inside the function now, kind of redundant
What's the difference between Holo and DeviceDefault? Isn't Holo only on Honeycomb?
For really ironclad safety, I think this key needs to be used with `&`, lest someone else define the same string as a key and have it get coalesced into the same pointer. Unlikely to actually happen, but.... (This goes for all uses of this key, of course.)

More importantly, this set ends up being hidden shared data, and so access to these sets really needs to be synchronized for thread safety. Even if we say the API is not thread safe (and it would be good if it was), it's unreasonable to expect the caller to treat separate observations as being unusuable from different threads simultaneously, and especially not for separate notification centers altogether.
Could you use `innerText` instead of `innerHTML`? It's more or less irrelevant here, but `innerHTML` is potentially XSSable: `innerText` isn't, so it's good to get in the habit of using it whenever possible.
I dont really see a point for a blog here. I'll keep posting news on the hongfire thread. Relevant information will be kept in the wiki and maybe we'll fill the web. But a blog... I dont see need for it.
How we will solve fm radio noise. It is annoying. Because no music after 10 minutes, just noise.
Fixed: c5fd17ad14013abd7d5f4f44912fbe0c7d6148cc
I don't like the duplicate code likes that your way to process RestComment
thank you Yorick Peterse for this patch
@cjmaclellan 

this needs to be submitted from the hopspack directory
Twisted, I wasn't trying to pass your code on as my own, Kali wanted the camera work uploaded to look at, it's very work-in-progress and gerrit was a good place to dump it. Hence why all 3 changes are marked as "Do not submit".

Apologies for not putting the credits into the gerrit change right from the beginning, I hope it's acceptable now.
itではなくpending が適切だと思いました
rake specでpendingの箇所が黄色くなります
${S}/jb
No, assumed it was something to do with the NetCDF since it's transposed to be put in there and transposed back again when we get it out.
toHex and toRGB allow you to just pass the string just as Y.Color allows now through DOM, by auto setting `options.css` to `true`. Modifying this to another name wouldn't be adding complications, but maybe I'm misunderstanding.

I like the idea of an assert package in there too. Should that be part of 'color' or a new submodule 'color-assert'. The regular expressions used are attached to Y.Color, so they are ready to `exec()` for tests, just dont have sugar methods on them.
Thanks.  I'll look into it ([ticket](http://yuilibrary.com/projects/yui3/ticket/2532740)).  

I assumed it wasn't due to the call sequence
```
renderer: function() {
	// kweight
	var widget = this;
	 
	widget._renderUI();
	widget.renderUI();
	 
	widget._bindUI();
	widget.bindUI();
	 
	widget._syncUI();
	widget.syncUI();
},
```
but that is only the methods, which isn't necessarily reflective of event timing.
I deleted it because it was not used anywhere. Then I just moved the $container variable to the beginning of the file. So I didn't really change the name of anything.
Use of an enum here would be preferable.
Shouldn't it be contains instead of equals ?
I hope not, that is an interesting test, to join when already joined, please create a ticket
ie. very nice!
mapping uniqueness should be enforced here.
I don't know what that path is used for. That was how it was done in corresponding RemoteRouterConfig. I have changed to use named parameters instead, so that the default value for the path is used, i.e. ""
I just wish it was easy in Java to see that they shouldnt call it.
changed to `suspedChildren(exceptFor = skip ++ childrenNotToSuspend)`
These are all public to JAva code
examples need to go into bin as well
I think this test can be 'if codename', but we need tests for it, then.
I think besides initializing it to nil, this is the only setting of @unmask_render
Please read up here on how to do this particular change using rebasing: https://gist.github.com/3206116
I strongly recommend using a multiline field here
Personally, I'd have the following to start the method:

if (OperationMap.Count == 0)
    return;

That way you don't have to indent the complete logic in that method.
Sure, but the one can simply be obtained from the other as "~b0_indices".
What is the exact indentation problem? Comma after str would solve that?
Is this needed for the old templates?

if so maybe we could do something like

    @property
    @depreciated
    def activity_stream():
        return get_action('package_activity_list_html')(context, {'id': c.current_package_id})

    c.package_activity_stream = activity_stream
Can you rename the plugins to <whatever>_preview/proxy to be consistent with the other ones?
Totally minor, but the comma belongs after resolve, not resource.
good point. nick says that he never wants lines to wrap, so everything should be `white-space: no-wrap; text-oveflow: ellipsis`,  so we could probably get away with this, though i don't like having to rely on it.

the only other option i can come up with is to set like a `data-model-id` attr on every row, so that even if the row is no longer in the DOM, we can still link it back to a model. i wanted to stay away from that, because in my experience, it always gets abused. we want the one and only way to go model <--> row to be the `_modelFromTr` and `_trFromModel` methods. 

so any thoughts on other alternatives?
At the moment (before SCN) is it possible to have many time the same timestamp...by looking at the other existing feeded, that seems to be the case. If that is true, then this code could 'skip' event.

Also, if that is true, I think we should refactor both classes and put common code in a parent class.
Please put the { on a new line, so it's in line with XBMC's coding-conventions.
does the caller need to know about the id? Or could it be abstracted out (return void). It is just that the result is sometimes an ID and sometimes not. That's what I was trying to avoid.
I would rather name this module vm_guest. Its all about guest commands.
Please address any TODO comments. Remove them if no longer applicable.
There is {elseif}
Including empty lines?
This is uglier, but OK :)
Based on: https://github.com/ajaxorg/cloud9/blob/master/Makefile#L25

@gjtorikian ?
Fair enough. Will add it in the new pull request.
Should the sandbox extension be registered in the abstract class ? It seems to me it is not useful in many cases and so should go in the Twig testsuite only.
Let's leave it as a private joke ^^ (oh no... "private" joke... things are getting worse)
I remember saying that a while ago too.... ._.
Or, since a bool is an `unsigned char`, you could, use this: `_footerView.hidden *= -1;`
Okay then, please check if these properties are different than what the current values is before setting them.
It's used only in the else branch below.
Decorators still use full paths, right?  e.g.

decorators.push("/scripts/lu-decorators/positionAbove");

???



On Mon, Jun 11, 2012 at 4:03 PM, Robert Martone
<reply@reply.github.com>
wrote:
>>   */
>> -var Container = require( '/scripts/lu-controls/Container' ),
>> +var Abstract = require( '/scripts/lu-controls/Abstract' ),
>
> with the version of inject I committed on Friday - they should 'work' - fingers crossed.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/Lu/pull/153/files#r963723



-- 
jimg at yojimg dot net
Protože https://github.com/nette/nette/blob/master/Nette/Config/Extensions/NetteExtension.php#L266-268
большой сложный метод, разбить на несколько
в роботах такого не было :) 
за это должен отвечать arrangeLinks - в роботах всё ок
это не мешает добавить их и в верхней строчке :)
I don't think so, the `authors` in that case is a symbol. https://github.com/frodsan/rails/blob/97e74917a0ae06a404d0e01bf604d6edc974328a/actionpack/test/controller/parameters/nested_parameters_test.rb#L9

Now it is a string.
Could compact to `(time_zone || ::Time.zone || ::Time).now`
```
Apply(Select(
  Block(List(ClassDef(
    Modifiers(scala.tools.nsc.symtab.Flags.FINAL), tpnme.ANON_CLASS_NAME, Nil, 
    Template(List(Ident(AnyRefClass)), emptyValDef, Nil))),
  Apply(Select(New(Ident(tpnme.ANON_CLASS_NAME)), nme.CONSTRUCTOR), Nil))
, sn.GetClass), Nil)
```
This was previously called `remove`, but I've renamed it to `remove_transition` so that there isn't a "mysterious" `remove` method on the `Order` class, and so that it fits more into the same theme as `find_transition`.
Please try to follow the format of the tests already there. In this case this just means calling "pretty" und "upretty" instead of "pprint". (In this case it's trivial, but if someone looks at the test they might wonder why this one is different.)
It is `N**2` work rather than `N`.  We just need the diagonal elements.  I think we have a way of getting the basis kets and then we could do the diagonal inner products and sum ourselves.  But, someclasses might have custom representation logic to handle more cases and I am guessing that is the case here.  Maybe @flacjacket can comment on the best way to compute this here.
``euler`` indicates that the ``eulervm`` LaTeX package should be used.  Thus indeed, in a way, ``euler`` and ``packages`` are overlapping.  However, I would vote against merging them right now, because that would change the semantics of ``preview``: ``eulervm`` is currently enabled by default; if the two arguments are merged, this latter package would be disabled by default.

Note that I'm not a fan of Euler fonts, apparently; my goal however was to extend ``preview`` without influencing the existing functionality.
Same question here ---- aren't the two Piecewise the same? If so, why do the change?
This change probably shouldn't be here.
Don't need to test existence of Closure. The following is better:

~~~
if(is_string($attribute)) 
    ...do the old logic...
else
    ...call_user_func()...
~~~

This will allow both anonymous function and PHP callback in the form of `array($object, 'method')`
else if => elseif
This method seems a bit long, could some be extracted into smaller methods?
so derby passes an array that has a `body` parameter? that seems odd.
I think you can remove this line, if we decide to use jQuery here we'll import it again.
Right, the client would need to look up the site keyed by the queue URL if that's important. Should the site be a part of the encryption key?
Works on windows?
You've tested the output of this, I trust?
I think this needs to be /en/Project:Copyrights - I don't think devmo_url works without a locale
Also, even though it is being used as a service, the class name should describe what the class does. In other words, this class manage notifications, correct? So IMO a better name would be `phpbb_notification_manager`.
This should be part of the query if it actually does anything.
Same as above: paranthesis should be on the same line and not on a new line in JS.
$extensions is more accurate I think since the top level of the array is actual extensions (and the '_allowed_' element) and then each extension element has information about what group it's in as well as other things.
So basically, I'd like to have a new function that runs the two queries with a good comment. Also, replacing all current locations of those two queries with a function call should lower the number of code. I can help you with that, if you prefer.
What is the cause of these changes?
Document what happens when user is not loaded and query is false.
@rphillips Yes, it does https://github.com/racker/virgo/blob/master/agents/monitoring/default/client/connection_messages.lua#L219
Cool. I'm glad you reverted the changes to this.
I'd prefer to use an anonymous namespace here.
(As an aside, why do we have both `compiler()` and `precompile()`?  They appear to be doing the same thing!)
discuss as a team
Me to!
Wes has done great work with pandas -- it's really well thought out. I don't like python much, though. I haven't done much speed testing, but I bet we'll have a tough time getting close to pandas. We do have some advantages. With split-apply-combine, Julia's jit can work its magic on any function applied. R and python can't do that.
Use camelCase for functions and variable names
yep, oops.
Where is ```value``` being used?
Should this method receive as a parameter `\Sky\Api\Identity` instead of `array`?
Small coding style remark:
```
if replace_with:
```
is more readable (and efficient).
Besides this, sorry I don't understand this code well enough to review this PR.
It is good for me.
Why is this needed? node is not copied, node.op is.
This refactoring is great. 

It would be nice if refactorings like this could go in a separate pull request from the feature change. Combining refactoring with new code makes for reviews that are hard to read as digestible chunks. I know that's more work for the reviewee, so we should talk as a group about what makes sense and when.
This is going to become an intermittently failing test.  Can we turn this into a repeated poll for the expected value at the end and just go into an infinite loop if it never matches?
Why use `max(1, ...` here if not on line 507?
Is there a reason why unicode() wouldn't work?
Handle freeing of previous modifier linkable list here.

Is there any danger involved in freeing it here?
Just use `contextlib.contextmanager`, you'll be much happier.
this change is wrong according to the Doctrine coding standards. Please don't change the CS of the existing code
Could you remove this method? Now it just calls its super, so its definition is useless
This was discussed here: http://bugs.jquery.com/ticket/12904
Just to mention, not sure what your minimum supported jQuery is, but if you only support 1.6+ you can use `.always( next )` instead of `.then( next, next )` also
Hmm, that's a good idea to clone the current repository.
Why don't you call srandom() instead of setseed()?  I don't see the reason to use SQL function here.  Same for drandom()
Say, all rows that have been seen on the right were negative weights.
global leakage also remove spaces around target
Nit: This should be at two indentation levels. The first is the (, the second is the {. So it was correct initially.
We don't really like to package forks like this.
jdob, if you could, pay particular attention to whether the above two lines should remain at their current indentation level. I decided that I thought they should stay here, but I don't feel that confident so I'd like to call your attention to it as well. Thanks!
unfortunately no. The fact that a distribution is orphaned or not is only evident in the importer. We need to some how communicate what to clean up to the distributor.
these changes should go into a separate PR
insufficient? Don't you want linkAll ?
Makes sense. I'm not extremely familiar with the code yet so just questioning on my thoughts of pure API.
invalid slot
(re-reading the [current Celery docs](http://celery.readthedocs.org/en/latest/userguide/tasks.html)) you may be correct, though the original fix works (preventing Celery worker death) in my original test cases.  I'll ask the Celery gurus for clarification.
Should be in your global gitignore, not here.
@visionmedia I've sent a PR to expose this in node-zmq:
https://github.com/JustinTulloss/zeromq.node/pull/162
We could probably remove `validateJsonById()` until we need it. As for `validateJson` taking dependencies, we could do it that way if you prefer.
Yeah caching isn't a bad idea, but keep in mind that orientationchange is completely insane in 2.2. The key with the timing is to make sure that our change is the last height change that gets made during the loading lifecycle.
This doesn't support unicode or upper-ascii. We may want to update the expression to exclude all ascii punctuation except $.

http://stackoverflow.com/questions/1661197/valid-characters-for-javascript-variable-names
Probably because once you start dragging, you need to keep getting the mouse move events even while the mouse is over some other element. It might be better to install a capture handler on document.body though, and do stopPropagation so other children of the main view don't process the move events. 

On May 4, 2012, at 6:36 PM, "Jason San Jose" <reply@reply.github.com> wrote:

>> +            
>> +            $("#sidebar-resizer").css("left", sidebar_width - 3);
>> +            $("#sidebar-resizer").mousedown(function (e) {
>> +                
>> +                // check to see if we're currently in hidden mode
>> +                if (is_sidebar_hidden) {
>> +                    // when we click, start modifying the sidebar size and then
>> +                    // modify the variables to set the sidebar state correctly. 
>> +                    $(".sidebar").css("width", e.clientX);
>> +                    CommandManager.execute(Commands.VIEW_HIDE_SIDEBAR);
>> +                    is_sidebar_hidden = false;
>> +                    
>> +                    // this keeps the triangle from jumping around
>> +                    $(".triangleVisible").css("display", "none");
>> +                }
>> +                $(".main-view").mousemove(function (e) {
> 
> I can't remember why the mousemove handler is installed this high up in the DOM tree. Why not on only the resizer itself?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/adobe/brackets/pull/798/files#r777907
``value`` wasn't either. removed both.
hehe, yeah I already told Sergi. He found another solution. Cool that you are helping out.
Good job for fixing this !!
@nashby I just made this change, thanks.
You can fix the same problem for logout, if it is.
Error message should be generic: like "Value is out of bounds"
Why is this here? Are you trying to stop things from listening to when the slider moves?
Need an alt attribute here
I don't totally agree with this. The way it's written now, each line's intent is a lot more obvious for readers (which I like).
See line 13
Ah, good catch. Title only gets escaped if I write `<%- title %>`. I'll fix this.
Wrongly named? IIUC this removes plugins in sonatype-work/plugin-repository
默认值设最大的时间值，这个默认值在出现maxidle指令的时候配置。如果用户只想设置maxidle值的话，maxlife过短会引起问题。
Текст в md лучше разбивать на строки не длиннее 80-90 символов.
Сейчас приходится скроллить вправо при просмотре diff, а это очень неудобно.
Tady bych použil moje, jen by chtělo vrátit místo analyzátoru zpátky parser.
This is not really a check on the layer being local, since we could still have WMS overlays coming from remote WMS servers and they would pass this check.
Broken style - calling function with arguments should have parenthesis
Why the drop(1) ?
IMO it's not a good idea. In fact, I would suggest making other templates follow this pattern because of this (taken from katello/manifest/config.pp):

    template("katello/${katello::params::config_dir}/thin.yml.erb")

once you change the ${katello::params::config_dir}, you're doomed.
This is line 11 under. My bad!
What do you think to having our own application class and then explicitly delegating to connect, rather than patching the connect object?
curly braces should be on the same line than the control structure (same than if, for, foreach and while)
fack. I'll force push clear this >__> and reset it
Don't like the `blue-button` class. The button certainly will not be blue when we update the visual :)
Just curious, why don't you use a display: none?
There's a difference between the head ( < head >), header tag ( < header> ) and the header tags ( h1, h2, h3, h4, h5, h6, etc.).

Every html page can only have one head tag.

I believe you can have multiple header and h1,h2,h3,h4,etc. tags but I prefer one single < header > tag on the page.

Also, for SEO, it's recommended to only use a single h1 tag on the page.  The hx tags are essentially a hierarchy of the page content, where h1 is the root element, and all the other hx tags are nested.
Ditto about the Numpy issue number (if possible).
要不request这个问题我们单独弄吧，Url类本身还是有用的，要不用Request类来处理url parse和拼装啥的也会怪异。
Suggestions? This breaks all *BSD builds and works on everything for non-static builds.
In project BL, the client has overloaded on purpose the plugin to that the tool is automatically toggled off when results are returned. It stays active if no result was found. (ditto than for regiogis).
Well, it passes the specs, so I assume it works. But here's the technical details (I do agree it's a bit vague upon initial viewing):

```
user has_many :memberships, ...
user has_many :groups, :through => :memberships
user has_many :discussions, :through => groups
```

so `user.discussions` is a list of all the discussions that belong to groups that the user is a member of.
`discussion_id` is going to need an index here. Maybe make it as a new migration?
These remaining defines should be surrounded with something like #if defined(ANDROID) || defined(BLACKBERRY), or even better would be #ifdef OPENGLES_20 if we had such a define...
Thanks for all of this discussion on a relatively trivial point.  At this point I'd rank the options as:

1. `~/.cython/ipmagic` (or  `~/.cython/ipy_magic`)
2. IPython profile dir
3. `~/.cython/magic`
`in_slow=all` or `in_slow=True`
Fixed! :heart:
Hm. This is not right. Filemodes can be corrupted altogether. Needs to look like this:

```c
if (git__strtol32(&attr, buffer, &buffer, 8) < 0 || !buffer)
    return tree_error("Failed to parse tree. Can't parse filemode", NULL);

attr = normalize_filemode(attr); /* always normalize the filemode */
```
Nit: it's better to compare in the opposite order so that the expected result is the second argument. Pretty sure that's the convention we're using.

e.g.:

    eq_(1, len(general_prods))  # ick

vs.

    eq_(len(general_prods), 1)  # awesomesauce
Could still optimize away this extra update query in the majority of cases where it's not needed by checking the old vs new idprefix values.
`isinstance(form[name],  basestring)`
It's probably not necessary to flag IP addresses if they don't have a protocol attached.
removing this line would be okay
Agreed.  This would be a nice, self-contained section of Erchef to experiment with them, though!
Could I suggest an $options parameter ?

```
$manager->getConnection($callback, $host, $port, array(
    'https' => true,
));
```

This way the code is self explanatory
It's a relatively tiny flaw.. but this is not compatible with all JSON parsers.
You have 2 blank lines here.
This would make it return adriver instance, not an integer or a boolean
this is wrong here too
ltrim would remove multiple occurences of `/`. But only the first should be left out.
Thanks. Pushed.
and before and after `-`.
null === $httpPort according to CS
Move `strlen($ret)` out of loop.
FormView instead of FormView ? What a big change :)
Can we the `type-of` syntax here?
I'd use `@{Users.about(member.id)}` to generate the URL. If we want to update `conf/routes`, we shouldn't have to change any templates. This arises a few times in this pull request.
I think that we should just use plain string, as long as the correct type safety is kept on the application (Scala) side. 
I'm not for going with JSON, that seems really overkill for the general use case (or well, we just need a "RudderPropertoes.json" serialized in the DB - but in that case, a SQL DB is really not what we want)
Yeah, I wondered about that too.
It can be None in the WMS request so I left that option open.
However, I couldn't predict if that would actually ever be useful...
link breaks don't work for wiki links. Should be `[[Querying Access Statistics]]`
@kselden  hmm, as discussed in #668 I think it's inconsistent if you create an application with a `rootElement`, create a view and call `append` and then the view is appended to the `body` instead of this `rootElement`. Also, the view does nor receive any events because it's not beneath the `rootElement`. Of course one could call `appendTo` but what's the point of having an `append` then?
heee, what about `rm -rf *_dev.php`?
`current_user.favorites.create(apartment_id: params[:apartment][:id])`
Remove this comment, or write a test for it.
this puts seach into the App model, as it was originaly on the ER diagram. it is still not being used in the app load but it should be in the future, ideally the user's dashboard (including serach) should pick up where they left off.
Locale sensitive?