labofsahil/github-event-dataset-2012 huggingface dataset:
Hi Jaikiran, hi Brian,
thanks for the feedback. I've to admit: I simply tried o get my changes working analogous to what I found in the current implementation.
From experience, it is a bad idea to do something without having fully comprehended what is going on :)

I peeked around into different services/subsystems and found that the access to either model or operation is basically mixed up (so not only cmp subsystem was doing it incorrectly). Also from the java doc and by debugging I found that before AddStepHandler.performRuntime() is called always populateModel(operation, model) is called. Conceptually this means that I will find a certain attribute in both (model and operation).

But I will follow Brians guideline and change it accordingly.
This should probably just be hard coded, as it won't work for any other state anyway
No, I just add some debug codes in this file and forget to revert it before committing.
I will revert it if you like
"Explicit is better than implicit."
其实我觉得定两个价格就好哦，根据汇率算不得必要，不过如果不麻烦也可以。只是觉得可以方便调整  

--  
zhoudi
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)


在 2012年12月16日星期日，上午10:29，longhengyu 写道：

> In data/dev/init-product.xml:
> > @@ -11,6 +11,7 @@ > description="Server Located in California, High Speed, No Access Limit for 1 month. (DO NOT support p2p)" > image_url="http://ww1.sinaimg.cn/mw690/ba2b4929gw1dz8xb9q489j.jpg" > price="26" > + dollar_price = "5"  
> dollar price 我准备实时取汇率来得到。这个模块忘记做哦，但是可以实时得到。
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/longhengyu/dream/pull/12/files#r2429352).  
>  
>  
>
примерно так https://github.com/hizel/lorsource/blob/spring-security/src/main/java/ru/org/linux/site/tags/Captcha.java#L43
As we discussed this morning, this is a Hack to show the settings app in the foreground ...
ouch! sorry I missed that on revision :(
Function name is ok here since `build` is a verb.
Ouhh ok! I just told you that because in https://github.com/mozilla-b2g/gaia/pull/5227 @fabi1cazenave told me that it will not work.

But if works! Go ahead!

Thank you!
Yes. We use it in:
- ext/libphonenumber/phonemetadata.pb.js
- ext/libphonenumber/asyoutypeformatter.js
I've audited the use of innerHTML in here since that can be a red flag.  It seems fine, although it does provide the localizers the ability to insert HTML with their string, which is not entirely something I think we really want, but should be okay.  (We can change the title.innerHTML to title.textContent to avoid that.)
Why do we need to listen to a event that we are not going to anything about it?
Calling showGroupHeaders to hide the headers sounds weird to me. May be this method could be called something like "toggleHeaders" more than "showHeaders"?
not really important, but what exactly rd_asd stands for? not very friendly naming :)
good catch, me and my dislexia problems ;)
Yes, it's my fault, I didn't realize. I'll fix all problems and made a new pull request.
Specific dialog should fall into the dialog-overlay group.
App-install-dialog seems to be system-wide, and looks to me its a fork from permission dialog(permission-screen), so the same as permission screen or higher than it is acceptable I think. Be careful to check the same group in `z-index: 1024` ones if you grant the app install dialog should be upon or below value selector/update dialog/inline activity frame. (I have no idea now).
What about moving the `$keyType` parameter to the end, so that it doesn't break BC.
Another random question: What's the color of a duck?

Looking forward to a truly random answer :)
Weiß nicht was das ist, habe da nichts gelöscht.
No, we are currently on 1.6.3.
That error is in the app manager log.
trans block instead?
ммм или раскомменть или удали
Added the name of the item you're deleting to the text in the popup box.
I don't think so, in 'handleTouchesBegin', we just add all touches to CCSet, at the end of 'handleTouchesBegin', we only invoke 'm_pDelegate->touchesBegan(&set, NULL);' once.
True. The tests still pass after the try is removed.
if <HOST> supposed to be last on the line, anchor it with " *$"
Is this wise? it's not a link or an internal anchor to anything.
`title` is not required with `BaseScopedNameMixin`. It's already there.
We expect this variable to be _definitely assigned_ (i.e. it could be `final`) so do not assign it to `null`.
So loader.js is loaded twice: Cu.import(loaderURI) and require('api-utils/loader')?
Can we avoid that? (and so avoid facing this platform bug and avoid loading a file twice)
we should add a test that this type of listener is removed on unload as part of the `testPrefUnloadListener` test.  Also this listener needs to be removed in this test before it is done.
for apps like Fennec or Thunderbird I don't think private browsing is implemented (and perhaps `nsIPrivateBrowsingService` is not implemented?), which is why I think `model` was used..  I'd have to do some research to figure it out, and it's probably easiest to keep it around for now.  Also I think the plan is to remove `nsIPrivateBrowsingService` so, we'll need a variable to remember the global PB state in the future anyhow.
I was also in doubts seeing it ..
I will see what's more sane
can you add spaces before and after `=>`?
my eyes just started bleeding :P
it should return a string. Returning an integer will likely break as typeahead is calling string methods on it (``toLowerCase``, ``indexOf``, ...)
This looks suspicious. Does it mean that bridges are broken in plain YaST?
@Maks3w can you give me an example?
Sorry for repeating myself ;) Could you please leave the old tests in there as well? That way we ensure there are no BC issues (or at least become aware were there any).
Cyan fails at `setattr`, obviously... this whole class looks just awful.
>i think its used to avoid that changesets from the server are being applyed while the editor is in "internalCompositionState"
That's correct.

@fourplusone  Thank you!
Yeah probably should have been postfix, but I couldn't use an ascending loop for the situations where it was removing tasks so I made them all descending. It's a `while` now.
Can't do much with the mojits/TodoMojit/assets/ folder. The mojito runtime will pickup from the assets folder (either app-global at `src/assets` or Mojit-specific at `src/mojits/TodoMojit/assets`).

However can do with the final output (references in index.html).

There's however one alternative possible - keep assets empty but add a readme for development.
Sorry about that - still new to the Pebbles concept.

Will revert that change later - do the other changes look OK?

--
Matt Rohrer

On 15/11/2012, at 17.35, Katrina Owen <notifications@github.com> wrote:

In README.md:

> @@ -55,26 +55,37 @@ To check the identity for a specific session, this call to checkpoint could be u
>
>      /api/checkpoint/v1/identity/me?session=10e9pde6ww4kr5nv7y9k54kei1dj1lfe9s [...]
>
> -Pebbles expect to find the session string in one of two places. First it looks for a url-parameter named 'session', if it is not found there it will attempt to retrieve it from a cookie named 'checkpoint.session'. If neither of these are present the request will be processed without authentication.

Actually, all Pebbles expect the session string to be present, and will use
that session string to ask Checkpoint about things.

—
Reply to this email directly or view it on
GitHub<https://github.com/bengler/checkpoint/pull/31/files#r2140859>.
I would use ``|=`` which is more logical to build a binary flag
I prefer to mimick the ORM interface - otherwise we are mixing layers. I guess that I am implementing ``PHPCR QueryInterface`` here because it is convenient, and doesn't break BC. But really it should probably implement hypothetical Doctrine Common interface or at least copy it. A noteable difference is PHPCRs ``bindValue`` and ORMs ``setParameter``.

Saying that, implementing ``getResult`` here would make the change 100% BC. So it would be a safe step and we won't have to worry about potentially breaking BC twice.
Nitpick: Always leave vertical whitespace between function declarations. It's pretty /  readable : )
Hi Ken,

On Wed, Sep 26, 2012 at 10:56 AM, Kenneth Hoste
<notifications@github.com> wrote:
> > +sourceURLs = ['ftp://selab.janelia.org/pub/software/%s' % name]
>
> use http download URLs, if possible

I also prefer that but, these guys seem to only provide the software
at an ftp endpoint.

Please review this .eb fully, since I (claim to have) fixed also all
the other comments.

Fotis
Fix these.
It is quite convenient to be able to run this with just a single command. (as in python -m easybuild.test.build). Unless there is some better way?
Why are you overriding this method? I think you don't need to?
Yes, I think you could do this via the CLI fine.

On 7 May 2012, at 15:57, Joel Tosi wrote:

>> +
>> +What is it?
>> +-----------
>> +
>> +This example demonstrates how to setup and log different levels of information in *JBoss AS 7*. An example of asynchronous logging is also included in the configuration.
>> +
>> +The example contains just one class file and one jsp file that, once accessed, fires off the logging information.
>> +Also included in the example are an updated standalone.xml and logging.properties files.  
>> +
>> +Follow these steps to better visualize the logging working:
>> +
>> +1) First deploy the jsp file and access it at <http://localhost:8080/jboss-as-logging>
>> +
>> +2) Look at your log files, located at *JBOSS_HOME*/standalone/log.  What information do you see there?  What came from the application?
>> +
>> +3) Copy the provided standalone.xml and logging.properties files.  Both of these files will go in your *JBOSS_HOME*/standalone/configuration directory.  Be sure to make a backup of your original files beforehand.
> 
> Yeah, modifying standalone.xml is going to be a bad route, and not even the recommended approach.  Do you know if the CLI would allow me to make those changes - modifying log settings?  If so, I could write a script to do it, but then we are expecting the user to be able to execute the CLI script.  Is that any better?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/114/files#r781451
Also nit: `Groups.get_curated()` probably describes it well enough; `get_curated_groups` seems like overkill.
Please add all the databases we currently have on iriscouch. We will have some changes soon.
We might be able to rev the PHP version once we hit 3.0. This way 2.0 will be functional enough and can be branched for security fixes by the community but all active development would happen on the 3.0 branch that's refactored for PHP 5.3. Might be sufficient.
This could be DRYed up in a similar manner to the chart_col_title in the controller, since the dd always has the same value, and only the value of the dt changes.

So, something like

<code>&lt;dt><%= (stat.to_s.titleize == "Comments") ? ts("Comment Threads") : stat.to_s.titleize %>&lt;/dt></code>
I'll implement partial '_kata_homepage_box' and compress some 'if' and 'each' statements to improve readability
no i just mean `if (` add a space :D haha
I used Gem::Version for a similar test recently: https://github.com/theforeman/foreman/blob/develop/lib/foreman/default_settings/loader.rb#L54.  The split on `-` was necessary for RC versions.  Having a version comparison library might be useful though to tidy this up.
as an aside - I've always wondered: Is that preferred because of speed or
for some other reason?

On Wed, Sep 12, 2012 at 9:00 AM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In APS-Physics.js:
>
> > +function doWeb(doc, url) {
> > +	
> > +	Zotero.debug(doc.title);
> > +	
> > +	// Search for abstract
> > +	var bylineXPathNode=doc.evaluate('//article/header/p[contains(@class, "byline")]', doc, null, XPathResult.ANY_TYPE, null).iterateNext();
> > +	if (bylineXPathNode) {
> > +		var abs = Zotero.Utilities.trimInternal(bylineXPathNode.textContent);
> > +	}
> > +	
> > +	//Only Viewpoints have PDFs
> > +	var titleXPathNode=doc.evaluate('//article/header/h1[contains(@class, "title")]', doc, null, XPathResult.ANY_TYPE, null).iterateNext();
> > +	var hasPDF = false;
> > +	if (titleXPathNode) {
> > +		var title = titleXPathNode.textContent;
> > +		if (title.search(/^Viewpoint:/)>-1) {
>
> For simple string searches like this, you can avoid using regular
> expressions and do title.indexOf('Viewpoint:') != -1
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/456/files#r1587851>.
>
>



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
daa?
From our config:

    def icecast_attributes():
            return {'host': icecast_proxy_host,
                'port': icecast_proxy_port, 'password': icecast_proxy_pass, 'format': icecast_format,
                'protocol': icecast_protocol, 'name': meta_name,
                'url': meta_url, 'genre': meta_genre,
                'description': meta_desc,
                'audio_info': {'bitrate': icecast_bitrate,
                'channels': icecast_channels, 'samplerate': icecast_samplerate}, 'mount': icecast_mount}
* I think the photometry routines should accept only `Image` objects (`Image` would be a subclass of `NDData`). `Image` objects would have a `gain` property, which would default to 1. 

* If an `Image` object is passed, it would still be useful to allow the user to specify these additional parameters. They would override the properties of the `Image` object if specified.

Note that in the current implementation, `gain` can be a scalar OR an array (matching dimensions of the data).
You don't need to catch, print and fail these exception. Simply declare them as part of the method signature and JUnit will fail the test for you if the exceptions should be thrown.
Agreed.  I was considering something like that, but I'm glad to hear an official word on it.
This handler uses a function expression (self-calling closure) to create the event handler. It generates and returns the function that is used as the actual event handler function.

This closure stores the `image` and the `options` so they can be used as needed. It also stores a variable for tracking whether the `src` attribute has been set once, a variable to keep track of the current timeout and the last known breakpoint label that was used by the image to set its `src` attribute. Finally, it stores a function named `set()` that performs the actual work of processing the breakpoint name to set the image's `src` based on the image's `data-*` attributes.
I think this is a bug or a issue on https://addons-dev.allizom.org/en-US/firefox/discovery/pane/4.0/Darwin

@krupa  can you confirm if this change is intended?
We're only using this once, so I would just reference `feedback_pg.messages` directly.
If we are going to be using an underscore iterator, might as well iterate it like a dictionary and get both key and value.
IMHO it doesn't belong there, because the Notification class itself doesn't use QList<Notification> for anything and thus it isn't necessary in order to use notification.h.
I was using it several places in my event / event group submission, to validate that the data we received was reasonable.  I could see it also being used for catalog submission, or pretty much anywhere where we are receiving complex objects from the wire.

That said, I'd be happy to hear suggestions on how to make it more generic, or move it somewhere "less" generic, or just ditch it for now.  I do think there is some utility for a generalized map validator function but I don't care much for now.

Here's where I was using it:

https://github.com/cprice-puppet/puppetdb/commit/e567c9efb5d3398fcf558d8b2d2e78200b59aeef#L7R14
I tested it, it matches `.js.erb.foo.bar.whatever` but doesn't match `.jss`

And yes, I think it's important enough.
I don't think this is an array actually, I believe it's an object where the keys represent the section ids. That might not be true though.
I agree, in theory we shouldn't need to call super, but in practice you'll have to make sure that is the case, i.e., is there any side-effect triggered in the parent classes? (side-effect that we may rely on?)
On Tue, Aug 7, 2012 at 6:38 PM, Mirco Dotta <notifications@github.com>wrote:

> In
> org.scala-ide.sdt.core.tests/src/scala/tools/eclipse/classpath/ClasspathTests.scala:
>
> >
> >      // on 2.8 an invalid setting is reported twice, so the total number of errors is 3 or 4
> > -    assertTrue("unexpected number of scala problems in project: " + errors, errors.length >= 3)
> > +    assertTrue("unexpected number of scala problems in project: " + errors, errors.length >= 1)
>
> Any reason why this is >=1 and not ==1?
>
Does it relate to my work? Can this be fixed later if needed?

> (And, if this should be changed, the comment about Scala 2.8 can be
> dropped as it is no longer supported).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scala-ide/scala-ide/pull/157/files#r1321884>.
>
>
I'm not sure; the other place I could think of is mark occurrences, but there if something is renamed, the complete `A => B` is highlighted. Also, the `ImportSelectorTree` type is from the refactoring library, so it shouldn't appear in too many places anyway.
The class loader is not needed anymore :)
Are you guys intending to change the license from the current MIT to this custom license? This actually might be a problem with getting Diamond into Debian/Fedora/RHEL/etc.
Whats happening here? Accident?
Не будет работать при DNA count отличном от 100.
И вы не могли бы в двух словах объяснить алгоритм? Просто у меня не получилось восстановить алгоритм по коду.
Нигде не используется, написан в процессе тестирования.
Вообще, метод мутирования ничего не должен выводить. Он только меняет последовательность.
Категории лучше объявлять делать в отдельном файле - Cell+Mutator.h
отступы не нада тут, private на том же уровне что и def
I saw Rx used to use a trick there to avoid stack overflow. What they did is have a scheduler for these things that executes the action directly if it's scheduled without recursion, and queues it if's recursing. This avoided both the stack overflow and the problems with correctly identifying the "current scheduler" since it simply saved the pending actions in the current thread and executed them serially. In fact one of the caveats was that calling a delay on this particular scheduler would sleep the thread.

Reference: http://channel9.msdn.com/blogs/j.van.gogh/controlling-concurrency-in-rx

I use past tense because as far as I can tell, that scheduler doesn't exist anymore, or is private, now there's simply a `CurrentThreadScheduler`.
I think we're misusing  `#human_attribute_name` and the `activerecord.attributes.*` section of the locale file, which is supposed to be used just for *actual* model attributes, not arbitrary stuff associated with the model.

I've added issue #95 for cleaning this up.
But still indicate that it's an optional field, and if omitted the user's created timestamp will be set to the current time. I believe there some similar text in the JS API docs. I didn't add anything to the docs earlier because the expected value (millis since the epoch) was the same as the JS API, but in retrospect I probably should have mentioned it.
这里干嘛要加语法转义?
@dengemann, I simplified this code a little bit.
it'd like to profile if there is any performance loss but otherwise I am +1
It was originally written by Daniel, but (1) with laterality as an integer, and (2) with a specimen_source integer.
I squashed in the changeset that makes laterality a varchar (in master this is a second changeset).
I removed the specimen_source column (I still need to drop this in master, till it gets implemented correctly as a fk to concept.)
它可以对JPEG、GIF和PNG等格式的图像进行变换。
Are you sure, there is no way to get the number of tests in advance ? (I don't know)
Because this will result into weird reports with progress reporter.
Welcome to the distributed eventually consistent world.
Самое оно для auto ИМХО.
Порядок инклюдов не тот — локальные для личкрафта идут после всех глобальных (правда, у тебя тут все глобальные ограничиваются кутями).
No encontré donde se recalcula esto en javascript
¿Qué tal si esto fuera un helper dentro de la misma vista? Esa vista puede ser una vista parcial llamada desde el layout como para que no se mezcle con todo lo demás.
Best I can tell, you'd get the exact same result if you removed `.concat(".") + interval.toString()` here and simply set the includePeriod property of the cacheKeyGenerator to true.  I would lean toward that approach, since the feature exists by design.
Conventions, use undersocres to separate "words"
I would do this differently for sure. Zero should mean zero. It's pretty explicit. As for "use default", I feel like we'd be better off with a sentinel value like "default" instead of blank, since blank can sometimes be difficult to actually implement.
you should use spaces everywhere for Assetic according to the coding standards
wrong indentation (which will break things as it makes the YAML invalid)
Minor suggestion, no insistence: since we have 4 instances of dpi / 72., and since it might not be completely obvious why, one could use a new variable, "dots_per_point" or "dpp" or "dppoint".  I would probably use "dpp = dpi / 72.0" to keep it short and similar to "dpi".  (And I like to include the zero after the decimal.)
Right, hanging indent with both arguments on a single line.  I don't see much alternative other than shortening the variable names "glyph_info" and "glyph_map", which is not very appealing because they are perfectly good names.
Is `2.0` more readable?
This might be kind of hard to set the minimum correctly if log base can be changed between to calls. Consider this
```python
ax.hist( x1, log=10)
ax.hist(x2, log=2)
```
The first hist call would have no idea that eventually the base of log scale will be changed to 2.

But, I do not think it would be hard for use to do another call to set_ylim though. The histogram will be painted all the way down (see line 7892) anyway.
In cases like this, however, I think using a short variable name is fine.  "def validate_sketch(sketch)" looks worse to my eye.
<3 I love that this will fail fast.

Small nit add a space

<code>len(signature_list_items) > 0</code>
in the example both results are to https
Before this all the time I think liibraries depends on and implements interfaces. Now I see, I was wrong :)
Since we don't support IE5 / IE5.5 - doesn't `cursor: pointer` suffice? [1]

[1] http://www.quirksmode.org/css/cursor.html#note
@croby Can we convert this file and the following one(s) to use the new style guidelines?
I've created a pull request against 1.2.0 at https://github.com/sakaiproject/3akai-ux/pull/1899 and combined the POST with the post for creating a new version.
Re: creating a utility method

I am moving that check into SparseUtils.isAdmin and am adding whitespace to align parens.
Can you please explain the magic number? ;)
Should be "Its main purpose is..." (instead of It's) and "It can be though of.." (dropping the "It's a can")
more performant than `NSString newLine = @"\n";`?
wont the experiment be remade on application initializiation if you destroy it?
`$` should be declared here, or better still, not declared at all:

    if (select(match, this.make(el)).length) {
Instead of relying on a timer, in theory EM.next_tick should give same behavior within test (and coverage). No?
Almost. But checking just `(= true %)` won't work if `pred` doesn't return `true` but some other truthy value. What you wan't is `identity`:
~~~clojure
(first (filter identity (map pred a-seq)))
~~~
Who uses /usr/include/petsc? Are the library files there too or is this a totally different directory structure?
Not sure I understand what you mean? What build output are your referring to?
What's the point of just adding every token to the database?
<strong> tags should be around aprobar, otherwise no point of them being there.
Dot at the end. Just write "Google authentication." as description.
This comment is really not useful. Do you think we cannot know this from `TASTYPIE_DATETIME_FORMATTING` name?

You should comment *why* we are setting this. Because RFC 22822 is better supported when parsing dates in JavaScript.
"wlan slovenija" should always be in italics.
Ehm, `)`.
So this function could really be very simple:

```
context.update({
    'header': _("Bicikelj stations"),
    'stations': stations.get_stations(self.request.node.latitude, self.request.node.longitude),
})
```
Why `success`?
(You always have to think about such assumptions. World is global today! Products/services should also be!)
We use _ naming for functions.
Why changing indentation?
That is not my code, I wrongly assumed that everything is already in order :S
And sorry for so many mistakes, I haven't slept for ages :S
Similar here, you could pass the object?

So, the problem with all this relaying on IDs is that sometimes you could set invalid IDs, or that there are duplicates. Much easier is to do the query once, or construct the object, and then pass it around. Also from performance stand point (but here we do not really have that issue).
Could this test conceivably fail? If so, what's the probability of that?
This is not a change made by the patch, but why the inconsistency in type in up vs down?  This is a good argument for the newer change method, which allows you to describe the column, and let rails take of adding or deleting the column, depending which way you are migrating.
Iterating over the entire CAS for each focus annotation is probably a bad idea. Is there any reason why this couldn't have been written something like:
```java
for (Predicate predicate : JCasUtil.selectCovered(jCas, Predicate.class, focusAnnotation) {
  return Collections.singletonList(new Feature("Predicate"));
}
for (SemanticArgument argument: JCasUtil.selectCovered(jCas, SemanticArgument.class, focusAnnotation) {
  return Collections.singletonList(new Feature(argument.getLabel()));
}
```
ebenso hier...
> What do you think ?

I think you know the answer ;-)

What do *you* think?
Это ты удачно придумала. 
handle_timeout, конечно, сейчас совсем простой — но то что попробовала такой подход это хорошо.
specify the default here
Do not expect people to know what a "promise chain" is at this stage.
Why is the implementation file empty and all the code is in the header?
This is potentially dangerous and I'd like to have either a real check before we delete anything or a check for the exact exception that is expected. Even better, if there is an exception that matches but the error code is not the expected 404, we should raise the error. 

See http://docs.python-requests.org/en/latest/user/quickstart/#errors-and-exceptions for more details on requests errors.
Probably just `Number` here too.
these lines should all be indented even with the earlier '('
It only substitutes other named directories if `cdablevars` is enabled. Which it is, though I don't know what enabled cdablevars, since `ack -ar cdablevars ~/.oh-my-zsh` shows nothing :/
rearranged/fixed
Have you thought about accumulating all the cython code in one place? Although there is the risk that it starts to look like pandas/src:

https://github.com/pydata/pandas/tree/master/pandas/src
I tried this in my two new spec classes but there are a bunch of other places where this could be changed--I'll investigate further.
I pushed my last modifications of the test. I use DygraphOps.dispatchXXX instead of updateOptions. Test passes if bugfix is applied.
the ":" should be aligned. If you found another place where they are not, please fix it :) thanks
Making it more personal =) Did this whenever I could.
that's weird, %{prefix}%=%{bin}% should already exists!
Yes, we can merge. It's only debug statement. Generally I don't prefer to leave such a statements in production code, but yes, we can fix it later. Probably @zoltax added this statement while he was testing issue, that's why I'm asking him to explain / delete this line.
Pascal Case
Thanks for making the changes for group_data
migration 21 created this field, for my own information
Use constants, itll be more self documenting that way, or just pass in the right video instance to this method
singular v plural, meh

weakly i prefer singular unless there is good reason for plural, for the (weak) reason that the extra s is usually redundant.  but often plural sounds better or avoids confusion so that dominates ... live with the variety?  no strong feelings exception v exceptions

yes, move Exceptions and RuntimeInterruptedException with deprecated old version (and could just extend the new version rather than delegate?)
Needs more meaningful element IDs.
Seeing the IDs we're generating come through I think 64 is probably overkill on my part.

I'll do the maths to work out what the length should be to be sufficiently unique yet minimize the overhead.
There's an easy_install package provider in core chef.  Wil that work instead of an execute resource?
@phiggins , this is not related to the purpose of this PR but I believe this gem is missing here, it is definitely needed to make Guard working
NBD but = ImmutableSet.<Link>copyOf(
I'm pretty sure this isn't good localization, though it's used elsewhere in this file. Is it the case that all languages separate lists of things with commas? Is it clear for a localizer that {rest} is a comma-separated list of people's names? I don't know either of these.

Also, the length == 2 and length > 2 cases are actually the same now that you've gotten rid of the comma before the "and". You can ditch the == 2 case and tweak the > 2 test to >= 2. This is true above (around line 47), too.
JTreg not JTrig.
@jessicaforbes I just noticed this hard coded path that needs resolved.  Thanks!
Oh yeah, that does look like a bug.  It should probably allocate a QList and append them to it.
Yes, coming up on the next commit :)
was not sure if i can monkey-patch using include. will try.
We should be able to assign `centroid[0] = parseFloat(centroid[0])` rather than do both lookups again.
I don't get this.   What's the point in adding the cache directory?
equals("") == isEmpty()
Надо что-то делать с handler'ами. Этот класс может называться, например, WordCounterMain. Но handler - это слишком общее название. К тому же, употребляется оно в контексте обработчика события/сигнала.
Тут ты закрываешь System.in
Sneaking in an unrelated fix in this PR.  Shhh! Don't tell anyone!
There is a bug related to the area tested and it's elements.
https://bugzilla.mozilla.org/show_bug.cgi?id=776882
PEP8 issue: filter.py:61:1: E302 expected 2 blank lines, found 1
we need an application which has the "More..." button in the description, and the bimmer app doesn't have that.
I'm not sure, if this algorithm is the right one to determine a `socketPath`, since it only focuses on absolut paths. I don't know if relative `socketPath`s exist.
A comment would be helpful here - just to explain why we need this and/or what it does.
Hmm. There is a minor difference in behaviour I needed in my socket code
It's documentation :-).
Use this: http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/events/nsIDOMKeyEvent.idl#8 instead
Also, "iniitialize" has an extra "i" in there!
you should always work iwth scipy.linalg and not numpy.linalg (sometimes it's the same but scipy.linalg is always faster or equally fast)
maybe somewhere around here you should assert that the row contains instances of `Square`
I don't think this is right.  I'm pretty sure toString returns [object Object] vs. [object Foo].  An object can't know the variable name pointing to the constructor function (Foo in this case).  Especially since constructor functions can be pointed to by many variables.  Which one would it use?
How come there isn't a password field here?
I'll have to come up with a better alternative here, either a different fgetln implementation or a getline implementation that doesn't use fgetln.
The test on wordOffset is now redundant
//MORE: Consider preallocating a single key (if fixed size) to avoid the unblock?
(actually it's the one below that should have been. Github displaying some weird things here)
Remember that linked row parameters were not supported before... I don't really remember the details of why the alias helped though.
In fact, those subfiles are input (selected by a user) for 'add' or 'remove'. They are selected by a user.
Are all of these nested substrings doing copies? Seems like you could use the start parameter of indexOf to minimize that.

indexOf(substr, [start])
slice(start,end)

and perhaps calculate the same value only once (i.e. newParamsSubString.indexOf("@name")+7).
please get rid of the leading ``_``. This is a convention which was set in the PHP 4 time when visibility were not available in PHP and it does not make much sense to keep using it in PHP 5. Most projects are moving away from it (for instance, Doctrine 2 still has it in a many places because of code inherited from Doctrine1 without renaming before the 2.0 release, but private methods and properties are renamed regularly when a refactoring is done in such class as it is possible without BC break)
In fact, you don't need to un-comment it because as soon as you `cp local.py-dist local.py` it's now set there correctly.
ugh, I have no idea where this is coming from constantly
Exactly. I don't see the point on these tests actually.
Will create a PR for this.
Unfortunately it's too late by then to tell the layout not to get involved. The model is fully built and nested before the renderer is even asked for (which is when the strategy finally figures out it's an application/json request). The only solution I've thought of so far that doesn't seem overly awkward is to somehow mark the root model as representing the layout (like with a flag or separate LayoutModel class that extends ViewModel). Then I can deal with it however I like in the JsonRenderer.

If that doesn't seem right, this may need a little more thought and get re-introduced in a different PR.. (since this one is primarily bugfixes at this point)
Interesting ... 
Note I've not modified the original test suite at `tests/Stdlib/IsAssocArrayTest.php` so this was never covered.

I'll take a look ....
Took me a little while to figure out what you were doing. Consider an extension method that does this:

    bool anyMatches = "foo".MatchesAny(predicates)
C'est pour que le fond ne soit complètement collé à la bordure du bas, mais qu'il déborde un tout petit peu afin qu'il se confonde avec l'ombre intérieure du bloc.
C'était surtout pour être fidèle au design du PSD.
letters are cheap on java lstBtnUploadImages can be more descriptive..
@yuhunglin What happens if the dest file already exists? Maybe need a cp -f there? 
Also, what is the trailing colon for? That's fresh to me.
If I'm reading this correctly, we basically have two flavors of OAuth2::Client instances: one for the request & another for the callback. This get_client method is basically tailored for the "request" flavor. For the "callback" flavor, you send in an empty-string "final_redirect" argument (not to be confused with the "final_redirect" that the "handle_callback" method actually uses), which then gets embedded in an unused "redirect_uri" object.

If that's right, would you mind distinguishing the two flavors more clearly in the code?
does this line need to be added manually?
This should probably be a private method. It helps identify / protect methods which are publicly available.
no, removed
psexec again...as said in other pulls requests.... I must ask if maybe it should be included on a module... I wouldn't like to have a lot of modules copying and pasting the same code
This should be caught by a unit test.
It looks like many of the plugins don't implement the `format_str` paramter. Maybe this call to `imsave` could be wrapped in a `try`/`except` which catches `TypeError` and just returns the normal `__repr__` value?
This book exists in English as well, I changed the title.
Consistent how?  I moved it so that the ```var position``` came right before the only two lines that it was being used.  So that position stuff is now grouped better and all of the this assignments are still together.
The problem with the comments file was already present before these changes, but I've just pushed a fix.  Now the file is generated during documentation instead of during build, where glsl files are skipped if the corresponding js file is up to date.
After init (which creates our custom application and user profiles on the drone), send the changed parameters to the drone.
BTW, why don't we return resumeTime here? I have no problem accepting as it, but...
It looks like you have a lot of duplicate code here.  The only thing I see that is different between your process* methods are the flags that you pass into updateContactField.  You could probably reduce the amount of duplicate code by having a generic process method, and for each method, just pass in different flags.  For example, you could have a generic processData method, and for processURL(), you can just call processData(urlHashMap, urlType, ops, uType, Website.CONTENT_ITEM_TYPE, Website.DATA, Website.TYPE).
я клиентом пробовала добавлять в игнор лист, а он не добавляется ))  подумала - мэджик, исправлю в след раз))
I thought about this too, but I decided to keep these in line with the original tutorial. The text of the tutorial has the add and the delete in different sections with explanatory text for each, so it might be helpful to have explicit blocks of code to explain what's going on in each case.
Indent 2 spaces since it's inside the div.
Also a bit longer, but way more readable.

    aws = config_data['aws']
    client.tasks.create(
      'ImageProcessor',
      image_url: aws['image_url'],
      aws_access: aws['access_key'],
      aws_secret: aws['secret_key'],
      aws_s3_bucket_name: aws['s3_bucket_name'],
    )
I believe the stack name is set by stackster in

https://github.com/live-community/stackster/blob/master/lib/stackster/entry.rb

    def set_default_attributes
      attributes.merge!('Name' => name)
      attributes.merge!('CreatedAt' => Time.now.utc)
    end

But check me on that.
This usage only works under bash...unfortunately the shebang line at the top of this script maps to different shells under different systems.  Under RHEL (and it's associated Linux distros) `/bin/sh` maps to `/bin/bash`, but under more recent Ubuntu distros (at least since 12.04) this maps into `/bin/dash`, which is an `ash` derivative, not a `bash` derivative.  As such, an error is thrown by any line that uses syntax similar to this (this syntax is also used in pull request #28).
Instead of passing in an empty string, you can just pass in `nil` and then check for that with `if start_date`.
maybe Button, Tab and Adapter all are different concepts after all?

Maybe this architecture is fine:

* Widget (the whole thingy, and a state machine: *blank*, *dialog opened*, *in progress*, *done*, *error*)
* Uploader ( a function (in the broad sense) from some notion of a file, like URL or File Object (a notion is unique for each uploader, meaning we have URLUploader and FileObjectUploader, etc) to `file_id` )
* some Chief Uploading Officer which received something like a file, whatever it is, and decides which Uploader to choose
* Button ( a widget ("reusable element of a graphical user interface"), with a callback `onClick` )
* Tab ( a widget, which can be *created*, *shown* (all tabs are shown when dialog is opened), *selected*, *unselected*, *hidden*, *desroyed*, a callback `fileChosen`, which receives some "notion of a file". When the dialog is opened, this callback is set to state transition function of a Widget)

something like that
мне неудобно отсутствие пустого места внизу экрана(
typo: s/idden/hidden/
кто удаляет эти указатели?
the listmus for this is 22919.
please don't modify build files
I meant that if you don't have RoR's length, you should be able to get it while reducing RoR. This requires a more involved algorithm, but it is doable.
A trailing backslash indicates line continuation. A trailing space after the backslash indicates that the line should end with the backslash.
http://d.puremagic.com/issues/show_bug.cgi?id=8851

Take it if you want it.
I fear that people will think this is akin to the never-returning `exec`. How about `run`?
I'm not sure about the prefix "generic", it's a rather ... generic prefix. And it isn't a Dart<Generic> class. Okay I'll stop with the puns now ;)
I think "Java EE 6" or above is clearer
it's just the documentation :-)
extend with what exaclty?
This function should at least retun the result of the query even if we aren't using it. This allows for easier failover testing.
The trailing comma on the last variable is problematic for earlier versions of puppet.
"Commands to manage your ServiceBus configuration" is overloaded, but I can't think of anything better.

"Service Bus" should be consistently two words and capitalized.
!!this was just a typo at the end -  actually what i have is when brackets
Use

```
sources = ['bfast-%s.tar.gz' % version]
```
With the way the website is currently used, this will always be a lottery preference, yes. It doesn't have to be though. It can be any StudentRegistration with a relationship other than Enrolled.

You can give yourself a Priority/1 StudentRegistration, and make sure that Priority/1 registrations are visible (using <manage/<prog.baseUrl>/registrationtype_management/> ). Then try removing it via studentreg.
Testen, ob die Route die Firm mit der ID __FIRMID__ erkannt und aus der DB geladen hat.
Because I'm idiot)
Wait, I thought we were doing the Boolean guard thing. Stats are always built in, but they still are controlled via a dynamic flag. No?
typo: reuqest
Let's leave it till the end. Its definitely much easier to review when its all in one place.
My biggest concern with introducing inheritance now is that once we do and its a public class then we have to live with that forever. With this code we can always introduce these subclasses later as we understand the usage of this component better
It seems like these 2 if blocks should be combined in some way. As it is it still relies on the delete not completing if the Session was returned to the cache, but we are not positive that behavior is the same for all JMS providers. Instead, now that you have the local "view" of the Session cache, why not simply check if it's still in there, and only delete the destination if the Session is no longer in that cache?
Why would we take bluecloth in use when there's already redcarpet (https://github.com/tanoku/redcarpet).
I think the comment is fine. Remember this will still default to the current behaviour and I expect users who override this can it figure out with a comment.
I'm not sure if use absolute URIs is a good idea
```
git diff master second 
diff --git a/test.log b/test.log
index 3af4268..faedcfc 100644
--- a/test.log
+++ b/test.log
@@ -1 +1,2 @@
-Вт. апр. 17 00:19:31 YEKT 2012
+Пн. апр. 16 16:53:24 YEKT 2012
+Пн. апр. 16 22:54:38 YEKT 2012
```
変数名が曖昧な気がします。
ok  ;)
Implement `IEnumerable<T>` not `IEnumerable`.
Fixed cs.

Will check again, but fairly sure there's no helper for this.
I realized that. I'm fixing it. Thanks for pointing this out.
I'd prefer "corresponds" rather than "correlate" here.
I suppose this is not needed for the SSL support ?
everything under form->isValid
GitHub rocks!
So does Erlang!
Er. Actually, nevermind. I'm full of crap on the string thing. -.-
after making the above change, this method will have only one line of code, so that one line can be moved to the public function itself
whitespace for most of this try block >>
this is not needed as ``custom`` is not allowed
We should probably describe the format of the newLanguage parameter, similar to the properties above.
Sorry. That is correct.
I haven't been able to find any google bug on this. 

What I found during my research: This code triggers a layout pass on the window layout, and is done before its children have gone through a layout pass.  As a result, it doesn't trigger any additional layout passes.
согласен. Над как то по-красивше. Ну просто ооочень хотелось посмотреть чо как получилось :(
Accessing Task.Result property waits for completion.
Remove blank spaces, please.
Also, this is described below. See "nominal".