gh-1646 - Roxie groups only updated on new env.

Thor cluster groups are only updated if the environment is detected to be
different from both the old environment and the live group.
This was disabled for roxie cluster/groups, i.e. the loaded environment
always too precedence.

This change treates roxie cluster group updates in the same way as thor
cluster group updates.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #1863 from jakesmith/gh-1646b

gh-1646 - Roxie groups only updated on new env.

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
gh-1822 - Fix xref attach/remove files

Some legacy code was inserting a spurious head path onto part mask, causing
reattached files to be invalid.
Was also effecting the deletion of orphaned files.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
gh-1865 Roxie can core when query deployed

A race condition between the control:reload query sent by ecl publish,
and the automatic reload triggered by the dali subscription, can cause
Roxie to core if the notify call is in progress when the QuerySet manager
is destroyed by the control:reload

Add a critical section so that a we never unsubscribe when a notify is
in flight.

Also deleted an unused member variable. Fixes gh-1865

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #1866 from jakesmith/gh-1822

gh-1822 - Fix xref attach/remove files

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Grouped HashAggregate deserialization error

Exposed by change in gh-1476.
That stopped the unecessary seralization from master to slave for local or
grouped hash aggregragtes, but the slave was still trying to deserialize if
grouped.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Multislave setups were ignoring nodeGroup

The nodeGroup setting was being ignored in multi-slave and local setups.
Instead, it forced the nodeGroup to equal the thor name group.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #1867 from richardkchapman/roxie-reload-core

Roxie reload core

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #1850 from richardkchapman/branching-strategy

Update VERSIONS to remove references to split-X.Y branch

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #1868 from jakesmith/group-hashagg

Grouped HashAggregate deserialization error

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #1864 from hpcc-systems/candidate-3.6.x

Merge latest 3.6.x fixes back into master

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Fix gh-1860 typo in eclcc help text

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Remove casts that have no effect

These are very occasionally generated when no_select are expanded.  If
they remain they can generate unnecessary temporaries.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Fix ecl command line should default to not limiting results

Defaulting to 100 can cause issues with queries published to roxie,
and roxie regression testing... and I prefer to handle the --limit
command line option consistently in all cases.

Signed-off-by: Anthony Fishbeck <Anthony.Fishbeck@lexisnexis.com>
Roxie core in self-join with prefix match optimization

The prefixjoin.ecl test case in regression suite cores if executed
with a choosen on the output datasets, as prefixed selfjoin was
not correctly handling the case where not all data was pulled.

Code was casting a pointer to a more derived type incorrectly, then
attempting to avoid the resulting issues by copying a valid pointer
back in before any virtual calls that migth crash were made. Yuk!

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #1873 from afishbeck/default_unlimited

Ecl command line should default to not limiting results

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #1872 from ghalliday/eclcctypo

Fix gh-1860 typo in eclcc help text

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #1869 from jakesmith/multislave-group

Multislave setups were ignoring nodeGroup

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #1875 from richardkchapman/prefixjoin-core

Roxie core in self-join with prefix match optimization

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Fix very obscure bug in folding case() = value

case(x,a1=>'a',a1=>'b','a')='a' was incorrectly converted to
x not in a1 because it wasn't taking into account previous (duplicate)
values that had matched - they differed only by an annotation.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>