labofsahil/github-event-dataset-2012 huggingface dataset:
Kimmo Varis wrote:
>> I think the best argument against Java/C# support in Cppcheck is that it can hurt C++ support.
>>      
> That myth is already debunked several times in this very thread. Just see again where this thread started!
>    
The whole reason this thread started is because C# support was being 
added to C++ parsing code.  That means the C++ parser was doing 
unnecessary work for most users.  I want to stop this practice now 
before it becomes common place and impossible to remove.

C# code processing should be handled in a separate function and only 
when processing C# files.  It is totally unacceptable for C++ parsers to 
have to deal with C# code.  It's a waste of CPU and developer resources 
for something that is probably not even used.

If we must process C# and java code, it should have no impact whatsoever 
on processing C and C++ code because the majority of users of cppcheck 
will be checking C and C++ code exclusively.
wofür braucht man das? ein div wird doch wohl nie gleichzeitig h1 sein??!! oder meintest du alle h1 in den divs (#mini-map div h1) ??
lol i meant if some one was really anal  like the act of being one  8)
And I agree with you, I'm just pointing out that when using Silverlight, this can become a real issue (versioning issues due to strong naming)
Requestで十分っちゃ十分かもですねぇ、login_conditionとかlogin_invalidでmapsとかsessionとか使わない気がしてきた
I guess this means i have to rebase [this](https://github.com/SpoutDev/Vanilla/pull/34) again...
a cake (remora) test failed but it didn't seem relevant
mmap_mode is not used!
Done :). I've just added you as collaborator, feel free to push any
changes you feel appropriate.
Ah! That I didn't know. Learning of the day! :)
Yeah it's a tough one. I totally agree the workflow you outlined above is pretty awful - I'll try to think through a more graceful way of doing this.

I also agree that customization through variables is definitely the way to go *when possible*, but I don't think that generating a bunch of unused code serves the majority of bootstrap users and I want to avoid that if possible.

It's not just about comprehension. I'm going to talk to @cloudhead and get his oppinion - it's definitely a hard problem.
问题是从poster->post();开始这个类就没用了，而后面是一个事件循环........
其实我觉得这种命令行程序应该直接阻塞来调用，不应该用事件循环
It is used by the FAIL() macro.

Also it is really there to provide a way to return an error.  If there was no possible errors, then it would still be normal since it is part of the interface.
You had me confused there, wondering why govspeak depended on rack. Glad to see it's rake!
classic problem, a fast moving bullet, moving 10 px each iteration, goes through a wall that's only 5 px thick. Your physics needs to move it 1 px at the time, and test for collisions each time.
you should take advantage of changes in 0.9 and use the cached jQuery wrapped el - `this.$el.find(selector)` this way you create one more jQuery object by wrapping this.el another time as well as you basically call the jQuery constructor method again
do we have to initialize the persona previews?
Not that I've found, but I'll double check. %* are the arg vectors and
not the command the batch script was invoked as.
I just noticed the old way hard-coded the path to the puppet or facter ruby file as the first argument. Would `%0` be correct if you executed the batch file using its extension, e.g. `puppet.bat`. Seem like the script would try to pass `puppet.bat` as `%0` instead of `puppet`
Issue #979
Please add variable to Makefile TESTARENA=/dev/shm or something like this.
Okay, agreed, now we have a clean lively.ide and lively.ide.ErrorStackViewer as separate module, see 8a7aeba.
By clean this codestyle you mean?
Do you think that if the spells worked and had spellscripts I would waste my time to fix them in a different way? :P
Ok! Got you. I'll correct this ASAP. Thanks for advice!
“3Q” in Chinese means "Thank you”.
Thanks Joe.  @MikeJolley was able to get me an answer over here:

http://wordpress.stackexchange.com/questions/44420/unhook-jquery-from-woocommerce-via-functions-php/44421#44421

Also, FYI thanks for your email, will respond a bit later...
I've check most of them before. Here is the output:

stats.isStatisticsEnabled() : 
true
stats.toString():
Statistics[start time=1325587059722,sessions opened=2,sessions closed=1,transactions=0,successful transactions=0,optimistic lock failures=0,flushes=2,connections obtained=3,statements prepared=3,statements closed=0,second level cache puts=3,second level cache hits=0,second level cache misses=0,entities loaded=1,entities updated=0,entities inserted=2,entities deleted=0,entities fetched=0,collections loaded=0,collections updated=0,collections removed=0,collections recreated=0,collections fetched=0,queries executed to database=1,query cache puts=1,query cache hits=0,query cache misses=1,update timestamps cache puts=2,update timestamps cache hits=0,update timestamps cache misses=0,max query time=5]

stats.getEntityNames()
org.jboss.as.test.integration.jpa.secondlevelcache.Employee

stats.getSecondLevelCacheRegionNames() 
jpa_SecondLevelCacheTestCase.jar#mypc.org.hibernate.cache.internal.StandardQueryCache
jpa_SecondLevelCacheTestCase.jar#mypc.org.hibernate.cache.spi.UpdateTimestampsCache
jpa_SecondLevelCacheTestCase.jar#mypc.org.jboss.as.test.integration.jpa.secondlevelcache.Employee

emp2LCStats.toString();
SecondLevelCacheStatistics[hitCount=0,missCount=0,putCount=3,elementCountInMemory=3,elementCountOnDisk=-1,sizeInMemory=-1]
idea: run js[hl]int in the packing script to catch such things.
The change to AttackTesla has been merged upstream. Refer bug #1348
Recommend not using php casing function because this will break UTF8 encoded languages (such as Greek and Chinese)
А если конструктор копирования, для хранения в коллекции? Как-то думать надо...
bundle-version should be "1.4.0" instead of "1.4.201".
Resolves Issue #1 #2
I just finished implementing the features on my to-do list https://github.com/dernalia/deep_cloning

though, I don't know what will happen when the saving / !-ing is removed. =\

gl
let's use new ENCODE_{START,FINISH} for these, and include dump() and generate_test_instances
see #18
Hmm.  I looked at this and rebasing the new method is trivial, but in the meantime you seem to have switched entirely to RSpec. I'm not familiar enough with RSpec to port my test case.
cant see thomas pushes in eclipse
[79e7673c](https://github.com/nanotech/-wzXcodeScripts/commit/79e7673c8b24e8e03883f61fe5729c2e949034a0) should have identical changes.
Yes I know. I have it fixed locally.
What happens if $Copay is greater than 0? Do not assume that reverse payments are impossible.
The tests were already broken in Firefox before. The tests pass in Chrome.
period at the end of this sentence, plz :D
@hramos, 

Since `Date` is in Ruby's standard library, there should be no need to include it in the Gemfile.
I didn't think about such solution, thx for pointing this out.

P.S. setting point prolly needs check of diff between vehZ and foundZ, because currently ejecting somebody out of the platform causes instant teleport to the far far feet of the frozen throne ;P temporarily I disabled searching for eject point to see if this will help in cases where players leaving vehicles where moved "under textures" and simply died in instances (happens for Marrowgar encounter very often).
yes, weird..

But I think not important enough to change, do you agree?
try to remove that intval and then write something via GET like: "...54.." you'll see that it goes in error. This is just an ugly solution but I'll fix it...
Sweet, looks like this one fixed my issue.  I'll test it out a bit and close my issue if it works.
As far as I read https://github.com/puppetlabs/puppet/blob/2.7.6/lib/puppet/property/ensure.rb#L8, which gets applied when no block is given, the default should be still `:present`
Лоя примера просто как отлавливать из физ движка удаление обхектов
so should I disable them now?
For the record, this is only partial cleanup. More to come.

Gosh my code sucked.... xD
Use the Infinispan formatting rules: no tabs, 3 spaces
nada si esto es de otro spell, esto como si no estuviera jajaja
Does it work without it? creatures should not block the LoS by default...
I agree, I did consider changing it to LFloopagain.  The reason it has a new prefix is that there is already functionality for loopagain but it doesn't work in thor.
I'll change it if you prefer.
I guess you are eliminating the 'no longer part of this array' rows when you copy...
What happens if the 'no longer part of this array section is enough to provide the resize all by itself? Shouldn't you in fact make it a circular buffer in order to be able to make use of them?
and CompleteEmote was also changed :P
Seems I should add a README as well. The thing is (as described in issue #279) that there is a bug in the Android canvas implementation if the dimensions are changed and the added line is a workaround to empty an internal cache there.
As noted I just patched the stock mapsforge 0.2.4 sources and added the resulting binary in place of the one provided by mapsforge.
Hmm. I'll look at it when I get a chance. Maybe I made a typo or something. Its kind of hard for me to test, not having a mac.
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Maescool <reply@reply.github.com> wrote:

@dkowis putted in jenkins :)
one thing, the icon doesn't seem to get put in the .app..

--- 
Reply to this email directly or view it on GitHub:
https://github.com/Maescool/Catacomb-Snatch/commit/f78d3e365cb5ffff8229462c33b9d8a1030d2ac3#commitcomment-1011329

!DSPAM:2,4f493eab132704042098162!
@blafoo I'll make the changes. I was first going to use an Intent to pass off to `cgeoadvsearch` (for its `instantSearch` function), but it had different patterns than I needed. But, I think I can change the patterns in there and it will still work fine.
I would pass intent to him and then he would return result of whether or not it was searched for (option would be added to avoid keyword search off of QR scan, because that is very unlikely scenario) Thoughts on redoing it this way?
Please don't repeat the version numbers all the time. There is a reason I spent all that time defining it once in one of the parent projects.
cocos2dv1 --> cocos2dv2
Also, no idea if this syntax works for active record )
I think it's possible to SQL inject this.
I tried undervolting all of them at first, sd card stopped working, sdc1 is sdcard, sdc2 is wifi. Got the patch from arco's HTC Wildfire kernel.
This is EXTREMELY dangerous..   In fact I would say Don't add this.  Adding an active flag on tax status works for me but the delete button can kill calculation of current orders.  That would be a HUGE bug for anyone using the delete button
True. I wasn't sure if the problem was actually in the css or somewhere else... well this is one more thing that'll make the next release look extra nice :)
Blargh, so much nesting.  Reminds me of the end of scheme code.
I have mad maddening problems with daemons.  I will look into foreman + upstart.  Thanks @betamatt
Yeah, I meant development dependency and when writing this I thought that `add_dependency()` would add it as one. This needs to be changed.
Is this intentional that the linux code doesn't put it in a subdirectory called HPCCSystems is TMPDIR is set - whilst the windows code does?
I would have thought getTempFilePath() was a more appropriate name given our normal conventions. queryTempFilePath suggests you are returning a pointer to a static buffer...
If the sum of all the weights in a phase is 100, yes. If not, no.
I'm assuming that `showEditForm` and `hideEditFormShow` weren't a public API that were called by other components?
Whoops, why did it do this?
I think this should probably be 0 - e.g. see CRoxieServerDiskWriteActivityFactory.  I think it is the number of uses within the graph.  I'm not sure if it actually has any significance - I'll defer t Richard.
the same problem with another BG with timer limits
Updated this to include a regex to check for both:

```ruby
url = "http://#{url}" unless url =~ /^http(s?):/
```
not really though xP
Not use test config anymore?
That is fine a fine goal, but using -alpha produces a compiler warning
about the format being incorrect.  It is code that does not build properly.
Using the forth number is a great candidate for that kind of thing.  Any
references can be set to major.minor.revision.* rather than
major.minor.revision.build
Assign whatever number you like to the forth thing, you could say 0 is
alpha, 1 is beta, 2 is gamma, 3 is release candiate, 10 is release..
whatever as long as it's a number that fits in to Windows expected build
format.

On 4 March 2012 14:21, Prabir Shrestha <
reply@reply.github.com
> wrote:

> we are planing to move to strictly follow semver while will look something
> like 6.0.0-alpha5/beta the only way to differentiate between the new
> version is to use AssemblyFileVersion. We are also trying to align it to
> the same version in nuget.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/PaulECoyote/facebook-csharp-sdk/commit/843f3bc2a9b9010258bf585cf5e9b4711be379d7#commitcomment-1040741
>
The point is that if you tag a release with a constraint ``*``, it implies you know all future releases of this library to be sure it will always be compatible with this release. So if you really do, it is fine.
Looking at the changes between Symfony 2.0 and Symfony 2.1-dev, I would not assume the compatibility with the full 2.x lifetime.

And ``twig/extensions`` should not be there at all. You don't depend on it but on ``twig/twig``
yeah, I remember Aleksi mentioned about this file gonna be excluded...
Btw,  my pull request has like 17 commits from other ppl as well. Is it expected or there's a way to go around that?
I will need to level up before I understand the syntax you've used.  Meanwhile, school has laid some stuff on me so it'll be a bit...
This fixed half of the error :3
They were batched together because the crt hack is just extracted from this composer
It's in the new merge request too.
@qwcode I'd rather not require and assert a specific version; that feels like it wouldn't demonstrate the typical scenario where this set of features will be useful.  It also wouldn't help me clean up the assertions in `test_upgrade_with_unneeded_recursive_upgrades_explicitly_requested()` since that one must not be pinned to a specific version.

What if we phrase the test assertions like this instead: https://github.com/ejucovy/pip/commit/c0c6e44c07ef78e226180becce37708376bd2ce8
Makes sense, will do. Thanks guys!
I understand now what and why this is needed, but it seemed a bit odd with the local anonymous function.  You can actually accomplish much of the same thing you are doing with replaceClass by using toggleClass, passing the optional 2nd Boolean parameter.
ElggBatch allows you to do as many as you like. Is there a reason to make the admin click multiple times to upgrade all comments?
There's value, but since it's a test dependency, arguably not much.  Guess it's easy to do, though, so why not?
Is this actually used in the management app?
I think the better way to do this is to reverse the dim tuple passed to `verify_reshape`. Should `self._dim` also be reversed in that case?
This still feels unnecessary. We now have two types of `load_config()`, and in both cases we already know which type we want to call.  There isn't really any need for this condition here.  If we're loading a fresh config from a file, we can call `_parse_config_container_file()` directory (which might be better named `load_config_from_file()`).

If we're loading a fragment we can call `_create_new_config_container(fragment)`.

This should complete remove this function.
I don't think the one source file requirement is important. A larger contribution might benefit from being split in several files according to normal conventions. It should include tests, which should be placed in different files. It might be a java contribution, which might require multiple files. It doesn't make sense.

The unit could be the package name.
If we decide that removing ìfNode` should be removed existing usages (in tests) should be updated together with this PR.

My opinion is that ordinary scala control structures (`if-else`) should be used instead `ifNode`. We will discuss this next week, when Roland is back.
No, I fix it right away.
Yep, it will be 130 :(
There is no need to use comment syntax ``#: `` inside the function: documentation extraction works only for module and class namespaces.
the usls here should be quoted according to the spec
All the imports are in alphabetical order, but 'import' statements always from before 'from' statements
Could also do:

o.required and (not kwarg_dict.get(o.name))

This covers all 3 cases where the keyword is not specified or has a value of None or empty string.
if  a card  starts as a T, it should become an I.  The above won't do that will it?
It has been removed in the new code in my alternative branch (see the PR's last comment).
hrm, maybe something like get_job_flows(options)?

Since you're converting this to be more object oriented, here is a thing to change: Usually, the option parser is a member of "self", so then you wouldnt need to pass the option parser explicitly like this. Just self.get_job_flows()
This doesnt handle jobs without a 'startdatetime' very well; it would explode on None vs. Datetime comparison. ..but since you just filtered them I guess that's okay.

I would also turn this into a lambda:

by_startdatetime = lambda j: j.get('startdatetime')
job_flows = sorted(job_flows, key=by_startdatetime)
The problem is that there are classes that are neither on-demand or reserved instance groups (Spot Instances for example). The way I deal with this is that Reserved is the only one where you buy a pre-allotted amount of instances. The only thing is_reserve_type is used for is to check whether or not there is an upper bound amount of instances we can use. 

I can change some names around because the only thing RESERVE_PRIORITIES is used for is to say "these are the utilization groups that have an upper bound of instances we have bought beforehand, while everything else can be picked up at any time."
when would that happen?
This change a lot again, so if we are going to go this way, and I think it is the way to go, the sooner we merge it, the better.
If this is to be treated as an error, you shouldn't return a valid map instance.
basically, because the whole extension needs to be rewritten, i'll do a second patchset to propose a clean extension, but this patch simply do the work :)

Xavier
Yeah, I almost implemented that, but I thought it was nice to have "forced documentation" at the top of a Module, listing all possible events it can fire. I'd say for Models, maybe have a base Model class, which all models extend and override init:

	init : function () {

		for (var p in this) {
			if (typeof this[p] !== "function") {
				this.events.push("change:" + p); 
			}
		}
		
		this.sup();
	}
This is being less error resistant because we trust in the fact that nothing happens after the switch. It's leaving room for us to shoot us in the foot in the future, when we've forgotten about this.
I don't see how going through a two-step method call is an "abstraction". Lets say this notification was modified to call `controlTintChanged:` instead of `_ controlTintChanged:`. What difference would there be?
Alright, makes sense-- could be easily replicated with the blocks.
Sorry, I mean at the top of the file. We use (approximately) the Google styleguide for python code.
Close the client/server, don't exit.
The code in nibabel.nicom for Siemens DTI is not using the DiffusionGradientDirection at all, but rather computing the "q_vector" from the "B_matrix". 

It would probably make more sense to define an interface specifically for getting this information, rather than trying to bake it into the generic LookupMeta interface (although I am open to suggestions).
Looks like this one definitely leaked on errors, and probably also leaked on normal return.
This import from optparse doesn't seem to be used in here, so should be removed.
{ на одной строке с foreach должна быть по стайлайгду
Thanks man.   I just built the scaladoc and I see the ugly.  Fixing now.
Well, non-experts should not look at `Inverse` in the first place, but just use `.I`/`.inverse()`. If they do look at it, this is really the most important thing they should know. What do you want me to add to the paragraph above?
I think it's for the lines 248 and 249, they are already been covered in 238 and 239, I have made necessary changes and removed unwanted code
here and throughout: no + is needed in this context:

```

>>> print ("this "
... "and that")
this and that

```
I'm unfamiliar with the `Permutation` class and, from a brief look it appears to have a fair amount of complex functionality.   It's not something I want to devote a lot of resources to in the near future.  My preference is to ensure that the interface and tests of this class are agnostic to the underlying data structure so that this change could be made in the future.  Is this sufficient?
I think that if we thought for a bit about how to have this inherit from Union we could factor out some of the code and the final result would be cleaner. This activity probably requires some hard thinking though and I don't think that either of us are particularly interested in doing that. 

I would revert the inherit-from-Union change and just go with a FiniteSet of FiniteSets. If the goal is to get this in soon then I think this is best.
Ah I see now that you weren't trying to assert that you had more of a claim
to than I. I'm sure you can understand how your statement can be viewed as
fairly offensive if taken in the wrong light.

I have no problem with newlines after statements. I think that that's
usually the way to go. I have indeed accepted that this is an acceptable
practice.

I also think that there are cases where the expansion of code is more
clutter than it's worth. The `for x in iter: yield x` construction is very
common in this file (really I would be very happy to find a cleaner way to
do it; if you know something please tell me). This idiom happens alot, has
little intrinsic complexity, and breaks up flow. For these reasons I think
it's a great candidate to be put on one line. If it only happened once or
was more complex I would definitely separate it out.


On Thu, Nov 1, 2012 at 4:07 PM, Ronan Lamy <notifications@github.com> wrote:

> In sympy/unify/unify.py:
>
> > +                    for x in _unify(aa, bb, sop, **fns): yield x
> > +            elif len(x.args) == len(y.args):
> > +                for x in _unify(x.args, y.args, sop, **fns): yield x
> > +
> > +    elif iterable(x) and iterable(y) and len(x) == len(y):
> > +        if len(x) == 0:
> > +            yield s
> > +        else:
> > +            for shead in _unify(x[0], y[0], s, **fns):
> > +                for x in _unify(x[1:], y[1:], shead, **fns):
> > +                    yield x
> > +
> > +def _unify_var(var, x, s, **fns):
> > +    # print 'UnVar: ', var, x, s
> > +    if var in s:
> > +        for x in _unify(s[var], x, s, **fns): yield x
>
> (Not sure why the discussion disappeared from view)
>
> We never precisely wrote down our coding standards but my understanding is
> that it's the community consensus: PRs adding newlines after all
> statement-ending colons are, I believe, always accepted. And since I've
> never seen you protest such PRs, that "We" tacitly included you.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/sympy/pull/1633/files#r2010255>.
>
>
Is this the way we do it in sympy? [@smichr maybe?]
sure. However, in this case when there is separate API for raw read/write and for custom modifications, I think it is better to use it instead of moving files around the system.
This was `:cyan` before being refactored.
change to __setup_router that calls _setup_router so subclass doesn't need to ro _ready=True
Is this supposed to call equals() or isEqual()?
вроде обычно `frontik.blahblah`
Style: arguments need to line up.
yes they are
It is used in test\test-spawn.c:683
I would like someone with a windows system to try this.
Unnecessary cast.
In the spirit of "fat models, skinny controllers", let's put this code in to the models.  I think the best place is in ````ProjectMember```` in a ````before_create```` callback.

This callback would check to see if this user has ````is_default```` set for any other project_member, if not it will set it.

That way, whenever this same thing happens (adding a member to his/her first project) from anywhere else (other code, from the console, etc), we'll get the desired behavior.

This of course should be tested in the project member unit test for add_member
Do we have a trend towards either using default values for parameters or overloading the method? [compare with prepare(..., applyVerification: Boolean = false)]
I *think* that's South implementation details, but just guessing because I could end up producing something like that if doing it manually -- the column itself is going to get added non-nullable and with a value (True) for every row, so it shouldn't matter what the DB-level default is.
Don't mark it as |safe. Just do it like this example: https://github.com/mozilla/betafarm/blob/master/templates/includes/footer.html#L43
ACP's will be prefixed.
Now there is a contraction of delete to del. Expand it.
shouldn't be using a backslash to escape it
That would be the sensible thing to do
Escape message or build an actual hash and serialize to json.
because ROLE_FORUM_STANDARD_NO_OTHER takes more space.
With that the "=>" wouldn't be aligned.
If you prefer not to have 'em ("=>") aligned I may remove all those tabs.
Commas would be preferred, again
spațiu înainte și după "=", PEP 8
As long as it's used only in OpenGLWindos - I do not think so. But if you do insist then I'll move these declarations to a separate header.
This trick is possible because we're surely not in the GUI thread.
I'd suggest you put a line of comment regarding this.
Don't you think we should ask for 2.4.3 instead of 2.4.2?
Hm, is this is just a small file, maybe put it directly into `pkgs/build-support/cabal/jailbreak.hs`?
Could we print a warning too, with *warnings.warn()*?
As agreed, remove.
/settings/ folder?
Do we need to handle single quotes too?
What is this proc dict entry for?  Something to do with logging I take it?
Пропустил `var`
I think that you can find a way to skip this type-cast.
:+1: Yep, exactly.
Add a new line to keep things consistent with the rest of your files.
wouldn't I have to duplicate the below code that makes corrections to `.getBoundingClientRect()`?
Hope you didn't hate me too much for not having commented there in the first place :/
Why it shouldn't?
Again, default to None.
can you send a me PR to my branch?
hummmm, un else if inutile. Je sais bien que plus tard on l'utilisera mais quand on met des choses qui n'existe pas encore, on prend le risque que la personne qui l'implémente ne voie pas cette partie, refait quelque chose a coté et on se retrouve avec du code inutile.
Yes. I intend to create a reference document explaining stuff like this. It certainly confused me the first time I used the wrapper. But it will be long term confusion if name sometimes mean a modhash and sometimes mean display name. It's better to consistently do the correct thing and make documentation for newcomers, so they know what the right thing is.
1. Тут тоже слишком много "вы". Надо бы написать что-то вроде такого:
"Скажем, вы и ваши соавторы закончили с нововведением и слили его в ветку `master` на удалённом сервере (или какую-то другую ветку, где хранится стабильный код)"
2. "используя весьма глупый синтаксис" лучше заменить на что-то типа "используя, пожалуй, непонятный синтаксис" или "несколько бестолковый"
Nope, no strong reason.
Could you please stop using "Yes" and "No" instead of true and false?!
We don't, but I'm wondering whether [1] is the universally true position of what we're going to want.
Tabs to spaces lines 267 to 277
I think it would be clearer to just leave `offsetEnd` off here, and test it for undefined in `_computeOffsets()`, rather than using a sentinel value.
I think that will change once #1825 is fixed though.
Done. Also removed toggleUseTabChars()
Regarding _getCodeHintList(), it's a private method only used by unit tests anyway, so it seems like having it give access to the raw value is fine--we can use it to actually distinguish what's going on under the hood.
typo: locals --> locales
``result.promise()``
So are we not reverting this?
will this fail if not a delegation case? I would make it a private-looking field given that
Generally, we add null checks to public constructors on public classes
Can the commented code be removed ?
Nope I just copy and pasted this from here: https://github.com/libgit2/rugged/blob/development/ext/rugged/rugged_tag.c#L210 :)

I guess this should `"10"` or `"10&"` instead?
Why you need span around text? Why not simply style button element? Why additional element?
Changed. Also masked as fb.get('email', fb.get('id')).
Really only a nit. Couldn't you just do media.ready here as well?
Maybe this should be "Build Prerequisites" instead. Not really required to just use or develop.
Should the blurb about `port` be on the next line?
Space after the 4
Simplify this, just do:

```
report.stateList.slice(-10).reverse().join(", ")
```

This will take the last 10 items (or fewer if less than 10), then you can drop all the list length state handling above.
yup. it's merged with edits in 8692aaff943e7716a7665d46f14e6bc6cb25a924
What happens if there is no ';' existed? For instance:
    Set-Cookie: name=value
added the 'make test' target to run test cases
@mrkn さん案、たしかに読みやすいので :+1: です！
task の名前については、最初につくってくれた @mitaku @asonas に考えがあると思うので、そこだけ確認できたら、もう Merge してしまいたい気持ちです。
Could this be Hash.new(PDF::Reader::Encoding::UNKNOWN_CHAR) to ensure unrecognised glyphs are returned as valid UTF-8?
same thing as previous comment. The direct model update (line 499) mirrors line 498
Yes, missed these in my sweep - will update.
Define all variables at the type of the function due to hoisting and function scoping.
`?:` operator should only be used as an oneliner. If you wold like to avoid
```ruby
if v
  @product.should_receive(:reset_repo_gpgs!).once.and_return([]) 
else
  @product.should_not_receive(:reset_repo_gpgs!)
end
```
consider
```ruby
@product.should_receive(:reset_repo_gpgs!).once.and_return([]) if v
@product.should_not_receive(:reset_repo_gpgs!) unless v
```
This notification breaks the lifecycle contract of the operation.. The operation manages a single NSURLConnection from start to finish, which may include additional requests if redirected. The `AFNetworkingOperationDidStartNotification` is used for, among other things, incrementing and decrementing the activity indicator spinner. Emitting additional start notifications is invalid behavior.

If the desire is to track these new requests, a better solution would be to introduce an `AFNetworkingOperationWillLoadRequestNotification` or something similar.
The issue with T UNION T stems from the same sort of limitations that prevent T JOIN T from working correctly -- at this point, I would suggest giving an error if any table mentioned in a UNION's (UNION TREE's) children occurs twice.  

For now, I would also suggest just living with the current restriction that the final plan can only have 1 or 2 fragments, meaning that only one of the selects can be multi-partition.

To me, a higher priority is either error handling or disabling  "inferred SP" support. Or BOTH error handling AND disabling -- try planning with inferredSP and on failure retry without inferred SP -- I THINK we do something similar with multi-statement batches. What we need to avoid is cases like "SELECT ID, DATA FROM T1 WHERE ID=1 UNION SELECT ID, DATA FROM T2 WHERE ID=2" where each SELECT would normally run as a single-partition plan and contain a single fragment, but the PartitioningForStatement state would indicate that the single-fragment plans are only valid when run each on their own partition.

In theory, in some cases where there are exactly 2 such single-partition SELECT plans -- or where there are only 2 different inferred partition keys shared by the two or more SELECTs, the SP plans can be stitched together into an MP plan by adding a Receive/Send pair to the top (and possibly a Distinct Node) but this would be very ambitious and could only be a specialized feature for specific SetOperations.
Yes, but it would be brief. And its better than having the homescreen flashes when the screen is turned back on.
I was thinking plural because I thought it would contain arrays in the future.
It's probably good to be consistent, although `x` will be a vector too in the future and no-one's proposing to call it `xs`, right?
So we won't have total consistency anyways and should just aim for whatever reads most naturally in most use cases.
Is this header intended to be at a different level than the others?
Ah right, I'll take a look at that.
Oh wait, I just saw 'if you're running a csh variant' - ignore me!
Yes, maybe use true will be more strict
done
On Aug 20, 2012, at 8:44 AM, jao <notifications@github.com> wrote:

> enormously
was this tested?  maybe this could work if we ret.push_back(o) ...  but it still doesnt show locked unspent outputs
How do you mean that? We don't currently have any functionality to "catch" crashes (something like google breakpad could help there, but there's the not-so-small issue of accidentally sending private key data), I'm not sure how it's related to created threads.
I'm pretty sure that providing a command line option does not change the setting in QSettings, so afaik it will not work. The code to get data for the options dialog reflects the current setting in the Qt settings, not the option actually in use in the core. 

We should at last test it.
@laanwj I don't need psz or f or n in front of variables, but at least the names should speak and be consistent everywhere.
Boost (sometimes) fails to provide a microsecond clock for Windows, which seems to be a known issue.
Maybe make this "The total" too?
The indentation here is off. It should be :

```
<optional>
    <element name="ProducedCommodity">
        <text/>
    </element>
</optional>
```
You sure this isn't used?
Add *all* config settings to `IApplicationSettings` and use this interface as the primary way to get setting information. Keep it DRY.
@thekad Why didn't you share this project with the grit guys?
ups, missed that one. fixed
Can just be 'return unless ts' with implicit nil.
Out of interest: does it matter that the children will be returned unsorted by their Uses? I'm guessing not, but it seems to me that would change the behaviour of this algorithm in interesting ways.
This needs to be here. The display() method returns a Response object.
Also, the proportions of the figures was not preserved.  Is there a reason for this?
missed this one. commit coming.
This is only going to work in Windows. I think you should be able to just use `sys.executable`.
is it possible to use \@WrapWith for this sortof structure? If we also need to name the arg, we could consider making the code that addresses WrapWith to also read the value of \@PayloadParam as the key.

Just thinking if we can reduce the amount of custom binders.

ex.

\@WrapWith("set_metadata")
future updateMetadata(\@PayloadParam("metadata") Map<String, String> metadata)
when and's and or's start to get this interwoven they really should be grouped in parentheses.
the logic here is flawed quite apart from the child/parent change above, if location.getParent() is null it proceeds to check location.getParent().getParent().
This is a good change to propagate the error code from `git_config_get_string` instead of overwriting it with -1. Is there a reason to overwrite errors other than `GIT_ENOTFOUND` here? Could this just `goto cleanup;` without setting error to -1?
I suggest you use #partition here to split the identity-map-found results from the non-identity-mapped ids. Should save you from having to reject on the next line, and maybe also the #is_a?(klass) part of the following select.
This is fine for now, bit I am wondering if we should start using static for new stuff. Then we could have the images live in `apps/products/static/img/products/.` or something similar.
Here, too. s/product/topic/
Applying things like this to self creates the possibility of corrupting other cases.  and it seems like you pass in the self.credentials anyway.  is there any reason why user, apikey and credentials can't be just local variables?
If it isn't hard to do, then yes! If it's going to take longer than the first half of today, though, then no. In that case, let's land this and do the additional work for the next cycle.
I'll do that change as part of my middleware cleanup, see https://bugzilla.mozilla.org/show_bug.cgi?id=778744
LENGTH_OF_UUID_PLUS_ONE - just in case UUIDs change length before this code is thrown out...
上面这段代码按代码规范修复一下吧。
Is it perhaps a problem that we end up in a race condition between the !doingRotation check and here?
Why did you remove this namespace?
docstring is now out of date and needs to describe the new behavior. Having these descriptions would really help reviewing this change too.
previous behaviour:

when a match fails, it tries the following region, recursive, until one matches. When one matches, it stablishes a limit in the region to search from previous failed, thus improving probability to match previous failed ones. If it reaches the last region with no  match, it simply failed and nothing will be extracted from those not-matched regions.

new behaviour:

it changes only how to manage the case when it reaches the last consecutive following region and did not found a match. Just force a retry to use this time the modified similarity matching algorithm if can't extract anything without the mod.
isn't it 5.3.8 ?
Can we rename this variable to `$padding-list` for clarity and consistency?
men va fan h[ller du p[ med!_
Also redundant spaces here
I started working on adding the other configuration items as attributes in a local branch. If you've done more work on that may we should start a remote branch so we can pool our work?
> What if they change the instance?

We haven't yet decided if an instance is immutable or not. Currently, you have to work really hard to change it in any meaningful way. If you don't use instances, you cannot map all of the epsg codes.
not really n^3.

i = 0 - n where n is the # of parts in the path
j = 0 - m where m is the sum of exact matches (0-1), wildcard matches (0-1), and variable matches (0+) for this part of the pattern
k = 0 - 1 for the first pass and 0-2 for the second

in practice it actually trends towards n instead of n^3
Another CS issue : Comment should stand above the `else` statement.
Empty line below is not necessary.
@stuartwdouglas wdyt of this, is it enough to have that safety against stateful beans leaking?
This is not thread-safe, in this case making it final should do
It's a good point, thanks.
I'll fix it.
You should test that `$cl` exists and is an array before using. i.e. `if($cl && is_array($cl)`, though, judging by how `$cl` is set up, you can probably just test that it's an array.
Should we have a test also for `resizable().draggable()` as well?
don't know why you have changed but use strict should go at the beginning
Indent the comments (L42-45)
Usually when you have an ID this is enough. This can be addressed in a followup.
early return?

if (out) {
    return out;
}

bla bla
Right, you moved it
Sorry, I was wrong. You should put it here, and:

    window.addEventListener('appopen', function hideTray(evt) {
      window.removeEventListener('appopen', hideTray);
      UtilityTray.hide();
    });

Drop the reference about `self = this;` cause we are not calling the `hide()` function of ourselves ... :-/
Also i think 0.8rem is not the height in the design (is about 6px not 8)
You scared me :p and I move the initialization of the localization feature to the init function ;-)
We don't want to show it always above fullscreen right?
Seems to me that we have at least in 4 places:

var photoURL = URL.createObjectURL(contact.photo[0]);
eleme.style.backgroundImage = 'url(' + photoURL + ')';

Can we refactor to a method?

Thanks.
Alter the <tt>label</tt> and <tt>menuLabel</tt> properties to not conflict with other labels already present inside the layout structure. I know these layouts should not end in settings but it is preferable to have different labels for debugging operations.
If (!image)
  return;

Also is cropImage a global function?
This won't work correctly if the href contains a fragment.
Not sure what the mozilla style guidelines say on JS but since these are God given constants maybe the variables should be spellin ALL_CAPS?
The message sending needs to be cleaned up a LOT. Not sure the deltas need to be in this format
Yes I'm planning to use adamantium in many classes. This one's included.
Yeah tom - you know what this should be - comon - you know better!
I think I may need some further discussion with you on this point to clarify what exactly you're looking for.  Did you want me to do an import test on yaml and then not make that format available if it fails?
I am not familiar with Autofac so much ;)
Done. Moved into their own class.
Agreed and fixed - thanks!
Asserts should be used for unit testing, not in actual code itself. I'd instead raise a BadParameterException or some other specific exception that we can write tests to enforce.
This will fail if zip extension is enabled but `mbstring` is not.
border and font-size should be above padding? (alphabetical)
Okay, sounds good.  Reordered them and committed.
Maybe it's better if we leave this out (because the iterator is not a InputIterator atm). There is no tag for weaker kinds of iterators.
What is "GDS-Regular"?
Your whitespace is weird in this file -- can you fix the inconsistencies?
It is possible that we can reuse the same `RemoteFilesystem` instance several times. Since it felt like `RemoteFilesystem` was written to be sorta a one-shot sorta deal, I decided it would be safer to just do it this way for now.

I can experiment with it if you like. :)
please fix the CS (you can use [PHP-CS-fixer](https://github.com/fabpot/PHP-CS-Fixer) for many rules)
This is not going to work, "CUSTOM" does not mean anything, better use the name, it has a chance of being resolvable back into a CoordinateReferenceSystem object, while "CUSTOM:xyzw" is guaranteed not to work
Isn't this exactly what the `term` helper does?  Why make this again?
these can be generalised, i.e. click each link, confirm the title contains the link text
If you have a long block of text, keep it separate so that it's not confusing to read in the code. Make it a variable declared at the top of the file, or in a separate module, or in a plain-text file that you load from.
Rouven is aware of the bootstrap stuff in platform files. He is dealing with that side.

Flipping stuff around and making the $tip optional is fine by me... I'll chang it right now...
Don't you need to inject `unloadSandbox` too ?
This function is like it's own DSL, I tried to understand it several times and have failed.
"its own set of built-ins"
Again, a higher level abstraction like "testidp.enablePrimarySupport" would make this easier to understand.
Nope we still use Boolean but the CS fixer does not change boolean to Boolean.
This needs to be fixed. That looks like a hack :)
Ok since bunyip is broken I'll merge this in but revert the check for `cmd.name`.
pre-initialize to numNodes
Temporal varaible for what exactly?
I'd change the above to:
{{{
if (!$defaultValue instanceof ValueGenerator) {
    $defaultValue = new ValueGenerator($defaultValue);
}
$this->defaultValue = $defaultValue;
}}}
This eliminates the else clause and simplifies the code.
Can't this check be removed? With the new Zend\Mail you actually can set the subject twice IIRC.
Thanks for fixing typo!
No worries, it's kinda hard to explain with three different repositories in the picture: local "working copy" clone (the one on your computer), remote "GitHub"/"fork" clone (github.com/username/GiveCRM), and upstream "central" repository (github.com/GiveCampUK/GiveCRM).  

The answer is neither: it will push changes to `nbarnwell/feature/<featurename>`. Unfortunately, you can't run `git flow feature publish` more than once; after you've done it once, you have to use the usual `git push origin` to update the published branch.
Style police again: space between keyword and paren.
In case they don't have `/usr/local/bin` in their `$PATH`? I don't know. That would probably work fine. The reason I did this is because that seems to be what the brew installer checks (i.e. if you have a `/usr/local/.git`, the brew install fails)
cs, please run php-cs-fixer here

style should be IMO:

```
      ->findOneBy(array(
              ...
          )
      ;
```

but i could be wrong
yes remove that in your PR please
Doesn't seem to apply to the next line which I guess you meant to comment on, as it's a complex predicate? 

.Where(q => !(q is BooleanQuery) || (q as BooleanQuery).GetClauses().Any());
Moved to a separate file.
@harjis Tässä on mun mielestä myös ongelma. Mitä jos lasku on alunperin ollut käteislasku ja se on maksettu johonki kassalippaaseen ja ollaan käytetty kassalippaan takaa poikeavaa tilinumeroa?
use `@arg`
I'd prefer it if this statement was broken out into multiple statements for readability.
Technically it's better we place the plugin removal, popcorn instance destroy and <pre>start();</pre> calls after your assertions in the event handler.

While the chances of this ever having async issues are minimal, it would be better.
Yeah intention was to have it in the window object. Will fix
shouldnt we then add :include => :domain_parameters here too?
Looks like you're missing a comma between the 2 arguments to `FileUtils.mv`. Also, please use a variable for the 2nd argument - so that the `gsub` isn't inline. Lastly, we try to avoid inline `if` statements (like `x + 1 if foo`), so please move the `if` to its own line.
Actually, that won't work for search results, so never mind...
Shouldn't have module_load_include() in the global space: http://api.drupal.org/api/drupal/includes!module.inc/function/module_load_include/7

Not certain, but throwing into an implementation of hook_boot() may suffice?
Thought I replied to this?!  Anyway, I was not sure of a convention.  It seemed like an error.
Perhaps we should have a bit more thorough comment. Something like:

    Each line contains the comma-separated list of roles for a particular user, and is of the form:
        <username>=<role>[,<role>,...]

    where
        <username> is the name of the user, and
        <role> is an expression describing a role for the user and which adheres to the format

    <roleName>[.<sourceName>[.<workspaceName]]

    where
        <roleName> is one of "admin", "readonly", "readwrite", or (for WebDAV and RESTful access) "connect"
        <sourceName> is the name of the repository source to which the role is granted; if absent, the role will be granted for all repository sources
        <workspaceName> is the name of the repository workspace to which the role is granted; if absent, the role will be granted for all workspaces in the repository

    For example, the following line provides all roles to user 'jsmith' for all workspaces in all repositories:

        jsmith=admin,connect,readonly,readwrite

    while the next line provides connect and read access to all repositories, but only write access to all workspaces in the 'customers' repository

        jsmith=connect,readonly,readwrite.customers