labofsahil/github-event-dataset-2012 huggingface dataset:
If you could just add comments in to explain what it's doing, where info is coming from and how it's being manipulated that would be great. No rewrite necessary. 

~ Scott

On Oct 22, 2012, at 6:25 PM, cshenry <notifications@github.com> wrote:

> In lib/ModelSEED/MS/Factories/SBMLFactory.pm:
> 
> > +			$proteins->[0]->[0] = $proteinItems
> > +		} else {
> > +			foreach my $item (@{$proteinItems}) {
> > +				push(@{$proteins},$self->parseSingleProtein($item,$gprHash));
> > +			}
> > +		}
> > +	} elsif ($root =~ m/\+/) {
> > +		$proteins->[0] = $self->parseSingleProtein($root,$gprHash);
> > +	} elsif (defined($gprHash->{$root})) {
> > +		$gprHash->{root} = $gprHash->{$root};
> > +		return $self->translateGPRHash($gprHash);
> > +	} else {
> > +		$proteins->[0]->[0]->[0] = $root;
> > +	}
> > +	return $proteins;
> > +}
> Well, it works, and it complains if it doesn't work. I'm not going to re-implement that particular thing. Obviously, it is a complex piece of code that can take any GPR string and convert to our protein data structure. This does it, and it works when applied to an entire genome-scale model. And it works right. Not sure what else I have to say here. Chris
> c
> \
> Reply to this email directly or view it on GitHub.
>
Pourquoi autant de new User() mangoose??
ps:
- dans add_user() un new User...
Would you mind using the notification [here](https://github.com/alexcrichton/hermes/blob/master/Classes/Pandora.m#L278) instead? I prefer the notification-listening style to explicitly calling methods which ends up with a tangled mess of dependencies that doesn't make a whole lot of sense.
This is an old function ! Please, could you use a Closure instead.
See https://github.com/composer/installers/blob/master/src/Composer/Installers/Symfony1Installer.php#L20
Don't forget that CoffeeScript provides `@prop` as sugar for `this.prop`. :)
Nope, that should still get called in push.
чтобы так называть он должен быть в namespace что-ли...
what is this migration for ?
+1 Nice catch
I don't like that this method contains so many steps. Each of these are really steps that should be in the test method itself. If it were a manual test case they would each be individual steps.
Should check for err first.
Can you add a TODO here stating that this should be removed once the UI is hooked up ?
Looks like validation is further down. It probably makes sense to do one validation test per comment action.
This method is quite hard to read. Would it be possible to break it down?
Even if you set it only once, that is not what happens in the bytecode. It's initial value is always ``null``, so you could still have visibility issue.
Hmmm, need to think it through. 

What you're saying is the "Already seen" code will fire (if all sections already seen) and so it won't process but also won't mark as done?

You might be right about removing the code, I'm just wondering why I put it their in the first place.
You should not need this since you'll be restructuring to remove absolute URLs except where its needed for compat and that code should be able to know what IP the original connection was on and we can assume that is the one to connect back on (even if its HTSP v HTTP).
This was done by the editor (PyDev) and I didn't realized it.
I set the formatting back to the original.
What does IsAppropriate mean? :) I guess it is there due to differences in view engines wrt master and partials?
This is nothing important, but since you have a lot of corrections to do - might as well change that *boolean* to just *bool*. Just to be consistent with how it's done anywhere else in CI.
Just replace *'gmt'* with *any PHP supported timezone*. The original description is more than good.
Да ты прав. Спасибо. Просто делал в спешке..
Looks like this loop and the next loop can be merged.
Yeah, the latter seems like the reasonable option.
Couldn't you dynamically define methods and delegate them to the api as needed? This way would act more like a real object (and the methods will appear listed in object.methods).

In the other hand, using method_missing probably has better performance than delegating the methods (at least at average) since you would only be forwarding when needed.
Ahh, fantastic. Didn't love the way I did that as you can tell by the note :)

I plan to do my own export out of this file to let folks hook into the build succeeded/failed stuff.

Is the best way to do that through exports?

Thanks!
`ActiveSupport.on_load` is instance eval'ed inside AR, this means we don't need to open ActiveRecord::Base here :)
Can we default both these arguments to null to simplify the api a bit? This will also make it backward compatible.
Whoops! Sloppy me...
... without the raw.copy()


On Thu, Dec 6, 2012 at 4:25 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> ?
>
>
> On Thu, Dec 6, 2012 at 4:24 PM, Denis-Alexander Engemann <
> denis.engemann@gmail.com> wrote:
>
>> def copy(self):
>>
>>      raw = self.raw.copy()
>>      del self.raw
>>      new = deepcopy(self)
>>      new.raw = raw
>>
>>
>>
>>
>>
>> On Thu, Dec 6, 2012 at 4:22 PM, Alexandre Gramfort <
>> notifications@github.com> wrote:
>>
>>> In mne/epochs.py:
>>>
>>> > @@ -463,19 +493,30 @@ def __repr__(self):
>>> >      def __getitem__(self, key):
>>> >          """Return an Epochs object with a subset of epochs
>>> >          """
>>> > -        if not self._bad_dropped:
>>> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
>>> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
>>> > -
>>> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
>>> > -        epochs.events = np.atleast_2d(self.events[key])
>>> > +        epochs = self.copy()
>>>
>>> I am always afraid that copy does not do the job. I would hack it with a
>>> deepcopy after removing the raw attribute...
>>>
>>> —
>>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2335953>.
>>>
>>>
>>
>>
>
double spacing "this  tag"
I think you have done an amazing job! Great stuff!
why not use the shorthand `$(function() {`?
Wait, how's this working? floor(level/100) is always 1 or 0.
This function I made as a response to the occasional out of expected error bound behavior I was getting from specifically bates and logNormal (though occasionally from other tests too). I ended up not implementing it because I don't believe it is the best way to do testing on random functions.
需要加上参数。
Actually I was just referring to the missing "the" :) But hey, even better now!
What are people going to do with all this info?
why use malloc in this c++ code? Even further, why not use auto_ptr to scope the memory allocation and avoid having to free it yourself?
Decided it was up to the calling function to supply properly-formatted `host` and `port` params to the dev server. Previously, the dev server was accounting for receiving `None`s from the command-line args, but that's not the dev server's job. This also allowed me to use default parameter values like they're meant to be used in the dev server initialization.
PyArray_   has been the standard.    This has been changed by several people recently.   We could go with Npy_ to be consistent with the NPY_ of Macros.
I don't understand this change in behavior of separatevars. I guess the docstring should be updated to say that no factoring is done?
Well, I think this is not clear enough and I consider splitting these part.

So when you are root, backend run as it is in same process.
And only for non-root dbus and policy kit is used. And I consider to refactor it out of base infrastructure. So every project can decide if they want role managent. So maybe we should specify here, that role based managent is optional and its implementation use DBus and policy-kit ( easily changable ).
Не понял? В смысле? Да, работает. А не должно?
А чо не ссылка?
Если ты дальше `parser` не юзаешь, то можно просто `QJson::Parser ().parse (data, &ok);`
Так, стоп. Чо этот сигнал вообще делает и когда он используется?
¿Deberíamos indicar también que decimos las cosas positivas? Creo que si no fuera así, no tendría mucho sentido las cosas que decimos (que, en su mayoría, son positivas).
This is an interesting change here!
The name of this function is a little confusing.  To me it looks like it returns the first column of content, and if the columns are envs, maybe it should be called "first-env"?

Could make it more generic by returning all the columns, and the letting someone else pick out what they want
```
(defn envs [results]
  (->> results columns (map (comp :content :to_display)))

repl> (-> myresults envs first)
```
Could you replace this with a nice dialog ?
Fixed for now, thanks for your explanation.
Backquotes have a way of biting you if you're not careful, so I'd vote for using $() over `` in general.
And what's with that hard-coded token? Should we pull it out and stick it up top somewhere?
`store()` should definitely not be synchronized.  Any concurrency control really should be in MongoDB itself.
I did, but in the wrong branch :) Will update the PR now.
Shouldn't return ClusterCacheLoaderConfigurationBuilder ?
Thanks, sound better.
Before GitList was released, i experimented with such feature. It was slow as hell and i decided to keep it out. An option is good, but if the feature sucks (for instance, it's slow), there's no reason to keep it there.

The true way of getting speed on this was not by querying GIT, but querying a database instead. That's what GitHub does. However, GitList is not meant to be a GitHub replacement... and a database is definitely not on it's plans.
Maybe I will backtrack on that one. Lets keep that particular change completely seperate (and for 1.3 perhaps).
`call_definitions.py` was a bad design decision. I may or may not have been drunk when I came up with it, and it was only designed to handle a handful of cases (`eval()` and the like). This is basically the same thing, but it prevents you from shooting yourself in the foot and it's a whole lot cleaner.
The warning/error is shown on email settings page.
I'm fine with this approach. N/A sounds fine to me!
Didn't find any, having a hard coded extension in there rang the alarm bell.
Ok, sounds good, but not forget ;-)
I think we can get rid of the `self` here.
@bramstein We should only compare to the last resort size here if we know the WebKit bug is present. Otherwise, we're going to give a false inactive for a font with the same size as the last resort font on platforms/browsers that don't have the bug.

I think this line should be:

    (this.hasWebkitFallbackBug_ && this.sizeEquals_(sizeA, this.lastResortSizeA_) && this.sizeEquals_(sizeB, this.lastResortSizeB_))) {

Does that make sense?
Are you sure ``$callback`` has the correct type as "object<Symfony\Component\Process\callable>|null" is not a sub-type of "object<Symfony\Component\Process\Closure>|string|array|null"?
++Factory Girl   @jameswritescode FactoryGirl would be a good meetup lightening talk .
I was having trouble deciding whether to put these methods here in the `Marketplace` class, or in a more inherently global place, such as the `Client` class.


Also, per an ongoing discussion in the #balanced IRC channel, I think it's worth considering remove the public getter and setter to the `@marketplace_uri` property.
den Limit meinst du? Finde regex ist hier unnötig. LIMIT Klausel ist immer am Schluss vom statement.
Was meinst du num 0 für infinity. Lieber überladen mit einer Variante ohne angabe?
Correct, works in DartEditor (setting package root folder)
and in Dart VM (after a pub install).
"1" the string, not the integer :)
I think you have space indenting on these two lines.
The thumbnail was just the resized version of the logo/icon; there wasn't a way (at least not intentionally) to change one without changing the other.  We just piggybacked on the thumbnailing code so that the images would automatically be resized.

I called it `thumbnail_file` so that it's contrasted more directly with `thumbnail_url` in `Video`.
Is there no InsertAll or Merge in Java?
That won't work, if you generate the content statically without running it within the application. I think we should support generating the content completely independent of Studio, so that everybody can do it, not only those who do that as part of Studio development.
#each_with_object is generally preferred over #inject for building a Hash
Why. I think it is very pretty solution. Are you familiar with any known issues?
It looks like it is implemented in every major version - http://kimblim.dk/css-tests/selectors/
I sent array like: [[a,b],[c]]
Than I read data: order = request.POST.getlist('order')
and I got this: [
			"panel-dummy",
			"panel-horoscope,panel-map",
			"panel-onlineusers"
		      ]
(You should create an asynchronous task and wait for it. So that it is done through Celery. Not directly.)
You do not have to set created_time, it is done automatically.
Yes, thank you Mitar. I didn't know, where this code should be. Now I know :)

I've pushed new commit just now.
Does it mean I need something like that?

```ruby
`echo '#{test_json}' | #{bin}/vbuckettool - hello world` == expected or raise "broken"
```
can you align with current master to support absent/present? installed and removed are going to be removed in cdist 2.1.
the Twig CS are to use underscore in names for variable and functions, not camelCase. And you should remove ``bundle`` IMO
If the whole AuthenticationService goes, this is a moot point.
Missing dependency to retrieve class metadata (I think we decided to directly inject the `ClassMetadataFactory`
This api can be misused, i.e. an user of this class can use apply without using is_applicable_for. Perhaps a check inside apply is needed.
WTF!
merging..
minor: missing supports section which shows what access types are supported
Remove all of these blank lines with leading whitespace, or at least remove the leading whitespace.
I have to think on it. But my purpose is mainly to say: step by step :)
In my point of view, your idea is more linked to a cache system (a limpyd-johnny-cache way? ;)) than to the collection it-self, and its more an optimization / contrib than a core need.
Manually storing the collection in python, when needed, with for example a list() could do the major part of the job.
Caching is not a trivial process.
I'd like to start with the basic needs, use it in real life, and then think about optimizations. :)
No, I meant should it include 'myfavoritebeer'.
Actually, should it be `VICINITY_MIN`?
Why set a directory for something that you don't create? ;)
You're right. It is better to make less assumptions.

> `if (( $+functions[compadd] ));`

Did you mean check `compdef`? I see zsh has `compadd` even with an empty `.zshrc`. It also says in the zsh manual that `compdef` is defined with compsys. Also, it seems that using compctl is fine.

Anyway, I experienmented with it a bit (clvv/fasd@3ea0a195c0f4acd0f5deafec4bac4dc5be9eeb1d). Please tell me if there's any problems or room for improvements. I know separate files for zsh would be ideal. However, installation would be more complicated and I'm reluctant to take the step.
after moving ``importpaths`` and ``pitfalls`` to ``Basic Documentation`` there is only ``dev\internal`` left that is not a duplicate of the ``Basic Documentation``.
Could you, please, replace tabs with 2 spaces here and everywhere else where they might be? I'd suggest adjusting your editor's settings to use 2 spaces for indenting Ruby files.
Done.

FYI, there are a few pre-existing trailing commas in other files:

$ perl -0 -ne 'if (/^(.*,)\s*\}/s) { @l=split(/\n/, $1); printf "%s:%d:%s\n", $ARGV, scalar @l, $l[$#l] }' *.js auto_tests/tests/*
auto_tests/tests/DygraphOps.js:149:    clientY : pageY,
auto_tests/tests/interaction_model.js:118:      'mouseup' : customUp,
auto_tests/tests/update_options.js:11:  height: 320,
auto_tests/tests/utils_test.js:63:    c: { x: "original", y: 2},
might change to reflect the current 10x10 version?
Or would Gary's fix on master speed things up enough to go back to the original 100x100?
Ah, thanks, I didn't think of doing that.  But... do you think it is problematic to have this public?
i think ultimately address this with proper mutexing of lifecycle events, and perhaps a "tearing down" state?
perhaps as part of revisiting manage/unmanage and ability to subscribe to such events.

can we fix the test garbage-leaving another way?

yes, the service_up check did cause problems.  i'm not sure where/why.  this might be fixed now that we can start nginx without any downstream servers.

open a new issue?
Not sure I follow the suggestion to removes those lines. Are you proposing making the call async, so we don't call `task.get()`? The mutex stuff is conservative, that we won't try to resize again until the current resize tasks are complete. Would be great to improve that, but non-trivial I think.
Its being used on [doc_code_merge.dart#L354](https://github.com/dart-lang/doc-code-merge/blob/master/doc_code_merge.dart#L354), maybe the question is do we really need to have an escape filter? I think htmlescape as a package has gone away, if we need it should we dig it up?
I am showing that although the plan might be $30 a month we're going to refund the actual payment.
all the methods of the ConnectionPool require locking[1] as they might be accessed concurrently by multiple threads.

[1] http://msdn.microsoft.com/en-us/library/ms173179(v=vs.80).aspx
ここに来る手前で original_user_glossary_id が確かに存在するIDかどうかを検証しておく必要があると思いました！
This feels a bit weird, passing in the basket and user here.  I need to have a think about this one.
var image = "../contacts/contact' + (this._contact.id % 10) + '.png and use that
Make it like this: (Make the fake tabs (lots of spaces) real tabs)
if(prob(25)) //Do some major damage
    affecting.take_damage(rand(10,15),0)
    G.assailant.visible_message("\red You smash \the [H]\s head on \the [src], [H.gender == MALE? "his" : "her"] bone and cartilage making a loud crunch!", "\red [G.assailant] smashes \the [G.assailant]\s head on \the [src], [H.gender == MALE? "his" : "her"] bone and cartilage making a loud crunch!", "\red You hear the nauseating crunch of bone and gristle on solid metal.")
else
    affecting.take_damage(rand(5,10),0)
    G.assailant.visible_message("\red You smash \the [H]\s head on \the [src]!", "\red [G.assailant] smashes \the [G.assailant]\s head on \the [src]!", "\red You hear the nauseating crunch of bone and gristle on solid metal.")
what's the return value here?
and PhoenixPilot
I'd still like to beat this dead horse.  There is not a unique mapping from VID/PID to IBoardType so this should be deleted.  Any usage of it is a bug.
Looks like it is grouping by 3 and doing a reverse first to group by 3 from the right.   You could do it without reversing by anchoring 3 to the end like:  ```(\d{3})\d{3}$``` 

Though two things: I'm surprised if there's not something already for this defined in ActiveSupport, and 2, this is clearly a view concern and not a Promotion (business) concern, so really, this method should not exist here for one of those two reasons.
Если я правильно понимаю, этого действия можно было бы избежать, если установить день месяца в 1.
I only stubbed out campusdb, I figured the others can be stubbed out in another pull, and probably have some figuring out to do with the settings.yml files.
This section is feeling a little hard to read. It looks like the stuff from lines 396-403 are related to this style - maybe grouping them together would make it more clear?
It doesn't need to be handled by the movies service. It's used by MCMS to determine which movies service URL to use from the configuration YAML. 

sekarp <reply@reply.github.com> wrote:

>> +             
>@client.should_receive(:api_request).with(/genre=This%20has%20spaces/)
>> +              @client.movies :genre => 'This has spaces'
>> +            end
>> +          end
>> +
>> +          context "and processing the lang parameter" do
>> +            it "should set lang to the 'lang' query string
>parameter" do
>> +              @client.should_receive(:api_request).with(/lang=fr/)
>> +              @client.movies :lang => 'fr'
>> +            end
>> +          end
>> +
>> +          context "and processing the locale parameter" do
>> +            it "should set locale to the 'locale' query string
>parameter" do
>> +              @client.should_receive(:api_request).with(/locale=ca/)
>> +              @client.movies :locale => 'ca'
>
>Is locale from the country collection in the json response or something
>else"?I haven't added this to the movie filters. Let me know what it
>should do.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/infospace/colonial_raptor/pull/2/files#r1035711
use `3px 3px 0 0`
Hah, good catch! Will fix.
This doesn't change anything; that's exactly what toString() does....
This `return` is not good for testing because it suggests that this text string is what's on the page. It's OK in automated testing just to hit the exception here and stop the test.
Can you add a newline between the description and the @return annotation?
i tried to make it have as few dupe lines as possible, that's why i split it up, to avoid possible c+p errors from someone adding a new target.  can't we just add the "-" to the targets, and keep the one for rpi empty?
I pass all tests using the following setup:  Ubuntu 12.04 32-bit, python 2.7.3, and numpy 1.6.2.
Also tried setting the io plugin to: pil, matplotlib, qt, and gtk, and they all passed.

@tonysyu, it looks like you are running on Windows?  I will try that next.
should be l1_reg=0
Shouldn't this be a scalar in the binary case? That's how we handle `intercept_` in the linear models.
The error message should contain the set difference, not the intersection.
The last paragraph and / or wikipedia quote?
In CPython, this `del` causes the reference count to drop to zero, meaning the object will actually get deleted. The full GC is not necessary as it only handles circular references.
could also be just `@state`
yep, that's because you don't have a block there. `all?` expects you to pass a block. you can pass a block by either using `do |foo, bar| ... end` or `{ |foo, bar| ... }`

the variable name `zoo_is_hungry` is super hilarious :D
Understood. I think in this case it makes sense to have it that way, as the XML looks "like XML" without imposing a inconvenient structure on YML/PHP users.
Since there might be multiple pending reports (Open GeoSMS or "regular"), the logic here is setting the return value to true at the beginning, but change it to false if any of the pending reports fail.  This was changed when debugging #92.  There won't be any difference if there's only one pending report though.
Good eye, thanks!
removeEventHandler only has a base implementation that returns error, guessing more implementations are on the way?
Unused call?
>fPosToNodeMap;
>fPosToLocalPartMap
>
>really need to be initialized to NULL in constructor, just in case init() never called

Like I do here, you mean?
No, process() is a virtual (prob should have virtual label), that is common placement for any master activity to do any work it needs to.
The way I did this for search was to not put the ``data`` argument here, and have ``current_versions`` only. This way that source thing is transfered to the ``Form`` class as part of ``*args``, and you can still create an unbound Form by omitting it, i.e. ``form = DailyFormBase(current_versions)`` instead of ``form = DailyFormBase(None, current_versions)``.
I think that's regression from another bug.
I believe shipping_options is called for express checkout from cart when the order does not have a shipping method set.  If this change is needed as part of this it should probably have a fallback to ShippingMethod.all.first if the find_by_id fails.
1-1-stable branch is on his way.. will sort things out this evening! Thanks for contributing!
Also this code is declaring a queue, so it doesn't belong inside the exchangeDeclare method. So it needs it's own queue declare method. Also the exchange declare method uses a flag called "declare" to avoid doing that call for every message publish call. That means your code must use a flag as well to prevent declaring the queue every time (else publishing messages will become very very slow and introduce a regression).

So in that case "declare" must be split in two variables. One called perhaps "exchange_declared" and the other "queue_declared" or something like that.
Yes, I think we should be careful about that. So, basically any widget into the Add-on bar in future shouldn't be bigger than the size of the download button (22x42px if I remember correctly). So you can still have your canvas to draw whatever you want, but in a very limited space.

On the other hand, a widget could have it's own real toolbar – in the same way now a widget can have a panel – under the regular one, that became visible when the widget is clicked. Only one toolbar at time can be displayed (so if you have a player's widget that display the current track and all controls, and you click on "memory usage" widget, the new toolbar takes place of the previous one).

If it's not clear, feel free to ask! I'm still waiting for the final mocks from UX, but that's seems pretty finalized.
Shouldn't this use the new write lock rather than plain synchronized? Otherwise one thread could set privileges to null while another one was initializing it.
I think the preceding loop won't put an entry into `rules` when the element contains no `pluralRule` child nodes (like for the first line of the XML file, which starts with "az bm bo" and includes "ja", and I happen to know that japanese doesn't really have any plural forms). That will probably cause an error at runtime. I think your `if not index in rules` clause needs to move up to live before the `for rule in pluralRules.childNodes` loop, maybe even at the top, like this:

```
    for pluralRules in doc.getElementsByTagName("pluralRules"):
        if not index in rules:
            rules[index] = {}
        for locale in pluralRules.getAttribute("locales").split():
            localesMapping[locale] = index
        for rule in pluralRules.childNodes:
            if rule.nodeType != rule.ELEMENT_NODE or rule.tagName != "pluralRule":
                continue
            pluralForm = rule.getAttribute("count")
            algorithm = rule.firstChild.nodeValue
            rules[index][pluralForm] = algorithm
        index += 1
```

(it might be a good idea to enhance test-l10n-plural-rules.js to cover this case, probably by adding a japanese example)
Probably it's about time that we implement an `aria.utils.Type.isCallback`. This check is hard to read and JsDoc might be misleading.

`Object|aria.core.JsObject.Callback` but actually we allow `aria.core.JsObject|aria.core.JsObject.Callback`

Plain objects are normalized and considered as callbacks
Do we want to do an assert for this?
I was looking at the develop branch. Master looks ok!
I'll be glad to show off my defaults today, yuhunglin. (I know there are very similar configuration tweaks available in Eclipse because I had to change them when I started on Nakamura, but I also know you're interested in making the switch.)
@shacker we should probably remove the bspace logo - we aren't using it anywhere
if null is changed to "" in getVmArgs() no need for this string manipulation
can we be more specific about the files we remove (e.g. file extension)?
Awesome, I'll check to see if you have admin acccess for simple patches.

Also, look out, @david-caro is watching.
Might as well rm the file here, too.
store_loo() returns where the file is stored.  It's always nice to print the stored path in case the module is fired against a lot of hosts... files will be easier to find that way.
Could you explain the motivation behind this?  I'm not very familiar with the code, and would like to understand what this does.
do we need to add the '/' at the end of base url?
I actually have a `Plane` object in the [polygonidl](https://github.com/AnalyticalGraphicsInc/cesium/tree/polygonidl) branch (see [Plane.js](https://github.com/AnalyticalGraphicsInc/cesium/blob/polygonidl/Source/Core/Plane.js)).  It is barely anything at this point, but you are welcome to start building on it.  Not necessarily required for this pull request.
should include an `os.path.expanduser` call to remove the `~`
Checking for getProperty() != null is more or less a duplicate check for hasProperty(). Maybe we can just get the property and check for null.  You may also want to use a temporary variable to avoid unnecessary access to the hashmap.
This suggests that it would return 'undefined', but in Android, we return null
Harold - There is a line in the greenTara fork of this file that is missing from your pull request. This is from an edit that was made after you forked the repository.
You should remove this` __name__ == '__main__' `and write a proper unittest.

If this intended to also be some documentation, consider putting it in [doctest](http://docs.python.org/library/doctest.html) format in the docstring.
use
```python
(dontcreate is None and self.cfg['dontcreateinstalldir']) or dontcreate 
```
If we make this return a deferred, can we just return the `jqXHR` object?
`s/It's/Its/`
pyflakes complains about unused variable resp. Wouldn't hurt to do a trivial check that resp == 'foo' as expected.
Oops, sorry! that should be the original line just wrapped up in a try-catch block - calling close() in certain situations can throw errors.
Isn't safe now to use String.isEmpty as that is in from java 5
Это с тем учетом, что те кто будет использовать виджет, будут выводить свои сообщения об ошибках. Может тогда давать им и код и строку `{code: 1, text: "Всё пропало"}`?
Hi Scott,

Thanks so much for this very useful feedback!  I made the changes you
suggested this morning.  Hopefully it'll be on the live site soon.  :)

Maureen

On Mon, Feb 20, 2012 at 2:07 PM, Scott Menke <
reply@reply.github.com
> wrote:

> > +                                     <p>If the sales tax in your city
> is <var>TAX</var>%, how much tax would you pay for an item that costs
> $<var>PRICE</var>?</p>
> > +                     </div>
> > +                     <p class="solution"
> data-forms="dollar"><var>TOTAL_TAX</var></p>
> > +                     <div class="hints">
> > +                             <div>
> > +                                     <p>In order to find the amount of
> sales tax you would pay, multiply the sales tax by the original price of
> the of the item.</p>
> > +                                     <p><code
> class="hint_blue"><var>TAX</var>\%</code> <code>\times</code> <code
> class="hint_green">$<var>PRICE</var></code><code> =</code></p>
> > +                             </div>
> > +                             <div>
> > +                                     <p>Percent means "out of one
> hundred," so <code class="hint_blue"><var>TAX</var>\%</code> is equivalent
> to <code class="hint_blue"><var>TAX</var> \div 100</code>.</p>
> > +                                     <p><code
> class="hint_blue"><var>TAX</var> \div 100 =
> <var>(TAX/100).toFixed(2)</var></code>
> > +                             </div>
> > +                             <div>
> > +                                     <p>Multiply the sales tax you just
> converted into a decimal by the original price to find the amount of sales
> tax that must be paid.</p>
> > +                                     <p><code
> class="hint_blue"><var>(TAX/100).toFixed(2)</var></code>
> <code>\times</code> <code class="hint_green">$<var>PRICE</var></code> =
> <code class="hint_orange">$<var>TOTAL_TAX</var></code>
> > +                                     <p class="final_answer">You would
> pay <code class="hint_orange">$<var>TOTAL_TAX</var></code> in sales tax.</p>
>
> Also, if you're using a non-integer sales tax like 8.1%, your final answer
> might have to be rounded.
>
> $45 * 8.1% = $3.645
>
> So I'd make a note to the user that they need to round to the nearest
> cent, or you can make the sales tax an integer.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Khan/khan-exercises/pull/13998/files#r468885
>



-- 
Maureen Suhendra
Khan Academy
716.703.8383
> I (partially) agree, but the main issue though is that this code relies on emplace, which, itself, doesn't actually correctly emplace that kind of stuff > anyways.
How it doesn't do it? 

> While these tests aren't actually checking correct manipulation of the structs, they do cover all of the Appender's code branches, which is already > good, and I dare say better than most unittests ;).

I'd that  "it's better but still broken" does suck. Ideally you'd catch bogus conditions then with some kind of assert and place a TODO note.
> How it doesn't do it?

If T doesn't have a constructor, then the implementation will create a temporary object, and then opAssign that to the the place where we are trying to construct our new object.

This creates 2 problems:
1. In opAssign, *this is just garbage (not T.init), which can create problems for anything that have payloads
2. Emplace shouldn't call opAssign at all anyways.
3. I'm not entirelly sure, but there might be some mixup between __ctor(S), and __postblit();

I had *tried* to fix it, but @denis-sh seemed to have a better idea then me about how to deal with this. His commits are waiting for pull.

> I'd say that "it's better but still broken" does suck. Ideally you'd catch bogus conditions then with some kind of assert and place a TODO note.

The problem is that this is a "theoretical" bug. Placing an assert could break code that otherwise (might) correctly works. It's a catch 22...
Right, but we have done this everywhere else so far. I think at least for HV we have to stick with it. I will committed the word to my memory though :-)
Verdade era isso que eu queria te perguntar.. Melhor deixar Internet? Do que Web?
not sure which one is the correct spelling or if they are two separate people
Eugh, old code. This is not actually correct, but not your fault.

The documentation for displayAccount is not very clear, actually. displayAccount is meant to only be called on successes, and the boolean is for whether the success stage was reached during Sync setup, or some other way (like sync pairing). Since displayAccount(false) is not actually used, I'm going to add a commit fixing displayAccount, and adding better documentation.

We'll display the default setup failed screen, because I don't think we have any strings along the lines of "Your account could not be created on your device."
Could you please add the {} (curly braces) to this if statement? We're trying to do this more consistently in MIS so that diffs are more clear going forward incase more gets added to the conditional in later code.
the xml/yaml mappings can re-use the same instances...
This is not equivalent to the previous validation rules
In other places, you've moved the catch on the same line as the close brace. Now it looks like there are about half one way, and half the other. Would be good to be consistent.
for-space-(
also use let
please cache chunks.length, as in:
```for (let k = 0, ke = chunks.length; k < ke; ++k)```
If the problem is that `quick_floor()` is returning `int`, it might be clearer to just add `unsigned()` around each entry.
Why wrap the value in parentheses?
I did a test:
use_sonata_admin: false # boolean false - sonata admin wasn't loaded
use_sonata_admin: 'false' # string 'false' - sonata admin was loaded
so with true, false, 'auto' is works like intended
with 'true', 'false', 'auto' it doesn't
Even though we have exactly that link in the line above it?
more of this everywhere please
the writeSkewCheck applies to theentire system and can be read from the Configuration.isWriteSkewCheck(). I can't imagine a situation(I might be wrong though) in which some instances of AbstractDataWriteCommand have the  writeSkewNeeded flag with a differen value than the one in Configuration.isWriteSkewCheck(). If my assumption is correct then the writeSkewNeeded flag should be dropped and the Configuration.isWriteSkewCheck() should be used in all the places: this would make the code simpler and easier to understand.
ok, I think I fixed all the blank line stuff.  3 between classes and 2 between methods of classes, right?
subtle thing, but checking `.count()` executes a separate count query. good if you only need the count, but inefficient if you'll be accessing the objects themselves regardless. Better to replace this with `if list(tag_list):`
but, then again, we see that there are already changes made to kwargs... must find a judicious spot for the keymaker.
Nested functions and delegate literals behave the same w.r.t. allocating closure variables.
Avoiding the allocation depends solely on the callee taking a **scoped** delegate.
Aliases to nested fields don't work.
Yes. That's what we want. That's the coding style. It's what we've done elsewhere when we've needed symbol names which match keywords (e.g. std.traits does it).
@christianv Can we remove this change?
From reading Paypal's docs, I believe the primary changes in the newer versions of the api is a change in many of the key names to a format of PAYMENTREQUEST_n_KEYNAME, to support multiple transactions per request.  There are a few additional keys, but I don't believe that anything has been removed.
Unless I'm missing something, ShapePart.GetEnumerator returns IEnumerator<Cartographic> not IEnumerator<Cartesian>, so this cast will fail at runtime.
this was made by floorman
True, but if we merged them the one big method would be a bit less readable. Also I feel like it would still be good to have a version we could just toss users to, though there's no use case like that yet.
The level upgrade will be done in horizons/world/player.py at Line 133. ;)
I might be missing something major here but... I don't get most of this connect method.

For my uses case (sending syslog messages to the local syslogd) the majority of this method is causing problems for me. Here are a few items that I just don't get...

1) If syslogd is listening on localhost:514 how would this socket ever bind?
2) If you want to send messages why would you bind and listen on a port?
3) What's the point of binding and not handling 'message' events?
Categorically this should be in lib. IMHO Helpers should be reserved for methods that directly manipulate the view or encapsulate conditional display logic, and this one marshals objects.
As this section is an integral part of the spec and not an additional "nice to have" bit of information I think it shouldn't be formatted as _tip_ but as normal text.
I think I'd almost just prefer to remove the raw=false parameter and instead just always return the URI object, and have the caller decide to use to_s or not. Thoughts?
Yeah, from the SQLCipher side, it's based on [this doc](http://sqlcipher.net/sqlcipher-api/#sqlcipher_export).
I'd simply set `$this->enable` to true.
Use `$ascp.FolderHierarchy.Enums.Type.DefaultInbox` here (see my other comment below for more details).
Nice, I missed that completely.
more-less random constants)))
For these four, might be clearer to say:

Represents a Blob that contains image data.
Represents a Blob that contains file data.
Represents a Blob that contains data.
Represents a Blob that contains String data.
Just a markdown formatting note: these are appearing as code blocks rather than bullets. To created bulleted or numbered lists, outdent the *s flush with the preceeding text.

    The value of foo...

    *   OAuth is preferred over...
    *   If a ...

Yields:


The value of foo...

*   OAuth is preferred over...
*   If a ...

Instead of:

The value of foo...
    * OAuth is preferred over...
    * If a ...
Make this file a bit more readable.  will be done in next pull request.
just $this->next, yes ?
Explicitly creating and webviews should ONLY be in one place (separation of concern). Same with being able to retrieve a list of all instantiated web views. This is magic, and is unexpected IMO.
The test worked.
The exercise asked for one comparison with three parameters. No points from this one.
`if` on tarpeeton. Lausekkeen `(== (mod n divisor) 0)` arvo on jo haluttu totuusarvo
Да, сохраняет в arr и возвращает удалённые элементы, которые мы объединяем `.join('-')` а затем сохраняем. Вот я и спрашиваю - зачем? Если хотим сохранить массив без удалённых элементов надо написать `arr.splice(j, 3); setStored(id, arr.join('-'));` и то это не нужно, потому что массив всё равно сохранится чуть позже, после того как будут применены все фильтры скрытия.