labofsahil/github-event-dataset-2012 huggingface dataset:
(to appear in 2013?) If you don't know the date, I'd just put (in press as of Dec 2012).
These mullet breaks don't entirely make sense.
nope, the useColors is mandatory, and the commented one is to disable colors when stdout is a pipe or a file, just uncomment it if you think it should work like this

On Feb 22, 2012, at 2:40, Ryan Phillips<reply@reply.github.com> wrote:

>> @@ -222,6 +225,11 @@ assert(xpcall(function ()
>>   process.argv = args
>> 
>>   local repl = require('repl')
>> +  utils.useColors = usecolors
>> +
>> +  -- if not (native.handleType(1) == "TTY") then
> 
> dead code?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/luvit/luvit/pull/133/files#r474260
не знаю. Мне кажется слишком далеко. Еще и туда - можно. Но только в трей -
какое-то говно

28 марта 2012 г. 17:39 пользователь 0xd34df00d <
reply@reply.github.com
> написал:

> > @@ -450,6 +450,7 @@
> >                       result <<
> Impl_->AppWideActions_.ActionRegexpMatcher_;
> >                       break;
> >               case AEPCommonContextMenu:
> > +                     result <<
> Impl_->AppWideActions_.ActionMarkAllAsRead_;
>
> И я бы не сюда добавил, а более глубоко. Возможно, в трей. Но не в
> контекстное меню вкладки, нет.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/0xd34df00d/leechcraft/pull/98/files#r615275
>
Вокруг блоков из одного стейтмента фигурные скобки не нужны.
Para simplificar los parámetros del action de MVC
Yes, we'll want to clean up the string handling a good deal later to make sure that we're at least UTF8-ready.
Yes wa can add some attributes to display in the anchor tag
I just added it, because I don't know how many kind of errors you want to check for.
Adapted from: http://www.marvinlabs.com/2010/10/custom-listview-ability-check-items/
I think $compile errors because of the ng-transcludes.  It doesn't know what to do.  You'll have to manually transclude the elements with ng-transclude attribute, then remove it before $compiling.
"and" appears twice here...
I'm very curious how you can make such a typo :D amazing
Should use log.debug() instead.
From here to end of method should be moved somewhere else to avoid failures here resulting in uncached cache manager which can be left unclosed if there's a failure in any of these lines.

For an example of where this should be located, see org.infinispan.client.hotrod.ForceReturnValueTest
Thanks for adding the getter and setters, but with those in place now, do you really need `amendTakeOffline` ? I think it should be removed.
From memory yes. I think it registers the projection with matplotlib. Presumably the code still runs as there are other 3d imports, but this particular import should remain and should be explicitly commented as to why it is there.
Do we normally wrap these?
Don't bother.  When we merge, it should see that the same change has shown
up twice and handle it ok.  Odd rebasing indeed...
What happens if the find element fails here and we access the text attribute on the object?
The sanitize utility function performs a different function.  It deletes files and not truncates them.  It also works on a different set of directories.
@dooremont we shouldn't be removing lines at the end of files.
May be it would be better to use matrix there and then construct features
そうですね。"tab"がいいかも。
you don't, but I like being consistent. 0em and 0px tell me what unit is intended if that value ever gets changed.
Well we need a way to uniquely identify categories. Category names aren't unique so that alone isn't sufficient.

Potentially you could maintain an ID map of: IDs in XML -> IDs in DB .. but I can see that getting messy.
We could treat a parent name+category name as unique, except thats not currently enforce in the application or DB.

Typical dupe category names would be for something like:
-Need
--Food
--Water
-Offer
--Food
--Water
The same reason - now this is just simplified to use scaleX scaleY coefficients.
This library is in no way guaranteeing backwards compatibility at this level at the current time. Nobody is really using this just yet. I plan to refactor quite a bit from where it is now.
why is this a list
This won't work if the book has more awards than in the set `awards`. This can be fixed by using `every?`:
~~~clojure
(every? (set->predicate (:awards book)) awards)
~~~
Let's add an stl tag here as well
And by that he means 12.3 ;-)
I'm not sure what you mean here exactly but I'm reasonably sure you don't mean things possessed by JData instances.
Ah sorry, I mean you can kill the blank line :smile:
probably we dont want to write query to console , right?
you can avoid parenthesis near `$object`.
Replaced with a utility method substringAfter.
It's more beautiful, isn't it?! :)
Use `fast`.
Definitely `!==`.
I am not sure about the second part. The way you put it will execute inner section only if condition is `true` (`not false`) so you are missing the case when condition is `false`. Whether this is enough or not I do not know :).
id is just 21 characters long string?
`$('#panel_form input[type="checkbox"][disabled]')` -> `$('input[type="checkbox"][disabled]', this)`
I try options['verbosity'] > 0 and then --verbosity 0 but they print a message.. so I add int(..)
*to open complete link.* (You do not have to repeat that we are confirming things here, this is clear.
Use lambda functions.
Don't go into the new line.
GET requests changed with POST requests.
Why is it `in`?
In ES6, Comprehension Block is defined as `for-of`. I'll see SpiderMonkey code and file issue if needed.
Move the comment above the function declaration.
http://php.net/manual/en/function.func-get-args.php
Working on that now and will queue it up in the PR.
id namespace einfügen
It works for bc but this should be set in the vars directly as above.
Hi
Sorry for the debug logging that should not be there of course.
With regard to the formatter interested to know the correct way.
Cheers
Oliver
On Apr 14, 2012 12:28 AM, "Sanne Grinovero" <
reply@reply.github.com>
wrote:

> > +
> > +     public OgmCalendarDateTypeDescriptor() {
> > +             DATE_TIME_FORMAT = new SimpleDateFormat( "yyyy/MM/dd
> HH:mm:ss:SSS Z" );
> > +             DATE_TIME_FORMAT.setLenient( false );
> > +     }
> > +
> > +     @Override
> > +     public Calendar fromString(String string) {
> > +             log.info( "OgmCalendar reading: " + string );
> > +             Calendar result = new GregorianCalendar();
> > +             try {
> > +                     result.setTime( DATE_TIME_FORMAT.parse( string ) );
> > +             }
> > +             catch ( ParseException pe ) {
> > +                     log.error( "OgmCalendar reading failed " + result
> );
> > +                     throw new HibernateException( "could not parse
> date string" + string, pe );
>
> use a ``throw log.couldNotParseDate( string )`` so that message
> interpolation and internationalization are an option
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hibernate/hibernate-ogm/pull/70/files#r684434
>
@darragh this is the only method we're adding to ActionController now. I don't have a problem with it but if you can think of a way to do this without adding a method that'd obviously be preferred.
no Data::Dumper import in production code
it is so hard to read the real change wit all the idiomatic fixes:)
Just a thought: the hook config is already under the `watcher:foo` section of the config file. Isn't

    [watcher:foo]
    watcher_hooks.before_start = foo.bar.baz

A bit of a DRY violation?

If not, could you give an example of possible other future hooks? And would you prefer:

    watcher_hooks.before_start = foo.bar.baz

or

    hooks.watcher.before_start = foo.bar.baz
Some minifiers damage code when contactinating multiple files. If one this is appended to has no `;` in the end such minifiers break code. Although I understand it's not very relevant in this context and I can remove it if you want.
Should this be written effectively as two similar loops:
1.times {} and
2.times {} to keep the intention clear (and similar structure)

And then these both creations could be refactored out to separate helper create_idea_with(comments:  2, votes: 1).

Please note the helper should take in also distribution like vote_distribution: 0.3 (meaning 30% of cases pro and 100%-30%=70% against). Later on the sortin test for most supported and most divided cases require these. Unless manually given values.
This condition is always true, `index` can never be `-1`
Should this check on `profiler_event_small_decl` instead? Line 95 too.
It's actually correct, except I'd move the declaration of `int i` into the for loop header because this is C++, not C89. It's looping over characters in the cameraName string. The test is checking for the null terminator.
It is better to close streams within a finally block, but that is not the problem here.
You forgot about alias which is used in more places.
roundcube_browser.prototype.set_cookie = setCookie;
Sorry I didn't realize what you meant by cleanup.
I'd like to advocate not allowing these things to be set later; that adds one more code path that needs to be tested and verified, and it could be a difficult one if a class needs to compute a bunch of radius-dependent things up front,  It also goes against my (admittedly slow-developing) goals of making more things immutable in #107.

Not having a default constructor can be a big pain in C++, but in Python, we can pass around classes as objects, so I don't think we would really gain much by allowing defaults either.
> I like the explicit parameter name references. But this first sentence reads a little funny. Like either it will create an image or it will shoot photons. :)
> 
Um, yeah, that's what it does appear to say!  Oy vey.

Fixed and pushed.
This line looks rather weird.  Maybe say explicitly why you need the ```_, _, _``` (presumably something to do with the PSF image, weight image, mask image)
Oooh, what about Martin White's lecture notes from the Sante Fe cosmology meeting?  http://mwhite.berkeley.edu/Lensing/SantaFe04.pdf (defines PS, Delta^2, explains the flat sky approx, the correspondence between k and ell, etc. - weird doesn't seem to say how P and Delta^2 are related, but it at least defines both)
I tested and this failed... on this line it should be:
    CharacterButton.BUTTON_WIDTH

Its failing because CharacterButton.WIDTH is 160, which is bigger than the image.

Make this small change it it should be good.
Removed it. Thought it would be useful for testing (since it is in the test resources dir).
super(Parse::Protocol::CLASS_USER, data)
This is a little duplicated, but that shouldn't be too big of a deal with only a couple controllers right now.

IMHO a good refactor would be to rename the `#stop` method in the controllers to `#stop!` (the bang denoting that it's unchecked), then changing the `#stop` method in the `JenkinsController` to:

```ruby
  def stop
    stop! if is_running?
  end
```

I'm going to merge the pull anyways, if you want to refactor, that's up to you :) :thumbsup:
Yes, that sounds more correct.
Can you put this in the same order as the functions in mini_bson.c please?
Could you elaborate why you are adding a new method and not use the ``offer_discounts`` property and then get the offer IDs from the list of offers? It might be a good idea to re-name this method to prevent confusing it with the property. What do you think?
this is basically the guava approach until we get lambdas :p
Programming error. This should be asserted.
While I'm commenting on this anyway, you don't need the "break;" here.
There is a comment below.
26 is damn short.  I would probably use like 32 or 40 :P
Ah, got it. That was fixed couple days ago by me - should work fine if you return it back.
Good catch! I missed that one before. It's wrong.

But this comes from another commit and better be fixed in a isolated one, to not to mix fetures and bugs.

Thanks for this! :smile:
Oh yeah, good point, any Deal created without ```:number_sold => blah``` passed to .new simply won't have a ```number_sold``` method.  Could fix it by adding a schema statement but probably not worth it.
Что будет, если на выход программе дать "1 1 + 1"
Что будет, если будет указано -u -w?
Этот if лишний.
So travis will ignore everything but test & default gems without specific environment groups.
two blank lines required here
Cause the previous one have only one screenshot :(
these in-tree builds are only used by developers. and they'll just have to pass the correct flags, and not contradicting ones (--with-external-libraries --without-external-ffmpeg)
Ok, seems like you carefully weighted alternatives and this is the best compromise. So LGTM :+1: !
:record_id => "aleph0123456789"
Should probably be added to #about-page-content instead of here
This line barfs in python 2.7:
```

self = <whenLoadingAYamlFile.WhenLoadingAYamlFile instance at 0x2ddb440>

    def testThatConfigObjectCanBeCreated(self):
      configLoader = anyconf.ConfigLoader()
>     fileObj = StringIO('')
E     TypeError: initial_value must be unicode or None, not str
```

I think you need the unicode_literal import. See the other test files.
Is the change to static necessary? Member methods can be overridden if necessary (may not be necessary here, but in general)
These should be in order, can you please order the ones that were added to the end?
This was kinda why `site` existed as a config var - so you could also set it to something with a different schema and TLD, i.e. `http://subdomain.chargify.local`.

This commit doesn't remove that ability. Is being able to set just the `domain` better than setting the full `site`?
Ok, I was not sure if in some circumstances `$this->request` could be null. I remove it
It's more polite to have everything inside a top-level dir in the tar, so when you check out you get ./socorro-crashstats:

```
tar zxf socorro-crashstats.tar.gz
cd socorro-crashstats
# WIN
```

Otherwise you get a big mess of files in your current directory.
More importantly try to break it up into functions. E.g. something like this:

```javascript

var Ajax = (function() {
    var private_variables;
    function private_function() {
    }
    return {
       public_function: function() {
       }
    }
})();

var Graph = (function() { 
    ...
})();

(function ($, window) {
    $(document).ready(function () {
        var url = Ajax.build_url();
        var graph = Graph.build_graph(url);
    });
}($, window));

```
or something like that. 
By making each sub-component standalone it's easier to split it up into multiple files or to write unit tests for them. It also makes it easier to read and debug which is probably most important of all.
Would be nice to leave this right after MWARE_HTTP_HOST, since it's frequently changed together with the mware server
Yep good idea... I'll rustle up something :-)
У тебя же вроде есть готовенький partial post, неужели он тут не подходит, чтобы его просто подключить?
I was thinking we can simply fetch the exception and print out the details that a specific test type was not found. Do you think we shouldn't do that and continue with the if statement?
have updated... the assembled params only stores the key for the param not the value
Oh yeah I understand that part. I was talking about the indentation of the code. It's not indented correctly.
Given the condition that interfaces are better to use than concrete types I am not sure if IList is the best choice for GetUntrackedFiles. Maybe GitItemStatus[] is better (as in string[] GetRemotes in IGitModule)?
This should probably be part of the Services mixin instead of copy-pasted all over.
The if condition this is in should be removed and added to the 'directory' resource so the condition does not run in compile time.  With that said, File.file?(f) should be used instead of exists.  Will add a note on this later.
It is definitely clearer to put them in place. This is both an artifact of some code I found online that I was looking at and also the performance argument if the fn is being called multiple times. If it is unlikely to be calling the function multiple times I think clarity should win.
Maybe `the level of operation` -> `an initial step`

Also, maybe add a reference for CRFs.
I would probably avoid this discussion of copying, I had to read it three times, as I thought it was something I had to do...
ugh, bad merge
这行print只对调试时有用。
I agree that we need to discuss this as a group and reach a consensus in matters of error checking.  I'm going to carve out some time to put together a write up for the mailing list to get people's opinions.
If that is the case, the code is good with me.  If it's no longer a problem, less is more, of course.
you can remove this conditional: you're anyway returning this.mapView below, so if it's null you'll be returning null :)
Theoretically, Mobile Web doesn't have to have text either, it just defaults to having text. I haven't tested setting the text to undefined (which should theoretically disable the label), so if it doesn't work then we should file a bug against Mobile Web.
Minor nitpick. If we're going to return based on a value, we can shortcut and explicitly state as such. "return [textWidgetView resignFirstResponder];" makes it very obvious that we are deferring to the widget.
True. Addressed in next update.
If you happen to do it before or on the weekend, would be pure awesomeness.  But no pressure, of course. :)
Would it be worth mentioning that there isn't a common format across all browsers, and that specifying an array is necessary in practice?
It's better that testing both `static` and non-static receivers.
```static if (is(typeof(range[] = filler)))```
> The rationale is that when you re-use a variable as such, by declaring it, and then assigning to it, you don't "special case" the syntax of the first assignment compared to that of the others.

That would make sense if you were testing assignment, but you're not. You're testing a function that uses the variable. How that variable was created is irrelevant.
We can if you want but this toolkit has been around since 2008 and has always been accessed as 'jboss-negotiation-toolkit' - that was the reason I kept the original context.
いれないコードのほうが多いと思うし、自分も書くときはいれないなぁ
Add a comment that this `keySet` is backed by the `Map`, so it will reflect the current state.
i would still prefer the use of the maven-dependency-plugin
Why did you remove this???
Good point. I think the  insertPost $ newPost myprms is pretty reasonable. (I'm not sure if it's worth the effort/making the example more complicated to do safe extraction of parameters.)
You should do the unlinking in the test so that the env file is deleted even if the test fails.
simply ``if ($config['allowed_http_methods_listener']) {`` as it will always contain a boolean
Btw you can have just one function to do all that for all `process***` functions here, like

    public function processXmlArray($xmlArray, $attribute, $className)
    {
        $container = array();
        $value       = $xmlArray[$attribute];

        if (is_array($value)) {
            foreach ($value as $instance) {
                $instance = new $className();
                $instance->parseXml($item->asXML());
                $container[] = $instance;
            }
        else {
            $instance = new $className();
            $instance->parseXml($item->asXML());
            $container[] = $instance;
        }
    }

you can use that in `processLinkNode` like

    processXmlArray($xmlArray, 'link', 'AtomLink');

In `processCategoryNode` like

    processXmlArray($xmlArray, 'category', 'Category');

You may need to tweak the method a little but that's the main structure.
all runners.
Просто страна, а не код региона выдачи
What condition is this checking?
Remember that this coding convention does not cover native functions or methods. It should cover just PHP code, not PHP itself. I believe everyone agrees that PHP itself has no naming convention whatsoever.
Can you make to variable declarations here instead of consolidating?
Rename to _container
btw, simply look at other filters to see how it is done
Insert one space after `switch`.
MINOR: pragma at top of file?
Would be nice to have comments through this to explain logic about what is happening.  This is a more complicated template that has some logic that might be modified by an admin later
why not determineScore() if null?
s/~~over~/from/
This breaks the parser because log-full-message now always has text...


		if (StringUtils.hasText(logFullMessage)) {
			if (StringUtils.hasText(expression)) {
				parserContext.getReaderContext().error(
						"The 'expression' and 'log-full-message' attributes are mutually exclusive.", source);
			}
			builder.addPropertyValue("shouldLogFullMessage", logFullMessage);
		}
We should document the change also in the HTTP Chapter.
You didn't address these comments...

quote:

Part of the reason for my nervousness here is, are we sure all the supported databases support sub-selects (MySQL does, but only relatively recently).

Hence I wonder if we should continue to distriubute the legacy message store in addition to this one, at least as a fall-back.
I understand both of your point of views and for that, I suggest to leave this function with <code>private</code> modifier. By doing this we are not exposing something that's not working and at same time we can turn it to public when they are supported.
It isn't. I chose Markdown HAML preprocessing simply because it's mentioned in the HAML reference. :) I didn't think of looking at how Markdown is preprocessed elsewhere.
@haus dealbreaker or suggestion?
Ah okay, I missed the non-development-specific dependencies above.  Yes, I agree you should move ActionPack there as well.
attempt to pull out, this pattern (of patterns) will be reused
Changing it at this point would make sense: There is no use case that can possibly want to specify an x location but no y (or the other way around). So i'd prefer condensing those two into a more common representation, as mentioned by totycro.
Comprend pas l'intérêt du en_value.

Ca doit aller dans une translation cette en_value.
Hmm, this doesn't seem right... index in the load() method as well as in the Hash lookup?
I agree - I just see some people having that field already created given
the nature of that stream. So keep it as open as possible.
	Ryan Thompson
President / CEO
AI Web Systems, Inc.
(877) 705-0806
www.aiwebsystems.com (http://aiwebsystems.com/)
---- Original Message ----
From: Osvaldo Brignoni 
To: "RyanThompson/nested_list_relationship" 
Cc: "Ryan Thompson" 
Sent: Sun, Oct 14, 2012, 1:54 PM
Subject: Re: [nested_list_relationship] Automate parent_id field assignment
and support stream_prefix for nested_list_stream (#4)
	In field.nested_list_relationship.php: 

	> + > + // If it exists, assign it to the nested list stream > +
Sthis->CI->streams->fields->assign_field( > +
Snested_list_stream->stream_namespace, > +
Snested_list_stream->stream_slug, > + Sparent_id_field->field_slug, > +
array('required' => true, 'locked' => true) > + ); > + > + } > + else > + {
> + > + // If not, we must create and assign it in one step > +
Sparent_id_field = array( > + 'name' => 'parent_id',  

	Sure. I'll do that at the end with the finishing touches. 

	This field is not supposed to be edited manually. We need that "hidden
fields" feature in the streams_core.  

	An alternative would be to create a simple parent_id field type with a
drop down form to allow users to switch the parent on a specific entry. 

	 &mdash;
 Reply to this email directly or view it on GitHub.
ditto re callback versus param
pls check again!
Perso, je pense pas que le titre soit le plus approprié
Well the build scripts are like sepearte module, they should not share code with the main application. It makes it much harder to debug if something goes wrong in shared code. Also no one expects code to be shared between build scripts and the application which could make it lot harder for someone to search it. 

I am fine with just keeping a utils file in the build script and copying code.

We currently have no good way of sharing code between the application and build scripts and I think that can be fixed as a separate initiative. If you feel strongly about this, feel free to open and issue and attach this pull request to it so we can come back to it later. 

The most important thing is that it should be predictable, I understand this code isn't portable so that point can easily be argued but saring code between the two is not easily predictable.

Let me know if you open an issue for it and then I will attach TECHDEBT label to it.