labofsahil/github-event-dataset-2012 huggingface dataset:
Just out of interest, why the limitation at 9? Is that a SOFA limitation?
Sure, that's fine, I see your point on the possible issues in duplication.  

Given this, though,when you're re-organizing the documentation, you might want to add in a simple example that makes it clear how to access these elements (feel free to just copy-and-paste my second one from above).
This needs to be updated to account for the rename from `color_text` to `_color_text`.
`enabled/0` looks *very* similar to `dtrace/1`. Is there any chance the redundancies could be merged for maintainability?
If opening the block file fails, there is something seriously wrong, and I think we should raise a fatal error or so.
Is there a need to initialize pszFile/etc to null?
The option is scheme in the tests.
There shouldn't be a space between `!` operator and `empty`
cgxp => CGXP
Ok this looks ok.
Add a todo for quarter unit
we'll need to remove these print statements
Any reason why you don't put your name here? It is your contribution, not from the whole firm. They have visibility through the emailaddress
Sorry, I was busy today. Please email me another time when you want to chat.

On Mon, Nov 5, 2012 at 11:09 AM, hadley wickham <notifications@github.com>wrote:

> In R/eval.r:
>
> > @@ -44,10 +48,14 @@ evaluate <- function(input, envir = parent.frame(), enclos = NULL, debug = FALSE
> >
> >    out <- vector("list", nrow(parsed))
> >    for (i in seq_along(out)) {
> > +    expr <- parsed$expr[[i]]
> > +    if (!is.null(expr))
> > +      expr <- as.expression(expr)
>
> Are you on IM? It's be helpful if we could have a quick chat about this.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hadley/evaluate/pull/22/files#r2033554>.
>
>
That could be more problematic given the way I'm calling it via subprocess...
This whole block should be indented four spaces so that sphinx doesn't get confused (the `::` above is OK, but the content below still needs to be indented relative to the `::`).  Dedent again when done, which would be the line that ends with `p-value:...`.
The existing filter `load_child_or_redirect` is already doing this lookup, and this will hit couchdb again. I think this new filter should either depend on `@child` already being set or both this filter and `load_child_or_redirect` should use a method that does a lazy-cached lookup (`@child ||= Child.get(params[:id])`).
I think we had some odd recursive logic going on here (which I think is unnecessary) direct property access is about 10x faster so normalize does quite a bit better with this method.
github is special some times, don't worry about it! :)
Wooow, nope. Let's make AmigaOS stick to the default cross-platform SHA1 implementation. This hack is way too ugly.
Just some error checking
php_url does a few useful things, like prefixing the URL with the current locale and such. It also gives us an easy way to track which pages are still on PHP.
I'm sure this doesn't need to be portable to systems that don't use "/" as a path separator, but path.join() is more appropriate here. Not an r-, just a suggestion.
The line above it does not test that a mail has been sent. It's the line after that checks the len of the mailbox.
RabbitMQ is definitely not required for minimal hacking. I rarely run it at all.
Not sure if we really want this change. I think having the duratino printed out for the module level should be enough. @davehunt can you please give your feedback on that?
Nit: let's keep these in alphabetical order!
IMHO, a much better name would be `CrashIDNotFound`. The suffix "Exception" is not needed. Feel free to ignore.
The argument `databaseName` is not optional so just `db = PostgreSQLManager('postgres')`.
maybe that's where that OSError leaked out from this library earlier...
Is this method needed?
Usually, everything related to expected values should be moved *after* the code tested. So in this case this should be added after the "getData" call, just before "assertEquals". Ideally with an empty line to have clearly separated blocks: initialization, execution, assertions.
Sorry should have been, `$fp`
I went to try_discard() to test something out:
````
# we never discard sources
((discard_sources)) || return
````
The default value of zero (true) in the config does work (if I tested this correctly):
````
$ ((0)) || echo 'return'
return
$ ((1)) || echo 'return'
$
````
As for backwards compatibility, we could leave the default config with true/false and then map these bools to the correct 0/1 in aurget.
Actually the old code looked suspicious to me since the denominator can 
clearly be zero when abs(y0+y1) = 0.  I didn't find a factor of y0-y1 
anywhere in those equations.  Honestly it doesn't make any since to have 
a different computation when y0-y1 is small.

I could not find a source for these equations - but I didn't look all 
that hard either.

So the bug manifested itself because somebody imported a Black Brant II 
(I think it was II) rocksim model.  This particular model has a tail 
cone and the fins match the outline of the tail cone. What ended up 
happening is the point definitions had:  y0 = .06, y1 = -0.6 where the 
trailing edge went straight back to the tail cone.  This caused the 
computation of CG to blow up with NaN.

OpenRocket does not support fins with negative y components. There are 
is no way to draw those since the freeform fin set tool does error 
correction.   OpenRocket also does not support Fins on Transitions 
(though I'd like to see this restriction go away sometime).

However, the rocksim importer allowed the fin to have a negative y 
component.  Probably the rocksim importer needed a little more 
validation - or at least a warning message.  I asked the user to edit 
points (change the -0.06 to something else close) but the UI complained.

On 10/6/2012 9:04 AM, plaa wrote:
>
> In core/src/net/sf/openrocket/rocketcomponent/FinSet.java:
>
> > @@ -440,7 +440,7 @@ private void calculateAreaCG() {
> >  			
> >  			double da = (y0 + y1) * (x1 - x0) / 2;
> >  			finArea += da;
> > -			if (Math.abs(y0 - y1) < 0.00001) {
> > +			if (Math.abs(y0 + y1) < 0.00001) {
>
> This change looks suspicious. True, there is y0+y1 in the denominator 
> of the else-clause, but I don't see any physical representation for 
> abs(y0+y1). I wonder if the equation itself is wrong? I can't remember 
> where I got that algorithm from...
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/plaa/openrocket/pull/4/files#r1779403>.
>
`hasCollection` ?
Good catch, thanks. I'm going to change this.
Regarding the way `ResponseHeaderBag` works, you're right, but what I meant was that I am manually setting it *after* instantiating the `BinaryFileResponse`, because it's the only way I have to specify a custom filename.

```php

$response = new BinaryFileResponse($document->getAbsolutePath());
$dispositionHeader = (new ResponseHeaderBag)->makeDisposition(ResponseHeaderBag::DISPOSITION_INLINE, $document->getId().'-myCustomGeneratedName'));
```

IMO, a better alternative would be passing `$document->getId().'-myCustomGeneratedName')` as an option of the class. What do you think?
missing phpdoc for \InvalidArgumentException (same on `min`).
I did not! Seems to be the best option, updated now (although we are speaking about very small time differences here, that nevertheless make a difference, given the number of executions on bigger forms).
Is there a strong reason for doing that?
Indentation off, hash syntax, quotes
Style preference for hash syntax:

```ruby
where(
  invitee_id: attributes.voter_id,
  invitee_type: attributes.voter_type,
  event_id: attributes.suggestion.event.id
)
```
vali inke faghat 2ta kar mikone be shedat zayassss :trollface:
I find this method a little bit counter-intuitive. I think it's not great that we're looking for results that we know won't exist (at least the first time) and counting on an exception to get us to a place where they do exist. Is it possible to do something like this (pseudocode):

```
def check(self, instance):
     pool = MyThreadPool()
     pool.apply(self._run_check, timeout=100) # this is pseudo-code
     pool.join() # wait for all threads to finish

     results = t.result for t in pool.threads
      
     self.process_results()
```

There's a few things I like about this approach:

- The code is easier to reason about. You start the threads, wait for them to finish (or timeout) and then process the results. You know what's running when. Everything is clean.
- If you let threads run across checks, there's no way to limit or control the entire number of threads running at once in the agent as a whole.
this doesn't look correct.  As much as a knifeparty sounds like fun....
Indeed, I first thought of "All files" but I saw "Any files" in the Qt Assistant at QFileDialog::setNameFilters(), and I thought the Qt guys know better.
"All files" certainly is better, so it should be that way :)
OK, I just pushed an update that uses YieldProcessor for defined(_MSC_VER) && defined(_WIN64), the old asm for defined(_MSC_VER) && defined(_WIN32).  Does that sound like the right strategy to you?
The sentence was a little awkward in the first place, perhaps:

```If not crs is given, the returned extent will be in this projection's native coordinate system.```?
Yes, we should probably encapsulate at least with an API if not with the gen_server itself.
After ensureEval, getReferenceKey should actually give Nothing for LazyBs.  Do you concur?
Also, please forgive us (particularly me) for this horrible scary crappy codez. It reeeeally needs some refactoring.

Thanks a lot the both of you!
As we discussed, it's nice to have full-path, explicit imports for visual-scanning reasons (it's easy to see "ah, this is from akanda" or "ah, this is a third-party library." With relative imports, that's not quite so easy to determine immediately.

Also, for long-lined imports, I like to do this:

from akanda.horizon.akanda.alias.tables import (
    PortTable, HostTable, NetworkTable)

In other words: no slashes ;-)

Thanks!
Why twitter profile use id? What the heck is id?
I see the logo & text "Kitchen" in the top left hand corner as the way to reset... If I create a query through multiple clicks while on the List page, and then click Graph to get a graph of what I'm left with, I don't want to have to create the query again...
There is a dedicated plumbing command to resolve a refspec into a complete valid SHA1.
We don't need to search for the link every time - we can just use ``@selected_item``. Also, this should only get fired for single selects.
this removes the defaults from App.js Technically we are using model : {} to describe internal models, and the defaults only if we want to set defaults. Before we were using the defaults to specify variable names in the model, in the future we would like ot hav these in the javadoc at the top of the Class file as propeties. That is a big TODO interms of our documentation for #430 this started it for the App.js
I can do that. Should I change it to a button element?
as I said, I generally agree with you for this, especially for cleaner code.

However your use case will work with my current code because all the SMS handling is done by gecko and the gecko internal database will be correct when you come back to the app.
`onRing()` is a workaround, how about `onCall()` ?
yeah, I wonder why myself :D:D:D
not intentional
why does this one have role="region" and the others don't? Because of the header?  I'd prefer to have them all the same, if possible.
ns_ -> bm_
I don't see `first-char` class being added anywhere. Do you mean ':first-child::after' ?

Also I don't understand what does these style rule do. Something special to the original key?
Cool, if it's that fast maybe we can skip this wait and go ahead with the current code :)

You trying in the S2 or otoro?

Thanks a lot!
It would be good to have a comment indicating when this code executes and why
@ochameau ,since you do not utilize `unlock` event anymore, let's skip this discussion.
@asutherland : After some implementation in resend, I think it's able to trigger "composer.finishCompositionSendMessage"  with clicking retry button in the toaster. But could we activate this api in message list view? It return some error while testing :
~
Error: Bad handle for compose done: 4
[Break On This Error] 	

address.name = module.exports.parseMimeWords(address.name);

gaia-email-opt.js (line 9149)
~
Because we already exited the compose page, is that possible to trigger message send api at that moment ?
I guess what you need is `parseInt(target.dataset.index)` instead of `valueOf()`.
see above, IIRC we use this exact code but formatted somewhere in gaia.
yay dehydrate!
I've fixed this at https://github.com/ipython/ipython/pull/1771
This function has a lot going on in it, it would be good to clean this up to make it easier to read/maintain this code later on. It seems that a lot of these (into {} (for ...)) blocks can be refactored into their own functions.
I need the code for older distros with dbus 1.2. So a fallback without the arg0namespace is needed.
Just following convention:

https://github.com/jimweirich/rake/blob/master/lib/rake/version.rb
https://github.com/wycats/thor/blob/master/lib/thor/version.rb
Did you look over the result?  This *was* a syntax error (statement
completely out of place and out of sequence), that I was fixing.  Since I
now have to rebase anyway, I'll check it all again against whatever other
changes have been posted since I made the pull req (over 5 weeks now).
Why is it safe to remove the sending of these sort records? Doesn't this break the ordering of deterministic combinators?
Keep in mind that we have never tested calling GroupBuilder methods in a CoGroupBuilder. We need to add some tests in CoGroupBuilderTests to check that this works.
Again, use a `with` block.
Not checked with statistcis module
The method 'toString' returns a String.
The variable 'value' is a Object

You cannot return an Object on a method that has to return a String.

Basically, he is first checking if the Object can be cast to a String using 'instaceof' and if it can, then he proceed to cast it to a String and return it.
I don't normally export functions unless they're ready for users (i.e. with docs and tests). for internal use I prefer calling the unwrapped function directly, e.g. `_dirs`
It is.

If ``rulesets`` go to the very end of ``css`` (and they don't have a trailing newline) this could be a problem in compress mode indeed.
page = the page from the page config, but yes w & n can be collapsed.
There are no Scala conventions :game_die:
Fichiers temporaires de GEdit
can you explain this one? We have the same issue in other place
I created a tab partial that can be used like below. Note the order of the content_for and the render partial. You first need to fill the content for the tabs and then render them together.
This won't actually activate window it will activate tab in this window.
I think naming like `destroyItemWorkerForWindow` or even `destroyItemFor` would be less confusing.
There is no need for a global declaration. Also you want to query for elements with the data-tooltip attribute.
This doesn't seem like a very clear URL methinks. Also, why would this be a route... shouldn't it be in a cron job or something? The user won't control when we fetch new marketplace data, right?
This is all commented out. You can probably just rip it out now that it's saved in a commit somewhere.
I don't see why not.  I was just copying and pasting what was already present, but I've moved them all to the parent block and the tests still all pass so I have committed it and pushed it up.
`... = RESOURCE_KINDS_TO_EXTERNAL_NAMES.invert`
Ok, I'll update this. Thanks :)
I suspect this a YAGNI situation -- can you explain why you need it?
probably you missed "self::" in the default argument value
I would prefer a positive test here like we have in the if() statement above as we're past the "input data check" point within the method.
Do not skip.
Well, I used the API.txt at the plusmid site ^_^
Any answer to this question?  Seems like you might be duplicating some level of checks that ap_some_auth_required would run below.
Someone and I appear to have dueling XML style settings - any thoughts on how to fix that are welcome.
We should be locking to specific versions of gems now, so this should be

    gem 'statsd-ruby', '1.0.0'
Could you align the `=` signs?
why creating 2 classes that are exactly the same ?
I think `access` essentially represents an interpretable expression, therefore it's not a term
prettify (see ictce libreadline easyconfig)
`konta`
they are not used *yet*, since this example project is not finished, and as a example project of hibernate4, I would like it shows some key features from JPA2 --  the type safe criteria query, powered by *hibernate-jpamodelgen*
Do you need to remove some dependencies elsewhere, otherwise, why the change?
Unless this site is still on Django < 1.3 we should be using the STATIC_* settings, and the django dev server will automatically handle this stuff for you.
Newline here. (Wanna add a space in after the comma while you're at it? ^_^)
because it is using Assert.contains rather than Assert.equals
This would break the plugin. This struct is used in Matrix4 and reflects the memory layout in the game.
Actually, same thing here. JSLint/Nodelint probably need to be updated to warn on these. I'll take that as an action to look into.
we tried that but between nova exception and the driver the data is made into a string anyway so we thought it better to use json.

Nonsense courtesy of autocorrect.

On Apr 3, 2012, at 11:01 AM, Tim Simpson<reply@reply.github.com> wrote:

>> @@ -39,9 +40,14 @@ def __init__(self, stdout=None, stderr=None, exit_code=None, cmd=None,
>>             description = _('Unexpected error while running command.')
>>         if exit_code is None:
>>             exit_code = '-'
>> -        message = _('%(description)s\nCommand: %(cmd)s\n'
>> -                    'Exit code: %(exit_code)s\nStdout: %(stdout)r\n'
>> -                    'Stderr: %(stderr)r') % locals()
>> +        message = {
>> +            'stdout': stdout,
>> +            'stderr': stderr,
>> +            'exit_code': exit_code,
>> +            'cmd': cmd,
>> +            'description': description
>> +        }
>> +        message = json.dumps(message)
> 
> This is good, but since nova/exception is being modified anyway why not just add the dictionary as a field to this type? Then rather than using json.loads you can just grab the property.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/reddwarf/pull/440/files#r639827
yeah, I'm cool with `approximateSize` unless something better comes up, I agree that `size` is wrong and `approxSize` feels lazy or something.
Because I'm still learning, and only thought of it after. However, it occurred to me that we might one day want different types of tokens for a host, so I left it in.

I can change it on Monday
it might make sense to add an option to specify the HTTPS or SSH remote instead of the default Git one
break tag, just use new lines! xD
ah, I see, I thought it was a mistake, but that makes sense.
Base address would probably be injected in the future, from a user configurable file or property.
But I understand is not part of this sprint.
shouldn't this be in the css files?
I'm basically positive that information would be lost, but seeing as the concept of serialization was just introduced recently as part of 0.6, I don't think we should need to worry about converting old data.
It might be more readable to just inline the hash you're building here, rather than add one element at a time. Like:

    result = {
      "status" => event.status,
      "timestamp" => Puppet::Util::Puppetdb.to_wire_time(event.time),
      "resource-type" => resource_type,
      ...
    }
Merged thanks! Always value your contributions, Pete.
I think the `each` call is redundant here.
space before and after equal sign
AFAIK there are no rest endpoints for making someone a tenant admin or getting a user by his username
has an additional space compared to visibility
Anyway, not a big deal. Luc, do what you think is best. :)
This comment it's completely useless, as there is another one just above that is pretty much identical. Remove it.
Yes, you're right (right now it would be `<nosymbol>`, but I can turn that into `<undefined>`).

The best way would be to have a nice pretty-printer and print the trees themselves (I don't understand why the original code uses only the symbol name, since you might have a more complicated expression that a simple reference to a symbol).
``"CC" -> CaseClass`` not needed.
The concept of "Service Pack" is changing. I'm unsure of what it is going to be used for going forward. You should double check with our support team.
We should think about changing node references to use entityreference
instead. The references module is deprecated and will go away and we'll
have a problem in the future if we don't.

On Sat, Sep 15, 2012 at 5:49 AM, Anuroop BobbyAldol Kuppam <
notifications@github.com> wrote:

> In smackdown.info:
>
> > \ No newline at end of file
> > +dependencies[] = node_reference
>
> Sorry my bad, the references module has two sub-modules one for
> node_reference and the other user_reference. These are the functional
> equivalent of the CCK modules in D6. So the dependency is named
> node_reference on d.o it should be downloaded from the
> drupal.org/project/reference
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sirkitree/smackdown/pull/1/files#r1613526>.
>
>



-- 
~Jerad
тут що?
Would it be possible to extract this code into a partial? Going to need the tabs rendering in other controllers and templates.
ya figured that out. But if we are not using it, then we should not have it in there. So, please make those changes as well, either way is fine with me :) -- using it or removing it.
Nor these.
Looks like the same code from above.
Да, моя проблема, забыл удалить.
Для вычисления процента нужно сделать наоборот: x*[tmp count]/100
лекцию 3 посмотрел олько вчера
указывать srcDNA здесь лишнее. Вашему объекту нужно сравнивать не две каких-то отдельных ДНК, а одну отдельную ДНК с собой.
Прочитайте первый массив, пожалуйста, внимательнее, там студент пошел на хитрость:

`for (int i=1; i<100; i+=2)`

Цикл начинается с единицы, а закончится на 101, но при этом за одну итерацию добавляется сразу два объекта. Цикл заполнит массив на 100 объектов.
As far as `Socket` goes, it doesn't matter if it's polling or websocket, it just needs to wait on the drain event, for which it should know what the sequence id is.
забавно выглядит, "если может создать именно этот определенный вопрос, то пусть создает другой" :)) но работать какнеш будет, просто не очень логично
I dont see this happening in the migration.
What is flag 10 here? Compare against a constant.
Unfortunately NSWorkspaceRecycleOperation didnt work :(
Prefix private methods and variables with underscore.
this is a deletion?
There are other ways to play sounds in emacs but this is one that does not introduces additional package dependencies. And everybody have a sound player for the console, so it dont feels too bad to use that.
@jwage: Was there any particular reason many of the UoW methods didn't type-hint for ClassMetadata? Is it a micro-optimization?
Should return `empty`.
It is. I should've clarified it a bit more – I'm referring specifically to the part about "flattening possibly deep recursion." That sounds like an attempt to solve #94, and I'd argue that `RACScheduler` is the wrong place to do so.
Check out [cheerio](https://github.com/MatthewMueller/cheerio) for screen scraping things. I've been recommending folks use that instead of soupselect or other things.
I wonder if `hasOptions` is necessary - rather than throw, why not just assume `null` `options` means use the default?
Thanks - fixed this test.
So one should add those also to the rest of the functions in this module, for the sake of consistency.
We'll be storing redundant information if we save the children hyperedges of every vertex. All the information about the hypergraph structure is stored in the edge.
What? No. IF DefaultCamel isn't TS, and is called by multiple Actors at the same time, then it's not TS. At all.
all of these on-hold  things should be removed.
Но зачем? И так c++0x щас по дефолту.
Необязательно, модель умная и сама растянется после следующего вызова.
Instance:runLibraryHook passes the instance to the hooks itself, no need to pass it twice.
Comment this some more.
Ya,

I was having a real pain trying to get it to pass.  If I added a beforeEach to set up the test it started breaking all the rest of the tests so I just commented it out and thought maybe we could take a look at it together.
`merge` is not a correct use, see http://docs.doctrine-project.org/en/2.0.x/reference/working-with-objects.html#
Talked with stramer on this one over IRC.
You're right. Good riddance. :)
Done and fixed a whole lot of other pep8's
Actually, one sec. The issue is different, there's no generator for 1.0.1... checking.
This is pre-Tristan's changes, I'll sort it out.
s/Calculator/FTU
note to self: this is the new way ;-)
The warning still works the way you describe. It checks to see if a staff owns the ticket and it is a staff other than the current staff, otherwise, if a team owns the ticket and the current staff is not a member of the team. If either is true, then the warning is shown.

I agree that the lock warning is likely more important than the ownership warning. Should we show both?
don't quote
Also, can you add some comments here to explain what this whole namespace is and what these numbers mean? This is the approximate average radius of the earth in meters, I believe.
@bp323 please fix the spaces here
Search for --user-style-sheet

http://madalgo.au.dk/~jakobt/wkhtmltoxdoc/wkhtmltopdf-0.9.9-doc.html
If we're going to use the library widget for groups as well, we probably need to get the principalId from the widgetData (which is now being passed in since the last PR went trough)
I'll open a new PR.  It feels like something was missed when cherry picking from https://github.com/schmittjoh/JMSSerializerBundle/pull/222.
rather use ```REQUIRE(m_dimension>0, "Dimensions must be greater than zero\n")``` here
Jo, já už na to dneska taky nemam mozek. Klidně si hraj, pak dej vědět, na cos přišel.
Dobrou noc. :-)
usually line height is 1.2~1.25 times size, what does 12.5 effect here?
Can we get here without cl having been initialized?   I'm not sure, but it looks a little strange to me.
Iz now.
Eap
hm.. If we indent this then on rendered HTML it is going to be double indented. Are we OK with this?
Are you sure ``$uri`` has the correct type as ``object<Zend\Uri\UriInterface>`` is not a sub-type of ``object<Zend\Uri\Uri>``?
Too long since I last did some C :-/
I would like to keep this as JavaScript but understand that all code samples are in CS. Switching code samples to JS
Its a 'static' method. Parsing node id must be possible even without an instance of node.
No, use window.console.log, this is better than alert. We just changed to that, so leave it there. (You can use `.debug` instead of `.log`.)
This is an implementation class - should not be in the API module.
Ah, thanks, I didn't notice that.
Oups, fixed thx.
The tuber is spawned permanently and I've got to make it invisible for the next 30secs after the boar digged out the chest so no player thinks "Hey there is a tuber, lets blow the whistle... oh, nothing there to get..."
What do you means for duplicated "queries"? I do not see any duplicated query in the resulting source file
Do you see what I did there?

![200px-Black_Flag_logo](https://f.cloud.github.com/assets/515758/29675/17188648-4db2-11e2-8c76-a9bd279ee62d.jpg)
Bah it's quite obvious tho... (6 - current day of the weak) * 86400 seconds
> I don't know you was expecting newcomers to JS contributing, so.... :)

Sorry, I don't understand that comment.
couldn't we simply assume that all those are TransferMaps? Or simply try to create one?
So you're suggesting :

     this.title = "Extension" + (rt.extension_name ? ': ' + rt.extension_name : ' Runtime '+ rt.runtime_id);
timeout_event_ = NULL?
an `else` which does...nothing? :p
Maybe add ini_get('session.cookie_domain') as default value to get()
can kernel be vectorized for x?   see question above about shapes of arguments to kernel functions.
I would have expected `build` to return an instance of `SortKey` instead of a byte array.  If you're going to return a byte array, why create an instance of `SortKey` at all?  Throughout the rest of the collation code, it doesn't look like instances of `SortKey` are retained anywhere - just the byte arrays.
Isn't Ruby calling `to_s` for you when you put something inside `#{...}`?
@timothyandrew, no problem. You can even store that block in variable, pass it around into other methods several times and it still will be able to reference the method and both arguments you need. That's an incredibly powerful feature of Ruby blocks.
You might need to select a different variable name other than $package, since the @foreach loop here will replace the $package variable.
Nvm, just saw that the other sharedLink call does validate.
I adjust the plugin description wich use now the link to the packages.
Despite the fact that most RadialProfiles have a half_light_radius, I don't think this should go here. 

First, Moffat and AtmosphericPSF override this.  Probably not usually a problem, but maybe a problem if someone decides to use a Moffat as a RadialProfile?  Wouldn't this version get used rather than the one in Moffat?  I don't really know how python resolves overrides of derived classes, so I could be wrong.  

More importantly, I actually find it more confusing in the classes that have a normal half_light_radius, but rely on this definition, since the others (fwhm, scale_radius, etc.) use this explicitly.  So you have to kind of remember that this is here so you don't need it in the derived class.  To me at least, this makes the derived classes more confusing to figure out.  So I'd rather just see these three lines duplicated in each of the derived classes that have a normal half_light_radius.

Finally, (and a minor consideration) I would switch some of them from having half_light_radius be the primary size value from which all other sizes are defined to using whichever is the most natural for that profile.  e.g. switch to sigma for a Gaussian, and scale_radius for Exponential.  Then I'd define half_light_radius in terms of that.  It seems like that is the more natural way to think about the class, so would ease maintainability.
Yeah == is indeed fine :-)
Concur.  Unqualified exceptions are evil and we need to root them out of our code base.
If we are indeed decoding the field pairs, the `search_doc()` type spec should be corrected to be `[ {binary(), binary()} ]`. You should also check that the `#search_results` record field is typed correctly.

Also, do we need to include `Index` in the results? I'm not sure.
$runDir doesn't look right.
Technically yes, but since `typeof null == 'object'` I think this clarification is needed. :-(
This test is probably not enough, but we don't have a lot of test servers. I am thinking this test is good enough for now.
This method doesn't exist. I think it's referring to `click_update_button()` but then that's misleading because the button on the page is named 'Next'
As zac was saying you'll need to work with Select elements, here's an example on how to: 
https://github.com/mozilla/Socorro-Tests/blob/master/pages/crash_stats_page.py#L104
Test comment: Please change this title.
не бачу сенсу
On Thu, Feb 23, 2012 at 7:17 PM, JugglerShu
<reply@reply.github.com>
wrote:
>> @@ -44,12 +46,23 @@ - (XVimEvaluator*)y:(id)arg{
>>      return nil;
>>  }
>>  - (XVimEvaluator*)w:(id)arg{
>> +#if 1
>> +    // question: when is this executed ?
>
> I think this code is not executed.
> ( they are just a garbage code which was used before)
>
> I want to clean them up and make the relationship between Visual and Normal mode robust.
> I mean the shared "motion" should be coded somewhere else...
> NSString+XVimOperation.m is the place where I intended to make code for this. (Should it be NSTextStorage category or totally other things? )
>
> Sorry I have been very busy for my main job and can't have time to code for XVim much...
>

No apologies necessary. I'm happy to have what's there. I'm
semi-retired and decided it would be fun to learn a bit of cocoa / osx
/ ios programming. I"m really used to using vi though so it let's me
learn a little bit in that area and gives me an editor environment
that i'm partial to. Hopefully we both benefit in the end..

-mike
Why do a relative path here and not an absolute one? Looks like some urls in this file use absolute paths and some use relative paths, but I don't understand why.
why not keeping it in the ``else`` ? it would avoid doing the check when unneeded (i.e. when you already checked before or when you retrieved the type from the factory)
Needs authentication.
why doing the injection of the deps by hand ? This is what the container is for
like now?
its the same slip.ogg that is normally used for wet floors. A lot of the time I've noticed that .ogg files that are less than 3 seconds long don't like to play correctly in VLC or other media players.
Very generous of Riot
Do you really need to hold onto the entire response? All we care about is the expiration (which you're already tracking separately) and the actual token.
I'd expect that because it is a test in the pipeline, you could add another test wrapper to the pipeline in your test to inspect the headings that were added.
That isn't the case for all the other classes though; very few of them will be affected in this way.
I will remove the unused MockUser option
We can add it later

On 10/19/2012 05:35 PM, Dave Hunt wrote:
>
> In pages/mobile/base.py:
>
> >              return True
> >          return False
> >
> > +    def login_with_user(self, user = "default"):
> > +        """Logins to page using the provided user
> > +        """
> > +        if isinstance(user, MockUser):
> > +            bid_login = self.footer.click_login_register(expect='returning')
> > +            bid_login.click_sign_in_returning_user()
> > +
> > +        elif isinstance(user, str):
> > +            bid_login = self.footer.click_login_register(expect='new')
>
> Actually, bidpom defaults to new user, which is the sensible default I 
> was alluding to. I still not clear why you're setting it at all, or to 
> 'returning' when you're using a MockUser. I also still don't see 
> MockUser being used anywhere in this pull. I don't see why using a 
> MockUser should differ from using a string.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/mozilla/marketplace-tests/pull/158/files#r1890450>.
>
``-0.5``
indeed this line does not make any sense if dual gap has not been computed.
Already fixed locally.
I am also -1 on duplicating all the estimators

I'd rather have a common way to assess if the estimator expected pairwise input so it can be checked in GridSearchCV and cross_val_score.
On Sun, Dec 30, 2012 at 5:45 PM, Andreas Mueller
<notifications@github.com>wrote:

> @dwf <https://github.com/dwf> how can you use the free energy to judge
> convergence?
>
I don't think you can, because that unknown constant is not actually
constant with respect to learning (the partition function is always
changing). Average free energy of training data minus average free energy
of validation data might be a useful quantity to monitor (basically the
"odds" of training vs. validation, such that the partition functions
cancel) but I haven't tried it.
oh by the way: is this not afterwards overwritten by the `locale` field of the form, if it is non-empty? could we not just default the `locale` choice to the request _locale instead?
It was not a very meaniful variable so I wanted to improve readability (through shorter lines). As it is returned from the function, it's purpuse becames very clear. Tought the comment saying what it was actually needed as someone could get confused at first glance.
Do we need this function somewhere else? If not why not declaring it inline in forEach? Also please add a blank before the opening '(' bracket.
Shouldn't this be:

```d
static assert(is(X5 == int));
```
Is args[0] guaranteed to be non-NULL?
The same comments for this block. Here we also adding created controls to the ones we already have in the, but didn't reuse them. Seems we have leaks here of the row we never clean up.
Also some changes from client to created rows I suppose won't affect these ones since they are not referenced anymore.
I think this should be nested inside a _response_info node
I think we're digging ourselves our own tombs with this. Not sure if it should be handled in this PR, but do you agree that we should stop doing `"doctrine.eventmanager.{$this->eventManager}"`  and instead allow entire strings?
Since opts.query has been tolowered() at this point, I don't think we need any special logic for case-insensitive search.
Can't you join them two? Also, shouldn't this be recursive?
If you intend to expand this to Zip files (and so on), this logic should not be in a filename called ```gitfile.cpp```. Otherwise, a simple ```isGitFile``` would suffice.
I doubt you will ever see these operators in this dumper.
Return type should be rowidx_t
`alt="Loading..."`
make this more specific. this pulls the entire page and looks for the text you provide. so if the word you are looking for is SMS any instance of that word would yield a true. What you really want to verify is if text appears in a specific location. Thus a more specific location specific verification would test this better. 

try something like: 
@FindBy(name="mytext")
   private WebElement myText;

public boolean verifyTextIsPresent(String expectedText){
	if(expectedText.equals(myText.getText())){
			return true;
		}else{
			return false;
		}
	} 


Lastly you don't need to pass the driver around. It's visible from anywhere.
It has the same purpose except it don't raise errors if you try and use string functions on it.
Hmmm, this double II could be confusing. What about calling it InfinispanExample?
@jordanbyron good feedback.

The participant name comes from the fact that we were toying with renaming `CourseMembership` to `Participant` but decided not to. I'll rename that.

The `StudentTask` idea is an interesting one that, as you say, might consolidate the code from 2 or 3 classes. I see this class as a non-persisted model. Do you agree? Also, I think we'd then need a `StudentTaskDecorator` because `#status` and `#complete_task_link` are presentation logic. 

I'll play with this in our repo and ask you to review a pull request.
Is it worth checking whether it has already been started?
Good suggestion, thx.
This comment isn't really that helpful, but a comment or docstring about the function itself could be useful. something like:
```python
"""Return image with each channel smoothed by a Gaussian filter."""
```
Can you add a test for this description? Calling `join` on a string (like result) will fail.
It was supposed to gitignore my gitignore but clearly it did not !
The previous message mentioned to use this gem -- don't use the one on rubygems:

  http://dl.dropbox.com/u/6758584/rdio-0.0.98a.gem

instead of doing:

   resp,data = access_token(requires_auth).post url,new_args
   return data

I'm doing:

   return access_token(requires_auth).post url,new_args).body

This would fix it, because 'data' would always be nil in your case.
If this does in fact fix it and other people are having the same
problems, I'll push this.  I pushed one last night, so I can wait
until there are more fixes I'd prefer that.

On Sat, Mar 3, 2012 at 5:24 PM, Scott Hyndman
<reply@reply.github.com>
wrote:
>> @@ -299,8 +299,7 @@ def call(method,args,requires_auth=false)
>>        if Rdio::log_posts
>>          Rdio::log "Post to url=#{url} method=#{method} args=#{args}"
>>        end
>> -      resp,data = access_token(requires_auth).post url,new_args
>
> Running against the latest on RubyGems, I except with the following stack:
> /Users/scotthyndman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/json/common.rb:148:in `initialize': can't convert nil into String (TypeError)
>  from /Users/scotthyndman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/json/common.rb:148:in `new'
>  from /Users/scotthyndman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/json/common.rb:148:in `parse'
>  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/base.rb:348:in `unwrap_json'
>  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/api.rb:429:in `search_json'
>  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/api.rb:370:in `search'
>  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/types.rb:672:in `search'
>  ...(application code)
>
> My Gemfile.lock:
> GEM
>  remote: http://rubygems.org/
>  specs:
>    activesupport (3.2.2)
>      i18n (~> 0.6)
>      multi_json (~> 1.0)
>    addressable (2.2.7)
>    awesome_print (1.0.2)
>    chronic (0.6.7)
>    faraday (0.7.6)
>      addressable (~> 2.2)
>      multipart-post (~> 1.1)
>      rack (~> 1.1)
>    i18n (0.6.0)
>    launchy (2.0.5)
>      addressable (~> 2.2.6)
>    multi_json (1.1.0)
>    multipart-post (1.1.5)
>    nokogiri (1.5.0)
>    oauth (0.4.5)
>    rack (1.4.1)
>    rake (0.9.2.2)
>    simple_oauth (0.1.5)
>    twitter (2.1.0)
>      activesupport (>= 2.3.9, < 4)
>      faraday (~> 0.7)
>      multi_json (~> 1.0)
>      simple_oauth (~> 0.1)
>    whenever (0.7.3)
>      activesupport (>= 2.3.4)
>      chronic (~> 0.6.3)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spudtrooper/rdiorb/pull/7/files#r515076



-- 
Jeffrey Palm --> http://jeffpalm.com
Nope, I'm using 0.4.5.  I'm not sure where this is coming from, I'm
using the same versions.  I've made this change and committed to git
and put a built gem here:

  http://dl.dropbox.com/u/6758584/rdio-0.0.98a.gem

I pushed a version last night, which probably didn't warrant a push,
so I don't want to push another unless more people are having this
problem.

Anyway, let me know if this fixes it.

On Sat, Mar 3, 2012 at 3:44 PM, Scott Hyndman
<reply@reply.github.com>
wrote:
>> @@ -299,8 +299,7 @@ def call(method,args,requires_auth=false)
>>        if Rdio::log_posts
>>          Rdio::log "Post to url=#{url} method=#{method} args=#{args}"
>>        end
>> -      resp,data = access_token(requires_auth).post url,new_args
>
> 0.4.5. Are you at 0.3?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spudtrooper/rdiorb/pull/7/files#r515005



-- 
Jeffrey Palm --> http://jeffpalm.com
I think you guys are way over-thinking this.  Standard JavaScript convention states that private things in JavaScript, variable or method, have a single underscore in front of them.  I see no reason to deviate from that practice.

So then you have a case where you have one object that once to access the "private" member of another object.  This is generally bad and should really never be done without a really good reason; otherwise it shows some sort of flaw in design.  In these cases the easiest thing to do is make the thing public.  For example, I see no reason why "collection" shouldn't just be a public read-only member variable for Polyline.

There's another aspect to this particularly issue you're missing; Polyline has an "internal" constructor and the only "correct" way to get a Polyline is to have the PolylineCollection create it for you.  So in that way, Polyline is a wholly "owned" class of PolylineCollection and the sole reason PolylineExists is to put data into PolylineCollection.  In that way, it's perfectly fine for PolylineCollection to access private members of Polyline because Polyline is not intended to be used stand-alone or by anything not just passing them to PolylineCollection.

As I said, in this case there's zero reason collection shouldn't just be a public read-only  variable on Polyline; otherwise I don't think we need to invent our own naming conventions for concepts that don't actually exist in Java, pretending these concepts do exist leads to poor code.
Don't worry, it still has the ability for both URL and event name to be time-varying.
I agree with your questions and the answer is, I don't know; but I can't think of a better logical organization at this time.  The strategy I use to help combat some of these questions is to put `@see` links in all of the constructor documentations that list all of the `from` and `compute` functions.  So if you look at the constructor for `Matrix4`, you will instantly see all of your options for creating a `Matrix4` instance, regardless of the name.  I think this is a good strategy to follow in all of our types.  My vote would be to leave the `compute` functions the way they are for now and if we think of a better solution or get a lot of questions about them, we can change them later.
Wow, this looks like some hacked code I wrote a while ago.  This is for supporting CZML points, right?
Change "validate" to "valid".
I think a saner default is `/usr/local/bin`.
Ok, will change. But I think we should revisit the convention - we're fighting our tools. Either that or we need to get the VS "Add Class" item template to put the usings inside the namespace.
Good point. I still feel uneasy about this, but it wouldn't be a regression if -- do we even have any production modules out in the wild?
Why -1? Seems like an arbitrary value.
We should probably call resetPostAnimationValues() on Top/Bottom/Left/Right/Center as well since they all trigger a layout pass.
Insert newline before KrollDict data =
Dislike the substitution of language -> JS. "JavaScript" would be acceptable.
not in a position to test right now, hence relying on feedback from you guys.

CGI.escape should do the right thing according to what I found but its a pita getting right
That hanging preposition ain't pretty. I was trying to get away from that. 

Maybe this fixes it: "...which you can then view, modify, and remove." That covers "operations".
So here's the trick:

    ref inout(T) refCountedPayload() inout { ... }

The second `inout` doesn't qualify the function but rather the `this` reference, thereby effectively making a parameter `inout`.
no need for the numbers
> Using http://dlang.org/declaration.html as a reference currently.

Oh, I found a documentation bug in website.

```
BasicType2:
  ...
  delegate Parameters FunctionAttributesopt

FunctionAttributes:
  FunctionAttribute
  FunctionAttribute FunctionAttributes

FunctionAttribute:
  nothrow
  pure
  Property

Property:
  @ PropertyIdentifier
```

In current spec, delegate type declaration cannot have postfix qualifiers.
I think `BasicType2` should be:
```
BasicType2:
  ...
  delegate Parameters MemberFunctionAttributeopt

MemberFunctionAttributes:
  MemberFunctionAttribute
  MemberFunctionAttribute MemberFunctionAttributes

MemberFunctionAttribute:
  const
  immutable
  inout
  shared
  FunctionAttribute
```
Just declare it with no body.
If the controller actions are removed from the NodeBundle we should also remove this entity
This works  too.
Should REST be capitalized here (nd in the form)? For example:

Click on `REST Invocation Test` link. The REST response is displayed on the iframe below.
Why is all this code commented out?
I'm curious; isn't a failure of this method rather worth an exception instead of returning null? But I'm opened for corrections :-)
These lines caused [OMERO-merge-4.4/61](http://hudson.openmicroscopy.org.uk/view/4.4/job/OMERO-merge-4.4/61) to fail.
Why can't this be done automatically in this code?
I had the problem recently again when testing this version of the code. When ghostscript isn't installed, it fails silently. So we should definitely do more error checking here !
I think we decided that using IDs in the tables is a huge hassle.

See [here](https://github.com/CS169-Raxa/raxa-visualizations/blob/dc6f78bd2ff169a57b8017415c3a9043cc53b212/features/registration/patients_table.feature) for the table format we've agreed on.
I think you should still use "$this->" here.