labofsahil/github-event-dataset-2012 huggingface dataset:
I think we should have each DaemonToken point to the module it is for. We won't use this yet, since all modules get full privileges, but it ensures that we architect this so that someday we can have different privilege levels for different modules.

I suspect this means the map of DaemonTokens should be in ModuleFactory (or wherever we keep the Maps of modules).
How are you proposing this bee done Seth? I know it would be something like:

{<<"password">>}, {fun_match, password_length_check()}

...

password_length_check(password) ->
   Check length how? Presumable not use a regex, so use what? byte_size > 6 ? Something else I don't know about? I'm not sure what the best way to check a binary string's length is in erlang, especially taking unicode into account. Any advice is appreciated.
What uses the cert?
Your indentation is fine so far. 
I generally use a 2 space-indents.
I had to create env files myself because generator spec will only create Refinery's files.
Surely just delete chrome is enough?
I think this will become one big sentence.
@jeanmonod Yes, you should create a PR with `2.0` information, @weaverryan will merge that in to all 3 branches. After that, you create your second PR where you add the `2.1` information (with the versionadded notes) into the existing docs, which are merged by ryan. He merge it again and you create your last PR on top of that for `2.2` (with versionadded notes).

Please note that you need to create a PR against the correct branch, you have `master` now and that is incorrect.
I think we can beter do something like this (as this is more compliant with [the PSR-2 standard for multiline method arguments](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#44-method-arguments):

    if (
        $request->attributes->has(SecurityContext::AUTHENTICATION_ERROR)
    ) {
A way to get the full number of tests loaded before they are executed.
Okay, we don't have that right now. Created a ticket for that: https://github.com/jquery/qunit/issues/350
Can you connect when already connected?
Why log and rethrow?
You always create a new CA store this way, even if the CA chain is empty.
Perdón, no lo entendí, me podrás pasar un ejemplo?
Your own copyright?
So you can't instantiate it.
why not removing an imbricated `if` ?
Still need it to default to chocolatey as a source...
it actually provides several mixins :)
I'd rename this to `sanitize_name`, better description
I'll be more accurate in the javadoc
attention le texte est en anglais
But there is currently no rc param for this, nor is there one proposed. Would adding an rc param be a more useful review action?
I know you wanted to make it a docstring.

<img src="http://i.imgur.com/3yvA0.jpg">
I would suggest a browser subdirectory, but can be done later.
Consider reducing the round trips to the database by merging all of these into a single SELECT statement.

e.g.
````
$sql = "
  SELECT
    (SELECT COUNT( 1 ) FROM cts_reservation) count_of_reservations,
    (SELECT COUNT( 1 ) FROM cts_reservation_equipment) count_of_equipment,
    (SELECT COUNT( 1 )
    ...
  FROM DUAL
";
````
This precondition re both-preds is not a good one - we want these values to increment past 1 as needed.
Can you also remove the reference to this file in `tests/qunit/js/dev.js`?
Should be oae- as well. I'll fix.
@bp323 - Since this selector is empty, can we remove it?
@bp323 Sure, should be fixed in a follow up commit.

I also saw that there were a couple of merge conflicts (after the config.json changes) so I fixed those.
Oops, that was not meant to be committed - I was keeping track of open issues while refactoring and failed to clean up my notes to myself.
```
SG_ADD(&m_machines, "machines", "Machines that jointly make up the multi-class machine.")
```
@willrossi Renaming the class from "CompositeField" to "composite-field" will stuff up a lot of existing CSS.
At the least, this makes the commit an api change. The class is used often enough that it also warrants an entry in the 3.0 upgrading guide I think, particularly since it "silently fails" (layouts will just look broken.
any reason we need to delete the images each time? thinking with many images potentially > 1mb each, this could be a bottleneck since we run it every hour!
I ended up making a change to not detect or ignore any last resort fallback sizes unless the webkit bug is present in 4e829cc.
Definitely worth looking into for the next iteration :)!
looks like something is missing in this line
Alright. Why should the check be in the function? It doesn't seem logic, to me.
button
done....OTL
Didn't see a point to having an empty line at the end of the file.
Are you sure you can call ``rand()`` with the given parameters? It seems like at least the 1. parameter (``$min``) is missing, no?
- Please always use braces to surround the code block of IF statements. Please also check line 128.
- Are you sure ``$options`` has the correct type as ``string|array|object<Zend\Config\Config>`` is not a sub-type of ``array|object<Traversable>``?
`el` and `i` needn't be declared in this scope. They exist within the scopes of the nested functions.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/11/2012 05:37 PM, Diego Zamboni wrote:
>> 
>> 
>> +    vars: +        # Contents of the ifdown-up script +
>> "ifdown_up_script" slist => { "#!/bin/bash", +
>> "/sbin/ifdown $1", +
>> "/sbin/ifup $1", +                                    };
> 
> Defining this as an slist is a bit dangerous - if, for any reason,
> the script got modified to remove the "if down" line, then ONLY
> that line would be re-added, but at the end. I think it would be
> best to provide this script as a single string variable, and to use
> insert_type => preserve_block so that it's added as a whole.


Yeah, im using edit_defaults => empty but a single block string is
probably more correct.

Any idea why cfe stops executing after the interface is downed?


- -- 
Nick Anderson <nick@cmdln.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPhtD2AAoJECdDoJhdeUpaFt8H/0bmCsdvmY0GBmWFybUC2aCl
l/JTBJHO9mxfkw/ZqzAwgrUUouHbKUSzDiQ/NHFMzBymojRvzlUdu44NeqbWcjV5
34IyEd7TQb5cbkFY9btG4CFkD26cIolxNdq7HQloeh53gk6IRndaLpsyTfpBVge/
Ief0CIb7VgotzPFEc1dJ8kT+rKOSlSHLIuJvMV0FtGWmW4+FdA+z7Y3YtLzibioK
MRazU0otcIH3qKOJFZ5EQPRLSfAyzi9cJ/rZq4N0H5jsVM998j3VydZ+yLx+Bm/H
t4Vzbn2TOCl7qpVGSLw41swfvl0K53ScKi95xmUks3UZ5ZdgNJ0Wd4uH8B907zg=
=RQhu
-----END PGP SIGNATURE-----
I was actually getting errors about userList not being defined, which is why I added this. I don't recall the situation that was causing them, unfortunately.
Указывать следующие теги в phpDoc аннотации (return, param, throws)
The jimport for JUri isn't necessary anymore.
For this, you could use `data()` on DOM.
OK. I see now that you made it differently than I imagined. ;-)
Yah, I'm referring to the contents of the `build_authorisation` method - the hash being passed to the `xml.tag!` method looks odd. At least I think it's a hash; I can't figure out how to parse it, so I'm not sure :):
and u prefer what and why?
I'm just worried about it changing.
It will minify to one char anyway, so better to be succinct ;)
I actually thought my change made it cleaner...Look at how wonky it was before. I can change it but before the braces aren't aligned at all and windw isn't indented.
I think that language should be passed as an argument. But for backward compatibility it can be optional.
missing space after the typecast.
@lkazus you need to check the return value
> Hibernate OGM will not use a single Cache but three,

I think this whole paragraph should be its own section at the same level as " Infinispan specific configuration properties". It is quite important information and disappears atm into almost a "side-note"
Surely filter gt, not gte (as per my original code), unless you exclude the current object.
Find could return null, but WasNotAlreadyHandled does not check for null
This could simply be `if (typeof rough_cell["get_" + prop] == "function")`.

Maybe also
```javascript
var getter = rough_cell["get_" + prop];
if (typeof getter == "function")
  rough_cell[prop] = getter(services);
```
Looks like albedo can potentially remain zero. Does that make sense?
Kill one of these newlines.
Can we leave off the trailing slash here so that in the rest of the variables that follow we can be explicit with a slash separating the variable and the path?  You are right that they should be escaped.
How to import only module and not content? I've googled it but I couldn't find anything. :/
You do not have to override template name? Rather more template file into default location.
Ugh my python snuck in but should probably stick to coffeescript/javscript styles. :smile:
Am I being totally dense, or is this a square region?  (If so, I was a little confused by the mention of R at line 390)
忙撸。
I'm a big fan of *not* having commented out code. Much better would be a TODO, to say that we could add isLast and some appropriate refs/links.
The commented out code just confuses people later because they don't know why it's commented out, if it ever worked, etc.

My rule of thumb is that the only time commented out code is a good idea is if it's a block that can be accompanied by a helpful TODO/FIXME comment to say what it's for and why it's commented out, plus it's going to be needed soon. If it stays commented out for more than a few weeks then it should usually be deleted as it will be getting more out-of-date and usually just becomes distracting clutter for future developers...
don't think jclouds is using that, and this code may eventually find its way there
Do we want to ensure that all of these machines are known about (e.g. check if they are in `detected`, or perhaps add them but less sure about that)? Or is it safe to add any nodes passed in?
log message looks wrong: `log.debug("Loading class for item {}", item)`
"(we will see the same-origin policy implications and how to solve that a bit further)" -> "(we will cover the impact on the same-origin policy later)"
`save!` again
You might want to format the time, else it will be too accurate ("1234.132837632476 ms")

One way to do this, is to use printf-style formatting:

  # This is one Ruby idiom for calling sprintf
  log_string += "request time=%.0fms" % [time*1000.0]

  # This is another idiom (Kernel#sprintf)
  log_string += sprintf("request time=%.0fms", time * 1000.0)
Nitpick: I'd name these createRoom() and disbandRoom(), it took me a while to figure out they were static methods on this class and not an enum or something (since we usually use capitalized names for classes/enums not functions)
Which ones are you referring to? Should we do a move of some files in the repo?
removing it causes guzzle test case to not be found, basically its the autoloader for the guzzle test case classes
It turns out that the "inline" comments which I added along with the new includes at the top of setlock.c (86b2742) also break makemake (the "compile setlock" line gets mangled by the inline comments), so as a rule inline comments in the source are bad news even if you're using a modern C compiler.
What's wrong with multiline comments?
Oh I see they all have this.
Выводить результат надо без этих преобразований. Т.е. если в файле есть "Привет", то надо выводить именно "Привет", а не "привет".
Making assets pipeline happy to be able to run locally.
`/public` is required for webapp specifications anyway to do with security around proxying.
assert the app name here and see if we are back to the correct app
"the common" rather than "a common"?
To show that you can comment on a line by line basis on the diff
It's not a depreciation warning so much as a "you're using this wrong" warning - I wouldn't want this quashed by `ActiveSupport::Depreciation` behaviors that ignore depreciation warnings, on the other hand the more that I think about this - the more that I think it should probably just raise an exception.  i can't think of any reason why you would ever want to do this.
This turns out to be an awesome paper on the topic:

- D. Kroon, 2009, Short Paper University Twente, Numerical Optimization of Kernel Based Image Derivatives.

We can implement those, and set N to 3 or 5 by default.
Please add 'author' information: get credit for your work. You don't have to add your email address if you don't want to.
Well, it is called a pre-pruning method in the literature.
We've done this in several places already. I consider the `LabelEncoder` an implementation detail; exposing it makes it expensive to switch to a `LabelBinarizer` when the need arises.
maybe call it ``logistic_sigmoid`` as ``sigmoid`` just refers to the shape....
Is the check for really necessary / useful? Besides that y is small compared to X, (np.asarray:
Convert the input to a `chararray`, copying the data only if necessary.)
These last 4 lines should probably be refactored into a helper function too since we use them at the end of every command so far.
This is fine. I just copied the restriction from our code.
`Hibernate Search` (both have capital letters)
Not new, but is this is safe?

Perhaps port is never used, but if it is, there might be access proeblems with ports <1024
and min(n, numrows-end) would copy the wrong amount...
Well the comment lies a bit.
The writer and spilling thread can alter, which are ensured to be mutually exclusive at this point.

(getRowClear, called by spillHashTable, called by spill request OR writer)
This was originally (findCluster() == 0) 

i.e. does it match the first (and only) cluster

Renato has agreed and is going to change the line/comment
I may have a go at changing this function a little so we don't directly switch on class type. Hope you don't mind :)
what you are removing are double separators, not double slugs
No. That's why we exactly have this if condition. If you specify the binary directly we retrieve the .app bundle.
this s wrong
Unneeded code I forgot to remove
Magic Number .. seems to be the same .. use constants
@shacker @yuhunglin we should also update our Sublimelinter jshint options to use these
@shacker I think they do this for the conversion from XML to JSON. Sometimes it's really hard to tell whether it will contain multiple items or not.
I've never been comfortable sending the whole params hash down to a model's method, especially when we are only pulling 2 values from that hash. What do you think about changing `Discussion.search` to explicitly require `state` and `category` eventually an optional search criteria argument?
Would be useful to do a report_service here? To be sure to report it in case digi_realport_version isn't used.
RHOST, VHOST, SSL* should all be registered by HttpClient already.
$() syntax is specific to bash.  Use ticks instead.
I prefer 

if !datastore['DOMAIN'] 

but whatev
Actually, my bad. I just realized my test machine isn't a domain controller.  There is a way to check if the machine is a DC or not though... if you want me to add that check.  I'll just borrow from enum_domain_tokens.rb.
It's for the case where the labels array has non-consecutive labels (like 1, 10, 200 instead of 1, 2, 3). But it can be tested anyway, which would remove a keyword. I'll modify this.
I'm not quite sure what's going on here. Is `__all__` supposed to prevent the module names from being added to the namespace? On my system, they still appear. Also, shouldn't `__all__` be a list of ``str``?

The naming for `felzenszwalb_segmentation` differs from the others (none of the other functions have the `_segmentation` postfix).
Yes, that check was removed intentionally.
On 28 Feb 2012, at 15:11, Joel Tosi wrote:

>> + * @author Joel Tosi
>> + * 
>> + */
>> +
>> +@Named
>> +@SessionScoped
>> +public class Email implements Serializable {
>> +	
>> +	private static final long serialVersionUID = 1544680932114626710L;
>> +	
>> +	/**
>> +	 * Resource for sending the email.  The mail subsystem is defined in either standalone.xml or domain.xml in your 
>> +	 * respective configuration directory. 
>> +	 */
>> +	@Resource (mappedName="java:jboss/mail/Default")
>> +	private Session mySession;
> 
> Hey dude, I go back and forth on this one.  To me, the quickstarts are about 'the simplest thing that works'.  To me, adding an extra class kind of detracts from that. Are you ok with not adding this?  Your call boss

I'm happy either way.
can we not use the new assert_unprocessable here?
Is this a typo?  Nothing is really "refreshing" here.  What happens if this is turned off?  I guess it just ends up scaling the canvas?
adressed in 8eb2104bfcc02435ff2acc8c95bdd75c5c25b5e3
Okay, this scares me. ReloadData is VERY expensive and worse yet, has in the past stomped on interface state machines and caused tables to become unresponsive. Are you sure reloadData is needed?
Nope. This is removing the overridden toImage method in View. 

I added periods to the ends of a few summaries at the same time because I run the validator in strict mode and it complains about them.
...to the inactive state_, and fires the `pause` event. The system then displays an alert to the user._ The app remains in this _state_ until the user _dismisses_ the alert.
Looks like we no longer have this image on our website. This fixes the broken image in the README on github.
It's different on mobile web - touch starts > scroll starts > scroll ends > touch ends (not cancels)
Width should not have a default value, i.e. it should be read back as undefined. Instead you should set the _defaultWidth property (and not in the constructor).
Sure that is an easy change
лучше лишний раз не алертовать, а выбросить TypeError
I just commented on and starred:
http://code.google.com/p/dart/issues/list?cursor=dart%3A4710&q=strings.join&ts=1352162136&updated=4710


On Fri, Nov 2, 2012 at 11:37 PM, adam <notifications@github.com> wrote:

> In web/file/terminal/Terminal.dart:
>
> > +        read(cmd, fileName, (result) {
> > +          writeOutput('<pre> ${result} </pre>');
> > +        });
> > +      } else {
> > +        writeOutput('usage: ${cmd} filename');
> > +      }
> > +    } else {
> > +      writeOutput('usage: ${cmd} filename');
> > +    }
> > +  }
> > +
> > +  void cdCommand(String cmd, List<String> args) {
> > +    args = args == null ? [""] : args;
> > +    StringBuffer sb = new StringBuffer();
> > +    sb.addAll(args);
> > +    var dest = sb.toString();
>
> Always forget about Strings class. Hopefully that gets refactored and
> hangs off of String at some point.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-html5-samples/pull/44/files#r2023230>.
>
>
It looks like this is vulnerable to an XSS attack. You may want to escape cmd.
This last line should just given example of what is returned.
Those single quotes around `key2` were a mistake on my part. Please remove.
Жкуери хэндлит сам falsy аргументы.
Имеешь в виду при генерации добавлять `.uploadcare` — `$(...).trigger('uploadcare-dialog-open.uploadcare')`?
Кажется это бессмысленно, или я чего-то не понимаю.

По моему нужно генерить "чистое" событие (`uploadcare-dialog-open`) и уже при подписывании, если нам нужно, добавлять тег.
Nice! I totally would have gotten lazy and worded it "...earned a grade of..." or something.
A more thorough unittest:

```D
unittest
{
    alias TypeTuple!(byte, ubyte, short, ushort, int, uint, float, double) Src;
    alias TypeTuple!(short, ushort, int, uint, long, ulong, double, real) Tgt;

    foreach (idx, T; Src)
    {
        static assert(is(Promote!T == Tgt[idx]));
    }
}
```
>I'm just not so sure how I feel about being told I'm wrong at English by non-native English speakers and an American ;)

Maybe you should feel proud that your native language is important enough that there are non-native speakers better at it than you ;)
Great, thanks. The point here is that this portion of code must be carefully documented as it's clearly non-intuitive and contingent (and dependent) on certain idiosyncrasies. Pulls come and go, but comments stay with the code. So please let's make sure the choices here are explained in comments, including an explanation on why the "obvious" choices won't work. Thanks!
Which name to use. I don't think that we should change the old name and if a new license header uses LLC or Inc I don't care.
After the rebase I'm not certain about this, though _get_client has side effects that are probably desirable here.
this function should return a reference to an internal pointer of a variable in the heap if not it can cause problems with constructors, destructors or other static variables calling it:  http://www.parashift.com/c++-faq/static-init-order-on-first-use-members.html
Should this table be within a box?
And also you could define your CSS styles as an array whose keys are those constants.
Por padrão, o Turumim (assim também como o Wordpress), usa funções com the_ com prefixo para mostrar a saída da função e não retornar algum valor. Para funções que retornam valor, usamos o prefixo get_
You will only get empty when the field doesn't exist on the model. Which is never the case in this if statement. This code looks like it will always update and not look at the fb_update_required. Could you explain how this works?

Thanks for the contribution!

Cheers,
Thierry
This library should not handle any styling internally.
* Seshadri Mahalingam
no need to use ``else`` as the ``if`` leaves the flow of the function
I would expect the updated package.xml to be part of this too. Is that a separate PR?
It is just an old typo, which one of the developer had noticed.
No, you need to keep the dir entry there. EasyBuild expects a dictionary with both the 'files' and 'dir' keys in there.

Just use `'dirs': []`.
@addyosmani What's the point of passing `element` and `options` to the `yourOtherFunction` when it's already available as `this.element`?
{% load class_manage_row %} needs to be changed to {% load class_render_row %} right?
Is this meant to be committed?
Нет. Нужны, чтобы линкер заругался, если ты вдруг вызовешь конструктор копирования. В твоем случае линкер не заругается, и в лучшем случае  плагин не подгрузится, в худшем — все приложение упадет где-то во время выполнения.
I don't understand this. are there cases where we have a list of lists?
This file is not used. Should be removed. 

But we can use it while testing. Haven't done this yet. Do you think it will be helpful?
You probably mean "array". However (thats not the point): There are cases, where `if`-expression may grow (If I can refactor it, to reduce it, is not the question here ;)). Isn't "either no whitespace, or a single new line" an option?
Porn-porn-porn )))))
И вообще, создавай лучше экшны как дети менюшечки, а не как дети виджета. Иначе экшны удалятся только при закрытии виджета — своеобразная утечка.
Stylistic nitpick: Empty line between the global attributes and declarations.
消します ><
this if block seems redundant - there is another one immediately after it that does the same thing (and an instanceof check does not need to be preceded with a null check in general)
No we don't need any else actually, because everything was already set and we are only guarding for the case of ambiguity where we just found another parameter that does not match headers thus can only be a payload, but payload is already set.
Not sure what else to add. Its a really simple and self-explanatory for those who do understand Mail API and for those who don't more info here will not be useful. So unless you have something specific in mind I'll keep it as is.
BigDecimal...

quero passar um ValorFinanceiro ou um double.
nice one-liner
![screenshot](http://f.cl.ly/items/3J0g3B162w0n3H1s0O30/20120904222327.png)
I didn't encounter exclamation marks or question marks, but I did encounter things like:

    [Section #5]
    Something "something" = value
    width% = 100
    height% = 100

Given those, I don't think it would be too unreasonable to include characters like `!` or `?` as well
Not all Rails apps < 3.2 use `attr_accessible`, so not having the ability to stop it from being called didn't make sense.

Also, that column may already be accessible on a model, and there's no need to call it twice.
Can we make this a bullet-point list please? And maybe highlight each command too using the double quotation marker highlighting as I have in BF?
Really? This is a kind of hack anyway to be able to test with a kernel...
Shouldn't it try to use the `config/application.config.php` instead? I think it makes sense to test if the current setup is bootstrapped correctly instead of a parallel module structure, or at least just add the module to the stack. Does this come from the old skeleton application?
OK no problem we can have a small JS tutorial. I'll also discuss what I asked Ron about with regard to style guides.
This looks suspicious. It should probably be done automatically? Not that you have to define it yourself?

And what about updating related documents?
Remove this line, it seems unneeded
With `data` vs `JSON.stringify(data)` objects appear in syslogs as [object]...
return sb.ToString().TrimEnd("&");
faîtes? sûr du ^ ?
Let me summarize to see if I understand:

* The interceptor can on each call use the metadata api to determine whether interception is needed
* The interceptor is free if not even encouraged to cache this information 
* If interception is necessary the according validation methods are called 
* If an error occurs a _ConstraintViolationException_ is thrown

The alternative is:

* Interceptor calls the validate method for each method (obviously worse performance)

So really it is up to the interceptor to make this efficient by caching the information on whether validation is needed!?
For what languages and use cases is `strip_accents='ascii'` a sensible default? For Romanian I always disable it because our diacritics (ă, ș, etc) are distinct letters, but this preprocessing strips them. For English is this even relevant and if English is the main target, isn't it faster to default to noop?
I wasn't sure.  My first inclination was to kill everything, but I wasn't sure if an app developer might want to store data from...external sites they manage, that are user-independent?  It seems pretty edge, but I didn't want to kill that possibility in the standard offering.

If you think it makes sense to kill it all, I could get behind that idea.
Use my sanitise function.
all this commented out code should be removed and we just

return compileSource(preprocessSource());
What's the difference between that and the $.ajax mechanism?

    $.ajax({ url: endpointName, data: options })

I like using the $.ajax method, because it returns a Deferred object, which makes chaining operations extremely easy.
Since you need to check authentication every time you get a socket from the pool, why not just return the authset with pool.get_socket()?
Input border styles are supported.
you could move it on class level
I don't understand that sentence
Can we just use <tt>safeQuery</tt> here?
why implementing the DecoderInterface in this class ? You don't need it IMO
Is this 404 page still needed? (does askbot override the 404 handler?)
That's pretty broad. Can we pin to a specific version; eg 6.0 and above?

(writing as someone who's written web sites for Blackberries for nearly 10 years and has seen things that can't be unseen)
I think something more like JNEXT_EXTENSIONS or JNEXT_PLUGINS may be more indicative of what this is.
unless of course element.getDynamicValidation() returns null sometimes.
I've fixed it.
"field fields"?
Should we keep log messages?
@pagey Yea, CI server is fine. I am using bbndk -2.0.1. I will try the bb10 beta ndk and see if i get the same problem. If this resolves it, we should update our README to point to the beta build and not the regular one.

FYI @miwong
I also think you should prepend them with what they refer to ie ````TYPE_NONE````, ````TRANSITION_DEFAULT````
send delete message
The table should be outside the loop rather than inside, so that there is only one table and and the columns line up properly where there are multiple comments.

I think it also needs a heading row to say what the columns are.
why do you need a transaction for a single put?