Change on 2012-10-15 10:49:06-07:00 by billydonahue

	GUnitize //util/gtl:stl_logging-inl_unittest.
	Add a test verifying buggy(?) silent truncation when logging large
	sparsetable objects.

	R=jgm,gpike
	DELTA=262  (112 added, 140 deleted, 10 changed)

Change on 2012-10-15 12:16:14-07:00 by billydonahue

	Support logging of sparsetables with non-default GROUP_SIZE and Alloc parameters.

	R=gpike,jgm
	DELTA=15  (13 added, 0 deleted, 2 changed)

Change on 2012-10-16 01:35:58-07:00 by tkaftal

	Changed time counting: benchmark listener stores time in cycles and converts them to usecs once the times from all next calls have been added up. This allows us to avoid rounding errors on multiple calls to
	next with less-than-microsecond duration.

	R=ptab
	DELTA=22  (2 added, 0 deleted, 20 changed)

Change on 2012-10-16 02:41:20-07:00 by dabramov

	Removing the "//base:basictypes_fileset" build rule.

	R=m3b,sanjay,mec
	DELTA=204  (0 added, 204 deleted, 0 changed)

Change on 2012-10-16 06:22:54-07:00 by mec

	Promote jgm to API owner.

	Tested:
	  blaze test strings/...

	R=jorg,jgm
	DELTA=1  (0 added, 0 deleted, 1 changed)

Change on 2012-10-16 07:10:42-07:00 by tkaftal

	Moved return rate from edge to node, added printable benchmark names.

	R=ptab
	DELTA=58  (35 added, 8 deleted, 15 changed)

Change on 2012-10-16 08:03:03-07:00 by saito

	Add IntrusiveHashMap::swap.

	R=psrc
	DELTA=177  (135 added, 8 deleted, 34 changed)

Change on 2012-10-16 12:59:43-07:00 by jmacd

	Make all the //base/logging macros hygienic.  This prevents
	future logging statements from common problems, such as reversed
	arguments and resolving to alternate definitions of "INFO",
	"ERRPR", etc.

	Part of http://goto/base-logging-cleanup

	R=sanjay
	DELTA=168  (30 added, 99 deleted, 39 changed)

Change on 2012-10-16 15:06:53-07:00 by dougkwan

	Fix fingerprint96 for big endian machines.

	This CL fixes fingerprint96.cc so that the unittest passes on
	both big-endian and little-endian machines.

	Tested:
	x86: tap_presubmit -c  35224211  -p components.core.released
	http://test/OCL%3A35224211%3ABASE%3A35495091%3A1350424287866%3Adb801a4e

	PowerPC64: /home/build/google3/devtools/manifest_destiny/scripts/powerpc64blaze.sh \
	  test //util/hash:all
	2 tests broken but they were known problems.

	R=waldemar
	DELTA=124  (57 added, 58 deleted, 9 changed)

Change on 2012-10-16 18:49:04-07:00 by wadetregaskis

	Rollback of cl/35258642 (which was itself a rollback of cl/35255328) with the build-breaking mistake fixed.  Original description:

	Renamed REQUIRE_MODULE to REQUIRE_MODULE_LINKED, and REQUIRE_GOOGLE_MODULE to REQUIRE_GOOGLE_LINKED, to better pair with the existing (and much more popular) REQUIRE_MODULE_INITIALIZED and REQUIRE_GOOGLE_INITIALIZED macros.

	Aliases were temporarily added for the older names, until all users of them have been migrated.

	R=maxim
	DELTA=150  (68 added, 65 deleted, 17 changed)

Change on 2012-10-17 02:40:27-07:00 by onufry

	Removed the LookupAlt function. It was unused.

	R=sanjay
	DELTA=22  (0 added, 22 deleted, 0 changed)

Change on 2012-10-17 13:22:01-07:00 by jorg

	Automated g4 rollback of changelist 35489826.

	*** Reason for rollback ***

	Breaks several tests, some with build errors:
	blaze test //gfe/gfe2:epoll_server_fatal_error_test
	blaze build //smartass/ads/uinormalization/lookup:uinormalizer_map_test

	*** Original change description ***

	Make all the //base/logging macros hygienic.  This prevents
	future logging statements from common problems, such as reversed
	arguments and resolving to alternate definitions of "INFO",
	"ERRPR", etc.

	Part of http://goto/base-logging-cleanup

	R=jmacd
	DELTA=163  (93 added, 24 deleted, 46 changed)

Change on 2012-10-17 13:45:01-07:00 by sanjay

	Support linker-initialization for Notification since that will
	allow replacing many uses of base::subtle Atomic
	(e.g., File::Init's file_init_done).

	R=m3b
	DELTA=42  (34 added, 7 deleted, 1 changed)

Change on 2012-10-17 21:19:54-07:00 by jmacd

	Fix so that the hygienic form of PLOG(FATAL) works properly: requires
	that PLOG-specific functionality be perfomed in Flush() instead of
	~LogMessage(), since Flush() is called from the LogMessageFatal
	constructor (it crashes before calling ~LogMessage() in this case.)
	Adds a test.

	(Addresses the problem which caused cl/35489826 to be rolled back.)

	R=sanjay
	DELTA=16  (11 added, 5 deleted, 0 changed)

Change on 2012-10-18 07:21:52-07:00 by tkaftal

	Added benchmark manager utilities with unit tests. Virtualised BenchmarkTreeNode to facilitate mocking.

	R=onufry
	DELTA=465  (442 added, 6 deleted, 17 changed)

Change on 2012-10-18 09:17:51-07:00 by tkaftal

	Minor changes in graph display:
	- disabled throughput display when processing times are rounded down to zero
	- changed throughput display pattern to the one provided by HumanReadableNum (k/M/B/T)

	R=ptab
	DELTA=44  (16 added, 9 deleted, 19 changed)

Change on 2012-10-18 18:28:56-07:00 by saito

	Fixed: Cord::Fingerprint() computes a wrong value when EXTERNAL_FP is
	used. EXTERNAL_FP is defined for code that ships externally.

	R=mec,sanjay,stephenamar
	DELTA=6  (6 added, 0 deleted, 0 changed)

Change on 2012-10-19 06:45:20-07:00 by tkaftal

	Several operation benchmarking examples, graphs are sent to Graphviz RPC and their URLs are logged.

	R=tomz
	DELTA=230  (227 added, 0 deleted, 3 changed)

Change on 2012-10-19 13:18:23-07:00 by mec

	Add a ctor for StringPiece(std::string).
	Conditional on HAS_GLOBAL_STRING.
	Should work fine in environments without HAS_GLOBAL_STRING.

	Reported by samsonov from an asan failure on a unit test.
	http://b/7192217

	Tested:
	  built and tested strings/... with {piii, k8} x {fastbuild, opt}
	  tap_presubmit -p components.core.released -c 34061260
	  tap global presubmit + reruns + hand runs
	    http://test/ui#id=OCL:34061260:BASE:35852575:1350629996342:be33f4c4

	R=jgm
	DELTA=69  (69 added, 0 deleted, 0 changed)

Change on 2012-10-19 15:05:45-07:00 by jorg

	Stop depending on the openssl version of the random library;
	that dependency brings in a use of 'auto', which blocks uss
	from automatically making sure we're not losing c++98 compatibility.

	Also, it slows down and increases the size of tests.

	R=mec
	DELTA=13  (0 added, 0 deleted, 13 changed)

Change on 2012-10-21 16:36:53-07:00 by jmercay

	Earth client needs std:: to be used for std namespace.

	Tested:
	  Fixes Linux build for Earth client.

	R=mec
	DELTA=1  (0 added, 0 deleted, 1 changed)

Change on 2012-10-22 04:59:39-07:00 by tkaftal

	Extracted two benchmark util functions from operation_example.cc - they will be useful for other benchmarks.

	R=tomz
	DELTA=169  (133 added, 19 deleted, 17 changed)

Change on 2012-10-22 05:40:10-07:00 by tkaftal

	Utilities for TPC-H benchmarking.

	R=ptab
	DELTA=254  (254 added, 0 deleted, 0 changed)

Change on 2012-10-22 08:15:00-07:00 by avivr

	Added the ability to split a string to equal-length chunks regardless of a delimiter string.

	Tested:
	blaze test --cpu=piii -c fastbuild strings/...
	blaze test --cpu=piii -c opt strings/...
	blaze test --cpu=k8 -c fastbuild strings/...
	blaze test --cpu=k8 -c opt strings/...

	R=mec,jorg,jgm
	DELTA=103  (87 added, 0 deleted, 16 changed)

Change on 2012-10-22 10:09:35-07:00 by yasez

	Updates examples in comments of ArraySlice.

	Tested:
	  $ blaze test util/gtl:array_slice_test

	R=jgm
	DELTA=4  (3 added, 0 deleted, 1 changed)

Change on 2012-10-22 10:38:54-07:00 by tkaftal

	Added a utility projector which projects those columns, whose indices are passed
	inside an argument vector.

	Removed an unnecessary include from tpch_utils.

	R=ptab
	DELTA=27  (26 added, 1 deleted, 0 changed)

Change on 2012-10-22 11:04:56-07:00 by m3b

	Apparently some clients do not find the wording on Barrier::Block() clear.
	It says:
	  // Block() returns true for one caller, which may then destroy *this.
	but some neverthess cause other threads to delete the object.
	Clarify with the comment:
	  // Other threads should not destroy *this, so stack allocation is unwise.

	R=sanjay
	DELTA=4  (2 added, 0 deleted, 2 changed)

Change on 2012-10-22 11:16:35-07:00 by oconnorr

	Adding testing for fLogOdds2Prob.

	R=peiwen,jgm
	DELTA=20  (20 added, 0 deleted, 0 changed)

Change on 2012-10-23 01:01:13-07:00 by tkaftal

	Porting the testing utils directory to the public version.

	R=ptab
	DELTA=164  (152 added, 0 deleted, 12 changed)

Change on 2012-10-23 07:45:10-07:00 by tkaftal

	Created a very simple protobuf matcher which relies on serialisation to strings.

	R=ptab
	DELTA=58  (55 added, 2 deleted, 1 changed)

Change on 2012-10-23 09:10:37-07:00 by tkaftal

	Implemented the TPC-H Q1 benchmark for Supersonic. Added some minor utility
	changes. Create a header with flags for use in similar binaries. The header
	should not be included anywhere else.

	R=ptab
	DELTA=390  (359 added, 7 deleted, 24 changed)

Change on 2012-10-24 01:30:44-07:00 by matthewbg

	Cleanup: fix unused-value warnings caught by Clang.

	Tested:
	    TAP presubmits for global presubmit queue
	    http://test/OCL:36207218:BASE:36207216:1351035237387:6e910952

	R=ptab
	DELTA=1  (0 added, 0 deleted, 1 changed)

Change on 2012-10-24 02:59:16-07:00 by tkaftal

	Implemented the TPC-H Q3 benchmark for Supersonic.

	R=ptab
	DELTA=306  (306 added, 0 deleted, 0 changed)

Change on 2012-10-24 03:05:32-07:00 by tkaftal

	Changed C++11 foreach to for-loop over iterators to be consistent with the open source version (no support for foreach in gcc4.4). Some minor scrubbings.

	R=ptab
	DELTA=92  (77 added, 1 deleted, 14 changed)

Change on 2012-10-24 06:45:07-07:00 by thollingsworth

	Fix TopN in limit=0 case.  In this case, the comparator was being called on inserted elements, which are not in the container.

	R=waldemar
	DELTA=35  (27 added, 8 deleted, 0 changed)

Change on 2012-10-24 08:53:17-07:00 by rsc

	This automated CL converts BUILD files to the official formatting,
	by running them through Buildifier. For background, see
	http://go/buildfmt and http://go/buildifier.

	You may find it easier to view this CL in Critique if you modify your settings:
	    Enable move detection: Always
	    Ignore whitespace: All

	This CL was generated with buildifier's "list sorting" mode disabled.
	If deps or other lists need sorting, that will happen in a followup batch.

	See the mini-FAQ at http://go/bcmf for details about genjsdeps and
	other common questions.

	Testing:

	This CL was tested by comparing the output of 'blaze query' before
	and after editing dir/BUILD. The changes in this CL leave that output
	unchanged except for line number information, meaning that the
	BUILD file has *exactly* the same meaning to Blaze that it did before
	reformatting.

	If any files in this CL are edited by other CLs before this can be
	submitted, so that a sync is needed, Rosie will remove those files
	from this CL (revert) rather than attempt a merge.
	We'll pick up those files next time.

	QA: NONE
	RELNOTES: NONE
	NO_RELEASE_NOTE

	R=dannyb
	DELTA=5095  (1063 added, 5 deleted, 4027 changed)

Change on 2012-10-24 09:05:49-07:00 by tkaftal

	Several open source utility fixes before the benchmarking utility is added to the public code base. Scrubbed GraphvizRPC support.

	R=ptab
	DELTA=207  (163 added, 14 deleted, 30 changed)

Change on 2012-10-24 10:27:45-07:00 by pjw

	Avoid panics on negative line numbers.  (found with
	blaze test -cpu=piii chubby/lamprey/testcell_test, where the log
	message at local_chubby.go:453 sees -405 as its line number.)
	This is related to code.google.com/p/go/issues/detail?id=4020

	R=rsc
	DELTA=3  (3 added, 0 deleted, 0 changed)

Change on 2012-10-24 12:01:01-07:00 by tkaftal

	Ported the benchmarking utility. Implemented an open source version of benchmark listener which counts time in nanoseconds just as boost timers do.

	R=ptab
	DELTA=202  (128 added, 38 deleted, 36 changed)

Change on 2012-10-24 14:10:31-07:00 by jmacd

	Hygienic logging. Apply most of the original change after several
	fixes. Three kinds of breakage were identified:
	(1) PLOG(FATAL) was behaving like LOG(FATAL), fixed in cl/35658785
	(2) One new caller using "transitional" symbols LOG_(INFO|...)_LEVEL,
	these symbols will be removed in a separate change
	(3) One new caller with reversed LOG_EVERY_N arguments.

	*** Reason for rollback [cl/35575374] ***

	Breaks several tests, some with build errors:
	blaze test //gfe/gfe2:epoll_server_fatal_error_test
	blaze build //smartass/ads/uinormalization/lookup:uinormalizer_map_test

	*** Original change description [cl/35489826] ***

	Make all the //base/logging macros hygienic.  This prevents
	future logging statements from common problems, such as reversed
	arguments and resolving to alternate definitions of "INFO",
	"ERROR", etc. [truncated]

	Part of http://goto/base-logging-cleanup

	R=sanjay
	DELTA=178  (43 added, 86 deleted, 49 changed)

Change on 2012-10-25 06:03:02-07:00 by rsc

	This automated CL converts BUILD files to the official formatting,
	by running them through Buildifier. For background, see
	http://go/buildfmt and http://go/buildifier.

	You may find it easier to view this CL in Critique if you modify your settings:
	    Enable move detection: Always
	    Ignore whitespace: All

	This CL was generated with buildifier's "list sorting" mode disabled.
	If deps or other lists need sorting, that will happen in a followup batch.

	See the mini-FAQ at http://go/bcmf for details about genjsdeps and
	other common questions.

	Testing:

	This CL was tested by comparing the output of 'blaze query' before
	and after editing dir/BUILD. The changes in this CL leave that output
	unchanged except for line number information, meaning that the
	BUILD file has *exactly* the same meaning to Blaze that it did before
	reformatting.

	If any files in this CL are edited by other CLs before this can be
	submitted, so that a sync is needed, Rosie will remove those files
	from this CL (revert) rather than attempt a merge.
	We'll pick up those files next time.

	QA: NONE
	RELNOTES: NONE
	NO_RELEASE_NOTE

	R=dannyb

Change on 2012-10-25 06:46:32-07:00 by psrc

	Comments: Accept util/gtl/ implicit constructors in portable google3.

	Remove some TODO comments calling for implicit constructors to become
	explicit; the costs of breaking non-google3 code are far higher than
	the benefits of retroactively making constructors explicit. In some
	cases, add comments explaining why specific implicit constructors are
	necessary.

	Tested:
	--cpu=piii -c fastbuild
	http://sponge/619e8813-8d32-4ba1-a802-0b78d289a8d3
	--cpu=piii -c opt
	http://sponge/76d24cc4-0434-4ef5-b7b4-ceb1109ba355
	--cpu=k8 -c fastbuild
	http://sponge/476075b2-a809-4db9-8feb-b4fff009370f
	--cpu=k8 -c opt
	http://sponge/97bbbd9a-2eae-437d-8a86-01035760977f

	R=jgm
	DELTA=21  (10 added, 2 deleted, 9 changed)

Change on 2012-10-25 06:52:32-07:00 by psrc

	util/gtl/: Non-heroic effort to reduce non-explicit constructors.

	Some non-explicit constructors are intended to act as conversions.
	(Some are even documented.) Add "explicit" to constructors when
	straightforward (and nothing breaks); add and improve documentation for
	interntional conversions; tweak/remove some TODOs.

	Tested:
	--cpu=piii -c fastbuild
	http://sponge/acb8172a-ec61-4d8b-aa6a-2f826259c058
	--cpu=piii -c opt
	http://sponge/0a3b60ce-0389-4ee3-a4fe-4081abcbbac9
	--cpu=k8 -c fastbuild
	http://sponge/3978fdbb-412a-4265-a0b3-989df50471cb
	--cpu=k8 -c opt
	http://sponge/185e40e5-8285-49d1-942b-fb3b1c37fd9d

	R=jgm
	DELTA=27  (2 added, 5 deleted, 20 changed)

Change on 2012-10-25 08:54:36-07:00 by asloane

	Rewrite StripWithMarkupTags with a linear-time algorithm.

	It was previously O(nm) with m markup tags and n characters, resulting in
	really slow worst-case behavior.

	Tested:
	  Added extra corner-case tests to //strings:strip_test.
	  http://test/ui#id=OCL:36160958:BASE:36411435:1351137602665:cd7223d1

	R=mec,jgm
	DELTA=23  (12 added, 0 deleted, 11 changed)

Change on 2012-10-25 09:52:22-07:00 by dougkwan

	Fix reference murmur hash for big endian machines.

	This CL fixes the reference implementation of murmur hash in
	murmur_larger_test.cc so that the test passes on both big-endian
	and little-endian machines.  Previously the reference implementation
	produced different results on big-endian and little-endian machines.

	Tested:
	X86: blaze test --cpu={k8,piii} //util/hash:murmur_large_test
	PowerPC64: /home/build/google3/devtools/manifest_destiny/scripts/powerpc64blaze.sh \
	  test //util/hash:murmur_large_test

	R=jyrki
	DELTA=3  (2 added, 0 deleted, 1 changed)

Change on 2012-10-25 12:54:03-07:00 by dsturtevant

	Remove using statements from strings/escaping.h for
	symbols for which no unqualified uses were found.

	Tested:
	strings:all (copt and fastbuild)

	R=mec
	DELTA=27  (0 added, 27 deleted, 0 changed)

Change on 2012-10-25 13:02:49-07:00 by titus

	Adding an empty definition for MUST_USE_RESULT, in somewhere that
	SWIG actually picks up (the change in cl/36309772 appears to be
	ineffective/misleading).  Without adding this change in a central
	location, many other .swig files will need to be edited in order
	to allow cl/36170542 to be checked in.

	Tested:
	  TGP of 36170542 works with this in place, and fails with build
	  errors without it.
	  blaze test //base:all {piii,k8}x{fastbuild,opt}

	R=sanjay
	DELTA=3  (3 added, 0 deleted, 0 changed)

Change on 2012-10-25 15:27:44-07:00 by nlewycky

	Move the explicit specialization definitions from the source file to
	the header file. This fixes an incorrect use of templates that just
	happened to work, but was invalid and could break with a different
	compiler or version of a compiler. Also remove the definition of the
	primary template. This allows the compiler to issue an error if someone
	tries to instantiate it with the wrong type, rather than getting a link
	error later.

	For reference, the relevant text in C++11 is [temp.expl.spec]/6:
	  "If a template, a member template or a member of a class templates is
	explicitly specialized then that specialization shall be declared before
	the first use of that specialization that would cause implicit
	instantiation to take place, in every translation unit in which such a
	use occurs"

	It's not enough here to simply provide a declaration, else you couldn't
	use them (you wouldn't know what methods are inside that particular
	specialization).

	Tested:
	  http://test/OCL:36242121:BASE:36243823:1351052733830:ed0a0fcb

	R=brockman
	DELTA=82  (40 added, 31 deleted, 11 changed)

Change on 2012-10-26 04:24:11-07:00 by mate

	Switch WeightedConsistentHash over to Fingerprint2011.

	See http://cl/34448795

	R=m3b,salty
	DELTA=18688  (8004 added, 7998 deleted, 2686 changed)

Change on 2012-10-26 05:01:35-07:00 by tkaftal

	Ported the vast majority of internal Supersonic unit tests to the open source version.
	Tests that haven't been ported are file_io_test (dependencies on file utilities), comparison_expression_test and build_expression_from_proto_test (unresolved compilation issues), cursor_statistics_test and tree_builder_test (lack of some functionalities in open source gmock and unresolved dependency on <tr1/tuple>).

	All ported tests pass on workstation except date_expressions - this will be fixed in a separate CL as there is a bug in the internal test - it passes on Blaze because of a certain set of circumstances that occur in the environment.

	R=ptab
	DELTA=398  (329 added, 32 deleted, 37 changed)

Change on 2012-10-26 07:58:37-07:00 by tkaftal

	Fixed time zone setting in date_expression_test.

	R=ptab
	DELTA=86  (46 added, 32 deleted, 8 changed)

Change on 2012-10-26 09:06:43-07:00 by jmacd

	Remove references to <strstream>.  This changes all the references to strstream
	in //base/logging.h except the parent class of LogStream.  It leaves in place two
	temporary methods to prevent breaking the //storage/f1/common build; that location
	will be updated after this change is released in components, and then the two
	temporary methods will be removed.

	R=sanjay
	DELTA=90  (35 added, 15 deleted, 40 changed)

Change on 2012-10-26 09:23:31-07:00 by tkaftal

	Prepared package for 0.9.2 release, applied boost_system bugfix.

	R=ptab
	DELTA=86  (59 added, 14 deleted, 13 changed)

Change on 2012-10-26 09:44:44-07:00 by tkaftal

	Changed email to external as the @google one will expire with
	end of internship.

	R=ptab

Change on 2012-10-26 09:57:56-07:00 by tkaftal

	Changed version to 0.9.2

	R=ptab
	DELTA=2  (0 added, 0 deleted, 2 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=5707