labofsahil/github-event-dataset-2012 huggingface dataset:
Use tryComplete since it's not an error if something is attempted to be completed more than once (see def complete for semantics)

val succeedFirstOrFailLast: Either[Throwable, T] ⇒ Unit = {
     case r@Right(_) ⇒ futureResult tryComplete r
     case l@Left(_)   ⇒ if (remainingFutures.decrementAndGet == 0) futureResult tryComplete l
 }
I forgot that was the reason I bothered with discount() in the first place, haha!!
For what it's worth, I think this test missed the mark. I'm less concerned with testing that it actually called mongo than I am verifying that the spec was correct. It's mocked at such an integral level that we're not testing the risky part of the code.

It shouldn't be too hard to add a few event listeners to the database, some with rest-api, some without, and then verifying that only the rest-api ones got modified and that they successfully did. IMO that's much more valuable than simply asserting the same dict from the code is passed to the mock.
This test makes me happy  :)

Do you mean self.assertTrue to use the TestCase assertions instead of the built in?
I agree it needs spec work.

First question: these aren't really "Settings" are they?
This shouldn't be required I think - i.e. the user should be prompted if the resume point is set?
It's a copy-paste from GUIWindowVideoBase.cpp:1203, i.e. the original "Play using" code.
I suppose it is remove both or none, but I wouldn't have arguments for removing it from the original code.
You don't need to | with ES_FLAG_UNICODE either (it's already there).

It's OK to leave the KEY_ASCII there - I'll figure out what's happening once it's in and clean it up.

BTW: If you're on IRC, this would be way faster (#xbmc on freenode), plus, we wouldn't be spamming 100+ people with every little note :)
Faktycznie, wywalilem i tez dziala ;-) Wczesniej nie dzialalo dlatego tego uzylem.. spoko
I think we should use the transactional Get here, so we get the existing qualifiers for a particular snapshot, and it also takes care of adding the get to the readRows if it needs to.
Line 90: this check might still fail if a weight gets re-initialized to zero. Change this to check that the position is not NAN.
I think we have our answer: http://jsperf.com/postmessage/6 http://jsperf.com/setimmediate-test/6 http://jsperf.com/postmessage-vs-settimeout

postMessage wins in recent FF, so seems like the better choice now.
This reverses the order of files shown.
I think it is pretty much the same either way, but delete probably uses less memory.  In the example below, both elements are undefined in the end, but setting a[2] = undefined stores undefined in the array, whereas delete doesn't, the javascript engine returns undefined when trying to access an element which has been deleted.

```javascript
> a = ['a', 'b', 'c'];
[ 'a', 'b', 'c' ]
> delete(a[1])
true
> a
[ 'a', , 'c' ]
> a[1]
undefined
> a[2] = undefined
undefined
> a
[ 'a', , undefined ]
> a[2]
undefined
```
Documentation coming soon... probably tomorrow, along with GCD support (optional, of course) and the layout manager class going private...
should probably truncate this to 32 bit two's complement
Sure, it'd be nice to.  But it belongs in a separate commit outside this pull.
forgot :D i'll fix this soonish
About English - I'm dont understand you. What are you want - please more accuracy you request?
Since you edited this, `777` should probably be `0777` to be completely accurate.
Why do we expose getpid if we've already called it and stored it at `process.pid`?  A pid can't change can it?
My general rule with node and luvit is to throw hard errors if it's obvious programmer error, but soft error to the callback is it's simple invalid data.  Being a loosely typed language this particular case is somewhat of a grey area.  My first instinct is to throw since a programmer should normally be in control of the type of value they are passing in.
Right, it's simply not possible to throw an exception *out* of functions like these. That's why the Python interpreter has a function for dealing with exceptions that are "Unraisable" :-).
Remove "of".
что означает сий чудный комментарий?
Yeah, I agree with @lest , because with `content_tag ` it will allow the use of classes and other html attributes
Huh. That's cool!

--
Aaron Patterson
http://tenderlovemaking.com/
I'm on an iPhone so I apologize for top posting.

On Jul 1, 2012, at 7:58 AM, Andrew White<reply@reply.github.com> wrote:

>> @@ -423,6 +423,7 @@ def test_compare_with_time_with_zone
>>   def test_to_f
>>     assert_equal 946684800.0, DateTime.civil(2000).to_f
>>     assert_equal 946684800.0, DateTime.civil(1999,12,31,19,0,0,Rational(-5,24)).to_f
>> +    assert_equal(-22610116560.0, DateTime.civil(1253,7,6,20,4,0).to_f)
> 
> @tenderlove it looks as though doing `strftime('%s')` is quicker:
> 
> ``` ruby
> require 'benchmark/ips'
> require 'date'
> require 'time'
> 
> date = DateTime.civil(1253,7,6,20,4,0)
> 
> Benchmark.ips do |x|
>  x.report("strftime.to_i") { date.strftime('%s').to_i }
>  x.report("ssue.to_i") { ((date - DateTime.civil(1970)) * 86400).to_i }
> 
>  x.report("strftime.to_f") { date.strftime('%s').to_f }
>  x.report("ssue.to_f") { ((date - DateTime.civil(1970)) * 86400).to_f }
> end
> ```
> ``` sh
> $ ruby seconds_since_unix_epoch.rb
> Calculating -------------------------------------
>       strftime.to_i     26480 i/100ms
>           ssue.to_i     13818 i/100ms
>       strftime.to_f     26561 i/100ms
>           ssue.to_f     14479 i/100ms
> -------------------------------------------------
>       strftime.to_i   616937.3 (±2.4%) i/s -    3098160 in   5.024749s
>           ssue.to_i   200108.8 (±6.9%) i/s -     994896 in   4.999278s
>       strftime.to_f   553581.3 (±2.2%) i/s -    2788905 in   5.040397s
>           ssue.to_f   204260.3 (±4.3%) i/s -    1028009 in   5.043072s
> ```
> 
> Caching the epoch date does make it a little faster but there's still a significant gap - changed in 210cd756a628cc19c0d6e44bee8c33dfb2d9d598.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/6823/files#r1081337
Ah ok, got it, thanks.
Would be interesting to know where that `msil.xml` lives to learn about maximal command line length.
You may want to put ``i`` and ``sl`` before ``X`` and ``Xcsr`` to make sure you can see what values they had in a failing test.
ditto, c style?
type: missing an "s" in last hek.attrs
Why is this part of the docstring removed?
Nice.

While I appreciate knowing that my specific example works I wonder if it's better to find a simpler test.  This test will fail if any of several pieces in sympy fail (stats, integrals, simplify, special functions, etc....)  These pieces also take a long time to run, unnecessarily increasing the test-time of the plotting module.
(in the SymPy universe)
You can just write
```
            raise ValueError("The number of elements in the permutations "
                             "does not match")
```

(I also fixed a grammar error)
I can't check the commit message at the moment, but this seems to be a deprecation worthy change.
maybe `# send 0 for u (3rd parameter) since it is not needed`
It was only processing the first column of B in `AX=B` (treating it like `Ax=b`). So the old result, if you notice, is just the first column of B and C.
Fixed this using 'callable'. It should check if the potential energy has been set or not.
Should SymPy provide a more intuitive way to do such an assumption/evaluation? If I were browsing the docs for how to assume a**2==2 and evaluate another expression, I would skip over something called invert.
imports go at the top
This is here so that Dagger(x) prints as "Dagger(x)" and not "adjoint(x)".
Returning None instead of True or False when the answer is either True or False? Is it because of our assumption system if so is someone working on changing our assumption system or are we  going to continue with this kind of issues by returning answer as None.
@flacjacket  Thanks for the explanation. So, looks like we can leave it the way it is for now.
Hrm, good point. This should be decided by assumptions, not sets. I'll post an issue with NeedsDecision tag asking if ask(integer(2.0)) should be True or not.
maybe it would be better to leave the original paragraph and add a new one just for `off`
@mdomba, @qiangxue, okay. Do i have to prepare reverting PR myself or someone of you will do that?
You think I should get rid of TestReporterExceptionInClassFixtureSampleTests and just leave all these Fake*TestCase floating in test_logger_test (or, perhaps, another place)?

I don't think I can do this, because then the fake test cases will be picked up and run as real test cases.

Am I misunderstanding your comment? Do you have a better solution?
Please extract an ask_email private method that contains the common parts of this class
Indentation is off here, and in below lambdas as well.
One would want to do an `d3.event.stopPropagation()` and `d3.event.preventDefault()`, just to be cautious (even though excerpts are unlikely to ever be nested, there may come a day when we have rich snippets in the excerpts.... maybe... )
I'm not sure why not.  The only thing I wonder is if all databases have the
ability to do that.  I don't particularly care about supporting others, but
I'd also like to not stop other people from being able to run in one...
 So, I guess ignorance is the reason.

On Thursday, November 29, 2012, gianm wrote:

> In common/src/main/java/com/metamx/druid/db/DbConnectorConfig.java:
>
> > @@ -41,4 +41,8 @@
> >    @JsonProperty("segmentTable")
> >    @Config("druid.database.segmentTable")
> >    public abstract String getSegmentTable();
> > +
> > +  @JsonProperty("ruleTable")
> > +  @Config("druid.database.ruleTable")
> > +  public abstract String getRuleTable();
>
> Why not use databases as namespaces instead of table prefixes? (Seems
> typical in other projects) Gian
> … <#13b4ddc89059382a_>
> On Nov 29, 2012, at 11:46 AM, cheddar wrote: In
> common/src/main/java/com/metamx/druid/db/DbConnectorConfig.java: > @@ -41,4
> +41,8 @@ > @JsonProperty("segmentTable") > @Config<https://github.com/Config>("druid.database.segmentTable")
> > public abstract String getSegmentTable(); > + > +
> @JsonProperty("ruleTable") > + @Config <https://github.com/Config>("druid.database.ruleTable")
> > + public abstract String getRuleTable(); I wonder if we should switch the
> table naming to be similar to the zk path naming. I.e. we can just specify
> a prefix unless we need individual overrides, at which point we use the
> individual overrides? — Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/metamx/druid/pull/36/files#r2270385>.
>
>


-- 
Sent from Gmail Mobile
> This document provides an overview of the core concepts and designs that underpin geospatial queries in MongoDB. For most cases, the :doc:`/applications/geospatial-indexes` provide complete documentation of all location-based operations and queries.
Have an example for me?  We have documents whose root doc is "MDN" ?
This is now wrong. You are overwriting the same key with the value of each row repeatedly.

When user style is overridden, everyone uses the specified style. It is rather pointless to make statistics show this.
chdir is unsafe to use in threaded environments. Since you are executing the process via a shell you should perform cd in the spawned shell.
Full post subject could be used as a title here.
Add empty line before if.
Indeed. I also thought mocks could be autoloaded. But that is not the case.
Please make these protected and don't set them to false.
If you are going to completely replace the header, then page_title and such should not be passed to the event. Otherwise a more appropriate name would be "modify" instead of "override" probably.
Comments that span over multiple lines should be using `/* */`
Remove true : false?
quite right. fixed in 3031d15
need a return?
Perhaps we should add some more info like the HTTP error code, the URL, etc in case of a retry?
Please organize imports: first python, then django, then wouso.
should be ```json_encode($PARCEL, true);```
You can ;)
What's the behavior of there's no match?
Be careful with your branches -- you've accidentally included code from the "Dropdown menu" fix (to change modules) into this pull request.  That's OK for now, especially with this smaller request, but please do look through your pull requests before submitting to make sure the correct code is included. Sometimes we will want to merge code from pull request A but not from B, so it's best if they aren't combined!
HeightInInches
Rename this to newPatientUuid
suggest: "if flag == 0 and line.find(start) > -1:"
The 'lastseen' column is still needed, don't remove it.
Just add a new 'lastping' column.
Could it be moved to PaginationMixin?
It looks like the fold is stopped once the error limit is reached. Why not continue the fold, but just silence the errors after 20?
unit tests are described in topics/testing/overview
Because they're not normal queries - during migration runs you might well want to show only the schema-altering statements as they're being run on the database, and not e.g. the queries to the migration history table. If there's a better way of achieving that I'll happily implement it, logging is not my strong point.
Indeed, that's quite a footgun. I will see if it can be done in a better way.
These tests don't pass

TypeError: today() takes no arguments (3 given)

happens again in test_date_list_order
The issue addressed by this pull request asked for a distributed solution (as it is, right now, on master). I think we should file another issue on Launchpad (for both master and nhlib integration) to remove such requirement.
Why? An if statement executes a statement when a condition is true; note that a compound statement is a statement that executes multiple statements. If you don't need one there's no need to introduce one...
The patch is absolutely necessary.

It is users who are interested in having pass available in OSX.
Given that the downloads are coming from SourceForge, how official is this repository?
Homebrew does not install things directly to /usr/local, but rather each package is installed into its own individual prefix and then things are symlinked into the top-level directories.

The correct way to do this is something like (untested)

```rb
system "make", "PREFIX=#{prefix}", "install"
bin.install_symlink share/'julia/julia'
bin.install_symlink share/'julia/julia-release-webserver'
```
`#{man}` and `#{sbin}` are the full paths including the prefix
True, but would that would be another commit/PR, imho, other context.
Lets rather use alpha to show that the API is not meant for production applications
I was primarily wondering about the change where initially `api_callback` was given the `sandbox_protocol` as an argument and now it relies on the local context and it's not completely clear why that change was necessary?
I meant `vumi.utils.redis_from_config` (that would go into `.connect_to_redis` or instead of it).
Won't think break if someone puts a * in their content?
Might want to mention that consumers that are bound to the Pulp repository will have the necessary certificate sent to them to grant access to the repository, which shows that Pulp is an end to end solution for consumer repository management and they won't have to find a way to get the certificate to the clients.
do not go beyond column 80, especially for comments.
please move this function into lib/bundles/framework.el
this is unrelated ofc :)
It was more for the sake of verbosity and clarity than anything. Removing.
Consider using text/x-java-source for the mime type (http://filext.com/file-extension/java)
A better way has been implemented in 9b13f3e. streambase.py should not contain anything specific for a single authentication mechanism.
Is the time-of-day automatically added?
We didnt know the id :D they arent the same as minecraft
Let me give that a try and see what it would look like.
Ah.  Well luckily it turns out, toggleUseTabChars() was moved to a different module recently.  So when you merge with master, that code will go away and the dependency on Editor will indeed no longer be needed.
Good catch! Fixed. Also, added length checks.
Not clear on how these relate. What happens if the user specifies both? It seems like they're mutually exclusive.
Would be nice if the resizing functionality could be added to a bottom panel simply by adding a the h-resizer class to the parent container and this DIV was dynamically added to the DOM. This would make it easier and less obtrusive to add.
Missing return JSDoc
Column info seems to count chars, not "columns", because it's not correct when there are Tab chars.
Yeah, but we're indexing that empty array.

![](http://cl.ly/image/2J0z2l3F2w14/content)
Unfortunately adding additional copyright is not something I'm willing to accept. In order to stay flexible I do ask contributors to hand over the copyright. Not doing so can make my life rather complicated in the future.
admittedly, this is strange but the browser was called up 'stateface.css' from the root and grid.less from the same directory as style.less - so I had to hardcode the path.
Changed `self.error(self.error_messages['bounds'])`to `self.error(u"Invalid lower_limit argument.")`.
No, this was done before. This is why you had to merge.
Same here, is this OK?
all you are fault
you mistook my comment for how I wanted it defined :( See below
See https://github.com/mozilla/butter/pull/808/files#L2R91
Instead of having this code here, could we just rely on the code in src/cornfield/module.js to prevent too many saves from happening?
I'm not too familiar with how the flatpages app works but to me wrapping everything it outputs inside of a <p></p> potentially dangerous for the site's code quality?

any lists, headings or other block level content inserted will immediately break validation of the page. Would it potentially be 'wiser' to allow raw HTML to be included, run a bleach filter over any non-wanted elements and attributes and insert the content via  the safe filter?
Unregister not UnRegister
> 80 column already?
这个ss_srv如果和header_headler里面的ss_srv不一样的话，这里写一条出错记录。
AFAIK, the only way to do that is to retain the original span throughout all the processing, and that's already super slow as it is.
would be great if this could say how to fix this if the test fails (i.e. how to make a new data+data.cdb)
Here we use 'number', elsewhere we use 'page_size'.  Sorry it's a nitpick... :)
Definitely not... :) Good catch!
You are apparently quering by keyname, therefore I would expect index on keyname BUT it seems we are not expecting many custom info records for each system, right? So this is the reason why the index is not there. Anyone, please confirm my idea.
I like it  a lot actually. Only problem is we would probably want that in one central location and homescreen can't load it cross domain .json file.
If I change the file to be a real javascript file no problems though.
I need to add an option to api.lua...
Good point @eteq, I withdraw that idea.  Maybe there could be a context manager to do this, but in any case it's not a huge deal.
This could of course just be written: `return isinstance(args[0], (h5py.highlevel.File, h5py.highlevel.Group))`
I guess the issue is that ``write`` doesn't know if the first argument being passed is a filename (some readers/writers might define it a different way). We *could* make the rule that if the first argument is a string in ``write`` then it is a filename (but that assumption wasn't being made at the moment). There is one cleaner option which is that that when writers are registered we have something like ``enable_overwrite=True``, which we set for any writer where the first argument can be a filename. Then ``overwrite`` won't work in cases where the writer function was registered without that option.
Also, do you think it's cleaner with ruby to just leave out the return?
missing space after `if`
Just for the record, I hate this type of comparisson. I like having the value at the end. There is nothing in our guidelines about it, though
you should add the fluent interface for this setter too
This is just assigning the twitter bootstrap class .inputError and my my validation class .limit-150 to this text field.  No need  for a helper here
Should this also check for `withBranches`? I.e. if I'm just cloning one branch, do I really care that it's not trunk?
> Can you check to see what py3 distutils expects here?

I checked the sources for 2.7 and 3.2, and it's an explicit check for *str* in both cases.  The bug in 2.x is that it should be strtypes, which of course is back to just str in Python 3.

That means that if you pass bytes to Python 3, it will fail with the same error as passing unicode to Python 2.

The logic should probably be:

```python
if isinstance(path, unicode):
    path = py3compat.unicode_to_str(path, encoding=sys.getfilesystemencoding())
```

Though the encoding might need to be more carefully selected on platforms like Windows.

I'll try to see what this does with unicode home on Windows later.
I don't care about SSH WIndows clients even a little bit.  If anything, I would raise an error if this is even attempted on Windows.
rename to addEmptyMediaInVDC
git_branch_tracking does not expose the branch.branchname.remote argument, it only returns the ref referred to in the branch.branchname.merge value.  I will fix the comment, however.
Here's a good starting point

```ruby
/([\.\w\/\-]+)-(\d+)-g([\da-fA-f]{3,})/
```
I see bitmask conditions written this way in quite a few places -- it's necessary to check for equality when the constant represents a mask of bits and you want to make sure all of them are set instead of just one, but your enumeration doesn't have any masks, just single bits, so `flags & GIT_STASH_KEEP_INDEX` suffices -- or maybe this is just personal preference. It's a nitpick, for sure.
`src` has already been dereferenced when this assert fires. Not a big deal, but the assert won't catch a src issue...
also please add unit tests to support name=name ( which means it will walk up the tree )
Oh, I just realized what this page does. We can't detect it on the server-side because of caching. Is there a way to detect it with javascript?

Not sure if that means we can't even use the django-dnt project.
By adding `'': 'All'` inside `GRANT_LABELS`, you can save the duplication of the if/else logic here.
Huh. I ran the tests and didn't bump into that error. So I'm puzzled.
Notice how you're calling tags.sort() in both branches. Instead of doing that, you can nix the else branch and call tags.sort() after the if branch. Like this:

    if tags is None:
        tags = self.tags.all()
        cache.add(cache_key, tags, CACHE_TIMEOUT)
    tags.sort()
The error for 'frame' doesn't make sense. When have you printed out this value? Before calling saveScreenshot?
437 - 441 have interspersed tabs
Perhaps I'm wrong but this is now repeated so many times you might want to move it outside the testcase class.
Since WSGI is a must, why not say "wsgi_server_class"?
I don't get why one would call them `helpers` when its a file of `filters`
I think there's a simpler way to do this, in a way that's also more flexible.  Rather than figuring out the type of match (exact vs partial), I think we can convert it to a regular expression, and rely on that to do the matching for us:

``` ruby
class StatusCodeMatcher
  attr_reader :code_strings

  def initialize(codes)
    codes = ["xxx"] if codes.none?
    @code_strings = codes
  end

  def code_regexes
    @code_regexes ||= code_strings.map do |string|
      /\A#{string.gsub('x', '\d')}\z/
    end
  end

  def matches?(status_code)
    code_regexes.any? { |re| re =~ status_code.to_s }
  end
end
```

A few things to note:

* This is more flexible than what you currently have, as it supports things like `20x`, `x00`, etc. I doubt these cases are particularly useful, but the consistency of being able to use "x" as a wild card anywhere is nice.
* No need to differentiate between partial and exact matches...if you have a status code like "200" then it'll create a regex like `/\A200\z/` which will only match exactly.
* I'm a huge fan of the null object pattern (which helps you avoid unnecessary nil checks by putting a suitable null implementation in nil's place).  I used that in this snippet, by setting the status code to "xxx" if none is given, which will automatically match everything w/o needing to special case it.
* I didn't implement #to_codes here as it's not clear to me what that method is for just yet.
треба буде якось позбутися жорсткої привязки до \Application\Bundle\UserBundle
@Tobion it is not really a BC as it would not have work without a valid regexp even before
@Baachi point 2,  There are may areas in Sf2's codebase where testing is overly complicated with too many dependencies due to the lack of mock testing, there is no need to continue that trend. The purpose of unit tests is to unit test, not functional test - as it stands theses tests not only require the extensions loaded, but they require working databases - this also slows down the entire test process and makes it unnecessarily complicated.
B and C are not mandatory. The configuration class can be anything. You simply need to overwrite the ``getConfiguration`` method if you don't follow the convention
ok will rename it.
Correct me if I am wrong but as said in the description of the PR, the ```attemptAuthentication``` method is called only if the ```requiresAuthentication``` does not return ```false```. If this premise is correct, the ```post_only``` option is true and the request method is not POST, ```requiresAuthentication``` will return false and ```attemptAuthentication``` will not be called. Therefore,  the condition you are asking is useless as it will be false all the time.
this variable would better be named ``$exitCode``
My question is: Do we need that double check ? (first check for `null` + second which can catch same)
Can we merge all but the _workflowId parsing part? It would be good to support passing workflowIds to the API and avoid forking on the index.html filename change.
We use scrooge in birdcage but not yet in science (the migration should happen in a very near future).

And yes, you need to mention that sbt use a plugin that call scrooge to compile thrift files. 
The latest plugin has only been release for sbt 0.11.2 
(usually it's not a problem because we provide a sbt script that download the proper version, 
see https://github.com/twitter/finagle/blob/master/sbt)
Please pull and push again. You are committing old content.
just a suggestion:

if (!error && item && !Rules.isExpired(key, rule || that.rules, created)) {
	callback(null, item, false);
} else {
	// expired, not found or client error
	callback(err, null, false);
}

Note: I shortened some things which you could expand if error truly needed to equal null as opposed to just be a falsy value
Using the URL helpers is a neat idea. I don't think I've seen that before.
A couple comments here:

1. Could you break out this change into it's own feature branch (since it's independent of the other code)?
2. I'm not sure if the HSV colorization is any easier to read than the blue->red gradient colorization. I wonder if both modes could be useful, maybe as some sort of select (or two buttons)?
```why not copy them to textures and hence decouple the decoder from the display process?```
The various hw decoders handle interoperation with OpenGL in different ways. VDPAU maps textures to video/output surfaces. That means during the time the textures are in use, the video surfaces are blocked as well. AFAIK a PBO allows only to copy from system memory to video ram but not from video ram to video ram. I tried this once for XvBA, I copied a decoded video surface via a PBO to a texture. This put a lot of additional load on the system. Finally I dropped this method.
Another option might be to render a texture or surface to another texture. I think this is done by XvBA internally when transferring a decoded surface to a texture. This requires additional gl code and prevents the decoder from going faster then the renderer.

I made buffing dependent on decoders because VAAPI failed with a buffer size greater 4. VDPAU and and XvBA have no problems. 

The critical point is when a video is started while the previous has not been stopped, as pvr does when switching channels. Then a new decoder gets instantiated while the old one has not completely freed up resources.
I'd prefer
```python
    return '< InterProjectionTransform %s -> %s >' % (self.source_projection,
                                                      self.target_projection)
```
Lazy or not, what's it doing here at all?
There's no such thing as *idiff*.
why not ``lang_template['hide_untranslated'] = getattr(settings, 'CMS_HIDE_UNTRANSLATED', False)``
This is a good question :) I will investigate
It overwrites the property with the same name in arquillian.xml
Good idea, I just committed the change.
typo:
strcuture -> structure
but dos it lint?
I'd prefer this in the first condition above:

if (stats.state === 'available') {
  if (stats.freeBytes >= fileSize) {
  } else {
  }
}

Actually, this would be a good place to use switch(stats.state)
Hey @gtorodelvalle, I'm currently working on a "nit-picking" pull request to send to your repo :)
Let's sync in a few once it's done, some of these issues will probably be fixed already!

In the meantime don't hesitate to comment on my comments here!
Hi @borjasalguero, are we always prepopulating?
this.node -> aNode.

No need to digg into the object here.
I did not know we have a native implementation already available? Do you refer I can use `<select>` instead a hack?
Not really intentional.  I just hadn't thought of a better way to do it.  I'll change it to not return the real constructor, just an object with the factory function.
there is a version with a callback, but it's hard to tell whether this truly IO blocks or not cause I cannot read C++ code :( Can you help?

https://github.com/joyent/node/blob/master/src/node_crypto.cc#L4364
For applications launched with applauncherd (so, everything frontend), applicationFilePath will be /usr/bin/applauncherd.bin. applauncher has a patch to handle this, but it requires a patch to Qt and weird non-standard API, so we have it disabled right now.

If we can't fix it at that level, maybe it should use applicationName() when that is non-empty? It's only present if filled in manually, usually for QSettings. It may also be an option to ignore this for now and file a bug to fix the paths from applauncher.

@rburchell, comments?
add a space before this line.
The naming of this is confusing. The calls looked like calls to PHPUnit APIs.

In fact I'd go as far as to make this a separate `ErrorCollector` class that is used in the test cases explicitly.
I'm thinking that `profile_examples` doesn't really read right....it sounds like a boolean, not like a number.  I can't think of a better name right now (and maybe I'm just tired).  Thoughts?
It would be nice, as you mentioned, to actually run a test job (one that we already have, for instance).

You are right, you will need to change this line:

https://github.com/twitter/scalding/blob/master/src/main/scala/com/twitter/scalding/JobTest.scala#L103

to call .run

I don't know why it doesn't now.  I can't think of a reason for that.  If you do that, I think this will work properly.
A process you silly guy.
After looking into the code, above code shouldn't work in Joomla 1.5. :)
ah yeah I suppose
Yes for creating threads.
I don't necessarily agree that code needs to be completely self documenting and without comments, but I never mind a little abstraction and refactoring.  Thanks.
Yeah, I meant to add one.
Yes, but everything needs to be ported to it first.
this doesn't feel like it belongs here. could either move it to a subclass or make it a dynamic property of the form?
no, I am not (:
Is it really need? :)
Where is parent initialized?
I think `nsIStringInputStream` is more efficient and more appropriate alternative. For examples see:
https://developer.mozilla.org/en/Creating_Sandboxed_HTTP_Connections#Creating_HTTP_POSTs
> Btw, is there going to be one global loader instance, or each addon will have its own?

We'll start with loader per add-on otherwise module state will be shared and that most likely will break our APIs.

> What about m-c code, is devtools going to share a loader with other part of m-c?

That's up for them to decide really, but I'd expect that there will be one shared loader and few case specific loaders.
The XXX TODO wasn't enough?  Get the fake password out of there and use user input.  The forgot page will have to be set up to input the password.
Yea, I should. Doing...
our tests should catch this, there has been a regression, I'll fix the general problem that we're not catching writes being performed by processes which cannot write, then we can fix the underlying issue.
I think this is the last step in a unit test per path, where we test the behavior of an unknown etag. It won't get reset to a real etag, but we've already run through the logic with real etags several times.
Secondly, since the callback to self.window only calls cb with the err, can we replace the entire `function(err) { cb(err); }` with cb.
I don't see a reason why we have to introduce another id here. You can keep 'resident' and give the sub span element a class="label". The same can be done for all the other elements in the widget. It would make the structure way cleaner.
You're putting the XPI in the release directory even when it's not a release build, is this desired?
Okay, its my mistake. Sorry.
And this is why we do reviews!
Yep, I'll take a stab at that before merging.
This spec description seem a little off to me. I guess it should read something like:

it "returns an equal string when given a single argument".

Also makes me wonder, does this return the same string instance or a duplicate?
probably will just add the static path for production...?
Won't this override the exiting start and stop tasks?
Can we leave this here but have it point to the new gem? That should install on demand when using 1.9.
again, this is not much straight code, so I think it should be moved to own function with good name and I am also againts short unintuitive names if code is so complex (  there is mix of three short variables ).
so at least I think it should be change to this:

```
foreach(string alias_name, map<string,any > alias_info, (map<string, map<string,any> >)value,
{
  map<string,any> replacement = (map<string,any>)value;
  replacement[alias_info["LABEL"]:""] = replacement[alias_name]:$[];
  replacement = remove( replacement, alias_name );
  value = replacement;
}
```
it is easier to see what is going on here.  And as I mentioned earlier, properly named function is even better.
I think that you should add to log some useful line why it happen. Can you dig it from exception? E.g. exception message?
put VERSION_10 first
The original was actually correct; it's only in the concrete implementation that we use specifically the ServiceManager implementation.
Because getData throws an exception of the form has not been validated.
Should have a trailing comma (makes changesets easier to identify)
* ErrorHandler::stop() can return NULL in which cases $error->getMessage() fails
* previous error

```
    throw new Exception\RuntimeException(sprintf(
        'Cannot serialize callback%s',
        ($error ? ': ' . $error->getMessage() : '')
    ), 0, $error);
```

(Not tested)
Next time, don't in this PR, leave trailing commas in array elements
You only need to use `global` if you want to modify testSets, so this line isn't needed.
What is the point of this enum no that we have a Creative and Survival GamMode classes
this should just be
clearCompletedElement.text = 'Clear ...
-> 'dblclick .view'
Please use camelCased names for variables
It's funny, I was just commenting the other day how inconsistent Ruby is with handling optional parenthesis. I'm getting to the point where I don't see the benefit of leaving them off anymore because there are so many exceptions.

I don't mind either way, and since parens seem to cause less pain, I'm all for parens.
Mmm you're totally right, there is no need to do that. My bad, I didn't get it. Should be :

```php
<?php
$legacyKernelClosure = $this->legacyKernelClosure;
return $legacyKernelClosure();
```
I know the match might look odd, but it's the various variable cases that mysql support. I tried doing the same with PHP and it doesn't work. You have to query `CALL procedure(@var)` and then `SELECT @var`. The results are just like this lib.

The only thing I try to do with this merge is be able to CALL+SELECT in one function and have the variables returned without the @.
Taking a closer look at the use cases of `value`, I have to admit that this is just syntactic sugar that doesn't really help you. Using `arguments[:my_column]` is a lot more meaningful than `value`. Also the use cases involving `value` always do some kind of computation in which case it is helpful to have descriptions of what they do.

@senny I agree with you.
I don't see where you're using this; anyways you can do `isinstance(cls, type)` as well (which is exactly what `inspect.isclass` does, in fact).
Should we add project_filter_search and friends to LdapQuery as well?
True, some months do not :-) But you can account for that, I guess. Which makes the test more difficult to get correct as well. OTOH, it will test for more that the start of the epoch. And by default 100 tests are generated (for the entire function, not for each parameter as that would imply 1M tests). But you can vary that. So it generates random (define this) data, so if there are specific corner cases that may be missed, you should prolly account for them yourself.
I don't grok it either. Can you clarify, boegel?
I was thinking the SecurityBundle way, but letting the classes specify whether they are oauth1 or oauth2. The bundle can handle the rest of the configuration.

I'm looking forward to your PR first! :)
@kripken: I did this so that I could pseudo-overload the getter in the LazyUint8Array. You can't overload the [] operator in JavaScript. So what would you suggest?
It blocks the default notifications from coming through since its already defined on this page.
we deprecated exec, we should be using `on` instead
this does the same thing as the patch file used to, but in a cleaner fashion
Here is the beginning of the save function for aws in fog.  Every compute instance gets an identity when it is created.  Powering off that instance does not change the identity.

# File 'lib/fog/compute/models/aws/server.rb', line 118

def save
  raise Fog::Errors::Error.new('Resaving an existing object may create a duplicate') if identity
  requires :image_id


From the Brightbox page in fog (http://rubydoc.info/gems/fog/1.3.1/Fog/Compute/Brightbox/FirewallRule#save-instance_method):
 - (Object) save

Sticking with existing Fog behaviour, save does not update but creates a new resource.


From fog docs for rackspace:
# File lib/fog/compute/models/rackspace/server.rb, line 87
def save
  raise Fog::Errors::Error.new('Resaving an existing object may create a duplicate') if identity
  requires :flavor_id, :image_id


I am sorry if this sounds rude, but have you tried to use an EC2 instance, power it off, and power it up?  I really would not have gone to all this effort if foreman's EC2 support worked as an EC2 user would expect.  I carefully read the code, and read all the functions that the Foreman code called.  A simple search on Google for "fog compute save" shows the error fog raises for the first 2 pages of results, so it is pretty clear to me that whoever wrote the save function into foreman did not understand how the fog compute save support worked. 

I was a developer for 10 years, a QA manager and QA technical developer for 13, and I have spent the last 4 years as an operations director/architect  - I don't modify anyone's code lightly.

I could just file bugs, if that makes this easier for you and the other developers.  However, I needed this support to convince my organization that Foreman was a viable choice for managing EC2, and if I have to maintain my own branch until that support becomes available and solid, I guess I can do that.  I had hoped that this would make your 1.0 launch viable for EC2 users, and  I am getting pressure from my management to move on to other things.
Why not just `interpolations`?
nit: Can we use `_.uniqueId()` so we can remove the `_loadCounter` var?
This print statement needs to be removed first
What happens when `name`, `type` or `path` are blank? Is that possible now, because the `new VdbModel(name,type,path)` call will throw an exception in any of those cases.
I prefer private than default modifier.
might be the thing to scrap the pull (and the pivotal task) in that case. that's the strategy that the previous version was using, albeit incompletely, but parts this pull supports that the previous code doesn't isn't used anyway.
Let's monkey do his job
Non issue, `json.dumps()` handles escaping for us.
Don't we need to be able to pass in the tenantAlias in case we want to get a tenant admin UI on the global server? Also, when removing a parameter the JSDocs should be updated.
The loginId properties still seem weird to me, as they're being tacked on on the fly.
Oops, that was what I intended to do, but sort of screwed up. Fixed now.
The title remains Global Administration UI, even if I'm logged in to the tenant admin ui
No idea, it's in all the other files so I've just followed this convention
Should add a check to see if the revisionId has been provided and is a resourceId
not to self: use the logger
I think you have missed this :-)
Redefining the property is useless
а де ми розглядаємо post як стрічку? і чому title
Lots of pointless blank lines here. Just one between each block of code is enough.
...чуть выше в коде создал массив mas, в котором столько эл-тов, сколько эл-тов в массиве dna. после заполнил его случайными нулями и единицами (этот процесс немного доработаю), в котором столько единиц, сколько эл-тов нужно изменить-мутировать. таким образом единицами в массива mas обозначены те ячейки, которые нужно изменить-мутировать.  в цикле "while (count--)" меняем их, проверяя условием while ([dna objectAtIndex:count] == temp). точнее, меняем до тех пор, пока оно Реально не изменится.
Спасибо, исправил в следующем коммите :)
ага. спасибо за ревью.
useless :P
These three lines are getting strings 3-5. I think you want to get strings 1-3 instead.
`s/the we/we/` :)
Well, yes you are right, `Given` is about preconditions. But instead of simply stating (and verifying) those preconditions, the step fulfills them.

By *implicit requirements* I was referring to the fact that one must go through the scenarios to find out this environment variable should be set before running the feature suite. Imagine several similar preconditions on the feature suite: it would quickly become a nightmare to handle.
this is a open task to support shard keys for referencens and embedded documents.
Right, so a method that removes all duplicates would be useful but this "Returns a stream of the receiver's values with sequential repeats removed."
@cspurk Thanks - both corrected in next commit.
By nasty, I mean it took me about an hour to track it down :)
2012/10/29 Alexandre Gramfort <notifications@github.com>
>
> In mne/artifacts/ica.py:
>
> > +        Returns
> > +        -------
> > +        fig : instance of pyplot.Figure
> > +        """
> > +
> > +        sources = self.get_sources_epochs(epochs)
> > +        fig = plot_ica_panel(sources[epoch_idx], start=start,
> > stop=stop,
> > +                             n_components=n_components,
> > source_idx=source_idx,
> > +                             ncol=ncol, nrow=nrow)
> > +        if show:
> > +            fig.show()
> > +
> > +        return fig
> > +
> > +    def find_sources_raw(self, raw, target, sources=None,
> > score_func=None,
> > +                         start=None, stop=None, sort_func=stats.skew):
>
> remark: can you convert your emails to text as it appears always a mess
> when you reply to comments by email. I always have to reformat to answer :(

Sorry, wasn't aware, bad gmail. Is it better now?

>> I'm afraid the API get's shaken... But yes. So just to draw a tiny
>> dependency-map of the method relations:
> yes
>> '-->' for left invokes right: (get_sources, pick_sources) --.>
>> sort_sources (plot_sources, find sources, pick_sources) --> get_sources so
>> in depth sort_sources does the default ordering job. get sources gets the
>> sources (calling sort_sources, internal scoring) and find_sources gets
>> scores based on comparison with a target vector (external scoring). How to
>> unify this?
> if target is None then the score_func expects only the sources and if not
> None it is passed as second argument to the score_func. order =

We could do this behaviour for find_sources where score_func could
either be of x-arg or x-y-arg type.

> ica.argsort_sources_epochs(epochs, …) ica.plot_sources_epochs(epochs, …)

The we could replace sort_sources by find_sources but keep the
implemented sorting bookkeeping.
Let me think about it for a moment. Also getting back to you later :)


>> I'm a bit -1 for adding more accessing-methods, It would get confusing at
>> some point. But extending / altering functionality and / or renaming would
>> be fine. The candidate I see is sort_sources We could try to merge
>> sort_sources into find_sources or allow it to return scores and make it a
>> internal-score version (index based on one input vecor) of find_sources or
>> something like that. Then the top level functions could access both scoring
>> functions via keys or so. However I'm a bit afraid of fumbling around with
>> it. The whole picking depends on consistent sorting which took some time.
> Basically you have to make sure, that pick_sources draws the sources in the
> same order as your decision-maker (human, correlation-algorithm via
> find_sources/ get_sources /sort_sources) If you see a quick way +1 for this.
>> What do you think?
> I am not sure. I'll get back to you later.

>
> —
> Reply to this email directly or view it on GitHub.
I think the state record isn't adding much. See what you think of the version in the attached patch.
can you line up the `:id` with the `t(` as before?
Does `@caching` exist before the first time it's expired?
I think you can use `.rstrip('/')` here:

```
    urls = [u.rstrip('/') for u in urls]
```
Only in debug mode. In prod, resources are not kept and the cache is considered as being fresh as soon as it exists
Ah. What if you change that feature to use `shoulda-matchers` too? Would that work? I'd like to have the most specific dependency possible, and not pulling in `shoulda-context` would be great.
Aha, to jsem přehlédl. Díky.
```python
>>> eq
sin(x)*cos(x)/(x**4*y**3)
>>> d=sift(eq.args, lambda w:
... w.is_Pow and w.base == x and w.exp.is_integer and w.exp.is_negative)
>>>
>>> other = Mul(*d[False])
>>> e = Add(*[p.exp for p in d[True]])
>>> e, other
(-4, sin(x)*cos(x)/y**3)
```
The border service handles checks validation constraints against incoming files
use `true` as second argument avoids to use `get_object_var`
remove all call to providers for twig templates
please remove if unused
build-nova-gridcentric depends on test-nova.xml, so it'll only build after tests can bee run.
You're right. I should not have introduced 1.9 syntax in an existing public gem without a good reason. I committed the fix and asked jazminschroeder to pull it
	https://github.com/jazminschroeder/fedex/pull/10

Mike

On Jun 25, 2012, at 12:23 PM, German Garcia wrote:

>> @@ -11,12 +10,18 @@ def initialize(credentials, options={})
>>         super(credentials, options)
>>         requires!(options, :filename)
>>         @filename = options[:filename]
>> -        @label_specification = options[:label_specification] || {}
>> +        @label_specification = {
> 
> This breaks on ruby 1.8
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jazminschroeder/fedex/pull/8/files#r1045190
Comments end with periods.