Web Inspector: SourceFrame shouldn't be a View
https://bugs.webkit.org/show_bug.cgi?id=93444

Patch by Jan Keromnes <janx@linux.com> on 2012-08-17
Reviewed by Pavel Feldman.

Source/WebCore:

Move SourceFrame from being a View to being an Object. This will allow
future ExtensionSourceFrames to share a single iframe ExtensionView.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.wasShown):
(WebInspector.CodeMirrorTextEditor.prototype.willHide):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.detach):
(WebInspector.SourceFrame.prototype.focus):
(WebInspector.SourceFrame.prototype._onTextEditorWasShown):
(WebInspector.SourceFrame.prototype._onTextEditorWillHide):
* inspector/front-end/TextEditor.js:
* inspector/front-end/scriptsPanel.css:

LayoutTests:

Use TextEditor as a View instead of SourceFrame.

* inspector/debugger/reveal-execution-line.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: decouple extension server from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=94322

Reviewed by Pavel Feldman.

- relay WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged received in ElementsPanel on WebInspector.notifications;

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
* inspector/front-end/ExtensionServer.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: hovering over an image link in Timeline popup kills popup
https://bugs.webkit.org/show_bug.cgi?id=94213

Reviewed by Pavel Feldman.

- Fixed bug with ElementsPanel PopoverHelper acting on the TimelinePanel (due to which the original issue occurs).
- Image preview added to resource entries popover in the timeline.
- Extracted the core image preview building code into UIUtils.js.
- Drive-by: fixed image centering in the preview element.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._showPopover.showCallback):
(WebInspector.TimelinePanel.prototype._showPopover):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.needsPreviewElement):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
First build the image preview element if necessary, then do everything else.
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
Original generatePopupContent() code plus the preview generation when necessary.
* inspector/front-end/UIUtils.js:
(WebInspector.buildImagePreviewContents.errorCallback):
(WebInspector.buildImagePreviewContents.buildContent):
(WebInspector.buildImagePreviewContents): Extracted from ElementsPanel. Enabled building of preview elements without the dimensions text data.
* inspector/front-end/elementsPanel.css:
(.image-preview-container):
(.image-preview-container img):
* inspector/front-end/timelinePanel.css:
(.image-preview-container): Fixed centering of the preview container contents.
(.image-preview-container img):
(.image-container):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Remove alloca usage
https://bugs.webkit.org/show_bug.cgi?id=93931

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Carlos Garcia Campos.

This patch is unifying the approaches for the creation of Edje_Message_Float_Set messages, and getting rid of alloca is part of it, since it is not portable.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::updateThumbPositionAndProportion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Patch by Dan Carney <dcarney@google.com> on 2012-08-17
Reviewed by Kentaro Hara.

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This update fixes a bad assertion which caused the previous
version to be rolled back.

No tests.  No change in functionality.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::mainThreadNormalWorld):
* bindings/v8/DOMWrapperWorld.h:
(WebCore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::count):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
* bindings/v8/IsolatedWorld.cpp: Removed.
* bindings/v8/IsolatedWorld.h: Removed.
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
* bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Change font family/script on layout tests causes flakiness
https://bugs.webkit.org/show_bug.cgi?id=94327

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.

Always set the font on WebCore even if the font family is the same. It
has to be done because the script value might have also changed.
Settings::set*FontFamily() has an implicit UScriptCode
parameter that will set the script back to the defaults.

* ewk/ewk_view.cpp:
(ewk_view_font_family_name_set):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove RefPtr from DateInputType::m_pickerElement
https://bugs.webkit.org/show_bug.cgi?id=94330

Reviewed by Kent Tamura.

To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is describe in bug 94324.

DateInputType::m_pickerElement does not need to be a RefPtr<Node>,
because it is guaranteed to point to a shadow DOM tree of the DateInputType
node, which is guaranteed to exist in the subtree of the DateInputType node.

No tests. No change in behavior.

* html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
(WebCore::DateInputType::createShadowSubtree):
(WebCore::DateInputType::destroyShadowSubtree):
* html/DateInputType.h:
(DateInputType):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed trivial follow-up fix to r125873: Add missing adoptRef to avoid leaks.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::WeakMap::set):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free()
https://bugs.webkit.org/show_bug.cgi?id=94312

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.

eina_strbuf_string_free() frees the contents of a string buffer but not the
buffer, so eina_strbuf_free() must be used to free the buffer.

Contents of the buffer has already been take care by stealing it with
eina_strbuf_string_steal(), so no reason to call eina_strbuf_string_free().

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(serverCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125888 268f45cc-cd09-0410-ab3c-d52691b4dbfc