labofsahil/github-event-dataset-2012 huggingface dataset:
Once François finishes working out the last issue(s) on his fork of the
plugin, I was planning to make modifications to preserve compatibility with
MT4.X, and potentially integrate some work my team has already completed on
our private fork. This is just FYI.

----------
Charlie Gorichanaz  |  Developer  |  601am
http://601am.com  |  phone: 303-658-9157 x180

Friend us: http://facebook.com/601am  |  http://twitter.com/601am


On Fri, Feb 3, 2012 at 22:23, Jay Allen <
reply@reply.github.com
> wrote:

> You know, in the future, you COULD send a pull request to let your
> upstream know you had modifications....  Not that it did any good when *I*
> did so to the movabletype account owner.  Or that time when I submitted all
> of those issues.  Pfft.
>
> By the way, I wonder why you broke compatibility with MT 4 instead of
> simply providing a compatibility module?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/padawan/mt-plugin-field-day/commit/983c3533c77aa5831bbabf363f462400e2e42efd#commitcomment-932672
>
Hello,

This way of checking the password is quite heavy. At some point I tried to solve the issue by myself (didn't think of checking here...) and came up with this solution:

          unless  => "psql \"user='$name' password='$password' dbname=template1\" -c 'select 1' 2> /dev/null",

I'm not sure it works all the time but it worked fine enough for me.

Best regards,
Dominique
A string is null-terminated in C, snprintf returns the length of the string without the null byte.
ModelAdmin work is slated for this week, to be finished before beta at the end of this week - so I doubt that we'll have time for this refactoring.
What I forgot:
Thanks SirLensen for notifying...
an example linux failure:
  http://d.puremagic.com/test-results/test_data.ghtml?dataid=141088

an example win32 failure:
  http://d.puremagic.com/test-results/test_data.ghtml?dataid=141047
You sure are picky @Kieldro !
You should rather use $conf['metadir'] instead of the fixed path here (it is set in inc/init.php).
Epic fail. I will change code.
this is fun and just found its way to the top of my todo list.  first up is tracking of the status bar background as it is expanding. the over shoot is absurd
Had to remove some GWT modules to get onebusaway-webapp to build...
I didn't test this. Figuring it might be in the context of a Rails example, but if Sinatra has a render call, we should replace it with that.

--
Hector

On Feb 28, 2012, at 10:48 PM, Jamie Ly<reply@reply.github.com> wrote:

> I'm wondering about why you created this helper versus using 
> 
>    = render :partial => "about"
> 
> in the haml. The example is from the bottom of [the HAML Tutorial](http://haml-lang.com/tutorial.html).
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/CfABrigadePhiladelphia/the-other-philadelphia/commit/d94cf63a41e47b10cde9086083f4b29d6f4f56ba#commitcomment-1024224
Ah OK, was wondering how that would work. Can I just add a new message key to locale/en_US/locale.xml and not worry about adding it to the other locale files? What happens then if/when using a locale other than en_US?
I want to omit such create methods too. When all information is collected to build an object out of it use the constructor. In constructor you have to initialize all attributes with valid values and your object has a valid state. I like endJunctions version very much.
should be modify_sql (verb first?)
It's better to put this into the "if (node == delegateNode[0]" block. And, to be perfect, create a new function named selectDomNode, which is called by this and setSelected().
Why don't you add commit to this PR than?
This wants to be `TestColouring` I guess?
I was struggling with java interop, but it was the sealed trait that was the problem, not the return type, so I have changed to `MemberStatus` here, thx
I'd suggest:

    val xcgPattern = if (oneWay) ExchangePattern.InOnly else ExchangePattern.InOut
    produce(transformOutgoingMessage(msg), xchPattern)
Ok, I just found the treatment a bit "terse". I think it's ok for now.
Alright!

How do I specify which ExecutionContext the callback will be executed on?
Please use infix operator notation for higher order functions (Scala Style Guide):

```
system foreach (_.shutdown())
```
Let’s call him Fred. Or Barney.
If it isn't done automatically I'd like to have a comment explaining why the order is as it is.
made the ConductorHandler `private[akka]`
we should add the scripts/fix-protobuf.sh to the instructions, or better, make a script `generate-protobuf.sh` that does both proto and the fix
yes, that was what I *tried* to say, thanks for clarifying ;-)
Ah. What if I use a different placeholder (null?) to represent
inst.receive?

sRp
On Jun 12, 2012 10:39 AM, "viktorklang" <
reply@reply.github.com>
wrote:

> > @@ -521,10 +521,7 @@ private[akka] class ActorCell(
> >        if (instance eq null)
> >          throw new ActorInitializationException(self, "Actor instance
> passed to actorOf can't be 'null'")
> >
> > -      behaviorStack = behaviorStack match {
> > -        case `behaviorStackPlaceHolder` =>
> Stack.empty.push(instance.receive)
> > -        case newBehaviors               =>
> Stack.empty.push(instance.receive).pushAll(newBehaviors.reverse.drop(1))
> > -      }
> > +      behaviorStack = behaviorStack.map { b => if (b ==
> Actor.emptyBehavior) instance.receive else b }
>
> so if someone does:
>
>    context become Actor.emptyBehaivor
>
> they mean
>
>    context become receive
>
> ???
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/534/files#r967890
>
Oh, just a mod to the ok! and ok?, sounds fine to me.  I think I'll wait 'till fewer plates are in the air to add it anywhre.
I would add a test that checks that a SiteCollection when used as a container of Sites, actually "lift to the surface" its Sites, especially if a client calculator relies on this feature.
Use brackets to distinguish operator order.
Hmm, problem here are None values. urllib cannot handle them.
But you are right.
urllib.unquote(string) if string else ''
Have you tried it? I'll check later.
I think so.  When running the unit tests on the developer workbench, it's reasonable to assume that the setup.py has been run or pulp packages symlinked to site-packages in some other way.  But, what about other environments or circumstances where we want to run the tests?  Seems invasive to require that site-packages be modified in order to run the unit tests.

I think we insert 'platform' and/or 'rpm_support' in most of the unit tests.  Seems that whatever we decide here should be applied across the board.
Can you change this to allow_multiple instead of pluralized and comma-separated? It'll be cleaner and more consistent; --event-type already supports this model so we should use it in all places.
We should be able to enumerate these from a simple card search now.
sounds like this is mysteriously working.   seems a little fragile.

why not `@dependents ||=`?
Why?.. when av_find_stream_info ends. We have found the streams that should be available. If things change after that we need to push it out as a packet. The buffered packet is a better approach than this.
Да, точно.
Map?
Bag later ?
I'm not 100% clear about this.

It seems that I could follow the letter of this comment with this code:

    return Proxy.create({
      get: function(rcvr, name) {
        // ...
      }
    }, Object.getPrototypeOf(item));

But I don't see how that would help because the prototype of `item` is {}, so it can't help with enumeration.

The advice is unclear to me:
* https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Proxy includes the scarey "To make sure no error is thrown when your object is used, you have to implement at least all fundamental traps.", which I'm certainly not doing, but then it's got several examples where the code does just what I'm doing.
* http://soft.vub.ac.be/~tvcutsem/proxies/ has examples of both what I'm doing an of using getPrototypeOf

My gut reaction is: Yes: this will break if you try to alter/enumerate/throw/etc the Proxy object. So don't do that.
I accept that this isn't a great answer however, but it does seem better than a false sense of security from adding getPrototypeOf or the huge expense of implementing all fundamental traps. I have a feeling that there could be option 3 that I'm not aware of.
Shouldn't need a factory if you do interned correctly, right?
I just tried the `QGraphicsView::AnchorUnderMouse` thing.

I did not quite do what we want.

Because, what we really want is not actually using the mouse/gesture postion as the anchor point for the transformation, but just recenter the view so that the mouse/gesture position stay the same as before the scaling occur (so the highlighted tile stay under de mouse).
Or the SslSettings should be optional. Good point.
This number conversion is possibly contentious because of the vague typing - however, I would argue that returning some value is better than null!
`selectionColor` should just default to this color.
Singletons should be [implemented with GCD and blocks](http://stackoverflow.com/a/2202304/515514), which is more thread-safe and helps avoid any global variables.
Oh my god, I'm going to shoot Xcode.
Do you not use Bundler 1.2.x? Anyway please don't change that :)
Premature optimization, probably even a deoptimization when `.listeners()` returns a copy (which is likely going to happen).
i just thought that the data one wants to store or read from pd arrays are more general and a programmer will have this as an array. but sure, he would also be able to just read that from a file or the audio in... in that perspective its the same and the array methods should also have ref floats...
maybe we should add a argument to the constructor to tell if we should use the try or set methods as we should either use try on both or none of them.. WDYT ?
Is clearTimeout required inside the function which executes the timeout?
вообще хочется как можно больше всего из mainwindow вынести такого, без чего оно прожить сможет
It's not particularly clear to me the difference between these two tests =(. I'll have to check their implementation later.
I'd prefer to keep these as `assert_equal` - the error message is better.
We prefer to mix, because change the whole file will invalidate pull request that touch the file.
This whole algorithm seems really sketchy to me; why delete keys and add new ones, when you could just make a new hash?
The reason I am forcing to a symbol here is so the test suite doesn't go nuts. There are apparently a lot of expectations sprinkled throughout the test suite that require a symbol. If I don't do the typecasting the suite throws 479 errors. I figured I'd err on the side of less changes.

Let me know how I should handle.
mapValues
I'd vote for a typeclass approach.
When you give a name to a variable like this you suggest that it has some function, like counting something, but you aren't...so this is confusing. Please just use the typical i-k symbols for indices.

You can also use the .is_Mul and .is_Pow methods.

You really need to put some sort of inline comments above the block to tell what you are doing. For example, I can't imagine why you don't just do the subs on the whole expression rather than doing it term by term.
this should go to augeas wrapper class. I think we should have constants near related code.
when adding a parameter you should add `@param` description to docblock.
`@since 1.1.13`
Don't think so. Table creation expression won't be executed unless exception thrown. And more, deletion expression will never delete the table—it's just a way of detecting table existence with exception throwing ability.
Yes, I would move this claim mapping to its own method. If we want to do this generic, the input would be the IClaimsIdentity and the output the JabbrIdentity (consisting of email + userIdentity + username). I would have by default a generic implementation that looks like this

```
private static JabbrIdentity GetInformationFromClaims(IClaimsIdentity identity) 
{
   // search first for the regular Email claim and if not there search for EmailAddress claim
   email = claims.Email ?? claims.EmailAddress; 
   // try nameidentifier, if not name if not email
   userIdentity = claims.NameIdentifier ?? claims.Name ?? email; 
   // try first with name claim type, if not first name, if not email
   username = claims.Name ?? claims.FirstName ?? claims.Email;
  
   return new JabbrIdentity { Username = username, Identity = userIdentity, Email = email };
}
```

Not sure if JabbrIdentity is the best name, it's probably ChatUserIdentity which is a subset of ChatUser.
remove one of these blank lines
Wouldn't self.make_default! work?
Not putting the comment in code keeps the compiler happy (formatter is guaranteed to be initalised), but leaving it out altogether doesn't make it explicit that we're only handling date and datetime between the two branches.  I could uncomment and add a third branch to catch the unexpected (should be unreachable) condition, but that seems a bit of messy overkill.
Ben points out that we need to allow this method to handle incremental event-style parsing, such that we're being passed parsed objects, rather than querying up the stack with the input stream, and then back down again. So, it becomes more tell-don't-ask.
why wouldn't the LoadQueuePeon handle the case where the segment has already been queued for dropping?  I'm pretty sure you're introducing a race condition here that didn't exist before.
You need to initialize this in the other order.  Register the listener *first* and then take the current state and put it into this set.  Otherwise, there's a race condition for things that are added after you populate the list and before the listener is registered.
not useful to link to things in headers.
Write all files in a subdirectory and nuke everything in that subdirectory.
Please make them into 11 lines then.
`$this->...` is undefined as per my other comment.
Surely jquery provides this.
20012 -> 2012
I think I fixed all this up in 98fb3ed9
Sorry for not chiming in sooner and pointing out this style / consistency issues:

* `cb` -> `callback` - afaik that's the convention we use everywhere else
* All the function names (besides the test names) should be camel case
* return should be on a separate line:

```javascript
callback():
return;
```
REQUIRED keyword stands for stopping the configuration process in case the package wasn't found (i.e. X11_X11_FOUND and X11_XRandr_FOND are not set).
Can you not put this in the `tilt` file? Since it's going to be the manifest file once we can figure this shit out.
I’m not. It uses 3rd-Party API and is part of the implementation, not the public interface
This is the worst part of the implementation because I am not sure how it works. I ported it from a python script I found here: http://blog.hackers-cafe.net/2009/06/how-to-calculate-bezier-curves-bounding.html

I tried understanding the math on the article you linked to but in the end, after struggling, I grabbed this and ported it and it seemed to work.
I originally tested this in multiple browsers. It only works in Chrome? If that is true then this isn't a good fix.
It might be better if the handler is `function(err, obj)` and then it can call `adapter.error(err)` instead.
Ok thanks for that extra info!
What is update.sh for? It doesn't seem to be referenced from anywhere.
is screener always the default?
this ticket is closed. is it a problem here?

p.s. if you copied this store, is there anywhere else we could put it in the tree to make it accessible to both Screener and OPD?
On Thu, Aug 2, 2012 at 1:34 PM, lamblin
<reply@reply.github.com>
wrote:
>>              {
>> -              assert (self->n_output_vars >= self->n_updates);
>> -              Py_DECREF(rval);
>> -              rval = PyList_New(self->n_output_vars);
>> -              for (int i = 0; i < (self->n_output_vars); ++i)
>> -                {
>> -                  Py_ssize_t src = self->output_vars[i];
>> -                  PyObject * item = PyList_GetItem(self->var_value_cells[src], 0);
>> -                  Py_INCREF(item);
>> -                  PyList_SetItem(rval, i, item);
>> -                }
>> +              Py_ssize_t src = self->output_vars[i];
>> +              PyObject * item = PyList_GetItem(self->var_value_cells[src], 0);
>
> At first, I checked the content of var_computed_cells, I'm using var_computed, now, and it works.

Good, I'm relieved :)
@pascanur is that normal that this is commited? @goodfeli is that change fine? I'm not sure, bit my guess is that this shouldn't be changed without other changes too.

@pascanur if you need this change, there is a need for a test for this.
spelling "elapsed" (2 places) also find and replace "infomation" => "information"
Uncharted.
Would be simpler/faster to test allowMismatchedResults here and bypass the whole comparison process -- not even bother to initialize curr_results.
XMLConfigManager is dead code cloned from INIConfigManager, but never implemented for XML or wired up and used. I deleted it.
2 blanks
oh no! how stupid am I!! sry
```coffeescript
vendorPath = sysPath.join __dirname, '..', '..', 'vendor'`
path = sysPath.join vendorPath, (if isAMD then 'almond.js' else 'require_definition.js')
```
Yes, look at tests.calculators.hazard.classical.post_processing_test.MeanCurveCalculatorTestCase (test_run and test_run_with_weights)
I see. I am cool with that. But what do you think about keeping sentences instead of paragraphs on a single line?
OK for now, since we currently do not have a Python "abstraction layer". But that should be used eventually, of course, instead of duplicating code.
Well, ereport doesn't solve the problem...

One way to easily to do that for short term is to make a postgres-ish function and wrap it by PG_TRY() ... PG_END_TRY() and return AnyType from there.  An example should look like

```
AnyType SRF_next() {
  Datum result;
  MADLIB_PG_TRY()  {
    result = call_your_c_function(fcinfo);
    return AnyType(result);
  }
  MADLIB_PG_DEFAULT_CATCH_AND_END_TRY;
```
and in your c function, you can call elog()/ereport()/palloc() and everything you are familiar with.
don't think you need this (also, it's not built into the dist js)
Just proper indentation according to the rest of the file, nothing changed here.
Adding an if branch to support Windows versions of sh and bash, such that the dev bundle generator can be ran of any sort of terminal on Windows.
I think originally it was a definition list, but i changed it because I would otherwise have to restyle it to take less vertical space. The Kitsune admin page is pretty long, so saving vertical space cheaply was helpful.

In this case, the page is pretty short (it'll get longer soon), so it could go either way. I think I'm going to contend that this is valid as tabular data and leave it as is.
I'm working on it. I'll make another pull request for that .
That's handled in FormulaInstaller; this is just the straight dependency processing code.
Mind adding a comment to note why these lines are necessary?
$apps = $result->fetchAll() is a bit cleaner
shouldn't this be self::eTagUpdate
I mostly just copied them from the original user guide, with very slight revision. :)
I understand it's easier like this, but we should use toThrowType to replace tests like this whenever we have the chance.
getFullPath() koennte dann in getUrl() umbenannt werden
sure we will extend this section. I am open.
@Tibor17 Good to hear! I think it might make sense to check-in those integration tests you setup. What do you think?
In what cases will this be called with a suite that's filtered out?  It is correct to also skip updating the "All" item in those cases?
Why are we using an invalid attribute?  Would this still work if it was `dir = rtl` instead getting replaced with "ltr" ?
Indenting is not correct. Brackets uses indenting of 4 spaces.

Be sure that View > Enable JSLint is turned on for Brackets code -- I think that would have caught this problem.
Can you construct a new menu item and command for this test instead of relying on the JSLint command? We should test checked state at menu-item creation time as well to make sure it initializes as expected.
Also from the original code--is `result.reject` bound to `result` by the promise code? If not, this looks like it won't work.
Yeah. Unfortunately there is no Date type in JSON, so we would need to roll our own.
`mkdirP` used to take 3 arguments. Did you check what permissions get revisions written with now?
Undecided. I'd rather a pure sqlalchemy-based approach, unless the resulting code is far more cumbersome than that which migrate provides.
Your last commit looks good.

Also, do you think it makes sense for `new_salts` to have the following signature?

```c
uint32_t *new_salts(unsigned int num_salts);
```

and then, in this function it would be used like:

```c
bloom->salts = new_salts(bloom->num_salts);
```

Essentially, I don't see any reason for it to *have* to take a specific structure as an argument.  I realize this function is only used once but this makes it a bit more agnostic to the type of bloom filter (otherwise I would argue it should be named `counting_bloom_new_salts` or just be brought into `counting_bloom_init`)
That is not how requestAnimationFrame works.  Your browser schedules a repaint, and the callback gets invoked right before the next repaint, but after an unknown delay.  You have to figure out what frame you should be on in your callback and draw that frame.  setTimeout has no guarantees with reference to paint cycles and as such is not suitable for animation.  I refactored the repeatAndCleanup() function to make it more readable, and I removed the time-so-far argument that requestAnimationFrame sends to the callback (because that functionality may evidently change and is likely not well supported across browsers).
This is the same as the default, isn't it?
these two strings seem basically unused.
Don't use `is` for numbers. Use `==`.
What is NextClip(1) going to do? Is the 1 something that should also be an enum?
You could add

local active_qtab
omg how has this code landet here ...
Make this all not on one line.

<pre>
if (  popcornOptions[ item ] ) {
  dropTarget.style.backgroundImage = "url('" + popcornOptions[ item ] + "')";
}
</pre>
<pre>enrionment</pre> -> <pre>environment</pre>
I think this function isn't used anywhere ever for anything.

Can we destroy it? It's old and slow.
why do I suck so much at whitespace
why return here? This is inside the `db.del` method, so theres no need to return. The comment above also suggests that `exports.remove` returns something, but it returns undefined.

Also, while you would usually want a callback for after `remove`, if someone didn't care, it should be legal to `things.remove(myKey, db);`. Currently, that will error because trying to invoke an undefined callback.
internal param is not used in the method
Thanks for the advice. I updated the code on commit 85c8fa0. I also make it as option in config file and is enabled by default. Refer to commit 85c8fa0.
You have some unmerged lines here
Oops, I'm late on this one ;)
Not a huge fan of the `for(..)` syntax. might be clearer as something like

```
span.serviceNames collect { case name if name != "" => serviceArray.add(name) }
```
Uhm, it already is in utf-8. See line no. 1
We have a calculator of thin processes for Katello. It may be worthing integrating this so both values are (correctly) calculated from free memory.
redcarpet is all in epel and fedora, not need to remove anything
No optional params in C#, add an overload.
Is there any reason to wrap the ul in a div? The fact that you call the div "tabs-list" suggests it could just be the ul. How about removing the wrapper and giving the ul an id of "tabs"?
The entire OptDict is gone now.  Good riddance.
This should use the optional dependencies decorator @eteq is working on in #476 when that is done.
Agreed - as we're so close to the wire I'd rather wait until we have the opportunity to refactor the sim to use more of the staged claim.  Would be nice if there was a flattening list comprehension.
Digging in to why we ned this function, turns out that this test is written in a way that would fail in a non-devrel scenario.
As I know there is no space before ':' in German, I can ask to Elisabeth tomorrow to confirm that.

And this space should be in labelSeparator: http://docs.sencha.com/ext-js/3-4/#!/api/Ext.form.FormPanel-cfg-labelSeparator

It should be an unbreakable space '&nbsp;'.
This line still doesn't appear to have been deleted in the amended pull request. It does something that is rendered irrelevant two lines below.

```
         maybe_offer->trans().resource()->setQuantity(requestAmt);
```

Can you respond to this?
Minor style nitpick, the final `"""` go on their own line.
Don't we need that any more?
`util.RNG` will come in handy here.
Fixed. 

I would prefere to make the codemirror configurability in a separate PR.
The try / finally block makes it difficult to split this method in two tests and keep things easy to understand.
this is nice.  can you also add a different test which only tests encode w/url safe (ex. outside context of TokenRequestFormat, probably called Base64UrlSafeTest)
@mdale Is there a way to extend evaluate api on the plugin code instead in KDPMapping? ( like what we're doing in setKDPAttribute )
I'll do that as part of finishing the handling of links.
`char * buffer` and `size_t buf_len` is what we've been doing lately.
PEP8: Mindestens zwei Leerschläge vor Inline-Kommentaren.
If these `console.log()` calls whose message starts with "DEBUG" are intended to be debug-level log output, you could instead log them via `console.debug()`! We don't yet use that method elsewhere in the codebase, but we might as well start doing so (along with `console.warn()` and `console.error()`, where appropriate); especially since SDK 1.13 will have support for setting a log level, with the default level for `cfx run` being *info* (which will show messages from `console.error()`, `console.warn()`, `console.info()`, and `console.log()`), while the default level for an addon installed by a user is *error* (which will only show messages from `console.error()`).
Hmm so I am not at all against having some basic info in the README, but the canonical place for this to date has been http://socorro.readthedocs.org/en/latest/ so we should try not to have too much overlap there (or else one side is going to end up out of date)

I know @lars was planning to add some dev info to this as part of getting configman apps ready, maybe he would like to comment or take this part.
what behaves weirdly here? this will need to be remain in the output for users; I have a custom version fo clint; I am maintaining that should fix unicode issues. But I dont think you are running into this issue here.
Identation seems wrong here now.
I understand adding the escape param, but why'd you remove the default ASC?
PHP 5.4 needs this.
The jira just asks whether the 2 links should go to a page on rsmart's website. The above is the link to the "Contact Us" part of the rsmart website. Would it be better to just point it to www.rsmart.com?
Space after `function`.
wrong indentation here. It should use 4 spaces
This is a BC break as it changes the attribute name
This is not valid anymore. It should instead assert that the normalier is not called. Like `$this->fail()`
`ltrim()`
You should convert your listener to a proper subscriber as done everywhere else in Symfony core.
you should add use statements for the class themselves to be consistent with the Symfony codebase
Why can't you run this as the postgres user as before?
Were you just ```mock```ing about ```mock```?
We can't use ```mock``` in Python2.x without an extra 3rd party package?
Or were you suggesting we make a ```mock``` ```mock```?
Should this be <code>/tmp/tmp.xml</code> for the default?  Better yet, how about os.path.join(test.tmpdir, 'tmp.xml') so directory is not hard coded?
А это мы с Семёном сказали, что неплохо бы, но не обязательно =_)
Зря?..
Stupidity will get you no where
I have the code that you changed but it didn't make sense at 2am in the morning.
I will work out either a) if it is a proper fix and thus use it or b) if it's a hack related to the current 8s hack then of course I need to determine how to fix it properly
The current code only affects the displayed hash time - it does not reduce the physical hash time of the Icarus.
However, setting that value to the correct amount did in the past (as you know) actually reduce the real hash rate of the device.
The multi-line version includes a header, footer and the who/what/when titles for each line, so i think combining them would be more complex than necessary
Can you shed some light (in the code) on why we need to branch this and do different processing based on number of entries.
Also, regarding your concern that this is happening only on `end` - I think that's okay. You could do some complex event counting and do the parsing incrementally somehow but I think that's too complex for no reason.
Why does this have a dependency on ember-views?
makes sense, I don't like end() as it does not fit.
maybe complete() or parent() but none of this feels right.
i will rename to pushChild() pop()
I don't want osgi to have a dependency on jpa. The osgi/integration module has that. For module configuration purposes however I need to know in osgi whether I'm dealing with some type of EE deployment that has hard wired module deps.
See my reasoning for outputting the value: https://issues.jboss.org/browse/AS7-5800?focusedCommentId=12728060&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12728060
I don't actually see the nesterov_momentum flag used anywhere in the "Files changed" view.
Remove dead code!
So that means we need `DEBUG=0` on `ifdef DEMO` ?
Same here we could improve readability removing an indentation level
I will say 300 is a more reasonable time, but you can keep 500 and ask for UX feedback.
You should add callback as in renderMessages. Using it you could ensure that hash change will occur once we have render everything properly.
Should we rename the files to avoid spaces?
The name is ambiguous. I recommend this to be renamed `TrustedDialog`
You don't really need to prefix the files names with fb_ since they already lives in a fb folder.
Should probably put this in the application layout.
That's just what YAML dumps, it isn't mandatory at all when reading data in.
Delete it here is it'd there for no reason?
We could refactor the test suite, most of the errors are (I hope) due to multiple add of new objects of the same class, without properties defined, but that would mean a huge BC break.
As noted in other PRs, it would be great to define "query_params" in a doc block.
This should be in another method, the first part is doing one thing and this part it's doing another thing. I think that would be good if there are separeted.
I think it's a little confusing that you've got some examples named "foos/bazzes/bars take X" and others are named "nth example".  It'd be nice to have a consistent naming scheme here.  Maybe something like `it "sleeps for X seconds (example #Y)"`? (where X and Y would be filled in for the specific example)
Although actually I'd put it differently, it's your visor version which is too old :)
I feel it should be `AuthorizationView` (we already used `PublicationView` instead of `PublisherView` ... )
You're right, I'd missed that, thanks.
I don't really know what I was thinking here,  if time/halfLife > 1023, this will overflow to infinity.

I think we are going to have to use the log-space, as we do in DecayedValue.

So, I guess it is a false generalization to make F anything where we don't have an exponential function on. We could get insane and make an trait Exponentiator[A] { def exp(a: A): A }, but honestly, I guess we should just fix F == Double for now. The reals are the only case we are going to care about here, and the Double representation is going to be fine for numerics.

Sorry I lead you down the blind alley.
Having the CoGrouped2[K,...] also have a TupleGetter[K] in the constructor would help.  It means when we construct we need to pass down the getter for K, and then we resolve it at compile time at the location where K is know.

I think for now it is actually okay, but if cascading does more work to have primitive tuples, it could be worth it to improve.
upvote for groupRandomly.

Also I like adding pass to GroupBuilder as Avi suggests, which can be this takeWhile(0) hack that is also repeated in groupAll.
+ needs to be in the brackets, this matches one character.
I'm sure you can.
I believe the delete cooldown is based on posts lifetime, not on the latest submission.
```html
<pre class="prettyprint">
  <span class="quote deadlink"><span class="pun">&gt;&gt;</span><span class="lit">298802</span></span><br>
  <span class="quote deadlink"><span class="pun">&gt;&gt;</span><span class="lit">298802</span></span><br>
  <span class="quote deadlink"><span class="pun">&gt;&gt;</span><span class="lit">298802</span></span><br>
  <span class="quote deadlink"><span class="pun">&gt;&gt;</span><span class="lit">298802</span></span>
</pre>
```
Should we even be reporting this?
The Router module will load the Route module before the spec runs, so it’s not possible to mock Route easily (apart from overwriting the Route module before loading the Router module). I’ll look into this.
Yep. Typo.
Fixed in latest commit.
Thanks!
It's already fixed in the master branch
you should also add the ``-o`` shortcut, like in ``dump-autoload`` (especially as the option name is even longer here)
@kouno can you explain why you need to split merge request and commit discussions here.
Wouldn't it be enough to have a flat list with discussion ids, because the noteable_type is included in it?
Of course. Squashed or second commit?
Again, this is weird.
It was my understanding that,  stylesheets/scripts placed in the first block of the Main template declaration get injected into the head on compilation, and only for this template.

The reason why it isn't/can't be in the the bootstrap process,  is that we *only* want to load this script on article pages that *are* live, hence why I have wrapped in an if statement here. And we don't have access to that page meta data until the config object has been generated at the end of commonJavascriptSetup.scala.html . And as it isn't an AMD module I can't require it in at a later date.

Therefore, this seemed like the most viable solution, but I could generate the script tag and append to body inside by modules init? and thus satisfy our JS acceptance tests.
How 'bout

```@fragments.dateline(new DateTime, false, Edition(request, Configuration))```
Looks like gzipping has been rolled back from production. It was not the only thing that went out and story packages were not working.

Need to uncomment after it goes out.
Well, it make the error handling more complex but you may be right.
@studioromeo  Meaning JIGOSHOP_OPTIONS?
Yes and yes. How do I do that?
Nit: For one liners we keep them on the same line `if (!stack) throw error;`
I actually tried to remove it and got an exception when trying to access .logged_in_user_email.  I concluded it was necessary, but I agree it sucks to add technically unnecessary work (page load).  Ideas to allow home_pg to extract logged_in_user_email without a navigation?
If you want to remove the 4 ttys, you need to change this
That code is not awesome, but it shouldn't have a problem with how those class variables are used.  Refactoring it is interesting but not necessary to tie to the 1.9 series support.
Describe what is computed. `"can handle"` is meaningless.
Why do we need `to_s`? Seems that we'll get `"nil"` string if `yield(f)` returns nil.
I think this could be

```scala
for {
  name <- r.getHeaderNames.iterator
  value <- Option(r.getHeaders).flatMap(_.toSeq).getOrElse(Nil)
} yield (name, value)
```
yeah we'll definitely have to refactor that part, I thought I was going to have time but I lied hahaha. might be able to get to it today
ok i will do it
Type could also be 'multicheckbox' without underscores.

Fieldset works for me. I agree about the semantics of legend vs. label in this case.
```php
$validator = new NoRecordExistsValidator('users', 'field1', 'id != 1');
```
This feels backwards to me.  Specifying `ARRAY_HYDRATE` returns an array extracted from the hydrated object whereas `ARRAY_RAW` returns the hydrated objects themselves.  Should the naming be flipped, or am I misunderstanding the terminology?
Again, this is not view related. I'd actually put it at the top-level of the Mvc hierarchy instead.
Fixed.

AGAIN.

:P
good catch, we should put the meta back into place, however it was not working anyways as the separator before was 
\ where it should have always been / since we run things on linux knpbundles.com of course not people desktops
Do these actually need to be cloned here? I think the surfaces are already being cloned manually before being passed in
You could reverse the boolean test, and make it a test for truthiness, removing the negation operator.
Can you add a short description of the framework?
Yeah, users of non-history-compliant browsers will have to press the refresh button, but i don't think that's the end of the world.
Instead of creating an array, append to a string.
Yes, this is btw about creating the collection object itself (isn't there at proxy instantiation). 

Lemme know about what I should move to `hasField`, since I don't have any idea of what all these funny things mean in PHPCR :P
Git uses a similar comment "syntax" to mark html comments containing data.
This is the comments section of a html imagemap generated by gimp:

    <!-- #$-:Image map file created by GIMP Image Map plug-in -->
    <!-- #$-:GIMP Image Map plug-in by Maurits Rijk -->
    <!-- #$-:Please do not edit lines starting with "#$" -->

    <!-- #$VERSION:2.3 -->
    <!-- #$AUTHOR:Florian -->

Couldn't find any other evidences for this, though. <!--# is really hard to google. >.<
I think it makes some to distinguish metadata comments from other comments this way. But is this really needed? No idea what the original author thought..
Yeah, let me know if there is a way to make it more clear. I suppose if we add settings for the output paths then we should mention that as well anyway so separating that out into another paragraph definitely makes sense.
Remove too much empty lines.
group sourceURLs and sources together
First, we import the JBoss AS parent POM to manage dependency versions:
Same issue with spacing after function here.
you should remove the second argument as it is its default value
Yea just change from get operation to get method

On Sep 15, 2012, at 11:31 AM, Michael Tewner <notifications@github.com> wrote:

> In src/com/googlecode/jmxtrans/model/Operation.java:
> 
> > +
> > +
> > +public class Operation {
> > +	private String operation;
> > +	private List<String> parameters;
> > +	
> > +	public String getOperation() {
> > +		return operation;
> > +	}
> > +	public void setOperation(String operation) {
> > +		this.operation = operation;
> > +	}
> > +	public List<String> getParameters() {
> > +		return parameters;
> > +	}
> > +	public void setParameters(List<String> parameters) {
> Not sure I completely understand. Does the Jackson give me that?
> 
> —
> Reply to this email directly or view it on GitHub.
>
disabled is removing it entirely from the list.
the request was "deprecating/removing 1.8"
that's true,if settings["copy_files"] is enough
Get rid of the deprecated `CoverageCraft`
Hi brainwane! No rush, but since you're doing this, could you expand the second instance of "ff.net" into "fanfiction.net" too, please? :D
NGHUTPR
Since all these tests are in the same TestNG style test class this can be an instance variable instead of a global.
partialはrails2系の記述だったのですね・・・
It adds to it, I checked and the validations are independent.
Are you saying you want to create a dashboard model?
not a big deal, but i think it makes more sense to be a method vs a class variable
At first I thought this was HTML special chars, but this makes me think that it's actually DocBook format https://www.oasis-open.org/docbook/documentation/reference/html/iso-grk1.html

Any thoughts how to reasonably unescape these? I guess we can make an unescapeDocBook utility function with a "simple" character map, though I would not want to resort to it.
Well if we get an ArgumentError we still skip the shim, just not for an expected reason. I can get rid of the whole rescue, though, since there's not an expected exception.
function to find the global settings file should be a separate function as it is found without any of the parameters of this global_settings function.
Please actually fetch teh creative and ensure it was properly created.
This is equivalent to

```ruby

if user && password
```
что в этом файле за бред?
an additional
Shouldn't that update be before pkg.versions.all().delete()?
I'm still tempted to just pass the provider + user login as 2 arguments, rather than merge them into the object. It feels like it just makes the internal API harder to use.
i will drop this empty lines
please use `assert(str == "$HOME")` instead of proof file
krijg als ik weltmeister open de error:
**Uncaught TypeError: Object [object Object] has no method 'spawnEntity' **
@slebedev кстати, еще вчера ты про эту строчку говорил так: «На данном этапе хватит того, что вы насильно приравняете в этом случае length к 0. Что-то типа if (length<0) length=0;»
Не возьмусь утверждать как будет правильнее.
Какие могут возникнуть последствия при сравнении с помощью "!="?
Да, Вы правы. Исправил, спасибо.
И при замене 100% происходит ошибка
Для этого достаточно реализовать метод description у класса, необязательно нам иметь доступ к DNA для этого.
nit: eliminate empty line above and add new line after your name/email.
making a comment on another comment
Fair enough. I think I'll have to call it something other than a boolean mask, though, since that would be the opposite behavior of what I'd expect from a mask (where values with the mask as True are kept).
thanks, right!

On 26.12.2012, at 14:44, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/preprocessing/tests/test_ica.py:
> 
> >      ica.decompose_raw(raw, picks[:5])
> > -    assert_true(ica.n_components < 5)
> > +    assert_true(ica.max_pca_components < 5)
> you're testing something different here
> 
> —
> Reply to this email directly or view it on GitHub.
>
change to: "When specified, only job enteries that match the filter value will be returned"
I get the following error on this line when running the canny example:

> Traceback (most recent call last):
>   File "/Users/Tony/python/devel/skimage/skimage/viewer/viewers/core.py", line 127, in save_to_file
>     overlay = im1.cmap(im1.get_array())
>   File "/Users/Tony/python/devel/mpl/lib/matplotlib/colors.py", line 561, in __call__
>     cbook._putmask(xa, xa > self.N - 1, self._i_over)
>   File "/Users/Tony/python/devel/mpl/lib/matplotlib/cbook.py", line 1853, in _putmask
>     return np.copyto(a, values, where=mask)
> TypeError: Cannot cast scalar from dtype('int64') to dtype('bool') according to the rule 'same_kind'

The overlay is a boolean array, and I think the casting rules changed in recent changes to numpy (which might be why you're not seeing the error).  If you cast the output of `get_array` to `uint8` or `float`, it works fine.
Sass warnings don't always make it through this gem
Won't this duplicate a lot of information?

The tree contains all the tests, and the reports contain them all again (as the keys, but obviously not in a nested structure).

Maybe you would rather walk the tree and replace each node with 
```clojure
(vector thistest (@reports thistest))
```
what if there are multiple spaces between the two?
So I guess `content` won't be simple metadata after all. This would have allowed us to treat files like simple key:value collections. I suppose you had your reasons for making `content` special, but I hope it's not because of syncing (metadata is also synced).
I think that too, but I was following convention from other slovian language, see ru trans for example
Did anything change here? I can see... maybe a title was added?
This gives an IndexOutOfRange exception, if there are less than 3 tokens. Please always expect malformed input when writing code dealing with file/user input.
I feel like the methods internalDb() and externalDb() should be merged into one method and check the setting inside the method. At least I see no other  usage of those 2 methods in the diff.
The indenting seems weird here.
single quote for keys
`CancelCommandCommand`?  :)  Why not just call it a `CancelCommand`?
What about using "gdmd" instead of "gdc". It's a script that converts all dmd flags to gdc flags.
:+1: I dig that.
Since it's not a `size_t` anymore, it'd probably be more appropriate to cast this to `NSUInteger` here, assuming that a cast is even needed.
Sorry to be picky, but could you add a space here? So that it reads `fig, (ax, ax2)`?
Nice tip!  I like it....but, in this case, I would rather see the unused variable stay as is, as a reminder to future readers that "maybe" it should be used.  The "_" implies that it "definitely" shouldn't be used.
good rename :)
Mind humoring my American-centricness and s/centre/center, here and elsewhere?
Sorry, I still don't understand what the advantage would be to make this a separate function. This is simply a Python for loop, and is two lines of code.. The function plus the call would make it four lines of code, and would essentially be wrapping a Python for loop. I suspect I'm misunderstanding something, so would you be able to give me perhaps a code sample of what you're proposing?
I found a way, how I solve this. I greated a abstract proprety (getter) with has to be overriten in the sub classes. THis proprety is read only, so it is a like a const
This is repeated in `js/osticket.js`. Should this just be put inside the `js/jquery.multifile.js`?

```js
$(function() {
    $('.multifile').multifile({
        ...
    });
});
```
same remark about the PEAR coding standard for if statements : this is how it should be done : http://pear.php.net/manual/en/standards.control.php#standards.control.splitlongstatements
Can you add a line or two of docs to these tests?
This was useful while reordering. Can remove it now.
I think focus should be implemented by attaching it to the existing "data" argument. This has the advantage of being available on the handleStateChange() callbacks, so no setTimeout() workarounds required. It also means that its "replayable" if a user navigates back and forward in history.
I have left the things which relate to the framework buttons (mostly removing unnecessary duplicate code). I have reverted items not related to overall buttons.
https://github.com/spiral-project/daybed/blob/master/daybed/tests/test_functional.py#L89
These `FontRuler` instances (which I love) are now actually reusable, right? I think we could name these properties something better, like `fontRulerA_` and `fontRulerB_` perhaps? Also, you could instantiate the rulers with just the default fonts, record the values for `originalSizeA_` and `originalSizeB_`, and then set the font stack to include the main font family. This would reduce the number of `FontRuler` instances you instantiate and the setup/teardown of DOM elements. What do you think?
I meant can you include a // comment next to "!important" explaining why it is important. This applies to all the other comments I made.
Is it possible to add a ``@param`` annotation for parameter ``$host`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? I found this a couple of more times on lines: 53, 89, 101, 113, 125, 137.
This does not work. The server is changing rooms at this point, so the create event of the NoticeO never runs. The NoticeO is also removed again right at the end of the Game Server Create event because that's when GM actually performs the pending room change, and NoticeO is not persistent.