labofsahil/github-event-dataset-2012 huggingface dataset:
# Homework 3

| **Part**  | **Points** |
|-----------|------------|
| base      |  0.25 |
| advanced  |  0 |
| **Total** |  0.25 |

First of all, the parts you did use you used correctly.  That said, you missed some aspects of the homework.  The first of all, at no point did you use a string in `raw_input` to create a prompt.  You can do things like `raw_input("Enter a number: ")` to create a prompt.  Also, since you have the users name you can use it to create a custom prompt: `raw_input(name + ":")`.  

The other big problem is that you are using the `input` function.  Input is, to quote the python documentation, "equivalent to eval(raw_input(prompt))."  Eval is evil and should almost never be used .  Since it just runs whatever python code you pass it, it can seriously break your code.  Here is how you should be getting numbers:

```python
# bad
num = input("Enter a number: ")

# better
num = raw_input("Enter a number: ")
num = int(num)           #  or float(num) for a decimal

# as one line
num = int(raw_input("Enter a number: "))
```

Here is the full step one code so you have it.

```python
# Step 1
name = raw_input("Enter your name: ")
print ""
print "PrissyBot:  Hello there, " + name + "!"
resp = raw_input(name + ":")
print "PrissyBot: You mean, \"" + resp + ", sir!\""
```
That works too. LGTM
Ejnye, Kolléga!
Ez Linuxon vagy olyan windowson, ahol nincs c:\ hogyan fog működni?:)
You're absolutely right, sorry about that! I agree, this line was a mistake.
sorry, i forgot this :p

add next line in your config

CONFIG_MSM_KGSL_CONTEXTS=32
Ok. If all projects need is to have `phantomjs` in the PATH, using provided tarball is the way to go. And we already install a few tools that way. Thanks again.
I think what sort! does is "this = this.sort"
Ah, I didn't see Endevver had its own fork. The Six Apart one was my reference.
Hm. You might want to add a 'Thread.dumpStack();' and find out where the explosion is being called from so we can fix it properly.
Would one more match case make this potential pitfall explicit?
dispensable to set here again, I think.
Could this be related to the fact that, on LG's kernel, bcm4325 support needs also qualcomm libra sdio (i.e. librasdioif.ko), while on CM that's not the case?
![](http://substack.net/images/dnode-slides/fuck_yeah.png)
Isaac, can't PM or send email to you on github here, so thought I'd try this. Konspiracy mentioned in the ICS dev thread on androidforums that you may have source to a 3.0 kernel port. Can you post that on github (ideal since then we can then see what changes went in for the MT), or just zip it up and post it? We have ICS working in alpha state and maybe someone can attempt to get a 3.0 kernel working too based on what you have. Thanks.
@will-r could you release a new gem with the lastest changes?
A dialog is far too verbose for this. It's better to just display a warning using a TYPE_INFO message when someone actually tries to use it without tinyurl.
Fixed: 2971a55a7be1bce357f8bfae090d4ecd65cd7c5b
fix for #25: https://github.com/socialcast/devise_oauth2_providable/issues/25
Don't do any changes via GET requests, this has a security hole:

<img src="http://mlm.dev/admin/user/admin/2" />
<img src="http://mlm.dev/admin/user/unadmin/1" />
Actually, in some case, for example "event" and "record-array",  it's not the "Javascript type string". I think "The type of the given property" is more precise. Please also change the description of the BWidget.getPropertyType in another commit.
Remove `@version`. Optionally, you may want to either remove @since or give it an appropriate value.
use:
    Try(call) getOrElse fallback
Otherwise exceptions thrown by the callback will be outside of the Try
So what happens if you have an attachment which is a file on disk, does this force that file into memory? If so, then the usefulness of this could be questionable.
Removed. Was only used for debugging.
Don't use this, use NettyRemoteTransport.notifyListeners() instead
Oh, no, it's perfectly recommended to put config parsing in Extensions as they may or may not be used.
See Serialization for instance.
The default ``fmin`` also behaves well, it seems.  ``fmin_bfgs`` complains about a bunch of division by zero errors, but gives roughly the same result.
hmmm,

there is a sys_admin auth function but it is useful to sometimes know that we are a sysadmin - maybe it should be a more private function

the problem is often sysadmins get special privileges like seeing all groups even if they are not in any
This will date quickly - maybe say all components should render correctly - even if that is a bit vague. 

Also add about new components should be added to the page/ only components on the primer should be used (in my opinion)
Looks like you didn't resolve the conflict here.. ?
Odd that it doesn't have a problem with the signature itself. You're right though, it runs in our current uses where we don't provide anything extra but not when I try to. Back to the drawing board.
This will fail if to is null/undefined.
according to the Sf2 CS, the ``abstract`` keyword should be placed before the ``protected`` one
Please leave space above your comments.
Oh, I just realized - `python_bin` and `interpreter_bin` will have to be separate, because the wrapper script will always be in Python!

Just a note-to-selves for the pre-hackathon work.
Aqui deve ser "AllBalances" que é o nome da ação a ser executada.
A ten warunek po co skoro już wcześniej to sprawdziliśmy?
Yea, I was a little bit lazy in my refactoring...
inconsitent... log.trace...or warn
Sure. Actually copy/pasted your comment :).
"its position"
Probably yes, if anything other also will use this. And maybe then also move LANG_IDS from addic7ed downloader there ? But in opensubtitles its generic and there is specific for addic7ed.
This can be written as `self.highlightColor ?: self.backgroundColor`.
Same as above for reading the content.
I'm starting to imagine a lot of users complaining: "What 1 >= 10 error means?!" :)

May be you should prefix it with informative message?
"suite-hook" (NAME/SYNOPSIS)
Looks like this already works without the fix of this PR:

    In [27]: np.min_scalar_type(2**63-1)
    Out[27]: dtype('uint64')

I suggest adding all the cases in the email linked from ticket 2028, with the correct output. Then the case ``2**64-1`` fails with the current code and works with the fix.

    >>> np.min_scalar_type(2**8-1)
    dtype('uint8')
    >>> np.min_scalar_type(2**16-1)
    dtype('uint16')
    >>> np.min_scalar_type(2**32-1)
    dtype('uint32')
    >>> np.min_scalar_type(2**64-1)
    dtype('uint64')
    >>> np.min_scalar_type(2**64)
    dtype('O')
An awesome future feature would to (optionally) integrate running ``qiime.check_id_map.check_mapping_file`` in ``load_remote_mapping_file.py``. Even cooler would then be if you feed the results back into Google Docs to highlight and bad fields - is that possible, or is the published spreadsheet read-only?
эти тоже объединить
Same situation as with previous thing - I haven't rebased and it was failing without it for some reason
Sorry I guess I was not clear with the `whitespace` message, I meant to say there are 2 blank lines where 1 should exist. Thanks.
Could you put a space after the `{` and before the `}`. Like this `{ "key" => 22 }`
quick question:   Can you still get access to this in OSGi?   Are you making a sub-package?
Actually what will really improve it is making them final, which will cause the constants to be inlined directly, at which point the access level doesn't matter since the field will never be accessed.
I'm planning on moving it to reflect.jar in my fork. We'll see how that goes. If the experience is positive, I may try to submit a similar change in a pull request.
On Wed, Dec 12, 2012 at 3:30 AM, Adriaan Moors <notifications@github.com>wrote:

> In
> src/compiler/scala/tools/nsc/interactive/tests/core/PresentationCompilerInstance.scala:
>
> >    protected val compilerReporter: CompilerReporter = new InteractiveReporter {
> >      override def compiler = PresentationCompilerInstance.this.compiler
> >    }
> > +  protected val projectName = ""
>
> where is this overridden?
>
Leftover. Will remove.

>  —
> Reply to this email directly or view it on GitHub<https://github.com/scala/scala/pull/1722/files#r2386688>.
>
>
I'm confused by this line.  If `b` is a matrix with a different shape than `A`, this will lead to a ValueError in line 63.  I don't think that's the behavior we want.
Maybe they got out of sync while I was experimenting.

In the mean time I worked out what I *think* is correct:

```
      { sqrt(2) * Re(Ynm)  for m > 0
Znm = { Ynm                for m = 0  # Yn0
      { sqrt(2) * Im(Ynm)  for m > 0
```

next compute the parts by

```
Re(z) = 1/2 * (z + conj(z))
Im(z) = 1/(2I) * (z - conj(z))
```

and

```
conj(Y_{n,m}) = (-1)^m * Y_{n,-m}
```

If we do this we get a perfectly nice result. However I'm almost sure (except I made an error or did not catch an identity) it differs from what the old code implemented. Hence either it was buggy/wrong or used another definition
for some reason (but then, why?). We should decide how to proceed now.
any reason not to just return `(expr - expr.subs(n, n + d)).expand()`?
"afater" --> "after"
Sure, done.   Looks better now.
I filed a bug to JSLint this file. It was missing a lot of semicolons
Not sure about the doxygen comment. Shouldn't it be number of data points projected on to this decomposition?
It is not clear whether Rails 4 will be supportable with the current code. Please revert this.
Can you please make this header public?
Needs to be volatile.
Break long lines into multiple lines.
Some javadoc here would be nice as well :-)
Can you please move all styles related stuff into CSS file and just assign `className` here?
Replace the first sentence with: 

   To create a geospatial index, MongoDB computes the :term:`geohash` value for the coordinate pair in the specified values. 

The next sentence should be added to the glossary.
Then it should be removed and an exception note added to docblock.
I agree with Oleg's previous comment.
should ITEM_APPROVED (new constant) tehn be named ITEM_VISIBLE aswell?
nit: the name should be writePid, not WritePid
Downloads should probably go to the runtime dir or to some installation dir we make in the case of installing via a package manager?
Minimum required GCC version is 4.3
This is OK, but just a note that there is code in the wild that uses `ac.dispatch()`.  So, this is a BC break, and should be called out in the release notes.
Great.  This is not something that the new resource store *removed* so it's not a regression.  The filed enhancement stands, and can be implemented once this PR lands (or before if needed).

Said another way, this PR shouldn't try to address all possible bugs -- it should focus on redesigning/rewriting the resource store.
I guess I imagine something like this instead:
```javascript
mark = {};
mark.group = group;
mark.label = label;
...
buffer[group].push(mark);
return mark;
```
seems like this could just be 'msg'.  errormsg seems redundant.
i'm leaving notes for the changes. hoorya
I'm not able to read this code. Tot = Total?
Updates are also carried out as Save statements, are we all happy for updates to be creating transactions?
Could this create any locking/race conditions?
Without this, sub messes up on ref if all columns are included.
Use Piyush Madan's function for getting the uuid's for concepts here (will also work for location)
consider taking args as an array of stores instead of 4 args
I recommend making this getPatientsInPatientList... just so that someone can also guess... getEncountersInPatientList
Change either...or
For now I'd go for `'1.1.0-dev'`.
I seem to remember we can do a link checker on build of docs. Something like:

```
cd docs/iris
make linkcheck
```
用了`符号后 就不用缩进了。
Never mind, I didn't see it was already printed.
Shouldn't it be ``in (int, long)`` here as well?
Sorry this comment is not valid. I make a new one bellow.
m_hasEndKey is redundant -- just use (m_numOfEndkeys != 0).
Should there be a check that default_port is a valid integer?
From XPath spec: "Whitespace can be freely used between tokens", so [position (    ) == 42] is a valid XPath expression.

What about other restrictions? following-sibling::, preceding-sibling::, descendant:: ancestor-or-self:: or descendant-or-self:: axes?

Also, foo[2+2=4] is a valid expression, but it is rejected.
"Handles POST requests" please.
Opted for calling an imaginary `update_counter` method on the article. Also set it to be non-permanent redirect otherwise it wouldn't be much use as a view (I believe the browser would skip hitting this url at all in future)
Since this is a utility function, it would be very nice to see some unit tests specifically for this bit of code. At the moment, I don't see any.
That seems fine. I also like `SuperClientPluginGlobablizerPlugin` though...
Sorry. :S
This line cause a error using with jQuery 1.8.0, the definition of function next if jQuery is:
```javascript
next = function() {
    jQuery.dequeue( elem, type );
};
```
This cause a error because this function return nothing, and the next call to deferred.resolve is passed a undefined argument instead of the AJAX result.

I have changed this line to:

```javascript
jqXHR = $.ajax(settings).done(deferred.resolve).fail(deferred.reject).then(next, next)
```

And this work as expected.
What is it for?  It seems no one is using it?
crap, I forgot if the key is missing it'll return -1, so you'd want to test for it like:

```
if (!(User is Player) && EvalTag(PowerKeys.NeverUpdatesFacing) <= 0)
    User.TranslateFacing(TargetPosition);
```
Perhaps, but there's really no reason to avoid the portable idiom here.
The Event object should also know whether it was created to log an event from the *client* or from the *server* and the pattern layout should contain a placeholder for this, otherwise it's going to be very hard to separate lines that come from the client from those that come from the server since the interaction is going to be happening in parallel.
I agree.   In general it seems like using ```import XYZ``` style rather than ```from XYZ import foo``` might make more sense in the long run.  For this first run I figured I'd see how it looks and get feedback.  

In a later change I can do a full sweep of ```from``` style imports and try to replace all of them with named imports.  Its likely that I'd also have to alias (not sure the right term for using ```import foo.bar.baz as baz```) most of the imports to make them not ridiculously verbose.
because two reasons:

1. the field descriptor may not have initially an extractor (not possible in shub because in the annotation tool you can only annotate fields that are defined in the item, and so, already has its extractor defined, but this is a shub feature only)
2. The field descriptor extractor is overriden during the checking of all extractors in the list. To place more than one type extractor in the pipeline is wrong, there can be only one (like the inmortals gathering :D) and must be at the begining of the pipe.
Could you add the `option` argument documentation ?

And maybe `option` is not the best name for it. I would use `use_session` or `session_stack`.
It's a hard one to name but I think it's better to have explicit variable names :)
Agreed - much better.
Any reason not to use `HTTP_OK` rather than 200 to match convention?
Can't we just test for newlines then?

    while c == '\n':
        c = resp.read()

    # read rest of delimiter length...
No debugging code please.
Updated to show namespaced results.
Ow thought I pushed it to fix that. I'll fix it real quick...again
all of that code is actually [here](https://github.com/danieldkim/mulberry/blob/e6ae4e9648a0c9a383a4421284aed990370421ab/app/mulberry/app/PhoneGap/analytics.js#L39-74)
Yep, most likely. Is there a good model for a test like this already?
Again, I don't see how, but this is an optional param in the spec. Remove ``!`` and add ``=``. Same for the callbacks.
If I put it in afterEach(), we'll open and close one window per test.  The goal here is to have one window for this entire test _suite_, so we only want to close the window once all the tests have completed.  (Ideally it would work like EditorCommandHandlers-test where we don't even need a new window at all, but that approach doesn't work for plugins).
Do these events mean "when the content of the menu is shown or hidden", or do they mean "when the menu is added or removed"? I'm assuming you mean the former, but "show" and "hide" for HTML elements usually refer to the element itself being shown or hidden. If these are about the menu content, maybe these should be "open" and "close" instead.
ah ok did not know that
i will update the pr now
(we can postpone this for your larger cleanup branch)
I did not implement searching so no need for meta_search, neither used will_paginate(instead used kaminari). Sorry for the rest seems I did mistake.
I see you copied the other `bail` function, and then expanded upon it a bit. Instead of leaving two copies, can you delete the other and move this outside so both functions can call it?
maybe edit 'typeCodeString' to 'dataLocationTypeCodes' or 'dataLocationTypes'?
Never mind, i was looking at the wrong part of the code. :)
Same as above. You can just `querySelector(...).cloneNode(true)` instead of generating a new DOMFragment.
top three lines. Whitespace.
Don't use this style of indentation. Maybe file a ticket to correct this globally.
This doesn't format properly: https://github.com/jbuck/butter/tree/t2336

Comes out as "Join the #popcorn IRC channel A lot of people..."
The content of this stuff should probably be in the butter-form area of the dialog, not the h2. See the ticket for a suggestion
Same thing here...I'm wondering if we want to be working against a "dialog" object vs. a dialog-html-fragment?
remove plz :D
nit: shall it be `// .notdef` ?
checking whether the backend supports this is just reading a boolean from a CPVRClient instance (capabilities are cached in there), so that wouldn't be a problem.

also, now that I think of it, I don't think your directories entry shows up when you create a custom timer in XBMC, do they?
think you better just check the add-on capabilities in the dialog.
We should find a better name for this. I have the feeling that this class needs to be broken down into multiple classes anyway, then the names will be easier to find as well.
Falls ihr das übernehmen wollt, kannst du das gerne noch so anpassen,wie es dir lieb ist. Hauptsache die Funktion ist irgendwann drin. Hab da mal nen Thread vor Jahren im Forum geschrieben. Mich nervt es ungemein. Bin oft eingeloggt, klicke auf nen Menüpunkt und bin raus. Manchmal tief irgendwo in nem AddOn. Alleine da wieder "in die nähe" zu kommen, wäre eine super Erleichterung
Yes, I'm quite sure, what we get from the shell is empty string. However we could check for both in case of future changes.
I don't think this is part of the fix and introduces unnecessary both-directions dependency between Katello and Foreman modules
could be simplified `all.collect(&:to_log).join ", "`
Yea, I am using `_store_item` which automatically puts the argument into `{"name": value}` but the code and the help info are using label. I'll alter _store_item though to use `{"label": value}`
On 11/13/2012 04:04 PM, Petr Chalupa wrote:
> please add a comment and commit-msg "why"

Changed commit message as well. The one from jenkins was not so clear.

-- 
Miroslav Suchy
Red Hat Systems Management Engineering
Does this need i18n wrapping?
Yes, but I can not think of a way for this type of imprecision to crop up here (a numerical integration of something complex that should return something real maybe, but I prefer having an explicit test case).
then maybe if (totalLength > 0) is better. up to you.
OK, I have a fix for this in 44d2441:

Here's how I tested with and without raven-php available...

```
(sentry)[last: 0] marca@SCML-MarcA:~/Sites/sentry-test/vendor/monolog/monolog$ ls -ld vendor/raven 
drwxr-xr-x 3 marca CHEGG\domain users 102 Apr 25 08:10 vendor/raven/
(sentry)[last: 0] marca@SCML-MarcA:~/Sites/sentry-test/vendor/monolog/monolog$ phpunit
PHPUnit 3.6.10 by Sebastian Bergmann.

Configuration read from /Users/marca/Sites/sentry-test/vendor/monolog/monolog/phpunit.xml.dist

...............................................................  63 / 137 ( 45%)
............................................................... 126 / 137 ( 91%)
...........

Time: 0 seconds, Memory: 13.50Mb

OK (137 tests, 328 assertions)
(sentry)[last: 0] marca@SCML-MarcA:~/Sites/sentry-test/vendor/monolog/monolog$ mv vendor/raven vendor/_raven
(sentry)[last: 0] marca@SCML-MarcA:~/Sites/sentry-test/vendor/monolog/monolog$ ls -ld vendor/raven
gls: cannot access vendor/raven: No such file or directory
(sentry)[last: 0] marca@SCML-MarcA:~/Sites/sentry-test/vendor/monolog/monolog$ phpunit
PHPUnit 3.6.10 by Sebastian Bergmann.

Configuration read from /Users/marca/Sites/sentry-test/vendor/monolog/monolog/phpunit.xml.dist

...............................................................  63 / 137 ( 45%)
.SSSS.......................................................... 126 / 137 ( 91%)
...........

Time: 1 second, Memory: 13.50Mb

OK, but incomplete or skipped tests!
```
How about call the outer div "tray" as it's a side-tray which will probably contain more things than tabs (e.g. the settings icon for now).
Is getting the count still require for the init process, or you are getting the count just for the purpose of debugging?
ok 这个我接受。

亲，请用cmd+enter。。。
Yea I ended up changing it.
Updated to use the dynamic solution in favor of a static string as app-name.
No looking at APPDATA env variable anymore?
This needs 4 spaced as indention :).
i never know the operator precedence of instanceof, so its save to brace it.
i see here 4 spaces, 4 spaces, 3 spaces, not sure if it's the same for you
The problem is that 'blatantly too long' is totally subjective. IMHO 'allow_scientific_notation' is nowhere near too long. There is a massive body of software engineering literature out there these days and I can't find one that says that typing is the hardest part of programming and hence we should choose short names ;^) I'm still stuck in emacs land and even I don't have to actual type a variable/class/method name more than once and then autocomplete it. 

Reading code really is the hardest and costliest part of software development, the cost of the actual typing is incidental.
No, you're right.
Adrian Cole <reply
+p-901104-91addb873decfa215578cff0402b4fdd6b128f33-1453210@reply.github.com>
 wrote on 30/05/2012 07:10:40 PM:

> From: Adrian Cole <reply
>
+p-901104-91addb873decfa215578cff0402b4fdd6b128f33-1453210@reply.github.com>
> To: Kenneth Nagin/Haifa/IBM@IBMIL,
> Date: 30/05/2012 07:10 PM
> Subject: Re: [jclouds] Added container handling methods and tests (#654)
>
> > @@ -0,0 +1,7 @@
>
> can you remove this file from the commit?
Sorry about that.  I removed it from the commit and pushed it to github.
Do I do now need to do another pull request?
-K
>
> there are tips here: http://groups.google.com/group/jclouds-dev/
> browse_thread/thread/899618e53cab800d/1e81e054d811e8ef
> and here: http://stackoverflow.com/questions/307828/git-remove-file-
> accidentally-added-to-the-repository
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jclouds/jclouds/pull/654/files#r901104
>
right. I will review this with a bit more attention. 
The reason I've used commons-codec though is that it was already used in other jclouds projects (gcs and apache hc), it was the actual lib used by the google client to base64 stuff in a way that just worked (jclouds base64 produces wrong results even without url encoding) and I didn't have the time to dig any further. Will take the time now to look into other alternatives.
Super classy. This will probably come in handy elsewhere, too. :heartbeat:
why not simply use the `ITERATOR_SET_CB` macro, here?
From the class Initial, third entry of tuple(count) is set to zero if input is null, which in resul t is 'dropping' the null entry.
I'll commit my new unit test soon, however from the test,
Variance of (1,2,3,4,5,6,7,8,9,10) = Variance of(1,2,3,4,5,6,7,8,9,10,null).
Thanks. I think @mageekguy is not in love with docblock, so I can't assume anything about this choice. I just let him review this. (the link should be enough).
We do this sort of thing in a lot of places in the code:

```
    qs = (Forum.objects.filter(is_listed=True)
                       .select_related('last_post', 'last_post__author'))
```

But, "preferred" in this case is really just what we want to do in the Kitsune code. It doesn't really matter much either way.
It looks like this parameter is orphaned, as there's one call to `openHelperTab()` that passes an argument for it, but `openHelperTab()` never actually uses it. So we should remove it (and remove the argument from the call that passes it).
excellent! I like the positional argument rename too.
Comments should be full sentences, so start with a capital, end with a period.
I have done various attempts of changing to Common::String around in the code, thing is that some functions still use char*, I am planning to do an overall conversion, but it's a rather large change all in all, that's why it hasn't happened yet.
Ah, if you're on the JVM and don't specify your own executors this is the default asynchronous behavior as well.
Yes, I know that after throwing an exception code is not executed, but it's more understandable example, as the more complicated services are created this way too.
@drak The validation is already performed properly by the Configuration class, using the processed value (meaning that you can validate as an integer there and use ``%lifetime%`` to use a parameter). The XSD validation occurs way too early to be able to be strict (which is also why we cannot use ``required`` in the XSD for required params for instance because they are required in *one* config file, not in *each* config file)
this looks like an alias for ``getMemberMetadatas``. Is it intended to have both ?
changed it now. Thanks for your input
So shall I typehint?
Not required at all and does nothing new. That would just give us a default implemenation. Implementations that override this could just as well implement RequestMatcherInterface themselves. Any other votes?
if on the previous line $status is either    

self::REQUIREMENT_MISMATCH    or
self::REQUIREMENT_MATCH

then why not checking either one of them and doing a check on 0?
oh, i see, because an exception could happen in the parsing even if we don't plan to rewrite the scala files.

i guess that bug's always been there. :)
you'll notice that the constructor just uses fromString, so if the string you pass in isn't one of these you'll get a null I think.
I'm not sure where this is coming from nor how it can be fixed. All I did here is generate a new modernizr.js with touch screen detection.
我先merge了，这些小问题慢慢改吧
Вот это хорошо. Но, блин, почему это всё в одном пуллреквесте? :(
Это же два разных набора кода. Вот я нижний бы втащил прямо щас, а то что вверху - подумал бы зачем.
Same remark as above, please don't override methods with the same code.
Unnecessary map
ah, ok, I just wrapped some sync around it before pushed it because I did not want to delay this any further.
Unnecessary comment, the purpose of `uniqueId()` should be clear.
There's not really any reason to expose this. We should just move it into a local function. That's probably true of all of these methods.
Every curl_setopt() call besides CURLOPT_URL could be done in the constructor.
надо было тогда еще javadoc поправить, т.к. теперь вместо null пустой список
OK, well at least that means you had it working locally and tested it.  :)  I went ahead and pushed it last night anyway assuming as such, I just removed the whole version check line as per my comment on line 72. The version check was just to differentiate between 2/3 when Honeypot was supporting both, now that it's not I just dropped the check.

Thanks again for the work and the pull request, I appreciate the help keeping these plugins updated.
Please change this name to be singular.  When I saw it, I expected it to take an array of candidates and sort them.
I'm kind of horrified that we're doing trigonometry in real time to generate these tones.  Maybe my sense of what a CPU can do is really old-fashioned, but that seems really expensive to me.  Do we have any way of measuring CPU load while a long tone is playing?  I'd suggest that we pre-compute a few cycles of each of the 7 frequencies and then use modular arithmetic to combine them.  Then this generate tones function would just have to do addition, multiplication and modulo to fill the array buffer.

That belongs in another followup, though. I'd be happy to do that one if you care to assign it to me.
I agree with @vingtetun to put them for the  moment under style/shared and later when BBs land migrate to the new shared/style.
when I asked you to drop the `window.alert()` call it was mostly because I thought it was a debug thing. Do we really want to display the raw `options.text` information? What does that contain?

(sorry for the silly question but as I can’t test this feature yet on my SIM card…)
Fixed:
https://github.com/basiclines/gaia/commit/91eb9c3e1fb3215d614243348e4e6ba8e8db42a2
nit: // Prompt appears when a transfer request from a paired device is received.
why this extra line?
`escapeHTML` here
Why does those parameters lives in settings? I'm not sure to understand the need here and this would let you remove the code for the SettingsGetter ?
classList.remove('ffos-menu-visible'). Better native API
nit: we uppercase those singleton -> `Swiper`
If we have CSS flexbox then it will push down the home screen :P
I supposed `this.reservedSettings.*` recorded the previous settings, and I set it back after turning off flight mode, no matter it's on/off, isn't it? 
Regard to isolating flight mode logic, I will do it for #2404.
ugh, right. Sorry for the noise.
exatly -> exactly
Unreg the object here as we discussed
I think it is safer to qualify class and file name with suffix parser.
This code snippet should not have been here. Left over from us not managing Debian model or Puppet not uploading there version yet (they use Debian)
Is :defaults => [] a default value ?
Should be :default then.
@solnic fwiw, I pushed to edge veritas-optimizer tonight. It should work with edge veritas and the adamantium conversion now.
s/です、以下の URL で試してみてください:/です。以下の URL にアクセスして下さい。/
Create API in garmentbox_item -- ``garmentbox_item_get_variant_price()``
Add a semicolon after this statement.
This is not a big deal, fine to keep it as is.
Checking return value is better than checking the return string.
`super(Iscsidev, self).__init__(params, root_dir, tag)`
FYI:
http://stackoverflow.com/questions/904036/chain-calling-parent-constructors-in-python
http://docs.python.org/library/functions.html#super
I think I prefer something like (for speed, regex is slow)

if ((expPkgName.endsWith(".*")) && (expPkgName.charAt(expPkgName.length()-3) != '.') {
That's an excellent idea.

It seems that branch will be None in the "trunk" case so i believe its default should still be None, and i don't think there should be a default for path. I think it is a requirement for the splitter to return something for path (and this actually matches how i documented it).

Do you agree?
@djmitche / @tomprince is this still in effect?

I think it's more confusing to people not 100% down with inlineCallbacks - they might think that defer.returnValue is just setting a global and that return still does the return!
you should remove the method name here. It is useless (we already have the method name) and breaks the phpdoc as this will be used as short description instead of the real one
remove this custom repo, it can cause problems during released when deploying to nexus or mirroring to maven central
[Khan Academy](http://www.khanacademy.org/)はあらゆる人々に世界レベルの教育を提供しようというひとつの試みです。数千のビデオ、数百のJavaScriptで動く演習問題、そして未来に向けた壮大な計画のために、Khan AcademyはBackboneを利用してフロントエンドのコードのモジュール化と最適化を実現しています。ユーザーのプロフィールと目標の設定はBackboneと[jQuery](http://jquery.com/)そして[Handlebars](http://handlebarsjs.com/)で提供され、さらに新しい機能のほとんどは、[the API](https://github.com/Khan/khan-api/)の質の大きな向上として、クライアントサイドに反映され続けています。
原文: If you've ever manually set this.el in a Backbone View to be a particular DOM element, you'll want to use setElement instead.

監訳案: Backbone Viewを`this.el`を使って手動で特定のDOM要素に設定している場合、代わりに`[setElement](#View-setElement)`メソッドを利用してください。
It's not good idea to store all messages in memory at once, try to use QFile::pos() and QFile::size() instead for progress bar
Vzhladom na to, ze HTML5 Boilerplate sa rychlo meni, tak by asi nebolo zle, vyuzit diff a patch, aby sa dala nova verzia HTML5 Boilerplate rychlo opatchovat a pouzit u nas. Mozno by sa dal vyuzit aj git fetch/merge z HTML5 Boilerplate repozitara do naseho.
Standard convention is to call this `media2SafeFields`
Do we want a feature that does nothing?
There you go...

![ship it](http://cdn.memegenerator.net/instances/400x/31453248.jpg)
yeah just a place holder
This one has to stay `;backend = memcache` because it's referring to the default driver (memcache vs redis vs apc). Same with the "If blank, or memcache" in the comment above it.
Spam ~ ~

Em 4 de setembro de 2012 11:57, luizferreira <notifications@github.com>escreveu:

> In src/wres.tour/wres/tour/skins/javascripts/amberjackPlone.js:
>
> > @@ -0,0 +1,775 @@
>
> Coloca um comentário bem chamativo aqui pra indicar onde modificamos esse
> js, isso vai facilitar quando quisermos atualizar a versão do amberjack. Ex:
> COMMUNIMED: this ... .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/luizferreira/cmed/pull/19/files#r1523573>.
>
>



-- 
Peter Thorun
This should be `return value + 10` right?
Required options
I'm using it in `tabs/utils` now too, so I'll leave it.
Alright. Good to know. We are on the right track then...
How about we wrap it in an `if (process.env['NODE_ENV'] !== 'production') instead? Although there's a script to do it anyway so we don't really need it now, right?
apparently redis is recognizing databases by numbers - so I just picked a number ...
Can't this be passed as a normal block argument at the end, rather than a separate argument?
intellect?
I could not find a call to this function. Maybe just drop it?
i pretty much wonder what d could be for ... can we probably change this to err ? thanks for your work
I added the .length there to make sure it got inserted in case the element wasnt on the page, and if not then it would still get the default `insertAfter()`  otherwise it wouldnt show up if the container wasnt there

I'll make your change as you suggested though
Ok
Sidenote, can we just agree on this once and for all. In athor PR I had it like this:

    class InvalidArgumentException 
        extends \InvalidArgumentException 
        implements ExceptionInterface
    {}

then I was advised by @Maks3w to put it back as one-liner if it doesn't break hard wrap limit of 120
I'm getting mixed signals and it's not helping
Rename to "allowRemove", to follow how other boolean getters are named.
Added the comments for the output
missing @author and since
use %p= content
Again very nice tests!  Thanks for being so thorough.
Please use hexs as in any other place...
@TooTallNate yup :-D
Do not abbreviate. What's qcp? Quebec Cops Party?
i wonder if in the case of multiple calls to finfo it would be more efficient to get all the data at once .. then again .. probably not a performance critical part anyway.
Keep the margin where it was at (0.5em) and add this underneath it: 

line-height: 1.25em;
small thing: don't have to declare `now_utc`, it's redundant.

```javascript
        var now = new Date();
        return new Date(now.getUTCFullYear(), now.getUTCMonth(), now.getUTCDate(),
            now.getUTCHours(), now.getUTCMinutes(), now.getUTCSeconds());
```
Only save to disk after the initial call is finished.
allow ``python *args,**kwargs``` to be passed to dict __init__
I don't quite understand what is done here? Is 0 valid? And why is this not done inside getMovementX/Y?
[undefined, undefined, undefined, undefined].indexOf(undefined) returns 0 in firefox and chrome.  That's because it's not a sparse array but an array with undefined in it.  You can tell the difference because your example does return -1.
Does this only apply to non-Mozilla repos? In any case, I've updated to pull requests@v0.12.1.
s/_get_invloved_link/_get_involved_link
Is `groups` ever false-y? If so, wouldn't it be fine as `False` or `None` anyway?
I don't know if Unittestzero handles this, but should there be some error messaging here for a failed assertion? Maybe something like 'positive case returned no search results'?
shouldn't the coma be before the '${3: ?
`a = b`
Looks good, but why remove the status?
Oh, I see what you're trying to do now. The intention from the code is a bit unclear and someone reading it later might not immediately get it (though it could be just me). IMO this is equivalent to
```javascript
for(var i=0, n=item.creators.length; i<n; i++) {
  //only change contributor to editor up to the first author
  //since authors always come first (???), change contributor to editor when author does not exist
  if(item.creators[i].creatorType == "author") break;

  if (item.creators[i].creatorType == "contributor") {
    item.creators[i].creatorType = "editor";
  }
}
```

Is that the correct intention?
can you use the documentation guidelines to document this function:
http://drupal.org/node/1354
I think the word you're looking for is "tilde" :)
@narrowtux fixed :D
"like Aptitude for Linux" would probably be better as "like Gem for Ruby" - or both
ERROR2 still around :P
contentId is not going to come back in a paging query, so no need to check for this. Other than that, I find Simon's for loop easier to read as well.
Is this intended to still be TODO? Or should it be in this PR?
I'd shorten this to simply ``InSynth code synthesis``.
Oh, I now see what you wanted to imply.

You should have read `needs to be` as `needs to stay` ;-) I'll change it as you suggested.
* Cosmetics: Should be aligned
* Rather than do ```1.0 / _fps```, you can simply do: ```av_inv_q( av_d2q( _fps, INT_MAX ) );```, and avoid an unneeded double precision operation. ```av_inv_q``` has been available since the end of July.
yeah but i don't want to change your code ... i thought you can optimize it
How about replacing isCopyin and OpElement with a HicudaElement *CopyinElement? If there is no copyin, this element is NULL.
Yes I'll do asap :)

/antoine

Le 24/10/2012 à 19.37, William Durand <notifications@github.com> a écrit :

In tests/Geocoder/Tests/Provider/FreeGeoIpProviderTest.php:

> @@ -135,7 +135,7 @@ public function testGetGeocodedDataWithRealIPv6GetsNullContent()
>
>      public function testGetGeocodedDataWithUSIPv4()
>      {
> -        $provider = new FreeGeoIpProvider(new \Geocoder\HttpAdapter\BuzzHttpAdapter());
> +        $provider = new FreeGeoIpProvider(new \Geocoder\HttpAdapter\CurlHttpAdapter());
>          $result   = $provider->getGeocodedData('74.200.247.59');

Can you please move these changes to another PR? It's not tied to your new
provider.

—
Reply to this email directly or view it on
GitHub<https://github.com/willdurand/Geocoder/pull/112/files#r1931456>.
The description is missing ;)
Use allman style : 

```php
foreach ($ip_v6 as $ip)
{
     //
}
```
Спасибо, поправил.
Здесь код должен быть в блоке if(self){...}
I think this is the wrong way to do this; the right way being something like what [Transmission](https://trac.transmissionbt.com/browser/trunk/macosx/PrefsController.m) (Adium is another good example of this) does, where there is a gui for setting an override url in the preferences so users can choose if they want Betas, RCs or just Stable releases.
use `sub.field_1.should == "1_updated"` to ensure that we're testing the right thing incase the `update_attributes` failed for whatever reason
This does not follow the coding standard used by doctrine. Also there should be a new line before the last return statement.

```
use MongoTimestamp;

if ($value instanceof MongoTimestamp) {
    return $value;
}

return $value !== null ? new MongoTimestamp($value) : null;
```
These changes are what I wanted to do after merging this pull, thank you.
+1
I've updated the code to reflect this.
yep! pretty nifty, saw it in the form helper guide.
I think I broke GitHub with the last comment. ;) 
This if statement is why I love Powershell. ;)
Thanks :smile:. Btw. this would crash when mMyRepo is NULL right ? :open_mouth:
I don't know what @mluessi thinks but I hate single letter variable names. At least order is explicit.
are we sure that it's not modifying input parameters inplace?
no need to change authors file..
is this replacing another method?  or duplicating one?
Yes that's true. And anyway we don't need to read the config at all here since we are delegating the classes instantiation to the `Global` object. I am missing something?
Done, won't do it again ;)
But master is used for 2.2 no?
Can you assign a variable called `branch` instead? The triple-nested conditional is hard to read.
there was a type in it, too: arg vs args. I removed all comparisons as they work without them.
Ты уверен, что тут в обоих местах должно стоять w?
No fui muy claro en mi comentario. Con el código original `controllerDescriptor.FindAction(` se tiene en cuenta el contexto, entonces si el HTTP method del contexto es `GET`, se pierden las de `POST` y entonces no me sirve para el formulario
Spaces after #, and please complete sentences.
a table of mappings which handles these mime type is already included with nginx, and is located at conf/mime.types
bad arrows alignement
Space V: The Space Strikes Back
Looking at that wiki page, I interpret their definition to match mine.  A Partition contains multiple parts, in my interface, each `cluster` is equivalent to a part and the Partition contains all the parts.  Their diagram shows the same kind of interpretation.
?

This is just a helper method to check that every verb is authenticated. Not 100% happy with it but it works.
Instead of error can this else clause basically do a full install of everything. Basically the same thing that setup.py does today.
Yes, a global enum or one per command ? (I'd prefer the latter)
if this should never happen then throw an IllegalStateException to assert it.
They say that some ways of asserting equality are better than others.  Why do you think this way is better than the line above it?
This makes serialisation of lists is inconsistent between application/x-www-form-urlencoded and multipart/form-data requests. 

See https://github.com/kennethreitz/requests/issues/737#issuecomment-7305046 for more details.
I'll try that -- I don't know if it will break or not.
PrefixedNode has two modes:
- PrefixedNode(full URI, None)
- PrefixedNode("prefix:suffix", Some(Prefix(...)))
why the difference here?
This adds unnecessary code. If you need this for testing, it would maybe be better to expose the caches as OpenLayers.XBrowser.(css|js)Cache. For the mock style, you can temporarily override document.createElement in the tests.
Use https://www.opscode.com/chef/install.msi please
There aren't other values to consider, but this could certainly be put elsewhere. Suggestions?
castToNumber is not neccessary - JavaScript gives "good" values for <,>,<=,>= for all types - so we can generalize to strings, etc pure Date objects also work just fine
locateWidgets does need to provide a default, as there could be widgets in the core HTML that don't have an id provided.

e.g.
```
<div data-widget='footer' />
```
Have updated example with a comment like that, as well as showing the result of creating the object.
Declarations of namespace, or use must be separated from file header by a blank line
Correct, in ReqRespData the headers are defined like below. I believe @jrwest is planning to change that.

```scala
requestHeaders: Map[HTTPHeader, String] = Map(),
responseHeaders: Map[HTTPHeader, String] = Map(),
```
Why did you've added this? What happens if it's only

return $this->_createItem();
Also, totally agree with the comment, you can remove it I think?
Same problem with `pred` not retuning booleans. Here you could use `my-some`:
~~~clojure
(not (my-some (complement pred) a-seq))
~~~
Ah, you're right... this could be called as part of another command. I'll fix this.
That can be fixed. :wink:
according to the ``check_cs`` script, you should add the newline at the end of files
Why we don't move this class to jdroid?
Gotcha. Pushing a fix shortly.
Bleh... I also don't relish the prospect of having a custom template tag just for this template. What are your thoughts on using `STATIC_URL` and an `{% if STATIC_URL|slice:4 == "http" %}`? Also not ideal, of course.
Can be
Lo dejaría por ahora sin indentar, así queda igual que en el resto de los ejercicios.
Igualmente me faltaba agregar la licencia que acabo de hacerlo.
Well, the original message didn't add much else.
Have you checked, that we don't need this anymore?
also, not sure if we want to put it /tmp, maybe /var/run or any other better place for it?

maybe we should consider adding a proxy tmp dir (just like rails does)
`bundle` argument is missing.
You removed the wrong one!!!
We are using `url` template tag from the `future`. You should load `future tag library above and then you have to use a different syntax here:

```
{% "url" contact as contact_url %}
```
Or you can do also:

```
panels_with_dependencies[panel] ||= []
```

before.
About this file, interesting use of templates, I feel the urge to praise the developer who came up with it.
no quotes around a font declaration. Only on individual font names if they are not standard or have multiple word names. 
There is an extra semi as well
Inheritance isn't required at all. I'd prefer to share code with a module anyway. How do you feel about using an included block to define the trap_exit?

On a related note, the Fanout specs should be refactored into shared examples so this one can use them.
remove it or change to `return self.image.width, self.image.height` with deprecation warning
Mat44 has multiplyVector, so I think this should be Mat44.preMultiplyVector. Up to now, unless I'm wrong, Vec4 had no dependency on Mat44; all function mixing Mat44 with Vec4 were on the Mat44 side.
maybe reorder theses one for consistency purposes
I am not sure we want {wid} neither $WID, or the one I current use for sockets: ${socket:xxx}. The first two ones because they are confusing in a commande line,

I vote for the Gnu Make standar *everywhere*:   $(WID)
It's actually Mathieu's code, but i can fix.
Why is this removing amazon support?
Done: d1c8ed3
Why this change, this seems unrelated.
I thought you meant this method, but you're referring to the entire *class*. So should we just remove it?
Extra spaces :)
Yes. The VideoPlayer doesn't use the ImageScroller, so that fix doesn't fix this.
Clean comma at the end. Write commas after last element only if you split tuple into multiple lines.
BigInteger is immutable.
Yes i need to remove the commented.
Just pushed a linear dimension clarification for all these docstrings!
Ah ha, you have picked up on a bit of annoying messiness:
* find_ellipmom_1 (the basis for FindAdaptiveMom) returns Mxx, Myy, Mxy of the observed image
* general_shear_estimator (the basis for EstimateShearHSM) returns PSF-corrected e1, e2 -- there is no corrected sigma in general, for all methods, and therefore no corrected Mxx, Myy, Mxy.

This is obviously not consistent and so I had to make a decision at the outset which I considered more interesting information for users.  I decided on e1, e2, sigma as members of the HSMShapeData struct, in part because we can make them for observed and corrected shapes (whereas sigma is only defined in general for the observed image, and therefore we can only make observed Mxx, Mxy, Myy).  And then I realized that for Demo.py I needed moments so I added member functions to compute them.  But I admit that this is clumsy.

I'd be okay with adding observed_mxx, observed_myy, observed_mxy to that struct, and populating those values in FindAdaptiveMom / EstimateShearHSM (which also estimates observed shape).  Does this sound like a reasonable compromise?
I think I've pushed a bunch more indentation edits.  Happy Mike?
DOT explanation