labofsahil/github-event-dataset-2012 huggingface dataset:
`-f` seems to be the valid option of the Mac OS X Lion `stty`. Running `info stty` give me:

``` bash

File: *manpages*,  Node: stty,  Up: (dir)


STTY(1)                   BSD General Commands Manual                  STTY(1)

NAME
     stty -- set the options for a terminal device interface

SYNOPSIS
     stty [-a | -e | -g] [-f file] [operands]

DESCRIPTION
     The stty utility sets or reports on terminal characteristics for the
     device that is its standard input.  If no options or operands are speci-
     fied, it reports the settings of a subset of characteristics as well as
     additional ones if they differ from their default values.  Otherwise it
     modifies the terminal state according to the specified arguments.  Some
     combinations of arguments are mutually exclusive on some terminal types.

     The following options are available:

     -a      Display all the current settings for the terminal to standard
             output as per IEEE Std 1003.2 (``POSIX.2'').

     -e      Display all the current settings for the terminal to standard
             output in the traditional BSD ``all'' and ``everything'' formats.

     -f      Open and use the terminal named by file rather than using stan-
             dard input.  The file is opened using the O_NONBLOCK flag of
             open(), making it possible to set or display settings on a termi-
             nal that might otherwise block on the open.

     -g      Display all the current settings for the terminal to standard
             output in a form that may be used as an argument to a subsequent
             invocation of stty to restore the current terminal state as per
             IEEE Std 1003.2 (``POSIX.2'').

     The following arguments are available to set the terminal characteris-
     tics:

   Control Modes:
     Control mode flags affect hardware characteristics associated with the
     terminal.  This corresponds to the c_cflag in the termios structure.
...
```
forgot comment, will add.
You would use cbuf_write_from_fd (), which writes into the circular buffer, which grows as needed.

Then you could either use cbuf_peek() to seek to the next NUL character, or you could copy the data
out to a char *buffer using

  buf = xmalloc (cbuf_used (cb));
  cbuf_read (cb, buf, cbuf_used (cb));

However, since this requires copying all the data, maybe you're right and it is not worth it at this point.
@Miserlou A commit has already been made for defaults (: https://github.com/rails/rails/commit/641a4f62405cc2765424320932902ed8076b5d38
How would that code get into someone's Rails version that's already downloaded though? They'd have to re-install Rails, or update the version to get any new code.
Whenever you catch, always catch as const reference.
I.e.
} catch (const boost:thread_interrupted& ex) {

The "const" is to make sure that you catch an exception which for some reason is const (not normal behaviour, but could happen).
The reference is to make sure you don't perform any unnecessary copying.
I always forget this one, sry.
Ah, good to know, because MSVC is accepting it.

I'm just seeing it this method is inline + virtual? :)
Thats not possible.
Could probably do with some doxy here, such as ///< desired width of the image to load
Please please please, add tests for this change!
I tried to remove it for something better, but it currently does so many things, along with ``get()`` that it's very difficult to see how it could be refactored cleanly.

Having a clearer interface, to see at least what it is really used to would help, I think.
I really don't know. The whole idea of a thread spawning itself caught me and hooked me like a fish.
So it should be included in libev-4.11, if that is the patch you're referring to :
http://cvs.schmorp.de/libev/ev.c?r1=1.405&r2=1.407
Dave typically likes you to sort your using statements.
It's a big change so I'll play with it for few days before using it on production.
Thanks
OK, segv issue is solved on krypt-core master.
Question or statement? AFAIK it's working...
i'd have to make it a python file i think.
пробелы надо заменить на таб
Same thing here. I think we should have a couple of helper functions or methods to work with the control flow analysis results in readable ways.
This is a feature I personally was missing in wave, because I don't do it regular. For me I use it in a spring cleaning kind of way. 
Maxbe we should start a poll to get a feeling for the need of this feature.
@Acrobot - Well actually I may be confusing something also.  Or maybe it's @tahg that confused both of us? heh...

I just saw that @tahg does refer to the data field as a short.  And I just looked closer and saw that ItemStack does not have a 3 parameter signature to pass in the data.  It only has a 3 parameter signature to pass in damage.  So what @tahg refers to as "data" here is actually "damage".  As it stands this command will allow you to give potions out. LOL.   However, it won't allow you to assign the data (MaterialData) as I believe @tahg intended?

But now that I look closer there is other funky things going on in ItemStack.  Why does the data parameter in this signature: https://github.com/Bukkit/Bukkit/blob/c80b2d2fd999edc682e855f9e110f23861e6c2e5/src/main/java/org/bukkit/inventory/ItemStack.java#L46 override the damage/durability?  That looks like a bug also.  As I read it ItemStack is currently incapable of assigning data at instantiation due to this bug.

Am I totally not understanding something here myself?
should take any kind of fusion sequence
Thanks for your interest in mdtwm. I have some updates for new go not pushed before. Now I updated mdtwm to last Go weekly.

test program isn't  important enough to keep it in subsequent releases of mdtwm. If would I think about create some subpackages, there probably Window type can be moved to "window" package because it is wrapper of xgb. But I think that it isn't general enough to decide to do it.

I use mdtwm for all my work in X, but I haven't to much free time to fix some problems in it, especially in mouse handling code, partial struts handling and with it interoperability with Gnome. But I gather experience and at some time I will deal with this. If you have some free time to help, try find better implementation of mouse handling (see input_events.go file). It is quiet separated piece of code so it can be easily changed without affecting the remaining mdtwm code.
So then we just have to order things right for the google submission. If this gets submitted before we submit Loongson patch, then Loongson patch should add the correct gyp stuff for loongson arch_variant.

If Loogson gets submitted first, then we need to add the loongson arch_variant stuff here.
Thank you! I haven't tested bootstrap outside of the automated tests. I pushed a new release candidate.
Can I raise the issue with classes on the html element again. html.classList.add("view") should do the trick
Search/replace ftw!  +1
src/modules/Wikula/locale/de/locale.ini still not needed.
:-)
Why is the terminator using "" instead of 0 pointers?
да и не огрызайся мне
yes, it could
+. +, I mean.
Isn't exactly the same patch, this looks better :)
unsigned int i to avoid a warning.
s/Faild/Failed/g
I corrected this in #76.

It is a bit trivial, but I am actually working on a more serious modification, a CodeMirror2 integration, much like the Ace integration.
@tibbi, ASSERT in this point - wrong, ButtleGrioundId may be 0 (if absent).
Reamer, seems that the cause of this problem by wrong TimeZone settings. It actual for Russia (less than year ago our TimeZone was changed).
rsa said that this problem will be happen while system be use wrong timezone and other programm (mysql, mangos for ex.) will be change TZ.
Sorry for my (and translate.google) English... =)
pardon my javascript ignorance here, but in most languages it is a logic error to loop from 0 to N-1 and delete the i'th element within the loop because the indexing logic no longer works. Maybe with JS this is OK because [i] is really an associative array reference?
@brockhaus 
Before I forget.... Please note this fix in the NEWS file, while this might change someones behaviour...
Due to how the commit was removed, this commit came back after a rebase.
Thank you. Ok, having never used those custom fields I didn't realize there was a problem. Please test/fix a fresh install and I'll continue testing your pull request.
I found it based on your professionalism
if it was a different man of dubious reputation, I would not use it
IMO most titles would be implicit, as WaveTitleHandler sets implicit titles.
Well, why not :) I know nothing about oracle, but the condition "ORACLE_HOME not set" seems to be enough to say that oracle is not installed :)
I from looking I guess this commit has to stay because the following commit is based off of it...
Looks good! R+
glsl requires that all typing and casting be done in constructor format, so

float(1.0), assuming you'd really want that for some reason.
Shouldn't this be encapsulated in the if case above?
Yeah i know pwiki fell down for @dmorley too, i think
Still looks like "comparible" to me.  Sorry to be a pain about it, but I'm going to be the one taking the heat for the spelling error.  :)
why is this an `<h4>`?
haha yeah I used to merge the suites based on the names but then I realized that meant merging the hooks as well so it didn't really work too well. It could still be done and it would still be really handy I think but more of a hack
Great. I can wait until you've tested everything :)
Good change here.
UPDATE quest_template SET PrevQuestId=0, NextQuestId=0, ExclusiveGroup=0, NextQuestInChain=0 WHERE id=13668;
Mode changes.  Never trust a designer.
great, will do that
PS : Congratulations for your great job !
Would it be better to use -mx-content-image to set the size from the style?
I'd love to make i18n opt-in. What do you think about forcing users to `require 'cucumber/runtime/jruby/EN'`? (except I prefer the lowercase locale name - it's more idiomatic ruby no?)

Otherwise - looks good. Might want to stick `# encoding utf-8` in there to make it valid.

I haven't tried this code, but beware that JRuby has a lot of encoding-related bugs (in case this doesn't work).
Great work Gregg! The only question in all those commits is whether we really don't support list of lists and what is going to happen if someuse uses them nevertheless?
Voy a agregar un # mas en cada nivel. por que sino siempre renderizará "Introducción" para todas las hojas.
Yup, will fix it.
Esta feature fue sugerida por EnriqueZamudio:
http://www.javamexico.org/blogs/rugi/jarhallalocal#comment-18111
Any reason not to use fast enumeration here?
`image_src ||= asset_path('noavatar_small.png')` или направо на един ред: `image_src = @user.small_avatar || asset_path('noavatar_small.png')`

Ако това се появява често (> 1 път), е добра идея да се направи view helper по въпроса; например:

    def avatar_url(user, size)
      user.send("#{size}_avatar") || asset_path("noavatar_#{size}")
    end

    image_src = avatar_url(@user, :small)
I had to change this to
`return self::getInstance()->logError( $message, $error_code, $trace[0]["file"], $trace[0]["line"] );`
perfectly work!1
What was the justification for this change - i.e. also parsing and inlining static external .css resources?
Added support for css style comment boxes
fixed in https://github.com/liip/LiipThemeBundle/pull/20
Couldn't you use css classes to reduce the volume of code here?
чтобы не пересчитывалось внутри цикла?
@campbeb Thanks for your remarks. I'll have a look at them and investigate further.
After doing a clean i got the same error :-( Nevertheless, here is the solution: cb0b90c81b70ca8fc7a869963bce8be4c6ec33d5
First stab at it with a few tests; I'll dig a bit deeper into it when I get home tonight to make sure the everything's covered.
Remove or make a verbose call
Isn't standard procedure _not_ to commit Gemfile.lock for gems?
damn it... tabs + auto format = epic changelog... gotta fix that
Can this be deprecated in 4.1.0 and removed in 5.0.0?
Actually here we finally come to the place where we must figure a nice way of handling 4-mode chest respawn
First way would be:
```
case CHEST_10: case CHEST_10_H: case CHEST_25: case CHEST_25_H: m_chestGuid = pGo->GetObjectGuid();
```
and then use the variable.
next would be:
```
case CHEST_10: case CHEST_10_H: case CHEST_25: case CHEST_25_H: m_mGoStorage[CHEST_10] = pGo->GetObjectGuid();
```
and then use: DoRespawnGO(CHEST_10)
and last would be 
```
case CHEST_10: case CHEST_10_H: case CHEST_25: case CHEST_25_H: m_mGoStorage[pGo->GetEntry()] = pGo->GetObjectGuid();
```
and then use
```
uint32 aChests[] = {CHEST_10, CHEST...};
DoRespawnGO(aChests[instance->GetDifficulty()])
```
no. you are correct on what you said.
A grue without dark? "Difficulty: 2"
What  was the problem before this commit ?
"Opening connection to MongoDB instance"
I suggest making it possible to pass a delegate from `Unit -> String`, something like [this](https://github.com/jkowalski/NLog/blob/master/src/NLog/LogMessageGenerator.cs) because it'll make deferred logging much smoother and avoid spending CPU cycles computing the ToString of the objects going into the log.
Bueno, lo es pero para el core que esta en esta sección por el momento.
This is a patch in order to fix the issue #2.
Esse cpf_validator.rb quebrou meu build porque eu já tinha um validador com mesmo nome mas que herdava de classe diferente (era um ActiveModel::Validator e não um EachValidator).
Será que essa alteração na implementação dos validators deveria dar um bump major na versão para 3.X e não minor (para 3.0.X)?
This comment isn't worth much.
On 14/01/2012, at 5:37 PM, Paul.W Harvey wrote:

> Hi Darryl,
> 
> Great work! I've been trying to find time to do a codemirror definition, FWIW, but in the meantime I thought I'd share my own test document with you, https://github.com/csirac2/src-highlite-foswiki/blob/master/TestCases/Test.txt


Thanks Paul, your test shows at least a couple of issues in my language def. I'll sort them out.


> 
> Yours seems more comprehensive than mine, but I notice you're not covering $percntDELAYED forms


Sorry, I am not sure what you mean by "$percntDELAYED forms". Is there a reference you can point me to?


> 
> Cheers
> 
> - Paul
> 


Thanks!

-- 
Darryl Lawson
Gotta pass Hilfinger style check.
Because I haven't tested it yet
@olegstepura The case where your RewriteBase is *not* ``/`` but something else, for instance
@tbaum you updating this to NodeJSGraphDatabase?
Oh you are right, thanks! I forgot to change that back after doing some debugging.
that's *really* been bugging me.  thank you.
I created the dead cell interface to use more as metadata when filtering objects from a list later on.
I added haml way back when compass required you to add haml.  I'll look into this again but I might remove haml all together now
Pitäisi olla $argseissa!
Hey! Thanks a lot!
script contains some debug code which will be removed after the last phase is completely finished

TODO:
- target selection for Harvest Soul and maybe some corrections not to target Harvest Soul targets with spell Defile
- Frostmourne phase on heroic mode
On Fri, Jan 06, 2012 at 06:48:57AM -0800, Jacob Vanderplas wrote:
> I think we should start including some standard comment along with these sorts of fixes like

>     # DEPENDENCY: scipy 0.7`

Agreed. I'll add this.

Gaël
Why default to null when it will be either overwritten in the constructor or set to `undefined`
But... at this point, their video ISN'T ready.
Блин трабла с 3d моделью! Она хреново грузится с вовхеда
`data` is a bad name (although I don't have a good idea for a better one right now :-)
oui je pense que c'est possible mais après j'aurai 1 graph = 1 twig .... alors ça va m'en faire des twig. Après je ne sais pas comment intégrer tous ces twig ensemble dans le design de romain. Surement une notion d'héritage ....
This line fails for me and produces an ugly warning that is displayed in the &lt;h1&gt; because my DokuWiki directory doesn't contain any files but just a .htaccess file referring to the actual (farm) installation. I think assuming that URLs translate to file paths is wrong. I think also that this assumption fails completely when the logo actually comes from data/media where the URL points to fetch.php or a clean url that doesn't exist in the filesystem. Maybe there should be a separate function like tpl_getMediaFile for getting the file path instead of the URL?
Hi TMorgan99,

I've given some thought to the inclusion of 'therubyracer' and decided to leave it out. It only serves Linux users who have not installed Node.js. I'm reluctant to clutter Gemfiles for Mac and Windows users just to accommodate the Linux users who have not installed Node.js. I'm happy to hear your thoughts if you disagree.

-- Daniel
Quick drive-by review for you…
support of Jquery form elements is included now (see 0.2.0 or 0.3.0 release)!

Thanks for your support!
Hey, thanks for the comment, Victor. Now I just need to get off my butt and finish the rest of it.
no need this option, this will break the function, still find how to enable this, some time just reboot the device :/
This should not be displayed
I wish I could like this! LOL
O correto é 0, caso o pivo seja zero o mesmo ficará como está.
Done in 3c4fabd
yeah, `[:sart_time]`
it seems weird to check if its long above but not convert.  Why not use NumberUtils.toLong(number, default) and then check if the default as supplied?
This is consistent with the former behavior, but I do think there's little reason to log an error if we rethrow.  Perhaps if we logged the failed SAML message here there would be some value.
I did it that way because that's the way B and BB were arranged in the original code. It doesn't change anything in terms of functionality so I think it's fine. You can edit it if you really want?
With the most recent change to use the template, these are now showing as [https://www.mediawiki.org/ MediaWiki], [http://www.php.net/ PHP], and [http://www.mysql.com/ MySQL] in plain text rather than as links as they're not getting treated as Wiki text when they are included in the template like they are in the core Special:Version.
this file belongs into the `akka/dataflow` directory (for us poor eclipse users)
What are valid values, and where can I read more about it?
why do you need long (1s) gossip-interval? timing issue?
This was in place to get timeout behavior on the call, which I was thinking was necessary when sticking to Nygard's version of the circuit breaker.  So if the call exceeds the call timeout that is specified, that can be considered a failure.  

I can certainly remove, and just consider exceptions to be failures?  Or are you suggesting I should find some other timeout mechanism?
Inconsistent naming `Ssl` vs. `SSL`
I agree, frequency is not the right term
Good documented.
(and fix GET)
instead `file_exists()`
The `StandingHeader` is the custom `TabbedPanelHeader` class defined in this example.
https://github.com/kivy/kivy/blob/uix-tabbedpanel/examples/widgets/tabbed_panel_showcase.py#L15
Is there a reason you have changed from None to '' if not provided?

If it is about `if sort_by is None:` then just changing to `if not sort_by:` would seem cleaner
Unfortunately, `"{}".format(...)` is not python 2.6 compatible.  You'll need to change this to `"{0}".format(...)` 

There are a few occurences of this where exceptions are raised.
Is there a reason fanstatic is not being used?

also the ?> is incorrect 

script tags need closing properly too
`<script></script>`  even if you have src= and no content
Just verified RHEL 6.2 (Santiago) with python 2.6.6 includes ctypes so think this has been resolved.
Needs gettext on the descriptions
Missing `</p>`
Cleaner if this would just return the string instead of as a parameter, then these two line things could be combined. But it's just a suggestion, not important.
If the feature has a state of `OpenLayers.State.INSERT`, the state should not be set to `OpenLayers.State.UPDATE`.
All class names need to follow the standard, which is to separate words with '-' rather than '_'.  We're forced to use '_' sometimes because we're translating Rails data field names into class names, but when we can choose, we should follow the standard and use '-'
These are short cuts to get at the Participant and ConversationType objects which are created by the endpoints; not the endpoint units so not remnants at all.
With the previous version, it was possible to end up with a negative sleep_time value.  This would cause the sleep method to raise an ArgumentError that isn't very useful in debugging.
I'm reverting the commit that uses timeout, since it really doesn't get you anything.
This is not a good hash function. We don't use it but ...

Here is what eclipse generates, simpler and stronger:

    public int hashCode() {
        final int prime = 31;
        int result = 1;
        result = prime * result + Arrays.hashCode(family);
        result = prime * result + Arrays.hashCode(qualifier);
        return result;
    }
Can you please fix this header :)
Docs are still missing (as you pointed out rightly) in some places, I will  
take this as a baseline then.
_setActive_
`performSelector:` doesn't accept more than one argument, nor arguments of non-object types.
Style: needs to line up with `String::NewSymbol(...)`
Use uint64_t if ms is always >= 0.
@isaacs please see this benchmark (https://gist.github.com/3265554), in order to get properly disappointed after making such statement!.
Can you reword that? "innovative" is rather generic / content free.
Okay, fair enough. Can you add a JS shim that defers the callback to the next tick?
Suggestion: Move the preceding two lines up, out of the if statement, and move the return statement down, out of the if statement.  Like this, you can eliminate the code duplication in the else branch.
How about something along the lines of:

```
286: if old_sort_id is not None: 
287:     self.sort_title = self.get_treeview
```

removing current `292 and 293`
I don't know how to do it better. If I knew it I past it.
The word "inverse" here is confusing -- this doesn't undo an indexing operation. Maybe something like "This is the opposite of arr[obj] -- it returns all of the items that arr[obj] would *not* return."
Please use `gxp.plugins.FeatureEditorGrid.prototype.xtype` and define `gxp.plugins.FeatureEditorGrid.prototype.xtype` next to `gxp.plugins.FeatureEditorGrid.prototype.ptype` and add API docs, so the xtype also shows up in the generated documentation.
@rafaelfranca it'll be great you post a link :)
Not so easy tho. Have to override a lot of methods to make it exclude lower bound (not only include?)
Ah, I got it.  Thanks.  Sorry, I've got a cold so my brain is running on half power. :(
`distinct` is [public API](http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-distinct). You need to deprecate it.
This method name change seems unrelated to the feature in this pull request.
Here is the escaping line you missed.
If we don't pass `root_path`, we'll face the following an exception.

```
test_structure_dump(ActiveRecord::SqliteStructureDumpTest):
NameError: uninitialized constant ActiveRecord::Tasks::SQLiteDatabaseTasks::Rails
    /home/kennyj/rails/activerecord/lib/active_record/tasks/sqlite_database_tasks.rb:7:in `initialize'
...
```

and related code

```ruby
  1 module ActiveRecord
  2   module Tasks # :nodoc:
  3     class SQLiteDatabaseTasks # :nodoc:
  4
  5       delegate :connection, :establish_connection, to: ActiveRecord::Base
  6
  7       def initialize(configuration, root = Rails.root)
  8         @configuration, @root = configuration, root
  9       end
 10
```

So when executing testcase in sqlite, I think we must pass a path to structure_dump method.
Please see also https://github.com/rails/rails/blob/master/activerecord/test/cases/sqlite_rake_test.rb (we always pass a path).
Lol never thought of it. Tunnel vision rocks.
Calling the exact same closure-creating map call on the same memberof Symbol  in four different places is more than sufficient cause to write a method.
This just blew my mind.   No issues showed up in tests?
That was used in the previous error message, but didn't show anything. 

We don't want the file of this symbol, but the file of the referring class.
And taking into account that I was wrong that "evalf uses _to_mpmath".
Yes, it seems to me as well, that PEP8 says you should have spaces around "*". In either case, I would use whatever looks more readable on the case by case basis, in this PR it seems that having spaces is more readable.
I'm now using `Symbols` when the supplied name is not empty, which allows me to fully rely on `Basic`'s comparison and hash functions.
Agreed, even if there wasn't one before.

Something like the following would be enough?

"Protocol relative url to the Google API loader which allows  access to most of the Google AJAX APIs"
I'm not sure that will work with the 'user.agent' property, b/c of the logic in the js. Or maybe I'm not seeing what your seeing.
Why did you remove empty($this->Controller->data instead of changing it to empty($this->Controller->request->data?
use Symfony\Component\Translation\Loader\XliffFileLoader;

    $app['translator.loader'] = $app->share(function () {
        return new XliffFileLoader();
    });
Needs a cast to `uintptr_t`
in this section and the one above, I think it'd be better to invert things. When I read both of these sections, I thought "oh, we're going to see an example," and was thrown by seeing the cross reference. 

I think the better way to convey this is to say, "for instructions on foo see the bar section." 

as I've mentioned earlier the "please," also feels a little too personal.
The :data:`collections` collection represents each sharded collection in the cluster in a separate document. Given a collection named `foo` in the `mydb` database, the documents in the :data:`collections` collection would resemble: 


It's hard to avoid saying collections a bunch of times, so maybe we can iterate further.
That's how `my_requests_get` gets called, and the headers trapped.
Comment est utilisé *web.scss*? Pour générer quel fichier?
no, it was recommended to be changed from $temp to something more like $temp_style_id
How does a client tell whether a given avatar driver needs custom html?
Well he's got a point. But I still don't like adding inline javascript for this. But there really isn't any other way, is there?
Right now the memory purge method removes these files from the file cache, what should be done about this?
Yes, certainly lower case. Maybe a bit more descriptive. E.g. `$user_group_ids` if that fits.
I'd prefer double quotes instead of escaping.
Hrm, I don't agree. I think when we make a bundle release it will be based on a git tag. It might be a different tag but still a tag.

For now it is the same tag though since we don't push zip file updates.
1) Agreed, but the SVG renderer has code like this all over the place. It mixes in stuff from other modules to be functional.
2) what do you mean by “pseudo-hide”
3) I’m not even sure runtimes create a hidden class for a type that has (in most cases) only one instance. Do you know more?
Not sure I understand. How would that help?
I think this was the only comment you skipped =)
Also think that this should be called something like `ResourceBasedTextResource` or similar, to communicate that it will pick stuff up from resource files. There might need to be a remark tag that describes the naming convention(s) that are used
Please don't put other random stuff in a pull request about hotkeys and mouse-buttons.
try to be very specific in your language when writing tests. These are the errors others will see when something in the product breaks. "load never completed"... load of what?
Remove all the extra commented lines.
Actually, it is now open source. Details of this should probably be in a separate PR. @munslowa probably knows more.
Do the most stuff on the GPU. If you can do the comparison then transfer then reduction, it will be faster then to transfer before the comparison.

When reduction are implemented, we can change it to the all() on the GPU and transfer just the answer. Can you make a ticket so that we don't forget about this?
Don't see where "_get_full_usage" is called. Dead code?
The whitespace here is pretty hard to look at. The indent isn't consistently 4 spaces and the "braces or not" question should also be a bit more consistent.
This is a bad hack that we keep on repeating.
Better add a "last_ping" method on the Device model.
please provide comment what is the format of query ( eg 

" we take 2 formats into the consideration:
1) package name
2) package name + space + version
why (true)?
Nagyon jó, de fejlesztés közben most nem kell update hook-okat írni, ez azért maradhat :)
`:attribute asset_nr` is missing the trailing `:`; without this, the docs will not be formatted correctly.
`jQuery( checkDiv ).remove();`
That @gibson042, even his damn comments are optimized! I understood it to mean "if and only if" as well.
Why take the ua and locale out of the arguments list?
We should symlink against the openjpeg lib symlinks in the prefix, not openjpeg's location in the Cellar. Linking against the Cellar location will cause this to break if openjpeg is upgraded.
`patches` method usually goes above the `install` method.
ok now it is done
I'm really not sure why this hasn't been failing on the test VMs, but it failed on my machine and it was obvious why.
Then you should compose all 3 strings individually. You can't use translated strings like lego blocks; they don't translate well in languages that need to reorder the words to be grammatically correct.
Since `wiki_modactions` needs to be imported, maybe it belongs in `r2.models.wiki`? I think we try to avoid importing controllers in other places.
Ok, I think we have different instincts here, and when I WAS debugging an earlier problem, not knowing that key A was a different binding than key B, even though they looked the same when toString was called in the assertion failure was completely unhelpful.  I have a strong concern about ambiguity in underlying types appearing to be the same things.  I can change it to `@Singleton key` as you say, but I would remove the tag under protest, since the underlying binding and the singleton binding are two different objects.
Still gives a offset notice and proceeds with the code and will result in incomplete code.
Will put the check back.
We shouldn't have to check for fExcludedCategories.length > 0 anymore, right?  containsCategory will just safely return false.
Why does this not get cached in `@allAncestors` itself?
I'd rather we set the sharing feature flag to false in the build helper. It's kind of buried here, and not intuitive that sharing would be disabled in this case even though the feature flag is true.
Is there a way to verify what? That we eventually get either (1) a generic key binding or (2) a key binding for the current platform? We could validate the default keyboard.json, but for clients calling ``addBinding`` directly we can't.
Only complain about the file not being an HTM(L) file if experimental features are turned off.
I see we use this pattern in Editor.js. Any idea why we wouldn't call the method on the instance instead? ``editor._codeMirror.execCommand("indentMore")``
Yes. I added a bunch of comments to clarify this.

Running this on a NodeJS server is a good alternative and should be added in the future. I feel, however, that many people will still find this apache configuration very useful.
https://github.com/magnars/dash.el has ert.el at the same directory as dash.el so this version of ert.el will override the default one.  You can ask author to change the directory organization or use `:type elpa`.
Assuming urlresolvers should be the import, not reverse?
i passed all the files with the autoindent of my editor (webstorm) probably missed the html one.
i'll check
Is there a reason you couldn't use the existing getReleases method?
`( {` -> `({`` same with the closing bracket. Also multi-line it please.
Hahahahahaahah noooo reason at all.
just change the prepare callback name here to ready, and it'll be obvious what it is for.
I don't see a webfonts.less file in css, and the compiled css is checked-in
Yeah... I duplicated it, so people will not miss it. And here it's more applicable then down there. People tend to not read the whole README file.
`target="_parent"` is wrong thing for other web browsers; move it to viewer.js inside "#if CHROME"-block
you need to check whether it actually returns an epg table here.
if (!epg) return false;

could you also move the Clear() and SetUpdatePending() calls to CEpg, and create a method like ForceUpdate() or something that does those two calls (single responsibility principle)
this boolean isn't really needed. just set the value of m_strDirectory and pass it to the client
Pheanstalk should work with `"php": ">=5.2.0"`, but I'm happy to leave it at 5.3.0 if you like.
I gather Composer itself requires >=5.3.0, so it probably doesn't make a difference.
Yep, just the openal in sfmllibs at the moment.
Make sure you have the latest test that doesn't contain the '{unknown}' string - I originally threw in some unusual characters (to make an obvious non-resolvable name) but it turns out curly braces have special meaning in IPv6 which meant that this was actually resolvable on IPv6 systems, contrary to the test assumptions.

Wrt. the 127.0.0.2 example, the resolveIp method has historically only checked to see if the name can be resolved to an address (which is a no-op in the case of 127.0.0.2) - it doesn't actually try to ping the address, since that may not be possible in certain setups. TBH quite a lot of the original class was either broken or accidentally working, so this is an initial attempt at cleaning up and testing the expected behaviour.

I would still suggest someone tries this on a system with squid or nginx to verify this in a real (non-mocked) configuration.
Look down. :)

Unless, of course, you saw that and want it to be reworded. I can do that too.
This line already handles the case where there aren't any speakers in the db. It'll return an empty list:

    Python 2.7.2+ (default, Dec  1 2011, 01:55:02)
    [GCC 4.6.2] on linux2
    Type "help", "copyright", "credits" or "license" for more information.
    (InteractiveConsole)
    >>> from videos.models import Speaker
    >>> len(Speaker.objects.all())
    0
    >>> Speaker.objects.filter(name__istartswith=u'f')
    []
Whatever this is needs to be figured out, or removed if it's unnecessary.
for content and name and perhaps others, you need to say E'%s'
General note, setting variables equal to 'undefined' at declaration time is unnecessary given this is the default behavior of Javascript.
Can you update the usage example to reflect the ST_GeomFromText change?
Please try to respect the formatting you see elsewhere in the sources, it would conform to the style to write this as `if (! indexSet) return string;` I always use braces when spanning multiple lines and compact short statements such as this to a single line.
Than move `$this->_connections->removeChannel($channel)` after the getting responses.
Just trying to keep all the methods for the future refactor :) Tried to keep the original keyboard.js structure in order to separate the isolation from the refactor. But we could remove it if you want :)
These pyparsing parsers are pretty difficult to debug without tracing output like this.  I'd just as soon leave it in (but turned off) so it's easy to switch back on when things are added to the parser etc.
+1 on `lat` and `lon`.
Oh, and it's not necessary to use `.keys()` here since `sorted()` will return a new list anyways.
Bad idea, someone deleteing their account automatically takes all their videos with them?
These few lines dont make it impossible to use multiple instances in parallel, in fact they make it more sane.  Without these lines, multiple instances get URIs distributed between them, which is...non-intuitive IMHO.  With these lines they simply all go to the most recent running version.
I only added it as a hint ... no need to discuss I'll remove it.
You are hard coding column name here which is bad. Plus if your column name is `password` wouldn't it already get unset in `_findUser()` ?
I don't think so, but I'm not strongly opposed to having it. Let's see what
other have to say about it

On Tue, Oct 2, 2012 at 8:54 AM, ADmad <notifications@github.com> wrote:

> In lib/Cake/Log/LogTrait.php:
>
> > + * @copyright     Copyright 2005-2012, Cake Software Foundation, Inc. (http://cakefoundation.org)
> > + * @link          http://cakephp.org CakePHP(tm) Project
> > + * @since         CakePHP(tm) v 3.0.0
> > + * @license       MIT License (http://www.opensource.org/licenses/mit-license.php)
> > + */
> > +namespace Cake\Log;
> > +
> > +use Cake\Log\Log;
> > +
> > +/**
> > + * A trait providing an object short-cut method
> > + * to logging.
> > + *
> > + * @package Cake.Log
> > + */
> > +trait LogTrait {
>
> Wouldn't keeping prefix "Trait" for all traits be better for consistency
> and easier to identify a triat file?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cakephp/cakephp/pull/885/files#r1736029>.
>
>
hmm, you should use a ``@dataProvider`` annotation instead. Currently, if one of the implementation fails, it will be really hard to debug the ailing test as assertions are used twice in the same test. And if the first implementation fails, the tests will not be run for the other implementation (as it is a single test).

```php
<?php

public function getReflectionClass()
{
    // initialize the Psr0Parser

    return array(
        'native' => array(new ReflectionClass($className)),
        'parser' => array($psr0Parser->getClassReflection()),
    );
}

/**
 * @dataProvider getReflectionClass
 */
public function testAnnotations($class)
{
    // the existing method without change except the instantiation of the reflection class.
}
```

This way, the 2 implementations will actually be 2 tests, which can fail independently. And PHPUnit will give us the name of the dataset when it fails (which is why I specified a key as the objects are not fine to identify the dataset)
Even though it is in a different place I think it is confusing to have this named the same thing as the method decorators.  I would use a name that suggests that this method *runs* a line magic.
OK, I've added the code and tests in b29fa5a, I think it's what we want, let me know if you see any issue.
> how can I inform passers-by of what this branch is supposed to be/do, and that they should run
>       %pylab inline
>       %config InlineBackend.figure_format='svg'

That's always been how you enable SVG figures, and SVG figures are nothing new.  So it should be clear simply from the fact that this PR relates to SVG figures that this is required, or if you don't think so, then simply mentioning that once (as you just did) should be quite sufficient.
OK, your call.  Actually, I've always wished Python provided a dict method to do 'slicing': `somedict.subdict(keys)`.  It's just a few lines of code to do it manually, but I end up doing it over and over in many places, and it annoys me it's not in the language.  But for this particular PR, it's OK to leave this here, esp. since it has that special-casing of `ignored_keys`.
The problem is when metadata does not exist, javascript return a `undefined`, so even if I map nothing to undefined you will still get some (and the ui will be inconsistent) if user have never touched the cell.
So I preferred to explicitly map it to undefined.
I always get my regexp from @bquorning... they are so fresh and organic!
Why is this needed? I don't see anywhere in this code that writes to `stdout`.
We should be able to merge these two methods using optional parameters:

```ruby
get "/activities/:description.?:format?" do
  messages = messages_for_activity(params[:description])
  format   = format_for(params[:format] || 'html')

  render_transcript(messages, format)
end
```

Also, do you think the route should be namespaced to a certain channel? For example:

```
/:channel/activities/:description.?:format?
```

I know right now we are only using anita in one channel, but since we are already using that format for general logs, I think it makes sense to stay consistent and do the same thing for activities
Is there already an external script for this page? If so, put it in there. If not, I guess we can clean this up later.
This is soooo much more readable than the original version.
Woah, nelly! This isn't javascript!

But seriously, better to just put this in an if block--it's the same number of lines.
You can just pass `, save=True`
oh wait--this is redesign related, i bet.
Errors seem relatively frequent, so I'd keep that in mind. I am fine with whatever you end up doing, just keep in mind that FTP can be very flaky.
I think it does not matter in this scope (tutorial)
Personally, I find the "here's the regex we used" error message rather too exposing of implementation detail. But I'm open to other opinions as well as addressing a fix in a different (later) PR.
It wouldn't hurt to put an actual description here… this is used as the "description" on PYPI.
and how would I distinguish a cache miss from a cached ``false`` value ?
couldn't you use the color support of the Console component instead of doing it by hand ?
I prefer the previous version which is IMO more readable.
@hhamon I think no.
See the [Request class](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L147) for instance.
Well, writing unit tests at the same time than the code would ensure that your code works. In the current PR, there is several places triggering fatal errors or notices
why not simply `return 1`?
I also believe that `L{1,4}` works faster then `LL?L?L?`.

And same pattern used in the line above. I'd say, abused =)
At the beginning of this function, we may have some VIFs using the bond and others a bond slave at the same time. It think it is safest to get rid of anything referencing bond slaves as soon as possible.
Why use `.join` instead of a full path as a string, maybe stored as a variable up top of the class?
You never know.  There are some crazy mofos on this earth :trollface:
double 'is'
remove extra braces and line white space
You are absolutely correct! Rolling a new pull request to fix that :)
or

    if (['331', '332', '353', '366'].indexOf(message.rawCommand) != -1) {
      client.emit('raw', message);
    }

Not quite as immediately understandable, but shorter.
Rune is right - it may be quite a few function calls, but done this way it is possible to add more fields later, and latto theme will still render them. Some module we do not know about might add extra fields. Latto is explicit about the ding fields it knows about - what fields it is unaware of will still be shown and can be manipulated through field UI. Might save a developer some frustration down the road. 

The way I see it, this is the only way we can truly mold the markup into the shape we want. The event node is one of the more complex pieces of content in this regard.
Attributes have to be written in the order they appear in the xsd.
This looks unused, and this sort of simple "getter" is generally unnecessary in Python.
the `.danger` class is defined in `shared/style/buttons.css`, maybe you could use it?
That's totally right :)
do you need cont var?
What is checking this condition?
Please help merge the latest revision, since the above `,` has been removed.
Thank you.
nit: FB: -> Contacts ?
Spreading spanish :)
I think we can refine the naming to make this PR better :)
Out of curiosity, is this a requirement?
(setting the `dataset.l10nid` when we also set the content ourselves from JS)
Not sure, since the one for the notifications lives in system app now...
We could have a numberOfVibration setting but it sounds overkill
As the use of <tt>continue</tt> is not usual, I prefer to comment its apparitions, but I think the same so I removed it.
Not always but in this case this is likley that the code that is a few lines above return |app|.
= == - ?
not sure if @vingtetun s  preference is for absolutely every anon fun to be names, but I definitely think this one should be
Nit: But seems a little more reliant on HTML elements than needed (which means this kinda tests for two things, but would break if only one -- the name of the home page in the template -- changed). If there's a more reliant-to-HTML-changes way of testing this I'm game... but it's pretty minor.
think this will throw an exception when there is no user with the username
Agree! get_fqdns() should return a list and print nothing. get_info() should be called log_info().
Maybe call it are_all_reservations_ready?
Sure, will give it a crack.


On 30 December 2012 16:21, Myron Marston <notifications@github.com> wrote:

> In lib/rspec/core/subject.rb:
>
> > @@ -201,6 +201,14 @@ def subject(name=nil, &block)
> >            end
> >          end
> >
> > +        # Just like `subject`, except the block is invoked by an implicit `before`
> > +        # hook. This serves a dual purpose of setting up state and providing a
> > +        # memoized reference to that state.
> > +        def subject!(name=nil, &block)
>
> It'd be good to have full yard docs for this....care to take a stab at
> that?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rspec/rspec-core/pull/760/files#r2520901>.
>
>
看代码ms是一个开发者无关的变量吧   加个 _ 区别一下
Should the `aliases` be factored into the equalizer? The general pattern is that all the object's state is used.
見直し終わり
use the 'is' operator here, rather than ==
Why are you starting a separate process here? Can't you handle these messages in the server process' handle_info?
If you fix the pkgver from the comment above. You can resubmit this pull request against the master branch and we can merge it in.

Against the experimental branch this PKGBUILD will need to be recoded to take into account all the new additions and changes that have been made in experimental.

So I think it's best to branch this pull request into 2. One for master which is reasonable to be accepted and updated on Arch immediately and the other branch will track modifications needed for the experimental branch.
if (that.filterDir.indexOf(dirName) !== -1) { 
用明确语义吧。
Isn't the file `.pilot-manifest`?
I think there might be an operator issue here.

The above statement is equivalent to 

```ruby
cover_id = metadata.css('meta [name=cover]').attr("content").value rescue (nil || 'cover-image')
# and thus:
cover_id = metadata.css('meta [name=cover]').attr("content").value rescue 'cover-image'
```

meaning this behavior:

```ruby
cover_id = (-> { nil }.call) rescue nil || 'cover-image' # == nil
cover_id = (-> { raise 'err' }.call) rescue nil || 'cover-image' # == 'cover-image'
```

not sure if it matters, but would be nice if the intent is clear =)
I guess, but when's the last time you've used JSON like that? I cant say I have, beyond config for our app I've never used it, and config doesn't belong in public components. JSON is questionable but im definitely not into supporting extensions like node does for .coffee etc
it should be marked as incomplete, not as skipped as the issue is in the way the test is written, not about the platform running the testsuite
you can use ``/`` instead as ``DIRECTORY_SEPARATOR``. It will make the code more readable, and it works well on Windows since 5.3
`return (bool)(file_exists($file) && include $file);` ?

And below you should re-use code not add everytime new with usage of other CS convention =)
The function definition must precede the first call to it. There is no method of "declaring" the function, as, for example, in C.

I'd prefer 'abort' instead of 'aborting', but that's a minor point.
I thought it weird too but apparently Seam transaction has this dependency on HIbernate. Have a look on the stacktrace if I do not include the module dependency: https://gist.github.com/3161538. I personally think that apps should rely on the server provided libraries as much as they can, in case of EAP these are considered stable versions that work well in conjunction with other server libraries and server features like logging, transaction, etc. Another important point is that relying on EAP server libraries also makes easier to provide bug fixes and security patches across all apps deployed on this environment.