labofsahil/github-event-dataset-2012 huggingface dataset:
Yeah. `etc` and `var` point to the top-level directories, everything else expands to `prefix+...`
> It's not an objectionable goal. But this is your software. Why can't you carry this patch?
This discussion is out of scope here. If you'd like to chime in on that, head on over to lists.zx2c4.com where there's quite a bit of discussion.

> If you aren't actually interested in supporting OS X properly, then why did you submit the formula in the first place?
I don't think the premise of this question has been actually been established. Who says upstream isn't interested in OSX?

> Homebrew is not Debian. We have real objections to carrying patches that can easily be incorporated upstream.
"Easily incorporated" is again another spurious claim. I'd encourage you to join the mailing list if you'd like to chime in on this discussion.
Thanks for fixing this. Let me bring a minor improvement/simplification.

As far as I understand, we first get the list of candidates (`commonprefix`) and then choose the best match (`localRoot==pwd`). That's how I did it initially, as far as I remember.  Looks we need the candidates only to print them in the error case. That's kinda pessimistic behavior. Now I think that the code would be clearer if we try to find the best match (`pwd==localRoot`) from the start. Then, if we didn't find the exact match, we print the candidates. This way we will have no the for loop with a single iteration.

I'm not sure how to propose code changes to a proposed pull request (forking your fork?) so I'll write the code right here:

```python
if any(l == pwd for (s, l) in folderMaps):
	return

print('You must be in a mapped local folder to use "git tf clone":')
for serverRoot, localRoot in folderMaps:
	if os.path.commonprefix((localRoot, pwd)) == localRoot:
    	printIndented(localRoot)
fail()
```
Note: I didn't run/check this code.
This should only be done in getCalendarObject() to save bandwidth. If calendardata is needed it will be called.
OK, I was not clear enough, sorry.  In any case, there is no clear solution in sight.  My only guess is that packaging should address some case considered to be "most usual", like maybe Python 2, and not running Mac OS.  For anything else, Pymacs should be installed the "hard way", or maybe tuned after installation.  We'll see how it goes, and acquire experience along the way...
That's a more general problem around dealing with bad messages. Our failure handlers should take care of this.
Ich finde bei 'false' könnte man denken, dass es ein reines boolean Feld ist und man es auf 'true' ändern kann. Daher finde ich 'null' als Gegenwert zu einer Proxyangabe passender.

Ja, host und port. Wenn der Port fehlt, wird 80 genommen.
Since `_on_create` is called during `_commit`, why is the call to `_commit()` necessary here?
Fixed, though I don't think it's better. I did a quick search and it's weird: implementation details LOVE 'we', but most documentation avoids it. But you can find uses in careful libraries with Guava and java.util.concurrent if you have the right regex.
I'd prefer to not have such comment lines... Thats what we have git for...
Can you explain why this list of XML built-in entities is not complete?
I would recommend using fluid.transform (similar to map functionality) instead of a straightforward for loop (Documentation can be found here http://wiki.fluidproject.org/display/fluid/Framework+Functions#FrameworkFunctions-fluid.transform%28list%29). 

It should be very similar to how the utility is used in XMLSettingsHandler (https://github.com/GPII/universal/blob/master/gpii/node_modules/settingsHandlers/src/js/XMLSettingsHandler.js#L73). This way we will avoid references like app[appId][j] and keep the overall codebase consistent.
:) Done.
This should probably return a 401
Yes! Why didn't we do this sooner?
iOS 4.3 doesn't support `position: fixed` and will ignore the next line; `position: absolute` is the next best option.
This could be merged with the above test, no?
So the consequences right now are that the old CodeHintList.$hintMenu gets left in the DOM forever, and in PopUpManager's internal _popUps list?
I don't think we need this at all. You're assuming that the user would like to close the tag right after selecting a tag from the code hints, but most users would need to enter some attributes and this would create disruption or inconvenience in users' workflow. 

Besides, if the user is replacing an existing tag, this code will insert invalid HTML. For example, if you have ``<span class="foo">`` and you set the cursor before span and select div to replace it, what will happen with your code?
This probably has something to do with #1257, but we should put a comment here about supporting inline editors.
Hi Jason,
	I explored that idea a bit but that feels more complex since all the add measure calls would need to change. There are some cases where the markStart and addMeasure are not in the same scope so sharing the ID without globals would be hard. I like the current solution since it allows clients to manually pass in matching string if they want (this works well when the start and end are not in the same scope), or if the timer name is a complex concatenation the return value serves as a convenience function to avoid mismatching timer names. I know it feels a little awkward, but it's simple and it minimize the amount of code necessary to instrument a function. 

-----Original Message-----
From: Jason San Jose [mailto:reply@reply.github.com] 
Sent: Thursday, May 10, 2012 11:05 AM
To: Ty Voliter
Subject: Re: [brackets] File Open Performance Tests (#841)

>       */
>      function markStart(name) {
> -        if (activeTests[name]) {
> -            console.log("Recursive tests with the same name are not supported.");
> -            return;
> +        if (enabled) {
> +            if (activeTests[name]) {
> +                console.log("Recursive tests with the same name are not supported.");
> +                return;
> +            }
> +            
> +            activeTests[name] = {
> +                startTime: brackets.app.getElapsedMilliseconds()
> +            };
> +
> +            return name;

You could also just keep an auto incrementing id and return that from markStart() to pass to addMeasurement() instead of name.  name could then be stored as a property

```
activeTests[id] = {name: "", startTime: ...} ```

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/841/files#r803744
Hmmm--I just synced and I still see the same problem. I'll see if I can figure it out.
You might have to do this fixup for results_path too. I couldn't get the script to write out the results on Windows (it would execute the tests, but no results.json file showed up).
Nice touch adding these markers!
Why is this done all here and not with APF databinding?
Can you do a try/finally here so that if something happens in fire(), the lock is still released?
This is where it's getting deleted, any thoughts? I simplified from https://github.com/dimagi/core-hq/blob/master/corehq/apps/reports/tasks.py#L60 (namely, using _id instead of get_id and not calling unicode()), and it works locally.
I think my biggest problem with this is that we call `serialize_recurse` every time, then compare the object to the result of the serialization. So I am not arguing the purpose, but the implementation has to be unwrapped into something that looks less obscure. Maybe something in this genre?

``` ruby
def serializable?(object)
   object.respond_to? :serializable_hash
     || object.kind_of?(Array) && !object.map {|o| o.respond_to? :serializable_hash }.include?(false)
     || object.kind_of?(Hash)
end

def serialize(object)
 # just like now
end

def encode_json(object)
 return object if object.is_a?(String)
 return MultiJson.dump(serialize(object)) if  serializable?(object)
 ...
end
```

I can take a stab at this if you don't find anything workable.
OK, so should I just create new module something like "middleware.py" and put it in the root of application or should I put it somewhere else?
Space before /.
But this is not the same. The point is that every visitor will have an user object which will be created automatically (and based on browser settings). And then language will be set based on this user object.
I've now moved it and created test_util.py
This seems worse than the previous implementation, now we call uuid4 every time we fetch a user by email, which is the common case (subscribing). Why'd you change to this?
Please don't abbreviate this. Use `account_manager_page` and then the comment above is not needed.
Well the background job process should really be independent.  There's no particularly good reason why we should need a web process just to spawn a background job process.  Similarly, we might want varying numbers of each - we don't necessarily want to spawn multiple workers just because we have multiple web container processes.

It works this way for testing because the test suite runs the whole app, so while it runs the web app in-process it needs to also run the background job and a child process is a convenient way to do that and also be (fairly) sure that the background job will be killed if the tests fail messily.
It's indeed a relative import, because we import _sd_booted from systemd.py in the modules directory. This way we can't conflict with any global systemd module.
http://hackage.haskell.org/trac/ghc/ticket/7395


On Thu, Nov 8, 2012 at 9:41 AM, Herbert Valerio Riedel <
notifications@github.com> wrote:

> In Data/Hashable.hs:
>
> > @@ -149,35 +166,85 @@ class Hashable a where
> >      -- the additional requirement that any instance that defines
> >      -- 'hashWithSalt' must make use of the salt in its implementation.
> >      hashWithSalt :: Int -> a -> Int
> > -    hashWithSalt salt x = salt `combine` hash x
>
> @tibbe <https://github.com/tibbe> are you gonna bring up this issue on
> ghc-users or ghc-Trac? If it is fixable (so that the current argument lose
> their weight) I think it would be worth it to help adoption of the
> default-signature feature
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/tibbe/hashable/pull/33/files#r2070131>.
>
>
Add a comment here describing what this struct is used for. Make sure it's clear it's for the Hadoop jobs (evne though it's in the file name)
Should this be in _() for localization?

_("Cancelled synchronization of %s") % "#{@sync_of}: #{@obj.id}"
RIght, fixing. I did not know this!

FYI http://www.themomorohoax.com/2008/12/08/and-vs-amperand-in-ruby
Would you mind keeping 2 spaces here? I hope I read it correctly...
The space was collateral damage.
This shows up as "API/Reference" and then "Reference/API" right below it, due to `automodapi`
I think there's merit to both subclassing from ndarray and subclassing from object. I guess you could have a mask that uses some value input. 

Anyways, I'm just warning if we allow masks and errors that are not arrays that this means we will have to write stuff like .sum(axis=5) ourselves. Maybe that's worth it. @andycasey, your input?
Agreed - I already took some notes and updated this in master after doing  a dry run.
not sure what I meant to do here, but it's a moot point because it's now removed due to the discussion above
def mac_addr_str
I changed the type name and removed `handoffs()` since it was used in only one place.
1000 and 2000
* Pointers (such as CBlockIndex*): use `%p`
* size_t and friends: use `%"PRIsz*"`
* uint64_t: use `%"PRI64*"`
* unsigned int: use %u
* signed int: use %d or %i
...

    #define PRIszx "%Ix" includes % whereas #define PRI64d "I64d" does not.

True. Feel free to remove the %, I added those macros in a hurry just to demonstrate it, but it would be closer to the standard of PRI64x by removing it.
Won't the previous value of fValid, coming from either before the loop or the previous iteration, which is not yet BOOST_CHECKED (as far as I can se in this context), get overwritten here?
I dislike the possibility of bitcoind just aborting. Is there some reason not to make this an if() block as a failsafe?
doesnt the parent already unset the pw?
Will we add the end re-indent all comment blocks? or will this still be our standard?
Adding this define() here seems to increase the amount of code used, not decrease it.  Why change it?
Ok, fixed, I added widget_type() method on the MockWidget.
* type: well right now we have nothing to fetch the type for a subject, the metadata loader will be able to get type for a class. i think its ok that way. in my entry point for example i load the data by subject to find its type. hm. not sure how that would work out if i would want to support create...
* subject parameter: this is optional, the main intention is that for the delete request i can have a different logic how to get the subject from the request (e.g. i have the subject as part of the url path, not a subject GET parameter). but indeed this should be better explained. and the workflow code should first check if data contains a subject before looking at the url.
by the way, not passing the type did not make sense here, as the data is raw and we need to build the model class from type and data... the metadata loader should be able to fetch metadata based on the model class, so it can come only later.
just noting this in case you wonder what happened of that idea.
Oops, also s/Foo::Tag/Flapjack::Data::Tag/ ... reworking this.
done. But not sure it was worthing it (for the moment!). The 2 clean commands always return GitTfsExitCodes.OK and if there is something wrong an exception is thrown so just call sequentially the 2 commands is enougth...
Is that defined?  I wasn't sure if it was strictly defined as MAGIC*2, or MAGIC+foo, or what.  I just remembered a recent conversation where there was a question about override, so I made the code assume as little as possible, because I am least familiar with this part of the code.  But ESC_MAGIC2 seems fine to me.
That's fair. Maybe comment it out for now, instead of removing then?
This should be of type str with a store action, not append.  Append is for lists only.
I don't think so. A call to `with_foo($bar)` would give me an array like this one for `$parameter`: `array(0 => $bar)`. Thus, I'd want only this first parameter passed to `with()` as the second parameter.
@nulltoken So, I'd like to have a little more discussion about this, maybe bringing in @tanoku too. You are right, the way this is written today, the test is not useful. However, I think because of the way the parent function (`collect_attr_files`) is written, the behavior is at least predictable - i.e. the index will never be NULL - it will always be allocated.

The question I'm left with is whether it is worth it to add the complexity to change this. Given a newly created in-memory index, then the code which looks for `.gitattributes` files will never find them in the index, so the behavior will still be correct (i.e. the index versions of attributes / ignores will not be used).

I could eliminate the `info->index != NULL` test, since right now it always returns true, or I can leave it in, so that at a future point we can rewrite `collect_attr_files` to not allocated the in-memory index if there is no on-disk available. I'm not feeling like it is urgent, although maybe I should add a comment.

What do you think? @tanoku Do you have an opinion?
Yep, that works well and ~4x faster per jsperf run

From: jimmyhchan <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/dustjs <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, August 15, 2012 3:09 PM
To: linkedin/dustjs <dustjs@noreply.github.com<mailto:dustjs@noreply.github.com>>
Cc: Microsoft Office User <rragan@ebay.com<mailto:rragan@ebay.com>>
Subject: Re: [dustjs] Make $idx/$len work for all array objects and not leave old values in contexts (#113)


In lib/dust.js:

>          chunk = body(chunk, context.push(elem[i], i, len));
>        }
> +      delete context.stack.head['$idx'];


if we are just resetting these.

context.stack.head['$idx']  = undefined;
context.stack.head['$len'] = undefined;


should be good enough and a little more performant.

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/dustjs/pull/113/files#r1387916>.
Quick Q: Why would this raise an exception in invocation?
This data value is never read back.
For l10n, need to do `{{ _(topic.title, 'DB: topics.Topic.title') }}`
doh :P
Instead of removing this, if you have a need for an id in the link, we should instead extend the customization of these links to support what you need. That way we can issue a pull request to the community instead of maintaining a fork of this page.
Sure, you can see the example in the test class. I create the query with Elastica_Query::create($queryString); and it don't work like is expected, well, it don't work like I expect :) May be I'm writting incorrectly the query, I'm not sure, but the test sends a query with an empty filter field.
not conventional !
If it can only be an array or null, please add the array typehint
Mistake :P
Thus, ``$groups`` does not exist (credit for this goes to @JMSBot which uses the symfony PRs as [its testing](https://github.com/JMSBot/test-repository/pull/353#discussion_r1498337))
Simply checking maxlen != 0, now.
inline comments are indeed not refreshed automatically
hmmm, I can see them used just below.
what about using ``!empty()`` instead ?
It uses the same character set as query results (character_set_results).
Not really from the js world myself, so you would prefer back reference by index instead?
包括下一行，都是没有用的话
Not a valid epsg is it?
Given the likelihood this code will be subject to the rigours of copy-paste-hack, I take your point. It does make some sort of `GeoreferencedImage` seem attractive though.
Yep, switched editors/machines.  I need to sync up my tab behavior
don't commit until I fix a bug with this line (if unauthorized but supported, it will continue and blow up)

also have some logic cleanup incoming...
Also, the line after this should use string formatting instead of string concatenation. To combine the two issues:

    try:
        docstr = '%s\n\n%s' % (parent.get_call_signature(), parent.docstr)
    except AttributeError:
        docstr = str(parent.docstr)
Care to explain?

I likely dont even need to specify el actually, was just following some examples.
This looks like a typo. I believe this should be 

         SecurityExtension.getResourceDescriptionResolver(Constants.FLUSH_CACHE)
and just `call = telephony.dialEmergency...` here
Surely this will only search for matches in the top 20 sites, that's not a full table scan. Is this what you intended?
What feature do we want here exactly?
Do we need it? When we send a SMS, it turns to 'sending' or 'failed' and it's stored in Gecko right?
This kind of buttons use to have some icons (or not) and are used in many context that the default,accept,dismiss ones doesn't fit the needs of the design.
They are used to be in context with more buttons such a settings list, contact information (adress, mail), etc...

So yes, is a generic thing.

BTW: i will fix the classname typo
Please if not used remove it
Should we have a better handling? Changing the message should be ok
nit: anonymous?
How about:

wallpaper:active > wallpaper-button, wallpaper-button:active {
  /* highlight image here */
}

Does that do what you want?
I think I'd go for filing a bug on this. It's a bit out of scope to block this on, though it probably will need solving.

As for how to solve it, I think the best approach is to look at introducing qt_foo-style private functions instead of screwing around with QApplication's public, published API.
Ideally this error should be presented to the user, not a full traceback. 
I don't know how to do it properly.
What is the reason for capital S in String.Format?
refreshTime
It looks like this is hard-wrapped onto a newline, it should all be on line 23.
Please give me example code.

On Fri, Nov 16, 2012 at 9:29 AM, Chris Bunch <notifications@github.com>wrote:

> In lib/file_io.py:
>
> > +
> > +"""
> > +This file contains functions for doing file IO and logging operations. Many
> > +of the functions serve as wrapper for easy mocking.
> > +"""
> > +
> > +def read(file_name):
> > +  """ Opens and reads a file, returning the contents of the file.
> > +
> > +  Args:
> > +    file_name: The full path or relative path of the file to read
> > +  Returns:
> > +    String containing the contents of the file
> > +  """
> > +
> > +  FILE = open(file_name, READ_ONLY)
>
> Don't read files like this - do it via with, in the Pythonic way.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154263>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
@stof @stloyd @pilot to be honest I dunno how do it phpspec2, but I can check/ask. BTW I do not need apc ext to "test" this class, cause apc functions are just overrided/mocked for Gaufrette/Adapter namespace, so I do not understand why I should skip test in that case... I think I will create specification which can check this and then add "if" again just to be sure. Thanks for feedback
Correct, will drop.
Isn't the option parsed called "seven_zip"?
Why not hold message in i.e. `$msg` and then at the end of function just use: `throw new \UnexpectedValueException($msg);`
If you add this, then I guess you should add a check at https://github.com/fortrabbit/composer/blob/4f4cbc17d93a13144423ab1339a7177859a7f869/src/Composer/Command/CreateProjectCommand.php#L196 to skip the block if $preferDist is true, otherwise we prompt the user for nothing. Also if $preferDist is true and $keepVcs is true it should error out, because that can't really be combined.
Just curious why you moved this flag to mini.c, it's not immediately obvious to me.
監訳ありがとうございました。
and always～以降が読み取りにくて困っていましたが、監訳していただいてなんとなく文書構造が分かりました。
そこで勉強のため1つ教えてください。

and always～について下の文章とした方が分かりやすい（文法的に合っている？）と思うのですが、
私のこの認識は正しいのでしょうか？

and always whitelist the attributes that you allow to be changed.
`replies`: Should the search return tweets that are replies to another tweet, ie. have `in_reply_to` field set in Twitter? `true
`retweets`: Should retweets be included? When set to true, each retweet of a matching tweet will cause a new message to appear in team inbox. `true` or `false`
@SaitoWu  gitolite 3 doesnt have `~/share/gitolite/hooks` so we use `~/.gitolite/hooks`
It might be cleaner to just get rid of reserve cap range in your next commit.  You can think that we automatically have our own range reserved when we simply create the component.  I always get quite excited when there's the opportunity to remove significant amounts of code.
It seems I'm getting old. Current implementation seems to be fast enough. I switch the code to TimeGet().
Should put in basic arg parsing / sanitising code - can just raise a backlog issue though.
This line is a little long, but I am not sure what the best thing to do is.  The string "ctx.getMessage().getProtocolParameters().get(" is repeated several times, making me think that a helper method on the CommandContext is in order.  For now, please just format this below 160 characters.
translation....
Shouldn't this be named `getOwnPropertyDescriptors`?
Although, I just realized that in some case we do `require('cuddlefish')` and in such cases there will be no `atob`  / `btoa` so this way is also no good. Something that may work and be a best option is probably a module in a following form:

```js
// Loaded as JSM
if (~String(this).indexOf('BackstagePass')) {
  EXPORTED_SYMBOLS = [ 'atob, btoa' ];
} 
// Loaded as CommonJS module
else {
   const { Cu } = require('chrome');
   const { atob, btoa } = Cu.import(module.uri);
   exports.atob = atob;
   exports.btoa = btoa;
}
```
@6a68, @klrmn - Do you want the assertion in the test, or was this used to develop the tests/POM?
I think the import of TestClient here requires the addition of a __init__.py file in datazilla/tests/webapp.  I get a "ImportError: No module named webapp.client" from this line when I run the tests.
Nit: I find it weird to catch the error first rather than view the reply... unless the reply is still truthy if there's an error.
Yeah, I was just joshing. In reality, @fwenzel is right; probably no need for this line at all.
Although I understand, it may be better to say, "Set the maximum time allowed for a resolution before the operation times out. ". And then I wonder what happens after that? Fail? Null value?
We are asking the puppet to not fork and go to the back ground so that the initscript library is able to manage the daemonizing. This is done so that the init script can control the lifetime using a separate pidfile, and hence distinguish it from a command line invocation. This is also the reason for nohup.
That is a lot of action at a distance!
Nope, please look at line 230.
That is an option, but it isn't compliant with Underscore.js. See my other comment about dropping the Wrapper versions. 

I think that in this case, the compliance is worth the runtime risk. FYI: I was thinking about adding an assert if the collection and block types didn't match. Maybe that's a good safeguard?
how about a max length validation on the model for the title?
Perhaps this method can also be split up into smaller chunks? Smaller methods = lots of benefits! :D
`che abbiamo un controller` -> `riguardo il controller da noi creato`
Do you feel this change significantly breaks conformance to contract-oriented design? 

In my opinion abstract request/response classes are needed for encapsulating some universal framework-wise logic. Before this refactor each class also had a matching interface which meant that components could type hint on either the class or interface, but I think that might get inconsistent with time (when should I type hint the description and when the class? What about user code?)

Ok. Are you going to start the discussion?
Don't forget to remove the comment if it's not used
Sad Panada, perhaps pull out the formatting? it makes this change look a lot bigger than it is.
I'm confused! >_>
we know the values here, but i think the casing doesn't matter here
@stof Absolutely not :) With this change it is installable at travis. Without it composer complained and didn't install anything :)
Personal preference I like my constants at the top of my classes just below include and extend statements.
slightly confused by your mixture of `this` and `self`. why not consistently just use `self` since you went through the trouble of making it in the first place?
all the protected names (well, string that can be compiled by re) should be defined as constants
Function calls are expensive ... I do not really see the advantage over keeping this one line. It would just be another line with a function call. I'll think about it.
Enablign packed-groups, and fixing that feature with a couple of commits (e.g. 8ab0789fd96b0bbb7615effd435e6f6390221a5c) fixed the issue: DOLFIN now builds, and the testcase the user provided also worked.
EasyBlock should be called EasyConfig

a .eb is an easyconfig file, an easyblock is a Python class that derives from Application

This does make the naming of the configuration of easybuild itself a bit troublesome...
yea i'm pretty sure about that. goGetUserInformationRequest() is protected and gets called by parent GenericOAuth2ResourceOwner::getUserInformation(), which always adds the "access_token" get parameter to the URL. So it always has a query string. for clarification, i could add an additional check for that.
This should be in the -with-hibernate bom I think?
How'd I miss this... Cherry picked it from my old PR, completely forgot to change it, thanks
should be mysql -u root ?
`iteritems` is going away in Python 3, might as well use `items` here.
Hmmm, I am following https://webmademovies.lighthouseapp.com/projects/63272/styleguide

But, I can see multiple interpretations.

Like:

  //  Good
  
  if ( condition ) {
    
    doSomething();
  
  }
  
  while ( condition ) {
    
    iterating++;
    
  }
  
  for ( var i = 0; i < 100; i++ ) {
    
    someIterativeFn();
    
  }

and:

  //  Good
  if ( true ) {
    return;
  }

  if ( true ) {
    blah();
  }  
  
  if ( true ) {
    
    foo();
    
  } else {
    
    bar();
  }
це все як раз дефолтні, брав з документації тут:
https://github.com/KnpLabs/KnpPaginatorBundle (Configuration example)

зі старими параметрами (як було до composer) не хотіло працювати
If server.start() is a blocking operation that will return if the servers exists/crashes, then base.shutdown seems to be a good choice to put in a finally block here.
nit: function names should be verbs describing what they do. This is additionally confusing since calling `styleUnset()` feels like something is being unset, which is pretty much the opposite of what this does. Maybe `setUnselectedStyle()` or something.
I will change to say :green for good things and say :red for bad things. A cool change!
Why it must be string ?
Theres a `parseURL` helper already. `parseURL(settings.url).href` should work.

I think we should avoid setting `requestUrl` on `options`, maybe just make a new local for it.
if I understand correctly, the "maintenance" block is always on the top of the dashboard, it takes a lots of vertical space for something that is useless for most users. In addition, the only way to hide it is to override dashboard.tpl...
Include footer in rendering
Perhaps we should fail if `macro_image` is already non-NULL?
Dox has some support for it.
It will output an object:
```javascript
{
    ...
    "otherMemberName": "Interface.get",
    "thisMemberName": Amazons3.get"
}
```

That said, I mostly used this as I didn't want to copy/paste the jsdoc from the interface each time it changed. I think this should be mostly stabilized by now so copy/pasting might not be a real issue anymore.
Reduce indentation here and below.
According to spec doc, this should be `...del('/api/content/:contentId/comments/:commentId', ...`
This should probably just check to see if this is the reference currency, then assign a value of one. It would be more obvious in the code.
Mijn pseudo code:

`
// for every enemy to be spawned
// get a random spawnpoint
// tell spawnpoint to spawn a new enemy
`

Laatste regel zou ik doen als:

`js
spawnpoint.spawnEnemy();
`

Wat je dus in `EntitySpwanPoint` moet doen is:

`js
spawnEnemy: function() {
  // do magic
}
`
Интересная реализация цикла down to. Но чем ж вам так for не понравился?)) Просто ради интереса спрашиваю.
по заданию вам нужно изменить не количество от общей последовательности, а процент от общей последовательности.

Понятное дело, что для 100 элементов процент будет равен количеству, но когда количество элементов больше или меньше - то метод будет отрабатывать некорректно (например, я захочу изменить 100% моей последовательности, состоящей из 245 объектов)
метод был больше для себя - поправила в соответствие с Вашими замечаниями
Вы написали специяльный метод для подучения константы **dnaSize** в одном месте им воспользовались, а здесь нет, нелогично)
В данном случае вообще удобнее зделать **#define**
Please can we remove commented-out code
True, doesn't need to be.
Style-wise, I prefer either:

```ruby
g = GoverningPeriod.make :start_date => Date.today,
                         :end_date   => Date.tomorrow,
                         :party      => nil
```

or 

```ruby
g = GoverningPeriod.make(
  :start_date => Date.today,
  :end_date   => Date.tomorrow,
  :party      => nil
)
```

(Sublime probably has a command to do the `=>` alignment)
It looks like you've got a double `||` here for some reason.
Together we are already two ;-)

On 11.12.2012, at 20:32, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > @@ -452,6 +452,7 @@ def apply_hilbert(self, picks, envelope=False, n_jobs=1, verbose=None):
> >      @verbose
> >      def filter(self, l_freq, h_freq, picks=None, filter_length=None,
> >                 l_trans_bandwidth=0.5, h_trans_bandwidth=0.5, n_jobs=1,
> > +               method='fft', iir_params=dict(N=4, ftype='butter'),
> I don't know what @mluessi thinks but I hate single letter variable names. At least order is explicit.
> 
> —
> Reply to this email directly or view it on GitHub.
>
how about isotrack? since you removed it from below
Does this test work for you? It fails here.
Ah, good idea! Will change it.
This code doesn't conform to the coding stds @ https://github.com/nvmecompliance/tnvme/wiki/Coding-Standards
yes for Promise actor
> The user must choose when to apply this Filter (in it's global).

So if a user has some actions that need CSRF protection, and some that don't, they need to put a big list of paths in Global, and if they create a new path that needs the protection, but forget to add it to that list of paths, or they make a typo, nothing will fail, except they will have a security vulnerability.  And what if they decide to have REST API that is also a website (as some websites do), and so the same path can accept a form or JSON?  I don't buy that.  In a CSRF attack, the browser will **always** submit a content type, and it always will be one off multipart/form-data, application/x-www-form-urlencoded or text/plain.  If there's no content type, or it's not one of these types, then there is no need for us to check it, because the attacker cannot coax the victims browser to do anything else.  This will save our users the hassle of having to manually define the paths that protection should be applied on and the danger of misconfiguration.

> "I would suggest checking for the token in the query string," 
> That's the default behaviour.

    def POST_LOOKUP: Boolean = c.getBoolean("csrf.tokenInBody").getOrElse(true)

No it's not, looking at the body is the default behaviour.
Is field injection the only way to get this to work? I'm guessing so. Shame
Any ideas on how to do go about doing this?
Yes, you can use a [loop](https://github.com/sorin-ionescu/prezto/blob/060d9064f8be6f420837d9846a785cd8cb58b032/modules/z/init.zsh#L8-24).
Should we remove it from the list or adding a warning?
you should mention that the validator should throw an exception to reject the value
This should probably go in the NEWS file, in case people subclassed PasswordsController and are confused when their app starts breaking when they upgrade.
The DB value should be the correct value.
If we're going to run rspec tests, might as well add `guard-rspec`
add metadata requires = ['parallelization']
Почему это? Достаточно выставить какое-нибудь значение у checkstate-роли. В
самом списке же тоже никаких чекбоксов нету.
Я здесь не про auto, а про const auto&. До питона плюсам все равно далеко —
типы все так же проверяются на этапе компиляции, и неявная херня все так же
может случиться, спасибо операторам приведения, implicit-конструкторам и
всякому такому.
Да я только за. Ща проверю - будет ли работать при закрытом табе
i.e. el <p>
Should be `date` or `authenticationDate`
Can't we just cooerce the pattern to be numeric always to cut down the duplication here?
Can we restore the previous formatting for the construction of gson, as it helps to see what has changed and avoids merge conflicts.
Why are you deleting the slovak strings and replace them by english strings ?
Can I get my car detailed too while it's detailing the database :)
same here for the if
Hmmmm, we don't normally use '_' in class names. Not sure it helps with camel autocompletion either. What about Parser51?
Stylistically this should be a ValueError instance. i.e. ```ValueError()```.
Use of backslash to continue a line is discouraged, as it is not PEP8 compliant. Could you use parentheses to continue the line, or a temporary variable to make the line shorter?
I've tried it several times this way, but no solution.
If a solution for is_alert_present() isn't found i think it's better if we "loose" this test.
I feel this should remain `displayed` to wait for the transition between the contact app sections.
@arnodeclercq Can't we just do

```javascript
var themes =  $.extend(sakai.config.skinStore, {}, true);
```

That way, you'll also don't have to do `{for i in themes.themes}` in trimpath
Is there another place we can modify this - namely the place that is causing the problem - instead of adding `!important` here? We might someday want a `ol li` that has a different list style.
As far as I can see, this method searches the tree for a TParameter instance with the given name. Why do you need it?
oh! I just proved that this code was taken from somewhere else
Oh, right. It needs a max-height then. I'll add one.
Pseudo's like before _should_ have 2 colons. I'm being persnickety because the epubcss relies on them having 2 colons. This probably occurs all over the place; maybe a subsequent pull request that just addresses formatting?
Are you sure ``'You must specify a tabl...ructor, or via options'`` has the correct type as ``string`` is not a sub-type of ``string``?
- Are you sure ``$this->returnCallback(function () use($i) {
    return (bool) preg_match('/\\.php/', ((string) $i->current()));
})`` has the correct type as "object<PHPUnit_Framework_MockObject_Stub_ReturnCallback>" is not a sub-type of "object<PHPUnit_Framework_MockObject_Stub>"?
- Are you sure ``'accept'`` has the correct type as "string" is not a sub-type of "object<PHPUnit_Framework_Constraint>|string"?
- Are you sure ``$this->any()`` has the correct type as "object<PHPUnit_Framework_MockObject_Matcher_AnyInvokedCount>" is not a sub-type of "object<PHPUnit_Framework_MockObject_Matcher_Invocation>"?
Are you sure you want to override the parameter ``$routes``? This often makes code less readable.
I have discussed this issue with David L. Actually there is a bug I have created - https://jira.appcelerator.org/browse/TIMOB-10255
So I just added comment before this checks //TODO remove this check when Jira bug TIMOB-10255 will be fixed. 
In order now app not to crash, and in the future when bugs will be fixed this checks should be removed.
Yeah ... I went back and forth. Without refactoring downstream it would just end up being used in the builder itself, which just seemed overkill.  The builder itself will take care of any malformed URLs that don't match, and I didn't want to refactor the whole Builder class just to use the URL class instead.
Please give the entire <algorithm>...</algorithm> block here with the new trialVectorCreationStrategy.
I believe this triggers a checkstyle line length `warning`..
This should be an InvalidArgumentException

    throw new InvalidArgumentException('Width or height cannot be zero with this scale method.');

Also adjust the DocBlock.  Thanks.
Porquê esta alteração?
not to be picky, but you're not doing anything if viewcount == 100
We were just talking about this today!  My vote is that the line number should not be included.  I see the clobbering of findings as an edge case.  Maybe when generating the annotations file, we can detect if results are being clobbered.  (Will add a note to the appropriate line)

_soapbox_
Copying/pasting code is the 8th deadly sin.  The extended version of Se7en included scenes of a coder, but I won't spoil that surprise.  

_off soapbox_
I too sin in this fashion.
I'd move these to the top of the file (the two enums)
`from piplmesh.account import models as account_models`
Don't use dict for only one value.
`future` template library is not used.
`keyup`? Not `change`? What if I paste something in? Doe sit still work?
Hm. In fact Facebook has 28x28 in chat. And the one in header menu is 23x23. I do not know where I found 20x20. But they have only 50x50 resized. The rest they resize with CSS. So what should we have?
Why is not good this? 
You think that if horoscope doesnt in DB then you get error? I think that if doesnt exits in DB you get fetch data from sites..
So

    :param dict layout: mapping of count of displayed columns(string) to PanelState() objects for that count

?
Then move the whole this `js` block to `home.html` template.
@ttilley Thank you very much for this one. I read the manual but did'nt found this possibility. Will update that tomorrow.
This is not needed. It was part of the other fork's implementation. I got rid of it.
What is the relationship of Axcess to Nochex? Is this just a copy/paste error?
`GetAppHarborAuthorizationUrl`
It would be simpler to just return the dictionary here without assigning it to context first.
Why adding the ``xmns`` attribute ?
good point, i just thought it would belong with the others (especially when I played with the "join", and using "join(timeout=5)", and raising this same exception if the join timeouted.

It's not used (yet?) elsewhere, so I can put it back where it was, if you prefer
Is there any advantage in doing:

    var template = [];
    if (foo)
      template.extend(bar);
    else
      template.extend(baz);

over this:

    var template;
    if (foo)
      template = bar;
    else
      template = baz;
M_PI is a define under MSVC. You can't overload. However, we would add "M_PIf", but this would require an additional header to include.
My bad, I did not realize that you were in the "small sample" case. So the implementation is fine to me.
(note that the "large sample" version, with data splitting, is what makes the *Fast* in the algorithm name. I guess we should therefore not expect the algorithm to be really faster than it is actually.)
I still do not understand why a larger `n_keep` would yield better results when going from stage 1 to stage 2... seems strange.

Anyway, I will think about it tomorrow, time to sleep now (good luck with kids ;)
not sure about this change. The doc was written by a native English speaker.
we should probably put, uh, this in a helper? It's tough since it's a relative path from @ dir, so it can't be a static class method tho
Don't refactor for now. But it does sound like there might be another bug there. The tests pass as-is?
No, this is wrong. This is something very Django-specific (not Python) and is used in Django model definitions to mark models as abstract (so that database table is not created for those models). Mixin just means that you create a class which by its own does not do anything useful and has to be used as a parent of some other class.

For example, in your case, you could do:

```
class CaseInsensitveUsernameMixin(object):
    ...
```

So a simple Python class without any inheritance. And then you can create case-insensitive form like:

```
class CaseInsensitveRegForm(CaseInsensitveUsernameMixin, auth_forms.UserCreationForm):
    pass
```

Python supports multiple inheritance and we are using this here (this is what means mixin, a parent in multiple inheritance, which just adds or overrides some functionality).
`_pd`
just pushed a very minor edit to capitalize `poisson` here to match earlier usage
like the new name
why is this file identical to the the previous file? I'd guess one is not used or not necessary, or one is copied from the other.
Like above, CoffeeScript tries to be *readable* where possible.

>  I'd rather have my operators not look like variables (or function names)

We've had people say this before. A text editor with simple support for syntax highlighting will pretty much defeat that argument. I'd say embrace the word-operators like you've done elsewhere with `and`, `or`, and `not`.
This is the USA!
How is AgentsHealthServiceService possible here? It's not imported.
this code seem rather complex and is wrong.

for instance you are doing

```python
if exclude is None:
    exclude = []
```

Then later you are testing if exclude is None, which never happens 

you can simplify it like this maybe:

```python
def get_services(names=None, exclude=None):   

    def _keep(service):
        if excluded is not None and service in exclude:
            # excluded !
            return False

       # in white list or no white list provided
       return names is None or service in names

    return [service for service in SERVICES if _keep(service)]
```
"Then much later there came another challenge required" --> "Then, much later, we introduced another challenge requiring"
Okay, changed the code to reflect that.
Sorry, I misread the diff, I though this code were in the 'call' function.
That said... we don't need to do that in this project, and I'd be ok with following the current PR as designed.
Can we get some comments at the top of the function explaining what this does?
[JSDoc](http://en.wikipedia.org/wiki/JSDoc#JSDoc_tags) comments would be awesome.
Why not use version_compare with PHP_VERSION? It's not like the code is performance critical, and I think it's just more readable since more common. Same below in the tests.
Seems like this path should be set in a specific instance of flockdb and not here?
This was me thinking of this lookup as a query, but using path elements rather than params. On reflection, we are identifying a resource, so path params are correct, so we should use 404.
Für die Zukunft: Bitte deaktiviere beim ReSharper die automatische Einrückung. Das verwirrt nur... für so etwas gibt den Zeilenumbruch von VisualStudio. Ich lass das noch gelten, aber bitte nimm das Feature raus, ok? Danke!
У ShardingProxyFactory указано, какие исключения ожидают при каких ситуациях.
Закрывать System.in нельзя
True, but one problem; to write a class extending Spell, you need to have void cast(Player), and for which you need to add the bukkit API as a library...
removed the string assert 
added is visible <code>section.notification-box.full > div.success </code> assert
That's some interesting indentation. Pro tip: Python's PEP8 says that it's acceptable to stick the arguments of a function/method call on the next lines:

    self.selenium.find_element(
        self._star_rating_locator[0],
        '%s[data-stars="%s"]' %
            (self._star_rating_locator[1], rating)).click()

Most editors will preserve your current indentation, so doing this means that you won't need to worry about how you indent your next line. Super useful if you've got lots of long statements. :)
agreed. we should use something more generic.
dependency injection ?
Technically,
Now ``scikit-image`` everywhere; sorry for the nuisance.
Are the Python wrappers used anywhere? Do we need them?
can you add vertical lines at maxima to say what to look at?
`n_samples, n_components = eigen_vec.shape`
The contents of `correlation_models` and `regression_models` are:

    In [1]: from sklearn.gaussian_process.correlation_models import 
    absolute_exponential     cubic                    generalized_exponential  linear                   np                  
    pure_nugget              squared_exponential      
    
    In [1]: from sklearn.gaussian_process.regression_models import 
    constant   linear     np         quadratic  

The nesting keeps their name short, otherwise we would need to do:

    from regression_models import linear as linear_regression_model

etc. to avoid overlap.
maybe add a note "(visible on web site)"
typo: "Constructs", no "e"
great. thats excatly what I meant!
Лишним не будет, добавил метод, описал в ридми
String hideAbstract = Boolean.valueOf(request.getParameter("hideAbstract")).toString();  // Handles all possibilities, including null
I didn't meant that. For example for Android it says: "On Android, use the font file name, minus the `.otf` or `.ttf` extension.
      For example, if you are using the Chantelli Antiqua font and the file is
      named `Chantelli_Antiqua.ttf`, specify `fontFamily: 'Chantelli_Antiqua'` 
      on Android."
Cannot find appropriate documentation for BB.
File was not passed through formatter
Since you're the first to update yml files, also update the docgent.py to contain the DEFAULT_BLACKBERRY_SINCE = "2.1" and add blackberry to the DEFAULT_PLATFORMS.

You'll also need to make use of DEFAULT_BLACKBERRY_SINCE in a similar fashion to DEFAULT_MOBILEWEB_SINCE
though operator '<' has higher precedence than &&, please enclose "++i < args.Length()" expression in brackets to make it more readable
Aren't there any pointers that need to be clean as part of the dtor?
Really this comment belongs somewhere else, more general, it's not specific to removeSuperFile..
Any failure during commit, that alters the store, e.g. cAddSubFileAction will not rollback, if subsequent failure..