labofsahil/github-event-dataset-2012 huggingface dataset:
No, but there's a bit of confusion here, there's two type of crc'ing, file crc's and block crc's (used by compressor)
I'm going to introduce a separate flag for the latter. 

Even if compressed you _might_ want crc of data calculated/checked, but Thor will not pass the flag to createRowWriter/createRowStream* for compressed files.

Wherever there's a createComrpessFileWriter used, block crc's was set to true, so I am going to default it to that here also.
But nothing afaict, checks them, so needs revisiting, to a) optionally check on read and b) optionally generate them
This message looks wrong (in both old and new code). Too much cut/paste perhaps?
The dlls tend to get copied around to multiple machines, while other associated files stay where they are generated (I am speculating)
Not actually sure they can clash..
I think it was mainly there to a) avoid thread unsafe calls to methods in directory and b) avoid high number of delete threads..

but may be wrong, maybe there is other contention.. either way, unless the remove always happens within CDistributedFileDirectory::renamePhysical (i.e. not in transaction), then the mutex won't be effective.
Is this else needed?
Yeah, I was thinking that but didn't want to change the way you had wrote it in case that was preferred style or something...
you should clean this list. ArrayInput is probably unused now as you don't call the InstallComment anymore
This list of XIncludes seems out of date?
I made issue #3 to bring the SQL and Mongo models to the same point. Might wanna change this to reflect that.
The apache docs suggest[1] leaving at 1024 bits because of backwards compatibility with older versions of Internet Explorer.  This fall (2012) Microsoft announced that 1024 bits was the minimum.  Some of the commercial Certificate Authorities[2] are moving to 2048 citing a NIST publication as the motivation[3], although the FIPS 186-3 specification (p.22)[4] suggests that 1024 is actually one of the accepted key lengths.The nice thing is that we can change this easily later and it only really matters if we're seeking to meet FIPS.
1. http://httpd.apache.org/docs/2.2/ssl/ssl_faq.html#keysize
2. http://www.entrust.net/knowledge-base/technote.cfm?tn=7710
3. http://csrc.nist.gov/publications/nistpubs/800-57/sp800-57-Part1-revised2_Mar08-2007.pdf
4. https://csrc.nist.gov/publications/fips/fips186-3/fips_186-3.pdf
merge 103 and 109. the nav to method should get to itself.
Whoops, was just testing recompiles.  I'll fix that.
Is there any reason to store the driver on the Point object? Out of scope, but it looks extraneous on the Metric object as well.
I think in this case it can be done a little easier:

<pre>
if (res and res.code !=200)
</pre>
`width` and `height` are switched here, right?
Test for dtypes with np.issubdtype
I think the scikits-image convention is to write `(N, 2)` instead of `Nx2`. (I'm not sure how consistent we are, though.) If you make this change, note that it would need to be changed in multiple places in this PR.
We have four quotes `"` here and four below, leading to a syntax error on travis ci. :)
Ok, but this is really a horrible thing to do.

It would be better to create some FacesMessages here, store them in the CDI request scope, and then enqueue them once JSF is available. It might be even better to just grap the input stream at this point, and stick it in the request scope. You could then parse it inside the JSF action method.
Updated to extend content provider from AdapterFactoryContentProvider
Just a comment (I'll fix while merging), dots don't have to be escaped in character classes, and hyphens either - as long as they're the last or first char of the char class.
I agree with @shunter, I'll remove the other =undefined that you mentioned.
FYI, I'm fine with removing all Object.freeze usage for the time being if we want (this should be done in a separate pull).  It's easy to find them again later if we need to and re-add it.
These are OK for this pull request, but we probably don't want them in master.  Perhaps some buttons to change to a cool view would be OK.
That's good point we have equivalent to `WebRoleExists` and `WorkerRoleExists` so 'll fix that
Capital A (As the test format...)
Mobile Web supports it too...technically (unfortunately there is currently only one browser that supports it: Mobile Safari 5). We don't currently expose the hascompass property/method, but it would be trivial to add one of them, whichever is preferred.
mmm not sure to understand what this is ... marginalia ?
On 06/28/2012 08:18 PM, David Strauss wrote:
>> +    // Allocate sufficient iovector space for the arguments.
>> +    iov = malloc(argc * sizeof(struct iovec));
>> +    if (!iov) {
>> +        ret = PyErr_NoMemory();
>> +        goto out;
>> +    }
>> +
>> +    // Iterate through the Python arguments and fill the iovector.
>> +    for (i = 0; i < argc; ++i) {
>> +        PyObject *item = PyTuple_GetItem(args, i);
>> +        char *stritem;
>> +        Py_ssize_t length;
>> +#if PY_MAJOR_VERSION < 3
>> +        if (PyString_AsStringAndSize(item, &stritem, &length)) {
>> +            // PyString_AsS&S has already raised TypeError at this
>> +            // point. We can just free iov and return NULL.
> 
> Shouldn't we bail at this point?
Right. Fixed (with a rewritten commit).

I also changed the behaviour of CODE_FUNC, CODE_LINE, CODE_FILE: if the
caller specifies at least one value, only the values given  by the
caller are used. Otherwise, this information is extracted from the
parent frame. I think that this is more sensible.

I think it would be nice to have extra TB_LEVEL=<n> parameter,
defaulting to 1, which would be used to extract the right frame. Then,
if somebody is writing a wrapper around journald.send(), they can
specify TB_LEVEL=2, to get the caller information from _their_ parent,
without reimplementing the tb logic.

Zbyszek
This seems more like a warning.
we need to open(make visible) first the dev comments and then get the text. because now we get a empty string
I think the example is what documentation states.
Yet, the actual test code is even more restricted. 
I'll make a pull to get this in line.
I'm considering weakening the constraints here: as long as the code is memory-safe, there should be no guarantee that calling front() on an empty container throws an exception. So we could replace a lot of enforce()s with assert()s and count on the fact that null pointer segfaults will take care of memory safety.
`isIntegral!T` is true for build-in types only (or it is implemented incorrectly) so this change just messes things. Shouldn't be merged.
aclHelper adapts the query here on the nodetranslation entity, but permissions are on node. Can you make the aclHelper to use the joined "node" table?
Cool - that sounds alot cleaner!

Here's a test I did for bulk docs:

 //$ curl -d '{"docs":[{"key":"baz","name":"bazzel"},{"key":"bar","name":"
barry"}]}' -X POST $DB/_bulk_docs

        Map<String,Object> bulk_doc1 = new HashMap<String,Object>();

        bulk_doc1.put("_id", "bulk_message1");

        bulk_doc1.put("baz", "hello");

        Map<String,Object> bulk_doc2 = new HashMap<String,Object>();

        bulk_doc2.put("_id", "bulk_message2");

        bulk_doc2.put("baz", "hi");

        List<Map<String,Object>> list = new ArrayList<Map<String,Object>>();

        list.add(bulk_doc1);

        list.add(bulk_doc2);

        Map<String,Object> bodyObj = new HashMap<String,Object>();

        bodyObj.put("docs", list);

        //String json = "{\"docs\":[{\"key\":\"baz\",\"name\":\"bazzel
\"},{\"key\":\"bar\",\"name\":\"barry\"}]}";

        Log.v(TAG, "About to do _bulk_docs");

        //Map<String,Object> bulk_result =

        List<Map<String,Object>> bulk_result  =
(ArrayList<Map<String,Object>>)sendBody(server,
"POST", "/db/_bulk_docs", bodyObj, TDStatus.CREATED, null);

        //revID = (String)bulk_result.get("rev");

        Log.v(TAG, String.format("POST returned %s", bulk_result));

Cheers -

Chris

On Mon, Mar 12, 2012 at 10:59 PM, Marty Schoch <
reply@reply.github.com
> wrote:

> > @@ -925,8 +1018,44 @@ public TDStatus do_GET_Document(TDDatabase _db,
> String docID, String _attachment
> >      }
> >
> >      public TDStatus do_GET_Attachment(TDDatabase _db, String docID,
> String _attachmentName) {
> > -        //FIXME implement
> > -        throw new UnsupportedOperationException();
> > +     // http://wiki.apache.org/couchdb/HTTP_Document_API#GET
> > +     //OPT: This gets the JSON body too, which is a waste. Could add a
> kNoBody option?
> > +     EnumSet<TDContentOptions> options = getContentOptions();
> > +     String revID = getQuery("rev");  // often null
> > +     Long sequence = null;
> > +        if(options.contains(TDContentOptions.TDNoBody)) {
> > +             sequence = db.getDocumentSequenceWithIDAndRev(docID,
> revID, options);
> > +        } else {
> > +             Log.d(TAG, "getDocumentWithIDAndRev start _attachmentName:
> " + _attachmentName);
> > +             TDRevision rev = db.getDocumentWithIDAndRev(docID, revID,
> options);
> > +             Log.d(TAG, "getDocumentWithIDAndRev stop _attachmentName:
> " + _attachmentName);
> > +             if(rev == null) {
>
> I see now, so I think we should be calling the other update() method (the
> one with 6 arguments not 4).  In this version we can get the TDRevision
> back directly, and not have to pass it through the doc object.  This will
> work more like the iOS version.  Also the update method you were calling is
> setting headers and response bodies that are not correct for the bulk
> request.  It may work because they ultimately get overwritten, but its
> clearly not the right way to go.  There are no good unit tests for
> bulk_docs so I'll let you know when I have something to test.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/couchbaselabs/TouchDB-Android/pull/4/files#r548377
>
It depends if the bean has been created by you or not:

- when a bean instance is passed to the programmatic configuration API, then the provider is not responsible
- when the bean class is provided (say via the XML file), then yes.

The rule of thumb is that what you create, you release. What you receive you leave alone.

Can you open a BVAL issue and assign it to the next version. We probably need to clarify that if that's undefined.
e.g., !
Replaced with thincloud-test.
why not making this method part of ModelDescription?
Use DelegationClassLoader of the labs project instead und set this.getClassLoader as parent class loader
We don't need this code in here anymore right?
please wrap the lines after the first word crossing 72 chars
Law of Demeter, mang
Fixed: https://github.com/imagin/FOSRestBundle/commit/13fb4392b19f928d21bb741448dd5fde2a6f9f43
you should remove the ``else``. It is not needed as the ``if`` returns
Can you change this to a local video? We can use the Popcorn.js test videos
I see, I misunderstood your point above.

A NullPointerError *IS* a SignalError (that will be renamed into InvalidPointerError as you suggested).

Your example above is, to me, suitable for a NullPointerError, because func did returned null and you dereference based on that. See the code as :
ubyte* ptr = func(); // returns null
ubyte val = ptr[0x10];

This type of stuff will generate a NullPointerSomething in almost every language, even if the address accessed isn't specifically null. This is why /proc/sys/vm/mmap_min_addr is often 64k instead of 4k.

Accessing this memory can only be done by forging a pointer manually or basing a dereference on null (as you did in the example above).
These last 2 getters, and their associated fields, don't belong in this class - they were in the Dummy (test) txManager solely to verify the commit/rollback were called appropriately during unit test execution.
See Mark's point #3 - we should only set it IF it's not already present; unless explicitly set.
lol sorry

On Fri, Nov 2, 2012 at 3:51 PM, Liz Fong-Jones <notifications@github.com>wrote:

> In js/main.js:
>
> > +  var zoom = 0;
> > +  for(var i = 0; i < prevZoom.length; i++) {
> > +    zoom += prevZoom[i];
> > +  }
> > +  zoom /= prevZoom.length;
> > +  if(prevZoom.length >= ZOOM_AVERAGE) {
> > +    prevZoom.shift();
> > +  }
> > +
> > +
> > +  curX += (PLAYGROUND_WIDTH/(zoom*0.78))/2;
> > +  curY += (PLAYGROUND_HEIGHT/(zoom*0.78))/2;
> > +
> > +  if(curX > 0)
> > +      curX = 0;
> > +  if(curX < DISPLAY_WIDTH*(1-zoom) )
>
> Damnit, let's not do the one line if statements. they're really hard to
> read.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/lizthegrey/spelunker-deathmatch/pull/100/files#r2020502>.
>
>
I would prefer if you do not commit this change. I will look into how other programs handle these configuration files. Maybe I need to make two config files, one with default settings and another the user modifies.
Sure. I just found it in the old code and put it back. :)
Use class-based views.
согласен, исправлено
This is true, I don't know why I didn't use the filter method, thanks!
Same as above. All dedent markers must have matching indents.
This might lead to an error if no providers are set
Walt, Jim,

You should pass the database that came from the _handle function to rd.save function to avoid cross threading issue.  Call rd.save without a database parameter uses the database that was create from the main pylons application thread instead of the one created on monitoring thread.

This can be use of weird conflict and hangup when using the same database from two different thread.
Object#is_a? does a little bit more than class equality check, e.g. an instance of ActiveRecord::Relation subclass is also kind_of? ActiveRecord::Relation. Of course, if we had a long list of classes we could DRY this up, but in such simple case I would leave everything as is.
I dont like `__toString` method because there are some magic behaind it (I am taling about those who read the code).
The `getErrorsAsString` shows exactly what we want to do:

```php
<?php

if (false === $response->isSuccess()) {
    echo $response->getErrorsAsString();
}

```
just remove the brackets when no args
to be correct from a semantic and accessibility pov we need to have the following markup

<menu aria-labelledby="tmenu">
   <h3 id="tmenu">Title</h3>
</menu>
Don't like this so I'm leaving this line out of the merge.
What's the "full initialization" in this case?
How should we look up the header to delete (this deletion happened elsewhere and we're just syncing with it)? All we get is a GUID, and the deleted message could be at any time. I'm guessing we'll need a FolderStorage method to handle this, but I don't know how we should do it in a performant way. (The same thing applies to changed messages.)

Maybe we need a table mapping guids to blocks?
Curious if you really need all these excludes?
Style nitpicking here. You comment should continue under the """. You should also leave a space before the python shell example. It might also be useful to make this a doctest.
Actually, I just look at the [built docs] (http://ci0000001875214:9080/hudson/view/WebWorks-API-Docs/job/WebWorks-API-Docs-next-BB10-pim-contacts-constructor/ws/WebWorks-API-Docs-next-BB10-pim-contacts-constructor/view/blackberry.pim.contacts.html#.find) and I find that I DID actually include sample code for leaving out filter (that's `listAllContacts()` in the sample code), so please remove `findContactWithoughtFilter()`.

Also, can you please move `findContactEmptyfindOptions()` to directly below `listAllContacts()`? (And change the name to `listAllContactsWithEmptyFindOptions()`)  I don't want it to be listed after the error case. Also, in the `var findOptions = {}` line you need a semi-colon. Please proofread all docs once again to make sure there is no typos or other errors.
here and below: {x,y} are in window's coordinate system on iOS.
Android does not have this event.
The first 'you' seems too much.
OK, I will figure after you control the code
This should be an hpp extension
This is a different check (just truthyness vs undefined) when compared to other js files
It's going to be tricky. This method is transactional and if you lock a dictionary here it won't be visible in other transactions. So you would have to lock the dictionary outside of this transaction, then do the export and unlock.