labofsahil/github-event-dataset-2012 huggingface dataset:
Yeah, <code>jobID, result = updatedJob</code> will break if you pass back a triple in <code>updatedJob</code> and then try to assign only two variables to it. Maybe standardize the return on such a method, or have a call to <code>len</code>, but checking the length seems like a messy solution.

d

On 7 Mar, 2012, at 2:35 PM, Daniel Zerbino wrote:

> Reviewing the code, I'm taking that back: in src/master:
> 
> updatedJob = batchSystem.getUpdatedJob(10) 
> #pauseForUpdatedJob(batchSystem.getUpdatedJob) #Asks the batch system 
> what jobs have been completed.
> if updatedJob != None: #Runs through a map of updated jobs and there 
> status,
>     jobID, result = updatedJob
> 
> So it should return either None, or a valid tuple. Unless I'm missing 
> another piece of code...?
> 
> On 07/03/2012 14:20, Dent Earl wrote:
>> Shouldn't this initialization be
>> <code>i = (None, None, None)</code>
>> Since you're now expecting this function to return a triple? See the call made by<code>getUpdatedJobs()</code>.
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/benedictpaten/jobTree/commit/0580ca24d6c8915964edf711f60729f10dacfb9a#commitcomment-1055948
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/benedictpaten/jobTree/commit/0580ca24d6c8915964edf711f60729f10dacfb9a#commitcomment-1056007
No, thank you for notifying. But then it's not imported and it's till causing error.
Ah, so that's what was going on, I probably have a to-do item for this bug somewhere on Trello...
Yep, I agree.

The refactoring is far from complete though & definitely not ready to be
used yet :)


On Sat, Feb 4, 2012 at 9:25 AM, Patrick Atoon <
reply@reply.github.com
> wrote:

> Interesting refactoring.
>
> When moving the messages, wouldn't it be more Maven-like to move all
> message properties files to somewhere inside the resources directory (like,
> say, "src/main/resources/i8n/")?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Beezer/ps3mediaserver/commit/2d1466156fb89c819bb4ed735859796eea27f59d#commitcomment-932809
>
These should be in a constant somewhere.
I am not sure I am following this correctly, The whole problem with Brightcove returning errors was because we were setting something as null when there were restrictions/validations on their end that prevented us from doing so.

Going by that behavior, I thought the solution was to prevent the attribute from being set as null if it didn't exist. This could be as easy as:

    if data.get('remoteUrl'):
        self.remote_url = data['remoteUrl']

Did you tried that and maybe that didn't work? What was the reasoning behind assigning `url` to `remote_url` ?
@tim-evans: I can't go into specifics about this, but it was a temporary fix that was done by someone else that was needed for a project in order to ship. This was not meant to get out but it unfortunately did. In any case I've done away with this code and put in a proper solution that's also part of public merge branch Juan pushed out.
<img src="http://picquick.ru/uploads/21022012/4380e03873669112e9562360e97f6d35.png" />
Yeah I think you were right here Mathias. 
This goes back to what we uncovered over here

https://github.com/paulirish/lazyweb-requests/issues/42#issuecomment-1901803
Most of these themes used to work without using rvm (or rbenv or the rbenv plugin) at all, because the ruby path string was just an empty string. 
Now they fail with #878:

    command not found: rbenv_prompt_info

Perhaps provide an empty `rbenv_prompt_info` using something like this?

    functions rbenv_prompt_info >& /dev/null && rbenv_prompt_info() {}
Small nit, please use double quotes when you can
made sense to me to call it GetCreatureTemplate.

CreatureTemplate const* xxx = me->GetCreatureTemplate() makes more sense than
CreatureTemplate const* xxx = me->GetCreatureInfo()

But it can be reverted if other devs think it does not make sense
Yes that's correct sorry. I changed it last minute as force_default wasn't descriptive enough.
Put a description here to explain what this is or link to the sample description on the website
this should be vary-meta, to prevent clobbering of any metadata explicitly set on the symbol
doesn't next already have a tag in it, that should either be left in place or removed before or-ing in the tag from old_blocks ?
Not all the information from the readme is on the wiki.
remove 'get' word from method name.
https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-BCIGIJJF
params == null is redundant as instanceof works on null.
The default is to use the concatenation of group id and artifact id, with duplicate elements removed. Thus you can and should leave this as the default. This will produce the symbolic name org.opennaas.extension.router.capability.ospf. This happens to follow the official recommendation for naming OSGi bundles.
And it seems to be a design error to let other components access these information, or isn't it? Why exactly do you need it?
Nice :). When we have a name for the product, I'll change the project name.
should "SON.stringify(event)" not be "JSON.stringify(event)" ?
Statyczne mają być tylko niektóre funkcje i żeby ich było jak najmniej...
Oui c'est vrai que tout compte fait ...
du coup j'aurai juste à masquer fileInDir( boost... ) pour le binding python
Does this need to remain? Never seen a .idea/ folder before.
Submitted a fix in 75dcd50d88388f77e7d99b3823db6cfa61a36084 (pull request #429)
But wait - don't we have the BCM4319? 

Will do ASAP.
It does, but not the info field of the service (:info doesnt get propogated to service.info). You can still report both though (service then web site)
reset-color-configuration and configure-background-colors do very similar operations but their names are not at all similar. making their names different in proportion to their different functionality would be an improvement. (also, as written these modify state and should probably have ! in their names)
Do you need access to the io_service inside of on_tls_init? If no, then every connection has a reference to the io_service, for instance,
<pre><code>void CTestHandler::on_open(connection_ptr connection) {
	if (connection != nullptr) {
		boost::asio::io_service &service = connection->get_io_service();
	}
}</code></pre>
xD
El Oh EL
now for the comeback kid to make paybacks....audience is waiting...
No ... it's still not working.

I can't ping with commit f9614a157d23ed5d10e5b148e723c70ba611a84d.
But ping works with commit 10ef7e71118146fd91cbb5fa01f6a3b704b75897
use value directly, instead of it's number, so if that number change, code won't broke. (value change in gtk3)
You can use `sort` predicate, out of the box in GNU Prolog http://www.gprolog.org/manual/gprolog.html#htoc219
I recompiled the same revision and it's working fine now. This has happened before too; something goes wrong with the compilation but it doesn't abort. It never happened for me before using Maven, maybe it's unstable? Maybe the external downloading doesn't properly verify the files?
Can't find any CVE or OSVDB references for this particular exploit.  I'll fix the author info.  How should I modify and submit the updates?
maybe [jaswope](https://github.com/jaswope) is right about this…
Tout est déjà dans web/bootstrap...
Actually `ValidateGroups` might be that vehicule. We could even change `validationMode` to accept an array and add `EXCLUDE_GETTERS` to `ValidationMode`
pas besoin de "!important", de toute manière, ce sont des styles inline qui prennent le pas sur tous ceux que tu as en CSS.
PermissionDeniedException?!
Pelo q eu me lembro quando vc coloca /periodo_letivos/1/disciplinas na url, era pra mostrar somente as disciplinas relacionadas ao periodo letivo de id = 1.... Mas no projeto não ta rolando isso, ta aparecendo todas independente da relação... Alguem aí manja de rotas pra me falar se eu q estou errado ou tem q configurar algo amais pra funcionar do jeito q falei?
А еще на github можно писать так: @vladislavbyk :)
yea xD
This is a too simplistic approach (eg. you're missing the port if the wiki runs on a non-standard port), the better way is to let DokuWiki generate the correct URL to the page with ``wl($ID,'','&',true)``
Once again thank you so much for you instant response and honest solution*
目前Build log: https://gist.github.com/1907441
For a family’s address, there is only a County field (no Country). It’s not for mailing, but instead, for demographic use.
 
On each student, there is a Country of Birth  or “Birth Country” (United States, Canada, International). This is used for demographic purposes, as well.
I have been looking at this when I was making the hybrid code from plamoni. Thank you for the work. As always excellent
Máš to celé strašně divně odsazené. Zkontroluj si nastavení IDE, aby používalo tabulátory, kód oprav a force-pushni prosím.

```sh
$ git commit --amend #sloucit do predchoziho
```
This refers to two licenses but neither of these license is given anywhere. I guess this would need us to ship the full license text.

Also GPLv3 is incompatible to GPLv2 and thus can't be used with znc: http://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility
So that means znc has to use the LGPL v2.1 version
we can put some constrains and documentation:
lon >= -180.0 and lon <=180.0
lat >= -90.0 and lat <=90.0
vs30 > 0.0 - Average shear wave velocity for top 30 m. Units m/s.
vs30Type = 'measured' or 'inferred'. Identifies if vs30 value has been measured or inferred. 
z1pt0 > 0.0 - Depth to shear wave velocity of 1.0 km/s. Units m.
z2pt5 > 0.0 - Depth to shear wave velocity of 2.5 km/s. Units km.
Replace "autocomplete" with "AutoComplete" here.
This could simply be: `dt_detail.show()` without the conditional if you switch to using creating the `dt_detail` table with `visibile: false`.
After discuss we decide to use my solution, because some css files store in src/css, use src directory to store user editable files is reasonable.
Maybe you should remove these lines?
I tend to agree with you. In addition to fixing refs, I personally find that the usage of `final` prevents me from somewhat being lazy and that it forces me to create new variables, instead of just being lazy to use what's already passed. For example, I used to do this:

````
public String method(String key) {
    key = "someValue" + key;
    return key;
}
```
Any way, I think this is the last remaining issue. Everything else looks great from my POV.
Isn't it better to just omit unknown attributes rather than emit a value like "!name-unknown-..."? Especially in the XML output case, omitting an attribute shouldn't cause any problems. In the text output case, it might cause problems if the output is processed by a script like "awk { print $3 }". But in that case I would prefer a shorter string like "?".
Hope that's addressed now.
Aha,  I see.  This is fine then.
getEvent() isn't something I looked into when refactoring this. In the interested of time I just copied and pasted it from WMU.  I agree we need to get rid of it.
Not really, there are two calls to Memc down there, not only one:

```php
$app = F::app();
$app->wg->Memc->delete( self::getArticleCacheKey( $id ) );
$app->wg->Memc->delete( self::getDetailsCacheKey( $id ) );
```

I'll cache the memc ref:

```php
$memc = F::app()->wg->Memc;
$memc->delete( self::getArticleCacheKey( $id ) );
$memc->delete( self::getDetailsCacheKey( $id ) );
```
Ok, the tests are complete. They cover the full public API of ```ByteString```, ```ByteStringBuilder``` and ```ByteIterator``` now, except the parts that are just inherited (not overridden). Hope I didn't overlook anything.
`: Unit = {`
Good one, I'll guard for more than once and create a case class for holding the endpoint and processor
logging is a godd suggestion, thanks
Oh, sorry, mixed that up on the phone: I actually meant ActorSystem.findClassLoader, which uses `sun.reflect.Reflection.getCallerClass` if available. I did some profiling before resorting to that extreme measure: getting a stack trace takes 50µs while each `getCallerClass` takes 700ns (on some popular hardware) and you need only a handful working your way up the call chain.
Most probably yes. Will fix.
ah, then it's no fun, I'll stick with the boring `squaredIntervalSum`
I agree, I've added that commit.
This is one of the places where it recurses.  card.left being based on cardname.left get 'A+B' when renaming 'A+B+T' to 'A+B', so we get stuck on the one card as we recurse through this point.

I think this also sometime fetches a missing id on some of the remove tests.
I think since they're going to remain constant, it makes sense for them to be properties.  But either way, I don't think we need to provide both--just ``non_b0s`` should do.
picky should there be a comma `(hours, minutes, seconds)`
this should be translatable
Typos:
- may -> many
- consumer -> consumers
Sorry, ging om 
 public/css/font/geogrotesque-regular-webfont (1).eot 
 public/css/font/geogrotesque-regular-webfont (2).eot
I don't think we need it since `slug` supports any registered Python codec - this assert is here to just user any other codec other than default (`utf-8`). Otherwise we'll need to test all Python registered codecs to ensure every codec is supported - I don't think it's clever (we don't need to go too deep).
Call this `job_log_step_nums`?
These methods were initially written to transform the image data to log scale prior to display, but they are not used anywhere.
where is this used? needs better documentation
I don't like my name either but this cannot be currentRetries since this contains all outstanding processed records + optional retry object. I like your suggestion to refactor Retry into Attempt. This is much cleaner and currentAttempts would be a great name!
make it a partialfunction instead of function + match
Looks like a formatting error to me but in any case 'priority' is ignored in recent versions of Graphite when used in storage-schemas. It was removed a few versions ago (0.9.8 maybe?) but lingered on in the example config until recently.
……话说咱继续这么混合命名fcitx的命名就会变得和postgresql一样屎了……
@jwilling Alright, I think I'm unable to see that on github.com then. Weird...?
I'll add it though I'll make a slight tweak since for CentOS (and Ubuntu/Debian which has the same problem), `SCALA_LIBRARY_PATH` would be enough since #292 was merged.
Also, for example:

    try {
                <-- HERE
        if (blah) {
Done (I think)
This processing here is the source of issue [1892](http://projects.scipy.org/numpy/ticket/1892).  If the output is a long string, the length gets discarded.
Variables must only be declared at the beginning of blocks in the version of C Numpy supports.
And if you do that and are working in the test directory you can run those tests by doing

    charris@f16 [tests (pull-477)]$ python test_ufunc.py
I'd make this function return a `zend_bool`. Not that it matters much, but would make the semantics of the return value more clear.
Perhaps I don't understand the question. sprintf() gets used after emalloc
Nevím jestli by měli, ale zkoušel jsem a je to široký pěkně jako obsah stránky.
Сейчас в закомментированном не актуально, но return опасный - мб не инциализирована часть объекта (mGesturesWidget). А в деструкторе mGesturesWidget удаляется без проверок.
`ActiveSupport::Deprecation.instance` here rather than rely on the instance delegator
I don't think we should hardcode to nodejs since many are available. Wouldn't `out` be enough to tell us what happened? Also why is execjs/sprockets writing to stdout instead of stderr? :( Thanks for looking into this!
This `alias` contains 2 spaces, can you take the opportunity to fix it pls?
This code isn't present in Dalli cache store, I'm pretty sure isn't needed if we are using Dalli.

/cc @mperham
I'll ammend that.
Maybe call it `skip_assign`? Wdyt?
I would prefer to do it in a separate pull request, i think.
I don't know if we can ignore these payloads. cc @fxn
I think you didn't finish your sentence here.
Better yet (more efficient) and more resilient is

    case AnnotationInfo(TypeRef(_, _, arg :: _), _, _) => Some(arg.typeSymbol)
Because `getMethods` returns stuff like `toString` and `getHashCode`
uber-minor nitpick: can probably drop the `treeInfo.` qualifier
Should this chain into another Hashing instance?  I can see that being useful potentially.
of golden --> of the golden
Space after ','.
do you mean `n >= 1`? and the same for k?
You shouldn't need to enclose asserts in parentheses, which is what is done in all the SymPy tests I've looked at.
Is that possible or does it just return `None` in that case?
On Tue, Jun 12, 2012 at 2:15 PM, Stefan Krastanov
<reply@reply.github.com>
wrote:
>> @@ -308,26 +309,67 @@ def expand(the_args):
>>
>>      # args = (x**2, ) --> args = (x**2, (x,-10,10)) and others
>>      def add_variables_and_ranges(the_args):
>> -        default_range = Tuple(-10, 10)
>> +        """make sure all limits are in the form (symbol, a, b)"""
>> +
>> +        assert isinstance(the_args[0], Expr) and \
>> +        all(isinstance(t, Tuple) for t in the_args[2:])
>
> This assert statement is not a very strong check. There are many things that it may permit even though they would result in garbage output. Do we care about this?

I would say no. I thought about this, too. I'm guessing the error will
be raised in the plotter if there is a problem:

1) you might have too many limits (I'm guessing 3 should be the max
unless you also allow some sort of animation of additional dimensions,
or curve families)
2) the limits might not be numbers
3) they might be (hi, lo) instead of (lo, hi) but that might be good
because then you could reverse the axis
4) the Tuple might not have 1 symbol or 2 numbers

And perhaps instantiation of the limits already caught some errors? (I
didn't look.)

So I guess I'm letting the error pass hoping that the plotter will
complain. Where it doesn't, then perhaps we can tighten up the sanity
checks.

/c
Why not make this part of instantiation:


```
Partition(['a','b','c','d'], rgs=[1,0,0,0])
```

And would it be possible to just supply the partition element of range(len(max(rgs)+1)) by default? So `Partition(rgs=[1,0,0,0])` would give `Partition([[1, 2, 3], [0]])`?
On Mon, Jul 30, 2012 at 12:42 PM, Aaron Meurer <
reply@reply.github.com
> wrote:

> > @@ -65,6 +65,14 @@ def _print_Add(self, expr, order=None):
> >              sign = ""
> >          return sign + ' '.join(l)
> >
> > +    def _print_And(self, expr):
> > +        return '%s(%s)' % (expr.func, ', '.join(sorted(self._print(a)
> for a in
>
> Why do you call sorted twice?
>
>
that bugs me, too. The inner sort alone didn't work but it worked when I
put on the outer sort. I just pushed an update where only the outer sort is
used (which appears to pass). Is string sorting system-independent?
Well, it looks more logical to me to refresh if there's a primary key. Doing nothing if record is new doesn't look good.
same as above: there is no `$matches[1]` anymore.
I don't get this. Why do we want the second-to-last entry?
Ha, coninuous! Perhaps d_isLogTransformed would be better?
Hm can a person ever have multiple projects without having a default one?
That must've got dropped on the floor when I backed out the first
implementation.  I'll look into that again.

On 20/10/12 23:18, Ben Hood wrote:
>> +
>> +  def createMigration(config: Configuration) = {
>> +    val migration = new MigrationBuilder(config)
>> +
>> +    migration.createTable("endpoint_view_rolling_windows").
>> +      column("space", Types.BIGINT, false).
>> +      column("endpoint", Types.VARCHAR, 50, false).
>> +      column("view_name", Types.VARCHAR, 50, false).
>> +      column("name", Types.VARCHAR, 50, false).
>> +      column("period", Types.VARCHAR, 50, true).
>> +      column("offset", Types.VARCHAR, 50, true).
>> +      pk("space", "endpoint", "name")
>> +
>> +    // Beware of changing column order in referential constraint definitions.
>> +    // Column names here are ignored when the schema is built on Oracle.
>> +    migration.alterTable("endpoint_view_rolling_windows").
> 
> What came of the deliberation to tighten up the FK constraints between views and parent categories that is currently only enforced in the application?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/270/files#r1897927
>
Ugh, this is slow. I really wish we had static hashtables here. Not something you have to fix now.
it's explained on 109. Does it need a redundant comment?
If you want I'll do it the other way.
Assign the result of the `validate_data` call to a variable and pass that into `array_merge`? This makes this quite hard to read.
db and config should be taken out as they are unused.
Please add doc block here.
Use sql_query and a while loop below? There can be more than one row because you're not using a primary key for the query.
I believe I actually did forget to test this specific part :O...
And this would actually be a situation I have problems testing... It evolves subscriptions and I, unfortunately, forgot to test the subscriptions system.
We worked this out somewhere - I believe the old version was iso-8859-1 and the new version is utf-8, github decides to render the file in 8859-1 which produces this result.
works either way
Fixed in bf0b6b5
Pretty yes, as long as project requires X11 (OSX and Windows can have X11)

For the future development this block must be changed.
Will not improve. As all lights are being used via Light* pointers I need to call lightSource->getPosition() on them. I don't want co check their type and cast to Movable* or Rotatable*.
Наскоро се сблъсках с факта, че в последните версии на Rails подаването на формат като част от името на темплейта е deprecated. Трябва да се подава експлицитно като параметър `:format`. Поправи ме, ако греша...
Yes, we have different strategies depending on the asset-type. Everything that is partially loaded (video, audio) is stored in `AssetController.assets`, which makes it accessibly by the AssetController (that triggers loading) and the renderer (that triggers the playback for example). For other asset-types that are accessibly via the browser's cache (assuming the file is cached) we don't need a shared context (access to the original Dom-Element) and therefore don't store a reference in `AssetController.assets`.
Perhaps the culture should be specified in the `InlineData` so we can add in a couple of more test cases for different cultures
be consistent in naming: Bill or Billing?

If Bill: class should be called ```Bill``` (line 26)
If Billing:  integer id should be called ```billingId```
I've added the _pyke_rules file that was missing. I've run into an issue with the stock npz files due to problems with MANIFEST.in and symlinks (see #12), but all is well with the install, it only affects ```python setup.py sdist```. I believe everything else is covered.
I don't think. This is not an op, just to find if the compiler support openmp.
не, дяденька

этот код должен быть тупым как дрова

текущий вариант меня полностью устраивает.
At some point, I was thinking of naming this as a test like "canLeverageIndexedExpression" but I was unhappy with that because it doesn't capture the fact that there is extra detail returned in the positive case -- a list of parameters whose underlying constants have become non-negotiable for this plan. "Binding" seems like a good word for that because it has a history of meaning "the constant associated with a parameter" or "the process of associating a constant with a parameter" but also has overtones of "enforceable like a contract" which also applies. If there's a better name, I haven't a clue.
The else issue can be fixed by directly adding "else {}" to my macro. Still leaves semicolon, but I'd personally ignore that.
Reusing function argument names is an antipattern.
Let's use PEP code style here.
I thought this would be covered by the worked example lower down. However, more examples can't hurt, I suppose.
Added a "DEBUG:" prefix :)
I like this, nice job.
On 03/21/2012 12:48 PM, Lars Butler wrote:
>> +    def _do_parse(self):
>> +        """parser implementation"""
>> +        # The tags we expect to see:
>> +        # fragility model
>> +        fm_tag = '%sfragilityModel' % xml.NRML
>> +        # fragility function set
>> +        ffs_tag = '%sffs' % xml.NRML
>> +        # discrete fragility function
>> +        ffd_tag = '%sffd' % xml.NRML
>> +        # continuous fragility function
>> +        ffc_tag = '%sffc' % xml.NRML
>> +
>> +        # current fragility function set
>> +        mdl = None
>> +        nrml_schema = etree.XMLSchema(etree.parse(nrml_schema_file()))
>> +        parse_args = dict(source=self.file, events=("start", "end"),
> 
> It looks like this would require a bit of rework (from the look of
> things, you'd have to change the way you parse the frag. functions
> from the elements). Let me experiment with something and I will
> suggest an alternative approach.
Err .. why? What happened to the good old "LGTM"?
``` clojure
(clean-empty (into {} (for [[k v] m] [k (operation v vv)])))
```
You could use `llvm::raw_string_ostream` here instead of pulling in iostreams.
That shouldn't be necessary. I think gcc is trying to apply the C++11 const initialization promotion rules (even though it's not C++11), which don't apply to runtime expressions.
Why not `( structure[ dataType ] || ( structure[ dataType ] = [] ) )` so that the field is not assigned to all the time (not that critical a code path but heh)?
seems like a `test` for `elem.style.backgroundPositionX` would be better than a test for `window.attachEvent`, right?
If resilt.isNull() == true, I am not sure result.getAsDatum() will be valid or not?
start_pos == 0, so we don't need start_pos*nlabel?
Since I think we'll want the same styling on insts as we do on descs, why not just make a common class name and use that here instead?
But About tab contains credits section with the names of contributors. How that differs from my entry?
Wants an `if bottle` I guess.
"CC: /usr/bin/clang" only means that the CC environment variable is set to /usr/bin/clang, it doesn't say anything about whether the actual cntlm build system is using clang.

```
xcrypt.c:1: error: bad value (native) for -march= switch
xcrypt.c:1: error: bad value (native) for -mtune= switch
```

are gcc error strings; "-march=native" is a clang-only flag, so the cntlm build system needs to be patched or otherwise told to respect the CC variable.
We don't need this comment at the top.
No can do - 1.4.4 :(
Why not use PHPUnit test cases
Isn't this violating your conclusion here: http://blog.ometer.com/2011/07/24/callbacks-synchronous-and-asynchronous/
Why do we have a shorter timeout here?
Согласен, оба варианта не очень.
Собственно, новый сохраняет все недостатки прежнего и отличается лишь наличием аббревиатуры в скобках. Мне показалось странным, что в тексте аббревиатура начинает использоваться так, словно читатель уже знаком с терминологией.
Заменю на предложенный вариант.
Ich meinte das allerdings anders, angenommen wir haben folgende struktur:
_dir1
_dir1/other
_dir1/_dir2
other
other/_dir3

mit `->filterDirs('_*')` würde ich das erwarten:
_dir1
_dir1/_dir2

und mit `filterDirs('/_*')` das:
_dir1
_dir1/other
_dir1/_dir2
ich glaube dass deine variante mit ``` ->filterDirs('_*') ``` weniger nützilch ist.
Why not just do that for them?
thx. I will inline it.
Likewise on these volatile fields.  I just want to be sure that the next committer who comes around doesn't break something because she doesn't understand the intent here.
This can be `||=` instead of `?=`, though it doesn't matter that much.
What is blessed for?
As I mentioned in chat, this may need to be using io script to get across domain restrictions. It's possible that it would be hitting a local resource, but I think that's probably more unlikely.
Should we rename to _currentFullEditor to clarify?
Ooh, good point!  So actually, can you remove that TODO now that your code properly supports the dialog being async?

Since you have reason to make another commit anyway, I think it'd be good to change ```.then(...)``` to ```.pipe(result.resolve, result.reject)```.  Not a big deal, but it's a little more compact and more similar to other code in Brackets.
Sorry for not mentioning this on the first pass, but I think it's an unnecessary level of indirection to reverse the logic here (i.e. "!result"). Please use:

```
  return result ? {line: ctx.pos.line, ch: ctx.token.start} : null;
```

Same in _findCommentEnd().
I don't think we should escape here: this is more of a model-level object and it shouldn't assume how the name will be displayed.  (In fact, soon enough it might be used for a native menu UI where escaping is _definitely_ undesired).  Also, as written right now I think we'll wind up double-escaping stuff.
Seems like you're not planning to localize the sample page. If so, you don't even need to add this file. If you want to keep this file, then you should add a comment before this line for someone else to translate the sample page and update this line to "ru/Getting Started" with the translated sample page.
Can this loop body and the main loop body (line 353) be factored out into a single function?
Nit: please indent for readability
Refresh my memory...This has something to do with native menu implementations right? How the native menu enabled state may get out of sync with Brackets?
Same comment from above applies here.
is there a stylistic reason for these inline imports that don't have a circular dependencies?
I think also this should go out?
I used videojs because that's what mozillapopcorn.org uses and I assumed it met some level of desired backwards-compatibility, but if straight `<video>` tags are good enough, I can switch it.
I think that adding the `-e` switch for errors only would be good because it'd get rid of the many `Warning: The character encoding of the document was not declared.` messages.
Same as https://github.com/mozilla/butter/pull/1316/files#L1R377
Not an addition, granted, but should this link really point to a localised location?
changes[fn_]   contatins {'something': 'value'}

changes[fn_].items() returns a one item list with a two item tuple.

[('something', 'value)]
not a standard, just something that I think helps - I generally try to document these types of things on public methods especially. And yes if I could wave a magic wand than I would fix all old Nexus javadoc, but hey this is new code. I like your idea of those additional annotations.
Do we even want to use `tmpnam`, since it doesn't work on windows?
Heads up for QA - this change could break hudson, you may need to do this:

    bundle install

on the hudson instance if ci_reporter gem will be missing after this is merged.
Msuchy had a comment today - should not this go ti models/glue/candlepin directory rather than this one? If I look on the candlepin glue RPM it looks like this currently:

    # rpm -ql katello-glue-candlepin
    /usr/share/katello/app/models/glue/candlepin
    /usr/share/katello/app/models/glue/candlepin/consumer.rb
    /usr/share/katello/app/models/glue/candlepin/content.rb
    /usr/share/katello/app/models/glue/candlepin/environment.rb
    /usr/share/katello/app/models/glue/candlepin/owner.rb
    /usr/share/katello/app/models/glue/candlepin/owner_info.rb
    /usr/share/katello/app/models/glue/candlepin/pool.rb
    /usr/share/katello/app/models/glue/candlepin/product.rb
    /usr/share/katello/app/models/glue/provider.rb
    /usr/share/katello/lib/resources/candlepin.rb

I have already fixed the spec, but let's discuss this and move it there after Katello 1.1.
The only place where the library does not follow the Symfony2 standards is for array keys, where underscores should be used (which also leads to a violation of the Twig CS for the same reason). So I'm wondering about changing them to underscores in the v2 of the library, but I'm not sure yet (it would be a BC break)
keep the convention. these lines should be:

``` js
    ['get', '/', 'Home']
  , ['get', '/soy', 'Soy']
```
I will clarify this in the docs.

The design of all of the classes in this module are as layers on top of other streams, where the other stream is listened to but not otherwise modified.

I've considered making pass-through be an option specifically for the flow control methods `pause()` and `resume()`; and `destroy()` may want to be optionally passed-through as well. However, I decided not to implement that until / unless I find an actual use case.
you should remove this extra newline
and what if there is other stuff in the context ?
offset: 0
do you think it's safe to just do `this.element.innerHTML = ''` here?
This line failed to show properly when there is a global button. Width of all the button add up to 11 or 12, pushing the return key out of screen.
Ah, sorry, thought that this was for get_temp_url stuff.
Actually, the same goes for ``flam``.
Maybe it would also be useful -- without going into too much details -- to specify what kind of data this is? (and should we really refer to it as a table?)
A mistaken `git commit -a`; I was running tests within the tests/ directory and it was giving me import errors from convolve.py even though convolve_fft was the only thing being tested, I think because of the __init__.py.  How do you run the individual tests?  i.e., do you do something other than py.test test_convolve.py?  (also, the comments have been undone in the latest commit)
I'm not entirely sure why you changed this.  The method using `count()` is significantly more efficient. `splitlines()` actually creates a bunch of new strings that will shortly be discarded anyways.
Sorry about that. I think I'm a bit too tired today. :( Fixed.
I think the opposite of what @seancribbs is true here. Maybe opposite isn't right... Inverse. yeah. Since this is an rpc:call, it'll work with distributed erlang, and the fact that we're working with a devrel doesn't matter. This function can live in the rt module.
Left over debug statement.
I think the idea is that each file needs to contain it so if a file is copied elsewhere, the license follows that file.
@markstory: aah, sorry, the integer 22527...

I'm a dnonkey. Gonna fix that in a second...
why not 'invalid_badbehavior_httpbl_key' :laughing:
`enaml_toolkit` appear to be an undefined local if this `else` block executes.
Ha - is this being too clever instead of just adding the 4 key dict manually?
When can the balance be None?
`create_ts`
These two wait functions will be fixed to actually wait (block) in the future. This means that they won't be able to use "real return values" (if it context switches, it will then write the return value to the wrong thread) so we might as well make them do it the ugly way now (void return value and use RETURN(x) instead). Wrapped parameters are fine though.

The real fix for this is probably to "defer" context switches until the HLE function returns, but that hasn't been done yet.
If the editor exits immediately with an error and wait is False, will this fail silently?
FYI,  this is conflicting just because of the 2 above  `assertEquals` that have drop `s` in 4a6836ce  ...
Using `BytesIO` and `TextIOWrapper` here is overkill - it's easier just to `return response.read().decode('latin1', errors='replace')`.

In `openpy` we use BytesIO so we can sniff the encoding before we decode it.
The generateHtml parameters shouldn't change here.  title can be assigned with a simple statement like this:

`title: config.title or path.basename source`

You'll need to add a default for the title as well, that is initialized to something falsey.
can you change this naming convention to Api?  currently, we don't employ the word "Service" anywhere
This is a pretty minor detail, I realize, but in my mind, I would move the switch on the `git_tree_entry_type` to the outer scope and only check for the `S_ISLNK` for `GIT_OBJ_BLOB` since that is the object type under which a link will be stored.
change this to:

``if {[string is integer -strict $query]} {  # .whopicked <index>``
Here you create a RegularPropertyDeclaration which is discarded if it turns out to be a AutoPropertyDeclaration - I believe it would be best to not create a RegularPropertyDeclaration until you know that's what you'll end up returning.
You don't need this anymore
There are different indentations in here. Not sure if it's tabs or what?
Yeah... I fiddled with a bunch of boost combinations and ended up with this. Boosting question title and content brought up things that were kind of meh and they'd score higher than documents would. I suspect it's because question title and content have fewer words than document title and content, so having a text phrase in them scores higher. Having said that, I didn't look at the explain numbers.
ugh, I mixed things up during my last changes, bugger.
in this case, I'm deriving from a class from webpy.   I'm setting variables that are inside the webpy appliciation class, so I don't have the power to PEP8ify the names.
This would result in a status code 500 at the client. This is not correct as it in fact was a bad request and not an internal server error.
Oops didn't notice this before merging sorry - probably want a variable in there instead of hardcoded date no ^?
I want my code in this case to pass the jslint tests, not going to introduce "!=null", although I understand the point.
WTF ? This is a memcached driver
Wrong. There is absolutely no reason for the form data to be Doctrine Collection. The only possible phpdoc is ``mixed``
actually the test fixtures did change
Yes, there is a top level exception handler, but it displays  "Report a bug to bugzilla" message with a backtrace, it should be used as the last place for uncaught exceptions.

But yes, catching general exception is probably not optimal as it might hide some programming errors.
An output stream would be more versatile than a filename, no ?
We might want to move this bit out into dogstatsd itself or make it more generic.
I'm sorry, that's obviously a mistake. Should I just patch it up and
re-submit the pull req?

-steve

On Tue, Oct 23, 2012 at 12:49 PM, Eric <notifications@github.com> wrote:

> In
> source/riak/references/appendices/comparisons/Riak-Compared-to-MongoDB.md:
>
> >  		
> >  			<ul>
> > -			  <li><a href="http://www.mongodb.org/display/DOCS/Data+Center+Awareness">Data Center Awareness</a></li>		
>
> Why did you remove this line?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/basho/basho_docs/pull/47/files#r1920658>.
>
>
ah, I see, okay.  My crappy example server in there needs to be updated, it was using the callback.  

Will merge and publish.

Thanks again!
empty lines?
Repeated minor gripe: there are no changes to this file.
@Sunight  呃，才注意到…看起来是有点问题。UITableViewCell的reuse机制是: 只存在可见个数的instance，滑动时看不到的cell并不会被release，而是重置其展示的数据append到新进入视野的cell去。现在的代码，相当于没有使用reuse机制带来的好处。想象一下，如果返回结果超多的情况，现在的代码会生成很多没有被展示但是已经存在并被赋值的实例在内存里，会占用很大一部分本可以不被占用的内存。
Since the hashes are essentially driving the resources, I wonder if giving them full control would be easier than providing direct mapping, especially to allow automatic support within the recipe when new attributes may be added to the resource. Something like:
```ruby
lxc_container name do
  container.each do |meth, param|
    self.send(meth, param)
  end
  action :create unless container.has_key?(:action)
end
```
Thoughts? Road to madness?
Well, after amending whats passed to the log message, it should now write 'of type' rather than 'with value'.

:-)
heh no need for comments .. just remove it for now
then you don't need this
Because on call log and call screens it fits perfect - with name containing average width character, of course CSS ellipsis would be the best solution but check my reply on that below.
nit: indentation seems wrong
This part of code is not human-readable. Please rewrite in a follow-up.
Please make sure this file is encoded in UTF-8.
@alivedise We haven't discussed power management very much, to be honest. Can you explain the behavior? The phone's power-saving features would automatically be disabled when the user connected to a power source?
Nit: please use `var _ = navigator.l10n.get` instead (gettext-like), just to be consistent with other apps.
No, this messages are rarely sent. Anyway, the debug method could be enabled/disabled on utils.js (and is disabled by default)
I think I might have fixed this.
Or your former solution of redirect siblings or may be the extension of each key via :after CSS pseudoselector in order to force the key to be taller. What do you think?
I'm sorry.  That contradicts the documentation and is a bug in the implementation.  You're not supposed to have to pass a function there.
I'm pretty sure we don't need to use `call` here, `this` will still be `this` :)

`this._checkDBReady(function deleteCB() {`

Simpler and we get rid of an anonymous function, win-win.
This should be

    font-family: "Open Sans", sans-serif;
    font-weight: 600;

But let's confirm that the platform does includes the font of three weights first, preferably in UI Tests.
@benfrancis right, I'll fill the bug and add the comment.
Let's declare tokenDataReady next to this window.addEventListener call. (false is also not needed, this is the default - thanks Webkit!)
lol i know
CHanged track/path to have priority 1.3 to match the cycleway priority or we would now prefer a path over a dedicated cycleway
That's what I was about to say. Each creature should really file it's own image choice with the server. (If not upload its own)
Should it be case sensitive?
oh, right, i get it.
Dont you want this to be strictly greater than 1?
Don't read files like this - do it via `with`, in the Pythonic way.
To make this consistent with other Python and Ruby documentation, either remove the extra lines or open an issue about this inconsistency and one of us can do it next sprint.
I thought about this. I also thought about looping backwards through the list to save execution time.

In the end, I didn't want a failed test because the developer decided to do other stuff while they ran the test suite. 

The only issue here is if the talk already exists prior to running the test suite, which is still a problem because I can't remove the talk (you'll see the TODO a little further down).
Nope, it's the first one that complains, still.
Coding style nit - adding "I" to the end of normalNode goes agains the naming conventions used in the rest of the file.
The naming of methods here is quite inconsistent. It seems there is a mixture of `underscore_separated` and `camelCase`. Existing buildbot code is inconsistent, but the preferred convention for new code is `camelCase`. Also, there seems to be a mix of private (_ prefixed) and not methods. I think probably everything but `poll` (which is public) should be _ prefixed.
it is just about making it more readable :)
Yes, that makes me think I need to add a "credit" section
what's the idea here?
I assume this means log* isn't marked dynamic and so in clojure >1.2 it can't be bound? Any thoughts on how to avoid log output during tests?
FLOWLOCK_* macro
It's an uneditable text label. I'll add that.
why params, however it can be instance variable
Maybe something like this instead? : 

branch="$(git symbolic-ref HEAD 2>/dev/null)" || branch="(unnamed branch)"
branch=${branch##refs/heads/}
is it useful to have this codename throughout our codebase?  would something more boring, but clearer be better?  `shimmed_idps` `shimmed_primaries` ?

this is a nit, it should not block merge.
+1 for hiding the merge call. The first point would be nice to have, though it looks like some modules have multiple cef calls with distinct signatures?
@ozten - the app cannot continue without storage.  I agree with your concern here and created PR-1489 to globally address this for all pages on the main site (minus the splash page) - if cookies are disabled (making localStorage unavailable), then an error is displayed to the user immediately upon landing on the page.
Why can't this just be `import configobj; ....; configobj.ConfigObj`?
AlinT: They weren't added because the tests were written prior to the introduction of the nondestructive marks- I'll fix that.
why does dp change here?
Maybe say "...based on the ´msg´string..." or "based on the given `msg` string..."
To be honest, that scenario didn't came to my mind. Thanks for pointing this out. Added to TODO list.
Perhaps time to split this to a longer line? perhaps 4 per line? That way we can track changes to these a little more easier.
The error message here doesn't make a lot of sense. Calling a method doesn't always create a resource.
This comment would appear to contradict the spec description at line 60, no? Is it possible to not call a method and yet ignore the return value? I'm confused. :)
I totally agree with @exviva
v sus - i don't think we want to associate objects with dom nodes
See previous comment - I'm proposing a little RF to avoid having to add this 'if __debug__' thing all the time. Makes the code cleaner.
Missing an empty line before line 4 and after line 5
this is useless. It is already set as you get it from Buzz.
switch statement pl0x
The if statement is not necessary.
@harjis Turha. Incluudattu jo parametrit.inc:ssä
isn't this just the opposite of above? if there is a different handling we might want to check ! empty above. but to me this should stay an if/else
You can just remove these blank helper files.
以前は `xmlns:og="http://ogp.me/ns#"` みたいな書き方をしていた記憶がありますが、
http://ogp.me/#metadata によると↑のような書き方をしている模様
import X before from X import Y lines
Style: space between if and paren.
oops, of course it is.
Might as well just make the function argument be arrayBuffer.

Please remove the spaces in `function (..`, emscripten convention is `function(..`.
Yeah, without the parens you need a `\` and also the parens help Sublime Text 2 line up the indents. :D
can we use the async test for this now that we support the most recent version of qUnit?
No, it shouldn't. ShadowFragment.onResume() gets invoked when a subclass of Fragment's onResume() method calls super.onResume() (or if it doesn't declare onResume at all). Think of the shadow as taking the place of the Fragment class itself.
That's a good point. I was writing it with an idea in mind, that it will be somewhere in /usr/bin/ in which case this information is needed. But there is no reason why it could not be called form the #{rails_root}/script directory, and therefore the path is known. I will update that.
The old RDF translator defaulted to Book if type could not be determined. The new one defaults to journalArticle, which I think is a better choice, since it supports more fields.

This change was made to maintain same results on the Archeion website though I'm not sure what default item type would be better for those records. The website reports them as "Reports" and refers to them as fonds. I have no experience with this sort of stuff.
I wonder if the `pull origin master` line is really needed and not just the `fetch`. Removing it would also fix #517.
Two things:

1) Can we use the drupal commenting guidelines? 
Comments should be on a separate line immediately before the code line or block they reference. 
see: http://drupal.org/node/1354#inline

2) We should default to TRUE. This was the old behavior, and we don't want to disable this surprising people when they update.
Good point. Okay, I will add those.
`.location` is an instance function on each `CookbookSource`
渡された配列群から和集合を計算します: 1つないしそれ以上の配列にある、ユニークなアイテムが順番になったリストとなります。
Yeah, the problem I've had resolving that split is that `Template` needs to know about the page it's rendering for (so it can get `metadata_for_path`) which kinda ties it into `Page` anyway. I feel like "how does this render" is the concern to separate, not path/template.
Keep undefined until we need it? If we don't have to generate a name no reason to set it to something and use memory.
you have a few spaces here
nice @zacc , so nothing to fix :)