labofsahil/github-event-dataset-2012 huggingface dataset:
Awesome. Very glad to get rid of this plumbing.
no space before a colon
This method ends up being an implementation of Hiera inside Hiera but only supporting the yaml backend. This seems less than ideal to me since the user will be creating a `hiera.yaml` file that isn't the same as the file used by hiera itself and could just lead to confusion.

This would be better implemented by using hiera in here to get data local to the module.
This needs to be in a before action: http://rubyspec.org/style_guide/
This is the lowest level connection driver, so even lim == -1 seems to be too much logic at this layer.  Always adding a Stat round trip on every Getdir message seems like you're trying to do too much, especially when this method assumes you already know the limit you want.

I'd assume the caller knows what they want, and not double check it for them with an extra call to validate the `lim` every time, but handle ErrRange as exceptional behavior.
```js
fn = $.isArray(this.source) ? 'lookupLocal' : 'lookupAsync'
```
"/usr/share/zoneinfo/" also looks like a constant of Timezone.ycp
It sounds reasonable but it would be probably better if someone more familiar with the language did such cleanup.
Function description missing. The function is global, so it's required.

/**
 * Does this and that...
 *
 * @param string MAC address
 * @return string something
 */
To follow PSR-1/2 guidelines, it should be:
```
class InvalidArgumentException extends \InvalidArgumentException implements
    ExceptionInterface
{}
```
I'll fix when merging.
Should this import Request, or MessageDescription?
It might be better to rename this to be more descriptive - eg. CursorShape
This should also be a <footer> tag
simple implementation of ConfigurationService so that we can run a stand-alone process without server
perf improvement: create temp variables for the start and end symbols outside of the forEach, preferably in the factory fn. then use those here.
What do you suggest ?
@stof: its correct that the change is in the suggestions, as its one of the possible alternatives for having a phpcr implementation.

@piotras: as i wrote in the original comment i am confused by the ``@dev`` version because usually that would be called dev-master. stof points out that suggests is supposed to be a message to the user. phpcr does have versions so you can indeed depend midgard phpcr on a version as needed.
Things break without this one as well. Learned these two from Pat while refactoring PasswordResets.
it is a type here. variable names are (currently) done as varrname=interger (see L198)
What are these changes actually about?
Incorrect docstring.

```
/**
 * Property: comboConfig
 * {Object} Additional config properties for the filter types combo.
 */
```
yes indeed, this should be cleaned up.
궁금한 것이 그렇게 할경우 html뿐만 아니라 js나 css에서
파일 로드하는 js, css 코드에도 모두 붙여줘야 하나요?
Foiled again by @zacc !

Ok, I will undo the complexity and push a new (boring) version. ;-)
Ah I see, I had a look at this page and I can't see why you wouldn't use `visible`, and given that this test would pass using `visible` it becomes a superior test because it's using a more representative assertion.

If you think about doing this test as a manual test you would fail this test if the links weren't visible and clickable even if they were in the HTML source. That's often how automated web tests fall down; not accurately representing the user's perspective. Can the user interact with the element? The user's perspective is the most important thing. What use is a passing test if the user can't use the page? If the element is expected to be visible then either the test needs to do something on the page to make the element visible (open a menu or something) or even better - it's found a bug in the website!
Does this every unlink? I'd imagine if the exe is gone and fetch is called refreshPointers() would just keep on failing without every triggering an unlink.
I believe we should avoid spaces in log labels. I recommend simply using "frei0r".
should we mention somewhere if its V1 or V2 ?
I've removed it from tests, as I dont think its really requied
This whole class doesn't do anything, is it a stub?
`src_files` listed twice
такое бывает у тебя?
Haml 3.2 switches the default to html5 output. Explicitly declareing `:format => :xhtml` will make sure things stay the same between 3.1 and 3.2
Got  @guilhem's Upstart recommendations working.
We should delete the comment after the :
you're missing documentation here, explaining what this method does.
The logic seems a bit funny.. you're calling `all` and then looping through each page *and* its children when they're already contained inside the `all` result set.
Needs a return statement as well
I'm not sure I understand. `// Get existing users` should work.
But the two syntaxes are equivalent without the manifest. Neither of the two ensures that at runtime it is more than some kind of `Either`.
oh I see, you have this here. We should keep at least one example in the `req.accepts()` docs
use devise :)
don't abbreviate names. use "account" instead of "acct".
Ik denk dat we dit beter in CSS kunnen doen. Ik zal kijken voor een fix:

http://www.w3schools.com/cssref/playit.asp?filename=playcss_cursor
This line is throwing an error for me. I'll fix it up to .FirstOrDefault() but what should the default behaviour be when null is found?
Он НЕ заменяет строго Х процентов.
@slebedev мне незачем. Я впринципе показывал, что проперти можно и выставлять извне, например, UILabel#text http://developer.apple.com/library/ios/documentation/uikit/reference/UILabel_Class/Reference/UILabel.html#//apple_ref/occ/instp/UILabel/text
Всё правильно, я не полностью прочитал, как вы заполняете массив индексов.
why it does not has {{ form.csrf_token }} ???
This is sometimes useful, so I'm keeping it in for future verbose debugging possibilities.
This looks awesome. One thing which occurs to me is it might be nice to separate the building and the execution of a plan into separate modules.
perfect!
I'm merging this pull but here I'll change to <code>$row->$key</code> to be independent of future primary key's change.
Are there cases with these two fields having null value ?
How can I replicate the error you're having for these two fields?

Thanks!
What do you mean by numpy style? If you mean fancy indexing, yes.


On Thu, Dec 6, 2012 at 5:21 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -148,6 +165,13 @@ class Epochs(object):
> >      epochs[idx] : Epochs
> >          Return Epochs object with a subset of epochs (supports single
> >          index and python style slicing)
>
> Actually it also supports numpy style indexing for the first dimension
> (events), doesn't it?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337067>.
>
>
reminder to fix this.
Not sure what is the practice here... Are we allowed to add new methods to this interface or should I create a new interface?
Ahh... true.

What happened is that I copied the README, the noticed I was using the -E flag for pip which is bad, so I switched it. Should have followed through.
Shouldn't this only be if VERSION is < 6?
It should be possible to use this method with other time signatures than 4/4 which you assume. Maybe a second argument called `beatUnit` or something like that, representing the lower number in a time signature (ie. `beatUnit = 8 for 8/8`, `beatUnit = 8 for 7/8` etc.)

Please change naming `tempo` to `bpm` or clarify in comment that the tempo is given in beats per minute.
This if statement is a bit hard to read. It looks to me like it fails on localhost if remote is not set to true.
You should store "repeated int32 subedges;"  in the hypergraph.proto. That way you can just check subedges.size() to know if it is a terminal vertex.
same CS issue here
Should be Option(...) and not Some(...)

Same goes for all Java constructors using Option
please avoid anonfuns, explodes the core lib
I'd be tempted to do something like:

```ruby
@major, @minor, @point = *version.split('.')
```
¿Estos chaboncitos no tiran excepciones si falla una autorización?
Esto fue accidente, no lo saqué a drede. Lo agrego de vuelta.
Probably want to put this in `package edu.nyu.library.citation/util;` and call it `XMLUtil` or some such thing.
You could probably pull this out into two different methods... maybe something like:

```
def retry_find_date(times)
  retry_attempts = 0
  begin
    retry_attempts += 1
    return find_date
  rescue InvalidDateError
    if retry_attempts < times
      puts "That is not a valid day of the week. Please try again."
      retry
    else
      puts "No valid date entered, giving shows for today (#{user_date})"
      return days_of_the_week[Time.new.wday]
    end
  end
end

class InvalidDateError < StandardError; end

def find_date
  Date::DAYNAMES.fetch(gets.chomp.capitalize) { raise InvalidDateError.new }
end
```

Then you'd use it in subjectively cleaner way:

```
date = retry_find_date(3)
Network.all###
```
You can't access property using static keyword because you are not in the object context.
```php
$availableLanguages = static::$availableLanguages;
$this['locale'] = $this->share(function(Application $app) use ($event, $availablaLanguages) {
```
cleanup phraseanet.logger / monolog
The definition is userkey, not lookupkey. Example, implementation, and readme heading are at odds with each other.
Nit: 80 cols max
should this really be set to 1 by default? maybe 10 sounds better
Ok, I'll see
I would push for yet another change here: I think it would be clearer if putInCache called putOrReplace, which called putOrReplaceInCache - you wouldn't need the function arguments.
yes, will add a comment regarding this
Dan, I removed this yesterday after our conversation. Look directly at the commit on branch at my fork. It should not be there
no `println`, please :)
I see. Do you remember why we're testing that? Doesn't seem to belong.
since these are pylab examples, no, it is not discouraged as this is the purpose of the pylab mode.  Personally, I don't like the pylab mode because of the namespace collisions and other ambiguities, but that is merely a personal preference.
Lets try to remove it. It the test fails for any one we can add it back in or remove some of the text.
Sorry to quibble, but I think that in the context of the few lines above, little or no comment is needed.  At most, "file-like object: check for name with extension" or something like that.
This changeset leaves in place the likelihood of somewhat obscure error messages if the file name lacks an extension.
One could use something like this:
<pre>
try: # file name
    basename, ext = os.path.splitext(fname)
except AttributeError:
    try:  # file-like object
        basename, ext = os.path.splitext(fname.name)
    except AttributeError:
        pass
try:
    ext = ext.lower()[1:]
except IndexError, NameError:
    ext = "png" # No extension, or no name provided: try png.
</pre>

Too ugly?
this method is never used
I'm inclined to think the opposite direction actually - you usually do this stuff up-front to avoid framework collisions in later patches with tests + framework modifications.
This one I'd prefer to take care of before merging, mainly cause the code duplication could cause problems down the line and it's not whole a lot of effort to do this.
now I know why, double miss ;)
can has feature request =) 
https://bugzilla.mozilla.org/show_bug.cgi?id=805574
Unnecessary Item; merge it with the Flickable.
Unfortunately this needs to stay "dé-selectionner" because of the way the text shows up on the button.  The button doesn't have enough space for the entire word "déselectionner."
Class names are singular.
The extra space in the first and last line of the method definition is different than our usual style, though using spaces to group related statements (as you've done throughout) is generally encouraged.
Try ...

```php
$a =array();
echo isset($a)?'YES':'NO';

```
All those are in the package at https://github.com/Seldaek/log/ - it will be migrated to php-fig/log in due time.
Why would they? Depends on your current interface obviously, but if it's
not incompatible no BC break is required.
How's this different from `flatten`?
Remove the trailing slash so that this stays consistent with `/dev`.
We should touch base with the Ops team (Doug in particular) to make sure that the Ubuntu 12.10 (quantal) mirrors are set up on their end.
@bp323 Sure, should be fixed in a follow up commit
@ christianv

If an image is not critical for understanding context the standard is to have an empty alt, I think, as then the screen reader will ignore. The image in this case is usually a logo supplied by S2, or the S2 site owner, or S2 and overriden by the site owner. I usually is a logo of some sort, random file name, random graphic format. A generic alt text such as "Site Icon" that would cover all cases would just be chatter to a screen reader as I understand it.
@bp323 Should be fixed now.
Minor: Can we use the $grid values here please?
if it's useful you can always add it. but if you don't need it i would keep it simple..
It feels like there should be an output if description changes. Maybe something like

      M: foo_id [integer] - belongs to :foo

or even

      M: foo_id description updated

I reckon it just should not be changed silently.
wdyt?
Why are we getting rid of the `ERROR_DISPLAY_DELAY` constant here, or at least creating a new named constant for this `250`? Also, `ERROR_DISPLAY_DELAY` is still defined earlier in this file but never used... If we don't reference it, we should delete the definition.
Do you mean like this?

```php

$quickmod = array(
	'lock'		=> array(($auth->acl_get('m_lock', $forum_id) || ($auth->acl_get('f_user_lock', $forum_id) && $user->data['is_registered'] && $user->data['user_id'] == $topic_data['topic_poster'] && $topic_data['topic_status'] == ITEM_UNLOCKED)), $user->lang['TOPIC_LOCK']),
	'unlock'	=> array('etc')
);

foreach($quickmod as $value => $qm_ary)
{
	if ($qm_ary[0])
	{
		$template->assign_block_vars('quickmod', array(
			'VALUE'	=> $value,
			'TITLE'		=> $qm_ary[1]
		));
	}
}
```
I would suggest to either build the string as a local
or call multiple time  io.put_string 
mainly because  a + b + c ... will create many intermediary string objects .. which should be avoided


About logging .. I would expect to be able to output the log in a file, not only on console ..
so you should have a creation procedure with a FILE and store this file in a output: FILE attribute

then, replace all the io.  by  output.
Scala allows direct mapping on Options, getting a more concise syntax
Added a test case to verify I fixed the bug
Any way to create an array of objects using smart queries and joins in the controller?

And then in the view page, reduce the model calls and logic of the data model?

For example result set:

[ {:id => 3, :name => '"Quy Phan", :latest_checkin => {:message => "Diner", :place => "Crab hut"}, :total_checkins => 29} , ... ]
3 ist vllt. bisschen wenig ;)
warum 'newBeer' wär doch eher 'newTag'?
Sorry, @igrigorik , I've slept very little today (damned coffee :-( ) I thought it were @prepor's comment.
Fixed in 4d777d2
So it looks like you and @k88hudson have the same version of lessc, and I have a slightly different one that keeps removing this `float: left` and adding a space to the background URL. Arg!
All these should be marked as private services IMO
Yes, but we still want authorization (to post tweets someday), not just authentication. [This discussion](https://dev.twitter.com/discussions/1253) seems good.

So first time you do authorization, otherwise you do authentication.
You probably should learn to use regex. ;-)
You probably have to rename it also in the code if the method, no?
*Minimalno*? *Najmanj* is better Slovenian word. :-)

*Najmanj 4 in največ 30 znakov.*
I can't figure out how to do this. I know I have to use context variable but how do I get urls defined by api?
because they are function based views but we should use class based views in this project as it is written in documentation.
Need to mention your github nickname here.
These caveats aren't necessary.
Oh, I misunderstood ... okay, I'll try to find a better solution.
what's the deal with /tmp/timberwolf
Just a Ruby style thing, but explicit returns aren't generally used unless necessary for control flow.
Forgot to wipe this method from ObjectMgr.h. Please, do it. It's not used anymore.
you can move the whole script to spell_valkyr_essences_AuraScript::Absorb
@ajpiano I'm thinking this might fit better at the end of the "Not all jQuery Objects are Created `===`" section, like so:

> This code functions identically to the example above, but it is a little more clear to read.
> 
> However you choose to organize your code, it is very important to make the distinction between jQuery object and native DOM elements. You cannot access native DOM methods and properties directly from a jQuery object, and vice versa. **If you see error messages like, "event.target.closest is not a function"' or "TypeError: Object [object Object] has no method 'setAttribute'" you are likely making this common mistake and now have the knowledge to remedy it.**

Does that work for you?
accumulateDirectories is not checked.
> I am not sure which one is more complexe actually.

* on one hand we are adding new functions on the fly to the class signature
* otoh we are serving the right function depending on the call

Unless having those functions as explicit class methods is something mandatory here, using a more conventional constructor will avoid:

- bugs related to the fact that new and init don't have the same signature
- a mixin
- all the class methods needed to hook the functions to the class

and will simply be a loop in the constructor and a one liner in getattr.

> Feel free to rewrite this part of the code.

I am just sending my feedback. I'll leave it up to the person that proposes this feature.
Done.  StrAppend is much better.
Should be a const member function: `int GetNumLights() const`.
c/p from bootstrap :P
none of our classes have a leading underline, even if they are internal classes, or classes for users that want to create their own subclasses
this should include the abstract method  update(Event o, Object arg)  and a concrete implementation for update(Observable o, Object arg)  casting o to Event and calling the abstract method.
If this code will not be used, please delete it.
is there a better way to handle timezones?
Let's kill thesecommented out lines, since the new lines supercede them. (It is a full supercession right?)
test header comment
Optional parameters should be listed after mandatory ones
this shouldn't refer to addthis anymore
Play 마켓으로 바꿀께요. 넥서스에 맞춰서요.
Should we call this something like chef_logrotate or something.  When I first saw it, I thought you were going to install the package or add some generic config.
This argument isn't used at all.. Could you please remove it so we don't have to keep track of irrelevant variables when looking at this code? :)
Doesn't exist in Django 1.3, which we're still supporting for now.
It's more a development dependency. It doesn't come along for the ride
when gem install is used
@adamcooke indeed.. green looks surprisingly yellow on mine!
is this switching to use the toolbar in the create.js header instead of next to the content?
Doc string is incorrect.
there will be the issue here that ['misc']['idxs'] and ['miscs']['vals'] will need to be filled in properly if e.g. TPE is to use this job.  There isn't a handy function to do it either, I'll think about how this could be done. It doesn't sound easy at the moment.
@MrMaksimize is going to remind you: Comments need a space between `\\` and should always represent a thought with a full stop.
What about the more recent 1.2.32.zip at http://www.bioinformatics.org/project/filelist.php?group_id=84 ?
@secondsun so they suggest creating a TAG static field?
like coyotte said, client does not know about this, ever. onJoinChannel or on PlayerReceived would be much closer
Forced exits are handled within .report now see below for an explanation
Oh there it is, I misread the code in IDEA. This feature works then.
can you try to catch any error message and add it here pls
Integrationテストでのみ使用できます。
↓
Integrationテストでのみテストできます。
同じ言葉が続くのはカッコ悪い感がありますが。
Let's do so the next tabbed view?
Should probably be ```core.add(handler.getCoreMetadata().get(0))```.
> > +    # Get indices where values of probas_pred decreases
> > +    thresh_idxs = np.r_[0,
> > +                        np.where(np.diff(probas_pred))[0] + 1,
> > +                        len(probas_pred)]

> I have a hard time understanding how this bunch of numpy magic works.

You just have to know that np.r_ concatenates. This s fairly standard
numpy manipulation. So what this code is doing is just sticking '0' at
the beginning of the array, and len(probas_pred) at the end.

G
Please rename `k` by `n_classes`.
Don't use single letter variable names. In this case this should be `n_samples` I think.
What is `K`? Please use an explicit variable name.
deux en un et un typedef pour les unir tous
Is it really ok to not have found an event or should we return an error? Might want to check what the other platforms do.
なるほど。
It should be ``pipeline.templatetags.compressed``.
The only thing we can do is replacing "find" by getReference where it makes sense.
This was probably in the cpp file to avoid macro pollution, but AFAICS, ```jsocket.hpp``` is mainly included in cpp files, when needed, so not a problem moving this here.

@richardkchapman is this ok?
This almost certainly works, but it should really be adding sizof(void *) instead of 1
Just code movement (see below)
Well I disagree, but not a show stopper or anything, I'd have probably coded as:

if (n) {
    unsigned i=0;
    loop {
        exceptions->item(i++).errorMessage(errors);
        if (i==n) break;
        errors.append(", ");
    }
}
There might be some benefit in adding firstRow into the base class.  It would simplify some derived functions, and might be useful for avoiding copies in some of the non-spilling functions.
I've raised a bug for this: https://bugzilla.mozilla.org/show_bug.cgi?id=734285
So I'm curious why you've removed the absolute reference here. Has the path changed in Solaris?

Anyway - the tests in spec/unit/processor_spec.rb fail due to this change.
@shacker I totally agree but again, for the POC I wouldn't make a big deal out of this.

When adding a library for something big like this (date formatting) it's good to know the specific needs it will have to fill.
Right now I don't feel like we really know that.
you should remove the constructor as there is nothing to put in it
style nitpick: indentation appears to be off here
Agreed; why doesn't it?
That's a valid concern.  I'm ok with not checking the file, tbh.  When an exploit is being developed, the developer should make sure that part is functioning properly anyway.
Would be nice to have a comment documenting why it's +8+5-11
Do you mean unless check == Exploit::Checkcode::Vulnerable?
Yes, that is indeed better.
I just want to be sure that the intention moving forward is to use the "described_class" method.  I like this personally but just want to make sure that we stay consistent with whatever we choose.
Where does `slideToggle` come from? What happens if the host doesn't define it? If it's *guaranteed* to be defined, shouldn't it be part of the public API?
I'd put a FacesContest producer in the org.jboss.as.quickstarts.kitchensink.Resources so we can @Inject the FacesContext, rather than use the static lookup.
I wanted to make it clear we were manipulating the database and not the guest agent. For some reason on the Sneaky Pete side "start_with_conf_changes" seems weird without specifying what to start.
Object literals are slow relative to what?  Uploading sub-images to textures?  Uploading texture coordinates to vertex buffers?  I doubt it.

If we don't need a new class, we should not create one - and this class is not general enough to be useful.  It is tightly coupled to `TextureAtlas` - just looks at its constructor function.  This is code for the sake of code, which is the worse kind of code.

This class is simple enough that brief documentation in `getTextureCoordinates` is enough.  The current documentation is bureaucracy.

@shunter - you're our JavaScript and software design expert - set us straight.

@IanLilleyT - we discuss the code itself; not the person who wrote it.  Detailed code reviews like these are a complement that we are interested in your work.
I actually meant to do a pass before submit to do this but forgot.  Thanks for reminding me.
Well, it's the bounding box, which is size + position. But I don't know what 'frame' means, so I'll remove that.
Since this is a new module, the copyright can just 2012 :)
These classes can be compacted considerably. There is no need to repeat margin-left and margin-bottom so many times (HTML elements can have multiple classes at the same time).
Needs since tag
It might be worth mentioning that rows act as if they are SIZE height.
I think we should be checking here if the api is removed and use "Removed in " instead of "Deprecated since".
We can make this async by checking for listeners like we do for firing onto the window.
А ты через JSLint не прогонял?
Whether we split out a chaining section or not, I agree that this:

>1. `then` must return a promise [2].

Needs to come after this:

>1. `then` may be called multiple times on the same promise.

Although @lsmith's reasons for breaking to a new section at the spot he did make sense to me, the bullets are all still specifying the behavior of `then`.  From that perspective, I think keeping it nested within the same section makes more sense, imho.
Default should probably be false? I realise that nil is a 'falsy' value, but in this case defaulting to nil is kinda weird
Может тогда это как фабрику вынести, если так хочется? Под неймспейсом ведь только классы лежат.
I hate to be the one bringing this up (luckily, this can probably be fixed by not manually touching every line), but: Isn't JS routinely indented by four spaces?
@jmdavis: Ask @dawgfoto, referring to std/utf.d line 167 and nearby.
Commenting on the existing unittests further down, I would love to see coverage for "cross-type-strings", eg:

```D
foreach(S1; TypeTuple!(string, wstring, dstring))
{
    foreach(S2; TypeTuple!(string, wstring, dstring))
    {
        //Test join!(RoS1, S2)
    }
}
```

Along with a bit of Unicode, those tests are painfully missing.
Let's got with `sw?`, actually.
`private final static CommandProcessor processor = new CommandProcessor();`. Then `getProcessor` becomes real easy :D
So far it is a copy, only difference with the previous one is we only want the release number to be passed to Sphinx.
Turning the git describe block into a macro is what you suggest, right?
ah sorry .. got confused with the lines .. will adjust my test scenario to see if the above is really in need of fixing.
Got it, re: not a presenter.

And I forgot the ExplicitDelegator. But you get the gist.

```
module WoopleTheme
  class ContentItem < ExplicitDelegator
  end
end
```
indentation is broken here, align the `[`s.
Is there a reason for not using `UserFactory` in this test too?
Looks like it's being fetched in the autosave functionality inside of this callback. I removed it from the autosave function and passed the pageData from this one.
And use explicit types.
Do we really want to resolve on every message?

That said, the parser is still injecting by reference so is any of this additional code in Recipient even needed?
extremely unlikely (since this is per-thread), but this is theoretically not guaranteed to be unique.
Using recursion to discard the stale responses is dangerous and could easily result in a stack overflow.

Let's say we have a small timeout and the consumer is down; we could pump thousands of messages into the queue. When the consumer is restarted he will process all those old requests and send the results back here. KABOOM!!
In Dancer 2 $dsl->engine triggers an exception if the engine is not set. Don't know if you really want to wrap that?

Also, why not doing that in init time?
I was thinking of having a 80 word limit because it is painful to read otherwise. What was the problem with the previous thingy?
'tis ain't a `table`. 'tis a definition list!
@bp323 Also made the same change in #86
Где найти список всех пакетов фреймворка?
possibly. I'll look into it. Off the top of my head, it seems like it would be messy. The implementation might change depending on what geometry type it is.
The authentication strategy is needed only in api processing. So it has to be somewhere near the client. So it should be in more nearrow scope. The root scope is to big to have api authentication logic in it.
I don't like constructor injection. :) Would you turn that into a setter?
Oh, I see. That's my bad. It doesn't actually matter, since python evaluates empty strings to `False` and nonempty strings to `True`, but I'll fix that.
This could be handled by composer
The code is good, but the comment is wrong.

`from django.utils.timezone import now`

This *only* works with Django 1.4+

@philomat it would be good if an updated release was available which worked with Django 1.4 directly
It is. I tried a few different ways, all ugly.

This is because, even though both super and file inherit from the file interface, one doesn't inherit from another. And exposing ```linkSuperOwner``` to the interface is not good.

To be honest, the whole treatment of this function is bad. I think it all should be atomic and no one else should use this method for any other purposes.

When I manage to get ```DFSAccess``` split, it'll be much cleaner.
indeedy, will fix
Yes it should :)
Please add unittest blocks specifically for your examples so that they can be programmatically verified for correctness.
Should there be something after the = here ?
Aright. Tajusin. Ihan ehdotuksena ensi kertaa varten niin tuon esimerkin voisi lisätä testiksi. Oma ratkaisuni kaatuu kun listan alkioina on listoja. Tämä on kuitenkin my-mapin erikoistapaus jota kannattaisi testata

Kiitos!

Jeremias

On 25.11.2012, at 19.02, Jani Rahkola <notifications@github.com> wrote:

> In src/one_function_to_rule_them_all.clj:
> 
> >  
> > -(defn count-params [x]
> > -  :-)
> > +(defn my-map 
> Ei hätää, sinulla on kasassa jo 121 pistettä.
> 
> Ajatus on aika lähellä, mutta ongelmana on se, että my-map-one-element ei toimi oikein. Esim:
> 
> (map count [[1] [1 2] [1 2 3]])
> ;=> [1 2 3]
> (my-map-one-element count [[1] [1 2] [1 2 3]])
> ;=> UnsupportedOperationException
> Lisäksi käyttämäsi matriisin kasaaminen käy paljon yksinkertaisemminkin. Pohdi mitä nämä tekevät:
> 
> (my-map first (cons a-seq more))
> (my-map rest (cons a-seq more))
> —
> Reply to this email directly or view it on GitHub.
>
Alright. I do not understand this part of code, yet. So if this is proper handling, then I am OK with the proposed code.
Tak mi priprav nastaveni NetBeans :D
we should write a test for this method.
Lets try this;

    attribs = feature["@"];
    if (attribs) {
        attribs.required = packagerUtils.toBoolean(attribs.required, true);
    }
    accessObj.features.push(attribs);

And then further down in the validateConfig function you can insert the below code into the existing `widgetConfig.accessList.forEach()` loop.

    //Check if there are empty features
    if (access.features) {
        access.features.forEach(function (feature) {
            check(feature, localize.translate("EXCEPTION_INVALID_FEATURE_ID")).notNull();
        });
    }
please test wiring to dao level
file name should have an uppercase first letter.

Login.cshtml
the commits below provide those new routes