labofsahil/github-event-dataset-2012 huggingface dataset:
Hey Massimo, I'm confused? Why the downgrade to 5.3?
It probably was :)
word, sorry about the over zealous pull.  was busy yesterday
Not [DRY](http://en.wikipedia.org/wiki/Don't_repeat_yourself), but pretty safe against [SQL injections](http://guides.rubyonrails.org/security.html#sql-injection). Here's [what I did](https://github.com/christiangenco/hw2_rottenpotatoes/commit/f46404204a6de1d27e2408ed0a902aa97982e33f).
Can you explain what problem this commit fixes. Example page would be super.
Think I'm going to have to get a few more brains working on the group loot. The only bug I have left is it resends the loot to a second player allowing them to open it over and over as long as they don't respawn it. But I can't figure out how to stop that. The bug exists in actual mangos too though. 
Sent on the TELUS Mobility network with BlackBerry

-----Original Message-----
From: stephen <reply@reply.github.com>
Date: Sat, 31 Dec 2011 15:15:38 
To: <Andrewmcmanemy@Hotmail.com>
Subject: Re: [KreegothInfinity] initial commit. Added custom SD2 scripts.
 DisplayID fix for custom items and Group chest loot fix (bddf929)

just gotta play around with it

--- 
Reply to this email directly or view it on GitHub:
https://github.com/Kreegoth/KreegothInfinity/commit/bddf929b84954ba19147fe4e8bb47df3a6f4516e#commitcomment-829706
DELETE FROM `creature_template` WHERE `entry` IN (43917,43438);
What? I don't understand the question.
On Jan 21, 2012 6:41 PM, "ac1965" <
reply@reply.github.com>
wrote:
>
> I wonder why you compile the some hierarchy. see
https://github.com/ac1965/LorDmodUE/blob/ICS-AUFS/kern_build.sh
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/TwistedUmbrella/LorDmodUE/commit/98870880b0809369feaab0f214a3d316c377b506#commitcomment-889195
Am I right in thinking that Molly is supposed to support Py2.5? If so, you'll need to go with the less-readable ``urlparse.urlparse(…)[2]``, as only in Py2.6 onwards is the result a named tuple.

    alex@machine:~$ python
    Python 2.5.2 (r252:60911, Jan 24 2010, 14:53:14) 
    [GCC 4.3.2] on linux2
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import urlparse
    >>> urlparse.urlparse('http://foo.bar/baz/')
    ('http', 'foo.bar', '/baz/', '', '', '')
@ethdemor MyPage를 배껴서 만든.. 사용자 정보 조회 페이지? 이건 모두에게 공개된느 페이지.. 너가 만든건 자신만 보는 페이지.
In java 7, this would be:

````java
catch (ExceptionType1 | ExceptionType2 | /* and so on... */ | ExceptionTypeX e)
````

But without java 7...
Where you able to make git ignore db.sqlite? When I try to add them to my ignore file git keeps recording changes to the file.

Thanks

--Matt
less.js 1.2.2 now provides support for YUI Compressor, but only if it's run server-side with node.js.
We're going to use the original JavaScript port of YUI Compressor https://github.com/stoyan/yuicompressor/blob/master/ports/js/cssmin.js
The trouble is that jQuery UI isn't applied when the GridField is used outside of the CMS. I would suggest that you check for its existence (`if(myEl.data('button')) ...`)
Hey carl, Actually the ans.out is correct. 

I will remove the my.ans.out in a moment.

Thank you for notifying us of possible errors!
My question was not if you're positive it worked the way you suggested, I assumed as much. But if it also worked the way I suggested...

I just saw it doesn't. I know you just said something similar to the conclusion I just reached but before testing this for myself, it was still working in my head, what I described in the previous post made sense to me. I had to see why it didn't make sense. My mistake, again, was that I was assuming since this is a library and my app is including this library, that the resources were separate but they are not (I just decompiled the ActionBar example .apk). The styles.xml files from all libraries and the app itself are merged into one.

I though they weren't and so I thought Android could follow some inheritance path picking different folders on the way. This can't happen because they are all merged. I got it now. Makes a lot more sense your solution now, hehehe. One thing to keep in mind if I ever develop a library :)

At least I learned something today, cool :)
On Mon, Jan 16, 2012 at 06:13:28PM -0800, Alastair Porter wrote:
> So just to confirm - unittest2 in <=2.6 provides the same functionality as unittest in 2.7?
Exactly.
Dear Mr. Quarx2k . when i build your cm9 for defy but still got error as below
hardware/ti/omap3/liboverlay/overlay.cpp:21:30: error: hardware/overlay.h: No such file or directory
hardware/ti/omap3/liboverlay/v4l2_utils.c:23:30: error: hardware/overlay.h: No such file or directory
hardware/ti/omap3/liboverlay/overlay.cpp:95: error: field 'device' has incomplete type
i delete the hardware folder and repo sync , there is no  overlay.h still.    could you check if there is overlay.h in system/hardware folder or the build.mk has probelm?

many thanks.

jeff
INSERT INTO playercreateinfo_spell (race, class, spell, note) VALUES (-1, 8, 79684, "Mages - Offensive State (DND) - Enables Arcane Missiles");
and all =)
bezier   - förs t "z" sedan "i"
Yes, I have been burned by the lack of  ==. What a pain :)
Just a note for speed generally, maybe we want to pass around pointers instead of copying vectors all over the place, or return const references.  But it's really not a huge issue, just wanna get it working first
Yeah don't think tab$Res is used again. I wonder if historically process.atlas.nc() came first, and things were copied to make computeAnalytics(), and now some stuff is non-functional -- pseudogenisation? ;) 

The tab object is also created in process.atlas.nc() and this is all written out to the tab-delim file.
probably it's just a metter of preference but can be shorter like:

```java
 return s.replaceAll("( )+", " ")
                .replaceAll("(_)+", "_")
                .trim();
```
Sounds good!

 I'm still unsure about your choice of day order and first_weekday. @allenrabinovich could you tell us if the order of the weekdays array has to be the same in all languages?
Could you simply use `return self.getattr('_fixed_blkmap', super(Plan, self).blkmap)`?
or mw.loader.use
if this throws then you've already added it to camelObjects...
That might work as well. But checking on port should be sufficient.
I tried the following:

  case class Accept(socket: SocketHandle, server: ServerHandle)(val options: Seq[SocketOption]) extends IOMessage {
    def this(socket: SocketHandle, server: ServerHandle) = this(socket, server)(Seq.empty)
  }

But the compiler fails with:


[info] Compiling 1 Scala source to /home/srp/git/akka/akka-actor/target/classes...
[error] /home/srp/git/akka/akka-actor/src/main/scala/akka/actor/IO.scala:254: ambiguous reference to overloaded definition,
[error] both constructor Accept in class Accept of type (socket: akka.actor.IO.SocketHandle, server: akka.actor.IO.ServerHandle)akka.actor.IO.Accept
[error] and  constructor Accept in class Accept of type (socket: akka.actor.IO.SocketHandle, server: akka.actor.IO.ServerHandle)(options: Seq[akka.actor.IO.SocketOption])akka.actor.IO.Accept
[error] match argument types (akka.actor.IO.SocketHandle,akka.actor.IO.ServerHandle)
[error]     def this(socket: SocketHandle, server: ServerHandle) = this(socket, server)(Seq.empty)
[error]                                                            ^
[error] /home/srp/git/akka/akka-actor/src/main/scala/akka/actor/IO.scala:253: ambiguous reference to overloaded definition,
[error] both constructor Accept in class Accept of type (socket: akka.actor.IO.SocketHandle, server: akka.actor.IO.ServerHandle)akka.actor.IO.Accept
[error] and  constructor Accept in class Accept of type (socket: akka.actor.IO.SocketHandle, server: akka.actor.IO.ServerHandle)(options: Seq[akka.actor.IO.SocketOption])akka.actor.IO.Accept
[error] match argument types (akka.actor.IO.SocketHandle,akka.actor.IO.ServerHandle)
[error]   case class Accept(socket: SocketHandle, server: ServerHandle)(val options: Seq[SocketOption]) extends IOMessage {
For each iteration I want to start one member and shutdown one, therefore I shutdown the one that was started in the previous iteration.
Do you see a problem with that? Is there a better way?
oh, good question.  seems like we might have a bunch of failures and start messages.   This is another case of channel missing, so channel in an actor should help.
of course, you’re right, and not only here
I don't think we should add that toString, then log messages will be very confusing, is it "null" or the "NullObject"
Not keeping a reference to the child?
It isn't deeply embedded even at this point, we can rename easily if you have a suggestion?
What would be the expected benefits of a GitPath / SvnPath option? We don't provide neither RsyncPath nor CvsPath, do we? Perhaps we should?

One thing I am worried about in this context is users shooting themselves into the foot:
1) User installs SVN via Fink
2) User runs fink selfupdate-svn for the first time, which sets SvnPath to /sw/bin/svn
3) User removes SVN
4) "fink selfupdate" stops working due to invalid SvnPath.

Similar for git, of course.
To explain how the occurrence rate has been obtained, you can write some lines of comment saying that:

Starting from the input data as defined in the PEER Report:

    magnitude = 6.0
    b_value = -0.9
    slip_rate = 2e-3 # m/year
    rigidity = 3e10 # N/m^2
    fault_length = 25.0 * 1e3 # m
    fault_width = 12.0 * 1e3 # m
    
The total seismic moment rate can be computed as:

    seismic_moment_rate = rigidity * fault_length * fault_width * slip_rate
    
From which we can derived the incremental a value:

    a_incremental = log10(seismic_moment_rate) - (1.5 + b_value) * magnitude - 9.05

and finally the rate:

rate = 10 ** (a_incremental + b_value * magnitude)
Change visibility to package-private
This is an update belongs in update.py
Can we call this guy "organization_admin" or something ? I got a bit confused thinking he was supposed to be a sysadmin. It's still confusing as he's not even an org admin until we make him one in test_05_. He's not actually needed until test_05_ maybe we should just create him at that point.
Seems wise
Same here about not using sys.exit.
We definitely want /var/log/httpd/error_log in this list because it will contain the bootstrap errors. Personally, I always look at that for apache errors too. I just did a quick poke through my ssl_error_log and I don't see any tracebacks, but that might just be my recent activity.

So either replace this with error_log or add a new one for error_log.
can be done in one line
this will need an explicit cast. also, there is no point in not setting these values here. Please always set both dts and pts. However... you must also take into account that AV_NOPTS_VALUE is different from DVD_NOPTS_VALUE. So you must do something like:
if(pPacket->pts == DVD_NOPTS_VALUE)
avpkt.pts = AV_NOPTS_VALUE;
else
avpkt.pts = (int64_t)pPacket->pts
It needs to be 
FileInputStream fin = null;
FileOutputStream fos = null;
would you not expect UDFs to return schema tuples as well? Based on what their output schema is?
This isn't portable to non-Unix, but maybe that doesn't matter.  http://docs.python.org/library/os.html#os.symlink
You should use the full class name here (with namespace).
I think this trick is not required here.  Can be just
if [ "x$2" = "x-f" ]; then
Obviously, this goes for the other uses of this pattern, too.
emm.. then revert it.
This doesn't match the documented default.
This check is fragile, because the struct attributes might change and cause this comparison to break.

There's really no need for it, because invoking this method against an `NSValue` which doesn't actually contain a `CGAffineTransform` is programmer error.
warning: variable ‘nbytes’ set but not used [-Wunused-but-set-variable]
grunt and phantom now needed.
-c option is duplicated.
STYLE: Rename AFNICommandInputSpec
This is actually more of a regression test than a unit test (for #2017). Do you feel that more unit tests for dtype hashing are needed ? Or just to check the flags member value ?
@claudiodsf do we also need to remove the libs in obspy/lib or so they get replaced automatically?
Yeah, you can see this failure happening in forem's travis here: http://travis-ci.org/#!/radar/forem/jobs/1121406

+1 for this change
Ok.  Will do.  I'll make all the changes requested and get back to you when I am done.
Yeah, agreed that AS doesn't look like a proper place.

> Another alternative could be having another gem to share code through AP itself and AC, AD, AV.

How about `AMo`? :smile:
dammit. I will fix this if we decide that #7661 is not an actual solution.
How hard would it be to get exclusive lower bound checking?
Might we use only `blank?`
Please ignore my babbling. `def x: Unit` is the just method I defined.
flat_map is a Ruby 1.9 feature afaik. We are still supporting Ruby 1.8 in Spree.
not a big deal, however an `elif` may better convey the idea of the code
I don' really see an issue with the name, even if it's technically not the only kind of lazy matrix that we have.  I would expect a "lazy matrix" to be exactly this.  Also note that it's possible to express all other kinds of lazy matrices with this class.
again, spaces
On 13.04.2012 05:24, Christopher Smith wrote:
>> +            C = sdm_LM(c)
>> +            if len(set([A[0], B[0], C[0]])) != 1 or not h in [a, b, c]:
>> +                continue
>> +            if monomial_divides(B[1:], monomial_lcm(A[1:], C[1:])):
>> +                remove.add((tuple(a), tuple(c)))
>> +        return [(f, g) for (f, g) in P if (h not in [f, g]) or \
>> +                    ((tuple(f), tuple(g)) not in remove and \
>> +                     (tuple(g), tuple(f)) not in remove)]
>> +
>> +    while P:
>> +        # TODO better data structures!!!
>> +        #print len(P), len(S)
>> +        # Use the "normal selection strategy"
>> +        lcms = [(i, monomial_lcm(sdm_LM(f)[1:], sdm_LM(g)[1:]), sdm_LM(f)[0]) for \
>> +                i, (f, g) in enumerate(P)]
>> +        i = min(lcms, key=lambda x:O((x[0],) + x[1]))[0]
>
> nit: space after the colon, I believe.
>

Sure.
I think "group generated is" instead of "generators are"
Agree, but I would add CAssetManager->publish() wil throw an exception if $forceCopy and $linkAssets are both true
Or maybe not. That might encourage bad tests.
Space between if and paren.
I don't really think that is acceptable... I can dig down but I would suggest to use a critical section for `waiters_count_lock`.
I think the alias {EXTERNAL_HTTP_CREDENTIALS => e} makes the code more confusing - I would prefer the capitalized table name explicitly in the code.
this sentence needs some help. the first use of filesystem is too ambiguous
I think it's probably right/preferable to link to :ref:`write-concern` here, which will reduce the number of hops that users have to make.
Please delete the extra line. there should be one empty line between methods.
The way php works, is that it calls proc_close() on all processes opened with proc_open. proc_close blocks until children are finished. With a server running in an infinite loop that means PHP will never terminate. So you have to do this.

This is also only killing children of the processid of the shell that we earlier opened with proc_open. So there is no risk of killing anything else.
Should be `GPL-2.0` as per http://getcomposer.org/doc/04-schema.md#license
It is still handled the same by use of $is_expr in parse_dynamic_path.
You should still check that this class is present rather than assuming.
Check, exists.
You can just use `$` here, there are no plans to use the `$` variable for anything else, and a modification that uses it would break functionality and be denied.
Please document all parameters.
Massive -1 to that. It is harder to read and uses considerably more resources.

There was an interesting talk in an IRC channel ages ago (I'll see if
I can find it later), where it was described as being almost like the
following:

```javascript
var stuff = ['one'];
stuff.push('two');
stuff.push('three');
```

Instead of `var stuff = ['one', 'two', 'three'];`.

Yes, mods can edit the last line, but it looks horrific and is inefficient.


On 1 May 2012, at 03:50, Oleg Pudeyev
<reply@reply.github.com>
wrote:

>>    el.attr('title', alt_text);
>>    el.text(alt_text);
>> });
>>
>> +/**
>> + * This callback is based on the alt_text callback.
>> + *
>> + * It replaces the current text with the text in the alt-text data attribute,
>> + * and replaces the text in the attribute with the current text so that the
>> + * process can be repeated.
>> + * Additionally it replaces the icon of the link and changes the link itself.
>> + */
>> +phpbb.add_ajax_callback('toggle_subscribe', function() {
>> +    var el = $(this),
>> +        alt_text;
>
> As I think I said in the original ajax pr, each line should have its own var. I do see that you copy pasted this from elsewhere.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/759/files#r754507
ok. +1
I'm going to punt on the loadSync() refactoring.  It's something that is broader than the Resource Store redesign.
va akhare in khat
using statements outside of the namespace declaration.. pff ;)
Interesting. I don't think this is the right place to fix it though. It's the checksum algorithm that's at fault, not the NIMROD loader. It's perfectly valid for a Cube to have non-C-order data.
You should specify the dtype or the int/float array returned by the unpacking or the ```numpy.array()``` call will result in an array of dtype int64/float64.
Inconsistent tabs and spaces.
虽然是Demo，但是把缩进这样的基本coding style搞定应该是一种习惯吧？
demo呢？
Yes, this is obscure. The test is checking that the function passed to scan (called 'fx') is causing the error and does so by inspecting the traceback and checking for the file and function name that raised the error. Because I added the dot() function before calling the Dot op, it means there is one extra traceback layer, so the test has to look one layer further to find the result it's looking for. That's why the index goes up by one. I should change to the comment to reflect that as well.
remove "with"
"compiles a Theano function"
You are absolutely right -- fortunately, the mistake is in my comment and not in my code! Thank you for reading so carefully. Moreover, I believe so far that your earlier comment is correct and I am doing away with the transpose entirely.
OK, it does look like it doesn't call out while holding the lock so it should be safe. I would definitely say it isn't safe to call out while holding the lock.
One line docstring would be enough
Don't do your own transaction management by hand.
Функции, принимающие mutable аргументы — не круто
```py
% (float_number)
```

Note: The parentheses are not required here.
I'm curious why you put tag first instead of ID. I'm open to it but would like to hear an argument for it.
heh, cool
You validate that 'trainingSource' is in the kwargs, but not 'trainingAttrColumn' or 'numAttrs' which can lead to:  ```KeyError: 'trainingAttrColumn'``` when the parameter is not set.
The correct value for lmc_fval is 1. 
The jump array is organized as following. 
1) jump[i] =x represents the value (i -1) will go to the xth node.
2) value 0 means a null value. As the array subscript of pl/pqsql starts from 1, we add 1 to the feature's value.

Therefore, assume that the best attribute for the root node has three distinct values: 1, 2, and 3; and value 1 will go to the second node; value 2 will go to the 3rd node; value 3 will go to the 4th node.
This function is already created by binary logistic regression.
Seems like the Context should be a member of the PythonDatasource?. The shared pointer under the hood I guess should handle this automatically, but why not?
Had to fix this because I changed parse_ua to return a Browser instead of a dict.

We can go further and change the test cases so that the case has a 'useragent' and 'browser' keys with the value of the 'browser' key being a tuple.
Need to pass `--prefix=#{prefix}` to configure, so that things are installed to the correct location.
En fait c'est un bug en cours de résolution. Je l'ai décommenté.
Debug .... A supprimer
Well to my understanding custom exceptions are referred to as custom exceptions unlike code which never is. But I can roll with your suggestion, although I would prefer removing PRAW so it's just "Error classes". Someone doing `help(praw.errors)` probably knows these are error classes belonging to PRAW.
We can change this after we define a naming convention for the logger messages.
Remove the spaces (e.g. `static_cast<uchar>(i)`) for consistency.
Have you read my commit before submitting this change again? I think the blue icon appearing in status bar is enough to indicate new messages. No need to popup each message. I'll change it (again) to update the notification instead of new popup
I need to keep those chars before strip(), and pull them back
Otherwise official whatsapp clients will see &lt and &gt instead of < and >
Consider moving this down closer to where it is used (line 35)
It looks like your formatter re-indented the whole file, which is making it very hard to figure out what's changed.  Can you fix it?  Thanks.
How come these callbacks aren't needed anymore?
Totally not your fault since I didn't give you the actual story to this feature, but can you update all adMob id references to be:
publisherId instead of admobid?

or publisher_id as the case may be.

Also the value to publisherId in AppConfig.js will need to be in " " 
So
adMob: { "publisherId": "312312312312312" }
Creating functions in a loop is certainly legal JavaScript, so I thought I'd Google to see what the Crockford-approved approach is. I was [not let down](http://stackoverflow.com/questions/3037598/how-to-get-around-the-jslint-error-dont-make-functions-within-a-loop)
I think this function is cleaner if you start with "if (!domItem) return null;". Then the usual code path is not indented.
Going by the null or undefined rules here https://zerowing.corp.adobe.com/display/brackets/JSLint+usage.
This works for now, but in DW we had separate strings file for non-localizable strings that was shared across all languages, but not sure if it's worth the effort for us to do that in Brackets.
20 should be in a maxLength variable so it's easier to maintain.
yes, fixing it now
Four pointers passed in, only one tested. Why?
That's arguably not a cosmetic change.. well, it is but in the wrong direction IMO. Why is this good?
As far as I've been told, the reason .get_id exists on couch Document objects is because you can't access an underscored attribute in a django template.  I've seen it elsewhere, but I don't know why one would use get_id instead of _id in Python code.
I'm finding these breakdowns a little hard to understand.

Firstly, I still think My Account Settings and Change My Password should be on a different page since this page is about per-project settings and those settings are global settings, but failing that, I think those two should be under their own section.

Including "User Management" seems overly verbose.  What does "Mobile & Reports User Management" mean?  Users who appear in reports? I propose the following names:

Mobile Workers [or "CommCare Users"]
 - Mobile Workers
 - Groups
 - CloudCare Access [or "CloudCare Settings"] moved from CloudCare Settings > App Access]

Web Users [or "CommCare HQ Users"]
 - Web Users
 - [more added later, like Web User groups]

Project Administration
- ...

My Account
- Settings
- Change Password
Did you make any schema changes? I didn't see any edits to migrations in this pull...
This seems like something you could put in the App Bar. Take a look at how the built-in Music app shows playback options for what I'm thinking about. It just feels like something that doesn't need to be on-screen at all times.
Oh, in this case, for any pending requests, we should also still satisfy the future with the result.
Oho, I see! Fair point, fair point. I'll make that change, or maybe simply rename the variable to `separator`, which is a more functional name anyway.
Create a posts/ directory and place .txt files in it containing your blog posts
we already have the migrators in the hashmap above, so I don't see it necessary. I rather be explicit with what's loaded, although I see how the actual implementation can be a problem if you let people to add new importers because they have to modify the binary too.
Storing the value of `embedSize.value.split` and referencing it will be cleaner and quicker than running this twice.
Well, since we can't edit it yet, it's not really useful for anything, so better left out.
You needn't pass `butter.currentMedia` into `updateTrackEvents`. `_media` is `butter.currentMedia`.
I didn't mean to do this. Going to update it.
Most of these are exploded in this file, actually. So, I fixed the other one I added instead. Good?
I hate to me mean but, can you fix all the styling in thise code you copied over from that speak.js? Just make it like everything else in regards to spacing, double quotes usage, etc.

From line 85 to here.
This is to provide a shortcut, so you can write
```javascript
{renderer: ol.RendererHint.DOM}
```
instead of
```javascript
{renderers: [ol.RendererHint.DOM]}
````
Please add a blank line above this line.
Thank you for pointing this, I already removed it from `ViewTestCase`.
There are fewer than 256 timezones, so a `Uint8` offset into an array would be best (an immutable one if we had those).
Yes.  actually it will work better then v1 because you can specify the importkeys in the 'options' parameter in the REST call to the server.
Can we utilize to_bool? of new class String from src/lib/string.rb on this?
Does it make sense to have this being adjustable? Maybe not, but I am asking just in case.
Ok, I'll try to describe it better. 

 1. `DefaultHubManager` is the center of the universe for everything about discovering hubs and available methods. 
 2. `HubDescriptor` carries an information about the existence of a certain hub. It might or might not be bound to a certain class. It groups a bunch of delegates (`MethodDescriptor`s) under a single name.
 3. `MethodDescriptor` carries an information about some delegate that can be invoked on a given hub. It might or might not be bound to an actual method on hub *object*.

By default, `HubDescriptor` acts as a wrapper for `Type` and `MethodDescriptor` acts as a wrapper for a delegate to `MethodInfo.Invoke`. Decoupling of those gives a possiblity to have `MethodDescriptor`s that do not actually invoke a method on target (but eg. fire some internal event, store call data in the database and so on) - in that case the target hub instance does not need to exist at all.

In the end, the `HubDispatcher` calls the `MethodDescriptor.Invoker` delegate, passing the hub instance (created by the manager) to it. If the instance does not exist (because current `HubDescriptor` does not carry type info) it should be null, instead of throwing an exception.
Here you can use the DNS module API to add the service. If it already exists, it is ignored. Also I would use more specific service name.

```perl
my $service = { service => 'zentyal-remote-desktop',
                            protocol => 'tcp',
                            port => DESKTOP_SERVICE_PORT,
                            priority => 0,
                            weight => 0,
                            target_type => 'domainHost',
                            target => $hostName,
                            readOnly => 1 };
$dnsMod->addService($domainRow, $service);
```
Hey Alex, can I edit the existing request or should I start again?
H


On 4 December 2012 16:35, Alex Torrance <notifications@github.com> wrote:

> In app/views/root/_base.html.erb:
>
> > @@ -106,7 +106,7 @@
> >            </div>
> >
> >            <div class="footer-inside-government">
> > -            <h2>Inside Government</h2>
> > +            <h2><a href="/government/">Inside Government</a></h2>
>
> There shouldn't be a trailing slash here
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/static/pull/143/files#r2308686>.
>
>
The two lines above should be outdented (with "note" capitalized) so they are not part of the example.  Otherwise it looks like this is part of the SExtractor table file.
Yea, it is assumed to only kill outbound and will only call outbound.  The reason there is no type info is because the HO mgr `add_inbound` is called by the handoff listener.  The relevant info is passed to the HO receiver which doesn't communicate with the HO mgr at all.  I've thought about setting up calls between recv and mgr to share this info but not sure yet.
Can you change the default config path outside of /root? I prefer something like /var/haraka/fwd_mx

I just don't like anything that looks like it would by default run under root's account.
I tried to not rename any variables as I understood it makes little sense ^^, but if we have a #define for something we should use it or throw it out alltogether IMHO.
I can check, but I think it's good style to init used arrays or variables, as this creates a clean environment for code relying on that array. What's your oppinion here?
Agreed that the string from the wiki is better. The focus should be on
bitcoin itself, no one cares about the widget toolkit used etc
Just to understand, a lock is persistent in a function scope, right? So when I have a lock in a sub-function used in ConnectSocket it is released, when returning back to ConnectSocket.
Yup don't see the point of adding an extra function call.
So I remember why I disallowed date(). Basically date() would blow up if the 2nd argument passed was a string, it requires an integer unix timestamp. The only solution I can think of is casting $result with strtotime(), but that doesn't seem necessary since the "format" option can be used in the datasource.
There is a better logging setup now, thanks to rkern. Take a look at line 14 of qt_object.py for an example.
\s* might be better... the ':' is the key separator.

I'm curious why there's only support for code reviewer here, while at the command line there are two other reviewers? Let's support the same set of notes in both places.
I tried that, but it becomes too convoluted: it's not having a directory /inst/doc that's deprecated, but rather having Rnw files in it. And testing for that is not amenable to the in_dir() construct you have below...
`open(imgfile, 'rb')`, please.
Read below:

>        # Provide a wrapper for :meth:`InteractiveShellApp.init_gui_pylab`
>        # to ensure that any exception is printed straight to stderr.
>        # Normally _showtraceback associates the reply with an execution,
>        # which means frontends will never draw it, as this exception
>        # is not associated with any execute request.
splitlines, i believe, read the whole docstring which could be long. While StringIO, i presume, only look until it found the first newline.
This could be omitted since it's only used once in the code (on line 41).  Doing so would eliminate 3 more lines (and one blank one).
Drop the `git__` from static functions
I would really like two code paths for this. Don't want to make Vista+
slower because of XP.

XP can possibly stream to file, or maybe even build the request on memory.
On Nov 1, 2012 1:47 PM, "pwkelley" <notifications@github.com> wrote:

> In src/transports/winhttp.c:
>
> > +}
> > +
> > +static int winhttp_stream_write(
> > +	git_smart_subtransport_stream *stream,
> > +	const char *buffer,
> > +	size_t len)
> > +{
> > +	winhttp_stream *s = (winhttp_stream *)stream;
> > +	winhttp_subtransport *t = OWNING_SUBTRANSPORT(s);
> > +	DWORD bytes_written;
> > +
> > +	if (!s->request && winhttp_stream_connect(s) < 0)
> > +		return -1;
> > +
> > +	/* Since we have to write the Content-Length header up front, we're
> > +	 * basically limited to a single call to write() per request. */
>
> Hmm, actually:
> Transfer-Encoding Header
>
> Starting in Windows Vista and Windows Server 2008, WinHttp enables
> applications to perform chunked transfer encoding on data sent to the
> server. When the Transfer-Encoding header is present on the WinHttp
> request, the dwTotalLength parameter in the call to WinHttpSendRequest is
> set to WINHTTP_IGNORE_REQUEST_TOTAL_LENGTH and the application sends the
> entity body in one or more calls to WinHttpWriteData. The lpOptional
> parameter of WinHttpSendRequest must be NULL and the dwOptionLength
> parameter must be zero, otherwise an ERROR_WINHTTP_INVALID_PARAMETER error
> is returned. To terminate the chunked data transfer, the application
> generates a zero length chunk and sends it in the last call to
> WinHttpWriteData.
>
> Sounds like this could be trouble for our Windows XP support, unless we
> buffer the data into a file and then play it back on that platform.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/libgit2/libgit2/pull/1030/files#r2003893>.
>
>
Is it possible to have a count of 1 and enters the if(count.get()>0) then context switch to another thread and decrementAndGet() ==0 which would cause a race condition on result.fail and result.done?
I wasn't sure how well an alpha sort with the non-ascii characters would go. I can give it a try.
If we add a gutter width to the padding here (so 80px instead of 60px) the columns line up better. It's only really noticable on the third block where the text lines up with the sidebar under this box, but it looks more orderly to me.
Errant print?
Also there was an extra `</div>` here.
Should probably be added to the sprite.
How would we cover the following two specific types?

* SubLogic
* Embedding

BTW note that they only apply to Logic translations, whereas the other ones above apply to mappings in general!
do you need to override these?
I finally removed all the `RouteHandler` crap. I don't like it. I'll find a better way.
@stloyd you are confusing the Session object and th Handler object. This method will only be called twice: once when initializing the session, and once when writing it at the end of the request
This is totally wrong. It is a an array of Definition objects. And Symfony does not put ``@var`` phpdoc on private properties
How is this file going to be used?
I think I'm stupid, sorry, there is of course no two-level return in ruby ;)
It's better to user `CPPost *post = [self.selectedVenueFeed.posts objectAtIndex:section];` then casting `(CPPost *)`. Casting is always considered as bad thing and should be avoided.
for now given that the other variables use underscored internal variables can you match that here?
same goes for postPlussingUserIds;
This line should perhaps be modified, now that the warnings are gone.
ino ezafe kardam bara inke mikhastam marker ro add konam
You should differentiate between a user who configured cacti incorrectly (he will want to see that error) vs a user who didn't configure cacti at all (he won't want to see that error).
The ASCII
It could be done, but the shared code is a few lines. Not enough in my opinion to require another class, but I wouldn't be opposed to it.
This has to be defined in the client or else clients will crash when receiving chunks containing this biome
Ah I see. Without that line I couldn't press Q after joining and grabbing an item but had to open the inventory, lift it up and put it down again so I figured it wasn't set
if task is a (const char *) then you don't need the cast
这个是需要的，通过这个获取一个connection
You should not use 
check foo /= Void end
foo.do_something

but rather
check foo /= Void then
    foo.do_something
end

But I encourage you to try avoiding using "check" or "check then end" as much as possible.
however when converting existing code, this is not obvious how to do without this.

in new code (new design), you should avoid those "check then end"
I see no comments added to AS7-5477, not sure what you mean by discussed in great length.  ;)

Regarding combining EE jpa and OSGI enterprise JPA in the same application.  Is that something that other OSGi vendors allow or would that be our unique advantage?
Weird comment. Should inform about WHY styles need to be changed.
I found that I had to explicitly include the madlib schema, e.g.: "<value>madlib.squared_dist_norm1</value>
s/unicode-epsilon/.../
Could we have a base render method in order to share most of code of rendering? thanks
do we need three empty lines in here?
Let's include @basiclines to fix it
nit: spaces after :
Nit: missing trailing semi-colon.
Are we using a 'selected' class for the whole item when we make 'click' on it? Because probably is not aligned with our Building Blocks, when clicking an item (without any Javascript) activates the 'input' behind it... I could fix it in next pull because there are things that we are changing in parallel.
nit: I'll vote for curly brackets since it will make this nested ifs easier to read.
Can you add a comment and make the code clearer a little bit about the result that will be in title :) I will approve after that ;)
Should probably be $(element).val(index+1);
The numbering convention followed by default has the lowest position at 1, not 0.  The stop function has them sorted with 0 at the lowest position.
This should be a code-quoted str literal.
Hmm. I wonder if we just want to leave these out until we add in launch / print info / terminate options, etc.
Razor should probably load these dynamically, based on the chosen engine, rather than statically loading them all.

You can just treat them like any function call in Ruby, so doing in a conditional out of the controller is fairly reasonable.  (Albeit slow; we should try not to put a call to `require` in a hot path.)
I made this change, it's much prettier. Updated the pull request.
cc: @dchelimsky
We still need to make sure we actually have an array here because of the pushing/unshift to grab the callback.
die('not good');
We can work on master now, they're both merged. Can you change this please?
Currently this will also upload videos in all subdirectories of the specified directory. I talked to @mitgoodman and he said this is intended and was requested at the code sprint. I think it's a bad idea as it's unexpected behaviour. Specifying a directory, a user will only expect files at that level to be uploaded. This could turn into a mess if the user has many subdirectories and videos in them. Also, to avoid this behaviour, the user would either need to upload files one-by-one or move the subdirectories outside of the directory.

If we constrain directory uploads to just the specified level and a user wants to upload files in a subdirectory, they can easily select that directory for the next iteration of uploads. @zxiiro @fosslc What do you think?
I actually fixed this earlier today while working on the next ticket. I used a dictionary that had 'git', 'zen', and the association lists as keys and booleans as values that were set to True if the list was successfully compiled and False if it was not. I then replaced all of the checks like the one on this line with calls to that dictionary.
Wrong James :P
Maybe add a small unit test that exercices these assertions?
it would be removed anyways right?
Huh, is that a merge/rebase issue? Same question for the api block in the Post model.
Looks like an extra `=` before the `:=`
I made a quick attempt, having the single chain is not hard and there is no real marriage with MathTransform2D in the streaming renderer code itself, but then Decimator will work only if the source coordinates are 2d, so this is a no-go unless also Decimator is modified... I'll see if I have time to give it a go tomorrow
IMHO init() should do nothing more than initialise the module, so it's more literate to have a method called _setInitialButtonState()_ or simular
so it is at least a bit better
this is not needed, use the composer autoloader. let me know if you need more information.
We had to fix many edge cases for array like constructs in `api-utils/list`. Maybe it's worth subclassing or creating `Class` based version and then sub-classing it instead.
2559c0bb9ea2a0f6e3ef9155dd4e47fcee24d2e7
Yeah do double quotes here, saving the \
What do these numbers do?
Good catch! :)
`comm-central` has this nit too! :)
You should read the code more carefully! :)

Definitely notifying with "pleaseDeRegisterYourself" message would be more understandable:
in `nightly.toggleCompatibility` an observer is registered in every menuItem click ... that should be unregistered! Always.

Of course there are other ways of implementing "Restart on demand". :)
Nit: This should probably end with a period.
I thought about that. I tend not to put line breaks in `<title>`, but I don't have a good reason. I'll do it.
There is absolutely no problem ;)
As above, these could do with some cleanup.
@vrthra can there by multiple 'known' versions? For example if 1.0 is installed, can I have 1.0.1 known and 1.0.2 known? Seems like we would want to always pick the most recent, otherwise, puppet could update to 1.0.1, then the next time it runs, it would see an update is available and update again to 1.0.2. Perhaps sort the known list in descending order of versioncmp?
This is a content license--not a code license. You should pick a code license to release your plugin under.
Do bullets still have owners?
We may want to use:

```ruby
::Object.instance_method(:method).bind(@object).call(@method_name)
```

to avoid problems with folks overriding `#method` (either accidentally or on purpose)
`this_acis_observation` needs to be a string-format obsid, not a list.
s/parts/numParts
const INVALID and INVALID_DATE already in parent : Zend\Validator\Date
Sort this constants with the old first
It's necessary import Traversable and is not longer needed use Zend\Config here.
Are you sure ?I think "call()" proxy the "__call" method.
I would return NULL here, as this seems to be a failure state.
Default SSH keys can also be named `id_dsa{,.pub}`.... (Mine is.)
I always do this typo error too ;-)
The indent here isn't symmetrical.
Update this for entities and when you do, make a flag in HungerComponent to toggle hunger off (or perhaps setting hunger to -1 acts as a disabler).

Better as a flag (think HealthComponent hasInfiniteHealth but that needs to be made a boolean...).
@samiluukkonen Turha funkkarikutsu ku meillä on jo yhtiorow aina kun tätä funkkaria kutsutaan. Lisätään globaaleihin.
does PSR-2 really forbid blank lines between cases ? I don't see anything like this in the spec: https://github.com/pmjones/fig-standards/blob/psr-1-style-guide/proposed/PSR-2-advanced.md#52-switch-case
`Enum.all?(kw, match?({x, _} when x in kw_keywords, &1))` looks great to me as well.
@andrerom The class pointed is actually an *enhanced* copy of the Symfony HttpCache store. I was replying to @noelg, but his comment seems to have been removed
We can. I was actually following suit as with https://github.com/ezsystems/ezp-next/blob/master/eZ/Publish/API/Repository/Values/Content/Query/Criterion/Status.php
l is not an allowed variable name...
Component Matrix for ...
Add a space after your opening ruby tag
action is a required parameter for form, and is required to be non-empty. I know this works, but I've been called on it before. You should just be able to do `action="{{ request.path }}"` if you want to submit to the current URL.
Weird. I don't like that, but I won't die on that hill. Change it if it's easy to change and still grok.
Huh. Didn't realize this one. [Words Reserved for Possible Future Use](https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Reserved_Words)
This was just an automatic reformatting of the code that happened when command + option + L. This way is more readable, let me know if you still want me to change it back
Yeah, `rails_admin` should use an underscore, not a dash. I think it's better to be consistent. If we start using underscores in some places and dashes in others, people may be confused when `gem install rails-admin` doesn't work.
I wonder if this method doesn't need to move into the model, so we don't have to duplicate it.
OK, I understood.
See, if you always prepend URLs with a slash you don't have to do this.
@ehelms No, the wrapper applies its content just by meeting a condition, then it behaves like it isn't wrapped by any extra element (it hasn't any specific selector, just condition).
Why didn't you choose this over System.currentTimeMillis() ?
This probably also doesn't need to run as `sudo()`. Plain `run()` will suffice.
blah blah blah4
Checking for allowSort() here prevents the default bi-directional arrow from showing on columns that do not allow sorting. This check is not required on the other two images as the column will not be sorted if sorting is not allowed. This will also allow the asc/desc arrows to show up if the column is sorted on at initialization, but the user is not allowed to change the sort direction.
are => an?
of ipv maar?
watch your whitespce
Why would using nth-child be flakey?
Same as the above comment related to triple double quotes around docstrings.
This is the same as the "short read" case above (but this one will never trigger).  The two checks should be consolidated.
I'm not actually using that garbage anymore.  Just missed that one reference to it.  Thanks.
this line is kinda long bro :/
Because I have no idea where these VMs are or how to get them working
This `stream` variable doesn't actually exist. Should be `writeStream`.
Could you expand a bit on what the output would be like?
If we pass the response object back, the user has full access to headers, statuscode, body, etc..
I was thinking of something like:

```Javascript
// In oae-tests/rest/..
// when the request returns
RestAPI.Users.getUser = function(ctx, user_id, callback) {
    .., function(err, response, body) {
        if (err) {
            return callback(new RestUtil.OaeError('Something went wrong trying to contact the server: ' + err));
        } else if (response.statusCode !== 200) {
            return callback(new RestUtil.RestError(response.statusCode, 'Could not get the specified user: ' + body));
        }
        parseResponse(body, response, callback);
    }
}

var parseResponse = function(body, response, callback) {
    try {
        var json = JSON.parse(body);
        callback(false, json, response);
    } catch (err) {
         return callback(new RestUtil.OaeError('Couldn\'t parse the response that came back from the server: ' + body));
    }
}
```
All these tests should have a comment block above describing it.
Yes, the aspectj maven plugin does complain that the library version is different that what it expect (1.7.0.RC1 vs 1.6.11?), but 1.6.12 is the latest release.
splitting after the `?` would be better. But well... no need to fix it atm
Done in subsequent commit.
false -> FALSE

Also might be a good idea to just do this and remove lines 235 & 239 (the latter doesn't seem correct anyway - shouldn't `$url` be present in there?):

    while (($tok = strtok($url, '/')) !== FALSE)
Опять же, вижу. =)
Метод есть, его не нужно писать в определении класса, так как он определён у родителя - NSObject. Нам нужно только написать свою имплементацию этого метода.
It would be better to retrieve items in the right order in the first place. This retrieves items and later reverses the list if desc is not blank. I.e. does things twice where once is more than enough.
Agreed.  We should typedef any function signatures that are used as args.
loader是肯定要有的，要用它来加载数据的。然后后面的options确实是用的map destruction啊
好吧...
````python
if dest is None:
    dest=ch
```
我一开始怎么总觉得channel是不带#的...
It will be helpful if you add a comment regarding the usage of the new parameter, setLimit.
Damn, lazy evaluation. Yes, I should have created a scenario in which baseline is None
I chickened out because of having to deal with datatypes. I think making sure alpha is a 64-bit float would also make it alright, but having both np.maximum() calls should be safe (both protect against dividing by zero, and protect that shrink is always >= 0). I'd be surprised if it impacted performance too much since these are row norms (so it's just one comparison per row) for however many times computations are performed on rows. And the time for running the mixed_norm part of the mixed-norm example code was indistinguishable with and without the extra np.maximum() in there.
probably  add a comment here:

run TF-MxNE without time regularization (alpha_time = 0)
I would use a dict

stcs['eeg'] = 
stcs['meg'] = 
stcs['meeg'] =