labofsahil/github-event-dataset-2012 huggingface dataset:
```
  1) App#create_app_instance! Kraken retuns a valid new app_instance sets app_instance_uuid
     Failure/Error: @app.create_app_instance!
     RuntimeError:
       An app_instance_uuid wasn't generated
     # ./app/models/app.rb:65:in `create_app_instance!'
     # ./spec/models/app_spec.rb:17:in `block (4 levels) in <top (required)>'

  2) App#create_app_instance! Kraken retuns a valid new app_instance returns the the app instance
     Failure/Error: response = @app.create_app_instance!
     RuntimeError:
       An app_instance_uuid wasn't generated
     # ./app/models/app.rb:65:in `create_app_instance!'
     # ./spec/models/app_spec.rb:22:in `block (4 levels) in <top (required)>'

  3) App#create_customizations_for_app_instance_attributes creates as many customizations as app instances attributes are specified
     Failure/Error: response = @app.create_customizations_for_app_instance_attributes(@map_app_instance_attrs_to_customizations_names)
     RuntimeError:
       An app_instance_uuid wasn't generated
     # ./app/models/app.rb:65:in `create_app_instance!'
     # ./app/models/app.rb:42:in `create_customizations_for_app_instance_attributes'
     # ./spec/models/app_spec.rb:55:in `block (3 levels) in <top (required)>'

  4) App#create_customizations_for_app_instance_attributes given 'secret_aws_key' already exists rollbacks the stages configuration if one of them fails, passing on the error message
     Failure/Error: response = @app.create_customizations_for_app_instance_attributes(@map_app_instance_attrs_to_customizations_names)
     RuntimeError:
       An app_instance_uuid wasn't generated
     # ./app/models/app.rb:65:in `create_app_instance!'
     # ./app/models/app.rb:42:in `create_customizations_for_app_instance_attributes'
     # ./spec/models/app_spec.rb:70:in `block (4 levels) in <top (required)>'

```
you should say something intellegent if you're going to suppress errors... e.g. "skip this member, keep going". or log the error.
yep, fixed all of these.
This uses a write-access URL, please use a read-only version.
We should have a test for this view probably.
Can you check the indentation here?
Did we intend to remove the copyright?
I see the benefit - man pages are often copied on the internet and they are often very outdated there. So when you are googling information and you land on an old man page in HTML format, you can see the version number there. Those HTML exports does not usually show man creation date. I would love to keep the version number in all our man pages. If you feel it should not be threre, please create a separate deletion pull request and let the team to review it :-)
Of course with the exceptionof  the worst cases ('use base' 20 lines below the package decaration).
hier hätte ich besser 2 statt 1 l geschrieben
A common pattern in JS is to do early return.

      if (!settings)
        return;
Why do you use `object.__setattr__` here?  Can't you just use 
```
self.Om = float(Om)
self.Ode = float(Ode)
```
?
You might want to check with @eteq on this. I'm not sure since I haven't been following the test framework/configuration framework interplay, but I'd want to make sure this won't accidentally affect the user's actual configuration (particularly when running `astropy.test()`).  Maybe it doesn't at all now, but I'm not sure.  There is a possibility do do `with CONESEARCH_DBNAME.temp_set(...):` but you'd have to wrap every test to do that.
Sorry, but one more note.  Reading this `__new__` implementation it already works basically the way I had in mind. But I would do things a bit differently.  I could be wrong here, but I don't think `__new__()` should know about any of the `Coordinates` subclasses (or `SphericalCoordinatesBase` or whatever).  Instead let any registered coordinates classes tell Coordinates whether or not the appropriate arguments were given to create an instance of itself.  That's a little confusing so an example here will help.  This exactly what PyFITS' `_BaseHDU` class does.  PyFITS has classes for every type of HDU supported. Each HDU class is required to have a `match_header()` method, which looks at the supplied header and determines whether that header goes with that HDU class, and returns True if so.  The first class that matches the header is what's instantiated.  See here:  https://github.com/astropy/astropy/blob/35fb693d1a540f223c47528ae9d7fb0fac12bac8/astropy/io/fits/hdu/base.py#L97  (the `_hdu_class_from_header()` function that does the heavy lifting is implemented just above that).

In this case we're not looking at FITS headers, but just the args and kwargs, but the same principle applies.  You could also support checking for multiple matches, and perhaps raise an error in the case of such ambiguities.
What is "wroang"?
I think we should have it in there, because I used it for the upload form in videos#new. Regardless of the styling, we should still use simple_form for the input boxes, right?

Zach/Max, can you confirm?
I'm fine with reverting this change, but would like to know what others think to not revert revert :).
NACK, if anything, tell them to add the ppa and use db4.*++ from there.
I like the first idea, saves a few lines of code and we won't forget to add it (perhaps as another pull or commit for this one?).

I can't comment on the Boost.Thread stuff, but as we include or somewhere else use it (the lib is there), why not ... perhaps main devs can comment here.
You should add the `cake` domain for translation here.
only if its passed - which it isnt here, of course.
Are you thinking something more like this https://gist.github.com/2759713 ?
Just being pedantic but rewriting this `if else` as below makes it a bit more readable :wink: 
```
if ($instance !== null)) {
	$this->_validator = $instance;
} elseif (!$this->_validator) {
	$this->_validator = new ModelValidator($this);
}
```
It would be wiser perhaps to check the actual cause rather then cooking up tests just to make them pass.
no, they need to contain ``@Annotation`` in their phpdoc
I converted this part of the code to a try, except, else block.  Let me know it is better now
true indeed. fixed that to use the classname with \ replaced by _
Is this really supposed to be checking read-timeout?
This should be a category method on NSMutableAttributedString.
Oh true, when I first wrote it I thought you could send a zero length vector to options, but you can't.  Annoying!
This would break gcalcli on anything _except_ a Mac, as @markgraf says. Definitely need a switch.
I don't think  you should try to generate a notebook id if it has none. 
Rename implicitely says that notebook should exist.
Sorry i'll nitpick...
wrong indent level.
spelling and punctuation:

"As of IPython 0.13, images are embedded by default, for compatibility..."
I am sure I missed a few things there are likely bugs and edge cases, I only covered a the case where we have both RDATE and RRULE.
FYI, I'm not sure why all the code from here down looks changed, because I didn't do anything to them.  The original file used tabs before the code and my editor uses tabs as well (not spaces and not tabs converted to spaces)  So I'm not sure why it perceives these lines to be different...
(As you probably know,) this switch is missing symlinks and submodules that should ultimately be supported in checkout. It's probably reasonable to skip both in the initial implementation, but you might consider putting placeholders in as a reminder that they ought to be dealt with, It will make it easier to me to hook in the submodule functionality that I've got in-progress into this code as needed. Also, the symlinks functionality is relatively easy - might be a good starter project for a new hire (or you can just add it when you get a moment).
D'oh! Details... Carry on. :blush:
Your wish == my command
It's probably better to use load-config.sh directly, ie `. $b2g_root/load-config.sh`, rather than `eval` + `grep` :) (ditto below line 65)
You'll need to put it in the 'mobile' bundle as well.
/nit
what value does this intermediate variable provide vs just using `act["meta"]` in your assertion? or even `res.json["meta"]` - the `act` var seems kind of superfluous too
Nit: this line should be shortened to 80 characters or less in width.
`kwargs['config']`
This needs to be unit tested.
weird indentation right there
I've addressed this in this commit: https://github.com/bhouston/three.js/commit/5d70541b3d8b02dfedc911057ae61d22083ea121
I wonder if this is a chance for us to lead, and just pick something that makes sense.  Two type params are bad enough, three is just kooky.
right, fixed now.
Yep, also all those changes must be noted in `UPGRADE` file.
``$expected is unused``
How about `isStarted()`?
I know but the RFC specifies that special values, like 0 (or in IE case, -1) should be handled as well. It is indeed a BC break, as pointed out before, but the only way to pass around this and don't break anything would be to deliver a date in the past, say 2000. If there's any other way that I don't see it, let me know.
Maybe we could leverage `grep` here. For instance if only this option is specified (or with a few others supported by grep), we could completely avoid the call to `find`.
If many options are passed, it should still be possible to use both commands I suppose.
use a ternary operator ?
`notify_fifo` should also be relative to `management_dir`
This was only required because I was converting `major`, `minor`, `patch` to return integers. So if `this.major = 0`, it would fail the test `this.major != null` (would return `true` instead).
I don't see the value of refactoring this.
Ah - that is a matplotlib issue! :-) 
I will see what I can do with that one...
Also, add an interface IConfig that AppConfig implements
On 12/05/2012 03:10 AM, liyangfnst wrote:
> In libvirt/tests/virsh_undefine.py:
>
>>
>>       vm_name = params.get("main_vm","vm1")
>>  -    vm = env.get_vm(params["main_vm"])
>>  -    vm.is_alive()
>>  -    vm.wait_for_login()
>>  -    vm_id = virsh.domid(vm_name).strip()
>>  -    vm_uuid = virsh.domuuid(vm_name).strip()
>>  +    vm = env.get_vm(vm_name)
>>  +    vm_id = vm.get_id()
>>  +    vm_uuid = vm.get_uuid()
>>  +    host_type = virsh.driver()
>>  +    if host_type =="qemu":
>>  +        uri ="qemu+ssh://%s/system"  % local_ip
>>  +    elif host_type =="xen":
>>  +        uri ="xen+ssh://%s/"  % local_ip
>
> You are right,I will make this function in next version of the patch and
> other patches I planned to do.

Cool! I can't wait to see it!

-- 
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
Gotcha. tweaked in 65c1e88.
Brain melt...
This does not belong here. Until we have a better way to customize drop events in the advanced editor area pane; it would be better if this is replaced with
`if getattr(event.mimeData().instance(), 'has_urls', False):`
since the instance() value can be any python object.
Ideally we should integrate PyMimeData with initializing the drag start event so that the event's mimeData is set to the specified PyMimeData, so this check would be made redundant and the drag would integrate with other desktop apps too.
this code is fine now, i will remove the TODO since i found the cause was in the unspecified model of activities
A framework created by the Factory is not automatically initialized, use FRAMEWORK_CREATE
You can't call notify without syncing
I don't fully understand the model operations being done in this createValve method. Is the goal of the global valve feature to allow valves to be made available via (random) jar files existing anywhere on the filesystem, by setting the file/path attributes? Or should the valves be always packaged as a module and be referenced by the classname, module name combination in the valve configuration?

Furthermore, this createValve method here seems to create a valve who class name is "myclass" and this valve seems to be always disabled. Is that what was being expected of this? I don't see a place where the valve is being enabled.
Ah yes. I wasn't aware of that - I've always had dest_dir set because of my preferences - sorry about this issue!

I did try using the getFilename approach earlier this evening but it seemed to slow things down significantly and lead to a lot of crashes. Of course, that could have been due to other issues in my code which were later fixed...

I'll investigate more tomorrow.
"wait for uptil"

upto
там дополнительная логика см.

```
if (replyTitle.trim().isEmpty()) {
            replyTitle = "комментарий";
}
```
Is rule a global?
Please put a confirmation prompt in here like the wireframes ask for since you're turning this on.  Deleting messages actually does work, it's just un-doable on IMAP right now.  (The part that's not implemented is having deletion be a move-to-trash operation.)  So we really want the prompt.
My bad, following up.
This is included twice :)
yes, i wrote pTotal as previous total although is current :)

thanks , today it's the moment for Benzema!!
is that really needed, as now we return directly to the Contacts List
No, because the way that you had the headers, required to change some stuff in edit_mode :S
Changed in this commit:-

https://github.com/skyluc/scalatest/commit/e65ff0a3e09171d123373530363e949418550134
This is the response
This is also backwards for a non-commutative monoid.

PS: Can you add a test of the monoid laws on this using the T = String?  That monoid is not commutative, and it should expose any problems we have there.
these two lines have high potential for reuse as a method
Why doesn't this return a bool?
Same as before, on this line and the next.
The reason I did it this way was to be consistent with the existing code, which defines a generic measurement type for the GAE Entity and does not define any measurement-specific classes. I agree this is a bit of kludge, so I'm happy to take a different approach.

Are you suggesting a collection of measurement-specific classes that are used for specifying measurements (and potentially for other measurement-specific purposes such as data validation) but that are not GAE entities? Or something else?
Why is this `<nav class="skip-to-related">`, but the other cases have `<p class="related-skiplink">` ?
Shouldn't the `<dd>` tags be tight around the content here?
Simplify to a single line.
This version should be controlled in the pluginManagement section of the parent pom.
We dont put vim config in our source code.
Why is `super` called after this and not before, like in `View`?
OK, don't forget to pull our latest codes before you do some changes. :)
Also if you keep http in the chain, if https fails it'd then fallback on http, so that kind of defeats the whole point. I think either we force https (but I know for a fact that this won't work for some people.. that's why we have this chain thing in place) or we try https first, then git and http and try to read the https failures to see if it failed because of MITM (in which case abort) or because of an expected failure (then try next in the chain)?
I think this block can go, the name is included in getNames(), and it's not like you'll check so many packages since you only scan the installed repo.
My bad. Did not read the doc fully. That N is important.

 TupleList2 is a copy of TupleList1 where the first occurrence of Tuple has been removed. I don't really want to remove the subscriber, because I have a monitor set up already. 

Do we want to remove an old subscription and add a new one during each subscription attempt, or should we let the 'DOWN' message do the removal? I think we just want to prevent new subscriptions to be added if one already exists.
not strictly related to galleries but noticed this was wrong after the recent football redesign.
Okay, I think we need to reflect this in the comments somehow.
I just don't like the fact that Rows.new is used inside of Row. I'd like if that would work like other Controls - i can imagine that this would be only possible if somehow uiadll would return a collection of all rows which can be iterated later on. In that case the solution i'm looking for would work.

Nevertheless - i'm merging this now, maybe you or someone else who knows these things technically can come up with better solution.
Why is the ````#initialize```` overridden and ````@hwnd```` evaluated instantly? Use ````Control#hwnd```` instead in ````#select````, ````#selected?```` and ````#row_count````.
again, define variables only in scope where it is needed.
There are bunch geaters here that just proxy to `internal(this).options.propertyName`. Could properties on `options` change ? If not can we just define non-writable / non-configurable properties in the constructor function to avoid all of these proxy-ing would also make code easier to read IMO.
I believe `Pages` is not used anywhere, so you could just have:

    const { Page } = require("sdk/page-worker");
There is missing coma(s)/point(s) in this sentence. May be some verbs too.

    It's very similar to `Object.create`. The only difference is that second argument which 
    is an object containing properties to be defined instead of property descriptor map. 
    The returned value is frozen.
This test needs remained to say something about the user not having a password.
+1, fixing with another commit
ok, removed the property attempt.
Which methods would need a local variable for storing the old length? It would be an improvement and kill one dependency when you do not know which variable really has the current length.
Changed the wording of the docs to reflect this.
I'm not doing regexp inheritance here. This is necessary for Ruby DSL to create the same catalogues as Puppet DSL.
The name will be helpful when the directory wrongly remain even if the process finished.
consider topNeighbors.subList(0, 10) - you can ditch the counter and the hard to follow break
Remove the `@throws` on the docblock too
I'd use byRef here to just remove `$k`
Hey Ralph,

Perhaps you could split up the code in this method to two or three separate ones? Would make it easier to comprehend, maintain. And test.

(also referring to http://www.amazon.com/Clean-Code-Handbook-Software-Craftsmanship/dp/0132350882 )
Can this code go inside of the first if? (line 122)
Warning about Coding Standards:
- ident with 4 spaces
- bad syntax for if look [PSR-2 5.1](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#51-if-elseif-else)

```php
if (is_resource(/* ... */)) {
    /* ... */
} else {
    /* ... */
}
@Maks3w line would be too long otherwise, and the most common way we do exceptions with sprintf() is to have the sprintf() open on the same line as the exception, and arguments on separate lines following.
I was basically following the practice established around the framework. But I can change that back, not sure if it adds any performance hit though
Why Simplelayoutcolorbox?
How is your feature connected to API?
Did you add a way to get tags via API?
The newline at the end of the file was removed...
as an FYI, you need to wrap `$user = $this->get('security.context')->getToken()->getUser()` into parens or `$user` will contain the boolean result of `$this->get('security.context')->getToken()->getUser() && $bundle->isOwnerOrContributor($user)`
I thought we were going to pull this out to a separate file?
oh yeah, that was one too many...

I'll collect the suggested changes and apply them in the next commit
Are nether portals supposed to work in the end or is a bug in Minecraft?
My line comment for some reason got put into into the main discussion; I didn't have to do this when I was making my own formula, what is this line for?
the contents → the content
you should remove this extra line
@stof is there a jira issue or something describing what you want to do? i guess we should do the same with phpcr-odm. i created http://www.doctrine-project.org/jira/browse/PHPCR-71 to track this further - i think we should not block this pull request by it. having the same behaviour over all 3 mappers is definitively better than having diverging behaviour.
(To be clear, this will currently raise a Type error -- I would instead raise the Mongo::OperationFailure.)
This is good, though it's the sphinx way of doing it and in the rest of the code we usually use the google style: http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
spaces around %
Lets avoid using `mozillian_client`
we should rename this method to is_save_button_present.
I'm not sure.  I think it's reset on each run, but I don't know.  @zenspider?
@sferik how's `/radmin`? :metal:
Should prolly move this one out of the try block.
that looks wrong - not sure why, but we should check if it's RIS related.
why this complicated dance? why not just `implicit def camel = …`?
It would be much cleaner if you replace '==' with more strict operator. I understand, this works as expected, but it makes me mad. Why not just use

```
'appendFormat' in params ? params.appendFormat : true;
```
At least in my current testing (as of last night) I slightly adjust the tutorial page layout to fit the full exercise (only when there are the two panels side-by-side). Not sure if you've tried that latest code, as of yet.
Thanks for catching it! :-)
Thanks for the pointer - I reverted that line...
There's no need to create a variable here, it's just used once.
Yes, legacy :) QDBus didn't support direct peer-to-peer connections when this was originally written.

Let's use this implementation for now since it works and has been used in production in Harmattan. I'll rewrite this in QDBus separately.
I don't like that color! D:

(just testing)
Ahh, good call.  I wouldn't worry about changing it then.  We'll wait and see if others agree if the Singleton library should be removed now or not.
Will do.  it can't hurt.
I think this is incorrect--the **children** of a RelativeLayout should have RelativeLayout.LayoutParams, while the RelativeLayout itself should have LayoutParams that correspond to its parent.
We can just use the ctx.user().isGlobalAdmin() function here
This function should check for a valid sectionName and principal_id.
Alright, I'll make it use the uninitialised logger.
I'm still in favor of making limit optional and assign a default value if it hasn't been provided.
Although files like `.DS_Store` should be added to `.gitignore` they can cause this function fail when the type is not checked. I think we should leave this check in.
Yep. Switched to forEach here.
хай цей метод буде protected + додай doc block для нього
will cause it to always return true since most browsers send this by default with every request.
@willdurand Is there any reason why the [GoogleMapsProvider](https://github.com/willdurand/Geocoder/blob/master/src/Geocoder/Provider/GoogleMapsProvider.php#L5) use `preg_match` and not `filter_var`?
Renamed, though ... both look weird to me.
рассчитывается дистация между днк, то есть их различия, а не совпадения
t в комментарии выше - это неотрицательное число. Написал вместо громоздкого "arc4random()%(self.genomeLength-i)", чтобы вам было легче понять, в каком отрезке лежит r.

Читайте это:
https://github.com/Hexlet/osx-project-1/pull/138/files#r2025411
Добавил сравнение с помощью isEqualToArray. DNA у меня объект класса NSMutableArray.
Двумя строками ниже вы удаляете элемент из массива indexes.
Значит на второй и последующих итерациях цикла рандом надо брать не от totalGenes
Looks unused.
Gah, all this swapping users is doing my head in.
I completely agree. It was a quick solution I hoped we could improve together.

This is why I `rescue`d in the first place:
`Unable to find xpath .//table[(./@id = 'Tosp list' or contains(.//caption, 'Tosp list'))] (Capybara::ElementNotFound)`

I tried `rescue ElementNotFound` and `rescue Capybara::ElementNotFound` but both gave me `uninitialized constant ElabsMatchers::Matchers::Capybara::ElementNotFound (NameError)`

Do you know how could we only rescue for ElementNotFound, or we could alternatively do has_xpath, and if true, find. Or is there a non-exception version of `find`?
I think you need to add "be" here otherwise this isn't actually checking anything.
Seems like these three `BOOL`s should have `is…` style getters.
Missing command docs and desc gives you no clue.
To stop php warning on non integer value
I'll take a look right now. I was kinda "ugh" about the original solution too. :)
Instead of "tangent space" I would say "parallel to the cortical surface" to make it less mathematical.
This is listed twice (see line 127). This is unintentional, right?
2012/10/11 Alexandre Gramfort <notifications@github.com>

> In examples/export/plot_raw_to_nitime.py:
>
> > +data_path = sample.data_path('..')
> > +raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
> > +
> > +###############################################################################
> > +# get raw data
> > +raw = Raw(raw_fname)
> > +
> > +# set picks
> > +picks = mne.fiff.pick_types(raw.info, meg=True, eeg=False, eog=False,
> > +                            stim=False, exclude=raw.info['bads'])
> > +
> > +# pick times
> > +start, stop = raw.time_to_index(100, 115)
> > +
> > +# export to nitime using a copy of the data
> > +raw_ts = raw.to_nitime(start=start, stop=stop, picks=picks, copy=True)
>
> if you don't plot anything don't call it plot
>
>
That was actually my quesiton. Do you think we can just demonstrate the
export or shall we look for something plotable?


> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1818018>.
>
>
> i think the clue is to add x-arg funcs to find sources and displace the order-bookkeeping. but wait. the solution is almost obvious. just dont sort anything and do everything with the scores: return unsorted sources get scores for those reorder on plotting using scores (and assume sufficiently aware / informed / users, also tell them) 'the plot visualizes the score sort, component index relative to unsorted sources' get args based on exploration, relative to the still unsorted sources... ... and all should be unmessy. makes sense??

+1

only the plot function does some sorting magic. I like that.
On 12.10.2012, at 10:04, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/evoked.py:
> 
> > @@ -314,6 +314,18 @@ def plot(self, picks=None, unit=True, show=True,
> >          plot_evoked(self, picks=picks, unit=unit, show=show,
> >                      ylim=ylim, proj=proj, xlim=xlim)
> >  
> > +    def to_nitime(self, picks=None):
> > +        """ Export Evoded object to NiTime
> > +        """
> > +        from nitime import TimeSeries
> > +
> > +        if picks is None:
> > +            picks = np.arange(self.data.shape[0])
> > +
> > +        evoked_ts = TimeSeries(self.data[picks], sampling_rate=self.info['sfreq'])
> why not just preload if not allready and then deepcopy? we then could omit the keyword? i can look into this. wdyt, single PR or as byproduct of ica?
> if you copy with a memmap preload how are you going to name the new memmap file if you don't specify it copy?


ok, taken :-)
> —
> Reply to this email directly or view it on GitHub.
>
Ahh you're right that it was like this before, but it seems to be a bug. My point is that if currentName equals newName then this will be set to true, but with the next iteration it may be set back to false, because we didn't stop the iteration. It will result in creating a new name even though the name is there. Try adding one more person name:

< person_name person_name_id="3" preferred="false" person_id="10000" prefix="President" given_name="John" middle_name="Fitzgerald" family_name="Kennedy" creator="1" date_created="2005-01-01 00:00:00.0" voided="false" uuid="d531d4a2d-a97e-4673-80f8-ac8dd5ced083" />

You will have 3 names instead of 2 when running  "patientService.mergePatients(10000, 10001)". Please add such a test.
Bit of an indentation issue here.
same for all other notes
This is not a standard, you need to align all variable names and there description, but not the variable name and a description of another item without a variable name (e.g. `@throws`)
Maybe having `test/unit/*` and `test/unit/*/*` both might help...
Boy-scout rule might be nice in principle, but I have no idea what to document. Shall I start researching?
Сейчас ты просто утверждаешь, что класс должен знать, как с ним будет работать окружающий мир. А не должен. Кто-то в шаред_птр положит, кто-то пэрента передаст. Первый кто-то — ты сегодня, второй — ты через полгода.

И лучше поймать double free, чем утечку.
Es cierto, que nabo. Ese tipo de cosas se pueden corregir rápidamente desde GitHub, ya mismo lo hago yo.
Ah -- I see you have 'String url' as the first parameter of the filter() method in this case.  I imagined that this interface was simply copied over from the previous version of the WPP.  In that version, pre- and post-processors had the same method signature.

Come to think of it, you might want to pass the httpclientt request object (like the first version).  I think there are things in that request someone might want to manipulate besides the URL.  Someone might want to send form fields in a POST, or a JSON payload, and may want to tweak it in a pre-processor.
Nope, Win7/x64 here.
throw error if name is None etc
please keep this space
delete **s**
```false === $structure```
This is easy to do for binding, but for unbinding, there is no such parent class for callbacks, they are extending Stub, but this stub is self generated by SDK for every IPC interface, so I propose letting this as it is for unbind, I have refactored it just for binding.
This doesn't need to return a const ref, it can better return a value IMO.
Please remove. We are OK with this being a 2nd pull request. We just want to have a concise commit history.
this check seem useless since parse_service_instance will call self.die in case of error.
Should `node.kernel.machine` be better expressed as `node['kernel']['machine']` ? I recognize that these are Mash structures, but accessing them in a consistent manner make more sense across the board.
ye ^_^
Nope, I should toss that out...
I meant the name of the Log interface, since now it's doing more than log
messages :)
Instead of calling them 'blacklisted' I'll just call them 'faulty'.
Oh sorry, the CacheLoaderManager is a per-cache component. It is worth considering though if you could not have a global component for MapReduceManager and then retrieve a cache's cache loader as when necessary... not urgent though.
this logic doesn't seem to be directly related to EntryWrapping, wouldn't it make more sense to move it in the StateTrasnferInterceptor?
I wondered that… but then I couldn't find the declaration of `STAssertTrue` which I thought was a bit odd O_O
remove "For"
That's what `/ num_values` is doing. It is calculating the (geometric) average of errors across all pixels, so you have already divided by the number of pixels. To test this, see my all127 vs all128 test, which has an RMS error of exactly 1.0, because all of the pixels have a difference of 1.
Cool, that's very informative, thanks. I've made this change and also fixed the test to check for warnings, then.
@davehunt Thoughts?
Filed #117 about this generally
`Tout le code dans un projet`... Seriously ?
Realized that this could be int, will change that as well.
@bp323 added
@bp323 : I'm inclined to say that we should have a full list of available fl-container-width classes here, otherwise they'll be unreliable for widget developers coming in.
Can you keep these?
`instanceof` will return true for `User` or any subclass of `User`.
Removed it for now. This is part of actions top. It might need it, but we can add it back and comment it if that is that case.
Zdar. Uz jsem vyresil ten problem s assertem a pustil se do toho planovani. A zjistil jsem, ze neco je fatalne spatne. Uz to resim, akorat musim tedka delat chvili rodinneho taxikare. Hadam tak za tri hodiny jdu zase debugovat. Takze 

Zdar! Už jsem vyřešil problémy s assertem a teď dělám to plánování. Zjistil jsem, že je něco fatálně špatně (patrně v tom timeru). Už to řeším, akorát teď musím tak na tři hodiny pryč. Pak se do toho zase dám. Píšu ti to hlavně proto, abys teď třeba zbytečně netrávil čas hledáním chyby u sebe.
how are `vacuum`, `regular` and `force` used?
If we can use `session_cnt` to avoid scanning the whole array, is there any need to maintain both `conn->sessions` and `conn->session_array` any more?  Could we have the hazard validate code scan `session_array` directly and get rid of conn->sessions?

As a general comment, I would feel more confident about this change if we never decrement `session_cnt` -- in other words, if it takes the place of `session_max` from the first commit.
It is non-nullable nowadays.
This should have an extra newline above it.
No, that just means you added a newline at the end of the file, which should've been there in the first place :)
To keep it simple, let's stay with a /24 configuration.
`var i` and `typeof model.clone` save bits
store should be stored
I don't know why I didn't notice this before but can you please spell out boolean.
I don't think that's a behavior we should be encouraging. I think we can come up with a better way to support CDNs so I'd suggest leaving this out for now.
`daisy == this.source` was already checked two lines above.
I don't think that we need to call `html_safe` here. Could you test it?
Can we use a `Set` for this?
can we have a `public final static` field with this and use it everywhere?
minor: What do you think about renaming the `add_element`/`add_data` methods to `add_task`/`add_tasks` or `add_task_data`/`add_tasks_data`?
I would not display errors for missing dependencies for automatically selected dependencies under the later, but they should be listed under initial panel. So if panel A requires panel B which in turn requires panel C, error message should be "Panel A depends on panels B and C, which have been selected."
.some() is available since javascript 1.6 https://developer.mozilla.org/en-US/docs/JavaScript/New_in_JavaScript/1.6. Can't find when it was released and in what implementations it is present.

.some is good becouse when it finds first that matches that predicate it stops, where inArray can only search by value and not function/predicate. jQuery.grep(array, function(element, index)) could replace .some() but with lesser performance. Not that there will be more than a few elements in array :) So do i use grep() instead and count how many results were returned?
```javascript
return grep(array, function) > 0;
```
but still some problem with pymongo
You can combine those two into one line.
Please use the FileSystem tool to put these test files in TEMP
should close a button tag, not install ;)
Why remove `return $this`? Also, why then leave in the documentation for @return?
@jctoledo @alisoncallahan Can we change these URLs so that they are not in the root path for www.bio2rdf.org and bio2rdf.org? It will make them easier to serve from bio2rdf-webapp if they are either in a subpath. Alternatively, they could be hosted by a different server.
It appears we are now checking for the existence of active_entries twice, once here, and then within the request.POST section. With the addition of the code below (outside of request.POST) we probably don't need it inside anymore.

We can probably also simplify that conditional to:
if request.POST.get('do_action') == 'Yes':
missing author Fabrice
Ok, thanks for the clarification. I will implement a single-arg constructor with the -inputFormat as an option.
Sure, give yourself top billing why dontcha? :-)
And what is the difference this ?
https://twitter.com/xuwei_k/status/279531973012254720
Fix Og-vocab to access bundle instead of entity.
Comment still refers to DeleteWhenDone()
Space between "//" and "TODO"
But I think maybe the right fix is for me to add it to `pagespeed_automatic.a` instead of doing it here.
Why is this necessary? I understand what it does, I just don't understand why. :-)
The context structure in Nginx means It could be changed when processing the request. Its lifetime is in a request. It could not be used for all the requests in the same server block.

If you have some similar configures for the same server block. You could use the server configure structure whose value could not be changed after configuration. You can copy or reference its value  to the request context.
I am not a JS expert but it appears in this case async.series is just sufficient as we are not passing rippling down the results. "skip" is anyways a global variable. So would you want to use async.series to be more correct?
wrong indentation (still using the old CS)
len(data) is also invalid here
Why is this synchronized?
Sorry for asking stupid questions: What does this mean?

TinyXML:  I could add a copy of tinyXML within the addon folder if this is feasible. From what I can see in the TinyXML-Docs windows is a supported target platform.
FileCurl: I thought using the internal xbmc-utils would be a good idea, I didn't knew that this was linux specific - again, a stupid question: what would be the windows equivalent?
ok, I can add an IT for that on OSS, FWIW, staging test that and it passed!
It can use hosted, yes, but jetty will be still started up (see JettyEnvironmentBuilder). This is as it was since day 0 of this UT helper class, and to be able to implement what you want (and without manually tamper with repository creation but have the UT do it for you), it would be needed to have deeper changes in AbstractProxyTestEnvironment and/or in JettyEnv builder....

Again, today, even if this UT would use hosted instead of proxy repository, it would not buy much, as Jetty would be still started as part of "env creation".
See note above... I've tried a compromise that avoids the having the params in multiple sorts of nested brackets, at the cost of there being more text in the body.
It may not matter.  But in case that's compiler-specific, I went through at added the std:: to this and other pow's that were missing it.
> The only other thing is that draw() and drawShoot() output ImageView instances.

They output ImageView's, but the user shouldn't ever need to know that.  (At least not for the level of usage being covered here.)  They can be used in the same way that one uses an Image.
Will we have to mirror this on the API side? i.e., shift the property into the V3ConsumerInfo object? Will it still live on the Order object, or will this have to go into the Consumer object/table now?
There are a bunch of places where we probably want these to not be parseInt anymore.
This models.py file is pulled over from master.
Let's just have the submap(Predicate) method here, and for the others I'll find/make suitable predicates.
What is the intent ofisComplete? Can't see it used anywhere.
Would `isEmpty` be a better name?
Should the comment indicate that `exp_date` is expected to be in `mmyy` format?
Why call1?
Please, remember https://github.com/kishiamy/canary_concrete/pull/8#discussion_r886978
Good idea, originally I thought I wanted to override `bid_login_failed` if it already existed in the query string, but then decided that it didn't matter, but didn't reevaluate my choice to reflect that.
you can make this a bit more explicit by doing:

    $sequenceName = $this->platform->supportsSequences())
      ? 'REVISIONS_ID_SEQ'
      : null;
We need to have a name convension before we do that. For instanse, with those functions i would go:

Webinos.Session.getPzp()
Webinos.Session.getPzpId()
Webinos.Session.getPzhId()

Then again i would change the getPzp() to getPzpInstance()

Maybe Webinos.Session is too much... We could say that the session, is the webinos, so that we have:

Webinos.getPzpInstance()
Webinos.getPzpId()
Webinos.getPzhId()

and:

Webinos.rpcHandler...
Webinos.contextManager...

etc
What's the purpose of this? If you want to move the file, you should use git mv. From what I can see, the original FEA_gas_mixture.dm is still present.
Oh, awesome, does this mean no corresponding change has to happen in galaxy?
А этот код зачем?
Similar to `Blind::Games`, this code could probably benefit from a nice DSL. But in the code below you will be able to see how my generalized world objects are meant to be used. The `Blind::Worlds.original` reflects the layout of the world used in Practicing Ruby 2.2
@grails prod run-app@...
の話をいまいち理解していない。prodだと何か最適化されるのかな？
Technically, doesn't this mean that the windows_registry LWRP _is_ deprecated? Also, typo in windows_registry

"The windows_registry LWRP is deprecated, please use the registry_key resource built into Chef-11."
Yes, raise an exception seems better.
..so it would be nice if this could be moved to another package altogether.
make this ``final``
Hmm has PEP8 changed recently? `pep8` does not complain on my box for that file...
I think that the imports above should be at the module level.
I'm sorry, I was wrong. I'll change that. Thanks
I think that you should also fit a linear model, and discuss the differences to illustrate your point.
Maybe you can note that here the manifold learning problem matches fairly well that of representing a flat map of the Earth and link to the following page: http://en.wikipedia.org/wiki/Map_projection
This seems to be done slightly differently than the usual minibatches in `scikit-learn`. I wonder if it affects the speed or anything. Anyway since these minibatches are indirectly implied by the `n_particles`, I think I should read the paper first.

I wonder if it's just me or if it's actually confusing: I ran the RBM before reading the code and noticed that the higher `n_particles` is, the quicker it is, whereas my ignorant intuition was that "using more stuff should take more time".  I commented once before about that parameter and I still argue that it's a particularity of the learning algorithm and not directly of RBMs themselves, so I wouldn't mind having its effect intuitively explained.
This is not really what you want. You want the probability to increase and you can't compute the partition function  usually.
We could do an example with ~5 hidden units and test that. That would actually a good test.

But: (P)CD learning doesn't guarantee increasing the probability of the data set and may diverge.

So I guess plotting the true model probability of the data would be a cool example and we could also test against that.
We only need a function to calculate the partition function ....
si trop
You can forget the __near. The compiler will never be compiled for 16 bit targets again :-)
iirc N_ stands for Native, in this case these are Ti specific values, so the enum name should be changed to TI_PICKER_TYPE
Add assert for obj
couldn't find such fromUtf8 function. What do you mean?
"comes" should not be followed by a plural form. Use `Here come`, or rephrase the "gory details" to a single entity like `the explanation of..`
Nothing more? Should we add Miles at least?
Not used any more.
this is a mutext betweeh remove/rename physical, and is there so that you don't touch the disk while someone else is also doing. This was originally shared between directory's doRemovePhysical and doRenamePhysical, now it's between CRenameAction and this method, where both ended up.
> Wouldn't it be better to use a single implementation for both traits and use return this._public; || this instead?

Not for the readability, also if by some reason light-traits object will have `_public` it will misbehave. In fact there are few exception cases where this is the case. Otherwise sure would make more sense!
`ruby -S` is used to emulate the #! line on a machine that doesn't support it, so it is entirely useless invoked directly on the #! line.

If you wanted to use it to support the "we have sh but not #!" mode of operation on ... no platform I know of ... then I would consider it, but it should be universally applied across the entire suite of tests, not just dropped in on one at random.

Otherwise, the standard batch files, or the local platform, should do the right thing with the invocation.  If you need to create `rspec` as a shell wrapper to invoke Ruby on Windows + whatever, because you are avoiding the standard cmd and bat wrappers, you should work around that locally.
Dans les autres projets, il n'y a pas de spécificité donc je l'ai mis là aussi.
Je sais pas si c'est utilisé pour la prod par contre.
correct spelling fo right in asssert method
@ctweney  ah, shouldn't be an issue once i strip out the userService
It's not necessary to refresh the user data (the profile page has userJSON on initial load as well). If you're worried about cached pages, we could configure profile.jsp so that page is never cached. Re-fetching the profile will only be necessary after the user has made an edit -- if you want to redraw top and left nav, for example.
Not a merge blocker, but it would be good to reformat this file per the usual IDE autolayout, to make it more readable.
elsif ret =~ /denied/
Why not just correct this for the suer rather than returning an error? just drop the TLD for them
Agreed, have removed  dead code throughout this file including lines 50 and 69.
How about ``_subdivision_masks``, perhaps with a comment above about the type of subdivision it implements.
I don' t think you need to `strip` here.
Should we use `clone` or `from` here too?
I like the idea of a `loadXML`, but it may be overkill to have it automatically convert the XML to JSON.  I think it would be fine to have it return the `responseXML` property from the XMLHttpRequest, and then the client (in this case the TMS imagery provider) can use functions like `getElementsByTagName` to query the relevant parts of the XML document.  This is what @tfili did in the WMS provider awhile back (https://github.com/AnalyticalGraphicsInc/cesium/blob/wms/Source/Scene/WebMapServiceTileProvider.js) and it looked like it worked out ok.  This is mostly just a gut feel, though - I can certainly be convinced if you feel strongly about it.

I agree on your edge cases.  The description should override the XML, and a missing XML file should not be an error as long as the description contains the necessary information.
Document exception.

As I asked for tile providers, is `isReady` the best pattern?
@shunter wrote most of this algorithm ;) besides, Isn't that what unit tests are for?
Make `isTipConvex` private to this file, and reuse it here.
Similarly here change to XmlTestContextTests
I believe `getContentResolver` is also available directly from the TiApplication instance.. `getCurrentActivity()` isn't always safe, because it may be null while transitioning between Activities
All platforms are supported, so the platforms directive may be omitted.
Hmm, field isn't being computed in this case. It is a constant that is passed in directly. NPEs are impossible unless someone is deliberately trying to crash it :)
This should really be "When one or more rows are added to the table view".
From the code, looks like milliseconds. But yes, the docs should have the units.
Mobile Web also returns a Boolean.
ashok: I found it's odd that we have this here and it lags the official one by 3 years to begin with...
It's still *true*, but doesn't it belong more in ticket discussion than in a "Won't Fix" list?
Why is this necessary? Is this change just meant to return the StringBundler?
Oddly enough, generally I think it's a bad idea to put docstrings on test functions or test methods. This is if the docstring exists, the test runner will output the docstring text when referring to the test, rather than the full dotted notation test method name. As you might guess, the dotted method name is almost always much more useful information.

Also, generally I prefer """ over ''' for docstrings. This might seem arbitrary, but I actually have a valid reason: Single apostrophes are pretty common in docstring text, while single quotation marks aren't. When you use ''' to delimit the docstring, and there's a single apostrophe in the docstring text, it totally screws up the syntax highlighting in many editors, so that the code is now highlighted as a string and the string constants are highlighted as code.
I think it's worth re-emphasize what z-score is in the last hint. Something like this:

> The z-score is 2.4. In other words, Jessica's score was 2.4 standard deviations above the mean.