[GTK] media/video-duration-known-after-eos.html and media/media-element-play-after-eos.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=83790

Reviewed by Eric Seidel.

Refactor the tests to wait the loadedmetadata event before
starting playback and attempting any access to the duration
attribute. This is an attempt to eliminate flakyness of the tests.

* media/media-element-play-after-eos-expected.txt:
* media/media-element-play-after-eos.html:
* media/video-duration-known-after-eos.html:
* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r126348.
http://trac.webkit.org/changeset/126348
https://bugs.webkit.org/show_bug.cgi?id=94588

We should use v8::String::NewSymbol() for symbols. See
https://bugs.webkit.org/show_bug.cgi?id=94574#c10 for more
details

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Chromium gardeing.

* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Removed.
* platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.png: Removed.
* platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Remove almost all #include "V8Proxy.h"
https://bugs.webkit.org/show_bug.cgi?id=94777

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/v8/NPV8Object.cpp:
* bindings/v8/PageScriptDebugServer.cpp:
* bindings/v8/ScheduledAction.cpp:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptInstance.cpp:
* bindings/v8/ScriptObject.cpp:
* bindings/v8/ScriptRunner.cpp:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8AbstractEventListener.cpp:
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8BindingMacros.h:
(WebCore):
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8EventListener.cpp:
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8LazyEventListener.cpp:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8NPUtils.cpp:
* bindings/v8/V8Proxy.h:
(WebCore):
* bindings/v8/V8Utilities.cpp:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerScriptController.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
* bindings/v8/custom/V8AudioContextCustom.cpp:
* bindings/v8/custom/V8BlobCustom.cpp:
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8ClipboardCustom.cpp:
* bindings/v8/custom/V8ConsoleCustom.cpp:
* bindings/v8/custom/V8CoordinatesCustom.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
* bindings/v8/custom/V8DataViewCustom.cpp:
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
* bindings/v8/custom/V8EntryCustom.cpp:
* bindings/v8/custom/V8EntrySyncCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
* bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLOutputElementCustom.cpp:
* bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8HistoryCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
* bindings/v8/custom/V8IntentConstructor.cpp:
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8MessagePortCustom.cpp:
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
* bindings/v8/custom/V8MutationObserverCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NodeCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8NotificationCustom.cpp:
* bindings/v8/custom/V8PopStateEventCustom.cpp:
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
* bindings/v8/custom/V8StorageCustom.cpp:
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
* bindings/v8/custom/V8TrackEventCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8WebKitAnimationCustom.cpp:
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* bindings/v8/custom/V8WorkerCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

After the TextTrackCue constructor was updated in r126350 the
expected constructor length is 3. Updating fast/js/constructor-length.html
to reflect that.

* fast/js/constructor-length.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Use vertical slider theme when the slider is vertical
https://bugs.webkit.org/show_bug.cgi?id=93838

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Applied vertical slider theme to the vertical sliders. The height
of the vertical slider is wrong when it's applied horizontal
slider theme.

And do not resize slider when its size is not specified. It's natural
to use the default value of renderer.

No new tests. It's covered by existing range and datalist tests.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):

LayoutTests:

Updated expected result because theme of the slider is changed.

The size of the renderSlider is changed to 129x12 from 129x11
because it has the slider thumb 12x12 and it is not resized when
the size is not specified.

* platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.png:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
* platform/efl/fast/forms/input-appearance-height-expected.png:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/range/input-appearance-range-expected.png:
* platform/efl/fast/forms/range/input-appearance-range-expected.txt:
* platform/efl/fast/forms/range/slider-padding-expected.png:
* platform/efl/fast/forms/range/slider-padding-expected.txt:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Adding myself to committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Added missing SKIP keyword to platform/efl/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=94781

Unreviewed. Some layout tests which are expected missing should not make
expected result files during layout test.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

A follow-up to r126400, updating various baselines for fast/js/constructor-length.html
so they are correct.

* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: treat 0 cookies as "no cookies" and render it accordingly in the UI
https://bugs.webkit.org/show_bug.cgi?id=94732

Reviewed by Yury Semikhatsky.

* inspector/front-end/RequestCookiesView.js:
(WebInspector.RequestCookiesView.prototype.get _gotCookies):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WK2] Refactoring: WebBackForwardList getters should be const
https://bugs.webkit.org/show_bug.cgi?id=94711

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Before the change were not consistent with each other
(WebBackForwardList::entries() was const but WebBackForwardList::currentIndex() was not).
Besides having not const getters is not a good practice in C++. (Please read
Scott Meyers. Effective C++ (3rd edition). ISBN: 0-321-33487-6.
Item 3: 'Use const whenever possible').

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
* UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::currentIndex):
(WebBackForwardList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Build fix for r126399.

* bindings/v8/ScriptInstance.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Chromium gardeing.

* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Gardening after r126350
https://bugs.webkit.org/show_bug.cgi?id=94787

Unreviewed gardening.

Gardening of media/track/track-cue-rendering-snap-to-lines-not-set.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-08-23  Dominic Cooney  <dominicc@chromium.org>

        [Chromium] Unreviewed gardening.

        notifications-event-listener-crash.html test has non-deterministic
        output on Chromium XP debug.

        * platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Chromium gardeing.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] draw <video> on <canvas> does not work
https://bugs.webkit.org/show_bug.cgi?id=94791
PR #195866

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-23
Reviewed by George Staikos.

Re-implement MediaPlayerPrivate::paintCurrentFrameInContext() in the
blackberry port. This method is mainly called from <canvas>, and it
is supposed to paint video frames using software rendering path.

On the other hand, MediaPlayerPrivate::paint() will choose accelerated
rendering if possible.

media/video-canvas-alpha.html covers this.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::paint):
(WebCore):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: [WebGL] Allow collecting calls for Resource objects affecting their states
https://bugs.webkit.org/show_bug.cgi?id=94686

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-23
Reviewed by Pavel Feldman.

Allow collecting calls for WebGL Resource objects affecting their states.
Clone Call's mutable arguments before pushing it to the log.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r126391.
http://trac.webkit.org/changeset/126391
https://bugs.webkit.org/show_bug.cgi?id=94302

Breaks Chromium browser_tests AccessibilityFooter,
AccessibilityListMarkers, AccessibilityUI

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):

LayoutTests:

* accessibility/editable-webarea-context-menu-point.html:
* accessibility/focusable-div-expected.txt: Removed.
* accessibility/focusable-div.html: Removed.
* accessibility/table-detection.html:
* platform/mac/accessibility/listbox-hit-test.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebInspector: unreviewed single line test fix.

The test has to open profiles panel explicitly because it is creating lazily.

* inspector/heap-snapshot-performance-test.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126415 268f45cc-cd09-0410-ab3c-d52691b4dbfc