labofsahil/github-event-dataset-2012 huggingface dataset:
It's a work-in-progress branch. I'll rebase it onto master when I've fixed some of the formatting/spelling mistakes.
private? It's set by the constructor.
This is when you wish you could just hang stuff on Object... Smalltalk, Ruby, Obj-C, anyone?
@jmikola you cannot have 2 interfaces containing the same method.
:+1: :cool: :+1:
I think they most use Settings.LOCK_HOME_IN_MEMORY rather than the string directly...
I was just testing, the crash was fixed in TC, i have not ported it yet to SF
I just noticed this when vendoring Thor in client side engineyard gem (for rubinius support that Yehuda has still not released): You deleted the LICENSE files from the vendored gems. I know you just removed them mistakenly but those must stay with the work. This is someone elses copyrighted work after all (and I know a few things about accidentally ignoring licenses, unfortunately)
add your device spesific name here :)
frankly speaking i cannot see the correlation with UI design and the red carpets or the red pack. anyway, thanks @sunner for the commit, that seems to be the best solution to come with :)
more { to fix in this file..
This is to add in the transmission plugin the ability to process a script after a torrent is finished downloading.  It adds two fields at the bottom of the page of the Server tab.
hi jerry, i like your customize, but why this use com.cyanogenmod.cmbootanimation? not com.cyanogenmod.cmparts.activities?

thanks :)
Ok, pushed changes from my other computer, forgot to change my default username on that.
But it was me who pushed the changes... ;-)
CyanogenDefy is not ready for ics...
use tpruvot or my repo
Yep, that commands.mm change looks good - note that the problem exists because upstream has been using the *10.4* SDK, not the 10.5/10.6 one.  The broken code path is for when kCFCoreFoundationVersionNumber10_5 exists.  Consider upstreaming it?
What fold? I thought you are talking about completion.
OMFG!?!
that was it??

will test it as soon I test your camera patcehs
Again, a not very helpful short description.
С какой целью эта функция может принимать аргументы `nodes` и `children`?
Yes, and I thought I had removed all debug code :(
Can you include a URL or a cherry-pick sha1 from popppler repo that shows where this came from?
I would rather use `@unittest.skipIf` here. You can decorate a class with if as well.
Should we also use $('.pageIcon', box) and $('#pages', box) to find elements?
Its just going to generate a lot of noise in the logs for minimal benefit (anyone testing can see the status code)
Wont the name change break scripts which already implement this function? Or are there any?
Might be cheaper with a VectorBuilder
I have fixed this, for the cluster tests, initialParticipants are by default same as number of registered roles, https://github.com/akka/akka/commit/56735477b8758c51ed762629ca1afac7dcbbb96d
if AkkaProtocolSettings would assume to get an appropriately selected sub-config (i.e. `conf.getConfig("akka.remoting")` in the normal case), that would make configuration even more flexible, right?
rename exitValueOrKill -> exitValue
He had sent me that and I pulled it in. In Master it is different https://github.com/akka/akka/blob/master/akka-cluster/src/main/scala/akka/cluster/Cluster.scala But I know after the pull the NPE's went away. I'll look into it.
In principle, why not? However, I did it this way (two apply(String) methods), because it was (and is) still sd
I think it can make a difference when adding or removing nodes, as rangeImpl is probably a lot more costly than get
Thank you for the relief, I promise to be a good Boy Scout!
It's probably nothing, but I'm just not sure if doing that won't have an impact in some codepath later on, and little changes like these are the worst to track down. If you could change this bit, I'll be happy to merge the patch.
Don't use `from foo import bar` (even though there are still lots of examples of it throughout CKAN), see: http://docs.ckan.org/en/latest/coding-standards.html#imports
An unbinding is defined in the docstring not shown here in the diff and is a dict of: type_id and repo_id.  Basically the data needed by the agent to unbind a binding.  A list of these are passed to the agent in the RMI call.
Just confirming that this is intended to be a no-op, maybe to be implemented later?
I haven't had time to go through all the code yet but I'm guessing this is to handle methods bound to an object? Would it perhaps make sense to use that naming instead? If handler is more accurate thats fine, just something which popped in when I was reading
uiBufSize? everything is always written right?
верни этот декоратор. Он всегда для этого вида нужен получается
sky_content_type doesn't exist anymore -- we should remove this addition.
Really weird indentation.
I added the explicit type stuff, can you pull and see if it resolves the problem in eclipse?
I don't like relying on too many vars. I would put count and lastTry in the constructor. tryAgain could return a new instance of try with the values updated.
if regexp doesn't have capturing groups token should be string instead of array
Hm. The registration is done to a dedicated actor  
(Remoting.transportSupervisor) that has no other job. Maybe I should  
allocate a dispatcher for that one? If I am not allowed to use Await here  
this can become terribly complicated. Do you have a better idea? I would  
be happy to get rid of this.
Might be clearer that way yes, though in this case it would result in the
same thing i believe.
The same check is run in the processedmetrics module and there won't be any
timer_data  if there aren't any timers.

Thanks for the feedback.

-Dan
On Sat, Oct 13, 2012 at 1:22 AM, Daniel Schauenberg <
notifications@github.com> wrote:

> In backends/graphite.js:
>
> >
> >    for (key in counters) {
> > -    var value = counters[key];
> > -    var valuePerSecond = value / (flushInterval / 1000); // calculate "per second" rate
> > -
> > -    statString += 'stats.'        + key + ' ' + valuePerSecond + ' ' + ts + "\n";
> > -    statString += 'stats_counts.' + key + ' ' + value          + ' ' + ts + "\n";
> > +    statString += 'stats.' + key + ' ' + counter_rates[key] + ' ' + ts + "\n";
> > +    statString += 'stats_counts.' + key + ' ' + counters[key] + ' ' + ts + "\n";
> >
> >      numStats += 1;
> >    }
> >
> >    for (key in timers) {
> >      if (timers[key].length > 0) {
>
> shouldn't this be for (key in timer_data) and if (timer_data[key].length
> > 0)?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/etsy/statsd/pull/167/files#r1835532>.
>
>
Can you add a comment showing what this is supposed to do? Someone unfamiliar with `TUITextEditor` might be confused as to what this is for.
This horizontal rule is unnecessary.
Ah, no, I missed porting over the condition from the original assertion. Will fix that now.
Since the process methods use ref float, I'd prefer to use ref float here as well.  That would also allow us to remove destOffset, which would feel more like the C version.
It has

http://conjugator.reverso.net/conjugation-english-verb-have.html
I guess this could be static final ?
The docs should assume that the reader has no idea why there would be any problem with writing `a[indices] += 1`, and explain.

It might also be useful to contrast with `ufunc(a[indices], *args, out=a[indices])` (which for fancy indexing doesn't work at all, but again it's not necessarily obvious why), or `a[indices] = ufunc(a[indices], *args)`.
Mention the "experimental" label here? Or not mention datetime as a highlight? It was a highlight in 1.4.0 and 1.6.0 too, which is more than a little embarrassing.
An empty line is needed after the first line. The first line may also read sth like: "Blast search PDB and download hits.", because after refactoring the function is not special to command line program.
Do you need to set the cache_store to :dalli_store? Why the gem doesn't do that automatically?
Sorry, when I was testing this I was not at the newest 3-2-stable and without this line one of `mime_responders` tests was failing. It's not needed now, I'll remove it.
Please, use 1.9 hash syntax. Thanks :)
I think a `case` statement, pretty much as the other in line 586 that you changed, would come in handy here.
Exposing magic numbers (4-15) is hard on the user, who has to google to figure out what they mean. In normal use, why is someone changing the cost? How would they decide which cost?

This is a better fit for `BCrypt::Engine.calibrate(1000)` which returns the cost whose computation time has an upper bound of 1000ms. Thinking in terms of "how long should it take to check a password?" is easier on people than "what should I set this magic constant to?"
Since this is for backward compatibility I would extract it to a method if a meaningful name.
Shouldn't it really be looking for the string under `:"#{@base.class.i18n_scope}.errors"` (activerecord/activemodel) namespace first (just like it is done for validation error messages)?

Additionally, this doesn't allow us to set different message formats for fields with the same name in different models. Should it support that? Maybe this syntax would be additional fallback? Basically we could have defaults array that's similar to the one constructed in [ActiveModel::Errors#generate_message](https://github.com/rails/rails/blob/2e4f7986b8ec90d7b41c385388be21b8cee79b9c/activemodel/lib/active_model/errors.rb#L393).

Or maybe I should do another pull request to add these things :)

Thoughts?
`@see [[scala.collection.generic.FromRepr]]`
This will throw an exception if it is not a success and default throws an exception.
Oh, you mean you want to terminate early.  That's easy enough.
Thanks.   This is helpful.     In just trying to get something to work, I was just mirroring the code that was there (from 1999).    I'm not sure if it's the best use of time or not, but I agree it's better to define a structure like this.   I'm changing all the code to reflect this style.
201 is for a created status. Result here should be 200. No need for render call at all.
nit: if (
I don't think you can rely on the result of ```python --version```:

```
$ ./bin/doctest
Traceback (most recent call last):
  File "./bin/doctest", line 57, in <module>
    "blacklist": blacklist, "normal": options.normal, "subprocess": options.subprocess})
  File "/home/jacobi/jrioux/git/sympy-jrioux/sympy/utilities/runtests.py", line 513, in doctest
    function_args=paths, function_kwargs=kwargs)
  File "/home/jacobi/jrioux/git/sympy-jrioux/sympy/utilities/runtests.py", line 202, in run_in_subprocess_with_hash_randomization
    if int(version[2]) == 7 and int(version[4]) < 3:
IndexError: string index out of range
$ python -V
Python 2.7
```
>
>
> I certainly think that we should use an unordered structure (frozenset or
> dict), but as long as we support `Add(2, 2, evaluate=False)`, we can't .
>
>
Unless we store it like `set(dummies), replacements` so `Add(2, 2,
evaluate=False)` gets stored as `set([d1, d2]), {d1: 2, d2:2}`.
I'm worried about delta being passed in here from the frame function. Each tween should have its own start time, but with this implementation it looks like all children share the start time during the render loop?

Maybe I am not fully grasping the frame function trickery going on here.
missing dashes (the length should match the title length)
double use.
I'm inclined to limit the explination of this behavior right here because it can confuse, and this is meant to be a "quickstart" guide and not terribly detailed. 

Do you know if the logrotate by default is windows specific or across all platforms? I think we should **definitely** sync up tomorrow to make sure the documentation will reflect this change.
largely irrelevant?
Same NS... rule as above.
I'm not sure if we've standardized on any form of syntax for this; I'd write the first, personally. For whatever that's worth.
So for dates I think we should support any of the three characters as separators.. that 'word' of the date will be split based on the Parser separator, so whatever the word is we have we should support splitting it based on one of '.' '-' or '/'
Space after foreach.
Another thing you can do is determine which posts have excess revisions with the help of group by: select post.id, count(revisions.id) from posts, revisions where post_id=revision_id group by post.id. Then for those posts that need pruning maybe fetch all revisions in one query. If you do this you can fetch all revisions only without joining posts, restricting by post_id.
Not sure why half of your comments have words that start with capital letters out of nowhere? Also see "Root path" and "PHP Extension" below this line.
You might want to actually access the language variable here, rather than hardcode english text, so that the test will still work if language is changed.
Is there some issue/problem that you are trying to address by this? Simply specify whichever format is needed in the caller.
Yeah, but don't the tests listen to ConnectionStream, not ConnectionMessages?
Move this import to the beginning of the file. No need to do it in here, especially inside a loop.
Sesiunea este server-side.Acolo sunt salvate si informatiile despre userul curent ce este logat de acceea cred ca este destul de sigura
这个可以删除了
fine for now, but FYI we are going to need to better abstract this kind of formatting into our CSS (rather than having it in the code, where it's likely to be thinly spread throughout the code)
Can use Util.DateTime(Util.getUTCTimeDiff()) here
The "if block" here is just a VERY minor variation of the else block. Instead of duplicating code set a local "bool isMulti = ! m_index->isUniqueIndex();"
and use it to make the "else block" code serve both cases -- you don't even need any additional "if" statements.
Yes, you are right. Change it when it supports "select Count(*) where id < ?" query.
All this cloning and clearing could be eliminated by just using separate first and second variables and calling to "new" between uses.
Keep your code simple and clean and let the garbage collector do its work.
He/She/It IS

This class tests, adds, edits, and deletes ...
Shouldn't this be {% url opts|admin_urlname:'change' object.pk %} instead?
If we are going to start using `@doc` and `-spec` in our api modules (which I think is a grand idea) then we should consistently use them. It'd be nice to have them for the functions in this module.
Might just credit Jeff-the-person not his django branch?
I think I forsee another test tautology in our future. heh. -.-v
@rwldrn we were - I just was wondering if it made sense / was readable.

@dmethvin also - use case wise... If I was implementing a complete animation override, I still need to add a `timer` function to hook into `stop`
the method is getting messy
For the hash table rationale, I know that there is a lot of objects you want to cache, but in most of the case it's almost empty.  I'm just afraid it's too expensive for simple functions.
It can be quite noticable -- especially if the element is not included:
```python
In [1]: l = map(str, list(xrange(100)))
In [2]: s = set(l)
In [3]: %timeit "a" in l
%100000 loops, best of 3: 4.32 us per loop
In [4]: %timeit "a" in s
10000000 loops, best of 3: 166 ns per loop
```
Compare against ``order.lower()`` in case we have "stupid" dbus clients?
Will this code globally modify whatever instance I passed in with the key ``''``?
And done. 

Required modifications made, committed and pushed.
I have no faith in a patch that so obviously was a global find/replace. No reason to change this comment.
I ran into this exact problem today when writing a duplicate for libpng 1.2.   I ended up running "make test" in the install phase, copying the two test files into "#{prefix}/etc", and then writing a test routine that used those saved test files: https://github.com/staticfloat/homebrew/commit/dc8fc9413125d388ab25f6416e7c5a8ac5daaa4f
Need a stable (versioned) URL
I copied that from original pull-request, didn't give a specific though to it ? do you want it back ?
Went with :HEAD.
First entry should use `repouser` rather than `$1`, right? ;)

Also, I think the third entry would read better if we assign it to a variable first and then use the variable:

```ruby
url = ARGV[1] || "https://www.github.com/#{repouser}/homebrew-#{$3}"
[repouser, $3, url]
```
Above should achieve that, if you pass a `/` you’ll get `./` in response. Which should work right? My data should go to the relative root of the wiki?
This should be an exception with a message that subclasses InvalidOption

    class InvalidCartridgeType < InvalidOption
         def initialize(cart_type)
         def to_s
             message...
    end

    raise InvalidCartridgeType.new(cart_type) if carts.empty?
Because I check if the HTML is properly escaped. The normalString tests check if a normal string is not affected by it.
If someone actually blanks out their description, I think we should respect that, rather than using something else.  But, I don't think that's a big enough deal for now.  Merging.
Maybe too verbose with little extra added debug value?
^Return the submission object this comment belongs to.
I think this section does a good job of walking a fine line between too little information and bogging the user down with a ton of verbiage. I feel like there should be a description of what would go in a consumer certificate if they wanted to roll their own solution, but that's well outside of the scope of the 2.0 release. In fact, given the complexity of generating those certificates, I'd rather just wait until someone asks us for it.
About 'widths' name: I'm just sticking with the R name.  I would have preferred to call it 'colspecs', as in "Column Specifications."  I can rename it.

About widths vs. intervals. In format specs, it's way more common to see intervals than widths. Actually, I don't think I've ever come across widths anywhere, and also, there's no guarantee that the columns are stacked against each other, i.e. intervals are more flexible because they can skip columns. 

I think we may want a conversion function from 1-indexed to 0-indexed, since it's so much more common.
Ja, gern. Es gibt dabei auch keine BC Probleme, da der formattype "filesize" erst in R5 von Robert hinzugefügt wurde.
why not use the approach described in #146? I think calling `cabbage-bundle-active-p` makes the code more readable and cabbage centric.
Reordered in bad5cdf1a4cbff033234a4ed7f0a3d696abed083
Unfortunately I'm not sure that type name can be looked up via the processing env. This new method is only used to reference classes being injected into or module names, never the types being injected so we shouldn't ever need to reference an exotic type like that.
Unnecessary comment?
Can't the results of getElementsAnnotatedWith() change between the first cycle and the last cycle? Shouldn't we only ask this at the very end? Otherwise generated modules could be missed?
Just use CodeGen#rawTypeToString ?
List spec arguments and wether they are optional or not

```
 @param spec {cfg [, size] [, interval] }
```
why indent this `=` so far?
OK with allOf if it compiles here.
javax _before_ java?  Is that common?
Style guide says we should always use double quotes.  I know it makes it less readable in this case, but OTOH we just accepter a pull request a sprint or two ago to clean this up throughout the code... so it may be better to just be consistent here.
I don't think we can match the base class function in InlineWidget. This is a different function to clean up Garth's data _colorPickers and it does get called. If I changed it to onChanged() as in your suggestion, then we got rendering issue in main editor -- the area where the inline editor pops up becomes a blank area.
Since we test both directions in the middle, should we also test hitting right when cursor is at the left edge, and vice versa?
Can you explain to me why you need to know the window focus to fix this?
Can this be replaced with the more idiomatic `if args and hasattr(webdriver, args[0].capitalize()):`?
The information about how many indent characters are used will need to be available. The `indent` function in source-package.js holds the information about how many characters the code will be indented. Should that be changed to an exported global so we can see it elsewhere, or is there a better way to handle it?
LGTM, but names such as ProbabilisticEventBasedAssetOutput are really too long. Since the output is always per asset I would use
ProbabilisticEventBasedOutput. Idem for the other output classes.
We retrieve the function manager twice in two lines... That don't seem to be a free operation, so we may use an intermediate variable here...
This looks reasonable, though it seems like there ought to be a better way to dig deeply into a nested hash of arrays of hashes...good enough for now.
Yes. I also found this only when through the source code. It is really badly written in the documentation (this makes me think - we should open a ticket on Django for this, I will do it). But I don't ignore things but investigate them. ;-)
No `error` method. Have you even tried forms with out of the bounds values?
Then I should only check for `datetime.date`. Because datetime.datetime is instance of datetime.date and hence only checking against `datetime.date` is needed.

`isinstance(self.upper_limit, (datetime.datetime, datetime.date))` is no different from `isinstance(self.upper_limit, datetime.date)`. I am only allowing `datetime.datetime` because that way I am sure what type of object I am dealing with.
Why just do not move this to the string bellow?

`"https://www.facebook.com/dialog/oauth?%(args)s"`
please add newlines at the end of the files :D
As above for docstring and wait.
Actually, can you move all these to the top?
This will retain `px` on the end of these values, correct?
these comments still stand
Instead of doing this and using querySelectorAll for button above, we can probably use document.getElementsByClassName( "done-button" ); and the same for cancel button.  getElementsByClassName returns an array of elements which have the given class.
There is a ticket in Popcorn to get rid of In and Out and make them Start and End, so we can probably get rid of this and just do a submodule update
I think we need it for now, since not including http will cause an error
whitespace between if and (
Maybe a generic optimize flag then?  It seems wasteful to iterate over the whole queue if it's not needed.
You could do `unless block_given?` instead. Otherwise you need the `&block` arg on line 128.
the above line might be rewritten as:

-            v->data = p + 1;

-            for (p = p + 1; p < last; p++) {
+           for (v->data = ++p; p < last; p++) {
查找Set-Cookie头和相应的cookie的处理可以搞成一个函数，感觉跟insert模式也有点重复。
The url can be send as a parameter in the url. But that can be fixed in a followup.
I think I see where you are going. I'll try it.
Can you please add
add_index(:custom_info, [:informable_type, :informable_id, :value], :unique => true)

and yes, I think index for keyname would be used as well.
You may run Katello with SQL loggin on DEBUG and see which SQL queries are run with custom_info and the add appropriate indexes.
These should not be here in the upstream project.
I think this was not intended
nit:

return Buffer.isBuffer(value) ? value : new Buffer(value, this.encodingName)

but yours is equally (if not more) readable.

FWIW, I also don't really like function terminal else blocks and prefer:

if (Buffer.isBuffer(value)) {
  return value;
}
return new Buffer(value, this.encodingName);

But totally up to you and your style.
Can't this be rewritten as `if decimal_mark == decimal_char`
See 87dfed4 and a0440ba
This should probably be an ERB comment as opposed to an HTML comment so it doesn't appear in the output.
Ok I'll handle this when I merge.
That explicit destructor isn't really necessary anymore.
Why was this moved to outside of all the if statements, and why the addition of the if statement here? Rebase error?
I like the idea to have bitmasks to handle error codes btw.
This looks like it would be better suited as an integration test (cucumber).
A better architecture for this widget may be to use a plain QFrame with a QSingleWidgetLayout to hold the traits widget `ui.control`. This will allow us to easily change the widget at runtime if the model/view/controller changes and the minimum/maximum size computation will be handled automatically.
Account key isn't necessary for characters; we shouldn't accept it.
I think `path`, `auth` (or `user`,  `pwd`), `destdir` would be a better argument list.  And I'd probably call it `spider_svn`
Ah, OK. I got confused b/c there was a `TestCase` subclass in there, which I thought was usable by itself.  In a similar situation, the pattern I use is to call that class `FooTestBase`, and *not* subclass `TestCase`, so that it's clear that this is an incomplete class, meant to be used as a mixin.  Then, the real test class will do `class FooTestCase(FooTestBase, TestCase)`.  It's slightly more verbose, but it makes the code more self-documenting, I think.
OK, then don't worry about trying to do the animations using jQuery.

On Thu, May 10, 2012 at 9:03 AM, Bussonnier Matthias
<reply@reply.github.com>
wrote:
>> +  -webkit-animation: fadeOut 800ms;
>> +  -moz-animation: fadeOut 800ms;
>> +  animation: fadeOut 800ms;
>> +  -webkit-animation: fadeIn 800ms;
>> +  -moz-animation: fadeIn 800ms;
>> +  animation: fadeIn 800ms;
>> +  vertical-align: middle;
>> +  background-color: #f7f7f7;
>> +  background-image: -webkit-linear-gradient(center bottom, #d7d7d7 13%, #d2d2d2 39%, #e3e3e3 56%, #f7f7f7 91%);
>> +  background-image: -webkit-gradient(linear, left bottom, left top, color-stop(13%, #d7d7d7), color-stop(39%, #d2d2d2), color-stop(56%, #e3e3e3), color-stop(91%, #f7f7f7));
>> +  background-image: -moz-linear-gradient(center bottom, #d7d7d7 13%, #d2d2d2 39%, #e3e3e3 56%, #f7f7f7 91%);
>> +  background-image: -ms-linear-gradient(center bottom, #d7d7d7 13%, #d2d2d2 39%, #e3e3e3 56%, #f7f7f7 91%);
>> +  background-image: -o-linear-gradient(center bottom, #d7d7d7 13%, #d2d2d2 39%, #e3e3e3 56%, #f7f7f7 91%);
>> +  background-image: linear-gradient(center bottom, #d7d7d7 13%, #d2d2d2 39%, #e3e3e3 56%, #f7f7f7 91%);
>> +  overflow: visible;
>> +  color: #000000;
>
> After some test, I alway get into trouble at some point... either because i'm using some before/after css properties for the arrow, or because the background for jquery ui element is not ment to be heigher than xxx-pixels.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1711/files#r802835



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
right, but the problem we're facing is that session.unlockMachine() is not making the machine be reported as unlocked immediately right?

The idea was that when we take an action to change the state of a machine we keep doing ws calls until the state is the reported one (with some small delay in between), and we do this for all state changes (feasible if all of those are in a single class).

I can do that after we merge this.
Hmm, I think we should change the signature of this function. I'm not sure what the name should be... Since the `one` and `two` parameters must refer to commits and since this is giving information about commits, what do you think about something like:

```c
GIT_EXTERN(int) git_commit_ahead_behind(
    size_t *ahead,
    size_t *behind,
    const git_commit *one,
    const git_commit *two);
```

Of course, by this logic, the `git_merge_base()` API should also change, maybe into:

```c
GIT_EXTERN(int) git_commit_merge_base(
    git_oid *oid, const git_commit *one, const git_commit *two);
```

What do you think?

Alternatively, this could take `const git_reference *` or we could keep it with `const git_oid *`. I'm not sure what's easiest. I lean towards `const git_commit *` because a) then the code doesn't have as much error checking to do (i.e. the API design prevents the user from making the error of passing an OID that doesn't refer to a commit), and b) you would get a `git_commit *` from `git_revparse_single()` if you were trying to map user input into this call.

/cc @vmg @carlosmn
>How about "The OID of the git object to remove notes from"?

Deal. However, please use the singular form. Only one note per git object per namespace is allowed.
Yeah... I'd consider calling this function with `NULL` to be wrong enough that you deserve the library to crash on you :p Thanks for the catch, I'll fix it
Missing the closing quote here too.
If SEARCH_DEFAULT_CATEGORIES told you to jump off a bridge, would you? (Totally kidding, but it's kind of a funny thing to say.)
Or me... hmmm. That's what happens when you code late with scotch.
Why the `*`? When we later use the result of this, that's far away from SQL and it's no longer obvious what columns were selected.
This is going to be a really slow algorithm O(n!). Can you come up with something a little faster?
I believe you can use a per-request memo helper on the Stats instance so you aren't allocating multiple per request:

```ruby
def stats
  @stats ||= Sidekiq::Stats.new
end
```
The `tests/unit/sample_complex_csv.txt` file seems to be missing from the repo - please add it in :)
Not sure I like this implicit factory creation.

@cboden thoughts?
> як варіант можна дописати функцію в лістенері, яка буде повертати квиток по платежу вибіркою із бази

можна
Where do you see a tab?
I thought it was all spaces.
@stof - thanks for the clarification, I'll make the necessary changes this PR.
This is useless. you can do ``$lessValue > $greaterValue`` with DateTime objects
I doubt it. My best guess is ansicon (https://github.com/adoxa/ansicon), but I can't see a way to disable canonical input processing.
Here is a a statement to check for Windows support. Could drop it into a method in `StreamOutput` to compliment `hasColorSupport`:

`$autoCompleteSupported = (function_exists('posix_isatty') && @posix_isatty($this->stream) && DIRECTORY_SEPARATOR != '\\');`

Also, maybe we could check the output of `stty` to be extra-safe.
should be named ValidationListenerTest.php
Why don't you use the Propel class?
this must be $content
Objects should compare without `.id`s, as in:

```ruby
<% if @user != @event.owner %>
```
验证效果：table环境貌似没多大问题，当h参数不行时，latex会自动按htbp规则摆放，或它自己的美观规则来摆放。其他的应该差不多。
Remove this migrate
Since you created this file completely from scratch I don't think you need to attribute copyright to atari.
Perhaps. I need to finish reading the reference (thanks). However, ironically I suspect the fact it is kept alive through this strong reference is the real reason the fix works. The hash of ```path``` is likely to be the id, which can be reused if the path is not longer used, causing the issues we saw previously. I just tested this by removing the ```__eq__``` and ```__ne__``` methods from ```PathTransformKey``` and nothing changed. In summary, the ```hash(path)``` is a unique key as long as the path object is still alive (e.g. by keeping a reference to it in the key).
What do you think about dashes? All of our wiki links use dashes now, so it might do for consistency.

[[Basic-Operations#Read-an-Object]] rather than:
[[Basic-Operations#Read_an_Object]]
need the same change than in async workers
This is really so it defaults to something sane, but if we want to pass in a value through the cmd line we can so that we can try things at different versions etc.
Bernie, if you have time please update this section with the correct instructions for setting up and running Mocha
It looks like good...I will do a few changes for this check.
@wagenet Perhaps I would add the current sortProperty (or its type) beeing processed, in order to make the implementation easier.
The other way could be to have a sort function by sort property. I don't know what way would be better, or if it good enough like this. Your advices would be welcome :)
this makes corpora private by defualt for #433
Good question - the API documentation in StandaloneServer doesn't describe anything although the implementation in EmbeddedStandAloneServerFactory does among other things:

  serviceContainer.shutdown();
  serviceContainer.awaitTermination();

What would you suggest?
This would be `keyboardShortcuts` and would be a boolean. But I don't think this is a good name or a good option.
ill take a look a this ASAP, alot today this week.
OWDError -> Contacts ?
Remove the lines instead of commenting them.

We have the history in git so we can go back :)
Yep, not happy with it but needed to handle the multiple entry points,
Two things I think you should fix:

1) You just display the text part of the message, not the title.  For the 'nospace' error, the current text "try freeing up space" without the title "not enough space" doesn't quite make sense.  I'd change this to concatenate title + ". " + text.

2) Up above on line 313, you have this:     var onerror = function() handleError('error-recording');
And it looks like down below, you have one other instance of a function without curly braces.  I don't know if ES6 has picked its final function shortcut syntax. But I'm not sure that this old spidermonkey-specific syntax is going to be the final one, so I don't think we should go there.
We can not use the `role=list` because that give us less flexibility for the markup, as the specefication only allows `role=presentation` and 'role=listitem` as direct child's. You can imagine how restrictive it is.
In the other hand this makes more sense, having multiples sections instead of nested `li` for an appropriated used of `header`
Shouldn't you combine these two ifs into a single one?  Won't they always both be true or both be false?
Ideally I would love to async load this
TraceError.
I think we need some YARD docs here, particularly to list all the color symbols that are valid.  Otherwise users will have to look at the source to discover that.
Why ceil when the convention is floor?
Yes, looks like you did it in a less hacky way as well!
this section could be ```this.action = handler[method] || handler.action```
I figured it would be weird to merge the `escaped` objects this way.
this removes 0.10 from the list, is it intended?
"unknown" is spelled wrong.
Constant. Also explain why this number was chosen.
it is, indeed :D
I was considering using load(BrixNode node), but i couldn't figure out how to distinuiish creating and editing the tile. Do you have any suggestion?
Is this print statement intended to be here? 'requirement' isn't particular clear as a help text
Do you mean line 36, "These" instead of "This"?
QUrl is heavy object, are we really need to store it as static objects?
Code formatting conventions, and if/else is done like this:
if () {
 ...
} else {
 ...
}
fp_engine_analysis_set can be -1 (fopen failure), which is "true" here leading to a segv later as the FILE *ptr is NULL
Right.

What about sigs that has a port range specified, but the PP registered port doesn't fall in the specified range.  Shall we invalidate such sigs?
Well, I'm not very familiar with the ```argparse``` module, but I think the ```nargs``` argument is needed if I want to make the positional argument optional. The reason I did it this was is because I thought it might be nice to retain "backwards-compatibility" and still support invoking the script via

```
nbconvert.py INFILE
```

(which is how it worked before my change).
As above, `if not 'x-content-type-options' in response:`
it'd be nice to see this type of helper available in `window/utils.js` too
Can prefs be floats? 

@warner no, unless a string type is used.
I'd prefer, but I'm ok with this as well

```js
filter(function(tab) { return return getURI(tab) === addonURL; }).
```
@shane-tomlinson no this is a temporary thing while waiting for jwcrypto merge :)
Note that this will delete the first item on the page if there are multiple items. Should it be renamed to indicate that?
Are these two-letter abbreviations understood in the add-on community? I don't know what they mean.
Page names and ui element names should probably be emphasized with either bold or italics so they're easier to distinguish from explanation text.
no need to use a space before a colon
Not sure what happened there... I performed these changes within Dreamweaver and didn't attempt to edit any actual content (such as those accents). Dreamweaver must've screwed up a couple of random accents upon saving :(.
Nevermind, already found it below.

Personally, I am not a big fan of opening up core classes in a library. Maybe we can't find a better way of implementing these, e.g. `Cliep::Utils.blank?(string)`
If possible add a description about the purpose of the class
callable, you wrote collable everywhere ;)
Agreed with @Maks3w -- @Freeaqingme -- I think you need to add some assertNotInstanceOf() clauses here to ensure you don't have a Json or Feed model, as those extend ViewModel, and it's clear you're expecting specifically ViewModel, not an extension.
s/\t/    / on lines 44 and 46.
- Space missing after "if"
- Why not test for isset($node['tuid']) ?
params[:sort] || default_sort_column
O apoio do CACo nunca foi oficial, mas acho que isso deve mudar ano que vem
Where do you expect rounding errors? This should consistently round up to the next full minute.
in 5.4 argument for break is depricated, have a sense to remove it now
Ah, I see, never mind.
better yet: srs = s["srs"] if "srs" in named_sql else 'EPSG:4326' .  I used to hate the python inline if-else, but it's been growing on me.

Also, I have no idea what this is supposed to be doing so this could be totally wrong, but based on the surrounding code it looks like this should be 'if "srs" in s:', not 'if "srs" in named_sql:'.  If it is supposed to be named_sql, this statement can be moved outside the loop.
I like to keep describe blocks as specific as possible, but if the tools is accepted I'll follow whatever standard you want to utilize.
duplicate definition (see 2 lines below)
Its the existing code just moved into a special method.
fancymonth has no logger. i'd prefer a hard crash so someone encourages me to implement it ;)
Why do this if you fail if there's more than one result? Just grab the first one, ignore the rest (and don't return a list)?
This is a very odd use of variables. Why not just

    return ctx.getCallerPrincipal().toString();

and remove the principal field?
Oh, I think I get it - you need to know *if* this version of http-parser is compiled in debug mode.

I initially read it as a switch to turn on/off debug mode.
Why this? ctrl.$setValidity('date', valid) does the same thing. And we should't write into these "internal" properties.
My comment above applies to tabzilla as well. We are only checking visibility and urls on the test_about page, which covers each page for now as they are all identical. See test_mission and test_partners for examples.
If `steward` is `not None` isn't this already `True`? I'm ok with denormalization I guess, but is this really needed here?
This needs to be in quotes as well, same as parser, players, and plugins
The rest of the code does it this way though, that's why I did it in this fashion. Lets face it, the entire code base could do with a good refactor. It's arcane.
What he originally meant is these // are 1 line too far to the left. You can also add the javadoc back, one space between @ param and then name of the variable.
if its required, I think you want to generalize it
I don't understand why this new line was necessary?
link 'getEndpoints'.
You can ask a string if it's empty: `string.empty?`
I know this method is not called too much (only during initialization), but might want to lowercase the product name to prevent repeatedly calling toLowerCase().
this function should reflect on the [above mentioned option](https://github.com/RiotGames/berkshelf/pull/206/files#r2093917) and build a URL for SSH, Git, or HTTPS
Should that be in a blockquote?
Hrm because Jbowes said so :) Honestly I had just the identity certificate, then alex and I asked jbowes. But forgot the real reason. I'll confirm again on Monday.
I might be wrong but we could use here until_not and remove the not from the lambda
Aren't you supposed to be passing a version id here? Why "previous?"
This all needs curly braces ...
I actually prefer it if both the actual query and parameters are provided on the same line. Makes them more connected.
As the number of parameters in the insert query is known, it might make sense to construct the actual query, rather than using Cassandra.constructUpsertCQL. Cassandra.constructUpsertCQL is only supposed to be used when you have a variable number of parameters.
The JSDocs need to be more descriptive as to what it is doing and why. `Reads the configuration values` hardly adds anything on top of the function name.
I just wanted to understand what you mean, thanks for clarifying. What you are pointing out is a visibility issue. Now we can discuss :)
Meh. It's a test, and the 2 expected result of the tests are: the file doesn't exist, and the file exists and have the right content. Any IOException would be a fluke or a problem with the test environment.
There should be a space between the * and the start of the sentence.
поправ лінки. mutuh => stfalcon
Can the parts above this have consistent line breaks?
In general, I prefer allocating a Hicuda object when all mandatory fields are ready.  In this case, the while loop may be replaced with:

while (Element = ParseHicudaElement()) HEL,push_back(Element);
return true;

The allocation of Element should be done within ParseHicudaElement after the name identifier is parsed.

This routine simply consumes as many valid hicuda variable as possible.

The only reason I pass DimExprs to ParseHicudaKernelLaunchConfig as a parameter as opposed to a return value is that the DimExprs is a temporary list and I do not want to allocate it on the heap (using new). Instead, I allocate the list on the stack.

Therefore, I agree with you in passing HicudaElementList as a parameter to ParseHicudaElementList. However, Element is not temporary, so it should be returned from ParseHicudaElement.
Why is this a JMXOperation vs JMXGetter? Please make these changes and I will pull this in.
Why are <tt>cleanup_config_line</tt> and <tt>process_config</tt> now public?
You'll need to put spaces here:

    $proxy = FALSE
Я только что пересмотрел лекцию о свойствах.
https://u.hexlet.org/courses/4/wiki/svoistva-properties?module_item_id=7

Там говорится, что свойсвтва создают переменные, которые "запрятаны". Это я и называю "неявными" переменными, не напрямую объявленными.

Ничего не могу сказать насчет таго, каким образом с помощью свойства можно задать определенное имя переменной. Об этом нам еще не рассказывали :)
Это ошибка. Нужно брать остаток от деления на  [DNA count] и не отнимать единицу.
Ваша реализация уходит в бесконечный цикл при мутации на 100%
Поделюсь одной "фишкой". Создав переменную int i внутри метода/функции/процедуры - она становится видна только в пределах этой процедуры. Но синтаксис языка таков, что можно определить переменную, которая будет доступна только внутри цикла!

Если убрать определение переменной int i, и определять её внутри цикла for, то будет интереснее:

`for(int i = 0; i < _length; i++ )`

В данном случае переменная i инициализируется в начале цикла, и после выхода из него становится недоступной, уничтожается. Соответственно, у вас может быть множество циклов `for`, в каждом из которых создаётся своя переменная i.

**Примечание:** если переменная i будет определена ранее в методе, как у вас, то такой метод не сойдёт.
Спасибо подправлено
получается мутируют (percent-1) элементов, а не percent
What is this doing? Looks weird :)
вот это у тебя код, который имеет отношение к представлению данных. Ему никак не место в модели. Вынеси в хелпер если хочешь оставить как есть
This looks good, but could you change the wording.
Honestly, I'm not sure if including these is absolutely necessary, but from reading the source of the Server proxy it seemed like it would be nice to be explicit here.
http://stackoverflow.com/questions/7552632/what-does-static-do-in-clojure 看这个，没什么用了。
docstring missing :)
You aren't removing the UTF-8 BOM here, are you?
@awagener what do you think about this knowing implementation details of Page?
It tries different servers, the list of which is passed in at construction. (Otherwise, I'd have just used urllib3's built-in retrying.)
I'd do `if $('#answer_body').length is 0` personally
I think it is better to do it like this, in order to be consistent with the example below (line 270):

    $this->assertGreaterThan(
        0,
        $crawler->filter('html:contains("Hello Fabien")')->count()
     );
you can *always* customize a service, even when the class name is not a parameter. It simply requires using a compiler pass, which is needed anyway as soon as you want to customize anything else than the class name
We could maybe create an API link for the methods?
Hey guys what's pending here? I saw @xuanxu added specific rescue exceptions. I would love to see this merged, if we're missing something please let me know and I'll try to get it done. thanks!.
No OK
Are you sure this will work? It's better turn the parent declaration of $_d to be protected.
Именование не по стилю (земля на конце не нужна), и в следующей константе тоже.
Yo no tengo problema (generalmente no me toca escribirlo), pero estaría bueno definirlo.
Should be "Excluded patterns:" to stay consistent with the rest of the messages.
A common convention with model specs is to use `subject` instead of `story` and possibly use `described_class` instead of the class name.  A couple variations:

    subject = Story.new(:url => 'specurl.com')
    subject = described_class.new(:url => 'specurl.com')

Additionally, for validation-related specs, RSpec provides an [`errors_on` helper](https://www.relishapp.com/rspec/rspec-rails/v/2-10/docs/model-specs/errors-on) ([code](https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/extensions/active_record/base.rb#L40)) that handles running the validations and checking errors.  If you care about the error messages (I usually do), you can do something like this:

    subject = described_class.new(:url => 'specurl.com')
    subject.errors_on(:title).should == ["can't be blank"]

If you don't care about the message, you could do something like this:

    subject = described_class.new(:url => 'specurl.com')
    subject.should have(1).error_on(:title)

Since you don't really need to pass in a URL, you could rely on RSpec's [implicit subject](https://www.relishapp.com/rspec/rspec-core/v/2-10/docs/subject/implicitly-defined-subject) and do:

    subject.errors_on(:title).should == ["can't be blank"]

But ... this advice is irrelevant if you use [shoulda matchers](https://github.com/thoughtbot/shoulda-matchers) instead for these simple validations.  You could then just do:

    it { should validate_presence_of(:title) }

Sorry for the length of this comment, hopefully the information and links here are helpful.
This mean that the log method could be removed to use the logger object without this abstraction (that was implemented to use a common log method  whenever no logger were defined)
Adding stop and log tests could be awesome !
Because it is the default in the schema class too. So i removed it here.
`se` variable isn't even used, is it?
This is explicit and clear, and it's good for now. But I'm curious: have you looked at whether json schema would fit the bill?  There's a python implementation, but I'm not sure how mature it is.
We set it to True, but this get converted to a '1' when stored into the MySQL database. Alternatively, in the long-term (future refactorings) I think this field in the metadata will be dropped because its not really used anywhere. In this case we can remove it from the unit test checks.
lets _not_ add defaults to this here, only [], or possibly only "os_admin", we dont want to remove users from the default list imho
yeah and if you want a date of deleted it should be deleted_at.
haha good catch @sacharya
Idea näyttäisi olevan oikea. Toteutus voisi olla yksinkertaisempikin:
~~~clojure
(defn permutations [a-set]
  (if (empty? a-set)
    '(())
    (mapcat (fn [p] (rotations (cons (first a-set) p)))
            (permutations (rest a-set)))))
~~~