labofsahil/github-event-dataset-2012 huggingface dataset:
> It's better to make sure that '{DAV:}unbind' is not marked as abstract.

I think I got the principle: Mark the needed properties as non-abstract in getDefaultSupportedPrivilegeSet() and return the struct for them in getACL(). I'm unsure of the format for returning aggregate properties. Should there be an array 'aggregates' under e.g. '{DAV:}write' that defines '{DAV:}unbind'?

```
array(
	'privilege' => '{DAV:}write',
	'principal' => $writeprincipal,
	'protected' => true,
	'aggregate' => array( ... )
),
```
or should I omit  '{DAV:}write' and define each aggregate property instead? Or something totally different :-P

> I'd definitely be interested in some constructive criticism from an external person such as yourself.

My only problem is that I find it a bit hard to grasp at times, but that can only be blamed on my Swiss cheese brain which is not wired to hold much at a time ;) Mostly when I get it explained it's "Ah, of course" moments :-)
J'espère que tu n'as pas modifié les fichier que tu as bougé parce que je ne pourrais pas le voir dans ce cas
Pour les entités sans tiles, je crois que j'ai fait ca pour le load des pnjs, ca buggait sinon. Je l'ai supprimé, de toutes on va s'occuper du load en profondeur bientôt. Pour la suppression/addition, je vois pas d'autres solutions "faisables" qui prennent pas 20Gb de memoire ... Si tu mets à jour tu rajoutes encore une boucle : j'ai jugé bon de l'éviter.
same as above with the first "="
returns should be return
I was simply following what appeared to be an existing convention, with singularized names for loops and one letter names for list comprehensions and generators, as is apparent on line 95, visible at the top of this diff. Would you like that one changed to ```link``` as well?
Any particular reason you've changed the semantics to include admins?
No space after the `if` please.
So I know I had the `ReferenceEquals` code in there, but I think it was generated by R# and I was lazy. Is it actually needed to compare edge to null? We should probably change this to 

    if (edge == null) return other == null;

That's much clearer. Unless there's an actual reason for `ReferenceEquals` when comparing to null (I don't think there is)
annotated.
Was trying to be consistent `clazz` name used in method parameters (I know, to avoid clash with keyword). `fTestClass` sounds fine though.
The fact that the super class' constructors take arrays instead of collection classes makes me sad.
Even more code repetition...
I avoided this change originally since identifiers can include unicode letters http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf. I think this is good enough for now until we implement the CodeMirror parser here. I'll add a TODO and an issue number.
Looks like we need a colon and space added there.  Also, might be useful to show an example?
Nice technique!
I would suggest the bag approach and moving the documentation down to here.  There are so many args to QuickOpenPlugin() that I think it's actually easier to read code creating a bag than to try to figure out the meanings of an unlabeled arg list just by order.

If you want, we could even remove QuickOpenPlugin entirely and just use the bag everywhere.
We should remove this comment now that the code change is gone
Why this change to the normal smoke files?
Looks like indent is off here.  Make sure you're using spaces instead of Tab chars.
Good points about not leaking, and fair enough re the private API.
I don't think this statement is always true: for example, "rgb,,,,,@#$%" would be modified to place a space after each comma even though it's totally invalid.  Maybe we could say something like this:

> The the given string is a valid color, returns the same color normalized to tinycolor's preferred string format. If the given string is an invalid color, the return value is also an invalid color (though it may not be the same exact string).
I agree with the cursor position, but tagInfo does not apply to js or css code hints providers though..
Validate the integer and the NPE... Again.....
`webapp` seems like the wrong name here. This parameter determines whether to show it by itself or in the context of the rest of the app, right?
`#{@hostname_command}`?
Sorry should have been clearer, I wasn't talking about the style, but the 10 blank lines at the end of the file that could be removed.
I think this may not be compatible with the way I've done AJAX search results. Can you pull from head and merge?
no no no. That's a false "move" operation detected by git. The package name has been changed (look at the full diff). And the nicolas' comment is linked to the "changes" in the header. That's *only* blank spaces... They are added by netbeans during the file creation, while applying the macro used to insert the header. If you want me to remove these spaces, I can do it. But I don't see what we would gain from that.
At the end we would like to get completely rid of relation database. So this can go out. No?
Unnecessary span.
Don't change passed in argument. Use some local variable.
If we already have the list of available migrators, it should be nice to print them, so people don't really need to run `jekyll --help` to check the migrator name. Something like this would be more helpful:

```ruby
puts "Invalid migrator #{migrator}."
puts "This is the list of available migrators:"
puts migrators.keys.map {|m| "\t- #{m}\n"}
```
This can't actually be replaced by `(max-width: @medium-w) and (max-height: @medium-h)` because there would be a case where `width > @medium-w` (out of range) but `height < @medium-h` (in-range) or vice versa that isn't covered by any media query.

The solution is either to use `(min-width : 0px) and (min-width: 0px)`, or to have a base style that has no media query, i.e.
```
.class {
  width: 10px; // This is for the @small case
  @media @medium {
      width: 13px;
   ...
```
Why not merge the objects, like the `_merged` array suggests it might? I like the lazy branch lookup system, but a lack of caching and this block are the only weak parts I see if we're at all concerned about performance.
Another good call. Just committed a fix.
Can you write a unit test that this works?
I think if we are going to spend the effort to update the deps, we should spend the effort to minimize there declarations as well.
conf->buffer_number = (conf->client_body_postpone_sending + conf->client_body_buffer_size - 1) / conf->client_body_buffer_size;
This view name shadows the list builtin. So we need to change this.
I would be interested to know if if-then-else or a case is faster than guards. I've heard guards are slow, but never really experimented with it.
I think we should keep it analyzed, but switch it to the snowball analyzer maybe?  If its not analyzed you can't search on something like  RHSA*   or RHSA-2012*  which i think are good things to be able to search on (although you could argue that there are other ways to search on them).  

How does it behave if you do use the snowball analyzer here?  I'm doing some work on the side to make search syntax a bit nicer and from what i've seen snowball may solve some of our problems.
Right, wont hurt. Good catch, I inspired from katello/config.pp. Force-pushing!
We could totally save some additional bytes here by rounding coordinate values to 7 decimal places. @robgur you see any problems with this?
It would be better to use the `placeholder` param of the input here.

Emptying the field by hand on a mobile phone is a pain.
I added this as a required parameter to ensure that if we are providing no source file, then it is done explicitly. (i.e. for small snippets of internal code)
@wkerzendorf I see - my mistake.

@astrofrog +1 for @eteq and @demitri's API suggestion too. It's clean, and the coding guidelines say:

> Using python properties, attribute syntax can still do anything possible with a get/set method. For lengthy or complex calculations, however, use a method:

I think a conversion between different reference frames falls in the grey zone here, but I'm in favour of a ``convert_to`` method instead of using attributes which needs caching.
@mdboom , when `pedantic` is `True`, any VO warning becomes an error. Currently, there is not a single service in the list that I check nightly that is completely clean. They are considered "good" after we ignore the non-critical warnings, as discussed in private emails. So to accept results from "good" services with ignored warnings, `pedantic` has to be `False`. This can be made stricter in the future when the service providers clean up their services.
I thought it was best to avoid discussion of the 'current' cosmology in the Getting Started section - in my opinion it's too much detail for a quick examples section. But I agree it's important, and there is still a description of this in the next section.
... and Link-Walking
Лучше использовать какой-нибудь `mktemp`, потому что при запуске `make -j 10` будет непредсказуемый результат
Maybe add a new environment variable for determining if this is necessary?

For example (above the -l z -l pthread def):

ifeq($(LMODE2), dynamic)
  ifdef NEEDS_DL
    LIBS += -l dl
  endif
endif
NACK: don't abbrv th mthd nms
I really don't like using - on flags. Please use a mask with `&` if you need a subset of the bits, instead of subtracting them one by one.
I would name it Logger instead. Or at least I would try to avoid exposing the name trait on it as it is different from interfaces in that they act very much like a class
For consistency shouldn't we use `floorText` instead of `levelText` here?
again, the curly braces here should be left on all the lines like this... is there a reason you changed them all?
maybe even remove the spaces or remove the spaces on the factory where the generator is configured because they there have already the "\n"
Wouldn't it be cleaner, consistent with existing code, and perhaps more readable to say the following?

item['packaged'] = row.attrib['singleton'] == '0'
Good point. My take on it is that the potential for confusion will be there whatever we call the classes - Test, TestRun, TestCase, TestSuite are all ambiguous. This is still a relatively young tool, so we can rename things later if we want.

As to your example use cases, I imagine for running with specific versions of Python we would make `supported_pythons` a parameter to `TestRun.__init__()`, while running the tests in parallel would only require implementation changes, and the API would stay largely the same.
I am not sure I consider this to be config information.  It is more a static list that is associated with the auto-highlighting code.  The people who should modify this list are not users but authors of cell magics.
I really like how you have refactored this method!
This accepts *either* a compiled expression or a string, but the attribute will always be a compiled regular expression object (`re.compile(re.compile(pat))` is allowed).  Adding 'casting' to the description would be appropriate.
rpy2 in places will convert `.` to `_` to handle this; is that worth doing here? It could print out a message like `foo.bar, baz.thing -> foo_bar, baz_thing`. But it's added complexity, so it's fine to leave it if it's a corner case.
I have added the annotation for consistency.
not clear what you mean... do you mean changing "target/test-classes" to "src/test/resources"?
This can be more clearly written as:

```
highlightRect = CGRectOffset(highlightRect, 0, -rect.origin.y);
```
The temporary variable `output` doesn't add anything here. Just do:
```python
print "PUTNOTIF severity=%s time=%i host=%s message=%s" % (severity, timestamp, fqdn, message)
```
If use the Sort List, encoded json string will like this 
"sorts": [{
"field": "time",
"order": "desc"
}]
which sensei can't handle it right.

sensei takes this 
"sort": [{
"time": "desc"
}]
kind of json for sorting
IMO this could flow better using a variable and a larger if statement:

```python
use_stub = not force_full_installer and settings.AURORA_STUB_INSTALLER
if use_stub and locale.lower() == 'en-us':
    filename = 'win32.installer-stub.exe'
else:
    filename = {
        'os_windows': 'win32.installer.exe',
        'os_linux': 'linux-i686.tar.bz2',
        'os_osx': 'mac.dmg'
    }[platform]
```

Not a blocker though.
Indent HTML files with 2 spaces, not 4, please. Your editor can do that for you I am sure :)
I didn't know about the one in sumo/utils.py.

(/me puts on his superior hat.) I think mine is better since it operates on any iterator rather than just sequences like lists and tuples. The problem is that the one in ``sumo/utils.py`` calls ``len()`` on the sequence and iterators and generators don't have a ``len()``.

Still, it's interesting to know about. Erik wrote another chunked one in more-itertools that's more complicated and I think it does more work than mine does, though I haven't verified that, yet.

I should look through the code to see what uses the one in ``sumo/utils.py`` and probably swap it out for mine.
Change this default to `{}`.
What you have there is not valid JSON.
嗯，这里我沿用的他之前的没改，我自己调试的时候还需要去改配置的host

发自我的 iPhone

在 2012-3-14，上午12:45，fengmk2 <reply@reply.github.com> 写道：

>>    var sender = config.mail_sender;
>>    var to = who; 
>>    var subject = config.name + '社区密码重置';
>>    var html = '<p>您好：<p/>' +
>> -               '<p>我们收到您在' + config.name + '社区重置密码的请求，请单击下面的链接来重置密码：</p>' +
>> +               '<p>我们收到您在' + config.name + '社区重置密码的请求，请在24小时内单击下面的链接来重置密码：</p>' +
>>               '<a href="' + config.host + '/reset_pass?key=' + token + '&name=' + name + '">重置密码链接</a>' +
> 
> 这里`config.host`不应用依赖配置中的host，要不然本地调试配置的url就无效了。应该根据req.headers.host 来获取。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/muyuan/nodeclub/pull/20/files#r552528
>
Will correct.. Thank you..
Why is the `array('')` for?
`); ?>`should go on next line
oops , left a echo there by mistake
Mind adding some documentation here?
``FauxFile`` ?
GH says it is: 

> ...mponent/Form/Exception/InvalidOptionException.php → .../OptionsResolver/Exception/ExceptionInterface.php 100644 → 100755
Oh ... thanks! Correct like that, or with an e-mail?
Besides the new features that this changed function signature makes possible, I also think it's much more expressive. The true/false param didn't say much to a reader. But using the constants, it's very clear what it generates.
Compiler|null
Meh, for the mess I’ve created with all my pull requests, you are excused :)
Moved html escaping into Post constructor.  Similar change in comment.
change this to generic "iPhone Developer"
需要一个dispose方法，清除闭包中的全部量，如 ele等，还要清除事件的绑定。
Copy/paste fail. Will grep and update.
That <tr> should be aligned with others.
wouldn't fopen be enought? It returns NULL if file don't exists
shapely files -> shapefiles
Is that a wms specific thing? I don't know what this is...
`require('./index').nodes`
Indentation here looks off
```R
return (response == '')
```

would look so much nicer, if you ask me
The week portion is the week of the enddate which corresponds to date the notification is generated which limits it to 1 sms per week. On week 5 it will have sent 3 sms total, not 3 new ones. Are you saying that they should only be notified on the first error condition and not each week until the error is resolved?
this adds a new function to setUpAndAssociatePublicViewsAndModelsWithCurrentCorpusMask start the showing the user what their corpus looks like when it is public vs private. each corpus has a public mask, which is what we will show the user if they click on the public/private word for #431
Tu es sûr pour le 100000 ?
That was not mean't to be left there, I just wanted a line I can set a break point on :-)
users can be numeric
fixed :-[
Extra whitespace :/
Yep but it's hard for me to know what has been told offline ;)
hi guys

thanks for clarifying and sorry for the late response. i missed the email notifications...

referencing my questions above

1) @arcturus if the user has to restart the phone every time the SIM is switched, adding a listener is indeed overkill. Totally. So lets avoid doing that if possible.


2) We should never hide the 'import from SIM' CTA. If it is not functional because the SIM is not present we should keep it visible but disable it. I have just replied to an email for Maria regarding the copy for this.

..is that OK?
Hmm, good catch, but could we get UX feedback on this idea?
ping @jcarpenter :)
arg, this is a mismatch with another PR...
These constants have very misleading names, which you appear to have taken from the filenames of the icons.

The words "INFINITE" and "ONCE" seem to specify the number of times that a song or playlist will be repeated, and that is what I assumed they did.  

But actually, "REPEAT_ONCE" means "repeat the current song forever" and REPEAT_INFINITE means "repeat the current list of songs forever".

You should rename these constants and the corresponding icon files (and possibly propagate the new icon names back up to @patrykdesign, if those were the filenames he chose.)
What about using array.filter?
logging in `catch` is ok, but this is really flooding the logcat, can you remove logs in the non-exception cases?
dContact -> deviceContact (let's be explicit :))

Also I think you can do |deviceContact.category.push(fb.CATEGORY, fb.LINKED, fb.uid);|
Is there any reasons for not using the same effect even if you stay on the same page? It seems strange when I use the phone.
`!!this.wifi.dataset.enabled` since the value will be either `underfined` or string `'true'`.
if you want `{user}` to be magically replaced, it should be `{{user}}`.
Yes I use dependency injection in cases like that too. Thanks for pointing this out.
please call your faces edts-debug-xxx
I don't insist. It just feels like this is not the right place for this, even if this is a temporary bugfix. Why do you need to introduce this as an inner function of operate? Will you ever need this again if you need to convert Grouped to Pipe?

By the way can you explain what the bug is about? Maybe put that in the issue description.
Will this strict equality be what you want when needle.dtype is float?
Document why these exceptions are here, and why a user of this function should call them.
@xGen do you mean the CSS code above or the pull request in general?
I think we heed to keep this, too, otherwise you cannot delete normal topics.
Is this new parameter even needed?  Couldn't the libvirt or virsh version or help-output be checked, then if the kickstart/answer-file method isn't supported/working for that version, throw an exception (TestNA perhaps?).
```coffeescript
if g.BOARD is 'f' and not g.REPLY
  filetag = QR.threadSelector.value
else
  threadID = g.THREAD_ID or QR.threadSelector.value
```
ah thats a valid point. main thing i was doing was fixing order. if you want those can be easily reverted to functions and remain in same place.
for different compilers BOOL = nil, it can be BOOL = NO, BOOL = nil, BOOL = 0x54837926
OK, so the other instances need to be corrected? e.g. https://github.com/alphagov/frontend/pull/70/files#L2R28
As before, ``x*x`` instead of ``x**2``
This will still work for old `.tac` files which do not specify a third argument.  Nice.
This commit looks good. The only comment I have is that perhaps we should add a `FIXME` comment here suggesting the mock here get replaced with a fake, at some point.
Array.prototype.splice.apply will take care of updating it in all browsers I tested.
Say we have a sig: "alert X any any -> any any" and proto X is only registered for tcp port 1234, we could update each signature that uses X to have port 1234 probably?
sounds like a good solution
A relative import will make this easier when we (very soon) move this to the main IPython repo and into the IPython namespace.

I think

    from .. import main

should work, but I don't know the IPython feelings on relative imports. @fperez?
Should these be permitted to throw any exceptions? What happens if they throw a `RuntimeException`?
I think you're right. What about this: labelSlots is an array of slot names, and the function is invoked on any change to any of those slots. The function is passed a JavaScript object with the slot names as keys and the values from the model as objects. Seem saner?
On the second thought it may be even make more sense in `util/dom` module or alike.
extra would do here as well.
would it be too magic to have `.checkSupport` just deal with email addresses when passed a string with `@`?
why comment this?  Why not delete this?
let's include a comment here which describes the rationale behind waiting for iframe load?  yeah, I know, it's a nit.
@lloyd - *I* have grammar problems.  I'll update the comment.
This will make us less aware of different classes of l10n problems. We won't know about them until localizers complain. If we have to maintain the en_US .po and .json files, then we'll see how string changes affect others, earlier.
Is this safe? Won't any embedded ```<script>``` tags in ```strToClean``` execute at this point? I'm hoping browsers have some better function for this..
remove this dead log
This is done in the new TB.
OS X >= 10.7

fail string should be on one line without the backslash
according to the ruby docs open without a block is the same as new
true. we should move them to the html.
Sorry, indentation still broken.
I opted to define the default value as a class property, as was also down for ExceptionHandler (which has no constructor) and Xml (which has more complicated option processing).

I would have done the same for `$format`, since the original set it to `self::DEFAULT_FORMAT . PHP_EOL`, but I wanted to use late-static bindings to read the overridden default in ErrorHandler, which extends this class.
MultiCheckbox is different than Checkbox semantically -- it's for a group of related checkboxes that share the same name (i.e., you'll get an array of values back). So, yes, needed -- and I'd argue that it should have an InArray validator that checks against the options provided. (Radio should as well)
s/out-the-box/out-of-the-box/
Per previous comments, track this in the SendResponse listener.
I think this is not what we want :P
IIRC we could skip this step if we rename this file in repository to: `behat.yml.dist`
So what is our convention here exactly? Use lower case string whenever we are in a type declaration (such as method type), but not when we are calling a method, such as string.Join?
Well then, I have a *lot* of code to update. Bummer.
This method seems superfluous.  We could just reference the constant directly...
Nope. On `KeyError` exception `fallback_value` will be returned. Otherwise, value of key (even if it `None` or `False`) will be returned. Just check in console! :)

As I said, all this settings have a default values (`settings._DEFAULT_CONFIG`), so if a setting isn't exist in user-defined settings file, default will be used (since we simply work with the settings dict).
Can be written more succinctly as

    var callback = sinon.spy(done(function (arg) {
        assert(callback.calledWith(object);
    });
This require_once is useless
This is wrong. The param is an entity manager
Same here. Try breadth first search instead of recursion.
With "Output" out, the name should probably specify to or from info, like Html5ToEzxml or opposite if that is the case.

Alternatively interface could cover both directions, unsure about the naming of the methods though.
We need to overwrite ``settings['PATH']`` with the actual path (the one from the command line), so that ``Page.get_relative_filename`` and ``Page.get_relative`` will generate a correct relative path. But I think this shouldn't be done in the generators: the sooner this override is done, the better.
Ideally, the constructor of the main ``Pelican`` class should take only one argument: ``settings`` (which would have already been synchronized with options from the command line).
@ametaireau what is your opinion on this?
`auto_now_add` is deprecated (and hated by the django devs). Better to use `default=datetime.datetime.now`.
Should it be `None` or is this what `sorl` sets when photo is blank?
I can make this change, but if you are editting stuff, please use

```js
if (!args) {
    return false;
}
```
I don't want to rename the function. When someone would like to add identity support in the future (oh, crazy), in case he needs a pointer for this, he'd end up having to modify function names etc. I usually try to stick to some templates when writing stuff so you can re-use it easier afterwards ;)
I editied it in the web interface. It did _things_ to my indents. let me see if I can unfox it.
Replace this line with:
```java
if (tile == null || dist == null || temp < dist) {
```
omniauthはレスポンスから渡ってくる情報をスタブできますよ
how many pages need to include this other than base.html?
This sentence is wrong. "Claim processed ok" seems better.
Many people in the Java world use _ for test methods. But I will camel case & shorten them. It is not my code after all so I don't care so much if it is ugly according to my standards :-)
Of course, additional properties can be recorded as "extra" properties at any time before `save()` is called. In this case, the file system connector usually assumes that the "`jcr:content`" child node (under an `nt:folder` node) has a primary type of `nt:resource`; if that is not the case, then the primary type is stored as an extra property.
Maybe we should call it fake.pem or some such descriptive name?
There is: {Q}. The letest commit added it to to_symbol as you suggested.
Agreed, shoulda done it from the get go.
Let's make sure we're using && for 'and' logical operations. 

see https://docs.google.com/document/d/1r3ZV8yiwSQWi3KttVDj0Pv1QZVJ89AXoabzcMxnNYYs/edit?hl=en_GB
i think it would be better to update local state after transport was called. if the transport hits some problem and throws an exception, we could land in an inconsistent state.
Agreed. It can be hard to read. In this case it made sense to me.

On Sep 29, 2012, at 12:22 AM, jimtla <notifications@github.com> wrote:

> In ryan-recursion.coffee:
> 
> > @@ -0,0 +1,82 @@
> > +check = (cond, msg) -> cond || throw new Error msg
> Nice! I'm still not sure how I feel about conditions on the right side of expressions, but there are definitely situations where it makes for pretty code.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Good point, I agree with you.  But let's delete the old code and keep the comment on this in a commit message.  Otherwise, we'll be overrun with in-line arguments! (Not really, I should wish for that kind of problem.  But it does help if we keep things clean.)
you  have some commented stuff in here is this expected??
If we don't wrap in a securityContext, this could just be:

module.exports.getRole = function(principal, subjectPrincipal) --> returning the role of principal on subjectPrincipal (if any).
should this be `opts.smallPictureUri`?
Should verify cropping by sending a String.
What is the correct format?
What I'm saying, is that I think it should be a separate module.
Just a note:  I don't use %% in my builds anymore.   I'd prefer the % syntax with explicit scala version.
Since we are at it, I was wondering whether we could reduce the number of ``Symbol``s transformed into ``SymbolInfo`` by discarding all symbols associated to invisible bindings (maybe by collecting only symbols that have a ``RangePosition`` or, maybe safer, filtering on Symbol.isSynthetic). Thoughts?
i think we should check for instanceof Symfony\Component\Routing\Route - the interface is only used to know if there is a getContent method during the match process, not relevant for generating. (actually this could be something that core symfony could support, generating a route from the route object...)
It needs a semicolon at the end ;
Why do you choose to continue parsing here? If there are extra tokens after nowait, I thought the kernel directive has syntax error and should be ignored.
Concur. I didn't add that one, but I'm happy to remove it!
То же самое. Цикл, теоретически, может никогда не завершиться.
похоже на опечатку
длинна по умолчанию должна быть 100, хоть и есть рядом инит, который создает массив с заданной длинной
наверное этой строчкой Вы имели ввиду проверку корректности числа процентов. При длинне ДНК в 100 (как в задании) - количество символов, которые надо поменять соответствует процентам, но при длинне ДНК больше 100 символов Вы будете менять только 100.
weird. putting space back in. I don't remember touching this file.
Except that `+deferredScheduler` guarantees it will be performed later, while we'd rather (I think) have subscriptions happen as soon as possible.
This is no longer true as of spagalloco/em-twitter@ab5eb7251fe76f543237720be1803598c3b32d43.
I'm a bit nervous about performance. This will be a pretty tight loop. I don't recommend using breakable in Scala, it's known to be a bit slow.
I considered changing it to "if not dir"  first, but thought we don't want  'dir = True' to enter processTV.processDir either.

But I'll change it.
I see your point, but I'm still a bit reluctant to add something like an
index argument to copy. Or do you see a way to do it without passing an
index argument?


On Thu, Dec 6, 2012 at 5:37 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -463,19 +493,30 @@ def __repr__(self):
> >      def __getitem__(self, key):
> >          """Return an Epochs object with a subset of epochs
> >          """
> > -        if not self._bad_dropped:
> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
> > -
> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
> > -        epochs.events = np.atleast_2d(self.events[key])
> > +        epochs = self.copy()
>
>  But wait, all is fine. If not preloaded no copy of self._data because it
>
> doesn't exist.
> else it in fact gets sliced to the events selected by the key. Where is the
> issue?
>
>  self.copy() makes a deep copy of self, including self._data. For
> consistency with numpy this seems a good idea. However, when indexing this
> entails a lot of unnecessary copying (especially since you're going to
> discard most of the copied data anyways when you index).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337289>.
>
>
That makes sense to me. I assume by default we'd have the 'mean' operation do the averaging using appropriate sign-flipping within the label, too. This seems very general. I'd be happy to implement this at some point after you're done classing it up if @dengemann wasn't planning on using this type of analysis.
you could also use more standard ways to do this eg lines = lines[np.newaxis, :] (same as lines = lines[np.newaxis, :])

there is also an np.atleast_2d but I am not sure it will put it in the correct orientation (might need to transpose)
What will happen here if the pathName is not /news?!
While this implementation is good and simple, please switch to using the express module to implement the server.
It is cleaner and mroe readable to do this:
<code>
if (order.getConcept() != null)){
 }
</code>
@mandubian I see your point about the Executor though, it's just a question of whether we want to support yet another interface
Copy/paste error: `task :release_rpm_rc do`
This seems weird to me. `content_tag` has always seemed like a one-off to use in helpers or something. I'm not sure I'd find this more readable than just 

```
<nav id=#{dom_id} class=#{css}>
  # ...
</nav>
```
use `joinPath` instead; note that `</>` is different on windows, but package depends on unix anyway. (alternative is to use intercalate)
This should be done the same way as I described in the previous comment
typo here: ``easily``
same issue here for the PHP template
Diese Änderung wiederum eher weniger gut.
Obviously, an only <DL> is enough for the whole page, but I just followed what was done before: one 'dl' by field. I can change that for the whole page if you want.
There isn't a documentation standard at the moment that is easily found. I'll put something together this weekend when I get home. At this point it is mostly the Python standards with some of my own eccentricities, you seem to have gotten most of it right from the existing code.

Documentation standards can sometimes get controversial because there is no particular reason to choose between equally good alternatives, but my own opinion is that the main goal of such standards is uniformity, not necessarily "the best", whatever that may be. In any case, with a C++ transition in sight I think some input from the C++ gurus among us would be appropriate. The 80 character line in particular started because that was the limit of the old punch cards, then the old terminals, and nowadays the argument seems to be "readability", but I know of no rigorous studies concerning the latter :)
Тоесть сделать const auto& и затем удалить reply?
Нет я. А геттер все-таки убери, ненужная деталь реализации.
Завтра накостыляем свой слайдер, с блекджеком и звуками, и что тогда?
`Blogging`, блин.
Estoy de acuerdo, no es escalable. Por el momento dejemosló así y si queremos mejorarlo en el futuro podemos incluir acá también `ScriptManager`.
¿Este salto no rompe el rendering?
We were discussing them earlier this evening, that's part of what made it so hilarious :)
```php
        if ('ok' === $request->get('flush_cache')) {
            
        }
```
Missing root backslash namespace separator on some static call like in the line 626, 633, 634 and on new object line 753 for example
Yeah pointless
```
root@dev1-1:~# dpkg -S /var/lib/libvirt/qemu
libvirt-bin: /var/lib/libvirt/qemu
```

libvirt-bin should be an explicit dependency of vms-libvirt (separate issue?). Presto. If `/var/lib/libvirt/qemu` is screwed then the system is screwed.
The method is used from scala code. You've probably disabled your intellij scala plugin?
Remember about covariant returns: http://en.wikipedia.org/wiki/Covariant_return_type
I want to see the entire original stack trace.  The log message also logs this.  For some reason, adding the original exception as the cause on the next line isn't enough, it still gets swallowed in some environments (e.g., AS 7)
Hmmm, can't this be defined in a parent pom.xml that affects all? i.e. parent/pom.xml ?

You'd need to check if some mvn project needs slightly diff settings, and see if it can override...
not totally sure, but i think this is taken care of by the form framework as you declare 'choice' in getParent. i think you can extend AbstractType
Could you put spaces around the binary operators: `*`, `-` and `+`?
One thing I am not able to test is the impact of this line. For instance, does the MacOS backend blow up now before any plot is produced? Are there other backends which we don't have sight of which will have this method called, with the obvious impact of having an unexpected exception raised?
PEP8 suggests that exceptions should be initialised. (i.e. ```raise AttributeError()```)
I'm not sure it is a good idea to rename the variable. `fname` is used as an argument in the outer function. Renaming it there would break the API. Renaming it in `pilread` only would be confusing I think.
А для этого кейса у нас есть тест? Кажется могло сломаться.
Concordo contigo, já havia iniciado uma série de refatorações para deixar isto na camada de models mas preferi deixar para submeter antes da próxima entrega aproveitando que terei que fazer algumas alterações nos renderers, assim estas alterações já ficam validadas pelos testes das entregas anteriores que ficaram em hard coded.
You need to mention that this is a CMS only feature, so I suggest renaming to "How to Create a CMS tooltip". Can you also add a link to here from the "extending the cms" docs?
...And I don't know. perhaps there was more to it originally.
Check line 296 below. We're first checking to see of the element exists, then grabbing the nodeValue ONLY if the element actually exists. The < parent > tag exists only for categories with parents.
Because it would look stupid and I will not corrupt "PHP" to "Php" :-) I think PHPUuidGenerator is good.
What else would you put here? The label and explanation are the in <dt> tags.
you should mark the test as incomplete IMO (with the message)
@schmittjoh this comment looks weird :)
missing newline before return. and return must be without () as its does not contain a condition.
CS, в этом случае путая строка не нужна
`every?` itse asiassa palauttaa `nil`:lle ja tyhjälle merkkijonolle `true`
Probably should put the closing paren' on a new line.
it should be

    simplexml_load_string('<notform><test /></notform');
Again here.  As an explanation, each test should be testing only one scenario.  More granular tests means that we get better information back from unit test reports (i.e. we can tell that the issue with getBool only happens when it is false).

The other thing to note here is that $_GET, $_POST etc don't get populated with integers, booleans, floats, etc.  If you do a var_dump of a typical request super global you will find that it contains a string.  You should change your tests to match this so that they more closely represent the real world scenario.
spacing: `function( context )`
you should remove the space between the class name and the brace and the spaces inside the braces
We should test that "latest" also works for a fallback, but possibly not here.
Can you remove this bundle ?
Sorry, I thought: $(pass1).removeClass('input_ok input_error').addClass('input_ok');
I can but I don't know how. Where can I initialize this embedded document?
What is this TODO?
No, `node_id` is not necessary int. We do not define this anywhere in the API. It can be arbitrary string defined by the backend. So you should not convert it here.
But of course you should also fix on all other files. :-) I mentioned it only on one. You should check everywhere then.
I am talking about creating a seperate view for password. I just dont think its necessary.
(but will do seperate form)
I don't think we want to have this in. You will rebuild the database every time you run ``make test`` anyway, so it's only useful during development.
Since Spreedly Core supports a transparent redirect, we've spent a lot of time thinking through the implications, and haven't been able to come up with any useful exploits based on fudging the redirect url. The payment information is taken before the redirect, and the only information that comes back on the redirect url is the token. Theoretically, if an attacker could tamper with the form they could exploit the redirect to get the consumer to re-enter their information on a second form, but if they can tamper with the form there are already much more interesting and less observable exploits that can be done (like capturing inputs via JS before the form is even submitted).

At the end of the day the consumer themselves are the only ones that can feasibly redirect themselves to another site, so you end up at a "what's the point" conclusion.
I'm making the assumption that the default is the same as the "NOTE" indicates was the only option previously:

> Prior versions return only the balance for the primary currency holding.

Since this *greatly* simplifies the API for callers, it seems worth it until someone runs into an issue with it.

The other option would be to run this against the sandbox and see what the default actually is; not sure if you want to subject yourself to that much pain though :warning:

Unless I see proof that there are actually three possible responses from this call, it's going to be hard to convince me to foist a tri-state option on the library caller.
!targetList.empty()
I would also add: 

self.assertAlmostEqual(my_measure.value * 2,  converted[my_measure].value)
> I think the check on the PROVIDER is redundant?

Yes, now I agree with you. The checking doesn't seem to be necessary because if `hibernate.ogm.datastore.provider` is set to `RedisDatastoreProvider` then the check always returns true. If `hibernate.ogm.datastore.provider` is set to something else then `RedisDatastoreProvider` is not even instantiated and the check is not called. So if a DatastoreProvider read from `hibernate.properties` is instantiated correctly, then it can assume that the property is set.

> Also, consider that someone might want to extend your DataStoreProvider to change a single method.. it would then fail for who is trying that.

This is also true. I should not let the subclasses to override the method and fail. Instead of making the chance for them to fail, I changed the scope from `protected` to `private` so that the subclasses have no chance to change the method but can get the checking in the super class, `RedisDatastoreProvider`.

These modifications are as in the commit named [Remove a redundant checking on 'hibernate.ogm.datastore.provider' ](https://github.com/seiyak/hibernate-ogm/commit/edb329a71dca145b7e29df8d3524162ebdc4b33a).
could you use a pattern like `log.useSafe( boolean )` so that we log something when it's disabled as well?
oh? no classloader juggling necessary?
Лучше сделать методом класса Server, подписываться на сигнал в начале метода Server.run
Comments need rephrasing.

Try something along the lines of
"Internal utility: Wrap `value` as a simplified promise that always resolves to `value`. Note the result is not a full promise, as its method `then` does not return anything."
```ruby
notifies :reload, 'ohai[reload_nginx]', :immediately
```
Wasn't intentional, but happened to because `FONT_MAX` isn't used for its value. Yes, should go after `FONT_MAX`.
Ah, I see what you mean.  No, I don't think an error should be thrown here.  Instead I think we should leave the original text in the string, so instead of `"5 houses"` you get `"%{houses_count:houses}"` without any replacements.

However!  I've been considering for a while whether to include a global option to raise errors instead of just letting things slide.  It really depends on the use case.  At Twitter, we would most likely not want TwitterCLDR to raise errors because we occasionally launch features that aren't 100% translated anyway, but other projects (or other companies) might feel differently.
(Hopefully this won't start a riot): Should these be camelCase?
2012/5/24 Vincent Bonamy
<reply@reply.github.com>:
> Je viens de regarder rapidement, finalement ce code tel que proposé prend déjà en compte le cas de l'attribut affiliation multi-valué  non ?
> Cf le .get(0) de RunnUtils
> affiliation = (String)attributes.get("affiliation").get(0)

Si affiliation contient tjs xxx@yyy, effectivement.
Je me pars me cacher /o\
Agreed, and I've taken the liberty of going ahead and doing it myself.
Also, this true_result is much lower than test_abs_err.  So it's not much of a test.  Maybe change the limits to -15..-14, which will be about 7.8e-9, so still above abs_err, but below rel_err.
I left this as is, but put the double comprehension method in config/image.py.
I actually disagree @billrob. Let's chat tomorrow
On May 29, 2012 10:32 PM, "Bill Robertson" <
reply@reply.github.com>
wrote:

> > @@ -73,6 +73,11 @@ public PurchaseRequest()
> >               /// </summary>
> >               public bool UsePromotionalPrice { get; set; }
> >
> > +             /// <summary>
> > +             /// Id used by publisher to identify the user associated
> with this purchase.
> > +             /// </summary>
> > +             public string ExternalUserRefId { get; set; }
>
> @AChusuei Sorry I missed this discussion.
>
> ExternalUserRefId should be on the ConsumerInfo object.
>
> @pmn4 We will consider adding it to the profile methods and bake it fully
> to the consumer object.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GroupCommerce/sdk.dotnet/pull/42/files#r897564
>
Perhaps I am confused here. I added logic to the LWRP to check to see if the server is licensed via the `licensed?` method.

I added an only_if to provide for cases where maybe I don't care about licensing my server, like if I'm using the OSS Nexus.

I could remove the `only_if` and add more logic to the LWRP in a way I describe above or through some other things, like if the data bag doesn't exist then I don't have a license to install.

As it is right now, the LWRP won't install a license more than once, but I can see the value in not licensing at all in cases where its not Nexus Pro.
assessive is good
@jrbl 

I know I'm commenting on a closed pull request here, but I think this is useful.  It would be better if you tended to use dict/objects more as your data structures rather than lists/tuples.  The we might have data[i]['type'] instead of data[i][0], which is much harder to de-reference.
remember that I updated the model fields for exams, so `create_ready_instance` and its friends will have to change.  Perhaps I should just open a bug.
You shouldn't get a new one here, you should use the getoptionstype method with the new as a default, otherwise it won't work if someone has already setup that type of container.
I will append `.id`.
The backslash is not necessary. Also, please leave a trailing space after the period.
That line it was for the castaña-machine. It's not necessary with the new one ^^
All these double negatives are getting confusing here...

Am I right in describing this conditional as follows?

> Add some `Content-Type` and `Content-Disposition` headers if a `controller` object is present and it's not an instance of `ActionMailer::Base`

If so then it could be rewritten as:

```ruby
if ( controller.present? ) && !( defined?(ActionMailer) && defined?(ActionMailer::Base) && controller.is_a?(ActionMailer::Base) )
```

I don't mind doing this once it's merged in.

Cheers,

Paul
Can use @@config.has_key?()  or @@config.key?()
I know the task description said that we should omit shard_id if the header is missing... but I also know that Ops and Architecture value machine-parseable log files. A field that is sometimes present and sometimes absent, is not very machine-parseable.

If we don't want to have a sometimes-present field, perhaps we could just log "Shard_id: default" when the shard ID header is not present.

It depends on what Ops wants however, since they asked for the change in the first place.
cool, I'll take a look at it.
This conflicts with the comments in the `add_bcc` method:

 > As of publication, only the Web API supports BCC
Yes, because we're monitoring the internal index and every request to splunkd causes events to appear.
Not English. Should be something like:

"The jobs endpoint only returns an outermost <entry> element, instead of an outermost <feed> element with an <entry> element embedded inside."
Regexes are handle by the compiler as far as I know.
what does abhi plan to do here?
I may end up throwing this out. I'm looking at the edit_skin and I may just create a new skin and have the user set its values. I'm leaving this for now. I may or may not use it. This is just extra code. The main purpose of this pull is for more templates.
Please add an error and completion handler. to this executeAsync
instead of clientWidth / height it might be better to use `lively.morphic.World.current().visibleBounds().extent().scaleByPt(pt(1/3, 1))`
I would suggest something similar for how we handle device driver handles in pios.  Pass around an opaque void pointer that any of the drivers can use.  In this case for UBS it would be a struct *USBInfo.  Then to be safe put a magic enum value at the end of the structure so you can validate it is a valid one before you attempt to deference it 

    struct  device {
        ...
        void *drive_info;
    }

the in RawHID::openDevice

    struct USBInfo *usbInfo = (struct USBInfo *) device-->drive_info;
    if (usbinfo == NULL || usbinfo->magic != USBInfo::MAGIC_VALUE)
        return false;
    int opened = dev.open(USB_MAX_DEVICES, usbinfo->vendorID, usbinfo->productID, USB_USAGE_PAGE, USB_USAGE);

this way we don't force information specific to one implementation into the general interface.
Yes, I feel like there are a few and/or possibilities here and I wasn't ready to commit to any of them yet:

* Look for /etc/aeolus-cli if ~/.aeolus-cli does not exist by default.
* Accept an argument that points to the config file, as you suggested.
* Accept site/username/password as three new command line options that override the config file (if the config file exists).