labofsahil/github-event-dataset-2012 huggingface dataset:
Her er synderen: https://chrome.google.com/webstore/detail/kbmipnjdeifmobkhgogdnomkihhgojep - gir en <div class="extLives"> på slutten av body.

Om vi skal ha denne greia, så bør vi vel kanskje bruke en form for detection som ikke går på CSS?
Would it be possible for you to hand me over a diff against the original version? That would be kinda helpful.
All i wanna say is You are Goddess !!!
http://pastebin.com/8sKiixaG
No reason to leave old code here unless you plan to use it again at some point.
I've removed all the permissions stuff to later integrate with PEX, bPermissions and PermissionsBukkit directly.
this case is specific and in this case a person is *forced* to set his special RewriteBase in .htaccess. So he will only need to modify the rule value.
thanks to: Shocker
maybe this one?:
elsif Rails.version =~ /^3\.[1-9]/
Thank you for this patch,
But can you please tell us what is it add? and how is that we OK without it?

Thanks allot any way :)
Ignore this commit, straight on to next.
Yeah, I can't see why not. Does jack-in even work with tramp?
I believe it'd be nicer if we did it like this

Change line 55

```python
if 'error' in rsp and 'code' in rsp:
```

to

```python
if not isinstance(rsp, bool) and 'error' in rsp and 'code' in rsp:
```

What do you think?
this comment is probably unnecessary
Проект для поупражняться в рельсах?
Sorted it - much simpler now, thanks. Details sent to freeradius-devel (two patches at https://github.com/mcnewton/freeradius-server/commits/master)
I deleted this error log since it is no longer needed.
Did you make sure to also build with ENABLE_BCM_4329=true for the above?
I'm not a big fan of half-adding features and commenting them out, it just leads to confusion on the long run.
Maybe it is better to forbid them at all?
With branch 2.0, bundle is still broken. See issue #90
But maven and ADT team already started working together on it!
https://groups.google.com/forum/?fromgroups#!topic/adt-dev/U2sdaC2bsNY
I hope that it will have some result.
In Intellij IDEA, the properties will be changed back to 14 automatically according to android-maven-plugin settings.
http://blog.stevenlevithan.com/archives/faster-trim-javascript
My assumption is `if-unmodified-since` checks against the timestamp on the server of the last client record upload.

In the case where `if-unmodified-since` rejects the upload, we *do not* upload after processing commands because it means another client uploaded our record with commands so we need to process it first.

So if our local `serverClientRecordTimestamp` was updated when we last uploaded our client record, then uploading our record after processing our commands will fail if commands were uploaded by another client after our last upload.

Does that make sense or am I missing something?
That's what I figured out from sniffs at least.. some can be wrong :P
would be nice to have a little explanation here for what our preprocessor is doing and what it is used for
So the parts of the query are joined with spaces, effectively being OR queries?
Is that intentional?

Yes, this is not the current version, but this is where it was introduced.
Blogging is way too much time. The wiki is more than enough actually to support the project.
Nice comment, very appropriate.

I do recommend moving a little closer to spite and away from frustration though, it will convey more confidence and less desperation.
I've even tried setting the matrix so that all axis should show the same value but nothing changes. It seems like this matrix isn't used at all.
There is an insane amount of stuff like that in Module::Build.  Things that seem simple refactoring/cleanup wind up having unexpected consequences.
You would think as many times as I have done this I would remember. Thanks.
qcom_ui.h is missing. "LOCAL_C_INCLUDES += $(TOP)/hardware/qcom/display/libqcomui" should be added into Android.mk of libstagefright project to finish the compilation.
Thanks @broady, much nicer!
Maybe the pattern `Result.(catch foo x |> is_exn Bar)` is clearer?
so you are telling me that you have working mic with new drivers??
you remember what commit fixed it?
Yes, it works as they claims it should. You can see it in action here http://twitter-bootstrap-on-rails.heroku.com/. Just click the x you gave me :)
Suite aux modifs, deux tests semblent ne plus passer :
SolutionTest.testAddReactionRule()
SolutionTest.testReact()

J'ai modifié testReact() pour qu'il soit plus pertinent, mais apparemment les RR ne sont pas ajoutées, donc rien ne se passe.

D'où probablement un souci au niveau de Solution.add(ReactionRule).
I hope it will not replace string-lambda template syntax where the old one behaves better:
`map!"a * a"`
look batter than
`map!(a => a * a)`
By the way, filled [Issue 7357](http://d.puremagic.com/issues/show_bug.cgi?id=7357) for the syntax proposed in my previous message.
The reason we didn't go with that is because we want developers to mix and match responsive and non-responsive behaviors on a page. Stuff inside a `.yui3-g-responsive` automatically collapse to 100%, but stuff inside `.yui3-g` doesn't (which is useful if you want to have a 3x3 grid of images on a mobile device or something).
This needs to be: `YArray.map(items, this._modelToObject)`
Shouldn't it inherit from SimpleList or ListBase?
Update `man_tronfig.rst` as well.
I'd definitely recommend against stringifying a Message since that could potentially be _huge_
Lol, yes, I agree ,but the common terminology for the interval of heartbeats is known as the pulse ;-)
We definitely want to help the user identify which setting was missing
should directly transition to RefStopped, no need for `busy`
This will break if we ever change the node ring sorting from plain name to something else right?
Was just writing up that comment as well. Will rewrite the code.
rely on `unhandled` instead?
currentFailureCount should perhaps not be public?
if we change that to private[akka] we don't need to care about this case

On Sun, May 20, 2012 at 8:13 PM, scullxbones <
reply@reply.github.com
> wrote:

> > +    def enter()(implicit executor: ExecutionContext): Unit = {
> > +      _enter()
> > +      notifyTransitionListeners()
> > +    }
> > +
> > +    def _enter()(implicit executor: ExecutionContext): Unit
> > +  }
> > +
> > +  private object CircuitBreakerClosed extends CircuitBreakerState {
> > +    val failureCount = new AtomicInteger(0)
> > +
> > +    override def invoke[T](body: => Future[T])(implicit executor:
> ExecutionContext): Future[T] = {
> > +      callThrough(body)
> > +    }
> > +
> > +    def callSucceeds()(implicit executor: ExecutionContext): Unit =
> failureCount.set(0)
>
> This is true - I don't see it affecting functionality but it could be
> confusing.  Should we guard with a current state check here?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/466/files#r850604
>



-- 

Patrik Nordwall
Typesafe <http://typesafe.com/> -  The software stack for applications that
scale
Twitter: @patriknw
Why not cache the toCamelUri instead of the ActorRef?
Thanks Dan. I'll amend now.
Do you mean we should get the distribution from scipy.stats and sample from that? They way I wrote this, we are getting a sample (or samples, for the Rician case) of Gaussian noise and then all the rest is just to get it to have the right variance, so that: 

SNR == var(signal)/var(noise)
Ah, and this function will be used within Jinja. So, it will not be possible to call urllib. Or I totally missed that possibility. But AFAIK, one has to define them outside.
Looks sensible, I'll make the change now and verify it when I test that all this command restructuring works.
Oh, I suppose you were referring to clean_db(). I actually didn't write that part, it was just from the old method. I have no idea what the intention of that method was, or when it gets used, so I didn't want to mess with it since it wasn't related to the migration stuff that I was doing.
Let me know if your name suggestion is final and I will update it.
Well the originating code was from the original video base window. ie not playlists. So it's strange.
What's the difference between these and iWidth/iHeight - perhaps a comment?
The side effects don't need to be methods, they can be inline functions in `setUp()`.
This really merits a comment so that a well-meaning person doesn't change it back to `'0.20'`. I'd include "MAPREDUCE-2361" and [a link to the Hadoop release notes](http://hadoop.apache.org/common/releases.html) at the very least.
Oh, I really was dumb.
I noticed a similar error in the SDManagerTests (which I pulled a moment ago, oops.). I've submitted pull request #286 to patch that.
This if () can be removed as the timezone is never null now.
Hmm… surely we should just remove it from the header? Pretty dumb that we are exposing methods which just don't exist.
This is not dependent either. The control could be selected, and the highlight would be during deselection.
This makes a copy. Might be worth checking if the constructor that transfers ownership is faster.
Should we do use the old signature here? `dns.isIpV6(ip)`
Should it have "radians" somewhere in it, too?
Mets ça sur plusieurs lignes. Une ligne par paramètre. Aligné avec :address
Wouldn't this create a new iterator which adds some GC pressure?
Message should be "Escape string must be a character"
Use the proper indentation.
`Collation is not supported...`
Please fix the indentation of the `=`. It is too much.
Removing this I get a failure in railties:

```
  1) Failure:
test_0042_config.action_controller.permit_all_parameters = true(ApplicationTests::ConfigurationTest) [test/application/configuration_test.rb:582]:
--- expected
+++ actual
@@ -1 +1,27 @@
-"permitted"
+"<!DOCTYPE html>
+<html>
+<head>
+  <title>We're sorry, but something went wrong (500)</title>
+  <style>
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+
+<body>
+  <!-- This file lives in public/500.html -->
+  <div class=\"dialog\">
+    <h1>We're sorry, but something went wrong.</h1>
+  </div>
+  <p>If you are the application owner check the logs for more information.</p>
+</body>
+</html>
+"
```
I think that `,` is not necessary, is it?
> I disagree, these are the exact same thing. "Something which is not final will be made final in the future." It would be like having separate "deprecatedClass" and "deprecatedMethod" annotations.

Agree, I don't have strong opinions about it. It is just that I haven't found a decent name combining both use-cases, that's why I currently prefer `@deprecatedInheritance`/`@deprecatedOverriding`.
Doesn't that need a deprecation cycle?
I'm not sure which case you mean, but neither of those cases simplifies to best :: Nil.  If you mean the second case, it also includes Nil (which does come through in practice.)
No, it is just about initialization order. I realize that is not entirely obvious.
nit: do you we want to standardize on brackets always for single line statements?
Thanks for the pull request.  I did notice that expansion hints were applied several times, but it didn't occur to me that it should have such effects.  On a side note, do think it would be possible to fix `expand` to only go through hints a single time?
>
> The surd function is confusing me (the docstring is not very clear, aside
> from the fact that I did not know what a "surd" is until I looked it up),
> but based on what I saw, I suspect the new result is wrong.
>
>
@pernici can say for sure, but I think it's ok. It's just splitting up
surds into groups having a gcd and those that are relatively prime to that
gcd.
Makes sense, I think. We'll discuss it in detail when I get to the diagram drawing PR.
common is referred to in the file...are you sure nothing needs to be done with it on return?
This was not a tuple rather a generator. And it did not work originally with generators.
This is true if neither of the limits is `0` or `+-oo`. But my point is that I do not think `gruntz` can use this "series expansion".
Its good idea to use ternary operator «? :» since its core.
type missing.
should it be `type=ajax` ? @jusuff ? it isn't admin or user...
If the filename is always feedback.png, why does it have to be defined here? Could we avoid passing the screenshotName as a parameter altogether?
Abstract already has this exposed. So, Tip2$element is public.
Should be `earlier::` to signify a code block is next.
I am not hapoy with this change. That `--std=c89` isn't used because it looks so nice.
Okay, let's fix that then.
Why is this nescessary?
Again, for the avoidance of nulls, I think endTime should be an Option too
Looks like a `push -f` update after a rebase orphaned the comments that were here.

Anyway, this import is here, rather than at the top, because it would be a circular import (and thus an error) if it were at the top. This module is imported by `wiki.models`, so this module cannot in turn import `wiki.models` until later on at runtime.
There should be a note here indicating that this is not currently safe until we have a `Pod` trait.
Typo `Cahnged` -> `Changed`
Var name could be like $style_is_active, also there's double ; at the end of the line.
Capital letter at the beginning of comments
Not really as its updating the user's name according to the code, not the username.
Well, there has to be a verb in there somewhere, right?
Is this compatible with phpBB 3.0.x? If not, please use proper naming, i.e. `$timezone`.
This implementation does not make sense. A 0x0 avatar will be invisible. My feeling is you can simply delete it. If so, apply the same reasoning to the remaining functions in this class and delete all of them that do not make sense.
Counting seems unnecessary here as the array seems to count for you. You can use `$unapproved_topics_count = sizeof($unapproved_topics_array);` after the loop.
It looks like self._latency = 0 is the initializer. Shouldn't it be initialized to max int or null?

Also, what is min_latency initialized to? Shouldn't it be MAX_LATENCY too?
@rphillips it does
I'd like to see us replace all one-off merge routines with a single one from utils.
Forms -> Stateless
done in commit 650d1b0273827ca1e0175fdaf4852732620af9f4
Cool, will do it.
i did run it. Missed that one by chance. Will be more careful with it from now on.
On Fri, Mar 16, 2012, Olivier Delalleau wrote:
> Can you confirm that all deletions in this file are intentional?

They were all "variable declared but never used" errors according to
pyflakes, and I checked that no call to "locals()" would use them.

I should probably have put them in another commit.
-- 
Pascal
Comments? At least one line on what this whole business is about, and what part of the StackVM it's mirroring.
Weird double zero.
you can ommit header_name
Let's make this more functional

```coffeescript
isAsset = !!paths.assets.filter((assetPath) -> helpers.startsWith path, assetPath).length
```
The style guide requires that these data members have the non_camelcase_style_ with an underscore_ at the end : http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names . 

So unless there are compelling reasons not to do it this way : 

doc -> doc_
xpathCtxt -> xpath_ctxt_
currentXpathObj -> current_xpath_obj_
We decided smart pointers were overkill for simulation agents for a few reasons:
* there are relatively few active agents created during the course of a sim (hundreds maybe)
* the agents are generally in use through the majority of the simulation (or at least a good portion).
* creating/casting smart pointers is uglier/"harder" than creating plain pointers
* manual memory management of agents is a maneagable task since ownership of the objects doesn't generally change.
See line 856. These local variables will be separate from other components once we separate each one out and use a build process.
It's best practice to use common string substitution.
should be string_types[0]
Hmm, that's a good point. Any sane migration framework wouldn't try to submit changes to these, and sometimes you _do_ want to create tables for unmanaged models, anyway. I'll change it.
Please fix the formatting:

```php
switch (func_num_args()) {
    case 0:
        $statement = $this->_conn->query();
        break;
    case 1:
        $statement = $this->_conn->query($args[0]);
        break;
}
Do you think fval is necessary in DISTRIBUTED BY?  If breakup table is distributed by fid, and as the join condition I saw below is COALESCE(...), only fid may make more sense.
The ideal solution would be to populate this from the .gitignore file(s). For now, maybe I should just add those entries manually.
LMFTuple is used here: https://github.com/madlib/madlib/pull/175/files#L4R28
Another good catch.  This has been corrected.
Its from the spec, ObjectID's are 12 bytes - 24 characters long
Validation could be better

http://www.mongodb.org/display/DOCS/Object+IDs
Do we catch ValueError correctly if someone passes in a non int, or do we just trust that the regexp we use in the current frontend is good enough.
One thing is that this doesn't add email addresses to the index. I don't know if we want to do that, but it does have the implication that if we're doing reports using solely the index data, it won't include email addresses. Just something for us to keep in mind when/if we end up doing reports.
Why are you using `test` on them, just to see if they were installed? Is there no test you can do by running them? If not, this test can just be removed.
This is the second edit needed - just to make sure the page class is aware of the 'current'/'base' directory of the wiki.
I'd rather never try put USSD menus into the Vumi message format. It's not clear to me that there's enough of a common definition of what menus are to make it useful. Obviously individual transports and applications are free to do what they like. Some sort of helper utility for dealing with lists of options at the application level would be pretty cool.
Do we want to join on `", "` or just `","` here?
Looking at this now, I suspect `content` shouldn't be part of the `history` list, probably will head & tail it.
LGTM. I like your reddit.com suggestion. I have to think about that, so let's table it for now.
The newFiles[i] and its keys are used multiple times, maybe you can save it locally to improve lookup times.
The sprint components shouldn't be included in the rainjs conf.
Why are these method names capitalized?
Thanks - added one extra assertion for good measure.
Um... I think that's actually standard for maven sub-builds and the like for console output.  It's at least not atypical.  I'll change it to spaces as it's not that big a deal which way.
Seems like people still want to be able to back up onto CDs/DVDs with Joliet FS where file path limits are much shorter
http://forums.zotero.org/discussion/24083/backup-with-file-name-too-long-ii/
http://forums.zotero.org/discussion/10449/backup-with-file-name-too-long/

What limit would you like to impose? 50? 100? 100 seems quite excessive to me, but it's ultimately your call.
We could reduce the duplication between this class and the next one:

```
public abstract static class AbstractTimeout {
  // fields _except_ for @Rule

  @Test public void run1() { ... }
  @Test public void run2() { ... }
  @Test public void run3() { ... }
  @Test public void run4() { ... }
}

public static class HasGlobalTimeout extends AbstractTimeout {
  @Rule public TestRule globalTimeout = new Timeout(20);
}

public static class HasGlobalTimeUnitTimeout {
  @Rule public final TestRule globalTimeout = new Timeout(50, TimeUnit.MILLISECONDS);
}
```
Yeah, I thought about that but it's not obvious what problems this might cause: who depends on the lexicographic ordering of two methods with different names that just so happen to have the same hash code?

I don't necessarily have a strong preference for that hunk of the 29b8870 commit, I just did it because the original behavior was so close to that and with that change you get (what I consider to be) a nice symmetry with NAME_ASCENDING.
Should mention options in docstring.
We could probably emit the events on the model from the `lifecycle` state machine:

```coffee
product.get('lifecycle').onEnter 'dirty', -> ...
```
is equivalent to:  

A)

```coffee
product.on('lifecycle:dirty'), -> ...
```

B)

```coffee
product.on('enter:dirty'), -> ...
```

or C)

```coffee
product.on('dirty'), -> ...
```

@jamesmacaulay @nciagra @Sija which do you think is friendliest while keeping the events scoped properly and client-code friendly?
Maybe a comment describing exactly what you're testing here (invalid characters)?
fixed

From: Glenn Ruehle [mailto:notifications@github.com]
Sent: Tuesday, August 14, 2012 1:10 PM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Combine jdiel's "language switching" pull request with tvoliter's templatization of index.html using mustache (#1358)


In src/strings.js:

> -    exports.CMD_TOGGLE_QUICK_EDIT               = "Quick Edit";

> -    exports.CMD_QUICK_EDIT_PREV_MATCH           = "Previous Match";

> -    exports.CMD_QUICK_EDIT_NEXT_MATCH           = "Next Match";

> -    exports.CMD_NEXT_DOC                        = "Next Document";

> -    exports.CMD_PREV_DOC                        = "Previous Document";

> -

> -    // Debug menu commands

> -    exports.DEBUG_MENU                          = "Debug";

> -    exports.CMD_REFRESH_WINDOW                  = "Reload Brackets";

> -    exports.CMD_SHOW_DEV_TOOLS                  = "Show Developer Tools";

> -    exports.CMD_RUN_UNIT_TESTS                  = "Run Tests";

> -    exports.CMD_JSLINT                          = "Enable JSLint";

> -    exports.CMD_SHOW_PERF_DATA                  = "Show Performance Data";

> -    exports.CMD_NEW_BRACKETS_WINDOW             = "New Brackets Window";

> -    exports.CMD_USE_TAB_CHARS                   = "Use Tab Characters";

> +    'use strict';

Should be double quotes.

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1358/files#r1376639>.
good catch.
actually is there a processType that we don't want to send to client?
As noted above.... we still need this check.
It looks like a lot of duplicate code that could be merged into one single internal function. It should not prevent this PR from being merged but would be great to see it refactored later on
yes. This is a basic work in progress. Preferred way of execution is the maven plugin. This main method is pretty much only for testing
*form_error* -> *field_error*
I thought they were done like that because of the API functions. Not because of the column names in the db. 

Anyway, I'll take a closer look.
Why didn't you just keep this line instead of resetting the editor to `plugin-list`?
These are random changes...
Why 10?  Also, why on a timeout?  This will already happen async, since you pass in a callback.
By changing to `CONFIG.server.bindIP` it'll output `localhost` as opposed to `127.0.0.1`, which is what was tripping up dseif
There's a ticket that removes this Facebook line. make sure if this lands before/after that we handle the merge conflict accordingly.
Needs transitions
space before opening brace.
There is a store Mmap, but it has a different (more posix-ish) calling sequence, where as MapFile only does read only mapping.   A real mmap allows read/write mapping of files which you can only do with kernel mounts, so one could argue not to have a Mmap API in iostore at all (though it could be used as an optimization, e.g. like with MapFile).
What's the preferred format?
The tastypie docs talk about using `PATCH` to update only some fields, did you try that?

http://django-tastypie.readthedocs.org/en/latest/interacting.html#partially-updating-an-existing-resource-patch
Don't you mean `0.0.2` here?
Isn't that logic inherently wrong. I'd think any_readable will return true if the user merely has permissions to read systems in an environment or permissions to read system groups. It should not be dependent on the Number of systems in the environment Or the Number of systems in a system group.
Just shooting - how about trail slash? Does katello directory statement has trailing slash?
I'm curious. Why did this script need to change from symlinking to file copying?

The above comment is out of date now that it is no longer a symlink.
No, no, you're right. Round. Neg tests look good.
Update will also need two contexts, similar to create
How about dynamically created assemblies or just assemblies loaded at run-time from sources/directories not visited by BuildManager?
Do we want an l10n ID here?
I saw that, yeah.  That's only for PUTs though, right?  And I don't see where the prefix goes, is it a query param?
I'm not a qt expert either, but looking at the code for Mac OS X, dpi are always forced to 72. Look at src/qt/src/gui/painting/qpaintdevice_mac.cpp

So I've forced 72dpi on linux too. Maybe a different approach is better than this.
It would be nice if this worked on readable file objects, too.  One would have to read the magic and then seek back to zero.  If it's a stream (i.e. doesn't support random access), you can put it in a buffer object to make these small seeks work.
No, they really should if they're going to be used at all frequently.  Although compiled regexps are cached there's no guarantee as to whether they'll stay in the cache.  I think also giving a regexp a name (in the form of a variable) makes the code more readable, not less.
Also a `ConfigurationItem` ?
不过我发现我对代码的要求貌似真的不高。。。实用就行。
Holding the cs_proxyInfos lock all through ConnectSocket and it's subroutines is bad practice.

How about something like:
    proxyType proxy;
    {
        LOCK(cs_proxyInfos);
        proxy = proxyInfo[addrDest.GetNetwork()];
    }
    ... proceed, with local copy of proxy...
I'm on the fence with this one, never like {} for strings
ayni sekilde out = goog.array.filter is gorur.
Shouldn't this be AutoLoader?
OK.  Just remembered after looking at the changes why it can't go in utils/text.py (cross-dependency)
Do we use the start year of the project or the file?  The file was created in 2011, not sure where the 2008 came from.
Sorry, that commit shouldn't have been part of this pull request.

We had to switch to our git version of browserchannel for the unicode/u2028 fix. Once that fix is released in a new package we'll switch back to your version.

I'm not sure how to remove a commit from the pull request, sorry.
Once again: two paths. The normal one, and a `on_error` label that performs cleanup and returns -1.
Thinking about this function again, I don't like an "is" function doing stuff. So I think you should limit it to DOM manipulation, rename it and move it to `privacy.js`.
Checking if doNotTrack is enabled is really one line so no real need for a function in util.js for that.
The name I have given for the variable was just an example. When looking at this function we do not search for the socket but trying to connect to the given port at the host. So 'connected' would be a much better name here.

Mind also adding a blank line before the while loop so we separate those blocks?

Otherwise looks good and I'm happy to get this checked in.
A few of the new tables do require this function still, so leaving this one in place.
`newCondition = LegacyThrottler.regexpHandlerFactory(condition)` should be `newCondition = self.regexpHandlerFactory(condition)` otherwise you loose the OO ability to override in sub-classes.
can just do:
```
signature = self.java_hex_addr_killer.sub('@<addr>', signature)
```
I've switched to ci() as its easier to deprecate a function than a property.
I run tests again. I have not noticed that I am skipping tests, terminal says

```
unable to find Stylus compiler: skipping stylus tests
```

I don't understand how to correctly configure load path for testing. I have stylus gem installed, and I have tried
```
ruby -I~/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/stylus-0.6.2 test/stylus_test.rb
```

Can you help me with this?
Awesome. Will add.
this was explicitly rejected a while ago, as it will degrade performances for people using the real intl classes by loading the file on each request whereas it is not needed
It is a copy from our production code, and there we always alias it to EntityManagerInterface so we can see right away that it is an EntityManager that is expected as an argument.
If you see the word "ObjectManager" it is not immediately obvious that it is an an interface, and an interface to the doctrine EntityManager.
but why not keeping the ``{% include %}`` tag like previously ?
I don't understand. `addPrefix('/prefix', array(...), array(...));` with defaults and requirements is not deprecated.
I find it weird to name a method ``validate`` when it returns the catalogue
Ok, thnx, i'll come up with another implementation later.
Indeed. I meant to type "collections" there.
fixed indentation to two spaces since I had to look at it to figure out what was going on.
Added a TODO here.
No good reason. I'm cool with a variable if that's how you guys like to do it.
Interesting, this was wrong all the time? I have tried this pattern for weaving fields for progressive but did not work very well. I thought this was because I tried on 720 and a weave together with an upscale would not work. What do you think? Should this work now with 720p?
This probably needs to be wrapped in a special cassette from what I seem to recall @jlsherrill running in to.  Also, these calls I found were helpful to wrap in rescue blocks.
Could you please give an example, I'm not sure I understand. :)
Err sorry - I think I said that backwards.

But I'm still confused. dy is potentially 0 here right? So isn't this code just making dx = 0 too potentially?
The implementation below should also pass those specs:

```ruby
def whenever?(*)
  true
end

def delayed_job?(*)
  true
end
```

;) Add tests cases when they return `false`.
Not tested anywhere. I haven't tested this with any downstream packages (e.g. Iris) which might warrant this get put back in, but otherwise I would sooner know about it if this is failing. Thoughts?
Can simply use `@hand_contents[name].join(", ")`
this is fine, but fwiw, we support org-mode style tables
当是localhost的时候怎么办捏？
you could just use relative, rather than global bindings, then you could avoid having to teardown the global
This does not look thread safe, is this an issue?
Same as KEYSTORE_TYPE
Using
 ````
.addClass( "ui-front" )
````
instead of 
````
.zIndex( this.element.zIndex() + 1 )
````
as Jörn said does not work when Selectmenu is inside a Dialog (see compatibility visual test). Do I need to adjust some CSS or something?
你说的这个有一定道理，但是在我们这里面不适用。

我觉得我们支持多种汇率付款，完全是为哦方便用户，不是为哦多收一部分客户更多的钱。我们一开始把价格定高，它就是对所有人高，不会因为用户来用支付宝付款，它就会变低。也就是说，我们标出的300块钱修风扇，不来的人就不来，来的人不管是哪个国家的，都是300。不会因为用哪样支付方式而改变价格。

你举的iphone的例子，不仅是收入和心理，还考虑哦关税各方面因素。
更重要的一点，也是我们和iphone不一样的，你给中国用户定价，中国用户也没得办法在美国买，只能默默承受高于美国的价格。

如果我们的用户发现用人民币付款和用美元付款差别这么大，不仅会觉得我们的产品有欺骗性，还会觉得我们的网站特别恶心，歧视中文不好的用户。仅仅是换一个支付方式，价格就会相差这么多。

我觉得现在不会做，以后我们也不会做不同支付方式收不同费用的应用，在这一点上，我们完全不需要跟苹果学。退一步讲，你就算学得来，也无法控制用户不能换一种支付方式取得最低价格的付款渠道，这样一来，我们的那个美元价格才是一个真正的鸡肋。

我的观点是，我们的各个币种的价格之间，唯一的联系就是汇率。我只想做一个真正的正常的汇率模块，而且它是可以通用的，和应用背景无关。

而这个汇率，你可以先整成固定，不用往数据库加任何东西，有时间我们再换成实时。

至于你说的考虑各种系数，平均收入的汇率转换模块，这种系统肯定有它存在的价值。但是我觉得应用背景太窄，你现在随便打开一个网站，用的都不是这种系统，用的都是正常的系统。不管是旅游网站，租车，订机票，电子商务。
我觉得这种系统和我们要做的系统应用背景差得太远。
Was a comment. It seems that not a very clear comment :D
Even if cool_apps is a cool name  I don't think this is a valid name for a directory :)
Fixed. contact will return callback if 1) cache exist. 2) db returned (no matter the result exist or not). If error occurs while accessing db, contact manager will return null for user to handle.
As for your suggestion, detach the iframe from DOM and change it's location will cause it to reload, so we couldn't do that. Besides, alarm ring screen should be on top of the call screen just because the clock app is being switched to.
Nit: I hate underscores, but our guidelines say that it should be `gesture_detector.js` instead of `GestureDetector.js`.
Pretty odd to use member constants, but I guess you do this in other places in the browser too, so I will let this one slide.
Excuse me Vivien, I don't understand this note.
Let's move this callback to value selector entirely
Indentation please…
What if the user puts more keys:values on every element? I would go for a closed object like
```
{
  title: 'My element title',
  callback: function
}
```
instead of using the key. You will avoid the second 'for' then
What's addresses?
At the other hand, shouldn't we return false?
No worries :) As mentioned by @ferjm the onsuccess and onerror functions are passed and event which target is the request ;-) Thanks!
`suite` indicates a grouping of `test` blocks what you actually want here is `test` not suite.

Assertions must be inside a test block for example..

````js

test('#to', function() {
  assert.equal('one', 'one', 'my message');
});
````

Even if those assertions pass/fail they happen outside of the scope of the runner and are never reported (because they happen before tests run)

You can also read up on how to write tests on the mocha site: http://visionmedia.github.com/mocha/#tdd-interface (which is what we use to write/run tests)
'Unexpected sort criteria'
Jak Jirka podotknul, tady je to modulo úplně zbytečný, protože ten úhel používáme pro JavaScriptí trigonometrický funkce, kterým x co není v 0..2π nevadí.
why is this an "assert" as opposed to a "raise" for the NotImplementedError?
You are incrementing the iterator twice. Is this correct?
This method needs a unit test.
+1 to use of Objects.xxx
Just so we're clear, `astropy.table` is part of the astropy core, now, which means it's a dependency of this package (``setup.py`` has `` requires=['astropy']`` in it), so I don't think it affects the "modularity". 

But your point about it being more naturally used as part of `Image` is reasonablem if after looking at `Table` you decide it would be awkward in this setting.  I'm just mildly concerned that by the time that's working, people will have already started using this... but I don't have a terribly strong opinion.
Same with this number.
And thanks for the review. Sorry for +2 alignment. :)
Ah, ok. I just saw the "import new" variant in other places.

I thought I remembered something about this versus Python 2.4 compatibility, but my memory was wrong.
implemented in 3d4693f
Thanks for the fix!

I wonder why you change the regex here. It means that for `DISPLAY=:0.0`, `display = "00"`. Is that intended?
an example of how to write an async method documentation
Not sure why these are removed
yes, IMO build a multiline log message with all warnings.
This does not seem readable...
unless 100% necessary we should stream the output, instead of collecting an array and outputting at the end.
Just `0.8.x`
This comment is true, but very little useful. Let's explain that better.
Can you just make rule an alias for error? "rule" is not really a level in it's own right, we just need it to make the API backwards compatible.
Only for normalize I think that is better do a post-increment.
is it about code formatting?
Need to bench it agains

```javascript
var matchKeyframes = token.substring(i).match(/^@((?:-\w+)+-)?keyframes\b/);
```
This is totally wacky - I'll try to put it back the way it was. But for some reason only this worked.
I think it might be safe to use the Controller as the discriminator. We could do:
if (controllerContext.Controller is ApiController) 
{
    // ...
}
Unfortunately I see a possible regression with this change - CreatePackageAsync does CommitChanges inside CreatePackageAsync. If we move it outside the transactionscope it's breaking the transaction.
You should be able to set this.
`if (this.model.getAllAsArray().length > 0) {` -> `if ( this.model.getAllAsArray().length ) {`

Space inside parens
I think prefixing the modules with "mvc-" and having the `Y.MVC` namespace is confusing. How about this for the module names:

* `todo` provides `Y.Todo`
* `todo-list` provides `Y.TodoList`
* `todo-view` provides Y.TodoView`
* `todo-app` provides `Y.TodoApp`
-> `typeof JSON !== 'undefined' ? JSON.stringify( tasks ) : tasks;`
it was the goal when I first write this, knowing what corresponds to each field
Is there a reason to iterate through all matches here, and then break? Can a cuesheet have more than one genre? Would it be easier to just write ``` @cuesheet.scan(@reg[:genre]).first``` ?
@samiluukkonen Miksi 'and $toim == ""' ehto on poistettu?
Ei ole mahdollista, että kassalippaalta puuttuu tilitietoja. Ne ovat pakollisia. Tarkistus tehdään kassalipastarkista.inc tiedostossa.  


On Tuesday 6. November 2012 at 13.19, harjis wrote:

> In myyntires/eikateinen.php:
> > \ No newline at end of file > + if ($myysaatili == "") { > + if ($kateisrow["kassa"] != "") { > + $myysaatili = $kateisrow["kassa"]; > + } > + else { > + $myysaatili = $yhtiorow['kassa']; > + } > + } > + } > + else { > + if($laskurow['kassalipas'] != '') { > + //haetaan kassalippaan tilit kassalippaan takaa > + $kassalipas_query = " SELECT kassa,  
>  
> Eli jos laskuriville on asetettu kassalippaan tiedot niin haetaan tämän kassalippaan tiedot. Jos kassalippaan tiedot ovat tyhjiä niin palautetaan yhtion takaa löytyvät tiedot, jos jotain on asetettu niin palautetaan kassalippaan tiedot.
> Semmoinen tuossa on mahdollista, että jos kassalippaan taakse on asetettu vajavaiset tiedot (esim. kassa on asetettu, mutta pankkikortti ja luottokortti puuttuvat) niin nämä tiedot palautetaan. Pitäisikö tuossa testata, että kaikki tiedot varmasti löytyvät? Voiko sellaista tapausta olla, että kassalippaan taakse on asetettu vain osa tiedoista?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/devlab-oy/pupesoft/pull/385/files#r2041084).
why not simply ``$cloneQuery->setParameters(clone $query->getParameters());`` instead of looping ?
No `elseif`?
you could add the comment from the PR about not using ->where() but ->andWhere to the docblock here.
As for now I have needed split_name with negative index to get last part of
a name. Returning list of lists I think is wrong. Returning binaries rather
than atoms would work as well.

On Thu, Aug 30, 2012 at 10:23 AM, José Valim <notifications@github.com>wrote:

> In lib/elixir/lib/module.ex:
>
> > @@ -462,6 +462,52 @@ defmodule Module do
> >      end
> >    end
> >
> > +  @doc """
> > +  Split the given module name into components.
> > +
> > +  ## Examples
> > +
> > +      Module.split_name Very.Long.Module.Name.And.Even.Longer
> > +      #=> [Very, Long, Module, Name, And, Even, Longer]
>
> This is actually tricker. Should we return an atom or a module name?
> Module.split Very.Long.Module.Name.And.Even.Longer #=> [Very, Long, Module,
> Name, And, Even, Longer] Is different than: Module.split
> Very.Long.Module.Name.And.Even.Longer #=> [:Very, :Long, :Module, :Name,
> :And, :Even, :Longer] Do you have use cases for this feature? I am actually
> thinking we should return binaries.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/446/files#r1499117>.
>
>
This seems a bit "verbose", but I can't really think of anything shorter off the top of my head that's still clear enough to describe what it does.
I'm curious about the choice here of class variables instead of just constants. Is there some deep magic I'm missing?
please, add a comment, like "1 is for our host, 2 is for s2s entry, so 3 is the first unused one"
Instead of just picking the first source file and assuming it's the binary installer, try and find a file named 'cplex_studio%s.linux-x86-64.bin' % ''.join(version.split('.')) instead.

If the binary installer changes name, something fishy is going on imho.
indeed. self.cfg is an instance of EasyBlock.
We should specify the branch in this path. Is the < intentional?
You shouldn't edit these files manually. As it says at the top of the file, all changes to it will be lost. You should edit the .ui file and then run `python setup.py build_ui`.
woah. i can add notes to each line. always wanted to do that.
Katello may not even need that gradient, as I originally just copied the way the header gradient looked.  I tested with just using the darker solid color and I think the difference was barely noticeable.  So unless @knowncitizen has an objection, I would say just clean-up the above that I mentioned and we can stick with a solid color.
Makes sense, undid that part of the commit
Okay, this is picking nits. Don't these child nodes each represent a separate "projection" of an external node to an internal node? Perhaps we can rename the node type to either "projection" or "externalProjection"? (As it stands, "projectionNodeMapping" seems like it implies something more than this, and thus seems less clear.)
`!=` -> `=!`

And use spacing:

`bool.loop = elem.loop = !undefined;`
Sources in the Berksfile might have an explicit location set. Creating a SiteLocation here would potentially override that. We also have a concept of "default locations" which somebody could set in their Berksfile which this would override.
Newline, please. Same with article file
don't mix polish and english comments
I'll have to look at that.  As above, this is aimed at init based distros.  systemd distros will be addressed in the next release round.
i'll replace them
Could use a post-condition `(map? %)` here.
Also, can we use delay/apply_async instead to fan out to multiple workers? Also: when using apply_async/delay we will have to make sure that the changes to the db are actually commited before we fire off the next task (This is currently not a problem since apply runs in the same transaction)
Documentation error.
Every time we post a comment here, we should get the comments and check that the one we made has been added/has not been added.
`def g` needs `CC`. Have you overseen it or do you mean that it is unnecessary  to check the tuple class?
Create a custom exception, e.g., ``NotSuspendedScalaThreadException`` (so that client code can catches it if needed, ``Exception`` is way too generic).
Moving it inside the ``try`` doesn't give anything more. If the call fails, the value of ``source`` is not set, so ``source.close`` cannot be used to release the handle.
The only possible change is to put the result of ``resultFile.getContents`` in its own *val*, and using it instead of ``source`` to close the stream. It doesn't change much of anything as ``fromInputStream(...)`` doesn't do anything more that creating a ``Source`` object link to the input stream.
Ah ah ah, thanks man for catching this horror :)
Use an enum map here instead. http://docs.oracle.com/javase/6/docs/api/java/util/EnumMap.html
hicuda is extended since I wrote the thesis. It is more compact to allow the shape directive to accept a list of shapes (like const remove, etc.).
ahh i see.. thanks i'll fix all the tests I just submitted to this method
стесняюсь спросить, а как индекс обьекта в массиве может оказаться больше количества обьектов в этом массиве?
вы правы, я написал полную ахинею. правильный код, конечно, выглядит так:
NSArray * allValues = @[@"A", @"T", @"G", @"C"];
int index = random() % 3;
if (index >= [allValues indexOfObject:[DNA objectAtIndex: indexToMutate]]) {
    index = (index + 1) % 4;
}

здесь все еще есть цикл (внутри indexOfObject), но он по крайней мере детерминирован и зависит только от числа элементов allValues
итерфейс в h имплементация в m
в main желательно как можно меньше всего
Мда, неразбериха пока что.
Я поправил, все работает, только не работает 100% мутация - приводит к бесконечному циклу. Не разобрался почему, с массивами все вроде в порядке, просто не может сгенерировать последний уникальный индекс.
Could you use i18n tags here ? Because, for example, in French, the « : » must be separated by spaces, but not in English.

Thank you :)

See https://github.com/MarkUsProject/Markus/wiki/Internationalization for help
Odd, it does work now.  It failed with an error that "http is not a known scheme" before.  I have no idea what changed.
we will probably want to increment runIdentifier or something, we will leave it for the user group meeting to figure this out
scratch that you need to BundleInstall
Why not 'instance = old_value || klass.new' ?
This should be conditionalized based on whether `self` is actually in `activeSubscribables`. We don't want to have one more than requested after `self` completes.
the 2nd one is suppose to be underscore.string.
Hm, I need to think longer, that's for sure, but what just popped up in my
mind is this: does VFAT really know about named FIFOs? Maybe we should
create it in /tmp in the first place... Plus, it should probably not depend
on the "rm" to be successful to go and try to create the FIFO (i.e. the
"&&" is probably wrong).

I don't know, spawning shell commands always feels a bit wrong, I think.
Please fix the styles of the code every time before pushing any changes.
That's a good point, though I think most of our services _do_ already have a getAll method, if just for unit test purposes, so we may want to preserve this method for that reason. (I definitely agree about adding the paging version.)
Probably, but I'm not much of an RFC-reader. I'll see what I can find and add it if I find something relevant.
Same as below, this reads easier as

```if info[1].to_s.match('^[\d]+')```
Why is this and `preview_layout` needed? Overriding?
I was obviously half asleep when I wrote that.
wrong wrapping here
PHPUnit has **nothing** to do with the Console component. It does not use it
this repo looks dead :)
No need - as header is set by camel only if previous call failed
Still not clear why these are being added?  Are we hiding a regression?
I cannot get the doctests to pass, due to this problem: http://pastebin.com/atJXPL1b .  Does anybody have ideas on how to fix this?
Умничка.
Да, без него не работает.
Es un TODO para el futuro, pero todo esto debería cargarse de algún otro lado.
I too have tried to submit multiple commands, but I'm not sure that it even works. *That* would be really neat to have.
to avoid having non-indented text like this, and avoid introducing unwanted spacing into this line you can say:

text = (' something'
<tab> 'something else')

They will concateneate as you expect them to.
Please revert this line
This is rendering strangely. The ticks and underscore stay
I want "restart" to require the instance number.
Sure, I'll fix it and send another pull request. I'm not up to snuff on older versions of Python. I didn't know 2.5 lacked support for named exceptions. 

-- 
James
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Friday, April 27, 2012 at 2:04 AM, Yesudeep Mangalapilly wrote:

> > @@ -140,6 +140,8 @@ def callback(pathnames, flags, emitter=self):
> > callback,
> > self.pathnames)
> > _fsevents.read_events(self)
> > + except Exception as e:
> > 
> 
> 
> Can this be done portably?
> This syntax won't work on python2.5 IIRC.
> 
> You could use the following instead:
> 
> import sys 
> ...
> 
> except Exception:
> e = sys.exc_info()[1]
> logging.error(e)
> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/gorakhargosh/watchdog/pull/102/files#r743149
> 
>
k just wanted to make sure :)
This should not have sudo in it. It should instead do this.

utils.execute(*args, run_as_root=True, root_helper="sudo")
Two choices: move CacheValue out of server (into core maybe ?) or move the entrywrapper to server (nonsense imho).
This is actually not really that much of an issue since client and server will be colocated in the rolling upgrade scenario
Is there any reason this actually needs to be a separate copy of this file? Is there anything lm4f specific here?
This currently happens in Ruby because there's no really good way to do it in SQL that 1) works across all RDBMS and 2) fulfills our specifications. If this turns out to be a significant performance problem for anyone, there'll be multiple nice ways of refactoring or optimizing this.