labofsahil/github-event-dataset-2012 huggingface dataset:
this should just be splunkUsername. Drop the email domain.
Ok, I fixed it!
Similar to itoa above, there is scan_ulong
used to create an instance an populate an object's errors.  seems like the app controllers in consumer web projects should catch the exception rather than on individual method calls, though
Это ли не copy-paste?
При исключениях надо делать System.exit(1)
This can be done with a select. records.select { |x| record.name.start_with? subdomain}. Also please consider validation of result of select to contain one record only.
I think we still need this check to make sure we don't try and rewrite when the media is off-site
Mostly cleanliness- it's much easier to read the public interface commentary if there aren't any implementation details in the way. I'm also just inclined to only show interfaces in the public API if I can- this doesn't really make sense for the outer object, because we have a getInstance method.
We should add a check for the support site too.
do next and prev buttons appear on every page? do they always return a Statistics page? if so, why is click_next_button repeated in the Details page? if not, move them to the right page.
As you suggested: maybe use a css class for this so we can easily tweak the appearance of all non-implemented elements. Not Important for this pull-request though.
Well we still could choose to set them to the type they will eventually have. Makes some sense right? For readability.
Some of the information could be summarised as a table, with the text content below.
Is there a way to exit out of a generator somewhat gracefully? If so most of the if options[:template_*] can be removed if we exit on def error
Is this a required addition or a "safer" one?
What is the "Scharr"?
Well transform is an alias for this one so you could say it is the most important one ;)
As there is also "transform' it is a bit redundant but I think all of the methods below are useful sometimes. And just renaming this one would be somewhat inconsistent.
From the [scipy source](https://github.com/scipy/scipy/blob/master/scipy/linalg/decomp.py#L320), it looks like it's using lapack directly. So that's an excellent question.
Is there a specific reason why these imports are not at the module level?
The two text strings here "Linked User" and "(No corresponding user)" should use translation functions.
use the explicit fromUtf8 function
Would it be wrong to use `TiUIBase*` as the type?
Un tableau de métadonnées. Chaque métadonnées est un tableau avec trois clés : meta_struct_id (entier), meta_id (entier ou null) and value (tableau)
This'd read better as ```if @local_authority```
You'll want to add code near where we set CMAKE_COMPILER_IS_CLANGXX to set CMAKE_COMPIER_IS_CLANG I think
no, autoCommit works around the transaction being active or not. That's the whole point of this call, actually.
Can we do `assert '/products/'`... in there just to be certain it's not calling some other url
Still working on photo for conversations (previously on single message)
Defensive copy --- in the ctor case we don't know who else has a reference to it.
Please replace tab with spaces and fix indentation.
Same with these two lines.
Well, I would if I knew :smile:
FYI as of pull #306 the UI can specify where to go on completion of the authorization/token process by passing ?final_redirect=/some/path to /api/canvas/request_authorization. The Google auth endpoint also handles final_redirect.
Can do. I think a eventually switching the freshen_vcr to be written up in a rake task, will also allow us to hook in actions after it runs through the specs, like reading in the fixture files and piping them through pretty print
Default preferred-name & profile-link are handled on the server in CampusPersonDataService mergeCampusData, so forcing this into JavaScript is a bit inconsistent. But given that it's an image resource and managed with other branding graphics, the inconsistency seems OK to me.
YES! Well spotted!

On Tuesday, 20 November 2012 at 7:02 AM, Manfred Moser wrote:

> In src/main/java/com/jayway/maven/plugins/android/AbstractAndroidMojo.java:
> > @@ -605,7 +605,12 @@ public void doWithDevice( final IDevice device ) throws MojoExecutionException > { > try > { > - device.installPackage( apkFile.getAbsolutePath(), true ); > + String result = device.installPackage( apkFile.getAbsolutePath(), true ); > + if ( device != null )  
> Should that now be  
> if ( result != null )
> ??
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/jayway/maven-android-plugin/pull/148/files#r2170142).  
>  
>  
>
Cette ligne ne me plait plus car si l'id est trouvé dans le début de la file, elle sera quand même parcouru jusqu'à la fin ...
@bootstraps Okay, so shouldn't this be `params.each` to iterate over multiple branches?
RHOST and VHOST you are right, the SSL stuff is registered as an advanced option for some reason in http::client. I can clean this up a bit on the next pr
A little more descriptive name please.
I assume this is correct, but should those values be so small?
From what I can tell, all uses of `self._coefs` copies this append pattern. Why not define `self._coefs = range(9)`?
Same as above. Also the `**` is unnecessary.
# Then reshape into (coordinates, rows, columns)
`v_outlineColor` is not used in the fragment shader.
Do we need this arrays?  Can we instead compute the size in advance and go right to the typed arrays?
Agreed.  I'm still figuring out how to document them myself.
`movement.startPosition` and `endPosition` are mouse screen positions, right?  So they're integers?  Is the epsilon test needed?
Two points here, one specific one general.

In general, use the properties directly rather than the accessor methods, unless the accessor is necessary. In this case, it could be:

    table.sections = (foo)

More specifically, however, the point of this bug is that it is no longer *necessary* to refresh all of the sections like this, because we have a whole new set of methods, such as appendSection, deleteSection, insertSectionAfter, etc. So in this case, we could use:

    table.insertSectionBefore(0, sectionFish);

or

    table.appendSection(sectionFish);

It should be noted in the sample that this sample works with 3.0 and later. Maybe even show the pre-3.0 code commented out.

But that's just the beginning. The Creating Tables section could probably use a mention of these new methods. As in, 

"Starting in Release 3.0, you can directly manipulate the sections in a table using the appendSection, deleteSection (... etc.) methods."

Plus, the TableViewSection page has a bunch of stuff to say about how you can't add a tableviewsection after the table view has been created... Which is false in 3.0. Again, the page should be updated to reflect both pre- and post-3.0 behavior.

At least some mention of the new methods should probably be added to the guides, as well:
https://wiki.appcelerator.org/display/guides2/TableViews#TableViews-Tablesections
Is there a reason for removing, rather than rewriting, this section?
What happens when the activeTab (which is the same as the selectedTab in the old code) is null?  The removed code seems to set the active tab to be the first tab.
...is raised...
I'm satisfied with the way you changed it.


On Fri, Nov 2, 2012 at 9:54 PM, adam <notifications@github.com> wrote:

> In web/file/terminal/Terminal.dart:
>
> > +                  'cp':mvCommand,
> > +                  'open':openCommand,
> > +                  'pwd':pwdCommand,
> > +                  'rm':rmCommand,
> > +                  'rmdir':rmdirCommand,
> > +                  'theme':themeCommand,
> > +                  'who':whoCommand
> > +    };
> > +
> > +
> > +
> > +    window.on.click.add((event) => cmdLine.focus());
> > +    // Always force text cursor to end of input line.
> > +
> > +    // Always force text cursor to end of input line.
> > +    cmdLine.on.click.add((event) => input.value = input.value);
>
> its a trick, do you have a better way to force text cursor to end of input
> line?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-html5-samples/pull/44/files#r2023168>.
>
>
```js
buttons: [
    {
        text: "Ok",
        click: function() { ... }
```
It looks like Andrei is/was against requiring a specific signature for `opEquals` on structs:

https://github.com/D-Programming-Language/phobos/pull/934/files#r2063499

> Re: Destructors, const structs, and opEquals
> Andrei Alexandrescu
> Sat, 04 Dec 2010 06:25:30 -0800
> On 12/4/10 12:42 AM, Don wrote:

>> Officially, opEquals has to have the signature:

    struct Foo {
    bool opEquals(const ref Foo x) const {...}
    }

> This is a compiler bug. For structs there should be no official implementation of opEquals, opCmp etc. All the compiler needs to worry about is to syntactically translate a == b to a.opEquals(b) and then let the usual language rules resolve the call.
Yes, good point. @denis-sh can you fix?
`rndGen` just returns the random number generator if it hasn't been initialized, and I'm not sure that it's a great idea for it to pop the front when you grab it in case that screws up code that expected `front` to stay the same (though it's _probably_ less bug-prone for it to just pop it every time, since you don't want the same `front` across multiple uses).
This implementation will wrongly return ```true``` if ```i == 0``` -- should be corrected to ```i && !(i & (i - 1))``` to avoid this.  See: http://graphics.stanford.edu/~seander/bithacks.html#DetermineIfPowerOf2 (thanks to Bearophile for pointing me to this page).

Also suggest renaming to ```isPow2``` and moving to ```std.math```.
»do« -> »does«, etc. for conformity.
Then the declaration should be on the method, not the entire class.
This will change the output of the mailer unfortunately, but I'm ok with that for now
La signature du constructeur est super longue, est ce que je dois faire des
sauts de lignes meme dans le code dans ce genre de cas ?
J'ai un doute.


2012/11/1 Renaud LITTOLFF <notifications@github.com>

> In fr/Contents/chapter4.md:
>
> > +    $loader->registerNamespaces(
> > +        array(
> > +            'Symfony'         => __DIR__ . '/../../../../../vendor/
> symfony/src',
> > +            'Acme\DemoBundle' => __DIR__ . '/../../../../../src'
> > +        )
> > +    );
> > +
> > +    $loader->register();
> > +
> > +    use mageekguy\atoum;
> > +
> > +    require_once __DIR__ . '/../../../../../vendor/mageekguy.atoum.phar';
> > +
> > +    abstract class Test extends atoum\test
> > +    {
> > +        public function __construct(atoum\factory $factory = null)
>
> Le constructeur a changé. Voir
> https://github.com/mageekguy/atoum/blob/master/classes/test.php#L72
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/marmotz/atoum-s-documentation/pull/10/files#r2002033>.
>
>
We should utilize mutator and accessor methods instead of setting the property directly. Not a big deal, but this way if we want to add some validation or something later, we don't have to go through and change it later.
Yes, that seems reasonable although automatically creating the directory specified in the output file would reduce the amount of code in the end script.
Agreed, that's fine. `value` is generic enough. There is a push sometimes when there are multiple parameters to designate them in a more verbose way, but a single param shouldn't matter. Sorry for the discussion/churn here.
I'll pull this back and go with your suggestion as I suppose you're right that it's pre-optimizing.
Please use " for all new code
Why one connection per keyspace?
What about this Alt text?
Имеет смысл его еще и дизейблить в таком случае. Или ваще прятать.
Do we need this now that it is running on the backend?
please *always* use memset here - bzero is deprecated anyways as of 2008
What's the point of moving these functions around?
So wouldn't `has64Bit[Chip]` or something like that be ideal? It'd even be x86-agnostic.
I mentioned this in another pull request, but this OBR is only one per group.  so move it outside the inner for loop
Ohh yeah dough. . .!
I already answered the same question in previous code review. The Builder class does not expose the metadata.
This approach actually creates a CLI that overrides the one by ORM. Don't do that!
I guess we want a more specific version range here instead of just '*'
You want to name your filter after your module :)
Perhaps it should be 'by itself', but from what I gather there seems to be some discussion about this. Nonetheless I propose that someone who knows this for sure can always supply a PR for themselves (see what I did there? ;))
Plaintext is later rendered to html, pdf, etc.

Maybe in this case is better use blockquote `> text` instead of code-block

You can do a commit over the same branch. Since you are using Fork & Edit feature just go to your fork switch the branch to `patch-38` and edit the file over your own fork
`--name=read-annotate-1`
@christianv We shouldn't put any more time in this particular issue since the delete dialog will almost never be shown and the functionality works as expected.
else group is wrong for 64173
If this was `StaticMesh(PrimitiveType t, RenderInfo *renderInfo = 0)` then the `Renderer` classes would not have to be friends.
If you have a `GetEnumerator` method, you should implement the `IEnumerable<T>` interface.
If you make a request to couchdb like

curl -XPOST -H "Content-Type:application/json" -d '{"keys":["stuff"]}' http://localhost:5984/resource_data/_all_docs the results object doesn't have an id, just key and error
Should be issueManagement instead of ciManagement.
Not blindly because they still have to pass the various requirements.
single quote and isset()
Should this be: "Defaults to the system default temporary directory." or something like that?
Nope that's wrong. Forget about my last post (the way I was thinking is nothing different from calling guess function).  So I think I can just call each function in Import.js inside events like:

this.model.HERE IS THE FUNCTION();   am I right??? 

I tried with CSV but when I click the option from the dropdown, the screen goes back to the dashboard instead of showing the step 2...
same as above comment. full version should be 2.7.17-1puppetlabs1
How about:
    >>> feature_index = bigram_vectorizer.vocabulary_.get(u'is this')
    >>> X_2[:, feature_index]

I think just displaying the number 7 is confusing and it's better to operate with it implicitly. However we should come up with a better variable name :)
i thought it would be nice to standardize database tables name e.g say if you were to write/run some scripts to directly with interact with database for whatever purpose .one can easily going by meta db table name otherwise you will have to depend by django default database table names i.e appname_modelname which is at times truncated depending on database engine .
I agree there is no need for it now will remove.
Fixed in 0108c04
Generate and assign this in the download success case. No point doing it here.
shown.
What does prevent default do here?
this seems bad overall. We shouldn't use try catch as logic

Is there no other way you can check if that feature exists?
We must pass this information from the packager. There is framework modules file, does that have this information?
Maybe add an exception for lazy loading and the likes.
The tokens `^^` and `^^=` are valid only in D2, so you should enclose them with `$(V2 ...)` macro.
> Сначала проверяется условие, i == 1, а потом выполняется --, и в цикле имеем i == 0

Упс…

> выполнение шесть раз умножения i*3 в функции может добавить к ея выполнению лишнее връмя..

Так мы не умножаем же. Смотри 92b9bac.
Can you use constants here ?