labofsahil/github-event-dataset-2012 huggingface dataset:
OK you meant everything :D, I thought that we will leave this in case we will use it later, OK then I will remove everything. ;)
The purpose was to be able to have better control over the error message. Perhaps I went overboard. 
Basically, if you use `/history/diff/NOT-A-TABLE/1/NOT-A-FIELD` you get a 400 error because the parameters are used incorrectly. However, if you use a `change_id` that isn't found in the database, you get a 404 error. 

I think I might just use a plain KeyError to make it feel simpler and lighter.
Missing a tiny space before the var.
let's move the `this.numComps` from the for-var-i loop
Yeah sentry raven as well, but it doesn't have to be a submodule for small things.
Moet dit niet ``self.board.sp.write`` zijn?
You're not passing NET_CMD_ARG_1 or _2, which I assume correspond to -S and 127.0.0.1 in your example. Either the code or the comment needs changing.
why unicode as default?
This looks like an accidental edit.
Oh, it's really part of the spec file :) I would suggest to make a comment about that here in the code to prevent some confusion later
These types of returns always look like typos to me....
I suggest to leave the default admin account there and lock it or something, create new account that would be triggered by Katello orchestration and give it super admin permissions. Just like we do in pulp/candlepin. This looks complicated, but if there is no other reasonable way, I am okay with it.
Updating the help line (and in a few other places) to read:  help=_("comma separated list of system group names (required)"))
nods, i think we need a background job that periodically clears tmp/? or simply delete the temp file once we are done with it. i did fix leaking of file descriptors though.
Mentioned in #8, but a style nit... Kill the leading space that aligns var names and values in this let binding.
Yes, though I originally wanted the failing message to be clearer than 'Failed asserting that exception of type "\UnexpectedValueException" is thrown' and I was not sure how to do that at the moment using the `@expectedException` notation.  This test however is covered by the one right below, so I removed it completely.
It causes other issues with the test setup we have (screen gets locked just after the app is launched...)
So `head.js` is going to need an update I think.
My goal was to make this event-driven as much as possible, so that we're not relying on the internal API. 
It seems like it tests what a user would be actually doing better to send an event and then wait to see what happens...
So I didn't try screen.mozEnabled
Do you mean ``ListHandler`` should be included in the public API, or just ``AstropyLogger``?
+1.  I left the public get/set methods there only because I didn't think we had fully agreed on properties vs. get/set for this class.
riak_object is not visible in riak_core.  I think `binary()` is good enough if there isn't already a bucket type in core.  Also, do you mind using module attributed specs?  We are trying to move away from edoc specs.
Sorry for my nescience, the value is then 2^32 - 1, right?
Thanks. I agree the logic as it is now won't crash, but without unit tests I think it is much too easy for somebody to modify it in the future an introduce a bug.

(and I think there might be a problem with the empty string down on line 51, where you check if (in[0] ==...)  )
setToolTip and setTextInteractionFlags can move to the ui-file and here is that Monospace thing I talked about (you can set bold in the Qt Designer though).
I don't think this `if` block is needed since we already check for non empty tag value and use default at line 483. All tests should pass even after removing this.
Whitespace looks off here.
disclaimers > disclaimer
It's a dict.  It's just that the bencoder thinks cookie is an int since it is all numbers.  When I added the space, cjdroute started accepting my auth.

--_-

On Apr 17, 2012, at 7:04 AM, Caleb James DeLisle <reply@reply.github.com> wrote:

>> +                    if (length($data) < BUFFER_SIZE) {
>> +                        last;
>> +                    }
>> +                }
>> +            }
>> +
>> +            my $dec = bdecode($to_decode);
>> +
>> +            my $cookie = $dec->{cookie};
>> +
>> +            my $req = {
>> +                q => 'auth',
>> +                aq => $method_name,
>> +                hash => $self->_sha2_hexdigest($self->{password} . $cookie),
>> +                cookie => " $cookie",
>> +                args => \%args,
> 
> As best I can tell, it looks like you're sending a list, it takes a Dict, we could fix it to handle a list though, it'll just take another few hours on my end.
> Talk to me on this, we should standardize on something...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/cjdelisle/cjdns/pull/65/files#r694017
we need to add a test that ensures that this fixes #524, can you add that @hasankhan ?
move these to private methods
No he wasn't!
this list of possible rev sounds like the right approach to me. on creation we would have to cicle this list until we find the rev that was used here.

this can also handle multiple rev attributes for the same type of parent. but in that edge case the collection would still need to specify the rev so things can be rendered. what exactly is the type of the parent used for? to infer the right rev to use? maybe we could reduce this to a list of rev to check and if multiple the collection must specify rev as well? or the child could specify a default rev. listing all parent types in the child sounds unflexible to me.
These size changes were done because they improve the appearance of SVG figures.
With lower figsize, pixelation and aliasing occurs, which makes SVG's look like
shit.  I still do not fully understand why this occurs, but simply increasing
these sizes visually fixes it on screen.

I would be happy to understand why SVG, which is supposed to be a vector format,
has such problems with pixelation and aliasing.  This occurs cross-browser, and
even in inkscape, IIRC.  I suspect the matplotlib output code, but was unable to
identify what it was putting in the SVG file that caused it.

Brian E. Granger [notifications@github.com] wrote:
> In IPython/zmq/pylab/backend_inline.py:
> 
> > @@ -40,12 +40,12 @@ def _config_changed(self, name, old, new):
> >      # The typical default figure size is too large for inline use,
> >      # so we shrink the figure size to 6x4, and tweak fonts to
> >      # make that fit.
> > -    rc = Dict({'figure.figsize': (6.0,4.0),
> > +    rc = Dict({'figure.figsize': (32.0,20.0),
> 
> Won' this change the figure size of all figure types, not just svg?

Yes.

> Also, the proportions of the figures was not preserved. Is there a reason for
> this?

Solely aesthetic on my screen.

Brian E. Granger [notifications@github.com] wrote:
> In IPython/zmq/pylab/backend_inline.py:
> 
> >          # 12pt labels get cutoff on 6x4 logplots, so use 10pt.
> > -        'font.size': 10,
> > +        'font.size': 32,
> 
> The font size increase is also not proportional. Comments?

Again, chosen by just looking at it and seeing that it looks nice.

--
Cheers, Bob McElrath

"The individual has always had to struggle to keep from being overwhelmed by
the tribe.  If you try it, you will be lonely often, and sometimes frightened.
But no price is too high to pay for the privilege of owning yourself." 
    -- Friedrich Nietzsche
You left the old `test_pr` name here :)
We probably want to call this something that reflects whether or not the notebook will be saved.
Any reason to use `const` here over var? const is not implemented everywhere and its inside a function so its not really what I would think of as `const`
I'd suggest not putting this function between function and prototype of RecurExpansion
Why not just wrap http://commons.apache.org/lang/api-2.4/org/apache/commons/lang/StringUtils.html#getLevenshteinDistance%28java.lang.String,%20java.lang.String%29 ?
Can't because inner functions/inner classes are static.
@jairodemorais  if @rragan is ok, a few more test cases makes sense here

{#.} {$idx} {/.}

more edge cases like these

empty array,

empty map
use 1.9 syntax
Oh you are absolutely right. Should've been ||
Those 'App thumbnail' images are decorative and should get an empty `alt` rather than a not very descriptive text.
Indentation is funky here.
Yeah this is because the default now is the second item. I think it is hackish though as it is hard coded here. I'll see if there is a better option. Actually, this is probably wrong.
Ok, taky se da ta podminka zabalit do zavorek, stejne jako volani funkce
;-)

Dne 18. srpna 2012 13:55 Jiří Maršík <notifications@github.com> napsal(a):

> In coffee/recorder.coffee:
>
> > @@ -58,10 +66,11 @@ $ ->
> >    # Eval nemerime pri eventech, ale sbirame pri kliknuti tlacitka 'Eval!'.
> >    $('#evalButton').click ->
> >      currentCode = myCodeMirror.getValue()
> > -    recordingTracks['evaluatedCode'].push
> > -      time: new Date() - recordingStartTime
> > -      value: currentCode
> > -    playbook['evaluatedCode'] currentCode
> > +    if recordingNow
>
> Tak jsem šťouchal do CoffeeScriptu a nějak začínám chápat, jak ty
> whitespace věci fungujou. První parametr funkce musí být na stejným řádku a
> všechny další se pak musí uvíst čárkou. Tímhle způsobem by to ten parser
> měl mít snad jednoznačný.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/progma/recorder/pull/2/files#r1408719>.
>
>
Replaced `$_ENV` with `NULL`.

Then the child's $_ENV seems to be empty array.
https://gist.github.com/3386850
Nitpicking but... you could use some sort of enum for these too (e.g. kNoTime) instead of "magic" values
Arrays.toString() on a potentially large byte array is a lot of work! Especially since LOGGER.fine means the work probably won't be used. Don't bother with this line unless fine logging is enabled?
shouldn't you keep it as deprecated for 2.2 ?
You should split every variable into new line, or none of them.
ok, I returned it now, you could check this out in 2 latest commits.
:warning: Can of worms alert!

EPSG 4326 is a geodetic CRS, not a Plate Carree projection. And it's only equivalent to an instance of our Geodetic class if that instance is using the WGS84 datum and ellipse.

Incidentally, why make this method private?
We're printing comments because (1) it was late and (2) it causes the play-through to make sense.

I think this is actually a bug in the example; it should include a speech block around line 24 so that Jack has something to say.
remove extra parens from this line
И куда-то скрываются, ага
А иногда приводят дополнительных нежданных товарищей
Ох уж эти отступы..
Here i find it ok to have it as this shows us the result in the jetty running.
Is it possible to relate a new item to more than one library (or should it be) ?
Ah. I find that the type is actually redundant since the class itself actually specifies that information. 

Having an abstract convenience method 'getType()' in (Abstract)WellKnownRecord is fair but not very useful(?). Having a non-normal field variable is not favorable; you should not be able to set the type of a well-known record to something else than its class.
Ah oki, j'avais mal compris ! Je vais corriger cela !
We can't use system properties for this.  There is no guarantee that they will be set. Their use in the host.xml files we ship is just our suggestion. Users are free to use a different property name or no property name at all.

HostControllerInfo.getNativeManagementInterface() and getNativeManagementPort() provide this information.
I'll fix it in next version, IDEA made it for me.
We are using 100 in other BB for setting the z-index of something that is over the content. I'm open to change this :D
Recherche… (points de suspension)
nit: empty line above + don’t inline the `.bluetooth-default` rule please
Checkbox fetching and early exist coding style fixed.  Thanks.
Hora -> hora
Should we check if FB is enabled? Or this is done in other part of the code?
Why don't you keep this line since you want to do it at the end and you have to do a this.index+1 a few lines after.
Also, you might want to bump 5 -> 15 which is the default in ff httpd does +5 that. I am not sure how much it matters.
I don't like the translation (that's why I translate to the previous one) but that's up to localizer in the community to decide.
Could you test if popup container shows at the same time modal dialog is shown(use uitest alert/confirm/prompt)? Thanks.
I think by `state` you mean the `evt.detail` we got from focuschange.
Could be save the state in a variable to do activate?
(Although  the `value` of the input might be changed after we save it, we don't check `value` right now, right?)
You don't need to move all those. Just user the defer/async attribute:  see https://developer.mozilla.org/en/HTML/Element/Script
what are you matching here?  `(?P<resource_name>transaction)` If it's just "transaction" do you need it in the named group?
Better to just use an if statement here, no need to concatenate an empty string.
Return, return, return, return, return. @alal3177 did you fall asleep on your keyboard? ;-)
same situation here.
Shouldn't `trackIds` be just a track? Thus named `track`?
Typo: damping
moved to ``data`` for future refactoring ;)
try simplified code:

    typeset CDPATH
    CDPATH="."
    chpwd_functions="" builtin cd "$@" || return $?

this works well with `IFS` - we have this trick in few places in code already and for now nobody complained
Please add a comment documenting that `proxy` should be a new variable that will act as a scratch, and not the target variable.
Is there a reason why you can't use JRegistry in 1.5?
move that function outside of thread()
what is a? needs a better name.
That would be my preferred approach too. @ssatish , can you use this '_forms.scss' mixin directly in the app? Alternatively, I've stripped down and reformatted the generated version according to our CSS style guide, here: https://github.com/alphagov/prototyping/blob/master/support-pages/compact-styles.css . Using the mixin would be better though.
This would probably be more idiomatic written as `!! @javascript_enabled`
The term used internally is "identifier". Can you please rename this option to *LowercaseIdentifier*?
you're missing coffee
It looks like `build_ide` is unchanged. You noticed that it does not use the ecosystem tool to set versioned dependencies. It would be awesome to fix that too. :)
BSRL
We want to get rid of the argreg shared area. I removed it.
From what I see on CRAN they rather appear as "name at servername", and 
staticdocs might also be used for packages that are not on CRAN.
I thought it would be good practice and it is free to achieve.
This could possibly be controlled by a runtime option?

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 03:39, hadley wickham wrote:
>> @@ -28,4 +28,8 @@ markdown<- function(x = NULL, path = NULL) {
>>
>>     (markdownToHTML(text = x, file = path,
>>       options = c("safelink", "use_xhtml", "smartypants")))
>> +}
>> +
>> +cloak_email<- function(x){
> I don't think there's any point in this - all the email addresses are already publicly available on CRAN.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/24/files#r1015022
unlikely?
Fixes:
```
NoMethodError (undefined method `container' for nil:NilClass):
plugins/redmine_s3/lib/redmine_s3/attachments_controller_patch.rb:20:in `redirect_to_s3'
```
redirect_to_s3 is intended to redirect the download of files to S3. It should not run while uploading. :destroy action was already being skipped, so I added :upload into the :except list
you don't need to set ':default => nil' btw, has the same effect as not specifying it at all
this was a typo,
It's a paranoia! No need to nullify everything, specially when there are good reasons for not to. In SDK we may create other module that does cache destruction after long delay. But anyway let's defer this discussion.
Feel free to change.

It's been useful while grepping, since we already use primary, proxy, shim, and idp for other features.
This makes sense and looks good to me.
r+
If you call `get_absolute_uri()` with no argument it defaults to `request.get_full_path()` - IOW a single `uri = request.build_absolute_uri()` would have the same effect here.
These tests will always fail if the datazilla environment does not have TEST_DB_PREFIX set to 'cam'.  Use `ptm.project` instead.
I originally did try this form out. I backed out because having a selector that takes a id and a class is not completely trivial without something like jquery. 

We can create a function:

function e(id, class) {
  return document.getElementById(id).getElementsByClass(class)[0];
}

but managing tooltips is more difficult unless you just want one tooltip per id (i.e. cc label,duration,age output the same tooltip).
just a nit: if a function doesn't have a name please use a blank before the opening bracket. Otherwise someone could think that 'function' is a valid function name. In this case it would be: `function (...)`
That would redeclare `manager` which already exists since line 50. We should simply remove the `var` here. I would assume that will work.
-M +confusion_matrix ?
Thanks so much for looking into this. As You may have guessed, I'm very very new to pecl development, and my C is, well, appalling.
Your comments are very much appreciated, I'll try follow your recommendations.
for clarity, I'd prefer `\$this->set{{$localeColumnName}}(\$locale);`
I just fixed a fatal error because of the wrong signature, don't know if there was an intention behind the '0' code. If there was none, the best solution is to remove the constructor from this class, just like in all other custom Exception classes.
In the Propel2 CS, the opening bracking should be on the same line of conditions:

    if (cond) {
        // foo
    } else if (cond2) {
        // bar
    }
@pcarlisle you may want to mention that exceptions raised within the setcode block will automatically be rescued and an error written to stdout (or err not sure)...
Looking at the docs I don't see any kind of cleanup. The `start` method is for reusing a single connection for multiple requests, but that wasn't happening there anyway.
Instead of defining this twice (here and in ffi.js), export it here as `Library.EXT = EXT`, and then re-export it in ffi.js as `ffi.LIB_EXT = ffi.Library.EXT`.
curly brackets dude
Mainly for performance. The scala foldLeft is substantially slower and less efficient object creation wise than a plain old while loop.
Not sure this method is really needed.
Please provide a better message something link "Countries out of the Single Euro Payments Area (SEPA) are not allowed"
CS, space missing after )
Personally, I prefer having the full path in the docblock - then I don't have to go to the top of a file to find which class I'm actually using, lose my place where I was editing... etc etc...

But as I said in IRC:

```
* Mez awaits the inevitable "but our coding standards don't match!"
< EvanDotPro> Mez: Mez lol
< EvanDotPro> just left a comment :-p
```
false actually has a special meaning internally, and should not be removed from the signature.
Oh, now I see what was wrong before... This doesn't take account of the event.getRadius() anymore
I don't think moving this out of the if statement is correct. What you really want to express is IF changes get commited, THEN NotifyIndexingService. Unfortunately the if statement only detects whether changes are committed now, and doesn't detect when they get committed later.
Para saan tong change na to?
it should use only 4 spaces, not 8
Calling `Enum.count` and then `Enum.split` will loop the collection twice. Which may not be possible if the collection can be iterated just once, like `File.Iterator`. What do you think about calling:

    { list, count } = Enum.map_reduce collection, 0, &1 + &2

And then we could do:

    real_count = max(0, total_items - abs(count))
    split(list, real_count)

Also, could you please update the docs to say that if a negative number is passed, we will loop the whole collection?

Thanks a lot!
You shouldn't have to comment these out; the debug output can be turned off completely via code by doing `Asciidoctor.set_debug(false)` and then turned back on later with `Asciidoctor.set_debug(true)`.
please, call this function as escalus:assert. escalus_new_assert module will change name at some point, when old escalus_assert gets deprecated
Use OptionParser?
change this to: 'ftpmirror.gnu.org/%s' % name.lower()
Should imports not occur only at the head of the file, not in the middle of the code?
I explained the conventional ordering of elements above. It looks like it's now fixed :-)
declare `clonedEvents` at the top of the function, but keep the assignment here - thanks!
Dsafe would love this. :)
It's safe to say that none of us are on our A game with this one. :D
Rather than importing the page at the top, you can do the import in the method:

    from view_source import ViewSourcePage
    return ViewSourcePage(self.testsetup)
no need to leave commented-out code lying around...
uh wait - you'll need another JSON.stringify for the posix case here
oops, I'd meant to remove that.  I was going to disable the field not in use, but it was a bit fiddly.
i think we need the same fix for lookup_keys?
the saving happens in _process_form
The idea was that a view can't be in a `ready` state if it hasn't been rendered yet. I think the only way to do this would be:

    view = new Thorax.View
    document.body.append view.el
    view.trigger('ready');

Seems reasonable when not using layout view, but maybe should have to explicitly render? Seems wonky to be able to get into a state where a view is ready but not rendered or appended.

Since these three things have to happen to make a view ready:

- be render
- be appended to the DOM
- have a ready fired

I wonder if it makes sense to add an `appendTo` method that would encapsulate all of these behaviors and be the only supported API for appending a root view to the DOM.

    view = new Thorax.View()
    view.appendTo($('body'))
    // or
    view.appendTo(document.body)

Thoughts?
That differs from what we currently have in the get_mozmill-environement job. I think the latter should also have this property set to false?
This is too much manual handling. HTTParty will deal with GET params easily. I'll pull and refactor though. Doesn't need to be a blocker
fixed.

On Mon, Mar 19, 2012 at 1:11 AM, Avram Lyon
<reply@reply.github.com>
wrote:
>> @@ -1,29 +1,25 @@
>>  {
>> -     "translatorID":"5ed5ab01-899f-4a3b-a74c-290fb2a1c9a4",
>> -     "translatorType":4,
>> -     "label":"AustLII and NZLII",
>> -     "creator":"Bill McKinney",
>> -     "target":"http:\\/\\/www\\.(?:austlii\\.edu\\.au|nzlii\\.org)\\/(?:\\/cgi-bin\\/disp\\.pl\\/)?(?:au|nz)\\/cases\\/.+",
>> -     "minVersion":"1.0.0b4.r1",
>> -     "maxVersion":"",
>> -     "priority":100,
>> -     "inRepository":true,
>> -     "lastUpdated":"2007-06-18 18:15:00"
>> +     "translatorID": "5ed5ab01-899f-4a3b-a74c-290fb2a1c9a4",
>> +     "label": "AustLII and NZLII",
>> +     "creator": "Bill McKinney and Sebastian Karcher",
>> +     "target": "^https?://www\\.(?:austlii\\.edu\\.au|nzlii\\.org)",
>> +     "minVersion": "1.0.0b4.r1",
>
> Not that it matters much, but the `ZU` shorthand and the `ZU.xpath()` function are 2.1.something and up (iirc).
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/228/files#r572958



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
same thing here. and `else if` makes this look nicer. Could you also fix the indenting?
Never mind, it does indeed look much better: https://gist.github.com/2228697/2e297163ae9c2463b1e138680b54df314a0fc16a
`<code>x = {}</code>` will also make some space (the same amount as goes before and usually goes after =, in fact).
do we need a KA purple?
function name should be consistent
This is pretty terrible. Don't update metadata through the by-ref variable.
Need some more info on this one
New line here, please
you can use System.arrayCopy() instead of the loop here
Tiny checkstyle error somewhere in here.
Keeping it consistent :)
кто?
надо минус балл за каждую очевидность ставить
My days in Clojure/Javascript are creeping into my Ruby
this should IMHO be placed in a separate script. Systemd do not permit to have arbitrary action , and so by using a seprate helper 
http://lists.fedoraproject.org/pipermail/devel/2012-June/169411.html
Does the userId still need to be filled in by a developer?
I'm assuming this would point to a generated id?
This needs some form of validation. I've tried creating a tenant without a baseurl and got no errors, although it didn't work.
I'll create a follow-up ticket to make retrieving config values more pleasant
Should all use RestUtil.encodeURIComponent
we should still maintain the original `req.accepts('html')` behaviour, easy to add though just `Array.isArray()`, hell if it's not an array we could just `[types]`
Don't need the sleep,has_css? automatically polls the page for up to 10 seconds
You need to put { at the next line, see the [coding style guidelines](http://codeigniter.com/user_guide/general/styleguide.html#code_indenting).
Имеется ввиду, что мы в любом случае должны поменять значение ячейки? Ни в коем случае не можем случайным образом получить такую же буковку?
спасибо за объяснение
интересный подход, я бы просто удалил ненужный символ из массива, и делал выборку из (count - 1), а тут красиво без лишних телодвижений достается нужный индекс
Я понимаю. Но сторонний программист, который будет пользоваться вашим классом, будет не задумываясь использовать init, так как это конструктор по умолчанию, а это не приведёт ни к чему хорошему, так как вы не переопределили этот метод для своего объекта.
Исключено, поскольку мы делаем не random, а shuffle и бежим по необходимому количеству индексов.
YAML.load_file
Is there a way to page through slides, that is, to click a link to view a specific slide? That would be a nice feature because I can envision this used for a promo banner of featured items. Those typically include a small dot navigator where you can click through each slide or go back to one you were just viewing.
we really should stick to one standard. 

Either:
var a = ...;
var b = ...; 

Or:
var a = ...,
      b = ...;

Not both.
This works for me, if it also fixes the bug. Won't this still fail when it tries to write VERSION though?
Could we just go with `MergeConflictException` or something to that effect? For now any need to merge would result in a conflict; once actual merging is supported, we'll just throw less often.
Ok, the name might not be well taken.
It means: proportion of the discraded pca components to put back before doing the unwhitening. This way you can restore some features of the original data. 

if 0.5, half of the components discardeed -- descennding explained variance order -- will be re-added to the ica-cleaned previously selected pca components.

makes sense?

On 14.11.2012, at 22:30, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/artifacts/ica.py:
> 
> > @@ -616,7 +635,7 @@ def pick_sources_raw(self, raw, include=None, exclude=None, start=None,
> >          return raw
> >  
> >      def pick_sources_epochs(self, epochs, include=None, exclude=None,
> > -                            copy=True):
> > +                            prop_unused=0.5, copy=True):
> what is prop_unused???
> 
> —
> Reply to this email directly or view it on GitHub.
>
would make more sense to have first n_pca_components and then max_pca_components in the list
; is missing at the end of the line. Also don't start the line with the comma.
There will be other validation errors here so it's not enough to test if there are any, but you need to use the for loop as below to test there's a one with code "Concept.error.notAtLeast..."
Why not get the specific property  rather than looping through all
Yes, we can deprecate the default too.
Should be trying to use 1.9 style hash syntax.
http://jsperf.com/array-declaration-test

it's slower.
It is a good practise to avoid long lines in code examples, use something like this:

    data-prototype="{% filter escape %}
        {% include 'AcmeTaskBundle:Task:prototypeTask.html.twig'
            with {'form': form.task.get('prototype')}
        %}
    {% endfilter %}"

You should also add an empty line between `..code-block:: ...` and the code.
I would mention the filename here at least (`my.cnf`), but you're right not to mention the full path.
Thanks should have looked into the docs but it looked like a typo to me thats why asked. 



On 01.12.2012, at 00:16, Fred Sauer <notifications@github.com> wrote:

> In test/e2e/angular-scenario/e2eSpec.js:
> 
> >      browser().navigateTo('/index.html');
> >      input('yourName').enter('A Pirate!');
> >      expect(element('.ng-binding').text()).toEqual('Hello A Pirate!!');
> >    });
> >  
> > -  it('should skip this e2e test', function() {
> > +  xit('should skip this e2e test', function() {
> xit is used to temporarily skip tests, in the same way xdescribe can be used.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Yeh - I'll make that blue for you!
Is this sufficient for now?

(Is this output used or checked, anywhere, aside from manually?)
Might it make sense to be a real URI?
If you use the splat technique this becomes:

```ruby
@new_version = [@major, @minor, @point].join('.')
# or
@new_version = "#{@major}.#{@minor}.#{@point}"
```

But should this method be setting an instance variable or just returning the value?
И ньюлайн лишний.
Hah, I removed unused imports, but forgot to remove my own xD
Use your tools!
cache cache cache ? :)
If you had documented it in the class' javadoc, I wouldn't have asked ;)

This is where I wish we had Scala's abstract types in Java... it solves this particular problem (example can be found in HotRodDecoder).

I agree that overriding is rather awkward. 

p.s. Add the explanation as javadoc :)
Actually, it's not without value. It just checks whether the parameter exists no matter if it has some value or not.
:+1: on those short descriptions.
Fair shout. :+1:
Most of the PEP8 violations here are a result of my copying and pasting from axes.py.  Thanks for catching these and I will fix them all (as well as do PEP8 work for mplot3d in a separate PR).
Heck, why not just simply remove the strings and use the comments instead?
I don't think that we need this part anymore because urllib2 should already have thrown an HTTPError exception.
Not needed to be completed to merge.
OpenEngSB-2.4.0 does not contain the register-methods and never will, because it breaks API
@jsloane Since this was the only issue, I fixed it myself.
If I add the jqmClose class to the links, it doesn't work. The overlay gets closed but the download doesn't start.
get_kernel_matrix would compute matrix each time you call it (even if you want num_cols only)
Can't we just check for existence of arguments in the setters (e.g. `from()`), and use them as getters if none are passed? So jQuery style.
Not the prettiest API, but in my opinion better than `itemisedFrom()`: It uses UK english, which is consistent within the framework, but counterintuitive to most users of the API, unnecessary confusion. There's no symmetry between getter and setter. Maybe its just wording choice, but I wouldn't be sure of the difference between `itemisedFrom()` and `prepareFrom()` just by the function names.
And i don't like query to db for every loop. It should be one query with coments ids and foreach on results.
Part of the SOCKS5 protocol is that the connection info (the byte
representation of the address type, address length, address, and port
number) must be sent at the end of all messages to the client after the
initial request. I found it easier to store this as a byte array than to
convert back and forth between all the various forms of addresses, strings
and ints each time I needed to append it to the end of a message.

-Nick Martindell
1 (206) 552-9501
nksemail@gmail.com



On Mon, Jun 25, 2012 at 4:11 PM, Will <
reply@reply.github.com
> wrote:

> > +        readNBytes(buf, 4);
> > +        byte version = buf.get();
> > +
> > +        if (version != SocksConstants.Version.SOCKS_5)
> > +            throw new
> SocksException(SocksConstants.Status.GENERAL_FAILURE);
> > +
> > +        byte command = buf.get();
> > +        buf.get(); // Reserved Byte
> > +        byte addressType = buf.get();
> > +        int length = 4;
> > +
> > +        switch (addressType) {
> > +        case SocksConstants.AddressType.IPv4:
> > +        case SocksConstants.AddressType.IPv6:
> > +            length *= addressType;
> > +            remoteID = new byte[length + 3];
>
> It isn't clear to me at all what remoteID has in it, it seems like it
> might be more suitable as a struct, since it seems to contain multiple
> things.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/UWNetworksLab/OneSwarm/pull/1/files#r1046957
>
Automatic detection of `all` / `any` is TODO for future improvements, I guess?
Hat sich für den Moment glaub erledigt.
Missing `;` here. =]
указывать тип переменой

```php
<?php

///
/**
 * @var string $name
 */
private $name;
```
On that note you just discovered a bug. :-)  The docs even show that there should be a return $this.
True. However, after thinking about it some more, we don't need to run the checks on $os again, we should just compare against IS_MAC or IS_WIN.

Something like:

define('IS_UNIX', (IS_MAC === false && IS_WIN === false));
Yes, it can; will update it.
hmm actually it seems Imagine itself is using the same approach .. the Imagick OO API also seems a bit strange:
https://github.com/avalanche123/Imagine/blob/master/lib/Imagine/Imagick/Imagine.php

@avalanche123 do you have a tip for us here what would make the most sense?
I've implemented this with a6f55e5.
And the test description better.

Something like this: `doesn't modify the options hash`
Really think that this should return x * x
Could you add some small comments about this and the EvaluationsDatable class? I'd be confused if I hadn't seen that Railscast episode :)
[maybe just link to that Railscast page]
Fixed. I have removed resetColumns() and now I'm using detach(). This function is exactly what I need :)
So no, nothing more then updating the database here. Making a HTTP request to push server takes time. And it is a blocking call. What if there are some problems in connectivity. Really, no code which requires external services should be called in request handler. This should be done asynchronously. (The exception is database of course.)
`post_url` -> `comment_uri`. So it is not post, but comment which you have here.
Don't know, I just copied it from documentation. If it's in there it should be right ;-)
Do we really need a separate function?
Please don't concatenate HTML, but use jQuery to build it. In this way escaping will be properly done.
Name of the view for account.
You should comment in a similar way [how it is done in nodewatcher](https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/templates/form.html). You should tell users of this form template, what and how can they do anything with it.
Oh, I see - makes sense.

We should probably be using the class name instead of the URL basename.
Please explain this code below.
use swtich:

```diff
diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp
index a497227..e4ed5a2 100644
--- a/src/server/game/Spells/SpellInfo.cpp
+++ b/src/server/game/Spells/SpellInfo.cpp
@@ -1990,16 +1990,16 @@ uint32 SpellInfo::GetMaxTicks() const
         DotDuration = 30000;
 
     uint8 x = 0;
-    for (uint8 j = 0; j < MAX_SPELL_EFFECTS; ++j)
+    for (x = 0; x < MAX_SPELL_EFFECTS; x++)
     {
-        if (Effects[j].Effect == SPELL_EFFECT_APPLY_AURA && (
-            Effects[j].ApplyAuraName == SPELL_AURA_PERIODIC_DAMAGE ||
-            Effects[j].ApplyAuraName == SPELL_AURA_PERIODIC_HEAL   ||
-            Effects[j].ApplyAuraName == SPELL_AURA_PERIODIC_LEECH))
-        {
-            x = j;
-            break;
-        }
+        if (Effects[x].Effect == SPELL_EFFECT_APPLY_AURA)
+            switch (Effects[x].ApplyAuraName)
+            {
+                case SPELL_AURA_PERIODIC_DAMAGE:
+                case SPELL_AURA_PERIODIC_HEAL:
+                case SPELL_AURA_PERIODIC_LEECH:
+                    break;
+            }
     }
 
     if (Effects[x].Amplitude != 0)
```
I feel like these should be in `CMDistance` instead of here. What do you think?
Did you get the word 'house' from anywhere? I wonder if this method should be called `get_family()`. To me that seems a little clearer than house or branch.
So `filterBy` using `findBy($filter)` is not working anymore?
OK, but you still don't need to remount /system to create `$WORK_DIR`. Also, creating a directory isn't actually cleaning anything :).

I would suggest removing `system_cleanup` altogether, and just replace line 10 in `test_factory_reset` with `$ADB shell 'mkdir $WORK_DIR 2>/dev/null'`
Should it be a list? a dict? We should tell a dict is wanted here.
Added a comment to the ctor. parameter to make this ownership explicit.
See the other pull request with the rest of the azure stuff: https://github.com/mspnp/cqrs-journey-code/pull/13
Space after `:1000,`
You can cut down on the verbosity if you use the `case` statement.
And then do a reshape?
ты каждый раз в тестах менять чтоль будешь?
I think that we should sever a "custconfig.js" for the users. It is easier to modify an existing file instead of not knowing where to store a non-existing file.
:grin: we've all been there.
It displays like that to me about in GitHub?
Remove - this isn't doing anything.
Class variable.
Yes.  I added it here too now.
According to [this](http://www.stack.nl/~dimitri/doxygen/markdown.html), you can write:
```
My Main Page                         {#mainpage}
============
```
Also, I think I probably prefer the underline notation for the level 1 and 2 headers.  It makes them stand out more in the text file version.  It might be worth switching to that for both this and INSTALL.md.  For the level 3 (and higher) headers, the only option is `###`, but I think that's fine for them.
@zoltax, please don't commit such a comment to repo and delete this line. If you need it for testing create the same user as ours on you local postgresql environment.
It's a unittest setting I put in there to make it print the whole diff for the intermittent iteration test failure.

Regardless of whether we want it there or not, it doesn't have any place in this particular PR.  I'll remove it.
What are the activeTasks for?
Should every node-provisioning call (i.e. call to create) be represented as a task?
Or is it only wanted for start()?
Correct. Until the iframe fix (which isn't perfect yet) is in place, links
are just gonna stop dead on iOS (no user response.... they just won't work.
:/)

- Sent from my Galaxy Nexus
On May 10, 2012 3:37 PM, "Matthew Batchelder" <
reply@reply.github.com>
wrote:

> > +      */
> > +     private static function remove_share_widget(&$feed_data) {
> > +             // Our icon removal regular expression
> > +             $remove_iconlet = "/(<p
> class=(?:'|\")?akst_link(?:'|\")?>(?:.*?)<\/p>)/s";
> > +
> > +             // Loop through each feed
> > +             foreach ($feed_data as &$event) {
> > +                     // Let's replace all occurrences of this tag (that
> match the regex) in the content area
> > +                     $event['content'] = preg_replace($remove_iconlet,
> '', $event['content']);
> > +             }
> > +     }
> > +
> > +     /**
> > +      * Private method to remove links from the posts content
> > +      */
> > +     private static function remove_links(&$feed_data) {
>
> Why are we removing links?  Is it because the iframe stuff doesn't work
> yet?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/plymouthstate/PSU-Mobile/pull/11/files#r804371
>
that would leave you with "ca = <blank>". Would it not be better to do something like:

    <% if scope.lookupvar("puppet::server::ca") -%>
      ca = scope.lookupvar("puppet::server::ca")
    <% end -%>

which would omit the line entirely?
As far as I can see your not using DQL or some sort of query abstraction.
ON DUPLICATE KEY does not work in PostgreSQL.
I don't think this is Mike's script.
So this can be deleted?
What does mock_galaxy do?  does it set up some kind of test expectation?  This will fail if I remove the invite call below?  It looks as if nothing is actually being tested here.
They have the same effect in this case I am pretty sure, so either way is fine.  I think I actually prefer class_eval since it clarifies that it's happening in a class instance.

I personally prefer ```define_method``` over ```eval``` for this type of thing, though it would require incorporating ```instance_variable_get``` and ```instance_variable_set``` and breaking up ```||=``` in this situation.
https://help.github.com/articles/syncing-a-fork
А зачем создавать буферизованные Reader/Writer, если копируешь по одному байту?
Здесь тоже надо проверять выход за границы массива.
Что будет, если на вход дать просто "-"
Should check that if stream already ended before emitting end.
@bebef1987 : Can you clarify if you need a message sent back on Fail or is the error about the import that @AlinT talked about, i fixed that on the latest update.
I wrote this thing in the heat of the battle and I don't remember if there was a reason or if it was just a precaution. I'm inclined to think that I put it there because something, somewhere, broke.
This will raise an exception if T is a list.
I would rather use an explicit `not in (PAI, PAII)` test rather than using string comparison for this.
This test is useless as if "locales" is not defined, it will be an empty array. Maybe I can add a requiresAtLeastOneElement in the configuration ?
Fix using nullable
`OutBuffer` has a `printf` method.
I'll update to test all compiler outputs (not only error message, and also pragma(msg)).
Then runnable and compilable tests would be able to use the feature.
Code de retour de l'opération : 0 => Le document a été ajouté à la collection ; 1 => Le document a été placé dans la quarantaine
Singulier ou pluriel ?
We've already brought in all of active_support in this gem so you can just do extract_options! here.
I should probably come up with better names.

check_missing_deps is the toggle for controlling the entire deps analysis.
If you don't pass that, it completely skips the missing dependencies
analysis.

check_all_deps is a flag for the missing deps analysis. Without it, it will
omit warnings for classes that aren't declared in a scala target. So if you
have an undeclared dep on a java class, without check_all_deps, it won't
tell you.

At the moment, check_all_deps is only useful for debugging. When I do the
analysis, I don't look at jar dependencies - so if a class depends on
something that it's getting from a jar library, rather than  from scala
source, the analysis won't see it.

    -mark


On Tue, Nov 6, 2012 at 6:38 PM, Benjy Weinberger
<notifications@github.com>wrote:

> In src/python/twitter/pants/tasks/scala_compile.py:
>
> > @@ -71,6 +72,18 @@ def setup_parser(cls, option_group, args, mkflag):
> >                              action="callback", callback=mkflag.set_bool,
> >                              help="[True] Enable color in logging.")
> >
> > +    option_group.add_option(mkflag("check_missing_deps"), mkflag("check_missing_deps", negate=True),
> > +                            dest="scala_check_missing_deps",
> > +                            action="callback", callback=mkflag.set_bool,
> > +                            default=False,
> > +                            help="[%default] Check for undeclared dependencies in scala code")
> > +
> > +    option_group.add_option(mkflag("check_all_deps"), mkflag("check_all_deps", negate=True),
>
> Not sure I understand the distinction between check_missing_deps and
> check_all_deps
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/foursquare/twitter-commons/pull/3/files#r2050146>.
>
>



-- 
Mark Craig Chu-Carroll
*** Software Engineer@foursquare, Software Tools/Programming Language/Math
Geek
*** Email: markcc@foursquare.com <markcc@gmail.com>; Twitter: @MarkCC
*** Blog: http://scientopia.org/blogs/goodmath
Fixed.

Those bloody frenchmen and their poor english !!!
Yes, as far as I know the path attribute requires the full name of the file you want to include.

I don't think it is going to be a big an issue  though, if this library should change for whatever reason the  test will fail telling that the library is missing. If some dependencies change I'm expecting to change something in this file anyway.

The alternative is to refer to a module, I don't think there is one for avro in JBoss AS but I will check.

I'm open to suggestion though and I would be happy if someone can prove me wrong :)
Maybe too big a change for now/for this commit(?), but we should presumably changing these xxxCluster() calls to xxxProcess() also..
Anything wrong with MyISAM?
Calling it `valid_value` makes me think it's a "value". Consider just calling it `valid`.
Also here, breaking after the += causes a syntax error
я цей PR розглядаю як твій, а не Сергія. якщо вони не потрібні, то їх тут не повинно бути.
I don't know I think `\S` fine, but I don't have problem restricting it further to `\w` either.
Agree that variable name isn't clear.  "required_status" is better. What about "symbol_for_required"? The problem is that I can't find good name to describe arguments without default values. I've seen "pre optional/splat" in other files but I don't like this name too. I don't mind naming it  "required_status".
there is no problem with it, check [http://travis-ci.org/#!/cursedcoder/KnpLastTweetsBundle](Travis)
You should always leave whitespace between a function and each of its parameters:

~~~clojure
(apply max (vals (frequencies (map rank hand))))
~~~
See https://github.com/puppetlabs/puppetlabs-razor/pull/48/files#L0L64
The . caused a full meterpreter crash when tested so its a precautionary measure
This indent is kinda off
No general references pls, only references to the specific technique used in this exploit
No, I don't know Pietro. I'll let you contact him then.
ditto ;)
This seems slow, right?  Adding polylines to a collection is an o(n) operation with respect to the number of polylines in the collection with the same width.  Although managing the individual positions will dominate, this still seems like needless computation.  Can we cache the last index?
Up to @bagnell, but I don't think we need to; I'd rather not introduce the extra file for this.  In 3D and Columbus view, `far` affects individual objects getting clipped in the distance.  In 2D, it affects everything getting clipped at once.  I suspect they are the same value because it was a quick copy and paste, not because they need to be.  In fact, in 2D, the distance isn't exactly meters.
I like the idea of using a default initial size and the ability to change it through some object literal to the constructor.
Do we even need the public `bufferUsage` property?  Can't we remove it?
```python
if 'error_messages' in kwargs:
```
is enough. In python, iteration or membership test use keys by default, no need to generate a list
Just check if  [newUrl fragment] is null?
This pattern seems common. Does it make sense to create a helper method that takes a callback and calls it with the trans, store, etc.?
Good job, it is much clearer that way.
придумай лучше. по-моему ns.markAsDragArea пойдет. ты просто неправильно переводишь "mark as drag area"
пишу тут:
названия, explicit, const, const&, using и т. д.
We probably also want to wrap this in ```#if !defined SPI_TRANSACTION_QUEUE_LEN``` so you can set a different queue length in the airframe file if needed.
Ah, sorry, didn't see this before writing my below comment. I think the entry should have a title/one-sentence summary which could be highlighted so that users who are just skimming the log are less likely to just TLDR-skip it.
403 is correct i believe
reverted this file.