labofsahil/github-event-dataset-2012 huggingface dataset:
The 06BindCache script is redundant, you should think about dropping it ( I have dropped it from cMTD )

instead look at
https://github.com/CyanogenMod/android_system_core/commit/110e0046059668db58e967e062da2a718e1e5e05 
and
https://github.com/CyanogenMod/android_vendor_cyanogen/blob/gingerbread/prebuilt/common/etc/init.d/06mountdl


I have a script based on 06mountdl
https://gist.github.com/1182265

wouldn't blame you for stating that I was over thinking it :)
some reasoning here
https://github.com/ezterry/GB-device_htc_dream-sapphire/commit/3186eb5e606704f0fc4f861099555f89397c0825#prebuilt/etc/init.d/06BindCache

also, 40mb is probably doing the opposite of what you need it to do

the cache bind script was created a long time ago when I re purposed the cache partition,
I then added the size check when I employed the script for cMTD, at the time the g1's cache size was 30mb, since then we have 1.33.0013d with cache size of 27mb.
I assume that if the cache size is below the 'smallest' that it has been shrunk to it's minimum, so the bind is done
Your 40mb will always bind mount a g1's cache which may lead to some issues with market, especially if no sd-ext, see
http://forum.xda-developers.com/showpost.php?p=21246394&postcount=35
their data partition will be under unnecessary pressure, needed at least 2xAppSize + 9.3 mb free space to install  

But like I said, it really is redundant as long at DOWNLOAD_CACHE is set and you have some script to look after it, either cm's mountdl or some variant of 05setEnv

NameLessJedi has also added this
https://github.com/NameLessJedi/vendor_nlj/commit/d054edc5fb0fcbbc98f4b906f441d02c2540894c


Keep up the good work :)
Should this be == instead of != ?
that is what i had in mind, and the test seems to catch that
maybe you could post a little more detail about what is exactly the problem...

I installed the tubs package by copying the contents of the archive to the texmf folder and installed the nexus font using updmap. This worked for me.
done ^^
thanks, I actually fixed this previously but somehow the commit was missed when merging the sensors stuff into master...
Reset generally clears out all the data.  With a file setup, it should probably still do that, but how would you instead reset the data?
Can do - was just mimicking https://github.com/fog/fog/commits/master/lib/fog/core/current_machine.rb
@dholth , regarding our IRC discussion, I was able to confirm wheel-installed packages don't properly uninstall (due to pyc files being left, which causes pkg dirs to be left).   this is not currently a problem with pip egg-info installs because part of the logic of the setuptools/distutils record feature is to add the *.pyc filename to the record list (and __pycache__ compilation is handled generally in `UinstallPathSet`)

so it's something this pull needs to handle (and test for), since this is a problem just for wheels.  I think an additional  `paths_to_remove.add` for the py2.x compiled file is all that is needed, although you maybe have ideas on how to handle this in the most general way.
Donna told me that it's intended to save some disk space as it's only a temp file and there's no chance for it to be deleted after downloading.
In adm.js, "Boolean" is used to specify a bool type
I don't like plugins placing input/output views into the core namespace (pages already adds `input/write_access`). Would prefer this view be "pages/input/parent", "input/pages/parent", or "input/pages_parent". @cash am I off-base here?
Yes, the change will force early "resolution" of the class which tries to ensure that the class is well behaved, and initialization by running the <clinit>.

I assume that the idea is that the class will be used just after calling this method, which will trigger those things anyway, so we might as well do it here.
Why yield serialized?

    for (originAddress <- origin; serialized <- serializeAddress(originAddress))
        controlMessageBuilder.setOrigin(serialized)
of course that reasoning required some sprinkling around of `private` and friends.
Equivalent to (but runs only one pass):

    nodes flatMap { node => if (node.address == address) Some(node.metrics) else None }
Great job, thanks Patrik
get the imports cleaned up
syntax error … “The callback will receive X as argument?”
Cool will fix that.
maybe not part of this branch but should we move these magic numbers into constants or even set-able via .ini
Awkward verbiage, consider: "The following...".
rename subContext
plz don't forget FreeBSD here.
or use _LINUX or TARGET_*
This is just an example. The FaradayMiddleware is a separate beast. I just copied our production setup verbatim as an example of what's possible to do with this adapter.
https://github.com/pengwynn/faraday_middleware
The worked and seems like a reasonable solution to what was otherwise a very thorny problem.  Feel free to figure out a better way if you really don't like this.
can you preserve the spacing used elsewhere?  statements should have a single space after them. thank you :)  also: hoist `p`?
It would be changed like:

```python
if not r:
    self.raise_exception()
```
On the contrary, `'["foo"]'` does not.
Why is this rectangle comparison necessary?
`TUILayoutConstraintAttribute` requires otherwise ;]
Sometimes my copy-pasting goes to extremes... I'll go fix that.
This comment should be on its own line.
Eeep! I'll get that in the next commit!
This should be "Universal 32-bit & 64-bit (.pkg)".
s/send/sent/
Yes, I guess I wanted to test "same type" interpolation here instead of the decomposed version, but I guess it's better to stick to the original purpose of the test after all.
We should favor the standard event names, rather than mapping them to different names for the D3 API. This includes using "load" instead of "success".
Using a docstring doesn't avoid the indentation problem, I'd need to call textwrap.dedent also in that case
Thinking about a better name for this option... maybe `versioning` would work as a catch-all for other versioning related things we might add? If this is too generic or specific, than maybe just `commitMessage`.
Variable/argument names should be all lower case, `Print` -> `print`.
This won't work anymore since they are all lowercase.
отладочный вывод из релизной версии лучше убрать
Only 3 ```
I'm not sure if messing with this whitespace here is a good idea or not. Does this fall under 'cosmetic?'
This was changed in ruby. In versions >1.9 Range#=== is just an alias of Range#include?
Maybe there is a point to do new commit with `alias_method :=== :include_without_range?` instead of changing guides for compatibility with previous usage of Range?
> I would place a dot in the beginning of each line but Ruby parser can't handle comments in-between :-( The receiver is the previous line, I've made an indentation to help people see that.

Put the comment inside the block.  e.g.:

```ruby
order_columns = orders.map { |node|
  # Convert Arel nodes to strings
  node.respond_to?(:to_sql) ? node.to_sql : node
}
```

The call to `map` isn't actually doing the conversion, it's building an array.  The call to `to_sql` is what your comment is actually about.

> The previous code converted to_sql everything but strings: s = s.to_sql unless s.is_a?(String). I'm doing essentially the same thing, except I ask the object if it can convert itself rather than check type.

It's still different behavior.  Removing the check for `String` means that we are increasing the number of types of objects that we accept (is it now OK to add `Arrays` and `Symbols`, etc?).  Unless you're actually fixing a bug, please don't change the logic.
same comment as above. switching to an object doesn't buy much and it breaks Java consumability.
I was playing with fixing the docstring, and this is apparently not really true.  For example, `expand(log(x*(y + z)))`, where `x`, `y`, and `z` are positive gives `log(x*y + x*z)`, even though `expand_log(log(x*(y + z)))` gives `log(x) + log(y + z)` and `log` comes before `mul`. 

This is because the way the algorithm is applied, the hints are applied several times, recursively (this is also I think part of why expand() is so inefficient).  

I'm going to send a PR to you fixing the docstrings and also updating this docstring with this information.
perhaps

```
which is exactly what is needed for the third paramenter, ``res``, in ``add``.
```
Put in the same note from the old test: `Use "# indirect doctest" in the docstring to surpress this warning`
I see no compelling reason to use `__new__`. You should use `__init__` instead.
Ya. I will change the doc example in my next PR
Space between ``x,y``
The indentation in this file seems bizarre. But it was not caused by this PR.
What assumption are you making about the number of arguments in the Add? Why is the 2nd one special? You need to more clearly indicate what you intend to expand. I think I mentioned this before: what should happen with `(a + b + c)**0.3`?
`block` will be ok then?
不存数据库有风险，进程重启，或者内存溢出，网站就挂了。用户又要重新授权，很麻烦的。
lolz

At this point, just do ``if(filename == null) filename = number + "." + type;``
you should revert this change according to the Sf2 CS.
Pourquoi inclure *webapp.css* ici et non pas *web.css*? Quelle est la différence entre *web.css* et *webapp.css*?
phpdoc missing for this property
How about just doing 
```php
foreach ($error as $key => $lang)
{
    if (is_array($lang))
    {
        $lang_key = array_shift($lang);
        $error[$key] = vsprintf($user->lang($lang_key), $lang);
    }
    else
    {
        $error[$key] = $user->lang("$lang");
    }
}
```
Remove ` ? true : false`
Its getting it from a trusted file?
Blank line before EOF
As my board only broke due to buggered database updater after I logged in, it seems that anonymous users do not use notification manager.

If so do not instantiate it globally, but do it on demand.

This call is worth 0.04 seconds.
break; statements must line up with case statements, as is the case throughout the rest of the file.
This is a rather useless comment.
This should be done by the caller, not here.
If driver is the only additional part could we maybe allow specifying driver via PHPBB_TEST_DRIVER and a variable in test config.php?
This needs to be off the query unless you mean I should do the comparison in the SELECT clause.
I need to know if the 1st one I get is not a category. If that happens, then this update is applied, else, it isn't.

Talk to me in IRC if you need more details.
Escaping?
why not move this up a line and then change the conditional to check the var, ruok?
please see f7fa805. I created a module that contains the context. better than stashing the context someplace globally, IMO
Changed in 1c6614ea37f246d62011d42e069e995c41385a83.
spațiu după :, te rog.
addXHailsSensitive is a `Middleware` that adds a header to the response under certain conditions. All Middleware always "executes" the app (the type signature is `Application -> Application` === `(Request -> m Response) -> Request -> m Response`), so I don't think there's anything abnormal here. In other words, middleware pipelines *should* in general depend on either the request or response or both, and therefore not be trivial.

How would you propose we do this instead? Basically just have the functionality in `hailsApplication`? It's not super complicated so we can obviously do this, but it seems like this particular functionality belongs in a different method because it's sort of special and is actually pretty likely to change, so it's nice to have it boxed into it's own method and, e.g. independently testable. Maybe just something that filters the `Response` rather than the whole `Application`?
@aszlig,

> this is just a small file, maybe put it directly into pkgs/build-support/cabal/jailbreak.hs?

I guess, it's possible to check `jailbreak.hs` into Nixpkgs. I'm not particularly happy about the notion, though, because the program does have its own repository (which includes the Cabal file and the LICENSE file, too), and duplicating the source code in another repository seems undesirable. Besides, how big is the risk, really, that Github is off-line for an extended period of time?

I consider the current `fetchurl` download an intermediate solution that's used until `jailbreak-cabal` has been uploaded to Hackage and can be referred to as a proper binary package that's part of haskellPackages. Of course, the builder needs to be more lazy so that expressions which don't set `jailbreak = true` don't require the jailbreak binary to compile. I'll make that change ASAP; it's probably a good idea to do that in any case.
Need to create a JIRA ticket to track any such TODOs, ~"add support for getting CHW's currently latitude, longitude via GPS".
There should be a link to that ticket from the code.
are you sure this is what we want to do? I think you might still want to post the "registrationFeesPaid", "complaintArea", etc.. even if you don't want height, weight, and BMI.
`call_user_func` is not necessary here, and is an extra function call.

You could just do `$class::$static_method($params, $this->identity)`.

--- 

The scenario where this would be good is if there were a variable amount of arguments, and we could use `call_user_func_array`
Personnaly I find it harder to read. Why you find it easier? I just try to understand.
Will anyone raise a stink, or will they grudgingly fall back to TimestampType?
I'm not seeing the dozen lines of code in question as being that burdensome.
Long term, I would see it as a net gain if we can deprecate TimestampType.
I don't anticipate that there are that many more "standard types" for which we would have to add more methods along these lines.
Support for the sql.* types seem like something reasonable to expect from an SQL database.
It just seems embarrassing to mostly support all the convenient types for input and output, except for this one interface -- and because we can't decide on terse function names? 
As for "agile", does the "DRY" principle apply to coding something once and then backing it out and waiting for someone to ask for it before coding it again?
Avoid hardcoded scripts.
`_this.getBuildResultChunk()` может вернуть promise
Didn't know coffeescript adds an catch block.
But CS returns `{}`, which is truthy.

we could refactor it to
```
try
  return require module
null
```
But that isn't better readable imho.
Whitespace. Again, looks like copy-pasted piece of code.
It's the best way that I found... personally I like it because that way you can see how our output variables (or the output hash) gets affected. It also makes it more testable. Other variations I could think of would have resulted in creating instance variables or passing the hash around and modifying it in every method.

The order of styles would have to be adjusted for everyone of the output variables, which I believe is reasonable :-)

If you got a cool idea I'm open to changes :-)
Perhaps here's a good point to mention using South if you do need to change it post-facto.
I think that `underscore-rails` and `jquery-rails` should go to `assets` group as they have only assets, `pjax_rails` should stay outside any group. I guess if we do so we won't need to modify `config/application.rb`.
I think the prefix ServiceBuilder ist not usefull because the http plugins also didn't have a prefix it is done by the namespace.

The Plugin add plugins to all client so what do you think about ```ClientPluginsPlugin``` i think it match the thing what i does, but i am not really lucky about the double plugin in this name.
`debug` itself doesn't, but `wrapText` does.
You can probably just do `async || false` here
res = re.search(r"/\*.*\*/(\r\n)|[\r\n]", fileData, re.M | re.S) # Will avoid breaking with MAC line endings
There has to be a better way than doing this crap all over this place :-P
If our tests were correct, then yes...
Word, I'm on vacation, so @dmethvin will have to add it
Add in the deprecated reference, so that I can test & merge this ;) Nice work as usual :)
so, my commit just landed which added `"WebKitPoint"` to this list. @dmethvin and @rwldrn please include this.
Hi Grace,

    expected_extraction in the crf_test.sql_in and expected_crf_feature 
in the crf_train.sql_in are
produced from the Dr. Sunita's java CRF package 
http://crf.sourceforge.net/ with the same inputs.
I used these results as the correct result to compare with the our 
results.


On 2012-08-31 13:54, geeg wrote:
> In src/ports/postgres/modules/crf/test/crf_test.sql_in:
>
>>
>> -- Features table
>> - CREATE TABLE textfex_feature (id integer,name text,prev_label_id
> integer,label_id integer,weight float);
>> - INSERT INTO textfex_feature VALUES
>> + CREATE TABLE crf_feature_test (id integer,name text,prev_label_id
> integer,label_id integer,weight float);
>
> Hi Kun,
>
> Similar to my comment about the values of expected_crf_feature, could
> you explicitly document where these hard-coded values for
> crf_feature_test and expected_extraction came from since they are 
> used
> to check against the MADlib crf output? Thanks!
>
>  --
>  Reply to this email directly or view it on GitHub [1].
>
> Links:
> ------
> [1] https://github.com/madlib/madlib/pull/199/files#r1508848
You can use memset
I don't know "text_to_cstring" is standard library function. Then, we should use it definitely.
This line prevents a build deciding to be universal when we didn't want it to be or wanting to add eg. a ppc arch. Universal flags are forcibly inserted in the cflags function.
This should go up by the other dep, and be a one-liner: `depends_on 'cmake' => :build if ARGV.build_head?`
Do you think it might be worth adding `head`? There is a git http://repo.or.cz/w/isl.git
`&>` is a bashism, and while bash is the standard shell on OS X for now, it may not always be, so we should try to use portable constructs.
I find your latter suggestion attractive. Will do it.
dlg should be d i think
Personally I like the shortcuts because i dont have to learn new ones. Also a webapp is different from a normal page, but maybe its against best practice.

Some shortcuts for comparison: http://office.microsoft.com/en-us/web-apps-help/keyboard-shortcuts-in-word-web-app-HA010378332.aspx
http://support.google.com/drive/bin/answer.py?hl=en&answer=179738
http://support.google.com/mail/bin/answer.py?hl=en&answer=6594


@jancborchardt what do you think?
It returns a forest of comment trees. And I would like to have the docstring contain information about how to get the leafs. How about

Return forest of all comments, with top-level comments as tree roots.

Use all_comments_flat for a unnested, flat list of comments. Multiple API requests may be needed to get all comments.
LGTM (looks good to me)
Todo: Bad merge
Oh, no real reason. I think I had a few instances of the same line with no consistency of how the tuple was arranged and did a find/replace to make them all ordered the same way.
How would we best solve cases like this where the word isn't a perfect 1:1 translation? The important thing is the intent and clarity of the instruction, rather than an exact or literal translation. 

Not knowing any languages other than English i may not be the best person to have a discussion on linguistics, but certainly we can sort out some good solution.
Removed those checks.

On Tue, Nov 27, 2012 at 8:11 PM, Cristi Burcă <notifications@github.com>wrote:

> In src/php/wp-cli/commands/internals/scaffold.php:
>
> > +    }
> > +  }
> > +
> > +  /**
> > +   * Subcommand taxonomy
> > +   *
> > +   * @param string $args Name of taxonomy
> > +   * @param array $assoc_args The ussual WordPress arguments
> > +   *
> > +   */
> > +  function taxonomy( $args, $assoc_args ) {
> > +    global $wp_filesystem;
> > +
> > +    if( !isset( $args[0] ) ) {
> > +      WP_CLI::error( "Please provide a taxonomy" );
> > +    }
>
> This check will not be necessary once you add the @synopsis tag above.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wp-cli/wp-cli/pull/226/files#r2240163>.
>
>



-- 

Met vriendelijke groet,

*Sebastiaan de Geus*

*hoppinger*
*internetconcepten  websites  applicaties
*Lees op ons blog over social media, webdevelopment
en ontwikkelingen op internetgebied: www.hoppinger.com/blog/

Hoppinger bv
Lloydstraat 138c
3024 EA Rotterdam

t: +31 10 221 01 90
e: sebastiaan@hoppinger.com
w: www.hoppinger.com
That's true. And there's not really a chance of unexpected failure, so verbose option isn't necessary for this command. I'll remove it.
Nono... thanks a bunch for creating and maintaining this nice little gem for working with MOAI.  =)
There may be some messages still stored in the OS buffers and then some in flight and we lose these. Lets follow the simpler approach and make it complex, if necessary, later.
I can implement it in JUnitCore, but not in the "main" method. There are many ways for a JUnit test run to be started, and not all of them make use of "JUnitCore.main". Java IDEs, for example, don't use the "main" method.

The whole point of this feature is to allow the *transparent* addition of external listeners to a JUnit test run, just like what was made available in TestNG 6.2. Therefore, the SPI lookup has to always happen.
@dsaff 
pls see my latest commit (updated JUnit description)
Ooof. I didn't even know about that file. Yeah, this should go in i18n.

On Wednesday, June 20, 2012 at 11:45 AM, Dan Imal wrote:

> > @@ -0,0 +1,2 @@
> > +.component.playlist-button
> > + %a{ title : "Playlist"} ="Playlist"
> > 
> 
> 
> Do we need the title text? We don't display it for most other buttons. Maybe we should start adding text again since we have mobile web and we should be accessible, but if we do have text, it should all go in the internationalization file:
> 
> https://github.com/Toura/mulberry/blob/master/app/mulberry/nls/en-us/mulberry.js
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Toura/mulberry/pull/498/files#r1018738
> 
>
Also, this is the name of a CSS class -- it shouldn't be localized.
I always trip up here where I want to be more explicit about using a fallback. I'll change to ``!!``.
This comment seems long enough that it should be put on a separate line above this line of code. That will also give you more space to expand abbreviations V, H, and ht.

Same comment applies to 2 other places in this file.
@RaymondLim @peterflynn I guess we have some conflicting guidance:

The JavaScript Style Guide (https://zerowing.corp.adobe.com/display/brackets/JavaScript+Style+Guide) says:
"Use single quotes, except for writing JSON (Node)"

The Brackets Coding Conventions page (https://github.com/adobe/brackets/wiki/Brackets-Coding-Conventions) says:
"Use double quotes in JavaScript. If a JavaScript string literal contains code within it, use single quotes within the string to avoid escaping."

I don't care if we use single or double quotes, but I think it's easier to read without escape characters.
Quotes inside url() are optional, and usually omitted.
This syntax is a little misleading. How about:

```
var directoryEntry = ...; // NativeFileSystem.DirectoryEntry
directoryEntry.getDirectory(path, {create: true});
```
One thing of note: this won't clean out old tags that may have been invalid.

Not a huge deal really though.
Also, if you feel like it.. you can leave your name here
commented ?
There's no harm in them. But I don't know much about them either.
This exception is not caught anywhere
Of course then that variable we do not need in the first place. ;-)
I used js inline for "onclick" attribute because it is much shorter and beautiful code as it would be if I used jQuery for setting up "onclick" attribute in external file. But I can use external file if you like.
We are not using sites anymore - they require relational database.
could you fix indentation?
While this transition time is adequate for most other tool tips, I feel it is a tad bit too laggy for this application. Would it be simple enough to override this style with a faster transition to opaque?

That is, if you agree it'd be a good change.
few whitespace issues in this block, if you don't wanna do it that's fine as we have beautifying tickets. Either way, figured I'd make note of it
Restore these 2 lines (comment + removeItem), and have callback(p) go last.
are migrations built into the deploy script?
anything that describes what it does is fine. retTmp is a bit meh.
We should store the `feed-atom.php` template as `src/templates/feed/atom.php` and share it across themes.
Oh right. Sorry for that.
good point, made it a map instead.
No, I thought ContentViewVersion has_many :environments.
I think this snippet would be better suited living in public/javascripts/wdigets/tipsy.custom.js
drop_column is invalid it  should be remove_column
Generally speaking - yes. The method provider has to remember to put it there (or some custom equivalent). I'm also not sure if that's the best idea, but...
What if I'd like to always have all the parameters strings, or more general - if a parameter is of different type than the exact JSON equivalent? Eg. client passes JSON date-time object, but the method expects `object` or `string`?

Would the deserializer try to deserialize to the .NET equivalent first and then try to do cast, `Convert.ChangeType` etc., or would it simply fail? I'm just not sure how the `JsonConvert.DeserializeObject` method exactly behaves, so I left the decision about the deserialization logic to the method provider itself. 

By default - we use the `Adjust` extension method of course.
No doc at all?
We could maybe remove the type to simplify the v1 of the app.
if (!this.hasPincode || !this.conn.cardState == 'pin_required') {
      console.log("Can't unlock.");
      return;
    }
To be clearer, the file is now called manifest.json and the structure did change a little (to allow localization for example).
Captured in issue #346 for later.
Is this deliberately commented out?
It seems you have a "." too much here.
@sipa Should this contain the SOCKS version? This would not get into this pull, just asking :).
That Commented out code should fade, if not used :).
This is the current behavior:

		$result = $this->Form->input('Post.content', array('rows' => '15', 'cols' => '75'));
		debug($result);
		'<div class="input text"><label for="PostContent">Content</label><textarea name="data[Post][content]" rows="15" cols="75" id="PostContent"></textarea></div>'

		$result = $this->Form->input('Post.content', array('rows' => '15', 'cols' => '75', 'type' => 'textarea'));
		debug($result);
		'<div class="input textarea"><label for="PostContent">Content</label><textarea name="data[Post][content]" rows="15" cols="75" id="PostContent"></textarea></div>'


Which i would think is not correct in the first place, or am i wrong here? i think its a bug that it doesnt set correct class when type is magically defined by presence of cols/rows
Perhaps add a check for valid currency using CakeNumber::$_currencies and return false in case of invalid value.
Couldn't this be expressed as:

```
if ($type === null) {
   $type = self::$hashType;
}
``` 
Instead of the nested ifs?
Watch indentation.
Good catch. Using labelSeparator is indeed a good solution.
But currently is labelSeparator modified when we change the language?
Can this be done globally at the application level?


On Wed, Nov 21, 2012 at 5:43 PM, Stéphane Brunner
<notifications@github.com>wrote:

> In core/src/script/CGXP/locale/de.js:
>
> > @@ -175,6 +175,14 @@ GeoExt.Lang.add("de", {
> >
> >      "cgxp.plugins.QueryBuilder.prototype": {
> >          layerText: "Layer"
> > +    },
> > +
> > +    "GeoExt.ux.form.FeaturePanel.prototype": {
> > +        pointRadiusFieldText: "Grösse ",
> > +        colorFieldText: "Farbe ",
> > +        strokeWidthFieldText: "Breite ",
> > +        labelFieldText: "Text ",
> > +        fontSizeFieldText: "Grösse "
>
> As I know there is no space before ':' in German, I can ask to Elisabeth
> tomorrow to confirm that.
>
> And this space should be in labelSeparator:
> http://docs.sencha.com/ext-js/3-4/#!/api/Ext.form.FormPanel-cfg-labelSeparator
>
> It should be an unbreakable space ' '.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/camptocamp/cgxp/pull/290/files#r2196150>.
>
>



-- 
Pierre GIRAUD
Géomaticien, Analyste

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac, Cedex

Tel : 00 33 4 79 44 44 93
Mail : pierre.giraud@camptocamp.com
http://www.camptocamp.com
s->state = LookingUp_state_NUMERIC
合并吧这俩函数

除了这个俩操作之外，另外把连续的 / 也替换成一个吧，例如 a////b -> a/b，这样的话不要inplace的改吧。新建个qstring不要紧的。
nodejs'te default olarak trim diye bir metod olmali string'ler uzerinde. kontrol eder misin?

yoksa da goog.string.trim kullanmak gerek; String, Number, Function, Object gibi native objelerin prototype'larinda yeni property'ler yaratmak butun instance'lari etkileyebilecegi icin tavsiye edilen bir yontem degil.
```
character_id:
    The ID of the character to look up kills for.
before_kill:
    Optional. Only show kills before this kill id. (Used for paging.)
```
I was in a hurry. There is a way to set it. I'll fix it sometime soon.
please remove pyzmq-static here
I was following the lead of the earlier tests.  This one doesn't need it though.
Ah, OK, I see.  Though note that this had been there all along in magic, for years.  I'm happy to do a cleanup of that some other time,  but now is not the time to go weed-whacking in the entire codebase for it.  This PR is massive enough as it is, and I tried to do only what we needed, not to clean up every last defect of the old magic code :)  So I suggest we keep the cleanup work to new code, and leave some of the old warts (and I agree this is one) in place until some other time.
`IPython.kernel_notification_widget`
Is it okay now?
So do you want be more explicit  that it is the embeded Javascritpt that causes an error ?
Ah ok. In the latest version, I have:

```python	
+    - if [[ $TRAVIS_PYTHON_VERSION == '2.'* ]]; then iptest -w /tmp; fi
+    - if [[ $TRAVIS_PYTHON_VERSION == '3.'* ]]; then iptest3 -w /tmp; fi
```
make AuthenticationFilterSwitch and interface, and rename it to AuthenticationFilter.  In this method, switch on authType and either return BasicAuthenticationAndTenantId or OpenstackKeystoneAuthReqFilter.  you can pass these as method args as opposed to the injector.  Also, you should coerce @Named(CDMIProperties.AUTHTYPE) String authType into an enum called AuthType
This is open source - please don't use these names.
ooooor, handle this in a middleware.
I think the language here is not quite correct. I think maybe "At least one letter and one number are required in the password" because the password can also accept symbols and other things--is that right?
it ends up we don't really need the UserResource, so I just removed it.
Some of our existing files lack license headers, but we should make sure to include them in any new files (we'll also fix the existing files eventually). The license we're using for this project is MPL 2.0, so the license header for this and other new JavaScript files, per [Mozilla License Headers](http://www.mozilla.org/MPL/headers/), is:

```
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
```
I'm sorry I didn't spot that earlier, but this file is actually not a great example of how to do service implementations. You will find a better example in ``socorro/external/postgresql/extensions.py``. 

So what's "wrong" here is:
* You shouldn't use web.py here (yes I know I do it in the ``get`` function, I will clean that in the near future) but only in the middleware service (``socorro/middleware/products_builds_service.py``). Don't bother raising BadRequest or InternalError exceptions. 
* Using a different function thus makes no sense: the content of ``insert_build`` should come into ``create``.
why not remove this?
What's "Apache" about this? Why not just called it `ModWSGIServer`?
Should the items in the array not be url_encoded before being sent to the middleware service?
Maybe use something like this ?

    $instance_id = '_' . ((isset($options['widget'])) ? $options["widget"]["instance_id"] : rand(2000,3000));
Should implement WritableStreamInterface.
fixed '0' problem
any specific reason on why it should be that way ?
extra space before strlen
I would use ``if (null !== $route) {``
ah, nice catch.
That's the proper indentation apparently.  emacs does a good job of setting it unless you have annotations.
I didn't have any problems compiling Ruby 1.9.3-p194 on an m1.small.  But the dots probably make sense as a progress indicator if nothing else.
Same question regarding tag testing.
I'm not madly concerned about it - the tolerance is arbitrary at the moment anyway (mpl issue 1291). I'd be happy enough to change it though if you'd prefer?
> I can't see too much benefit from the conditional import here (it doesn't import matplotlib does it?).

Then you shouldn't have written it! :wink: It's just a cut'n'paste from your natural_earth_shp method.

Seriously though, the deferred import does keep the `shapefile` module as an optional dependency.
> This sentence doesn't parse

? My test for this:

```
>>> ('hello %s world'
...  'foobar' % ('test', ))
'hello test worldfoobar'
```
If the `central_longitude` is zero then the method could return EPSG::9825 (as defined by http://www.epsg-registry.org/). But it shouldn't return EPSG::4326 - that would be the job of `Geodetic.as_epsg` when its ellipse & datum are both WGS84.
Yea, I completely agree!
Пожалуйста, не исправляй же идентацию. Или настрой редактор, если он сам.
I think it should be:
gem "rails", :git => "git://github.com/rails/rails.git"
i don't really like when functions have odd side effects like overriding log levels. if this is to make it less spammy, could we put this logic in the mgmt command so it's only relevant there?
this creates a global variable ``cmsQuery``. That's not good. This should either be inlined in line 12 or done in a closure (inlining is probably easier).
I am in favor of adding more introspection to Ember objects.
Yeah the new record is clearly wrong. A cast would be the correct approach. Also the cast to byte is not needed. 

Test cases are a bit neglected so far, would be a good idea to add more. And also there now might be inter-record-dependencies and rules (id references, handover record being first record etc), so some kind of extra validation would be good.
We already talked about this on IRC, but for the public record: My GnuTLS patch only gives the option to use GnuTLS. If OpenSSL is used we still need to link with libcrypto.
This should be a localized IllegalArgumentException. Generally, we cannot use throw new *Exception() without localization
Yes you're right. It should also handle autostart.
Can we setup this handlers in one single place. They look like the same for the fb_link.js and the fb_impor.js, better to have them in a single place to change just once.
always have spaces between ':' and the content of the rule
Thanks, this is rubbish from previous tests
As you said we are going to add "Pending" message in two ways:
- In "Message Thread View" we will append the message after the list showed, so there is no DB query (same as you suggested)
- We need to include it in Thread List because now It's a requirement of UX Team... (check behaviour in iPhone. Even without any SIM Card iPhone creates a new thread with this 'pending' message). When API stores this pending we will remove our 'concat + sorting' method from 'pending' JS class and everything will work without more changes ;).
i < 4 (gjslint)
I admit I couldn't figure out better wording :X
BTW, @borjasalguero , have you tried to comment out the content of the fitPrimaryInfoToSpace() function? I am not getting much better performance :-)
Yes, this overrides the dialog submit method so I can manage last STK operations ;)
O.K....some physics...`inertia moment`?
well, it was included before, we just put it out so user can add it or not. This way will be included in the code when you do a pull, but if you don't want it you can take it out from the index.

Furthermore, I think that almost everybody test it on desktop before trying in the phone.
two things i need to know before i can advise:

1) @arcturus for my understanding could you clarify for me what your concern is about adding a listener? is it dev time? does it effect performance?

2) could you also clarify for me what the current situation is if there is no SIM card in the phone. Do we allow the user to action the import sim functionality? if so what happens? does the user get a massage informing them that there is no SIM?
We should check pluralization for l10n, again is ok for me if we are going to do the l10n in a new round. Remember the strings young paddawan.
projects=None by default?
You can remove the `rescue` wrap from this now.
Can we fix this properly in FakeRedis? I assume real redis doesn't do that...
So why is it called Safe? I thought that means it won't throw an exception?
unused arg: handler
can you add another one:

(m1: Map[Int,Int]) =>
  Monoid.sum(m1.values) == Monoid.sum(removeZeroes(m1))
}
Can you explain all of these little contractions, or provide a link to some scala code that explains them? This looks like an internal detail that they'll upgrade sometime to mess with us.
Spell out public and private here.
Should add Freeseer headers to all the .vbs and .bat files.

Grab them from any of the existing code files. You'll likely have to reformat the comments to vbs and batch comments style though.
Can we create a variable into the view instead? I don't want to keep changing templates more than we really need -- so I want this to be the last time on this one. Using $this->usernamechange = true/false should do it..
что это за закомменченный зверь?
Hi Chris, it should be generally true, but there are some tests which changes the running VM (usually tests which creates the VM in the test itself). I encountered this problem in _cdrom_ test where I couldn't check `__needs_restart` because params were changed.
Yes, there are other ways of handling this but I think that this method is the cleanest possible way. You can modify VM params directly if you know what you are doing and you can modify params and not modify VM params if you need to.
This acquisition of buffer & segment locks happens multiple times in similar/identical code, seems like a DRY refactoring opportunity?

* lookup
* range
* iterator (the new addition)
I'm not convinced yet it's a good idea... Every time you use 1 regular expression you add 1 problem to solve...

Wildcards are something Backbone and Chaplin both use in their `routing`; they are simple and offer flexibility. They also lead to fewer errors and enforce good naming of actions.

So, I'm not sure.
I guess they are named this way because the method are executed after the event has happend. 

ie when an  item is added to the collection,  itemAdded is executed.

To me it makes sense.
this looks like some copypasta of some bad code I wrote and didnt test :(
ok, I deleted it ;)
What happened to `error` in what was previously line 266?
This insert() creates an Activation for rule2-modify and rule3-modify
This is used to decide the CPU id. We want it to be fast so the value should be defined at compile time. How can I access the Linux define value from here?
Are site messages always going to have a tool icon?
unnecessary by the looks of it; set to 0 when it's defined in the block above
4 is magic.
Add comment "Deliberately ignore Exception"
This page will not render in a browser. Culprit seems to be (at least) that these paths are not correct.
Nope, it's not :) `prototype` is an argument.
relative require please
> It is add-on code, but here we are in case of system modules. They should only use require(sdk/panel), right?

Ah I see what you mean. I think you're right need to verify though first.
Nit: typo doesn't
when I'll remove fake data I'll not need it anymore. That way I'll not forget about removing the require.
also, this require is used in this function only, so no need to have in the module scope
Do we need the $_SERVER... ? Can we just remove the /CoinCod/ without deleting $_SERVER... ?
I think it just means that multiple engines may be created after a single modification, right (assuming multiple threads try to read between modification and engine creation time)?  I figured this was still an improvement over a new engine being created with every read.
If this is safe because it is actually a private method, then can we change the method to be private? Or some other way that makes clear that what you say is the case?
Okay, except that upstart bits can have trailing comments, and parens in trailing comments shouldn't be counted.
this one isn't correct as well
You can get rid of the duplication of these "helper" methods by two ways:

```ruby
module ConstNameHelpers
  include RSpec::Mocks::RecursiveConstMethods

  def const
    recursive_const_get(self)
  end
end

shared_examples_for "unloaded constant stubbing" do |const_name|
  const_name.extend ConstNameHelpers

  it 'allows it to be stubbed' do
    const_name.const.should_not eq(7)
  end
end
```

OR

```ruby
module ConstHelpers
  include RSpec::Mocks::RecursiveConstMethods

  def self.[](const_name)
    @@const_name = const_name
    self
  end
  
  def const
    recursive_const_get(@@const_name)
  end
end

shared_examples_for "unloaded constant stubbing" do |const_name|
  include ConstHelpers[const_name]

  it 'allows it to be stubbed' do
    const.should_not eq(7)
  end
end
```
You could rewrite this as `this.$element.parent('[data-toggle^="buttons-radio"]')`. `^=` means *starts with*.
but it could be even simpler I believe

s = open(fn).read()
There is no IPv6 support in the WebYaST UI
Cut and paste error -- s/filter/validator/.
The same with this.
Same comment here -- this appears to lock the testing API to HTTP only, yet it's clear that you also intend to test Console endpoints. Can you explain?
Use the ErrorHandler please, not error suppression.
Can you wrap this (and other lines) at 80 chars?
Sorry, I wasn't very clear - I was asking if the new private member variables that you added were really necessary.
I was working on ncp loan approval service. Should be back to this tomorrow.
This gives the wrong pluralization when there are 0 items.

-> `return num is 1 ? "item" : "items"`
Why isn't this self.write_headers_if_needed?
@guilhermeblanco All other parts of the EntityGenerator are using ``\n``, not ``PHP_EOL``. Why should the last newline be different ?
this line is useless since the refactoring of the phpunit setup months ago so you should remove it
ah sorry, I missed the space as the first line is not aligned with the others because of the openign quote
extra space after #
As it is a prototyped array node, it is *always* set (it defaults to an empty array unless another default value is configured in the tree)
Use fopen/fread/fclose instead? open/read/close are only available on POSIX platforms.
`(Look...`
No whitespace.
Hah, ok. I'll make sure prefixing with `window.` works. I did a little research on detecting frames and from what I saw this was better supported than the previous `window.parent === window`, which didn't work in several IEs.
this is a private file you should not commit it in the fork 

also cange your password because it's public now
Print out both `self` and `universe`
this actually doesn't work as expected, I'll see if I can find a work-around
>tweet_id は nil を取る可能性があるのか?
Twitter::Tweet オブジェクトに必ず含まれ、nilとなる可能性があります。
あるツイートが、特定のツイートに対する返信だった場合、tweet_idは特定のツイートIDを示します。

>remove_noise(nil) を評価する必要があるのか?
評価する必要ありませんでした・・・

def
rescue
end

でbegin不要でしたね
Yes, according to Restlet API, these should all be initialised, especially as this handling happens at very end of request processing, when `handle()` method (where all our code executes, the Nexus REST resource) are executed.
closing this one. i think it's worth it to simplify how template kinds are being handled, but we'll have to do it in v2 (if we'll do it)
I can add a wrapper div that's present for the VM and image pages and then just replace the contents. Is that what you mean, @ohadlevy?
Would probably be a good idea to wrap the two deletions in a transaction.
Thanks for the review Ronald, I'll pick up your comments tomorrow morning!
Shouldn't think be called: 
fedora_repository_fedora_repository_can_ingest
if this str() is necessary the preceding if can fail. adaccount_id should be of type str
admin@example.com / password
The "text-align: right;" could be added back in, but it's only important if the content extends past one line. With the elements set to be inline-blocks, the blocks collapse to the width of the content.

I don't think anyone could be relying on the floats to the point where this would break their layout… inline-block elements can have widths, heights, margins, and padding applied to them, just like floated elements. The width could be more of an issue, because white space between inline-block elements is rendered… it is conceivable that some developers could have put fixed pixel widths on the elements, and those widths + the white space would cause the Next button to drop down a row.
strtr() would indeed be 'prettier'. Do you have any preferences, Evert?
Umh there's no need to free `temp_body` here, isn't it?
Alternatively, we should see that the math module is available for JS backend as well.
s/name/value
Just thinking out loud here, but there's no reason why we'd want/need to explicitly version the experimental stuff, is there?

This could be, e.g., under v1/experimental/catalog, which would allow us to both warn people about it's stability but also maintain previous versions of its API?  I'm not sure that's really worth the effort, but wanted to make sure we'd considered it.
..sorry, and the condition is because we need to wait for tests, since we have tests for completions coming from the classpath (so we need to wait for the indexer in those cases).
Typo: "noramlTerminationOf"
selector should be called `row_spec`. I try to use this name as a reference to a specification for a given row.
is the ``[]`` a defined standard way to handle "typed" arrays? never seen this ..
Why dot here? And I'd suggest `Комментарий` or `Сообщение` instead as they're more formal words.
I think it toString()s but I prefer to be explicit.
There's two scenarios:

1. On clicking a link like `[test](test)`, in which case the hook needs to trigger a refresh to get around Awesomium's generic error, so the hook can't return null early
2. The markdown has an image (or stylesheet request etc) like `![test](test)` in which case the hook should just return null (or the resource if it exists - to be added) and not refresh.

In either scenario, the hook gets the same URL - `local://base_request.html/test` - so we have a problem.
Again, per the style guide: `and` -> `&&`
Yes, and that's why I'm asking why is it declared as protected:

    $ php -a
    Interactive shell
    
    php > class test { protected function __construct() { } }
    php > $test = new test();
    PHP Fatal error:  Call to protected test::__construct() from invalid context in php shell code on line 1
    
    Fatal error: Call to protected test::__construct() from invalid context in php shell code on line 1

I see that what you want to achieve by doing this is to prevent creation of a second singleton, but if you'd never call `new CodeIgniter()` from outside of the CodeIgniter class itself - why should there be a constructor at all?
Picky, but can you put a space in here?
@lilumi да, абсолютно верно. И смысл тогда вообще в этой переменной? :)
Если например нужно будет поменять 20 элементов, то в этом массиве поменяется только 19
Done.  I'll also fix the Mac script that had a comment erroneously referencing the other name (which is I think what threw me off).
This method is already [speced](https://github.com/worldofchris/cucumber-js/blob/0ee152a8ffa15fe5ff3512a2ec33536976064ab0/spec/cucumber/ast/feature_spec.js#L47) :) The original example description is wrong though, it is about *background* while we're describing *feature*.
It doesn't look like this method was changed (only relocated). Assuming there were no changes, can you move it back to keep the diff smaller?