labofsahil/github-event-dataset-2012 huggingface dataset:
Hi! just wanted to let you know that till this commit everything was OK, but after I merged this one and the rest few, my SystemUI FCs.. didn't have time to investigate yet troughly where it brakes.

aslo I had my own hdpi resized icons before you posted, but they were working OK before

thanks for all your great work!!
Better yet, how about:

    <p>© jvc26 {{ 'now' | date: "%Y" }}</p>
This should be here a long time ago... The current change only highlighted its need.
btw... the pull request #922 was to fix a slightly different problem (if I understand yours correctly), the problem reported by @orip was `command not found: rbenv_prompt_info`, while yours seems rvm-related

that said, it would be good to fix this one too, so let me know regarding the above-asked questions...

cheers
Далее в этой главе ... Так не пишут. Просто удали.
Ok, 0 mcycles per second in sound_init  is not good, neither 16 mcycles per
samples for psg/fm (is config.hq disabled btw ?).

Either you are passing a wrong framerate value to audio_init or data
somehow got corrupted/overwritten in memory in between. Try passing 0 as
framerate (this will force use of original genesis clock value instead,
which libsnes seemed to be using anyway)

Le 15 fvr. 2012 23:12, "twinaphex" <
reply@reply.github.com>
a crit :
http://cdn.anonfiles.com/1329343954245.txt

Here is a logfile taken with LOGSOUND defined and the 'error' function
implemented.


---
Reply to this email directly or view it on GitHub:
https://github.com/twinaphex/genesis-next/commit/bce300cfdc1d18154544905d2f8fd934de1a55f4#commitcomment-971576
FYI I'll likely rename that column names
I have gone ahead and checked in that change.
vmap extractor is same or different for this purpose?  also i still dont know y we need to re extract since the re-extraced ones will b the same i m using before
Oh, could you build against the latest Neo4j SNAPSHOT, maybe re-downloading it? This is a change in neo4j/community master. Let me know if that works.
Why are you catching KeyError in a new except rather than tacking it into the existing error handling code's exception list?
Looks good. Waiting on another shipit to merge.
and then mono became moon ...
not performant, lazy, only happens once
No need. Integrating it now. Will push in a few minutes.
It is easy for me, but can be not so easy for end-user.

Please look at next commit to tax_statuses model.

It is now impossible to remove records with childs.
As far as names go, beginLevel and withTransactionLevel are great.
Any neat changes?
I did setup a namespace on purpose, not by accident.
So...

  { 1, 806400, ACPU_PLL_2, 2, 0, 403200, 1, 7, 403200 },

Should be a nice extreme overclock & triple your gpu & axi bus speed.

  { 1, 806400, ACPU_PLL_2, 2, 0, 268800, 2, 7, 268800 },

Would be more conservative, but still more than double it.

I think they all have to divide by 19200
okok :) vettem :D

2012. janur 26. 23:47 Balazs Varga rta, <
reply@reply.github.com
>:

> azrt, mert nekem meg mshogy nevezi a glassfishemet a netbeans (vagy a
> franc tudja), az a lnyeg, hogy emiatt mindig mdostja a pom fjlt meg
>  pampog, hogy nem tallja meg a szervert.
>
> ha tbben dolgoztok egy projekten, akkor nem illik beletenni
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Kresshy/kurzuscsere-wicket/commit/9341ae183d24e7277f3cc828ddaaf5b86b9750cc#commitcomment-906197
>



-- 
Szabolcs Varadi
SCH 1109

www.crashdesign.deviantart.com
Le nom du projet en prefix c'est bien pour ne pas avoir de collision sur des trucs un peu générique comme sequence_hpp
Hmmm - I am not keen on empty strings for these attributes

either use explicit sample values, or maybe placeholders with descriptive property names...

cron="${some.cron.expression}"
Suggest removing this debugging statement.
Ah, you're on bcm4329 hardware, I didn't realize that.

Ok, I just branched in my local U8160 kernel git to try a quick build of this.
I can have a look, but testing without hardware will be difficult. 

The new protocol should not be needed at all, the old code should work with an .idc file. It may need slight modification as shown at https://github.com/CyanogenMod/htc-kernel-msm7x30/commit/3ff30f0ba93e5126384f980ae0758bc93cb89e84

If you do want to use the new protocol read the doco at http://www.kernel.org/doc/Documentation/input/multi-touch-protocol.txt . Type A is what was used previous, type B is what is now used on blade. Use getevent when testing to make sure the correct events are being used.
This problem has been fixed permanently: https://github.com/audiocommander/processing-js/commit/854120463e53476b7f770d6bf0ecc756f435f07b
Yes, or 

```
getEditor().putLong(…).commit();
```

— right now you're creating two separate `Editor`s, and only committing one!
In the upload case, verify that the record has been received by your test HTTP server, and that its GUID wasn't `"default"`!

In the download case, return some real data from your test HTTP server.
どもです :smile:
OK. I will do it.
ça fait quoi ulr() ?
Is this Gingerbread compatible ?
N3X15, I hope you will take the rest of my directionality fixes into consideration - whenever they are not in contradiction with fixes already made by you or leagris. Yesterday I took your newest plugin versions into test, and while some things work now, there is still a lot of functionality which is broken: "launch player" launches into wrong direction, chest spawning isn't working to all directions, announcement signs are not working properly etc.

All of the fixes I've made ARE needed for the plugins to work properly in terms of directionality!
no es lo que propongo, es distinto redirigir que apuntar una url directo a la vista, pero es una cosa de forma solamente.
I don't think the method getPrice was ever implemented for playbook if so remove playbook support tag.
sanity checks on variables
I want to know how "classs" works?
If you don't use legacy audio, nothing. Devices using it do not need the
old settings, so having them was just extra code. It is just cleanup.
On Jan 21, 2012 5:21 PM, "LorD ClockaN" <
reply@reply.github.com>
wrote:

> what do we get by reverting this?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/TwistedUmbrella/android_hardware_libhardware_legacy/commit/5502205aea6ba0849d7d7b426ade30ed1993c073#commitcomment-889043
>
Of course, here is an example:
https://github.com/fog/fog/blob/master/lib/fog/aws/requests/compute/describe_instances.rb#L58
This used to take a different type of parameter, so now it checks to see the type and converts but warns. Let me know if that isn't enough to work from, but I think other things that are like that use a similar pattern.
What is this parameter for? What is the unit?

This isn't really clear from the bug description.
I think that 2nd paragraph belongs to your other pull request. Go to sleep.
I'd move the places where you can quit early to the top of the function. That way you're not doing unnecessary work before you're going to exit out of the function early anyways.
I remember another patch has done similar thing, why do it again?
divider_theme is a better name
Could you please elaborate a bit? You mean that the idea of analysing the logs is not enough or that what the current tests are testing is not enough?
Fixed in 5daa03
Do we want to enforce these restrictions during Sparsity construction?  Something like:

assert all(m.dataset == self._rmaps.dataset for m in self._rmaps)
assert all(m.dataset == self._cmaps.dataset for m in self._cmaps)
for pair in lmaps:
   assert pair[0].iterset == pair[1].iterset

?
Strange, I wonder how it worked for me before.
why not use MigrationSystem?
s/akka.remote.RandomRoutedRemoteActor/your.multi.NodeTest
private, or define explicit return type
yes, with the move of the unwrap that's great, I have changed
magic value: 5 seconds
same as managedRemoteSettings.ShutdownTimeout?
Shouldn't this also disconnect to avoid Reset by Pierre?
Fair enough, I'll add the extra comment as a normal comment below
No need for the braces :-)
Why do we need AMQPActor at all?
It could send itself the Connect message in its constructor or in preStart
I'm skipping the rest of the Dummy* as I assume this code will be dropped later in the process.
good, motivates the usage of ReentrantLock over plain synchronized also
( + space is ok with pep8 ?
I don't have any experience with using gtables, so I'll leave this up to you guys.
It will use only one of the b0s.  It's a trick to make the data value for b0 to sit on the origin (center) of the q-space grid. I will revisit again this when we will start working together with Eric on the DSI deconvolution method. However, if there are more than one b0s with values higher than 0 (but still low) it can be quite tricky. I 'll put a note on that.
Think we should have separate subscription search and not modify this at all.  It will cause the subscription last 50 list to be displayed if a user decides to do the same search as in their subscription (which is a likely search they will want to do) and currently this will mean that any sort_by they do will be ignored.
You might want to explain that it's used so the broker will authenticate the Pulp server. It may just be me, but feels a bit confusing configuring a "client" certificate on the server, even though it's acting as a client in this context. A little extra info might alleviate that.
Making each step a section with the same weight as Overview looks awkward when the docs are generated, specifically with respect to the TOC. Maybe try having Overview and Configuration at the same weight and then each step at a lower weight (underlined with ^) and see how that looks.
Well, I think we should have a standardized options hash.  You are right that it shouldn't be just whatever params has, I think it should be {:email=> , :password=> } since we are using email.

The point is we should define a hash based API for this.  Also, I made this one call to find the account and authenticate.
workaround:

    #define Format(fmt, ...) _Format( fmt, false, ...)
    static std::string _Format(const std::string &fmt, bool dummy, ...);
Maybe clearer to have if (m_renderMethod = RENDER_DXVA) { new stuff} else { old stuff }
Or change the format selection to include the dxva case.

Would be nice to have the Log() just before log the actual format in the dxva case.
it would be best to format this up from the enum/define for c12.

It could probably be simplified using CDatabase::GetSingleValue() as well.
может лучше написать `block b-page, doctype: this.ctx.doctype || '<!DOCTYPE html>'` (или даже разрешить пустую строку как значение), чтобы из BEMJSON можно было управлять
"birt"
I changed this name so it is more distinct from hard_template() since they respond to different cards.  This is for recognizing a :content rule card an the other is to get the virtual card for a templated card.
I figured there are probably cases where the original message is unhelpful (e.g. if the value being checked wasn't directly under client control). I think the most straightforward way to get the best of both worlds is to do `%s` substitution in the message, a la `console.log()`.
is there a need to initialise the counter variable outside of the loop?
Maybe.


    Can do change, but if to do will go repeat message. Are you expect 
comportment?


Regards
Em 03-07-2012 14:24, Dickson S. Guedes escreveu:
>>   uninstall()
>>   {
>> -	echo "NOT IMPLEMENTED YET!"
>> +	VERSIONS=$($LS -1 $pgvm_home/environments/ 2>  /dev/null)
>> +	TARGET=$1
>> +
>> +	for i in $VERSIONS
>> +	do
>> +		
>> +		if [ $TARGET  == $i  ]
>> +		then
>> +			echo -e "Removing Postgres installed by PGVM!\n"
>
> We could tell which postgres version `pgvm` are uninstalling, may be something like:
>
> "removing postgres version X.Y.Z installed by pgvm!"
>



-- 
Fernando Ike
http://midstorm.org/~fike/weblog
Heh, yeah, testing jasmine-promise using itself is not ideal :P
Why is this print statement here?   This should be removed.
already add ini  date.timezone=UTC.
It seems this is going to leak in development. Every request we will add a new model class and they will never be garbage collected. :(
I think you can amend the other entry with one describing your addition, and add you both as authors. Also it'd be good to add a simple example of one of the helpers here.
Good idea, I can change the Rails::InfoController as well.
This can be defined directly in the module, doesn't need to be in an `included` block
Done #5959
Is this still valid after this pull request?
Since this is coffee lets write using string interpolation

```coffee
alert "fib of #{count} is: #{data}."
```
I can but looks like there are a lot of tests that test this behavior implicity. E.g https://github.com/nashby/rails/blob/f5760d571445156c576925c4889fbd50ec388c6f/actionpack/test/template/form_options_helper_test.rb#L119 
wdyt?
Is not better call this exception `ForbiddenAttrbibutesError` or something like this?
Yes, we have to check if token is false which is different than nil.
"Only" sounds odd when nearly a dozen extensions are supported !
The return value of `flatten` isn't used here.  Is it necessary?
When I added univeral skip_apps=/apps= support in rebar_core I had split it process_dir
and the function names were non-descriptive. The renaming fixes that.
``` 
 @deprecated("use `(xs, ys).zipped.map(f)` instead of `List.map2(xs, ys)(f)`", "2.8.0")
  def map2[A,B,C](xs: List[A], ys: List[B])(f: (A, B) => C): List[C] = {
```

What should I use?
Typo `elemnents ` -> `elements `
Can you also re-add `scala.iml`, the module for the root folder?

Otherwise LGTM (not that I've tried compiling within IntelliJ).
True, the renaming is intentional. To my liking `isHidden` sounds too generic. WDYT?
If you define it in terms of the log pdf, then it would be simpler to define _logpdf and take the exp in _pdf
And here.

Could this check possibly be moved into a separate method?
Is the use of `(-self).__add__(om)` instead of just `-self + om` intensional?
I think the only commutator we have is the one in the quantum module, but if I remember correctly, it can do this.
yeah, I agree with you and I'm implementing it relatively
It is done. Thanks for checking the changes.
A good reading about the topic: http://blog.ircmaxell.com/2011/08/rainbow-table-is-dead.html

Probably can be added as a "read more".
I don't think we should deprecate `registerMetaTag`. I also don't like the idea of introducing a new method here because the original method IS adding unique meta tags. 

I read through the old discussion. keyboard.idol showed some examples of meta tags that vary by content option. So this PR still doesn't help.

I think we may consider adding an additional parameter named `$key` to `registerMetaTag`. By default it is null, meaning using `serialize($options)` as the key to the meta tag array. If not null, the parameter value will be used as the key instead.
Criteria got by reference. Possible side effect of modifying scopes.
Grr. These are in my ignore file. WHY DID THEY GET PUSHED???
How about "Enable" and "Quit" instead of "Yes" and "No"?
The offset is computed as `-(@stack_usage+i+1)`, so both `@stack_usage` and `i` are taken into account.
I think it would be cleaner to pass in the name of the table whose indexes require a rebuild rather than assuming it will just be the DIFFS table - you have this information in the partitioning hook, so this could be passed through.
spelt
since the projection document include a specific exclude option, i wouldn't use the word excluding here.

You could state something like "the results from the query only include ..."
i think you mean snapshot document, unless you also mean to link to isolated operations (which has to do with isolating sequence of operations). Also, my document has to do with snapshot mode, which isn't a true snapshot
I'd probably be fine with having a protected/private method that is called by the two public functions untrimmed_variable() and variable().
As far as I know it is not used yet.
I read the rfc and I'm clarifying what was decided (as opposed to what you think was decided).
Other tools like CLI tools, might very well need to access meta data. It certainly is not unique to the ACP pages. The extensions manager manages extensions, so it should quite certainly know about their metadata?
configuration directory (not config directory)
`classMap` or `classReplacements`.
I would like to see at least one other vote from a developer that this one line change alters the entirety of phpbb to link to all images, javascripts and stylesheets via absolute rather than relative paths.
The destroy method handles "tables" as an array internally, therefore just as well merge these two calls into one.
```php
$cache->destroy('sql', array(GROUPS_TABLE, TEAMPAGE_TABLE));
```
I'll break it down for you:

`[^...]` is a negated character class. It matches characters that aren't in the character class.   
`a-z0-9` means any characters that are letters or numbers.

So… it matches any characters that aren't letters or numbers!
If more than just those three existing elements that you are using are being returned by $avatar->process_form(), please define a new array variable instead of overwriting $result.
Do not modify global $phpbb_root_path. Put modified path into a local variable and pass it forward. If this doesn't work, change the rest of the code until it does.
Explain what you are doing with a comment.
Oh comment here I guess. It retrieves a list of all children process ids for the given process id.
Template variables that begin with a $?
This method should probably return an instance of filespec instead of assigning it as a property of the test. It should therefore probably also be called `get_filespec` instead.
the windows porting team will flame you on this declaration.
spațiu între metodele aceleaiși clase
Yeah, I'm playing around a little now to see if I can get rid of it.
Perhaps we could use a callback here instead of reflection based object creation. Just a thought, I'll locally merge this pull and play more before you need to bother making changes.
oh sorry its not file, its actually john posted a json on my ticket itself.
You can look it:  https://raxaemr.atlassian.net/browse/RAXAJSS-154
its in comments
I think that it does not -- this corner case exists only because the code for the next section (if either x or y is a tensor) fails if y.ndim == 1, as it includes a statement which pops the -2 index of range(y.ndim).  So range(1).pop(-2) causes an error. So this corner case is basically what the following case boils down to if you know in advance that ydim = 1.

And looking at it with fresh eyes, I can definitely simplify that following case. For example, sum0.pop(-1) is unnecessary if sum0 is defined as range(xdim-1) instead of range(xdim). 

I believe that the corner case can be handled more elegantly, but the solution was evading me last night so I wrote the special case to deal with it.  This whole section feels a little ugly, but one of mul/outer/dot/tensordot has to be applied depending on the context. I'll try to rework it, or at least add overly-helpful comments.
raise automatically -> automatically raise, and I guess \`\` around AssertionError
This case is never tested, right?
I wish the index enum itself would tell you if it was scannable. Not your code's problem though.
Yup, thanks! deleted
spurious whitespace after { and before }.
how about `registerMarket` and `registerRegion`?  Strike a balance between descriptiveness and brevity.  Brevity has its benefits too.
Fixed in aaac8a2
It's used on line 469.
The original methods didnt return void or? At least the EntityManager has a return value here. This should be replicated.
These three lines (and the ones like them below) can be condensed into:

```objc
expect([transformer transformedValue:booleanYES]).to.equal(kCFBooleanTrue);
```

This also removes the need for the `boolTrue` and `boolFalse` temporaries.
@rwldrn Done :)
I'm usually in favor of 3 args or less before I switch to options array. I mean, it's sort of arbitrary to me. Whatever eats the least space, I suppose.
I think this entire special-case block and corresponding expense of `.index` can be eliminated if the `jQuery( this ).remove()` on [L296](https://github.com/PaulBRamos/jquery/blob/6fb68d22f4b136f0b467cf060ea3286f8cc6fcce/src/manipulation.js#L296) moves after the `.before`/`.append`. Did you try anything like that?
That does not fit to the above description.
@haying was right.  You need to check result.isNull() to return NULL.  I'll add it.
I actually think it's confusing to name the client id "appId", but also recognize the simplification this introduces.

How about this alternative? Store, separately, Meteor.accounts.weibo._config.common and Meteor.accounts.weibo._config.server. In the common object we'll hold appId and appUrl, or clientId and appUrl for different services. You still get the ease of checking for their existence in a unified manner since you can check whether Meteor.accounts[serviceName]._config.{common,server} have already been set.
#elif else

Should be #else I think :)
I guess this means we might want to add HTTP_STREAM_SERVER_* if we end up having to split the two tasks, but worrying about this can just wait imo.
Since we're indexing documents using the Django ORM model instance id, you don't need to do all this work. You can just do:

```
mapping_type.unindex(item_id)
```
Man, I love mock classes.  :)
Maybe you should use the _countof macro here instead of using the number of characters directly.
Be careful.  This rm -rf was just my being paranoid.  If you do that to a real user, they may get upset.  I would just remove this line.
The structure here can be simplified a bit by moving the rescue to the method level and sticking the heredoc inside:

```rb
def check_user_curlrc
  return if File.exist? "#{ENV['HOME']}/.curlrc"

  nostdout { curl('-o', '/dev/null', '--head', 'http://github.com') }
rescue
  <<-EOS.undent
    ...
  EOS
end
```
Hm, but if they're not valid utf-8 why does it work with the utf-8 magic comment?
Okay, I will try it :)
I'm a bit skeptical that a key should control its display format.  Typically in MVC architectures it's reversed.  I'd rather there be a helper for key output that binds the erb to a model rather than the other way around.
Code commenté, code supprimé :-)
The code to issue `submit_multi` PDUs was removed in the same commit, because it was unused and untested.
Maybe either amend the previous bullet or add a new one for describing that you're hosting the Pulp repositories from the Pulp server. Could even mention the ability to serve them over HTTP and/or HTTPS and apply client certificate based authentication for a repository contents.
Good point, will fix (I've needed to pass encoding in python 2.7)
Hrmm… that's a little tricky, because you need to return the deferred from `bodyProducer.startProducing` from your testcase.  Because what kind of bodyProducer is used is completely an implementation detail and the actual body producer used has no way to reach inside of it to inspect the string body that will be sent to request.
The comment itself is a cut-and-paste error, sorry.

Dagger may not have only one method. I can see this as the place where any configurability would come in.  

Dagger.wire()

or

Dagger.with(new GuiceModuleHandler()).wire(module);

etc.

Ignore the specifics of naming or configuration - the point is, it's a nice clean place to make sure any variance from default behaviour is up-front and explicit, and doesn't get in the way of anyone else who does use the defaults. 

Regardless, even if wire() was the only method, I'd still rather have a clear entry point, and this is nice and separated.
Or, we could be clever about it: `if ( $args[0] ends with '.zip' ) it's a file.`
A call to createTestDescription(Class, String) will be handled by the createTestDescription(Class, String, Annotation...) method. See the parseClassAndMethodNoAnnotations() unit test. Is that sufficient for backwards compatibility?
ugh. semicolon misplaced. sloppy today. *pulls self together*
``done`` and ``error`` are unused
Not to generate a ton of busywork, but... I wonder if we should keep the "menu-" prefix that we used to have on all of these.  Since they're DOM node ids, they're supposed to be unique across the whole HTML document.  Some of these (e.g. "view-sidebar") sound generic enough that they could potentially collide.

Another option would be to programmatically tack on the suffix when creating the DOM node, and again later when searching in the DOM by id.  That would keep the code cleaner and prevent people from forgetting to add the suffix on their own menu item ids.
Technically, this is a comparator function, not the actual sort.
jslint - "i" is undefined
These declarations should also be specified with unprefixed properties so this doesn't break when Chrome changes support and also in case anyone want to try to get this working in another browser:

```
    highlight.style.setProperty("transition-property", "opacity, box-shadow, background");
    highlight.style.setProperty("transition-duration", "0.3s, 0.4s, 0.4s");
```
I think that second check could be simplified to just `allUpdates[0].buildNumber > _lastNotifiedBuildNumber` (if the latest update isn't new enough, none of the others will be either).
We should filter out hidden files and folders here. Otherwise, we're showing folders like ".git" in code hints.
Is there a reason we need to copy this into a temp variable?
Try this:
```python
getattr(self, table_name).drop(self.engine))
```

I'm mostly impartial here. More curious than anything else.
Yeah, I should do that. I was actually planning to give connection_proxy some refactoring love this afternoon.
I think this is wrong. This implies that when creating the ACL, the {DAV:}owner actually gets replaced by the 'real owner', thus resulting in a sort of hardcoded. If `<d:property><d:owner /></d:property>` is specified in the ACL method this should be retained.
If you do use a HashSet, note that is doesn't guarantee the order of its elements. So when you create `typeObjects` below, you may need to sort `types` before enumerating it.

```csharp
BindableCollection<AngleType> typeObjects = new BindableCollection<AngleType>();
foreach (string s in types.OrderBy(a => a))
{
    typeObjects.Add(new AngleType(s, this));
}
This change doesn't make sense to me - if there is no entry in entries[] for delta_base, then KeyError will be raised and base_offset won't be set.
It should be POST.
I thought you will have problems here but it should really be simple. I thought you will manage yourself.

```
{% for lang in LANGUAGES %}
    <form action=" ... " method="post">
        {% csrf_token %}
        <input type="hidden" name="next" value=" ..." />
        <input type="hidden" name="language" value="{{ lang.0 }}" />
        <button type="submit" class="text_button">{{ lang.1 }}</button>
    </form>
{% endloop %}
```

And then style the button to be a link. ;-)

Code above is untested and check XHTML validity.
What about return value in case of rescue?

```ruby
rescue SyntaxErrot => e
  puts "YAML Exception reading #{name}: #{e.message}"
  self.data
rescue => e
  puts "YAML Exception reading #{name}: #{e.message}"
  self.data
end
```
Should set it to "visible" and not an empty string.
Change the argument order to `butter, _pattern`
Add some kind of "Popcorn Maker" string to this warning, so they know it's our app touching LocalStorage and failing vs. random JS.
This is wrong.  We discussed in the bug that you might have time==="00:04.132412341234" (i.e., a timecode that needs to get converted to a better printed style--"4.13") or you might have time==="3661".  In the latter case, there is no ":", so we treat everything as a number.
I believe it's necessary since the page does use `section` tags, etc, but I didn't actually give it thought here. It just came over from Thimble so I left it.
Do we expect divers implementations? Like?
这个函数拿脚本来测试下，确保所有情况下都不会出错。

我感觉最后链表最终不断插入删除的结果是变成都是每个都是长度为1的链表。
dynamically
Stejně jako předchozí, pokud se ti nezdá to přidané odřádkování, tak ho stačí odmazat.
We could just delete this function. But I'm worried about the ensuing chaos if people use non-publicly-accessible urls. Note that the function just returns the string unadulterated if (1) it can't find `github.com` or (2) it doesn't start with `git@`. I thought that was pretty safe.

We could also put in checks for other hosting sites, if that's preferable to the current situation or to deleting this function altogether.
source should not be changed
Ah yes, I totally forgot to add in tipsify.
May want to include a note saying that these `.json` files must exist and contain valid json data structures if you want to compile the namespace. I just created them by hand locally and put `{}` in both, just to get uberjarring to work.
Why do you reset?
Same here, should this be localized?
Shouldn't this field really be the origin of the app store the app was installed from? (e.g. market.gaiamobile.org:80 or https://marketplace.mozilla.org:80)
Du oder Sie?
Won't this end up being called as lists:filter(true, ...) and throw a function clause error? Shouldn't you return a fun that always returns true instead?
Search query, not secondary index. And it returns more than just keys, it will return "documents" along with a few stats.
This code will not do what you want it to. Line 4 won't just automatically return; you need to put this all in an if else block. Ruby only automatically returns the final evaluated expression in a function.
It IS in the MinGW headers (winbase.h) but just enabled for #if (_WIN32_WINNT >= 0x0601), which is Windows 7. As this is not correct (the used function and it's parameters are there since WinXP SP3).

I think it's better to re-define that flag instead of just using 0x00000001.
Fixed in [74b77a4d73a6de6c111da5ca783df86c7da62113]
I feel that there is a deeper issue here that revolves around the order of
inclusions. From a historical stand point, why was this written using a $ds
variable as opposed to  a constant?

The issue to which I am referring to is the one that if I exclude the if
(!defined('DS')) { define('DS', DIRECTORY_SEPARATOR); } in cake.php
defining DS in ShellDispatcher.php redefines DS. Ideally, DS should only
need to be defined once and declaring $ds in ShellDispatcher.php should not
be needed as it has already been defined elsewhere.

Perhaps this should be submitted as two different patches?

I think the cake bake project fix should be implemented sooner than later.
The semantic definition and placement of define('DS', DIRECTORY_SEPARATOR);
could be made at a later date.

Thoughts on this?

On Mon, Aug 6, 2012 at 1:33 PM, Mark Story <
reply@reply.github.com
> wrote:

> > @@ -17,25 +17,27 @@
> >   * @since         CakePHP(tm) v 1.2.0.5012
> >   * @license       MIT License (
> http://www.opensource.org/licenses/mit-license.php)
> >   */
> > -$ds = DIRECTORY_SEPARATOR;
> > -$dispatcher = 'Cake' . $ds . 'Console' . $ds . 'ShellDispatcher.php';
> > +define('DS', DIRECTORY_SEPARATOR);
>
> I understand but disagree on your semantic correctness point. But this
> change makes this version of cake.php inconsistent with the other 2 which
> also use local variables.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cakephp/cakephp/pull/755/files#r1314331
>



-- 
Justin A. Barnes
Leading Edge Solutions, LLC
Office:  +1.501.436.4336
Cell:  +1.501.259.6290
Fax:  +1.888.707.8212
Calendar must not use any additional dependencies, such as ESDateResolution.
Please extract a separate class and use it for NSCalendar category implementations.
Use the condensed version of the above 3 lines that I mentioned earlier.
Anyone have ideas on how we can shrink the size of this controller down? I'd like to move the logic into the User model, but the problem is there are a whole bunch of controller redirects embedded in the logic. One idea I had would be to add a state-machine to the user so that I could run the command User.invite_and_notify! and then check the user state (i.e. User.invited?) to determine how the controller should respond. Don't know if adding a state-machine to the user would be overkill though.
Why is everything being proxied out to a callable? I rather just have as something a user can subclass. It's about the same amount of effort as defining a function.
I've never used Redis, but \r\n seems OS specific.
Shouldn't we use StringHelper.END_OF_LINE (ie System.getProperty("line.separator")) here?
No, it's definitely not a good solution. Was just a quick hack to get something working at one point.
inaccessible

Also, we should possibly be more specific about what errors are caught here. E.g. this will also catch a `UnicodeDecodeError` from openpy, and transform it into this ValueError. In fact, I'd be inclined to let the HTTP errors propagate, unless there's a good reason not to.
Cool. :thumbsup:
Ohh I see, this needs to be fixed.
cheers dudi
As of 09a03995e00605c9b23f799673b7ccb304506e5b, symlinks are (I think) done. Is there an easy way to identify a submodule node so I can put a better TODO comment?
please use `@method`
Didn't you tell me it was useless if I raise the exception after logging?
```|length``` нє?
I think it should read "for locale ..." instead of "for the locale ..." (same for the other two)
Is is valid for collections ?
line endings: http://help.github.com/line-endings/
You should use `count()` not alias `sizeof()`
you should use 4 spaces per level for the indentation, not tabs
Yes of course. We have to find a clever way to fix that.
I've only tested it by generating a bootstrap. And with adaptive set to false as is the case when generating bootstrap, the already loaded classes are added into the final file.
Why it wouldn't work?
why an indent?
Correct. `initFileToPhoto` is only used for the initial photos in `app/utils/Bootstrap.java`. Otherwise, we encounter the error I described in a previous comment.
It's not clear what this is doing. Can you add a comment of what data[0] might look like?
Same as before, I/O  => try/catch + failure
Ah, maybe this fixes the last comment...
```
![AWS Marketplace Security Group](/images/aws-marketplace-security-group.png)
```
I agree, we can change how the `around_scenario` method works to handle this and only have at most 1 callback in the corresponding array.

About the need for `around_scenrio`, yes this is crucial, for example I'm using Sequel and to ensure each scenario runs in a transaction (using the right connection) it needs a block, without `around_scenario` hooks it would then not be possible (at least cleanly).
this should just be able to be a boolean
Because we are only returning in this case, you can drop all the "current_node" logic and embed this block in line 47
Also, you will need to catch `KeyError` in the links view for when a node does not have any links defined, or alternatively just do `.get('links')`.

For example, startint from line 44:
```python
        for node in host.get('virtualization', {}).get('guests', []):
            if fqdn == node['fqdn']:
                for link in current_node['kitchen']['data'].get('links', []):
                    if link.get('title') == 'monitoring':
                        return redirect(link['url'])
                return None
```
I don't think we should remove this part.

It still would be very useful in the event of using request arguments to decide the URL.

Do you think you can put it back and re-send this pull request?
We don't actually have a guava dependency in the AS7 proper yet (guava is only present in the pom because it is a dependency of weld). 

I don't know if we really want to add a dependency to this module just to get this one function.
Eduardo, we chatted about this the other day and I said your idea about ManagedReference sounded reasonable, but I think Stuart is correct here.
I remember when working on status bar that you should be able to probe `data.connected` for the information. But I will review this patch as-is.
nit: anonynous
There is a fun mix of '' and "", which one do you want to use?
`function deleteCB() {`...
var existsPhoto = 'photo' in contact && contact.photo; and then you can avoid checking contact.photo != '' in the if
Hi, 

This error should lead to the case of 0 data. So we provide some feedback.
yes, for the sake of consistency defer should be used. 

WRT to the 'fb_' prefix I would like to keep it as it denotes clearly that these files are part of the FB regardless of the folder they are.
The `label` should be in uppercase, it is designed in that way
On 19/07/2012 17:56, James Lal wrote:
>> @@ -3,25 +3,11 @@
>>     <head>
>>       <meta charset="utf-8">
>>       <meta http-equiv="pragma" content="no-cache">
>> +    <!-- Shared code -->
>> +    <script defer src="shared/js/l10n.js"></script>
>> +    <script defer src="shared/js/GestureDetector.js"></script>
> I don't see this as part of the commit? was Gesture Detector added in a different one?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla-b2g/gaia/pull/2624/files#r1198136
Yep. I have forgot it in the first pull :)
(Non-blocking) on purpose that `openFrame = null` but `closeFrame = ''`?
What about, instead of returning on the 3 previous cases, something like:

```javascript
if (!ActivityHandler.currentlyHandling) {
  reloadContactDetails();
  navigation.go('view-contact-details', 'right-left');
  return; 
}

//Check numPhoneNumbers here
```

What do you think?
This function will never fire the callback if Gecko doesn't comes with `addNextPaintListener` or `removeNextPaintListener` method.

In order to avoid unsynced Gecko-Gaia version and to prevent 
https://bugzilla.mozilla.org/show_bug.cgi?id=810431
from stopping the app from opening, please add some checks here.
Date can wrap (31 -> 1), is your `diffDays` work with that?
*lighter* for a *strong* element?
Is there 2 things to do or only one?
Dear @vingtetun, I think that piece of CSS code is from building blocks.
If it is OK, could we refine it in the follow ups of building blocks but not in this pull request.
Thanks.
I remove it because the status would be updated on `statuschange`. I try to collect all `gStatus.textContent` (or `gWifiInfoBlock`) updates together.
I've seen this error too (thanks !) but that's not the cause. The problem was that `addResendHandler` was trying to get the messageDOM from the DOM whereas in appendMessage it was not added yet.

I've pushed a commit to fix this (https://github.com/julienw/gaia/commit/26cf5c7f83b1bc69e085a681788bf4f2a79eb565) (and this time I didn' t squash so that you can see the specific commit, I'll squash before merging)

BTW this was happening when we were trying to send a message without a SIM too !
Actually this doesn't work for bidirectional requests. fetchHistory can call this if going back beyond the 10 page cache. It is also possible for a user to jump to a position in the history directly.
I think we could do this instead with a CascadeJob companion object so you don't need to make CascadeJob mutable.

So:

object CascadeJob {
  apply( jobs : (String, Args)*)
}

Then: CascadeJob(("job1", Args("--test1")), ("job2", Args("--test2")))

What do you think?
What is an instance?
Arbitrarily chosen.
Try to do something like `thread: (data) ->` where data is an object containing semantic key/value pairs.
Also, don't need %s in the string - passing the exception as the second parameter to logging.exception does the right thing.
Maybe this is just me speaking as a non-astronomer, but my general preference is to see these things spelled out and less vague looking.  I mean, "circ" is obvious enough, and so in context "ell" also makes sense. But "aperture_ellipitical" still wouldn't be that long, and if I saw it in code it would be so much more clear, I think...
No. I just need the break to jump out the loop to get the free target id
There are already many tests that access private methods. I think for unit testing, that is fine. If one was writing integration tests, that would be a separate issue.
I wonder if the list of log files this is done to should be separate from `self.logfiles`. I can imagine that a user would want to add additional log files, and that they shouldn't have their location moved like this (or be removed automatically).

Also, you should probably use `self.build.path_module.join` here, to use the right path separator for the slave (not this is likely anything other than unix-like).
After first push detection, the `/home/git/repositories` will be like this.

![img](http://f.cl.ly/items/0i2C3q1Z2R1q3W1q0e0H/Screen%20Shot%202012-09-09%20at%2010.20.00%20AM.png)
(Consider including comments.)
whats the purpose of this sleep?
typo: s/loggin/logging/
Did I not commit the changes to that? Grumble. Fixed.
default zero and make it float
Can you add a test against this parameter value?
We don't want to change real globals, we want to copy all globals and override console.
You're wrong as it's loaded by test-harness for example and loader helper for tests.
this is an orthogonal change to copy updates, made here during testing of l10n of copy updates.  we should ignore `/locale` which is typically svn co'd into a git checkout.
I see. Another solution might be to simply split this into two management commands (inheriting from a common base as needed in order to take common options). If two different options to the same command are doing such different things that they require separate lockfiles, it seems to me like they'd really make more sense as separate commands than as options to one command.
the better way to raise an error from a Django management command is `raise CommandError("Enter a valid project name")` - don't call `quit()` yourself
If we can't pick any from the categories, we just choose games? Why would this ever happen?
OK. this method is exactly the same as: https://github.com/mozilla/qmo-tests/blob/master/page.py#L20 so it's duplicated code.

We have that one in page.py so we can access it anywhere.
Since these behave in very similar ways, can we extract the functionality to somewhere common (eg: Puppet::Resource), then unify the two parts of the code to run through that?

It seems like the behaviour is "create a resource from this hash", as an alternate initializer for the resource instance itself.
[Kelsey Hightower:]
| > @@ -14,8 +14,7 @@ PATH=/usr/bin:/sbin:/bin:/usr/sbin
| >  export PATH
| >  
| >  [ -f /etc/sysconfig/puppet ] && . /etc/sysconfig/puppet
| > -lockfile=${LOCKFILE-/var/lock/subsys/puppet}
| > -pidfile=${PIDFILE-/var/run/puppet/agent.pid}
| > +pidfile=${PIDFILE-/var/run/puppet.pid}
| >  puppetd=${PUPPETD-/usr/sbin/puppetd}
| 
| Currently the master stores it's pid under `/var/run/puppet/master.pid` should we change this to:
| 
|     pidfile=${PIDFILE-/var/run/puppet/puppet.pid}

probably not, since this has been a public interface for puppet,
changing that has a possibility of breaking customer scripts.
 
| ---
| Reply to this email directly or view it on GitHub:
| https://github.com/puppetlabs/puppet/pull/929/files#r1205586
---~*~---

                                    rahul
--
http://people.oregonstate.edu/~gopinatr/
Fixed in https://github.com/puppetlabs/puppet/pull/624
This should invoke the just-created method, rather than reimplementing it.
k, will add that and update.
as we discussed, this could be more expansive...
we should set this up as a make target and remove this file
If mac is (nil) this line throws an error into y2log:

    Argument (param) to size(...) is nil
As far as I know it is only local thing. However, this function wasn't subject of the patch. I've only reformatted it, bcs I had to read it for some reason.
It cannot be fixed in a best way, which would mean change in the all files. We're messing with past and new edits.

But I'll try with yet one more commit
When using the `useUploadName` option, should we be doing any sanitizing of the $_FILES['name'] value which will be used as the target filename?
s/Coul/Could/
This method hereby becomes 100+ lines long. Can't we move this to its own method?
php-doc comment says: "Return nothing" and then returns array
Please remove this magic.
Please replace the email addresses so that they end with @example.com
Nothing is done until I save in the line below, just preparing the instance to authorize.
SetUpdateUpdatesIs... is that name right?  Should it be PublishPackageUpdatesIs...?
use `git add -p` to avoid these ;-)
this looks like an integration test now. are you sure the correct library/controller will be dispatched?
Reverse the comparison and add the 13 as a constant.

`if (13 !== event.which) { return; }` -> 

```
var ENTER_KEY = 13;

...

if ( event.which !== ENTER_KEY ) {
    return; 
}
```
Something like:

```js
var store = localStorage.getItem('todos-knockout');
var todos = ( store && JSON.parse( store ) ) || [];
```
These are probably a mistake.
_attachments needs to be fixed as well
and sometimes its gone, then update actually wont update

this wasn't tested as far as i understood
Given that nom-fresh is in the nominal namespace do we need this? I suspect people might write something like this after requiring the nominal namespace as nom:

```clojure
(run* [q]
   (fresh [x]
      (nom/fresh [y]
         ...)))
```
should be no space after if nor after typecast
What is this part ?
yes .. it should lead to no path exception .. unless it gets computed in persistNew() via a repository
A usage example here would be nice (code explains more than a thousand words ;-)).

Code examples in PHPDoc come between `<code>` and `</code>`.
We can probably kill this line? Lets add a test case and see if we can (after the merge)
Let me fix this
`apply` is deprecated, use `f(*args, **kwargs)` instead of `apply(f, args, kwargs)` (this remarks applies :-) below as well)
You mean this regex should be defined in vsc.base.VSC? Maybe we should just move all VO stuff out of here? But that complicates matters I think.
Idem :-)
Holy fuck. Indentation, indentation! I do not recall fucking this up so bad.
Should have two empty lines in front of the def line.
Whitespace gone wrong here.
Always index foreign keys
As above, do you have a use case to justifies the additional feature?
I tried the package-plugin and install-plugin it and I've recognized. the plugin name was right 'improx'. it's no problem.
The tricky place is `.get()` in pread, I believe. Best might be to do a check there, is this a normal typed array or a lazy one, and have different code paths.

Thanks for benchmarking this. I tested on Firefox and the slowdown is significant there too. All engines seem to optimize best when they know typed arrays have not been fiddled with.
Ah, this looks like one place where we're using src
sorry about that - it just doesn't make sense to recreate the display name. Also, make sure that the indents make sense and that you stay under 80 characters
Unless I am missing something all the css files in mozillians use 2 space indentation.
You will also have to upate the JSON config files to make use of this parameter.
Nvm it was an event, +1 to removing this.
This change is unrelated to the ticket, can you do this in its own ticket?
We will probably include the license in each file and this will get cleaned up then....
Indeed it does, now that I cleared my cache. Let me poke at it some more...
set_phrases がネットワークにアクセスして例外を発するような名前に見えない．
fetch とか retrieve などの語彙が良さそう
修正分をpush -f (ignore schema.rbを消した）のでコメントが一部消えてしまいました・・・
本来ならactive_decoraterに書く旨、確認しました。
Here, the model is the CellData class

In fact CellDetailsRss is part of the view
I am getting ```Routing Error undefined method `t' for Alchemy::RailsTranslations:Module``` in Conductor and Winged Monkey.

I created pull request for your engine branch that fixes this file: https://github.com/ehelms/alchemy/pull/1
Correct computation of the scrolling amount (per your code, instead of the one adapted from Qt-labs flickcharm
I should have set them both for good measure, but if we're overriding itemType, then defaultUnknownType should not matter. Fixed it though.
This would be a bit cleaner with the `ZU.xpath(..)` call that you used in other places.