labofsahil/github-event-dataset-2012 huggingface dataset:
I don't think that the separate function at https://github.com/Islandora/islandora/pull/203/files#L10R40 is necessary.  Drupal and Islandora developers should be comfortable using the hook_load functions to load items.  It is a well established pattern; we should conform to it rather than violating expectations in an interface.  The fact that the hook is being implemented but the function can be called directly should be documented.
Please don't leave comments in.
I guess I'm a little confused. If the connector wanted all the information, couldn't it just read the Document?
I can look into it. I'm not sure if rest-client provides an equivalent "upload-file" command. I don't think it is the same as POST or PUT.
我说了可以把$("input.select")缓存起来，只做一次
另外这绝对都是毫秒内的时间，有必要这么计较？
количество параметров
как удалять файлы с бранча, я сам не пойму откуда он взялся
ok, forward compatibility :-) it won't break, so lets leave it in.
OK I will add it
Type is off.
To make this more in line with the other APIs, this update can probably be moved into an internal _updateSection function
If we do cache this, it'd better to do it up front on `init` and make this a synchronous function, since it's never invalidated.
This might sound a bit silly, but I've found in a few cases when I'm adding a new parameter that comments don't get aligned at tab-stops (i.e., a multiple of 4 spaces). I tend to move them to tab-stops thinking they should be there, but here they've been adjusted out of tab-stops. Should they be aligned at tab-stops? Does that matter?
This doesn't seem necessary, as we've already checked this on line 309.
Javaの部分は、ほぼそのまま`setup.sh`から持ってきていたためでした。
パス区切り文字もスラッシュになっているため、その部分も修正します。
会不会 `data-group=3-1`,  `data-group=3-2`,  `data-group=3-3` 比较好？
@Crell we have a problem here, as we do not know the name. but do we have any value in having that name? cf my comment on https://github.com/symfony/symfony/pull/6100 - we probably want to pass $name as argument to getAttributes
Typo. "Ne considérez pas". No "ce".
Лучше использовать DNA_SIZE для указания размера массива.
You may see these $Revision$ placeholders sprinkled around in the codebase, but I think Jasig has come down in favor of not using them going forward.  I think Git allows us to view and audit revision information well enough.
oops sorry didn't see `var i = 0` earlier (searched for `var i`' failed). agree could have kept this declaration and kept this one instead, though some people like var'ing things at one place :) thanks for the explanation!
This loop is pretty confusing because of all the control jumping. Could you flip some of these conditions so that the "normal" (top level) path through the loop continues normally?
We should verify that the subscriptions haven't changed after this line.
Instead of keeping this in a variable, you could store it on `robot.brain`. This would persist across hubot restarts, assuming you are using the redis-brain.coffee.
Apologies, IDE did some automatic whitespace cleanup there.
因为我们是第三方类库，我不建议加入tools.logging做任何日志处理。因为不是所有项目都配置日志的。
Just a reminder to update this list when you add PLV/PPC.
you have indent problems
this is needed for responsive design too.
fileops is now npm module
I prefer a normal list with inline code blocks:

    * ``PRE_SET_DATA``
    * ``POST_SET_DATA``
    * ``PRE_BIND``
    * ...
默认安装
默认编译
"Visually Communicate"
Above, you should use `self.table_name = 'orders'` etc instead of `set_table_name` which is deprecated.
Потому что инициализировать переменные хорошо, и не надо считать, что парсер пишут идеальные неошибающиеся люди.
Ну тут-то круглые скобки нафига? И строка после пустая.
Please describe, that the html-content for the tooltip has to be a sibling of the tooltip trigger element.
I can't, without changing the model.. but then that's what I'll do ;)
I think this could be a little cleaner if you initialized `customErrorHandler` to `handleException` and modified `handleException`. Then you wouldn't have to check... you just always do the same thing.
You can change the above 2 lines to `let(:user) { FactoryGirl.create(:user) }`
Please add and update only ``sylius/blogger-bundle``.
assignments in control structure must be explicit , either with a boolean cast or with a comparison
Maybe, as the same code is present in GoogleMapView as well (this is inherited from carneros version already). If you issue is associated with such a high zoom level (22 is VERY close up, the live map for example has a maximum of 18 IIRC)
Ok, could you remove the commented lines?
this suspend logic should actually be removed as it is already present in the getInvocationContextWithImplicitTransactionForAsyncOps. The tx needs to disassociated(suspended) with the sync (caller's) thread and the associated with the async thread. This happens few lines below, in the callable: "associateImplicitTransactionWithCurrentThread(ctx);"
We should give this method a more suggestive name, such as <code>are_results_found</code>.
also if it's unused just remove it :)
that's a pretty damn specific selector
one of these should be tileoffsetlon
When describing what you're testing, I'd recommend to focus on what the code does. Since the side effects are the important thing here (rather than the return value), I'd go with something like "it downloads the MSI when executing the batch file via winrm"
So, this is actually by-design, we're treating trying to set a `double` to `null` here like a formatting error, like if you bound `string => int` then passed in "lol" as the string.

You could make this argument too though - pros / cons?
Addressed in 372c43b
This should be a return I think?
I got your comments, I will work on it as soon as I get done with my midterm exams. 
Thank you,
mohamed
If you're going to have addFrom and setFrom, then we'd also have

 * addSelect / setSelect
 * addWhere / setWhere

All of these would move away from the fluent syntax, but that's probably okay, since this class is really an internal plumbing class and not something exposed to regular SS users.
you can and should use `find_or_create_by_alternative_and_metric` to do this, or since this will be deprecated in rails 4, the more savvy, `first_or_create`:

```ruby
vanity_metric_counts.find_or_create_by_alternative_and_metric(alternative, metric)
# or:
vanity_metric_counts.where(:alternative => alternative, :metric => metric.to_s).first_or_create
```

see:
http://api.rubyonrails.org/classes/ActiveRecord/Relation.html#method-i-first_or_create
I think this bit of logic should go in the adapters (ie is_experiment_enabled?) so there's no need to set it in ab_test (saves a whole one db access per experiment lol). Same with setting enabled to false when an experiment completes (since active? precedes enabled? anyway. and now you can save a whole two db accesses !!).

The trivial db accesses aside, I think is_experiment_enabled? should always return a boolean regardless of whether set_experiment_enabled? is called before it or not.
Ah, and yes, the serialization. There is no setter for UUID so no. It will not work.
Yeah, this makes more sense :) I also first thought that it's just a local declaration, but now I see it's actually a multiple assignment.
why not move `!isset($params['tagger'])` to line 26 and next `elseif (!isset($params['tagger']['name'], $params['tagger']['email'], $params['tagger']['date']))` to line 28?
Eh... yo he probado una instalación con npm install, con esas dependencias, y me lo ha instalado todo.
"generated" -> "generated offline"
What happens if multiple plugins define the same attribute?  (note that the order of dictionaries is not guaranteed)
corrected the indentation/spacing issue
Why do you remove this code?
Should key be `mixed`?
Good idea, just did this.
oh and there is a simple byte reduction I had thought of, but I'm not implementing yet. give me your 2c:

``` js
'left,top,bottom,right,width,height,letterSpacing,lineHeight,...'.split(',').forEach(function(property){
    Element.Styles[property] = {map: '@px'};
});
```
aha! that's exactly what we were looking for.
It's kind of vague and presumptuous to tell people what they want--it's better to say why something is preferred, if that's what this is. I kinda fudged and said it was more useful, called ResultsReader a base class (is that true?) 

 * The {@code ResultsReader} class is a base class that represents a streaming 
 * reader for Splunk search results. See {@code ResultsReaderXml}, which is 
 * probably more useful to you.
`weather icon` is translatable string.
User visible string.
*uporabnikE*
Local variables should be with [underscore](https://github.com/wlanslovenija/PiplMesh/pull/199#commitcomment-1707793). :-) (Just style we are using.)
Why `trim`?
No, you had some `-a` parameter there.
Ok i changed this now. It works. If this is not the right way, then I have no Idea how to write it differently :).
This URI is directly to the comment. Will change to all post comments.
No, there should be no need for this.
Chain those together.
This works, but it might be more efficient if you filtered the unneeded directories from `dirnames` (called `dummy` here).

```python
remove = [f for f in dummy if self.should_skip_directory(f)]
for f in remove:
    dummy.remove(f)
```

You'd also be able to remove the path normalizing stuff in `should_skip_directory`.
Same with this: `self.assertTrue(filesize < 1100000, msg)`.
Even though this syntax does works, Twisted recommends passing in a full string.
this.sso = {

                {%- for param in sso.service -%}
                    {%- if sso.service[param] is defined -%}}
                        {{sso.service[param]}}: "{{sso.service[param]}}"
                    {%- endif -%}
                {%- endfor -%}

            };
Oh, yes, you're right. But there was :D Commit incoming...
Ich glaube nicht dass das nötig ist, ist wirklich ein Spezialfall. Was meint @d22 dazu?
On Jul 25, 2012, at 01:33 , Mario Uher wrote:

>> @@ -6,13 +6,12 @@ module Rails
>>     module ActionView
>>       class TestCase < MiniTest::Rails::ActiveSupport::TestCase
>>         TestController = ::ActionView::TestCase::TestController
>> +
>> +        # Register by name, because Helpers are just modules
>> +        register_spec_type(/Helper(\s?Test)?$/, self)
>> +
> 
> Referring to [ruby-doc](http://www.ruby-doc.org/core-1.9.3/Regexp.html#label-Character+Classes) `\s` matches any of following white space characters `/[\t\r\n\f]/`, which should be just fine.

You really want to match:

```ruby
describe "Helper
Test" do
  # ...
end
```

?!?
This check doesn't seem to work. I'd just do `if (empty($newSettings)) {`.
the translation would be "Alejamiento"
Please remove this file from your commit.
I'm pretty sure `({@name, @age, @height})` works.
I'm not very well versed in the Maven world. What exactly is the parent info you are referring to?
boom!  stubed
what is the purpose of the Mixin here ?
There's actually a few decorators now - I think it'd make more sense there, actually, but I like that idea.
Ha!  Awesome.
Will [`Array#replace`](http://www.ruby-doc.org/core-1.9.3/Array.html#method-i-replace) work here?
Yes, this is much better.  I was doing some other logic with this `case` before refactoring and just didn't see it this way - thanks!
added docs pls take a look
please remove the ; at the end. I've heard that the mysql wrapper doesn't understand the query if it is present at the end. I'll have to remove the other leftovers too I see.
Hmm sounds like bring a lot of code no ?

I don't understand why check capabilities first ?

Can you explain me quickly ?
Aww, no rickroll? I'm disappoint.
I just copied the Sersic maximum.  But regardless what number we go with, I think we need a better behavior for what to do if it is exceeded.  But I'm happy to defer this until the issue comes up in actual usage, since that might inform what would be the appropriate action to take.
i guess I have a similar question about the provenance of `xdbg`? Are these well-known shorthands for default debugging info streams?
I just finished reading through ```getShear```.  I see there are some changes in handling of args, plus the fact that the gridded shears get saved under certain circumstances and could be reused.  I think it's worth being more clear about under what circumstances they are saved and reused in the dox.  Also, I think that in this case we might want to consider a kwarg to force it to discard and regenerate a new random realization.  Or perhaps this should also be saved for #248...
This is probably a case where my request that "All profiles have a getHalfLightRadius" was a bit silly.  This might be better to just remove as an option at all, rather define it and than raise a NotImplementedError.  (BTW, I think you meant raise rather than return.)
I believe this is the first demo to use the truncation.  If I'm right about this, then perhaps a small explanation of the units for the truncation parameter would be helpful?
image of the correlation function?  I thought this was just the image itself?
I added some clarifying comments about this in the script.  And I moved the STOP's even later just to point out that it is fine to do so with the way Queue works.
Fixed and pushed this.
This block does not seem proper or necessary.
I guess you could write your address here instead of the ocamlpro one :-)
I've noticed that you do type comparisons this way -- by slicing off the first four characters and comparing only them.  Why?  Hard to believe it's anything but marginally better performing, and note quite as correct (type="noneck" would match).

Won't hold up pulling in, style question
out of interest, what's the reason for this change to sudo args and input?
This is a really unpleasant error to be thrown to the user, given the underlying cause. There is a log.warn earlier to tell the user no port was available, but we should also strive to have the thrown exception tell the user what's wrong.

This fixes the integration test which is really important just now. Could you raise an issue to improve the error reporting in this scenario? And I'll merge this pull request.
it was just for logging, but i've done it properly with atomic ref and a synch block now
personally, I would change reference of JCloudsCloud.getByName to a field of type LoadingCache\<String, JCloudsCloud\>

a ctor parameter could set this by default to 

   this(CacheBuilder.newBuilder()
       .build(
           new CacheLoader\<String, JCloudsCloud\>() {
             public JCloudsCloud load(String key) throws AnyException {
               return JCloudsCloud.getByName(key);
             }
           }), other params);

but in a unit test, it could use something non-static.  ex. returning a constant instance of JcloudsCloud
I could
- take it off both
- leave it in but as a tabstop that is easy to delete on the fly
- split it off to an eof snippet
For android yes. For other platforms preferably no. 

Sent from my iPad

On 12 Nov 2012, at 18:32, Martin Lasak <notifications@github.com> wrote:

> In webinos/core/pzp/lib/pzp_websocket.js:
> 
> > @@ -66,6 +68,22 @@ var PzpWSS = function(_parent) {
> >      return Object.keys(parent.pzp_state.connectedPzh);
> >    }
> >  
> > +  function getVersion(callback) {
> > +    var version;
> > +    if (os.platform().toLowerCase() !== "android") {
> > +      child_process("git describe", function(error, stderr, stdout){
> > +        if(!error){
> > +          callback(stderr);
> > +        } else {
> > +          callback("v0.7");
> > +        }
> > +      })
> > +    } else {
> > +      callback("v0.7");
> does that needs to be changed manually each time we go up with the version number?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Removing this code makes me really happy!
A norm I think you introduced ;) haha
please remove these ``@return void``. Sf2 does not use them. And this method should use ``{@inheritdoc}``
This should probably be a part of our DataSource or maybe another library - rather than a top level function...
Perhaps we get something out and iterate on the look/feel thereafter. That being said, I'd be happy with you making the heading change as you see fit if  it doesn't look good as-is.
Он был потом переименован в Tester, но почему-то остался. Fixed
Исключение в reader.close() -- и остальные не будут закрыты.
Правильнее называть LineCounter
This is definitely a sign of an object that needs to be extracted. Whenever you have a method that says "Let's delete all the variables and re-initialize them", you are essentially recreating object creation/destruction mechanisms. Still, I struggled to find the clear dividing lines here.
Yeah, I didn't like that either. Do you know if QUnit has a way for me to register something to happen for a particular test when start is called? I didn't see anything obvious.
Is it not better to do:

kdd_simp - qd_kd = 0 ?

I vaguely remember Gilbert having issues with assertions failing due to simplification in long expressions.
Some comments on the configuration in use here would be good.
Is the nil? check needed?
eigenenen --> eigenen
I can't see where these `browser_id_*` properties are being used. 

If they're not being used then generally we delete them as a prevention of them becoming out of date and broken as unless you use these properties you won't know if or when they are broken. 

It keeps the test suite looking and running lean too :)
standardized on pre-approval and pre_approval
] や [
や前後のスペースはいらないのでは。
I'll look into this today, background loading was already next on my to-do list :)

If `isLoaded()` always returns true after a call to `loadMovie()`, should we add a second flag, maybe something like `isReady()`?
The same thing could be accomplished by just returning false if the _hdata_user_load_basic fails to find the user.  This would result in less queries and therefore lower page load time.
з setPlainPassword('qwerty') авторизація нормально працювала. чому прибрали?
not a big fan of the parameter name fullPage - seems ambiguous - still pondering over the correct name
Thanks - duly noted.
nothing wrong with tmp0.length being 0
How do you get the base_site? can you please add a :hint => "Link to the help/doc about it"
Like previous paragraphes, initiate it.

You're in a BC break changelog, there's no need to tell that "there's also a change", tell the change.
I think the logic of this function (combined with the kill() in spill hash table) is that rows get deduped until the bucket spills, but from then on they are written straight out to disk.  The last bucket to be spilled isn't fully spilled and continues to dedup rows.

An alternative approach might be to still dedup rows for all spilt buckets, and only write out rows that aren't duplicates.

The advantages of the current scheme are that it delays the point where the subsequent buckets need to spill.  If your very close to the memory limit then that is going to be better.

The advantages of the alternative scheme occur if there are many more rows than memory.  If the data follows a zipf distribution or something there are likely to be a large number of duplicates reasonably close to each other.  If each bucket continues deduping then you may find that significantly reduces the number of rows written to each spill file.

I suspect it is highly data dependent which is the best.  Maybe both should be allowed, selected via a hint?
Is this meant to do something different, or can it be deleted?
So we can run other remote tests without the URI library
Ok, I'll change it back. 
But in my opinion this is more logical way of using it, because we pass data through our filter and only if there is parameters that we need (I mean if this is our case) we add some additional stuff.
This is convoluted. If all you want to do is filter out empty lists and empty strings then just do: `valid_value = bool(value)`
That `except TypeError` feels to me like it doesn't really know what it's expecting.
Ah makes sense then.
I'm not seeing an indentation weirdness. Please describe in more detail?
BTW: bootstrap used XMLHttpRequest initially but there was some issue either with encodings or maybe it was something else, but we had to move away from XHR (Don't exactly know if that was justified I just saw it post factum after change was landed). Yeah unification is a good idea, but maybe not in bootstrap as it's not as easy or maybe bootstrap could pass it's `read` to a loader somehow which than would expose it in some way, but again not sure how easy it would be and if it would justify the complexity. l10n, self, and here seems like a good places to do this unification.

Also @ochameau mentioned it's not easy for l10n not sure why.
FIX THE WHITESPACE ERRORS JESUS
Might need clarification on what you mean.
`do` shouldn't be used on any function that doesn't return a monad (such as `IO a`, `StatementGeneratorT a`, `BlockGeneratorT a`, etc.).
`params.each` won't work because all `params` contain default rails stuff like controller, action, etc. Doing `params.each` would pull those in too
All modules have VERBOSE already registered, no reason to re-register it.
Upper-case "U" for "uploading", please.  Also, this part can take some time.... I think it's nicer if you mention that in the message. Something like "this may take a few minutes" is fine.
Changed... I'm still too used to Python 2.x
oh sorry. no idea how that happened.
Was this test added just for completeness, or does it relate to the code you removed above?
I think you mean to discuss the advantage that this offers - DRY. Perhaps rephrase in these terms?

"This allows you to not repeat the definitions of the constraints, but still have them applied at all layers, and thus report good error messages to users"
Why is this reading up to 1024 bytes?
So if `doneCallback` gets called when an error is generated, is `doneCallback` the right name then?  Also, doesn't finish take an `event` parameter.  Does that event have any information to let us know what the error was or if it's good or bad.  It seems like we might want incrementalGet to provide an `errorCallback` and a `doneCallback` if we can tell the dfference.  Or maybe this should return a promise that is called on done rather than multiple callbacks?  @shunter ?
Did you test regions greater than 3x3?  Do they need to be odd?
Should we mention that we drop the `z` component?  Obvious, I know.
See also:

https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/map/src/java/ti/modules/titanium/map/TiMapView.java#L750

```
			case MAP_VIEW_HYBRID :
				view.setSatellite(false);
				view.setTraffic(false);
				view.setStreetView(true);
				break;
```

So we're just doing the wrong thing here.
Great, sounds like we need it then.  Thanks for looking into this.
You could do just:

    hintText: {
        post: "_updateHint"
    },

If the property's "post" value is a string, it assumes a method and will do this["_updateHint"](). This is useful only if you don't need to pass anything to _updateHint(), so it works in this case.
Will address this. I was wondering if this value could be null.
good catch. "Country" is suported, not "CountryCode". Also added that we don't support "County"
The more that I think about this solution, the more I don't like it. I opted for fabricating/generating the data for each spec. It could introduce some redundancy in the data, but it makes each spec self-sufficient and also gives you the flexibility to use any data that's necessary to stress test the functions.

When we merge my specs, we should revise your specs to adhere. What do you think?
Not sure what you mean by always. It'll only warn if file level DocBlock exists and it doesn't have an @package tag.

I added the check based on the examples from manual.phpdoc.org, e.g. see tests/data/file-level/NoPackagePrecedesDocBlock.php added in this commit.
Да, я что-то намудрил. Не знаю почему сразу просто не подключил через sass.
That check will be covered by https://litmus.mozilla.org/show_test.cgi?id=15127 for all tabs.
Oh, and the cast isn't needed either - it's all `size_t`s. No?
@andralex Okay. I rebased and added the extra requirement to `isRandomAccessRange` that `r[$]` work properly if it compiles with the range (though we can't require that it work for all random-access ranges without enhancement #7177 being implemented, just that it does have the correct type if it does compile).
`forceToInit` may be a better name. Anyhow, what is the utility of this function outside Phobos' implementation itself?
We shouldn't deprecate this, it's gratuitous. Just alias it away.
The task of splitting off type agnostic parts out of template is an important optimization pretty much overlooked in Phobos.
I'm very much in favor of it making its way into Phobos.  So carry on :)

I'd argue futher that containers need little to know about types they store (especially for PODs - size+alignment is enough). Just a food for thought.
Utilise plutôt l'impératif que l'infinitif. On dirait une recette de cuisine :)
yes it's my understanding that  all previous  versions are defined as well as the current one
See the MISWiki: https://www.plymouth.edu/webapp/mis/wiki/Oracle_Tricks#Ranking_Records
break should be in line with the contents of a case.
I'd like the file name/path to be recorded here as well, and used in content.dataload.js
+1

I don't think it is a lot of effort to install that on linux, but it might be more complex on mac os x.
Cache calculated values where possible, e.g:

	string typeAttr;
	string TypeAttr {
	    set {
	        typeAttry = value;
	        JsonTypeAttrPrefix = "{\"" + value + "\":";
	        JsvTypeAttrPrefix = "{" + value + ":";
	    }
	}

        JsConfig.TypeAttr = "_type";
Because the namespace will be different for every user, so might as well set n the same place as the $issues. People can choose to optimize by inlining; we don't need to do that for them.
Can we make the new class row templates include a common template to reduce code duplication?
Ok I added a builder, it's 35°C here though so it's probably not correct. Just wanted to get some feedback. I left the getDefaultExclusionStrategy method in the Serializer, because I think it should still use grouping by default no matter what, and I think it should be easy to override by extending it.
Just added a comment in a new commit.
What if File["${apt::params::root}/sources.list.d"]  isn't defined in the apt module? Then this block, which is attempting to override parameters for the resource, won't work, failing with "Only subclasses can override parameters." You would need the apt class to inherit the foreign class for that.
Missing space before `{` here and below
They determine the position of the widget to avoid users dragging it to an unreachable area off screen.
Pass URL parameters to Solr query for sorting
Not sure I want to make this message any longer :) but, .... perhaps it should mention that the correlationKey would require that a downstream consumer knows to expect that and will send it back in a reply.
I know what you trying to say, but i think the real question here; Are we OK with this field being modified once set since it would not make any sense to set t to anything once initialized, so may be a boolean flag in the setter like we have in other places
Let me explian. In most cases doParse(..) is implemented in the *InboundChannelAdapterParsers, which build some implementations of MessageProducerSupport. And last щту takes care about null check in the onInit(). And other implementation is AbstractOutboundChannelAdapterParser, where I've added  **if (!StringUtils.hasText(channelName)) {**.
And also SourcePollingChannelAdapter has it in the onInit() too.

About 'isNested()': it's about prevent directChannel creaction, when <outbound-channel-adapter> is within e.g. <chain>.
Or do you mean that I should add 'null check' is the all adapters' parsers?
Nit: since everything is now synchronous, you don't need the done() function anymore. Also, there's still a tablename variable in this test, that's no longer used.
Yo Tito,

Just in case you were going to look at it tomorrow, don't!

I've got it working very nicely with threads now (after three hours of trying), so I will try to finish off the final bits that I am struggling with and  push again tomorrow.

Thanks,

Fb

On 22/03/2012, at 11:42, tito wrote:

>> +	##       ##     ##    ##          ##     ##   ##  ##     ##    ##    
>> +	######   ########      ######     ##    ##     ## ########     ##    
>> +	##       ##     ##          ##    ##    ######### ##   ##      ##    
>> +	##       ##     ##    ##    ##    ##    ##     ## ##    ##     ##    
>> +	##       ########      ######     ##    ##     ## ##     ##    ##    
>> +	
>> +	# Hi Tito!  
>> +	
>> +	# So, I've had a go with it. I had a couple of problems:
>> +	
>> +	# - The big one: I don't understand how to turn on and off the event listener,
>> +	#		so it is currently on all the time.
>> +	
>> +	# - I couldn't set a sidebar_results variable that I could then access
>> +	#		from the FindResultsListener, so I went off the name of the view.
>> +	
> 
> That object seems to be non-writeable. That's way view.settings() is there.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/titoBouzout/SideBarEnhancements/pull/11/files#r590303

--
Stephen Horne
Do we need to escape the backslashes here, or is this safe?
doUnexpectedFailure - maybe rename to handleUnexpectedFailure?
Long 型のパラメータ取得のためのメソッド ResourceHelper.getLongParam がありますのでそちらを使うと良いと思います。
the registry.mako template file is missing from #197 pull request.  Need it added.
I must say that I do not understand this line? You just create pk from thin air here by taking the length minus one? Is this OK? Is not pk/id automatically generated by MongoDB?
nit: space after `=`
Лучше использовать console.log() вместо document.write()
Here's the bits I actually added.
Totally reworked both sections.
too strict and narrow. this is "show us how smart/capable you are" not "learn django in 24 hours" or something
context should go in the constructor
This cache guarantees there will be no locks when deleting the file, but shows the fragility of the DFS access.

Once ```addSubFile``` and ```swapSubFile``` are on the same page, I'll introduce the ```DFSAccess``` object, so at least ```FileServices``` can use it consistently.
They're meta tags, so the idea was to place the identical information for all events in one place, and then have them surround the events.
replaced glob with Finder instance
Curiously this appears to be dead code. This method is not called anywhere in the source. We should be removing it as a result.
der gehört nicht rein, oder
1. Насчёт функции "скрывать похожие". Я её все равно буду переделывать (как и 90% кода скрытия) для ленивой инициализации спеллов/текста если последние ещё не инициализированы. Так что тот иф сейчас лучше убрать, да.
2. Логику скрытия я ещё не менял. Проблема точно появилась после этого пулл-реквеста?
Нет, самое простое и быстрое. С таблицей оно быстрее, ибо без неё фактически придётся с нуля высчитывать эту же таблицу для каждого хэша.
If params is null/undefined, this means no additional params will be used for blackberry-signer.
Almost had it! :)

    Invalid <feature> element - failed to find the id attribute
please don't bump any version numbers in pull requests. New releases are up to the package maintainer
Can we put further qnx calls into Web Platform? Then we can just call the webview.notifyContextMenuCancelled();
It seems that something like:
<artifactId>maven-compiler-plugin</artifactId>
		<version>2.3.2</version>
		<configuration>
			<source>1.6</source>
			<target>1.6</target>
		</configuration>

Is needed, otherwise I get the following error on a fresh maven install:
annotations are not supported in -source 1.3
Lyhyemmin myös näin: `(not (teen? age))`