bitbake-layers: fix traceback in show-overlayed with nothing overlayed

There is no logger.note, use logger.plain instead (which is what we
really want here anyway.)

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
runningbuild.py: fix goggle ui

* goggle ui actually fails with :
Traceback (most recent call last):
  File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
    build.handle_event (event, pbar)
  File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 234, in handle_event
    pbar.update(0, None, bb.event.getName(event))
TypeError: update() takes exactly 3 arguments (4 given)

Signed-off-by: Eric Bénard <eric@eukrea.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Typo: "nonexistant" -> "non-existent"

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: implement a self-defined notebook visual component for Hob

In recipe selection page, package selection page, and build details page, etc, there is a notebook component which is not gtk.Notebook in the design video.
We implement the visual component with a drawing area, and use it to replace the old notebook in recipe selection page and package selection page. The reasons why we do it are:

1) General speaking, gtk.Notebook doesn't look like the designer worked out. (see https://wiki.yoctoproject.org/wiki/File:Hob1.2-screencast2.mov)
2) And the designer version looks better, for example, there is an indicator to show how many recipes or packages are included, and how many issues happened when building? Very straightforward.
But technically, gtk.Notebook can't implement that, as far as we know.
3) Moreover, there is an entry for "search recipes", and "search packages". How to make it horizontal to the tabs is a problem to us.

Regarding those, we give up gtk.Notebook and use our own.

(From Poky rev: e4ebac226cc5e4589bcecd8bada9fde462e925cc)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: use HobNotebook to implement a notebook in build details page

This patch is to use HobNotebook we defined to implement the notebook in the build details page.

(From Poky rev: 792c5eb29cf44d9ef559ae59802327fb1bb2cb3c)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: show indicators on the tabs of the Hob notebook

This patch is to show the indicators (e.g., the number of the issues) in the build details page to highlight.

(From Poky rev: 2e08a8e6818b8f1df7eaac499ebc3a5854efe7be)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: change the code style to enumerate a list in a for-loop

We use the more common style to enumerate a list in a for-loop
(http://docs.python.org/library/functions.html#enumerate), that is:

try to use
for item in mylist,

and try to use
for i, item in enumerate(list)
rather than
for i in range(len(mylist))

(From Poky rev: 33c21bc60bd1542f81d33c328f116dec424728cd)

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: fix '!= None' and '== None' in the code

This patch is to fix the following:

if foo != None -----> if foo
if foo == None -----> if not foo

(From Poky rev: d771343b1726f166ed8d75543ba68bd2a20aee7b)

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: remove the invalid code in hobwidget.py

To delete some code which is not used

(From Poky rev: a8f5a72d36e9a55ec7a2296e1c9623e177a95a74)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: Fixed the hobwidget code and make it like a pythonista

fixed the 'for..in..' range dance code, and use the 'iterator' approach to replaced the index for quote the 'children' list

(From Poky rev: 74e7286a4e875eda5e8abeb5db1015031d21c35f)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: add auto adjust background area function for long issue text

To add auto expand the background area function for long issue text input.

(From Poky rev: f1822f0961bd719de0827e361f7e6fa3bf872746)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: change HobNoteBook tab edge color from green to gray

To change the notebook tab pressed edge color from green to gray.

(From Poky rev: 8e454749e7f535cf43544eeb167c90632e89cfb0)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: fix static variable "self.search" to parameter "search" in signal callback function

To fix the signal callback function code, and make the temp parameter to replaced the static global variable, as required.

(From Poky rev: a95b61d48bf92948ff5a21896e71ed3cb323ab38)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hob: fixed the tabbar search entry retaining focus when user has clicked off it issue

Add reset focus code to fixed the search entry retaining focus issue

(From Poky rev: 75969f92af4b0aae25dcaa3321f835dd729f4bf9)

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
ui/crumbs/hig: use close rather than OK for dismis button

Dialogue buttons should have descriptive names

Signed-off-by: Joshua Lock <josh@linux.intel.com>
ui/crumbs: remove unused return value from append_toolbar_button

No caller of the method uses the returned toolbar variable

Signed-off-by: Joshua Lock <josh@linux.intel.com>
ui/crumbs/hobpage: no need to force a Toolbar button type

This uses a more concise API that will be more flexible whent he Toolbar
style is updated to match the visual design.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
ui/crumbs/persistenttooltip: try to reflect WM close button position

When the user is running a desktop where the close button is on the left we
try to detect that and position the tooltip close button appropriately.
Where we can't easily determine this we default to placing the close button
on the right.

Tested on Ubuntu/Unity and Fedora/Gnome Shell.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
utils: Add split_version function for splitting a version into its components

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
ui/crumbs/hig: make the layer selection dialogue more closely match design

The layer dialogue design includes in-line remove/delete widgets next to
the layer path in the tree view for all layers other than the meta layer as
well as an in-line notice that the meta layer cannot be removed.

This is achieved  in this patch through the use of custom cell_data_func's
for the treeview to render the meta layer differently and a custom
CellRenderer implementation, CellRendererPixbufActivatable, which renders a
pixbuf and emits a clicked signal when the user clicks on it.

Signed-off-by: Joshua Lock <josh@linux.intel.com>