labofsahil/github-event-dataset-2012 huggingface dataset:
The actual meaning/syntax is clearer this way, and plays nicer with diff
I considered removing all macros and go to pure boost::interprocess, but there is no way to keep Gavin's fancy deadlock detection then, which needs __FILE__ and __LINE__ to track code locations. I'm fine with just an argument for TRY_LOCK and IS_LOCKED.
Actually, the only sane way is keeping a fBlockDirty flag or so, setting it to true when a block is written, and then inside FlushBlockFile only sync the block file part if that flag is true (the undo file part should always be synced).
Merged LegalTrademarks2 into LegalTrademarks1 :), you convinced me.
Nah, for simplicity's sake and to prevent problems like this in the future, I prefer balance to be recomputed instantly when a transaction comes in. Some caching also happens inside Bitcoin, so computing the balance is not a very expensive operation. Also remember that transactions can also deduct from the balance, which happens instantly and not after maturing/confirmation.

Also mind that updateTransaction can also be called if a transaction is updated (CT_UPDATE), so there is no need to always trigger the timer. It is neater to have it triggered when there is actual unconfirmed/immature balance.
No real preferences:
false is better for backward compatibility, but
true seen to be a most common chose.
@davidfowl  can you post a sample url?
This should be a static variable out of the function scope if possible
You should not try/except this. If there is an importerror, emesene.py should handle it so we know that this session is unavailable
Hmm, I've never seen people use "will" in a test. I reckon we stick with "should" OR... my new favorite: `it "autolinks a link"`. Present-tense instead of past tense. It's just less words and more direct.
Group drop down doesn't seem to work on any page for me.  Need to check this works as expected
`logging` comes before most of the rest of these imports
Is this block here in case the config dict has a key where the name of the mode is not `magic_mode` but just `mode`?  If I am reading this correctly, in this case, you just switch to that mode directly.  This logic happens after the first line regexp has matched.  In what case would this logic be triggered?  What usage case do you envision for this?
it is but we can use typed access to expiration and emission times for chacheing.
Can't understand the use case for this.
Missing writer injection, no ?
```php
  $cloverReport->addWriter($cloverWriter);
```
I still don't get the difference here. I'd need a proper definition of searching vs. filtering to keep this sentence.
Oh nevermind, that's exactly what you did. Thanks!
That bit isn't done in the template - it feels better to have it in here for this case I think, especially as we have the multi-sort
empty this file, but don't remove it (IIRC, Django wants a models.py file).
you shouldn't have this line in here.
No--we were waffling between Sphinx and ES, it's just that we hadn't split the view.
This should probably be a comment instead of a multi-line string. It's legal syntax in Python to put a string anywhere, but a docstring is only a thing for functions and classes (i.e. it gets automatically pulled out and available for help()) - otherwise, it's the same effect as a comment.
you spelled "wrongly" wrongly.
TODO ;)
It is intention to change url to read only one?
I think the count admin query is missing for mysql?
Cancellare*
Same line below.
This is wrong. The `hasSession()` must return `true` when a request is associated with a session, that's all. The fact that the session is started or not is not the same thing.
why would you have such a method in the driver interface ?
@Tobion the code in other places is already expecting a kernel as it calls the container and the boot.

And you cannot remove a service from a container.
Another (and more clean solution) is to rewrite the class Symfony\Component\Security\Core\Encoder\EncoderFactory so that it do not try to create the Encoder objects on its own (using $reflection->newInstanceArgs()), but instead makes use of the DI to create a new service. In that way the created encoder service may depend on other services in a clean way. But that is a major rewrite of that class, so I guess it would have to be approved by @fabpot  first.
yep it was :)
I have added SecureRandomInterface to be able to mock the class in tests (as I don't see how seed providers would be able to do the same easily).
これいらなくないっすか?
Would it be better to write as:
```
device_parsers.some(function(d) {
    return !!(device = d(ua));
});
```

Just a thought.
If it is not readable, then what? Certainly this needs an else and should probably throw an exception of some sort.
as it should be, indicates to backend when the API call from that client was implemented. 
allows for conditional response from backend when functionality changes.
We could extract this method into it's own class (factory) and clean up the user model a little, but I felt like at this point that would be a little YAGNI.
Notice the slight difference between mine and @croaky's examples. The shorthand syntax only works if you don't provide the first argument as Hash. Look at the implementation of the `render` method [here](http://api.rubyonrails.org/classes/ActionView/Helpers/RenderingHelper.html#method-i-render) and look at the case when first argument is not a Hash.
If you return False here, the method won't be able to be unpacked into `status, message`. It might just be easier to raise an exception with the message "A correct port must be specified" and then you can just do a `self.log.exception()` in the main check method.
How can I get the three parts from the hsG3DDeviceModeRecord then?
same thing here:

```ruby
describe ".tag_types" do
  subject { TaggableModel.tag_types }
  it { should be_a(Tagtical::Tag::Type::Collection) }
  its(:first) { should be_a(Tagtical::Tag::Type) }
end
```
"methods" -> "method"
There is no evidence because you haven't checked.
Does a reopen affect any data waiting before the reopen? Does it affect any data that was being sent during the reopen?
It is a known issue on windows

I know you don't verify anything but the obvious issues with your code (you have proven that in the past) so unless you verify that this hack (and it is clearly a hack) does NOT affect performance - there is no way I'd want it in there
Until the code reports MH/s perfectly (yes yours doesn't either) using the MH/s number to decide if it affects performance is of course wrong.
Instead use some programming skills and work out how to detect this RARE event and deal with it then - you yourself say it is outside the control of cgminer when it happens
if apiRequest's uri is null ...
fixed the bug of dragging labels that would change midway and be very frustrating..
Can you apply the same indentation for these changes, like the other dependencies in that file, please? Same for the other PR against master branch.
I guess I should update that template
Looks like it can. This module is the only one that declares a dependency:

$ git grep org.python
build/build.xml:        <module-def name="org.python.jython.standalone">
build/build.xml:            <maven-resource group="org.python" artifact="jython-standalone"/>
build/pom.xml:                    <groupId>org.python</groupId>
build/pom.xml:                                            <title>Module org.python.jython.standalone</title>
build/pom.xml:                                            <packages>com.kenai.jaffl:com.kenai.jaffl.annotations:com.kenai.jaffl.byref:com.kenai.jaffl.mapper:com.kenai.jaffl.provider:com.kenai.jaffl.provider.jffi:com.kenai.jaffl.struct:c
build/src/license/licenses.xml:      <groupId>org.python</groupId>
build/src/main/resources/modules/org/jboss/as/jdr/main/module.xml:        <module name="org.python.jython.standalone"/>
build/src/main/resources/modules/org/python/jython/standalone/main/module.xml:<module xmlns="urn:jboss:module:1.1" name="org.python.jython.standalone">
jdr/jboss-as-jdr/pom.xml:            <groupId>org.python</groupId>
jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/SoSReport.java:import org.python.core.PyObject;
jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/SoSReport.java:import org.python.core.PyString;
jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/SoSReport.java:import org.python.core.adapter.ClassicPyObjectAdapter;
jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/SoSReport.java:import org.python.util.PythonInterpreter;
jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/SosInterpreter.java:import org.python.util.PythonInterpreter;
pom.xml:        <version.org.python.jython.standalone>2.5.2</version.org.python.jython.standalone>
pom.xml:                <groupId>org.python</groupId>
pom.xml:                <version>${version.org.python.jython.standalone}</version>
Shouldn't it be using OAuth and storing a user ID or access token anyway. Or is it just for public display? (But I agree with you Lorna, not required)
We should probably use `targetElem` instead of `options.of` here. Unrelated to the changes, but you're already doing a lot of cleanup.
How is it rendered when the image is rounded?
There should be a  `/* XXX hack */` on top of the CSS properties that is used for the hack. (see `sms/style/sms.css`)
It seems that removing the src is working properly. Could you check it?
Make sense. But if friends_shortcuts.js / friends_list.js could be replace by contacts_shortcuts.js and contacts_list.js there won't be any files not related to facebook so imho that should be fine.
Could be extracted into it's own JS file with `brazilRegionName()` and `brazilNationalCarriers()` functions but it's not a blocker for the PR.
You also may want to add a few line breaks to the code to make it more readable.
I can see a couple of issues with this:

1. It uses vCenter specific resources, in what should be a generic broker.
2. Using apply in that mode might not work well, depending on the setup of the system
3. This will create a second key and certificate for that node, as root on the Razor system

Those are pretty bad; I think you would be better off with an empty function here rather than this very site-specific configuration.
If every test name contains `test_should_` then there is no new information :)
Мне кажется было бы лучше написать *... если не настроен ни один* **из способов** *оплаты*. Как думаете?
As `userWantsToSignUp` is a method the syntax should somehow be different. Why didn´t you use `signUp`? `userWantsToSignUp` seems more like an event to me ...
You use this syntax several times, if you agree to change it please remember to change the other occurrences, too.
if period == 1, then this will be a DateRange with only startDate inside the range.

I think the upperBound logic needs to come into play here as well.  Of course, if DateRange had been exclusive in the upper bound, this would have been simpler. Maybe for scalding 0.9.0.

So, I guess, the period-1 is confusing me. I think it should be startDate + Days(period) - Millisecs(1) (due to the damn inclusive behavior).
you should make this "if not copy_successful:"
You can change that whole path to `/etc/appscale` to simplify it.
Btw, smooth zoom is now on Android 4 too, right?
iirc we don't need `sendAsBinary` anymore as we were passing form data into an iframe as a string.
It also only exists on Gecko afaik.
Just do `r.send data`.
This is the default behaviour of a generated Rails app.  Nothing in the application was including application.js anywhere, so this was redundant (and only slows down the assets:precompile task)
Would be cleaner to use the non-block form of content_for:

```erb
<% content_for :body_classes, 'full-width' %>
```
Well it is depends on the hardware designs and you never know there are some architecture will shows up. Now we already see some numanode assign cpu like node 1 has 1, 3, ... and node 0 has 0, 2, ... in the desktop. And we don't test in something like server or blade which may include tens and hundreds of cpus. So it is probably one day the autotest is running in a system with more than one \d+-\d+.  So I'd like to cover more possibles.
You copied this pattern around 4 times. Any chance you could extract it into a method?
This should be a call to `buildbot.config.error` instead.
Why not return `this`?
are you sure about the glue for the implode call ? I think there is extra quotes in it. You should use several prefixes in the test
Please keep the lock file from the master branch. there should be no reason to change it here
You should test the result
why we need `html_safe` here?
I don't think an `options` object is "official" in terms of convention, I just like grouping them all together. As it is in this case I have to break it anyway because I can't refer to the scope of the block itself when setting `options.qs`. Perfectly happy to switch to `CONSTANT`-style naming. The one thing I do like with using `options.store` or whatever is that it's easier to search for all usages of option-based parameters, rather than just searching for any variable which could be local in terms of scope. I guess all-caps naming will help with distinguishing that, though.
Added trailing whitespace?
I'd prefer ````case...when```` construct for these cases actually because it would make this kind of code more readable. I know you used similar code in other place too. So, this example could be written as:
````
case which_item
  when Fixnum
    # do with numbers
  when String
    # do with strings
end
````
Yes, sorry, that actually what I had in my patch locally.
Thanks,
Matt

Sent from my iPhone

On Sep 19, 2012, at 2:21 AM, Jonas Nicklas <notifications@github.com> wrote:

> In lib/capybara/selenium/node.rb:
> 
> > @@ -5,7 +5,8 @@ def text
> >    end
> >  
> >    def [](name)
> > -    native.attribute(name.to_s)
> > +    @attrs = {}
> Nice catch Olek :)
> 
> —
> Reply to this email directly or view it on GitHub.
>
changed.

thank you.
hmm, I think this could be done a little differently to test that the order of events is correct.  Perhaps just loop throu one array and make sure the element at the same index in the other array is the same.
Same formatting comment as before.
It might be cool to print it last, before `Your sample add-on is now ready`.
Just to emphasis it and may be drop a note to say that's in package.json:id attribute and that you can set a human readable one?
`require('./private-browsing');` would be more explicit.
Yeah, that's true enough.
used `baseID` as arg name instead.
This if statement is confusing. I believe you just use `instanceof` here to `QueryInterface` but instead it looks like there may be a selections that are not `instanceof` `nsISelectionPrivate`. If my previous assertion is false, please factor interface querying out of the if block to make code more obvious.
would this be more readable?

  if (r && r.urls) {
    // udpate db etc
  } else {
    if (err) logger.error(err);
    httputils.badRequest()
  } 

??
PS don't worry about removing it from the other pages just yet. It should be done in a separate pull to keep the pressure off this pull. Or better, pop it in the pivotal as a refactoring task and someone can pick it up and do it :)
Yeah. I could take that out. I thought it'd be cool if and only if the s= value was a valid ISO date. My worry is that if the sprint isn't yet created, then this code will mostly only add it to the ready backlog, and when the sprint is created, it won't automatically flow into it unless the bug is updated again. I could write some post save logic on Sprints that would search for bugs with the slug in their whiteboard and collect them I guess.

I'm just trying to make this thing as useful as possible for the most people. MDN isn't organized enough to use the sprint planning features yet, so they'd rather still be able to manipulate things from bugzilla. I did think about adding a boolean onto Project that you'd have to switch to enable this. Perhaps that would be better?
I tried that already and it resulted in test failures for other parts of Puppet.
This is a little hard to follow. What do you think about something like:

```ruby
value = instance.meth_2(:submitted_arg) { |a, b| [a, b] }
expect(value).to eq [:submitted_arg, :additional_yielded_arg]
```
although there is testing of this within test_afni_niml_dset  it would be nice to have 'atomic' test for this particular function testing different corner cases.
class header with the appropiate "@group"
Shouldn't this be "library/Zend/Acl"? And what effect will this have for people who have already installed following beta5?
If someone has gcc, can we be sure that everything is set up correctly? If so, then this would definitely be the better route. I will change the wording for now, though.
Huh? Why not check the IsPrerelease bit?
@guilhermeblanco what framework specific code? This is composer support...
and this is of course true for all protected properties in the codebase
you should be using PHPUnit's ``@expectedException`` instead
why does my app still work with this line commented out? does rails automatically do this for you?
Not sure about that, there isn't a lot of duplicated code... The core parts are slightly different.
I assume you meant the 'an' in this line, not the title? 
You can see that this stateless session bean has been marked up with the @javax.ejb.TransactionAttribute annotation.

Done.
Okay, fixing it up, and send an update in a bit. Sorry about that.
Just push another commit that deletes that line.
true, dammit  c-p from wrong file

Fix it and tell me when to pull

PROC kai PROGRAM why not? cause of braces?
This change is relevant to this pull. I am adding choice for BUILD_TYPE where a choice exists. Currently the only choice on the other jobs is 'daily' so there's no real benefit to adding a choice with one item.
nevermind, on a hunch I examined the fill file and saw that this is actually a salutation of some kind. thought it was plugin text.
keep the other changes, but change this to log to the console instead of throwing. You'll likely need to change the tests so that they dont expect a thrown exception
Move the " to the end of sources
What is the last "false" argument for?
I feel that it will be more visible to make the URL and open it here  then use a page.py method
You don't need to declare another method for this.
You already have one in base.py https://github.com/mozilla/wiki-tests/blob/master/pages/base.py#L37
you need to call cuDeviceGet, passing in i. The CUDA runtime returns it's own private device ID into dev.

see: http://developer.download.nvidia.com/compute/cuda/4_2/rel/toolkit/docs/online/group__CUDA__DEVICE_g8bdd1cc7201304b01357b8034f6587cb.html
I think this could throw an exception which should be catched to return a valid result.
It's used in an Array#map call from the classification model.  It seems 1.8 allows you to call a private method from map (using the &: syntax) but 1.9 only lets you call public methods, hence it's moved above the private line.
I guess it does, as it would simplify the SQL query (it would also use indexes better etc)

it would be select * from reports vs select * from reports where host_id in (all ids of all hosts)
I am not sure what this code does, so dont have it in the bundler_ext branch of the if statement.
I will send a new PR soon, also looking at adding History too if you're not against it.
But on the line before, a referrer is added to `@referrers` so there will always be at least one referrer in `@referrers` on line 116, right?
Is this the text we want to flash on save or was it part of the generator? (I honestly don't know. Same question applies to other `notice:`s and `status:`s.)
I don't think $pid is defined in this context.
Is the `Trade` parameter even necessary?

 * The `TradeManager` stores a `Trade` as a property.
 * The `Trade` isn't even used anyway.
why the echo?

your shell scripting ability amazes me!
i think classes make sense when the styles are intended to be re-used.  or to continue your example, if you wanted to float the header's entry-meta, but not the footer you'd do header.entry-meta {float:left;}  

anyway,  i can agree to leave it as is.  it might even make transitioning old childthemes to thematic5 a touch easier.  with that thought we should probably avoid re-naming things as much as possible.  though i already renamed #header since it is now <header>... should it be <header id="header">

hmmm.... or is it better to reduce the div naming and rely on the semantic elements.  oh the choices..  this is why i'd never get this done by myself.  

how do we merge some of the commits but not all?
What's this component for, exactly? It doesn't seem to add much functionality over the HermesService that it's wrapping. Or is this refactoring needed for some future feature?
I think Function.bind isn't implemented on IE8. Maybe use enyo.bind() instead?
Support filtering on complex properties.
How big will pDis2 be? If it is likely to fit in memory - then a ,LOOKUP or ,LOOKUP MANY will be more efficient here
i can agree to do the check and throw exceptions in orderBefore rather than here (though it will make the potentially expensive array_search twice). either way we can not just remove the throw, as we would start to violate the PHCPR api.
Nope does not work
undefined method `NUMBER_OF_LABEL_SIZES' for #<#<Class:0xa502d8c>:0xa500dfc>
That's the line 
` min<max ? 1 + ((NUMBER_OF_LABEL_SIZES -1)*(log_distance_to_min(tag.frequency, min))/log_distance_to_min(max, min)).round : 1`
That is so weird!
What about maximum retries?
Might be better UX just to give them a link directly in the empty grid.  We can take care of that later though.
Should be resolved by b019289.
This type of recursive function is very different to how we do it elsewhere in the code. Please consistify.
The fixes may actually have hurt readability quite a bit. My preference would be to just make the logIn part of the validator in this function, and limit the other changes that are being made.
Do we really need to define the available principals and object types here? I'm thinking about scenarios where optional modules want to add in additional object types.
Make "Topic" fixed-width by wrapping with hyphens as it is a value.
Grammar Nazi: "You must send at least 1 argument to msg" s/arguments/argument
i feel this is a pointless abstraction, there are no plans to use anything other than redis at this point.
подивися заодно чи можна такі урли зробити
"/blog/tag/{text}/page/{page}"
I had to change this to 'change' to actually get this to work. on mouseup $( this ).val() still gives you the old value.
Extending `RuntimeException`?
well, the worse idea is ``print cookie jar`` as this does not mean anything for a browser. the name CookieJar comes from the BrowserKit component. I would remove this step entirely.
I swear this is the most bizzare use of a constructor I've ever seen (and probaby ever will). What the hell ... go for it.
пробовал через цикл через do while. получается, только из количества нужно отнять единицу и код получается менее красивым.  поэтому оставил так как есть.
кстати, конечный результат https://github.com/khudenkon/osx-project-1/commit/1c2ca12c23bcb92bdf3d4b530cb934898fe8d365
And (iirc) this one commented out.
You see, here you now just have a simple line, instead of a usable block for doc.
Yes, I prefer this to 'negate'.
visit edit_user_path 
используйте хелперы
Is there any reason to create these .bat files dynamically instead of just checking them into the repo? They don't seem to have any variables in them that need to be set by this script.
Logan, I put this in b/c of lines 22, 67 (size => badge_size).  Feel free to remove this variable.  I'll leave it up to you.
Oops, that definitely wasn't meant to be included in the PR. Sorry about that. Updated now.
It seems like it would make more sense to invoke the selector once, immediately, and then never again.

Either way, we should document this behavior.
Move from Module context onto class variable ... see ASModel suppression code.
这个地方蛮赞的，type hint还可以这么用啊 -- 用来指示到底调用参数列表相同的哪个方法
"Ciebie" małą literą. Nie ma potrzeby, żeby tutaj pisać wielką.
thanks for clarifying !

10% is not enough I think to justify the complexity? what do you think?
let's keep digging ...
2012/10/11 Alexandre Gramfort <notifications@github.com>

> In examples/export/plot_epochs_to_nitime.py:
>
> > +
> > +# Setup for reading the raw data
> > +raw = fiff.Raw(raw_fname)
> > +events = mne.read_events(event_fname)
> > +
> > +# Set up pick list: EEG + MEG - bad channels (modify to your needs)
> > +exclude = raw.info['bads'] + ['MEG 2443', 'EEG 053']  # bads + 2 more
> > +picks = fiff.pick_types(raw.info, meg=True, eeg=False, stim=True, eog=True,
> > +                            exclude=exclude)
> > +
> > +# Read epochs
> > +epochs = mne.Epochs(raw, events, event_id, tmin, tmax, proj=True,
> > +                    picks=picks, baseline=(None, 0), preload=True,
> > +                    reject=dict(grad=4000e-13, mag=4e-12, eog=150e-6))
> > +
> > +epochs_ts = epochs.to_nitime()
>
> untested :
>
> --> 582 from nitme import TimeSeries
> 583
> 584 if not self.preload:
>
> ImportError: No module named nitme
>
> GGGGRRRRR!!!!
>
> ok ;-)
that was a nasty one, I thought I fixed it before pushing it...

—
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1818062>.
>
>
completely forgot to turn off hard line wrapping. I shall fixor
Isn't the user_id intended to be 5511 to make the test above concrete, this relates to my comment above
This is incorrect, "its" with no apostrophe was correct. The only time it's appropriate to use "it's" is for a contraction of "it is" or "it has".
The Twig doc has been refactored on Friday. The new link is http://twig.sensiolabs.org/doc/advanced.html#creating-an-extension
It should be:

    (``symfony/http-kernel`` on `Packagist`_)
I think we should only have the caution here, just because we need to keep the main book chapter as short and readable as possible :)
指令 -> 指定
You could have separate `describe`s for failure scenarios:

    Visitor signs up
      with valid data

    Visitor tries to sign up
      with invalid email
      with blank password
Does this mean that XWQL doesn't support `lower(...)`?
Could you be more specific on how to get in sync with the `currently` supported options? Where exactly to get list of them?
why semi-colon, just have 2 lines
Turn this into a single call to `malloc()` that you free before `Start()` returns. It shows up as a lot of tiny memory leaks in valgrind now.
this will only work when name of generator is always lowercase. If that is the case you do not need to check UrlManager.
simply call strtolower on name.
Не знаю. Везде делаю через GetIcon.
Está declarado dos veces, uno en la línea 123, el otro en la línea 624.

Seguramente el segundo esté pisando la definición de este.
Maybe something more like below ?
```
      size_t typesize = int_size_in_bytes (TREE_TYPE (t));
      size_t initsize = int_size_in_bytes (TREE_TYPE (DECL_INITIAL (t)));
      size_t declsize = gen.getTargetSizeConst (DECL_SIZE (t));

      if (typesize < initsize)
        internal_error ("Mismatch between declaration '%s' size (%wd) and it's initializer size (%wd).",
                        sym->prettyIdent ? sym->prettyIdent : sym->Sident, declsize, initsize);
      else if (declsize != typesize)
        internal_error ("Mismatch between declaration '%s' size (%wd) and it's type size (%wd).",
                        sym->prettyIdent ? sym->prettyIdent : sym->Sident, declsize, typesize);
```
Yes we could change the name, however this is a template method intended to be overwritten, so the "get from session" would capture a implementation detail which might not be true for the actual filter. I see two possible solutions
a) make the name even more generic to not imply semantics: retrieveAssertion(HTTPServletRequest)
b) move the method to the AuthenticationFilter, make it private and name it "retriveAssertionFromRequestOrSession(req)

(I had the second option first, but then I saw the retrieveTicket() method and opted to mirror that). 

In all cases the change will also build the (common) groundwork for [CASC-191](https://issues.jasig.org/browse/CASC-191)
Adding! Pushing in a second!
Perhaps reduce the duplication in this block with line 107 by refactoring the call to `Call#send_agi_action!` into a method which takes the args and delegates, including this block.
please bump to `3.8.0.a3`
This will fail if the current user is not authenticated, because in this case 
```$app['firewall']->requireAccessToModule('admin'); ``` 
will return an instance of **\Symfony\Component\HttpFoundation\Response** not an instance of **\Alchemy\Phrasea\Security\Firewall**.
So the sequence of methods will be broken;
not sure what i think of this part yet.  i like it because it address cup, where if you cup a package and its not already there, it will install it.
I dont think "not found" in that scenario is worthy of a exit 1

stewing a little while.
Ah, thanks Chris!
you don't need `:search` to be `attr_accessible`. A book does not have an attribute called `search`. Rather, the Book class has a method called `search` which filters books based on a search parameter.
For some reason I like how it looks better when its calling a function, but I'll change this to a for loop.
The if above looks like it could be a separate method.
That would mean the config object should return ```Boolean``` instead of ```boolean``` otherwise StateTransferManagerImpl would not know if it was set by user or is not set and should be inferred.  Also please note this entire discussion also applies to the already existing fetchInMemoryState/originalFetchInMemoryState fields.
we only acquire locks on the main owner(forwarder). The other nodes should not acquire locks.
@galderz it's actually the former: https://issues.jboss.org/browse/ISPN-2322
Indentation in this function.
トランプのマークはsuit、トランプの数はrankで全体を統一してください。
Would this be more readable if we use np.deg2rad()?
Тут нужно использовать DOM методы/свойства, а не jquery (или другие jquery-вские методы, я их плохо помню).
В частности здесь -- previousSibling.
Потому что prev() возвращают предыдущий **элемент**, а не любую ноду.
Т.е. если перед node была текстовая нода (ну или коммент), то получится не то, что хочется.
It was part of some tests...fixed
Spelling mistake in "whether", but otherwise, lgtm. :+1:
Oops, of course!

Commit amended. Also changed other apt::params variables to be explicit about the namespace.
In checking `SparseTagOperation`, I concur with you. Please remove `immediate=true` from `SakaiDocPagePublishOperation` and `SparseTagOperation`.
"It will use"....? ;-)
Notifications go to users, so I think these two should be placed in the User and/or Group repositories.
We should probably just call this `this.userAgent_` since it's actually a real instance of `webfont.UserAgent` and not just a stub object.
Ahh, the coobooks in infra/cookbooks are public cookbooks and I just cloned the locally and copied them over. We could introduce another tool called [Librarian](https://github.com/applicationsonline/librarian) which is like Bundler for chef. I'm cool with introducing that.

Would it be better if I closed the Pull Request and submitted this as many more granular Pull Requests?
line up 'value' attr and the other ones below 'type'
getIndex()의 쓰임새가 이러하다면 List 대신 Map을 쓰면 코드가 더 간결해질 것 같네요~
cool, I appreciate any such suggestions :) - already changed it to "deploy" in a pull req
Are you sure the class "Zend\Math\Exception" actually exists, or did you maybe forget to add a USE statement?
I thought of it, but it's only one meager function.... it does seem a bit overkill to have a class with just that one single function in it...?
This feels a bit more like a tour than a description. I'm still left wondering about how all these things you mention LOOK. What kind of bridge is the Bridge of Cloud and Water, is the plaza dotted with little stone stalls or just an open space, what is the architecture on the buildings like? I think you described more what has HAPPENED to an eldritch city than you have described the city itself. Which is interesting, but not entirely on prompt (I'm guilty of most of these things too).
しまったスペルミス。。。
please change it to ``<2.5-dev`` to allow the 2.4.x serie (currently the master branch)
It does support it! :) Search for `alnum` here for more info:

http://www.erlang.org/doc/man/re.html
Still two trailing spaces in this file that I can see.
Don't we monkeypatch our forms so we don't have to do this? `|safe` is always a code smell to me.
Maybe a more descriptive variable name? :)
I wasn't sure either... the footer is "copyright 2012 SUSE", despite Studio's still begin 2011 Novell...
Jealous, we had rain all weekend! Go enjoy the sunshine :)
Да, но тогда будет выводиться имя первого тега( то есть если юзер создал пост с тегами hello и sport, то в списке появится только hello.)
I see camelcase in home.js.
(There you do not need `post` argument, because you can access post through `self`.)
I think now is okay. I deleted the file and made a new one. Github than recognized as a new file(?!) and was okay.
`onlineUsers[user.username]` is good enough.
I read about these, did some tries but did not go far. `models.User.objects(__raw__={'getlasterror':1})` always returns `[]`. I used `save()` operation instead of `update()`.
In the first commits, all the code is inside the `RandomNumericSequenceGenerator` class. However, calculating the lower/upper limits and returning a random number within a specified range, look as as two different responsibilities. For that reason the calculation of lower/upper is extracted (eventually resulting to the `RandomNumericSequenceLimit` class).

So, if I would move this method to `RandomNumericSequenceLimit` class then I would wonder if its better to go again with one class.
return std::min(1, std::min(_minTime, _maxTime));
Evtl. das ganze noch mit einem ScrollLayout umgeben, das behebt das Problem mit dem Softkeyboard dass die Sichtblockiert und dann wirds auch scrollable wenns Horizontal ist. Siehe: https://github.com/bieridee/bieridee-front/commit/2dcecee96815f8d6f8a610ddecd2a2ef32c0db9d
pull the group catch for openvz that no longer works
why ``sec`` ?
hard-coded string alert!
> You don't need shadowing to prevent global interactions, and using it for that purpose just makes for really confusing code.

Huh?  It is much more confusing to look at local code and have no idea if it is modifying something higher in the source.  I can't believe the CS community doesn't care about locality.
can you disable auto rearrange imports?
o_O nothing.
if (a || b)
Yes. Let me fix that.
You should use something like "UseRandomPort" instead of "RandomPort".
histogram2d might be the easiest to use here

or a bincount2d, similar to histogram2d without the quantize call or check what sklearn does
Okie, I'll fix it
CoffeeScript has existential operator, so we can replace `unit is null or unit is undefined` with a simple `unit?`.
设置将会添加额外参数到CFLAGS变量中。
Erm, I mean the underscore version is how it's called in pysrc and python, vs. non-underscore in the documentation.
I was thinking about this earlier.  I'm also going to need a way to specify positions.  And we do have a Position class in galsim.  So maybe I should just use that here.  Then I'd want to change DXDY to XY, but that's probably fine.
```
shift : 
    type : XY
    x : { type : InputCatalog , col : 15 }
    y : { type : InputCatalog , col : 16 }
```
That doesn't seem unclear, does it?
Hmm. entire file is a diff.  is this another line ending change?
This seems ok for now, but maybe we should open an issue to make this dynamic?
Closing when removed from parent: good idea, I'll add that.
Currently it's done more ad-hoc in JcloudsLocation and LxcHostLocation but we can definitely improve on that with a check for `instanceof Closeable` when removing the child location.

Our tests may cause problems, because we're not closing locations is those. Two things spring to mind: is GC finalize good enough for now; and we can hopefully fix the problem in one go when locations are known about by the ManagementContext (as part of a ManagementContext.terminate).
Indent this line with four spaces and you won't need the `<pre>`. Also, it might be worthwhile referring to the version as x.x.x
Of course, in Python.
Ahh, right right. ok!
plus logic in views is something we're trying hard to move away from :)
MONGODB_URI is not the only available key. For example if you use MongoLab addon on heroku, it'll be MONGOLAB_URI.
Swallowing exception (without explanation).
а хіба в блог бандлі юзається вічаплоадер?
From this line down is new code.
This line and 157 can be deleted :-)
Applied. Thanks for your note.
You know, it would be great if you do not apply indentation rules to all the files.
Зачем setAccessible(false)?
Почему нельзя - можно. Ты ведь отнаследовался.
Зачем этот new String()? Область видимости переменной можно сократить.
This works for 2 profiles. If there are more than 2, this will always select the first profile that is not the current, instead of the real "Next" one.
a new issue created on github to track this separately.
I think it'd be good to check for empty string as well.
jboss-logging ?
Any good reason to keep this commented? Can we remove this block?
if you use the default priority, you should omit it IMO
Feel free to remove the case-insensitive matching. I've cleaned up the inconsistency in my uiAddContent branch.
I would cache the `options[:template_framework]` and `options[:template_engine]` in local variables.
Actually, np.resize would do it. But anyhow, this function is not used in the code, so you can probably remove it.
The `6.` is weird. Better use:

    a = np.array([[1, 2, 3], [4, 5, 6], [7, 8, 9]], dtype=np.float64)

to enforce a float dtype.
maybe @wslihgt can also give us a hand reviewing the code :)
can you please inject this in the constructor? that means have the same constructor as Sonata\AdminBundle\Admin\Admin but add a $locales parameter to the end, then adjust the configuration of Resources/config/multilang.admin.xml to pass that parameter in. (the code in the extension can stay the same). for the sake of consistency, i would call the value symfony_cmf_content.multilang.locales
this line should return the body and resp as well.
I'm totally cool with improvements to clean-up whitespace and otherwise improve middleman-deploy in respect to standard ruby best practices, but these should be in another pull request.
"nvm" => typo ?
This should really be its own file, rather than an embedded string. 

I know there are other tests that have it this way, but they are slowly being changed over.
Leave as an error
include v8.h will likely not be needed anymore once `retrieveDate` is moved out of this class
the apidoc update documents a click event but i don't see any event handling/forwarding done for this class.  How is that accomplished?
This is a tricky one. While it is returning a value, the template is passing a reference therefore it could affect a field withing the object.
You are right: *handle* was basically a remnant of my application that made it into the test file, since in my app I only allowed 1 connection at a time.
Creating multiple connections should be just fine: just strip out all references to handle and use *arg0*. I'm not sure what the default backlog is: I think it is 50 or something, but the base *WebSocketServer* doesn't set it when calling *bind*, so there may be something there that prevents multiple connections.
an example of a strange comment formatting in the diff
This is already set in commonsetup.cmake - should not be needed here
numRows isn't used in this context, other than where the base CThorExpandingRowArray::clearRows() called during construction.

I am only maintaining here for the base class. I thought about not deriving from CThorExpandingRowArray for this reason+others, it is sharing the ptr array allocation routines mainly.
I would rather not place the onus here on becoming a voting member or somehow imply, as this text does, that being a voting member is the only way to influence PSRs - as we have shown over and over again, PSR are often greatly influenced by non-voting participants (let's just call them FIG community members). Active participation is far more important than voting rights.
Hi @alexsdutton 

First off nice hat.

This case statement should be moved to a params class and you should use the osfamily fact instead of operatingsystem.

You should also make a variable for the ruby postgres class and maybe move it to a separate class.
Is there some reason this is in getMediaUrl instead of in getMediaList? If it's in getMediaList, then the disabling/enabling logic is closer together and easier to maintain. If this is because you want to make sure the api call to get the actual media file works, then this should be in the success handler of the ajax request.
`Copy these files`
Actually, the current my/course_sites feed _does_ use mixed case as shown. I based my implementation squarely on "dummy/myclasses.json".
`(and (<= x1 x3 x2) (<= y1 y3 y2))` already returns a boolean so no `if` is needed.
`(> (author-count book) 1)` ajaa saman asian
Just a test, can you receive this? 

-----Original Message-----
From: joeg [mailto:reply@reply.github.com] 
Sent: Friday, May 04, 2012 10:43 AM
To: Justin Yu
Subject: Re: [azure-sdk-for-java] java iaas change (#1)

> +    @DoesServiceRequest
> +    public final void copyFromBlob(final URI source) throws StorageException {
> +        this.copyFromBlob(source, null, null, null, null);
> +    }
> +
> +    /**
> +     * Copies an existing blob's contents, properties, and metadata to a new blob, using the specified access
> +     * conditions, lease ID, request options, and operation context.
> +     * 
> +     * @param source
> +     *            A <code>URI</code> The URI of a source blob.
> +     * @param sourceAccessCondition
> +     *            An {@link AccessCondition} object that represents the access conditions for the source blob.
> +     * @param destinationAccessCondition
> +     *            An {@link AccessCondition} object that represents the access conditions for the destination blob.
> +     * @param options

Need to make sure Uri is encoded, use Utility.SafeEncode

--- 
Reply to this email directly or view it on GitHub:
https://github.com/justinyu/azure-sdk-for-java/pull/1/files#r775654
Nevermind, I'm crazy. `rake scss` just needed to be run.
A working spec test will be dropped back in when the rest of patches are merged to provide full functionality.
assignment should be aligned
devops track as well
Didn't know that, I am happy to take it out.
There really ought to be a ```Scanner::Udp#new_udp_sock``` or something to do this.  These lines are cumbersome and copy-pasted all over.
Shouldn't this be ARCH_X64 with no quotes? That is what is returned above in session_arch
Having a rescue here seems a good idea for me, but you're handling exceptions also in the "execute_command", "get_output" and "cleanup_after" methods. In the handling request you're doing in these methods, sometimes you just "return", so here you are not aware of errors... and you can execute both three methods even if one of them fails. See #1011 for an exemple of such situation :)

Please, feel free to ask again if my explanation isn't understood :)
Ah, I see what you mean.  Yes, we'll have to load it manually, using something like ``np.load(os.path.join(skimage.data_dir, 'hand.npy'))``.

Or, we can update the data module to also include "hand" as a data method--maybe this is the way to go.
let's

But really, "log the time we updated" is maybe better? Sorry, nitpicky.
I submit that we should always be ok with going against our own guidelines when it makes sense to do so.  They're just guidelines.  Anyway, sounds like it's a moot point. :)
I mean `computeWindingOrder2D`.
We can probably get away with a 1x1 white texture for this.  We could actually use this elsewhere like the material system scripting.
there is already an existing functionality that does this. Please look at the Point.js. Let's try to avoid situations like this.
Yeah, it's the capitalization of `linux` vs `Posix` that tricked me.
**Before**: if the input object did not contain "received_time" or "start_time", the deserialized value would be ```default(DateTime)``` - equivalent to ```DateTime.MinValue```.
**After**: in that condition, you'll get a NullReferenceException, since ISO8601ToDateTime returns null.

If you can guarantee that the server will *always* send those members in the JSON object, then you're fine. Otherwise you should account for that case as well.
This test needs to be updated to be 125 instead of 150 as per this PR: https://github.com/appcelerator/titanium_mobile/pull/2371/files
eventObjectForScrollEvent will not know about scrollview. Might need to pass the scrollview as an argument.
If this is now requiring modal flag, the next if check will always be true. Is this an or compare, or should the if statement below simply run its contents?
heh, most of copied that out with the "Copyright" notice.
Neither of these are used, remove them.
Could I persuade you to move the function to Map.js while you're at it? Putting the code here was a very evil hack that should never have made it into production.
The reason why your code works is that the code (pre my request's modifications) utilizes the `storage` object which is wrong – it ties the implementation to localStorage which makes it unusable for sessionStorage.

When you call `proto.incrby`, `incrby` uses `proto.get` (line 82) which then uses `storage.getItem` not `this.getItem`. In the correct case of `get` using `this.getItem` your `incrby` would then trigger the proper illegal invocation (because `get` sees `this` as the prototype object).

We should merge my changes first and then adjust the references in your code accordingly.
Maybe better use a QUrl.
...and leave these as they are shipped by Glance.
I hate inline comments. Either remove them or extract this logic into another method.
Your comments in the PR discussion are clearer than this comment. "handle the return in a generic manner" left me rather confused. "By default, return a generic error on stateless events. " is much clearer. Any chance the comment can be clarified?
shouldn't this last else be: else if( settings.useStencil ){ ?
-1 for mixing force_encoding method into ruby 1.8.  i've run across gems that check for `responds_to?(:force_encoding)` to perform special logic.  i would rather add something like this to the OpenToken module.  otherwise it looks good!

```ruby
module OpenToken
  private
  def encode(string, encoding)
    string.respond_to?(:force_encoding) ? string.force_encoding(encoding) : string
  end
end
```
Do you have a separate PR for the ChangeLog.txt, like exists in Node and Java? Or is that not expected in PHP?
backend_version = self._get_version(versions, Versions.UPSTREAM_SERVER)
Did you see `// ...` used in another project for Composer examples? I think we can do without it, since it's not valid JSON and it should be obvious to any developer that they're adding a dep rather than replacing all existing ones. I think the same applies to bundle registration.
It's already parsed into ruby hash - then i check what kind of level i should apply to each message
Why do you need to add the Velvet sources here, while Velvet is also a dependency?
What's going on with this indentation?  Do you mind fixing that?
Why this is necessary? You already override `TypeInfo.type() `in `TypeInto_Array`. Is this redundant, no?
Also `TypeInfo_Ar`, `TypeInfo_Aq`, and others.
The issue is that rt_init and rt_term have been used outside of druntime
for quite a while so we have no way of updating that code.

>It should be source compatible, but it's probably not binary compatible.

Yup, adding another parameter will change the argument registers.

By the way dylib_fixes.c is already broken because it declares `char rt_init()`, i.e. dg is passed uninitialized.
Any particular reason it's not `@safe`? In any case, I think it's better to mark all of them `@trusted` to give the runtime as much freedom as possible without having to break the ABI in the future (`@trusted` and `@safe` have different mangling).