labofsahil/github-event-dataset-2012 huggingface dataset:
It'd be more idiomatic to either use a custom exception here or to raise with a string, eg.

````raise "Failed to create Zendesk ticket"```
I'd go with the latter. Though I might be inclined to go with a tuple of tuples.
coffee style guide prohibits `unless-else`, reverse `if-else` looks cooler
I do not think it is wise to assume where the WSDL is located and what is is called (`$this->wsdlUrl . '/moreinfo.wsdl'`) although I'm aware of the fact that it is the case in Ding 1.8.

Instead I think we should prompt the user for the WSDL url.
Added the following:

    /**
     * Transforms the geometry from its current crs to {@link DefaultGeographicCRS#WGS84}. If the
     * specified geometry is already in WGS84, then it is returned unchanged.
     * <p>
     * The method {@link CRS#equalsIgnoreMetadata(Object, Object)} is used to compare the numeric values
     * and axis order (so {@code CRS.decode("CRS.84")} or {@code CRS.decode("4326",true)} 
     * provide an appropriate match).
     * @param geom
     *            The geometry to transform.
     * @param crs
     *            The CRS the geometry is currently in.
     * @return The geometry transformed to be in {@link DefaultGeographicCRS#WGS84}.
     * @throws TransformException
     *             If at least one coordinate can't be transformed.
     */
ps is set but not used
Please use double-quotes like the rest of this file. :)
Hum that's weird, it shouldn't work and it doesn't work for me.
Because of cross-sandboxes/compartments values, exc is never a instance of SyntaxError.
It is an instance of `sandbox`'s SyntaxError.
We should do something like this instead:
`} catch (exc if exc.name === "SyntaxError") {`
I totally agree. I used iterator to match existing window-utils iterators.
I removed it in favor of an array.
This makes a dark band appear in the footer.  The top half is dark, the bottom half is light.
Change from a "static" pseudo-global primaryVerificationInfo variable to an object instance.
Similarly, I think `get_unprocessed` is a misleading name here - something like `get_claimed` would be clearer.
still not sure about the kwargs here, and the separation/wrapping around `dprime_from_samp` -- do we have to make it that difficult/over parametrize for such a simple, not often used metric?
From the semver spec:

```
Bug fixes not affecting the API increment the patch version, backwards compatible API additions/changes increment the minor version, and backwards incompatible API changes increment the major version.
```

Even though Hiera `1.1.0` would have a backwards-compatible API, the assumption under semver is twofold in that:

* 1.1.0 may add new APIs that don't exist in 1.1.0
* 1.1.0 would contain the same bug fixes that are in the latest 1.0.x bug release that don't alter the API

In practice, you'd want to bump the minor version of Hiera when you'd bump the minor version of Puppet: to take advantage of new APIs and functionality while maintaining backwards compatibility of existing ones. The same would apply to Facter here.
The v1 API isn't supported with Eureka. AgiApp consumes Agifog directly so isn't affected by Eureka state. We don't want to register v1 API with Eureka in any case.
@justinko I think stub_const is different enough that it doesn't need to be constrained by double's API. I'm OK with your suggestion (which doesn't align w/ double IMO) to return a StubbedConstant object with the original_value hanging off it. I also like @myronmarston's idea of yielding when the constant was previously defined. It aligns with ActiveRecord's `find_or_create_by` APIs. I'd like some other opinions @alindeman, @patmaddox, @spicycode.
> I think stub_const is different enough that it doesn't need to be constrained by double's API. I'm OK with your suggestion (which doesn't align w/ double IMO)

Yeah, `double` was a bad example. `should_receive` returns a `MessageExpectation`. Just because `stub_const` doesn't have an explicit receiver doesn't mean it shouldn't be consistent with RSpec's other "mocking" methods.
If the lengths are not equal, there is no reason to go trough each args
`'' + item` is shorter than `item.toString()` :)
Actually, I think it's because you've probably forked the project quite some time ago, and haven't pulled the upstream changes, and some of the things that have already been fixed are now undone. I've noticed all the trailing spaces are back in the code too :smile:
Same reason as above (Dreamweaver stubbornly stripping out a couple of accents upon save).
The change description could be actually better ;)
This looks like you want passwords to leak.
Yeah that would be an option. It doesn't solve everything as other ErrorHandler:start/stop guarded calls might cause the same problem but for that specific case it would do the trick. I'll check with the rest of our team for feedback as well.
I think that is possible to be more concrete here, string|\Zend\Uri\Uri
This should not be skipped. As a new component, we should be making sure these run.
It's easier if we do it without constructors, and also means it could theoretically be attached to multiple SM instances.
For the templating, should I still overwrite the file with a templated version, or should change the copy in the repository and link it to the right spot?
i forget to remove the static
This should be `instanceof static::$_classes['entity']`, and you can move the `use` declaration to `$_classes`. Also, I think you can rewrite this deeply nested structure to be simpler if you [return home early](http://debuggable.com/posts/programming-psychology-return-home-early:4811de9f-ae28-49c2-a7dc-2f154834cda3).
@nateabele Have a look at the library logic in Dispatcher::applyRules
Remove the `item` class. Not needed.
Don't need a constant here either.
it still tells me:
No handlers could be found for logger "pelican"
Je ne vois pas trop comment ça peut marcher, tu passes 2 arguments à ```outputZip``` alors que la signature de la méthode en prend 3. J'ai loupé quelque chose ?
This a drive-by fix to enable RST specific checks.
i dont think we need reversing really, it would be pretty weird to specify them in reverse IMO
What does this do on unsupported browsers? It may be better to do something like if ( window.sessionStorage && ... ) instead.
_canPlayType( container, url )_ is there supposed to be an _ at the beginning and end?
Why only on create?
This is probably easier:

```ruby
validates_format_of :link, :with => URI.regexp(['http', 'https'])
```
break long description
Hi Ken, all,

On Mon, Sep 10, 2012 at 7:29 PM, Kenneth Hoste <notifications@github.com>wrote:

> What I did say is that you should try to keep pull requests manageable in
> size to review, i.e. a maximum of, let's say, 10 easyconfig files at a time
> in this context.
>

Good to hear that, it makes the whole thing much much better to go through.

> Combining easyconfigs that belong together in some way (e.g. form a
> dependency tree/graph together, or are the same type of tools), makes sense
> and makes it easier to review things.
>
Exactly, that makes a lot of sense, also from this end. This better be
explicitly said in the contrib policy.

> Just so we're clear: we appreciate you're actively contributing your work,
> we just want to avoid ending up with a huge mess. ;-)
>
Indeed, I fully agree :-)

I certainly enjoy the contrib cycles, just remember I am learning with you
guys;
it's only last week I've been able to get my git branch herding in some
kind of control!

btw.
I come to realize that I should rather not spam you too much this period
with serial pull requests,
since v0.9 is such a high priority this period. (I m fond of #99 and other
such blockers especially).
So, let's make this proposal: any easyconfig pull request is "lesser" than
main easybuild contribs.
Let's keep our focus on the major stuff.

cheerio,
Fotis
Oh, sorry, I see now; the postfix isn't an option in the assert_ style. I retract my profanity.

I still suggest that the API awkwardness is trying to tell you that there may be something wrong with this feature, though.
multiple lines. =) Also, please remove the extra spaces in between the (). Try to follow the existing code formatting rules. I know it is banal, but keeping things consistent is really important and I'd just have to modify this myself...
I would leave this question to @ashughes1. But personally I don't think we should start messing around with the priorities here. ESR10 will go away soon so we would have to revert the priority of ESR17 again. Doesn't look worth the time given how fast we run the tests.
you should drop the padding between the `(` and `function() {`

This whitespace issue is present in several other places, please fix those up as well.
Comment above this to explain why you're caching.
If we were being all nitpicky about it, the "down" (reverse) migration would be:

<code>rename_column :skins, :font_size, :base_em</code>

;)
TIL

I'll remove this.
呼び出すたびに異なるパスが返ったら、キャッシュの意味がないような?

    @cache_path || Dir.tmpdir

とか?
Under 1.9.3 tests fail with those lines present. Considering that RRDtool
this is the only use of RRDtool in foreman and that it's vintage and not
being maintained (doesn't look like it?), not sure it's worth the effort to
spend any amount of time on getting RRDtool to build under 1.9.3.

On Wed, Oct 24, 2012 at 12:42 PM, Ohad Levy <notifications@github.com>wrote:

> In test/fixtures/report-errors.yaml:
>
> > @@ -17,9 +17,7 @@ metrics:
> >      basedir: /var/lib/puppet/rrd/my.sol.client.com
> >      label: Time
> >      name: time
> > -    rrd: !ruby/object:RRDtool
> > -      rrdname: /var/lib/puppet/rrd/my.sol.client.com/time.rrd
>
> should we merge without this part?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/foreman/pull/193/files#r1927280>.
>
>
I'm not sure how you would get to this stage without having a vm object?
also, can you add a test which detects that the squid_url is available to the template?
imho this logic needs to move to lib/fog_extensions/openstack/server.rb
you're referring to "sender" inside a Future callback, big no-no
(2-2)*x is always 0, so why include this?  Can also simplify some of the other math here
I think the only place where the endPt variables are used are in the graphie sections.
I'm kind of new so I don't know much about general coding practices or efficiency, but is it generally a better idea not to define variables if they're actually constants and can be subbed in the code?
return firewall_list()
Provided product attributes are irrelevant and not used, we can very likely remove this whole thing!
Can we just move this up to L43?
No, problem, i will do it asap.

On Sun, Jul 8, 2012 at 8:53 PM, David Chambers
<reply@reply.github.com>
wrote:
>> @@ -17,6 +17,8 @@ responder = (fn) ->
>>  app = express.createServer()
>>  app.get /// ^/card/(\d+)(?:/(\w+))?/?$ ///, responder api.fetch_card
>>  app.get '/card/:name',                      responder api.fetch_card
>> +app.get /// ^/lang/(\d+)(?:/(\w+))?/?$ ///, responder api.fetch_lang
>> +app.get '/lang/:name',                      responder api.fetch_lang
>
> I'd prefer to use "language" in full in the URL patterns. Do you mind making this change?
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/davidchambers/tutor/pull/17/files#r1119850



-- 
The lights then came up and the crowd erupted in applause, because
that's what the crowd does after it watches destruction on a large
screen. -- Ben Kuchera, Modern Warfare 3 review.
Fixed a bug where a grid with only 1 column would never initialize properly.
I added the option check, but why shouln't I use `strval`? Option names are strings only...
typedef на тип внутренний. Ну длинный же он. зачем его два раза писать?
references to SQL2 should probably be stripped from this class
I think fetch already raises, doesn't it?
This should `jQuery.extend()` and not redefine the basic colors. In addition to saving bytes, it won't clobber any custom additions that have already occurred.
Who needs to access this?
Why are you caching this?
Also need to var it, because now idField is leaked to global scope.
Labelling this one with `first_` is a bit restrictive. We should make this return the list of all *addon flyouts* in the region and then we can pick out the first one using the array/list reference.
https://github.com/pculture/vidscraper/blob/develop/vidscraper/videos.py#L405
README is been referred from existing unified_tomcat branch. Above link is part of that.
The functionality in here should probably be pushed into an api function. wdyt?
Would it make sense to use a different schema for running our tests? At least we'd be sure that we're not adding data to the actual UI or worse, deleting data when cleaning up after the test.
I think `context.isAdmin` will send a db request, that possibly will not be needed if `context.user().id === principal_id`, right? If so, we should probably perform that check first, and isAdmin only if necessary.
Yes exactly. We can have node-gyp do the whole thing. I can reenstate them though if you feel more comfortable with them around.
With node-gyp you post the following command:

 node-gyp configure build 

just like node-waf, once upon a time :)
Done. Merging now.
Mention the version of Liferay in which the feature was introduced and breakup the sentence. Example - "The concept of the Canonical URL is new in Liferay 6.1. A Canonical URL is a unique URL for the articles that will redirect the visitor to the default display page of the article."
This will make the app compatible for those that have installed current
version and log them in automatically so they don't see any real difference
in that respect unless they log out explicitly.

On Thursday, December 20, 2012, Jason Smale wrote:

> In app.js:
>
> > @@ -59,6 +65,9 @@
> >        var firstLoad = data && data.firstLoad;
> >        if ( !firstLoad ) { return; }
> >
> > +      this.store('email', this.settings.username);
> > +      this.store('password', this.settings.password);
>
> Should this be done by default? Does username and password need to be
> required anymore?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendesk/harvest_app/pull/3/files#r2474263>.
>
>
I'll cleanup and follow this up with @liulikun
The main difference is that you now don't have local timezone, but you can still use GMT, If "local" is needed, I could get the local timezone and set it to a constant, maybe, and then use it as local timezone, but I think is not a "pretty" solution.
ACK

On Nov 15, 2012, at 7:41 AM, Andrey Andreev wrote:

> In user_guide_src/source/libraries/javascript.rst:
> 
> >  
> > -Initializing the Class
> > -======================
> > +Configuration
> > +=======================
> These should have the same length as the title itself.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
...because it's the (protected) constructor itself that prevents creation of a second singleton. Without it, we'd have no... well... _protection_. (LOL)
Именно так. Уже читал про description
Работать с ссылками умеем. В данном случае сравниваются две строки NSString, которые возвращает метод `genomeAtIndex`.
Из-за этого совсем не понимаю, зачем нам нужен static NSMutableArray *intArr
whoops, yep. the downside of doing !true is that it recurses the tree through nodes that can't reference the arg specified unnecessarily (there should be no functionality side effect, just efficiency). fixed this
Is SECT_INSIDE better?  Or should the statement be removed entirely and allow a floor to exist in any sectors we didn't define in the preceding lines?
Restored the JSDuck docs. I like to stick to a certain style (which is accepted by both Closure Compiler and JSDuck), in which I use lowercase for the JS primitives and capitalise the first letter only for non-primitives. This is the way it tends to be done within Closure Compiler examples, and JSDuck also outlines it as acceptable.
I think anyway, might have to refresh my memory on the ordering logic in sidekiq.
how about call `page:reflow(kc, render_mode)` in `KoptDocument:getPageDimensions(pageno, zoom, rotation)` and put `kc` into cache, so `KoptDocument:renderPage` can get it from cache?
I would store the query results locally. So something like

```javascript
label = $( "[for='"+ controlID +"']" ),
labelID = $( "[for='"+ controlID +"']" ).attr( "id" ) || controlID + "-label",
```

...

```javascript
label.attr("id", labelID);
```
I'd rather be able to pass a node_angle or a node_layout that would be returned by a function (basically the code you have above). You could avoid the start_pos parameter.

also rename n_draw to n_lines seem more explicit to me.
Sorry, I mean pairs of epochs.
When you are programatically creating a project eg. https://github.com/mobify/mobify-client/blob/version-7-tag/test/integration/server.coffee#L37

You want `filename` to be resolved relatively to the CWD.
Add headers to the response.
That was intentional. Please revert.
Original committ: https://github.com/openmrs/openmrs-core/commit/6d482f2613b8e969fbd600ca541e40055cd25d8f and ticket: https://tickets.openmrs.org/browse/TRUNK-3706

http://en.wikipedia.org/wiki/Byte_order_mark
It works the same way as a params array in C#. It let's you call 

    serialize(a, b, c, d)

instead of having to explicitly box them in an array.
Indead it's a good idea to remove this…
remove the space between `class` and `;`
Should be a bash code block too
针对任何地址
->
针对任何路径
Sorry for the delay. I can't think of any other way to do this either. Mind cleaning up that one whitespace issue and I'll merge?

Thanks!
Is it really necessary to use '*' before each line of a multi-line comment?    What is the justification for this?   It creates some hassle in creating long comments so that one is less inclined to type and edit a long comment.  

I would rather get rid of this requirement.
This seems to work. I tested mysql, mysql2, postgres and sqlite as those are what I have. I would imagine that this shouldn't introduce any major problems with the others since it's using existing rails behavior to add the indexes. Can anyone confirm?
here and elsewhere, why not use `if isinstance(q, Pow)`?
as task_id is the primary key, there's no reason to limit 1
 
by the way, the select could just be done on task2.task_id, then perform a rowCount() instead a fetch
I did it that way because others told me doc processors do automatically a strip of empty lines and gets cleaner, so i should do this way. I don't know, but makes sense. In any case, i have fixed it but needs to read about this topic...
Nope, it just happened that my commit contained these changes and I created a pull request from it. You only need to change layout_methods.rb
lets set this to Aug 1.. 2012-08-01
Big, commented out block?  Why?
Usage of debug...
Since these are set differently depending on the `describe` block, they should be declared separately within each one.
@pelson Yes, yes, yes. Yes a thousand times. The community could learn a lot from specific use-cases such as those of @chdemars. And this is a __much__ more valuable asset than adding 7MB of data to the repository.
These two lines look identical. Am I missing something, or is it just `diff` being stupid?
It's set to `None` right above.
Might not be needed if the wait for condition flow is used
This file has been removed :)
The off-screen map does not display the buffered tiles any more when the target map needs them, so the target map will be using the image elements after they were created by caching content from the off-screen map. @mpriour can chime in with more details here.

Now to the question what "map uses a cached tile" means: the cache is merely a collection that references <img> elements. These <img> elements will be reused when a tile needs an image with a url that matches the src attribute of a cached <img> element. @elemoine, catch me on IRC if you need a more detailed explanation.
It's also OK to split the string onto multiple lines. E.g.:

```
$foo = __(
    'blah blah blah '
    . 'blah blah blah '
    . 'blah blah blah'
);
``
Can we make a reusable function out of this and the same functionality on line 287?
For sure, that's interesting, my editor is showing 4 spaces. I'll check what's going on here.
And I think the logic here is the reverse of what you want. The `!` operator is going to bind to just the first of these two terms, meaning that only `Group`s will pass to the second term, which will throw a `ClassCastException`.

But that's just me reading this. The way we _really_ tell is with a unit test. :-)
Missing space after the `if`.
html 5 有 <footer> 可以用
所以就不用 class="footer" 了
詳情可查 w3c school
(+) resolved merge conflict
shouldn't this be a check against `None`? As written, `netPropagate=0` will fall back to using `self.netPropagate` rather than overriding with false
Ok, I'm fine with it then.
Should the type for parameter ``$activationStrategyOrPriority`` not be ``ActivationStrategyInterface|integer|null``?
reverted back as suggested to original (without properties) and not added delete statement. Actually this is not breaking the code - only if we try to change or work with this properties we need to check for them.

This was my initial test modification so this was not needed to separate.
no, it's the opposite: Large-Scale used to be enclosed in its entirety
because we enclose(d) words with capital letters in non-initial positions.
Treating something following a hyphen as whitespace takes care of that.


On Fri, Dec 14, 2012 at 12:44 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In BibTeX.js:
>
> >  		// I hope these are all the escape characters!
> > -		//First escape all curly brackets in the Zotero fields, then do the mapping/replacing of other characters
> >  		value = value.replace(/[|\<\>\~\^\\\{\}]/g, mapEscape).replace(/[\#\$\%\&\_]/g, "\\$0");
> >  		// Case of words with uppercase characters in non-initial positions is preserved with braces.
> >  		// treat hyphen as whitespace for this purpose so that Large-scale etc. don't get enclosed
>
> This is something that we're not doing, but I'm also not following the
> example that's given. Does it mean to say that Large-Scale should be
> enclosed as in Large-{S}cale?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/adam3smith/translators/pull/3/files#r2424579>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
I'm guessing these are from dartlang.org? Maybe add a comment to that effect so we don't inadvertently diverge.

Otherwise, if these are specific to us, why not nest them all inside a single .highlight {} instead of repeating that over and over?
Вспомните, что такое инкапсуляция.  Мне так кажется, это ее нарушение
How would you do it?  I still haven't done much with late static bindings, so tips are welcome.
Please add @ since 12.2
Good spot, I will look into it

On Thu, Jun 28, 2012 at 10:11 AM, Piotr Szmyd <
reply@reply.github.com
> wrote:

> > +             }
> > +
> > +             public override IEnumerable<object> GetServices(Type
> serviceType)
> > +             {
> > +                     object result;
> > +
> _lifetimeScope.TryResolve(serviceType.MakeArrayType(), out result);
> > +                     return (IEnumerable<object>)result;
> > +             }
> > +
> > +             IEnumerable<IComponentRegistration>
> IRegistrationSource.RegistrationsFor(Service service, Func<Service,
> IEnumerable<IComponentRegistration>> registrationAccessor)
> > +             {
> > +
> > +                     var result = new IComponentRegistration[] { };
> > +                     var serviceType = service as TypedService;
> > +                     if (serviceType != null)
> > +                     {
>
> This should be changed to GetServices(...), as there can already be
> multiple registrations for a given type.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pszmyd/SignalR.Autofac/pull/2/files#r1066532
>
I don't think it will even catch thrown IException *'s
No I wasn't aware its generated file. 
What we do to make it as a library in @auraphp is keep an `src.php` at root level which will require all the necessary files if needed.
If they have a PSR-0 autoloader or are using composer it works in a charm not including `src.php` itself .
I have seen https://github.com/crodas/Autoloader#how-it-works  Probably you are using one among it .
Plese indent all in the same way as it was before (and block/tag, template or HTML, is indented).
In general it is better to return `None` in such cases.
> Maybe we shouldn't really store all data to make things faster?

No. :-)

But it is really strange. We do not have so much data to store. This is strange.

Hm, or it is. 32k entries? Where from???
And define another form just for changing password. You can also define another view for that. Under `/account/password/`.
For JavaScript, I recommend you to run some JavaScript lint tool over it. Will tell you even more JavaScript recommendations than me. :-)
No need for this to in a separate file? We will not have notifications on other pages? Or will we? Hm, maybe. :-)
LLVM intrinsic externals need the `llvm` attribute so they will be codegenned as LLVM intrinsics rather than as C functions:

```
private external ("llvm.x86.sse2.sqrt.sd", llvm)
    x86_sqrtsd(a:Vec[Double,2]) : Vec[Double,2];
```

The externals in math/simd/simd.x86.clay should use the `llvm` attribute too.
Why use instance variables as opposed to local variables?
See https://github.com/cloudmine/cloudmine-ios/pull/23/files#r1299092
maybe having in the ini the setting

     [circus]
     backend = gevent


instead of testing on import would be better ? or do you think it can wait next release?
I saw the discussion and see What @gakuzzzz want to say.   Merge it.
That's correct, I tend to follow these strict guidelines with the public APIs, `Utilities` is internal class that I just use for myself. IOW, some people consider me extra careful because I'm covering these things.
not clear to me: does it make sense to allow for rank deficient exog in sysreg?

I guess answer is yes for the multivariate model, I'm not sure about system of equations

(main reason: calculating rank is not cheap)
I was looking for a good example that I can use in Stata, so I only have to read a very small selection in a textbook instead of cover to cover.
Now I remember: 
I actually have a Stata script for survival when I started to learn Stata, however with a standard Stata dataset, not with one that's in statsmodels. I need to check my Stata working directories.
full name ``weights``
а, тфу, не заметил про create. может прям сверху будем делать глобальный ucare, в CLI-то?
I just started to implement this but then realised, after having to remove const-ness from the getHalfLightRadius() function and from the pointers to that pimpl implementation, that it would surely be a breach of SBProfile immutability?  Is this right?

Either way, I'll go back to the current system for the time being.
No particular concern, but why the change from 1 to 1.8?
Also, is there a reason you are looking up via slug instead of just video=video?
AbstractSoftwareProcessDriver.java has an implementation of kill that delegates to stop (but no warning currently). Various things override this, where implementing kill is straightforward.
Will add some javadoc. Too lazy of me not doning that in the first place!
certes mieux
I understand. I will do so.
This patch was quick, indentation was changed to non const since preserveIndentation flag could modify it.
Ok. What is strange is that _loadViewTemplate is called at a slightly different place but 
- I did not touch the tpl = "app" + tpl code
- It was already called for all views in previous version!
Anyway I will look into this thanks for pointing out.
If you don't incude tests, remove this dependency too, please
I see you changed this from "what happens under the hood" to something that describes the intent.   Should we surface what's under the hood?  Maybe not at the stakeholder's level
Isn't better to put it in the model to get more flexibility in the future? Due to I have to make a migration in the future as the way you say
Hmh. Good question. I may have moved some code around in the latest versions making this declaration no longer needed
"behavior changed"
woopsalert.
should this not named as downloadArchiveUrl (abbreviatons URL should be named as Url in camelCase)?
It'd be nice for this to include the message object in the failure so the developer can get more detail.

Also, there's duplicated logic in `message.is_a?(String) or message == nil`.

So, I think it might be best to change this to a method like:

``` ruby
def verify_message_is_a_string(message)
  return if message.is_a? String
  raise ArgumentError, "The passed expectation message was not a string, " +
                       "but only strings are supported. Message: #{message.inspect}"
end
```

Then call it with:

``` ruby
verify_message_is_a_string(message) if message
```
Sounds like an `uncheckedRestartSplunk` to me.
I think it adds more complexity than it's worth. log_duration is a very cheap function, and takes basically no time compared with the HTTP round trip. It logs at the debugging level, and enabling logging of that level is explicitly setting a debug variable.
Why call it "agent_params" and only put it in server.pp? Do you not want it in init.pp too? If you don't, your example in the commit log doesn't work...
I think it would make more sense to print out m_icon.isNull() instead (and then also iconPath as received from the resolver), then you can skip having the if() altogether.
The improvements under -server can be dramatic depending on what you're doing. For anything that will take longer than few seconds, there's little reason to not have this flag set.
As in,  this line to....
А можешь тогда питоно код убрать с проекта чтобы я смержнул?
You can leave off the # node_attribute thing at the end... we'd like to get rid of all that stuff eventually...
А это значит, что если строка args содержит " , то нужно экранировать её?
Right. So your comment doesn't relate to "localhost," it needs to tell the developer that the test must run from "a web server."
Yep

--
Paul Furgale


On Wednesday, August 8, 2012 at 17:04 , neunertm wrote:

> In sm_eigen/include/sm/eigen/serialization.hpp:
> > @@ -69,7 +69,7 @@ > Eigen::Matrix<Scalar,A,B,C,D,E> & M, > const unsigned int file_version) > { > - int rows, cols; > + uint64_t rows, cols;  
> Is ist the same for the code above (line 46/47)?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/furgalep/Schweizer-Messer/pull/7/files#r1333012).  
>  
>  
>
Here we don't need the if, <code>return self.is_element_visible(*self._app_expanded_description_locator)</code> is enough.
we should make the methods below here private.
Ah, now I recall, the python-software-properties package was added to fix 'add-apt-repository: command not found'.

Doesn't seem to be a requirement any longer, since we are just appending to sources.list.
Hm, I've come to the conclusion that with the center of mass implementation we also need a loop over all coordinates to suppress peaks with the same value... so, I don't think it think we benefit from restructuring the logic in the loop. I also doubt we'll have speed improvements with your implementation as there are in general very few peaks (comparatively).
This will fail if X is not an array (eg for lists).

Also, I think that the error message could be a bit longer: 'X should be a vector (1D), but a shape of %s was passed'.
> I could link to the scikit-learn doc on this or a wikipedia page?

Link to the scikit-learn doc, which should itself link to wikipedia.
I would make ``learn_rate`` lower case, as this is a literal quote. Maybe start the sentence with "Here" ?
why is there a different amount of samples for each problem in model selection? ``StratifiedKFold`` shouldn't do that, should it?
Why #including exceptions twice ?
I get extra newlines with this commit if I do the following:

```python
import pybedtools
a = pybedtools.example_bedtool('a.bed')
b = pybedtools.example_bedtool('b.bed')
print a.cat(b, postmerge=False)
```
```
chr1	1	100	feature1	0	+

chr1	100	200	feature2	0	+

chr1	150	500	feature3	0	-

chr1	900	950	feature4	0	+

chr1	155	200	feature5	0	-

chr1	800	901	feature6	0	+

```
Shouldn't the message read: "the final state should not have exited"?
Add a comment saying what algorithm you are using here.
Small issue regarding the comments.  We're not coersing an existing object.  We're creating new objects.  If we were to coerse the object, we would change object's prototype.
openURL already not part of app.js and doesn't prevent us from running KS. Also we don't have browser for now. That's why it leaved for near future.
Ton problème vient de là.
Tu as deux  routes en POST avec la même adresse   (/bugs).
La méthode editBug() tu dois y accéder en GET en plus.
Et du coup tu auras deux routes en GET avec la même adresse (editBug() et bugs()), donc faut que tu changes la route de editBug().
Exemple :   GET       /bugs/edit/:id               controllers.Bugtrackers.editBug(id: Long)
Good point. Because an earlier version wasn't passing CFLAGS to the libjs.a build below so I piggybacked on CC. Then I needed the '-fPIC' from CFLAGS to get through as well, so I did the right thing. Will fix.
While this approach is quite flexible, it would be easier for the end user to have some config to change instead. The event could still be there, but some factory should be probably used in a default listener for this event, so that the user could benefit from a simple array like

```php
<?php return array(
    'doctrine' => array(
        'drivers' => array(
            'Some\Namespace' => array(
                'type' => SomeClass::ANNOTATION_DRIVER, // or 'annotation', I just prefer having constants instead of magic vars
                'options' => array(
                    'paths' => array(
                        'my/first/path',
                        'my/second/path',
                    ),
                ),
            ),
        ),
    )
);
It could use getFirstActivityArgument(expr)+1
I'll make some changes.
Again, not sure why this is a form.
should be a const function
coding style - we normally don't brace single lines
чому винесли окремо інсерти?
Why? This will break the builder tests..
Note from conversation: Consistently use `permissions` instead of `permission` for the caching member/method names
@raydavis Do we also need first_name and last_name, where we use preferred_name if exists and fall back to First Last?
Sorry, I want to understand why function should declare lower return type than actually it returns?
When I declare function argument I say that it has to be of type X and it is good practice to X is the lowest possible type which function needs.
But when function returns some type it should be the highest possible type.
FIRST's event page HTML make me =(
who needs this dependency ?
fixing this now.
connected should be a boolean, not a string
Original code, I might have time tomorrow or sometime next week, if not I've added you as a collaborator feel free to change it as you wish :)
Almost ready to merge! (apart from the very minor comments above).

This can be done independently from this PR, but could you think in the future of an example for the gallery using `label` to label objects, and `clear_borders` to clean the image (for example in order to measure their size, and avoiding artifacts due to objects lying on the border)? We don't have yet an example in the gallery for `label`.
The advantage of using rake over a shell script is that if there is an error it stops.
I is defined here
I'm not sure that we want to say "vertices" here.  It is precise, but maybe too precise for some users.  Perhaps just "billboards?"
I wanted to check but I end up trusting the tests... I'll see if I can improve them.
I don't understand the question. Could you explain a little more? The infinite projection matrix of the off-center frustum used for culling when picking is never used. However, infinite projection matrix of an off-center frustum should behave as expected. The only terms that change in an infinite projection matrix are those with the far plane where the limit is taken as the far plane approaches infinity.
I'm not sure about calling these just bins.  Bin is a pretty general term like bucket in bucket sorting.  Once we introduce front-to-back sorting, we are going to have even more bins.  What will we call them?

Aren't these frustums?  Or frustum commands?  Or commands per frustum?  Or something more meaningful than bins?
I am still learning Javascript and I did not know u could do that. If your suggestion can be done, which I like it BTW, then I am going to definitely make the change. You always learn something new!
May want null check here as well
Should I remerge AudioStreamerCur back into AudioStreamer or otherwise do away with the bridge, or leave it in there in case we need to have this dual function again?
We should be able to toggle `CFDevelopmentRegion`, since it shouldn't be hardcoded as "English". I'm not sure if this is picked up or modified by tiapp.xml at this time, but it could be at a future point where we improve localization support.
Sweeping under the rug for now.
The array nonsense no longer exists.  Should remove this comment.
This is a nice change, but is it needed? I don't see it used.
My bad, thanks. Could you please add a unittest for this as well? The test would e.g. print a string into a file using file.writeln() and then read() the file and make sure the string is there. Thanks again!
But there is a `long` in `B` struct. You probably misunderstand something.
no need to save vertical space that way
It looks to me like it's lining up the arguments to `tuple`, which is exactly what I do if I have to break up a function call across multiple lines, and I'm sure that it's all over the place in Phobos already. So, if anything, I'd argue that it's fixing indentation.
32bit is repeated, rephrase
Imho this seems like an optimization I would expect – but you are right, the docs seem to require that the predicate is evaluated. Just putting a code comment here so we don't forget to remove the code comment before committing.
All of these constraints that check for integrals, characacters, booleans, and non-real floating point types should be using `canSwapEndianness`. The individual checks should only be used if the function or template only operates on a subset of them.
added a map for the place search request.
コメントとメソッド定義の間に空行が欲しいです。
Fluent::HandleTagNameMixin is a part of fluentd's lib/fluent/mixin.rb
Can we get some blank lines, pretty please? :D
Any reason why this isn't an attribute? Do we support other topologies?
Dammit.  I knew I needed to remove that before submitting...  Fixed.
The style guide has a mix of btn and button.  I wasn't sure which I should use... Mid way through the project you had said use btw, so most stuff uses that, but I must have missed a couple older references.  Fixed.
What do we get from using single-file mode here?
typo here

and take care that you can use ``name_prefix`` on an import only when the file is imported itself with the type ``rest``
These tests are weak, in the sense that the main point of the Atom Source is to correctly round-trip serialize the data. I would be more useful to have something like this for all the tests in this section:

        $source->setAttributes($expected);
    +   $xml = $source->asXML();
    +   $newSource = Source::createFromXML($xml);        
    -   $actual = $source->getAttributes();
    +   $actual = $newSource->getAttributes();
Yeah, that is good feedback!
More URLs?
I think you should customise this list for issues pertinent to the WA election.
Не уверен, что Qxt тебе тут нужно.
agreed. OSM is what I wanted, I keep forgetting that it is in its own file
now.

2012/2/28 Éric Lemoine <
reply@reply.github.com
>

> > @@ -0,0 +1,40 @@
> > +[first]
> > +OpenLayers/SingleFile.js
> > +
> > +[last]
> > +
> > +[include]
> > +OpenLayers/Map.js
> > +OpenLayers/Kinetic.js
> > +OpenLayers/Projection.js
> > +OpenLayers/Layer/Vector.js
> > +OpenLayers/Layer/XYZ.js
>
> I think we want OSM.js instead of XYZ.js.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openlayers/openlayers/pull/254/files#r497351
>



-- 
Matt Priour
OpenGeo - http://opengeo.org/
Expert service straight from the developers
Because if everyone has their own preferences, it would be hard to derive a set of rules and recommendations that are a non-empty intersection.
Added: <ul><li><code>long double</code></li>
<li><code>signed/unsigned char</code></li>
<li><code>const signed/unsigned char*</code></li>
<li><code>std::ostream, std::ios, std::ios_base</code></li></ul>
Removed: <ul><li><code>std_stream_manipulator</code></li><li><code>std::stringstream</code></li><li><code>bool</code> (it still serializes, but was causing precedence issues)</li></ul>
Disputed (ambiguity issues):<ul><li><code>std::string</code></li><li><code>std::string*</code></li></ul>
fix formatting of date filters when a * is given
use 2 spaces for tabs. looks like you're using 4.
Just looked at where this is used....

````java

			if (this.expectSingleResult) {
				if (result.size() == 1) {
					payload = result.iterator().next();
				}
				else {

					throw new MessageHandlingException(requestMessage,
						"The Jpa operation returned more than "
					  + "1 result object but expectSingleResult was 'true'.");
				}

			}
````

Given that the poll() method is called from both inbound and outbound adapters, it is not correct to throw a MessageHandlingException because that only applies to MessageHandlers. Need to bump up the superclass MessagingException.
We seem to have hijacked Oleg's PR here but rather than leaving this hanging here...

I would say @After or @AfterClass methods are better for doing cleanup; @DirtiesContext is really intended to signal that a test method has made changes to the context such that any other tests might be affected and need it to be reloaded.

If you want to discuss further, let's do it outside of the PR.
What I would love to do for 3.0 is to align the packages with the rest of Spring Integration and following that, message store implementations should go into the *store* package. I also chose that package so that I can store the unit tests into a package separate from the other JDBC tests in order to better keep track of things.
I agree that the attribs should be mutually exclusive. It would be consistent with the JMS inbound adapters where we do the following:

```java
if (element.hasAttribute("container")) {
    for (String containerAttribute : containerAttributes) {
        if (element.hasAttribute(containerAttribute)) {
            parserContext.getReaderContext().error("The '" + containerAttribute +
                    "' attribute should not be provided when specifying a 'container' reference.", element);
        }
    }
...
```

As for the name, the actual interface is called "MongoConverter", so even though it seems inconsistent, I think we should match the name of the interface that they would be referencing an instance of via that attrib.
I suggest that you also explicitly set font-family for h3 enclosed in .idea . Currently the font-family set for h1, h2, h3, h4, h5 and h6 in _typography.css.scss (Segoe WP) overrides the one set here (Georgia), but Georgia should be used for content such as the heading of an idea page.
Spelling mistakes w/ "Dooing" that could be changed to "Doing" or "Performing" and "docuemtnation" is spelled "documentation"
`it through (single) entry point` -> `it through the (single) entry point`
`Controller analyze request` -> `Controller analyze the request`
`invokes appropriate Action of` -> `invokes the appropriate Action of`
`This process is called the routing` -> `This process is called routing`
`Model communicates with the data` -> `Model communicate with the data`
`then loads appropriate View` -> `then loads the appropriate View`
`In the end response is returned to the user` -> `In the end the response is returned to the user`

Weird sentence: `Within the Action Model is asked to return and/or save submitted data.`
@wraps actually does the opposite... it grabs the f.__doc__ and f.__name__ and a few other of f's properties applies it to set_flow_control, so set_flow_control looks and acts like the real f function.
This file is for testing? Then it is good to have versions for both Django 1.3 and Django 1.4. If want to support both versions.
Anyone know what the default value is on a mac?
Ok. The code looks good, I just wanted to make sure that changing that method signature wouldn't affect anything else.

If the tests pass, commit! :)
Sorry, I don't understand what you mean. I updated this comment. Is is not clear?
I'll have a look again. Also I change the whats_new. Is this also not clear?
I don't think we need to check the organization of the task.  We may have a case where a Task is owned by one organization, but is eligible to be assigned by others.  I don't remember the desired behavior off-hand, but I think we might already have that expectation.

I don't see that this method is being used anywhere, at least not in this diff, so maybe it's irrelevant?

I think the most common use case will be to check that the actor has the right to modify a particular user's assignments by virtue of them being related to the same org, and the actor having a privileged role.
Move that to "project_sheet" app.
please add stack trace logging here