labofsahil/github-event-dataset-2012 huggingface dataset:
I also see quite some duplication between this docblock and the one in `phpbb_template_locator::get_first_file_location`. Would it make more sense to describe the details in the locator and simply refer to it here?

Copy-pasted docblocks that have become out of sync give me nightmares. We should clean it up imo.
The plurals logic here should be replaced with the 3.1 plurals stuff.
This seems hacky but I haven't thought of anything better yet. Suggestions welcome.
mai taie din ele! :) (prea mult spatiu liber)
It's safer to use `libfs` and `libpath` for these variable names, so that they don't get clobbered.
Картинку должно быть можно как загрузить, так и залить
With the use of full CF names, this is no longer needed and should be removed.
The rest of this routine seems like it would be a worthwhile as a stand-alone "dictionary_to_list_of_pairs" utility function.
No, there's only one.

It's an attempt to isolate the batching discipline from the processing of batches. The call-backs don't have to understand what looping logic is wrapped around generating sub-batches.

It may be a case of over-encapsulation that does more obfuscation than good. In Python I'd be using a generator.

I can flatten it if you don't like it.
Drop the "is_", it should simply be named: rack_exists
This .format is unnecessary
Per Katy's indication of our prior decision on this, I'll assume that all such references are a prod for more descriptive doc rather than elimination.  As we discussed today - while really torn - I am reluctant to let this be a pull-stopper.  Some kind of hot-fix would be welcome.
Here's how I would have written it: https://gist.github.com/3911240. Hopefully it's not worse than the previous version.
I'd be okay with a more general solution.
`var cString = String; new cString("foo@);` an alias get around that
I'm just seeing this now. We really should not create tables in the madlib schema.
Could u please tell me the reason. Thanks.
I mean, I actually fixed this issue in 4.2.  But 4.0 and 4.1 should need LIMIT ALL.
I know you decided not to make this more generic, but I guess the way to do this would be with passing in a function to unwrap results. Anyway, I would also consider adding a note that this code is mostly intended to be independent of mopidy and that if anyone wants to use it they should get in touch about splitting it out.
Won't the inspector do this for you?
This file should probably be in the `base` app (`fjord/fjord/base/`) . Ditto for all its related files.
Put parens around this whole string and ditch all the backslash-continuations.
Small 'x' looks way better
share/mailman is cool. Fixed. thanks.
But if you pass `''` you'll get `.//`.

But the path format the Wiki class is expecting is not the full path - i.e. `./bjc/style` should be passed through as `bjc/style/`.

And if you're in the root directory, it expects `nil` to be passed.
Rename type argument here to `assetType`
It is not, this is fine.
Besides readability, it probably makes the failure more obvious if anything accidentally calls code that expects a real delimiter.
This changes the semantics from required whitespace to optional whitespace.
stray console!
Done.

     * <p>The current graph is not modified by this operation: its objects and the
     * dependency links between them are unchanged. But this graph's objects may
     * be shared by both graphs. For example, the singletons of this graph may be
     * injected and used by the returned graph.
@dsaff : are you referring to the return value of Matcher<Result> which you want to be a Matcher<PrintableResult>? If that is the case, I need to create a method 'getFailures()' on PrintableResult (which get's the failure collection from the inner Result). Is that fine with you? If this is not what you mean, what do you mean in that case?

And, what about the 'causedBy' matcher in this file below? Officially it does not have to be part of this file (it does not have anything to do with PrintableResult). Should I leave it here, or do you prefer having it in 'org.junit.matchers.JUnitMatchers'?
Because that code is synchronous :)

(mocha determines whether the code is sync by looking at the length of the function's arguments; 0 == sync, 1 == async)
I'll give that a go, as well as looking at the possibility of a cancellable unload event.  The main question on the cancellable unload is whether or not to fire it when an unconditional unload is occurring (that is, if the unload() call is being made directly, or in conjunction with another un-cancellable situation - region.unload, world.unload, server shutdown).  Alternately, the event could be 'cancellable' conditionally - it could include a flag indicating that the specific event is actually NOT cancellable, in the context that it is being emitted.
not the form is locked, but the form config
this should read something more specific like: "should return node sharing text if it's set for the node"
Okay, I'll do that, if it passes in JSLint.
Not sure if we have this in the style guide, by why not ``callback.call()``?
You need to remove the elipses for these two lines since \u2026 is going to replace it. Otherwise, you will see two in the tooltip.
I like it. It's the same size that Sublime uses except they have an text shadow 1px top.
I don't know enough about the ref-based message receive optimization to answer this question so late at night, but ... it's my tiny understanding of the optimization that the ref is created by the Erlang side of the world, then sent in a message in a particular position in a tuple?
Yup, Future Refactoring Candidate. This one wasn't my code.
Use `/*`
I'm always wary of changes that add stuff like this into the codebase...
refresh the what ?
Really what is any number of tuples of Char, JsCmd, and the command executes a set of JsCmds when their corresponding Chars are pressed, right?
Interesting. Because duration is a TimeSpan, will it actually accept “slow” or “fast” as values?
You probably want here `RedirectView`?
And how we again got this `context.update` code into views? It has been removed and replaced with context processors. You merged something wrong?
Aha. Can you then only fix the case?
no space between `)` and `{`.
You've added webpage and wikipedia to the defaults list, but not included them above in plugins, which means they won't load.  Either remove them from here, or add them above.
No, shims has to go last.  Move your UAParser line up one.
That.... seems wrong. Let me fix that!
Can you make this function not called `players` anymore? It needs a more descriptive name since it's actually... a function hahaha.
Could you use publishUrl here somehow? If not, good lord we need to re-write the publish stuff even more.
Please move this to the section with the other @font-face declarations
This will fail for python < 2.6. nose supports 2.4 and better, so it has to be the old `except X, e` syntax.
unused? how could this possible. I need to make a double checking on this.
Can you remove the extra blank line (PEPify)
if the statfs is listed as a "backend" in plfsrc, then we'd have an iostore we could use.   if not, then we'd need to be able to add another iostore in order to get at it.
Please make this an echo, and add an `exit(1);` below, indicating an error status.
Whoops didn't catch that.  I'll get it corrected!
Ska vi verkligen ha detta? Vad innebär det att en assistent tillhör en labbgrupp? Kommer den informationen även finnas i databasen eller är den helt "fiktiv" och beräknas ut baser på vilka verkliga labbar som assistenten rättar?
What's the advantage of using the `:const` form?
Just out of interest, why did you move this `if`` statement up here?
Add types to all of the parameter docs.
If this copies the address, please use copy "Copy Address" as text.
Could comment out this line too, since the height is mentioned in debug.log just few lines before this line.
Agreed. I don't think the fallback was ever used. If something as simple as
requesting a stock path from the OS fails, there's a serious problem and
it's better not to try to guess either...
Why nBlockSize+8, is that a padding?
Is there a particular easy way using git to break this up into smaller commits, or do I just take a backup, rewind, and add each one as a separate branch from upstream master?
And possibly very wrong if the fixtures are attached to alternate test datasources.
Because  'utf-8' was used in CakeEmail class.

https://github.com/cakephp/cakephp/blob/2.2/lib/Cake/Network/Email/CakeEmail.php#L254

I also think that it is good to use "UTF-8". 
Do you think that an initial value may be changed into "UTF-8" ?
Wouldn't setting the default to a value that doesn't exist cause a number of errors downstream?
I don't agree on this point, fist we can't extends the  `Ext.slider.SingleSlider` because we nee also the floor list.
And we should first define a strategy to place plug-ins where we want, it what I try with #44 but it's completely stalled.
`var` is missing
Missing documentation here.

```php
/**
 * Constructor
 *
 * @param string $directory Cache directory
 *
 * @throws \InvalidArgumentException
 */
```
You want call it Api ?
@beberlei asked you to move this logic to another class implementing an interface and injected inside the parser, so that people can replace it by another implementation if they don't follow PSR-0
Hehe, cool. Try to give it another go tomorrow and if you can't get it working then maybe it means we should stick with your version for now. =)
Why did you remove this plugin?
WasTfsAuthenticated => IsTfsAuthenticated
Ideally yes ;-)  Moved to hooks.scala
Extra comma?
`str` is not the same thing as `bytes` on Python 3.
If I drag a file in, this looks like it will put the path to the file in the text. If I dropped a `.py` file in, I'd expect it to grab the contents of the file. But maybe it should be context sensitive, because you obviously wouldn't expect that for a URL.
The database API is supposed to be consistent, so I think importing as
sqlite3 is OK. Changing the name across the file would make the code harder
to read, and leaves more chances for bugs to sneak in.

Skylar, have you tested it with pysqlite2, both manually and by running
iptest?


On 24 December 2012 11:46, Bussonnier Matthias <notifications@github.com>wrote:

> In IPython/core/history.py:
>
> > @@ -20,7 +20,10 @@
> >  try:
> >      import sqlite3
> >  except ImportError:
> > -    sqlite3 = None
> > +    try:
> > +        from pysqlite2 import dbapi2 as sqlite3
>
> Do we have guaranties that the api will be the same ?
>
> I don't like importing as sqlite3 as later you don't know that sqlite3 is
> not effectively sqlite3
>
> Maybe importing both as history_db and change sqlite3 references across
> all file ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipython/ipython/pull/2718/files#r2497725>.
>
>
What about accepting other objects? Pretty much everything could be accepted, since strings are objects too?
Not really good-looking indeed. I'm not yet this fluent with Ruby, and not really aware of the best syntax to use in such cases.

What about this one, using `inject`?

```
if matches.length > 1
  msg = (matches.inject(["Ambiguous step definitions"]) do |components, match|
    components.push("  - \"#{match.expression}\" (#{match.block.source_location.join(':')})")
  end).join("\r\n")
  raise Turnip::Ambiguous, msg
end
```

If this seems ok for you, I'll try to update the pull request (is that possible?). Feel free to make a suggestion if you had some better way in mind, I was not seeing a nice way to do with `map`.
hmm, not really concerned with any -- I'll let the client/user see the actuall exception, so they know what went wrong.
Do we really need to have one indent per selector? Why not something like

```
.no-js {
  #unhelpful-survey ul > li label input {
    display: inline
  }
}
```

It isn't as LESS-ey, but I think it is a lot more readable.
dump the content of the imported frame module right after the import and not within saveScreenshot. It will give you an impression if it has been loaded correctly or if something went wrong already at this point.
This is really a question for @carljm
OK done thanks
Thats the only change that was required but it was done in a way that didnt match the style guide and its a massive edge case. Who is doing that?
why is it defined as abstract? if to avoid instantiation, then defining private visibility for constructor is a better way
This will never be executed. It is not possible to emulate the PHP's core "optional argument" behavior with user land implementation when you declare a argument in the function signature like in this method (you would need to use no arguments and use `func_get_args()` to implement this behavior - very clumsy). And since this is not possible, this kind of check is not even needed.

If you call a method with a mandatory argument without passing the parameter, you get a warning - we don't need to reimplement what the interpreter already does for us. Example:

    <?php

    function a($b) {
       var_dump(func_num_args());
    }

    a();     // would throw a warning and print int(0)
    a(null); // int(1)
don't change file permissions please
These two can't be disabled if they're loaded. At least I don't know an option for that.
``routing.match.requirements`` would be better
you should add the phpdoc (this method is deprecated, right ?)
Should this rather be an else clause?
Doesn't this one also need os_replacement?
was this change also applied to replies? (only ask for replies after the timestamp from the last received)
This works as a hash without the braces, I believe.
This is a good question. I think it's a style issue and we likely don't want to show more than one flash at a time.

@kaishin - thoughts on this?
It looks like this is stubbing an old boundary: `User` now depends on `UserFacade`. I'm not feeling the `UserFacade`, though, so I'd keep this test and bring the Facade's contents back to where the mailers are invoked.
The update parameter is not included in MaketxParams because we pass in an ImageBuf and ImageOutput. Perform that check here, before calling make_texturemap. Note that there is a subtle difference from the original maketex in that an updated texture map will now have a new DateTime attribute, rather than having the DateTime match the source file.
Das ist der Handler fuer fehlerhafte Logins. In diesem Fall setzen wir einen Flash und leiten auf die Seite um, von der wir kamen. Denn wir wollen ja nicht nur eine leere Seite mit dem Login-Formular, sondern beispielsweise wieder die Landingpage sehen.
Ah thank you! I was looking at the coloured part and couldn't see the problem (doh!) :smile:
I'm not sure if we really need this class.  Parallel collision detector is very closely connected with DataBus, so it seems to be ok to remove a separate class for a parallel CD.
"archive" -> "achieve"
how about

    try:
        from django.utils.timezone import now
    except ImportError
        now = datetime.now

So you can just call ``now()`` later on and don't care which ``now`` function it is
fair enough - i guess it can't be avoided that it's messy whichever way you go.
How about?
```python
    elif func.__p_type__ != 'list':
```
there was a logical flaw in my import code, i was session at the wrong time, and creating it twice. now it is created once, and saved after the datalist. this was breaking hte sync for me, im not sure if it was breaking it for everyone too. but now it works.
renamed default data list to all data (its a bit more descriptive. this is for @gretchenmcc
now I'm really nitpicking :P but function and method names should be written as readable as possible. urlsAreEqual is a statement to me, while areUrlsEqual sounds like a question, which seems more fitting here
ah, fair. maybe we add a li'l:

    && typeof define !== 'function'

that work?
This should attempt to close the connection
If isJPA determines if the bundle is a OSGi Persistence Bundle, we probably need additional tests here.
Should be `http://api.jqueryui.com/selectmenu`
@scottgonzalez @jzaefferer When I look at this `_create()` method, it seems there's a **lot** of initializing sub-tasks going on.

* We're initializing `menuItems`
* We're instantiating a `$.ui.menu`s underneath all of these `menuItems`
* We're setting behavior on the `menuItems` and on the sub-menu items
* We're defining callbacks that are applied on the sub-menu items....
* etc.

Combine with the jQuery 'dot-chaining' syntax, the method seems to strain easy readability (in my book).  This makes the contribution bar higher (IMNSHO) and makes testing / debugging harder.  Maybe this isn't so for jQuery gurus such as yourselves, but I think the code would be more approachable if the long methods used intention-revealing sub-methods.  I don't see this done elsewhere in the jQuery UI environment, but I wanted to get your thoughts on why this is or if this is just my relative unfamiliarity with plugin design.

Questions:

1.  Is it against jQuery standard to split these `_create()`-homed activities into intention-revealing sub-methods?
2.  Doing so might mean that you have a single `var` declaration in the sub-method and thus chaining becomes less attractive (given the "only one `var`" statement) style rule
имхо этот js надо вынести чтобы не копипастить, по аналогии с tagsAutocomplete.js
I can get behind that :)
I used div because i assumed that their will be more wallpapers from differents sources (different size). 
I will put that code into a onload().
The rationale is: we don't want a shared css going hand in hand with a shared js because it means we're creating a component. And that's exactly what the building blocks are *not* supposed to be.
looks like a duplicate of `data-connect-warning-message` — this line should be dropped
It's only a margin-right? When there is '0' we dont have to put the 'unit' (in this case 'px')
a bit strange that we do things after callback is called ...
mmm sorry for this comment specially cause cannot help with a brillian idea ... but ... there is no way of making those selectors less complicated? Just asking.
I think this method is a little bit calendar specific. I would return, given a form, all the input tags values. What do you think?
I really feel like adding an empty `<span>` element here is a pity… please consider re-opening #5680.

If you absolutely want to use an empty additional `<span>` to have a button icon, it would be more robust for the l10n system to use something like:
```html
<button id="msg_button" class="activity">
  <span role="button" class="icon-message"></span>
  <span data-l10n-id="msg-send">Message</span>
</button>
```
Templates uses new Function but the eval'ed content is all hand written no user/remote input will go through new Function directly.
(And is stripped of all HTML before it hits the templates).

If we enable CSP  (and it will disable this) then many of our apps will need to change (like Settings).
For me its a simple change to just find the two places that I need to call this function and just use a regular event handler in app.js.
`this` -> `self`

and there should be a `var self = this;` above.
Also I have the feeling that isDisabledDrop is synced with this.transitionning, is that not always the case?
No good reason. I will fix that.
And here too. :-) Also, just FYI (return None is fine), you can just do "return" and that return's None, and in Python, if you don't return anything, it actually just return's None too.
As you suggested, I have converted the `unless` into an `if` in 049b0b64dd3fb0d65a7e958419e7ea5c875ae159.

However, I disagree with the `and` and `not` conversion.  Yes, they may be confused by novices who don't know or understand Ruby's precedence rules.  But I have made no such mistake here.  It's simply more readable this way, without the `!` and `&&` line-noise IMHO. :cop:
missing a *
Why did you rename the annotation?
What strategy do you advise? Should we force `mbstring` dependencies by requiring it or fallback on `strlen()` if not available?

btw, I noticed the same behavior in the [Apc adapter](https://github.com/KnpLabs/Gaufrette/blob/master/src/Gaufrette/Adapter/Apc.php#L60).
Thanks Josh. I'll do that.

Thanks

Thiru

On Wed, Jul 18, 2012 at 12:11 AM, jblatt-verticloud <
reply@reply.github.com
> wrote:

> >  end
> >
> > +node['nagios']['nrpe']['mon_host'] << '127.0.0.1'
> > +
> > +# if node.run_list.roles.include?(node['nagios']['server_role'])
>
> Instead of commenting this out, I think you should introduce an option to
> run in solo-only mode which defaults to false.
>
> That way you can send a pull request back to the maintainer and have a
> better chance of them requesting it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/VertiCloud/nagios/pull/1/files#r1181531
>
I'm inclined to suggest that this should append project to the repository URL. Except that I just realized this function doesn't have enough information to do that.
and there is a typo at desciprtionDone
I'd rather not duplicate the information linked to, but it doesn't look like it is obvious where to look there.
We can add if Debug mode (#ifdef _DEBUG) then don't write to AppData, but for Release mode do use AppData?

Or make this configurable by setting some variable?
hmmm... sudden change of contributer?!?
Yes, you are right. I will fix it. Thx :)
maybe worth keeping the `storagePrefix` var just to make life easier?
Don't need to commit this file.
Could you please add comment explaining what  `__exposedProps__` are and maybe link to an MDN page if exists one, otherwise Bug number will work as well.
Do the promises passed always get handlers attached or does lazed wait until handlers are attached to the promise it returns before it does that? I think it's worth documenting (also think the latter should be the case)

I don't like the lazed and promised naming here, are there examples in other places where this naming is used?
Alternatively you could just warp `install` function into `promised`, that way exceptions would've just propagate and reject a promise.
Yeah, I am quite unhappy with name `box2`. Open to suggestions.
list items can't be self closing. Source: http://www.w3.org/TR/html5/syntax.html#void-elements
As far as I know the CC doesn't free anything but only creates a list of objects to be removed.
Why not: this._buffer = new Array(this.length)
if it was "Latte" you would have.
Shouldn't you rename the whole test file?
Inverting this `unless` to an `if` would remove the need for most of the comment above since the code would be almost the same as the comment. Pulling out something to track if this has been evaluated to the point of having a final answer would help out the rest (a block is always a final answer, other things are only final if they are false).
Thanks for adding the space... it drove @pcarlisle and me nuts.
Oops, there is a tab on this line.
Are we reverting to this method of snapshotting (having the snapshots refer to the previous event)? Its fine with me, but we should decide on one so we don't get confused when examining traces.
a!=b is equivalent to !(a==b)
So, since we are not initializing the @success value it would raise and exception (undefined) if we use !=
This import is unnecesary
This is no problem with special characters in some languages​​ (German, Russian, Chinese, etc)?
subnamespace Getopt doesn't exists. Can you fix it?
thx
It's not clear if return ViewModel due */* or because defaultViewModelName
Line 97 isn't necessary
Whatever you want. Guess Jon Doe will do?
This has been fixed in a new commit. Disregard this diff.
is this common practice? or are we all using phpstorm?
Just bootstrap stuff. You can ignore this file.
wow, extraneous ? !
this should override them only if they are not ``null`` IMO
Yes, you should create a `Commentable` module.
You should find solutions to this problem with good controller code, not view code.
You should move this down and make it a private method. Public methods are exposed potentially as actions.
fixes the linter in my editor :)
Agreed. I wrote a context manager for my unit test but didn't think about writing one for this, good idea :)
You're right. I don't see how that could have worked in my tests then. 

Added it.
Right - I was thinking about introducing runtime errors.  What do you think about that, and if you like the idea, do you have any opinions about how they ought to be implemented?
Also: add "options.fps has now been removed, as I know some users use this."
Now that I think about it, why can't we just set `bound.prototype = target.prototype`?
should I just add it to .gitignore or it's not a good way to solve it?
We left `BANNERS_HASH` as empty because the hashes vary from one environment to another.
You don't need this line since there aren't any templates below, but nor does it hurt anything.
Ah I see, class methods.  Still looks a bit funny, but I guess it's fine.
I'm mildly concerned just because it's in the direction of increased customization.  I'd actually lean towards dropping the join link from the blurb rather than making it join/leave. That section still isn't cacheable right now but that moves us towards more-easily-cacheable, but I could be persuaded otherwise if you felt it improved the usability.
I'd be in favour of that, yes! Might want to ask for a second opinion in chat, but I'd say go for it. :)
Just more readable indentation
припускаю. але й дефолтні дублювати нема сенсу. просто треба було забрати непрацюючий
Ok, I realized I wasn't actually gaining anything from the userchangeform - it's a standard form now and doing just as well without the hack.
need to have some tests that cover .hocon ... I think there might be a test that checks that we load and merge resources with the 3 current extensions, which could be extended to also verify that it loads .hocon in the proper order.
This isn't right, you don't need that packet at all, GenericCustomArmor should be a packet by itself, like GenericCustomItem :P
Why store this in a variable that is not being reused?
Brilliant ! Now the ball is on @gbentley's side :)
Ah, I see.  I will definitely need to rework this, then.
I've heard you're fixing this in another PR, so I'm just gonna put it back to its `foo` value.
You could just do

    *level_count = result->nodesetval->nodeNr;
It renders as intended. Fixed the missing . with b019289.
Hmmm.  Well I'll just go on record then as saying that I am philosophically opposed to the idea of making it easier to swallow an exception under any circumstances.  :)
Maybe "Drop all constraints" instead of "Drop the constraint"?
Yeah I agree... there was a lot of logic all entwined in this one module and this series of commits has mostly been about separating it out into a more reasonable class heirarchy a few bits at a time.  This is the last remnant and should eventually be dealt with, but I'm not sure whether or not now is going to end up being the time to tackle it.
agh.  thx
Created the `getMe` function in `api.user` in `oae-principals`.
We should probably just do `'://' + ...` to make sure that we are https friendly
On the other hand, this will break souce compatibility, but I feel it should be easy for plugin devs to follow this change. Do you want me to add a deprecate method? (though, I don't think we should do this because ``getInteractiveCompilationUnit`` was introduced in unreleased code, i.e., V2.1)
Kann dieser Fall nicht mit dem Default-Case unten abgehandelt werden?
For named arguments, I prefer ``foo=bar.`` This is consistent with PEP8 (even though not really following it for everything)
if messages.empty? then use messages.first
use net.liftweb.json.parse directly instead (available by just importing "net.liftweb.json._" )
Need to throw. The host need to know that an error occured.
Вы забыли, что percent - это именно процентное соотношение! Пока у вас последовательность состоит из 100 элементов - всё хорошо. Но если вдруг понадобится последовательность из 46 элементов? Или 400?
Эхъ ...
Если ячейка ДНК равна строке такой же ячейки ДНК, то увеличить расстояние :( наоборот ...
Yup! Good catch!
On Sep 15, 2012 9:29 PM, "Steve Fenton" <notifications@github.com> wrote:

> In index.html:
>
> >              };
> >
> >              var resources = resourcesEnGb;
> >
> > -            var template = '<li data-name="{name}" id="{id}" class="{class}" data-category="{category}" data-update="{updateCounter}">' +
> > +            var template = '<li data-name="{name}" id="{id}" class="{class}" title="{title}" fixer="{fixer}" data-category="{category}" data-update="{updateCounter}">' +
>
> Should the attribute be data-fixer as fixer isn't a valid attribute?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Steve-Fenton/Cruiser/pull/1/files#r1613951>.
>
>
Tim is MIT, so including this license here may be an issue
This should be the end of this test.  The next step is an implementation detail and it should not be included as part of this, you can simply verify that information in this step.
I'd like to keep this as .hook() since .defineHook is just the private implementation
Maybe a `nil` block could be used to represent an infinite stream of a single value (the start value), analogous to [repeat](http://www.haskell.org/ghc/docs/7.0-latest/html/libraries/base-4.3.1.0/Prelude.html#g:16) in Haskell.
I haven't actually tried it, but I figured that signature would break if an implementor of <RACStream> wanted to redeclare the block to return its exact type.

It's not a blocking issue for me, but it's also misleading in that you can't return _any_ <RACStream> — only whatever the instancetype is. Using id generally forces a closer reading of the documentation.
Ok, after merging this change I'll add on platform code and I'll create tests for it.
Cool, I will fix that :)
Ok, I see :)

Then I suggest adjust the naming of that variable. `width` might confuse people to think it means the width of the text. Name the (x,width) pair in the way you name (pen_y_top, pen_y_bottom) will make more sense I think. (Or (x0,x1))
use == to compare strings. "is" means the same location on disk
it is not a decorrelation. It's dimensionality reduction and maybe sphering.
I meant everything inside an if(isNameField) should inside one if clause
Probably we want to update this to `dev@praekeltfoundation.org` or something similar.
You'll have to override the entire method unfortunately.
启动 -> 启用
Why do you need this line?
Does this line still have a meaning? If not, please remove ;) (I would've done it but wasn't sure about its purpose) // @quetschman86 @SickBang
I think that this more compact form is simpler to read/understand:
val current = reverse.getOrElse(token, Set())
This example class is cleaned up and has been moved to the test package.  Run with test:run-main.
And this is also the same as in master in a different form

```py
In [46]: solve((2*sinh(x) - cosh(x)), x)
Out[46]: 
⎡       ⎛    ___    ⎞         ⎛  ___    ⎞⎤
⎣2⋅atanh⎝- ╲╱ 3  + 2⎠, 2⋅atanh⎝╲╱ 3  + 2⎠⎦

In [47]: [i.evalf() for i in solve((2*sinh(x) - cosh(x)), x)]
Out[47]: [0.549306144334055, 0.549306144334055 - 3.14159265358979⋅ⅈ]

In [48]: [i.evalf() for i in [log(-sqrt(3)), log(sqrt(3))]]
Out[48]: [0.549306144334055 + 3.14159265358979⋅ⅈ, 0.549306144334055]
```

The form of the answer is nicer, but that should be a job for internal simplification in the trig functions.  Given that there are also regressions for solutions, I am -1 to this whole branch (at least based on these tests).
@gquemener any reason why you don't fix this ?
Pero no sabés si va a estar dentro del form, ¿verdad? Es decir, si no tiene los permisos necesarios, no va a mostrar el form, pero sí va a mostrar este div.  Si en cambio tiene los permisos necesarios va a mostrar el form y adentro el div.
Yep, but not sure how to handle multiple commands executing in parallell on the node via drmaa. Added some dummy code that needs to be fixed up for that. Will stick to the bash wrapper for the time being.
I like that "bursts into appearance"
Tests have to pass capp_lint too. Consecutive var declarations.
Yes use const TypeOfSomething&& here.
de ce nu mai folosim `form.select.open`?
Debug output sneaked in here.
The aim here was to return the longer of two sequences. You can do this with `count`. This implementation of `seq-max` does not. It shuold work like this:

~~~clojure
(seq-max [1 2 3] [2]) ;=> [1 2 3]
~~~

But the current implementation would return `[2]` instead.
I do not want TestNG to run it but I want the test methods to be inherited by subclasses. If I do not add ```@Test``` to base class nothing is inherited. I would expect adding ```@Test``` just to the test method should work but the inherited method is still not picked up by TestNG. So I'm using this trick that is also used by other tests in infinispan. Is this the norm or is there a better hack?
why `servers2Hash.keySet().size()` instead of just `servers2Hash.size()`?
The curly bracket should be on his own line
Yes, but in those cases, the `m` stands for module, which was the source of my confusion about this, at least.  I think `mplDeprecation` would be fine and is a reasonable compromise.
Ideally we would like to get line widths <= 80 characters for smaller screens, would you mind putting newlines through this and other long lines.
Just realised this is in a string. You can ignore my previous comment if you wish.
One idiom which I think helps clarity in the case where you are forced to handle data that you don't ever use is to call your variable ```_```. In this case:

```
patch_inside, _ =  self._bbox_patch.contains(mouseevent)
```
if the slave name was specific per-client, would that take care of it?
You added whitespace again. :p
is there a reason why we are caching the description response and not its parsed result?
We never actually use this function. It should be deleted.

[Issue here](https://github.com/reddmetrics/forma-clj/issues/93)
This can probably be consolidated into oae.base as well, as all content items in lists will get a share icon.
It should when integrated in a group.
What's the difference between this and edit_question_set.jsp?
Can we solve this by better selectors?
i'm not a big fan of tap like this, but if it works it works
No, actually not. It returns a concrete implementation of the interface. It just happens that there's just this one implementation now. But it still implements the interface. And there will be moar.
- ``$entity_id`` does not seem to conform to the naming convention (``^[a-z][a-zA-Z0-9]*$``). Please also check line 137.
- Is it possible to add a ``@param`` annotation for parameter ``$entity_id`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? Please also check line 137.
Put comment on previous line
Wieso steht da wieder prename und surname? Wir hatten mal beschlossen, das firstName und lastName zu nennen, ist viel weniger Verwechslungsgefährdet.
that's not legit
Kudos on shortcuts. Not sure if 'it' refers to Backbone.js. Backbone.js has been very practical and useful. I think I meant BackboneMVC. Maybe the 'becomes' is not accurate?
Capitalize the first word in an inline comment please.

Why indented?
let's brainstorm this one in person--this will work but there's a bit more subtle behavior I'd hope to express here
why keep this out of sync between vis_mpl and vis_2d?
Also, am I missing something here, `__send__(:after_failure)` should not work as the method is called `run_after_failure`
Why not just write `sys.stdout.write` below?
Basically, just check for `.git` and `require 'bundler/setup'` or `Bundler.setup`, it's worked for Ronin. I would love to use furnace-swf / furnace-avm2, but I do not want to manually edit the `bin/` scripts just to get them working.
Move this import bellow to celery group.
Exactly this. You want to see that form has new/updated data now. That changes have been stored.
I think this came from merge... But I'm not sure. Fixed back to previous state...
Even if function argument? That javascript is actually the first argument of setTimeout.

    setTimeout(
        function () {
            marker.setAnimation(null);
        },
        750
    );
?
Ehm, absolute? Why? It should simply be another element in the header menu (next to login, logout, and other entries).
Please make normal if sentence here.
This is not registration.
Hardcoded urls? Not sure what to do with them, maybe define them as constants or something?
No need for parenthesis around the sum.
It is done automatically in middleware!
I would make it at least warning, if not error. Info messages are not displayed with the default value of --log-level
"// To do:" doesn't seem to be picked up by vs, probably other tools too, should use "// TODO:"
Can we change this to  "...permission to complete this action." ?
Same here (`name in self._retries`).
spacing is off a bit here
The specs failed to run on ruby 1.8.7. See travis build output.

I think the issue is the period should be moved up to the previous line. The line break would occur between '.' and 'm' instead of ')' and '.'.
WAT. It *is* `-ifndef.`
Config? Nein, die Länge ist nur für die Registrierung.

Wegen der Länge, eine Länge von 6 vs 8 Zeichen kann für einen Bruteforcer Jahre ausmachen.

Und nein, das Argument "es ist nur low security" gilt nicht. Wenn jemand Password Reuse macht, kann eine "low security" Seite eine "high security" Seite kompromitieren, zB: http://www.codinghorror.com/blog/2009/05/i-just-logged-in-as-you-how-it-happened.html
why changing the location hash ?
i removed elgg_register_title_button() and added  elgg_register_menu_item start.php
typo: "its" ;)
Like
```javascript
      "p", LOCAL_URL_TYPES.contains(entry.urltype) ?
        ui_strings.S_NETWORK_NOT_REQUESTED : ui_strings.S_NETWORK_SERVED_FROM_CACHE,
```
?
That's what I was trying to fix with this styling. How do they not look like the rest?
Please don't change this; it won't build on Travis with this uncommented.
I tried what you suggested and found that the code lost much in readability. And since the other models (e.g. hurdle or zero-inflated) will require a different logpmf anyway, we don't really gain any extensibility by splitting this as a separate function. I vote for keeping the code in the Class so that it's clear what happens when _ll_nb2 calls _ll_nbin (or whatever we name the latter).
this plot doesn't look nice, tight layout ?
First, I'm still interested in what kind of syntax is `Array.new(size=15, obj="")`? I assume it's equivalent to `Array.new(15, "")`, but I've never seen it before in Ruby. Second, without going into the depth of Ruby implementation, that I'm not very familiar, don't you think creating a whole new array of object is not worth reducing the amount of code you need to perform this check? I think it's really nice to make smth like `element = hash.fetch('key', [])` to get an empty array if the key is not present in the hash, but in this particular case creating an array of 15 elements seems like too much for me. Anyway, I'm just sharing my opinion.

Regarding your changes, why `"".split`? It'll simply return an empty array anyway. How about that:

```ruby
unicode_data = TwitterCldr::Shared::UnicodeData.for_code_point(code_point)
decomposition_mapping = unicode_data ? unicode_data[5].split : []
```
What do you think if we remove this intermediate `UnicodeData` module? `CodePoint` is the only class in it and I think it's nested too deep.
Why have this try/catch at all?  Logging doesn't seem like a good reason to catch and immediately rethrow.
Or, we need a python YourRequestIsNonsensicalError :)

And now for the serious response: I agree with Mike that this could be removed.  This NotImplementedError is more useful for things like OpticalPSF or Convolve where a HLR is something people might wonder about and not realize it's non-trivial to make.

On Jun 13, 2012, at 10:15 AM, Mike Jarvis wrote:

>>         if yw is None:
>>             yw = xw
>>         GSObject.__init__(self, galsim.SBBox(xw=xw, yw=yw, flux=flux))
>> -    # Ditto!
>> +
>> +    def getHalfLightRadius(self):
>> +        return NotImplementedError("All the light within a Pixel is contained within its borders. "
>> +                                   +"Try the Pixel.getXWidth() and Pixel.getYWidth() methods.")
> 
> This is probably a case where my request that "All profiles have a getHalfLightRadius" was a bit silly.  This might be better to just remove as an option at all, rather define it and than raise a NotImplementedError.  (BTW, I think you meant raise rather than return.)
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/189/files#r976305


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
Actually, it used to be there.  It just used to be done automatically.  It took me a while to figure out why 360 degrees / 20 = 0 degrees.  It was because 360 degrees was being automatically wrapped to 0.  So I realized that depending on the context, the two values don't necessarily mean the same thing.  

So I changed it so any wrapping has to be explicitly done, and thus added the documentation about it.
For relative python newbies, it may be worth explaining that the assert statements are used to demonstrate that the g1/g2 determined from ps.getShear(pos) is identical to that from the grid to within 1e-15 precision?
I will read through this $.deferred() stuff tomorrow, with more mental energy.
We should delete this unused (now commented out) code. And delete the deprecated Jboss6Server.PROPERTY_FILES.
But that can be a separate pull request.
Cycles are forbidden for entity ownership (i.e. when going through getOwnedChildren, you'll never hit a cycle).
I can change it, but don't think it really matters.
And I only fixed the bugs, didn't clean up the code :)
It is troublesome specification. I will comment out it when find it.
Added just below now.
One day soon we'll have argValue instanceof ArrayBufferView, but for today yeah
Why ignore the exception?
actually maybe this step is unnecessary at all
What's the reason for adding a product to the basket for every test?
if(!$data){
                    return false;
 }
$data = $data[$Model->alias];
no need for the ``class_exists`` check here. ``instanceof`` does not trigger the autoloading at all. It inspect the parent classes of the object
Ditto as above!
Comentariul nu are inteles.
Why make this a proc?
e надо передавать в конструктор FormatterException в качестве cause (и в остальных местах).
Между методами пустая строка должна быть.
Пробел до < лишний
Если добавить ```Class<?>``` вместо Class, то у тебя не будет варингов.
Any chance of more descriptive variable names?
Is this required for local installs? Or if so: should it be? Seems like busy work for local development.
Nit: extra space "if  the"
Why not tell the user to add it to the Gemfile ?
I think this loop can be replaces by a faster ``np.bincount``.
I think that opens the question where the strong rule code really belongs. I don't see why only the basic strong rule should be in ElasticNet and the other stuff somewhere else. I troubled by this questions since a while, that's why I commit already not working code so we can agree on where to implement things.
besides the memory jump difference iterate on active features or reduced set should do the same amount of computation and It should at least for small data be almost equivalent right?
We avoided using mixin inheritance as marker of estimator kind (except in tests).  This is my first proper look so I haven't really understood the design yet. Why is this code here and not in the classes that inherit from it?
Did you check if this is actually faster than the numpy-way of doing it a la
```
sample_mask = np.zeros(n_total_samples, dtype=np.bool)
mask_inds = random_state.randint(n_total_samples, size=n_total_in_bag)
sample_mask[mask_inds] = True
```
?
не було, я зробив) непотрібно було?
I know, I'm replacing/fixing them now and there. And it would be nice to have these correct, so I don't have to fix them later...
That code was commented out and it doesn't really make a lot of sense to keep it as it is (the if being unconditional makes the code outside the if unreachable). Maybe it should be removed altogether.

Anyway, for now I just leave it unchanged, I guess it was part of an initial search&replace and overlooked it afterwards...
I think it is 2.1 only - we are using this way in the 2.0 version of AbstractElasticaToModelTransformer would be good to use PropertyPath in master though
This is the format I usually use. The formatter doesn't have a problem with it.
Doesn't seem we use this ctor anywhere.
Trace est dans /home/public pas /var/public 
ça devrait résoudre le problème de permissions
Syntax error. (This is missing a `\n` and a `\`)
Ditto for this line.
We only need to commit to this number if the release goes out, right? I mean, while in ```master```, you can change the API (for instance, if Jake needs an extra argument or function) only until the candidate goes out of the door. Correct?
I think should be >= instead of >
That was my original design, but both "dump op" and "dump type" were identical, so I preferred a single implementation.

I don't think that "CASE_OP_TO_TEXT" will add much more information, and it's a bit too big. DUMP_CASE seemed to be just fine...
We generally test the c++ compiler because we are generally using c++....

This program however is all c

You just need to say

```
if (CMAKE_COMPILER_IS_GNUC)
``` 

rather than 

```
if (CMAKE_COMPILER_IS_GNUCXX)
```

and similar where you are fetching the version. You should probably fetch both C and CXX versions and store in two separate CMake variables.
Ok, now that I see what the old code is for, then it does make sense for the old code to stop the monitor queue too.

In eclwatch, it MIGHT make sense to be able to manipulate the monitoring queue independently. I don't THINK it makes sense to assume that suspension of the spray job queue implies suspension of the monitor queue though.
I'd have thought this should be an error...

If not, correct me if I'm wrong, doesn't it mean if you make a typo and name an unnamed cluster, you will end up deleting all copies?
Logs should be avoided
My name is @mathjazz, and I approve this message. :)
We probably need to load it from elsewhere, as if you do this we will run all this combinations for all test cases and it is too much.
display not diaplay
I was informed to refactor the code, as follows

try something like:
@FindBy(name="mytext")
  private WebElement myText;

public boolean verifyTextIsPresent(String expectedText){
       if(expectedText.equals(myText.getText())){
                       return true;
               }else{
                       return false;
               }
       }
:
@shacker Looks like there is a space before the tab.
Vaihtoehtoisesti `(= (sort rank-freqs) [2 3])`
Destrukturoinnin voi tehdä suoraan `rectangle` arvosta:
~~~clojure
(let [[[x1 y1] [x2 y2]] rectangle
      ...
~~~
Remember to remove code you have commented out
Maybe we should be checking the sender's db, but we shouldn't be doing it because of the settings hack. Multiple databases are not meant to be used this way.
Hmm, maybe I'm missing something, but from looking at the code this looks like it replaces the last byte with the second last one of the payload?
I had a long reply and then GitHub ate it, it was probably trying to tell me something. :) Here's the bullet version. 

1 First, when I say style, I mean non-technical changes  that don't change code behavior
1 While I agree that grouping `this.foo = bar` assignments in the constructor is good style, I wouldn't ask a contributor to change it unless the constructor was a mess for other reasons as well.
1 I think asking contributors to order properties in the constructor to align with getters/setters is unreasonable process that will frustrate people. (what's next, enforcing local variable naming rules?)
1 Ultimately, style choices (at the function level) should be mostly left to the coder (within reason)
1 All official style guidelines need to be on the coding conventions wiki page and strictly followed in order to eliminate bike shed discussions like this.  Style guidelines should be reached by consensus of the most active coders.
1 This is not the right place to have this discussion.
It is probably better style to say `this._renderList.length = 0` so there is one less level of indirection to see that we are changing a member variable.
double taps