labofsahil/github-event-dataset-2012 huggingface dataset:
Thank you! Any upcoming updates for spell_dbc?
Was trying to mend it - not success due lack of knowledge, sorry.
This causes a failure for `[1e308]` for example:

```
julia> [1e308]
Assertion failed: (!IsSpecial()), function AsDiyFp, file src/ieee.h, line 279.
```
Need to change this inside the emitter. The emitter should be returning the actual data, not just the data's size.
Barring minor style nit, looks good to me.  Doesn't seem to break any new tests.  Thanks for taking this on!

I thought you were going to try to get this onto 0.6. Are you still planning on doing that?  The commit looks like it has a relatively minor collision on 0.6, but I didn't pursue it very far.
Yet it seems to work, somehow.
Taking a look at it tomorrow.
Thank you! Works fine
after 10 hours its back at 40%, we will see tomorrow
I think it's fine for some of these widgets to have no content.  In this case specifically, a user will usually want to drop the `<textarea>` so someone else can write in it -- they wouldn't want default content.

May apply to other widget entries in this file as well.
Any number of `<bibl>` should be allowed here now (but not listBibl—for reasons, I confess, I did not investigate deeply). See commit 2bdbc88
Will be re-done and thus put back in once Malcrom converted it properly =)
Style: +4 spaces of indent  :)
ololo.7z
What is this extensions flag? What does it do?
A <TR> element is supposed to have at least one <TD> or <TH> element.  Most browsers will handle this, but it's strictly not proper HTML.
It's not really important which tool will be used. Only the suggestions are important. Of course the changes of the line

    o.url = o.url ? o.url : $t.p.editurl;

and the line

    tmp = sucret[1] ? sucret[1] : tmp;

to

    o.url = o.url || $t.p.editurl;

and

    tmp = sucret[1] || tmp;

do improve the code a little. Moreover JSLint can gives another practical recommendations. For example information about unused variables like `i,n` from [the line 356](https://github.com/tonytomov/jqGrid/blob/master/js/grid.inlinedit.js#L356):

    $.each($t.p.colModel, function(i,n){

unused `i` in the [line 388](https://github.com/tonytomov/jqGrid/blob/master/js/grid.inlinedit.js#L388):

    $($t.p.colModel).each(function(i){

unused `e` in the [line 465](https://github.com/tonytomov/jqGrid/blob/master/js/grid.inlinedit.js#L465), [line 482](https://github.com/tonytomov/jqGrid/blob/master/js/grid.inlinedit.js#L482), [line 502](https://github.com/tonytomov/jqGrid/blob/master/js/grid.inlinedit.js#L502), [line 529](https://github.com/tonytomov/jqGrid/blob/master/js/grid.inlinedit.js#L529)

    onClickButton : function ( e ) {

I find the suggestions good.

Best regards
Oleg
Sure, I agree that would be more clear.  I was just getting rid of the warning by using a variable.
Hmm, I do like the ability to supply a custom runner though.
Aren't you able to add `@priority` to 4chan x, even though it's Scriptish only, so people don't have to add `@delay` themselves?
Nope, my code is correct. Think about it for a sec. If I do

int[] myArray = new int[3];

What are the indexes? 0, 1, and 2. But myArray.length is 3. 3 is not a valid index, the last valid index is length - 1. 

:)
typing redis twice is shorter :)
Actually didn't add the tests to implement list. That went into the main project
whoops, sloppy on my part, thanks for fixing.
I don't think so.  These patches need to be updated to 4.8 anyways.
おお、なるほど。ありがとうございます
theres nothing exactly like this on windows. it should be enough to include io.h and instead of F_OK use 00 because F_OK == 00 as its a mode for acces()
link:
 http://openbook.galileocomputing.de/c_von_a_bis_z/017_c_dateien_verzeichnisse_002.htm
you are wrong LiMCrosS. 0 != NULL. 
You can test it on writing a little programm with function "int example()"  which returns always null. Now create a condition in your main function if(example) prinf("NULL != 0");. When you run this little programm u will see "NULL != 0" in your console
To me It looks really weird to return what callback returns. It is arbitrary value chosen by the user of my code. If I am returning something, I prefer this to be in the contract of my function and not something I have no idea what is it.

Are you sure it is a good practice?
Yup, my mistake w/ copy/paste.
I'll need to dig around in python-vnc-viewer as I simply haven't ever taken a look, but I'm certainly down for including anything that makes more sense than my implementation. Thanks for the heads up.
Using doubles by default is like using longs for your loop counters instead of ints. In all likelihood, you don't need the extra precision.
Because you arent using the latest Bukkit
@huacnlee , @huobazi 

加个 site_token 是个好主意！

PS，为什么不用 Ruby 自带的 SecureRandom 来算呢。
PSS，private key 上需要加 index，如果不打算自动为每个用户生成一个的话，则需要加 spare index。
Emacs wont use syntax highlighting with python2, looking to see if I can fix it.
You add `=`s but forget them at here?
Because we run it through strtolower.
ok , I will but later tonight .
Heh, actually that's a hand-written composer for the master repo.  Just fixed it in Signal and the earlier repos. Thanks!
@stigkj: Sure it would be. However it seems manifest and branch are provided in the constructor, and as such must be passed as null by Jenkins. So that would have to be done in the Jenkins source.
As for the bug you mentioned, do you mean for loops over column vectors in general or a MATLAB incompatibility when it comes to what the ```get``` command returns? Regarding the former, both Octave and MATLAB show the same behavior:

```
>> x=[1;2;3], for i=x; i, end

x =
     1
     2
     3

i =
     1
     2
     3

>> x=[1 2 3], for i=x; i, end

x =
     1     2     3

i =  1

i =  2

i =  3
```
kannst du weglassen, ${project.build.sourceEncoding} ist default
style-nit: indentation is a bit inconsistent here and other places. This should line up with line 37 (only indented two spaces). Line 43 should only be indented two spaces.
MethodSorter is an internal class. I don't think you should define values that you want people to use here.

I suggest creating a SortingMethod enum
It's cool.  There's a button on the top right of your forked repo that says "pull request" - I think you just hit that - enter a comment and you're done. (obv. I already have this similar code - but just helping you out) :)
By the way, why have you move it?
Because we are locked in a version of webrat since it has Rails 3.x related bugs. :(
I've made these changes in my branch, and squashed it back down into one edit adding the whole file.
I'm fine with getter, what name do you prefer ? `wasCancelled()` ?
I was kinda following https://developer.mozilla.org/en/DOM/event (defaultPrevented is property as well).

Btw, you can hack it even with getter :-D

````javascript
scope.$on('someEvt', function(event) {
  event.cancel();
  event.wasCancelled = function() {
    return true;
  };
});
````
This commit broke compilation for win32
due to missing endian.h.
See http://mediaservant.info/jenkins/job/Lightspark-win32/55/console

In other code parts, we used glib's macros for crossplatform compatibility, see
http://developer.gnome.org/glib/2.30/glib-Byte-Order-Macros.html
and
lightspark's compat.h
Cool - should have sussed it was generated :)
Спрашивал у этих товарищей у них на канале, сказали, что нету.
It's a way to simulate the location in Xcode for the Simulator :
http://plainoldstan.blogspot.com/2011/08/on-gpx-files-for-xcode-42.html
Divs is not allowed directly inside ul tag.
Please don't look at this diff only when talking about stylistic issues! The indentation is correct in the appropriate file!
You're totally right, I was a hurry to get this rolled out for the PEAR guys. Fixed now.
@probins Thanks - in with ca2c3526b3f593646b74db442a6b4af7e618e6db
Done, but in a different way.
Additional DB updates (for UDB)

-- Additional script for quest 9737. Set npc 10917 hostile and attack the player
insert into event_scripts (id, delay, command, datalong, datalong2, datalong3, data_flags, comments) values
(11206,1,22,14,10917,10,1,''),
(11206,1,26,0,10917,10,2,'');

-- Silverhand paladins linking
delete from creature_linking_template where entry in (17911,17912,17913,17914);
insert into creature_linking_template values
(17911, 329, 17910, 143),   -- link cathela to gregor
(17912, 329, 17910, 143),   -- link nemas to gregor
(17913, 329, 17910, 143),   -- link aelmar to gregor
(17914, 329, 17910, 143);   -- link vicar to gregor
We do dominate everything, just not as overtly as when we had the British empire. :P
This says deprecated 12.3 not 12.1.
Actually when you want to share the netbeans project files usually you wouldn't commit the private folder. It contains settings specific to your machine and it will just create problems for those who try to clone it and use it for a netbeans project.
Well.. Marking a comment as SPAM is not a workflow supported by S9Y. So I let the xmlrpc user 
decide, what to do in that special workflow. If he decides to fire a SPAM event, the Bayes should 
react as if the user is clicking on the SPAM button in the comments list: Learn, then moderate or 
move to recicler.

These two events should be handled exactly the same as the valid / spam buttons in the comment list. 
When these events should be fired, the user will be able to configure. Default: moderate - do 
nothing exept pending, approve - learn as HAM (ham event fired), spam - learn as SPAM (spam event 
fired).
After next commit all this non-working-yet Calendar stuff is based 100% on me and my guessing structs skills :D so blame on me when you read the code and say "Who the fuck coded this shit!!!" :D

Now less words about credits, and help to make it work =)
For the date here you can use jQuery Date Picker. http://jqueryui.com/demos/datepicker/
sorry i love c++ xD

And trash of medium spire is coming :) id give a try to this SAI scripts, that i assume is the conversion of my c++ scripts to SAI right? a very clean job, congratz.
Hi, I have some time following the work, and I wondered if there is any way to find a patch for your version of Ulduar? is incredible.

sorry for my bad english
Original idea and images from http://catacombsnatch.info/forum/showthread.php?tid=26
why remove the licence? o.O
Yep... it was a coordinate issue. Needed to add a mapFromGlobal. There is a
video on opengis.ch.
Thx for the help

Marco Bernasocchi (mobile)
www.opengis.ch
On Feb 17, 2012 10:00 PM, "Nathan Woodrow" <
reply@reply.github.com>
wrote:

> Did you mange to fix that long click stuff with the legend panel?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mbernasocchi/Quantum-GIS/commit/b3efb0b406484c6bc2bf44919e982e85125f83ac#commitcomment-979775
>
I've removed checking presence in _regularParms as LinkedHashSet won't allow duplicates. I also did small performance tests with old and new code:
enu - 500000 different strings
_regularParams - 3000 strings (1500 present in enu)

Old stats: best(85) avg(97.97) worst(146)
New stats: best(73) avg(83.98) worst(126)
Does this still work correctly with Contao 2.10 ?
I used your fork to get this change specifically, and it works beautifully! How'd you know to add the route stuff to add_module? It even works with our custom SessionsController which inherits Devise::SessionsController.

It would be nice if someone would pick up the maintenance of this gem, it's a shame the original author doesn't seem to be active. Anyway, thanks!
My browser is using UTF-8, which enconding were you using when submitting the text?
I will care once everything finally works. Still heavy debugging ^^
Yeah, you're reading too much into it. It'll take like 5 nanoseconds to finish this entire function. You don't need it right there. Also, I added code that considers how many processes are running.
![FIREF … WHAT?](http://i.qkme.me/3647nl.jpg)
Repare que no final da linha de código colocamos o caractere ; o qual dá ao interpretador de JavaScript a indicação de que a instrução termina nesse local.
I changed the interface name from IAddthisBrowserLayer to IAddThisBrowserLayer to be in line with rest of the naming convention in the addon. If I remember correctly old layer is still needed to make upgrade step (https://github.com/collective/collective.addthis/commit/bcda06de85c0bf041c869d8e0869c1d06ac6d696#L9R11) work. This can be removed in the next major release.
lol, i think the previous implementation was better, you just moved the code from function to before the call, instead you can inline the function or use the vibrate() from previous commit.
I think it's a worthy addition, think I'll spend some time adjusting the current behavior to that rather than merge yours exactly, hope thats ok
Не уверен, что это делает её более безопасной.
В твоём коде -- да.
А в том коде, в котором она использовалась изначально, внесение такого изменения приведёт к дедлоку.
Т.е. это просто две разные функции.
Got it. For future reference, let's try not to push this kind of thing. This is the type of code you can keep on your machine for reference / notes, but our team repo should only have code that's mostly polished.

The general rule is that if you can't show it to a client, you don't push.
What do you mean by bus is also increased in ICS? 

Isn't bus calculated from the clock speed divided by the divider?

For instance in this case freq is 1100 and divider (second and third params) are 4:
/* L1 : [1100/200/200/100][166/83][133/66][200/200] */
{0, 4, 4, 1, 3, 1, 4, 1, 3, 0, 0},

So bus speed for cpu and gpu is 220. Right? At least that is how I understood it but I might be wrong...
And that's why wou always check your commits before you push.
Yeah I understand why it's separate from the core repo as it applies to all our repos. What I'm worried about is Repo pollution. I will look for an equivalent javascript repo. Does it make sense to pull all of them as subtrees/submodules to our styleguide repo?
You're right zach, my bad, it was like 5AM last night lol
I think this would be more clear as a case statement. Also, it is best to use =:=. == will do type conversion for numbers and so habit-wise, folks suggest sticking with =:= which is Equal Equal, not just equal. :)
Yes,  the *const* modifier is needed if you give the values per reference or per pointer. However, the source code will be changed by many others, and the value of an argument may be changed by accident. Here is an example:

void foo( size_t i)
{
   .....
   i = 10;  // by accident
  ..
}

If we use *const*  to size_t i as
void foo( const size_t i)
{
   .....
   i = 10;  // by accident
  ..
}
the compiler can detect this 'accident'.

Since most of arguments of member functions of this class are integer, which are used as indicies of matrix/vector entries,   and moreover  this is a sort of root class,  one can easily come cross the above addressed 'accident'.
Use `Y.log()` method instead of `console.log()`.
Why return when header is not found? I think we should do the reverse.
I'd like to remove all getInstance methods from classes. Just have this function to get a ref to the DIC (Elgg_ServiceProvider) and let the container manage all other instances.
If so, I think we ought to take a pass at the POM to make sure all other modules are consistent. As far as I can remember, the only module that noted "Jasig" was the EhCache. Almost all other modules use "JA-SIG". 

Could we do that as a separate commit?
On 05/11/2012 11:53, Graham Markall wrote:
> In pyop2/cuda.py:
> 
>> -    module.__solve(M._rowptr,
>> -                   M._colidx,
>> -                   M._csrdata,
>> -                   b._device_data,
>> -                   x._device_data,
>> -                   b.dataset.size * b.cdim,
>> -                   x.dataset.size * x.cdim,
>> -                   M._csrdata.size,
>> -                   solver_parameters)
>> -    x.state = DeviceDataMixin.DEVICE
>> +class Solver(object):
>> +    def solve(self, M, x, b):
>> +        b._to_device()
>> +        x._to_device()
>> +        solver_parameters = {'linear_solver': 'cg',
>> +                             'relative_tolerance': 1e-10}
> 
> It seems that cusp and PETSc use some different names for preconditioners
> (e.g. jacobi/diagonal) - I imagine that there will need to be a mapping from
> the names we are using to the CUSP names (or vice-versa - I guess we haven't
> decided to standardise on a particular library's names yet).

I think jacobi is a better name, so we can happily change the cusp interface.

-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.
this formatting looks a bit surprising (i.e. different first impression from true parenthesis structure); I’d suggest keeping all of `createInstanceFor` on the first line and start the next with `.recover`.
I prefer: repliesFromAddresses must be === Set(node(first).address, node(second).address, node(third).address)

Then you can replace 5 LoC with 1
should values in this cache expire? a node could go down, start a new remote transport and try to rejoin, could it not?
When does restart throw an exception?
:-)
I'd be happy to rename it to clock. I never liked timeMachine.
Ah, ok. Good with good commit messages :-)
Great catch, it's just residue from an intermediate solution. Will revert it.
true, it's not really internal api
no copyright?
It has to be removed in order to allow adding () to the other apply method: def apply[T <: Actor: ClassManifest](): Props
Else both have the same signature after erasure.
ok, because of Array, keep it as it is, np
:) Ah, I was already so proud to work on something experimental! AkkaX project or something
Alright, so what you're saying is that you want to fold in both "there is no such Metric" into "there is no value for this Metric"?

IF that makes sense in all cases then it sounds like a simplification.
Total misunderstanding. I know what "_" is.
No, this code is not called from my Remoting class, this is just there to  
make the old NettyTransport happy (he inherits these methods). In my code  
this is handled in EndpointWriter and it uses the address in the handle.
I think that many chunks just set @unmask_text, and these have a fixed unmasked value.  When a transclusion calls it's block, it sets @unmask_render.  I'm not positive this is the way this should be, but it works pretty well and makes sure it re-calculates @unmask_render on render! to the *Content object.

If we cal supply a block to as_json (It should have an optional Hash argument for options, that should be fixed in a later commit), possibly as a :unmask => proc do ... end option, then render! wouldn't be necessary.
This one will not new the card if it isn't there, it returns nil in that case.  I think the use case (setting_names_by_group) depends on it returning the card when it finds it.
Session.valid?  Session.in?  Session.live?  Session.signed_in?

I guess option #4 makes the most sense.
This should be lowercase 'sort'.
orientation_dep=None to filter() implies that the caller doesn't care about gesture.orientation_dep. 

If orientation_dep is None (unspecified), no filter is applied - all gestures are returned. If orientation_dep is specified (True/False), we return only gestures where gesture.orientation_dep matches the filter criteria exactly. With the proposed change, it would not be possible to specify orientation_dep=False to return rotation invariant gestures only (it amounts to "if gesture.orientation_dep = True", which obviously is not the intention).
.
Hope that clarified it; I'm sure there are better ways to write it. Maybe an 'elif' would make it easier to read.
Same comment as for form_to_db_schema()
@tobes Excellent. Many thanks.
Why not in uper case ? ;)
If this is intended you can remove the if-else condition completely.
Est-ce vraiment utile de faire un tableau pour une seule valeur ?
this argument doesnt exist anymore.

Similarly should have documentation of lock_mode
Please avoid reverting this recently added ellipse drawing code.
D'oh!  Good call.
Done!

El 19/10/2012, a las 01:54, Ben Combee <notifications@github.com> escribió:

> In source/DatePicker.js:
> 
> > @@ -15,6 +15,7 @@ enyo.kind({
> >  	name: "onyx.DatePicker",
> >  	classes: "onyx-toolbar-inline",
> >  	published: {
> > +		disabled: false,
> last thing I need -- a doc comment for the new disabled property
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
The goal of the base template being to factor out the `Some code`, `Some other code` parts.
The name of [CAConstraintLayoutManager](https://developer.apple.com/library/mac/#documentation/GraphicsImaging/Reference/CAConstraintLayoutManager_class/Introduction/Introduction.html) is a bit misleading – it's actually supposed to be instantiated for each layer that uses constraints, and set as the `layoutManager` property.

I'm a big fan of keeping stuff private unless there's a need to expose it, because then making changes later is easier, and will break existing code less often (since no code should be depending on it). It's always easier to make something public later than to try to make it private.
Simply put, use [CTLineCreateTruncatedLine](https://developer.apple.com/library/mac/documentation/Carbon/Reference/CTLineRef/Reference/reference.html#//apple_ref/c/func/CTLineCreateTruncatedLine). You're duplicating what it already does.
These still need better names.
Please use ```lu/Container``` and ```lu/Abstract```
I would remove this line and add `<a href />` tag to 'the Apache Harmony project'.
True, there are lots of places with hard coded values of this and that in Numpy. A NPY_UNICODE_SIZE macro might be useful, I didn't see one with a quick grep. However, I don't think current usage is a good argument for not making changes, you can look at the code in, say, the 1.1 release to see how much has changed in that regard. Just thought it might be useful to start doing things differently going forward if there is agreement on usage. I think the explicit sizeof is a bit more self documenting.
This change be noted in ``Qiime/ChangeLog`` since it involves a change to default behavior.
const mb
I dunno. Seems `delete` not required.
I'll remove this commit in this PR.
`request.body` returns an instance of `StringIO` here (maybe it can be something else in some situations), so it has to be rewinded after being read if anything may read from it again later.
We'll have two distinct errors: the old one for "only allowed for members of traits" and a new one for "not allowed on type members"
`scala.concurrent.context.minThreads` sounds fine to me.
You reimplement the ``__call__`` and ``ev`` methods, so would be good to test those.
typo "overlaping"
hek.attrs.EventType(EventType) should read hek.attrs.FL
On 29.05.2012 23:46, Aaron Meurer wrote:
>> +    def _sdm_to_dics(self, s, n):
>> +        """Helper for _sdm_to_vector."""
>> +        from sympy.polys.distributedmodules import sdm_to_dict
>> +        dic = sdm_to_dict(s)
>> +        res = [{} for _ in range(n)]
>> +        for k, v in dic.iteritems():
>> +            res[k[0]][k[1:]] = v
>> +        return res
>> +
>> +    def _sdm_to_vector(self, s, n):
>> +        """
>> +        For internal use by the modules class.
>> +
>> +        Convert a sparse distributed module into a list of length ``n``.
>> +        """
>> +        """
>
> Why is this here?
>

It converts the low-level representation of vectors from 
distributedmodules.py into a highlevel representation involving SDM or 
SDF. It allows all users of the PolynomialRing classes to access the 
lowlevel code uniformly.
Can you put some docstring here?
```

>>> var('A B C', commutative=False)
(A, B, C)
>>> (A*B*C - (A*B*C)**(-1))*A*C*B
(A*B*C - (A*B*C)**(-1))*A*C*B
```
They were used with the `schreier_sims` algorithms with `Jerrum` filter. The incremental `schreier_sims` is faster
than the one with Jerrum filter for big groups; e.g. with `RubikGroup(3)` about 5x times, with `RubikGroup(4)` 
`schreier_sims` with `Jerrum` failed. For small groups they are equally fast; therefore I eliminated the slower algorithm,
which I implemented, and left the one implemented by Malekov.
I'm not familiar with the sphinx system. Is there some nice place where I can read about what I have to do?
bad align
usually I avoid environment variables, and I'd like to ask users to explicitly pass the path through the `rst2pdf` argument
just noticed that all the options described in the docs of `copyDirectory` are completely ignored...!? Has nobody noticed that until now, or am I overlooking something?
We can remove these iVars now since they should be automatically synthesized.
Are you sure that these should be "null" as a string? I don't think that will work.
No, leave it in bin but under run_in_background, i.e., bin/run_in_background/daemon_wrappe
Add a comment at the beginning:
# Don't run manually, used from inside of lib/run_in_background/...
We should also document these errors.  Even right now, I', not sure what the difference is between `integrity` and `nomorepaths`.  I'm almost sure that they're the same thing.
preserves the database name on the destination instance.
this might be superfluous? i.e., if we can use doc.current_revision.creator in the template? can put `{% set current_revision = doc.current_revision %}` in the template so we don't have to type `doc.` every time.
should be encode('utf-8', 'ignore') yes? with 'ascii' I got this: http://pastebin.mozilla.org/1725317
break to next line? it looks like it's past the typical length limit?
Change a OODAtech temporairement. Je m'etais dit que ce serait mieux d'avoir un nom court parce qu'on ne le verrai pas au complet dans le 'tab' de certains browsers sinon. Mais c'est un peu laid OODAtech alors je le changerai eventuelllement pour OODA ou OODA Technologies.
Again, this is an expression and not a query.
These are not array keys but values.
Actually that was a copy and paste fail.
Should be:
    
    if (!is_dir($this->phpbb_root_path . 'ext/'))
Why was this changed? The setting to use board default style is 0.
Is this really an array? $config is an object now.
A bit below.
From an engineering point of view, I'm uncomfortable with this being Trustworthy vs Safe. It's saying that yet another level of abstraction is part of the TCB and couldn't be replaced by a "better" layer by application developers or someone building a library for HAILS apps or whatever. See below for comment on pain point.
Which method? IsValidCultureInfoName is something @grumpydev asked for to be public
Seems odd that zorder isn't needed to be set here, given that it was in TEC. Can TEC's zorder kwarg be removed?
in the absence of comments, calling this variable "clear_storage_map" would be more helpful I think.
Minor nitpicking: I don't think you can have ":" following "!" (though I'm not 100% sure)
Looks like a debug print to be removed.
Thanks. Is this pre-check done inside of the optimization itself? If yes, here's my proposed re-write of the 2nd paragraph:

The problem with DebugMode is that it will trigger a useless error when checking a rejected inplace optimization, since it will lead to wrong results. In order to be able to use DebugMode in more situations, your inplace optimization can pre-check whether it will get rejected by using the ``theano.gof.destroyhandler.fast_inplace_check()`` function, that will tell which Ops can be performed inplace. You may then skip the optimization if it is incompatible with this check. Note however that this check does not cover all cases where an optimization may be rejected (it will not detect cycles).

Is that accurate?
I think I meant just IGNORE m_needsSubstitutePostExpression.
This two methods are documented in their parent class TableIndex. Should I also add comments again to the child classes?
Minor minor minor indentation issue.
Does the same thing. It looks better to use the same phrase as the previous line.
Drop the "is_", it should simply be named: ip_exists
3 strikes rule
I would remove the ``&& true`` here. It is useless (even if I recognize it is a copy-paste from some other code) :)
should be ``&& ! $index->isPrimary()`` according to the Doctrine CS (we use ``=== false`` only when really needed, for instance for ``strpos`` where ``0`` is a success)
Do me a favor and drop a line break in before these two lines - thanks
What do you mean here? Actually, the size of the array is not hard-coded. We calculate and store the value to array_length.
What is the benefit of renaming chiSquaredCDF to chi\_squared\_CDF?
Agreed. A lot of this can move back into `Server` and each connection can maintain its own buffer. The API exposed could be something like:

```
# initialize buffer, send NOOP
Server#multi_response_start

# read into buffer and parse incrementally. return all values on success and cleanup buffer
Server#multi_response_nonblock # => :again
Server#multi_response_nonblock # => :again
Server#multi_response_nonblock # => {'key' => 'value'}

# assume IO timeout and mark server as failed/down, clean up buffer
Server#multi_response_abort
```
I don't think it'd be easy to change `SHAREDIR` just for extensions, and also I think it's too late to get a proper change into postgres 9.2, which means any sort of proper fix for this would be in postgres 9.3 (september 2012 if they keep to their schedule).

I'm willing to make this into a tap now that homebrew has taps. That seems like the best approach assuming the cross-keg thing is a deal-breaker for main homebrew.
Remove comment here
Are these really needed? It doesn't look like the formula uses them.
This is pretty unwieldy---it would have to be updated with each Clojure version. How about using string interpolation to splice the auto-detected version in: `"clojure-#{version}.jar"`?
Was it necessary to strip the test?
Yes, we should keep the remainder of the docstring.
The part of the docstring that has the "This is equivalent to..." should change to reflect that it is now equivalent to `EndAnnotationTracer(BufferingTracer(...`
You're only setting api_username in one method. It probably isn't necessary to override initialize.
Is there a way you can do the same trick? One loop instead of two, and one collection instead of two?
> Maybe we could parse to the stdout but keep a flag for the theme? --theme to keep the current way working just as well.

That's fine.

> Also we use the theme as the textdomain right now but what should we provide as a default value if none is set?

Maybe the default textdomain could be 'YOUR-TEXTDOMAIN'.
Ack! "lick it" not "luck it"!!! :)
Like the other places, a comment here would help.
We should almost never set style directly in JS; we should use a class instead. The convention is to use a class of "hidden" to indicate that an element should be hidden, and to adapt the component's CSS as required.
No—since the media feed is getting parsed through a capability, when the component is loaded, the page will have no video attribute at all; media is added later or destroyed based on whether the media feed has a video for it. If a video asset is present, there will be a videos attribute on the node and its length will determine if we should show a video player.

Writing that out, it's rather jury-rigged. A better solution might be rewriting this check to run later in the component's construction, destroying the component if it hasn't received a video yet.
Nice refactoring! Very clear.
I took a look at it but I'm not sure how to differentiate that the scroll event is happening during a drag as opposed to a real scroll event. But the two events look like they have a totally different structure (one, I'm assuming being fired programmatically and the other from a real scroll event). But even if I can differentiate between those two events I'm not sure how to make sure it's a drag event and not another event that's calling .triggerHandler("scroll"); 

I'll do some more research.
hintList is initialized as long as a session is active, and isn't accessed unless the session is known to be active. I'll add a comment explaining this above inSession(). But, again, I'm happy to be overruled on this if you think it's better to be defensive.
This change should also be made in `Makefile`. Other than that, LGTM.
It seems you are forgetting about all subfolders and subfiles...
I figured out how to do without it, so removed this.
This magical number comes from mpmath. Don't know how they came up with this.
But it works very well.
Thanks, I made the change.
Move the definition of CoerceAPI into here as a before block just like in the `presence_spec.rb`. These classes pollute the global scope and have unpredictable results. Or namespace it the same way as `CoerceTest`. We should pick one way of doing things, right now there're `let's` and modules and examples and all kinds of other fun stuff, I'll go cleanup master into one of them (probably module-based).
modifier order is wrong, and why isn't it `private`?
I've been conditioned to leave out `else` after `return` because it's redundant:

```c
if (as_obj)
    return rugged_object_new(…);
return rugged_create_oid(…);
```

But reasonable people can certainly disagree about this. :-)
Is it best to drop these since they're empty?
Use `"""`.
I used escape filter.
*What bothers me is how can we access these additional user data from a template? With current (I agree) crappy solution is as easy as user.gender.* << Also when you extend the provided User document with ours you can access this in the same manner. This mongoengine makes sure that all fields are simply accessible.
Jon seemed to want that back in when I pointed it out to him that it wasn't there anymore. Up to you if you want it in or not.
Right, I agree. I'm just being consistent with the original codebase here.
Missing brackets?
I think @nvcVincent can move this to head. Ehm... It didn't occur to me this will be called twice. I'll get this fix ASAP.
If there's a better way to write this that uses Fog.mock then that sounds great.  I found that I was getting errors because I didn't have AWS access keys configured.  Maybe we should include a config/amazon_s3.yml in the repo that has 'redacted' access keys (ie. all x's).

My objective is that we should be able to clone the repo, install the bundle and then run 'rake' and it will run all the tests without using external dependencies like AWS, iMedidata, Dalton, audit service, etc. etc.  The further out towards the 'edges' of our app we can test, the better, so if we can use Fog mocking then that's great.  I don't know much about that so I haven't done it.  If you know of a better way to do it then let's do that.

I'll look into the Fog mocking as a better way to do these tests.  In the meantime if you agree that this PR is an improvement and does not make anything worse, then I'd like to merge this PR and make any further changes in a future PR.
This shouldn't be necessary -- the connection should be automatically removed from the waiting list when its closed.
Line length (100 max)
Yep, whoops. Updated in a subsequent commit.
Make this optional. If the argument is not passed, then do ls in merge stream directory and get the stream names
Syntax question:  should we be consistent using the built-in nil check i.e: 

`unless match.nl? && match[1].nil?`
Could you expand a little more what you mean here?
Since you call this 3 times and it's rather long, what about making a xxxx? method.
I'm wondering about performance, if the number of hubs would be big. Returning `IList<HubDescriptor>` would mean the enumeration of the whole merged collection of hubs would happen twice. Maybe I'm just thinking too much about performance...?
If there is only one event to handle you wouldn't need to do this.

If you are planning for the future use `switch (evt.type)`.
`msgListView`

**List** and **View** is of different word. Unless you want to made up a new word in the code (if so you need to change all the instance everywhere in this file)
nit: I guess you can omit |window| if you want to save some space
Yes - though I'd rather force the conversion here since it is safe to do so. We can still consider merging #460, but I think we might as well explicitly convert it in the reader.
Heh--Edwin Hubble is a test observer on a lot of pyfits tests too.

I once wrote a test suite that practically read as a piece of Evangelion fanfiction, but that's about all I'll say about that.
All the absolute imports were a workaround to get the tests to run on mac before pytest 2.3.3 was in astropy.  I forgot to put them back, but will do so.
为啥所有方法都是public的？ 隐藏方法啊隐藏方法。
GetProxy(NET_IPV4, address) is safer, I think.
You should use ``QLabel { color: red; }`` as styleSheet and also remove the HTML parts and just input the raw string.
This one should probably be folder5 as well no?
I had to change the line [1] in start_update_notifier and then noticed we never handle that message. I could go back and make this two commits so that we fix that bug and then add this commit on top to make it a bit more clear. But mostly it was just my OCD of firing off a message that we don't handle properly.

Also, I think the note about rexi_EXIT and rexi_DOWN should be to just handle them like this instead of vice versa.
is "eith" supposed to say "to" here?
I'm not familiar with writing tests for javascript. Craig, do you have a preferred method/testing-framework?
Using the string "block" here seems less than idea. Maybe position shouldn't be a string, but should be an actual object, which can implicitly convert to a string. I'd prefer if this code went:

```ruby
if position.block? && !previous_position.block?
```
Please use a more verbose name, like buttonNumber.
Did you really meant to make this public?
Tested as 9999 on a real PSP using your code.
endswith can accept a tuple of possibilities, so this can be a bit cleaner.
seems awkward to have the vbox version as a test property, maybe you could use a vbox specific property, e.g., <vbox.version> and make the test version refer to that as well as the dependency version.
clever.  probably should note that this user will have sudo access to root
use guava eq/hashcode pattern
Is it logical to have columns filter on Eloquent?
`symlink()` may not be a supported function on Windows.
Good. :-)  Merged, thanks.
The file still doesn't pass JSHint though. :(
oh snaplicious. been there, done that.
Doh! You're so right! What an amazingly stupid thing I asked! Ha!
Hmm so this means that starting up middlware will not be possible without copying this .ini over and specifying this file, right?
Is there a reason this can't be done as a default in the file?
I completely agree with this; I just re-factored without knowing exactly where it was used.
does ferret itself need these dependencies?
Is the buffer cleared anywhere, and are data events emitted on the response after the header is received?
Actually, since I moved conversion to happen in `RestAdapter#invokeRequest` the nesting is no longer needed here.
Wait, aren't we deleting core?
This is useless IMO as you are unable to pass a ``Memcache`` instance without the extension anyway
It's not from me...
Doctrine also returns collections instead of arrays.
The convention for defining predefined php classes is to use them in-line prefixed with a backslash.

For example:
```php
class Options implements ArrayAccess, Iterator, Countable
```
becomes...
```php
class Options implements \ArrayAccess, \Iterator, \Countable
```
with the use statements removed.
Wrong indent.

Also what with: https://bugs.php.net/bug.php?id=39992 ?
maybe you can mark this test as a "benchmark" group so it can be excluded easily 

```
/**
 * @group benchmark
 */
```
phpunit.xml.dist already does exclude this group

```
    <groups>
        <exclude>
            <group>benchmark</group>
        </exclude>
    </groups>
I understand that they work fine, was suggesting that both be the same for consistency. Guess we can't take lastID out of api call anyways since web uses that now.
Um, String::Quote() does not add beginning and trailing quite, you have to add it manually, eg:
```ruby
"/bin/logger '%1' -- '%2'"
```
But in this case you probably need to pass the optinos as a list so it's not passed as a single argument. And quote each list member separately.
这一行是没用的话，应该尽量避免类似的口头语
acutally => actually
segmentationMarker
stylistically im ok with


```ruby
  result = instance_variable_get("@#{association_id}") || begin
     # code goes here
  end
```

do you not like this? its more readable for me, not sure about u
needs removing.
Again, I think this is done in #104.
Use the one true brace style. Space after if, braces surrounding even single-line conditionals.
yeah, no need to those comments, if people are digging into the source, they should know this already :)
This looks like it is indented one level too far.
Did you forget this or do you really intend for this plugin to be on for the testrepo?
Wouldn't it make more sense as an abstract class ?
Same as edit.php, $parentTag does not have to be instance of eZTagsObject -> fatal error.
Does this succeed if the directory doesn't exist?  (I can't see if you replied to the previous comment because it was attached to the commit).
i renamed the corpusid and corpusname variables to all be lowercase to match the corpusname in the models, but maybe it should have gone the otherway, all camel case, and change the corpusname to corpusName
these are just changes resulting in my experimentation with trying to make sure the sapir user was read only. in the end i came to the conclusion that we might have a problem replicating from things taht are read only, mostly because we are replicating to first, and replicating to seems to try to write a doc in the remote couch (maybe as a lock? or to know where it should start replicating form) and this is unsuccessful. so when sapir was read only, i wasnt able to pull down his data. in the end i commented it all out to be worked on in the future when we start working on what data looks like when not authenticated.. my plan is to run abuild script that takes the user to a page with a main js that only has read only views, and only a replicate from in the corpus. that might work...
J'ai mis la même regexp en Javascript et en Java histoire que ce soit consistant.

- Pas de blancs
- Pas de caractères de ponctuation :  !"#$%&'()*+,-./:;<=>?@[\]^_`{|}~
не понял что это
I will check indentation throughout that file
This will work every time for the case we care about (coming back to the dialer), but I think it would make sense to iterate on all the attentions screens, put the one that match (if any) on top of the others and then expand the overlay.
Did you test music playback?
You should use CSS transition and do transition on `visibility` and `opacity` instead.
can we do `action2Node.className = ''` instead, we don't have any class on the initial markup.
ok im going to take a look
should be `data-option-index=1` and `dataset.optionIndex`. camelCase conversion happen automatically on platform.
Event->CustomEvent?
It does not work? F**! can you open a platform issue in this case so someone will fix it?
Yes, thanks for clarify.
we've been putting scripts up in the head with the defer attribute in other apps.
Are you going for backward compatibility for this one so it runs on older browsers?
No need to shout in the string :) Let's make it a NoICCId
it can be put under the `Icons of toolbar of dialer` section for now
Yes, now SMS App is handling this issue properly. 'mozvisibility' handler will manage it!
This function seems unused. Let's remove it.
`parseInt(link.dataset.id)`

a lot easier than `link.getAttribute('data-id')`
Great idea, modified.
There's actually a race condition on this line. Whenever invoking the scheduler you have to isolate the code within the submit-lock of Nimbus. I fixed this here: https://github.com/nathanmarz/storm/commit/488734aba329f7819c6f1fab218fdaea034302b9
I added the test for the first one and it seems OK.

But there is a slight problem with the second one as there are two messages. Something like:

    >> BaseForm[12, -3]
     : Positive machine-sized integer expected at position 2 in BaseForm[12, -3]. 
     : MakeBoxes[BaseForm[12, -3], OutputForm] is not a valid box structure. 

Is there any way how to show just the first one?
setUp and run_inputs appear to have been duplicated a number of times. Could you create a ticket for factoring these methods out into a common base class?
Can we use:

    return false unless a && ! a.empty?

What's the goal of validation_args? Can we simply make get_cli_var and get_web_var raise an exception if it doesn't find all variables we ask it to retrieve in the first place?
@jessicabarbalho, ask @julianalucena if this should be loaded through lazy load or this is fine.
``isInstanceOf``/``asInstanceOf`` is not 'best practices' in Scala. The following code should be equivalent.

```scala
apply.args.lastOption match {
  case b: Some[Block] =>
    b
  case _ =>
    apply.args match {
      case List(a: Apply, _*) =>
        findBlock(a)
      case _ =>
       None
    }
}
```
With a instance variable for the limit (here: 4) it would generally be more configurable ... also, see line 120.
Could you add some code to do something like:

--JobOne:outdir j1out --JobTwo:outdir j2out

So, any args prefixed with "<jobname>:" would only be passed (with the jobname removed) to one of the particular jobs?  This is useful because there could be collisions in the names of the args (for instance output or outdir is probably going to be common).  This gives some namespacing.
I don't understand this comment. Should this instead be something like "The probability that we should terminate an AppServer that has exceeded its memory limit"?
@bricel, Please add Behat test...
So here's what I think about ChatChannel so far... I think it should probably just be...
```java
final String name;
final Set<ChatComponent> listeners = new HashSet<ChatComponent>();
final ChatArguments format;

String getName();
Set<ChatComponent> getListeners();
boolean addListener(ChatComponent);
boolean removeListener(ChatComponent);
void setFormat(ChatArguments);
ChatArguments getFormat();
void broadcast(Object... message);
```
This C++ trick doesn't work for C.
This functions seems to be duplicated in a number of places.
Also, it seems like it would make sense to call it from the end of the `assertBuildsetAdded` functions
Do you know if there's another way to set up a correspondence? AFAIK the only way to make a correspondence between characters of a pattern if via backreferences, which works for `%r|regex|`, but not for `%r(regex(`.
Can you explain why it's wrong? It doesn't say it contains credentials.

Can you give me an example for the phpdoc?
Use `None` for not "not present"
Copy paste was detected :wink:  It's not critical just FYI
Is it  works with private posts?
Why not leave the `layout :admin` in the `AdminController`? and override if necessary. Which could be by using your `layout_type` helper. 
But I think setting the layout explicitly in the controller is not so bad, that way it's always clear which layout is used.
Yes. It's more for sharing purposes, if I want to tweet a link to a given image.

Even the current (code not touched for years) desktop galleries do this: http://www.guardian.co.uk/sport/gallery/2011/sep/18/tour-of-britain-cycling#/?picture=379188041&index=10

Nicely, those hashbang URLs will work on these new galleries too, so you'll still get to the correct offset.

Agree that the back button thing is tricky: on guardian.co.uk they get around this with a "Back to article" link if the gallery is attached to a story (that one isn't, sorry).
Why use p->payload, not "pkt"? The decode function normally operate on the buffer that is passed to it through the function parameters.
xffip should then also be a uint8_t I think
Comments above 'config' lines in logstash plugins are what are used to generate the plugin documentation. Each config call should have some comments detailing what it is for and possibly some examples
expecetd -> expected