Community Edition 3.8.4 Release Candidate 1

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge remote-tracking branch 'origin/candidate-3.8.x' into candidate-3.8.4

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge remote-tracking branch 'origin/candidate-3.8.x' into candidate-3.8.4

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
gh-2938 Fix Configmgr - Component tree collapses

  - Upon deletion, focus will be on the parent row.
  - Upon duplication, focus will remain on the selected component.

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Manually merge pull request #3268 into candidate-3.10.x

Commits squashed and commit formatting fixed.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
gh-3136 Configmgr - Improper notification of config file change
- After generating a configuration using the wizard. Selecting
  advanced view will no longer causes a refresh of the configuration.

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Merge pull request #3316 from garonsky/issue-3136_Configmgr_Improper_config_change_notification

gh-3136 Configmgr - Improper notification of config file change

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
gh-1874 Configmgr - Enable deletion of attributes

  - In XML view clicking 'Delete' from the context menu,
    deletes the attribute and its' value.
  - No validation is done on the delete.
  - Context menu 'Delete' is available only for attributes.
  - Only attributes that can be specified using an unambiguous XPath will
    succeed.
  - Deleted optional attributes appear in red.
  - Context menu closes when clicking off the menu.
  - After delete, nested XML Tree View refreshes to previous location.
  - Incorporated changes based on review feedback
    - Fix handling when deleting EnvSetttings
    - Improve focus after refreshing table

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Manual merge pull request #3226 into candidate-3.10.x

Reviewed-By: Kevin Wang <kevin.wang@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
gh-3313 Memry fragmentation issues

Add a unit test case to assist in investigating suspected memory fragmentation
issues.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
gh-3321 Fix memory leak for large blocks in memory manager

The heapHWM variable was being updated incorrectly when a block of
memory was allocated.  It should have only been updated if this could
be guaranteed to be the top block of free memory.  Instead it was
updated unconditionally which meant that blocks of memory could be
leaked and could never be reached again.

Experimentation indicated that it was unlikely for the correct update
condition to be met, so it was simplest to remove the heapHWM
altogether, and always search the full memory range.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Merge pull request #3322 from ghalliday/issue3313

gh-3321 Fix memory leak for large blocks in memory manager

Reviewed-By: Renato Golin <rengolin@hpccsystems.com>
Reviewed-By: Jake Smith <jake.smith@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge remote-tracking branch 'origin/candidate-3.8.x' into candidate-3.8.4

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Community Edition 3.8.4 Release Candidate 2

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-7807 Change commit-msg tests to Jira

Commit message checks in .git/hooks need to change to reflect the change
from github's issue tracker to Jira. Please, copy this file to .git/hooks.

Signed-off-by: Renato Golin <rengolin@hpccsystems.com>
Merge pull request #3331 from rengolin/githooks

HPCC-7807 Change commit-msg tests to Jira

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
HPCC-1874 Modify code to avoid using dynamic array allocation

Previous fix causes compilation errors on Windows compiler.

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Manually merge pull request #3330 into candidate-3.10.x

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-7811 Fix DFS filename rename issue

A regression introduced by GHPCC-3083, cause multi-part logical files to
fail when renaming.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #3332 from jakesmith/renamephys-fix

HPCC-7811 Fix DFS filename rename issue

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>