labofsahil/github-event-dataset-2012 huggingface dataset:
Value entities can be linked to either Location or DataLocation - hence the generic property name location
Use OpenLayers.js and ext-all-debug.js
Why this line? We do not do imports like this. And you have `template` module already imported above.
Start with the upper case letter.
Why you do this through JavaScript?
Ah, btw, this could be lowercased. Because upper case is often then done in the template, if wanted.
I use `forEach` so `./list` is required.
How about adding a `defaults` array here, so the plugin tray actually has things in it when you boot up?
I tried pretty much all of our other mouseup listeners and it doesn't look like I can stop propagation anywhere else.
Any way this could conflict with jQuery at some point if it's included in export?
Bug report is here:
https://bugzilla.gnome.org/show_bug.cgi?id=689075
Why doing this via function? why not just export an object with two properties:

``` javascript
module.export = {
  test: function (actual) { /*...*/ },
  expected: [
    // ...
  ]
};
```
This should all be moved into a processMsg function, with the target being a placeholder for now (which will trigger the game code), and eventually turning into channel names.
ngx_event_timer_empty_pt -> ngx_event_timer_is_empty_pt
Please add a precondition so we don't allow naive clients to shoot themselves here.

How about reset document, topicVector fields to null before each new key and ensure those vars are null before assignment?
It should be trivial to fix with a custom style, maybe bootstrap has something for that too. I haven't looked though, because I liked that solution and wanted to get your opinion on that.

Now that I have it, I'll rework that patch. What's your stance on the centering of the menu (I hope you understand what I mean)?
This return a set of all interesting, forked, and starred repos. Def needs to be refactored.
JavaScript 秘密花园是一个不断更新的文档，主要关心 JavaScript 一些古怪用法。 对于如何避免常见的错误，难以发现的问题，以及性能问题和不好的实践给出建议， 初学者可以籍此深入了解 JavaScript 的语言特性。
No real need for this comment, the context+spec should be enough. Also, always try to respect 80 character line widths.
you should also add it in the ``require-dev`` section as it is needed to run the testsuite fully
you should put it in ``require-dev`` too, to have it when running the testsuite
Building the filters on attribute isn't a good design. There should be an interface instead. ```IFilter```
Was thinking about that and 'Descriptor' seemed the best. 'ActionInfo' or 'MethodDescriptor'?
yes you're right. This is just a skeleton. this just means that an error needs to have a interpolate method (and in my opinion a convolve method as well).
I really think making this record would be worth it.
Possibly. I think the current semantics is pretty vague. Some of the flags are usable, but not modal, because it's separated out to a different parameter. A pull request to change this would affect exactly the same areas as this one. So let's try to do it right in one go.
This needs to be inside an #ifdef USE_IPV6
I always use this coding style for if/expressions:
 
    if(a && !b && ((c + d) < e)) 
    {
    } else {
    }

You can recognize other people's code if it is different :-) So I prefer it that way, but won't reject pull requests on it unless it's an absolute mess otherwise. 

My point was that here's no need to change this function in this patch. We like minimal changes, as they make merging easier.
When I now read the first comment all that makes sense ^^ you are such a patient person :-P.

With your new code we would pass hSocketMax == 0 to select(), when -proxy is invalid (no BOOST_FOREACH pass), I'm not sure if this is valid. But you are right, when hSocketMax stays 0, we have no fds set, but I'm not sure if it can ever become 1. It would be 1, if vhListenSocket or vNodes is not empty and the contained sockets are == 0.
I see. I thought as it passed on the tests, it was okay the change, maybe what about another way to ensure the class is autoload, it's quite weird two conditions nested doing the same check.
I usually try to avoid conditional define() calls, and don't really like the ones that already exist in cake.  I think splitting things up makes sense for now.  I'm planning on reworking the console bootstrapping for the next major release anyways as its a bit convoluted right now.
Can we add a default return? throwing an exception sounds a bit too much for view related code
Assert_always(!"Got a lookupHost() request with an unexpected lookupArgs state.");
Rule #5: Do not abbreviate
A week may start not from day#1 for some locales.
This will break for the locale, not similar to en_US
Is there a reason you test each of these individually rather than just asserting the overall structure is equivalent?
Yep, no problem, changed it!
good call, Done.
note you can use Charsets.UTF_8 instead of making a new constant
clone strategies should be an enum.  The property should not be namespaced test, rather jclouds.vsphere.clone-strategy
no because that will bind explicitly to RestAnnotationProcessor<?> which isn't any better than RestAnnotationProcessor, except more complicated to bind
I'm not actually sure why this file was included. I originally opened a pull request on the master branch then realized I should have pulled on the develop branch. When I made the change, this file updated. Is there a way I can exclude this file from the pull request?
The installations I work with offer Visual Studio Whatever and Visual Studio Whatever x64
this should be annotating any function with a newsletter form. I'm not sure how it got separated in the views for mozorg, but it should be on the "home" view. You can remove it here.
Shouldn't all the text on this page be enclosed in `_()` for l10n? I believe we're doing that for all text in bedrock templates now. We can check w/ others on that though if necessary.
definitely! good catch

On Friday, October 5, 2012, Rehan Dalal wrote:

> In apps/wiki/showfor.py:
>
> > +ALL_VERSION_GROUP_JSON = json.dumps(
> > +    _version_groups(FIREFOX_VERSIONS))
> > +MOBILE_VERSION_GROUP_JSON = json.dumps(
> > +    _version_groups(MOBILE_FIREFOX_VERSIONS))
> > +DESKTOP_VERSION_GROUP_JSON = json.dumps(
> > +    _version_groups(DESKTOP_FIREFOX_VERSIONS))
> > +
> > +
> > +def showfor_data(products=None):
> > +    """Return the showfor data required for the passed in products.
> > +
> > +    If no products are passed, we will return the showfor data for all
> > +    (mobile + desktop).
> > +    """
> > +    if products is None:
> > +        slugs = ['firefix', 'mobile']
>
> Should be firefox?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/kitsune/pull/878/files#r1772654>.
>
>
nit: blank line between method definitions please.
This should really be an assert. If it doesn't exist we would fail in loading it with a less helpful exception.
After looking into this further, I'm certain the diffs will still work as expected.
``if not params.versions or params.versions[0] == '':`` would be better for the very-unexpected-but-yet-maybe-possible case where ``params.versions = []``.
Please add some foreign key constraints.
Ok, j'ai donc définitivement les yeux qui se croisent :) Je vais encore re-tester from scratch avec le manifest puppet que j'ai préparé, et je mettrai à jour ce pull-request ou en ferais un nouveau au besoin...
It is leftover from the original source, yes.
Yes there is a need to do a count which is currently done by code `empty($tokenExists)` and it works but it seems more natural do the count in SQL, doesn't it ?
Maybe nicer: There is no dumper associated with format "%s".
it should be ``if (!file_exists($file))`` to follow the Symfony CS. We use the strict comparison with ``false`` only for cases where it is necessary (such as ``strpos`` which can return ``0`` with the opposite meaning)
I'm not opposed to it, I'm not sure about the benefits of one slightly large function compared to ten or so small functions.  Thanks for contributing btw. :)
I fixed the problem it by changing it to double in this sub-branch:

https://github.com/brainstorm/DRASS/commit/a6546f564198479b9ae030f79ae1c6a53ab2d905

If you did (don't do it):

<code>
git pull roman feature/python_module
git pull roman error_rate_bug
make python
</code>

You'll see it's fixed, but it does not make sense! A float has enough precision to hold "0.0005".
No? If there is no entry, the domain is available. Or am I missing something? :)
I personally don't like this formatting style for else if blocks, but it's consistent with what's used elsewhere in the file, so I wouldn't change anything now. Do we have a style guideline for this kind of stuff?
Ok, didn't think about the local use case, but in that case one's env is already setup by rvm when running from command line - this script is really only needed for running rubber from cron.

If you can get things to work without forcing upgrade, go for it - might be tricky and time consuming though
In other words it's part of this classes API.

Sent from my iPhone

On Dec 6, 2012, at 4:34 PM, Adarsh Pandit <notifications@github.com> wrote:

In spec/models/group_private_messenger_spec.rb:

> +
> +    help_out_text = UserPrivateMessenger.new(invitation, sender).get_help_out_text
> +
> +    help_out_text.should == "out #{invitation.event.owner.name}"
> +  end
> +
> +  it 'return me out when the recipient is the owner' do
> +    invitation = build_stubbed(:invitation)
> +    sender = build_stubbed(:user)
> +    invitation.invitee = invitation.event.owner
> +
> +    help_out_text =  UserPrivateMessenger.new(invitation, sender).get_help_out_text
> +
> +    help_out_text.should == 'me out'
> +  end
> +end

Here's another strike against use of the module: we're testing it inside
group_private_messenger_spec.rb which seems to cross county lines.

—
Reply to this email directly or view it on
GitHub<https://github.com/yammer/sched.do/pull/238/files#r2343635>.
az akhar nafahmidam bayad chi bezanam inja :D
nu se folosește rspec?
```ruby
print_check(s.gemfile_exists?, "Gemfile exists")
```
If there's no specific evidence either way I'd leave it out of this PR and make the change to master instead.
Don't code late in the evenings, or double check to remove all your print statements
This function, like Ember#compare, must return an integer
Should this perhaps depend on the properties listed? Now it seems to be calculated once and used forever.
Ok, now it should be there
These properties are not common between the sub classes Remote and Managed. It's only applicable to Managed
I would not deprecate this version of method, as by default users/developers should not need micro version specified other then 0.
if we deprecate this method, users will try to use it and define it to something else then 0, which then renders this attribute useless.
in any case non-eap versions should use this method, and eap the one with microVersion, this way we can make sure it is used only for maintenance.
Can you add that demo, maybe along with adding datepicker, autocomplete and tooltip inside one of the dialogs?
This needs to be restored. Restoring this will change the order of events though.
"to take the data apart again" sounds better to be. this one is personal preference :)
Remove these comment
Hi @etiennesegonzac Just to verify I get your point. In which file do you suggest to place the Confirm BB HTML template, in /apps/communications/contacts/index.html ? In /apps/communications/contacts/index.html but also in /apps/communications/contacts/index.html ?, so that the ConfirmDialog code just configures the final Confirm dialog appearance and behavior. We have to keep in mind that the final HTML code may have to be placed in the dialer/index.html file (in the case of the Comms app when the Contacts are running in an iFrame, we want the dialog to cover the tabs at the bottom of the Comms app) but also in contacts/index.html (in the case of the Contacts app running in its own). On the other hand, the ConfirmDialog code will also have to deal with the showing/hiding of the whole dialog but also of some of its internal elements (the title, the second button in cases when only one is needed, etc.).

Regarding the first question, my suggestion would be to place the Confirm BB HTML template both in the /apps/communications/contacts/index.html but also in /apps/communications/contacts/index.html and use ConfirmDialog to properly configure, to show and to hide it. Otherwise, we would end up having to inject code in either of those HTML files.

Please, comment ;) Thanks!
I recommend using an sprite for this kind of images switching to avoid unwanted flickering when changing from one state to another:

normal / active
Same comment as above about the format.
Yes. thanks.
The "str" here seems unnecessary.
Any reason why the `<literal>` tag has been removed?
Shouldn't it be `\W` and even so wouldn't `\b` or `\s` be more appropriate?
if (!CanDetectAppDomainRestart)
The command executor was made for our http based console support (not completed as yet) and it's fully tested. The Executable is used everywhere else in our code path and has some nice helpers for bubbling stuff out to the console (as well as other helpers) so you don't have to do it manually.
This line looks messy. Change it to:

```csharp
var siteBindings = new List<string>();

if(!String.IsNullOrWhiteSpace(_settingsResolver.SitesBaseUrl)) 
{
    siteBindings.Add(applicationName + "." + _settingsResolver.SitesBaseUrl);
}

```
- Are you sure the method ``getDatabase`` can be called on ``$appData`` (of type "null|object<AppData>")?
- Are you sure ``'test1'`` has the correct type as "string" is not a sub-type of "object<Database>|null"?
Sam comma space nitpick. Not important, your choice.
Definitely.  My first goal was just to make sure the scala compiler got the type inferences right - and a spec isn't necessary for that, since we just need to make sure that it compiles.

But I certainly want more testing before considering this for a merge.
Be more descriptive here.
Also, shouldn't we be specifying an explicit keyspace here?
Yep, thats the intention. And where I use that feature, I have a button on WebStatus that is essentialy wired up to insubstantiate.
no need for ``else`` as the ``if`` leaves the function because of the exception
oops.. missed that cancel.. my search through the file went wrong.. :-)
I'd only do that if verbose=true
remove com,ment
@mattandrews  Nope that got removed a long time ago with routing using the front bootstrap file, but this code needs to live inside this adverts module.
That said, I think it'll be rare, if ever, that someone wants to set this value (unless you have any ideas, of course). The default should probably be "1.0"
esse margin-left de antes não é mais necessário?
Is it displayed a <button> or <a>
We can do that, but I'm not sure it is a good idea. I'm open to discuss this, but I'd prefer discussing this in a followup in order to ship that in 1.11.
So in most cases the page will be hidden in history and be kept frozen until the tab is close. It means that we will most likely pile up messages and use memory for nothing.
And I'm not sure it will be meaningfull to send a stack of messages long time after they have been dispatched?
For example imagine if a widget send a state value each time it change. Let's say this state change mutliple times while the page is frozen, It means that the content script will receive a list of sequence state change and a potential blink-cpu overusage effect.
can we have this as `===` so that it is type checked
Please use messages resource bundle and AlertUtil class to show messages, for example AlertUtil.showError("error.logoNotFound");
This change requires you to regenerate parser.rb (see makefile in that directory). There should be some tests around what happens now when you leave out $.
Please move this line to __init__ or, at least, set self.act to None there. It is good practice to declare all elements of self in __init__.
Are we sure that t.alive? will return true from the very first time this could get executed? In other words, is this guaranteed race-free given MRI's very fuzzy thread semantics?
Am I understanding things correctly: IE8 always skips this condition and falls through to other conditions (since crossdomain doesn't work with xhr in IE8)?  So in IE8, I guess window.FormData returns False?
Will do.  Sorry.
This uploads two compiled asset files to the server:

* build/index.css
* build/index.js
I'd remove this, and simply add the i18n/L10n filters to Zend\Filter\FilterPluginManager.
Better go with sprintf() directly here.
You can use DataProviders instead of the loop. With data providers is more easy know the data that cause an unexpected failure.
Sure... maybe having good practices with every regex will improve significantly the speed of the addon...
Heh, what does this mean?
Messages are immutable.
Yes, but I do wrap my code, just not markdown files.
Per the contribution guidelines, all lines must wrap at 100 characters
This is open to discussion, but personally I like to assert against literals if I can. That makes it a little clearer what the intended behavior is and avoids potential bugs on the "expected" side of the assertion.
Well, not exactly, you need to keep the strict format nagios expects, so no timestamp, INFO, ... etc. in the line. But you do want that in the actual log of your application.
Import statement order
importing duplicate shizzle?
its a bootstrap thing.
It's probably worth testing that the form works without the message (it's supposed to be optional, right?) and that the email sent doesn't contain "Personal Message"
It gives us more flexibility and configuration options via the config files at least. Otherwise we can't specify it and would have to change Jenkins for it.
you missed this guy D:
make it `end: function( event, options ) {`
If I remember correctly, there was some reason for it being polymorphic that had to do with tags using STI. Worth double-checking, though.
Nothing about this method is `this` sensitive or constructor body bound - move it outside of the constructor as a function declaration - thanks.
This shouldn't be removed as part of this. It is still used. Otherwise is there a migration path?
This is missing a ```var```, but you could also just use ```return url.replace(/\?.+/, "") + ".enw";``` and not bother with an intermediate variable.
If I enter a XSLT that doesn't exist in the config page I get:
Fatal error: Call to a member function saveHTML() on a non-object in /mnt/share/drupal6/sites/default/modules/islandora/ObjectDetails.inc on line 74
I'm not sure we need it either, I added this in the beginning when I started work on federation. I happy to have it removed.
Well, if there is a piece of this that is iffy, it's this.
The safest thing to do is probably to not allow the user to provide any annotation or mapping and always build a new one.
We can merge in an annotation object in a separate function.
I'll make that change.

On Oct 22, 2012, at 5:53 PM, Scott Devoid wrote:

> In lib/ModelSEED/MS/Factories/SBMLFactory.pm:
> 
> > +    	}
> > +    	$args->{annotation} = ModelSEED::MS::Annotation->new({
> > +			defaultNameSpace => $args->{namespace},
> > +			name => $mdlData->{name},
> > +			mapping_uuid => $args->{mapping}->uuid(),
> > +			mapping => $args->{mapping}
> > +		});
> > +		$args->{annotation}->add("genomes",{
> > +			id => $mdlData->{id},
> > +			name => $mdlData->{name},
> > +			source => "SBML"
> > +		});
> > +		$newAnno = $args->{annotation};
> > +    } elsif (!defined($args->{mapping})) {
> > +    	$args->{mapping} = $args->{annotation}->mapping();
> > +    }
> 
> Not sure I understand what's happening here with Biochemistry, Annotation and Mapping.
> 1. I think you always construct a biochemistry, but if you already have an associated annotation / mapping, how does the new bio get linked? Especially what happens if it doesn't contain the same reactions?
> 
> 	• What happens if I provide an annotation but not a mapping? A mapping but not an annotation? Both? Niether?
> —
> Reply to this email directly or view it on GitHub.
> 
>
overall formatting for C++ - please follow this guide http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
I like to be able to read what the function does in english.   So,
I'll be keeping this.

On Tue, May 15, 2012 at 5:04 AM, Karl Skomski
<reply@reply.github.com>
wrote:
>> @@ -156,6 +161,83 @@ void GraphNode::Initialize() {
>>    return scope.Close(Integer::New(size));
>>  }
>>
>> +// get the value underlying this node, but only if it is safe to do so (This may be over conservative).
>> +// If we can't get it, return undefined
>> +Handle<Value> GraphNode::GetHeapValueSafe(const Arguments& args)
>> +{
>> +  HandleScope scope;
>> +  Handle<Object> self = args.This();
>> +  HeapGraphNode* node = static_cast<HeapGraphNode*>(self->GetPointerFromInternalField(0));
>> +  int32_t type = node->GetType();                    // get type of Node
>> +  Handle<String> title = node->GetName();            // get the name of the node
>> +  v8::String::AsciiValue str(title);                 // get ascii rep of name
>
> above comments duplicate code - unneeded
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Skomski/v8-profiler/pull/2/files#r821964



-- 
Seth Copen Goldstein
FlashGroup: Connecting people through intention
412-818-1192
this does not compile. Another parameter is required :S
I didn't it's just moved..  see below
https://github.com/ether/etherpad-lite/blob/d09894ce779e1b55970514d1318119dd2485da44/src/templates/pad.html#L199
Misses an ending ", sorry!
сделать namespace impl и там все реализовать
i would directly use this in the if condition for the filter chain. we don't use it afterwards anymore and nobody cares about it once the list is created.
`r` will not change. it must be evaluated each time b/c `r` is the expression that instantiates the resource for this request. It must be guaranteed this expression is evaluated each time to ensure that a new instance of the resource is used per request (unless of course the resource is an `object` but that choice is up to whoever is using the library).
use 'this' only if it really needed
Should the 8 be a define? I have no idea what that keycode is.
This seems inapplicable, or poorly explained: this is raising an error, not making an HTTP request.  Is that a copy-and-paste error, or that the error handling system turns the exception into an HTTP response error, and is buggy, so you need to work around it here?
Is this (adorable) image freely licensed for use?
The URL on this endpoint I think should be a canonical reference to the tenant to update it. So I think port should be in the URL:

`app.server.post('/api/tenant/:port', ...) {`
Type statement is off.
Don't we have a fromUuid function for this?
Again, make sure there is spacing between parameters
So this could be called from an Observer of notification. That way you would have a much thinner controller. Some people do not like using observers and wrap the logic in a Service class or use a pattern like DCI. 

I think at this stage you could just use an observer to get familiar with them. Also I think it is a good TDD approach to start off with a controller like this and as you red-green-refactor you would move this (and obviously the associated methods below) into an observer (or DCI context or Service class - but baby steps).
How about this revision? Strictly major-ish new features and changes. I think it's worth mentioning spot instances at least.
Deze hele if-else kan herschreven als:

```js
this.spotted = !tr.collision.x && !tr.collision.y;
```
Is it a problem with the position, or having the slider there at all? Could add an option to hide it, or have it fade in/out like the floating toolbar to make it less obvious. The only other place I thought it could go was over the preview, it couldn't go under the editor frame without pushing up the chrome. Open to suggestions.
Проверка всё же обязательна, вам могут в качестве передаваемого параметра в этот метод передать как отрицательное значение, так и значение свыше 100.
OK, исправлю.
äÏÂÒÙÊ ×ÅÞÅÒ. äÅÊÓÔ×ÉÔÅÌØÎÏ, ÚÁÂÙÌ ÐÒÏ×ÅÒËÕ. óÐÁÓÉÂÏ.

2012/11/6 S. Lebedev <notifications@github.com>

> In osx-project-1/Cell.m:
>
> > +//  Cell.m
> > +//  Progect1-DNK
> > +//
> > +//  Created by omoroot on 06.11.12.
> > +//  Copyright (c) 2012 omoroot. All rights reserved.
> > +//
> > +
> > +#import "Cell.h"
> > +
> > +@implementation Cell
> > +
> > +
> > +- (id) init {
> > +
> > +
> > +    self = [super init];
>
> ðÅÒÅÓÍÏÔÒÉÔÅ ÐÒÉÍÅÒ × ÌÅËÃÉÉ. ðÒÏ×ÅÒËÁ if (self) ÂÙÌÁ ××ÅÄÅÎÁ ÎÅ ÐÒÏÓÔÏ
> ÔÁË.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Hexlet/osx-project-1/pull/258/files#r2041156>.
>
>
У вас могут замениться одни и те же ячейки по несколько раз
перечитал кучу инфы по random, но так и не понял, как он работает. но метод опытного тыка подсказал, что если убрать один запуск генератора, либо в файле NSString+Nucleotides.m изменить random на rand - все нормально генерируется.
На эту строчку ругается ворнингом "Format string is not a string literal (potentially insecure)"
Смысл в объявлении переменной index здесь? Логичнее убрать ее оттуда и переделать for как: 
for ( int index=0, distance=0; index < [dna count]; index ++ )
разница, как известно, в том, что do while - цикл с постусловием. т.е. сначала делаем, потом проверяем. такой подход имеет смысл реализовывать, когда хотя бы одну итерацию цикла нужно сделать в любом случае.
в своем коде можно заменить while на do while, если изначально отсечь передаваемый методу ноль. может, так и сделаю. пока не знаю. посмотрю еще разок ближе к вечеру.
Please don't change these cause this would break your jenkins
it "should allow to view questions" do

тесты должны описывать поведение
Seems like you can DRY some of these validations `ensure_equal(pub, sub)` and iterate through the publisher fields and ensure that they match the subscriber fields. Either that or check the values directly instead of matching against pub_e1 etc... Intention is clearer IMHO,
Is the addition of `$sort` here fixing some other bug where reference-many collections aren't returned in sorted order?
Any reason to not use http://www.ruby-doc.org/core-1.9.3/NotImplementedError.html?
I would add: ```tbPage = tbPage || $el.closest( ".ui-page" )``` what do you think?
是不是给b也要加上type hint?
Thinking about those tests, I really wonder if they make sense. Checkout mostly needs a working directory to work.

If the user is willing to create/update the active branch of a bare repository, then the `Branches` or `References` namespace should be the way to go.

I'd vote for making `Checkout()` throw a `BareRepositoryException` when not being run against a standard repo.

@jamill @carlosmn @dahlbyk @ben What's your take on this? Am I missing something obvious?
Pretty sure this is python 2.6+ only, SB needs to support python 2.5
On 21.10.2012, at 18:16, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> >          indices = []
> >          for time in args:
> >              ind = int(time * self.info['sfreq'])
> >              indices.append(ind)
> >          return indices
> >  
> > +    def index_to_time(self, *args):
> @mluessi @Eric89GXL I don't like our time_to_index and index_to_time as it ignores first_samp and it has not docstrings (shame on me...)
> 
> what do you think of time_to_index([t0, t1], use_first_samp=False) and index_to_time([i0, i1], use_first_samp=False) ?
> 

seems very natural to me.

> basically I want to be able to extract a time interval of data from the timings visible in mne_browse_raw
> 
> thoughts?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Also, return an error in the response.
I think that should be to `title__prefix`.
It's more efficient with LinkedList where you can call addFirst.
If webmock can't block this connection, how does this work?
This should be:

    $this
        ->getMockBuilder(
            'Symfony\Component\Form\Extension\Validator\ValidatorTypeGuesser'
        )
i think i all along was referring to the difference between getting a tarball with tests and getting .git instead. In tarball if package maintainer have used .gittattributes to filter the Test.php files then we would not get the tests as opposed if i had cloned the repository with all included.

do you see now what i said above?
Sorry, I missed your question about Errno::ETIMEDOUT.  I have actually not seen that one come up in a production application, to my knowledge.  I would check to be sure it's an exception that can actually be raised from the Net::HTTP library before rescuing for it.  But, certainly in theory, it sounds like a good thing.  I just don't know the condition in which may be called.
Yeah, I'll just do some minor tweaks and we can merge.
I did a spike and tried to do this - it created horrible experience for java users
use != ?
Потому что contains как минимум не медленнее. Потому что это как-то чище —
использовать более простую структуру данных под задачу.
Ты бы еще вместо массивов использовал хештаблицы int → value.
Así está joya, además por ahí me equivoco y puede que cambie el contexto de la función y algo se rompa. Dejalo así.
especially here :astonished:
$aabsic_attrs: Besides from the wrong variable naming I am not sure what you are doing here and in the following foreach block. Invalid fields are already excluded by the array_intersect a couple lines aboce so all values should be available? Please explain.
Why (int)$id_lang and not just $id_lang ?
Yup, that's another reason not to do this :)

Cyclic dependency example:
ns foo :requires bar, and bar :requires foo.  So neither namespace can load because it ends up requiring itself.

The solution to this is, whatever foo needs from bar, and bar needs from foo, push them into a separate namespace quux.

Then foo requires quux and bar requires quux.  Problem fixed :)
Let's define these in an enum and export them to JavaScript. Less fragile that way.
please rename this to `deleteRecords`
description should be at top of comments
Please add `.rvmrc` to your global git `excludesfile`, it's a personal choice much like editors are.
Please update your code first and then update your submodule :

git submodule update --init
@dcrosta that is partly true. I used this to setup the arbiter on one of the config servers. Because config servers have a different `@name` this didn't cause an issue for me. I can see though that next to a standalone mongodb or a replica set member this would cause problems. I haven't thought of that.
If this resource is persisted, it will use the ResourceUri that came back from the api for future requests. This should save us from having to do too much ResourceUri parsing other than getting rid of /v# in front, and the resource's id on the end.
There is a check in DistributedExecutorTest$LongRunningCallable. I did not fake the whole thing that much :-) but I agree with you that more tests are needed!
Please keep within 80 characters line width as per PEP8.
I added this to prevent the button on the Committees dashboard from saying that there's an active election when the only elections for the committee are closed.

What you'll probably want to do instead is add a helper method called `HasActiveElection` to `Committee` and implement that in committees.aspx.cs. It should be an easy fix.
There are some typos in that message
occurs->occured
mehtodcall->method call
No support for GML? We should mention that somewhere in the docs as a caveat.
Why are these comments kept?
In screen size hacks, we are manually setting the height of the container #content.  We depend on each section within the #content container to be absolutely positioned at 0 for each of top, right, bottom and left.  Since we were setting the error section to be statically positioned, it was ignoring the absolute positioning and taking up only as much space as it's content was told to, in this case 250px.

Remove the manual height setting as well as the static positioning allows the error screen to take up the full height of the container as well as keep the inner contents vertically centered.

Can you check this on any mobile browsers that you have?
I'm trying to play with this, but I'm actually not sure when `0` values are valid in this case anyway.

For example, if I set up a json file:

`[ { "name": "Tokyo", "data": 0 } ]` - doing a `null` comparison will cause this to fail with `Uncaught TypeError: Object 0 has no method 'filter'`... with the existing code however it works fine. I'm pretty sure if the json data gets corrupted or with funny values lots of other things can break along the path too.

Any thoughts on this? Is `0` ever a valid value for the `name`, `color` or `data` fields?
I'd tweak these short names. Usually `-c` is reserved for "change directory".

Maybe `-js ENGINE`, `--js-compressor=ENGINE` and `-css ENGINE`, `--css-compressor=ENGINE`.
Can you explain this line to me?

I understand that it check to see if there are 4 files in the update folder but why does it need to be so complicated?
ben geen sales man dus weet ook niet wat het wel is
maar zoals het nu is vind ik het maar een vreemd woord
For readability, how about:

    .multiple-choice,
    .free-response,
    .art-connections {
      > .section > .title > a { display: none; }
    }
should be "private var"
<code>finalPrefix.equalsIgnoreCase("")</code>

eeh..
I looked into `DeclarationVisitor.visit(Tree.FunctionalParameterDeclaration)` and I think that this is not supported.
Note: undocumented functions will show as a warning for JSDoc generation, add: use /** @private */ to hide it
Weird. I don't know.
Can we just `raise` here. Don't need to be verbose, even if we haven't raised an exception before that, we'll still raise an exception about trying to raise None :)
yeah, I'm not sure either about adding the transformers in the default loader
`[ -t 0 ]` means: "is `stdin` a terminal?`, whereas `[ -p /dev/stdin ]` means "is `stdin` a pipe?"

The former is pretty much always what you want. Sorry if I haven't updated you since the whole `-p` thing. :-) (https://github.com/janmoesen/tilde/blob/master/.bash/commands uses `-t` everywhere.)

Try this:
    function foo { [ -t 0 ] && echo term || echo no term; [ -p /dev/stdin ] && echo pipe || echo no pipe; }
    foo bar baz
    echo foo | foo bar baz
    foo bar baz <<< bar

As you can see, `no term` is when you want to use `stdin`. Using `<<<` does not trigger the `pipe` status.
I was just debugging :p forgot about it !
shouldn't that say calname not timezone?
You can open a ticket/add TODO that user's could configure the default map.
Oh, but you do know about this syntax.
I still don't like this long if-structure. Why you don't simply update and return context immediately in those two special cases?
Is this okay now? Static tag works. Should I do this in all templates?
Also, this should go each into its own line.
Extend `piplmesh.test_runner.MongoEngineTestCase` and things should magically start to work for you. (You will be able to run tests through `./manage.py test`)
Is this user visible string? Is this hard-coded HTML? Don't do it like that!
Interesting, I missed the `error` atom inserted into the list by the macro.
While you're in here please document the run_instance function this new code is in.
Couldn't this be safely deleted?
I added some docs for authorize_transaction
I guess this is only needed for Ruby 1.8 - not sure if it's worth checking for the `RUBY_VERSION` and conditionally require it
A gateway instance might be re-used multiple times, so I don't think it's appropriate to use instance variables to store details about a specific transaction.
I think these imports were added at a point in which the extra_nav logic was going to be handled by a template tag and are no longer needed.
Why are you trying to re-raise the error?
Nit: Not a pair anymore.
why the array order logic belong to HostedService instead of WindowsAzureService?
does check style complain about the indentation here?
`0` without `px`, above too.
Why not 0.3?
If (only if) we find something else that needs to be changed, maybe add a newline here?
`source "$commands[virtualenvwrapper.sh]"`
Yes, my preferred
outsourcing?
What's the thinking behind having separate exog and data arguments? Can we stick to the endog, exog=None signature here and add a censoring argument? Then we could also have an time_type = "interval" or whatever and get rid of the Survival class. Then it could be similar to the TimeSeries models. I'm not against having a helper class to pass to these models but I'm seeing if we can simplify this code a bit first.
Ah, sorry @timothyandrew, I completely misunderstood this line. You're returning either the value from the hash directly or pass this hash into the other method in order to find it inside of one of the range-blocks. I think `||` is more appropriate here, but [`Hash#fetch`](http://ruby-doc.org/core-1.9.3/Hash.html#method-i-fetch) with block calling this method might be even better here.
Can't you do this in a single step? `df[rep(1:nrow(df), df$count), ,]`
Hi, Jimmy,
what do you mean by "s/HashMap/Map"? static HahsMap<Map>?

Ke
I won't use it I was just testing what was the problem. I will consult other team members.
Good, you spotted the guidance on not using more than one attribute per span element. Phew, if you'd combined those two we'd have been in a real pickle and your code would have been tricky to read & maintain.
My ditto comment about the Ifs was supposed to go here.  Not sure how github managed to move it up as a reply to the other message.
Done!

On 19 Jun 2012, at 16:21, Mike Jarvis wrote:

>> 
>> -    def drawShoot(self, image, N, ud=None):
>> +        if normalization.lower() == "flux" or normalization.lower() == "f":
>> +            dx = image.getScale()
>> +            image *= dx*dx
>> +        elif normalization.lower() != "surface brightness" and normalization.lower() != "sb":
>> +            raise ValueError("Invalid normalization requested: %s"%normalization)
> 
> Sure.  That's a good idea.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/194/files#r1014391

--
Barnaby Rowe

Jet Propulsion Laboratory
California Institute of Technology
MS 169-237
4800 Oak Grove Drive
Pasadena CA 91109
United States of America

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom
drop this method for cleanliness
Oh, I see, the diff cut off right at the condition.  Looking at the file in your branch clarifies.  NP.
Just want to check: is the purpose of this test to give useful info for when looking at results of subsequent tests? It appears to not really test much production code.
Perhaps it would be worth moving the exec("vmc info") call into the production code somewhere, so the version etc can be shown as entity attribute etc?
But no strong feelings, so feel free to ignore...
FYI—I'm swapping the semicolons above with commas to prevent hOffset and vOffset from becoming global.
is much more enjoyable, mais au-dela de cette typo je ne suis pas d'accord et c'est encore pire aux US ou tout le monde est en train de textoter et bouffer du popcorn
It is related to 0.26: to be comply with MythTV protocol (success response is OK, not something else). Also before 0.26 response could be "ok" and now it is "OK". Below i call the new cmyth_rcv_okay. Also cmyth_rcv_okay read all block unconsumed on the socket. Old code read only 2 bytes and may cause a side effect of load the next time.
please ignore this file when commiting
Does this get returned as a record, or as a dict?
Can you make sure this doesn't break CA delegation?
The desktop does not know about MozSmsFilter right? If so the the web demo would be broken if you do that. This is the main reason of using an object SmsFilter (now MozSmsFilter) does not exist.
I got nothing productive to say @philsturgeon ;)
I'm guessing you need to add the keys to the .xsd, and then add the nodes
to
https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L161
If you have a `use Guzzle\Http\Exception\BadResponseException` statement, then just the class name will suffice... `BadResponseException`.
A better solution is to add "\improper" before the name.  i.e. "\improper Chef's Apron"
Ужас какой :+1: 

Думаю алгоритм поиска файлов переписать. То что сейчас ui файлы и cmake, CMakeLists.txt файлы не добавляет в проект
If we delete one why not delete the other?  Or everything that isn't here supply a bunch of parameters which will be the defaults 90% of the time?
I'll have to take a closer look at this... I'm a bit confused why Cinder is importing settings from Glance for Swift...
А что это за пользователи?
Имя класса не соответствует названию класса. Я поправил это.
if (checkOverflow(a, b, operand)) {
Вроде проверяется, или Вы что-то другое имеете в виду?
Yep, "doing the same job" is a simpler way of saying "employed in the same profession." My priority is conversational language that's conducive to sharing on social networks.
tonumber?
You can specify the length of the array to the object's constructor.
see src/konoha/datatype.h:281 kArray_init()
A neat trick I can't take credit for for cases like this is to use lastIndexOf so that it only checks the one position in the failure case rather than the whole string.
30 should not be hard-coded. It should be a parameter of the function.
Do we really need to run `which git` to invoke Git with a full path to its binary? Should `git` not "just work"?
The name here should be more descriptive, artifactory is a product name...
Actually, netbeans formats it right, i just forget to press format :P
@alta189 hmm, gonna try that branch thing, would be awesome if it works o_O

Anyway, my power/internet went down, so don't expect any changes for about 12 hours :P
Also, the name doesn't seem appropriate. How about PersistentV8Value?
The CInterfaceOf is in cancidate-3.10 - and although sounds like the construct I'd need for above typedef, it is something different.
Worth adding a comment to indicate why this code is here
newSize is a misleading name.  More like actualSize.
I don't understand. The arg is provided to format the output after parsing the iso date. The longer and most common format string is the default, which avoids a line break later. A shorter format is provided instead, once, to set the display strings for the graphs.
It only becomes visible if you actually install a third-party package.
Couldn't the fact that you are actually setting these semi-global variables here (rather than stubbing them) end up causing side effects in other tests?
Import this. Also, I think it's technically Zend\Date\Date
this should use a yoda condition (same for next ones)
you should typehint it
Could this be made a reference to the usage document?
Missing 
@param {aria.core.CfgBeans.ClassDefinitionCfg}
Is this the same set of VALID_YEARS we use elsewhere? Should we put this in tba_config as a global?
You should probably catch errors in building these, because a team_number of 0 isn't going to return a team.
there's no need to guard deletion, 'delete 0;' is safe
must convince the target user
Yes. I looked at 0x01 all the way to 0xff one by one, and those chars are allowed.
What about this instead?

```ruby
if @subject.class.count == 0
  entry = @subject.class.new
  # etc
  entry # return the entry
end
```

Then set `@existing` to the return value of this block. You don't need to cache it, since you only call it once.
The `'type'` key should still be settable from the constructor based on the type names configured in `Media`. I don't really care if it maps to the `$_type` property, it just has to set the header. This is important for reason that will become clearer as we continue to evolve the media type system.
I still think this and `/contribute` should be tested in kitsune's tests, not here. These are hard-coded redirects and when we can move the tests closer to the code, I think we should. (kitsune tests for these things will also be faster and when/if we change the expected target it won't be a spurious failure for you to investigate.)

So, I think you should drop these.

If you really don't want to, you can combine this and `test_contribute_redirects` below. They're both just shortcut/vanity URLs, and the tests are identical. `test_vanity_redirects` would be appropriate.
The first thing you should do is add a test for `undefined` and throw if it's true.  This is a common enough error that it should be handled separately than the other exception you are throwing.

```
if(typeof color === 'undefined')
{
    throw new DeveloperError('color is required');
}
````
Don't forget to update the doc with it as well.
I think these two lines should be the below.  It both avoids an extra allocation and avoid changing the type of object `p` is in the middle of the function (which I believe Chrome recommends we avoid doing).
```
var p = new Cesium.Cartesian4(positions[i], positions[i + 1], positions[i + 2], 1.0);
p = this._modelMatrix.multiplyByPoint(p,p);
```
If it throws, the throw happens on `new Error()`, so that's a separate line.  It probably wouldn't hurt to combine, but I think keeping it separate makes it more debuggable.
You could use the `currentTime` parameter as the scratch object for conversions and defaults, etc.  That's normally what I do.
thx,I'm a newbie, that's helpful
Incorrect method name `replaceChild`
Thanks for the reminder about the `transparent` setting.

As we rely on undefined values to provide the default behavior throughout our APIs, I have not explicitly explained it here.
Definition of size behavior would be nice here.
Is there a reason we are no longer calling setProperty?  It doesn't seem like the property gets set on the kroll object if you don't set the property here.
could re-use width/height variables here
Each platform should be independent; if there's a platform which contains shared code, it should go somewhere else.
`run_test_cases` is not for `make test`, `run_test_step` does that, which is not controlled by `run_test_cases`.

It should state: "run_test_cases (bool): run test cases after completing installation"
`else` should be on new line.
Ohh, you true. ```!empty?``` is much faster.
Please change "element" to "category_element" so there's more context about what's getting passed around.
Personally I'd rather never use one-line CSS declarations. I think it's a lot harder to read/grok, and much like `var foo = 5, bar = 6;` vs `var foo = 5; var bar = 6;` is just more work to change once you wanna add more than one/a few rules. Let's just be consistent.
Oh. I remember now. The problem is that the assignment needs to affect the original range. If you just assign the pointer, then the original range is unaffected. So, what you then get with

    r = r[n .. r.length];

is that the slice of the origanl range ( which `opSlice` returned wrapped in a `RefRange`) is assigned to the original range. So, the

    r = r[n .. r.length];

acts like it was the slice of the original range which is assigned to the original range rather than having the wrapper then refer to a new range.
Also note: *n-dimensional static array* type is defined as `<type>` followed by *n* `[<in­te­ger>]`, not as `<type>[<in­te­ger1>, <in­te­ger2>...]` so *zero-dimensional array* perfectly follows language *n-dimensional static array* definition.
Swap Yes and No.
In general, we haven't been using exceptions in range functions, and I don't think that we should start now. They _need_ to be fast, and I think that it's perfectly reasonable to require that that the caller do any necessary verification. Not to mention, if `empty` requires verification from the caller's perspective, I think that there's something wrong with the design.
Can you change this to http://c.gwt-examples.com. I haven't been building gonevertical.com for a while and may be closing it down until I get it rebuilt. :)