add test for SwiftmailerServiceProvider and update composer.json require-dev section
add a test for swiftmailerServiceProvider app->finish event
Merge remote-tracking branch 'upstream/master'
following @igorw approach
remove  variable
Merge branch 'master' into swiftmailer-test

* master:
  made monolog logger as the default logger when the monolog bridge is installed
  added the ServiceProviderInterface::boot() method
  fixed some skipped comments
  fixed Twig provider
  removed the Symfony bridges provider as it is not needed anymore with Composer
  added the possibility to register a logger for internal services
  fixed markup in the docs
  removed translation.messages in favor of translation.domains
  Remove dependency on the ClassLoader component.
Fix SwiftmailerServiceProviderTest (stub the spool)
Merge pull request #1 from igorw/swiftmailer-test

Swiftmailer test
merged branch ricardclau/master (PR #328)

Commits
-------

f2cc243 Merge pull request #1 from igorw/swiftmailer-test
f43dd5a Fix SwiftmailerServiceProviderTest (stub the spool)
1798d08 Merge branch 'master' into swiftmailer-test
5ed7e45 remove  variable
f1edad0 following @igorw approach
a238971 Merge remote-tracking branch 'upstream/master'
34ddab5 add a test for swiftmailerServiceProvider app->finish event
5d599be add test for SwiftmailerServiceProvider and update composer.json require-dev section

Discussion
----------

Add test for Swiftmailer service provider

---------------------------------------------------------------------------

by igorw at 2012-05-25T12:39:59Z

A test that verifies that Application->finish() sends mails would be nice.

---------------------------------------------------------------------------

by ricardclau at 2012-05-25T13:03:39Z

Ok, makes sense, will work on that and send a new pull request :)

---------------------------------------------------------------------------

by GromNaN at 2012-05-25T13:05:58Z

@ricardclau You can simply commit to the same branch to update the PR.

---------------------------------------------------------------------------

by ricardclau at 2012-05-25T15:45:13Z

What do you think about this way of testing listener?
Couldn't find a better way to test it so any comments are more than welcome!

---------------------------------------------------------------------------

by igorw at 2012-05-25T16:04:29Z

Not a good idea, the asserts may not be executed. Also, please don't call run. Call terminate explicitly.

My approach would be:

* define a controller that sends a message
* check the spool to make sure it's empty
* call handle()
* check the spool to make sure it has a message
* call terminate
* check the spool to make sure the message is flushed

---------------------------------------------------------------------------

by ricardclau at 2012-05-25T16:10:27Z

Sounds much better, I'll try my best as you suggest.

Although your method seems much better than mine, I'm curious... in which cases asserts would not be executed?

---------------------------------------------------------------------------

by ricardclau at 2012-05-25T18:11:33Z

Seems I screwed up a little bit. Once all is ok, I can provide a clean pull request if you prefer so.
Sorry and waiting for your comments

---------------------------------------------------------------------------

by stof at 2012-05-25T22:07:17Z

@ricardclau no need to create a new PR. Once the review is done, you can simply squash your commits and force the push of the branch, which will update the PR. This is described in [the Symfony doc](http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch)

---------------------------------------------------------------------------

by ricardclau at 2012-05-26T02:49:31Z

@stof I didn't know that! Amazing!
The best thing of trying to contribute in Symfony community is always the amount of things you can learn from all you guys! Thanks!

---------------------------------------------------------------------------

by ricardclau at 2012-05-30T09:19:52Z

@igorw Ping? Is it now ok? Anything that should be changed?
Waiting for your comments

Regards!

---------------------------------------------------------------------------

by igorw at 2012-05-30T15:17:02Z

@ricardclau I've submitted a PR to your repo, please merge.

---------------------------------------------------------------------------

by ricardclau at 2012-05-30T15:33:50Z

Merged

---------------------------------------------------------------------------

by igorw at 2012-05-30T15:45:16Z

Ok, this looks good to me.
Added more tests on validator provider

To avoid another regression fixed by PR #321,
tests ensure validation works on form built without class
merged branch lyrixx/fix-validator (PR #337)

Commits
-------

7509fa2 Added more tests on validator provider

Discussion
----------

Added more tests on validator provider

To avoid another regression fixed by PR #321,
tests ensure validation works on form built without class
Updated vendors
Added simple smoke test for default session provider setup
Switch to FileSessionHandler, NativeFileSessionHandler remove upstream
Removed SymfonyBridgesServiceProvider from the translation documentation, as it doesn't exist anymore

See commit 75556d7e8fd06cf919f6f41afbab4f5b449e4c9a
Translation doc: added Twig bridge explanation
merged branch neurolit/master (PR #339)

Commits
-------

c8592e7 Translation doc: added Twig bridge explanation
87e2872 Removed SymfonyBridgesServiceProvider from the translation documentation, as it doesn't exist anymore

Discussion
----------

Removed SymfonyBridgesServiceProvider from the translation documentation

Hi!

As you removed SymfonyBridgesServiceProvider (commit 75556d7e8fd06cf919f6f41afbab4f5b449e4c9a), I removed it from the translation documentation too.

---------------------------------------------------------------------------

by stof at 2012-05-30T22:35:37Z

You should say that this will work when you have the bridge in your project, not always

---------------------------------------------------------------------------

by neurolit at 2012-05-30T22:54:25Z

Thanks for your advice, stof. I added a link to the bridge documentation (not sure this is the right syntax, though).
merged branch davedevelopment/remove-native-file-session-handler (PR #338)

Commits
-------

f9837f8 Switch to FileSessionHandler, NativeFileSessionHandler remove upstream
e9af894 Added simple smoke test for default session provider setup
a34077d Updated vendors

Discussion
----------

Switch NativeFileSessionHandler to FileSessionHandler

Looks like it's been removed upstream...
Move some dependencies to require-dev and suggest

* BrowserKit, CssSelector and DomCrawler are only needed for functional tests
  This should be an optional dependency.

* Process and Finder are only used to build the phar, they are dev dependencies.
Remove references to ClassLoader