labofsahil/github-event-dataset-2012 huggingface dataset:
Hannes Magnusson <notifications@github.com> wrote:

> > +			/* Check for bool/int value >= 1 */
> > +			if ((Z_TYPE_PP(safe_pp) == IS_LONG || Z_TYPE_PP(safe_pp) ==
> IS_BOOL)) {
> > +				safe_op = (Z_LVAL_PP(safe_pp) >= 1);
> > +				goto ok;
> > +			}
> > +			/* Check for string value ("majority", or a tag) */
> > +			if (Z_TYPE_PP(safe_pp) == IS_STRING) {
> > +				safe_op = 1;
> > +				goto ok;
> > +			}
> > +			php_error_docref(NULL TSRMLS_CC, E_WARNING, "The value of the
> 'safe' option either needs to be a boolean or a string");
> > +		}
> > +		/* Check for "fsync" in options array */
> > +		if (zend_hash_find(HASH_P(options), "fsync", strlen("fsync")+1,
> (void**)&fsync_pp) == SUCCESS) {
> > +			/* Check for bool/int value of 1 */
> > +			if ((Z_TYPE_PP(fsync_pp) == IS_LONG || Z_TYPE_PP(fsync_pp) ==
> IS_BOOL) && Z_LVAL_PP(fsync_pp) == 1) {
> 
> Feels weird to be explicitly checking the types rather then cast it to
> boolean.. Now for example we explicitly disallow the string "1"..
> Although technically incorrect there isn't any reason why we shouldn't
> allow it and follow the general PHP type juggling
I've already fixed this today. But I forgot to push before I left for the MUG.

Cheers,
Derick
Ok. I'll see if I can do them all in a separate branch once these have been merged.
I'm not sure this will work generally - but if fixed my problem with multiple Info.plist in my app. My main target had the /Info.plist without a prefix which is where this came in handy.
For safety, i'd add a return if these two conditions are false---that way if this condition happens in a non-debug build things don't go nuts
my VERY bad
It's a nit, but the convention we're going for is two underscores between resource names and string keys, but only one underscore between class names and string keys.
Must have been a bug in my lossy text compression algorithm (fix)
`merge` merges two Hashes. The tag syntax is:

    {
      title: "Thing"
      parent: {
          nested tag here
      }
    }

`tags` is probably a bad name for this as it's really a tree of nested tags.
Feedback per NMA und Prowl gibt es doch bereits?
Ahhhh, this is really ```has_one``` now, nevermind
А если параметр будет пустой строкой?
Occasionalyl in the failure screenshot I'd see the basic section greyed out and the spinner inthe middle. I suspected that the Wait was resolving to true before the spinner even appeared.

I'll give it a try again soon.. etiehr way the waits here can't make it worse.
multiple spaces before operator
however, the annotation should not be responsible of the parsing. The rendering should
Good find, that seems to explain Stefan's issue.
Taking a step back and looking at the PR with a more high-level point of view, it seems to me that the purpose of this attribute is an adaptation purpose.

In other words, it is not easy to know, simply by looking at a given instantiated estimator, if 'pairwise' should be True or False. Thus need for an extra attribute and properties to implement it.

The question is: can we choose wisely the APIs of estimators so that this adaptation is not necessary? That is, can we make it so that all estimators that need pairwise=True expose the same attribute, with a name that would still make sens for the corresponding estimator? If we could, it would simplify a lot the code. Note that if the estimator only works with 'pairwise' data, than the corresponding attribute is a class-level attribute, and the user doesn't have to see it.

Another alley that we could go down, would be to enforce that an estimator is either pairwise, or not pairwise. That would force separating out SVC(kernel='precomputed') from other SVCs, but it might give a simpler picture to the user, and end up with simpler code in the long run. It would be a big design design, but I think that it is worth considering: that aspect of the scikit currently doesn't feel quite right to me.
I am curious, what make you change your mind? :)
scale_C not in use
If sparse input is indeed supported, then shrinking won't work properly; `X - self.centroids_[y]` implicitly densifies `X`. In that case, I would prefer a `ValueError` to be raised when `issparse(X) and self.shrink_threshold is not None` because I've experienced too many workstations freezes from accidentally densifying large sparse matrices.
I think it should say ``use passed function as affinity``. The options say what the algorithm does if this option is passed, right? If you pass ``rbf``, it will use the rbf kernel as affinity, if you pass a callable, it will use the callable as affinity.

Maybe ``precomputed`` should be a bit more explicit and say ``interpret X as precomputed affinity matrix`` or something.
Personally I think we should start upgrading our code-base to make it as py3k ready as possible (I mean with as little as 2to3 translation as possible). As we have now dropped the python 2.5 compat, we can start using stuff such as `from __future__ import print` and other tricks from [six](http://packages.python.org/six/). We could even try to have a single code base by trying to clean it up with tools such as [python-modernize](https://github.com/mitsuhiko/python-modernize).
From my perspective the "through a tranformer object" is somewhat redundant. But I'm not sure I'm the best judge when it comes to how the docs read to a newbie ;)
Oops, this one wasn't supposed to get in.
OPTIONS?
It's nice to have a comment here expression, in D syntax, the syntax being synthesized.
Right, sorry, ignore that one. I was just working down the column, and didn't notice that one was different than the others.
Can we wrap both the &lt;;script&gt; tags and the &lt;;style&gt; tag in a &lt;;c:if&gt; of some sort?  I think even loading the jQuery library is a performance hit.
I don't think this should have been changed, to keep it close to what is done for other platforms.  But it probably doesn't matter.
you know the Cast part is not necessary?

const String::Utf8Value v8UtfString(args[0]); does the trick ;)
Update the apidoc for the properties not implemented
They for sure for ios only. Modified appropriately.
That's right. However, my comment was about [layered security](http://en.wikipedia.org/wiki/Layered_security). I'm afraid someone might create new mass-assignable attributes in the future.
This is a singleton pattern using a static object, as such the singleton lives for the life time off the application after init.  However, I replaced the singleton with an owned type, but this still won't delete the object until the application exits.
That would make the comparison above ```if (sn != index++ || sn > n)``` awkward.
FYI, these values were defined twice.
The huge array causes early OOM, which would be easier to deal with if there were separate bucket blocks I think..
this doesn't make sense. Did you mean 'it' rather than 'if' ?
This variable looks unused
I think if wait is 0, the control:reload should not be issued at all.
do you really need to extend the class for this ? Simply use the base class
Whilst you're at it, remove these imports. Both of them. The module is already [imported here](https://github.com/AdrianGaudebert/socorro-crashstats/blob/e44d63428e8fa096d0afd957a262d2bf6ba86f1a/crashstats/crashstats/tests/test_views.py#L13)
the 'sub'  bit is a little strange -- i would guess the env looks something like:

    PATH=/usr/bin...
    ...
    activerecord=3.0.0
    ...
typo: Now we that we --> Now that we
Buildbot always imports using a full path.
Isn't there a better way to achieve this than messing with the margins? Seems like it fragments the CSS a bit, and maybe it should just go directly with the element it belongs to rather than standing as its own mixin/class...
@christianv how do we do handlebar commenting out
I would remove the link to the PHP documentation from here to make the message shorter
you should handle curl errors
Well, we didn't know Draper either (at least I didn't) and, as matter of fact, we haven't even tried it since all we need is a simple decorator. So we decided :kiss:. We also suspect it would break because the AR::Base, can't confirm though.
yes, URIs are passed to SPARQL as <URI> where as strings are passed as "string"

Care needs to be taken with this as the two types are treated differently
The end goal here is to have a base standard set of tiers... perhaps create a new set of available tiers if they have a custom COST_OVERRIDE?
@runningman no problem at all. It's important to understand if the style guide is a little ambiguos in places.

The last phrase does not apply to this case b/c it is a variable and not a string.

The phrase that captures the specific style detail that I am referring to is at the bottom of the same section. Even though the example provided is a value being assigned to a resource attribute, it is meant to apply universally to cases where variables appear by themselves in Puppet.

Just in case I may be wrong, perhaps @jeffmccune could confirm this was the intent of these sections.

"Variables standing by themselves should not be quoted.  For example:

Good:

    mode => $my_mode
Bad:

    mode => "$my_mode"
    mode => "${my_mode}"
"
I am not sure why my formatting is off here, it shows correctly in two different ext editors :/
Um how would that be redudnant? that's how it checks locally.
'if connected' would seem to be way clearer here.  The question is does it provide exactly the same logic as was desired.  It should except in the case where connected = nil
I just verified again that if I drop a random text file, the mof file will be processed right away. If not, it can be sitting there forever.....
Why not just have this as __init__, and check that either the parameters or the matrix is specified?
I think there's an easier way to reset the `I18n` database in the `after` block:

```ruby
after { I18n.backend.reload! }
```

Based on this line: https://github.com/thoughtbot/shoulda-matchers/blob/master/spec/shoulda/active_model/helpers_spec.rb#L63
"should raise a custom exception"
What if it was:

```
<div class="sub_records {{showExpanded}}">
```

(Totally assuming `{{showExpanded}}` will print `true` or `false` here)

Then in `app.css` have something like:

```
.sub_records {
  &.false {
    display: none;
  }
}
```
Is this app running on production?
I'm seeing an airbrake related to this line: https://zendesk.airbrake.io/groups/52057297/notices/7145675633
It is specific to the central body. It uses the points computed for the depth plane and its larger than creating a screen-space rectangle from the bounding sphere because it needs to be big enough to contain the sky atmosphere.
Ow an bdrip is the same as brrip in CP, again see quality plugin ;)
Nice! Fixed in next update.
okay, somehow the tabs are still not right. Thank github for that :)
This isn't as clear to me. It sounds like it's trying to establish an order between `onFulfilled` and `onRejected`, not between multiple (`onFulfilled`, `onRejected`) pairs.
This should use ``%command.name%`` to avoid hardcoding the name (which is wrong anyway as it could change)
I copied this from the createFromStreamMethod above this one.
Thanks. WIll fix.
Ranges have mixed semantics in that the limits are copied but they always refer to the same data. Classifying them as value types creates confusion.
Add a newline between these two blocks.
I seem to recall that I at least believed once that it is needed. I seem to recall that the JMeter GUI when it scans for JUnit 4 tests looks for it. I might be wrong so. Let me double check.
Actually, why don't we provide http://jboss.org/jdf/quickstarts/get-started as the URL here?
pls try to avoid simple runtime exceptions if there's a chance to give a better exception; even if you have to create a new one
nit: please indent properly all those catch blocks
I feel like randomizing a testing sequence could lead to bizarre results. If it doesn't matter which one is picked, just pick the first one. If all of them need to be tested, then we should iterate.
maybe that's  a waste of time...
Hi,

Thanks for the review, indeed I can greatly simplify this piece of code. But I still need to use my _distinctParent_ method, because _FilePath.list()_ will return an entry for each file, and there is more than one. Is there a way to restrict the search only on folders? I haven't found anything about that it the javadoc.

Best regards,
Reynald
setteledPrice und ProofreaderSallerySettled können gleich vom Order übernommen werden
Según esta implementación todas las capas se guardan en la misma posición (lo que he dicho antes) pero sería bastante sencillo de cambiar.
This differentiation doesn't look like a good idea.

I think you should have the sympy generated equations that compute front wheel contact rates instead of time differentiating my contact point equations. This should reduce the error somewhat. Trying to minimize time differentiation of measured signals is a generally good practice, here you have the choice so I'd use the sympy equations.
Can't see the 2nd $? :)
When I uncomment these lines, appear me this message when I run rake test:
DEPRECATION WARNING: config.whiny_nils option is deprecated and no longer works. (called from block in <top (required)> at /home/danilo024/delivery-web-app/config/environments/test.rb:15)

It look like as it's deprecated and it's not necessary?
no need to use ``else`` as the ``if`` returns (and btw, the ``else`` is misplaced)
I made this change in all the Test files and the tests pass when using NUnit. However, trying to run individual tests (except those in TestPointShapes) with TestDriven.NET always fails when trying to access any of the private variables with the message "Object reference not set to an instance of an object," as though SetUp is never called. I can run the KML tests that use[SetUp] just fine. And if I remove certain initializations from the SetUp function (e.g. m_parts and m_positions in TestPolylineShapes), then the tests will run and pass with TestDriven.Net. Weird.
Same here re: dummying
hmm ... why a property ? Then it should be `authentication` and not `get_authentications` !? Anyways, the method means "Instantiantes and returns the authentications.Authentication to be used on the request".
You pointed out in a good place. I wonder if I can call 
_event.trigger("payment.purchase.callback", args);

The args content call be like "SUCCESS ;;;; JSON Object". So, JSON.parse won't work. But, if I don't have to call JSON.parse then it should be fine.
There is an explicit test for pickling. And I test grid search with 2 CPU: it works.
RIP Spacey
Ah yep. Fixing
There should be a bug filed to automate this process on our end.
Uses `pixels` instead of `dip`
Missed this in the Touch review.  You need to redefine the event var in this method (it's out of scope otherwise).
are you sure that we want/need a status?
Nope, was just wondering ;)
Given that the HttpServer sets this unconditionally, shouldn't this be an error state here, not "silently return a bogus value"?
Суть:

И еще у меня вопрос о литературе. 
Для любого языка есть куча книг о том как нужно писать по стандарту(где в очередной раз объяснят как работает цикл for, whilt и волшебный if).

Вопрос:

 А не знаешь есть ли книга о js в которой рассказывается не как писать по стандарту, а как правильно писать на js. Так как я думаю ты не успеешь рассказать о всех прелестях этого языка за этот курс.
Can we rename getFreeFeatures to something more descriptive like getGlobalFeatures?
this logic means that there is no way for someone to override the ui-resources folder.
can you add cmake_minimum_required(VERSION 2.8) to the top of the file so the compiler output doesn't show a warning
The exercise asked for one comparison with three arguments. No points from this one.