labofsahil/github-event-dataset-2012 huggingface dataset:
I think it could be just done here and not on the install check, then we could direct them to the details page to check it out.
yes, I added a return.
Please use `Nil` like for `requireBundle` (just a cosmetic issue).
why not just use `Text` vs. `ByteString`? I'm not suggesting making this modification now, but we should consider this after this in some later version.
Outside of templates it's lower camel case, I've added a section to readme.
I would - but this is a complete cut-and-paste from your code. :p.  But I can fix it.
Yeah, this was from @caridy. I'll defer to him.
please run http://jsbeautifier.org/ to clean up spacing
Actually, let's rename the variable 'seen' -- this variable is to check whether the recipient has read it or not....
Can you use standard_name here?
Why not. :-)
Maybe I'm being too sensitive - but I see this as a workaround for a bug with netcdf4-python, *not* a bug in Iris.
remove the if.
That comment is outdated, I just removed it.
Oops, good catch, I'll fix it right away (my bad)
this is misleading - they are not viewed as float32, they are actually float32s. To get the ints, you are casting them back to integers.
I'm planning to downgrade it to warning eventually, but I want to make sure the tests pass with it being an Exception first.
It's confusing to see a completely new file with "battle scars" (commented code for no apparent/commented reason).
It's especially confusing to see the partitioning DDL commented out for a table named "*_P2" (vs. "*_R2").
In my day, P used to stand for something.
Is this true if the key uses non-inlined memory?
The name `recursive_join` was a little vague for me. Maybe a comment explaining how it's flattening the nested stat tree, creating a flat list of stats with names prepended by `BaseName_`?
В jsdoc не хватает типов, в других местах тоже (не буду повторяться).
you probably want this to be shorter
text_type is str in python 3, so calling str(AnonymousUser()) results in a RecursionError. -- More importantly __str__ shouldn't encode to utf-8 on py 3 since it should return text and not binary data, or do I miss something?
Is there any way to avoid the global state here, maybe by factoring out the parser state into a Parser object?
Then the error would be "jQuery.ajax is not defined", which defeats the whole point of allowing people to get this functionality *without* the ajax module.
OK. I used one window function of cume_dist to do the task now. Please review again.
All of mothur's source should be the project folder.  You can use xcode's smart groups to organize the code.  examples: calculators, chimera, classifier smart groups.
We should add a note in the documentation about this.
wow that would have been an ugly bug. thanks! :D
Seems like these three lines could just be `selector_string = "".join([s.selectorText for s in rule.selectorList])` instead
Just a style nit, but `:build` deps should go at the top of the list.
We can't force CC to `gcc`. Does configure pick the wrong compiler if this isn't done? Does it have problems with clang?
I think this already exists as `Formula.installed`.
Instead of these two lines, do

    if line.chomp! =~ /permission denied/i
Many argue that using exceptions for application flow is a bad thing. But in the case of sabredav and a not-allowed put this is the way to go.

Even better would be to properly implement ACL. This is what we do
```
OC::$WEBROOT = '/alias' . '/dir'
OC::$WEBROOT = '/alias/dir'
```

if no alias, or no subdir
``OC::$WEBROOT = ''``
I removed it because in relative_modified_date in lib/template.php is not used, I think they should use the same format
Right, turns out I probably don't need `delete_tags` happy to remove the whole method and just stick with `purge_pool` instead.
I've never set this up so I can't talk too much to the accuracy, but looks good.
I want to avoid having the documents link directly to each other in case we want to move them. Linking to our own "docs" page does require one extra click for the user, but guarantees flexibility in how we host and organize our docs, and makes sure our users are familiar with what other docs are available.
It should affect Python 2 and Python 3, although the route it takes may be different.
You should start replacing these lists with the set_options(options) method code that I discussed in the Skype chat.
Oetiker, 

The advantage of having exception classes declared centrally is that it's easier to find them all and perhaps thus helps in easy localizations (translations).
Default case mit exception bitte
replaced with appropriate assert*Equals
I can't do it in pre as pre doesn't have the actual input page name.  Does it?
https://github.com/site5/solusvm/issues/28
Ah of course, so you want this in all the methods?
So that the roll_up_interval passes, because I can't pass in timestamps manually with the decorator.
i will fix it
Thanks for reminding me
I actually kind of like that it will serialize a property with private getters and setters. If someone doesn't want it serialized they can always use the DontSerialize attribute.
I can't think of a better way.
Yep - fixed.
We did decide to push command enablement, but I added the isEnabledFn since I thought NJ brought up a case with asynchronous functions where even with pushing the state it's possible that the state may have not changed before the command executes.

isEnabledFn isn't used at all now now however, so I wouldn't mind removing it until we find a case that requires it's usage.

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 2:16 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +
> +    }
> +
> +    /** @return {Command} */
> +    Command.prototype.getID = function () {
> +        return this._id;
> +    };
> +
> +    /**
> +     * Executes the command. Additional arguments are passed to the executing function
> +     *
> +     * @return {$.Promise} a jQuery promise that will be resolved when the command completes.
> +     */
> +    Command.prototype.execute = function () {
> +        if (this._commandFn) {
> +            if (this._isEnabledFn && !this._isEnabledFn()) {

I think the idea with storing _enabled on the command is that we shouldn't need to re-run the function here.  If the command impl is listening for the right change conditions and pushing updates to the enabled state whenever it hears about such changes, I think checking _enabled should be enough here.  And actually, if that's all true I'm not sure Command needs to keep track of _isEnabledFn at all.

Or did we decide to punt on "push" enablement and only check when menus are shown, for now?  (That would have to change if we add toolbars or async native menus, but we don't have either of those yet).

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r878165
It seems like you can remove ``_initStatusBar`` and replace the call on line 192 with ``_onFocusedEditorChange()``.
Use `FS.exists = FS.exists || require("path").exists` here (or use an if statement).
https://github.com/frendo11/PiplMesh/commit/ec73cae43a0998f4e3a9e58a9d21956808b491c6
I did fix everything?
Cleaner like this:

close: function () {}
I don't know what you mean. I actually think this is right.

Can you elaborate?
change comma to semicolon
Instead of talking about `existing accuracy`, reference `__timeAccuracy` explicitly. The way you've labeled this function, it looks like it's an option you can pass in through the signature.
Let's make this a more generic path.
Actually I was thinking of throwing the whole body away. Was thinking what should i do with the <body> content. @nvcVincent I think you can throw the rest of the body content away just like what we discussed earlier.
Thanks! Come to think of it, there is one more issue. The canonical case you wrote down in the example section of the documentation contains a code path where the MULTI/EXEC is not executed, but no error is raised either. Maybe we should call `#unwatch` unconditionally, as long as there is no `ConnectionError`? This would make sure that the example would work even if the user doesn't explicitly calls `#unwatch`. On the other hand, it comes at the cost of an added round-trip even when this is not necessary (when a MULTI/EXEC was executed).
I don't have the diff in front of me at the moment, but if that's your intention it should have exposure in those configs for default values not here. The __opts__ var is doing dependency injection and it only stays clean if those dependencies are consolidated. 

Additionally, the way your are parsing the configuration value is a too fragile to expose to any users. It is very easy to break the parse by providing a value with no '.'  

--
Dan

On Nov 13, 2012, at 7:42, Jack Kuan <notifications@github.com> wrote:

> In salt/renderers/stateconf.py:
> 
> >  }
> >  
> >  
> > +STATE_FUNC = STATE_NAME = ''
> > +
> > +STATE_FUNC = __opts__['stateconf_state_func']
> > +STATE_NAME = STATE_FUNC.split('.')[0]
> it's in opts_ to serve as a doc and provides a default value for the option. The option is there so that users will know and can override it by specifying it in their master/minion config.
> 
> —
> Reply to this email directly or view it on GitHub.
>
'-rdynamic'
How does the '128' come?
This tests fail locally on my machine.
keep the line short
That is not how Rails works, so it would be very unintuitive.
Yes, good idea. A char[3] should do. The zone is actually only a cosmetic field, never used for computations. The offset is the canonical info, but its not enough unfortunately to display the zone.
I picked it out of a hat. I wanted something to limit length. If there was an easier way to pass in options, it'd be nice to have that user definable.
So we are not using those weird encoding methods and we just drop an UUID there if no "source" is provided. I can live with that.
That is interesting.  I do not see the commit that introduced the change; however, the 72749 has is actually a bit old representing:

   commit b74d799cfcdf53f608005528119b149dfee72749
   Author: Eric D Helms <ehelms@redhat.com>
   Date:   Mon Jun 25 12:16:16 2012 -0400

       Automatic commit of package [converge-ui-devel] release [0.7-1].

However, the latest hash on master appears to be:  

   commit f329c0b770aa4e0894140829da1c885c8d5ac2ed
   Merge: fedf3e8 8f7eec1
   Author: Eric D Helms <ericdhelms@gmail.com>
   Date:   Tue Jul 3 12:26:03 2012 -0700

       Merge pull request #31 from knowncitizen/master
    
       Login spinner upon login click.


At first glance, I'd assume it was a result of a merge commit, but I don't see it in the commits.  We'll need to check w/ Mr. Helms.
I would write it like this:
```ruby
%w(True T t true Yes yes y 1).all? { |v| v.to_bool.should be_true }
```
If desired, we could probably drop the redir_path local variable from here and 112 and then use dashboard_index_path directyl in the interstitial.js.haml.
the resource.pm needs to be filtered out here, otherwise it will show up as a resource
Is there a nuget package for this?
It would be nice if this would output something related to the test 'pinch 0' will tell you which pinch test failed but during CI if this fails that's not a lot of info.
I don't see any new commits yet. Looks like you still need to push the changes :)
If abs(wa) is < 1e-5, the user should be using wCDMCosmology, so this check is unnecessary (same applies to w0wzCDM).
Done in 06d746f.
I would recommend putting this sentence in a ``.. warning::`` directive given that it's potentially destructive.
@adrn knows my thoughts on this - keep it as simple as possible. If you find something, great, if not, return `None` or a custom exception. Let's add functionality like specifying a database later when we actually define this properly.

I'm not sure if I'm reading the code correctly (it's broken up so much on this pull request), but if you are, don't return a `urllib2.URLError` exception. Right now, it should just work or not. You can make a custom exception to provide more detail like "no result found" or "server not responding", but `URLError` is an under-the-hood implementation detail that the user shouldn't be catching.
Sort of an in joke. Not the place for it. Have changed as you recommend.
Haraka style prefers commas on the end of lines.
ipcThread and ipcThread2 are never called from outside qtipcserver.cpp. They should be static and local, not exported in the header file.
Nope, EFILT_READ=-1, EFILT_WRITE=-2, EV_ERROR = 0x4000, EV_EOF=0x8000
you dont need to always comment that its fixed. we can all see that :-)
Could you replace the BC methods with assertEquals($expected, $result);
These indent correctly on my machine. I'll check it out.



On Mon, Sep 24, 2012 at 3:19 PM, Katy Huff <notifications@github.com> wrote:

> In src/Models/Facility/BatchReactor/BatchReactor.rng:
>
> > @@ -5,20 +5,19 @@ datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">
> >       <element name="BatchReactor">
> >
> >         <!-- Material In/Out  -->
> > -        <oneOrMore>
> > -          <element name="fuelpair">
> > -            <ref name="incommodity"/>
> > -            <ref name="inrecipe"/>
> > -            <ref name="outcommodity"/>
> > -            <ref name="outrecipe"/>
> > -            </element>
> > -        </oneOrMore>
> > +       <element name="fuel_input">
> > +	 <ref name="incommodity"/>
>
> indentation
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cycamore/pull/69/files#r1677354>.
>
>
I still don't understand why you need to do this - could you provide an example where `normalizePath` doesn't already convert a relative to an absolute path?
My only concern about this type of styling is that if we change our jQuery UI styling, it won't update.  Is is possible to use some of the jquery ui css classes to get some of the basic styling done?
I prefer context manager because it does not contaminate the namespace of the try block.  But anyway, it's done.
default tag was 'v2.0', do we want to change that ? 
`fd` is not very explicit, could you add a description n the docstring below ? 

change `and` to `and/or`?
Wouldn't using an `env` dict as we do on other platforms work more reliably? We should be able to use `subprocess.call` in place of `os.system`.
return the image we're using (if the ids match) or null no?
Ahhh, I forgot to remove the line, I'll do it now. :)
I'd opt for something like this here.

~~~~
if ( is_null($value) or !static::$remember)
~~~~

That follows with the Laravel style a bit more. I'd suggest looking at some other core files and replicating the style that Taylor uses to get this merged in.
This should be a `REBASE_MERGE` status (when a `rebase -m` operation is in progress), different from `MERGE`.
I can never understand if Github is trying to tell me that you added a newline at the end of the file, or removed one. I don't care either way, just confused.
For consistency and to indicate that this should be run in the terminal each of these lines should start with `$ `

```
$ sudo ln -s /usr/lib/`uname -i`-linux-gnu/libfreetype.so /usr/lib/
$ sudo ln -s /usr/lib/`uname -i`-linux-gnu/libjpeg.so /usr/lib/
$ sudo ln -s /usr/lib/`uname -i`-linux-gnu/libz.so /usr/lib/
```
The next line re-raises the exception which will send us email but only when we've done as many retries as we're allowed.
we have an easier way to create a user that we use in tests:

```
from users.tests import user
u = user(save=True)
```
ok, got that figured out.  thanks for the tip!  that's very slick!  :)
As a nit, would you mind putting it back in ?
At least include the `ooid` in the error message.
still using tabs in the params
I've never heard if negative return codes :)
Like in test_threaded_task_manager.py, all of these can be moved to setUp()
Ah, so get_es stashes a copy of the es it generates.
The variable name or visibility must be changed to follow CakePHP coding styles (naming conventions). See http://book.cakephp.org/2.0/en/contributing/cakephp-coding-conventions.html#member-visibility
Please add a comment that this is necessary for interoperability with MongoDB, as that driver returns Cursor instances instead of arrays.
I think for the average user this explanation is perfectly fine, although technically you can circumvent some of these restrictions as you correctly pointed out. Whether that is a good idea is a different topic though...
This call should be on one line.
Right now, this is always 0.

Also, the list of arguments for the constructors is already quite long, so added something that is never used makes little sense to me.
I'll fix it now.
The class that's being test that is, so the assertion you suggested doesn't make sense.
you are doing this inside an "it" method. If I 3 of these failed. Would you get three failures? I believe you would only get the first one that failed, no?
Replace clouds.nil? with Cloudfile.present?
Can't see the typo, can you be more explicit please?
Use the header information to select the appropriate bounds.

`if ( $Frm->hdr( "FILTER" ) eq "850"  ) {`
exceptions should be instantiated.
particilar => particular
It seems like this change will make it no longer work with other `Ember.Enumerables` that don't provide support for `slice` or `reverse`.
This might be better "The source widget (a native toolkit widget) for the drag event."
See? This should be done via `RelatedViewInstance.remove()`
made the lowest per page to 10 instead of 12 since it is a nice round number
I think this should be type="xs:string". Should take advantage of the xsd version bump to fix this
Possibly. But it is a coarse grained solution and the risk is we delay 
every test for the sake of making a handful of badly written tests pass.

What do others think.

Mike

> In qa/tests/src/org/jboss/jbossts/qa/Utils/CrashRecoveryDelays.java:
>
> >      private static void awaitReplayCompletion(int seconds) throws InterruptedException
> >      {
> > -        Thread.sleep(seconds * 1000);
> > +        Thread.sleep(getDelayFactor() * seconds * 1000);
>
> is it worth a search and replace for 
> s/Thread.sleep/org.jboss.narayana.qa.Delays.sleep/g
>
> Then implement the sleep function in Delays to do a 
> Thread.sleep(getDelayFactor()
>
> WDYT?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/jbosstm/narayana/pull/91/files#r1564602>.
>
@shadowhand sorry, I'm not sure I understand you. I am essentially doing that, but once I've checked whether the page has a .md or .markdown extension I still need to strip that extension off the filename before it gets passed to Kohana::find_file (which will add the extension back on again as you can see at #L320).

I figured it was more reliable and quicker to rebuild the filename without extension using the other pathinfo keys. I guess the alternative would be:

```php
$ext = pathinfo($page, PATHINFO_EXTENSION);
if (($ext =='md') OR ($ext == 'markdown'))
{
    $ext ='.'.$ext;
    $len = strlen($ext);
    $page = substr($page, -$len, $len);
}
```

but that seems much less tidy than just adding the plain filename back to the path?

Or I suppose, closer to what I'm doing:

```php
$info = pathinfo($page, PATHINFO_EXTENSION);
if (($ext =='md') OR ($ext == 'markdown'))
{
    $page = pathinfo($page, PATHINFO_DIRNAME).DIRECTORY_SEPARATOR.pathinfo($page, PATHINFO_FILENAME);
}
```

but it seemed more efficient to get all of that at once rather than in three separate calls...
Perhaps "Invalid priority\n"?
ok, I can to talk about it with UX but I want to merge this in order to solve the problem. If they say to me that we should implement the same effect I can change it for using the same effect in both cases, are you ok? thanks Vivien
sure this id is on the section and not on the button?
I'm willing to release this code under whatever license you find convenient (MPL should work, but WTF works for me as well). The above link is correct, but I do not plan to update ogg.js in the future, so, as said in an other comment, you guys are the upstream. It was really a one time effort to parse ogg metadata for gaia, originally.
Is it not enough ?
return 'GMT' + (gmt > 0 ? '+' : '-') + '0' + Math.abs(gmt) + ':00');

Or is there a really good reason to return names only for 2 timezones?
changed to pass the lint
What will happen if screen is enabled when this timer goes off?
`&gt;`
We might want to wait on merging this until we decide what we're doing with the Gmail/Hotmail/Other mail buttons. Andrew and I would like to remove them, since they just seem to confuse everyone about what they really do. However, I'm not averse to making Andrew do this when he changes it.

See https://github.com/mozilla-b2g/gaia/pull/7027 for more details on the change.
Let's prefix all the other functions names with gn_ too.
You should send an empty object into `setCarrierStatus();`, like `setCarrierStatus({});` here, or there will be Javascript Error at line 304
If you always create one it can live statically in `system/index.html`
Ok!! Merge it!
I have an idea because it is not very robust in my honest opicion

Add a attribute to Bookmark constructor, here [1], for example, this.isBookmark = true;

and you can check:

if (app.isBookmark()) { bla bla }

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/bookmark.js#L8
nit: remove this, we try to not pollute too much the debug log
Roger, let's continue in this way and I'll change for the sake of simplicity as soon as possible. ;)
autoseed exposes a cb that appears to be invoked when it's done.  Here there's no deference to that.  Are there possible race conditions by the way this is implemented?
call() was a protected slot so this would only be a problem for derived classes. It was used internally like this:

connect(this, SIGNAL(triggered()), this, SLOT(call()));

and the triggered() signal came from QAction, which also contains trigger(), which emits the signal. I can put all these in MRemoteAction for backwards compatibility reasons but I would be really surprised if anyone actually used them. Deriving from MAction/QAction was a mistake from the very beginning (and was known already when developing libmeegotouch but never fixed).
Alternatively, shouldn't you keep an arr
I'm thinking we leave this as a system gem, but we keep that resource handy.
library is already included with tent-status and makes $.live() that much easier
couldn't we instead do:

val jobList  = args.list("jobs").map { jobname => Job(jobname, argsFor(jobname, args)) }

Then I think you can make jobList immutable and public, and you can also remove the other methods below.  What do you think?
So, I don't think we want an implicit string sitting around (obviously), but we could have something like:

case class YearMonthDayPath(path: String)

and make that implicit.

Or we could, as Sam suggested, just make it a val, which could we could override in a subclass, e.g.:
```scala

class EtsyHourlySource( ).. {
  // In Eastern time, because @avibryant loves time zones.
  override val timePath = "DD/MM/YY"
}
```

Can you sketch out
Just a comment that I've replaced most of my uses of the ternary operator in Ruby with something like this:

    priority = options['priority'] or 'defaultPriority'

This has the benefit of being a bit more direct (some people find the ternary syntax hard to read) and also taking into account the case when `options['priority'] is false.

Just a comment for future patches, this seems fine for this one.
Esta comparación debe ser cambiada, ya que la función __DIR__ fue añadida desde la versión 5.3.0 de PHP, y algunas personas (como yo) tendrán problemas si intentan correr su aplicación en una versión posterior, digamos 5.2.13.

Ver la documentación: http://php.net/manual/es/language.constants.predefined.php
Why all of the repeated if statements here? You are doing the same thing in each case?
Instead of including this everywhere, you're better of using a base template that includes bootstrap and extending that template.
not sure exactly what you have in mind
I'm torn on this. I mean, even my one-liner is borderline-readable.
I know :) But I kept the old name for the interface... taking into account your next comment, I assume this to be ok
It should still work. You just can't reference `this.model` anymore.
pushed to `not-approved`
As I said above, do one more commit to clean up the whole `owner` mess.  This should be `owner = spd;`, or simply get rid of the owner variable.
Can the gallery pass a function that knows how to build a gallery url to the history manager, so it can invoke it on swipe or popState()?
This is tedious tear-down. Just do a `db.drop_all`.
Maybe "Set DOWNLOADBEFORE to 'TRUE'..." will be clearer for user?
What about parsing @gsub up front in 'def register' (called once per filterworker) and making a better config data structure that has the replacement stuff already split out -- then we won't have to regexp it every time through.
It doesn't build the URL but the full file path. 

 plugin_page( 'bug_graph_bystatus.php' )   give "/mantisbt/plugin.php?page=MantisGraph/bug_graph_bystatus.php" ,  PHP doesn't like it to find a file and include it.
Again simple `.filter(isMatchingURL).forEach(..)` is easier to read and maintain + is not moz specific.
@shane-tomlinson I don't think we can have a graceful degradation to secondary once primaries are in place, including BigTent. It would mean that secondaries can always trump primaries for trust, which is the opposite of what we want to do. If Google is down, then you can't auth with your google email. I think that's okay.
typically the convention I've tried to use throughout the source is callbacks always take an `err` param as their first argument.  this breaks that convention.  I do this because that's what node does throughout its api.
@seanmonstar - the hasSignals check above looks like a good way to go.
Seems like the right places to me!
Could we call it 'more' instead of 'continueRead' ? Also please add a blank line before try
Just put in this as deb request (include "/Login_Form/check_login.php")..
remove (include $domain.$path."/Login_Form/check_login.php";)
Should it be part of SurveyManager? Why is it in the model package?
U missed the doc
That would be another way of solving this issue. Is that a reasonable thing? I would be a simple change to the last_updated field being set in the CertificateRevocationList#revoke method.
In-place calculations are subtle. The code has gotta be obvious.
Oh, okay, I didn't know it returned a string. Why not initialize to zero (and set to zero when necessary) and interpret that to mean "time's up"? Then the only error is when the user puts in something like ``__sagecell_interact__="look, i'm a string!"`` since it casts to float properly, it doesn't cause potential errors inside the user namespace, and its value corresponds to its meaning. I guess the biggest reason for initializing it is that it's in the user namespace at some point (and it's reasonable to assume that in some cases the user will manually set it), so it should be there from the beginning, not added ad-hoc.
Re-reading your comments gave me a different interpretation :-) So, the line for this comment wouldn't be changed, but the return value of updater, right? If so, then agreed completely and my points are invalid, as `updater` can still be used as a callback and the default implementation can still return the label.
write a more description content
Well, but you already commented that block. Why comment this imports too?
I agree with that, I was talking about testExcludeConstructor sorry for the confusion


>________________________________
> De: Roman Vidyayev <reply@reply.github.com>
>Para: Maks <github.maks3w@virtualplanets.net> 
>Enviado: Viernes 4 de Mayo de 2012 18:29
>Asunto: Re: [zf2] Refactored Zend\Validator\AbstractDb to compy with the latest Zend\Db changes (#1054)
> 
>> -     * Test when adapter is provided
>> -     *
>> -     * @return void
>> -     */
>> -    public function testAdapterProvidedNoResult()
>> -    {
>> -        //clear the default adapter to ensure provided one is used
>> -        AbstractTable::setDefaultAdapter(null);
>> -        $validator = new RecordExistsValidator('users', 'field1', null, $this->_adapterNoResult);
>> -        $this->assertFalse($validator->isValid('value1'));
>> -    }
>> -
>> -    /**
>> -     * @return ZF-8863
>> -     */
>> -    public function testExcludeConstructor()
>
>the purpose of this test is to reset the default adapter:
>AbstractTable::setDefaultAdapter(null);
>and then set it within the validator, since the getDefaultAdapter function does not exist and the adapter has to be provided in the constructor, this test becomes irrelevant.
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/zendframework/zf2/pull/1054/files#r775186
>
>
>
It is changing - this is the offset of the little box with the arrow in it to the draggable handle - it changes whenever the cursor is moved to a different number, I believe
php 5.4 only :(
Sounds good to me, thanks for the explanation.  I guess this could use some refactoring, I think that if `self.segments = segments` is necessary here it's a sign of bad coding and structuring by me, and after reading the code again I agree with you that a local `segments` variable makes more sense here.
Must we have specific protocols for entities with no metadata? There's really no need. http://wiki.vg/Entities
we can simply remove lineno when its not a valid number (current sentry will handle that case)
spork-rails?
These tests don't really cover all the cases and more importantly miss the important side of the behavior, which is sending the appropriate HTTP status and headers to the client.

`PATH_INFO` is a purely server-side value. We could change it in the `request` object (and we do, I think) but it doesn't mean we've sent a redirect to the client. You can look at [how Kitsune tests this](https://github.com/mozilla/kitsune/blob/master/apps/sumo/tests/test_middleware.py#L10) but even those tests could be better, because we could use the `TestCase.assertRedirects` method.

```python
class TrailingSlashMiddlewareTests(TestCase):
    def test_legitimate_404(self):
        """Don't try to redirect if it's still a 404."""
        r = self.client.get('/en-US/ohnoez/')  # Not a real path.
        eq_(404, r.status_code, '/ohnoez/ should be a 404.')

    def test_strip_trailing_slash(self):
        url = reverse('about')
        r = self.client.get(url + '/')
        self.assertRedirects(r, url, status_code=301)

    def test_no_trailing_slash(self):
        """Don't redirect 404s without a trailing slash."""
        r = self.client.get('/en-US/ohnoez')
        eq_(404, r.status_code, '/ohnoez should be a 404.')
```
Actually, "display_name" is used as a user's full name from what I can tell both on the admin panel as well as in apps/users/models.py. It's guaranteed to have a value based on /register.

Are you thinking of username? That definitely isn't guaranteed to have a value.
Yep, it seemed suspicious that I was getting rid of so much earlier. AND IT WAS!
Good point. I'll remove it from this test so.
Ops. My bad, yeah. Generally, you don't want to see my code comments :D
\o/
A point of contention, I really don't like cramming the entire parameter dictionary into this granule.
adds proper cleanup to the queues.
This is a rather odd sequence of code. Why is `t` being set here? It does not appear to be used anywhere else.
why invent this special thing? looks baroque … and it does not fundamentally improve upon `try … catch … finally`.
Makes sense.  I'll get on this after tutoring today.  And thanks for reviewing! :-)
Note that this change adds Apache Lucene (and its Regex library) as a new "org.apache.lucene" module. Although this module only includes what ModeShape uses, it was separated out because Hibernate Search is dependent upon it and is a separate module.
"We'll be using the `client` argument later on", or something like that
Descriptions are generally texts not strings
I prefer it if _.values(Visibility) would be in the isIn function. It's a bit confusing now to have 2 variables for visibility
I think the actual comment creator and comment body will still return for comments that have been marked as deleted. When a comment has been deleted, only the `deleted: true` should come back, other things should be hidden from the feed.
I can't find any pointers on how to tackle the optional callback parameters, I'd assume they are optional since the callback is optional and not require the `[ ]`
yes please. i guess this could fall under polish next week...
I don't think it's really necessary to add this to the docs. The point of this section was to alert people to breaking changes and new ways of doing things, not merely new features and bugfixes.
CM doesn't autowire up if its a usercontrol.

ie, in this example, listboxs datacontext is never set.
 
```
<ShellView>
   <SettingsView>
      <ListBox x:Name="Blogs" />
   </SettingsView>
<ShellView>
```
Remove all `@access` lines - those are only useful if you define properties with the `var` keyword.

P.S.: *protected* for a *public* property?!
нарушение инкапсуляции, как уже отмечалось - нужно создать свойство, и обращаться к нему. в геттере и сеттере можно провести проверки, дополнительно обработать значения.
Я так и не понял, где используется этот метод.
Почему бы и нет? :)
Чтобы запомнить старое расположение элементов можно создать массив с такими же элементами
NSMutableArray *oldDNA= [NSArray arrayWithArray: self.dna];
Решение не оптимально и запутанно.
Да, должно быть так: rndIndex =  (arc4random() % [mutateIndex count]);
Там алгоритм несколько раз переписывался в короткие сроки, в итоге запутался.
видно, что вы что-то слышали о директивах, но никогда не пользовались ими.

Почитайте про них поподробнее, так, как вы, никто не делает. Обычно объявляют директиву `#define DEBUG` (заметьте, никаких значений нет), а тот код, что должен присутствовать при наличии директивы, обрамляется в конструкцию

`#ifdef ДИРЕКТИВА
// код
#endif`

Да и логика будет другой. В вашем случае программа откомпилируется, грубо говоря, со всеми строками, что там есть. Если обрамлять какой-то код в директиву, то компилятор, при отсутствии такой директивы, будет игнорировать код внутри конструкции (будто он закомментирован).
Ага, теперь вижу, спасибо.
По поводу того, что человек был согласен - как же ж с самим преподавателем не согласится то? (-:
упс... обсуждение длиное, уже забыл, с чего все начиналось, искренне считал, что речь о процентах в mutate: 
в случае инита думаю имеет смысл длину проверять до вызова [super init] и в случае ее некорректной длины возвращать nil - объект не создается, программа не вываливается, все счастливы ))
Может заменить @"A" на @"A" и итоговая мутация заменит не X элеменетов.
that was just a debug print that I forgot to remove.
How do we get this UpgradeCode? Can it be shared for multiple products and/or locales? 

I noticed that you have 1033 for Language in this tag, but further down this line you have 1033 and 1036 in Package tag. So I'm curious how can 1033 also work for French installer?
Ugh, I didn't realize that the DevTools only worked in a WebKit-based browser. I've updated the code to call OpenLiveBrowser() instead of OpenURLInDefaultBrowser().

And yes, this is a temporary fix until this CEF bug is fixed:
http://code.google.com/p/chromiumembedded/issues/detail?id=659&sort=-id
I would prefer all var statements at the top of the function when possible so can you just declare success and error at the top and then assign them values here?
demo.orientation != the data-orientation attribute, we thought it best to use data- attributes to stay out of the way of potential future standard attributes.
So that if the topic is invalid (i.e. has no title), then the user is taken back to the same pre-filled form. With a redirect to new, a new empty topic is created, which means the user has lost all the work done on that form.
like it, updated.
Shouldn't the Choose Shipping Method be the selected option? If not, whats the purpose of having it? Also, if you keep it in, I would suggest adding a disabled prop to so its not selectable.
yeah, we thought LzopInputFormat should put it back CodecPool only it created.
actually it would just fine to always reuse. It will simplify the patch a lot. That way we can add the same for LzopOutputFormat as well.
I will change this to `CanFetchIntoAnEmptyRepository` - (when originally naming this, my thought was "we are executing fetch from (inside of) an empty repository"
You have to cache the reachability flags, but the standard Reachability implementation doesn't do that, unfortunately. You could hack it a bit to have it send a dictionary containing the reachability object and flags in the notification, and then cache the flag values in Zinc somewhere. There's no real clean solution the way it stands now, which is why I rewrote it...

If we keep Zinc from updating while a game is playing, the hiccups might not be too noticeable. Or maybe have it check the WIFI status on a background queue?
Great, thanks heaps for the detailed feedback.


On Thu, Dec 6, 2012 at 6:21 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > +            epochs.events = np.atleast_2d(self.events[key]
> )
> > +
> > +            if self.preload:
> > +                if isinstance(key, slice):
> > +                    epochs._data = self._data[key]
> > +                else:
> > +                    key = np.atleast_1d(key)
> > +                    epochs._data = self._data[key]
> > +        elif key not in self.event_id:
> > +            raise KeyError('Event "%s" is not in Epochs.' % key)
> > +        else:
> > +            epochs.events = self._get_events(key)
> > +            if self.preload:
> > +                epochs._data = epochs._data[epochs.events[:, 0]]
> > +            epochs.name = (key if epochs.name == 'Unknown'
> > +                           else 'epochs_%s' % key)
>
> copying looks good to me now.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337924>.
>
>
thinking about it it seems weird to name it drop and to pass the epochs to keep. How about passing the bad indices?
I think it should be OpenmrsDataDAO<T extends OpenmrsData>.
this is already required in `lib/git_reflow.rb`, so it was throwing an already defined constant warning
I don't know.  I don't know what that bit is referring to in order to explain it better.
You're right, we really want to test `leaf?` except that `MenuItems` isn't actually implementing nested sets properly yet so it doesn't have that. I added the method!

In doing so, I realised we already had `has_children?` so I've refactored that to use `!leaf?`

Thanks!!
please use ``:class:`` here (and link to the interfaces)
这一行没标点，上一行是英文标点。
除此以外，其他都ok。
How about just dropping them altogether?

    Visitor signs up
      with a blank password
      with an invalid email
      with valid data
the `:` at the end causes the issues. Rails mistakes it as part of the has key name
Should use `$input===''` instead of `empty($input)`. The latter will be true if `$input='0'`.
Оно ввод в прочие части личкрафтов не блокирует? Если да, то и ок.
A nitpick, but these abbreviations don't match what we use elsewhere: 
 "subscription" -> "subsin" 
 "activation key" -> "act-key".

I think we use "ak" for activation key.  Or maybe just don't abbreviate at all?
this method is obsolete as `RecordsRequest` does it, please check and remove this)
Remove comma between technologies and exist.
@extend -> @extends
Since "ctx" is only used in test_get_context_as_dict you could just move this code to the top of that method.
And @vblagoje, atomic maps guarantee that all keys under an atomic map entry will be stored in the same node, so you could effectively do the reduce in one of the nodes that owns that entry.
ok.
I can't seem to be able to find the coding guidelines. So I don't have access to those rules.
Yes, you're right. Maybe we leave the upper one for backward compatibility and remove it in alchemy 2.4
I have actually tested that flow and nothing happens, it doesn't connect.
These would be better as `click_delete`, `click_edit` etc as that's the action on the element.
That looks good, too
I would normally agree, but this is a very complex conditional. I wanted to have the `(` on the same column as its corresponding `)` to improve the readability of the conditional.
when doing casts please add a space like
```(CHOGFeatures*) m_features->get_sample(idx);```
Otherwise: great work. This seems so much smoother than the old approach! :)
This log statement will have to be removed.
Good catch, fixed in c4924b9c5b5fd6dfaa122e28a8b78eef7f6ae5fa
This will usually be wasted work: if we're just reading from a table, we don't need to open the index cursors at all.
I would name this class differently.
Maybe `JobCreator`, because it's not really a Job, it can be confusing in this sense.
Is this property going to be deprecated after the migration? If so, add a TODO for that.
No worries - know the feeling! 

But back to original question I guess, what is missing? ;-)
out will be empty string and as such will not log anything - as in parseTests is unnecessary. It s the responsibility of the parser to log error.  i.e. scalatest will log an error message with an instrumentation code of error. We could have something nicer of Stream[(Int, String)].
This uses $this->image directly with Imagick
usually i would do::

(function($, undefined) {
 ...
)(jQuery));
It would be cool if we did a hanging indent. So instead of this:

```
 * Ensured tea wasn't consumed until
cooled
```

How about this:

```
* Ensured tea wasn't consumed until
   cooled
```
What is the best way to remove hard-coded URL here? Constant variable?

Yes, I'm doing GET requests because POST requests doesn't work. CSRF doesn't allow POST requests. I don't know how to fix this.

Spaces fixed.
Hm, return `dict.get(key)`? Maybe just rename `lookup` to `get`? :-)
(There are some double spaces.)
Just have a creation timestamp. You can always calculate the validity based on that, especially if validity length is a settings option, so that even if settings option changes, it will get into the effect for all tokens issued.
Ok. I wanted to use obj_create to send signal to push notification but signal wasn't trigger-ed (you explained why). I forgot to delete this method before commiting.
Please write in all arguments function gets, even if you do not use them, because later on maybe they will be useful, so it is good to remember what is available, because sometimes you do ugly ways to getting some value, forgetting that it is already given as an argument.
Read all comments first. I proposed `get_source_name` method for that.
You can use relative import also for above.
Actually it should be OK now, a couple of days ago I tweaked `brew test` to check if Formula#test returns false
I am aware of the fact that mocks and stubs - and all those other differentiations - are not framework-specific.
But as I said before, I don't really see the point in using these different names depending on the amount of implementation provided.
In complex systems, I very often do interaction-based testing. In such tests, you normally verify expectations *and* return test data from your substitutes (mocks, stubs, ...).

An interaction-based test is also what is happening here.
This decorator exists for only one reason: Putting all parameters into an array and pass it on as one parameter to the decorated method. I think that warrants its own test.
Furthermore, I like my tests to read like specifications - reading the name of the test should convey what is being tested. Using multiple asserts in one test that don't form one logical assert would make the test name even more awkward and would disregard the useful rule to only assert one thing per test.
Please read again this: https://github.com/cypreess/django-getpaid/issues/3


"1) We need to change what backends get_gateway_url() method returns. Now it returns just an str URL. I think it should return a tuple with:
( url, method, post_params_dict) 

so this should be like 
```python
('http://somebroker/newpayment?id=xxx&...', 'GET', { }) 
```
or
```python
('http://somebroker/newpayment', 'POST', {'id' : 'xx', ...} )
```

(method checking should be case insensitive)"
```python
template = self.get_template_name()
```
> in any NoSQL store supported by Infinispan:

and then start the bullet points

> So you can store Lucene indexes in: 

can be removed
No documentation. Why is manual module injection required?
Seriously, I'm in a mad rush.  Sure, I'll send something off later tonight.  What's the preferred way to force a `node.compileClosure` on line 47 in `nodes.coffee`? That's what my ugly `switch` was trying to do.
why do we `print` here?
I can't see that we have such a handler already.
Just copied the old stuff, I'll let the maintainer of the view fix it. :)
I agree with Ben, I think the correctness of memset(&url_, sizeof(url_)) is easier to see as well
It actually shouldn't as this branch doesn't deal with fixing it. This was a fixed bug that crept in somehow from the atmospheric model branch, probably  through git extensions preserving changed files when switching branches:)
I would move that line and everything below it directly under `QSResultController` because it's cleaner : 
- no return in the middle of the method
- no plain ivar access (->)
- it doesn't adds a default key somewhere in some file, but I'm picking nits ;-)

Maybe you could override `-rowModified:` to perform the child list update directly and call that instead of returning above ? I just don't like those -> things ;-).
According to this [note](http://www.w3.org/Protocols/HTTP/NoteMethodCS.html) method names are case sensitive.
These are "internal" classes. The user uses the final subclass and sees the explicit missing keyword.

related but opposite: For the L1 pull request I asked Lian to hide an internal keyword in the **kwds, so the user doesn't see it as part of the fit signature.
"save"? :)
OK.  Feel free to edit the doc string as you think appropriate.  I don't think I know the thrust of the concern here, so I'm not sure what to write.
mention that these come from the example real galaxy training sample with 100 galaxies included in the repo? (i.e., no additional downloads needed)
I assume you are using this to break out of the for loop when you find the key that is supposed to be simulated. Is that right? If so you really should remove this and add a break after the assignment that happens in the next if statement.
I will pull in, but will open bug to support Exams as groupable.
Future enhancement: could return a task id or some such, for getting the result of the invocation later?
Currently, no way to get the result.
Which bit confusing? It needs to be initialized here because otherwise get an NPE in configure(), whereas previously we didn't do any ``leftoverProperties << ...``. The code is now following the same pattern as in Entity/Location - in fact I pretty much copied the code from AbstractLocation.
How is your ide configured?

It replaces tabs by spaced?
If it automatically replaces tabs by spaced, how many spaced do you get?

IntelliJ -> default config -> replace tabs by 4 spaced.

PS: In my ide this code also isn't aligned correctly btw. I guess it was caused by me merging the changes.
We'll need to config it in the future. Why not now?